fe5a66f91c88 ("drm/i915: Read PSR caps/intermediate freqs/etc. only
> once on eDP")
> Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com>
Oops, does smatch catch this? I don't recall seeing the complaint in
recent runs?
Reviewed-by: Chris Wilson <ch...@chris-wi
fe5a66f91c88 ("drm/i915: Read PSR caps/intermediate freqs/etc. only
> once on eDP")
> Signed-off-by: Dan Carpenter
Oops, does smatch catch this? I don't recall seeing the complaint in
recent runs?
Reviewed-by: Chris Wilson
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
just leaves the
complication of whether to use cond_resched_lock() or a lock around
the individual __free_vmap_area().
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
just leaves the
complication of whether to use cond_resched_lock() or a lock around
the individual __free_vmap_area().
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
On Sat, Oct 08, 2016 at 08:43:51PM -0700, Joel Fernandes wrote:
> On Thu, Sep 29, 2016 at 1:18 AM, Chris Wilson <ch...@chris-wilson.co.uk>
> wrote:
> > On Thu, Sep 29, 2016 at 03:34:11PM +0800, Jisheng Zhang wrote:
> >> On Marvell berlin arm64 platforms, I see t
On Sat, Oct 08, 2016 at 08:43:51PM -0700, Joel Fernandes wrote:
> On Thu, Sep 29, 2016 at 1:18 AM, Chris Wilson
> wrote:
> > On Thu, Sep 29, 2016 at 03:34:11PM +0800, Jisheng Zhang wrote:
> >> On Marvell berlin arm64 platforms, I see the preemptoff tracer report
> &
ert all these hardcoded values
> to PLANE_X, and convert "int"s to "enum plane"s everywhere.
Note that this is not PLANE_A, but setting up a shorthand local for
const struct skl_plane_wm *p_wm = crtc_state->wm.skl.optimal.planes;
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
ert all these hardcoded values
> to PLANE_X, and convert "int"s to "enum plane"s everywhere.
Note that this is not PLANE_A, but setting up a shorthand local for
const struct skl_plane_wm *p_wm = crtc_state->wm.skl.optimal.planes;
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
ut pipe CRC code")
> Fixes: 13fa0253d97a ("drm/i915: Use new CRC debugfs API")
Reveiwed-by: Chris Wilson <ch...@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
0253d97a ("drm/i915: Use new CRC debugfs API")
Reveiwed-by: Chris Wilson
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
> + size_t *values_cnt) { return 0; }
> +#endif
Please fix by passing the right pointer to intel_display_crc_init()
instead.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
c_source(struct drm_crtc *crtc, const char *source_name,
> size_t *values_cnt);
> +#else
> +static inline int intel_crtc_set_crc_source(struct drm_crtc *crtc,
> + const char *source_name,
> +
On Thu, Sep 29, 2016 at 04:28:08PM +0800, Jisheng Zhang wrote:
> On Thu, 29 Sep 2016 09:18:18 +0100 Chris Wilson wrote:
>
> > On Thu, Sep 29, 2016 at 03:34:11PM +0800, Jisheng Zhang wrote:
> > > On Marvell berlin arm64 platforms, I see the preemptoff tracer report
> &g
On Thu, Sep 29, 2016 at 04:28:08PM +0800, Jisheng Zhang wrote:
> On Thu, 29 Sep 2016 09:18:18 +0100 Chris Wilson wrote:
>
> > On Thu, Sep 29, 2016 at 03:34:11PM +0800, Jisheng Zhang wrote:
> > > On Marvell berlin arm64 platforms, I see the preemptoff tracer report
> &g
unsigned long *start,
unsigned long *end,
__free_vmap_area(va);
spin_unlock(_area_lock);
}
- spin_unlock(_lock);
}
/*
should now be safe. That should significantly reduce the preempt-disabled
section, I think.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
unsigned long *start,
unsigned long *end,
__free_vmap_area(va);
spin_unlock(_area_lock);
}
- spin_unlock(_lock);
}
/*
should now be safe. That should significantly reduce the preempt-disabled
section, I think.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
ing the call size for DRM_DEBUG is a definite improvement.
Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk>
>
> Miscellanea:
>
> o Convert args... to ##__VA_ARGS__
> o The equivalent DRM_DEV_ macros are rarely used and not
> worth conversion
Today. I woul
ing the call size for DRM_DEBUG is a definite improvement.
Reviewed-by: Chris Wilson
>
> Miscellanea:
>
> o Convert args... to ##__VA_ARGS__
> o The equivalent DRM_DEV_ macros are rarely used and not
> worth conversion
Today. I would rather see us to migrate to DRM_
ngine_cs *engine)
> */
> int intel_engine_init_common(struct intel_engine_cs *engine)
> {
> - int ret;
> -
> - ret = intel_engine_init_breadcrumbs(engine);
> - if (ret)
> - return ret;
> -
> - return 0;
> + return intel_engine_init_breadcrumbs(engine);
These are written like this for consistency and ease of change.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
struct intel_engine_cs *engine)
> {
> - int ret;
> -
> - ret = intel_engine_init_breadcrumbs(engine);
> - if (ret)
> - return ret;
> -
> - return 0;
> + return intel_engine_init_breadcrumbs(engine);
These are written like this for consistency and ease of change.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
lme, kernel log as delme2. Nothing too
> suspicious :-(.
[ 234.547] (EE) intel(0): failed to set mode: Permission denied
upon resume.
There is a VT switch so there should be a DropMaster, SetMaster combo
across resume, but that didn't flag any errors. I couldn't see any sign
of logind (so no revoc
lme, kernel log as delme2. Nothing too
> suspicious :-(.
[ 234.547] (EE) intel(0): failed to set mode: Permission denied
upon resume.
There is a VT switch so there should be a DropMaster, SetMaster combo
across resume, but that didn't flag any errors. I couldn't see any sign
of logind (so no revoc
is the yet unconditional return
> intentional?
The patch is queued up elsewhere. It's part of the selftests.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
is the yet unconditional return
> intentional?
The patch is queued up elsewhere. It's part of the selftests.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
On Wed, Aug 24, 2016 at 01:55:28PM +0200, Linus Walleij wrote:
> On Tue, Aug 23, 2016 at 10:32 PM, Chris Wilson <ch...@chris-wilson.co.uk>
> wrote:
>
> > The io-mapping.h include arose from the need to workaround an arch/um
> > compile failure:
> >
> >d
On Wed, Aug 24, 2016 at 01:55:28PM +0200, Linus Walleij wrote:
> On Tue, Aug 23, 2016 at 10:32 PM, Chris Wilson
> wrote:
>
> > The io-mapping.h include arose from the need to workaround an arch/um
> > compile failure:
> >
> >drivers/gpio/gpio-mpc8
On Wed, Aug 24, 2016 at 12:15:50AM +0300, Leon Romanovsky wrote:
> On Tue, Aug 23, 2016 at 09:16:26PM +0100, Chris Wilson wrote:
> > This file does not use any structs or functions defined by io-mapping.h
> > (nor does it directly use iomap, ioremap, iounamp or friends). Remove it
On Wed, Aug 24, 2016 at 12:15:50AM +0300, Leon Romanovsky wrote:
> On Tue, Aug 23, 2016 at 09:16:26PM +0100, Chris Wilson wrote:
> > This file does not use any structs or functions defined by io-mapping.h
> > (nor does it directly use iomap, ioremap, iounamp or friends). Remove it
: Eli Cohen <e...@mellanox.com>
Date: Sun Jul 7 17:25:49 2013 +0300
mlx5: Add driver for Mellanox Connect-IB adapters
which looks like a copy across from the Mellanox ethernet driver.
Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Eli Cohen <e...@mellanox.com>
Cc
: Eli Cohen
Date: Sun Jul 7 17:25:49 2013 +0300
mlx5: Add driver for Mellanox Connect-IB adapters
which looks like a copy across from the Mellanox ethernet driver.
Signed-off-by: Chris Wilson
Cc: Eli Cohen
Cc: Jack Morgenstein
Cc: Or Gerlitz
Cc: Matan Barak
Cc: Leon Romanovsky
Cc: Doug
ilding under
arch/um). My desire to remove the unneed include to io-mapping is to
simplify verification of changes to io-mapping.h
Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Linus Walleij <linus.wall...@linaro.org>
Cc: Alexandre Courbot <gnu...@gmail.com>
Cc: linux-g..
ilding under
arch/um). My desire to remove the unneed include to io-mapping is to
simplify verification of changes to io-mapping.h
Signed-off-by: Chris Wilson
Cc: Linus Walleij
Cc: Alexandre Courbot
Cc: linux-g...@vger.kernel.org
---
drivers/gpio/gpiolib-of.c | 1 -
1 file changed, 1 deletion(-)
g.h
The original patch is incorrect as io-mapping.h is not the right header
for iounmap() - that is #include (pulling in )
which is (and was) already present.
So the root cause here is arch/um not supplying enough stubs? But in the
meantime, do you mind removing the incorrect include now that
e right header
for iounmap() - that is #include (pulling in )
which is (and was) already present.
So the root cause here is arch/um not supplying enough stubs? But in the
meantime, do you mind removing the incorrect include now that you have a
w/a to keep 0day quiet? :)
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
RROR* pipe A underrun
Other than the annoying underrun, is everything else as expected? i.e.
no connected outputs? Have we lost dvo detection?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
RROR* pipe A underrun
Other than the annoying underrun, is everything else as expected? i.e.
no connected outputs? Have we lost dvo detection?
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
4,6 @@ void intel_dvo_init(struct drm_device *dev)
return;
}
- drm_encoder_cleanup(_encoder->base);
kfree(intel_dvo);
kfree(intel_connector);
}
--
Chris Wilson, Intel Open Source Technology Centre
4,6 @@ void intel_dvo_init(struct drm_device *dev)
return;
}
- drm_encoder_cleanup(_encoder->base);
kfree(intel_dvo);
kfree(intel_connector);
}
--
Chris Wilson, Intel Open Source Technology Centre
igt/prime_vgem
Testcase: igt/gem_concurrent_blit # *vgem*
Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Sumit Semwal <sumit.sem...@linaro.org>
Cc: Daniel Vetter <daniel.vet...@ffwll.ch>
Cc: Eric Anholt <e...@anholt.net>
Cc: linux-me...@vger.kernel.org
Cc: dri-de.
igt/prime_vgem
Testcase: igt/gem_concurrent_blit # *vgem*
Signed-off-by: Chris Wilson
Cc: Sumit Semwal
Cc: Daniel Vetter
Cc: Eric Anholt
Cc: linux-me...@vger.kernel.org
Cc: dri-de...@lists.freedesktop.org
Cc: linaro-mm-...@lists.linaro.org
Cc: linux-kernel@vger.kernel.org
---
drivers/dma-buf/
igt/prime_vgem
Testcase: igt/gem_concurrent_blit # *vgem*
Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Sumit Semwal <sumit.sem...@linaro.org>
Cc: Daniel Vetter <daniel.vet...@ffwll.ch>
Cc: Eric Anholt <e...@anholt.net>
Cc: linux-me...@vger.kernel.org
Cc: dri-de.
igt/prime_vgem
Testcase: igt/gem_concurrent_blit # *vgem*
Signed-off-by: Chris Wilson
Cc: Sumit Semwal
Cc: Daniel Vetter
Cc: Eric Anholt
Cc: linux-me...@vger.kernel.org
Cc: dri-de...@lists.freedesktop.org
Cc: linaro-mm-...@lists.linaro.org
Cc: linux-kernel@vger.kernel.org
---
drivers/dma-buf/
constructs, provided by the
> kernel, to allocate & access the array of pointer to channel buffers.
>
> Cc: Chris Wilson <ch...@chris-wilson.co.uk>
> Cc: Tvrtko Ursulin <tvrtko.ursu...@intel.com>
> Signed-off-by: Akash Goel <akash.g...@intel.com>
This has the
by the
> kernel, to allocate & access the array of pointer to channel buffers.
>
> Cc: Chris Wilson
> Cc: Tvrtko Ursulin
> Signed-off-by: Akash Goel
This has the benefit of being a mechnical change and I could not think
of a better way to express the per-cpu indirection.
r
quot;)
Reported-by: Dave Gordon <david.s.gor...@intel.com>
Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Reviewed-by: Vladimir Davydov <vdavy...@virtuozzo.com>
Cc: Christoph Lameter <c...@linux.com>
Cc: Pekka Enberg <penb...@kernel.org>
Cc: David Rientjes <rien
1e2 [i915]
[ 138.850707] [] SyS_delete_module+0x193/0x1f0
[ 138.850711] [] entry_SYSCALL_64_fastpath+0x1c/0xac
v2: Keep remove_partial() under the lock, just move discard_slab()
outside the lock.
v3: Rename discard list.
Fixes: 52b4b950b507 ("mm: slab: free kmem_cache_node after destroy sysfs file&q
On Tue, Aug 09, 2016 at 06:45:39PM +0300, Vladimir Davydov wrote:
> On Tue, Aug 09, 2016 at 04:27:46PM +0100, Chris Wilson wrote:
> ...
> > diff --git a/mm/slub.c b/mm/slub.c
> > index 825ff45..58f0eb6 100644
> > --- a/mm/slub.c
> > +++ b/mm/slub.c
> &g
On Tue, Aug 09, 2016 at 06:45:39PM +0300, Vladimir Davydov wrote:
> On Tue, Aug 09, 2016 at 04:27:46PM +0100, Chris Wilson wrote:
> ...
> > diff --git a/mm/slub.c b/mm/slub.c
> > index 825ff45..58f0eb6 100644
> > --- a/mm/slub.c
> > +++ b/mm/slub.c
> &g
1e2 [i915]
[ 138.850707] [] SyS_delete_module+0x193/0x1f0
[ 138.850711] [] entry_SYSCALL_64_fastpath+0x1c/0xac
v2: Keep remove_partial() under the lock, just move discard_slab()
outside the lock.
Fixes: 52b4b950b507 ("mm: slab: free kmem_cache_node after destroy sysfs file")
Reported-by: D
1e2 [i915]
[ 138.850707] [] SyS_delete_module+0x193/0x1f0
[ 138.850711] [] entry_SYSCALL_64_fastpath+0x1c/0xac
v2: Keep remove_partial() under the lock, just move discard_slab()
outside the lock.
Fixes: 52b4b950b507 ("mm: slab: free kmem_cache_node after destroy sysfs file")
Reported-by: Dave
1e2 [i915]
[ 138.850707] [] SyS_delete_module+0x193/0x1f0
[ 138.850711] [] entry_SYSCALL_64_fastpath+0x1c/0xac
Fixes: 52b4b950b507 ("mm: slab: free kmem_cache_node after destroy sysfs file")
Reported-by: Dave Gordon <david.s.gor...@intel.com>
Signed-off-by: Chris Wilson <ch...@chr
1e2 [i915]
[ 138.850707] [] SyS_delete_module+0x193/0x1f0
[ 138.850711] [] entry_SYSCALL_64_fastpath+0x1c/0xac
Fixes: 52b4b950b507 ("mm: slab: free kmem_cache_node after destroy sysfs file")
Reported-by: Dave Gordon
Signed-off-by: Chris Wilson
Cc: Christoph Lameter
Cc: Pekka Enberg
Cc: David
IC_LOCKDEP_MAP_INIT("cpu_hotplug.dep_map",
> _hotplug.dep_map),
> #endif
> };
Going by
/*
* Static locks do not have their class-keys yet - for them the key
* is the lock object itself:
*/
if (unlikely(!lock->key))
l
* Static locks do not have their class-keys yet - for them the key
* is the lock object itself:
*/
if (unlikely(!lock->key))
lock->key = (void *)lock;
this is the right choice for .key (as lock here is the dep_map).
Reviewed-by: Chris Wilson
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
_helper]
> [1.356038] [] ? drm_modeset_unlock_all+0x66/0xc0 [drm]
> [1.356038] [] cirrus_fbdev_init+0xa0/0xb0 [cirrus]
> [1.356038] [] cirrus_modeset_init+0x18b/0x1e0 [cirrus]
> [1.356038] [] cirrus_driver_load+0xbc/0x100 [cirrus]
> [1.356038] [] drm_dev_register+0xa9/0xd0 [drm]
_helper]
> [1.356038] [] ? drm_modeset_unlock_all+0x66/0xc0 [drm]
> [1.356038] [] cirrus_fbdev_init+0xa0/0xb0 [cirrus]
> [1.356038] [] cirrus_modeset_init+0x18b/0x1e0 [cirrus]
> [1.356038] [] cirrus_driver_load+0xbc/0x100 [cirrus]
> [1.356038] [] drm_dev_register+0xa9/0xd0 [drm]
atus (as tracked by probe helpers)
> - anything in the edid changes (when setting it
> drm_mode_connector_update_edid_property)
> - other changes (like sink state changes in dpcd or whatever)
>
> That way userspace would be able to reliably spot such changes and do a
> new modeset.
Yes, please. I have had similar wishes for state changes and overall
modeset counters.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
atus (as tracked by probe helpers)
> - anything in the edid changes (when setting it
> drm_mode_connector_update_edid_property)
> - other changes (like sink state changes in dpcd or whatever)
>
> That way userspace would be able to reliably spot such changes and do a
> new modeset.
Yes, please. I have had similar wishes for state changes and overall
modeset counters.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
On Fri, Aug 05, 2016 at 08:28:15AM +0100, Chris Wilson wrote:
> On Thu, Aug 04, 2016 at 11:24:14PM -0300, Gustavo Padovan wrote:
> > From: Gustavo Padovan <gustavo.pado...@collabora.co.uk>
> >
> > Signalling doesn't need to be enabled at sync_file creation, it is onl
On Fri, Aug 05, 2016 at 08:28:15AM +0100, Chris Wilson wrote:
> On Thu, Aug 04, 2016 at 11:24:14PM -0300, Gustavo Padovan wrote:
> > From: Gustavo Padovan
> >
> > Signalling doesn't need to be enabled at sync_file creation, it is only
> > required if userspace waiting
set enabled and protect fence_add_callback()
>
> v4: use user bit from fence flags (comment from Chris Wilson)
>
> Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk>
> ---
> + if (!test_and_set_bit(POLL_ENABLED, _file->fence->flag
k()
>
> v4: use user bit from fence flags (comment from Chris Wilson)
>
> Signed-off-by: Gustavo Padovan
> ---
> + if (!test_and_set_bit(POLL_ENABLED, _file->fence->flags)) {
> + if (fence_add_callback(sync_file->fence, _fil
+from it.
> +
> +Interface:
> + struct fence *sync_file_get_fence(int fd);
> +
> +
> +The function return a struct fence pointer referencing the fence(s) in the
> Sync
> +File.
+ The returned reference is owned by the caller and must be disposed of
afterwards using fenc
unction return a struct fence pointer referencing the fence(s) in the
> Sync
> +File.
+ The returned reference is owned by the caller and must be disposed of
afterwards using fence_put(). In case of error, a NULL is returned
instead.
Reviewed-by: Chris Wilson
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
On Thu, Aug 04, 2016 at 06:18:53PM -0300, Gustavo Padovan wrote:
> 2016-08-03 Chris Wilson <ch...@chris-wilson.co.uk>:
>
> > On Tue, Jul 12, 2016 at 03:08:45PM -0300, Gustavo Padovan wrote:
> > > From: Gustavo Padovan <gustavo.pado...@collabora.co.uk>
>
On Thu, Aug 04, 2016 at 06:18:53PM -0300, Gustavo Padovan wrote:
> 2016-08-03 Chris Wilson :
>
> > On Tue, Jul 12, 2016 at 03:08:45PM -0300, Gustavo Padovan wrote:
> > > From: Gustavo Padovan
> > >
> > > Signalling doesn't need to be enabled at sync_f
if (!test_and_set_bit(POLL_ENABLED, _file->fence->flags)) {
if (fence_add_callback(sync_file->fence, _file->cb,
fence_check_cb_func) < 0)
wake_up_all(_file->wq);
}
Saves adding a raw atomic.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
ce->flags)) {
if (fence_add_callback(sync_file->fence, _file->cb,
fence_check_cb_func) < 0)
wake_up_all(_file->wq);
}
Saves adding a raw atomic.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
generate smaller code.
Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: "Paul E. McKenney" <paul...@linux.vnet.ibm.com>
Cc: Andrew Morton <a...@linux-foundation.org>
Cc: Dan Williams <dan.j.willi...@intel.com>
Cc: Jan Kara <j...@suse.cz>
Cc: Jose
generate smaller code.
Signed-off-by: Chris Wilson
Cc: "Paul E. McKenney"
Cc: Andrew Morton
Cc: Dan Williams
Cc: Jan Kara
Cc: Josef Bacik
Cc: linux-kernel@vger.kernel.org
---
include/linux/list.h | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/include/linu
static?
>
> Signed-off-by: Wei Yongjun <yongjun_...@trendmicro.com.cn>
Thanks,
Reviewed-by: Chris Wilson <ch...@chris-wilson.co.uk>
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
ngjun
Thanks,
Reviewed-by: Chris Wilson
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
nder pressure.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
nder pressure.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
provides a building
block which can be used for determining an order in which tasks can
execute.
Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Sumit Semwal <sumit.sem...@linaro.org>
Cc: Shuah Khan <shua...@osg.samsung.com>
Cc: Tejun Heo <t...@kernel.org>
Cc: D
provides a building
block which can be used for determining an order in which tasks can
execute.
Signed-off-by: Chris Wilson
Cc: Sumit Semwal
Cc: Shuah Khan
Cc: Tejun Heo
Cc: Daniel Vetter
Cc: Andrew Morton
Cc: Ingo Molnar
Cc: Kees Cook
Cc: Thomas Gleixner
Cc: "Paul E. McKenney"
. not be scheduled) until all work queued before the
barrier is completed.
Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Sumit Semwal <sumit.sem...@linaro.org>
Cc: Shuah Khan <shua...@osg.samsung.com>
Cc: Tejun Heo <t...@kernel.org>
Cc: Daniel Vetter <daniel.
. not be scheduled) until all work queued before the
barrier is completed.
Signed-off-by: Chris Wilson
Cc: Sumit Semwal
Cc: Shuah Khan
Cc: Tejun Heo
Cc: Daniel Vetter
Cc: Andrew Morton
Cc: Ingo Molnar
Cc: Kees Cook
Cc: Thomas Gleixner
Cc: "Paul E. McKenney"
Cc: Dan Williams
scheme based upon
kfences and back every task with one. Any task may now wait upon the
kfence before being scheduled, and equally the kfence may be used to
wait on the task itself (rather than waiting on the cookie for all
previous tasks to be completed).
Signed-off-by: Chris Wilson <ch...@ch
,
and async_dependency_get() retrieves a kfence for inspection or waiting
upon.
Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
Cc: Sumit Semwal <sumit.sem...@linaro.org>
Cc: Shuah Khan <shua...@osg.samsung.com>
Cc: Tejun Heo <t...@kernel.org>
Cc: Daniel Vetter <daniel.vet...@
A preparatory patch for adding new features (and their tests). First we
want to add coverage of existing features to kselftest.
Signed-off-by: Chris Wilson <ch...@chris-wilson.co.uk>
---
lib/Kconfig.debug | 9 ++
lib/Makefile
dma-buf provides an interfaces for receiving notifications from DMA
hardware, and for implicitly tracking fences used for rendering into
dma-buf. We want to be able to use these event sources along with kfence
for easy collection and combining with other events.
Signed-off-by: Chris Wilson <
A preparatory patch for adding new features (and their tests). First we
want to add coverage of existing features to kselftest.
Signed-off-by: Chris Wilson
---
lib/Kconfig.debug | 9 ++
lib/Makefile| 1 +
lib/test-async-domain.c
dma-buf provides an interfaces for receiving notifications from DMA
hardware, and for implicitly tracking fences used for rendering into
dma-buf. We want to be able to use these event sources along with kfence
for easy collection and combining with other events.
Signed-off-by: Chris Wilson
Cc
scheme based upon
kfences and back every task with one. Any task may now wait upon the
kfence before being scheduled, and equally the kfence may be used to
wait on the task itself (rather than waiting on the cookie for all
previous tasks to be completed).
Signed-off-by: Chris Wilson
Cc: Sumit Semwal
,
and async_dependency_get() retrieves a kfence for inspection or waiting
upon.
Signed-off-by: Chris Wilson
Cc: Sumit Semwal
Cc: Shuah Khan
Cc: Tejun Heo
Cc: Daniel Vetter
Cc: Andrew Morton
Cc: Ingo Molnar
Cc: Kees Cook
Cc: Thomas Gleixner
Cc: "Paul E. McKenney"
Cc: Dan Williams
Cc: Andrey Ry
A common requirement when scheduling a task is that it should be not be
begun until a certain point in time is passed (e.g.
queue_delayed_work()). kfence_await_hrtimer() causes the kfence to
asynchronously wait until after the appropriate time before being woken.
Signed-off-by: Chris Wilson <
Peter Zijlstra gave a lot of feedback and thanks to him, I think both
the function names and docs are a lot more sane. There is also a good
consensus on renaming dma-buf's struct fence to be struct dma_fence,
allowing for use of the cleaner name for the core struct.
A quick overview of a fence is
A common requirement when scheduling a task is that it should be not be
begun until a certain point in time is passed (e.g.
queue_delayed_work()). kfence_await_hrtimer() causes the kfence to
asynchronously wait until after the appropriate time before being woken.
Signed-off-by: Chris Wilson
Cc
Peter Zijlstra gave a lot of feedback and thanks to him, I think both
the function names and docs are a lot more sane. There is also a good
consensus on renaming dma-buf's struct fence to be struct dma_fence,
allowing for use of the cleaner name for the core struct.
A quick overview of a fence is
On Wed, Jul 13, 2016 at 11:38:52AM +0200, Peter Zijlstra wrote:
> On Fri, Jun 24, 2016 at 10:08:46AM +0100, Chris Wilson wrote:
> > diff --git a/kernel/async.c b/kernel/async.c
> > index d2edd6efec56..d0bcb7cc4884 100644
> > --- a/kernel/async.c
> > +++ b/kernel
On Wed, Jul 13, 2016 at 11:38:52AM +0200, Peter Zijlstra wrote:
> On Fri, Jun 24, 2016 at 10:08:46AM +0100, Chris Wilson wrote:
> > diff --git a/kernel/async.c b/kernel/async.c
> > index d2edd6efec56..d0bcb7cc4884 100644
> > --- a/kernel/async.c
> > +++ b/kernel
e it accessible to
> modules like i915 ?
Yes, we need the companion function in i915.ko. That needs to be
explained in the patch notes to justify adding the EXPORT_SYMBOL.
Otherwise without that context, it looks unnecessary as Andrew objected
to.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
e it accessible to
> modules like i915 ?
Yes, we need the companion function in i915.ko. That needs to be
explained in the patch notes to justify adding the EXPORT_SYMBOL.
Otherwise without that context, it looks unnecessary as Andrew objected
to.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
entry
+ * is available.
*/
int relay_late_setup_files(struct rchan *chan,
const char *base_filename,
with a comment in the changelog that modules using relay_open() in early
init also want to later register their buffer-only relays once debugfs is
available, e.g. i915.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
rchan *chan,
const char *base_filename,
with a comment in the changelog that modules using relay_open() in early
init also want to later register their buffer-only relays once debugfs is
available, e.g. i915.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
userspace, which enables them to capture data/logs from relay file in order &
> without any post processing, support of Global buffer mode is warranted.
>
> Cc: Eduard - Gabriel Munteanu <eduard.munte...@linux360.ro>
> Cc: Tom Zanussi <tzanu...@gmail.com>
> Cc: Chris W
to capture data/logs from relay file in order &
> without any post processing, support of Global buffer mode is warranted.
>
> Cc: Eduard - Gabriel Munteanu
> Cc: Tom Zanussi
> Cc: Chris Wilson
> Signed-off-by: Akash Goel
> ---
> kernel/relay.c | 32 +++
le;
> + struct fence *fence;
> +
> + sync_file = sync_file_fdget(fd);
> + if (!sync_file)
> + return NULL;
> +
> + fence = sync_file->fence;
> + fence_get(fence);
Or just fence = get_fence(sync_file->fence);
> + fput(sync_file->fil
_fdget(fd);
> + if (!sync_file)
> + return NULL;
> +
> + fence = sync_file->fence;
> + fence_get(fence);
Or just fence = get_fence(sync_file->fence);
> + fput(sync_file->file);
Reviewed-by: Chris Wilson
Using fence-array for this works very nicely, as we can then inspect the
fences returned and handle native fences for fd passed around.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
701 - 800 of 1356 matches
Mail list logo
