viewed-by: William Kucharski
Looks good,
Reviewed-by: Christoph Hellwig
On Thu, Nov 12, 2020 at 09:26:33PM +, Matthew Wilcox (Oracle) wrote:
> Enhance mapping_seek_hole_data() to handle partially uptodate pages and
> convert the iomap seek code to call it.
Maybe split this into two patches for the mapping_seek_hole_data
enhancement (which could use a little more
to run
> through all the pages quickly, and splitting a page can sleep.
>
> Signed-off-by: Matthew Wilcox (Oracle)
> Reviewed-by: Jan Kara
> Reviewed-by: William Kucharski
Looks good,
Reviewed-by: Christoph Hellwig
On Thu, Nov 12, 2020 at 09:26:32PM +, Matthew Wilcox (Oracle) wrote:
> Rewrite shmem_seek_hole_data() and move it to filemap.c.
>
> Signed-off-by: Matthew Wilcox (Oracle)
> Reviewed-by: William Kucharski
Looks good:
Reviewed-by: Christoph Hellwig
On Thu, Nov 12, 2020 at 09:26:30PM +, Matthew Wilcox (Oracle) wrote:
> find_get_entry doesn't "find" anything. It returns the entry at
> a particular index.
>
> Signed-off-by: Matthew Wilcox (Oracle)
Looks good,
Reviewed-by: Christoph Hellwig
try() static.
I think this should mention that find_get_entry is now only used by
pagecache_get_page. That answers the obvious questions of why we could
not switch all callers of find_get_entry to pagecache_get_page.
Otherwise looks good:
Reviewed-by: Christoph Hellwig
PRESENT
case as well?
Otherwise looks good:
Reviewed-by: Christoph Hellwig
use huge
> pages today are in-memory, so there are no tagged huge pages today.
>
> Signed-off-by: Matthew Wilcox (Oracle)
> Reviewed-by: Jan Kara
> Reviewed-by: William Kucharski
Looks good,
Reviewed-by: Christoph Hellwig
On Thu, Nov 12, 2020 at 09:26:28PM +, Matthew Wilcox (Oracle) wrote:
> There's no need to get a reference to the page, just load the entry and
> see if it's a shadow entry.
>
> Signed-off-by: Matthew Wilcox (Oracle)
Looks good,
Reviewed-by: Christoph Hellwig
ec_lookup()
> is a simpler function to use than find_get_pages(), so use it instead.
>
> Signed-off-by: Matthew Wilcox (Oracle)
> Reviewed-by: Jan Kara
> Reviewed-by: William Kucharski
Looks good,
Reviewed-by: Christoph Hellwig
So despite a week long wait I'e only received this patch from the
series. Please resend the whole series if you want a review.
Thanks,
applied.
Thanks,
applied both patches to nvme-5.11.
On Fri, Nov 13, 2020 at 02:15:59PM +0100, Niklas Schnelle wrote:
>
>
> On 11/12/20 6:36 PM, Keith Busch wrote:
> > On Thu, Nov 12, 2020 at 04:45:35PM +0100, Niklas Schnelle wrote:
> >> You got to get something wrong, I hope in this case it's just the subject
> >> of the cover letter :D
> >
> >
On Fri, Oct 23, 2020 at 02:12:19PM +0200, Ulf Hansson wrote:
> SD spec mentions the write-protect switch on SD cards, while uSD cards
> doesn't have one. In general, host drivers implement support for it
> via a dedicated GPIO line routed to one of the pins in the SD slot.
>
> In this SD
On Wed, Nov 11, 2020 at 07:04:37PM -0600, Tyrel Datwyler wrote:
> Both ibmvfc_show_host_(capabilities|npiv_version) functions retrieve
> values from vhost->login_buf.resp buffer. This is the MAD response
> buffer from the VIOS and as such any multi-byte non-string values are in
> big endian
On Sun, Nov 08, 2020 at 07:36:34PM +, David Woodhouse wrote:
> So it does look like we're going to need a hypercall interface to
> compose an MSI message on behalf of the guest, for IMS to use. In fact
> PCI devices assigned to a guest could use that too, and then we'd only
> need to
On Wed, Nov 11, 2020 at 09:26:20AM +0100, Christian Borntraeger wrote:
>
> On 11.11.20 09:18, Christoph Hellwig wrote:
> > On Tue, Nov 10, 2020 at 06:21:22PM -0800, Nick Desaulniers wrote:
> >> Sorry, I think this patch may be causing a regression for us for s390?
>
On Tue, Nov 10, 2020 at 06:21:22PM -0800, Nick Desaulniers wrote:
> Sorry, I think this patch may be causing a regression for us for s390?
> https://travis-ci.com/github/ClangBuiltLinux/continuous-integration/jobs/432129279#L768
>
> (via
Jens, can you take a look and possibly pick this series up?
On Thu, Oct 29, 2020 at 03:58:23PM +0100, Christoph Hellwig wrote:
> Hi all,
>
> this series removes the annoying struct block_device aliases, which can
> happen for a bunch of old floppy drivers (and z2ram). In that cas
On Tue, Nov 10, 2020 at 11:20:28PM +, Al Viro wrote:
> On Tue, Nov 10, 2020 at 09:35:11PM +, Al Viro wrote:
> > On Tue, Nov 10, 2020 at 09:32:53PM +, Al Viro wrote:
> >
> > > AFAICS, not all callers want that semantics, but I think it's worth
> > > a new primitive. I'm not saying it
On Tue, Nov 10, 2020 at 09:43:50PM -0800, Ben Widawsky wrote:
> +config CXL_MEM
> +tristate "CXL.mem Device Support"
> +depends on PCI && CXL_BUS_PROVIDER != n
depend on PCI && CXL_BUS_PROVIDER
> +default m if CXL_BUS_PROVIDER
Please don't set weird defaults for new
On Tue, Nov 10, 2020 at 09:43:48PM -0800, Ben Widawsky wrote:
> +menuconfig CXL_BUS
> + tristate "CXL (Compute Express Link) Devices Support"
> + help
> + CXL is a bus that is electrically compatible with PCI-E, but layers
> + three protocols on that signalling (CXL.io,
On Mon, Nov 09, 2020 at 02:01:41PM -0500, Chris Mason wrote:
> You do consistently ask for a shim layer, but you haven???t explained what
> we gain by diverging from the documented and tested API of the upstream zstd
> project. It???s an important discussion given that we hope to regularly
>
On Mon, Nov 09, 2020 at 08:10:08PM +0100, Michal Suchanek wrote:
> xfs accepts both dax and dax_enum but shows only dax_enum. Show both
> options.
Which is very much intentional. The -o dax was an experimental hack
that fortunately is gone now.
s/moount/mount/
On Thu, Oct 29, 2020 at 11:14:30AM +0100, Christoph Hellwig wrote:
> Hi Andrew,
>
> this small series drops the not needed follow_pte_pmd exports, and
> simplifies the follow_pte family of functions a bit.
any comments?
On Mon, Nov 09, 2020 at 11:32:09AM +, David Brazdil wrote:
> As we progress towards being able to keep guest state private to the
> host running nVHE hypervisor, this series allows the hypervisor to
> install itself on newly booted CPUs before the host is allowed to run
> on them.
Why? I
On Tue, Nov 10, 2020 at 06:50:32PM +0900, Tomasz Figa wrote:
> In what terms it doesn't actually work? Last time I checked some
> platforms actually defined CONFIG_DMA_NONCOHERENT, so those would
> instead use the kmalloc() + dma_map() path. I don't have any
> background on why that was added and
On Tue, Nov 10, 2020 at 10:33:05AM +0100, Ricardo Ribalda wrote:
> Also FYI, I managed to boot an ARM device with that tree. But I could
> not test the uvc driver (it was a remote device with no usb device
> attached)
>
> Hopefully I will be able to test it for real this week.
>
> Any
On Mon, Nov 09, 2020 at 03:53:55PM +0100, Ricardo Ribalda wrote:
> Hi Christoph
>
> I have started now to give a try to your patchset. Sorry for the delay.
>
> For uvc I have prepared this patch:
> https://github.com/ribalda/linux/commit/9094fe223fe38f8c8ff21366d893b43cbbdf0113
>
> I have
Should not be needed in stable in any form.
On Mon, Nov 09, 2020 at 10:43:03AM +0100, Maxime Ripard wrote:
> Hi Christoph, Chen-Yu, Hans,
>
> On Fri, Nov 06, 2020 at 05:07:37PM +0100, Christoph Hellwig wrote:
> > Thanks,
> >
> > this looks good to me:
> >
> > Reviewed-by: Christoph Hellwig
> &g
On Fri, Nov 06, 2020 at 01:26:50PM -0800, Ralph Campbell wrote:
>
> On 11/6/20 12:03 AM, Christoph Hellwig wrote:
>> I hate the extra pin count magic here. IMHO we really need to finish
>> off the series to get rid of the extra references on the ZONE_DEVICE
>> pages
On Fri, Nov 06, 2020 at 10:00:25AM -0700, Logan Gunthorpe wrote:
> We make use of the top bit of the dma_length to indicate a P2PDMA
> segment.
I don't think "we" can. There is nothing limiting the size of a SGL
segment.
On Fri, Nov 06, 2020 at 10:00:22AM -0700, Logan Gunthorpe wrote:
> In order to call this function from a dma_map function, it must not sleep.
> The only reason it does sleep so to allocate the seqbuf to print
> which devices are within the ACS path.
>
> Switch the kmalloc call to use GFP_NOWAIT
On Fri, Nov 06, 2020 at 03:37:44PM +, Sudip Mukherjee wrote:
> When CONFIG_MXC_CLK_SCU is configured as 'm' the build fails as it
> is unable to find device_is_bound(). The error being:
> ERROR: modpost: "device_is_bound" [drivers/clk/imx/clk-imx-scu.ko]
> undefined!
>
> Export the
You just keep resedning this crap, don't you? Haven't you been told
multiple times to provide a proper kernel API by now?
On Mon, Nov 02, 2020 at 10:05:27PM -0800, Nick Terrell wrote:
> From: Nick Terrell
>
> Adds zstd_compat.h which provides the necessary functions from the
> current zstd.h
On Thu, Nov 05, 2020 at 02:06:49PM -0500, Konrad Rzeszutek Wilk wrote:
> .
> > > Right, so I am wondering if we can do this better.
> > >
> > > That is you are never going to get any 32-bit devices with SEV right? That
> > > is there is nothing that bounds you to always use the memory below 4GB?
Thanks,
this looks good to me:
Reviewed-by: Christoph Hellwig
Can you include this patch at the end of your series to that it gets
picked up with the other patches?
---
>From 5963f88d365367fe74d477b8420d34562d684406 Mon Sep 17 00:00:00 2001
From: Christoph Hellwig
Date: Fri, 6 Nov 2020 17
Thanks,
applied to nvme-5.11
I hate the extra pin count magic here. IMHO we really need to finish
off the series to get rid of the extra references on the ZONE_DEVICE
pages first.
> +#ifdef CONFIG_TRANSPARENT_HUGEPAGE
> +extern struct page *alloc_transhugepage(struct vm_area_struct *vma,
> + unsigned long addr);
No need for the extern. And also here: do we actually need the stub,
or can the caller make sure (using IS_ENABLED and
Looks good:
Reviewed-by: Christoph Hellwig
On Thu, Nov 05, 2020 at 04:51:42PM -0800, Ralph Campbell wrote:
> +extern void prep_transhuge_device_private_page(struct page *page);
No need for the extern.
> +static inline void prep_transhuge_device_private_page(struct page *page)
> +{
> +}
Is the code to call this even reachable if THP
On Thu, Nov 05, 2020 at 04:51:43PM -0800, Ralph Campbell wrote:
> Move the definition of migrate_vma_collect_skip() to make it callable
> by migrate_vma_collect_hole(). This helps make the next patch easier
> to read.
>
> Signed-off-by: Ralph Campbell
Looks good,
Reviewed-by: Christoph Hellwig
On Wed, Nov 04, 2020 at 03:02:14PM -0400, Jason Gunthorpe wrote:
> I saw that once and I really couldn't make sense of it..
> What use is having futex's that only work on THP pages? Confused
>
> CH said there was no case of HAVE_FAST_GUP !ARCH_HAS_PTE_SPECIAL, is
> one hidden someplace then?
On Wed, Nov 04, 2020 at 04:37:58PM +, Christoph Hellwig wrote:
> On Wed, Nov 04, 2020 at 05:26:58PM +0100, Daniel Vetter wrote:
> > What we're discussing is whether gup_fast and pup_fast also obey this,
> > or fall over and can give you the struct page that's backing the
> &
On Wed, Nov 04, 2020 at 05:26:58PM +0100, Daniel Vetter wrote:
> What we're discussing is whether gup_fast and pup_fast also obey this,
> or fall over and can give you the struct page that's backing the
> dma_mmap_* memory. Since the _fast variant doesn't check for
> vma->vm_flags, and afaict
On Wed, Nov 04, 2020 at 04:54:19PM +0100, Daniel Vetter wrote:
> I don't really have a box here, but dma_mmap_attrs() and friends to
> mmap dma_alloc_coherent memory is set up as VM_IO | VM_PFNMAP (it's
> actually enforced since underneath it uses remap_pfn_range), and
> usually (except if it's
On Wed, Nov 04, 2020 at 10:15:49AM +, Robin Murphy wrote:
> How about having something in the platform code that keys off the top-level
> SoC compatible and uses a bus notifier to create offsets for the relevant
> devices if an MBUS description is missing? At least that way the workaround
>
Implement ->read_iter for all proc "seq files" so that splice works on
them.
Suggested-by: Linus Torvalds
Signed-off-by: Christoph Hellwig
---
fs/proc/generic.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/proc/generic.c b/fs/proc/generic.c
index f
From: Greg Kroah-Hartman
Implement ->read_iter for all proc "single files" so that more bionic
tests cases can pass when they call splice() on other fun files like
/proc/version
Signed-off-by: Greg Kroah-Hartman
Signed-off-by: Christoph Hellwig
---
fs/proc/generic.c | 2 +-
1 fi
Implement ->read_iter so that splice can be used on this file.
Suggested-by: Linus Torvalds
Signed-off-by: Christoph Hellwig
---
fs/proc/stat.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/proc/stat.c b/fs/proc/stat.c
index 46b3293015fe61..4695b6de315129 100
Implement ->read_iter so that the Android bionic test suite can use
this random proc file for its splice test case.
Signed-off-by: Christoph Hellwig
---
fs/proc/cpuinfo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/proc/cpuinfo.c b/fs/proc/cpuinfo.c
in
Wire up generic_file_splice_read for the iter based proxy ops, so
that splice reads from them work.
Signed-off-by: Christoph Hellwig
Tested-by: Greg Kroah-Hartman
---
fs/proc/inode.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/proc/inode.c b/fs/proc/inode.c
index 58c075e2a452d6
iov_iter based variant for reading a seq_file. seq_read is
reimplemented on top of the iter variant.
Signed-off-by: Christoph Hellwig
Tested-by: Greg Kroah-Hartman
---
fs/seq_file.c| 45
include/linux/seq_file.h | 1 +
2 files changed, 33
Hi Al,
Greg reported a problem due to the fact that Android tests use procfs
files to test splice, which stopped working with 5.10-rc1. This series
adds read_iter support for seq_file, and uses those for various seq_files
in procfs to restore splice read support.
Chances since v1:
- only
On Tue, Nov 03, 2020 at 10:57:10AM -0800, Linus Torvalds wrote:
> On Tue, Nov 3, 2020 at 10:48 AM Christoph Hellwig wrote:
> >
> > ping?
>
> It looked fine by me, although honestly, I'd prefer that last patch to
> be the minimum possible if we want this for 5.1
On Mon, Nov 02, 2020 at 10:06:49PM +, Paul Cercueil wrote:
> This function can be used by drivers that need to mmap dumb buffers
> created with non-coherent backing memory.
>
> Signed-off-by: Paul Cercueil
> ---
> drivers/gpu/drm/drm_gem_cma_helper.c | 39
>
ping?
On Thu, Oct 29, 2020 at 11:09:47AM +0100, Christoph Hellwig wrote:
> Hi Al,
>
> Greg reported a problem due to the fact that Android tests use procfs
> files to test splice, which stopped working with 5.10-rc1. This series
> adds read_iter support for seq_file, and uses tho
Hi all,
Linux 5.10-rc1 switched from having a single dma offset in struct device
to a set of DMA ranges, and introduced a new helper to set them,
dma_direct_set_offset.
This in fact surfaced that a bunch of drivers that violate our layering
and set the offset from drivers, which meant we had to
On Tue, Nov 03, 2020 at 02:21:16AM +, Gloria Tsai wrote:
> When host issue shutdown + D3hot in suspend, NVMe drive might have
> chance choosing wrong pointer which has already been used by GC then
> cause over program.
> Do GC before shutdown -> delete IO Q -> shutdown from host -> breakup GC
it.
>
> Cc: # v2.6.15+
> Fixes: c4a3e0a529ab ("[SCSI] MegaRAID SAS RAID: new driver")
> Reviewed-by: Christoph Hellwig
> Signed-off-by: Arnd Bergmann
> ---
> drivers/scsi/megaraid/megaraid_sas_base.c | 15 ++-
> 1 file changed, 10 in
Looks good,
Reviewed-by: Christoph Hellwig
On Sat, Oct 31, 2020 at 11:05:45AM +0100, David Hildenbrand wrote:
> On 31.10.20 10:18, Christoph Hellwig wrote:
> > On Fri, Oct 30, 2020 at 10:38:42AM +0200, Mike Rapoport wrote:
> > > What do you mean by "system memory block"? There could be a lot of
>
On Mon, Nov 02, 2020 at 01:31:51PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann
>
> These are all handled correctly when calling the native
> system call entry point, so remove the special cases.
Ok, this is where you do it. I think this belongs into the main
patches.
> #ifdef CONFIG_COMPAT
> COMPAT_SYSCALL_DEFINE6(move_pages, pid_t, pid, compat_ulong_t, nr_pages,
> +compat_uptr_t __user *, pages,
> const int __user *, nodes,
> int __user *, status,
> int, flags)
> {
> +
> + for (i=0; i < nr_segments; i++) {
Missing spaces around the "=".
> +SYSCALL_DEFINE4(kexec_load, unsigned long, entry, unsigned long, nr_segments,
> + struct kexec_segment __user *, segments, unsigned long, flags)
> +{
> + return kernel_kexec_load(entry, nr_segments,
On Thu, Oct 29, 2020 at 03:55:29PM +0100, Christoph Hellwig wrote:
> I'm still worried about this.
>
> If power state based suspend does always work despite a HMB and is
> preferred for the specific Google board we should have purely a DMI
> based quirk for the board independ
On Mon, Nov 02, 2020 at 10:55:33AM +0100, Sebastian Andrzej Siewior wrote:
> On 2020-10-31 09:00:49 [-0600], Jens Axboe wrote:
> > There really aren't any rules for this, and it's perfectly legit to
> > complete from process context. Maybe you're a kthread driven driver and
> > that's how you
On Mon, Nov 02, 2020 at 07:44:21PM +0800, Baolin Wang wrote:
> Hi,
>
>> Use the request's '->mq_hctx->queue_num' directly to simplify the
>> nvme_req_qid() function.
>>
>> Signed-off-by: Baolin Wang
>
> Gentle ping?
As this clearly isn't 5.10 material it will have to wait for the 5.11
branch
On Mon, Nov 02, 2020 at 11:52:56AM -0400, Jason Gunthorpe wrote:
> Need to hold the lock to check that and there are two ways to register
> notifiers these days, so it feels to expensive to me.
>
> CH's 'export symbol only for kvm' really does seem the most robust way
> to handle this though.
I
On Mon, Nov 02, 2020 at 10:28:34AM +0100, Daniel Vetter wrote:
> > --- a/include/linux/swiotlb.h
> > +++ b/include/linux/swiotlb.h
> > @@ -5,6 +5,9 @@
> > #include
> > #include
> > #include
> > +#ifndef CONFIG_SWIOTLB
> > +#include
> > +#endif
No conditional includes please. And the
On Fri, Oct 30, 2020 at 11:08:08AM +0100, Daniel Vetter wrote:
> Also mark up follow_pfn as EXPORT_SYMBOL_GPL. The only safe way to use
> that by drivers/modules is together with an mmu_notifier, and that's
> all _GPL stuff.
I also think it also needs to be renamed to explicitly break any
On Sat, Oct 31, 2020 at 12:50:44PM -0700, Linus Torvalds wrote:
> So this is just a stylistic nit, and has no impact on this pull (which
> I've done). But looking at the patch, it triggers one of my "this is
> wrong" patterns.
Adding the author and maintainer of that code so that they can sort it
On Sat, Oct 31, 2020 at 09:01:45AM -0600, Jens Axboe wrote:
> On 10/31/20 9:00 AM, Jens Axboe wrote:
> > On 10/31/20 4:41 AM, Sebastian Andrzej Siewior wrote:
> >> On 2020-10-29 14:07:59 [-0700], Sagi Grimberg wrote:
> in which context?
> >>>
> >>> Not sure what is the question.
> >>
> >> The
The following changes since commit ed8780e3f2ecc82645342d070c6b4e530532e680:
Merge tag 'x86-urgent-2020-10-27' of
git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip (2020-10-27 14:39:29
-0700)
are available in the Git repository at:
git://git.infradead.org/users/hch/dma-mapping.git
On Fri, Oct 30, 2020 at 10:38:42AM +0200, Mike Rapoport wrote:
>
> What do you mean by "system memory block"? There could be a lot of
> interpretations if you take into account memory hotplug, "mem=" option,
> reserved and firmware memory.
>
> I'd suggest you to describe the entire use case in
On Fri, Oct 30, 2020 at 11:40:33AM +0100, Greg Kroah-Hartman wrote:
> On Thu, Oct 29, 2020 at 08:32:42PM +0100, Christoph Hellwig wrote:
> > On Thu, Oct 29, 2020 at 08:22:36PM +0100, Greg Kroah-Hartman wrote:
> > > After this, you want me to get rid of kobj_map, right? Or yo
On Fri, Oct 30, 2020 at 05:41:22PM +0100, Pali Rohár wrote:
> I would like to open discussion about two ntfs kernel drivers. Do we
> really need two drivers (one read only - current version and one
> read/write - this new version)?
>
> What other people think?
>
> I remember that Christoph
On Sat, Oct 31, 2020 at 03:55:15PM +0800, Fengfei Xi wrote:
> Fix the inappropriate comment to help people to understad the code
>
> Signed-off-by: Fengfei Xi
I think we can just drop the comment entirely as it isn't very useful
to start with.
On Thu, Oct 29, 2020 at 11:18:06PM +0100, Thomas Gleixner wrote:
> This is achieved by:
...
>
> - Consolidating all kmap atomic implementations in generic code
...
> Though I wanted to share the current state of affairs before investigating
> that further. If there is consensus in going
On Thu, Oct 29, 2020 at 08:22:36PM +0100, Greg Kroah-Hartman wrote:
> After this, you want me to get rid of kobj_map, right? Or you don't
> care as block doesn't use it anymore? :)
I have a patch to kill it, but it causes odd regressions with the
tpm driver according to the kernel test. As I
On Tue, Oct 27, 2020 at 08:55:51AM +0100, Christoph Hellwig wrote:
> Looks good:
>
> Reviewed-by: Christoph Hellwig
>
> Rob and Frank: do you want to take this through the OF tree, or should
> I queue it up in the dma-mapping tree that caused the problem?
I've picked this up
Now that bdev_map is only used for finding gendisks, we can use
a simple xarray instead of the regions tracking structure for it.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
Reviewed-by: Greg Kroah-Hartman
---
block/genhd.c | 208
-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
---
drivers/block/z2ram.c | 100 --
1 file changed, 58 insertions(+), 42 deletions(-)
diff --git a/drivers/block/z2ram.c b/drivers/block/z2ram.c
index eafecc9a72b38d..c1d20818e64920 100644
--- a/drivers
reindent the driver using Lident as the code style was far away from
normal Linux code.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
---
drivers/block/z2ram.c | 493 --
1 file changed, 236 insertions(+), 257 deletions(-)
diff --git
a separate gendisk for each of the aliases
if they are accessed.
Signed-off-by: Christoph Hellwig
---
drivers/block/ataflop.c | 135 +---
1 file changed, 86 insertions(+), 49 deletions(-)
diff --git a/drivers/block/ataflop.c b/drivers/block/ataflop.c
index
.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
---
drivers/block/amiflop.c | 98 +++--
1 file changed, 55 insertions(+), 43 deletions(-)
diff --git a/drivers/block/amiflop.c b/drivers/block/amiflop.c
index 71c2b156455860..9e2d0c6a387721 100644
Use the simpler mechanism attached to major_name to allocate a brd device
when a currently unregistered minor is accessed.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
---
drivers/block/brd.c | 39 +++
1 file changed, 11 insertions(+), 28
gendisk for each of the aliases
if they are accessed.
Signed-off-by: Christoph Hellwig
---
drivers/block/floppy.c | 154 ++---
1 file changed, 97 insertions(+), 57 deletions(-)
diff --git a/drivers/block/floppy.c b/drivers/block/floppy.c
index 7df79ae6b0a1e1
an unclaimed ide device node, but except for a few potentially loaded
modules for a fringe use case of a deprecated and soon to be removed
driver that doesn't make a difference.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
---
drivers/ide/ide-probe.c | 34
Use the simpler mechanism attached to major_name to allocate a md device
when a currently unregistered minor is accessed.
Signed-off-by: Christoph Hellwig
Acked-by: Song Liu
Reviewed-by: Hannes Reinecke
---
drivers/md/md.c | 21 -
1 file changed, 8 insertions(+), 13
Use the simpler mechanism attached to major_name to allocate a brd device
when a currently unregistered minor is accessed.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
---
drivers/block/loop.c | 30 --
1 file changed, 8 insertions(+), 22 deletions
Switch from using blk_register_region to the probe callback passed to
__register_blkdev to disable the request_module call for an unclaimed
dev_t in the SD majors.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
---
drivers/scsi/sd.c | 19 +--
1 file changed, 5
The swim driver (unlike various other floppy drivers) doesn't have
magic device nodes for certain modes, and already registers a gendisk
for each of the floppies supported by a device. Thus the region
registered is a no-op and can be removed.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes
There is no need to ever register the fake gendisk used for ide-tape.
Signed-off-by: Christoph Hellwig
Reviewed-by: Hannes Reinecke
---
drivers/ide/ide-probe.c | 32
drivers/ide/ide-tape.c | 2 --
include/linux/ide.h | 3 ---
3 files changed, 37
Add a callback to the major_names array that allows a driver to override
how to probe for dev_t that doesn't currently have a gendisk registered.
This will help separating the lookup of the gendisk by dev_t vs probe
action for a not currently registered dev_t.
Signed-off-by: Christoph Hellwig
Hi all,
this series removes the annoying struct block_device aliases, which can
happen for a bunch of old floppy drivers (and z2ram). In that case
multiple struct block device instances for different dev_t's can point
to the same gendisk, without being partitions. The cause for that
is the
1001 - 1100 of 23089 matches
Mail list logo
