Re: [PATCH] iio: light: add driver for bh1730fvc chips

On Wed, Feb 21, 2018 at 6:15 PM, Pierre Bourdon (delroth) wrote: > Hi Daniel, > > On Wed, Feb 21, 2018 at 4:31 PM, Daniel Baluta > wrote: >> On Wed, Feb 21, 2018 at 2:55 PM, Pierre Bourdon wrote: >>> Ambient light sensor that supports visible light and IR measurement

Re: [PATCH] iio:dummy: Fix coding style in simple_dummy and evgen

On Wed, Feb 21, 2018 at 4:05 PM, Rodrigo Siqueira wrote: > This patch fixes the following checkpatch.pl warnings: > > drivers/iio/dummy/iio_simple_dummy.c:603: WARNING: Block comments should > align the * on each line > drivers/iio/dummy/iio_dummy_evgen.c:151:

Re: [PATCH] iio:dummy: Fix coding style in simple_dummy and evgen

On Wed, Feb 21, 2018 at 4:05 PM, Rodrigo Siqueira wrote: > This patch fixes the following checkpatch.pl warnings: > > drivers/iio/dummy/iio_simple_dummy.c:603: WARNING: Block comments should > align the * on each line > drivers/iio/dummy/iio_dummy_evgen.c:151: WARNING: Symbolic permissions >

Re: [PATCH] iio: light: add driver for bh1730fvc chips

Hi Pierre, Few comments inline: On Wed, Feb 21, 2018 at 2:55 PM, Pierre Bourdon wrote: > Ambient light sensor that supports visible light and IR measurements and > configurable gain/integration time. > Can you have a quick look to existing ROHM light sensor support. Perhaps

Re: [PATCH] iio: light: add driver for bh1730fvc chips

Hi Pierre, Few comments inline: On Wed, Feb 21, 2018 at 2:55 PM, Pierre Bourdon wrote: > Ambient light sensor that supports visible light and IR measurements and > configurable gain/integration time. > Can you have a quick look to existing ROHM light sensor support. Perhaps your sensor is

[PATCH] ASoC: codecs: ak5558: Fix style for SPDX identifier

Use // for .c and /* for .h files according to: Documentation/process/license-rules.rst file. Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com> --- sound/soc/codecs/ak5558.c | 11 +-- sound/soc/codecs/ak5558.h | 4 ++-- 2 files changed, 7 insertions(+), 8 deletions(-) diff

[PATCH] ASoC: codecs: ak5558: Fix style for SPDX identifier

Use // for .c and /* for .h files according to: Documentation/process/license-rules.rst file. Signed-off-by: Daniel Baluta --- sound/soc/codecs/ak5558.c | 11 +-- sound/soc/codecs/ak5558.h | 4 ++-- 2 files changed, 7 insertions(+), 8 deletions(-) diff --git a/sound/soc/codecs/ak5558

Re: [PATCH] iio: apply coding-style into ms5611_probe function

Hi Rodrigo, Mostly looking good. Few comments. Please read: https://chris.beams.io/posts/git-commit/ 1) Capitalize the first letter of commit 2) Use prefix tags to indicate the driver that is changed. Here iio:pressure:ms5611. If not sure what prefix tags to use please use git log file.c and

Re: [PATCH] iio: apply coding-style into ms5611_probe function

Hi Rodrigo, Mostly looking good. Few comments. Please read: https://chris.beams.io/posts/git-commit/ 1) Capitalize the first letter of commit 2) Use prefix tags to indicate the driver that is changed. Here iio:pressure:ms5611. If not sure what prefix tags to use please use git log file.c and

Re: [PATCH] staging: iio/meter: add name to function definition arguments

Hi Rodrigo, I think this is a nice finding. One comment inline: On Vi, 2018-02-16 at 10:50 -0200, rodrigosiqueira wrote: > This patch fixes the checkpatch.pl warning: > > drivers/staging/iio/meter/ade7854.h:157: WARNING: function definition > argument 'struct device *' should also have an

Re: [PATCH] staging: iio/meter: add name to function definition arguments

Hi Rodrigo, I think this is a nice finding. One comment inline: On Vi, 2018-02-16 at 10:50 -0200, rodrigosiqueira wrote: > This patch fixes the checkpatch.pl warning: > > drivers/staging/iio/meter/ade7854.h:157: WARNING: function definition > argument 'struct device *' should also have an

Re: [PATCH v4 1/2] ASoC: codecs: Add support for AK5558 ADC driver

On Vi, 2018-02-16 at 12:14 +, Mark Brown wrote: > On Tue, Feb 13, 2018 at 04:29:33PM +0200, Daniel Baluta wrote: > > > > > +++ b/sound/soc/codecs/ak5558.c > > @@ -0,0 +1,417 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > Just make this a C++ c

Re: [PATCH v4 1/2] ASoC: codecs: Add support for AK5558 ADC driver

On Vi, 2018-02-16 at 12:14 +, Mark Brown wrote: > On Tue, Feb 13, 2018 at 04:29:33PM +0200, Daniel Baluta wrote: > > > > > +++ b/sound/soc/codecs/ak5558.c > > @@ -0,0 +1,417 @@ > > +// SPDX-License-Identifier: GPL-2.0 > > +/* > Just make this a C++ c

[PATCH v4 2/2] ASoC: ak5558: Add bindings for AK5558 ADC

Document the bindings for AK5558 ADC. Reviewed-by: Rob Herring <r...@kernel.org> Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com> --- Documentation/devicetree/bindings/sound/ak5558.txt | 22 ++ 1 file changed, 22 insertions(+) create mode 100644 Documentatio

[PATCH v4 2/2] ASoC: ak5558: Add bindings for AK5558 ADC

Document the bindings for AK5558 ADC. Reviewed-by: Rob Herring Signed-off-by: Daniel Baluta --- Documentation/devicetree/bindings/sound/ak5558.txt | 22 ++ 1 file changed, 22 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/ak5558.txt diff --git

[PATCH v4 1/2] ASoC: codecs: Add support for AK5558 ADC driver

.w...@nxp.com> [tdm support] Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com> [pm support, cleanups and porting to latest kernel] --- sound/soc/codecs/Kconfig | 6 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/ak5558.c | 417 ++ sound

[PATCH v4 1/2] ASoC: codecs: Add support for AK5558 ADC driver

-off-by: Junichi Wakasugi [initial coding for 3.18 kernel] Signed-off-by: Mihai Serban [cleanups and porting to 4.9 kernel] Signed-off-by: Shengjiu Wang [tdm support] Signed-off-by: Daniel Baluta [pm support, cleanups and porting to latest kernel] --- sound/soc/codecs/Kconfig | 6 + sound/soc

[PATCH v4 0/2] Add support for AK5558 ADC

* remove debug prints at the beginning of functions. * only support auto clock switching (manual switching was dead code anyway) (in the future we could add a DT property to choose between manual and auto) * Use gpiod API * use GENMASK * introduce power_off/power_on Daniel Baluta (2): ASoC

[PATCH v4 0/2] Add support for AK5558 ADC

* remove debug prints at the beginning of functions. * only support auto clock switching (manual switching was dead code anyway) (in the future we could add a DT property to choose between manual and auto) * Use gpiod API * use GENMASK * introduce power_off/power_on Daniel Baluta (2): ASoC

Re: [PATCH v3 1/2] ASoC: codecs: Add support for AK5558 ADC driver

On Lu, 2018-02-12 at 12:02 +, Mark Brown wrote: > On Mon, Feb 05, 2018 at 07:01:54PM +0200, Daniel Baluta wrote: > > > > AK5558 is a 32-bit, 768 kHZ sampling, differential input ADC > > for digital audio systems. > > > > --- /dev/null > > +++ b/sound

Re: [PATCH v3 1/2] ASoC: codecs: Add support for AK5558 ADC driver

On Lu, 2018-02-12 at 12:02 +, Mark Brown wrote: > On Mon, Feb 05, 2018 at 07:01:54PM +0200, Daniel Baluta wrote: > > > > AK5558 is a 32-bit, 768 kHZ sampling, differential input ADC > > for digital audio systems. > > > > --- /dev/null > > +++ b/sound

[PATCH v3 0/2] Add support for AK5558 ADC

enough. With just power_on after resume aplay plays a song for 1 seconds and then the sound stops. Datasheet says, page 55" (1) The PDN pin should be held to “L” for more than 150 ns after AVDD and TVDD are powered up. Daniel Baluta (2): ASoC: codecs: Add support for AK5558 ADC driver

[PATCH v3 0/2] Add support for AK5558 ADC

enough. With just power_on after resume aplay plays a song for 1 seconds and then the sound stops. Datasheet says, page 55" (1) The PDN pin should be held to “L” for more than 150 ns after AVDD and TVDD are powered up. Daniel Baluta (2): ASoC: codecs: Add support for AK5558 ADC driver

[PATCH v3 2/2] ASoC: ak5558: Add bindings for AK5558 ADC

Document the bindings for AK5558 ADC. Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com> --- Documentation/devicetree/bindings/sound/ak5558.txt | 22 ++ 1 file changed, 22 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/ak5558.txt diff

[PATCH v3 2/2] ASoC: ak5558: Add bindings for AK5558 ADC

Document the bindings for AK5558 ADC. Signed-off-by: Daniel Baluta --- Documentation/devicetree/bindings/sound/ak5558.txt | 22 ++ 1 file changed, 22 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/ak5558.txt diff --git a/Documentation/devicetree

[PATCH v3 1/2] ASoC: codecs: Add support for AK5558 ADC driver

.jp> [initial coding for 3.18 kernel] Signed-off-by: Mihai Serban <mihai.ser...@nxp.com> [cleanups and porting to 4.9 kernel] Signed-off-by: Shengjiu Wang <shengjiu.w...@nxp.com> [tdm support] Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com> [pm support, cleanups and

[PATCH v3 1/2] ASoC: codecs: Add support for AK5558 ADC driver

] Signed-off-by: Mihai Serban [cleanups and porting to 4.9 kernel] Signed-off-by: Shengjiu Wang [tdm support] Signed-off-by: Daniel Baluta [pm support, cleanups and porting to latest kernel] --- sound/soc/codecs/Kconfig | 6 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/ak5558.c | 618

Re: [PATCH v2 1/2] ASoC: codecs: Add support for AK5558 ADC driver

On Sun, Feb 4, 2018 at 4:31 PM, Andy Shevchenko <andy.shevche...@gmail.com> wrote: > On Sat, Feb 3, 2018 at 1:11 AM, Mark Brown <broo...@kernel.org> wrote: >> On Fri, Feb 02, 2018 at 09:33:18PM +0200, Andy Shevchenko wrote: >>> On Fri, Feb 2, 2018 at 6:20 PM, Daniel

Re: [PATCH v2 1/2] ASoC: codecs: Add support for AK5558 ADC driver

On Sun, Feb 4, 2018 at 4:31 PM, Andy Shevchenko wrote: > On Sat, Feb 3, 2018 at 1:11 AM, Mark Brown wrote: >> On Fri, Feb 02, 2018 at 09:33:18PM +0200, Andy Shevchenko wrote: >>> On Fri, Feb 2, 2018 at 6:20 PM, Daniel Baluta wrote: >> >>> > +static int ak

[PATCH v2 2/2] ASoC: ak5558: Add bindings for AK5558 ADC

Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com> --- Documentation/devicetree/bindings/sound/ak5558.txt | 23 ++ 1 file changed, 23 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/ak5558.txt diff --git a/Documentation/devicetree/bindings

[PATCH v2 2/2] ASoC: ak5558: Add bindings for AK5558 ADC

Signed-off-by: Daniel Baluta --- Documentation/devicetree/bindings/sound/ak5558.txt | 23 ++ 1 file changed, 23 insertions(+) create mode 100644 Documentation/devicetree/bindings/sound/ak5558.txt diff --git a/Documentation/devicetree/bindings/sound/ak5558.txt b

[PATCH v2 1/2] ASoC: codecs: Add support for AK5558 ADC driver

.jp> [initial coding for 3.18 kernel] Signed-off-by: Mihai Serban <mihai.ser...@nxp.com> [cleanups and porting to 4.9 kernel] Signed-off-by: Shengjiu Wang <shengjiu.w...@nxp.com> [tdm support] Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com> [pm support, cleanups and

[PATCH v2 1/2] ASoC: codecs: Add support for AK5558 ADC driver

] Signed-off-by: Mihai Serban [cleanups and porting to 4.9 kernel] Signed-off-by: Shengjiu Wang [tdm support] Signed-off-by: Daniel Baluta [pm support, cleanups and porting to latest kernel] --- sound/soc/codecs/Kconfig | 6 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/ak5558.c | 626

[PATCH v2 0/2] Add support for AK5558 ADC

power_on alone isn't enough. With just power_on after resume aplay plays a song for 1 seconds and then the sound stops. Datasheet says, page 55" (1) The PDN pin should be held to “L” for more than 150 ns after AVDD and TVDD are powered up. Daniel Baluta (2): ASoC: codecs: Add support for AK555

[PATCH v2 0/2] Add support for AK5558 ADC

power_on alone isn't enough. With just power_on after resume aplay plays a song for 1 seconds and then the sound stops. Datasheet says, page 55" (1) The PDN pin should be held to “L” for more than 150 ns after AVDD and TVDD are powered up. Daniel Baluta (2): ASoC: codecs: Add support for AK555

Re: [PATCH] ASoC: codecs: Add support for AK5558 ADC driver

Hi Fabio, Andy, Thanks a lot for your comments. I will address them and send v2. Few comments inline. On Mi, 2018-01-31 at 18:12 +0200, Andy Shevchenko wrote: > On Wed, Jan 31, 2018 at 2:57 PM, Daniel Baluta <daniel.bal...@nxp.com> wrote: > > > > AK5558 is a 32-

Re: [PATCH] ASoC: codecs: Add support for AK5558 ADC driver

Hi Fabio, Andy, Thanks a lot for your comments. I will address them and send v2. Few comments inline. On Mi, 2018-01-31 at 18:12 +0200, Andy Shevchenko wrote: > On Wed, Jan 31, 2018 at 2:57 PM, Daniel Baluta wrote: > > > > AK5558 is a 32-bit, 768 kHZ sampling, differe

[PATCH] ASoC: codecs: Add support for AK5558 ADC driver

.jp> Signed-off-by: Mihai Serban <mihai.ser...@nxp.com> Signed-off-by: Shengjiu Wang <shengjiu.w...@nxp.com> Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com> --- Documentation/devicetree/bindings/sound/ak5558.txt | 20 + sound/soc/codecs/Kconfig |

[PATCH] ASoC: codecs: Add support for AK5558 ADC driver

Signed-off-by: Shengjiu Wang Signed-off-by: Daniel Baluta --- Documentation/devicetree/bindings/sound/ak5558.txt | 20 + sound/soc/codecs/Kconfig | 6 + sound/soc/codecs/Makefile | 2 + sound/soc/codecs/ak5558.c | 754

Re: [PATCH v5 2/2] iio : cm32181 : cosmetic cleanup

On Thu, Nov 23, 2017 at 12:52 AM, Marc CAPDEVILLE wrote: > Somme cosmetic cleanup suggested by Peter Meerwald-Stadler. Proper way to give credit to someone is to use the Suggested-by tag above your Signed-off by tag. thanks, Daniel.

Re: [PATCH v5 2/2] iio : cm32181 : cosmetic cleanup

On Thu, Nov 23, 2017 at 12:52 AM, Marc CAPDEVILLE wrote: > Somme cosmetic cleanup suggested by Peter Meerwald-Stadler. Proper way to give credit to someone is to use the Suggested-by tag above your Signed-off by tag. thanks, Daniel.

Re: [Outreachy kernel] [PATCH] Fixed IIO_DEVICE_ATTR_NAMED API to take name as a string and added "" around names

Hi Himanshi, On Tue, Sep 12, 2017 at 1:43 AM, Himanshi Jain wrote: > Fixed IIO_DEVICE_ATTR_NAMED API to take name as a > string instead of implicit conversion to string using > preprocessors. Added double quotes around names in > existing usage of IIO_DEVICE_ATTR_NAMED.

Re: [Outreachy kernel] [PATCH] Fixed IIO_DEVICE_ATTR_NAMED API to take name as a string and added "" around names

Hi Himanshi, On Tue, Sep 12, 2017 at 1:43 AM, Himanshi Jain wrote: > Fixed IIO_DEVICE_ATTR_NAMED API to take name as a > string instead of implicit conversion to string using > preprocessors. Added double quotes around names in > existing usage of IIO_DEVICE_ATTR_NAMED. Always use imperative

Re: [PATCH] ASoC: simple-scu-card: Parse off codec widgets

On Lu, 2017-08-21 at 00:43 +, Kuninori Morimoto wrote: > Hi > > > > > Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com> > > --- > >  Documentation/devicetree/bindings/sound/simple-scu-card.txt | 1 + > >  sound/soc/generic/simple-scu-card.c

Re: [PATCH] ASoC: simple-scu-card: Parse off codec widgets

On Lu, 2017-08-21 at 00:43 +, Kuninori Morimoto wrote: > Hi > > > > > Signed-off-by: Daniel Baluta > > --- > >  Documentation/devicetree/bindings/sound/simple-scu-card.txt | 1 + > >  sound/soc/generic/simple-scu-card.c | 4 +++

[PATCH] ASoC: simple-scu-card: Parse off codec widgets

Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com> --- Documentation/devicetree/bindings/sound/simple-scu-card.txt | 1 + sound/soc/generic/simple-scu-card.c | 4 2 files changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/simp

[PATCH] ASoC: simple-scu-card: Parse off codec widgets

Signed-off-by: Daniel Baluta --- Documentation/devicetree/bindings/sound/simple-scu-card.txt | 1 + sound/soc/generic/simple-scu-card.c | 4 2 files changed, 5 insertions(+) diff --git a/Documentation/devicetree/bindings/sound/simple-scu-card.txt b/Documentation

Re: [PATCH v2 1/2] ASoC: codec: wm9860: avoid maybe-uninitialized warning

On Jo, 2017-04-27 at 12:07 +0200, Arnd Bergmann wrote: > On Wed, Apr 26, 2017 at 3:09 PM, Daniel Baluta <daniel.bal...@nxp.com > > wrote: > > > > The new PLL configuration code triggers a harmless warning: > > > > sound/soc/codecs/wm8960.c: In function 'wm896

Re: [PATCH v2 1/2] ASoC: codec: wm9860: avoid maybe-uninitialized warning

On Jo, 2017-04-27 at 12:07 +0200, Arnd Bergmann wrote: > On Wed, Apr 26, 2017 at 3:09 PM, Daniel Baluta > wrote: > > > > The new PLL configuration code triggers a harmless warning: > > > > sound/soc/codecs/wm8960.c: In function 'wm8960_configure_clocking': >

[PATCH v2 0/2] Relax bitclk computation when using PLL

Second one does the actual bitclk relaxation. Daniel Baluta (2): ASoC: codec: wm9860: avoid maybe-uninitialized warning ASoC: codec: wm8960: Relax bit clock computation when using PLL sound/soc/codecs/wm8960.c | 36 +--- 1 file changed, 21 insertions(+), 15

[PATCH v2 0/2] Relax bitclk computation when using PLL

Second one does the actual bitclk relaxation. Daniel Baluta (2): ASoC: codec: wm9860: avoid maybe-uninitialized warning ASoC: codec: wm8960: Relax bit clock computation when using PLL sound/soc/codecs/wm8960.c | 36 +--- 1 file changed, 21 insertions(+), 15

[PATCH v2 1/2] ASoC: codec: wm9860: avoid maybe-uninitialized warning

8960: Stop when a matching PLL freq is found") Suggested-by: Arnd Bergmann <a...@arndb.de> Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com> --- Changes since v1: * use return instead of break * update commit message sound/soc/codecs/wm8960.c | 26 +

[PATCH v2 1/2] ASoC: codec: wm9860: avoid maybe-uninitialized warning

8960: Stop when a matching PLL freq is found") Suggested-by: Arnd Bergmann Signed-off-by: Daniel Baluta --- Changes since v1: * use return instead of break * update commit message sound/soc/codecs/wm8960.c | 26 +- 1 file changed, 9 insertions(+), 17 dele

[PATCH v2 2/2] ASoC: codec: wm8960: Relax bit clock computation when using PLL

. Lets do the same thing when sysclk is derived via PLL. Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com> --- Changes since v2: * rebase after changes in first patch in the series sound/soc/codecs/wm8960.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) di

[PATCH v2 2/2] ASoC: codec: wm8960: Relax bit clock computation when using PLL

. Lets do the same thing when sysclk is derived via PLL. Signed-off-by: Daniel Baluta --- Changes since v2: * rebase after changes in first patch in the series sound/soc/codecs/wm8960.c | 18 -- 1 file changed, 16 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/

Re: [alsa-devel] [PATCH 1/2] ASoC: codec: wm9860: avoid maybe-uninitialized warning

On Mon, Apr 24, 2017 at 6:27 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Mon, Apr 24, 2017 at 3:15 PM, Daniel Baluta <daniel.bal...@gmail.com> > wrote: >> On Fri, Apr 21, 2017 at 5:46 PM, Arnd Bergmann <a...@arndb.de> wrote: >>> On Fri, Apr 21, 201

Re: [alsa-devel] [PATCH 1/2] ASoC: codec: wm9860: avoid maybe-uninitialized warning

On Mon, Apr 24, 2017 at 6:27 PM, Arnd Bergmann wrote: > On Mon, Apr 24, 2017 at 3:15 PM, Daniel Baluta > wrote: >> On Fri, Apr 21, 2017 at 5:46 PM, Arnd Bergmann wrote: >>> On Fri, Apr 21, 2017 at 3:07 PM, Daniel Baluta >>> wrote: >>>> The new

Re: [alsa-devel] [PATCH 1/2] ASoC: codec: wm9860: avoid maybe-uninitialized warning

On Fri, Apr 21, 2017 at 5:46 PM, Arnd Bergmann <a...@arndb.de> wrote: > On Fri, Apr 21, 2017 at 3:07 PM, Daniel Baluta <daniel.bal...@nxp.com> wrote: >> The new PLL configuration code triggers a harmless warning: >> >> sound/soc/codecs/wm8960.c: In function 'wm8

Re: [alsa-devel] [PATCH 1/2] ASoC: codec: wm9860: avoid maybe-uninitialized warning

On Fri, Apr 21, 2017 at 5:46 PM, Arnd Bergmann wrote: > On Fri, Apr 21, 2017 at 3:07 PM, Daniel Baluta wrote: >> The new PLL configuration code triggers a harmless warning: >> >> sound/soc/codecs/wm8960.c: In function 'wm8960_configure_clocking': >> sound/soc/c

[PATCH 1/2] ASoC: codec: wm9860: avoid maybe-uninitialized warning

freq is found") Suggested-by: Arnd Bergmann <a...@arndb.de> Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com> --- Arnd, I agree that your code was more both humans and gcc anyhow for consistency with wm8960_configure_sysclk function I preferred to keep the "if(..) break" st

[PATCH 1/2] ASoC: codec: wm9860: avoid maybe-uninitialized warning

freq is found") Suggested-by: Arnd Bergmann Signed-off-by: Daniel Baluta --- Arnd, I agree that your code was more both humans and gcc anyhow for consistency with wm8960_configure_sysclk function I preferred to keep the "if(..) break" statements. sound/soc/codecs/wm8960.c | 14 +++

[PATCH 2/2] ASoC: codec: wm8960: Relax bit clock computation when using PLL

. Lets do the same thing when sysclk is derived via PLL. Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com> --- Here, I forced the following harmless initialization: *sysclk_idx = *dac_idx = *bclk_idx = -1; otherwise I would trigger a gcc false positive warning: sound/soc

[PATCH 2/2] ASoC: codec: wm8960: Relax bit clock computation when using PLL

. Lets do the same thing when sysclk is derived via PLL. Signed-off-by: Daniel Baluta --- Here, I forced the following harmless initialization: *sysclk_idx = *dac_idx = *bclk_idx = -1; otherwise I would trigger a gcc false positive warning: sound/soc/codecs/wm8960.c: I

[PATCH 0/2] Relax bitclk computation when using PLL

Second one does the actual bitclk relaxation. Daniel Baluta (2): ASoC: codec: wm9860: avoid maybe-uninitialized warning ASoC: codec: wm8960: Relax bit clock computation when using PLL sound/soc/codecs/wm8960.c | 29 - 1 file changed, 20 insertions(+), 9 deletions

[PATCH 0/2] Relax bitclk computation when using PLL

Second one does the actual bitclk relaxation. Daniel Baluta (2): ASoC: codec: wm9860: avoid maybe-uninitialized warning ASoC: codec: wm8960: Relax bit clock computation when using PLL sound/soc/codecs/wm8960.c | 29 - 1 file changed, 20 insertions(+), 9 deletions

Re: [PATCH 3/3] iio: tools: generic_buffer: increase trigger length

On Wed, Apr 19, 2017 at 11:20 AM, Eugen Hristev wrote: > Increased trigger length to 50 in order to cope with trigger names like > fc03.adc-dev0-external-rising > > Signed-off-by: Eugen Hristev > --- > tools/iio/iio_utils.h | 2 +- >

Re: [PATCH 3/3] iio: tools: generic_buffer: increase trigger length

On Wed, Apr 19, 2017 at 11:20 AM, Eugen Hristev wrote: > Increased trigger length to 50 in order to cope with trigger names like > fc03.adc-dev0-external-rising > > Signed-off-by: Eugen Hristev > --- > tools/iio/iio_utils.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [PATCH] ASoC: codec: wm9860: avoid maybe-uninitialized warning

On Thu, Apr 20, 2017 at 10:44 AM, Arnd Bergmann <a...@arndb.de> wrote: > On Thu, Apr 20, 2017 at 8:48 AM, Daniel Baluta <daniel.bal...@gmail.com> > wrote: >> Hi Arnd, >> >> On Wed, Apr 19, 2017 at 8:04 PM, Arnd Bergmann <a...@arndb.de> wrote: >>>

Re: [PATCH] ASoC: codec: wm9860: avoid maybe-uninitialized warning

On Thu, Apr 20, 2017 at 10:44 AM, Arnd Bergmann wrote: > On Thu, Apr 20, 2017 at 8:48 AM, Daniel Baluta > wrote: >> Hi Arnd, >> >> On Wed, Apr 19, 2017 at 8:04 PM, Arnd Bergmann wrote: >>> The new PLL configuration code triggers a harmless warning:

Re: [PATCH] ASoC: codec: wm9860: avoid maybe-uninitialized warning

Hi Arnd, On Wed, Apr 19, 2017 at 8:04 PM, Arnd Bergmann wrote: > The new PLL configuration code triggers a harmless warning: > > sound/soc/codecs/wm8960.c: In function 'wm8960_configure_clocking': > sound/soc/codecs/wm8960.c:735:3: error: 'best_freq_out' may be used >

Re: [PATCH] ASoC: codec: wm9860: avoid maybe-uninitialized warning

Hi Arnd, On Wed, Apr 19, 2017 at 8:04 PM, Arnd Bergmann wrote: > The new PLL configuration code triggers a harmless warning: > > sound/soc/codecs/wm8960.c: In function 'wm8960_configure_clocking': > sound/soc/codecs/wm8960.c:735:3: error: 'best_freq_out' may be used > uninitialized in this

[PATCH 2/2] ASoC: codec: wm8960: Relax bit clock computation when using PLL

. Lets do the same thing when sysclk is derived via PLL. Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com> Acked-by: Charles Keepax <ckee...@opensource.wolfsonmicro.com> --- sound/soc/codecs/wm8960.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/s

[PATCH 2/2] ASoC: codec: wm8960: Relax bit clock computation when using PLL

. Lets do the same thing when sysclk is derived via PLL. Signed-off-by: Daniel Baluta Acked-by: Charles Keepax --- sound/soc/codecs/wm8960.c | 16 ++-- 1 file changed, 14 insertions(+), 2 deletions(-) diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c index ace69da..8ab9

[PATCH 0/2] ASoC: codec: wm8960: Relax bit clock computation when using PLL

did in patch 2/2 of previous series. Daniel Baluta (2): ASoC: codec: wm8960: Stop when a matching PLL freq is found ASoC: codec: wm8960: Relax bit clock computation when using PLL sound/soc/codecs/wm8960.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) -- 2.7.4

[PATCH 1/2] ASoC: codec: wm8960: Stop when a matching PLL freq is found

When a matching PLL freq is found, searching continues even this is not necessary. The problem was introduced with the following refactoring commit 84fdc00d519ffd ("ASoC: codec: wm9860: Refactor PLL out freq search) Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com> --- sound/soc/co

[PATCH 0/2] ASoC: codec: wm8960: Relax bit clock computation when using PLL

did in patch 2/2 of previous series. Daniel Baluta (2): ASoC: codec: wm8960: Stop when a matching PLL freq is found ASoC: codec: wm8960: Relax bit clock computation when using PLL sound/soc/codecs/wm8960.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) -- 2.7.4

[PATCH 1/2] ASoC: codec: wm8960: Stop when a matching PLL freq is found

When a matching PLL freq is found, searching continues even this is not necessary. The problem was introduced with the following refactoring commit 84fdc00d519ffd ("ASoC: codec: wm9860: Refactor PLL out freq search) Signed-off-by: Daniel Baluta --- sound/soc/codecs/wm8960.c | 4 1

[PATCH v2 2/2] ASoC: codec: wm8960: Relax bit clock computation when using PLL

. Lets do the same thing when sysclk is derived via PLL. Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com> Acked-by: Charles Keepax <ckee...@opensource.wolfsonmicro.com> --- sound/soc/codecs/wm8960.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/sou

[PATCH v2 2/2] ASoC: codec: wm8960: Relax bit clock computation when using PLL

. Lets do the same thing when sysclk is derived via PLL. Signed-off-by: Daniel Baluta Acked-by: Charles Keepax --- sound/soc/codecs/wm8960.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c index 1c973f0..8ab9

[PATCH v2 1/2] ASoC: codec: wm9860: Refactor PLL out freq search

Add a separate function for deriving (sysclk, lrclk, bclk) when the clock is auto or pll. Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com> Acked-by: Charles Keepax <ckee...@opensource.wolfsonmicro.com> --- sound/soc/codecs/wm8960.c | 97 +--

[PATCH v2 1/2] ASoC: codec: wm9860: Refactor PLL out freq search

Add a separate function for deriving (sysclk, lrclk, bclk) when the clock is auto or pll. Signed-off-by: Daniel Baluta Acked-by: Charles Keepax --- sound/soc/codecs/wm8960.c | 97 +-- 1 file changed, 68 insertions(+), 29 deletions(-) diff --git

[PATCH v2 0/2] ASoC: codec: wm8960: Relax bit clock computation when using PLL

warnings [i strongly believe they were compiler false positive - see full warning log here (1)] * fixed break for inner loop [1] http://mailman.alsa-project.org/pipermail/alsa-devel/2017-April/119513.html Daniel Baluta (2): ASoC: codec: wm9860: Refactor PLL out freq search ASoC:

[PATCH v2 0/2] ASoC: codec: wm8960: Relax bit clock computation when using PLL

warnings [i strongly believe they were compiler false positive - see full warning log here (1)] * fixed break for inner loop [1] http://mailman.alsa-project.org/pipermail/alsa-devel/2017-April/119513.html Daniel Baluta (2): ASoC: codec: wm9860: Refactor PLL out freq search ASoC:

Re: [alsa-devel] [PATCH 1/2] ASoC: codec: wm9860: Refactor PLL out freq search

On Tue, Apr 4, 2017 at 7:45 PM, Daniel Baluta <daniel.bal...@nxp.com> wrote: > Add a separate function for deriving (sysclk, lrclk, bclk) > when the clock is auto or pll. > > Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com> Just noticed this warnings: sound/soc/codecs

Re: [alsa-devel] [PATCH 1/2] ASoC: codec: wm9860: Refactor PLL out freq search

On Tue, Apr 4, 2017 at 7:45 PM, Daniel Baluta wrote: > Add a separate function for deriving (sysclk, lrclk, bclk) > when the clock is auto or pll. > > Signed-off-by: Daniel Baluta Just noticed this warnings: sound/soc/codecs/wm8960.c:743:3: warning: 'best_freq_out' may be used u

[PATCH 1/2] ASoC: codec: wm9860: Refactor PLL out freq search

Add a separate function for deriving (sysclk, lrclk, bclk) when the clock is auto or pll. Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com> --- sound/soc/codecs/wm8960.c | 93 --- 1 file changed, 64 insertions(+), 29 deletions(-) diff --git a

[PATCH 0/2] ASoC: codec: wm8960: Relax bit clock computation when using PLL

This is a follow up of commit 3c01b9ee2ab ("ASoC: codec: wm8960: Relax bit clock computation") where we relaxed bitclk when sysclk was derived from MCLK. Now, we do the same thing for sysclk derived using PLL. Daniel Baluta (2): ASoC: codec: wm9860: Refactor PLL out freq search A

[PATCH 2/2] ASoC: codec: wm8960: Relax bit clock computation when using PLL

. Lets do the same thing when sysclk is derived via PLL. Signed-off-by: Daniel Baluta <daniel.bal...@nxp.com> --- sound/soc/codecs/wm8960.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c index 36c8454

[PATCH 1/2] ASoC: codec: wm9860: Refactor PLL out freq search

Add a separate function for deriving (sysclk, lrclk, bclk) when the clock is auto or pll. Signed-off-by: Daniel Baluta --- sound/soc/codecs/wm8960.c | 93 --- 1 file changed, 64 insertions(+), 29 deletions(-) diff --git a/sound/soc/codecs/wm8960.c b

[PATCH 0/2] ASoC: codec: wm8960: Relax bit clock computation when using PLL

This is a follow up of commit 3c01b9ee2ab ("ASoC: codec: wm8960: Relax bit clock computation") where we relaxed bitclk when sysclk was derived from MCLK. Now, we do the same thing for sysclk derived using PLL. Daniel Baluta (2): ASoC: codec: wm9860: Refactor PLL out freq search A

[PATCH 2/2] ASoC: codec: wm8960: Relax bit clock computation when using PLL

. Lets do the same thing when sysclk is derived via PLL. Signed-off-by: Daniel Baluta --- sound/soc/codecs/wm8960.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/sound/soc/codecs/wm8960.c b/sound/soc/codecs/wm8960.c index 36c8454..e8cb764 100644 --- a/sound/

Re: [alsa-devel][PATCH v2 2/2] ASoC: wm8960: Let wm8960 driver configure its bit clock and frame clock

On Mon, Apr 3, 2017 at 4:54 PM, Charles Keepax <ckee...@opensource.wolfsonmicro.com> wrote: > On Mon, Apr 03, 2017 at 04:39:40PM +0300, Daniel Baluta wrote: >> On Mon, Apr 3, 2017 at 4:34 PM, Charles Keepax >> <ckee...@opensource.wolfsonmicro.com> wrote: >> >

Re: [alsa-devel][PATCH v2 2/2] ASoC: wm8960: Let wm8960 driver configure its bit clock and frame clock

On Mon, Apr 3, 2017 at 4:54 PM, Charles Keepax wrote: > On Mon, Apr 03, 2017 at 04:39:40PM +0300, Daniel Baluta wrote: >> On Mon, Apr 3, 2017 at 4:34 PM, Charles Keepax >> wrote: >> > On Mon, Apr 03, 2017 at 04:16:23PM +0300, Daniel Baluta wrote: >> > Doe

Re: [alsa-devel][PATCH v2 2/2] ASoC: wm8960: Let wm8960 driver configure its bit clock and frame clock

On Mon, Apr 3, 2017 at 4:34 PM, Charles Keepax <ckee...@opensource.wolfsonmicro.com> wrote: > On Mon, Apr 03, 2017 at 04:16:23PM +0300, Daniel Baluta wrote: >> On Thu, Jan 15, 2015 at 3:34 PM, Zidan Wang <b50...@freescale.com> wrote: >> > On Wed, Jan 14, 2015 at 07:2

Re: [alsa-devel][PATCH v2 2/2] ASoC: wm8960: Let wm8960 driver configure its bit clock and frame clock

On Mon, Apr 3, 2017 at 4:34 PM, Charles Keepax wrote: > On Mon, Apr 03, 2017 at 04:16:23PM +0300, Daniel Baluta wrote: >> On Thu, Jan 15, 2015 at 3:34 PM, Zidan Wang wrote: >> > On Wed, Jan 14, 2015 at 07:27:03PM +, Mark Brown wrote: >> >> On Wed, Jan 07, 2015 a

Re: [alsa-devel][PATCH v2 2/2] ASoC: wm8960: Let wm8960 driver configure its bit clock and frame clock

On Thu, Jan 15, 2015 at 3:34 PM, Zidan Wang wrote: > On Wed, Jan 14, 2015 at 07:27:03PM +, Mark Brown wrote: >> On Wed, Jan 07, 2015 at 03:31:45PM +0800, Zidan Wang wrote: >> >> > + for (i = 0; i < ARRAY_SIZE(dac_divs); ++i) { >> > + if (wm8960->sysclk ==

Re: [alsa-devel][PATCH v2 2/2] ASoC: wm8960: Let wm8960 driver configure its bit clock and frame clock

On Thu, Jan 15, 2015 at 3:34 PM, Zidan Wang wrote: > On Wed, Jan 14, 2015 at 07:27:03PM +, Mark Brown wrote: >> On Wed, Jan 07, 2015 at 03:31:45PM +0800, Zidan Wang wrote: >> >> > + for (i = 0; i < ARRAY_SIZE(dac_divs); ++i) { >> > + if (wm8960->sysclk == lrclk * dac_divs[i]) { >>

Re: [Outreachy kernel] [PATCH 1/4] iio: common: st_sensors: Replace ternary operator with min macro

On Wed, Mar 29, 2017 at 3:33 PM, simran singhal wrote: > Use macro min() to get the minimum of two values for brevity and > readability. > > Signed-off-by: simran singhal > --- > drivers/iio/common/st_sensors/st_sensors_i2c.c | 2 +- > 1 file

Re: [Outreachy kernel] [PATCH 1/4] iio: common: st_sensors: Replace ternary operator with min macro

On Wed, Mar 29, 2017 at 3:33 PM, simran singhal wrote: > Use macro min() to get the minimum of two values for brevity and > readability. > > Signed-off-by: simran singhal > --- > drivers/iio/common/st_sensors/st_sensors_i2c.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff

Re: [alsa-devel] [PATCH v3 2/2] ASoC: imx-wm8962: Fix codec_clk cleanup

On Tue, Mar 28, 2017 at 6:24 PM, Mark Brown <broo...@kernel.org> wrote: > On Tue, Mar 28, 2017 at 12:53:06PM +0100, Charles Keepax wrote: >> On Tue, Mar 28, 2017 at 01:47:04PM +0300, Daniel Baluta wrote: > >> > >> - codec_clk = devm_clk_get(_dev->dev, NULL

<    1   2   3   4   5   6   7   8   9   10   >