Re: [PATCH] jfs: clear PAGECACHE_TAG_DIRTY for no-write pages

2007-12-28 Thread Dave Kleikamp
On Fri, 2007-12-28 at 12:33 +0100, Peter Zijlstra wrote: On Fri, 2007-12-28 at 16:03 +0800, Fengguang Wu wrote: Andrew, This patch fixed the 'pdflush stuck in D state' bug http://bugzilla.kernel.org/show_bug.cgi?id=9291 and should be pushed to mainline ASAP. --- When

Re: [PATCH] jfs: clear PAGECACHE_TAG_DIRTY for no-write pages

2007-12-28 Thread Dave Kleikamp
On Fri, 2007-12-28 at 10:25 -0600, Dave Kleikamp wrote: On Fri, 2007-12-28 at 12:33 +0100, Peter Zijlstra wrote: I'm not liking this open-coded tag_clear, although I currently fail to come up with a nice solution. I'm looking at __block_write_full_page() for guidance. The situation

Re: [PATCH] jfs: clear PAGECACHE_TAG_DIRTY for no-write pages

2007-12-28 Thread Dave Kleikamp
On Sat, 2007-12-29 at 10:21 +0800, Fengguang Wu wrote: On Fri, Dec 28, 2007 at 10:53:14AM -0600, Dave Kleikamp wrote: --- diff -Nurp linux-2.6.24-rc6-git5/fs/jfs/jfs_metapage.c linux/fs/jfs/jfs_metapage.c --- linux-2.6.24-rc6-git5/fs/jfs/jfs_metapage.c 2007-12-28 10:28

Re: [rfc] lockless get_user_pages for dio (and more)

2007-12-11 Thread Dave Kleikamp
On Wed, 2007-12-12 at 15:57 +1100, Nick Piggin wrote: > On Tuesday 11 December 2007 08:30, Dave Kleikamp wrote: > > Nick, > > I've played with the fast_gup patch a bit. I was able to find a problem > > in follow_hugetlb_page() that Adam Litke fixed. I'm haven't

Re: [rfc] lockless get_user_pages for dio (and more)

2007-12-11 Thread Dave Kleikamp
On Wed, 2007-12-12 at 15:57 +1100, Nick Piggin wrote: On Tuesday 11 December 2007 08:30, Dave Kleikamp wrote: Nick, I've played with the fast_gup patch a bit. I was able to find a problem in follow_hugetlb_page() that Adam Litke fixed. I'm haven't been brave enough to implement

Re: [rfc] lockless get_user_pages for dio (and more)

2007-12-10 Thread Dave Kleikamp
On Mon, 2007-10-15 at 22:25 +1000, Nick Piggin wrote: > On Monday 15 October 2007 04:19, Siddha, Suresh B wrote: > > On Sun, Oct 14, 2007 at 11:01:02AM +1000, Nick Piggin wrote: > > > This is just a really quick hack, untested ATM, but one that > > > has at least a chance of working (on x86). >

Re: [rfc] lockless get_user_pages for dio (and more)

2007-12-10 Thread Dave Kleikamp
On Mon, 2007-10-15 at 22:25 +1000, Nick Piggin wrote: On Monday 15 October 2007 04:19, Siddha, Suresh B wrote: On Sun, Oct 14, 2007 at 11:01:02AM +1000, Nick Piggin wrote: This is just a really quick hack, untested ATM, but one that has at least a chance of working (on x86). When we

Re: [PATCH] - [6/15] - remove defconfig ptr comparisons to 0 - fs/jfs

2007-11-13 Thread Dave Kleikamp
On Tue, 2007-11-13 at 18:05 -0800, Joe Perches wrote: > Remove defconfig ptr comparison to 0 > > Remove sparse warning: Using plain integer as NULL pointer > > Signed-off-by: Joe Perches <[EMAIL PROTECTED]> Signed-off-by: Dave Kleikamp <[EMAIL PROTECTED]> I've add

Re: [PATCH] - [6/15] - remove defconfig ptr comparisons to 0 - fs/jfs

2007-11-13 Thread Dave Kleikamp
On Tue, 2007-11-13 at 18:05 -0800, Joe Perches wrote: Remove defconfig ptr comparison to 0 Remove sparse warning: Using plain integer as NULL pointer Signed-off-by: Joe Perches [EMAIL PROTECTED] Signed-off-by: Dave Kleikamp [EMAIL PROTECTED] I've added this to the jfs git tree. Thanks

Re: [interesting] smattering of possible memory ordering bugs

2007-10-26 Thread Dave Kleikamp
Memory barriers aren't one of my strengths, but this appears correct. Acked-by: Dave Kleikamp <[EMAIL PROTECTED]> On Fri, 2007-10-26 at 12:09 +1000, Nick Piggin wrote: > Index: linux-2.6/fs/jfs/jfs_metapage.c > === >

Re: [interesting] smattering of possible memory ordering bugs

2007-10-26 Thread Dave Kleikamp
Memory barriers aren't one of my strengths, but this appears correct. Acked-by: Dave Kleikamp [EMAIL PROTECTED] On Fri, 2007-10-26 at 12:09 +1000, Nick Piggin wrote: Index: linux-2.6/fs/jfs/jfs_metapage.c === --- linux-2.6.orig

Re: oops in lbmIODone, fails to boot [Re: 2.6.23-mm1]

2007-10-20 Thread Dave Kleikamp
On Fri, 2007-10-19 at 22:34 -0700, Andrew Morton wrote: > On Sat, 20 Oct 2007 13:57:54 +0900 Mattia Dongili <[EMAIL PROTECTED]> wrote: > > > On Thu, Oct 11, 2007 at 09:31:26PM -0700, Andrew Morton wrote: > > > > > > ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23/2.6.23-mm1/

Re: oops in lbmIODone, fails to boot [Re: 2.6.23-mm1]

2007-10-20 Thread Dave Kleikamp
On Fri, 2007-10-19 at 22:34 -0700, Andrew Morton wrote: On Sat, 20 Oct 2007 13:57:54 +0900 Mattia Dongili [EMAIL PROTECTED] wrote: On Thu, Oct 11, 2007 at 09:31:26PM -0700, Andrew Morton wrote: ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.23/2.6.23-mm1/ Hey

Re: [PATCH] JFS: Bio cleanup: Replace missing return statements

2007-10-13 Thread Dave Kleikamp
On Sat, 2007-10-13 at 12:28 -0700, Randy Dunlap wrote: > On Sat, 13 Oct 2007 15:11:10 -0400 Jeff Garzik wrote: > > > > > From: Dave Kleikamp <[EMAIL PROTECTED]> > > > > commit 6712ecf8f648118c3363c142196418f89a510b90 removed some "return 0;" >

Re: 2.6.23-git3 jfs/bio bug

2007-10-13 Thread Dave Kleikamp
[ 9159.490780] Rebooting in 30 seconds.. I don't have time to test this now, but the bio_endio patches ended up removing some return statements that need to stay. I think this should fix it. JFS: Bio cleanup: Replace missing return statements commit 6712ecf8f648118c3363c142196418f89a510b90 remo

Re: 2.6.23-git3 jfs/bio bug

2007-10-13 Thread Dave Kleikamp
this should fix it. JFS: Bio cleanup: Replace missing return statements commit 6712ecf8f648118c3363c142196418f89a510b90 removed some return 0; statements, rather than changing them to null returns. Signed-off-by: Dave Kleikamp [EMAIL PROTECTED] diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c

Re: [PATCH] JFS: Bio cleanup: Replace missing return statements

2007-10-13 Thread Dave Kleikamp
On Sat, 2007-10-13 at 12:28 -0700, Randy Dunlap wrote: On Sat, 13 Oct 2007 15:11:10 -0400 Jeff Garzik wrote: From: Dave Kleikamp [EMAIL PROTECTED] commit 6712ecf8f648118c3363c142196418f89a510b90 removed some return 0; statements, rather than changing them to null returns. Is my

Re: [PATCH] JFS: fix bio-related build breakage

2007-10-12 Thread Dave Kleikamp
I'd say add my ack, but I see it's already been picked up. Thanks, Shaggy On Fri, 2007-10-12 at 00:01 -0400, Jeff Garzik wrote: > Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> > > diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c > index 57c3b8a..ccfd029 100644 > --- a/fs/jfs/jfs_logmgr.c

Re: [PATCH] JFS: fix bio-related build breakage

2007-10-12 Thread Dave Kleikamp
I'd say add my ack, but I see it's already been picked up. Thanks, Shaggy On Fri, 2007-10-12 at 00:01 -0400, Jeff Garzik wrote: Signed-off-by: Jeff Garzik [EMAIL PROTECTED] diff --git a/fs/jfs/jfs_logmgr.c b/fs/jfs/jfs_logmgr.c index 57c3b8a..ccfd029 100644 --- a/fs/jfs/jfs_logmgr.c +++

Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()

2007-10-02 Thread Dave Kleikamp
On Tue, 2007-10-02 at 14:24 +0100, David Howells wrote: > Dave Kleikamp <[EMAIL PROTECTED]> wrote: > > > Of course, the cast is unnecessary, > > The cast is necessary as the argument is a const pointer and the return type > is not. Ah yes. I stand corrected. -

Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()

2007-10-02 Thread Dave Kleikamp
On Tue, 2007-10-02 at 13:32 +0100, David Howells wrote: > Zach Brown <[EMAIL PROTECTED]> wrote: > > > /* haha, continuing the fine tradition of terrible names in this api.. */ > > static inline void *PTR_PTR(void *err_ptr) { > > BUG_ON(!IS_ERR(err_ptr) || !err_ptr); > > return err_ptr;

Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()

2007-10-02 Thread Dave Kleikamp
On Tue, 2007-10-02 at 13:32 +0100, David Howells wrote: Zach Brown [EMAIL PROTECTED] wrote: /* haha, continuing the fine tradition of terrible names in this api.. */ static inline void *PTR_PTR(void *err_ptr) { BUG_ON(!IS_ERR(err_ptr) || !err_ptr); return err_ptr; } How

Re: [PATCH 07/30] IGET: Stop BEFS from using iget() and read_inode()

2007-10-02 Thread Dave Kleikamp
On Tue, 2007-10-02 at 14:24 +0100, David Howells wrote: Dave Kleikamp [EMAIL PROTECTED] wrote: Of course, the cast is unnecessary, The cast is necessary as the argument is a const pointer and the return type is not. Ah yes. I stand corrected. -- David Kleikamp IBM Linux Technology

Re: [PATCH 20/30] IGET: Stop JFS from using iget() and read_inode()

2007-10-01 Thread Dave Kleikamp
of an inode in the event of an error. > > jfs_fill_super() returns any error incurred when getting the root inode > instead of EINVAL. > > Signed-off-by: David Howells <[EMAIL PROTECTED]> Acked-by: Dave Kleikamp <[EMAIL PROTECTED]> > --- > > fs/jfs/i

Re: [PATCH 20/30] IGET: Stop JFS from using iget() and read_inode()

2007-10-01 Thread Dave Kleikamp
in the event of an error. jfs_fill_super() returns any error incurred when getting the root inode instead of EINVAL. Signed-off-by: David Howells [EMAIL PROTECTED] Acked-by: Dave Kleikamp [EMAIL PROTECTED] --- fs/jfs/inode.c | 20 fs/jfs/jfs_inode.h |2 +- fs

Re: [PATCH] JBD slab cleanups

2007-09-19 Thread Dave Kleikamp
On Wed, 2007-09-19 at 14:26 -0500, Dave Kleikamp wrote: > On Wed, 2007-09-19 at 12:15 -0700, Mingming Cao wrote: > > > Here is the patch to clean up __GFP_NOFAIL flag in jbd/jbd2. In all > > cases except one handles memory allocation failure so I get rid of those &g

Re: [PATCH] JBD slab cleanups

2007-09-19 Thread Dave Kleikamp
On Wed, 2007-09-19 at 12:15 -0700, Mingming Cao wrote: > Here is the patch to clean up __GFP_NOFAIL flag in jbd/jbd2. In all > cases except one handles memory allocation failure so I get rid of those > GFP_NOFAIL flags. > > Also, shouldn't we use GFP_KERNEL instead of GFP_NOFS flag for kmalloc >

Re: [Jfs-discussion] [2/4] 2.6.23-rc6: known regressions

2007-09-19 Thread Dave Kleikamp
On Wed, 2007-09-19 at 13:44 +0200, Oliver Neukum wrote: > Am Donnerstag 13 September 2007 schrieb Dave Kleikamp: > > On Wed, 2007-09-12 at 18:58 +0200, Michal Piotrowski wrote: > > > > > Subject : umount triggers a warning in jfs and takes almost a >

Re: [Jfs-discussion] [2/4] 2.6.23-rc6: known regressions

2007-09-19 Thread Dave Kleikamp
On Wed, 2007-09-19 at 13:44 +0200, Oliver Neukum wrote: Am Donnerstag 13 September 2007 schrieb Dave Kleikamp: On Wed, 2007-09-12 at 18:58 +0200, Michal Piotrowski wrote: Subject : umount triggers a warning in jfs and takes almost a minute References : http://lkml.org

Re: [PATCH] JBD slab cleanups

2007-09-19 Thread Dave Kleikamp
On Wed, 2007-09-19 at 12:15 -0700, Mingming Cao wrote: Here is the patch to clean up __GFP_NOFAIL flag in jbd/jbd2. In all cases except one handles memory allocation failure so I get rid of those GFP_NOFAIL flags. Also, shouldn't we use GFP_KERNEL instead of GFP_NOFS flag for kmalloc in

Re: [PATCH] JBD slab cleanups

2007-09-19 Thread Dave Kleikamp
On Wed, 2007-09-19 at 14:26 -0500, Dave Kleikamp wrote: On Wed, 2007-09-19 at 12:15 -0700, Mingming Cao wrote: Here is the patch to clean up __GFP_NOFAIL flag in jbd/jbd2. In all cases except one handles memory allocation failure so I get rid of those GFP_NOFAIL flags. Also

Re: [PATCH] JBD slab cleanups

2007-09-18 Thread Dave Kleikamp
On Tue, 2007-09-18 at 09:35 -0700, Mingming Cao wrote: > On Tue, 2007-09-18 at 10:04 +0100, Christoph Hellwig wrote: > > On Mon, Sep 17, 2007 at 03:57:31PM -0700, Mingming Cao wrote: > > > Here is the incremental small cleanup patch. > > > > > > Remove kamlloc usages in jbd/jbd2 and consistently

Re: [2/3] 2.6.23-rc6: known regressions v2

2007-09-18 Thread Dave Kleikamp
On Tue, 2007-09-18 at 16:24 +0200, Jan Kara wrote: > > Subject : umount triggers a warning in jfs and takes almost a minute > > References : http://lkml.org/lkml/2007/9/4/73 > > Last known good : ? > > Submitter : Oliver Neukum <[EMAIL PROTECTED]> > > Caused-By : ? > >

Re: [2/3] 2.6.23-rc6: known regressions v2

2007-09-18 Thread Dave Kleikamp
On Tue, 2007-09-18 at 16:24 +0200, Jan Kara wrote: Subject : umount triggers a warning in jfs and takes almost a minute References : http://lkml.org/lkml/2007/9/4/73 Last known good : ? Submitter : Oliver Neukum [EMAIL PROTECTED] Caused-By : ? Handled-By

Re: [PATCH] JBD slab cleanups

2007-09-18 Thread Dave Kleikamp
On Tue, 2007-09-18 at 09:35 -0700, Mingming Cao wrote: On Tue, 2007-09-18 at 10:04 +0100, Christoph Hellwig wrote: On Mon, Sep 17, 2007 at 03:57:31PM -0700, Mingming Cao wrote: Here is the incremental small cleanup patch. Remove kamlloc usages in jbd/jbd2 and consistently use

Re: [Jfs-discussion] [2/4] 2.6.23-rc6: known regressions

2007-09-13 Thread Dave Kleikamp
On Wed, 2007-09-12 at 18:58 +0200, Michal Piotrowski wrote: > Subject : umount triggers a warning in jfs and takes almost a minute > References : http://lkml.org/lkml/2007/9/4/73 > Last known good : ? > Submitter : Oliver Neukum <[EMAIL PROTECTED]> > Caused-By : ? >

Re: [Jfs-discussion] [2/4] 2.6.23-rc6: known regressions

2007-09-13 Thread Dave Kleikamp
On Wed, 2007-09-12 at 18:58 +0200, Michal Piotrowski wrote: Subject : umount triggers a warning in jfs and takes almost a minute References : http://lkml.org/lkml/2007/9/4/73 Last known good : ? Submitter : Oliver Neukum [EMAIL PROTECTED] Caused-By : ? Handled-By

Re: [2/4] 2.6.23-rc5: known regressions v2

2007-09-08 Thread Dave Kleikamp
On Sat, 2007-09-08 at 13:11 +0200, Michal Piotrowski wrote: > Hi all, > > Here is a list of some known regressions in 2.6.23-rc5. > > Feel free to add new regressions/remove fixed etc. > http://kernelnewbies.org/known_regressions > FS > > Subject : umount triggers a warning in jfs and

Re: [2/4] 2.6.23-rc5: known regressions v2

2007-09-08 Thread Dave Kleikamp
On Sat, 2007-09-08 at 13:11 +0200, Michal Piotrowski wrote: Hi all, Here is a list of some known regressions in 2.6.23-rc5. Feel free to add new regressions/remove fixed etc. http://kernelnewbies.org/known_regressions FS Subject : umount triggers a warning in jfs and takes

Re: [linux-cifs-client] Re: BUG: scheduling while atomic - linux 2.6.22

2007-08-29 Thread Dave Kleikamp
On Tue, 2007-08-28 at 07:11 +0800, Michael Deegan wrote: > Hi, > > On Tue Aug 7 16:00:19 GMT 2007, Martin Koegler wrote: > > A vanilla 2.6.22 kernel (SMP PREEMPT i686) produced the following messages, > > while working with a CIFS mount point: > > > > Aug 7 16:12:30 localhost kernel: BUG:

Re: [linux-cifs-client] Re: BUG: scheduling while atomic - linux 2.6.22

2007-08-29 Thread Dave Kleikamp
On Tue, 2007-08-28 at 07:11 +0800, Michael Deegan wrote: Hi, On Tue Aug 7 16:00:19 GMT 2007, Martin Koegler wrote: A vanilla 2.6.22 kernel (SMP PREEMPT i686) produced the following messages, while working with a CIFS mount point: Aug 7 16:12:30 localhost kernel: BUG: scheduling

Re: [PATCH 28/30] jfs: avoid pointless casts of kmalloc() return val

2007-08-23 Thread Dave Kleikamp
Thanks, but Jack Stone submitted the same patch a few weeks ago. It's already in the jfs git tree and the -mm kernel. Shaggy On Fri, 2007-08-24 at 02:36 +0200, Jesper Juhl wrote: > There's no need to cast the, void *, return value of kmalloc() when > assigning to a pointer variable. > >

Re: [PATCH 28/30] jfs: avoid pointless casts of kmalloc() return val

2007-08-23 Thread Dave Kleikamp
Thanks, but Jack Stone submitted the same patch a few weeks ago. It's already in the jfs git tree and the -mm kernel. Shaggy On Fri, 2007-08-24 at 02:36 +0200, Jesper Juhl wrote: There's no need to cast the, void *, return value of kmalloc() when assigning to a pointer variable.

Re: [Jfs-discussion] [PATCH 2/4] Fix mainline filesystems to handle ATTR_KILL_ bits correctly

2007-08-20 Thread Dave Kleikamp
ttr inode op. Here's my ack for the jfs piece. > > Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> Acked-by: Dave Kleikamp <[EMAIL PROTECTED]> -- David Kleikamp IBM Linux Technology Center - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in t

Re: [Jfs-discussion] [PATCH 2/4] Fix mainline filesystems to handle ATTR_KILL_ bits correctly

2007-08-20 Thread Dave Kleikamp
. Here's my ack for the jfs piece. Signed-off-by: Jeff Layton [EMAIL PROTECTED] Acked-by: Dave Kleikamp [EMAIL PROTECTED] -- David Kleikamp IBM Linux Technology Center - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

Re: [Jfs-discussion] [PATCH 15/25] JFS: call attr_kill_to_mode from jfs_setattr

2007-08-07 Thread Dave Kleikamp
On Mon, 2007-08-06 at 09:54 -0400, Jeff Layton wrote: > Signed-off-by: Jeff Layton <[EMAIL PROTECTED]> Acked-by: Dave Kleikamp <[EMAIL PROTECTED]> > --- > fs/jfs/acl.c |2 ++ > 1 files changed, 2 insertions(+), 0 deletions(-) > > diff --git a/fs/jfs/acl.c

Re: [Jfs-discussion] [PATCH 15/25] JFS: call attr_kill_to_mode from jfs_setattr

2007-08-07 Thread Dave Kleikamp
On Mon, 2007-08-06 at 09:54 -0400, Jeff Layton wrote: Signed-off-by: Jeff Layton [EMAIL PROTECTED] Acked-by: Dave Kleikamp [EMAIL PROTECTED] --- fs/jfs/acl.c |2 ++ 1 files changed, 2 insertions(+), 0 deletions(-) diff --git a/fs/jfs/acl.c b/fs/jfs/acl.c index 4d84bdc..34ca314 100644

Re: [RFC 12/26] ext2 white-out support

2007-08-01 Thread Dave Kleikamp
On Wed, 2007-08-01 at 15:33 -0400, Josef Sipek wrote: > On Wed, Aug 01, 2007 at 02:10:31PM -0500, Dave Kleikamp wrote: > > On Wed, 2007-08-01 at 14:44 -0400, Josef Sipek wrote: > > > Now what? How do you rename? Do you rename in the same branch (assuming it > &g

Re: [RFC 12/26] ext2 white-out support

2007-08-01 Thread Dave Kleikamp
On Wed, 2007-08-01 at 14:44 -0400, Josef Sipek wrote: > Alright not the greatest of examples, there is something to be said about > symmetry, so...let me try again :) > > /a/ > /b/bar(whiteout for bar) > /c/foo/qwerty > > Now, let's mount a union of {a,b,c}, and we'll see: > > $

Re: [RFC 12/26] ext2 white-out support

2007-08-01 Thread Dave Kleikamp
On Tue, 2007-07-31 at 13:11 -0400, Josef Sipek wrote: > On Tue, Jul 31, 2007 at 07:00:12PM +0200, Jan Blunck wrote: > > On Tue, Jul 31, Josef Sipek wrote: > > > > > On Mon, Jul 30, 2007 at 06:13:35PM +0200, Jan Blunck wrote: > > > > Introduce white-out support to ext2. > > > > > > I think

Re: [RFC 12/26] ext2 white-out support

2007-08-01 Thread Dave Kleikamp
On Tue, 2007-07-31 at 13:11 -0400, Josef Sipek wrote: On Tue, Jul 31, 2007 at 07:00:12PM +0200, Jan Blunck wrote: On Tue, Jul 31, Josef Sipek wrote: On Mon, Jul 30, 2007 at 06:13:35PM +0200, Jan Blunck wrote: Introduce white-out support to ext2. I think storing whiteouts on the

Re: [RFC 12/26] ext2 white-out support

2007-08-01 Thread Dave Kleikamp
On Wed, 2007-08-01 at 14:44 -0400, Josef Sipek wrote: Alright not the greatest of examples, there is something to be said about symmetry, so...let me try again :) /a/ /b/bar(whiteout for bar) /c/foo/qwerty Now, let's mount a union of {a,b,c}, and we'll see: $ find /u

Re: [RFC 12/26] ext2 white-out support

2007-08-01 Thread Dave Kleikamp
On Wed, 2007-08-01 at 15:33 -0400, Josef Sipek wrote: On Wed, Aug 01, 2007 at 02:10:31PM -0500, Dave Kleikamp wrote: On Wed, 2007-08-01 at 14:44 -0400, Josef Sipek wrote: Now what? How do you rename? Do you rename in the same branch (assuming it is rw)? Er, no. According

Re: [Patch 16/16] Remove unnecessary kmalloc casts in the jfs filesystem.

2007-07-31 Thread Dave Kleikamp
Looks good. I'll push it through the jfs git tree. Thanks, Shaggy On Tue, 2007-07-31 at 13:53 +0100, [EMAIL PROTECTED] wrote: > Signed-off-by: Jack Stone <[EMAIL PROTECTED]> > > CC: David Kleikamp <[EMAIL PROTECTED]> > --- > fs/jfs/jfs_dtree.c |8 ++-- > 1 file changed, 2

Re: [Patch 16/16] Remove unnecessary kmalloc casts in the jfs filesystem.

2007-07-31 Thread Dave Kleikamp
Looks good. I'll push it through the jfs git tree. Thanks, Shaggy On Tue, 2007-07-31 at 13:53 +0100, [EMAIL PROTECTED] wrote: Signed-off-by: Jack Stone [EMAIL PROTECTED] CC: David Kleikamp [EMAIL PROTECTED] --- fs/jfs/jfs_dtree.c |8 ++-- 1 file changed, 2 insertions(+), 6

Re: bonnie++ benchmarks for ext2,ext3,ext4,jfs,reiserfs,xfs,zfs on software raid 5

2007-07-30 Thread Dave Kleikamp
On Mon, 2007-07-30 at 10:29 -0400, Justin Piszcz wrote: > Overall JFS seems the fastest but reviewing the mailing list for JFS it > seems like there a lot of problems, especially when people who use JFS > 1 > year, their speed goes to 5 MiB/s over time and the defragfs tool has been >

Re: bonnie++ benchmarks for ext2,ext3,ext4,jfs,reiserfs,xfs,zfs on software raid 5

2007-07-30 Thread Dave Kleikamp
On Mon, 2007-07-30 at 10:29 -0400, Justin Piszcz wrote: Overall JFS seems the fastest but reviewing the mailing list for JFS it seems like there a lot of problems, especially when people who use JFS 1 year, their speed goes to 5 MiB/s over time and the defragfs tool has been removed(?)

Re: RFC: CONFIG_PAGE_SHIFT (aka software PAGE_SIZE)

2007-07-13 Thread Dave Kleikamp
On Fri, 2007-07-13 at 17:13 +1000, David Chinner wrote: > On Thu, Jul 12, 2007 at 09:34:57AM -0700, Dave Hansen wrote: > > On Thu, 2007-07-12 at 18:31 +0200, Andrea Arcangeli wrote: > > > On Fri, Jul 13, 2007 at 12:44:49AM +1000, David Chinner wrote: > > > > That's crap. Just because a machine has

Re: RFC: CONFIG_PAGE_SHIFT (aka software PAGE_SIZE)

2007-07-13 Thread Dave Kleikamp
On Fri, 2007-07-13 at 17:13 +1000, David Chinner wrote: On Thu, Jul 12, 2007 at 09:34:57AM -0700, Dave Hansen wrote: On Thu, 2007-07-12 at 18:31 +0200, Andrea Arcangeli wrote: On Fri, Jul 13, 2007 at 12:44:49AM +1000, David Chinner wrote: That's crap. Just because a machine has lots of

Re: [EXT4 set 2][PATCH 2/5] cleanups: Add extent sanity checks

2007-07-12 Thread Dave Kleikamp
On Thu, 2007-07-12 at 12:38 +0100, Andy Whitcroft wrote: > Andrew Morton wrote: > >> + if (ext4_ext_check_header(inode, ext_block_hdr(bh), > >> + depth - i - 1)) { > >> + err = -EIO; > >> +

Re: [EXT4 set 2][PATCH 2/5] cleanups: Add extent sanity checks

2007-07-12 Thread Dave Kleikamp
On Thu, 2007-07-12 at 12:38 +0100, Andy Whitcroft wrote: Andrew Morton wrote: + if (ext4_ext_check_header(inode, ext_block_hdr(bh), + depth - i - 1)) { + err = -EIO; +

Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version

2007-07-11 Thread Dave Kleikamp
On Wed, 2007-07-11 at 15:05 +1000, Neil Brown wrote: > It just occurred to me: > > If i_version is 64bit, then knfsd would need to be careful when > reading it on a 32bit host. What are the locking rules? How does knfsd use i_version? I would think that if all it was doing was to compare

Re: [EXT4 set 4][PATCH 1/5] i_version:64 bit inode version

2007-07-11 Thread Dave Kleikamp
On Wed, 2007-07-11 at 15:05 +1000, Neil Brown wrote: It just occurred to me: If i_version is 64bit, then knfsd would need to be careful when reading it on a 32bit host. What are the locking rules? How does knfsd use i_version? I would think that if all it was doing was to compare

[git pull] jfs update

2007-07-09 Thread Dave Kleikamp
(-) through these ChangeSets: Commit: 288e4d838d1e999c0515f85a337cacb2be233071 Author: Dave Kleikamp <[EMAIL PROTECTED]> Wed, 13 Jun 2007 10:17:50 -0500 JFS: Update print_hex_dump() syntax Signed-off-by: Dave Kleikamp <[EMAIL PROTECTED]

[git pull] jfs update

2007-07-09 Thread Dave Kleikamp
(-) through these ChangeSets: Commit: 288e4d838d1e999c0515f85a337cacb2be233071 Author: Dave Kleikamp [EMAIL PROTECTED] Wed, 13 Jun 2007 10:17:50 -0500 JFS: Update print_hex_dump() syntax Signed-off-by: Dave Kleikamp [EMAIL PROTECTED] Commit

Re: [PATCH 0/6][TAKE5] fallocate system call

2007-06-28 Thread Dave Kleikamp
On Thu, 2007-06-28 at 11:33 -0700, Andrew Morton wrote: > On Thu, 28 Jun 2007 23:27:57 +0530 "Amit K. Arora" <[EMAIL PROTECTED]> wrote: > > > > Please drop the non-ext4 patches from the ext4 tree and send incremental > > > patches against the (non-ext4) fallocate patches in -mm. > > > > Please

[PATCH 2.6.22-rc6-mm1] compile error when CONFIG_DM_NETLINK is not defined

2007-06-28 Thread Dave Kleikamp
s' drivers/md/dm-mod.o:drivers/md/dm-netlink.h:51: first defined here make[2]: *** [drivers/md/built-in.o] Error 1 I was able to fix it by making the dummy inline functions static. Signed-off-by: Dave Kleikamp <[EMAIL PROTECTED]> diff -Nurp linux-2.6.22-rc6-mm1/drivers/md/dm-netlink.h

[PATCH 2.6.22-rc6-mm1] compile error when CONFIG_DM_NETLINK is not defined

2007-06-28 Thread Dave Kleikamp
-netlink.h:51: first defined here make[2]: *** [drivers/md/built-in.o] Error 1 I was able to fix it by making the dummy inline functions static. Signed-off-by: Dave Kleikamp [EMAIL PROTECTED] diff -Nurp linux-2.6.22-rc6-mm1/drivers/md/dm-netlink.h linux/drivers/md/dm-netlink.h --- linux-2.6.22-rc6-mm1

Re: [PATCH 0/6][TAKE5] fallocate system call

2007-06-28 Thread Dave Kleikamp
On Thu, 2007-06-28 at 11:33 -0700, Andrew Morton wrote: On Thu, 28 Jun 2007 23:27:57 +0530 Amit K. Arora [EMAIL PROTECTED] wrote: Please drop the non-ext4 patches from the ext4 tree and send incremental patches against the (non-ext4) fallocate patches in -mm. Please let us know what

Re: [-mm patch] remove nobh_{prepare,commit}_write()

2007-06-26 Thread Dave Kleikamp
On Tue, 2007-06-26 at 13:32 -0700, Andrew Morton wrote: > On Fri, 15 Jun 2007 00:15:55 +0200 > Adrian Bunk <[EMAIL PROTECTED]> wrote: > > > nobh_{prepare,commit}_write() are no longer used. > > wth? What happened to ext2 and ext3 nobh mode? They seem to > have magically and unchangeloggedly

Re: [-mm patch] remove nobh_{prepare,commit}_write()

2007-06-26 Thread Dave Kleikamp
On Tue, 2007-06-26 at 13:32 -0700, Andrew Morton wrote: On Fri, 15 Jun 2007 00:15:55 +0200 Adrian Bunk [EMAIL PROTECTED] wrote: nobh_{prepare,commit}_write() are no longer used. wth? What happened to ext2 and ext3 nobh mode? They seem to have magically and unchangeloggedly disappeared?

Re: [patch 00/14] Page cache cleanup in anticipation of Large Blocksize support

2007-06-15 Thread Dave Kleikamp
On Thu, 2007-06-14 at 15:04 -0700, Andrew Morton wrote: > > On Thu, 14 Jun 2007 14:37:33 -0700 (PDT) Christoph Lameter <[EMAIL > > PROTECTED]> wrote: > > On Thu, 14 Jun 2007, Andrew Morton wrote: > > > > > We want the 100% case. > > > > Yes that is what we intend to do. Universal support for

Re: [patch 00/14] Page cache cleanup in anticipation of Large Blocksize support

2007-06-15 Thread Dave Kleikamp
On Thu, 2007-06-14 at 15:04 -0700, Andrew Morton wrote: On Thu, 14 Jun 2007 14:37:33 -0700 (PDT) Christoph Lameter [EMAIL PROTECTED] wrote: On Thu, 14 Jun 2007, Andrew Morton wrote: We want the 100% case. Yes that is what we intend to do. Universal support for larger blocksize.

Re: [RFC 0/4] CONFIG_STABLE to switch off development checks

2007-06-03 Thread Dave Kleikamp
On Sat, 2007-06-02 at 09:28 -0700, Jeremy Fitzhardinge wrote: > Dave Kleikamp wrote: > > I'm on Christoph's side here. I don't think it makes sense for any code > > to ask to allocate zero bytes of memory and expect valid memory to be > > returned. > >

Re: [RFC 0/4] CONFIG_STABLE to switch off development checks

2007-06-03 Thread Dave Kleikamp
On Sat, 2007-06-02 at 09:28 -0700, Jeremy Fitzhardinge wrote: Dave Kleikamp wrote: I'm on Christoph's side here. I don't think it makes sense for any code to ask to allocate zero bytes of memory and expect valid memory to be returned. Yes, everyone agrees on that. If you do

Re: [RFC 0/4] CONFIG_STABLE to switch off development checks

2007-06-02 Thread Dave Kleikamp
On Fri, 2007-06-01 at 11:58 -0700, Jeremy Fitzhardinge wrote: > Christoph Lameter wrote: > > Hmmm... We got there because SLUB initially return NULL for kmalloc(0). > > Rationale: The user did not request any memory so we wont give him > > any. > > > > That (to my surprise) caused some strange

Re: [RFC 0/4] CONFIG_STABLE to switch off development checks

2007-06-02 Thread Dave Kleikamp
On Fri, 2007-06-01 at 11:58 -0700, Jeremy Fitzhardinge wrote: Christoph Lameter wrote: Hmmm... We got there because SLUB initially return NULL for kmalloc(0). Rationale: The user did not request any memory so we wont give him any. That (to my surprise) caused some strange behavior of

Re: [PATCH resend] introduce I_SYNC

2007-05-31 Thread Dave Kleikamp
On Thu, 2007-05-31 at 16:25 +0200, Jörn Engel wrote: > --- linux-2.6.21logfs/fs/jfs/jfs_txnmgr.c~I_LOCK2007-05-07 > 10:28:55.0 +0200 > +++ linux-2.6.21logfs/fs/jfs/jfs_txnmgr.c 2007-05-29 > 13:10:32.0 +0200 > @@ -1286,7 +1286,14 @@ int txCommit(tid_t tid, /*

Re: [PATCH resend] introduce I_SYNC

2007-05-31 Thread Dave Kleikamp
On Thu, 2007-05-31 at 16:25 +0200, Jörn Engel wrote: --- linux-2.6.21logfs/fs/jfs/jfs_txnmgr.c~I_LOCK2007-05-07 10:28:55.0 +0200 +++ linux-2.6.21logfs/fs/jfs/jfs_txnmgr.c 2007-05-29 13:10:32.0 +0200 @@ -1286,7 +1286,14 @@ int txCommit(tid_t tid, /*

Re: Apparent Deadlock with nfsd/jfs on 2.6.21.1 under bonnie.

2007-05-29 Thread Dave Kleikamp
On Tue, 2007-05-29 at 13:14 -0500, Roger Heflin wrote: > Dave Kleikamp wrote: > > On Tue, 2007-05-29 at 12:16 -0500, Roger Heflin wrote: > > > >> Dave, > >> > >> Apparently there appears to be another different similar lockup, > >> The MTBF

Re: Apparent Deadlock with nfsd/jfs on 2.6.21.1 under bonnie.

2007-05-29 Thread Dave Kleikamp
On Tue, 2007-05-29 at 12:16 -0500, Roger Heflin wrote: > Dave, > > Apparently there appears to be another different similar lockup, > The MTBF has risen from 1-2 hours without that patch to >100 hours, > so I am fairly sure the patch did correct the original lockup, or > at the very least make

Re: Apparent Deadlock with nfsd/jfs on 2.6.21.1 under bonnie.

2007-05-29 Thread Dave Kleikamp
On Tue, 2007-05-29 at 12:16 -0500, Roger Heflin wrote: Dave, Apparently there appears to be another different similar lockup, The MTBF has risen from 1-2 hours without that patch to 100 hours, so I am fairly sure the patch did correct the original lockup, or at the very least make it a lot

Re: Apparent Deadlock with nfsd/jfs on 2.6.21.1 under bonnie.

2007-05-29 Thread Dave Kleikamp
On Tue, 2007-05-29 at 13:14 -0500, Roger Heflin wrote: Dave Kleikamp wrote: On Tue, 2007-05-29 at 12:16 -0500, Roger Heflin wrote: Dave, Apparently there appears to be another different similar lockup, The MTBF has risen from 1-2 hours without that patch to 100 hours, so I am

Re: [RFC 2/5] inode reservation v0.1 (ext4 kernel patch)

2007-05-24 Thread Dave Kleikamp
On Thu, 2007-05-24 at 02:06 +0800, coly wrote: > The patch is generated based on 2.6.20-ext4-2 branch. you can find the > benchmark from other email. > > DO NOT waste time on reading the patch :-) I post this patch here is to > show that I really spent time on it and the patch can work (even not

Re: [RFC 2/5] inode reservation v0.1 (ext4 kernel patch)

2007-05-24 Thread Dave Kleikamp
On Thu, 2007-05-24 at 02:06 +0800, coly wrote: The patch is generated based on 2.6.20-ext4-2 branch. you can find the benchmark from other email. DO NOT waste time on reading the patch :-) I post this patch here is to show that I really spent time on it and the patch can work (even not

Re: Apparent Deadlock with nfsd/jfs on 2.6.21.1 under bonnie.

2007-05-17 Thread Dave Kleikamp
On Thu, 2007-05-17 at 09:37 -0500, Roger Heflin wrote: > Dave Kleikamp wrote: > > > > > I don't have an answer to an ext3 deadlock, but this looks like a jfs > > problem that was recently fixed in linux-2.6.22-rc1. I had intended to > > send it to the stable

Re: [PATCH 1/5][TAKE3] fallocate() implementation on i86, x86_64 and powerpc

2007-05-17 Thread Dave Kleikamp
On Thu, 2007-05-17 at 09:40 +1000, David Chinner wrote: > On Wed, May 16, 2007 at 07:21:16AM -0500, Dave Kleikamp wrote: > > On Wed, 2007-05-16 at 13:16 +1000, David Chinner wrote: > > > Please don't make this always happen. c/mtime updates should be dependent > >

Re: [PATCH 1/5][TAKE3] fallocate() implementation on i86, x86_64 and powerpc

2007-05-17 Thread Dave Kleikamp
On Thu, 2007-05-17 at 09:40 +1000, David Chinner wrote: On Wed, May 16, 2007 at 07:21:16AM -0500, Dave Kleikamp wrote: On Wed, 2007-05-16 at 13:16 +1000, David Chinner wrote: Please don't make this always happen. c/mtime updates should be dependent on the mode being used and whether

Re: Apparent Deadlock with nfsd/jfs on 2.6.21.1 under bonnie.

2007-05-17 Thread Dave Kleikamp
On Thu, 2007-05-17 at 09:37 -0500, Roger Heflin wrote: Dave Kleikamp wrote: I don't have an answer to an ext3 deadlock, but this looks like a jfs problem that was recently fixed in linux-2.6.22-rc1. I had intended to send it to the stable kernel after it was picked up in mainline

Re: [PATCH 1/5][TAKE3] fallocate() implementation on i86, x86_64 and powerpc

2007-05-16 Thread Dave Kleikamp
On Wed, 2007-05-16 at 13:16 +1000, David Chinner wrote: > On Wed, May 16, 2007 at 01:33:59AM +0530, Amit K. Arora wrote: > > Following changes were made to the previous version: > > 1) Added description before sys_fallocate() definition. > > 2) Return EINVAL for len<=0 (With new draft that

Re: [PATCH 1/5][TAKE3] fallocate() implementation on i86, x86_64 and powerpc

2007-05-16 Thread Dave Kleikamp
On Wed, 2007-05-16 at 13:16 +1000, David Chinner wrote: On Wed, May 16, 2007 at 01:33:59AM +0530, Amit K. Arora wrote: Following changes were made to the previous version: 1) Added description before sys_fallocate() definition. 2) Return EINVAL for len=0 (With new draft that Ulrich

[PATCH -stable] JFS: Fix race waking up jfsIO kernel thread

2007-05-15 Thread Dave Kleikamp
to the log_redrive queue and the jfsIO thread to be awakened after the thread releases log_redrive_lock but before it sets its state to TASK_INTERRUPTIBLE. The jfsIO thread should set the state before giving up the spinlock, so the waking thread will really wake it. Signed-off-by: Dave Kleikamp <[EM

Re: [PATCH 002 of 8] knfsd: exportfs: remove iget abuse

2007-05-15 Thread Dave Kleikamp
uper.c 2007-05-14 11:15:29.0 +1000 > @@ -738,6 +738,7 @@ static const struct super_operations jfs > }; > > static struct export_operations jfs_export_operations = { > + .get_dentry = jfs_get_dentry, > .get_parent = jfs_get_parent, > }; Looks sane. You can add

Re: [PATCH 002 of 8] knfsd: exportfs: remove iget abuse

2007-05-15 Thread Dave Kleikamp
can add: Signed-off-by: Dave Kleikamp [EMAIL PROTECTED] -- David Kleikamp IBM Linux Technology Center - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please

[PATCH -stable] JFS: Fix race waking up jfsIO kernel thread

2007-05-15 Thread Dave Kleikamp
to the log_redrive queue and the jfsIO thread to be awakened after the thread releases log_redrive_lock but before it sets its state to TASK_INTERRUPTIBLE. The jfsIO thread should set the state before giving up the spinlock, so the waking thread will really wake it. Signed-off-by: Dave Kleikamp [EMAIL PROTECTED

[git pull] jfs update

2007-05-08 Thread Dave Kleikamp
/jfs/jfs_logmgr.c |7 --- fs/jfs/jfs_txnmgr.c |6 +++--- 9 files changed, 38 insertions(+), 9 deletions(-) through these ChangeSets: Commit: 05ec9e26be1f668ccba4ca54d9a4966c6208c611 Author: Dave Kleikamp <[EMAIL PROTECTED]> Sat, 05 May 2007 14:24:05

Re: [PATCH 4/5] ext4: fallocate support in ext4

2007-05-08 Thread Dave Kleikamp
On Tue, 2007-05-08 at 16:22 +0530, Amit K. Arora wrote: > On Mon, May 07, 2007 at 10:24:37AM -0500, Dave Kleikamp wrote: > > On Mon, 2007-05-07 at 17:37 +0530, Amit K. Arora wrote: > > > On Thu, May 03, 2007 at 09:31:33PM -0700, Andrew Morton wrote: > > > > S

Re: [PATCH 4/5] ext4: fallocate support in ext4

2007-05-08 Thread Dave Kleikamp
On Tue, 2007-05-08 at 16:22 +0530, Amit K. Arora wrote: On Mon, May 07, 2007 at 10:24:37AM -0500, Dave Kleikamp wrote: On Mon, 2007-05-07 at 17:37 +0530, Amit K. Arora wrote: On Thu, May 03, 2007 at 09:31:33PM -0700, Andrew Morton wrote: So we don't implement fallocate on bitmap-based

[git pull] jfs update

2007-05-08 Thread Dave Kleikamp
/jfs/jfs_logmgr.c |7 --- fs/jfs/jfs_txnmgr.c |6 +++--- 9 files changed, 38 insertions(+), 9 deletions(-) through these ChangeSets: Commit: 05ec9e26be1f668ccba4ca54d9a4966c6208c611 Author: Dave Kleikamp [EMAIL PROTECTED] Sat, 05 May 2007 14:24:05 -0500

Re: [PATCH 4/5] ext4: fallocate support in ext4

2007-05-07 Thread Dave Kleikamp
On Mon, 2007-05-07 at 17:37 +0530, Amit K. Arora wrote: > On Thu, May 03, 2007 at 09:31:33PM -0700, Andrew Morton wrote: > > On Thu, 26 Apr 2007 23:43:32 +0530 "Amit K. Arora" <[EMAIL PROTECTED]> > > wrote: > > > +int ext4_fallocate(struct inode *inode, int mode, loff_t offset, loff_t > > >

<    4   5   6   7   8   9   10   11   >