Roland McGrath wrote:
+#ifndef arch_has_block_step
+/**
+ * arch_has_block_step - does this CPU support user-mode block-step?
+ *
+ * If this is defined, then there must be a function declaration or inline
+ * for user_enable_block_step(), and arch_has_single_step() must be defined
+ * too.
Roland McGrath wrote:
snip
+#ifndef arch_has_block_step
+/**
+ * arch_has_block_step - does this CPU support user-mode block-step?
+ *
+ * If this is defined, then there must be a function declaration or inline
+ * for user_enable_block_step(), and arch_has_single_step() must be defined
+ *
consider this request to move trace into the mm tree.
Regards
David Wilder
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at
this request to move trace into the mm tree.
Regards
David Wilder
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Andi Kleen wrote:
On Thu, Oct 04, 2007 at 12:19:35PM -0700, David Wilder wrote:
Andi Kleen wrote:
"David J. Wilder" <[EMAIL PROTECTED]> writes:
@@ -0,0 +1,160 @@
+Trace Setup and Control
+===
+In the kernel, the trace interface provides a simple mechani
Andi Kleen wrote:
"David J. Wilder" <[EMAIL PROTECTED]> writes:
@@ -0,0 +1,160 @@
+Trace Setup and Control
+===
+In the kernel, the trace interface provides a simple mechanism for
+starting and managing data channels (traces) to user space.
Wasn't relayfs supposed to do
Andi Kleen wrote:
David J. Wilder [EMAIL PROTECTED] writes:
@@ -0,0 +1,160 @@
+Trace Setup and Control
+===
+In the kernel, the trace interface provides a simple mechanism for
+starting and managing data channels (traces) to user space.
Wasn't relayfs supposed to do that
Andi Kleen wrote:
On Thu, Oct 04, 2007 at 12:19:35PM -0700, David Wilder wrote:
Andi Kleen wrote:
David J. Wilder [EMAIL PROTECTED] writes:
@@ -0,0 +1,160 @@
+Trace Setup and Control
+===
+In the kernel, the trace interface provides a simple mechanism for
+starting
Andrew-
Could you please add the trace patches to the merge list?
These patches have been very well reviewed on lkml. I believe they are
ready to be merged. The patches can be found here:
http://lkml.org/lkml/2007/10/2/236
http://lkml.org/lkml/2007/10/2/237
http://lkml.org/lkml/2007/10/2/238
Andrew-
Could you please add the trace patches to the merge list?
These patches have been very well reviewed on lkml. I believe they are
ready to be merged. The patches can be found here:
http://lkml.org/lkml/2007/10/2/236
http://lkml.org/lkml/2007/10/2/237
http://lkml.org/lkml/2007/10/2/238
Randy Dunlap wrote:
On Tue, 02 Oct 2007 09:33:25 -0700 David J. Wilder wrote:
Trace example - Adds the trace example to samples/
Signed-off-by: David Wilder <[EMAIL PROTECTED]>
---
samples/Kconfig|6 ++
samples/Makefile |1 +
samples/trace/Makefile
Randy Dunlap wrote:
On Tue, 02 Oct 2007 09:33:25 -0700 David J. Wilder wrote:
Trace example - Adds the trace example to samples/
Signed-off-by: David Wilder [EMAIL PROTECTED]
---
samples/Kconfig|6 ++
samples/Makefile |1 +
samples/trace/Makefile |4
e for the next round of submissions.
Mathieu
[patch 4/5] Linux Kernel Markers - Samples
http://lkml.org/lkml/2007/9/25/166
Signed-off-by: David Wilder <[EMAIL PROTECTED]>
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [
Randy Dunlap wrote:
On Wed, 26 Sep 2007 11:22:29 -0700 David J. Wilder wrote:
These patches provide a kernel tracing interface called "trace".
(update) Moved the sample code to the new samples\ subdir
The motivation for "trace" is to:
- Provide a simple set of tracing primitives that will
/157)
and create samples/Makefile or apply: [patch 4/5] Linux Kernel
Markers - Samples (http://lkml.org/lkml/2007/9/25/166)
Signed-off-by: David Wilder <[EMAIL PROTECTED]>
Looks good. Thanks.
Acked-by: Randy Dunlap <[EMAIL PROTECTED]>
Andrew, Mathieu is making changes to patch 3/
/157)
and create samples/Makefile or apply: [patch 4/5] Linux Kernel
Markers - Samples (http://lkml.org/lkml/2007/9/25/166)
Signed-off-by: David Wilder [EMAIL PROTECTED]
Looks good. Thanks.
Acked-by: Randy Dunlap [EMAIL PROTECTED]
Andrew, Mathieu is making changes to patch 3/5 referenced above
Randy Dunlap wrote:
On Wed, 26 Sep 2007 11:22:29 -0700 David J. Wilder wrote:
These patches provide a kernel tracing interface called trace.
(update) Moved the sample code to the new samples\ subdir
The motivation for trace is to:
- Provide a simple set of tracing primitives that will
.
Mathieu
[patch 4/5] Linux Kernel Markers - Samples
http://lkml.org/lkml/2007/9/25/166
Signed-off-by: David Wilder [EMAIL PROTECTED]
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http
Christoph Hellwig wrote:
On Mon, Sep 24, 2007 at 08:38:34AM -0700, David Wilder wrote:
NACK, don't put code into Documentation/. Put it into kernel as it's
actually useful kernel code.
Are you suggesting moving the example code into kernel? Or complaining
about example code
: this patch requires "[Patch 2/2] Relay reset consumed" is applied.
-
Trace - Provides tracing primitives
Signed-off-by: Tom Zanussi <[EMAIL PROTECTED]>
Signed-off-by: Martin Hunt <[EMAIL PROTECTED]>
Signed-off-by: David Wilder <[EMAIL PROTECTED]>
Christoph Hellwig wrote:
Your mailer wrapper the patch so I can't actually apply it to start
playing with the patch.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
Christoph Hellwig wrote:
Your mailer wrapper the patch so I can't actually apply it to start
playing with the patch.
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at
: this patch requires [Patch 2/2] Relay reset consumed is applied.
-start of patch
Trace - Provides tracing primitives
Signed-off-by: Tom Zanussi [EMAIL PROTECTED]
Signed-off-by: Martin Hunt [EMAIL PROTECTED]
Signed-off-by: David Wilder [EMAIL PROTECTED]
---
Documentation/trace
Christoph Hellwig wrote:
On Mon, Sep 24, 2007 at 08:38:34AM -0700, David Wilder wrote:
NACK, don't put code into Documentation/. Put it into kernel as it's
actually useful kernel code.
Are you suggesting moving the example code into kernel? Or complaining
about example code
Randy Dunlap wrote:
On Wed, 19 Sep 2007 17:20:18 +0100 Christoph Hellwig wrote:
On Wed, Sep 19, 2007 at 07:14:47AM -0700, David Wilder wrote:
I agree with you; however, this is in the example code in the
Documentation directory, It is not part of the trace code. The example
was just meant
Andi Kleen wrote:
"David J. Wilder" <[EMAIL PROTECTED]> writes:
Not having read the whole thing; just something I noticed.
Gut feeling is that you have too many knobs and options and
some overengineering though -- simplifying it would be a good thing.
+
+#define TRACE_PRINTF_TMPBUF_SIZE
Andi Kleen wrote:
David J. Wilder [EMAIL PROTECTED] writes:
Not having read the whole thing; just something I noticed.
Gut feeling is that you have too many knobs and options and
some overengineering though -- simplifying it would be a good thing.
+
+#define TRACE_PRINTF_TMPBUF_SIZE (1024)
Randy Dunlap wrote:
On Wed, 19 Sep 2007 17:20:18 +0100 Christoph Hellwig wrote:
On Wed, Sep 19, 2007 at 07:14:47AM -0700, David Wilder wrote:
I agree with you; however, this is in the example code in the
Documentation directory, It is not part of the trace code. The example
was just meant
Mathieu Desnoyers wrote:
* Andrew Morton ([EMAIL PROTECTED]) wrote:
On Tue, 18 Sep 2007 09:53:03 -0700 Vara Prasad <[EMAIL PROTECTED]> wrote:
This is part of the effort by the SystemTap team to move pieces of the
project that are generic to mainline.
Yeah. It seems to have been reviewed to
Andrew Morton wrote:
On Tue, 18 Sep 2007 09:53:03 -0700 Vara Prasad <[EMAIL PROTECTED]> wrote:
This is part of the effort by the SystemTap team to move pieces of the
project that are generic to mainline.
Yeah. It seems to have been reviewed to death. Is it ready to
be applied yet?
I am
Andrew Morton wrote:
On Thu, 13 Sep 2007 16:43:09 -0700
David Wilder <[EMAIL PROTECTED]> wrote:
These patches provide a kernel tracing interface called "trace".
The motivation for "trace" is to:
- Provide a simple set of tracing primitives that will utilize the h
Andrew Morton wrote:
On Thu, 13 Sep 2007 16:43:09 -0700
David Wilder [EMAIL PROTECTED] wrote:
These patches provide a kernel tracing interface called trace.
The motivation for trace is to:
- Provide a simple set of tracing primitives that will utilize the high-
performance and low-overhead
Andrew Morton wrote:
On Tue, 18 Sep 2007 09:53:03 -0700 Vara Prasad [EMAIL PROTECTED] wrote:
This is part of the effort by the SystemTap team to move pieces of the
project that are generic to mainline.
Yeah. It seems to have been reviewed to death. Is it ready to
be applied yet?
I am just
Mathieu Desnoyers wrote:
* Andrew Morton ([EMAIL PROTECTED]) wrote:
On Tue, 18 Sep 2007 09:53:03 -0700 Vara Prasad [EMAIL PROTECTED] wrote:
This is part of the effort by the SystemTap team to move pieces of the
project that are generic to mainline.
Yeah. It seems to have been reviewed to
Sam Ravnborg wrote:
Hi David.
A random comment to the code.
Several of the struct file_operations are not declared static as
they should be.
Btw. it looks good from a coding style point-of-view.
About the name what about ktrace??
Sam
Thanks for the comment. I sure don't want to
Andrew Morton wrote:
+/*
+ * Based on blktrace code, Copyright (C) 2006 Jens Axboe <[EMAIL PROTECTED]>
So can we migrate blktrace to using this?
Yes, a blktrace patch is comming.
+ int ret;
+
+ if (trace->flags & TRACE_DISABLE_STATE)
+ return -EINVAL;
+
Andrew Morton wrote:
+/*
+ * Based on blktrace code, Copyright (C) 2006 Jens Axboe [EMAIL PROTECTED]
So can we migrate blktrace to using this?
Yes, a blktrace patch is comming.
+ int ret;
+
+ if (trace-flags TRACE_DISABLE_STATE)
+ return -EINVAL;
+
Sam Ravnborg wrote:
Hi David.
A random comment to the code.
Several of the struct file_operations are not declared static as
they should be.
Btw. it looks good from a coding style point-of-view.
About the name what about ktrace??
Sam
Thanks for the comment. I sure don't want to
This patch allows relay channels to be reset i.e. unconsumed.
Basically allows a 'rewind' function for flight-recorder tracing.
Signed-off-by: Tom Zanussi <[EMAIL PROTECTED]>
Signed-off-by: David Wilder <[EMAIL PROTECTED]>
---
Documentation/filesystems/relay.txt | 11 ++
i
Trace - Provides tracing primitives
Tom Zanussi <[EMAIL PROTECTED]>
Martin Hunt <[EMAIL PROTECTED]>
David Wilder <[EMAIL PROTECTED]>
---
Documentation/trace.txt | 297
include/linux/trace.h | 99
lib/Kconfig |
Desnoyers. Changes include the addition of a mutex and synchronization
protecting trace state changes (using RCU) and the reduction of the
number of exports.
Patches are against 2.6.23-rc4-mm1
Required patches:
1/2 Trace code and documentation
2/2 Relay reset consumed (required for trace's "r
This patch allows relay channels to be reset i.e. unconsumed.
Basically allows a 'rewind' function for flight-recorder tracing.
Signed-off-by: Tom Zanussi [EMAIL PROTECTED]
Signed-off-by: David Wilder [EMAIL PROTECTED]
---
Documentation/filesystems/relay.txt | 11 ++
include/linux
of a mutex and synchronization
protecting trace state changes (using RCU) and the reduction of the
number of exports.
Patches are against 2.6.23-rc4-mm1
Required patches:
1/2 Trace code and documentation
2/2 Relay reset consumed (required for trace's rewind feature)
Signed-off-by: David Wilder [EMAIL
Trace - Provides tracing primitives
Tom Zanussi [EMAIL PROTECTED]
Martin Hunt [EMAIL PROTECTED]
David Wilder [EMAIL PROTECTED]
---
Documentation/trace.txt | 297
include/linux/trace.h | 99
lib/Kconfig | 10 +
lib/Makefile|2
Placing a kprobe on "bc" instruction (s390/s390x) can cause an oops.
The instruction length is encoded into the first two bits of the s390
instruction. Kprobe is incorrectly computing the instruction length.
The instruction length is used for determining what type of "fix-up" is
needed for
Placing a kprobe on bc instruction (s390/s390x) can cause an oops.
The instruction length is encoded into the first two bits of the s390
instruction. Kprobe is incorrectly computing the instruction length.
The instruction length is used for determining what type of fix-up is
needed for
I forgot to CC the list in my response to Alexey.
I plan to address Alexey's concerns in a couple of days (as soon as I
get past the OLS push).
Alexey Dobriyan wrote:
Can we get another user to justify this generalizing?
Systemtap has plans to use the GTSC also.
--
David Wilder
IBM
s)) {
- consumed = (produced / n_subbufs) * n_subbufs;
+ consumed = produced - n_subbufs + 1;
buf->subbufs_consumed = consumed;
+ buf->bytes_consumed = 0;
}
produced = (produced % n_subbufs) * subbuf_size + buf-
;
+ consumed = produced - n_subbufs + 1;
buf-subbufs_consumed = consumed;
+ buf-bytes_consumed = 0;
}
produced = (produced % n_subbufs) * subbuf_size + buf-offset;
--
David Wilder
IBM Linux Technology Center
Beaverton, Oregon, USA
[EMAIL
I forgot to CC the list in my response to Alexey.
I plan to address Alexey's concerns in a couple of days (as soon as I
get past the OLS push).
Alexey Dobriyan wrote:
Can we get another user to justify this generalizing?
Systemtap has plans to use the GTSC also.
--
David Wilder
IBM
--
David Wilder
IBM Linux Technology Center
Beaverton, Oregon, USA
[EMAIL PROTECTED]
(503)578-3789
This patch fixes a bug in the relay read interface causing the number
of consumed bytes to be set incorrectly.
Signed-off-by: Tom Zanussi <[EMAIL PROTECTED]>
Signed-off-by: David
--
David Wilder
IBM Linux Technology Center
Beaverton, Oregon, USA
[EMAIL PROTECTED]
(503)578-3789
This patch introduces the Generic Trace Setup and Control (GTSC) API.
In the kernel, GTSC provides a simple API for starting and managing
data channels to user space. GTSC builds on the relay
Patches to convert blktrace to the new GTSC API.
Two patches are included, the first is to the kernel portion of
blktrace. Apply the second patch is to the blktrace user code.
--
David Wilder
IBM Linux Technology Center
Beaverton, Oregon, USA
[EMAIL PROTECTED]
(503)578-3789
This patch
e the GTSC example work properly you will need to apply this
patch. This
patch is named relay-file-read-start-pos-fix.patch.
--
David Wilder
IBM Linux Technology Center
Beaverton, Oregon, USA
[EMAIL PROTECTED]
(503)578-3789
This patch provides the documentation for the Generic Trace
Setup a
example work properly you will need to apply this
patch. This
patch is named relay-file-read-start-pos-fix.patch.
--
David Wilder
IBM Linux Technology Center
Beaverton, Oregon, USA
[EMAIL PROTECTED]
(503)578-3789
This patch provides the documentation for the Generic Trace
Setup and Control (GTSC
--
David Wilder
IBM Linux Technology Center
Beaverton, Oregon, USA
[EMAIL PROTECTED]
(503)578-3789
This patch introduces the Generic Trace Setup and Control (GTSC) API.
In the kernel, GTSC provides a simple API for starting and managing
data channels to user space. GTSC builds on the relay
Patches to convert blktrace to the new GTSC API.
Two patches are included, the first is to the kernel portion of
blktrace. Apply the second patch is to the blktrace user code.
--
David Wilder
IBM Linux Technology Center
Beaverton, Oregon, USA
[EMAIL PROTECTED]
(503)578-3789
This patch
--
David Wilder
IBM Linux Technology Center
Beaverton, Oregon, USA
[EMAIL PROTECTED]
(503)578-3789
This patch fixes a bug in the relay read interface causing the number
of consumed bytes to be set incorrectly.
Signed-off-by: Tom Zanussi [EMAIL PROTECTED]
Signed-off-by: David Wilder [EMAIL
in the appropriate
bytes.
Signed-off-by: David Wilder <[EMAIL PROTECTED]>
diff --git a/arch/s390/kernel/kprobes.c b/arch/s390/kernel/kprobes.c
index 8af549e..993f353 100644
--- a/arch/s390/kernel/kprobes.c
+++ b/arch/s390/kernel/kprobes.c
@@ -167,7 +167,7 @@ static int __k
in the appropriate
bytes.
Signed-off-by: David Wilder [EMAIL PROTECTED]
diff --git a/arch/s390/kernel/kprobes.c b/arch/s390/kernel/kprobes.c
index 8af549e..993f353 100644
--- a/arch/s390/kernel/kprobes.c
+++ b/arch/s390/kernel/kprobes.c
@@ -167,7 +167,7 @@ static int __kprobes
60 matches
Mail list logo
