On Fri, Oct 24, 2014 at 5:01 AM, Gioh Kim wrote:
>
>
> 2014-10-24 오전 8:16, Gioh Kim 쓴 글:
>
>>
>>
>> 2014-10-24 오전 5:36, Devendra Naga 쓴 글:
>>>
>>> Hello,
>>>
>>> On Thu, Oct 23, 2014 at 6:22 PM, Gioh Kim wrote:
>&g
Hello,
On Thu, Oct 23, 2014 at 6:22 PM, Gioh Kim wrote:
> This patch shrink page-pool by page unit.
>
> Signed-off-by: Gioh Kim
> ---
> drivers/staging/android/ion/ion_page_pool.c |5 +++--
> drivers/staging/android/ion/ion_system_heap.c |7 +--
> 2 files changed, 8
Hello,
On Thu, Oct 23, 2014 at 6:22 PM, Gioh Kim gioh@lge.com wrote:
This patch shrink page-pool by page unit.
Signed-off-by: Gioh Kim gioh@lge.com
---
drivers/staging/android/ion/ion_page_pool.c |5 +++--
drivers/staging/android/ion/ion_system_heap.c |7 +--
2 files
On Fri, Oct 24, 2014 at 5:01 AM, Gioh Kim gioh@lge.com wrote:
2014-10-24 오전 8:16, Gioh Kim 쓴 글:
2014-10-24 오전 5:36, Devendra Naga 쓴 글:
Hello,
On Thu, Oct 23, 2014 at 6:22 PM, Gioh Kim gioh@lge.com wrote:
sys_heap = container_of(heap, struct ion_system_heap, heap
use devm_kzalloc and no need of free's at error path and unload
Signed-off-by: Devendra Naga
---
Please apply this after
changeid: 1fb4ec94e7e955a1e26bf81f2634e5be2fa5f1d5
[PATCH] uio: uio_sercos3: use module_pci_driver macro
sorry for sending as patch should be patch 2/2.
drivers/uio
use module_pci_driver macro and simplify the module init and exit code
Signed-off-by: Devendra Naga
---
drivers/uio/uio_sercos3.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/uio/uio_sercos3.c b/drivers/uio/uio_sercos3.c
index 81a10a5..5419832
use module_pci_driver macro and simplify the module init and exit code
Signed-off-by: Devendra Naga devendra.a...@gmail.com
---
drivers/uio/uio_sercos3.c | 14 +-
1 file changed, 1 insertion(+), 13 deletions(-)
diff --git a/drivers/uio/uio_sercos3.c b/drivers/uio/uio_sercos3.c
use devm_kzalloc and no need of free's at error path and unload
Signed-off-by: Devendra Naga devendra.a...@gmail.com
---
Please apply this after
changeid: 1fb4ec94e7e955a1e26bf81f2634e5be2fa5f1d5
[PATCH] uio: uio_sercos3: use module_pci_driver macro
sorry for sending as patch should be patch 2
use devm_kzalloc and remove the error path free'ing and unload free'ing
as the devm resource functions free them.
Signed-off-by: Devendra Naga
---
drivers/mfd/jz4740-adc.c | 23 +++
1 file changed, 7 insertions(+), 16 deletions(-)
diff --git a/drivers/mfd/jz4740-adc.c b
use devm_kzalloc and remove the error path free'ing and unload free'ing
as the devm resource functions free them.
Signed-off-by: Devendra Naga devendra.a...@gmail.com
---
drivers/mfd/jz4740-adc.c | 23 +++
1 file changed, 7 insertions(+), 16 deletions(-)
diff --git a/drivers
On Tue, Sep 4, 2012 at 11:17 AM, MyungJoo Ham wrote:
>> any comments ?
>>
>
> Sorry for replying late.
>
> It has been applied to the extcon-for-next tree at
> http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon-for-next
> , which will appear in hours.
Thanks!
--
To
On Tue, Sep 4, 2012 at 11:17 AM, MyungJoo Ham myungjoo@samsung.com wrote:
any comments ?
Sorry for replying late.
It has been applied to the extcon-for-next tree at
http://git.infradead.org/users/kmpark/linux-samsung/shortlog/refs/heads/extcon-for-next
, which will appear in hours.
any comments ?
On Wed, Aug 15, 2012 at 12:19 PM, Devendra Naga
wrote:
> actually we can do returns with error or success with out ret in this
> function,
> so remove the ret variable, and reduce a very little (4byte) space on stack
> of this function
>
> Signed-off
any comments ?
On Wed, Aug 15, 2012 at 12:19 PM, Devendra Naga
develkernel412...@gmail.com wrote:
actually we can do returns with error or success with out ret in this
function,
so remove the ret variable, and reduce a very little (4byte) space on stack
of this function
Signed-off
tifm_7xx1_init and tifm_7xx1_exit with module_init and module_exit calls
can be replaced with the module_pci_driver call, as they are similar
to what module_pci_driver does
Signed-off-by: Devendra Naga
---
drivers/misc/tifm_7xx1.c | 14 +-
1 file changed, 1 insertion(+), 13
tifm_7xx1_init and tifm_7xx1_exit with module_init and module_exit calls
can be replaced with the module_pci_driver call, as they are similar
to what module_pci_driver does
Signed-off-by: Devendra Naga devendra.a...@gmail.com
---
drivers/misc/tifm_7xx1.c | 14 +-
1 file changed, 1
" and "3.",
> and on error condition call lp8727_unregister_psy().
>
I think i need to learn more in order to touch this path. will give a try.
Thanks,
> Thanks,
>
>> On Sun, 2012-07-29 at 23:31 +0545, Devendra Naga wrote:
>> > actually the driver doe
usb
>>
>> > if (power_supply_register(pchg->dev, >batt))
>> > - goto err_psy;
>> > + goto err_psy_usb;
>>
>> Same here, why don't you use err_psy_batt
>
> Thanks, folks! It was easy to change so I applied the following:
&g
);
}
module_exit(drv_exit);
Signed-off-by: Devendra Naga
---
drivers/misc/bmp085-spi.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/misc/bmp085-spi.c b/drivers/misc/bmp085-spi.c
index 78aaff9..5e982af 100644
--- a/drivers/misc/bmp085-spi.c
+++ b/drivers
);
}
module_exit(drv_exit);
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/misc/bmp085-spi.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers/misc/bmp085-spi.c b/drivers/misc/bmp085-spi.c
index 78aaff9..5e982af 100644
--- a/drivers
))
- goto err_psy;
+ goto err_psy_usb;
Same here, why don't you use err_psy_batt
Thanks, folks! It was easy to change so I applied the following:
commit 6297b5e54b5511d4e72e8d5fc3b139650adc74d8
Author: Devendra Naga develkernel412...@gmail.com
Date: Sun Jul 29 23:31:55
this path. will give a try.
Thanks,
Thanks,
On Sun, 2012-07-29 at 23:31 +0545, Devendra Naga wrote:
actually the driver does a request_threaded_irq and after this it calls
lp8727_register_psy, and if it fails it doesn't free the irqs that it
registered to
Signed-off-by: Devendra Naga
: *** [drivers/thermal/rcar_thermal.o] Error 2
with gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)
Signed-off-by: Devendra Naga
---
drivers/thermal/rcar_thermal.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/rcar_thermal.c b/drivers/thermal/rcar_thermal.c
: *** [drivers/thermal/rcar_thermal.o] Error 2
with gcc version 4.6.3 (Ubuntu/Linaro 4.6.3-1ubuntu5)
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/thermal/rcar_thermal.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/thermal/rcar_thermal.c b
actually we can do returns with error or success with out ret in this function,
so remove the ret variable, and reduce a very little (4byte) space on stack of
this function
Signed-off-by: Devendra Naga
---
compile tested.
drivers/extcon/extcon-max8997.c | 6 ++
1 file changed, 2
actually we can do returns with error or success with out ret in this function,
so remove the ret variable, and reduce a very little (4byte) space on stack of
this function
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
compile tested.
drivers/extcon/extcon-max8997.c | 6
Sorry to ask this again,
But will anybody please ACK , NACK or comment on this patch?
Thanks,
Devendra.
On Sun, Jul 29, 2012 at 11:16 PM, Devendra Naga
wrote:
> actually the driver does a request_threaded_irq and after this it calls
> lp8727_register_psy, and if it fails it doesn'
Sorry to ask this again,
But will anybody please ACK , NACK or comment on this patch?
Thanks,
Devendra.
On Sun, Jul 29, 2012 at 11:16 PM, Devendra Naga
develkernel412...@gmail.com wrote:
actually the driver does a request_threaded_irq and after this it calls
lp8727_register_psy
On Mon, Aug 6, 2012 at 7:57 PM, Dan Carpenter wrote:
> On Sat, Aug 04, 2012 at 11:06:12PM +0545, Devendra Naga wrote:
>> as we do a strcpy(smdrv_ptr->fb_struct->fix->id, name), and the name here in
>> sm7xxx_probe is not having any assignment, and which leads to copying
On Mon, Aug 6, 2012 at 7:57 PM, Dan Carpenter dan.carpen...@oracle.com wrote:
On Sat, Aug 04, 2012 at 11:06:12PM +0545, Devendra Naga wrote:
as we do a strcpy(smdrv_ptr-fb_struct-fix-id, name), and the name here in
sm7xxx_probe is not having any assignment, and which leads to copying
we missed a unregiser_chrdev if the class_create and subsequent function calls
/ checks fail
Signed-off-by: Devendra Naga
---
drivers/staging/crystalhd/crystalhd_lnx.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/crystalhd/crystalhd_lnx.c
b/drivers
the rc assignment to PTR_ERR at fail cases of class_create and device_create
are missed out,
return proper error rather than returning -ENODEV.
Signed-off-by: Devendra Naga
---
drivers/staging/crystalhd/crystalhd_lnx.c |2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging
the rc assignment to PTR_ERR at fail cases of class_create and device_create
are missed out,
return proper error rather than returning -ENODEV.
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/staging/crystalhd/crystalhd_lnx.c |2 ++
1 file changed, 2 insertions(+)
diff
we missed a unregiser_chrdev if the class_create and subsequent function calls
/ checks fail
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/staging/crystalhd/crystalhd_lnx.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/crystalhd
this does kmalloc and followed by memset, calling kzalloc will actually
sets the allocated memory to zero, use kzalloc instead
Signed-off-by: Devendra Naga
---
drivers/staging/media/cxd2099/cxd2099.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/media
integer as
NULL pointer
Signed-off-by: Devendra Naga
---
drivers/staging/media/cxd2099/cxd2099.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/cxd2099/cxd2099.c
b/drivers/staging/media/cxd2099/cxd2099.c
index 1c04185..1678503 100644
igned-off-by: Devendra Naga
---
Changes since V1:
Fix a null deref when smtc_alloc_fbinfo fails, this was added by me in V1.
drivers/staging/sm7xxfb/sm7xxfb.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c
b/drivers/staging/sm7xxfb/
igned-off-by: Devendra Naga
---
Only compile tested
This patch is not tested using the hardware... if any one is having this
hardware, i request them to
please test this
drivers/staging/sm7xxfb/sm7xxfb.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/stagin
the following fixes:
* fix line over 80
* fix no space at start of line
* use tabs instead of spaces
* no need of opening & closing braces for single statement if block
Cc: Mikko Virkkilä
Cc: Lauri Hintsala
Cc: Riku Mettälä
Cc: Veli-Pekka Peltola
Signed-off-by: Devendra Naga
---
dri
the interfaceTag is actually initialised in for loop of this function
and its not needed to initialise it before for loop.
and also remove the comment that is obvious about this variable.
Cc: Mikko Virkkilä
Cc: Lauri Hintsala
Cc: Riku Mettälä
Cc: Veli-Pekka Peltola
Signed-off-by: Devendra
the following fixes:
* fix no space at the start of line
* line over 80 characters
* use tabs instead of spaces at starting of every line
Cc: Mikko Virkkilä
Cc: Lauri Hintsala
Cc: Riku Mettälä
Cc: Veli-Pekka Peltola
Signed-off-by: Devendra Naga
---
drivers/staging/csr/bh.c | 29
The following warnings and errors were fixed:
* fix no space at the start of a line
* fix line over 80 characters
* use tabs instead of spaces
Cc: Mikko Virkkilä
Cc: Lauri Hintsala
Cc: Riku Mettälä
Cc: Veli-Pekka Peltola
Signed-off-by: Devendra Naga
---
drivers/staging/csr/bh.c | 15
: Mikko Virkkilä
Cc: Lauri Hintsala
Cc: Riku Mettälä
Cc: Veli-Pekka Peltola
Signed-off-by: Devendra Naga
---
drivers/staging/csr/bh.c | 83 --
1 file changed, 43 insertions(+), 40 deletions(-)
diff --git a/drivers/staging/csr/bh.c b/drivers/staging
, unifi_warning,
unifi_error, and unifi_trace,
I think these can be implemented using dev_warn, dev_dbg, functions,
i mean we can remove these unifi_warning and unifi_error and unifi_trace
and use the dev_warn and dev_dbg.
Please correct me if i am wrong
Devendra Naga (5):
staging/csr: clean coding
, unifi_warning,
unifi_error, and unifi_trace,
I think these can be implemented using dev_warn, dev_dbg, functions,
i mean we can remove these unifi_warning and unifi_error and unifi_trace
and use the dev_warn and dev_dbg.
Please correct me if i am wrong
Devendra Naga (5):
staging/csr: clean coding
: Mikko Virkkilä mikko.virkk...@bluegiga.com
Cc: Lauri Hintsala lauri.hints...@bluegiga.com
Cc: Riku Mettälä riku.mett...@bluegiga.com
Cc: Veli-Pekka Peltola veli-pekka.pelt...@bluegiga.com
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/staging/csr/bh.c | 83
Peltola veli-pekka.pelt...@bluegiga.com
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/staging/csr/bh.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/drivers/staging/csr/bh.c b/drivers/staging/csr/bh.c
index 2b7c4c0..7a00aa8 100644
Peltola veli-pekka.pelt...@bluegiga.com
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/staging/csr/bh.c | 29 +++--
1 file changed, 15 insertions(+), 14 deletions(-)
diff --git a/drivers/staging/csr/bh.c b/drivers/staging/csr/bh.c
index 7a00aa8..2597e22
Mettälä riku.mett...@bluegiga.com
Cc: Veli-Pekka Peltola veli-pekka.pelt...@bluegiga.com
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/staging/csr/bh.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/csr/bh.c b/drivers/staging/csr/bh.c
index
...@bluegiga.com
Cc: Veli-Pekka Peltola veli-pekka.pelt...@bluegiga.com
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/staging/csr/bh.c | 44 +++-
1 file changed, 23 insertions(+), 21 deletions(-)
diff --git a/drivers/staging/csr/bh.c b
-by: Devendra Naga develkernel412...@gmail.com
---
Only compile tested
This patch is not tested using the hardware... if any one is having this
hardware, i request them to
please test this
drivers/staging/sm7xxfb/sm7xxfb.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git
-by: Devendra Naga develkernel412...@gmail.com
---
Changes since V1:
Fix a null deref when smtc_alloc_fbinfo fails, this was added by me in V1.
drivers/staging/sm7xxfb/sm7xxfb.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sm7xxfb/sm7xxfb.c
b/drivers
integer as
NULL pointer
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/staging/media/cxd2099/cxd2099.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/media/cxd2099/cxd2099.c
b/drivers/staging/media/cxd2099/cxd2099.c
index
this does kmalloc and followed by memset, calling kzalloc will actually
sets the allocated memory to zero, use kzalloc instead
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/staging/media/cxd2099/cxd2099.c |3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff
This driver does seems to do only platform_driver_register in the
init function and platform_driver_unregister in the exit function,
so replace all this code including the module_init and module_exit with
module_platform_driver macro...
Signed-off-by: Devendra Naga
---
drivers/rtc/rtc-at91sam9
This driver does seems to do only platform_driver_register in the
init function and platform_driver_unregister in the exit function,
so replace all this code including the module_init and module_exit with
module_platform_driver macro...
Signed-off-by: Devendra Naga develkernel412...@gmail.com
with devm_kzalloc there is no need of freeing at the errorpath
and also at unregister it.
Signed-off-by: Devendra Naga
---
drivers/power/ds2781_battery.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/power/ds2781_battery.c b/drivers/power
void __exit mymod_exit(void)
{
platform_driver_unregister(_operations);
}
module_init(mymod_init);
module_exit(mymod_exit);
can be replaced with
module_platform_driver(drv_operations)...
Signed-off-by: Devendra Naga
---
drivers/power/ds2781_battery.c | 14 +-
1 file
-ENOMEM
Signed-off-by: Devendra Naga
---
Changes since V2:
* fix the comments from the Ramakrishna (ramakrishna.pall...@intel.com)
quoting his comments:
> if (power_supply_register(pchg->dev, >usb))
> - goto err_psy;
> + goto err_psy_ac;
"er
-ENOMEM
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
Changes since V2:
* fix the comments from the Ramakrishna (ramakrishna.pall...@intel.com)
quoting his comments:
if (power_supply_register(pchg-dev, psy-usb))
- goto err_psy;
+ goto err_psy_ac
);
}
static void __exit mymod_exit(void)
{
platform_driver_unregister(drv_operations);
}
module_init(mymod_init);
module_exit(mymod_exit);
can be replaced with
module_platform_driver(drv_operations)...
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/power/ds2781_battery.c
with devm_kzalloc there is no need of freeing at the errorpath
and also at unregister it.
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/power/ds2781_battery.c | 13 -
1 file changed, 4 insertions(+), 9 deletions(-)
diff --git a/drivers/power/ds2781_battery.c
-ENOMEM
Signed-off-by: Devendra Naga
---
drivers/power/lp8727_charger.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/power/lp8727_charger.c b/drivers/power/lp8727_charger.c
index 699f0ef..401b66e 100644
--- a/drivers/power/lp8727_charger.c
+++ b/drivers
actually the driver does a request_threaded_irq and after this it calls
lp8727_register_psy, and if it fails it doesn't free the irqs that it
registered to
Signed-off-by: Devendra Naga
---
drivers/power/lp8727_charger.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git
this driver's pch_phub_pci_init, and pch_phub_pci_exit functions with
the module_init and module_exit calls can be replaced with
module_pci_driver
Signed-off-by: Devendra Naga
---
drivers/misc/pch_phub.c | 13 +
1 file changed, 1 insertion(+), 12 deletions(-)
diff --git a/drivers
sparse warns about using 0 as NULL pointer,
drivers/misc/pch_phub.c:702:44: warning: Using plain integer as NULL pointer
Signed-off-by: Devendra Naga
---
drivers/misc/pch_phub.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc/pch_phub.c b/drivers/misc
the pointers that are allocated with devm_kzalloc will be automatically freed,
at unload time.
Signed-off-by: Devendra Naga
---
drivers/pinctrl/pinctrl-sirf.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-sirf.c b/drivers/pinctrl/pinctrl-sirf.c
index 2aae8a8
the pointers that are allocated with devm_kzalloc will be automatically freed,
at unload time.
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/pinctrl/pinctrl-sirf.c |1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/pinctrl/pinctrl-sirf.c b/drivers/pinctrl
sparse warns about using 0 as NULL pointer,
drivers/misc/pch_phub.c:702:44: warning: Using plain integer as NULL pointer
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/misc/pch_phub.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/misc
this driver's pch_phub_pci_init, and pch_phub_pci_exit functions with
the module_init and module_exit calls can be replaced with
module_pci_driver
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/misc/pch_phub.c | 13 +
1 file changed, 1 insertion(+), 12
actually the driver does a request_threaded_irq and after this it calls
lp8727_register_psy, and if it fails it doesn't free the irqs that it
registered to
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/power/lp8727_charger.c |4 +++-
1 file changed, 3 insertions(+), 1
-ENOMEM
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/power/lp8727_charger.c | 12 +++-
1 file changed, 7 insertions(+), 5 deletions(-)
diff --git a/drivers/power/lp8727_charger.c b/drivers/power/lp8727_charger.c
index 699f0ef..401b66e 100644
--- a/drivers/power
in
this function)
drivers/thermal/thermal_sys.c:1216:3: note: each undeclared identifier is
reported only once for each function it appears in
link:
http://www.spinics.net/lists/linux-kernel-janitors/msg12174.html
use the indx instead.
Cc: Durgadoss R
Signed-off-by: Devendra Naga
---
This patch is build
in
this function)
drivers/thermal/thermal_sys.c:1216:3: note: each undeclared identifier is
reported only once for each function it appears in
link:
http://www.spinics.net/lists/linux-kernel-janitors/msg12174.html
use the indx instead.
Cc: Durgadoss R durgados...@intel.com
Signed-off-by: Devendra Naga
the code under _init and _exit does platform_driver_register and
platform_driver_unregister respectively only,
so its better to use the module_platform_driver than just replicating
the module_platform_driver's implementation
Signed-off-by: Devendra Naga
---
drivers/staging/tidspbridge/rmgr
the code which under _init and _exit does only the platform_driver_register
and platform_driver_unregister, and nothing else,
so its better to use the module_platform_driver macro rather duplicating
its implementation
Signed-off-by: Devendra Naga
---
drivers/staging/iio/iio_hwmon.c | 12
the allocated memory will be destroyed at the driver unload time,
automatically if driver uses the devm_ functions, so no need of
doing devm_kfree at the error path
Signed-off-by: Devendra Naga
---
drivers/pinctrl/pinctrl-u300.c |8 ++--
1 file changed, 2 insertions(+), 6 deletions
we do a check of firmware pointer against the NULL value before we give
it to the release_firmware.
as release_firmware is actually having a check against NULL, its not needed
here.
Signed-off-by: Devendra Naga
---
drivers/staging/csr/firmware.c |4 +---
1 file changed, 1 insertion(+), 3
the following coding style problems were fixed:
1. move function return type from top to the starting of the function
2. remove all the spaces at the start of a line and used tabs
Signed-off-by: Devendra Naga
---
drivers/staging/csr/sdio_mmc.c | 43 +++-
1
the following warnings were fixed:
1. removed all spaces before the start of a line and used tabs
2. removed the braces around the if as it encloses only a single statement
Signed-off-by: Devendra Naga
---
drivers/staging/csr/csr_time.c | 20 +---
1 file changed, 9 insertions
the following warnings were fixed:
1. removed all spaces before the start of a line and used tabs
2. removed the braces around the if as it encloses only a single statement
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/staging/csr/csr_time.c | 20 +---
1
the following coding style problems were fixed:
1. move function return type from top to the starting of the function
2. remove all the spaces at the start of a line and used tabs
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/staging/csr/sdio_mmc.c | 43
we do a check of firmware pointer against the NULL value before we give
it to the release_firmware.
as release_firmware is actually having a check against NULL, its not needed
here.
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/staging/csr/firmware.c |4 +---
1 file
the allocated memory will be destroyed at the driver unload time,
automatically if driver uses the devm_ functions, so no need of
doing devm_kfree at the error path
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/pinctrl/pinctrl-u300.c |8 ++--
1 file changed, 2
the code which under _init and _exit does only the platform_driver_register
and platform_driver_unregister, and nothing else,
so its better to use the module_platform_driver macro rather duplicating
its implementation
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers/staging
the code under _init and _exit does platform_driver_register and
platform_driver_unregister respectively only,
so its better to use the module_platform_driver than just replicating
the module_platform_driver's implementation
Signed-off-by: Devendra Naga develkernel412...@gmail.com
---
drivers
oops forgot to add LKML,
On Fri, Jul 20, 2012 at 10:45 PM, Devendra Naga
wrote:
>
> as the init and exit functions just do a platform_driver_register and
> platform_driver_unregister, and nothing else, so its better to
> use the module_platform_driver macro rather replicating its im
oops forgot to add LKML,
On Fri, Jul 20, 2012 at 10:45 PM, Devendra Naga
develkernel412...@gmail.com wrote:
as the init and exit functions just do a platform_driver_register and
platform_driver_unregister, and nothing else, so its better to
use the module_platform_driver macro rather
-by: Devendra Naga
---
drivers/staging/sbe-2t3e3/module.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sbe-2t3e3/module.c
b/drivers/staging/sbe-2t3e3/module.c
index cd778b3..1a1a9be 100644
--- a/drivers/staging/sbe-2t3e3/module.c
+++ b/drivers
-by: Devendra Naga devendra.a...@gmail.com
---
drivers/staging/sbe-2t3e3/module.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sbe-2t3e3/module.c
b/drivers/staging/sbe-2t3e3/module.c
index cd778b3..1a1a9be 100644
--- a/drivers/staging/sbe-2t3e3
freeing will trigger when driver unloads, so using devm_kfree is
not needed.
Signed-off-by: Devendra Naga
---
drivers/rtc/rtc-da9052.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/rtc/rtc-da9052.c b/drivers/rtc/rtc-da9052.c
index da6ab52..7807025 100644
devm_kzalloc doesn't need a matching devm_kfree, the freeing mechanism will
trigger
when driver unloads.
Signed-off-by: Devendra Naga
---
drivers/rtc/rtc-88pm80x.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-88pm80x.c b/drivers/rtc/rtc-88pm80x.c
At the probe we are assigning ret to return value of PTR_ERR right
after the rtc_register_driver, as we would have done it in the
if (IS_ERR(ptr)) check, since the function fails and goes inside
that case
Signed-off-by: Devendra Naga
---
drivers/rtc/rtc-88pm80x.c |2 +-
1 files changed, 1
At the probe we are assigning ret to return value of PTR_ERR right
after the rtc_register_driver, as we would have done it in the
if (IS_ERR(ptr)) check, since the function fails and goes inside
that case
Signed-off-by: Devendra Naga devendra.a...@gmail.com
---
drivers/rtc/rtc-88pm80x.c |2
devm_kzalloc doesn't need a matching devm_kfree, the freeing mechanism will
trigger
when driver unloads.
Signed-off-by: Devendra Naga devendra.a...@gmail.com
---
drivers/rtc/rtc-88pm80x.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/drivers/rtc/rtc-88pm80x.c b
freeing will trigger when driver unloads, so using devm_kfree is
not needed.
Signed-off-by: Devendra Naga devendra.a...@gmail.com
---
drivers/rtc/rtc-da9052.c |5 +
1 files changed, 1 insertions(+), 4 deletions(-)
diff --git a/drivers/rtc/rtc-da9052.c b/drivers/rtc/rtc-da9052.c
index
From: Devendra Naga
This patch modifies the kthread usage in the gdm_usb code, and tries to
use the kthread APIs better.
Actually the task_struct is taken as global as the limitation of priv.
we run the kthread before we allocate the priv.
did only compilation test, but not the insmod, check
From: Devendra Naga devendra.a...@gmail.com
This patch modifies the kthread usage in the gdm_usb code, and tries to
use the kthread APIs better.
Actually the task_struct is taken as global as the limitation of priv.
we run the kthread before we allocate the priv.
did only compilation test
instead calling kthread_create and another call to the
wake_up_process, so with this change the creation of rtsx_scan_thread
will be in consistency with the other control and poll threads.
Signed-off-by: Devendra Naga
---
Compile tested only,.. didn't done ps ax to check whether this thread runs
if the alloc_chrdev_region fail,
we are still returning -ENODEV, use ret and the error path will
take care of returning of the ret.
Signed-off-by: Devendra Naga
---
This patch is not compile tested because i dont have the
powerpc toolchain, i am trying hard to setit up one,
drivers/char
1 - 100 of 182 matches
Mail list logo
