Re: [PATCH] arm64: dts: qcom: sc7180:: modified qfprom CORR size as per RAW size

2021-02-17 Thread Doug Anderson
Hi, On Wed, Feb 17, 2021 at 9:27 AM Ravi Kumar Bokka wrote: > > modified QFPROM controller CORRECTED region size as per RAW region size > > Signed-off-by: Ravi Kumar Bokka > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Douglas

Re: [PATCH] kgdb: Remove kgdb_schedule_breakpoint()

2021-02-10 Thread Doug Anderson
Hi, On Wed, Feb 10, 2021 at 6:25 AM Daniel Thompson wrote: > > To the very best of my knowledge there has never been any in-tree > code that calls this function. It exists largely to support an > out-of-tree driver that provides kgdb-over-ethernet using the > netpoll API. > > kgdboe has been

Re: [PATCH 1/2] arm64: dts: qcom: sdm845: Move reserved-memory to devices

2021-02-09 Thread Doug Anderson
Hi, On Tue, Feb 9, 2021 at 8:09 AM Bjorn Andersson wrote: > > diff --git a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi > b/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi > index 216a74f0057c..2f44785d1af0 100644 > --- a/arch/arm64/boot/dts/qcom/sdm845-cheza.dtsi > +++

Re: [PATCH] drivers: nvmem: Fix voltage settings for QTI qfprom-efuse

2021-02-05 Thread Doug Anderson
Hi, On Fri, Feb 5, 2021 at 3:29 AM Ravi Kumar Bokka wrote: > > QFPROM controller hardware requires 1.8V min for fuse blowing. > So, this change sets the voltage to 1.8V, required to blow the fuse > for qfprom-efuse controller. > > To disable fuse blowing, we set the voltage to 0V since this may

Re: [PATCH v2] firmware_loader: Align .builtin_fw to 8

2021-02-05 Thread Doug Anderson
Hi, On Fri, Jan 22, 2021 at 11:04 AM Doug Anderson wrote: > > Hi, > > On Tue, Jan 5, 2021 at 11:20 AM Nick Desaulniers > wrote: > > > > On Tue, Jan 5, 2021 at 9:45 AM Doug Anderson wrote: > > > > > > Hi, > > > > > > On Mon, De

Re: [PATCH v2] kdb: Refactor env variables get/set code

2021-02-04 Thread Doug Anderson
Hi, On Thu, Feb 4, 2021 at 2:14 AM Sumit Garg wrote: > > Add two new kdb environment access methods as kdb_setenv() and > kdb_printenv() in order to abstract out environment access code > from kdb command functions. > > Also, replace (char *)0 with NULL as an initializer for environment >

Re: [PATCH v2 3/3] soc: qcom: rpmh: Conditionally check lockdep_assert_irqs_disabled()

2021-02-03 Thread Doug Anderson
Hi, On Sun, Jan 24, 2021 at 10:21 PM Maulik Shah wrote: > > @@ -136,6 +136,6 @@ void rpmh_rsc_invalidate(struct rsc_drv *drv); > int rpmh_rsc_mode_solver_set(struct rsc_drv *drv, bool enable); > > void rpmh_tx_done(const struct tcs_request *msg, int r); > -int rpmh_flush(struct rpmh_ctrlr

Re: [PATCH v2 2/3] soc: qcom: rpmh: Add rpmh_write_sleep_and_wake() function

2021-02-03 Thread Doug Anderson
Hi, On Sun, Jan 24, 2021 at 10:21 PM Maulik Shah wrote: > > Let RPMH clients call rpmh_write_sleep_and_wake() to immediately > write cached sleep and wake data to the TCSes. > > Signed-off-by: Maulik Shah > --- > (no changes since v1) > --- > drivers/soc/qcom/rpmh.c | 16 >

Re: [PATCH v2 1/3] drivers: qcom: rpmh: Disallow active requests in solver mode

2021-02-03 Thread Doug Anderson
Hi, On Sun, Jan 24, 2021 at 10:21 PM Maulik Shah wrote: > > From: Lina Iyer > > Controllers may be in 'solver' state, where they could be in autonomous > mode executing low power modes for their hardware and as such are not > available for sending active votes. Device driver may notify RPMH >

Re: [PATCH v3] kdb: kdb_support: Fix debugging information problem

2021-02-03 Thread Doug Anderson
Hi, On Wed, Feb 3, 2021 at 3:31 AM Stephen Zhang wrote: > > Doug Anderson 于2021年2月3日周三 上午1:40写道: >> >> kdb_dbg_printf(AR, "returns [...] (%s)\n", >>ret, symtab->sym_start, [...], symtab->sym_name); > > > Thank you for the detai

Re: [PATCH v3] kdb: kdb_support: Fix debugging information problem

2021-02-02 Thread Doug Anderson
Hi, On Tue, Feb 2, 2021 at 3:15 AM Stephen Zhang wrote: >> >> >> > @@ -147,11 +141,10 @@ int kdbnearsym(unsigned long addr, kdb_symtab_t >> > *symtab) >> > >> > if (symtab->mod_name == NULL) >> > symtab->mod_name = "kernel"; >> > - if (KDB_DEBUG(AR)) >> > -

Re: [PATCH v4 1/7] iommu: Move iotlb_sync_map out from __iommu_map

2021-02-01 Thread Doug Anderson
Hi, On Thu, Jan 7, 2021 at 4:31 AM Yong Wu wrote: > > @@ -2438,18 +2435,31 @@ static int __iommu_map(struct iommu_domain *domain, > unsigned long iova, > return ret; > } > > +static int _iommu_map(struct iommu_domain *domain, unsigned long iova, > + phys_addr_t

Re: [PATCH v3] kdb: kdb_support: Fix debugging information problem

2021-02-01 Thread Doug Anderson
Hi, On Sat, Jan 30, 2021 at 3:24 AM Stephen Zhang wrote: > > int kdbgetsymval(const char *symname, kdb_symtab_t *symtab) > { > - if (KDB_DEBUG(AR)) > - kdb_printf("kdbgetsymval: symname=%s, symtab=%px\n", symname, > - symtab); > +

Re: [PATCH v2] kdb: kdb_support: Fix debugging information problem

2021-01-29 Thread Doug Anderson
Hi, On Wed, Jan 27, 2021 at 11:50 PM Stephen Zhang wrote: > > int kdbgetsymval(const char *symname, kdb_symtab_t *symtab) > { > - if (KDB_DEBUG(AR)) > - kdb_printf("kdbgetsymval: symname=%s, symtab=%px\n", symname, > - symtab); > +

Re: [PATCH v2 3/5] drm/panel-simple: Retry if we timeout waiting for HPD

2021-01-27 Thread Doug Anderson
Hi, On Mon, Jan 25, 2021 at 12:28 PM Stephen Boyd wrote: > > > +/* > > + * Some panels simply don't always come up and need to be power cycled to > > + * work properly. We'll allow for a handful of retries. > > + */ > > +#define MAX_PANEL_PREPARE_TRIES5 > > Is this define used

Re: [PATCH v2] kdb: Simplify kdb commands registration

2021-01-25 Thread Doug Anderson
Hi, On Sun, Jan 24, 2021 at 11:06 PM Sumit Garg wrote: > > Simplify kdb commands registration via using linked list instead of > static array for commands storage. > > Signed-off-by: Sumit Garg > --- > > Changes in v2: > - Remove redundant NULL check for "cmd_name". > - Incorporate misc.

Re: [PATCH] kdb: Refactor env variables get/set code

2021-01-25 Thread Doug Anderson
Hi, On Mon, Jan 25, 2021 at 6:30 AM Sumit Garg wrote: > > diff --git a/kernel/debug/kdb/kdb_env.c b/kernel/debug/kdb/kdb_env.c > new file mode 100644 > index 000..33ab5e6 > --- /dev/null > +++ b/kernel/debug/kdb/kdb_env.c > @@ -0,0 +1,229 @@ > +// SPDX-License-Identifier: GPL-2.0 > +/* > + *

Re: [PATCH v3 1/2] power: supply: PCHG: Peripheral device charger

2021-01-22 Thread Doug Anderson
Hi, On Fri, Jan 22, 2021 at 2:07 PM Daisuke Nojiri wrote: > > +static int cros_ec_notify(struct notifier_block *nb, > + unsigned long queued_during_suspend, > + void *data) > +{ > + struct cros_ec_device *ec_dev = (struct cros_ec_device

Re: [PATCH] kdb: Simplify kdb commands registration

2021-01-22 Thread Doug Anderson
Hi, On Tue, Jan 19, 2021 at 2:50 AM Sumit Garg wrote: > > Simplify kdb commands registration via using linked list instead of > static array for commands storage. > > Signed-off-by: Sumit Garg > --- > kernel/debug/kdb/kdb_main.c| 78 > ++ >

Re: [PATCH v2] firmware_loader: Align .builtin_fw to 8

2021-01-22 Thread Doug Anderson
Hi, On Tue, Jan 5, 2021 at 11:20 AM Nick Desaulniers wrote: > > On Tue, Jan 5, 2021 at 9:45 AM Doug Anderson wrote: > > > > Hi, > > > > On Mon, Dec 7, 2020 at 9:49 PM Fangrui Song wrote: > > > > > > arm64 references the start address of .b

Re: [PATCH v3] kdb: Make memory allocations more robust

2021-01-22 Thread Doug Anderson
Hi, On Fri, Jan 22, 2021 at 3:06 AM Sumit Garg wrote: > > Currently kdb uses in_interrupt() to determine whether its library > code has been called from the kgdb trap handler or from a saner calling > context such as driver init. This approach is broken because > in_interrupt() alone isn't able

Re: [PATCH] soc: qcom: socinfo: Fix an off by one in qcom_show_pmic_model()

2021-01-20 Thread Doug Anderson
Hi, On Wed, Jan 20, 2021 at 1:58 AM Dan Carpenter wrote: > > These need to be < ARRAY_SIZE() instead of <= ARRAY_SIZE() to prevent > accessing one element beyond the end of the array. > > Fixes: e9247e2ce577 ("soc: qcom: socinfo: fix printing of pmic_model") > Signed-off-by: Dan Carpenter > ---

Re: [PATCH v5 4/4] pinctrl: qcom: Don't clear pending interrupts when enabling

2021-01-15 Thread Doug Anderson
Hi, On Fri, Jan 8, 2021 at 4:36 PM Linus Walleij wrote: > > Hi Doug, > > this is an impressive patch. > > We definitely need to touch base with Bjorn on this, preferably also > Sboyd. > > On Fri, Jan 8, 2021 at 6:35 PM Douglas Anderson wrote: > > > Fixes: 4b7618fdc7e6 ("pinctrl: qcom: Add

Re: [PATCH] soc: qcom: socinfo: Don't print anything if nothing found

2021-01-15 Thread Doug Anderson
Hi, On Fri, Jan 15, 2021 at 12:39 PM Stephen Boyd wrote: > > Let's skip printing anything if there's nothing to see. This makes it so > the file length is 0 instead of 1, for the newline, and helps scripts > figure out if there's anything to see in these files. > > Cc: Sai Prakash Ranjan > Cc:

Re: [PATCH v2 4/5] dt-bindings: dt-bindings: display: simple: Add N116BCA-EA1

2021-01-15 Thread Doug Anderson
Hi, On Fri, Jan 15, 2021 at 2:44 PM Douglas Anderson wrote: > > Another simple eDP panel. > > Signed-off-by: Douglas Anderson > --- > > Changes in v2: > - ("dt-bindings: dt-bindings: display: simple: Add N116BCA-EA1") new for v2. > > .../devicetree/bindings/display/panel/panel-simple.yaml

Re: [PATCH v8 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p

2021-01-15 Thread Doug Anderson
Hi, On Fri, Jan 15, 2021 at 6:58 AM Benjamin Tissoires wrote: > > > Thanks, but don't spend too much time on it, unless something really > > jumps out. I'll debug that tomorrow. It's much easier with an actual > > device than by just looking at the code. > > > > Well, that's weird. Now suspend

Re: [PATCH v5 4/4] pinctrl: qcom: Don't clear pending interrupts when enabling

2021-01-14 Thread Doug Anderson
Hi, On Wed, Jan 13, 2021 at 11:14 PM Stephen Boyd wrote: > > > @@ -195,6 +201,20 @@ static int msm_pinmux_set_mux(struct pinctrl_dev > > *pctldev, > > if (WARN_ON(i == g->nfuncs)) > > return -EINVAL; > > > > + /* > > +* If an GPIO interrupt is setup on this

Re: [PATCH v5 4/4] pinctrl: qcom: Don't clear pending interrupts when enabling

2021-01-14 Thread Doug Anderson
Hi, On Thu, Jan 14, 2021 at 9:15 AM Bjorn Andersson wrote: > > > > @@ -195,6 +201,20 @@ static int msm_pinmux_set_mux(struct pinctrl_dev > > > *pctldev, > > > if (WARN_ON(i == g->nfuncs)) > > > return -EINVAL; > > > > > > + /* > > > +* If an GPIO interrupt

Re: [PATCH 0/3] usb: dwc2: Fixes and improvements

2021-01-13 Thread Doug Anderson
Hi, On Wed, Jan 13, 2021 at 3:21 AM Nicolas Saenz Julienne wrote: > > I'm picking up this series by Guenter Roeck as he stated he has no time > for it ATM. It was found to solve some unaligned DMA access issues on > Raspberry Pi 3. You can find the original discussion here: >

Re: [PATCH v8 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p

2021-01-13 Thread Doug Anderson
Hi, On Wed, Jan 13, 2021 at 7:09 AM Benjamin Tissoires wrote: > > > I wanted to apply the series yesterday, but for these kinds of changes > > I like giving it a spin on actual hardware. Turns out that my XPS-13 > > can not boot to v5.11-rc2, which makes testing the new branch slightly > > more

Re: [PATCH 4/7] spi: spi-geni-qcom: Add support for GPI dma

2021-01-12 Thread Doug Anderson
Hi, On Mon, Jan 11, 2021 at 7:17 AM Vinod Koul wrote: > > We can use GPI DMA for devices where it is enabled by firmware. Add > support for this mode > > Signed-off-by: Vinod Koul > --- > drivers/spi/spi-geni-qcom.c | 395 +++- > 1 file changed, 384

Re: [PATCH 0/7] Add and enable GPI DMA users

2021-01-12 Thread Doug Anderson
Hi, On Mon, Jan 11, 2021 at 7:17 AM Vinod Koul wrote: > > Hello, > > This series add the GPI DMA in qcom geni spi and i2c drivers. For this we > first need to move GENI_IF_DISABLE_RO and struct geni_wrapper to common > headers and then add support for gpi dma in geni driver. > > Then we add spi

Re: [PATCH 3/7] soc: qcom: geni: Add support for gpi dma

2021-01-12 Thread Doug Anderson
Hi, On Mon, Jan 11, 2021 at 7:17 AM Vinod Koul wrote: > > +static int geni_se_select_gpi_mode(struct geni_se *se) > +{ > + unsigned int geni_dma_mode = 0; > + unsigned int gpi_event_en = 0; > + unsigned int common_geni_m_irq_en = 0; > + unsigned int common_geni_s_irq_en =

Re: [PATCH] soc: qcom: socinfo: Open read access to all for debugfs

2021-01-12 Thread Doug Anderson
Hi, On Mon, Jan 11, 2021 at 6:04 PM Stephen Boyd wrote: > > Quoting Doug Anderson (2021-01-05 15:06:35) > > Hi, > > > > On Tue, Dec 15, 2020 at 11:19 PM Stephen Boyd wrote: > > > > > > There doesn't seem to be any reason to limit this to only root u

Re: [PATCH v2] spi: spi-qcom-qspi: Use irq trigger flags from firmware

2021-01-12 Thread Doug Anderson
Hi, On Mon, Jan 11, 2021 at 4:13 PM Stephen Boyd wrote: > > We don't need to force this to be trigger high here, as the firmware > properly configures the irq flags already. Drop it to save a line. > > Cc: Douglas Anderson > Cc: Rajendra Nayak > Cc: Mukesh Kumar Savaliya > Cc: Akash Asthana

Re: [PATCH] arm64: dts: qcom: Clean up sc7180-trogdor voltage rails

2021-01-11 Thread Doug Anderson
Hi Bjorn, On Mon, Dec 7, 2020 at 2:33 PM Douglas Anderson wrote: > > For a bunch of rails we really don't do anything with them in Linux. > These are things like modem voltage rails that the modem manages these > itself and core rails (like IO rails) that are setup to just > automagically do the

Re: [PATCH 7/7] arm64: dts: qcom: sdm845: enable dma for spi

2021-01-11 Thread Doug Anderson
Hi, On Mon, Jan 11, 2021 at 7:18 AM Vinod Koul wrote: > > @@ -2622,6 +2626,13 @@ pinmux { >"gpio2", "gpio3"; > function = "qup0"; > }; > + > +

Re: [PATCH] drm/panel: panel-simple: add bus-format and connector-type to Innolux n116bge

2021-01-11 Thread Doug Anderson
Hi, On Sat, Jan 9, 2021 at 5:10 AM Heiko Stuebner wrote: > > From: Heiko Stuebner > > The Innolux n116bge panel has an eDP connector and 3*6 bits bus format. > > Signed-off-by: Heiko Stuebner > --- > drivers/gpu/drm/panel/panel-simple.c | 2 ++ > 1 file changed, 2 insertions(+) This looks

Re: [PATCH] arm64: dts: qcom: sc7180: Add labels for cpuN-thermal nodes

2021-01-08 Thread Doug Anderson
Hi, On Fri, Jan 8, 2021 at 2:17 PM Matthias Kaehlcke wrote: > > Add labels to the cpuN-thermal nodes to allow board files to use > a phandle instead replicating the node hierarchy when adjusting > certain properties. > > Due to the 'sustainable-power' property CPU thermal zones are > more likely

Re: [PATCH v5 1/2] mmc: sdhci-msm: Warn about overclocking SD/MMC

2021-01-08 Thread Doug Anderson
Ulf, On Mon, Dec 14, 2020 at 9:23 AM Douglas Anderson wrote: > > As talked about in commit 5e4b7e82d497 ("clk: qcom: gcc-sdm845: Use > floor ops for sdcc clks"), most clocks handled by the Qualcomm clock > drivers are rounded _up_ by default instead of down. We should make > sure SD/MMC clocks

Re: [PATCH v4 3/4] pinctrl: qcom: Don't clear pending interrupts when enabling

2021-01-08 Thread Doug Anderson
Hi, On Mon, Dec 21, 2020 at 8:01 AM Maulik Shah wrote: > > Hi Doug, > > On 12/12/2020 3:45 AM, Douglas Anderson wrote: > > In Linux, if a driver does disable_irq() and later does enable_irq() > > on its interrupt, I believe it's expecting these properties: > > * If an interrupt was pending when

Re: [PATCH] fs: process fput task_work with TWA_SIGNAL

2021-01-07 Thread Doug Anderson
Hi, On Tue, Jan 5, 2021 at 10:30 AM Jens Axboe wrote: > > Song reported a boot regression in a kvm image with 5.11-rc, and bisected > it down to the below patch. Debugging this issue, turns out that the boot > stalled when a task is waiting on a pipe being released. As we no longer > run

Re: [PATCH v3] soc: qcom: rpmh: Remove serialization of TCS commands

2021-01-07 Thread Doug Anderson
Hi, On Thu, Jan 7, 2021 at 12:39 AM Maulik Shah wrote: > > From: Lina Iyer > > Requests sent to RPMH can be sent as fire-n-forget or response required, > with the latter ensuring the command has been completed by the hardware > accelerator. Commands in a request with tcs_cmd::wait set, would

Re: [PATCH] Input: cros_ec_keyb: Add support for a front proximity switch

2021-01-07 Thread Doug Anderson
Hi, On Wed, Jan 6, 2021 at 6:22 PM Dmitry Torokhov wrote: > > Hi Doug, Stephen, > > On Wed, Jan 06, 2021 at 05:16:10PM -0800, Doug Anderson wrote: > > Hi, > > > > On Fri, Dec 4, 2020 at 4:48 PM Stephen Boyd wrote: > > > > > > Some c

Re: [PATCH] Input: cros_ec_keyb: Add support for a front proximity switch

2021-01-06 Thread Doug Anderson
Hi, On Fri, Dec 4, 2020 at 4:48 PM Stephen Boyd wrote: > > Some cros ECs support a front proximity MKBP event via > 'EC_MKBP_FRONT_PROXIMITY'. Map this to the 'SW_FRONT_PROXIMITY' input > event code so it can be reported up to userspace. > > Cc: Dmitry Torokhov > Cc: Benson Leung > Cc: Guenter

Re: [PATCH v8 4/4] HID: i2c-hid: Introduce goodix-i2c-hid using i2c-hid core

2021-01-06 Thread Doug Anderson
Hi, On Fri, Dec 11, 2020 at 2:25 PM Douglas Anderson wrote: > > +static const struct goodix_i2c_hid_timing_data goodix_gt7375p_timing_data = { > + .post_power_delay_ms = 10, > + .post_gpio_reset_delay_ms = 120, As I've been going through my holiday email I found that Goodix has

Re: [PATCH v8 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p

2021-01-05 Thread Doug Anderson
Benjamin, On Fri, Dec 11, 2020 at 2:24 PM Douglas Anderson wrote: > > The goal of this series is to support the Goodix GT7375P touchscreen. > This touchscreen is special because it has power sequencing > requirements that necessitate driving a reset GPIO. > > To do this, we totally rejigger the

Re: [PATCH] soc: qcom: socinfo: Open read access to all for debugfs

2021-01-05 Thread Doug Anderson
Hi, On Tue, Dec 15, 2020 at 11:19 PM Stephen Boyd wrote: > > There doesn't seem to be any reason to limit this to only root user > readable. Let's make it readable by all so that random programs can > read the debugfs files in here instead of just root. The information is > just that,

Re: [PATCH v2] crypto: Fix divide error in do_xor_speed()

2021-01-05 Thread Doug Anderson
Hi, On Wed, Dec 30, 2020 at 1:34 PM Kirill Tkhai wrote: > > crypto: Fix divide error in do_xor_speed() > > From: Kirill Tkhai > > Latest (but not only latest) linux-next panics with divide > error on my QEMU setup. > > The patch at the bottom of this message fixes the problem. > > xor:

Re: [PATCH v2] firmware_loader: Align .builtin_fw to 8

2021-01-05 Thread Doug Anderson
Hi, On Mon, Dec 7, 2020 at 9:49 PM Fangrui Song wrote: > > arm64 references the start address of .builtin_fw (__start_builtin_fw) > with a pair of R_AARCH64_ADR_PREL_PG_HI21/R_AARCH64_LDST64_ABS_LO12_NC > relocations. The compiler is allowed to emit the > R_AARCH64_LDST64_ABS_LO12_NC relocation

Re: [PATCH v2 2/4] spi: spi-geni-qcom: Fail new xfers if xfer/cancel/abort pending

2020-12-17 Thread Doug Anderson
Hi, On Wed, Dec 16, 2020 at 8:21 PM Stephen Boyd wrote: > > Quoting Douglas Anderson (2020-12-16 14:41:50) > > If we got a timeout when trying to send an abort command then it means > > that we just got 3 timeouts in a row: > > > > 1. The original timeout that caused handle_fifo_timeout() to be

Re: [PATCH v2 3/4] spi: spi-geni-qcom: Don't try to set CS if an xfer is pending

2020-12-17 Thread Doug Anderson
Hi, On Wed, Dec 16, 2020 at 8:29 PM Stephen Boyd wrote: > > > The SPI core in general assumes that setting chip select is a simple > > operation that doesn't fail. Yet another reason to just reconfigure > > the chip select line as GPIOs. > > BTW, we could peek at the irq bit for the CS change

Re: [PATCH v2 3/4] spi: spi-geni-qcom: Don't try to set CS if an xfer is pending

2020-12-17 Thread Doug Anderson
Hi, On Wed, Dec 16, 2020 at 8:25 PM Stephen Boyd wrote: > > Quoting Douglas Anderson (2020-12-16 14:41:51) > > If we get a timeout sending then this happens: > > * spi_transfer_wait() will get a timeout. > > * We'll set the chip select > > * We'll call handle_err() => handle_fifo_timeout(). > >

Re: [PATCH 1/2] spi: spi-geni-qcom: Fix geni_spi_isr() NULL dereference in timeout case

2020-12-16 Thread Doug Anderson
Hi, On Mon, Dec 14, 2020 at 6:29 PM Stephen Boyd wrote: > > Here's a shortened version: > > CPU0 CPU1 > > setup_fifo_xfer() > geni_se_setup_m_cmd() >

Re: [PATCH 2/2] spi: spi-geni-qcom: Really ensure the previous xfer is done before new one

2020-12-16 Thread Doug Anderson
Hi, On Tue, Dec 15, 2020 at 5:18 PM Stephen Boyd wrote: > > Quoting Doug Anderson (2020-12-15 15:34:59) > > On Tue, Dec 15, 2020 at 2:25 PM Stephen Boyd wrote: > > > > > > Quoting Doug Anderson (2020-12-15 09:25:51) > > > > In general when we're sta

Re: [PATCH 2/2] spi: spi-geni-qcom: Really ensure the previous xfer is done before new one

2020-12-15 Thread Doug Anderson
Hi, On Tue, Dec 15, 2020 at 2:25 PM Stephen Boyd wrote: > > Quoting Doug Anderson (2020-12-15 09:25:51) > > On Mon, Dec 14, 2020 at 6:57 PM Stephen Boyd wrote: > > > > > > Quoting Douglas Anderson (2020-12-14 16:30:19) > > > > diff --git a/drivers/

Re: [PATCH 2/2] spi: spi-geni-qcom: Really ensure the previous xfer is done before new one

2020-12-15 Thread Doug Anderson
Hi, On Mon, Dec 14, 2020 at 6:57 PM Stephen Boyd wrote: > > Quoting Douglas Anderson (2020-12-14 16:30:19) > > diff --git a/drivers/spi/spi-geni-qcom.c b/drivers/spi/spi-geni-qcom.c > > index 6f736e94e9f4..5ef2e9f38ac9 100644 > > --- a/drivers/spi/spi-geni-qcom.c > > +++

Re: [PATCH] arm64: dts: qcom: sc7180: Drop pinconf on dp_hot_plug_det

2020-12-15 Thread Doug Anderson
Hi, On Mon, Dec 14, 2020 at 6:00 PM Stephen Boyd wrote: > > We shouldn't put any pinconf here in case someone decides to invert this > HPD signal or remove an external pull-down. It's better to leave that to > the board pinconf nodes, so drop it here. > > Reported-by: Douglas Anderson > Cc:

Re: [PATCH] arm64: dts: qcom: sc7180: Enable passive polling for cpu thermal zones

2020-12-15 Thread Doug Anderson
Hi, On Tue, Dec 15, 2020 at 1:39 AM Manaf Meethalavalappu Pallikunhi wrote: > > Enable passive polling delay for cpu thermal zone for sc7180. It > enables periodic thermal zone re-evaluation on post first trip > temperature violation. > > Signed-off-by: Manaf Meethalavalappu Pallikunhi > --- >

Re: [PATCH] spi: spi-geni-qcom: Fix NULL pointer access in geni_spi_isr

2020-12-14 Thread Doug Anderson
Hi, On Fri, Dec 11, 2020 at 5:32 PM Stephen Boyd wrote: > > Quoting Doug Anderson (2020-12-10 17:51:53) > > Hi, > > > > On Thu, Dec 10, 2020 at 5:39 PM Stephen Boyd wrote: > > > > > > Quoting Doug Anderson (2020-12-10 17:30:17) > >

Re: [PATCH v4 2/2] mmc: sdhci-msm: Actually set the actual clock

2020-12-14 Thread Doug Anderson
Hi, On Mon, Dec 14, 2020 at 4:44 AM Veerabhadrarao Badiganti wrote: > > > On 12/11/2020 10:42 PM, Douglas Anderson wrote: > > The MSM SDHCI driver always set the "actual_clock" field to 0. It had > > a comment about it not being needed because we weren't using the > > standard SDHCI divider

Re: [PATCH] spi: spi-qcom-qspi: Use irq trigger flags from firmware

2020-12-14 Thread Doug Anderson
Hi, On Sat, Dec 12, 2020 at 9:29 PM Stephen Boyd wrote: > > We don't need to force this to be trigger high here, as the firmware > properly configures the irq flags already. Drop it to save a line. > > Cc: Douglas Anderson > Cc: Rajendra Nayak > Cc: Mukesh Kumar Savaliya > Cc: Akash Asthana

Re: [PATCH v3 3/3] pinctrl: qcom: Clear possible pending irq when remuxing GPIOs

2020-12-11 Thread Doug Anderson
Hi, On Thu, Dec 10, 2020 at 1:56 PM Stephen Boyd wrote: > > Quoting Douglas Anderson (2020-12-09 16:41:03) > > Conceptually, we can envision the input on Qualcomm SoCs to pass > > through a bunch of blocks between coming into the chip and becoming a > > GPIO interrupt. From guessing and running

Re: [PATCH v2 3/3] pinctrl: qcom: Clear possible pending irq when remuxing GPIOs

2020-12-11 Thread Doug Anderson
Hi, On Thu, Dec 10, 2020 at 11:07 PM Maulik Shah wrote: > > I have slightly modified your test case (see at > https://crrev.com/c/2584729) which is as per what i used in my testing. > > Here is what i am doing, setting GPIO to a fixed function (function 2 here) > Note that function 0 is the GPIO

Re: [PATCH v3] mmc: sdhci-msm: Warn about overclocking SD/MMC

2020-12-11 Thread Doug Anderson
Hi, On Thu, Dec 10, 2020 at 9:56 PM Adrian Hunter wrote: > > On 10/12/20 11:27 pm, Douglas Anderson wrote: > > As talked about in commit 5e4b7e82d497 ("clk: qcom: gcc-sdm845: Use > > floor ops for sdcc clks"), most clocks handled by the Qualcomm clock > > drivers are rounded _up_ by default

Re: [PATCH] spi: spi-geni-qcom: Fix NULL pointer access in geni_spi_isr

2020-12-10 Thread Doug Anderson
Hi, On Thu, Dec 10, 2020 at 5:39 PM Stephen Boyd wrote: > > Quoting Doug Anderson (2020-12-10 17:30:17) > > On Thu, Dec 10, 2020 at 5:21 PM Stephen Boyd wrote: > > > > > > Yeah and so if it comes way later because it timed out then what's the > > > p

Re: [PATCH] spi: spi-geni-qcom: Fix NULL pointer access in geni_spi_isr

2020-12-10 Thread Doug Anderson
Hi, On Thu, Dec 10, 2020 at 5:21 PM Stephen Boyd wrote: > > > > I guess I'm not convinced that the hardware is so bad that it cancels > > > and aborts the sequencer, raises an irq for that, and then raises an irq > > > for the earlier rx/tx that the sequencer canceled out. Is that > > >

Re: [PATCH] spi: spi-geni-qcom: Fix NULL pointer access in geni_spi_isr

2020-12-10 Thread Doug Anderson
Hi, On Thu, Dec 10, 2020 at 4:51 PM Stephen Boyd wrote: > > Quoting Doug Anderson (2020-12-10 15:50:04) > > Hi, > > > > On Thu, Dec 10, 2020 at 3:32 PM Stephen Boyd wrote: > > > > > > Quoting Doug Anderson (2020-12-10 15:07:39) > > > > Hi, &

Re: [PATCH] spi: spi-geni-qcom: Fix NULL pointer access in geni_spi_isr

2020-12-10 Thread Doug Anderson
Hi, On Thu, Dec 10, 2020 at 3:32 PM Stephen Boyd wrote: > > Quoting Doug Anderson (2020-12-10 15:07:39) > > Hi, > > > > On Thu, Dec 10, 2020 at 2:58 PM Stephen Boyd wrote: > > > right? It will only ensure that other irq handlers have completed, which > > &

Re: [PATCH v2] mmc: sdhci-msm: Warn about overclocking SD/MMC

2020-12-10 Thread Doug Anderson
Hi, On Thu, Dec 10, 2020 at 1:19 PM Douglas Anderson wrote: > > + pr_warn("%s: Card appears overclocked; req %u Hz, actual %d > Hz\n", > + mmc_hostname(host->mmc), clock, achieved_rate); Ugh, multitasking too heavily. Clearly this is wrong format codes...

Re: [PATCH] spi: spi-geni-qcom: Fix NULL pointer access in geni_spi_isr

2020-12-10 Thread Doug Anderson
Hi, On Thu, Dec 10, 2020 at 2:58 PM Stephen Boyd wrote: > > Quoting Doug Anderson (2020-12-10 09:14:15) > > > > This is my untested belief of what's happening > > > > CPU0

Re: [PATCH] mmc: sdhci-msm: Warn about overclocking SD/MMC

2020-12-10 Thread Doug Anderson
Hi, On Thu, Dec 10, 2020 at 1:03 PM Stephen Boyd wrote: > > Quoting Douglas Anderson (2020-12-10 12:57:25) > > diff --git a/drivers/mmc/host/sdhci-msm.c b/drivers/mmc/host/sdhci-msm.c > > index 3451eb325513..dd41f6a4dbfb 100644 > > --- a/drivers/mmc/host/sdhci-msm.c > > +++

Re: [PATCH 1/2] clk: qcom: gcc-sc7180: Use floor ops for sdcc clks

2020-12-10 Thread Doug Anderson
Hi, On Thu, Dec 10, 2020 at 12:27 PM Stephen Boyd wrote: > > Quoting Douglas Anderson (2020-12-10 10:22:38) > > I would repeat the same commit message that was in commit 5e4b7e82d497 > > ("clk: qcom: gcc-sdm845: Use floor ops for sdcc clks") but it seems > > silly to do so when you could just go

Re: [PATCH] spi: spi-geni-qcom: Fix NULL pointer access in geni_spi_isr

2020-12-10 Thread Doug Anderson
Hi, On Wed, Dec 9, 2020 at 7:17 PM Stephen Boyd wrote: > > Quoting Doug Anderson (2020-12-03 08:40:46) > > > I would guess that if "mas->cur_xfer" is NULL then > > geni_spi_handle_rx() should read all data in the FIFO and throw it > >

Re: [PATCH v2 3/3] pinctrl: qcom: Clear possible pending irq when remuxing GPIOs

2020-12-09 Thread Doug Anderson
Hi, On Tue, Dec 8, 2020 at 9:54 PM Maulik Shah wrote: > > >> but as long as its IRQ is in disabled/masked state it > >> doesn't matter. > > ...but there's no requirement that someone would need to disable/mask > > an interrupt while switching the muxing, is there? So it does matter. > > > > >

Re: [PATCH v2] phy: rockchip-emmc: emmc_phy_init() always return 0

2020-12-09 Thread Doug Anderson
Hi, On Tue, Dec 8, 2020 at 6:08 PM Chris Ruehl wrote: > > rockchip_emmc_phy_init() return variable is not set with the error value > if clk_get() failed. 'emmcclk' is optional, thus use clk_get_optional() > and if the return value != NULL make error processing and set the > return code

Re: [PATCH v3] iio: sx9310: Fix semtech,avg-pos-strength setting when > 16

2020-12-08 Thread Doug Anderson
Hi, On Wed, Dec 2, 2020 at 12:02 PM Stephen Boyd wrote: > > This DT property can be 0, 16, and then 64, but not 32. The math here > doesn't recognize this slight bump in the power of 2 numbers and > translates a DT property of 64 into the register value '3' when it > really should be '2'. Fix it

Re: [PATCH v3] ath10k: add option for chip-id based BDF selection

2020-12-07 Thread Doug Anderson
Hi, On Mon, Dec 7, 2020 at 3:23 PM Abhishek Kumar wrote: > > In some devices difference in chip-id should be enough to pick > the right BDF. Add another support for chip-id based BDF selection. > With this new option, ath10k supports 2 fallback options. > > The board name with chip-id as option

Re: [GIT PULL] ARM: SoC fixes for v5.10, part 3

2020-12-07 Thread Doug Anderson
Hi, On Mon, Dec 7, 2020 at 1:55 PM Arnd Bergmann wrote: > > On Mon, Dec 7, 2020 at 9:23 PM Geert Uytterhoeven > wrote: > > On Tue, Dec 1, 2020 at 3:06 PM Arnd Bergmann wrote: > > > On Tue, Dec 1, 2020 at 12:39 PM Ulf Hansson > > > wrote: > > > > So, I think we have two options. If people

Re: [PATCH] phy: rockchip-emmc: emmc_phy_init() always return 0

2020-12-04 Thread Doug Anderson
Hi, On Thu, Dec 3, 2020 at 7:01 PM Chris Ruehl wrote: > > Hi, > > On 2/12/2020 4:36 pm, Chris Ruehl wrote: > > > > On 2/12/2020 12:05 am, Doug Anderson wrote: > >> Hi, > >> > >> On Mon, Nov 30, 2020 at 7:10 PM Chris Ruehl > >>

Re: [PATCH] ARM: OMAP2+: omap_device: fix idling of devices during probe

2020-12-04 Thread Doug Anderson
Hi, On Fri, Dec 4, 2020 at 8:14 AM Andreas Kemnade wrote: > > > > Fixes: 21b2cec61c04 ("mmc: Set PROBE_PREFER_ASYNCHRONOUS for drivers that > > > existed in v4.4") > > > > From the description it sounds like this problem has always existed > > but the async probe just tickled it reliably.

Re: [PATCH] ARM: OMAP2+: omap_device: fix idling of devices during probe

2020-12-04 Thread Doug Anderson
Hi, On Fri, Dec 4, 2020 at 1:55 AM Andreas Kemnade wrote: > > On the GTA04A5 od->_driver_status was not set to BUS_NOTIFY_BIND_DRIVER > during probe of the second mmc used for wifi. Therefore > omap_device_late_idle idled the device during probing causing oopses when > accessing the registers. >

Re: [PATCH v2] soc: qcom: rpmh: Remove serialization of TCS commands

2020-12-03 Thread Doug Anderson
Hi, On Mon, Nov 23, 2020 at 11:32 PM Maulik Shah wrote: > > @@ -423,8 +422,7 @@ static irqreturn_t tcs_tx_done(int irq, void *p) > cmd = >cmds[j]; > sts = read_tcs_cmd(drv, RSC_DRV_CMD_STATUS, i, j); > if (!(sts &

Re: [PATCH] drivers: qcom: rpmh-rsc: Do not read back the register write on trigger

2020-12-03 Thread Doug Anderson
Hi, On Thu, Dec 3, 2020 at 1:15 PM Doug Anderson wrote: > > Hi, > > On Tue, Nov 24, 2020 at 1:53 AM Maulik Shah wrote: > > > > From: Lina Iyer > > > > When triggering a TCS to send its contents, reading back the trigger > > value may return an

Re: [PATCH] drivers: qcom: rpmh-rsc: Do not read back the register write on trigger

2020-12-03 Thread Doug Anderson
Hi, On Tue, Nov 24, 2020 at 1:53 AM Maulik Shah wrote: > > From: Lina Iyer > > When triggering a TCS to send its contents, reading back the trigger > value may return an incorrect value. That is because, writing the > trigger may raise an interrupt which could be handled immediately and > the

Re: [PATCH v2 3/3] pinctrl: qcom: Clear possible pending irq when remuxing GPIOs

2020-12-03 Thread Doug Anderson
Hi, On Thu, Dec 3, 2020 at 3:22 AM Maulik Shah wrote: > > >>> + /* > >>> + * Clear IRQs if switching to/from GPIO mode since muxing to/from > >>> + * the GPIO path can cause phantom edges. > >>> + */ > >>> + old_i = (oldval & mask) >> g->mux_bit; > >>> + if (old_i != i

Re: [PATCH] spi: spi-geni-qcom: Use the new method of gpio CS control

2020-12-03 Thread Doug Anderson
Hi, On Wed, Dec 2, 2020 at 4:47 PM Stephen Boyd wrote: > > Quoting Stephen Boyd (2020-12-02 15:28:45) > > Quoting Alexandru M Stan (2020-12-02 14:18:20) > > > Unfortunately this patch makes my cros-ec (the main EC that used to > > > work even before my debugging) also fail to probe: > > > [

Re: [PATCH] spi: spi-geni-qcom: Fix NULL pointer access in geni_spi_isr

2020-12-03 Thread Doug Anderson
Hi, On Wed, Dec 2, 2020 at 11:45 PM Roja Rani Yarubandi wrote: > > Here, there is a chance of race condition occurrence which leads to > NULL pointer dereference with struct spi_geni_master member 'cur_xfer' > between setup_fifo_xfer() and handle_fifo_timeout() functions. > > Fix this race

Re: [PATCH v2 1/1] ath10k: add option for chip-id based BDF selection

2020-12-03 Thread Doug Anderson
Hi, On Thu, Dec 3, 2020 at 3:33 AM Rakesh Pillai wrote: > > > What I'm trying to say is this. Imagine that: > > > > a) the device tree has the "variant" property. > > > > b) the BRD file has two entries, one for "board-id" (1) and one for > > "board-id + chip-id" (2). It doesn't have one for

Re: [PATCH 2/2] platform/chrome: cros_ec_spi: Drop bits_per_word assignment

2020-12-02 Thread Doug Anderson
Hi, On Wed, Dec 2, 2020 at 5:16 PM Stephen Boyd wrote: > > This is already handed by default in spi_setup() if the bits_per_word is > 0, so just drop it to shave off a line. > > Cc: Simon Glass > Cc: Gwendal Grignou > Cc: Douglas Anderson > Cc: Alexandru M Stan > Signed-off-by: Stephen Boyd

Re: [PATCH 1/2] platform/chrome: cros_ec_spi: Don't overwrite spi::mode

2020-12-02 Thread Doug Anderson
Hi, On Wed, Dec 2, 2020 at 5:16 PM Stephen Boyd wrote: > > There isn't any need to overwrite the mode here in the driver with what > has been detected by the firmware, such as DT or ACPI. In fact, if we > use the SPI CS gpio descriptor feature we will overwrite the mode with > SPI_MODE_0 where

Re: [PATCH v6 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p

2020-12-02 Thread Doug Anderson
Hi, On Wed, Dec 2, 2020 at 7:20 AM Benjamin Tissoires wrote: > > Hi Doug, > > On Tue, Dec 1, 2020 at 10:12 PM Doug Anderson wrote: > > > > Hi, > > > > On Wed, Nov 11, 2020 at 4:41 PM Douglas Anderson > > wrote: > > > > > > The goal

Re: [PATCH v6 0/4] HID: i2c-hid: Reorganize to allow supporting goodix,gt7375p

2020-12-01 Thread Doug Anderson
Hi, On Wed, Nov 11, 2020 at 4:41 PM Douglas Anderson wrote: > > The goal of this series is to support the Goodix GT7375P touchscreen. > This touchscreen is special because it has power sequencing > requirements that necessitate driving a reset GPIO. > > To do this, we totally rejigger the way

Re: [PATCH v4 1/5] drm: panel: simple: Fixup the struct panel_desc kernel doc

2020-12-01 Thread Doug Anderson
Hi, On Sun, Nov 29, 2020 at 2:10 PM Sam Ravnborg wrote: > > Hi Douglas, > On Mon, Nov 09, 2020 at 05:00:55PM -0800, Douglas Anderson wrote: > > When I run: > > scripts/kernel-doc -rst drivers/gpu/drm/panel/panel-simple.c > > > > I see that several of the kernel-doc entries aren't showing up

Re: [PATCH] phy: rockchip-emmc: emmc_phy_init() always return 0

2020-12-01 Thread Doug Anderson
Hi, On Mon, Nov 30, 2020 at 7:10 PM Chris Ruehl wrote: > > rockchip_emmc_phy_init() return variable is not set with the error value > if clk_get() failed. The debug message print 0 on error and the function > always return 0. > Fix it using PTR_ERR(). > > Fixes: 52c0624a10cce phy: rockchip-emmc:

Re: [PATCH v2 3/3] pinctrl: qcom: Clear possible pending irq when remuxing GPIOs

2020-11-30 Thread Doug Anderson
Hi, On Mon, Nov 30, 2020 at 2:33 AM Maulik Shah wrote: > > > [1] > > https://lore.kernel.org/r/603c691f-3614-d87b-075a-0889e9ffc...@codeaurora.org > Please wait to land [1] before i confirm with HW team if this is indeed > valid case. Oh, oops. Somehow I thought your reply was in response to

Re: [PATCH v2 1/3] irqchip: qcom-pdc: Fix phantom irq when changing between rising/falling

2020-11-30 Thread Doug Anderson
Hi, On Tue, Nov 24, 2020 at 9:47 AM Douglas Anderson wrote: > > We have a problem if we use gpio-keys and configure wakeups such that > we only want one edge to wake us up. AKA: > wakeup-event-action = ; > wakeup-source; > > Specifically we end up with a phantom interrupt that blocks

Re: [PATCH v2 1/1] ath10k: add option for chip-id based BDF selection

2020-11-30 Thread Doug Anderson
Hi, On Tue, Nov 24, 2020 at 7:44 PM Rakesh Pillai wrote: > > > > I missed on reviewing this change. Also I agree with Doug that this is not > > the change I was looking for. > > > > > > The argument "with_variant" can be renamed to "with_extra_params". > > There is no need for any new argument

Re: [GIT PULL] ARM: SoC fixes for v5.10, part 3

2020-11-30 Thread Doug Anderson
Hi, On Mon, Nov 30, 2020 at 9:44 AM Linus Torvalds wrote: > > So basically, the way the async probing works for say SCSI is that we > have multiple "layers of asynchroniety". We have the usual "init calls > done asynchronously", but then within the init calls themselves you > can start sub-scans

Re: [GIT PULL] ARM: SoC fixes for v5.10, part 3

2020-11-30 Thread Doug Anderson
Hi, On Fri, Nov 27, 2020 at 2:56 PM Linus Torvalds wrote: > > On Fri, Nov 27, 2020 at 12:51 PM Arnd Bergmann wrote: > > > > - Some DT patches for the Rockchip RK3399 platform, > >in particular fixing the MMC device ordering that > >recently became nondeterministic with async probe. > >

<    1   2   3   4   5   6   7   8   9   10   >