Re: [PATCH v4 4/7] genirq: introduce irq_suspend_parent() and irq_resume_parent()

2020-08-11 Thread Doug Anderson
Hi, On Mon, Aug 10, 2020 at 4:21 AM Maulik Shah wrote: > > From: Douglas Anderson > > This goes with the new irq_suspend_one() and irq_resume_one() > callbacks and allow us to easily pass things up to our parent. > > Signed-off-by: Douglas Anderson > Signed-off-by: Maulik Shah > --- >

Re: [PATCH v4 3/7] genirq: Introduce irq_suspend_one() and irq_resume_one() callbacks

2020-08-11 Thread Doug Anderson
Hi, On Mon, Aug 10, 2020 at 4:21 AM Maulik Shah wrote: > > From: Douglas Anderson > > The "struct irq_chip" has two callbacks in it: irq_suspend() and > irq_resume(). These two callbacks are interesting because sometimes > an irq chip needs to know about suspend/resume, but they are a bit >

Re: [PATCH v4 1/7] pinctrl: qcom: Add msmgpio irqchip flags

2020-08-11 Thread Doug Anderson
Hi, On Mon, Aug 10, 2020 at 4:21 AM Maulik Shah wrote: > > Add irqchip specific flags for msmgpio irqchip to mask non wakeirqs > during suspend and mask before setting irq type. > > Masking before changing type should make sure any spurious interrupt > is not detected during this operation. > >

Re: [RFC 0/5] Introduce NMI aware serial drivers

2020-08-11 Thread Doug Anderson
Hi, On Tue, Aug 11, 2020 at 7:58 AM Greg Kroah-Hartman wrote: > > On Tue, Aug 11, 2020 at 07:59:24PM +0530, Sumit Garg wrote: > > Hi Greg, > > > > Thanks for your comments. > > > > On Tue, 11 Aug 2020 at 19:27, Greg Kroah-Hartman > > wrote: > > > > > > On Tue, Aug 11, 2020 at 07:20:26PM +0530,

Re: [PATCH] serial: qcom_geni_serial: Fix recent kdb hang

2020-08-11 Thread Doug Anderson
Hi, On Tue, Aug 11, 2020 at 4:54 AM Akash Asthana wrote: > > > On 8/11/2020 2:56 AM, Doug Anderson wrote: > > Hi, > > > > On Mon, Aug 10, 2020 at 5:32 AM Akash Asthana > > wrote: > >> Hi Doug, > >> > >> On 8/7/2020 10:49 AM, Do

Re: [PATCH] serial: qcom_geni_serial: Fix recent kdb hang

2020-08-10 Thread Doug Anderson
Hi, On Mon, Aug 10, 2020 at 5:32 AM Akash Asthana wrote: > > Hi Doug, > > On 8/7/2020 10:49 AM, Douglas Anderson wrote: > > The commit e42d6c3ec0c7 ("serial: qcom_geni_serial: Make kgdb work > > even if UART isn't console") worked pretty well and I've been doing a > > lot of debugging with it.

Re: [PATCH] ARM: hw_breakpoint: Handle inexact watchpoint addresses

2020-08-06 Thread Doug Anderson
Hi, On Thu, Aug 6, 2020 at 3:02 PM Russell King - ARM Linux admin wrote: > > On Thu, Aug 06, 2020 at 11:28:09AM -0700, Doug Anderson wrote: > > Let's hope this one works: > > > > https://www.armlinux.org.uk/developer/patches/viewpatch.php?id=8997/1 > > Almost

Re: [PATCH 4.19 066/133] regmap: debugfs: Dont sleep while atomic for fast_io regmaps

2020-08-06 Thread Doug Anderson
Hi, On Wed, Jul 22, 2020 at 5:09 AM Pavel Machek wrote: > > Hi! > > > From: Douglas Anderson > > > > [ Upstream commit 299632e54b2e692d2830af84be51172480dc1e26 ] > > > > > + err = kstrtobool_from_user(user_buf, count, _val); > > + /* Ignore malforned data like debugfs_write_file_bool()

Re: [PATCH] ARM: hw_breakpoint: Handle inexact watchpoint addresses

2020-08-06 Thread Doug Anderson
Hi, On Thu, Aug 6, 2020 at 8:45 AM Doug Anderson wrote: > > Hi, > > On Thu, Aug 6, 2020 at 8:41 AM Russell King - ARM Linux admin > wrote: > > > > On Thu, Aug 06, 2020 at 08:05:10AM -0700, Doug Anderson wrote: > > > Hi, > > > > > > On M

Re: [PATCH] ARM: hw_breakpoint: Handle inexact watchpoint addresses

2020-08-06 Thread Doug Anderson
Hi, On Mon, Dec 2, 2019 at 8:36 AM Doug Anderson wrote: > > Hi, > > On Wed, Nov 20, 2019 at 11:18 AM Will Deacon wrote: > > > > On Sat, Oct 19, 2019 at 11:12:26AM -0700, Douglas Anderson wrote: > > > This is commit fdfeff0f9e3d ("arm64: hw_breakpoint: Han

Re: [PATCH 1/2] soc: qcom: aoss: Don't wait for IRQ if we might be in suspend/resume noirq

2020-08-06 Thread Doug Anderson
Hi, On Thu, Aug 6, 2020 at 7:36 AM Sibi Sankar wrote: > > On 2020-08-06 04:32, Stephen Boyd wrote: > > +Sibi who wrote the code > > > > Quoting Doug Anderson (2020-08-05 13:24:06) > >> > >> On Wed, Aug 5, 2020 at 10:36 AM Stephen Boyd > >> wrot

Re: [PATCH] ARM: hw_breakpoint: Handle inexact watchpoint addresses

2020-08-06 Thread Doug Anderson
Hi, On Thu, Aug 6, 2020 at 8:41 AM Russell King - ARM Linux admin wrote: > > On Thu, Aug 06, 2020 at 08:05:10AM -0700, Doug Anderson wrote: > > Hi, > > > > On Mon, Dec 2, 2019 at 8:36 AM Doug Anderson wrote: > > > > > > Hi, > > > > &

Re: [PATCH 2/2] soc: qcom: aoss: qmp_send() can't handle interruptions so stop pretending

2020-08-05 Thread Doug Anderson
Hi, On Wed, Aug 5, 2020 at 10:28 AM Stephen Boyd wrote: > > Quoting Douglas Anderson (2020-08-05 09:16:11) > > The function qmp_send() called wait_event_interruptible_timeout() to > > wait for its interrupt. However, this function did not check for > > -ERESTARTSYS and assumed that any non-zero

Re: [PATCH 1/2] soc: qcom: aoss: Don't wait for IRQ if we might be in suspend/resume noirq

2020-08-05 Thread Doug Anderson
Hi, On Wed, Aug 5, 2020 at 10:36 AM Stephen Boyd wrote: > > Quoting Douglas Anderson (2020-08-05 09:16:10) > > Running suspend/resume tests on a sc7180-based board with a modem I > > found that both system suspend and system resume would hang for 1 > > second. These messages indicate where: > >

Re: [PATCH] regulator: Avoid grabbing regulator lock during suspend/resume

2020-08-04 Thread Doug Anderson
Hi, On Tue, Aug 4, 2020 at 12:08 AM Stephen Boyd wrote: > > I see it takes about 5us per regulator to grab the lock, check that this > regulator isn't going to do anything for suspend, and then release the > lock. When that is combined with PMICs that have dozens of regulators we > get into a

Re: [PATCH v3] pinctrl: qcom: Handle broken/missing PDC dual edge IRQs on sc7180

2020-08-03 Thread Doug Anderson
Hi, On Mon, Aug 3, 2020 at 2:06 PM John Stultz wrote: > > On Tue, Jul 14, 2020 at 8:08 AM Douglas Anderson > wrote: > > > > Depending on how you look at it, you can either say that: > > a) There is a PDC hardware issue (with the specific IP rev that exists > >on sc7180) that causes the PDC

Re: [PATCH v2] arm64: dts: qcom: sc7180: Add LPASS clock controller nodes

2020-08-03 Thread Doug Anderson
Hi, On Sat, Aug 1, 2020 at 11:14 AM Taniya Das wrote: > > Update the clock controller nodes for Low power audio subsystem > functionality. > > Signed-off-by: Taniya Das > --- > arch/arm64/boot/dts/qcom/sc7180.dtsi | 25 + > 1 file changed, 25 insertions(+) > > diff

Re: [PATCH] arm64: dts: qcom: sc7180: Add LPASS clock controller nodes

2020-07-31 Thread Doug Anderson
Hi, On Thu, Jul 16, 2020 at 10:34 AM Doug Anderson wrote: > > Hi, > > On Tue, Jul 14, 2020 at 11:56 PM Taniya Das wrote: > > > > Update the clock controller nodes for Low power audio subsystem > > functionality. > > > > Signed-off-by: Taniya

Re: [PATCH v4 4/5] arm64: dts: sdm845: Add OPP tables and power-domains for venus

2020-07-29 Thread Doug Anderson
Hi, On Tue, Jul 28, 2020 at 1:11 PM Lina Iyer wrote: > > On Tue, Jul 28 2020 at 13:51 -0600, Stephen Boyd wrote: > >Quoting Lina Iyer (2020-07-28 09:52:12) > >> On Mon, Jul 27 2020 at 18:45 -0600, Stephen Boyd wrote: > >> >Quoting Lina Iyer (2020-07-24 09:28:25) > >> >> On Fri, Jul 24 2020 at

Re: [PATCH v2] soc: qcom: rpmh-rsc: Sleep waiting for tcs slots to be free

2020-07-28 Thread Doug Anderson
Hi, On Sun, Jul 26, 2020 at 2:44 AM Stanimir Varbanov wrote: > > Hi Stephen, > > On 7/25/20 12:17 AM, Stephen Boyd wrote: > > From: Stephen Boyd > > > > The busy loop in rpmh_rsc_send_data() is written with the assumption > > that the udelay will be preempted by the tcs_tx_done() irq handler

Re: [PATCH v2 5/5] iio: sx9310: Enable vdd and svdd regulators at probe

2020-07-24 Thread Doug Anderson
Hi, On Fri, Jul 24, 2020 at 2:33 PM Stephen Boyd wrote: > > Enable the main power supply (vdd) and digital IO power supply (svdd) > during probe so that the i2c communication and device works properly on > boards that aggressively power gate these supplies. > > Cc: Gwendal Grignou > Cc: Daniel

Re: [PATCH v2 4/5] iio: sx9310: Drop channel_users[]

2020-07-24 Thread Doug Anderson
Hi, On Fri, Jul 24, 2020 at 2:33 PM Stephen Boyd wrote: > > This struct member isn't used. Drop it. > > Cc: Gwendal Grignou > Cc: Daniel Campello > Cc: Hartmut Knaack > Cc: Lars-Peter Clausen > Cc: Peter Meerwald-Stadler > Cc: Douglas Anderson > Fixes: 72ad02b15d63 ("iio: Add SEMTECH

Re: [PATCH v2 3/5] iio: sx9310: whoami is unsigned

2020-07-24 Thread Doug Anderson
Hi, On Fri, Jul 24, 2020 at 2:33 PM Stephen Boyd wrote: > > This is an unsigned value, actually it's a u8 but regmap doesn't handle > that easily. Let's make it unsigned throughout so that we don't need to > worry about signed vs. unsigned comparison behavior. > > Cc: Gwendal Grignou > Cc:

Re: [PATCH v2] soc: qcom: rpmh-rsc: Sleep waiting for tcs slots to be free

2020-07-24 Thread Doug Anderson
Hi, On Fri, Jul 24, 2020 at 2:17 PM Stephen Boyd wrote: > > From: Stephen Boyd > > The busy loop in rpmh_rsc_send_data() is written with the assumption > that the udelay will be preempted by the tcs_tx_done() irq handler when > the TCS slots are all full. This doesn't hold true when the calling

Re: [PATCH 1/3] dt-bindings: iio: Add bindings for sx9310 sensor

2020-07-24 Thread Doug Anderson
Hi, On Thu, Jul 23, 2020 at 4:03 PM Stephen Boyd wrote: > > From: Daniel Campello > > Adds device tree bandings for sx9310 sensor. > > Signed-off-by: Daniel Campello > Cc: Hartmut Knaack > Cc: Lars-Peter Clausen > Cc: Peter Meerwald-Stadler > Cc: Rob Herring > Cc: Douglas Anderson >

Re: [PATCH] soc: qcom: rpmh-rsc: Sleep waiting for tcs slots to be free

2020-07-24 Thread Doug Anderson
Hi, On Fri, Jul 24, 2020 at 1:27 PM Stephen Boyd wrote: > > Quoting Doug Anderson (2020-07-24 13:11:59) > > > > I wasn't suggesting adding a timeout. I was just saying that if > > claim_tcs_for_req() were to ever return an error code other than > > -EBUSY that we

Re: [PATCH 2/3] iio: sx9310: Add newlines to printks

2020-07-24 Thread Doug Anderson
Hi, On Thu, Jul 23, 2020 at 4:03 PM Stephen Boyd wrote: > > Printks in the kernel have newlines at the end. Add them to the few > printks in this driver. > > Cc: Gwendal Grignou > Cc: Daniel Campello > Cc: Hartmut Knaack > Cc: Lars-Peter Clausen > Cc: Peter Meerwald-Stadler > Cc: Douglas

Re: [PATCH 3/3] iio: sx9310: Enable regulator for svdd supply

2020-07-24 Thread Doug Anderson
Hi, On Thu, Jul 23, 2020 at 4:03 PM Stephen Boyd wrote: > > Enable the digital IO power supply (svdd) during probe so that the i2c > communication works properly on boards that aggressively power gate this > supply. > > Cc: Gwendal Grignou > Cc: Daniel Campello > Cc: Hartmut Knaack > Cc:

Re: [PATCH] soc: qcom: rpmh-rsc: Sleep waiting for tcs slots to be free

2020-07-24 Thread Doug Anderson
Hi, On Fri, Jul 24, 2020 at 1:01 PM Stephen Boyd wrote: > > Quoting Doug Anderson (2020-07-24 12:49:56) > > Hi, > > > > On Fri, Jul 24, 2020 at 12:44 PM Stephen Boyd wrote: > > > > > > > > - if (ret) > > > > > -

Re: [PATCH] soc: qcom: rpmh-rsc: Sleep waiting for tcs slots to be free

2020-07-24 Thread Doug Anderson
Hi, On Fri, Jul 24, 2020 at 12:44 PM Stephen Boyd wrote: > > > > - if (ret) > > > - goto unlock; > > > > > > - ret = find_free_tcs(tcs); > > > - if (ret < 0) > > > - goto unlock; > > > - tcs_id = ret; > > > +

Re: [PATCH] soc: qcom: rpmh-rsc: Sleep waiting for tcs slots to be free

2020-07-24 Thread Doug Anderson
Hi, On Wed, Jul 22, 2020 at 6:01 PM Stephen Boyd wrote: > > The busy loop in rpmh_rsc_send_data() is written with the assumption > that the udelay will be preempted by the tcs_tx_done() irq handler when > the TCS slots are all full. This doesn't hold true when the calling > thread is an

Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-22 Thread Doug Anderson
Hi, On Tue, Jul 21, 2020 at 1:26 PM Doug Anderson wrote: > > Hi, > > On Tue, Jul 21, 2020 at 11:55 AM Stephen Boyd wrote: > > > > Quoting Doug Anderson (2020-07-21 09:18:35) > > > On Tue, Jul 21, 2020 at 12:08 AM Stephen Boyd wrote: > > > > >

Re: [PATCH v2 3/3] kgdb: Add NOKPROBE labels on the trap handler functions

2020-07-21 Thread Doug Anderson
Hi, On Mon, Jul 20, 2020 at 1:13 AM Daniel Thompson wrote: > > On Fri, Jul 17, 2020 at 03:39:58PM -0700, Doug Anderson wrote: > > Hi, > > > > On Thu, Jul 16, 2020 at 8:20 AM Daniel Thompson > > wrote: > > > > > > Currently kgdb honours the kprob

Re: [PATCH v2 2/3] kgdb: Use the kprobe blocklist to limit single stepping

2020-07-21 Thread Doug Anderson
Hi, On Mon, Jul 20, 2020 at 1:08 AM Daniel Thompson wrote: > > On Fri, Jul 17, 2020 at 03:39:51PM -0700, Doug Anderson wrote: > > Hi, > > > > On Thu, Jul 16, 2020 at 8:20 AM Daniel Thompson > > wrote: > > > > > > If we are running in a part of the

Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-21 Thread Doug Anderson
Hi, On Tue, Jul 21, 2020 at 11:55 AM Stephen Boyd wrote: > > Quoting Doug Anderson (2020-07-21 09:18:35) > > On Tue, Jul 21, 2020 at 12:08 AM Stephen Boyd wrote: > > > > > > Quoting Stephen Boyd (2020-07-20 22:59:14) > > > > > > > > I wor

Re: [PATCH] i2c: i2c-qcom-geni: Fix DMA transfer race

2020-07-21 Thread Doug Anderson
Hi, On Tue, Jul 21, 2020 at 12:08 AM Stephen Boyd wrote: > > Quoting Stephen Boyd (2020-07-20 22:59:14) > > > > I worry that we also need a dmb() here to make sure the dma buffer is > > properly mapped before this write to the device is attempted. But it may > > only matter to be before the

Re: [PATCH] ath10k: Add interrupt summary based CE processing

2020-07-21 Thread Doug Anderson
Hi, On Mon, Jul 20, 2020 at 6:32 PM Peter Oh wrote: > > I'll take my word back. > It's not this patch problem, but by others. > I have 2 extra patches before the 3 patches so my system looks like > > backports from ath.git 5.6-rc1 + linux kernel 4.4 (similar to OpenWrt) > On top of the working

Re: [PATCH] ath10k: Add interrupt summary based CE processing

2020-07-20 Thread Doug Anderson
Hi, On Mon, Jul 20, 2020 at 5:33 PM Peter Oh wrote: > > I'm getting this panic on IPQ4019 system after cherry-picked this > single patch on top of working system. > > [ 14.226184] ath10k_ahb a00.wifi: failed to receive initialized > event from target: 8000 A bit of a shot in the dark,

Re: [PATCH] drm: panel: simple: Delay HPD checking on boe_nv133fhm_n61 for 15 ms

2020-07-20 Thread Doug Anderson
Hi, On Thu, Jul 16, 2020 at 1:21 PM Douglas Anderson wrote: > > On boe_nv133fhm_n62 (and presumably on boe_nv133fhm_n61) a scope shows > a small spike on the HPD line right when you power the panel on. The > picture looks something like this: > >

Re: [PATCH v2 2/3] kgdb: Use the kprobe blocklist to limit single stepping

2020-07-17 Thread Doug Anderson
Hi, On Thu, Jul 16, 2020 at 8:20 AM Daniel Thompson wrote: > > If we are running in a part of the kernel that dislikes breakpoint > debugging then it is very unlikely to be safe to single step. Add > some safety rails to prevent stepping through anything on the kprobe > blocklist. > > As part of

Re: [PATCH v2 1/3] kgdb: Honour the kprobe blocklist when setting breakpoints

2020-07-17 Thread Doug Anderson
Hi, On Thu, Jul 16, 2020 at 8:20 AM Daniel Thompson wrote: > > Currently kgdb has absolutely no safety rails in place to discourage or > prevent a user from placing a breakpoint in dangerous places such as > the debugger's own trap entry/exit and other places where it is not safe > to take

Re: [PATCH v2 3/3] kgdb: Add NOKPROBE labels on the trap handler functions

2020-07-17 Thread Doug Anderson
Hi, On Thu, Jul 16, 2020 at 8:20 AM Daniel Thompson wrote: > > Currently kgdb honours the kprobe blocklist but doesn't place its own > trap handling code on the list. Add labels to discourage attempting to > use kgdb to debug itself. > > These changes do not make it impossible to provoke

Re: [PATCH v2] drm: msm: a6xx: fix gpu failure after system resume

2020-07-17 Thread Doug Anderson
Hi, On Fri, Jul 17, 2020 at 1:24 PM Rob Clark wrote: > > On Fri, Jul 17, 2020 at 10:39 AM Doug Anderson wrote: > > > > Hi, > > > > On Fri, Jul 17, 2020 at 7:46 AM Jordan Crouse > > wrote: > > > > > > On Fri, Jul 17, 2020 at 08:04:18PM +05

Re: [PATCH v2] drm: msm: a6xx: fix gpu failure after system resume

2020-07-17 Thread Doug Anderson
Hi, On Fri, Jul 17, 2020 at 7:46 AM Jordan Crouse wrote: > > On Fri, Jul 17, 2020 at 08:04:18PM +0530, Akhil P Oommen wrote: > > On targets where GMU is available, GMU takes over the ownership of GX GDSC > > during its initialization. So, move the refcount-get on GX PD before we > > initialize

Re: [PATCH v5] x86/speculation/l1tf: Add KConfig for setting the L1D cache flush mode

2020-07-17 Thread Doug Anderson
Hi, On Fri, Jul 17, 2020 at 9:22 AM Thomas Gleixner wrote: > > Doug, > > Doug Anderson writes: > > On Thu, Jul 9, 2020 at 3:51 AM Thomas Gleixner wrote: > >> TBH, I don't see why this is a good idea. > >> > >> 1) I'm not following yo

Re: [PATCH 1/2] ASoC: qcom: dt-bindings: Add sc7180 machine bindings

2020-07-17 Thread Doug Anderson
Hi, On Fri, Jul 17, 2020 at 5:02 AM Cheng-Yi Chiang wrote: > > Add devicetree bindings documentation file for sc7180 sound card. > > Signed-off-by: Cheng-Yi Chiang > --- > .../bindings/sound/qcom,sc7180.yaml | 123 ++ > 1 file changed, 123 insertions(+) A bit of a

Re: [PATCH] arm64: dts: qcom: sc7180: Move the fixed-perm property to SoC dtsi

2020-07-16 Thread Doug Anderson
Hi, On Thu, Jul 16, 2020 at 12:18 PM Sibi Sankar wrote: > > All the platforms using SC7180 SoC are expected to have the wlan firmware > memory statically mapped by the Trusted Firmware. Hence move back the > qcom,msa-fixed-perm property to the SoC dtsi. > > Fixes: 7d484566087c0 ("arm64: dts:

Re: [PATCH v3 3/5] pinctrl: qcom: Use return value from irq_set_wake call

2020-07-16 Thread Doug Anderson
Hi, On Thu, Jul 16, 2020 at 6:19 AM Linus Walleij wrote: > > On Mon, Jun 22, 2020 at 11:32 AM Maulik Shah wrote: > > > msmgpio irqchip is not using return value of irq_set_wake call. > > Start using it. > > > > Fixes: e35a6ae0eb3a ("pinctrl/msm: Setup GPIO chip in hierarchy") > > Signed-off-by:

Re: [PATCH] arm64: dts: qcom: sc7180: Add lpass cpu node for I2S driver

2020-07-16 Thread Doug Anderson
Hi, On Wed, Jul 15, 2020 at 11:14 PM Cheng-Yi Chiang wrote: > > From: Ajit Pandey > > Add the I2S controller node to sc7180 dtsi. > Add pinmux for pirmary and secondary I2S. s/pirmary/primary > > Signed-off-by: Ajit Pandey > Signed-off-by: Cheng-Yi Chiang > --- > This patch depends on these

Re: [PATCH] arm64: dts: qcom: sc7180: Add LPASS clock controller nodes

2020-07-16 Thread Doug Anderson
Hi, On Tue, Jul 14, 2020 at 11:56 PM Taniya Das wrote: > > Update the clock controller nodes for Low power audio subsystem > functionality. > > Signed-off-by: Taniya Das > --- Somewhere here you should be pointing to the unlanded bindings patch, AKA:

Re: [PATCH v2] arm64: dts: qcom: sc7180: Add missing properties for Wifi node

2020-07-15 Thread Doug Anderson
Hi, On Sun, Jul 12, 2020 at 9:46 PM Rakesh Pillai wrote: > > The wlan firmware memory is statically mapped in > the Trusted Firmware, hence the wlan driver does > not need to map/unmap this region dynamically. > > Hence add the property to indicate the wlan driver > to not map/unamp the firmware

Re: [PATCH v3 1/5] pinctrl: qcom: Remove irq_disable callback from msmgpio irqchip

2020-07-14 Thread Doug Anderson
Hi, On Tue, Jul 14, 2020 at 3:38 AM Maulik Shah wrote: > > Hi, > > On 7/14/2020 3:47 AM, Doug Anderson wrote: > > Hi, > > On Mon, Jun 22, 2020 at 2:32 AM Maulik Shah wrote: > > > > The gpio can be marked for wakeup and drivers can invoke disable_irq() > &

Re: [PATCH v5 0/4] nvmem: qfprom: Patches for fuse blowing on Qualcomm SoCs

2020-07-14 Thread Doug Anderson
Srinivas, On Fri, Jul 10, 2020 at 7:35 AM Douglas Anderson wrote: > > This series enables blowing of fuses on Qualcomm SoCs by extending the > existing qfprom driver with write support. > > A few notes: > - Though I don't have any firsthand knowledge of it, it's my > understanding that these

Re: [PATCH v3 6/9] drm/bridge: ti-sn65dsi86: Use 18-bit DP if we can

2020-07-14 Thread Doug Anderson
Hi, On Fri, Jul 10, 2020 at 10:11 AM Steev Klimaszewski wrote: > > > On 7/10/20 9:47 AM, Doug Anderson wrote: > > Hi, > > > > > > But should I continue on this path, > > It's probably worth getting dithering working on your sdm845 anyway in > &g

Re: [PATCH v2] pinctrl: qcom: Handle broken/missing PDC dual edge IRQs on sc7180

2020-07-14 Thread Doug Anderson
Hi, On Tue, Jul 14, 2020 at 3:54 AM Marc Zyngier wrote: > > Hi Doug, > > On 2020-07-13 16:26, Douglas Anderson wrote: > > Depending on how you look at it, you can either say that: > > a) There is a PDC hardware issue (with the specific IP rev that exists > >on sc7180) that causes the PDC not

Re: [PATCH] tty: serial: qcom-geni-serial: Drop the icc bw votes in suspend for console

2020-07-13 Thread Doug Anderson
Rajendra, On Fri, Jul 10, 2020 at 5:41 AM Greg KH wrote: > > On Thu, Jul 09, 2020 at 03:07:00PM +0530, Rajendra Nayak wrote: > > When using the geni-serial as console, its important to be > > able to hit the lowest possible power state in suspend, > > even with no_console_suspend. > > The only

Re: [PATCH 0/9] drm/msm: Avoid possible infinite probe deferral and speed booting

2020-07-13 Thread Doug Anderson
Hi, On Mon, Jul 13, 2020 at 1:25 PM Rob Herring wrote: > > On Mon, Jul 13, 2020 at 9:08 AM Doug Anderson wrote: > > > > Hi, > > > > On Mon, Jul 13, 2020 at 7:11 AM Rob Herring wrote: > > > > > > On Fri, Jul 10, 2020 at 5:02 PM Douglas Anderson

Re: [PATCH v3 1/5] pinctrl: qcom: Remove irq_disable callback from msmgpio irqchip

2020-07-13 Thread Doug Anderson
Hi, On Mon, Jun 22, 2020 at 2:32 AM Maulik Shah wrote: > > The gpio can be marked for wakeup and drivers can invoke disable_irq() > during suspend, in such cases unlazy approach will also disable at HW > and such gpios will not wakeup device from suspend to RAM. > > Remove irq_disable callback

Re: [PATCH v3 2/5] pinctrl: qcom: Add msmgpio irqchip flags

2020-07-13 Thread Doug Anderson
Hi, On Mon, Jun 22, 2020 at 2:32 AM Maulik Shah wrote: > > Add irqchip specific flags for msmgpio irqchip to mask non wakeirqs > during suspend and mask before setting irq type. > > Masking before changing type should make sure any spurious interrupt > is not detected during this operation. > >

Re: [PATCH v3 5/5] irqchip: qcom-pdc: Reset all pdc interrupts during init

2020-07-13 Thread Doug Anderson
Hi, On Mon, Jun 22, 2020 at 2:33 AM Maulik Shah wrote: > > Clear previous kernel's configuration during init by resetting > all interrupts in enable bank to zero. > > Signed-off-by: Maulik Shah > --- > drivers/irqchip/qcom-pdc.c | 13 + > 1 file changed, 13 insertions(+) > > diff

Re: [PATCH v3 3/5] pinctrl: qcom: Use return value from irq_set_wake call

2020-07-13 Thread Doug Anderson
Hi, On Mon, Jun 22, 2020 at 2:32 AM Maulik Shah wrote: > > msmgpio irqchip is not using return value of irq_set_wake call. > Start using it. > > Fixes: e35a6ae0eb3a ("pinctrl/msm: Setup GPIO chip in hierarchy") > Signed-off-by: Maulik Shah > --- > drivers/pinctrl/qcom/pinctrl-msm.c | 8

Re: [PATCH v3 4/5] irqchip: qcom-pdc: Introduce irq_set_wake call

2020-07-13 Thread Doug Anderson
Hi, On Mon, Jun 22, 2020 at 2:33 AM Maulik Shah wrote: > > Remove irq_disable callback to allow lazy disable for pdc interrupts. > > Add irq_set_wake callback that unmask interrupt in HW when drivers > mark interrupt for wakeup. Interrupt will be cleared in HW during > lazy disable if its not

Re: [PATCH] pinctrl: qcom: Handle broken PDC dual edge case on sc7180

2020-07-13 Thread Doug Anderson
Hi, On Sat, Jul 11, 2020 at 2:16 AM Marc Zyngier wrote: > > On Fri, 10 Jul 2020 17:10:55 +0100, > Doug Anderson wrote: > > > > Hi, > > > > On Fri, Jul 10, 2020 at 2:03 AM Marc Zyngier wrote: > > > > > > Hi Doug, > > [...]

Re: [PATCH 0/9] drm/msm: Avoid possible infinite probe deferral and speed booting

2020-07-13 Thread Doug Anderson
Hi, On Mon, Jul 13, 2020 at 7:11 AM Rob Herring wrote: > > On Fri, Jul 10, 2020 at 5:02 PM Douglas Anderson > wrote: > > > > I found that if I ever had a little mistake in my kernel config, > > or device tree, or graphics driver that my system would sit in a loop > > at bootup trying again and

Re: [PATCH 1/2] serial: qcom_geni_serial: Make kgdb work even if UART isn't console

2020-07-10 Thread Doug Anderson
Hi, On Fri, Jul 10, 2020 at 12:03 PM Evan Green wrote: > > On Fri, Jul 10, 2020 at 11:19 AM Doug Anderson wrote: > > > > Hi, > > > > On Fri, Jul 10, 2020 at 10:39 AM Evan Green wrote: > > > > > > On Fri, Jun 26, 2020 at 1:01 PM Douglas Anderso

Re: [PATCH 2/2] serial: qcom_geni_serial: Always use 4 bytes per TX FIFO word

2020-07-10 Thread Doug Anderson
Hi, On Fri, Jul 10, 2020 at 10:46 AM Evan Green wrote: > > On Fri, Jun 26, 2020 at 1:01 PM Douglas Anderson > wrote: > > > > The geni serial driver had a rule that we'd only use 1 byte per FIFO > > word for the TX FIFO if we were being used for the serial console. > > This is ugly and a bit of

Re: [PATCH 1/2] serial: qcom_geni_serial: Make kgdb work even if UART isn't console

2020-07-10 Thread Doug Anderson
Hi, On Fri, Jul 10, 2020 at 10:39 AM Evan Green wrote: > > On Fri, Jun 26, 2020 at 1:01 PM Douglas Anderson > wrote: > > > > The geni serial driver had the rather sketchy hack in it where it > > would adjust the number of bytes per RX FIFO word from 4 down to 1 if > > it detected that

Re: [PATCH] pinctrl: qcom: Handle broken PDC dual edge case on sc7180

2020-07-10 Thread Doug Anderson
Hi, On Thu, Jul 9, 2020 at 10:09 PM Maulik Shah wrote: > > Hi Doug, > > On 7/9/2020 2:46 AM, Douglas Anderson wrote: > > As per Qualcomm, there is a PDC hardware issue (with the specific IP > > rev that exists on sc7180) that causes the PDC not to work properly > > when configured to handle dual

Re: [PATCH] pinctrl: qcom: Handle broken PDC dual edge case on sc7180

2020-07-10 Thread Doug Anderson
Hi, On Fri, Jul 10, 2020 at 2:03 AM Marc Zyngier wrote: > > Hi Doug, > > On Wed, 08 Jul 2020 22:16:25 +0100, > Douglas Anderson wrote: > > > > As per Qualcomm, there is a PDC hardware issue (with the specific IP > > rev that exists on sc7180) that causes the PDC not to work properly > > when

Re: [PATCH v3 6/9] drm/bridge: ti-sn65dsi86: Use 18-bit DP if we can

2020-07-10 Thread Doug Anderson
Hi, On Thu, Jul 9, 2020 at 11:15 PM Steev Klimaszewski wrote: > > Hi, > > On 7/9/20 11:12 PM, Doug Anderson wrote: > >> root@c630:~# bus=$(i2cdetect -l | grep sn65 | sed > >> 's/i2c-\([0-9]*\).*$/\1/') > >> root@c630:~# i2cdump ${bus} 0x50 i > edid &

Re: [PATCH v3 6/9] drm/bridge: ti-sn65dsi86: Use 18-bit DP if we can

2020-07-09 Thread Doug Anderson
Hi, On Thu, Jul 9, 2020 at 8:43 PM Steev Klimaszewski wrote: > > > On 7/9/20 10:17 PM, Steev Klimaszewski wrote: > > > > On 7/9/20 10:12 PM, Steev Klimaszewski wrote: > >> > >> On 7/9/20 9:14 PM, Doug Anderson wrote: > >>> Hi, > >>>

Re: [PATCH v3 6/9] drm/bridge: ti-sn65dsi86: Use 18-bit DP if we can

2020-07-09 Thread Doug Anderson
Hi, On Thu, Jul 9, 2020 at 6:38 PM Doug Anderson wrote: > > Hi, > > On Thu, Jul 9, 2020 at 6:19 PM Steev Klimaszewski wrote: > > > > Hi Doug, > > > > I've been testing 5.8 and linux-next on the Lenovo Yoga C630, and with this > > patch applied,

Re: [PATCH v3 6/9] drm/bridge: ti-sn65dsi86: Use 18-bit DP if we can

2020-07-09 Thread Doug Anderson
Hi, On Thu, Jul 9, 2020 at 6:19 PM Steev Klimaszewski wrote: > > Hi Doug, > > I've been testing 5.8 and linux-next on the Lenovo Yoga C630, and with this > patch applied, there is really bad banding on the display. > > I'm really bad at explaining it, but you can see the differences in the >

Re: [PATCH v5] x86/speculation/l1tf: Add KConfig for setting the L1D cache flush mode

2020-07-09 Thread Doug Anderson
Hi, On Thu, Jul 9, 2020 at 4:05 PM Abhishek Bhardwaj wrote: > > > > On Thu, Jul 9, 2020 at 3:43 PM mark gross wrote: >> >> On Thu, Jul 09, 2020 at 12:42:57PM -0700, Doug Anderson wrote: >> > Hi, >> > >> > On Thu, Jul 9, 2020 at 3:51 AM Thom

Re: [PATCH] arm64: dts: qcom: sc7180: Add missing properties for Wifi node

2020-07-09 Thread Doug Anderson
Hi, On Thu, Jul 9, 2020 at 2:18 AM Rakesh Pillai wrote: > > The wlan firmware memory is statically mapped in > the Trusted Firmware, hence the wlan driver does > not need to map/unmap this region dynamically. > > Hence add the property to indicate the wlan driver > to not map/unamp the firmware

Re: [PATCH v5] x86/speculation/l1tf: Add KConfig for setting the L1D cache flush mode

2020-07-09 Thread Doug Anderson
Hi, On Thu, Jul 9, 2020 at 3:51 AM Thomas Gleixner wrote: > > Abhishek Bhardwaj writes: > > This change adds a new kernel configuration that sets the l1d cache > > flush setting at compile time rather than at run time. > > > > The reasons for this change are as follows - > > > > - Kernel

Re: [PATCH] ath10k: Keep track of which interrupts fired, don't poll them

2020-07-09 Thread Doug Anderson
Hi, On Wed, Jul 8, 2020 at 4:40 PM Brian Norris wrote: > > On Wed, Jul 8, 2020 at 4:14 PM Doug Anderson wrote: > > On Wed, Jul 8, 2020 at 4:03 PM Brian Norris > > wrote: > > > If I'm reading correctly, you're removing the only remaining use of > > > 'p

Re: [PATCH] spi: spi-geni-qcom: Set the clock properly at runtime resume

2020-07-09 Thread Doug Anderson
Hi, On Thu, Jul 9, 2020 at 1:55 AM Rajendra Nayak wrote: > > > On 7/9/2020 5:09 AM, Douglas Anderson wrote: > > In the patch ("spi: spi-geni-qcom: Avoid clock setting if not needed") > > we avoid a whole pile of clock code. As part of that, we should have > > restored the clock at runtime

Re: [PATCH] spi: spi-geni-qcom: Set the clock properly at runtime resume

2020-07-09 Thread Doug Anderson
Hi, On Thu, Jul 9, 2020 at 12:30 AM Akash Asthana wrote: > > Hi Doug, > > > > > @@ -670,7 +674,13 @@ static int __maybe_unused > > spi_geni_runtime_resume(struct device *dev) > > if (ret) > > return ret; > > > > - return geni_se_resources_on(>se); > > + ret =

Re: [PATCH] ath10k: Keep track of which interrupts fired, don't poll them

2020-07-08 Thread Doug Anderson
Hi, On Wed, Jul 8, 2020 at 4:03 PM Brian Norris wrote: > > On Tue, Jul 7, 2020 at 10:18 AM Douglas Anderson > wrote: > > diff --git a/drivers/net/wireless/ath/ath10k/ce.h > > b/drivers/net/wireless/ath/ath10k/ce.h > > index a440aaf74aa4..666ce384a1d8 100644 > > ---

Re: [PATCH 0/4] arm64: kgdb/kdb: Fix single-step debugging issues

2020-07-08 Thread Doug Anderson
Hi, On Wed, Jul 8, 2020 at 3:06 PM Will Deacon wrote: > > Doug, > > On Mon, Jul 06, 2020 at 02:37:05PM -0700, Doug Anderson wrote: > > On Tue, Jun 30, 2020 at 12:22 AM Will Deacon wrote: > > > On Mon, Jun 29, 2020 at 02:20:11PM -0700, Doug Anderson wrote: > > &g

Re: [PATCH v2] pinctrl: qcom: sc7180: Make gpio28 non wakeup capable for google,lazor

2020-07-08 Thread Doug Anderson
Hi, On Wed, Jul 8, 2020 at 6:42 AM Doug Anderson wrote: > > Was there something wrong with my proof of concept patch? Unless I > get swamped with other things, my plan was to try to make that more > real and post it unless someone told me why it was wrong... OK, I spent a bit of

Re: [PATCH] arm64: dts: qcom: sc7180: Drop the unused non-MSA SID

2020-07-08 Thread Doug Anderson
Hi, On Tue, Jun 30, 2020 at 1:20 AM Sibi Sankar wrote: > > Having a non-MSA (Modem Self-Authentication) SID bypassed breaks modem > sandboxing i.e if a transaction were to originate from it, the hardware > memory protections units (XPUs) would fail to flag them (any transaction > originating

Re: [PATCH 1/3] spi: spi-geni-qcom: Avoid clock setting if not needed

2020-07-08 Thread Doug Anderson
Hi, On Wed, Jul 8, 2020 at 3:01 AM Mark Brown wrote: > > On Tue, Jul 07, 2020 at 05:53:01AM -0700, Doug Anderson wrote: > > On Tue, Jul 7, 2020 at 5:08 AM Mark Brown wrote: > > > > This doesn't apply against current code, please check and resend. > > > As mentio

Re: [PATCH v2] pinctrl: qcom: sc7180: Make gpio28 non wakeup capable for google,lazor

2020-07-08 Thread Doug Anderson
Hi, On Tue, Jul 7, 2020 at 10:29 PM Maulik Shah wrote: > > Hi, > > On 7/8/2020 4:33 AM, Doug Anderson wrote: > > Hi, > > > > On Mon, Jul 6, 2020 at 9:52 PM Rajendra Nayak wrote: > >> > >> [].. > >> > >>>>> @@ -1151,6 +

Re: [PATCH v2] pinctrl: qcom: sc7180: Make gpio28 non wakeup capable for google,lazor

2020-07-07 Thread Doug Anderson
Hi, On Tue, Jul 7, 2020 at 4:03 PM Doug Anderson wrote: > > Hi, > > On Mon, Jul 6, 2020 at 9:52 PM Rajendra Nayak wrote: > > > > > > [].. > > > > >>> @@ -1151,6 +1168,10 @@ static const struct msm_pinctrl_soc_data > > >>> sc

Re: [PATCH v2] pinctrl: qcom: sc7180: Make gpio28 non wakeup capable for google,lazor

2020-07-07 Thread Doug Anderson
Hi, On Mon, Jul 6, 2020 at 9:52 PM Rajendra Nayak wrote: > > > [].. > > >>> @@ -1151,6 +1168,10 @@ static const struct msm_pinctrl_soc_data > >>> sc7180_pinctrl = { > >>> > >>> static int sc7180_pinctrl_probe(struct platform_device *pdev) > >>> { > >>> + if

Re: [PATCH v4 3/4] nvmem: qfprom: Add fuse blowing support

2020-07-07 Thread Doug Anderson
Hi, On Mon, Jun 22, 2020 at 7:49 AM Douglas Anderson wrote: > > From: Ravi Kumar Bokka > > This patch adds support for blowing fuses to the qfprom driver if the > required properties are defined in the device tree. > > Signed-off-by: Ravi Kumar Bokka > Signed-off-by: Douglas Anderson > --- >

Re: [PATCH 1/3] spi: spi-geni-qcom: Avoid clock setting if not needed

2020-07-07 Thread Doug Anderson
Hi Mark, On Tue, Jul 7, 2020 at 5:08 AM Mark Brown wrote: > > On Wed, Jul 01, 2020 at 05:45:07PM -0700, Douglas Anderson wrote: > > Every SPI transfer could have a different clock rate. The > > spi-geni-qcom controller code to deal with this was never very well > > optimized and has always had

Re: [PATCH 0/4] arm64: kgdb/kdb: Fix single-step debugging issues

2020-07-06 Thread Doug Anderson
Hi, On Tue, Jun 30, 2020 at 12:22 AM Will Deacon wrote: > > On Mon, Jun 29, 2020 at 02:20:11PM -0700, Doug Anderson wrote: > > On Sat, May 16, 2020 at 1:20 AM liwei (GF) wrote: > > > On 2020/5/14 8:34, Doug Anderson wrote: > > > > On Sat, May

Re: [PATCH v2] pinctrl: qcom: sc7180: Make gpio28 non wakeup capable for google,lazor

2020-07-06 Thread Doug Anderson
Hi, On Fri, Jul 3, 2020 at 12:49 AM Rajendra Nayak wrote: > > The PDC irqchip driver currently does not handle dual-edge interrupts, > and we have google,lazor board with sc7180 designed to configure gpio28 > as a dual-edge interrupt. This interrupt is however not expected to be > wakeup capable

Re: [PATCH v3] x86/speculation/l1tf: Add KConfig for setting the L1D cache flush mode

2020-07-05 Thread Doug Anderson
Hi, On Sun, Jul 5, 2020 at 8:23 AM Mike Rapoport wrote: > > On Fri, Jul 03, 2020 at 07:00:11AM -0700, Doug Anderson wrote: > > Hi, > > > > On Fri, Jul 3, 2020 at 4:40 AM Mike Rapoport wrote: > > > > > > On Thu, Jul 02, 2020 at 11:43:47PM -0700, Abhi

Re: [PATCH v3] x86/speculation/l1tf: Add KConfig for setting the L1D cache flush mode

2020-07-03 Thread Doug Anderson
Hi, On Fri, Jul 3, 2020 at 4:40 AM Mike Rapoport wrote: > > On Thu, Jul 02, 2020 at 11:43:47PM -0700, Abhishek Bhardwaj wrote: > > We have tried to steer away from kernel command line args for a few reasons. > > > > I am paraphrasing my colleague Doug's argument here (CC'ed him as well) - > > >

Re: [PATCH v4 3/4] nvmem: qfprom: Add fuse blowing support

2020-07-01 Thread Doug Anderson
Hi, On Wed, Jul 1, 2020 at 8:09 AM Ravi Kumar Bokka (Temp) wrote: > > Hi Doug, > I have tested v4 changes internally on target, if i am giving input as > unaligned address, it's not throwing any error message. You mean if you _read_ from an unaligned address, right? Yes, this is on purpose and

Re: [PATCH v3] kdb: remove unnecessary null check of dbg_io_ops

2020-06-30 Thread Doug Anderson
Hi, On Tue, Jun 30, 2020 at 1:30 AM Cengiz Can wrote: > > `kdb_msg_write` operates on a global `struct kgdb_io *` called > `dbg_io_ops`. > > It's initialized in `debug_core.c` and checked throughout the debug > flow. > > There's a null check in `kdb_msg_write` which triggers static analyzers >

Re: [PATCH] kgdb: Resolve races during kgdb_io_register/unregister_module

2020-06-30 Thread Doug Anderson
Hi, On Tue, Jun 30, 2020 at 8:05 AM Daniel Thompson wrote: > > On Mon, Jun 29, 2020 at 02:03:52PM -0700, Doug Anderson wrote: > > Hi, > > > > On Mon, Jun 29, 2020 at 10:15 AM Daniel Thompson > > wrote: > > > > > > Currently kgdb_re

Re: [PATCH] spi: spi-geni-qcom: Don't set the cs if it was already right

2020-06-29 Thread Doug Anderson
Hi, On Mon, Jun 29, 2020 at 4:53 AM Mark Brown wrote: > > On Fri, Jun 26, 2020 at 03:19:50PM -0700, Douglas Anderson wrote: > > Setting the chip select on the Qualcomm geni SPI controller isn't > > exactly cheap. Let's cache the current setting and avoid setting the > > chip select if it's

Re: [PATCH 0/4] arm64: kgdb/kdb: Fix single-step debugging issues

2020-06-29 Thread Doug Anderson
Wei, On Sat, May 16, 2020 at 1:20 AM liwei (GF) wrote: > > Hi Douglas, > > On 2020/5/14 8:34, Doug Anderson wrote: > > Hi, > > > > On Sat, May 9, 2020 at 6:49 AM Wei Li wrote: > >> > >> This patch set is to fix several issues of

Re: [PATCH v2] kdb: remove unnecessary null check of dbg_io_ops

2020-06-29 Thread Doug Anderson
Hi, On Mon, Jun 29, 2020 at 1:50 PM Cengiz Can wrote: > > `kdb_msg_write` operates on a global `struct kgdb_io *` called > `dbg_io_ops`. > > It's initialized in `debug_core.c` and checked throughout the debug > flow. > > There's a null check in `kdb_msg_write` which triggers static analyzers >

Re: [PATCH] kgdb: Resolve races during kgdb_io_register/unregister_module

2020-06-29 Thread Doug Anderson
Hi, On Mon, Jun 29, 2020 at 10:15 AM Daniel Thompson wrote: > > Currently kgdb_register_callbacks() and kgdb_unregister_callbacks() > are called outside the scope of the kgdb_registration_lock. This > allows them to race with each other. This could do all sorts of crazy > things up to and

<    1   2   3   4   5   6   7   8   9   10   >