to dma_alloc_wc().
Also check pb->mapped for non-NULL in the destroy function as that is the
right way of checking if dma_alloc_wc() was successful.
Signed-off-by: Emil Goode <emil@goode.io>
---
v2: - Change the phys member type instead of adding casts.
- Check pb->mapped in the destroy f
to dma_alloc_wc().
Also check pb->mapped for non-NULL in the destroy function as that is the
right way of checking if dma_alloc_wc() was successful.
Signed-off-by: Emil Goode
---
v2: - Change the phys member type instead of adding casts.
- Check pb->mapped in the destroy function as 0 is a valid
Hello,
On Mon, May 14, 2018 at 10:43:08AM +0200, Thierry Reding wrote:
> On Mon, Mar 26, 2018 at 04:44:14PM +0200, Emil Goode wrote:
> > The compiler is complaining with the following errors:
> >
> > drivers/gpu/host1x/cdma.c:94:48: error:
> > passing argume
Hello,
On Mon, May 14, 2018 at 10:43:08AM +0200, Thierry Reding wrote:
> On Mon, Mar 26, 2018 at 04:44:14PM +0200, Emil Goode wrote:
> > The compiler is complaining with the following errors:
> >
> > drivers/gpu/host1x/cdma.c:94:48: error:
> > passing argume
Hello,
On Mon, Mar 26, 2018 at 04:57:34PM +0200, Thierry Reding wrote:
> On Mon, Mar 26, 2018 at 04:44:14PM +0200, Emil Goode wrote:
> > The compiler is complaining with the following errors:
> >
> > drivers/gpu/host1x/cdma.c:94:48: error:
> > passing argume
Hello,
On Mon, Mar 26, 2018 at 04:57:34PM +0200, Thierry Reding wrote:
> On Mon, Mar 26, 2018 at 04:44:14PM +0200, Emil Goode wrote:
> > The compiler is complaining with the following errors:
> >
> > drivers/gpu/host1x/cdma.c:94:48: error:
> > passing argume
of ‘dma_alloc_wc’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
The expected pointer type of the third argument to dma_alloc_wc() is
dma_addr_t but phys_addr_t is passed. Fix this by adding casts to the
expected pointer type.
Signed-off-by: Emil Goode <emil@goode
of ‘dma_alloc_wc’ from incompatible pointer type
[-Werror=incompatible-pointer-types]
The expected pointer type of the third argument to dma_alloc_wc() is
dma_addr_t but phys_addr_t is passed. Fix this by adding casts to the
expected pointer type.
Signed-off-by: Emil Goode
---
drivers/gpu/host1x
gt;>> introduced a
> >>>>> regression causing the wlcore to time out and go into recovery.
> >>>>> Reverting the
> >>>>> changes regarding write of the last partition size brings the module
> >>>>> back to
> >>>
gt; >>>>> Reverting the
> >>>>> changes regarding write of the last partition size brings the module
> >>>>> back to
> >>>>> it's functional state.
> >>>>>
> >>>>> Fixes: 3719c17e1816 (&quo
onal state.
Reported-by: Ross Green
Signed-off-by: Emil Goode
---
drivers/net/wireless/ti/wlcore/io.c | 8
drivers/net/wireless/ti/wlcore/io.h | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wireless/ti/wlcore/io.c
b/drivers/net/wireless/ti/wlcore/
onal state.
Reported-by: Ross Green <rgker...@gmail.com>
Signed-off-by: Emil Goode <emil@goode.io>
---
drivers/net/wireless/ti/wlcore/io.c | 8
drivers/net/wireless/ti/wlcore/io.h | 4 ++--
2 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/net/wire
Hello Ross,
On Mon, Feb 08, 2016 at 07:26:34PM +1100, Ross Green wrote:
> On Mon, Feb 8, 2016 at 9:05 AM, Emil Goode wrote:
> > Hello,
> >
> > On Tue, Feb 02, 2016 at 05:05:38PM +0100, Sebastian Reichel wrote:
> >> On Tue, Feb 02, 2016 at 04:41:13PM +1100, Ross Gre
Hello Ross,
On Mon, Feb 08, 2016 at 07:26:34PM +1100, Ross Green wrote:
> On Mon, Feb 8, 2016 at 9:05 AM, Emil Goode <emil@goode.io> wrote:
> > Hello,
> >
> > On Tue, Feb 02, 2016 at 05:05:38PM +0100, Sebastian Reichel wrote:
> >> On Tue, Feb 02, 2016 a
> Here is a dmesg dump in the attachment.
> > >> >
> > >> > Anyone have any ideas here?
> >
> > [...]
> >
> > If I get time, this evening, I'll see if I can give a bisect a try.
>
> On N950 [wl1271 via SPI, using extra patches to init f
N950 [wl1271 via SPI, using extra patches to init from DT] I get wifi
> working again on 4.5-rc1 with 3719c17e1816 ("wlcore/wl18xx: fw logger
> over sdio") reverted.
Reverting the changes in wlcore_set_partition() as below seem to help.
Best regards,
Emil Goode
8<
:58, Emil Goode wrote:
> >In the brcmf_count_20mhz_channels function we are looping through a list
> >of channels received from firmware. Since the index of the first channel
> >is 0 the condition leads to an off by one bug. This is causing us to hit
> &g
discovered the bug.
Introduced by:
commit b48d891676f756d48b4d0ee131e4a7a5d43ca417
("brcmfmac: rework wiphy structure setup")
Acked-by: Arend van Spriel
Signed-off-by: Emil Goode
---
v2: Added Arends "Acked-by" tag.
drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c |
Hello Arend,
Ok I will resend with your ack.
Best regards,
Emil
On Mon, Sep 22, 2014 at 11:49:56AM +0200, Arend van Spriel wrote:
> On 09/21/14 00:58, Emil Goode wrote:
> >In the brcmf_count_20mhz_channels function we are looping through a list
> >of channels received from
Hello Arend,
Ok I will resend with your ack.
Best regards,
Emil
On Mon, Sep 22, 2014 at 11:49:56AM +0200, Arend van Spriel wrote:
On 09/21/14 00:58, Emil Goode wrote:
In the brcmf_count_20mhz_channels function we are looping through a list
of channels received from firmware. Since the index
discovered the bug.
Introduced by:
commit b48d891676f756d48b4d0ee131e4a7a5d43ca417
(brcmfmac: rework wiphy structure setup)
Acked-by: Arend van Spriel ar...@broadcom.com
Signed-off-by: Emil Goode emilgo...@gmail.com
---
v2: Added Arends Acked-by tag.
drivers/net/wireless/brcm80211/brcmfmac
, Emil Goode wrote:
In the brcmf_count_20mhz_channels function we are looping through a list
of channels received from firmware. Since the index of the first channel
is 0 the condition leads to an off by one bug. This is causing us to hit
the WARN_ON_ONCE(1) calls in the brcmu_d11n_decchspec
discovered the bug.
Introduced by:
commit b48d891676f756d48b4d0ee131e4a7a5d43ca417
("brcmfmac: rework wiphy structure setup")
Signed-off-by: Emil Goode
---
drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/d
discovered the bug.
Introduced by:
commit b48d891676f756d48b4d0ee131e4a7a5d43ca417
(brcmfmac: rework wiphy structure setup)
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/net/wireless/brcm80211/brcmfmac/wl_cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
Hello Greg and Geert,
On Thu, Jul 10, 2014 at 09:38:00AM +0200, Geert Uytterhoeven wrote:
> Hi Greg,
>
> On Thu, Jul 10, 2014 at 12:46 AM, Greg Kroah-Hartman
> wrote:
> > On Mon, Jun 02, 2014 at 07:45:25PM +0200, Emil Goode wrote:
> >> The variable err is not initia
Hello Greg and Geert,
On Thu, Jul 10, 2014 at 09:38:00AM +0200, Geert Uytterhoeven wrote:
Hi Greg,
On Thu, Jul 10, 2014 at 12:46 AM, Greg Kroah-Hartman
gre...@linuxfoundation.org wrote:
On Mon, Jun 02, 2014 at 07:45:25PM +0200, Emil Goode wrote:
The variable err is not initialized here
Hello Maciej,
I didn't know it was possible to go beyond commit 1da177e,
thank you for the info.
Best regards,
Emil
On Sun, Jul 06, 2014 at 12:16:38PM +0100, Maciej W. Rozycki wrote:
> On Sun, 6 Jul 2014, Emil Goode wrote:
>
> > > > diff --git a/arch/mips/mm/tlb-r3k.c b/arch
Hello Maciej,
I didn't know it was possible to go beyond commit 1da177e,
thank you for the info.
Best regards,
Emil
On Sun, Jul 06, 2014 at 12:16:38PM +0100, Maciej W. Rozycki wrote:
On Sun, 6 Jul 2014, Emil Goode wrote:
diff --git a/arch/mips/mm/tlb-r3k.c b/arch/mips/mm/tlb-r3k.c
of local_flush_tlb_page() don't bother checking if vma is NULL, also
vma is dereferenced before being passed to local_flush_tlb_page(),
thus it is safe to remove this NULL check.
Signed-off-by: Emil Goode
---
arch/mips/mm/tlb-r3k.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/mips
Hello,
On Sat, Jul 05, 2014 at 09:10:44PM +0200, Jonas Gorski wrote:
> On Sat, Jul 5, 2014 at 8:26 PM, Emil Goode wrote:
> > We check that the struct vm_area_struct pointer vma is NULL and then
> > dereference it a few lines below. The intent must have been to make sure
> >
We check that the struct vm_area_struct pointer vma is NULL and then
dereference it a few lines below. The intent must have been to make sure
that vma is not NULL and then to check the value from cpu_context() for
the condition to be true.
Signed-off-by: Emil Goode
---
v2: Updated the commit
We check that the struct vm_area_struct pointer vma is NULL and then
dereference it a few lines below. The intent must have been to make sure
that vma is not NULL and then to check the value from cpu_context() for
the condition to be true.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
v2
Hello,
On Sat, Jul 05, 2014 at 09:10:44PM +0200, Jonas Gorski wrote:
On Sat, Jul 5, 2014 at 8:26 PM, Emil Goode emilgo...@gmail.com wrote:
We check that the struct vm_area_struct pointer vma is NULL and then
dereference it a few lines below. The intent must have been to make sure
that vma
of local_flush_tlb_page() don't bother checking if vma is NULL, also
vma is dereferenced before being passed to local_flush_tlb_page(),
thus it is safe to remove this NULL check.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
arch/mips/mm/tlb-r3k.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
Hello Jonas,
On Fri, Jul 04, 2014 at 11:52:51PM +0200, Jonas Gorski wrote:
> On Fri, Jul 4, 2014 at 7:07 PM, Emil Goode wrote:
> > We check that the struct vm_area_struct pointer vma is NULL and
> > then dereference it. The intent must have been to check that
> > vma
Hello,
I noticed one more thing.
On Fri, Jul 04, 2014 at 07:07:48PM +0200, Rickard Strandqvist wrote:
> 2014-07-04 11:10 GMT+02:00 Emil Goode :
> > Hello Rickard,
> >
> > Since this is a probe function there is also no need to release the devm_*
> > resources in
We check that the struct vm_area_struct pointer vma is NULL and
then dereference it. The intent must have been to check that
vma is not NULL before we dereference it in the next condition.
Signed-off-by: Emil Goode
---
arch/mips/mm/tlb-r3k.c |2 +-
1 file changed, 1 insertion(+), 1 deletion
2,9 @@ static int i2c_pxa_probe(struct platform_device *dev)
> eadapt:
> if (!i2c->use_pio)
> free_irq(irq, i2c);
The free_irq() call should also be removed since devm_request_irq() was used.
> -ereqirq:
> - clk_disable_unprepare(i2c->clk);
> -
Hello Jonas,
On Fri, Jul 04, 2014 at 11:52:51PM +0200, Jonas Gorski wrote:
On Fri, Jul 4, 2014 at 7:07 PM, Emil Goode emilgo...@gmail.com wrote:
We check that the struct vm_area_struct pointer vma is NULL and
then dereference it. The intent must have been to check that
vma is not NULL
, resource_size(res));
+err_nothing_to_release:
return ret;
}
Best regards,
Emil Goode
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
We check that the struct vm_area_struct pointer vma is NULL and
then dereference it. The intent must have been to check that
vma is not NULL before we dereference it in the next condition.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
arch/mips/mm/tlb-r3k.c |2 +-
1 file changed, 1
Hello,
I noticed one more thing.
On Fri, Jul 04, 2014 at 07:07:48PM +0200, Rickard Strandqvist wrote:
2014-07-04 11:10 GMT+02:00 Emil Goode emilgo...@gmail.com:
Hello Rickard,
Since this is a probe function there is also no need to release the devm_*
resources in the i2c_pxa_remove
Hello Greg,
On Wed, Jul 02, 2014 at 09:33:34AM -0700, Greg Kroah-Hartman wrote:
> On Wed, Jul 02, 2014 at 11:25:51AM +0200, Emil Goode wrote:
> > We need to make sure the struct rtllib_device pointer ieee is not NULL
> > after the goto rx_dropped label since it
We need to make sure the struct rtllib_device pointer ieee is not NULL
after the goto rx_dropped label since it is dereferenced there.
Signed-off-by: Emil Goode
---
drivers/staging/rtl8192e/rtllib_rx.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging
We need to make sure the struct rtllib_device pointer ieee is not NULL
after the goto rx_dropped label since it is dereferenced there.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/staging/rtl8192e/rtllib_rx.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Hello Greg,
On Wed, Jul 02, 2014 at 09:33:34AM -0700, Greg Kroah-Hartman wrote:
On Wed, Jul 02, 2014 at 11:25:51AM +0200, Emil Goode wrote:
We need to make sure the struct rtllib_device pointer ieee is not NULL
after the goto rx_dropped label since it is dereferenced there.
Signed-off
/scsi/qla2xxx/qla_dbg.c:632:22: warning: duplicate [noderef]
drivers/scsi/qla2xxx/qla_target.c:1435:22: warning: duplicate [noderef]
Introduced by commit:
f73cb695d3eccd171f03ed194e72d67732b17487
("[SCSI] qla2xxx: Add support for ISP2071.")
Signed-off-by: Emil Goode
---
drivers/sc
/scsi/qla2xxx/qla_dbg.c:632:22: warning: duplicate [noderef]
drivers/scsi/qla2xxx/qla_target.c:1435:22: warning: duplicate [noderef]
Introduced by commit:
f73cb695d3eccd171f03ed194e72d67732b17487
([SCSI] qla2xxx: Add support for ISP2071.)
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers
This cleans up some line over 80 character violations.
Signed-off-by: Emil Goode
---
drivers/media/dvb-frontends/stb6100_cfg.h | 12
drivers/media/dvb-frontends/tda8261_cfg.h |9 ++---
2 files changed, 14 insertions(+), 7 deletions(-)
diff --git a/drivers/media/dvb
This removes checks of struct member addresses since they likely result
in the condition always being true. Also in the stb6100_get_bandwidth
and tda8261_get_bandwidth functions the pointers frontend_ops and
tuner_ops are assigned the same addresses twice.
Signed-off-by: Emil Goode
---
drivers
This cleans up some line over 80 character violations.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/media/dvb-frontends/stb6100_cfg.h | 12
drivers/media/dvb-frontends/tda8261_cfg.h |9 ++---
2 files changed, 14 insertions(+), 7 deletions(-)
diff --git
This removes checks of struct member addresses since they likely result
in the condition always being true. Also in the stb6100_get_bandwidth
and tda8261_get_bandwidth functions the pointers frontend_ops and
tuner_ops are assigned the same addresses twice.
Signed-off-by: Emil Goode emilgo
We use devm_kzalloc() to allocate memory for the struct vt8500lcd_info
pointer fbi, so there is no need to free it in vt8500lcd_remove().
Signed-off-by: Emil Goode
---
drivers/video/fbdev/vt8500lcdfb.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video/fbdev/vt8500lcdfb.c
b
We use devm_kzalloc() to allocate memory for the struct vt8500lcd_info
pointer fbi, so there is no need to free it in vt8500lcd_remove().
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/video/fbdev/vt8500lcdfb.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/video
The variable err is not initialized here, this patch uses it
to store an eventual error value from devm_clk_get().
Signed-off-by: Emil Goode
---
drivers/usb/misc/usb3503.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/misc/usb3503.c b/drivers/usb
The .owner member of struct device_driver is assigned THIS_MODULE twice.
Introduced by:
commit c44cb2edd01ca31471d9385f0895891b006ab904
("NFC: dts: st21nfca: Add device-tree (Open Firmware) support to st21nfca")
Signed-off-by: Emil Goode
---
drivers/nfc/st21nfca/i2c.c |1 -
1 fi
: driver: stmicro: Remove some useless the lock protection
This introduced the following sparse warning:
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c:424:1: warning:
context imbalance in 'stmmac_get_pauseparam' -
different lock contexts for basic block
Signed-off-by: Emil Goode
Signed-off-by: Emil Goode emilgo...@gmail.com
---
Hello,
Some spin_lock/unlock calls where also left behind in
stmmac_ethtool_setsettings(), I'm not sure if it was intentional?
Best regards,
Emil Goode
drivers/net/ethernet/stmicro/stmmac/stmmac_ethtool.c |2 --
1 file changed, 2 deletions
The .owner member of struct device_driver is assigned THIS_MODULE twice.
Introduced by:
commit c44cb2edd01ca31471d9385f0895891b006ab904
(NFC: dts: st21nfca: Add device-tree (Open Firmware) support to st21nfca)
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/nfc/st21nfca/i2c.c |1
The variable err is not initialized here, this patch uses it
to store an eventual error value from devm_clk_get().
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/usb/misc/usb3503.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/misc
.
commit 59a9f7a32adf6537b4e4db8ca204eeb77d7a634e
("mfd: menelaus: Use NULL instead of 0")
Signed-off-by: Emil Goode
---
v2: Changed (vtg_val == 0) to (!vtg_val)
drivers/mfd/menelaus.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/menelaus.c b/d
Hello,
On Wed, May 28, 2014 at 04:20:11PM +0100, Lee Jones wrote:
> On Wed, 28 May 2014, Emil Goode wrote:
>
> > The struct menelaus_vtg pointer vtg cannot be NULL here
> > so the condition is never true and if it ever was true
> > it would lead to a NULL pointer
.
commit 59a9f7a32adf6537b4e4db8ca204eeb77d7a634e
("mfd: menelaus: Use NULL instead of 0")
Signed-off-by: Emil Goode
---
Hello,
This is only build tested, it would be good to get a comment
from someone who is familiar with this code.
Found using coccinelle.
Best regards,
Emil Goode
d
.
commit 59a9f7a32adf6537b4e4db8ca204eeb77d7a634e
(mfd: menelaus: Use NULL instead of 0)
Signed-off-by: Emil Goode emilgo...@gmail.com
---
Hello,
This is only build tested, it would be good to get a comment
from someone who is familiar with this code.
Found using coccinelle.
Best regards,
Emil
Hello,
On Wed, May 28, 2014 at 04:20:11PM +0100, Lee Jones wrote:
On Wed, 28 May 2014, Emil Goode wrote:
The struct menelaus_vtg pointer vtg cannot be NULL here
so the condition is never true and if it ever was true
it would lead to a NULL pointer dereference when we goto
label
.
commit 59a9f7a32adf6537b4e4db8ca204eeb77d7a634e
(mfd: menelaus: Use NULL instead of 0)
Signed-off-by: Emil Goode emilgo...@gmail.com
---
v2: Changed (vtg_val == 0) to (!vtg_val)
drivers/mfd/menelaus.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/mfd/menelaus.c b
Hello,
On Mon, May 26, 2014 at 10:30:46PM +0300, Dan Carpenter wrote:
> On Mon, May 26, 2014 at 06:41:21PM +0200, Emil Goode wrote:
> > diff --git a/drivers/base/platform.c b/drivers/base/platform.c
> > index 9e9227e..dd1fa07 100644
> > --- a/drivers/base/platform.c
&
Hello Russell,
On Mon, May 26, 2014 at 05:51:05PM +0100, Russell King - ARM Linux wrote:
> On Mon, May 26, 2014 at 06:41:21PM +0200, Emil Goode wrote:
> > @@ -211,6 +215,7 @@ struct platform_device *platform_device_alloc(const
> > char *name, int id)
> >
the original patch, updated changelog and
generated new data structure layout info]
Signed-off-by: Emil Goode
---
drivers/base/platform.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index dd1fa07..ba98219 100644
using platform_device_alloc() and the
u64 .dma_mask of struct platform_object that it points to will be freed
when the release callback function platform_device_release is called.
Signed-off-by: Emil Goode
---
arch/arm/mach-imx/devices/platform-ipu-core.c |5 -
1 file changed, 5 deletions
/3480961/
[5]
http://lkml.kernel.org/r/1386886207-2735-1-git-send-email-ydrone...@opteya.com
Cc: Yann Droneaud
Cc: Uwe Kleine-König
Cc: Dmitry Torokhov
Cc: Greg Kroah-Hartman
Signed-off-by: Yann Droneaud
[Emil: split v4 of the patch in two and updated changelog]
Signed-off-by: Emil Goode
---
Hello
ydrone...@opteya.com
[Emil: split v4 of the patch in two and updated changelog]
Signed-off-by: Emil Goode emilgo...@gmail.com
---
Hello Greg,
The first two patches in the series are created from v4 of the
original patch, since I have not changed how the code works I think
it is correct to keep
using platform_device_alloc() and the
u64 .dma_mask of struct platform_object that it points to will be freed
when the release callback function platform_device_release is called.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
arch/arm/mach-imx/devices/platform-ipu-core.c |5 -
1 file
dmitry.torok...@gmail.com
Cc: Greg Kroah-Hartman gre...@linuxfoundation.org
Signed-off-by: Yann Droneaud ydrone...@opteya.com
[Emil: split the original patch, updated changelog and
generated new data structure layout info]
Signed-off-by: Emil Goode emilgo...@gmail.com
---
drivers/base/platform.c |4
Hello Russell,
On Mon, May 26, 2014 at 05:51:05PM +0100, Russell King - ARM Linux wrote:
On Mon, May 26, 2014 at 06:41:21PM +0200, Emil Goode wrote:
@@ -211,6 +215,7 @@ struct platform_device *platform_device_alloc(const
char *name, int id)
strcpy(pa-name, name
Hello,
On Mon, May 26, 2014 at 10:30:46PM +0300, Dan Carpenter wrote:
On Mon, May 26, 2014 at 06:41:21PM +0200, Emil Goode wrote:
diff --git a/drivers/base/platform.c b/drivers/base/platform.c
index 9e9227e..dd1fa07 100644
--- a/drivers/base/platform.c
+++ b/drivers/base/platform.c
ny one of the resulting two patches.
Perhaps keeping this information in the changelog is a good reason for
applying the patch as it is?
(I have attached the patch in question)
Best regards,
Emil Goode
>From 66b72cb8eb71974903dd40ed67a34412faf818f0 Mon Sep 17 00:00:00 2001
From: Yann Droneaud
Date: Mo
of the resulting two patches.
Perhaps keeping this information in the changelog is a good reason for
applying the patch as it is?
(I have attached the patch in question)
Best regards,
Emil Goode
From 66b72cb8eb71974903dd40ed67a34412faf818f0 Mon Sep 17 00:00:00 2001
From: Yann Droneaud ydrone...@opteya.com
Date
Hello Uwe,
On Thu, May 22, 2014 at 08:10:24PM +0200, Uwe Kleine-König wrote:
> Hello Emil,
>
> On Thu, May 22, 2014 at 07:51:19PM +0200, Emil Goode wrote:
> > We forgot to free pdev->dev.dma_mask on error after
> > having called the imx_alloc_mx3_camera function.
&
We forgot to free pdev->dev.dma_mask on error after
having called the imx_alloc_mx3_camera function.
This patch introduces the imx_free_mx3_camera function
that adds the missing kfree call and is practical for
future usage with imx_alloc_mx3_camera().
Signed-off-by: Emil Goode
---
arch/arm/m
Hello Dan,
On Thu, May 22, 2014 at 04:50:16PM +0300, Dan Carpenter wrote:
> On Thu, May 22, 2014 at 03:14:42PM +0200, Emil Goode wrote:
> > We forgot to free pdev->dev.dma_mask as it is not freed
> > by platform_device_put().
> >
>
> Every function which calls imx
We forgot to free pdev->dev.dma_mask as it is not freed
by platform_device_put().
Signed-off-by: Emil Goode
---
arch/arm/mach-imx/mach-mx31_3ds.c|4 +++-
arch/arm/mach-imx/mach-mx31moboard.c |4 +++-
arch/arm/mach-imx/mach-mx35_3ds.c|4 +++-
arch/arm/mach-imx/mach-pcm03
Hello Uwe,
On Mon, May 19, 2014 at 08:27:22AM +0200, Uwe Kleine-König wrote:
> Hello Emil,
>
> thanks for your effort.
>
> On Sun, May 18, 2014 at 10:51:00PM +0200, Emil Goode wrote:
> > This converts the imx camera allocation and initialization
Hello Uwe,
On Mon, May 19, 2014 at 08:27:22AM +0200, Uwe Kleine-König wrote:
Hello Emil,
thanks for your effort.
On Sun, May 18, 2014 at 10:51:00PM +0200, Emil Goode wrote:
This converts the imx camera allocation and initialization functions
to use platform_device_register_full() thus
We forgot to free pdev-dev.dma_mask as it is not freed
by platform_device_put().
Signed-off-by: Emil Goode emilgo...@gmail.com
---
arch/arm/mach-imx/mach-mx31_3ds.c|4 +++-
arch/arm/mach-imx/mach-mx31moboard.c |4 +++-
arch/arm/mach-imx/mach-mx35_3ds.c|4 +++-
arch/arm/mach
Hello Dan,
On Thu, May 22, 2014 at 04:50:16PM +0300, Dan Carpenter wrote:
On Thu, May 22, 2014 at 03:14:42PM +0200, Emil Goode wrote:
We forgot to free pdev-dev.dma_mask as it is not freed
by platform_device_put().
Every function which calls imx31_alloc_mx3_camera() is buggy
We forgot to free pdev-dev.dma_mask on error after
having called the imx_alloc_mx3_camera function.
This patch introduces the imx_free_mx3_camera function
that adds the missing kfree call and is practical for
future usage with imx_alloc_mx3_camera().
Signed-off-by: Emil Goode emilgo...@gmail.com
Hello Uwe,
On Thu, May 22, 2014 at 08:10:24PM +0200, Uwe Kleine-König wrote:
Hello Emil,
On Thu, May 22, 2014 at 07:51:19PM +0200, Emil Goode wrote:
We forgot to free pdev-dev.dma_mask on error after
having called the imx_alloc_mx3_camera function.
This patch introduces
Hello Uwe,
Thank you for the review and sorry for the late response.
On Mon, May 19, 2014 at 08:27:22AM +0200, Uwe Kleine-König wrote:
> Hello Emil,
>
> thanks for your effort.
>
> On Sun, May 18, 2014 at 10:51:00PM +0200, Emil Goode wrote:
> > This converts the
Hello Uwe,
Thank you for the review and sorry for the late response.
On Mon, May 19, 2014 at 08:27:22AM +0200, Uwe Kleine-König wrote:
Hello Emil,
thanks for your effort.
On Sun, May 18, 2014 at 10:51:00PM +0200, Emil Goode wrote:
This converts the imx camera allocation
backporting and git history.
Emil Goode (2):
ARM: imx: fix error handling in ipu device registration
ARM: imx: convert camera init to use platform_device_register_full()
arch/arm/mach-imx/devices/platform-ipu-core.c | 43 +
arch/arm/mach-imx/mach-mx31_3ds.c
This converts the imx camera allocation and initialization functions
to use platform_device_register_full() thus simplifying the code.
Signed-off-by: Emil Goode
---
Only build tested, unfortunately I currently don't have the hardware.
arch/arm/mach-imx/devices/platform-ipu-core.c | 43
If we fail to allocate struct platform_device pdev we
dereference it after the goto label err.
This bug was found using coccinelle.
Signed-off-by: Emil Goode
---
v4: Simplified version that just fixes the bug.
Also updated the changelog.
v3: Made subject line more specific.
v2: Changed
()
dma_declare_coherent_memory()
platform_device_add()
Sorry about the mistake!
Best regards,
Emil Goode
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
P
Hello Uwe,
On Sat, May 17, 2014 at 09:05:46PM +0200, Uwe Kleine-König wrote:
> Hello Emil,
>
> On Sat, May 17, 2014 at 05:35:40PM +0200, Emil Goode wrote:
> > On Fri, May 16, 2014 at 09:31:39PM +0200, Uwe Kleine-König wrote:
> > > On Fri, May 16, 2014 at 01:49:10PM +
Hello Uwe,
On Sat, May 17, 2014 at 09:05:46PM +0200, Uwe Kleine-König wrote:
Hello Emil,
On Sat, May 17, 2014 at 05:35:40PM +0200, Emil Goode wrote:
On Fri, May 16, 2014 at 09:31:39PM +0200, Uwe Kleine-König wrote:
On Fri, May 16, 2014 at 01:49:10PM +0200, walter harms wrote:
Am
()
dma_declare_coherent_memory()
platform_device_add()
Sorry about the mistake!
Best regards,
Emil Goode
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read
This converts the imx camera allocation and initialization functions
to use platform_device_register_full() thus simplifying the code.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
Only build tested, unfortunately I currently don't have the hardware.
arch/arm/mach-imx/devices/platform-ipu
If we fail to allocate struct platform_device pdev we
dereference it after the goto label err.
This bug was found using coccinelle.
Signed-off-by: Emil Goode emilgo...@gmail.com
---
v4: Simplified version that just fixes the bug.
Also updated the changelog.
v3: Made subject line more
backporting and git history.
Emil Goode (2):
ARM: imx: fix error handling in ipu device registration
ARM: imx: convert camera init to use platform_device_register_full()
arch/arm/mach-imx/devices/platform-ipu-core.c | 43 +
arch/arm/mach-imx/mach-mx31_3ds.c
1 - 100 of 270 matches
Mail list logo
