[trivial PATCH] Documentation/sparse: fix typo

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- Documentation/dev-tools/sparse.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/dev-tools/sparse.rst b/Documentation/dev-tools/sparse.rst index 78aa00a604a009071361..c401c952a340a50fa769

[trivial PATCH] Documentation/sparse: fix typo

Signed-off-by: Eric Engestrom --- Documentation/dev-tools/sparse.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Documentation/dev-tools/sparse.rst b/Documentation/dev-tools/sparse.rst index 78aa00a604a009071361..c401c952a340a50fa769 100644 --- a/Documentation/dev-tools

Re: [PATCH] video: fbdev: via: remove VLA usage

A. R. Silva <gust...@embeddedor.com> Sorry for my reply on v1, I missed that Emil already replied to another post of the same patch (side note on that, making use of `-vX` and `--in-reply-to` helps track the evolution of patches) This looks good to me: Reviewed-by: Eric Engestrom <eric.engest...@imgtec.c

Re: [PATCH] video: fbdev: via: remove VLA usage

Sorry for my reply on v1, I missed that Emil already replied to another post of the same patch (side note on that, making use of `-vX` and `--in-reply-to` helps track the evolution of patches) This looks good to me: Reviewed-by: Eric Engestrom > --- > drivers/video/fbdev/via/via_aux_sii164.c

Re: [PATCH] video: fbdev: via_aux_vt1636: remove VLA usage

On Wednesday, 2018-03-07 13:47:03 -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wvla, remove VLA and replace it > with a fixed-length array instead. Also, remove variable 'len'. > > Notice that no new IDs have been added in seven years. > > Signed-off-by: Gustavo A. R. Silva

Re: [PATCH] video: fbdev: via_aux_vt1636: remove VLA usage

On Wednesday, 2018-03-07 13:47:03 -0600, Gustavo A. R. Silva wrote: > In preparation to enabling -Wvla, remove VLA and replace it > with a fixed-length array instead. Also, remove variable 'len'. > > Notice that no new IDs have been added in seven years. > > Signed-off-by: Gustavo A. R. Silva >

Re: [PATCH] locking/ww_mutex: add ww_mutex_is_owned_by function v4

On Tuesday, 2018-02-20 15:49:46 +0100, Christian König wrote: > amdgpu needs to verify if userspace sends us valid addresses and the simplest > way of doing this is to check if the buffer object is locked with the ticket > of the current submission. > > Clean up the access to the ww_mutex

Re: [PATCH] locking/ww_mutex: add ww_mutex_is_owned_by function v4

On Tuesday, 2018-02-20 15:49:46 +0100, Christian König wrote: > amdgpu needs to verify if userspace sends us valid addresses and the simplest > way of doing this is to check if the buffer object is locked with the ticket > of the current submission. > > Clean up the access to the ww_mutex

Re: [PATCH] drm/vc4: clean up error handling on devm_kzalloc failure

> +++ b/drivers/gpu/drm/vc4/vc4_hdmi.c > @@ -311,14 +311,11 @@ static struct drm_connector > *vc4_hdmi_connector_init(struct drm_device *dev, > { > struct drm_connector *connector = NULL; This `= NULL` isn't needed anymore either. Reviewed-by: Eric Engestrom <eric

Re: [PATCH] drm/vc4: clean up error handling on devm_kzalloc failure

tic struct drm_connector > *vc4_hdmi_connector_init(struct drm_device *dev, > { > struct drm_connector *connector = NULL; This `= NULL` isn't needed anymore either. Reviewed-by: Eric Engestrom > struct vc4_hdmi_connector *hdmi_connector; > - in

Re: [PATCH] fbdev: make get_fb_unmapped_area depends of !MMU

On Monday, 2017-07-10 16:48:55 +0200, Benjamin Gaignard wrote: > Even if CONFIG_FB_PROVIDE_GET_FB_UNMAPPED_AREA flag is selected > do not compile and use get_fb_unmapped_area() if CONFIG_MMU is > also set. This will avoid mmap errors when compiling multi > architectures at same time. > >

Re: [PATCH] fbdev: make get_fb_unmapped_area depends of !MMU

On Monday, 2017-07-10 16:48:55 +0200, Benjamin Gaignard wrote: > Even if CONFIG_FB_PROVIDE_GET_FB_UNMAPPED_AREA flag is selected > do not compile and use get_fb_unmapped_area() if CONFIG_MMU is > also set. This will avoid mmap errors when compiling multi > architectures at same time. > >

Re: [PATCH] drm/pl111: Add a debugfs node to dump our registers.

On Wednesday, 2017-05-17 17:56:40 -0700, Eric Anholt wrote: > While debugging an X11 display failure, I wanted to see where we were > actually scanning out from. This is probably generally useful to > others that might be working on this device. > > Signed-off-by: Eric Anholt >

Re: [PATCH] drm/pl111: Add a debugfs node to dump our registers.

On Wednesday, 2017-05-17 17:56:40 -0700, Eric Anholt wrote: > While debugging an X11 display failure, I wanted to see where we were > actually scanning out from. This is probably generally useful to > others that might be working on this device. > > Signed-off-by: Eric Anholt > --- >

Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to drm_mode_legacy_fb_format

On Wednesday, 2017-04-26 07:53:10 +0200, Gerd Hoffmann wrote: > On Di, 2017-04-25 at 12:18 +0900, Michel Dänzer wrote: > > On 24/04/17 03:25 PM, Gerd Hoffmann wrote: > > > Return correct fourcc codes on bigendian. Drivers must be adapted to > > > this change. > > > > > > Signed-off-by: Gerd

Re: [PATCH 3/6] drm: fourcc byteorder: add bigendian support to drm_mode_legacy_fb_format

On Wednesday, 2017-04-26 07:53:10 +0200, Gerd Hoffmann wrote: > On Di, 2017-04-25 at 12:18 +0900, Michel Dänzer wrote: > > On 24/04/17 03:25 PM, Gerd Hoffmann wrote: > > > Return correct fourcc codes on bigendian. Drivers must be adapted to > > > this change. > > > > > > Signed-off-by: Gerd

Re: [RFC PATCH 04/12] staging: android: ion: Call dma_map_sg for syncing and mapping

On Friday, 2017-03-03 14:04:26 +0300, Dan Carpenter wrote: > On Thu, Mar 02, 2017 at 01:44:36PM -0800, Laura Abbott wrote: > > static struct sg_table *ion_map_dma_buf(struct dma_buf_attachment > > *attachment, > > enum dma_data_direction direction) > > { > >

Re: [RFC PATCH 04/12] staging: android: ion: Call dma_map_sg for syncing and mapping

On Friday, 2017-03-03 14:04:26 +0300, Dan Carpenter wrote: > On Thu, Mar 02, 2017 at 01:44:36PM -0800, Laura Abbott wrote: > > static struct sg_table *ion_map_dma_buf(struct dma_buf_attachment > > *attachment, > > enum dma_data_direction direction) > > { > >

Re: [PATCH] drm: drm_printer: add __printf validation

On Wednesday, 2017-02-15 15:33:18 -0800, Joe Perches wrote: > drm_printf does not currently use the compiler to verify > format and arguments. Make it do so. > > Miscellanea: > > o Add appropriate #include files for __printf and struct va_format > o Convert dev_printk to dev_info I think these

Re: [PATCH] drm: drm_printer: add __printf validation

On Wednesday, 2017-02-15 15:33:18 -0800, Joe Perches wrote: > drm_printf does not currently use the compiler to verify > format and arguments. Make it do so. > > Miscellanea: > > o Add appropriate #include files for __printf and struct va_format > o Convert dev_printk to dev_info I think these

Re: [PATCH v4] drm: add fourcc codes for 16bit R and RG

On Wednesday, 2017-01-04 14:50:02 +0100, Rainer Hochecker wrote: > From: Rainer Hochecker > > Signed-off-by: Rainer Hochecker > --- > include/uapi/drm/drm_fourcc.h | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git

Re: [PATCH v4] drm: add fourcc codes for 16bit R and RG

On Wednesday, 2017-01-04 14:50:02 +0100, Rainer Hochecker wrote: > From: Rainer Hochecker > > Signed-off-by: Rainer Hochecker > --- > include/uapi/drm/drm_fourcc.h | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h >

Re: [Intel-gfx] [PATCH v2] drm: add fourcc codes for 16bit R and GR

On Wednesday, 2017-01-04 11:06:09 +0200, Jani Nikula wrote: > On Wed, 04 Jan 2017, Daniel Vetter wrote: > > On Tue, Jan 03, 2017 at 08:02:07PM +0100, Rainer Hochecker wrote: > >> From: Rainer Hochecker > >> > >> Now sent with git send-email: > >> > >>

Re: [Intel-gfx] [PATCH v2] drm: add fourcc codes for 16bit R and GR

On Wednesday, 2017-01-04 11:06:09 +0200, Jani Nikula wrote: > On Wed, 04 Jan 2017, Daniel Vetter wrote: > > On Tue, Jan 03, 2017 at 08:02:07PM +0100, Rainer Hochecker wrote: > >> From: Rainer Hochecker > >> > >> Now sent with git send-email: > >> > >> Signed-off-by: Rainer Hochecker > >> ---

Re: [PATCH] drm: add fourcc codes for 16bit R and GR

On Tuesday, 2017-01-03 17:56:10 +0100, Rainer Hochecker wrote: > On Mon, Jan 2, 2017 at 3:31 PM, Rainer Hochecker wrote: > > > > I chose GR16 because that matches with Mesa texture formats. Unfortunately > > RG16 is already taken by DRM_FORMAT_RGB565 > > So GR32 / RG32 might

Re: [PATCH] drm: add fourcc codes for 16bit R and GR

On Tuesday, 2017-01-03 17:56:10 +0100, Rainer Hochecker wrote: > On Mon, Jan 2, 2017 at 3:31 PM, Rainer Hochecker wrote: > > > > I chose GR16 because that matches with Mesa texture formats. Unfortunately > > RG16 is already taken by DRM_FORMAT_RGB565 > > So GR32 / RG32 might be better. All other

[PATCH] drm/i915/gvt: fix deadlock in dispatch_workload()'s error path

90d27a1 moved the lock before this error path but forgot to add an unlock here. Fixes: 90d27a1b180e51ef0713 ("drm/i915/gvt: fix deadlock in workload_thread") Cc: Pei Zhang <pei.zh...@intel.com> Cc: Zhenyu Wang <zhen...@linux.intel.com> Signed-off-by: Eric Engest

[PATCH] drm/i915/gvt: fix deadlock in dispatch_workload()'s error path

90d27a1 moved the lock before this error path but forgot to add an unlock here. Fixes: 90d27a1b180e51ef0713 ("drm/i915/gvt: fix deadlock in workload_thread") Cc: Pei Zhang Cc: Zhenyu Wang Signed-off-by: Eric Engestrom --- drivers/gpu/drm/i915/gvt/scheduler.c | 1 + 1 file changed, 1

[PATCH v4] drm: move allocation out of drm_get_format_name()

<robdcl...@gmail.com> Acked-by: Sinclair Yeh <s...@vmware.com> (vmwgfx) Reviewed-by: Jani Nikula <jani.nik...@intel.com> Suggested-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- v4 - rebase on drm-next (d8c1abd968f

[PATCH v4] drm: move allocation out of drm_get_format_name()

Signed-off-by: Eric Engestrom --- v4 - rebase on drm-next (d8c1abd968f1c880ad8c) - add missed `const` to the return value v3 - fix "Fixes" tag, replace it with an actual commit message - collect ack & r-b v2 - use single-field struct instead of typedef to let the compiler enf

Re: [PATCH] drm/atomic: fix memory leak when fetching format name

On Friday, 2016-11-11 16:26:22 +, Colin King wrote: > From: Colin Ian King > > drm_get_format_name allocates memory that is not currently free'd > when printing the state. Fix this by kfree'ing the memory after > use. You are correct, but there are more cases of

Re: [PATCH] drm/atomic: fix memory leak when fetching format name

On Friday, 2016-11-11 16:26:22 +, Colin King wrote: > From: Colin Ian King > > drm_get_format_name allocates memory that is not currently free'd > when printing the state. Fix this by kfree'ing the memory after > use. You are correct, but there are more cases of this, and another fix has

Re: [Intel-gfx] [PATCH v3] drm: move allocation out of drm_get_format_name()

On Wednesday, 2016-11-09 14:13:40 +0100, Daniel Vetter wrote: > On Wed, Nov 9, 2016 at 12:42 PM, Eric Engestrom > <eric.engest...@imgtec.com> wrote: > >> Well, had to drop it again since it didn't compile: > >> > >> > >> CC [M] drivers/gpu/d

Re: [Intel-gfx] [PATCH v3] drm: move allocation out of drm_get_format_name()

On Wednesday, 2016-11-09 14:13:40 +0100, Daniel Vetter wrote: > On Wed, Nov 9, 2016 at 12:42 PM, Eric Engestrom > wrote: > >> Well, had to drop it again since it didn't compile: > >> > >> > >> CC [M] drivers/gpu/drm/drm_blend.o >

Re: [Intel-gfx] [PATCH v3] drm: move allocation out of drm_get_format_name()

On Wednesday, 2016-11-09 02:13:25 +0100, Daniel Vetter wrote: > On Wed, Nov 09, 2016 at 02:09:16AM +0100, Daniel Vetter wrote: > > On Wed, Nov 09, 2016 at 12:17:52AM +0000, Eric Engestrom wrote: > > > The function's behaviour was changed in 90844f00049e, without changing &

Re: [Intel-gfx] [PATCH v3] drm: move allocation out of drm_get_format_name()

On Wednesday, 2016-11-09 02:13:25 +0100, Daniel Vetter wrote: > On Wed, Nov 09, 2016 at 02:09:16AM +0100, Daniel Vetter wrote: > > On Wed, Nov 09, 2016 at 12:17:52AM +0000, Eric Engestrom wrote: > > > The function's behaviour was changed in 90844f00049e, without changing &

[PATCH v3] drm: move allocation out of drm_get_format_name()

<robdcl...@gmail.com> Acked-by: Sinclair Yeh <s...@vmware.com> (vmwgfx) Reviewed-by: Jani Nikula <jani.nik...@intel.com> Suggested-by: Ville Syrjälä <ville.syrj...@linux.intel.com> Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- v3 - fix "Fixes" tag, repla

[PATCH v3] drm: move allocation out of drm_get_format_name()

Signed-off-by: Eric Engestrom --- v3 - fix "Fixes" tag, replace it with an actual commit message - collect ack & r-b v2 - use single-field struct instead of typedef to let the compiler enforce the type (Christian König) --- include/drm/drm_fourcc.h| 10

Re: [PATCH v2] drm: move allocation out of drm_get_format_name()

On Monday, 2016-11-07 10:10:13 +0200, Jani Nikula wrote: > On Mon, 07 Nov 2016, Eric Engestrom <e...@engestrom.ch> wrote: > > Fixes: 90844f00049e9f42573fd31d7c32e8fd31d3fd07 > > > > drm: make drm_get_format_name thread-safe > > > > Signed-of

Re: [PATCH v2] drm: move allocation out of drm_get_format_name()

On Monday, 2016-11-07 10:10:13 +0200, Jani Nikula wrote: > On Mon, 07 Nov 2016, Eric Engestrom wrote: > > Fixes: 90844f00049e9f42573fd31d7c32e8fd31d3fd07 > > > > drm: make drm_get_format_name thread-safe > > > > Signed-off-by: Eric Engestrom > >

Re: [PATCH] drm: move allocation out of drm_get_format_name()

On Sunday, 2016-11-06 08:03:47 -0500, Rob Clark wrote: > On Sun, Nov 6, 2016 at 4:47 AM, Christian König > <christian.koe...@amd.com> wrote: > > Am 05.11.2016 um 17:49 schrieb Rob Clark: > >> > >> On Sat, Nov 5, 2016 at 12:38 PM, Eric Engestrom <e...@enges

Re: [PATCH] drm: move allocation out of drm_get_format_name()

On Sunday, 2016-11-06 08:03:47 -0500, Rob Clark wrote: > On Sun, Nov 6, 2016 at 4:47 AM, Christian König > wrote: > > Am 05.11.2016 um 17:49 schrieb Rob Clark: > >> > >> On Sat, Nov 5, 2016 at 12:38 PM, Eric Engestrom wrote: > >>> > >>> O

[PATCH v2] drm: move allocation out of drm_get_format_name()

Fixes: 90844f00049e9f42573fd31d7c32e8fd31d3fd07 drm: make drm_get_format_name thread-safe Signed-off-by: Eric Engestrom <e...@engestrom.ch> [danvet: Clarify that the returned pointer must be freed with kfree().] Signed-off-by: Daniel Vetter <daniel.vet...@ffwll.ch&

[PATCH v2] drm: move allocation out of drm_get_format_name()

Fixes: 90844f00049e9f42573fd31d7c32e8fd31d3fd07 drm: make drm_get_format_name thread-safe Signed-off-by: Eric Engestrom [danvet: Clarify that the returned pointer must be freed with kfree().] Signed-off-by: Daniel Vetter Cc: Rob Clark Cc: Christian König Suggested

Re: [PATCH] drm: move allocation out of drm_get_format_name()

On Saturday, 2016-11-05 13:11:36 +0100, Christian König wrote: > Am 05.11.2016 um 02:33 schrieb Eric Engestrom: > > +typedef char drm_format_name_buf[32]; > > Please don't use a typedef for this, just define the maximum size of > characters the function might write somewhere. &

Re: [PATCH] drm: move allocation out of drm_get_format_name()

On Saturday, 2016-11-05 13:11:36 +0100, Christian König wrote: > Am 05.11.2016 um 02:33 schrieb Eric Engestrom: > > +typedef char drm_format_name_buf[32]; > > Please don't use a typedef for this, just define the maximum size of > characters the function might write somewhere. &

[PATCH] drm: move allocation out of drm_get_format_name()

Fixes: 90844f00049e9f42573fd31d7c32e8fd31d3fd07 drm: make drm_get_format_name thread-safe Signed-off-by: Eric Engestrom <e...@engestrom.ch> [danvet: Clarify that the returned pointer must be freed with kfree().] Signed-off-by: Daniel Vetter <daniel.vet...@ffwll.ch>

[PATCH] drm: move allocation out of drm_get_format_name()

Fixes: 90844f00049e9f42573fd31d7c32e8fd31d3fd07 drm: make drm_get_format_name thread-safe Signed-off-by: Eric Engestrom [danvet: Clarify that the returned pointer must be freed with kfree().] Signed-off-by: Daniel Vetter Suggested-by: Ville Syrjälä Signed-off-by: Eric

[PATCH variant 1] drm: make drm_get_format_name atomic/irq safe again

Fixes: 90844f00049e9f42573fd31d7c32e8fd31d3fd07 drm: make drm_get_format_name thread-safe Signed-off-by: Eric Engestrom <e...@engestrom.ch> [danvet: Clarify that the returned pointer must be freed with kfree().] Signed-off-by: Daniel Vetter <daniel.vet...@ffwll.ch>

[PATCH variant 1] drm: make drm_get_format_name atomic/irq safe again

Fixes: 90844f00049e9f42573fd31d7c32e8fd31d3fd07 drm: make drm_get_format_name thread-safe Signed-off-by: Eric Engestrom [danvet: Clarify that the returned pointer must be freed with kfree().] Signed-off-by: Daniel Vetter Note (Rob Clark): I think we need to be a bit

Re: [PATCH] i915: don't call drm_atomic_state_put on invalid pointer

> Fixes: 0853695c3ba4 ("drm: Add reference counting to drm_atomic_state") > Cc: Chris Wilson <ch...@chris-wilson.co.uk> > Cc: Daniel Vetter <daniel.vet...@ffwll.ch> > Signed-off-by: Arnd Bergmann <a...@arndb.de> Reviewed-by: Eric Engestrom <eric.engest.

Re: [PATCH] i915: don't call drm_atomic_state_put on invalid pointer

> Fixes: 0853695c3ba4 ("drm: Add reference counting to drm_atomic_state") > Cc: Chris Wilson > Cc: Daniel Vetter > Signed-off-by: Arnd Bergmann Reviewed-by: Eric Engestrom > --- > drivers/gpu/drm/i915/intel_display.c | 5 +++-- > 1 file changed, 3 inse

Re: [patch] drm/i915: fix a read size argument

fe5a66f91c88 ("drm/i915: Read PSR caps/intermediate freqs/etc. only > once on eDP") > Signed-off-by: Dan Carpenter <dan.carpen...@oracle.com> Good catch! What tool did you use to find it, or did you find it by inspection? Reviewed-by: Eric Engestrom <eric.engest...@i

Re: [patch] drm/i915: fix a read size argument

fe5a66f91c88 ("drm/i915: Read PSR caps/intermediate freqs/etc. only > once on eDP") > Signed-off-by: Dan Carpenter Good catch! What tool did you use to find it, or did you find it by inspection? Reviewed-by: Eric Engestrom (btw, there's a missing `---` here, between the commi

[PATCH v2] debugfs: propagate release() call result

The result was being ignored and 0 was always returned. Return the actual result instead. Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- v2: add a commit message --- fs/debugfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/debugfs/file.

[PATCH v2] debugfs: propagate release() call result

The result was being ignored and 0 was always returned. Return the actual result instead. Signed-off-by: Eric Engestrom --- v2: add a commit message --- fs/debugfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index 592059f

Re: [PATCH] debugfs: remove unused variable

On Wed, Sep 21, 2016 at 10:50:38AM +0200, Nicolai Stange wrote: > Greg Kroah-Hartman <gre...@linuxfoundation.org> writes: > > > On Tue, Sep 20, 2016 at 05:17:15PM +0100, Eric Engestrom wrote: > >> Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> >

Re: [PATCH] debugfs: remove unused variable

On Wed, Sep 21, 2016 at 10:50:38AM +0200, Nicolai Stange wrote: > Greg Kroah-Hartman writes: > > > On Tue, Sep 20, 2016 at 05:17:15PM +0100, Eric Engestrom wrote: > >> Signed-off-by: Eric Engestrom > >> --- > >> fs/debugfs/file.c | 3 +-- > >&

[PATCH] debugfs: propagate release() call result

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- fs/debugfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index 592059f..40e586f 100644 --- a/fs/debugfs/file.c +++ b/fs/debugfs/file.c @@ -209,7 +209,7 @@ stat

Re: [PATCH] debugfs: remove unused variable

On Wed, Sep 21, 2016 at 10:01:11AM +0200, Greg Kroah-Hartman wrote: > On Tue, Sep 20, 2016 at 05:17:15PM +0100, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> > > --- > > fs/debugfs/file.c | 3 +-- > > 1 file cha

Re: [PATCH] debugfs: remove unused variable

On Wed, Sep 21, 2016 at 10:01:11AM +0200, Greg Kroah-Hartman wrote: > On Tue, Sep 20, 2016 at 05:17:15PM +0100, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > > --- > > fs/debugfs/file.c | 3 +-- > > 1 file changed, 1 insertion(+), 2 deletions(-) >

[PATCH] debugfs: propagate release() call result

Signed-off-by: Eric Engestrom --- fs/debugfs/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index 592059f..40e586f 100644 --- a/fs/debugfs/file.c +++ b/fs/debugfs/file.c @@ -209,7 +209,7 @@ static int full_proxy_release(struct

[PATCH] rcu: add missing prototype

`make W=1` warns: kernel/rcu/tree.c:226:15: warning: no previous prototype for ‘rcu_rnp_online_cpus’ [-Wmissing-prototypes] unsigned long rcu_rnp_online_cpus(struct rcu_node *rnp) ^~~ Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- I couldn't

[PATCH] rcu: add missing prototype

`make W=1` warns: kernel/rcu/tree.c:226:15: warning: no previous prototype for ‘rcu_rnp_online_cpus’ [-Wmissing-prototypes] unsigned long rcu_rnp_online_cpus(struct rcu_node *rnp) ^~~ Signed-off-by: Eric Engestrom --- I couldn't figure out how this list

[PATCH] debugfs: remove unused variable

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- fs/debugfs/file.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index 592059f..04eca0b 100644 --- a/fs/debugfs/file.c +++ b/fs/debugfs/file.c @@ -195,7 +195,6 @@ stat

[PATCH] debugfs: remove unused variable

Signed-off-by: Eric Engestrom --- fs/debugfs/file.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/debugfs/file.c b/fs/debugfs/file.c index 592059f..04eca0b 100644 --- a/fs/debugfs/file.c +++ b/fs/debugfs/file.c @@ -195,7 +195,6 @@ static int full_proxy_release(struct

[PATCH 2/2] ext4: remove unused variable

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- fs/ext4/page-io.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c index a6132a7..b4cbee9 100644 --- a/fs/ext4/page-io.c +++ b/fs/ext4/page-io.c @@ -405,14 +405,12

[PATCH 1/2] ext4: remove unused variable

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- fs/ext4/dir.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c index 67415e0..acd76f1 100644 --- a/fs/ext4/dir.c +++ b/fs/ext4/dir.c @@ -627,7 +627,7 @@ int ext4_check_all_de(

[PATCH 2/2] ext4: remove unused variable

Signed-off-by: Eric Engestrom --- fs/ext4/page-io.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/fs/ext4/page-io.c b/fs/ext4/page-io.c index a6132a7..b4cbee9 100644 --- a/fs/ext4/page-io.c +++ b/fs/ext4/page-io.c @@ -405,14 +405,12 @@ int ext4_bio_write_page(struct

[PATCH 1/2] ext4: remove unused variable

Signed-off-by: Eric Engestrom --- fs/ext4/dir.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/fs/ext4/dir.c b/fs/ext4/dir.c index 67415e0..acd76f1 100644 --- a/fs/ext4/dir.c +++ b/fs/ext4/dir.c @@ -627,7 +627,7 @@ int ext4_check_all_de(struct inode *dir, struct

Re: [PATCH v2] skd: fix assert typo

On Fri, Sep 16, 2016 at 08:40:54AM -0400, Jeff Moyer wrote: > Eric Engestrom <eric.engest...@imgtec.com> writes: > > > The assert was missing a `!` to become active, but since that would only > > turn > > it into a complicated codepath for a pr_err(), let's simply r

Re: [PATCH v2] skd: fix assert typo

On Fri, Sep 16, 2016 at 08:40:54AM -0400, Jeff Moyer wrote: > Eric Engestrom writes: > > > The assert was missing a `!` to become active, but since that would only > > turn > > it into a complicated codepath for a pr_err(), let's simply replace it. > > The sk

[PATCH v2] skd: fix assert typo

The assert was missing a `!` to become active, but since that would only turn it into a complicated codepath for a pr_err(), let's simply replace it. CC: Jeff Moyer <jmo...@redhat.com> Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- drivers/block/skd_main.c | 4 ++-- 1

[PATCH v2] skd: fix assert typo

The assert was missing a `!` to become active, but since that would only turn it into a complicated codepath for a pr_err(), let's simply replace it. CC: Jeff Moyer Signed-off-by: Eric Engestrom --- drivers/block/skd_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

[PATCH] skd: fix assert typo

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- drivers/block/skd_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index 3822eae..94a7425 100644 --- a/drivers/block/skd_main.c +++ b/drivers

[PATCH] skd: fix assert typo

Signed-off-by: Eric Engestrom --- drivers/block/skd_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/block/skd_main.c b/drivers/block/skd_main.c index 3822eae..94a7425 100644 --- a/drivers/block/skd_main.c +++ b/drivers/block/skd_main.c @@ -1905,7 +1905,7

[FIXUP] drm: remove `const` attribute to hint at caller that they now own the memory

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 +- drivers/gpu/drm/drm_atomic.c| 2 +- drive

[FIXUP] drm: remove `const` attribute to hint at caller that they now own the memory

Signed-off-by: Eric Engestrom --- drivers/gpu/drm/amd/amdgpu/dce_v10_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v11_0.c | 2 +- drivers/gpu/drm/amd/amdgpu/dce_v8_0.c | 2 +- drivers/gpu/drm/drm_atomic.c| 2 +- drivers/gpu/drm/drm_crtc.c

Re: [PATCH] drm: make drm_get_format_name thread-safe

On Mon, Aug 15, 2016 at 03:52:07PM +0200, Daniel Vetter wrote: > On Mon, Aug 15, 2016 at 04:13:54PM +0300, Jani Nikula wrote: > > On Mon, 15 Aug 2016, Eric Engestrom <eric.engest...@imgtec.com> wrote: > > > On Mon, Aug 15, 2016 at 12:54:01PM +0300, Jani Nikula wrote: &g

Re: [PATCH] drm: make drm_get_format_name thread-safe

On Mon, Aug 15, 2016 at 03:52:07PM +0200, Daniel Vetter wrote: > On Mon, Aug 15, 2016 at 04:13:54PM +0300, Jani Nikula wrote: > > On Mon, 15 Aug 2016, Eric Engestrom wrote: > > > On Mon, Aug 15, 2016 at 12:54:01PM +0300, Jani Nikula wrote: > > >> On Mon, 15 A

Re: [PATCH] drm: make drm_get_format_name thread-safe

On Mon, Aug 15, 2016 at 12:54:01PM +0300, Jani Nikula wrote: > On Mon, 15 Aug 2016, Eric Engestrom <e...@engestrom.ch> wrote: > > Signed-off-by: Eric Engestrom <e...@engestrom.ch> > > --- > > > > I moved the main bits to be the first diffs, shouldn't affe

Re: [PATCH] drm: make drm_get_format_name thread-safe

On Mon, Aug 15, 2016 at 12:54:01PM +0300, Jani Nikula wrote: > On Mon, 15 Aug 2016, Eric Engestrom wrote: > > Signed-off-by: Eric Engestrom > > --- > > > > I moved the main bits to be the first diffs, shouldn't affect anything > > when applying the patch, but

[PATCH] drm: make drm_get_format_name thread-safe

Signed-off-by: Eric Engestrom <e...@engestrom.ch> --- I moved the main bits to be the first diffs, shouldn't affect anything when applying the patch, but I wanted to ask: I don't like the hard-coded `32` the appears in both kmalloc() and snprintf(), what do you think? If you don't like it

[PATCH] drm: make drm_get_format_name thread-safe

Signed-off-by: Eric Engestrom --- I moved the main bits to be the first diffs, shouldn't affect anything when applying the patch, but I wanted to ask: I don't like the hard-coded `32` the appears in both kmalloc() and snprintf(), what do you think? If you don't like it either, what would you

Re: [PATCH v3 4/5] staging/android: add Doc for SW_SYNC ioctl interface

ation > internally. This is to prevent misuse of this feature. > > v2: take in Eric suggestions for the Documentation > > Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> > Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > drivers/staging/andro

Re: [PATCH v3 4/5] staging/android: add Doc for SW_SYNC ioctl interface

of this feature. > > v2: take in Eric suggestions for the Documentation > > Signed-off-by: Gustavo Padovan > Reviewed-by: Eric Engestrom > --- > drivers/staging/android/sw_sync.c | 31 +++ > 1 file changed, 31 insertions(+) > > diff -

Re: [PATCH v2 6/6] dma-buf/sw_sync: de-stage SW_SYNC

ation and release of a sync > timeline. To create fences on this timeline the SW_SYNC_IOC_CREATE_FENCE > ioctl should be used. To increment the timeline value use SW_SYNC_IOC_INC. > > Also it exports Sync information on > > /sync/info > > Signed-off-by: Gustavo Padovan <gustavo

Re: [PATCH v2 6/6] dma-buf/sw_sync: de-stage SW_SYNC

meline. To create fences on this timeline the SW_SYNC_IOC_CREATE_FENCE > ioctl should be used. To increment the timeline value use SW_SYNC_IOC_INC. > > Also it exports Sync information on > > /sync/info > > Signed-off-by: Gustavo Padovan Reviewed-by: Eric Engestrom > -

Re: [PATCH v2 5/6] staging/android: add Doc for SW_SYNC ioctl interface

d signal any fence that has seqno, smaller of equal > + * it. This last paragraph could use some love: comma before "SW_SYNC_IOC_INC", "that has seqno smaller or equal to it." > + * > + * struct sw_sync_ioctl_create_fence > + * @value: the seqno to initiate the fenc

Re: [PATCH v2 5/6] staging/android: add Doc for SW_SYNC ioctl interface

h could use some love: comma before "SW_SYNC_IOC_INC", "that has seqno smaller or equal to it." > + * > + * struct sw_sync_ioctl_create_fence > + * @value: the seqno to initiate the fence with s/initiate/initialise/ With these fixed, Reviewed-by: Eric Enge

Re: [PATCH v2 4/6] staging/android: prepare sw_sync files for de-staging

index 5b82cf8..ee3c27b 100644 > --- a/drivers/staging/android/sync_debug.h > +++ b/drivers/staging/android/sync_debug.h > @@ -1,5 +1,5 @@ > /* > - * include/linux/sync.h > + * Sync File validation framework "and debug information" With that added, Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > * > * Copyright (C) 2012 Google, Inc. > * > -- > 2.5.5

Re: [PATCH v2 4/6] staging/android: prepare sw_sync files for de-staging

++ b/drivers/staging/android/sync_debug.h > @@ -1,5 +1,5 @@ > /* > - * include/linux/sync.h > + * Sync File validation framework "and debug information" With that added, Reviewed-by: Eric Engestrom > * > * Copyright (C) 2012 Google, Inc. > * > -- > 2.5.5

Re: [PATCH v2 3/6] staging/android: move trace/sync.h to sync_trace.h

; Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Reviewed-by: Eric Engestrom <eric.engest...@imgtec.com> > --- > drivers/staging/android/sw_sync.c| 2 +- > drivers/staging/android/sync_trace.h | 32

Re: [PATCH v2 3/6] staging/android: move trace/sync.h to sync_trace.h

On Mon, Aug 08, 2016 at 06:24:19PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > The common behaviour for trace headers is to have them in the same folder > they are used, instead of creating a special trace/ directory. > > Signed-off-by: Gustavo Padovan

Re: [PATCH v2 0/6] de-stage SW_SYNC validation frawework

On Mon, Aug 08, 2016 at 06:24:16PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Hi Greg, > > This is the last step in the Sync Framwork de-stage task. It de-stage > the SW_SYNC validation framework and the sync_debug info debugfs file. > > The

Re: [PATCH v2 0/6] de-stage SW_SYNC validation frawework

On Mon, Aug 08, 2016 at 06:24:16PM -0300, Gustavo Padovan wrote: > From: Gustavo Padovan > > Hi Greg, > > This is the last step in the Sync Framwork de-stage task. It de-stage > the SW_SYNC validation framework and the sync_debug info debugfs file. > > The first 2 patches are clean up and

[PATCH 2/2] netfilter: add missing macro

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- This can't compile without this macro… Is this header really used by anyone? Should it be removed, to avoid bit-rot? --- include/uapi/linux/netfilter/xt_sctp.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi

[PATCH 2/2] netfilter: add missing macro

Signed-off-by: Eric Engestrom --- This can't compile without this macro… Is this header really used by anyone? Should it be removed, to avoid bit-rot? --- include/uapi/linux/netfilter/xt_sctp.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/include/uapi/linux/netfilter/xt_sctp.h b

[PATCH 1/2] libnvdimm: add missing macros

Signed-off-by: Eric Engestrom <eric.engest...@imgtec.com> --- This can't compile without these macros… Is this header really used by anyone? Should it be removed, to avoid bit-rot? --- include/uapi/linux/ndctl.h | 8 1 file changed, 8 insertions(+) diff --git a/include/uapi

[PATCH 1/2] libnvdimm: add missing macros

Signed-off-by: Eric Engestrom --- This can't compile without these macros… Is this header really used by anyone? Should it be removed, to avoid bit-rot? --- include/uapi/linux/ndctl.h | 8 1 file changed, 8 insertions(+) diff --git a/include/uapi/linux/ndctl.h b/include/uapi/linux

  1   2   3   >