Hi,
Yes, you are touching a good point where things can be improved. I admit that I
did not have a look at the code yet, if not very quickly. Perhaps I'm missing
somethin. However, let me give you my two cents based on what I usually do.
I do not like the idea of adding tags to the file and
ocs: make reporting-bugs.rst obsolete")
commit 4f8af077a02e ("docs: Fix reST markup when linking to sections")
commit 3a4928cf5e3c ("Documentation: kernel-hacking: change 'current()' to
'current'")
commit c170f2eb9648 ("docs: Document cross-referencing between documentation
page
le.
Fixes: d2ce285378b0 ("docs: make reporting-issues.rst official and
delete reporting-bugs.rst")
Acked-by: Wu XiangCheng
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/translations/it_IT/process/howto.rst | 2 +-
Acked-by: Federico Vaga
Documentation/translat
le.
Fixes: d2ce285378b0 ("docs: make reporting-issues.rst official and
delete reporting-bugs.rst")
Signed-off-by: Mauro Carvalho Chehab
---
Documentation/translations/it_IT/process/howto.rst | 2 +-
Acked-by: Federico Vaga
Documentation/translations/ja_JP/howto.rst
s/zh_CN/admin-guide/reporting-issues.rst:
Documentation/admin-guide/reporting-bugs.rst
As it will call the ./scripts/documentation-file-ref-check.
That's basically why I detected and submitted a fix ;-)
Thanks,
Mauro
--
Federico Vaga
http://www.federicovaga.it/
| 2 +-
Documentation/translations/it_IT/process/submit-checklist.rst | 2 +-
Documentation/translations/zh_CN/process/4.Coding.rst | 2 +-
drivers/gpu/drm/tilcdc/Makefile | 2 +-
6 files changed, 6 insertions(+), 6 deletions(-)
Acked-by: Federico Vaga
--
Federico
that's OK for the italian transation
--
Federico Vaga
("docs: process: Add cross-link to security-bugs")
commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning")
commit f67281a72b30 ("Documentation: process: step 2: Link to email list fixed")
Signed-off-by: Federico Vaga
---
v2: added mi
On 2020-11-13 22:53, Jonathan Corbet wrote:
On Fri, 13 Nov 2020 14:36:38 +0100
Federico Vaga wrote:
Translation for the following patches
commit 905705a8fd43 ("docs: programming-languages: refresh blurb on
clang support")
commit 5ff4aa70bf34 ("docs: submitting-pa
n-off process")
commit 7433ff33e8ba ("Documentation/process: expand plain-text advice")
commit eb45fb2fb16d ("docs: process: Add cross-link to security-bugs")
commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning")
commit f67281a72b30 (&qu
n-off process")
commit 7433ff33e8ba ("Documentation/process: expand plain-text advice")
commit eb45fb2fb16d ("docs: process: Add cross-link to security-bugs")
commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning")
commit f67281a72b30 (&qu
a namespace tag there, in order to prevent that.
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Federico Vaga
---
Documentation/translations/it_IT/kernel-hacking/locking.rst | 2 ++
1 file changed, 2 insertions(+)
diff --git
a/Documentation/translations/it_IT/kernel-hacking/locking.rst
b
iante per
la famiglia di conversioni "in-situ", come :c:func:`cpu_to_be32s
--^
Signed-off-by: Mauro Carvalho Chehab
Acked-by: Federico Vaga
---
Documentation/translations/it_IT/kernel-hacking/hacking.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(
sure, no problem
On 2020-09-10 18:58, Jonathan Corbet wrote:
On Thu, 10 Sep 2020 00:38:39 +0200
Federico Vaga wrote:
Translation for the following patches
commit 68e4cd17e218 ("docs: deprecated.rst: Add zero-length and
one-element arrays")
commit 5429ef62bcf3 ("compiler/gcc
Patch generated with
./scripts/documentation-file-ref-check --fix
Signed-off-by: Federico Vaga
---
.../bindings/display/tilcdc/tilcdc.txt | 2 +-
.../devicetree/bindings/media/i2c/tvp5150.txt| 2 +-
.../bindings/soc/qcom/qcom,smd-rpm.yaml | 2 +-
Documentation
for creating a fixes tag")
commit 858e6845654d ("docs: dt: convert submitting-patches.txt to ReST format")
commit bdc48fa11e46 ("checkpatch/coding-style: deprecate 80-column warning")
commit cca73e4946c4 ("docs: Correct the release date of 5.2 stable")
Signed-
Of course, you are right! Thanks
On 2020-07-15 14:23, Lee Jones wrote:
Flag is __maybe_unused, not __maybe_used.
Cc: Federico Vaga
Cc: Jonathan Corbet
Cc: linux-...@vger.kernel.org
Cc: clang-built-li...@googlegroups.com
Signed-off-by: Lee Jones
---
Documentation/translations/it_IT/process
On Mon, Jun 22, 2020 at 02:01:12PM +0200, Thomas Ruf wrote:
On 22 June 2020 at 06:47 Vinod Koul wrote:
On 21-06-20, 22:36, Federico Vaga wrote:
> On Sun, Jun 21, 2020 at 12:54:57PM +0530, Vinod Koul wrote:
> > On 19-06-20, 16:31, Dave Jiang wrote:
> > >
> > >
On Sat, Jun 20, 2020 at 12:47:16AM +0200, Federico Vaga wrote:
Hello,
is there the possibility of using a DMA engine channel from userspace?
Something like:
- configure DMA using ioctl() (or whatever configuration mechanism)
- read() or write() to trigger the transfer
Let me add one more
On Mon, Jun 22, 2020 at 10:17:33AM +0530, Vinod Koul wrote:
On 21-06-20, 22:36, Federico Vaga wrote:
On Sun, Jun 21, 2020 at 12:54:57PM +0530, Vinod Koul wrote:
> On 19-06-20, 16:31, Dave Jiang wrote:
> >
> >
> > On 6/19/2020 3:47 PM, Federico Va
On Sun, Jun 21, 2020 at 10:45:04PM +0200, Richard Weinberger wrote:
On Sun, Jun 21, 2020 at 10:37 PM Federico Vaga wrote:
>Federico, what use case do you have in mind?
Userspace drivers
Is using vfio an option?
I do not know the subsystem. Could be, thanks for the suggestion I will h
On Sun, Jun 21, 2020 at 12:54:57PM +0530, Vinod Koul wrote:
On 19-06-20, 16:31, Dave Jiang wrote:
On 6/19/2020 3:47 PM, Federico Vaga wrote:
> Hello,
>
> is there the possibility of using a DMA engine channel from userspace?
>
> Something like:
> - configure DMA using io
Hello,
is there the possibility of using a DMA engine channel from userspace?
Something like:
- configure DMA using ioctl() (or whatever configuration mechanism)
- read() or write() to trigger the transfer
--
Federico Vaga [CERN BE-CO-HT]
It is already fixed by https://lkml.org/lkml/2020/5/31/260
On Monday, June 15, 2020 8:47:01 AM CEST Mauro Carvalho Chehab wrote:
> there are missing references causing Sphinx warnings:
>
> Documentation/translations/it_IT/process/submitting-patches.rst:384:
> WARNING: undefined label:
- add complete translation of symbol-namespaces.rst
- fix references to this page within the italian translation
- add document to main indexes
Signed-off-by: Federico Vaga
---
.../translations/it_IT/core-api/index.rst | 18 ++
.../it_IT/core-api/symbol-namespaces.rst | 166
On Tuesday, June 9, 2020 10:12:41 PM CEST Alexander A. Klimov wrote:
> Rationale:
> Reduces attack surface on kernel devs opening the links for MITM
> as HTTPS traffic is much harder to manipulate.
>
> Deterministic algorithm:
> For each file:
> For each line:
> If doesn't contain
-namespace.rst
and move the link again
On Tuesday, June 2, 2020 10:37:21 AM CEST Federico Vaga wrote:
> On Sunday, May 31, 2020 8:56:18 PM CEST Lukas Bulwahn wrote:
> > Documentation generation warns:
> > it_IT/kernel-hacking/hacking.rst:
> > WARNING: unknown document: ../core-
On Sunday, May 31, 2020 8:56:18 PM CEST Lukas Bulwahn wrote:
> Documentation generation warns:
>
> it_IT/kernel-hacking/hacking.rst:
> WARNING: unknown document: ../core-api/symbol/namespaces
>
> it_IT/process/5.Posting.rst:
> WARNING: undefined label: it_email_clients
>
>
quot;docs: locking: Drop :c:func: throughout")
commit 6adb7755996f ("docs: locking: Add 'need' to hardirq section")
Signed-off-by: Federico Vaga
---
.../it_IT/doc-guide/kernel-doc.rst| 25 ++-
.../it_IT/kernel-hacking/hacking.rst | 18 ++
...
On Monday, September 2, 2019 8:10:10 PM CEST Ingo Molnar wrote:
> * Federico Vaga wrote:
> > On Saturday, August 31, 2019 4:43:44 PM CEST Jonathan Corbet wrote:
> > > On Sat, 31 Aug 2019 15:41:16 +0200
> > >
> > > Federico Vaga wrote:
> > > > sev
implementations (nested threads). For this reason, it is safer
to use `request_any_context_irq()` to avoid errors at probe time.
Signed-off-by: Federico Vaga
---
drivers/i2c/busses/i2c-ocores.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/i2c/busses/i2c-ocores.c
On Tuesday, August 13, 2019 8:15:47 AM CEST Denis Efremov wrote:
> Cleanup MAINTAINERS from FMC record since the subsystem was removed.
>
> Cc: Linus Walleij
> Cc: Federico Vaga
> Cc: Pat Riehecky
> Fixes: 6a80b30086b8 ("fmc: Delete the FMC subsystem")
> Signed-o
The patch translates the following patches in Italian:
1fb12b35e5ff kbuild: Raise the minimum required binutils version to 2.21
9c3c0c204814 isdn: remove isdn4linux
Signed-off-by: Federico Vaga
---
.../translations/it_IT/process/changes.rst| 22 ---
1 file changed, 4
The patch translates the following patches in Italian:
d9d7c0c497b8 docs: Note that :c:func: should no longer be used
83e8b971f81c sphinx.rst: Add note about code snippets embedded in the text
cca5e0b8a430 Documentation: PGP: update for newer HW devices
Signed-off-by: Federico Vaga
This patch add translations for:
- programming-languages
- kernel-docs (It is better to not translate this since English is
a requirement to get something useful out of it)
Signed-off-by: Federico Vaga
---
.../translations/it_IT/process/index.rst | 1 +
.../it_IT/process/kernel-docs.rst
Well I do not know if it make sense to make it stronger with:
Signed-off-by: Federico Vaga
As you want
On Monday, June 10, 2019 4:18:09 PM CEST Linus Walleij wrote:
> The FMC subsystem was created in 2012 with the ambition to
> drive development of drivers for this hardware up
cumentation/translations/it_IT/process/license-rules.rst:341: WARNING:
> Unexpected indentation.
> Documentation/translations/it_IT/process/license-rules.rst:305: WARNING:
> Unknown target name: "metatags".
>
> Signed-off-by: Mauro Carvalho Chehab
Reviewed-by: Feder
On Thursday, May 30, 2019 1:23:46 AM CEST Mauro Carvalho Chehab wrote:
> There's a wrong identation on a code block, and it tries to use
> a reference that was not defined at the Italian translation.
>
> Documentation/translations/it_IT/process/license-rules.rst:329: WARNING:
> Literal block
Fix italian translation file references based on
`scripts/documentation-file-ref-check` output.
Signed-off-by: Federico Vaga
---
.../it_IT/admin-guide/kernel-parameters.rst | 12
.../translations/it_IT/process/adding-syscalls.rst | 2 +-
.../translations/it_IT/process
Hi Alan,
thanks for your answer
On Wednesday, April 10, 2019 4:21:09 PM CEST Alan Tull wrote:
> On Wed, Apr 10, 2019 at 7:50 AM Federico Vaga wrote:
>
> Hi Federico,
>
> I wish I could point you to a complete solution, but there is a lot of
> work to be done in this a
m/vdsao/fpga-cfg
> [2] https://marc.info/?l=linux-fpga=155078072107199=2
> [3] https://marc.info/?l=linux-fpga
>
> Am 10.04.2019 12:01, schrieb Federico Vaga:
> > Hello,
> >
> > sorry to push for an answer but I do not want to take the risk of
&
something
useful not only for CERN but for the entire community.
Thank you
On Wednesday, March 27, 2019 6:17:18 PM CEST Federico Vaga wrote:
> Hello,
>
> I'm looking for guidance
>
> What I have:
> * Intel x86_64 computer
> * PCIe card with FPGA on it
>
> What I want t
Hello,
I'm looking for guidance
What I have:
* Intel x86_64 computer
* PCIe card with FPGA on it
What I want to achieve:
* load an FPGA bitstream on the card
* load a device-tree like description for the FPGA devices contained in the
bitstream
This is achievable on ARM with DeviceTree,
Hi Alex,
On Wednesday, March 6, 2019 2:57:05 AM CET Alex Shi wrote:
> Generally It looks good! A short guide to translator is good as well as a
> disclaimer.
> On 2019/3/6 6:06 上午, Federico Vaga wrote:
> > This is only an example to propose a structure for translation's
This is only an example to propose a structure for translation's
disclaimers. The actual text needs some thoughs.
Signed-off-by: Federico Vaga
---
Documentation/translations/index.rst | 18 ++
.../translations/it_IT/disclaimer-ita.rst | 13
:
Documentation/translations/it_IT/disclaimer-ita.rst.
Thanks a lot!
Signed-off-by: Alex Shi
Cc: Harry Wei
Cc: Jonathan Corbet
Cc: Li Zefan
Cc: Shawn Guo
Cc: Fengguang Wu
Cc: Coly Li
Cc: Federico Vaga
---
Documentation/translations/zh_CN/disclaimer-zh_CN.rst | 11
+++
1 file changed, 11
Translated documents:
- stable-kernel-rules.rst
- deprecated.rst
- kernel-enforcement-statement.rst
- license-rules.rst
Added document to have valid links
- netdev-FAQ.rst
Modifications to main documentation
- add label in deprecated.rst
Signed-off-by: Federico Vaga
---
Documentation/process
hello,
I have just a general observation for the community, not related to the
content of this patch, but related with the idea behind.
Is it really important to specify the major release number in the documents? .
Can't we just use a generic x.y.z, or a more generic statement?
When you open
The following patch forgot to remove a reference to the -git
patches
commit 2c71d305caf9 ("docs: process: Remove outdated info about -git patches")
This patch complete the removal and update all translations
Signed-off-by: Federico Vaga
---
Documentation/process
Synchonise translations: CN, IT, JP, KR
commit 2c71d305caf9 ("docs: process: Remove outdated info about -git patches")
I can guarantee for the Italian translations, but since we are removing
an entire chapter I think I did it right also for the other languages.
Signed-off-by: Fed
The following patch forgot to remove a reference to the -git
patches
commit 2c71d305caf9 ("docs: process: Remove outdated info about -git patches")
This patch complete the removal and update all translations
Signed-off-by: Federico Vaga
---
Documentation/process
Synchonise translations: CN, IT, JP, KR
commit 2c71d305caf9 ("docs: process: Remove outdated info about -git patches")
I can guarantee for the Italian translations, but since we are removing
an entire chapter I think I did it right also for the other languages.
Signed-off-by: Fed
The patches fixes some typos in process/license-rules.rst
Signed-off-by: Federico Vaga
---
Documentation/process/license-rules.rst | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/process/license-rules.rst
b/Documentation/process/license-rules.rst
index
On Thursday, February 14, 2019 4:19:36 PM CET Joe Perches wrote:
> On Thu, 2019-02-14 at 16:03 +0100, Federico Vaga wrote:
> > On Thursday, February 14, 2019 3:44:55 PM CET Joe Perches wrote:
> > > On Thu, 2019-02-14 at 13:48 +0100, Federico Vaga wrote:
> > > > Hell
On Thursday, February 14, 2019 3:44:55 PM CET Joe Perches wrote:
> On Thu, 2019-02-14 at 13:48 +0100, Federico Vaga wrote:
> > Hello,
> >
> > Recently I have produce a couple of patches but I get different warnings
> > if I run checkpatch on the file (-f) or
if there are other similar cases.
I do not know Perl, so I cannot investigate more, but I have a practical
example. I have this simple patch applied on my tree that introduces a spell
error:
From: Federico Vaga
Date: Thu, 14 Feb 2019 13:29:39 +0100
Subject: [PATCH] script: checkpatch: buggy(?) output
This patch set provides improvements to the i2c-ocore driver.
[V6 -> V7]
- restore accidentally removed 'reviewed-by' tags in changelog
[V5 -> V6]
- remove redundant code introduced in V5 (double read control register)
[V4 -> V5]
- deterministic status of IEN bit in register "CONTROL" at the
Miscellaneous style fixes from checkpatch
Signed-off-by: Federico Vaga
Reviewed-by: Andrew Lunn
---
drivers/i2c/busses/i2c-ocores.c | 29 ++---
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c
ted in ocores_wait() mostly
not looping at all. But for reading an 4K AT24 EEPROM, it increased
the read time by 10ms, from 424ms to 434ms. So we should probably keep
with 8.
Signed-off-by: Federico Vaga
Tested-by: Andrew Lunn
---
drivers/i2c/busses/i2c-ocores.c |
It adds the SPDX tag and it removes the old text about the GPLv2.
Signed-off-by: Federico Vaga
Reviewed-by: Andrew Lunn
---
drivers/i2c/busses/i2c-ocores.c | 5 +
include/linux/platform_data/i2c-ocores.h | 5 +
2 files changed, 2 insertions(+), 8 deletions(-)
diff --git
If the Interrupt Flag (IF) is not set, we should not handle the IRQ:
- the line can be shared with other devices
- it can be a spurious interrupt
To avoid reading twice the status register, the ocores_process() function
expects it to be read by the caller.
Signed-off-by: Federico Vaga
Acked
a new function to handle timeout
- modified the current ocores_process() function in order to be protected
by the new spinlock
Like this it is obvious at first sight that this locking serializes
the execution of ocores_process() and ocores_process_timeout()
Signed-off-by: Federico Vaga
Reviewed
On Thursday, February 14, 2019 4:07:33 AM CET Andrew Lunn wrote:
> On Mon, Feb 11, 2019 at 05:49:08PM +0100, Federico Vaga wrote:
> > This patch set provides improvements to the i2c-ocore driver.
> >
> > [V5 -> V6]
> > - remove redundant code introduced in V5
On Monday, February 11, 2019 5:54:54 PM CET Wolfram Sang wrote:
> On Mon, Feb 11, 2019 at 05:49:12PM +0100, Federico Vaga wrote:
> > It adds the SPDX tag and it removes the old text about the GPLv2.
> >
> > Signed-off-by: Federico Vaga
>
> I can convert the platfor
If the Interrupt Flag (IF) is not set, we should not handle the IRQ:
- the line can be shared with other devices
- it can be a spurious interrupt
To avoid reading twice the status register, the ocores_process() function
expects it to be read by the caller.
Signed-off-by: Federico Vaga
Acked
Miscellaneous style fixes from checkpatch
Signed-off-by: Federico Vaga
---
drivers/i2c/busses/i2c-ocores.c | 29 ++---
1 file changed, 18 insertions(+), 11 deletions(-)
diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
index 78085a8..b32d67c
a new function to handle timeout
- modified the current ocores_process() function in order to be protected
by the new spinlock
Like this it is obvious at first sight that this locking serializes
the execution of ocores_process() and ocores_process_timeout()
Signed-off-by: Federico Vaga
ted in ocores_wait() mostly
not looping at all. But for reading an 4K AT24 EEPROM, it increased
the read time by 10ms, from 424ms to 434ms. So we should probably keep
with 8.
Signed-off-by: Federico Vaga
Tested-by: Andrew Lunn
---
drivers/i2c/busses/i2c-ocores.c |
It adds the SPDX tag and it removes the old text about the GPLv2.
Signed-off-by: Federico Vaga
---
drivers/i2c/busses/i2c-ocores.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
index 5dea7b9..78085a8
This patch set provides improvements to the i2c-ocore driver.
[V5 -> V6]
- remove redundant code introduced in V5 (double read control register)
[V4 -> V5]
- deterministic status of IEN bit in register "CONTROL" at the end of
ocores_init()
- more style fixes
[V3 -> V4]
- add
On Monday, February 11, 2019 5:12:23 PM CET Peter Rosin wrote:
> On 2019-02-11 17:05, Federico Vaga wrote:
>
> > Miscellaneous style fixes from checkpatch
> >
> > Signed-off-by: Federico Vaga
> > ---
> >
> > drivers/i2c/busses/i2c-ocores.c | 30
This patch set provides improvements to the i2c-ocore driver.
[V4 -> V5]
- deterministic status of IEN bit in register "CONTROL" at the end of
ocores_init()
- more style fixes
[V3 -> V4]
- add reviews-by/tested-by
- add comment to justify the formula in
udelay((8 * 1000) /
a new function to handle timeout
- modified the current ocores_process() function in order to be protected
by the new spinlock
Like this it is obvious at first sight that this locking serializes
the execution of ocores_process() and ocores_process_timeout()
Signed-off-by: Federico Vaga
ted in ocores_wait() mostly
not looping at all. But for reading an 4K AT24 EEPROM, it increased
the read time by 10ms, from 424ms to 434ms. So we should probably keep
with 8.
Signed-off-by: Federico Vaga
Tested-by: Andrew Lunn
---
drivers/i2c/busses/i2c-ocores.c |
It adds the SPDX tag and it removes the old text about the GPLv2.
Signed-off-by: Federico Vaga
---
drivers/i2c/busses/i2c-ocores.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
index 5dea7b9..78085a8
If the Interrupt Flag (IF) is not set, we should not handle the IRQ:
- the line can be shared with other devices
- it can be a spurious interrupt
To avoid reading twice the status register, the ocores_process() function
expects it to be read by the caller.
Signed-off-by: Federico Vaga
Acked
Miscellaneous style fixes from checkpatch
Signed-off-by: Federico Vaga
---
drivers/i2c/busses/i2c-ocores.c | 30 +++---
1 file changed, 19 insertions(+), 11 deletions(-)
diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
index 78085a8
On Monday, February 11, 2019 3:01:38 PM CET Andrew Lunn wrote:
> > Applied to for-next, thanks!
>
> Hi Wolfram
>
> Could you drop these patches and wait for a new version? I don't
> think you have pushed it out yet? So it won't be a visible rebase.
I will wait to send v5: full patch set, or
On Monday, February 11, 2019 11:25:26 AM CET Wolfram Sang wrote:
> On Mon, Feb 11, 2019 at 09:31:20AM +0100, Federico Vaga wrote:
> > This driver assumes that an interrupt line is always available for
> > the I2C master. This is not always the case and this patch adds support
&g
On Monday, February 11, 2019 2:35:15 PM CET Peter Rosin wrote:
> >>> @@ -294,7 +427,7 @@ static int ocores_init(struct device *dev, struct
> >>> ocores_i2c *i2c)
> >>
> >>
> >>
> >>>
> >>>
> >>>
> >>> /* Init the device */
> >>> oc_setreg(i2c, OCI2C_CMD, OCI2C_CMD_IACK);
> >>>
> >>>
>
On Monday, February 11, 2019 11:43:45 AM CET Peter Rosin wrote:
> On 2019-02-11 09:31, Federico Vaga wrote:
>
> > This driver assumes that an interrupt line is always available for
> > the I2C master. This is not always the case and this patch adds support
> &g
On Monday, February 11, 2019 11:44:46 AM CET Peter Rosin wrote:
> On 2019-02-11 09:31, Federico Vaga wrote:
>
> > Detecting a timeout is ok, but we also need to assert a STOP command on
> > the bus in order to prevent it from generating interrupts when there are
> &g
On Monday, February 11, 2019 12:54:11 PM CET Vinod Koul wrote:
> On 08-02-19, 16:30, Federico Vaga wrote:
> > It clarifies that the DMA description pointer returned by
> > `dmaengine_prep_*` function should not be used after submission.
> >
> > S
This patch set provides improvements to the i2c-ocore driver.
[V3 -> V4]
- add reviews-by/tested-by
- add comment to justify the formula in
udelay((8 * 1000) / i2c->bus_clock_khz);
[V2 -> V3]
- fix particular error condition on platform_get_irq(). Copied from
Miscellaneous style fixes from checkpatch
Signed-off-by: Federico Vaga
Reviewed-by: Andrew Lunn
---
drivers/i2c/busses/i2c-ocores.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
index
a new function to handle timeout
- modified the current ocores_process() function in order to be protected
by the new spinlock
Like this it is obvious at first sight that this locking serializes
the execution of ocores_process() and ocores_process_timeout()
Signed-off-by: Federico Vaga
Reviewed
ted in ocores_wait() mostly
not looping at all. But for reading an 4K AT24 EEPROM, it increased
the read time by 10ms, from 424ms to 434ms. So we should probably keep
with 8.
Signed-off-by: Federico Vaga
Tested-by: Andrew Lunn
---
drivers/i2c/busses/i2c-ocores.c |
It adds the SPDX tag and it removes the old text about the GPLv2.
Signed-off-by: Federico Vaga
Reviewed-by: Andrew Lunn
---
drivers/i2c/busses/i2c-ocores.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
If the Interrupt Flag (IF) is not set, we should not handle the IRQ:
- the line can be shared with other devices
- it can be a spurious interrupt
To avoid reading twice the status register, the ocores_process() function
expects it to be read by the caller.
Signed-off-by: Federico Vaga
Acked
On Saturday, February 9, 2019 10:33:53 PM CET Andrew Lunn wrote:
> > +static int ocores_poll_wait(struct ocores_i2c *i2c)
> > +{
> > + u8 mask;
> > + int err;
> > +
> > + if (i2c->state == STATE_DONE || i2c->state == STATE_ERROR) {
> > + /* transfer is over */
> > + mask
This driver assumes that an interrupt line is always available for
the I2C master. This is not always the case and this patch adds support
for a polling version.
Signed-off-by: Federico Vaga
---
drivers/i2c/busses/i2c-ocores.c | 176 +++-
1 file changed, 156
It adds the SPDX tag and it removes the old text about the GPLv2.
Signed-off-by: Federico Vaga
---
drivers/i2c/busses/i2c-ocores.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
index bbe3e96..5b80190
Miscellaneous style fixes from checkpatch
Signed-off-by: Federico Vaga
---
drivers/i2c/busses/i2c-ocores.c | 19 ---
1 file changed, 12 insertions(+), 7 deletions(-)
diff --git a/drivers/i2c/busses/i2c-ocores.c b/drivers/i2c/busses/i2c-ocores.c
index 5b80190..ba35d2a 100644
a new function to handle timeout
- modified the current ocores_process() function in order to be protected
by the new spinlock
Like this it is obvious at first sight that this locking serializes
the execution of ocores_process() and ocores_process_timeout()
Signed-off-by: Federico Vaga
This patch set provides improvements to the i2c-ocore driver.
[V2 -> V3]
- fix error condition on platform_get_irq(). Copied from
https://patchwork.ozlabs.org/patch/1038409/
[V1 -> V2]
- replaced usleep_range() with udelay() so that the polling version can be
used in atomic context.
- added
If the Interrupt Flag (IF) is not set, we should not handle the IRQ:
- the line can be shared with other devices
- it can be a spurious interrupt
To avoid reading twice the status register, the ocores_process() function
expects it to be read by the caller.
Signed-off-by: Federico Vaga
Acked
It clarifies that the DMA description pointer returned by
`dmaengine_prep_*` function should not be used after submission.
Signed-off-by: Federico Vaga
---
Documentation/driver-api/dmaengine/client.rst | 7 +++
1 file changed, 7 insertions(+)
diff --git a/Documentation/driver-api/dmaengine
On 2019-01-21 09:11, Federico Vaga wrote:
On Monday, January 21, 2019 2:56:17 AM CET Jonathan Corbet wrote:
On Sat, 19 Jan 2019 23:13:41 +0100
Federico Vaga wrote:
> This patch adds the Italian translation for the following documents
> in Documentation/process:
>
> - appl
This patch adds the Italian translation for the following documents
in Documentation/process:
- applying-patches
- submit-checklist
- submitting-drivers
- changes
- stable api nonsense
Signed-off-by: Federico Vaga
---
V3 - update according to recent change
8f7e6d134bda (doc/docs-next) doc
On February 1, 2019 4:17:50 AM UTC, Vinod Koul wrote:
>On 28-01-19, 09:47, Federico Vaga wrote:
>> Hi,
>>
>> I have a new question concerning documentation.
>>
>>
>https://www.kernel.org/doc/html/latest/driver-api/dmaengine/client.html
>>
>
1 - 100 of 432 matches
Mail list logo
