Re: [PATCH 0/4] Removing full paths from DT full_name

Hi Rob, On 07/25/17 14:44, Rob Herring wrote: > This series is the last steps to remove storing the full path for every > DT node. Instead, we can create full path strings dynamically as needed > with printf %pOF specifiers (commit ce4fecf1fe15). There are a number of > remaining direct users

Re: [PATCH 0/4] Removing full paths from DT full_name

Hi Rob, On 07/25/17 14:44, Rob Herring wrote: > This series is the last steps to remove storing the full path for every > DT node. Instead, we can create full path strings dynamically as needed > with printf %pOF specifiers (commit ce4fecf1fe15). There are a number of > remaining direct users

Re: [PATCH 1/2] MAINTAINERS: device property: acpi: add fwnode.h

On 07/21/17 15:03, Rafael J. Wysocki wrote: > On Thursday, July 20, 2017 12:13:24 PM frowand.l...@gmail.com wrote: >> From: Frank Rowand <frank.row...@sony.com> >> >> ACPI is impacted by changes to fwnode.h, add a file entry >> to ACPI >> >> Signe

Re: [PATCH 1/2] MAINTAINERS: device property: acpi: add fwnode.h

On 07/21/17 15:03, Rafael J. Wysocki wrote: > On Thursday, July 20, 2017 12:13:24 PM frowand.l...@gmail.com wrote: >> From: Frank Rowand >> >> ACPI is impacted by changes to fwnode.h, add a file entry >> to ACPI >> >> Signed-off-by: Frank Rowand >

Re: [PATCH] of: provide of_n_{addr,size}_cells wrappers for !CONFIG_OF

ude/linux/of.h > +++ b/include/linux/of.h > @@ -735,6 +735,9 @@ static inline struct device_node *of_get_cpu_node(int cpu, > return NULL; > } > > +static inline int of_n_addr_cells(struct device_node *np) { return 0; } > +static inline int of_n_size_cells(struct device_node

Re: [PATCH] of: provide of_n_{addr,size}_cells wrappers for !CONFIG_OF

p) { return 0; } > +static inline int of_n_size_cells(struct device_node *np) { return 0; } > + > static inline int of_property_read_u64(const struct device_node *np, > const char *propname, u64 *out_value) > { > Reviewed-by: Frank Rowand

Re: [PATCH] docs: submitting-patches - change non-ascii character to ascii

On 07/21/17 10:27, Jonathan Corbet wrote: > On Thu, 20 Jul 2017 18:30:55 -0700 > frowand.l...@gmail.com wrote: > >> Documentation/process/submitting-patches.rst contains a non-ascii >> character. Change it to the ascii equivalent. > > You should know better than to tell somebody like me that a

Re: [PATCH] docs: submitting-patches - change non-ascii character to ascii

On 07/21/17 10:27, Jonathan Corbet wrote: > On Thu, 20 Jul 2017 18:30:55 -0700 > frowand.l...@gmail.com wrote: > >> Documentation/process/submitting-patches.rst contains a non-ascii >> character. Change it to the ascii equivalent. > > You should know better than to tell somebody like me that a

Re: [PATCH] media: Convert to using %pOF instead of full_name

On 07/19/17 09:02, Rob Herring wrote: > On Wed, Jul 19, 2017 at 4:41 AM, Sylwester Nawrocki > wrote: >> On 07/18/2017 11:43 PM, Rob Herring wrote: >>> Now that we have a custom printf format specifier, convert users of >>> full_name to use %pOF instead. This is preparation

Re: [PATCH] media: Convert to using %pOF instead of full_name

On 07/19/17 09:02, Rob Herring wrote: > On Wed, Jul 19, 2017 at 4:41 AM, Sylwester Nawrocki > wrote: >> On 07/18/2017 11:43 PM, Rob Herring wrote: >>> Now that we have a custom printf format specifier, convert users of >>> full_name to use %pOF instead. This is preparation to remove storing >>>

Re: [PATCH v3 1/3] of: overlay: add overlay unittest data for node names and symbols

On 07/19/17 06:39, Rob Herring wrote: > On Tue, Jul 18, 2017 at 10:52 PM, <frowand.l...@gmail.com> wrote: >> From: Frank Rowand <frank.row...@sony.com> >> >> Add nodes and properties to overlay_base and overlay dts files to >> test for >>- incorr

Re: [PATCH v3 1/3] of: overlay: add overlay unittest data for node names and symbols

On 07/19/17 06:39, Rob Herring wrote: > On Tue, Jul 18, 2017 at 10:52 PM, wrote: >> From: Frank Rowand >> >> Add nodes and properties to overlay_base and overlay dts files to >> test for >>- incorrect existing node name detection when overlay nod

Re: [PATCH] spmi: pmic-arb: Always allocate ppid_to_apid table

c-arb: optimize table lookups") >> Signed-off-by: Stephen Boyd <sb...@codeaurora.org> > Reviewed-by: Kiran Gunda <kgu...@codeaurora.org> Tested on a qcom-apq8074-dragonboard on 4.13-rc1 Tested-by: Frank Rowand <frank.row...@sony.com> >> --- >> drivers/spmi/

Re: [PATCH] spmi: pmic-arb: Always allocate ppid_to_apid table

hen Boyd > Reviewed-by: Kiran Gunda Tested on a qcom-apq8074-dragonboard on 4.13-rc1 Tested-by: Frank Rowand >> --- >> drivers/spmi/spmi-pmic-arb.c | 17 +++-- >> 1 file changed, 7 insertions(+), 10 deletions(-) >> >> diff --git a/drivers/spmi/spmi-

Re: panic, bisect to commit 7f1d4e58dabb "spmi: pmic-arb: optimize table lookups"

On 07/17/17 22:44, Frank Rowand wrote: > On 07/17/17 22:06, Frank Rowand wrote: >> On 07/17/17 20:56, Rajendra Nayak wrote: >>> >>> On 07/18/2017 09:12 AM, Frank Rowand wrote: >>>> Hi Abhijeet, >>>> >>>> My qcom-apq8074-dragonboar

Re: panic, bisect to commit 7f1d4e58dabb "spmi: pmic-arb: optimize table lookups"

On 07/17/17 22:44, Frank Rowand wrote: > On 07/17/17 22:06, Frank Rowand wrote: >> On 07/17/17 20:56, Rajendra Nayak wrote: >>> >>> On 07/18/2017 09:12 AM, Frank Rowand wrote: >>>> Hi Abhijeet, >>>> >>>> My qcom-apq8074-dragonboar

Re: panic, bisect to commit 7f1d4e58dabb "spmi: pmic-arb: optimize table lookups"

On 07/17/17 22:06, Frank Rowand wrote: > On 07/17/17 20:56, Rajendra Nayak wrote: >> >> On 07/18/2017 09:12 AM, Frank Rowand wrote: >>> Hi Abhijeet, >>> >>> My qcom-apq8074-dragonboard panics on boot on v4.13-rc1. >>> >>> I bisected the p

Re: panic, bisect to commit 7f1d4e58dabb "spmi: pmic-arb: optimize table lookups"

On 07/17/17 22:06, Frank Rowand wrote: > On 07/17/17 20:56, Rajendra Nayak wrote: >> >> On 07/18/2017 09:12 AM, Frank Rowand wrote: >>> Hi Abhijeet, >>> >>> My qcom-apq8074-dragonboard panics on boot on v4.13-rc1. >>> >>> I bisected the p

Re: panic, bisect to commit 7f1d4e58dabb "spmi: pmic-arb: optimize table lookups"

On 07/17/17 20:56, Rajendra Nayak wrote: > > On 07/18/2017 09:12 AM, Frank Rowand wrote: >> Hi Abhijeet, >> >> My qcom-apq8074-dragonboard panics on boot on v4.13-rc1. >> >> I bisected the problem to commit 7f1d4e58dabb, "spmi: pmic-arb: >> optimiz

Re: panic, bisect to commit 7f1d4e58dabb "spmi: pmic-arb: optimize table lookups"

On 07/17/17 20:56, Rajendra Nayak wrote: > > On 07/18/2017 09:12 AM, Frank Rowand wrote: >> Hi Abhijeet, >> >> My qcom-apq8074-dragonboard panics on boot on v4.13-rc1. >> >> I bisected the problem to commit 7f1d4e58dabb, "spmi: pmic-arb: >> optimiz

panic, bisect to commit 7f1d4e58dabb "spmi: pmic-arb: optimize table lookups"

Hi Abhijeet, My qcom-apq8074-dragonboard panics on boot on v4.13-rc1. I bisected the problem to commit 7f1d4e58dabb, "spmi: pmic-arb: optimize table lookups". The panic occurs at the top of pmic_arb_ppid_to_apid_v1(), due to pa->ppid_to_apid being null. A little more information that might

panic, bisect to commit 7f1d4e58dabb "spmi: pmic-arb: optimize table lookups"

Hi Abhijeet, My qcom-apq8074-dragonboard panics on boot on v4.13-rc1. I bisected the problem to commit 7f1d4e58dabb, "spmi: pmic-arb: optimize table lookups". The panic occurs at the top of pmic_arb_ppid_to_apid_v1(), due to pa->ppid_to_apid being null. A little more information that might

Re: [PATCH v2 1/3] of: overlay: add overlay unittest data for node names and symbols

On 07/10/17 19:31, Rob Herring wrote: > On Mon, Jul 10, 2017 at 2:05 PM, <frowand.l...@gmail.com> wrote: >> From: Frank Rowand <frank.row...@sony.com> >> >> Add nodes and properties to overlay_base and overlay dts files to >> test for >>- incorr

Re: [PATCH v2 1/3] of: overlay: add overlay unittest data for node names and symbols

On 07/10/17 19:31, Rob Herring wrote: > On Mon, Jul 10, 2017 at 2:05 PM, wrote: >> From: Frank Rowand >> >> Add nodes and properties to overlay_base and overlay dts files to >> test for >>- incorrect existing node name detection when overlay nod

Re: [PATCH 2/3] of: overlay: correctly apply overlay node with unit-address

On 07/10/17 09:08, Rob Herring wrote: > On Fri, Jul 7, 2017 at 7:28 PM, <frowand.l...@gmail.com> wrote: >> From: Frank Rowand <frank.row...@sony.com> >> >> Correct existing node name detection when overlay node name has >> a unit-address. >> &

Re: [PATCH 2/3] of: overlay: correctly apply overlay node with unit-address

On 07/10/17 09:08, Rob Herring wrote: > On Fri, Jul 7, 2017 at 7:28 PM, wrote: >> From: Frank Rowand >> >> Correct existing node name detection when overlay node name has >> a unit-address. >> >> Expected test result is overlay will update the nodes

Re: [PATCH 0/5] Make PDF builds work again

On 07/03/17 01:25, Daniel Vetter wrote: > On Sun, Jun 18, 2017 at 05:46:25PM -0600, Jonathan Corbet wrote: >> I've just spent rather more time than I would like figuring out why the PDF >> builds fail and what was needed to fix it. The result is the following >> patch series. It's a combination

Re: [PATCH 0/5] Make PDF builds work again

On 07/03/17 01:25, Daniel Vetter wrote: > On Sun, Jun 18, 2017 at 05:46:25PM -0600, Jonathan Corbet wrote: >> I've just spent rather more time than I would like figuring out why the PDF >> builds fail and what was needed to fix it. The result is the following >> patch series. It's a combination

Re: [PATCH] of: document /sys/firmware/fdt

On 06/28/17 14:49, Grant Likely wrote: > I'm slowly getting back into things and plan to actively participate. > Please use my ARM address: > > grant.lik...@arm.com OK, I'll do that. -Frank > > g. > > On Wed, Jun 28, 2017 at 10:46 PM, Frank Rowand <frowand.l...@gm

Re: [PATCH] of: document /sys/firmware/fdt

On 06/28/17 14:49, Grant Likely wrote: > I'm slowly getting back into things and plan to actively participate. > Please use my ARM address: > > grant.lik...@arm.com OK, I'll do that. -Frank > > g. > > On Wed, Jun 28, 2017 at 10:46 PM, Frank Rowand wrote: >>

Re: [PATCH v2] of: document /sys/firmware/fdt

Hi Rob, Please ignore this version, Grant replied to your v1 comment, so I'll spin a v3. -Frank On 06/28/17 14:53, frowand.l...@gmail.com wrote: > From: Frank Rowand <frank.row...@sony.com> > > Add ABI documentation for /sys/firmware/fdt > > Change obsolete cont

Re: [PATCH v2] of: document /sys/firmware/fdt

Hi Rob, Please ignore this version, Grant replied to your v1 comment, so I'll spin a v3. -Frank On 06/28/17 14:53, frowand.l...@gmail.com wrote: > From: Frank Rowand > > Add ABI documentation for /sys/firmware/fdt > > Change obsolete contact for /sys/firmware/devicetree

Re: [PATCH] of: document /sys/firmware/fdt

On 06/22/17 08:23, Rob Herring wrote: > Meant to add Grant. > > On Thu, Jun 22, 2017 at 10:21:24AM -0500, Rob Herring wrote: >> On Tue, Jun 13, 2017 at 09:20:07PM -0700, frowand.l...@gmail.com wrote: >>> From: Frank Rowand <frank.row...@sony.com> >>> >

Re: [PATCH] of: document /sys/firmware/fdt

On 06/22/17 08:23, Rob Herring wrote: > Meant to add Grant. > > On Thu, Jun 22, 2017 at 10:21:24AM -0500, Rob Herring wrote: >> On Tue, Jun 13, 2017 at 09:20:07PM -0700, frowand.l...@gmail.com wrote: >>> From: Frank Rowand >>> >>> Add ABI document

Re: [PATCH] scripts/dtc: dtx_diff - Show real file names in diff header

-qq -f ${dtc_sort} -o -" > > if (( ${cmd_diff} )) ; then > > - diff ${diff_flags} \ > + diff ${diff_flags} --label "${dtx_file_1}" --label "${dtx_file_2}" \ > <(compile_to_dts "${dtx_file_1}") \ > <(comp

Re: [PATCH] scripts/dtc: dtx_diff - Show real file names in diff header

f (( ${cmd_diff} )) ; then > > - diff ${diff_flags} \ > + diff ${diff_flags} --label "${dtx_file_1}" --label "${dtx_file_2}" \ > <(compile_to_dts "${dtx_file_1}") \ > <(compile_to_dts "${dtx_file_2}") > > Reviewed-by: Frank Rowand Thanks Geert! It may look like a small change, but it is a big usability win. -Frank

Re: [PATCH v6 1/4] of: remove *phandle properties from expanded device tree

adding Ben and Paul. Hi Michael, On 06/20/17 21:57, Michael Ellerman wrote: > Hi Frank, > > frowand.l...@gmail.com writes: >> From: Frank Rowand <frank.row...@sony.com> >> >> Remove "phandle", "linux,phandle", and "ibm,phandle&

Re: [PATCH v6 1/4] of: remove *phandle properties from expanded device tree

adding Ben and Paul. Hi Michael, On 06/20/17 21:57, Michael Ellerman wrote: > Hi Frank, > > frowand.l...@gmail.com writes: >> From: Frank Rowand >> >> Remove "phandle", "linux,phandle", and "ibm,phandle" properties from >> the

Re: [PATCH v6 1/4] of: remove *phandle properties from expanded device tree

On 06/20/17 23:18, Frank Rowand wrote: > Hi Rob, > > Michael has an issue that means this patch series is not OK in the > current form. I will work on a v7 to see if I can resolve the > issue. > > -Frank < snip > Hi Rob, The issue is in patch 1. Patches 2 - 4 ar

Re: [PATCH v6 1/4] of: remove *phandle properties from expanded device tree

On 06/20/17 23:18, Frank Rowand wrote: > Hi Rob, > > Michael has an issue that means this patch series is not OK in the > current form. I will work on a v7 to see if I can resolve the > issue. > > -Frank < snip > Hi Rob, The issue is in patch 1. Patches 2 - 4 ar

Re: [PATCH v6 1/4] of: remove *phandle properties from expanded device tree

Hi Rob, Michael has an issue that means this patch series is not OK in the current form. I will work on a v7 to see if I can resolve the issue. -Frank On 06/20/17 21:57, Michael Ellerman wrote: > Hi Frank, > > frowand.l...@gmail.com writes: >> From: Frank Rowand <fra

Re: [PATCH v6 1/4] of: remove *phandle properties from expanded device tree

Hi Rob, Michael has an issue that means this patch series is not OK in the current form. I will work on a v7 to see if I can resolve the issue. -Frank On 06/20/17 21:57, Michael Ellerman wrote: > Hi Frank, > > frowand.l...@gmail.com writes: >> From: Frank Rowand >&g

Re: [PATCH] of: update ePAPR references to point to Devicetree Specification

On 06/18/17 07:05, Rob Herring wrote: > On Tue, Jun 13, 2017 at 07:49:04PM -0700, frowand.l...@gmail.com wrote: >> From: Frank Rowand <frank.row...@sony.com> >> >> The Devicetree Specification has superseded the ePAPR as the >> base specification for binding

Re: [PATCH] of: update ePAPR references to point to Devicetree Specification

On 06/18/17 07:05, Rob Herring wrote: > On Tue, Jun 13, 2017 at 07:49:04PM -0700, frowand.l...@gmail.com wrote: >> From: Frank Rowand >> >> The Devicetree Specification has superseded the ePAPR as the >> base specification for bindings. Update files in Documentat

Re: [PATCH v5 0/4] of: remove *phandle properties from expanded device tree

On 06/15/17 17:06, Benjamin Herrenschmidt wrote: > On Fri, 2017-06-09 at 22:47 -0700, frowand.l...@gmail.com wrote: >> From: Frank Rowand <frank.row...@sony.com> >> >> Remove "phandle" and "linux,phandle" properties from the internal >>

Re: [PATCH v5 0/4] of: remove *phandle properties from expanded device tree

On 06/15/17 17:06, Benjamin Herrenschmidt wrote: > On Fri, 2017-06-09 at 22:47 -0700, frowand.l...@gmail.com wrote: >> From: Frank Rowand >> >> Remove "phandle" and "linux,phandle" properties from the internal >> device tree. The phandle will stil

Re: Qemu crashes in -next due to 'of: remove *phandle properties from expanded device tree'

On 06/14/17 21:12, Guenter Roeck wrote: < snip > > Good (v4.12-rc4): > < snip > > OF: Checking node /soc@e000/pic@4 > OF: type match > OF: node '/soc@e000/pic@4' compatible '' type 'open-pic' name '' > score 2 > OF: node '/soc@e000/pic@4' compatible 'open-pic'

Re: Qemu crashes in -next due to 'of: remove *phandle properties from expanded device tree'

On 06/14/17 21:12, Guenter Roeck wrote: < snip > > Good (v4.12-rc4): > < snip > > OF: Checking node /soc@e000/pic@4 > OF: type match > OF: node '/soc@e000/pic@4' compatible '' type 'open-pic' name '' > score 2 > OF: node '/soc@e000/pic@4' compatible 'open-pic'

Re: Qemu crashes in -next due to 'of: remove *phandle properties from expanded device tree'

On 06/14/17 15:35, Guenter Roeck wrote: > On Wed, Jun 14, 2017 at 02:31:58PM -0700, Frank Rowand wrote: >> Hi Guenter, < snip > >> Can you also include the console messages before the "[ cut here ]" line? >> > http://kerneltests.org/builders > > Che

Re: Qemu crashes in -next due to 'of: remove *phandle properties from expanded device tree'

On 06/14/17 15:35, Guenter Roeck wrote: > On Wed, Jun 14, 2017 at 02:31:58PM -0700, Frank Rowand wrote: >> Hi Guenter, < snip > >> Can you also include the console messages before the "[ cut here ]" line? >> > http://kerneltests.org/builders > > Che

Re: Qemu crashes in -next due to 'of: remove *phandle properties from expanded device tree'

Hi Guenter, Thanks for reporting this. On 06/14/17 12:26, Guenter Roeck wrote: > Hi Frank, > > your commit 'of: remove *phandle properties from expanded device tree' in > -next causes several of my ppc qemu tests to crash. Looking into qemu, it > sets "linux,phandle" properties for the mpic

Re: Qemu crashes in -next due to 'of: remove *phandle properties from expanded device tree'

Hi Guenter, Thanks for reporting this. On 06/14/17 12:26, Guenter Roeck wrote: > Hi Frank, > > your commit 'of: remove *phandle properties from expanded device tree' in > -next causes several of my ppc qemu tests to crash. Looking into qemu, it > sets "linux,phandle" properties for the mpic

Re: [PATCH] external references for device tree overlays

Adding back the Cc: list On 06/11/17 23:13, Stefani Seibold wrote: > Hi Frank,i > > i am in vaction for the next two weeks. I will rewrite the patch when i > am back. > > Regards, > Stefani Hi Stefani, Please let us know how you intend to solve the problems you are facing before you invest a

Re: [PATCH] external references for device tree overlays

Adding back the Cc: list On 06/11/17 23:13, Stefani Seibold wrote: > Hi Frank,i > > i am in vaction for the next two weeks. I will rewrite the patch when i > am back. > > Regards, > Stefani Hi Stefani, Please let us know how you intend to solve the problems you are facing before you invest a

Re: [PATCH] external references for device tree overlays

On 06/07/17 23:48, Stefani Seibold wrote: > Hi Pantelis, > > On Wed, 2017-06-07 at 11:11 +0300, Pantelis Antoniou wrote: >> Hi Stefani, >> >> On Tue, 2017-06-06 at 21:17 +0200, Stefani Seibold wrote: >>> Hi Pantelis, >>> >>> thanks for the suggestion. This feature is not very well >>> documented.

Re: [PATCH] external references for device tree overlays

On 06/07/17 23:48, Stefani Seibold wrote: > Hi Pantelis, > > On Wed, 2017-06-07 at 11:11 +0300, Pantelis Antoniou wrote: >> Hi Stefani, >> >> On Tue, 2017-06-06 at 21:17 +0200, Stefani Seibold wrote: >>> Hi Pantelis, >>> >>> thanks for the suggestion. This feature is not very well >>> documented.

Re: [PATCH v4 1/4] of: remove *phandle properties from expanded device tree

On 06/09/17 19:35, Frank Rowand wrote: > On 05/15/17 15:23, Rob Herring wrote: >> On Mon, May 1, 2017 at 9:46 PM, <frowand.l...@gmail.com> wrote: >>> From: Frank Rowand <frank.row...@sony.com> >>> >>> Remove "phandle", "linux,phan

Re: [PATCH v4 1/4] of: remove *phandle properties from expanded device tree

On 06/09/17 19:35, Frank Rowand wrote: > On 05/15/17 15:23, Rob Herring wrote: >> On Mon, May 1, 2017 at 9:46 PM, wrote: >>> From: Frank Rowand >>> >>> Remove "phandle", "linux,phandle", and "ibm,phandle" properties from >

Re: [PATCH v4 1/4] of: remove *phandle properties from expanded device tree

On 05/15/17 15:23, Rob Herring wrote: > On Mon, May 1, 2017 at 9:46 PM, <frowand.l...@gmail.com> wrote: >> From: Frank Rowand <frank.row...@sony.com> >> >> Remove "phandle", "linux,phandle", and "ibm,phandle" properties from >&g

Re: [PATCH v4 1/4] of: remove *phandle properties from expanded device tree

On 05/15/17 15:23, Rob Herring wrote: > On Mon, May 1, 2017 at 9:46 PM, wrote: >> From: Frank Rowand >> >> Remove "phandle", "linux,phandle", and "ibm,phandle" properties from >> the internal device tree. The phandle

Re: [PATCH 03/17] base: fix order of OF initialization

On 06/08/17 02:05, Mark Rutland wrote: > On Wed, Jun 07, 2017 at 08:49:43PM -0700, Frank Rowand wrote: >> On 06/07/17 11:39, Wesley Terpstra wrote: >>> It was a while ago that I debugged this. I already reported this bug >>> to Benjamin Herrenschmidt (now in CC), a

Re: [PATCH 03/17] base: fix order of OF initialization

On 06/08/17 02:05, Mark Rutland wrote: > On Wed, Jun 07, 2017 at 08:49:43PM -0700, Frank Rowand wrote: >> On 06/07/17 11:39, Wesley Terpstra wrote: >>> It was a while ago that I debugged this. I already reported this bug >>> to Benjamin Herrenschmidt (now in CC), a

Re: [PATCH 03/17] base: fix order of OF initialization

On 06/07/17 11:39, Wesley Terpstra wrote: > It was a while ago that I debugged this. I already reported this bug > to Benjamin Herrenschmidt (now in CC), and I believe he has a patch of > his own to fix the same issue. > > As I understand it, of_core_init sets up the OF entries in >

Re: [PATCH 03/17] base: fix order of OF initialization

On 06/07/17 11:39, Wesley Terpstra wrote: > It was a while ago that I debugged this. I already reported this bug > to Benjamin Herrenschmidt (now in CC), and I believe he has a patch of > his own to fix the same issue. > > As I understand it, of_core_init sets up the OF entries in >

Re: [PATCH] external references for device tree overlays

On 06/06/17 12:22, Stefani Seibold wrote: > Hi Frank, > > On 06.06.2017, 00:20 -0700 Frank Rowand wrote:: >> On 06/05/17 05:59, Stefani Seibold wrote: >>> From: Stefani Seibold <stef...@seibold.net> >>> >>> This patch enables external r

Re: [PATCH] external references for device tree overlays

On 06/06/17 12:22, Stefani Seibold wrote: > Hi Frank, > > On 06.06.2017, 00:20 -0700 Frank Rowand wrote:: >> On 06/05/17 05:59, Stefani Seibold wrote: >>> From: Stefani Seibold >>> >>> This patch enables external references for symbols which are n

Re: [PATCH] external references for device tree overlays

On 06/06/17 00:20, Frank Rowand wrote: > On 06/05/17 05:59, Stefani Seibold wrote: >> From: Stefani Seibold <stef...@seibold.net> >> >> This patch enables external references for symbols which are not >> exported by the current device tree. For example >>

Re: [PATCH] external references for device tree overlays

On 06/06/17 00:20, Frank Rowand wrote: > On 06/05/17 05:59, Stefani Seibold wrote: >> From: Stefani Seibold >> >> This patch enables external references for symbols which are not >> exported by the current device tree. For example >> >> // RASPI example (on

Re: [PATCH] external references for device tree overlays

On 06/05/17 05:59, Stefani Seibold wrote: > From: Stefani Seibold > > This patch enables external references for symbols which are not > exported by the current device tree. For example > > // RASPI example (only for testing) > /dts-v1/; > /plugin/; > > / { >

Re: [PATCH] external references for device tree overlays

On 06/05/17 05:59, Stefani Seibold wrote: > From: Stefani Seibold > > This patch enables external references for symbols which are not > exported by the current device tree. For example > > // RASPI example (only for testing) > /dts-v1/; > /plugin/; > > / { > compatible = "brcm,bcm2835",

Re: [PATCH 3/3] of: fix sparse warnings in fdt, irq, and resolver code

ay, child) > diff --git a/include/linux/of_irq.h b/include/linux/of_irq.h > index 1e0deb8e8494..ec6b11deb773 100644 > --- a/include/linux/of_irq.h > +++ b/include/linux/of_irq.h > @@ -8,7 +8,7 @@ > #include > #include > > -typedef int (*of_irq_init_cb_t)(struct device_node *, struct device_node *); > +typedef int const (*of_irq_init_cb_t)(struct device_node *, struct > device_node *); > > /* > * Workarounds only applied to 32bit powermac machines > Reviewed-by: Frank Rowand <frank.row...@sony.com>

Re: [PATCH 3/3] of: fix sparse warnings in fdt, irq, and resolver code

ild) > diff --git a/include/linux/of_irq.h b/include/linux/of_irq.h > index 1e0deb8e8494..ec6b11deb773 100644 > --- a/include/linux/of_irq.h > +++ b/include/linux/of_irq.h > @@ -8,7 +8,7 @@ > #include > #include > > -typedef int (*of_irq_init_cb_t)(struct device_node *, struct device_node *); > +typedef int const (*of_irq_init_cb_t)(struct device_node *, struct > device_node *); > > /* > * Workarounds only applied to 32bit powermac machines > Reviewed-by: Frank Rowand

Re: [PATCH 2/3] of: fix sparse warning in of_pci_range_parser_one

ce = be32_to_cpup(parser->range); > range->flags = of_bus_pci_get_flags(parser->range); > range->pci_addr = of_read_number(parser->range + 1, ns); > range->cpu_addr = of_translate_address(parser->node, > Reviewed-by: Frank Rowand <frank.row...@sony.com>

Re: [PATCH 2/3] of: fix sparse warning in of_pci_range_parser_one

r->range); > range->flags = of_bus_pci_get_flags(parser->range); > range->pci_addr = of_read_number(parser->range + 1, ns); > range->cpu_addr = of_translate_address(parser->node, > Reviewed-by: Frank Rowand

Re: [PATCH 1/3] of: fix sparse warnings in of_find_next_cache_node

cache_node = of_parse_phandle(np, "next-level-cache", 0); > > - if (handle) > - return of_find_node_by_phandle(be32_to_cpup(handle)); > + if (cache_node) > + return cache_node; > > /* OF on pmac has nodes instead of properties named "l2-cache" >* beneath CPU nodes. > Reviewed-by: Frank Rowand <frank.row...@sony.com>

Re: [PATCH 1/3] of: fix sparse warnings in of_find_next_cache_node

= of_parse_phandle(np, "next-level-cache", 0); > > - if (handle) > - return of_find_node_by_phandle(be32_to_cpup(handle)); > + if (cache_node) > + return cache_node; > > /* OF on pmac has nodes instead of properties named "l2-cache" >* beneath CPU nodes. > Reviewed-by: Frank Rowand

Re: [PATCH] of: undeclared variable when CONFIG_DEBUG_LOCK_ALLOC

On 05/01/17 14:20, Rowand, Frank wrote: > On Monday, May 01, 2017 1:13 PM, Rob Herring [mailto:robh...@kernel.org] > wrote: >> >> On Sun, Apr 30, 2017 at 3:00 PM, Frank Rowand <frank.row...@sony.com> >> wrote: >>> An undeclared variable was used in a m

Re: [PATCH] of: undeclared variable when CONFIG_DEBUG_LOCK_ALLOC

On 05/01/17 14:20, Rowand, Frank wrote: > On Monday, May 01, 2017 1:13 PM, Rob Herring [mailto:robh...@kernel.org] > wrote: >> >> On Sun, Apr 30, 2017 at 3:00 PM, Frank Rowand >> wrote: >>> An undeclared variable was used in a macro that evaluates to nothing

Re: [PATCH v3 1/4] of: remove *phandle properties from expanded device tree

On 04/29/17 17:22, kbuild test robot wrote: > Hi Frank, > > [auto build test ERROR on robh/for-next] > [also build test ERROR on v4.11-rc8 next-20170428] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: >

Re: [PATCH v3 1/4] of: remove *phandle properties from expanded device tree

On 04/29/17 17:22, kbuild test robot wrote: > Hi Frank, > > [auto build test ERROR on robh/for-next] > [also build test ERROR on v4.11-rc8 next-20170428] > [if your patch is applied to the wrong git tree, please drop us a note to > help improve the system] > > url: >

Re: [PATCH 1/2] of: fix uninitialized variable warning for overlay test

On 04/28/17 02:44, Arnd Bergmann wrote: > gcc warns that an empty device tree would cause undefined behavior: > > drivers/of/unittest.c: In function 'of_unittest': > drivers/of/unittest.c:2199:25: warning: 'last_sibling' may be used > uninitialized in this function [-Wmaybe-uninitialized] > >

Re: [PATCH 1/2] of: fix uninitialized variable warning for overlay test

On 04/28/17 02:44, Arnd Bergmann wrote: > gcc warns that an empty device tree would cause undefined behavior: > > drivers/of/unittest.c: In function 'of_unittest': > drivers/of/unittest.c:2199:25: warning: 'last_sibling' may be used > uninitialized in this function [-Wmaybe-uninitialized] > >

Re: [PATCH 2/2] of: fix unittest build without CONFIG_OF_OVERLAY

test_unflatten_overlay_base(void) {}; > I thought I had tested that OF_UNITTEST forced OF_OVERLAY. But going back and trying again, I can confirm your results that it does not. Thanks for catching this! Reviewed-by: Frank Rowand <frank.row...@sony.com> Tested-by: Frank Rowand <frank.row...@sony.com> -Frank

Re: [PATCH 2/2] of: fix unittest build without CONFIG_OF_OVERLAY

ten_overlay_base(void) {}; > I thought I had tested that OF_UNITTEST forced OF_OVERLAY. But going back and trying again, I can confirm your results that it does not. Thanks for catching this! Reviewed-by: Frank Rowand Tested-by: Frank Rowand -Frank

Re: [PATCH v4 2/2] of: Add unit tests for applying overlays

On 04/28/17 04:25, Geert Uytterhoeven wrote: > Hi Frank, > > On Wed, Apr 26, 2017 at 2:09 AM, <frowand.l...@gmail.com> wrote: >> From: Frank Rowand <frank.row...@sony.com> >> >> Existing overlay unit tests examine individual pieces of the overlay >> c

Re: [PATCH v4 2/2] of: Add unit tests for applying overlays

On 04/28/17 04:25, Geert Uytterhoeven wrote: > Hi Frank, > > On Wed, Apr 26, 2017 at 2:09 AM, wrote: >> From: Frank Rowand >> >> Existing overlay unit tests examine individual pieces of the overlay >> code. The new tests target the entire process of appl

Re: [PATCH v2 1/2] of: support dtc compiler flags for overlays

On 04/25/17 15:04, Masahiro Yamada wrote: > 2017-04-25 8:05 GMT+09:00 <frowand.l...@gmail.com>: >> From: Frank Rowand <frank.row...@sony.com> >> >> The dtc compiler version that adds initial support was available >> in 4.11-rc1. Add the ability to set the d

Re: [PATCH v2 1/2] of: support dtc compiler flags for overlays

On 04/25/17 15:04, Masahiro Yamada wrote: > 2017-04-25 8:05 GMT+09:00 : >> From: Frank Rowand >> >> The dtc compiler version that adds initial support was available >> in 4.11-rc1. Add the ability to set the dtc compiler flags needed >> by overlays.

Re: [PATCH v2 2/2] of: Add unit tests for applying overlays

On 04/25/17 09:44, Rob Herring wrote: > On Mon, Apr 24, 2017 at 6:05 PM, <frowand.l...@gmail.com> wrote: >> From: Frank Rowand <frank.row...@sony.com> >> >> Existing overlay unit tests examine individual pieces of the overlay >> code. The new test

Re: [PATCH v2 2/2] of: Add unit tests for applying overlays

On 04/25/17 09:44, Rob Herring wrote: > On Mon, Apr 24, 2017 at 6:05 PM, wrote: >> From: Frank Rowand >> >> Existing overlay unit tests examine individual pieces of the overlay >> code. The new tests target the entire process of applying an overlay. > >

Re: [PATCH v3 0/4] of: remove *phandle properties from expanded device tree

On 04/25/17 01:47, frowand.l...@gmail.com wrote: > From: Frank Rowand <frank.row...@sony.com> > > Remove "phandle" and "linux,phandle" properties from the internal > device tree. The phandle will still be in the struct device_node > phandle field

Re: [PATCH v3 0/4] of: remove *phandle properties from expanded device tree

On 04/25/17 01:47, frowand.l...@gmail.com wrote: > From: Frank Rowand > > Remove "phandle" and "linux,phandle" properties from the internal > device tree. The phandle will still be in the struct device_node > phandle field. > > This is to resolve th

Re: [PATCH 1/3] of: overlay_adjust_phandles() - do not modify const field

On 04/24/17 14:40, Rob Herring wrote: > +Ben H > > On Mon, Apr 24, 2017 at 1:54 PM, Frank Rowand <frowand.l...@gmail.com> wrote: >> On 04/24/17 09:56, Rob Herring wrote: >>> On Mon, Apr 24, 2017 at 12:20 AM, <frowand.l...@gmail.com> wrote: >>&g

Re: [PATCH 1/3] of: overlay_adjust_phandles() - do not modify const field

On 04/24/17 14:40, Rob Herring wrote: > +Ben H > > On Mon, Apr 24, 2017 at 1:54 PM, Frank Rowand wrote: >> On 04/24/17 09:56, Rob Herring wrote: >>> On Mon, Apr 24, 2017 at 12:20 AM, wrote: >>>> From: Frank Rowand >>>> >>>> When adju

Re: [PATCH 1/3] of: overlay_adjust_phandles() - do not modify const field

On 04/24/17 09:56, Rob Herring wrote: > On Mon, Apr 24, 2017 at 12:20 AM, <frowand.l...@gmail.com> wrote: >> From: Frank Rowand <frank.row...@sony.com> >> >> When adjusting overlay phandles to apply to the live device tree, can >> not modify the

Re: [PATCH 1/3] of: overlay_adjust_phandles() - do not modify const field

On 04/24/17 09:56, Rob Herring wrote: > On Mon, Apr 24, 2017 at 12:20 AM, wrote: >> From: Frank Rowand >> >> When adjusting overlay phandles to apply to the live device tree, can >> not modify the property value because it is type const. >> >> This is to

Re: [PATCH 2/2] of: Add unit tests for applying overlays.

On 04/24/17 10:16, Rob Herring wrote: > On Mon, Apr 24, 2017 at 12:43 AM, <frowand.l...@gmail.com> wrote: >> From: Frank Rowand <frank.row...@sony.com> >> >> Existing overlay unit tests examine individual pieces of the overlay >> code. The new test

Re: [PATCH 2/2] of: Add unit tests for applying overlays.

On 04/24/17 10:16, Rob Herring wrote: > On Mon, Apr 24, 2017 at 12:43 AM, wrote: >> From: Frank Rowand >> >> Existing overlay unit tests examine individual pieces of the overlay >> code. The new tests target the entire process of applying an overlay. >&g

Re: [RFC 2/3] of: reserved_mem: Accessor for acquiring reserved_mem

tatic inline struct reserved_mem *of_get_reserved_mem_by_idx(struct > device_node *np, > + int idx); > +{ > + return NULL; > +} > + > static inline void fdt_init_reserved_mem(void) { } > static inline void fdt_reserved_mem_save_node(unsigned long node, > const char *uname, phys_addr_t base, phys_addr_t size) { } > Reviewed-by: Frank Rowand <frank.row...@sony.com>

Re: [RFC 2/3] of: reserved_mem: Accessor for acquiring reserved_mem

m_by_idx(struct > device_node *np, > + int idx); > +{ > + return NULL; > +} > + > static inline void fdt_init_reserved_mem(void) { } > static inline void fdt_reserved_mem_save_node(unsigned long node, > const char *uname, phys_addr_t base, phys_addr_t size) { } > Reviewed-by: Frank Rowand

<    4   5   6   7   8   9   10   11   12   13   >