Re: [PATCH 4.19 000/247] 4.19.178-rc1 review

2021-03-03 Thread Hanjun Guo
On 2021/3/2 0:10, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.178 release. There are 247 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

Re: [PATCH 5.4 000/340] 5.4.102-rc1 review

2021-03-03 Thread Hanjun Guo
On 2021/3/2 0:09, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.4.102 release. There are 340 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

Re: [PATCH 5.4 000/340] 5.4.102-rc1 review

2021-03-02 Thread Hanjun Guo
On 2021/3/2 20:31, Greg Kroah-Hartman wrote: On Tue, Mar 02, 2021 at 02:42:15PM +0800, Hanjun Guo wrote: Hi Greg, On 2021/3/2 0:09, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.4.102 release. There are 340 patches in this series, all will be posted

Re: [PATCH 5.4 000/340] 5.4.102-rc1 review

2021-03-02 Thread Hanjun Guo
Hi Greg, On 2021/3/2 0:09, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.4.102 release. There are 340 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses

Re: [PATCH 4.19 000/247] 4.19.178-rc1 review

2021-03-01 Thread Hanjun Guo
On 2021/3/2 0:10, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 4.19.178 release. There are 247 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses should be made

Re: [PATCH 5.10 00/23] 5.10.19-rc1 review

2021-02-26 Thread Hanjun Guo
On 2021/2/26 14:44, Hanjun Guo wrote: Hi Greg, On 2021/2/25 17:53, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.10.19 release. There are 23 patches in this series, all will be posted as a response to this one.  If anyone has any issues with these being

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-26 Thread Hanjun Guo
Hi Nick, Sorry for taking so long to reply you, we had discussions on how to corporate with KCIDB, please see my comments inline. On 2021/2/19 22:45, Nikolai Kondrashov wrote: Hi Hanjun, On 2/19/21 10:54 AM, Hanjun Guo wrote: > In specific, we will start from the testing work, using H

Re: [PATCH 5.10 00/23] 5.10.19-rc1 review

2021-02-25 Thread Hanjun Guo
Hi Greg, On 2021/2/25 17:53, Greg Kroah-Hartman wrote: This is the start of the stable review cycle for the 5.10.19 release. There are 23 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know. Responses

Re: [PATCH v1] ACPI: processor: idle: Drop extra prefix from pr_notice()

2021-02-25 Thread Hanjun Guo
On 2021/2/25 2:37, Rafael J. Wysocki wrote: From: Rafael J. Wysocki Drop "ACPI: " from the pr_noitice() instance in acpi_processor_cstate_first_run_checks(), because pr_fmt() causes that prefix to be added to the message already. Reported-by: Hanjun Guo Signed-off-by: Rafael

Re: [PATCH v1 1/4] ACPI: processor: Get rid of ACPICA message printing

2021-02-25 Thread Hanjun Guo
On 2021/2/25 2:06, Rafael J. Wysocki wrote: On Tue, Feb 23, 2021 at 3:45 PM Rafael J. Wysocki wrote: On Tue, Feb 23, 2021 at 12:31 PM Hanjun Guo wrote: On 2021/2/23 2:59, Rafael J. Wysocki wrote: Index: linux-pm/drivers/acpi/processor_idle.c

Re: [PATCH v1 0/4] ACPI: Get rid of ACPICA message printing from core

2021-02-23 Thread Hanjun Guo
for details. Except patch 1/4, others are looking good to me. some legacy printk(PRIFIX ...) are still there, but we can clean up them later. Feel feel to add my review tag with minor issue addressed. Reviewed-by: Hanjun Guo Thanks Hanjun

Re: [PATCH v1 1/4] ACPI: processor: Get rid of ACPICA message printing

2021-02-23 Thread Hanjun Guo
On 2021/2/23 2:59, Rafael J. Wysocki wrote: Index: linux-pm/drivers/acpi/processor_idle.c === --- linux-pm.orig/drivers/acpi/processor_idle.c +++ linux-pm/drivers/acpi/processor_idle.c In this file, function

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-22 Thread Hanjun Guo
On 2021/2/20 17:53, Greg Kroah-Hartman wrote: On Sat, Feb 20, 2021 at 03:02:54PM +0800, Hanjun Guo wrote: On 2021/2/19 17:08, Greg Kroah-Hartman wrote: On Fri, Feb 19, 2021 at 04:54:24PM +0800, Hanjun Guo wrote: Hi Greg, On 2021/1/26 15:29, Greg Kroah-Hartman wrote: [...] I want to see

Re: [PATCH v1 0/4] ACPI: PCI: Unify printing of messages

2021-02-20 Thread Hanjun Guo
to me, Reviewed-by: Hanjun Guo Thanks Hanjun

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-19 Thread Hanjun Guo
On 2021/2/19 17:08, Greg Kroah-Hartman wrote: On Fri, Feb 19, 2021 at 04:54:24PM +0800, Hanjun Guo wrote: Hi Greg, On 2021/1/26 15:29, Greg Kroah-Hartman wrote: [...] I want to see companies _using_ the kernel, and most importantly, _updating_ their devices with it, to know if it is worth

Re: 5.10 LTS Kernel: 2 or 6 years?

2021-02-19 Thread Hanjun Guo
Hi Greg, On 2021/1/26 15:29, Greg Kroah-Hartman wrote: [...] I want to see companies _using_ the kernel, and most importantly, _updating_ their devices with it, to know if it is worth to keep around for longer than 2 years. I also, hopefully, want to see how those companies will help me out

Re: [PATCH v3 4/5] ACPI: video: Clean up printing messages

2021-02-03 Thread Hanjun Guo
changes to fix up white space and use ACPI_FAILURE() instead of negating ACPI_SUCCESS(). Signed-off-by: Rafael J. Wysocki Reviewed-by: Hanjun Guo Thanks Hanjun

Re: [PATCH v3 2/5] ACPI: battery: Clean up printing messages

2021-02-03 Thread Hanjun Guo
and drop the unneeded PREFIX sybmbol definition from battery.c. Also adapt the existing pr_info() calls to the new pr_fmt() definition. Signed-off-by: Rafael J. Wysocki Reviewed-by: Hanjun Guo Thanks Hanjun

Re: [PATCH v3 1/5] ACPI: AC: Clean up printing messages

2021-02-03 Thread Hanjun Guo
with pr_info(), add a pr_fmt() definition to ac.c and drop the unneeded PREFIX symbol definition from there. Signed-off-by: Rafael J. Wysocki --- v2 -> v3: Also add a pr_fmt() definition to ac.c and replace direct printk() with pr_info (no log level change). Reviewed-by: Hanjun Guo

Re: [PATCH v2 5/5] ACPI: thermal: Clean up printing messages

2021-02-02 Thread Hanjun Guo
--- v1 -> v2: Changelog update Reviewed-by: Hanjun Guo Thanks Hanjun

Re: [PATCH v2 4/5] ACPI: video: Clean up printing messages

2021-02-02 Thread Hanjun Guo
On 2021/2/3 2:18, Rafael J. Wysocki wrote: [...] Also make one unrelated janitorial change to fix up white space and use ACPI_FAILURE() instead of negating ACPI_SUCCESS(). [...] status = acpi_evaluate_object(video->device->handle, "_DOD", NULL, ); if (!ACPI_SUCCESS(status))

Re: [PATCH v2 3/5] ACPI: button: Clean up printing messages

2021-02-02 Thread Hanjun Guo
-by: Hanjun Guo

Re: [PATCH v2 2/5] ACPI: battery: Clean up printing messages

2021-02-02 Thread Hanjun Guo
On 2021/2/3 2:15, Rafael J. Wysocki wrote: From: Rafael J. Wysocki Replace the ACPI_DEBUG_PRINT() and ACPI_EXCEPTION() instances in battery.c with acpi_handle_debug() and acpi_handle_info() calls, respectively, which among other things causes the excessive log level of the messages previously

Re: [PATCH v2 1/5] ACPI: AC: Clean up printing messages

2021-02-02 Thread Hanjun Guo
Hi Rafael, On 2021/2/3 2:14, Rafael J. Wysocki wrote: From: Rafael J. Wysocki Replace the ACPI_DEBUG_PRINT() and ACPI_EXCEPTION() instances in ac.c with acpi_handle_debug() and acpi_handle_info() calls, respectively, which among other things causes the excessive log level of the messages

Re: [PATCH] ACPI: configfs: add missing check after configfs_register_default_group

2021-01-13 Thread Hanjun Guo
On 2021/1/13 15:30, Qinglang Miao wrote: A list_add corruption is reported by Hulk Robot like this: == list_add corruption. Call Trace: link_obj+0xc0/0x1c0 link_group+0x21/0x140 configfs_register_subsystem+0xdb/0x380 acpi_configfs_init+0x25/0x1000 [acpi_configfs]

[PATCH v3 1/2] drm/amdkfd: Move the ignore_crat check before the CRAT table get

2020-11-12 Thread Hanjun Guo
If the ignore_crat is set to non-zero value, it's no point getting the CRAT table, so just move the ignore_crat check before we get the CRAT table. Signed-off-by: Hanjun Guo --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

[PATCH v3 2/2] drm/amdkfd: Put ACPI table after using it

2020-11-12 Thread Hanjun Guo
used to get the OEM information, so those two table mappings need to be released after using it. Fixes: 174de876d6d0 ("drm/amdkfd: Group up CRAT related functions") Fixes: 520b8fb755cc ("drm/amdkfd: Add topology support for CPUs") Signed-off-by: Hanjun Guo --- driver

Re: [PATCH v4 0/6] resource: introduce union(), intersection() API

2020-11-03 Thread Hanjun Guo
On 2020/11/3 16:31, Andy Shevchenko wrote: On Tue, Nov 3, 2020 at 2:46 AM Hanjun Guo wrote: On 2020/11/3 5:00, Andy Shevchenko wrote: Some users may want to use resource library to manage their own resources, besides existing users that open code union() and intersection() implementations

Re: [PATCH v4 0/6] resource: introduce union(), intersection() API

2020-11-02 Thread Hanjun Guo
-by: Hanjun Guo

Re: [PATCH v4 6/7] arm64: mm: Set ZONE_DMA size based on early IORT scan

2020-10-28 Thread Hanjun Guo
Murphy Cc: Hanjun Guo Cc: Sudeep Holla Cc: Anshuman Khandual Signed-off-by: Ard Biesheuvel [nsaenz: Rebased, removed documentation change and add declaration in acpi_iort.h] Signed-off-by: Nicolas Saenz Julienne --- Changes since v3: - Use min_not_zero() - Check ACPI revision - Remove

Re: [PATCH] ACPI: dock: fix enum-conversion warning

2020-10-26 Thread Hanjun Guo
FY_EJECT_REQUEST, false); + dock_hotplug_event(dd, ACPI_NOTIFY_EJECT_REQUEST, + DOCK_CALL_HANDLER); list_for_each_entry_reverse(dd, >dependent_devices, list) acpi_bus_trim(dd->adev); Reviewed-by: Hanjun Guo

Re: [PATCH v3 7/8] arm64: mm: Set ZONE_DMA size based on early IORT scan

2020-10-16 Thread Hanjun Guo
On 2020/10/16 15:27, Hanjun Guo wrote: The patch only takes the address limit field into account if its value > 0. Sorry I missed the if (*->memory_address_limit) check, thanks for the reminding. Also, before commit 7fb89e1d44cb6aec ("ACPI/IORT: take _DMA methods into accoun

Re: [PATCH v3 7/8] arm64: mm: Set ZONE_DMA size based on early IORT scan

2020-10-16 Thread Hanjun Guo
Hi Ard, On 2020/10/16 14:54, Ard Biesheuvel wrote: On Fri, 16 Oct 2020 at 08:51, Hanjun Guo wrote: On 2020/10/16 2:03, Catalin Marinas wrote: On Thu, Oct 15, 2020 at 10:26:18PM +0800, Hanjun Guo wrote: On 2020/10/15 3:12, Nicolas Saenz Julienne wrote: From: Ard Biesheuvel We recently

Re: [PATCH 1/1] ACPI/IORT: Fix doc warnings in iort.c

2020-10-16 Thread Hanjun Guo
'size' description in 'iort_dma_setup' drivers/acpi/arm64/iort.c:1534: warning: Function parameter or member 'ops' not described in 'iort_add_platform_device' Signed-off-by: Shiju Jose Acked-by: Hanjun Guo

Re: [PATCH v3 7/8] arm64: mm: Set ZONE_DMA size based on early IORT scan

2020-10-16 Thread Hanjun Guo
On 2020/10/16 2:03, Catalin Marinas wrote: On Thu, Oct 15, 2020 at 10:26:18PM +0800, Hanjun Guo wrote: On 2020/10/15 3:12, Nicolas Saenz Julienne wrote: From: Ard Biesheuvel We recently introduced a 1 GB sized ZONE_DMA to cater for platforms incorporating masters that can address less than

Re: [PATCH v3 7/8] arm64: mm: Set ZONE_DMA size based on early IORT scan

2020-10-15 Thread Hanjun Guo
32), but with the wrong DMA size in IORT, we still have the ZONE_DMA created which is actually not needed? Cc: Jeremy Linton Cc: Lorenzo Pieralisi Cc: Nicolas Saenz Julienne Cc: Rob Herring Cc: Christoph Hellwig Cc: Robin Murphy Cc: Hanjun Guo Cc: Sudeep Holla Cc: Anshuman Khandual Sig

Re: [PATCH] ACPI / NUMA: Add stub function for pxm_to_node

2020-09-30 Thread Hanjun Guo
/* CONFIG_ACPI_NUMA */ #endif/* __ACP_NUMA_H */ Looks good to me, Reviewed-by: Hanjun Guo

Re: [PATCH v2 0/2] ACPI/IORT: Code cleanups

2020-09-02 Thread Hanjun Guo
On 2020/9/2 17:48, Will Deacon wrote: On Wed, Sep 02, 2020 at 05:17:43PM +0800, Hanjun Guo wrote: +Cc Will On 2020/8/18 17:16, Hanjun Guo wrote: On 2020/8/18 14:36, Zenghui Yu wrote: * From v1 [1]:    - As pointed out by Hanjun, remove two now unused inline functions. Compile tested

Re: [PATCH v2 0/2] ACPI/IORT: Code cleanups

2020-09-02 Thread Hanjun Guo
+Cc Will On 2020/8/18 17:16, Hanjun Guo wrote: On 2020/8/18 14:36, Zenghui Yu wrote: * From v1 [1]:    - As pointed out by Hanjun, remove two now unused inline functions. Compile tested with CONFIG_IOMMU_API is not selected. [1] https://lore.kernel.org/r/20200817105946.1511-1-yuzeng

Re: [PATCH v2 1/2] drm/amdkfd: Move the ignore_crat check before the CRAT table get

2020-08-27 Thread Hanjun Guo
On 2020/8/27 12:28, Felix Kuehling wrote: Am 2020-08-26 um 4:29 a.m. schrieb Hanjun Guo: If the ignore_crat is set to non-zero value, it's no point getting the CRAT table, so just move the ignore_crat check before we get the CRAT table. Signed-off-by: Hanjun Guo --- drivers/gpu/drm/amd

[PATCH v2 2/2] drm/amdkfd: Put ACPI table after using it

2020-08-26 Thread Hanjun Guo
used to get the OEM information, so those two table mappings need to be released after using it. Fixes: 174de876d6d0 ("drm/amdkfd: Group up CRAT related functions") Fixes: 520b8fb755cc ("drm/amdkfd: Add topology support for CPUs") Signed-off-by: Hanjun Guo --- driver

[PATCH v2 1/2] drm/amdkfd: Move the ignore_crat check before the CRAT table get

2020-08-26 Thread Hanjun Guo
If the ignore_crat is set to non-zero value, it's no point getting the CRAT table, so just move the ignore_crat check before we get the CRAT table. Signed-off-by: Hanjun Guo --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git

Re: [PATCH v2 0/2] ACPI/IORT: Code cleanups

2020-08-18 Thread Hanjun Guo
the unused @ops of iort_add_device_replay() ACPI/IORT: Remove the unused inline functions drivers/acpi/arm64/iort.c | 10 ++ 1 file changed, 2 insertions(+), 8 deletions(-) Nice cleanup. Acked-by: Hanjun Guo

Re: [PATCH] ACPI/IORT: Drop the unused @ops of iort_add_device_replay()

2020-08-17 Thread Hanjun Guo
On 2020/8/17 18:59, Zenghui Yu wrote: Since commit d2e1a003af56 ("ACPI/IORT: Don't call iommu_ops->add_device directly"), we use the IOMMU core API to replace a direct invoke of the specified callback. The parameter @ops has therefore became unused. Let's drop it. Signed-off-by: Zenghui Yu ---

Re: [PATCH] drm/amdkfd: Put ACPI table after using it

2020-07-31 Thread Hanjun Guo
On 2020/7/31 10:41, Felix Kuehling wrote: Hi Hanjun, Sorry for the late reply. Thank you for the patch and the explanation. This seems to have been broken since the first version of KFD in 2014. See one suggestion inline. Am 2020-07-22 um 5:48 a.m. schrieb Hanjun Guo: The acpi_get_table

[PATCH] dmaengine: acpi: Put the CSRT table after using it

2020-07-22 Thread Hanjun Guo
The acpi_get_table() should be coupled with acpi_put_table() if the mapped table is not used at runtime to release the table mapping, put the CSRT table buf after using it. Signed-off-by: Hanjun Guo --- drivers/dma/acpi-dma.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git

[PATCH] drm/amdkfd: Put ACPI table after using it

2020-07-22 Thread Hanjun Guo
those table mappings need to be release after using it. Signed-off-by: Hanjun Guo --- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 16 +++- 1 file changed, 11 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_crat.c b/drivers/gpu/drm/amd/amdkfd/kfd_crat.c index

[PATCH] mailbox: pcc: Put the PCCT table for error path

2020-07-22 Thread Hanjun Guo
-by: Hanjun Guo --- drivers/mailbox/pcc.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c index 8c7fac3..ef9ecd1 100644 --- a/drivers/mailbox/pcc.c +++ b/drivers/mailbox/pcc.c @@ -457,14 +457,17 @@ static int __init

Re: [Question]: about 'cpuinfo_cur_freq' shown in sysfs when the CPU is in idle state

2020-06-02 Thread Hanjun Guo
On 2020/6/2 11:34, Xiongfeng Wang wrote: Hi Viresh, Sorry to disturb you about another problem as follows. CPPC use the increment of Desired Performance counter and Reference Performance counter to get the CPU frequency and show it in sysfs through 'cpuinfo_cur_freq'. But ACPI CPPC doesn't

Re: arm64/acpi: NULL dereference reports from UBSAN at boot

2020-05-22 Thread Hanjun Guo
On 2020/5/22 16:07, Hanjun Guo wrote: Hi Will, On 2020/5/21 18:09, Will Deacon wrote: Hi folks, I just tried booting the arm64 for-kernelci branch under QEMU (version 4.2.50 (v4.2.0-779-g4354edb6dcc7)) with UBSAN enabled, and I see a couple of NULL pointer dereferences reported at boot. I

Re: arm64/acpi: NULL dereference reports from UBSAN at boot

2020-05-22 Thread Hanjun Guo
Hi Will, On 2020/5/21 18:09, Will Deacon wrote: Hi folks, I just tried booting the arm64 for-kernelci branch under QEMU (version 4.2.50 (v4.2.0-779-g4354edb6dcc7)) with UBSAN enabled, and I see a couple of NULL pointer dereferences reported at boot. I think they're both GIC related (log

Re: [PATCH v2] ACPI/IORT: Fix PMCG node always look for a single ID mapping.

2020-05-12 Thread Hanjun Guo
pmcg->overflow_gsiv) + return -EINVAL; + return 0; default: return -EINVAL; With my comments addressed, Reviewed-by: Hanjun Guo

Re: [PATCH] ACPI/IORT: Remove the unused __get_pci_rid()

2020-05-09 Thread Hanjun Guo
On 2020/5/9 17:34, Zenghui Yu wrote: Since commit bc8648d49a95 ("ACPI/IORT: Handle PCI aliases properly for IOMMUs"), __get_pci_rid() has become actually unused and can be removed. Signed-off-by: Zenghui Yu Looks good to me, Acked-by: Hanjun Guo

Re: [RFC PATCH] cpufreq: add support for HiSilicon SoC HIP09

2020-05-07 Thread Hanjun Guo
any enhancements there. Regards, Thanu On 06/05/2020, 18:19, "Sudeep Holla" wrote: + Thanu, Souvik who work with ASWG On Wed, May 06, 2020 at 05:36:51PM +0800, Hanjun Guo wrote: > Hi Sudeep, > > On 2020/4/30 17:55, Sudeep Holla wrote: >

Re: [RFC PATCH] cpufreq: add support for HiSilicon SoC HIP09

2020-05-06 Thread Hanjun Guo
Hi Sudeep, On 2020/4/30 17:55, Sudeep Holla wrote: On Thu, Apr 30, 2020 at 02:19:59PM +0800, Xiongfeng Wang wrote: HiSilicon SoC has a separate System Control Processor(SCP) dedicated for clock frequency adjustment and has been using the cpufreq driver 'cppc-cpufreq'. New HiSilicon SoC HIP09

Re: [PATCH 3/3] arm64: configs: unset CPU_BIG_ENDIAN

2019-10-14 Thread Hanjun Guo
On 2019/10/15 0:24, Will Deacon wrote: > On Sat, Oct 12, 2019 at 03:50:55PM +0100, Russell King - ARM Linux admin > wrote: >> On Sat, Oct 12, 2019 at 12:47:45AM +0200, Arnd Bergmann wrote: >>> On Fri, Oct 11, 2019 at 12:33 PM Russell King - ARM Linux admin >>> wrote: 32-bit ARM experience

Re: [PATCH 3/3] arm64: configs: unset CPU_BIG_ENDIAN

2019-10-14 Thread Hanjun Guo
Hi Arnd, On 2019/10/12 22:05, Arnd Bergmann wrote: > On Sat, Oct 12, 2019 at 9:33 AM Hanjun Guo wrote: >> >> On 2019/10/11 18:27, Will Deacon wrote: >> [...] >>> >>> Does anybody use BIG_ENDIAN? If we're not even building it then maybe we >>> s

Re: [PATCH 3/3] arm64: configs: unset CPU_BIG_ENDIAN

2019-10-12 Thread Hanjun Guo
On 2019/10/11 18:27, Will Deacon wrote: [...] > > Does anybody use BIG_ENDIAN? If we're not even building it then maybe we > should get rid of it altogether on arm64. I don't know of any supported > userspace that supports it or any CPUs that are unable to run little-endian > binaries. FWIW,

Re: [RFC PATCH 0/3] ACPI, arm64: Backport for ACPI PPTT 6.3 thread flag for stable 4.19.x

2019-10-10 Thread Hanjun Guo
Hi John, On 2019/10/10 21:29, John Garry wrote: > This series is a backport of the ACPI PPTT 6.3 thread flag feature for > supporting arm64 systems. > > The background is that some arm64 implementations are broken, in that they > incorrectly advertise that a CPU is mutli-threaded, when it is not

Re: [PATCH v3 00/10] Rework REFCOUNT_FULL using atomic_fetch_* operations

2019-10-09 Thread Hanjun Guo
Changes since v2 include: > > - Remove the x86 assembly version and enable this code unconditionally > - Move saturation warnings out-of-line to reduce image bloat > > Cheers, > > Will > > Cc: Kees Cook > Cc: Ingo Molnar > Cc: Elena Reshetova > Cc: Peter

Re: [PATCH v4 1/5] locking/qspinlock: Rename arch_mcs_spin_unlock_contended to arch_mcs_pass_lock and make it more generic

2019-09-17 Thread Hanjun Guo
Hi Alex, On 2019/9/6 22:25, Alex Kogan wrote: > The new macro should accept the value to be stored into the lock argument > as another argument. This allows using the same macro in cases where the > value to be stored when passing the lock is different from 1. > > Signed-off-by: Alex Kogan >

Re: [PATCH v2 0/6] Rework REFCOUNT_FULL using atomic_fetch_* operations

2019-09-06 Thread Hanjun Guo
On 2019/9/6 21:43, Will Deacon wrote: > On Wed, Aug 28, 2019 at 02:03:37PM -0700, Kees Cook wrote: >> On Wed, Aug 28, 2019 at 03:14:40PM +0100, Will Deacon wrote: >>> On Wed, Aug 28, 2019 at 09:30:52AM +0200, Peter Zijlstra wrote: On Tue, Aug 27, 2019 at 05:31:58PM +0100, Will Deacon wrote:

Re: [PATCH v12 2/2] mm: page_alloc: reduce unnecessary binary search in memblock_next_valid_pfn

2019-07-24 Thread Hanjun Guo
On 2019/7/23 16:33, Mike Rapoport wrote: > On Tue, Jul 23, 2019 at 01:51:13PM +0800, Hanjun Guo wrote: >> From: Jia He >> >> After skipping some invalid pfns in memmap_init_zone(), there is still >> some room for improvement. >> >> E.g. if pfn and pfn+1

Re: [PATCH v12 1/2] mm: page_alloc: introduce memblock_next_valid_pfn() (again) for arm64

2019-07-24 Thread Hanjun Guo
On 2019/7/23 16:30, Mike Rapoport wrote: > On Tue, Jul 23, 2019 at 01:51:12PM +0800, Hanjun Guo wrote: >> From: Jia He >> >> Commit b92df1de5d28 ("mm: page_alloc: skip over regions of invalid pfns >> where possible") optimized the loop in memmap_init_zone(). B

[PATCH v12 1/2] mm: page_alloc: introduce memblock_next_valid_pfn() (again) for arm64

2019-07-22 Thread Hanjun Guo
el Vacek Signed-off-by: Jia He Signed-off-by: Hanjun Guo --- arch/arm64/Kconfig | 1 + include/linux/mmzone.h | 9 + mm/Kconfig | 3 +++ mm/memblock.c | 31 +++ mm/page_alloc.c| 4 +++- 5 files changed, 47 insertions(+),

[PATCH v12 2/2] mm: page_alloc: reduce unnecessary binary search in memblock_next_valid_pfn

2019-07-22 Thread Hanjun Guo
memory region, skip to next region directly to speedup the binary search. Signed-off-by: Jia He Signed-off-by: Hanjun Guo --- mm/memblock.c | 37 +++-- 1 file changed, 31 insertions(+), 6 deletions(-) diff --git a/mm/memblock.c b/mm/memblock.c index d57ba51bb9cd

[PATCH v12 0/2] introduce memblock_next_valid_pfn() (again) for arm64

2019-07-22 Thread Hanjun Guo
Here is new version of "[PATCH v11 0/3] remain and optimize memblock_next_valid_pfn on arm and arm64" from Jia He, which is suggested by Ard to respin this patch set [1]. In the new version, I squashed patch 1/3 and patch 2/3 in v11 into one patch, fixed a bug for possible out of bound accessing

Re: [PATCH 0/3] arm64: Allow early timestamping of kernel log

2019-07-22 Thread Hanjun Guo
bunch of arm64 systems, both bare-metal and in VMs. Boot > tested on a x86 guest. This makes the boot log more useful and I can debug some time consuming issue easier before the arch timer initialization, tested on my ARM64 server, I can see the timestamping from the start [1], Tested-by: Hanjun

Re: [PATCH] ACPI/IORT: Fix off-by-one check in iort_dev_find_its_id()

2019-07-22 Thread Hanjun Guo
PI: Add new IORT functions to support MSI domain > handling") > Link: https://lore.kernel.org/linux-arm-kernel/20190613065410.GB16334@mwanda/ > Reported-by: Dan Carpenter > Signed-off-by: Lorenzo Pieralisi > Cc: Dan Carpenter > Cc: Will Deacon > Cc: Hanjun Guo > Cc:

Re: [PATCH] ACPI/IORT: Rename arm_smmu_v3_set_proximity() 'node' local variable

2019-07-22 Thread Hanjun Guo
ameter. > > Execution was unaffected but it is prone to errors and can lead > to subtle bugs. > > Rename the local variable to prevent any issue. > > Reported-by: Will Deacon > Signed-off-by: Lorenzo Pieralisi > Cc: Will Deacon > Cc: Hanjun Guo > Cc: Sudeep

Re: [PATCH v2 0/5] Add NUMA-awareness to qspinlock

2019-07-12 Thread Hanjun Guo
gt; greatly reduced. > Tested-by: Jan Glauber Tested this patchset on Kunpeng920 ARM64 server (96 cores, 4 NUMA nodes), and with the same test case from Jan, I can see 150%+ boost! (Need to add a patch below [1].) For the real workload such as Nginx I can see about 10% performance improvement as wel

Re: [PATCH v3 1/2] x86, arm64: Move ARCH_WANT_HUGE_PMD_SHARE config in arch/Kconfig

2019-07-01 Thread Hanjun Guo
ARM64_4K_PAGES || (ARM64_16K_PAGES > && !ARM64_VA_BITS_36) > select ARCH_HAS_UBSAN_SANITIZE_ALL > select ARM_AMBA > select ARM_ARCH_TIMER > @@ -901,9 +902,6 @@ config HW_PERF_EVENTS > config SYS_SUPPORTS_HUGETLBFS > def_bool y > > -co

Re: [PATCH REBASE v2 1/2] x86, arm64: Move ARCH_WANT_HUGE_PMD_SHARE config in arch/Kconfig

2019-06-30 Thread Hanjun Guo
On 2019/5/26 20:50, Alexandre Ghiti wrote: > ARCH_WANT_HUGE_PMD_SHARE config was declared in both architectures: > move this declaration in arch/Kconfig and make those architectures > select it. > > Signed-off-by: Alexandre Ghiti > Reviewed-by: Palmer Dabbelt > --- > arch/Kconfig | 3 +++

Re: [PATCH v8 3/7] cpu-topology: Move cpu topology code to common code.

2019-06-28 Thread Hanjun Guo
A node1 CPU(s): 24-47 NUMA node2 CPU(s): 48-71 NUMA node3 CPU(s): 72-95 Flags: fp asimd evtstrm aes pmull sha1 sha2 crc32 atomics fphp asimdhp cpuid asimdrdm jscvt fcma dcpop asimddp asimdfhm Tested-by: Hanjun Guo For the ACPI code, Acked-by: Hanjun Guo Thanks Hanjun

Re: [PATCH v5 1/4] ACPI/PPTT: Modify node flag detection to find last IDENTICAL

2019-06-26 Thread Hanjun Guo
On 2019/6/27 5:37, Jeremy Linton wrote: > The ACPI specification implies that the IDENTICAL flag should be > set on all non leaf nodes where the children are identical. > This means that we need to be searching for the last node with > the identical flag set rather than the first one. > > Since

Re: [PATCH v2] irqchip/mbigen: stop printing kernel addresses

2019-06-18 Thread Hanjun Guo
if (err) { > - dev_err(>dev, "Failed to create mbi-gen@%p irqdomain", > - mgn_chip->base); > + dev_err(>dev, "Failed to create mbi-gen irqdomain\n"); > return err; Reviewed-by: Hanjun Guo

Re: [PATCH] irqchip/mbigen: stop printing kernel addresses

2019-06-18 Thread Hanjun Guo
On 2019/6/18 11:22, Kefeng Wang wrote: > After commit ad67b74d2469d9b8 ("printk: hash addresses printed with %p"), > it will print "ptrval" instead of actual addresses when mbigen > create domain fails, > > Hisilicon MBIGEN-V2 HISI0152:00: Failed to create mbi-gen@(ptrval) >

Re: [PATCH v4 0/4] arm64: SPE ACPI enablement

2019-06-17 Thread Hanjun Guo
rop ARM_SPE_ACPI and just use ARM_SPE_PMU. Tested on top of 5.2-rc1, I can see in the boot log: arm_spe_pmu arm,spe-v1: probed for CPUs 0-95 [max_record_sz 128, align 4, features 0x7] and I also tested perf record, and works as expected, Tested-by: Hanjun Guo Thanks Hanjun

Re: [RFC] Disable lockref on arm64

2019-06-13 Thread Hanjun Guo
On 2019/6/12 12:10, Jayachandran Chandrasekharan Nair wrote: > On Wed, May 22, 2019 at 05:04:17PM +0100, Will Deacon wrote: >> On Sat, May 18, 2019 at 12:00:34PM +0200, Ard Biesheuvel wrote: >>> On Sat, 18 May 2019 at 06:25, Jayachandran Chandrasekharan Nair >>> wrote: On Mon, May 06,

Re: [PATCH v11 0/3] remain and optimize memblock_next_valid_pfn on arm and arm64

2019-06-12 Thread Hanjun Guo
On 2019/6/12 9:05, Jia He wrote: >> >>> So what I would like to see is the patch set being proposed again, >>> with the new data points added for documentation. Also, the commit >>> logs need to crystal clear about how the meaning of PFN validity >>> differs between ARM and other architectures,

Re: [PATCH v11 0/3] remain and optimize memblock_next_valid_pfn on arm and arm64

2019-06-11 Thread Hanjun Guo
Hello Ard, Thanks for the reply, please see my comments inline. On 2019/6/10 21:16, Ard Biesheuvel wrote: > On Sat, 8 Jun 2019 at 06:22, Hanjun Guo wrote: >> >> Hi Ard, Will, >> >> This week we were trying to debug an issue of time consuming in mem_init(), >

Re: [PATCH v11 0/3] remain and optimize memblock_next_valid_pfn on arm and arm64

2019-06-07 Thread Hanjun Guo
Hi Ard, Will, This week we were trying to debug an issue of time consuming in mem_init(), and leading to this similar solution form Jia He, so I would like to bring this thread back, please see my detail test result below. On 2018/9/7 22:44, Will Deacon wrote: > On Thu, Sep 06, 2018 at

Re: [PATCH] ACPI/IORT: Fix build without CONFIG_IOMMU_API

2019-05-20 Thread Hanjun Guo
On 2019/5/20 14:57, Christoph Hellwig wrote: > IOMMU_FWSPEC_PCI_RC_ATS is only defined if CONFIG_IOMMU_API is > enabled. > > Fixes: 5702ee24182f ("ACPI/IORT: Check ATS capability in root complex nodes") > Signed-off-by: Christoph Hellwig > --- > drivers/acpi/arm64/iort.c | 3 ++- > 1 file

Re: [PATCH v2 3/5] locking/qspinlock: Introduce CNA into the slow path of qspinlock

2019-04-03 Thread Hanjun Guo
Hi Alex, On 2019/3/29 23:20, Alex Kogan wrote: > + > +static __always_inline void cna_init_node(struct mcs_spinlock *node, int > cpuid, > + u32 tail) > +{ > + if (decode_numa_node(node->node_and_count) == -1) > + store_numa_node(node,

Re: [PATCH RFC 1/1] iommu: set the default iommu-dma mode as non-strict

2019-02-26 Thread Hanjun Guo
Hi Jean, On 2019/1/31 22:55, Jean-Philippe Brucker wrote: > Hi, > > On 31/01/2019 13:52, Zhen Lei wrote: >> Currently, many peripherals are faster than before. For example, the top >> speed of the older netcard is 10Gb/s, and now it's more than 25Gb/s. But >> when iommu page-table mapping

Re: [PATCH v6 4/4] perf/smmuv3_pmu: Enable HiSilicon Erratum 162001800 quirk

2019-02-13 Thread Hanjun Guo
> > Signed-off-by: Shameer Kolothum > --- > drivers/acpi/arm64/iort.c | 16 ++- > drivers/perf/arm_smmuv3_pmu.c | 48 > --- > include/linux/acpi_iort.h | 1 + > 3 files changed, 57 insertions(+), 8 deletions(-) For this patch, Reviewed-by: Hanjun Guo Thanks Hanjun

Re: [RFC PATCH] USB: PCI: set 32bit DMA mask for PCI based USB controllers

2019-02-02 Thread Hanjun Guo
On 2019/2/1 17:13, Hanjun Guo wrote: > On 2019/2/1 13:55, Hanjun Guo wrote: >> Hi John, >> >> On 2019/1/31 17:54, John Garry wrote: >>> On 30/01/2019 07:01, Hanjun Guo wrote: >>>> From: Hanjun Guo >> [...] >>>> >>>>

Re: [RFC PATCH] USB: PCI: set 32bit DMA mask for PCI based USB controllers

2019-02-01 Thread Hanjun Guo
On 2019/2/1 13:55, Hanjun Guo wrote: > Hi John, > > On 2019/1/31 17:54, John Garry wrote: >> On 30/01/2019 07:01, Hanjun Guo wrote: >>> From: Hanjun Guo > [...] >>> >>>  drivers/usb/core/hcd-pci.c | 4 >>>  1 file changed, 4 insertion

Re: [RFC PATCH] USB: PCI: set 32bit DMA mask for PCI based USB controllers

2019-01-31 Thread Hanjun Guo
Hi John, On 2019/1/31 17:54, John Garry wrote: > On 30/01/2019 07:01, Hanjun Guo wrote: >> From: Hanjun Guo [...] >> >>  drivers/usb/core/hcd-pci.c | 4 >>  1 file changed, 4 insertions(+) >> >> diff --git a/drivers/usb/core/hcd-pci.c b/drivers/usb/c

Re: [RFC PATCH] USB: PCI: set 32bit DMA mask for PCI based USB controllers

2019-01-30 Thread Hanjun Guo
Hi Christoph, On 2019/1/30 15:40, Christoph Hellwig wrote: > On Wed, Jan 30, 2019 at 03:01:54PM +0800, Hanjun Guo wrote: >> This is the RFC version, I'm not sure this is the best solution, >> comments are warmly welcomed. >> >> Thanks >> Hanjun >> >&g

[RFC PATCH] USB: PCI: set 32bit DMA mask for PCI based USB controllers

2019-01-29 Thread Hanjun Guo
From: Hanjun Guo We met an issue that when we update the IORT table to revision D, and the kernel update to 4.19, the USB on D06 (ARM64 based server) will probe fail: [ 13.495751] CPU: 0 PID: 15 Comm: kworker/0:1 Not tainted 4.19.0-00115-gb2b5200 #5 [ 13.503219] Hardware name: Huawei D06

Re: [PATCH v2 0/4] add support for MBIGEN generating message based SPIs

2019-01-09 Thread Hanjun Guo
Hi Marc, Sorry for ping you... On 2018/10/26 15:51, Yang Yingliang wrote: > Now MBIGENs have pins that used to generate SPIs, > with > 5052875 ("irqchip/gic-v3: Add support for Message Based Interrupts as an MSI > controller"), > we can support MBIGEN to generate message based SPIs by writing >

Re: [PATCH -next] ACPI/IORT: fix build when CONFIG_IOMMU_API=n

2018-12-24 Thread Hanjun Guo
return NULL; } > static inline int iort_add_device_replay(const struct iommu_ops *ops, >struct device *dev) Acked-by: Hanjun Guo Lorenzo, I think this is 4.21-rc1 material if it's OK for you. Thanks Hanjun

Re: [PATCH v11 6/7] ACPI/IORT: Stub out ACS functions when CONFIG_PCI is not set

2018-12-17 Thread Hanjun Guo
On 2018/12/18 10:56, Sinan Kaya wrote: > Remove PCI dependent code out of iort.c when CONFIG_PCI is not defined. > A quick search reveals the following functions: > 1. pci_request_acs() > 2. pci_domain_nr() > 3. pci_is_root_bus() > 4. to_pci_dev() > > Both pci_domain_nr() and pci_is_root_bus()

Re: [PATCH v10 6/6] ACPI/IORT: Stub out ACS functions when CONFIG_PCI is not set

2018-12-17 Thread Hanjun Guo
Hi Sinan, On 2018/12/15 9:02, Sinan Kaya wrote: > Remove PCI dependent code out of iort.c when CONFIG_PCI is not defined. > > Signed-off-by: Sinan Kaya > --- > drivers/acpi/arm64/iort.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/acpi/arm64/iort.c

Re: [PATCH 4/4] ACPI/IORT: Don't call iommu_ops->add_device directly

2018-12-17 Thread Hanjun Guo
tions(-) Robin and Lorenzo know this better than me, but it's pretty straight forward to me, Acked-by: Hanjun Guo Thanks Hanjun

Re: [PATCH 3/6] ACPI/IORT: Use device_iommu_mapped()

2018-12-17 Thread Hanjun Guo
On 2018/12/11 21:43, Joerg Roedel wrote: > From: Joerg Roedel > > Replace the iommu-check with a proper and readable function > call. > > Cc: Lorenzo Pieralisi > Acked-by: Robin Murphy > Signed-off-by: Joerg Roedel Acked-by: Hanjun Guo Thanks Hanjun

Re: [PATCH 2/9] ACPI/IORT: Use helper functions to access dev->iommu_fwspec

2018-12-17 Thread Hanjun Guo
Signed-off-by: Joerg Roedel > --- > drivers/acpi/arm64/iort.c | 19 ++- > 1 file changed, 10 insertions(+), 9 deletions(-) Acked-by: Hanjun Guo Thanks Hanjun

Re: [PATCH 3/4] irqchip/mbigen: add support for a MBIGEN generating SPIs

2018-10-18 Thread Hanjun Guo
On 2018/10/18 19:56, Marc Zyngier wrote: > Hi Hanjun, > > On 18/10/18 12:20, Hanjun Guo wrote: >> Hi Marc, >> >>>>>> >>>>> Now, the biggest question of them all: how does it work with ACPI? Last >>>>> time I checke

Re: [PATCH 3/4] irqchip/mbigen: add support for a MBIGEN generating SPIs

2018-10-18 Thread Hanjun Guo
On 2018/10/18 19:56, Marc Zyngier wrote: > Hi Hanjun, > > On 18/10/18 12:20, Hanjun Guo wrote: >> Hi Marc, >> >>>>>> >>>>> Now, the biggest question of them all: how does it work with ACPI? Last >>>>> time I checke

  1   2   3   4   5   6   7   8   9   10   >