Re: [PATCH] drm/amd/display: dual cursors are seen if scaling is enabled

On 2021-03-29 3:54 a.m., Louis Li wrote: [Why] This issue is found when scaling is not equal to one from src to dest. When issue happens, there are offsets in both axis x and y between two cursors. Users cannot control APP under such a condition. What's the use case? I don't think we support

Re: [PATCH 2/3] drm/connector: Add helper to compare HDR metadata

it into an helper that can be shared across those drivers. Signed-off-by: Maxime Ripard Patches 1 & 2 are Reviewed-by: Harry Wentland Harry --- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 21 +- drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 17 +-- drivers/gpu

Re: [PATCH 06/19] drm/amd/display/dc/calcs/dce_calcs: Move some large variables from the stack to the heap

/../display/dc/calcs/dce_calcs.c:2016:1: warning: the frame size of 1216 bytes is larger than 1024 bytes [-Wframe-larger-than=] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: Colin Ian King Cc: amd-...@lists.freedesktop.org

Re: [PATCH 08/19] drm/amd/display/dc/dce80/dce80_resource: Make local functions static

’ [-Wmissing-prototypes] drivers/gpu/drm/amd/amdgpu/../display/dc/dce80/dce80_resource.c:913:16: warning: no previous prototype for ‘dce80_validate_global’ [-Wmissing-prototypes] Cc: Harry Wentland Cc: Leo Li Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Cc: Daniel Vetter Cc: A

Re: [PATCH] drm/amd/display: Set AMDGPU_DM_DEFAULT_MIN_BACKLIGHT to 0

On 2021-03-19 10:22 a.m., Alex Deucher wrote: On Fri, Mar 19, 2021 at 3:23 AM Evan Benn wrote: AMDGPU_DM_DEFAULT_MIN_BACKLIGHT was set to the value of 12 to ensure no display backlight will flicker at low user brightness settings. However this value is quite bright, so for devices that do

Re: [PATCH][next] drm/amd/display: fix the return of the uninitialized value in ret

elieve setting it to zero is a correct default. Addresses-Coverity: ("Uninitialized scalar variable") Fixes: bd0c064c161c ("drm/amd/display: Add return code instead of boolean for future use") Signed-off-by: Colin Ian King Reviewed-by: Harry Wentland Harry --- drivers/gpu

Re: [PATCH] drm/amd/display: fix unused variable warning

,-Wunused-variable] Add another such #ifdef. Fixes: 98ab5f3513f9 ("drm/amd/display: Fix deadlock during gpu reset v3") Signed-off-by: Arnd Bergmann Reviewed-by: Harry Wentland Harry --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 ++ 1 file changed, 2 insertions(+)

Re: [PATCH][next] drm/amd/display: Fix spelling mistake of function name

On 2021-01-20 4:26 a.m., Colin King wrote: From: Colin Ian King Reviewed-by: Harry Wentland Harry There are two spelling mistakes of the function name, fix this by using __func__ instead of a hard coded name string. Signed-off-by: Colin Ian King --- drivers/gpu/drm/amd/display/dc

Re: [PATCH] drm/amdgpu: Assign boolean values to a bool variable

: WARNING: Assignment of 0/1 to bool variable. Reported-by: Abaci Robot Signed-off-by: Jiapeng Zhong Reviewed-by: Harry Wentland Harry --- .../display/dc/dml/dcn30/display_rq_dlg_calc_30.c | 32 +++--- 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/drivers/gpu

Re: [PATCH] amd/display/amdgpu_dm: delete same check in if condition

On 2020-11-10 3:03 a.m., Bernard Zhao wrote: In function amdgpu_dm_connector_get_modes, drm_edid_is_valid will check weather (!edid), no need to check again in the if branch. Signed-off-by: Bernard Zhao Reviewed-by: Harry Wentland Harry --- drivers/gpu/drm/amd/display/amdgpu_dm

Re: [PATCH 4/5] drm/amdgpu: fix build_coefficients() argument

calling conventions after the type was changed, and the value should actually be 0 (TRANSFER_FUNCTION_SRGB) here instead of 1 (true). This looks correct to me. Harry, Leo? Confirmed with Kruno, this is correct. Reviewed-by: Harry Wentland Harry Alex Fixes: 55a01d4023ce ("drm/amd/di

Re: [PATCH] drm/amdgpu: remove unneeded break

On 2020-10-19 10:55 a.m., Christian König wrote: Am 19.10.20 um 16:43 schrieb t...@redhat.com: From: Tom Rix A break is not needed if it is preceded by a return or break Signed-off-by: Tom Rix Acked-by: Christian König Reviewed-by: Harry Wentland Harry ---   drivers/gpu/drm/amd

Re: [PATCH -next] drm/amd/display: Fix possible memleak in dp_trigger_hotplug()

On 2020-09-09 11:26 p.m., YueHaibing wrote: If parse_write_buffer_into_params() fails, we should free wr_buf before return. Fixes: 6f77b2ac6280 ("drm/amd/display: Add connector HPD trigger debugfs entry") Signed-off-by: YueHaibing Reviewed-by: Harry Wentland Harry --- drive

Re: [PATCH -next] drm/amd/display: Create trigger_hotplug entry

On 2020-09-09 11:13 p.m., YueHaibing wrote: Add trigger_hotplug debugfs entry. Fixes: 6f77b2ac6280 ("drm/amd/display: Add connector HPD trigger debugfs entry") Signed-off-by: YueHaibing Reviewed-by: Harry Wentland Harry --- drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_deb

Re: [PATCH] drm/radeon: remove assignment for return value

e; > -return ret; > > Signed-off-by: Wambui Karuga Thanks for your patch. Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/radeon/cik.c | 8 ++-- > 1 file changed, 2 insertions(+), 6 deletions(-) > > diff --git a/drivers/gpu/drm/radeon/cik.c b/driver

Re: [PATCH] drm/amd/display: Fix typo in some comments

On 2019-10-05 7:32 a.m., Christophe JAILLET wrote: > p and g are switched in 'amdpgu_dm' > > Signed-off-by: Christophe JAILLET Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 dele

Re: [PATCH -next] drm/amd/display: remove set but not used variable 'core_freesync'

:24: > warning: variable core_freesync set but not used [-Wunused-but-set-variable] > > It is not used since commit 98e6436d3af5 ("drm/amd/display: Refactor FreeSync > module") > > Reported-by: Hulk Robot > Signed-off-by: YueHaibing Reviewed-by: Harry Wentland Harry

Re: [PATCH] drm/amd/display: Fix 32-bit divide error in wait_for_alt_mode

> Fixes: b5b1f4554904 ("drm/amd/display: Enable type C hotplug") > Reported-by: Randy Dunlap > Signed-off-by: Nathan Chancellor Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/core/dc_link.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deleti

Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8

intended to be used without the change to drop the *10 in display code, which was done with this change: commit 23ec3d1479fd79658cd52c47618d8ddd2f32550b Author: Rex Zhu Date: Mon Jun 18 18:15:15 2018 +0800 drm/amd/pp: Convert clock unit to KHz as defined Convert clock unit 10KHz to KHz as the dat

Re: [PATCH 4.18 222/235] drm/amd/pp: Send khz clock values to DC for smu7/8

intended to be used without the change to drop the *10 in display code, which was done with this change: commit 23ec3d1479fd79658cd52c47618d8ddd2f32550b Author: Rex Zhu Date: Mon Jun 18 18:15:15 2018 +0800 drm/amd/pp: Convert clock unit to KHz as defined Convert clock unit 10KHz to KHz as the dat

Re: [PATCH] drm/amd/display: clean up assignment of amdgpu_crtc

order violation") > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Looks like i goofed. Thanks for fixing this. Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- > 1 file cha

Re: [PATCH] drm/amd/display: clean up assignment of amdgpu_crtc

> Signed-off-by: Colin Ian King Looks like i goofed. Thanks for fixing this. Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgp

Re: [REGRESSION] drm/amd/dc: Add dc display driver (v2)

it was found the following commit introduced the bug: > > > commit 4562236b3bc0a28aeb6ee93b2d8a849a4c4e1c7c > Author: Harry Wentland <harry.wentl...@amd.com> > Date:   Tue Sep 12 15:58:20 2017 -0400 > >     drm/amd/dc: Add dc display driver (v2) > > > The regression

Re: [REGRESSION] drm/amd/dc: Add dc display driver (v2)

it was found the following commit introduced the bug: > > > commit 4562236b3bc0a28aeb6ee93b2d8a849a4c4e1c7c > Author: Harry Wentland > Date:   Tue Sep 12 15:58:20 2017 -0400 > >     drm/amd/dc: Add dc display driver (v2) > > > The regression was introduced as of v4.15-

Re: [PATCH] drm/admgpu: fix mode_valid's return type

the driver too. > > Signed-off-by: Luc Van Oostenryck <luc.vanoostenr...@gmail.com> amd-gfx mailing list should be sufficient for changes like these. Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c| 8

Re: [PATCH] drm/admgpu: fix mode_valid's return type

the driver too. > > Signed-off-by: Luc Van Oostenryck amd-gfx mailing list should be sufficient for changes like these. Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_connectors.c| 8 > drivers/gpu/drm/amd/amdgpu/dce_virtual.c

Re: [PATCH] drm/amd/display: fix spelling mistake: "Usupported" -> "Unsupported"

On 2018-03-30 12:00 PM, Colin King wrote: > From: Colin Ian King <colin.k...@canonical.com> > > Trivial fix to spelling mistake in DRM_ERROR error message text > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Reviewed-by: Harry Wentland <

Re: [PATCH] drm/amd/display: fix spelling mistake: "Usupported" -> "Unsupported"

On 2018-03-30 12:00 PM, Colin King wrote: > From: Colin Ian King > > Trivial fix to spelling mistake in DRM_ERROR error message text > > Signed-off-by: Colin Ian King Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 4 ++--

Re: [PATCH] amdgpu/dc: Add missing cast in dce_clock_set_min_clocks_state()

On 2018-02-09 04:28 PM, Matthias Kaehlcke wrote: > dce_clock_set_min_clocks_state() assigns (intentionally) a value of type > 'enum dm_pp_clocks_state' to a variable of type 'enum dm_pp_power_level' > without an explicit cast. This causes clang to raise the following > warning: > >

Re: [PATCH] amdgpu/dc: Add missing cast in dce_clock_set_min_clocks_state()

On 2018-02-09 04:28 PM, Matthias Kaehlcke wrote: > dce_clock_set_min_clocks_state() assigns (intentionally) a value of type > 'enum dm_pp_clocks_state' to a variable of type 'enum dm_pp_power_level' > without an explicit cast. This causes clang to raise the following > warning: > >

Re: [PATCH v3 4/4] amdgpu/dc/calcs: Support clang option for stack alignment

On 2018-02-08 04:03 PM, Harry Wentland wrote: > On 2018-02-08 03:53 PM, Matthias Kaehlcke wrote: >> calcs uses the compiler option -mpreferred-stack-boundary=4 to configure >> a stack alignment of 16 bytes. Clang uses the option -mstack-alignment >> instead, which

Re: [PATCH v3 4/4] amdgpu/dc/calcs: Support clang option for stack alignment

On 2018-02-08 04:03 PM, Harry Wentland wrote: > On 2018-02-08 03:53 PM, Matthias Kaehlcke wrote: >> calcs uses the compiler option -mpreferred-stack-boundary=4 to configure >> a stack alignment of 16 bytes. Clang uses the option -mstack-alignment >> instead, which

Re: [PATCH v3 4/4] amdgpu/dc/calcs: Support clang option for stack alignment

of two like -mpreferred-stack-boundary. > > Probe for both compiler options and use the correct one, similar to > what is done in arch/x86/Makefile. > > Signed-off-by: Matthias Kaehlcke <m...@chromium.org> Series is Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry

Re: [PATCH v3 4/4] amdgpu/dc/calcs: Support clang option for stack alignment

of two like -mpreferred-stack-boundary. > > Probe for both compiler options and use the correct one, similar to > what is done in arch/x86/Makefile. > > Signed-off-by: Matthias Kaehlcke Series is Reviewed-by: Harry Wentland Harry > --- > Changes in v3: > - patch added

Re: [PATCH v2 1/2] amdgpu/dc/dml: Consolidate redundant CFLAGS

On 2018-02-07 08:51 PM, Matthias Kaehlcke wrote: > Use subdir-ccflags instead of specifying the same flags for every source > file. > > Signed-off-by: Matthias Kaehlcke > Reviewed-by: Guenter Roeck > --- > Changes in v2: > - added 'Reviewed-by: Guenter

Re: [PATCH v2 1/2] amdgpu/dc/dml: Consolidate redundant CFLAGS

On 2018-02-07 08:51 PM, Matthias Kaehlcke wrote: > Use subdir-ccflags instead of specifying the same flags for every source > file. > > Signed-off-by: Matthias Kaehlcke > Reviewed-by: Guenter Roeck > --- > Changes in v2: > - added 'Reviewed-by: Guenter Roeck ' tag > >

Re: [PATCH] amdgpu/dc: Fix enum mismatch in calls to program_color_matrix()

m_dce, tbl_entry, GRAPHICS_CSC_ADJUST_TYPE_SW); > > Signed-off-by: Matthias Kaehlcke <m...@chromium.org> Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 2 +- > drivers/gpu/drm/amd/display/dc

Re: [PATCH] amdgpu/dc: Fix enum mismatch in calls to program_color_matrix()

m_dce, tbl_entry, GRAPHICS_CSC_ADJUST_TYPE_SW); > > Signed-off-by: Matthias Kaehlcke Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/dce/dce_transform.c | 2 +- > drivers/gpu/drm/amd/display/dc/dce110/dce110_opp_csc_v.c | 2 +- > 2 files changed

Re: [PATCH] drm/amd/display: Remove extra pairs of parentheses in dce_calcs.c

ous parentheses > [-Werror,-Wparentheses-equality] > if ((data->graphics_micro_tile_mode == bw_def_rotated_micro_tiling)) { > > Signed-off-by: Matthias Kaehlcke <m...@chromium.org> Thanks. Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- >

Re: [PATCH] drm/amd/display: Remove extra pairs of parentheses in dce_calcs.c

ous parentheses > [-Werror,-Wparentheses-equality] > if ((data->graphics_micro_tile_mode == bw_def_rotated_micro_tiling)) { > > Signed-off-by: Matthias Kaehlcke Thanks. Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c |

Re: [PATCH] drm/amd/display: fix incompatible structure layouts

On 2018-02-02 11:02 AM, Arnd Bergmann wrote: > On Fri, Feb 2, 2018 at 4:39 PM, Harry Wentland <harry.wentl...@amd.com> wrote: >> On 2018-02-02 07:31 AM, Arnd Bergmann wrote: >>> Building the amd display driver with link-time optimizations revealed a bug >> >&g

Re: [PATCH] drm/amd/display: fix incompatible structure layouts

On 2018-02-02 11:02 AM, Arnd Bergmann wrote: > On Fri, Feb 2, 2018 at 4:39 PM, Harry Wentland wrote: >> On 2018-02-02 07:31 AM, Arnd Bergmann wrote: >>> Building the amd display driver with link-time optimizations revealed a bug >> >> Curious how I'd go about buildin

Re: [PATCH] drm/amd/display: fix incompatible structure layouts

e superset > of the members, to ensure the interfaces are all compatible. > > Fixes: ae79c310b1a6 ("drm/amd/display: Add DCE12 bios parser support") > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thanks for the fix. Reviewed-by: Harry Wentland <harry.wentl...@amd.c

Re: [PATCH] drm/amd/display: fix incompatible structure layouts

e superset > of the members, to ensure the interfaces are all compatible. > > Fixes: ae79c310b1a6 ("drm/amd/display: Add DCE12 bios parser support") > Signed-off-by: Arnd Bergmann Thanks for the fix. Reviewed-by: Harry Wentland Harry > --- > .../drm/amd/di

Re: Failing S3 resume since "Add missing irqflags tracing to native_load_gs_index()"

On 2018-01-06 09:55 AM, Harry Wentland wrote: > On 2018-01-05 06:07 PM, Andy Lutomirski wrote: >> >> >>> On Jan 5, 2018, at 1:51 PM, Harry Wentland <harry.wentl...@amd.com> wrote: >>> >>>> On 2018-01-05 04:28 PM, Andy Lutomirski wrote: >>&

Re: Failing S3 resume since "Add missing irqflags tracing to native_load_gs_index()"

On 2018-01-06 09:55 AM, Harry Wentland wrote: > On 2018-01-05 06:07 PM, Andy Lutomirski wrote: >> >> >>> On Jan 5, 2018, at 1:51 PM, Harry Wentland wrote: >>> >>>> On 2018-01-05 04:28 PM, Andy Lutomirski wrote: >>>> It's a known issue, and

Re: Failing S3 resume since "Add missing irqflags tracing to native_load_gs_index()"

On 2018-01-05 06:07 PM, Andy Lutomirski wrote: > > >> On Jan 5, 2018, at 1:51 PM, Harry Wentland <harry.wentl...@amd.com> wrote: >> >>> On 2018-01-05 04:28 PM, Andy Lutomirski wrote: >>> It's a known issue, and it should be fixed in newer -rc kernels. &g

Re: Failing S3 resume since "Add missing irqflags tracing to native_load_gs_index()"

On 2018-01-05 06:07 PM, Andy Lutomirski wrote: > > >> On Jan 5, 2018, at 1:51 PM, Harry Wentland wrote: >> >>> On 2018-01-05 04:28 PM, Andy Lutomirski wrote: >>> It's a known issue, and it should be fixed in newer -rc kernels. >>> >> >

Re: Failing S3 resume since "Add missing irqflags tracing to native_load_gs_index()"

On 2018-01-05 04:28 PM, Andy Lutomirski wrote: > It's a known issue, and it should be fixed in newer -rc kernels. > I'm still seeing this on v4.15-rc6. Will I need rc7 or the latest x86 merges in linus's master? Thanks, Harry

Re: Failing S3 resume since "Add missing irqflags tracing to native_load_gs_index()"

On 2018-01-05 04:28 PM, Andy Lutomirski wrote: > It's a known issue, and it should be fixed in newer -rc kernels. > I'm still seeing this on v4.15-rc6. Will I need rc7 or the latest x86 merges in linus's master? Thanks, Harry

Re: [PATCH] drm/amd/display: remove redundant null check of array 'data'

369 ("Array compared against 0") > > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 d

Re: [PATCH] drm/amd/display: remove redundant null check of array 'data'

0") > > Signed-off-by: Colin Ian King Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c > b

Re: [PATCH] drm: amd: dc: don't use FP math when Kcov is enabled

On 2017-12-05 07:05 AM, Arnd Bergmann wrote: > On Mon, Dec 4, 2017 at 9:34 PM, Harry Wentland <harry.wentl...@amd.com> wrote: >> On 2017-12-04 08:08 AM, Arnd Bergmann wrote: >>> Building the DCN 1.0 Raven display driver with CONFIG_KCOV_INSTRUMENT_ALL=y >>> and

Re: [PATCH] drm: amd: dc: don't use FP math when Kcov is enabled

On 2017-12-05 07:05 AM, Arnd Bergmann wrote: > On Mon, Dec 4, 2017 at 9:34 PM, Harry Wentland wrote: >> On 2017-12-04 08:08 AM, Arnd Bergmann wrote: >>> Building the DCN 1.0 Raven display driver with CONFIG_KCOV_INSTRUMENT_ALL=y >>> and CONFIG_KCOV_ENABLE_COMPARISONS=

Re: [PATCH] drm: amd: dc: don't use FP math when Kcov is enabled

On 2017-12-04 08:08 AM, Arnd Bergmann wrote: > Building the DCN 1.0 Raven display driver with CONFIG_KCOV_INSTRUMENT_ALL=y > and CONFIG_KCOV_ENABLE_COMPARISONS=y results in warnings about many functions > that do a comparison of floating-point variables: > >

Re: [PATCH] drm: amd: dc: don't use FP math when Kcov is enabled

On 2017-12-04 08:08 AM, Arnd Bergmann wrote: > Building the DCN 1.0 Raven display driver with CONFIG_KCOV_INSTRUMENT_ALL=y > and CONFIG_KCOV_ENABLE_COMPARISONS=y results in warnings about many functions > that do a comparison of floating-point variables: > >

Re: drm/amd/display: Restructuring and cleaning up DML

kin <dmytro.laktyush...@amd.com> > > AuthorDate: Wed Aug 23 16:43:17 2017 -0400 > Committer: Alex Deucher > <alexander.deuc...@amd.com> > CommitDate: Sat Oct 21 16:45:24 2017 -0400 > > > drm/amd/display: Restructuring and cleaning up DML > >

Re: drm/amd/display: Restructuring and cleaning up DML

rm/amd/display: Restructuring and cleaning up DML > > > > Signed-off-by: Dmytro Laktyushkin > > Reviewed-by: Tony Cheng > > Acked-by: Harry Wentland > > Signed-off-by: Alex Deucher > > --- > > > > diff --git a/drive

Re: [PATCH] drm/amd/display: Fix potential NULL pointer dereferences in amdgpu_dm_atomic_commit_tail

->base.state); > + if (!disconnected_acrtc) > + return; > > - if (!disconnected_acrtc || !acrtc_state->stream) > + acrtc_state = to_dm_crtc_state(disconnected_acrtc->base.state); > + if (!acrtc_state->stream) > return; This part is already in https://lists.freedesktop.org/archives/amd-gfx/2017-November/016389.html on its way to be merged. The rest of the patch is Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > > /* >

Re: [PATCH] drm/amd/display: Fix potential NULL pointer dereferences in amdgpu_dm_atomic_commit_tail

onnected_acrtc) > + return; > > - if (!disconnected_acrtc || !acrtc_state->stream) > + acrtc_state = to_dm_crtc_state(disconnected_acrtc->base.state); > + if (!acrtc_state->stream) > return; This part is already in https://lists.freedesktop.org/archives/amd-gfx/2017-November/016389.html on its way to be merged. The rest of the patch is Reviewed-by: Harry Wentland Harry > > /* >

Re: [PATCH] drm/amd/display: fix memory leaks on error exit return

driver (v2)") > Signed-off-by: Colin Ian King <colin.k...@canonical.com> Thanks. I got the same patch but was too slow to post. Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 12 +++- >

Re: [PATCH] drm/amd/display: fix memory leaks on error exit return

ed-off-by: Colin Ian King Thanks. I got the same patch but was too slow to post. Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/dce110/dce110_resource.c | 12 +++- > 1 file changed, 7 insertions(+), 5 deletions(-) > > diff --git a/drivers/gpu/drm/amd/

Re: [PATCH] drm/amd/display/dc/core/dc_resource: use swap macro in rect_swap_helper

; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 11 ++- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/dri

Re: [PATCH] drm/amd/display/dc/core/dc_resource: use swap macro in rect_swap_helper

; Signed-off-by: Gustavo A. R. Silva Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/core/dc_resource.c | 11 ++- > 1 file changed, 2 insertions(+), 9 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/core/dc_resource.c > b/drivers

Re: [PATCH] drm/amd/display/dc/dce110/dce110_mem_input_v: use swap macro in program_size_and_rotation

; Signed-off-by: Gustavo A. R. Silva <garsi...@embeddedor.com> Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > .../drm/amd/display/dc/dce110/dce110_mem_input_v.c | 28 > +++--- > 1 file changed, 8 insertions(+), 20 deletions(-) > &

Re: [PATCH] drm/amd/display/dc/dce110/dce110_mem_input_v: use swap macro in program_size_and_rotation

; Signed-off-by: Gustavo A. R. Silva Reviewed-by: Harry Wentland Harry > --- > .../drm/amd/display/dc/dce110/dce110_mem_input_v.c | 28 > +++--- > 1 file changed, 8 insertions(+), 20 deletions(-) > > diff --git a/drivers/gpu/drm/amd/display/dc/dce110/dce

Re: [PATCH 2/4] drm: amd: Fix line continuation formats

> - "%s: Link Training Error, could not \ > - get CR after %d tries. \ > - Possibly voltage swing issue", __func__, > + "%s: Link Training Error, could not get CR after %d > tries. Possi

Re: [PATCH 2/4] drm: amd: Fix line continuation formats

"%s: Link Training Error, could not \ > - get CR after %d tries. \ > - Possibly voltage swing issue", __func__, > + "%s: Link Training Error, could not get CR after %d

Re: AMD, please run Smatch on your driver

Thanks, Dan, for bringing this to our attention. We (the display guys here) weren't aware of smatch and will give it a spin and try to address some of the remaining items (after your, Dave's, and Ernst's patches). Harry On 2017-11-06 06:34 AM, Dan Carpenter wrote: > Linux-next was offline for

Re: AMD, please run Smatch on your driver

Thanks, Dan, for bringing this to our attention. We (the display guys here) weren't aware of smatch and will give it a spin and try to address some of the remaining items (after your, Dave's, and Ernst's patches). Harry On 2017-11-06 06:34 AM, Dan Carpenter wrote: > Linux-next was offline for

Re: [PATCH] drm/amdgpu/virt: don't dereference undefined 'module' struct

e> Looks like 'str' isn't even used here. Either way, this change by itself is correct and Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/

Re: [PATCH] drm/amdgpu/virt: don't dereference undefined 'module' struct

't even used here. Either way, this change by itself is correct and Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_virt.c > b/drivers/gpu/drm/amd/

Re: [PATCH v2] drm/amdgpu/display: provide ASSERT macros unconditionally

ed-off-by: Arnd Bergmann <a...@arndb.de> Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/amd/display/dc/os_types.h | 4 > 1 file changed, 4 deletions(-) > > v2: remove accidtental comment change. > > diff --git a/drive

Re: [PATCH v2] drm/amdgpu/display: provide ASSERT macros unconditionally

Signed-off-by: Arnd Bergmann Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/os_types.h | 4 > 1 file changed, 4 deletions(-) > > v2: remove accidtental comment change. > > diff --git a/drivers/gpu/drm/amd/display/dc/os_types.h > b

Re: [PATCH 3/3] drm/amdgpu/display: fix integer arithmetic problem

arking the constant as explicitly unsigned makes it work fine everywhere > without warnings. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Thanks for these fixes. Series is Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/amd/dis

Re: [PATCH 3/3] drm/amdgpu/display: fix integer arithmetic problem

arking the constant as explicitly unsigned makes it work fine everywhere > without warnings. > > Signed-off-by: Arnd Bergmann Thanks for these fixes. Series is Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/display/dc/calcs/dce_calcs.c | 2 +- > 1 file changed,

Re: [PATCH] drm/amd/powerplay/hwmgr: Remove null check before kfree

On 2017-08-29 09:12 AM, Himanshu Jha wrote: > kfree on NULL pointer is a no-op and therefore checking is redundant. > > Signed-off-by: Himanshu Jha <himanshujha199...@gmail.com> Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry > --- > drivers/gpu/drm/amd

Re: [PATCH] drm/amd/powerplay/hwmgr: Remove null check before kfree

On 2017-08-29 09:12 AM, Himanshu Jha wrote: > kfree on NULL pointer is a no-op and therefore checking is redundant. > > Signed-off-by: Himanshu Jha Reviewed-by: Harry Wentland Harry > --- > drivers/gpu/drm/amd/powerplay/hwmgr/cz_hwmgr.c | 6 +- > .../gpu/drm/a

Re: [PATCH 01/14] amdgpu: powerplay: Remove unused function

On 2017-07-26 09:47 AM, Ricardo Ribalda Delgado wrote: > Hi Harry > > On Mon, Jul 24, 2017 at 5:45 PM, Harry Wentland <harry.wentl...@amd.com> > wrote: >> On 2017-07-24 10:06 AM, Ricardo Ribalda Delgado wrote: >>> Hi Harry >>> On Mon, Jul 24, 20

Re: [PATCH 01/14] amdgpu: powerplay: Remove unused function

On 2017-07-26 09:47 AM, Ricardo Ribalda Delgado wrote: > Hi Harry > > On Mon, Jul 24, 2017 at 5:45 PM, Harry Wentland > wrote: >> On 2017-07-24 10:06 AM, Ricardo Ribalda Delgado wrote: >>> Hi Harry >>> On Mon, Jul 24, 2017 at 4:01 PM, Harry Wentland &

Re: [PATCH 1/2] drm/edid: Add helper to detect whether EDID changed

by another one during suspend), > no hotplug event will be triggered so the change will not be caught at > resume time. Detecting that the EDID changed allows detecting it. > This makes sense and could be used by other drivers. Acked-by: Harry Wentland <harry.wentl...@amd.com>

Re: [PATCH 1/2] drm/edid: Add helper to detect whether EDID changed

by another one during suspend), > no hotplug event will be triggered so the change will not be caught at > resume time. Detecting that the EDID changed allows detecting it. > This makes sense and could be used by other drivers. Acked-by: Harry Wentland Harry > Signe

Re: [PATCH 01/14] amdgpu: powerplay: Remove unused function

On 2017-07-24 10:06 AM, Ricardo Ribalda Delgado wrote: > Hi Harry > On Mon, Jul 24, 2017 at 4:01 PM, Harry Wentland <harry.wentl...@amd.com> > wrote: > >> >> This is used and needed by the DC display driver. See >> display/amdgpu_dm/amdgpu_dm_services.c

Re: [PATCH 01/14] amdgpu: powerplay: Remove unused function

On 2017-07-24 10:06 AM, Ricardo Ribalda Delgado wrote: > Hi Harry > On Mon, Jul 24, 2017 at 4:01 PM, Harry Wentland > wrote: > >> >> This is used and needed by the DC display driver. See >> display/amdgpu_dm/amdgpu_dm_services.c:193 in Alex's amd-

Re: [PATCH 01/14] amdgpu: powerplay: Remove unused function

On 2017-07-24 09:35 AM, Ricardo Ribalda Delgado wrote: > amd_powerplay_display_configuration_change is never called. > > Signed-off-by: Ricardo Ribalda Delgado > --- > drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 21 - >

Re: [PATCH 01/14] amdgpu: powerplay: Remove unused function

On 2017-07-24 09:35 AM, Ricardo Ribalda Delgado wrote: > amd_powerplay_display_configuration_change is never called. > > Signed-off-by: Ricardo Ribalda Delgado > --- > drivers/gpu/drm/amd/powerplay/amd_powerplay.c | 21 - >

Re: [PATCH v2] drm/core: Fail atomic IOCTL with no CRTC state but with signaling.

gt; > Fix: Protect against this issue by failing atomic_commit early in > drm_mode_atomic_commit where such probelm can be identified. > > v2: > Fix typos and extra newlines. > > Change-Id: I3ee28ffae35fd1e8bfe553146c44da53da02e6f8 > Signed-off-by: Andrey Grodzovsky <a

Re: [PATCH v2] drm/core: Fail atomic IOCTL with no CRTC state but with signaling.

gt; > Fix: Protect against this issue by failing atomic_commit early in > drm_mode_atomic_commit where such probelm can be identified. > > v2: > Fix typos and extra newlines. > > Change-Id: I3ee28ffae35fd1e8bfe553146c44da53da02e6f8 > Signed-off-by: Andrey Grodzovsky Re

Re: [PATCH] drm/core: Fail atomic IOCTL with no CRTC state but with signaling.

On 2017-06-09 05:30 PM, Andrey Grodzovsky wrote: > Problem: > While running IGT kms_atomic_transition test suite i encountered > a hang in drmHandleEvent immidietly follwoing an atomic_commit. s/immidietly/immediately/g s/follwoing/following/g > After dumping the atomic state I relized that in

Re: [PATCH] drm/core: Fail atomic IOCTL with no CRTC state but with signaling.

On 2017-06-09 05:30 PM, Andrey Grodzovsky wrote: > Problem: > While running IGT kms_atomic_transition test suite i encountered > a hang in drmHandleEvent immidietly follwoing an atomic_commit. s/immidietly/immediately/g s/follwoing/following/g > After dumping the atomic state I relized that in

Re: [PATCH] drm: fourcc byteorder: brings header file comments in line with reality.

Thanks, Christian for adding me. On 2017-04-21 09:27 AM, Christian König wrote: Adding Harry to this mail thread as well, cause is one of the people really affected by this. Christian. Am 21.04.2017 um 15:21 schrieb Christian König: Am 21.04.2017 um 15:12 schrieb Gerd Hoffmann: Hi,

Re: [PATCH] drm: fourcc byteorder: brings header file comments in line with reality.

Thanks, Christian for adding me. On 2017-04-21 09:27 AM, Christian König wrote: Adding Harry to this mail thread as well, cause is one of the people really affected by this. Christian. Am 21.04.2017 um 15:21 schrieb Christian König: Am 21.04.2017 um 15:12 schrieb Gerd Hoffmann: Hi,

Re: [PATCH] drm/amd/dc: fix semicolon.cocci warnings

Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry On 2017-02-14 01:14 AM, Julia Lawall wrote: Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Harry Wentland <harry.wentl...@amd.com> Signed-off-by: Julia Lawall <julia.law...@lip6

Re: [PATCH] drm/amd/dc: fix semicolon.cocci warnings

Reviewed-by: Harry Wentland Harry On 2017-02-14 01:14 AM, Julia Lawall wrote: Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Harry Wentland Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- tree: git://people.freedesktop.org/~agd5f

Re: [PATCH] drm/amd/dc: fix semicolon.cocci warnings

Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry On 2017-02-14 01:13 AM, Julia Lawall wrote: Remove unneeded semicolons. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Harry Wentland <harry.wentl...@amd.com> Signed-off-by: Julia Lawall <julia.law...@lip6

Re: [PATCH] drm/amd/dc: fix semicolon.cocci warnings

Reviewed-by: Harry Wentland Harry On 2017-02-14 01:13 AM, Julia Lawall wrote: Remove unneeded semicolons. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Harry Wentland Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- tree: git://people.freedesktop.org/~agd5f

Re: [PATCH] drm/amd/dc: hw_sequencer: fix semicolon.cocci warnings

Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry On 2017-02-14 01:19 AM, Julia Lawall wrote: Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Harry Wentland <harry.wentl...@amd.com> Signed-off-by: Julia Lawall <julia.law...@lip6

Re: [PATCH] drm/amd/dc: hw_sequencer: fix semicolon.cocci warnings

Reviewed-by: Harry Wentland Harry On 2017-02-14 01:19 AM, Julia Lawall wrote: Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Harry Wentland Signed-off-by: Julia Lawall Signed-off-by: Fengguang Wu --- tree: git://people.freedesktop.org/~agd5f

Re: [PATCH v2] drm/amd/dc: resource: fix semicolon.cocci warnings (fwd)

Thanks for these fixes. I'll merge them. Reviewed-by: Harry Wentland <harry.wentl...@amd.com> Harry On 2017-02-14 04:47 AM, Christian König wrote: Am 14.02.2017 um 07:21 schrieb Julia Lawall: Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC:

Re: [PATCH v2] drm/amd/dc: resource: fix semicolon.cocci warnings (fwd)

Thanks for these fixes. I'll merge them. Reviewed-by: Harry Wentland Harry On 2017-02-14 04:47 AM, Christian König wrote: Am 14.02.2017 um 07:21 schrieb Julia Lawall: Remove unneeded semicolon. Generated by: scripts/coccinelle/misc/semicolon.cocci CC: Harry Wentland Signed-off-by: Julia

  1   2   >