://patchwork.kernel.org/project/linux-pci/patch/20210104230300.1277180-4-kbu...@kernel.org/
Keith's series *does* fix the problem for me:
Acked-by: Hedi Berriche
Tested-by: Hedi Berriche
Cheers,
Hedi.
--
Sathyanarayanan Kuppuswamy
Linux Kernel Developer
--
Be careful of reading health
On Mon, Nov 02, 2020 at 15:10 Hedi Berriche wrote:
Commit 6d2c89441571 ("PCI/ERR: Update error status after reset_link()")
broke pcie_do_recovery(): updating status after reset_link() has the ill
side effect of causing recovery to fail if the error status is
PCI_ERS_RESULT_C
on.
Cc: Russ Anderson
Cc: Kuppuswamy Sathyanarayanan
Cc: Bjorn Helgaas
Cc: Ashok Raj
Cc: Joerg Roedel
Cc: Sinan Kaya
Cc: sta...@kernel.org # v5.7+
---
Hedi Berriche (1):
PCI/ERR: don't clobber status after reset_link()
drivers/pci/pcie/err.c | 7 +--
1 file changed, 5 insertions(+)
LT_DISCONNECT
or PCI_ERS_RESULT_NO_AER_DRIVER.
Fixes: 6d2c89441571 ("PCI/ERR: Update error status after reset_link()")
Signed-off-by: Hedi Berriche
Reviewed-by: Sinan Kaya
Cc: Russ Anderson
Cc: Kuppuswamy Sathyanarayanan
Cc: Bjorn Helgaas
Cc: Ashok Raj
Cc: Joerg Roedel
Cc: s
On Sun, Oct 11, 2020 at 18:56 Sinan Kaya wrote:
On 10/10/2020 6:16 PM, Hedi Berriche wrote:
Commit 6d2c89441571 ("PCI/ERR: Update error status after reset_link()")
broke pcie_do_recovery(): updating status after reset_link() has the ill
side effect of causing recovery to fail if
aj
Cc: Joerg Roedel
Cc: sta...@kernel.org # v5.7+
---
Hedi Berriche (1):
PCI/ERR: don't clobber status after reset_link()
drivers/pci/pcie/err.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
--
2.28.0
LT_DISCONNECT
or PCI_ERS_RESULT_NO_AER_DRIVER.
Fixes: 6d2c89441571 ("PCI/ERR: Update error status after reset_link()")
Signed-off-by: Hedi Berriche
Cc: Russ Anderson
Cc: Kuppuswamy Sathyanarayanan
Cc: Bjorn Helgaas
Cc: Ashok Raj
Cc: Joerg Roedel
Cc: sta...@kernel.org # v5.7+
---
dri
nger calls ->slot_reset() in the case of a successful
reset which breaks error recovery by breaking driver (re)initialisation.
Cc: Russ Anderson
Cc: Kuppuswamy Sathyanarayanan
Cc: Bjorn Helgaas
Cc: Ashok Raj
Cc: Joerg Roedel
Cc: sta...@kernel.org # v5.7+
---
Hedi Berriche (1):
PCI/ERR: don't c
LT_DISCONNECT
or PCI_ERS_RESULT_NO_AER_DRIVER.
Fixes: 6d2c89441571 ("PCI/ERR: Update error status after reset_link()")
Signed-off-by: Hedi Berriche
Cc: Russ Anderson
Cc: Kuppuswamy Sathyanarayanan
Cc: Bjorn Helgaas
Cc: Ashok Raj
Cc: Joerg Roedel
Cc: sta...@kernel.org # v5.7+
---
dri
ot
calling ->slot_reset() (because we skip report_slot_reset()) thus
breaking driver (re)initialisation.
Don't clobber status after reset_link(), use a boolean instead to track
the outcome of reset_link().
Fixes: 6d2c89441571 ("PCI/ERR: Update error status after reset_link()")
Signed-off-by:
g Roedel
Cc: sta...@kernel.org # v5.7+
---
Hedi Berriche (1):
PCI/ERR: don't clobber status after reset_link()
drivers/pci/pcie/err.c | 11 +--
1 file changed, 9 insertions(+), 2 deletions(-)
--
2.28.0
On Fri, Oct 09, 2020 at 05:09 Hedi Berriche wrote:
On Fri, Oct 09, 2020 at 04:46 Raj, Ashok wrote:
Hi Ashok,
Thanks for looking into this.
On Fri, Oct 09, 2020 at 03:52:51AM +0100, Hedi Berriche wrote:
Commit 6d2c89441571 ("PCI/ERR: Update error status after reset_link()"
On Fri, Oct 09, 2020 at 04:46 Raj, Ashok wrote:
Hi Ashok,
Thanks for looking into this.
On Fri, Oct 09, 2020 at 03:52:51AM +0100, Hedi Berriche wrote:
Commit 6d2c89441571 ("PCI/ERR: Update error status after reset_link()")
changed pcie_do_recovery() so that status is updated with
ror status is
PCI_ERS_RESULT_{DISCONNECT,NO_AER_DRIVER}.
Fixes: 6d2c89441571 ("PCI/ERR: Update error status after reset_link()")
Signed-off-by: Hedi Berriche
Cc: Russ Anderson
Cc: Kuppuswamy Sathyanarayanan
Cc: Bjorn Helgaas
Cc: Ashok Raj
Cc: Keith Busch
Cc: Joerg Roedel
Cc: sta.
that, on such a system, we end up using 1020 owner IDs,
hence I'm suggesting that we bump ACPI_OWNER_ID_MAX up to 2047.
Signed-off-by: Hedi Berriche
Cc: Russ Anderson
Cc: Mike Travis
Cc: Frank Ramsay
Cc: Robert Moore
Cc: Erik Schmauss
Cc: Rafael J. Wysocki
---
drivers/acpi/acpica
Commit-ID: 8945d96f7b3ead56e053ac79b8f7b0de98a30bfe
Gitweb: https://git.kernel.org/tip/8945d96f7b3ead56e053ac79b8f7b0de98a30bfe
Author: Hedi Berriche
AuthorDate: Wed, 13 Feb 2019 19:34:12 +
Committer: Borislav Petkov
CommitDate: Fri, 15 Feb 2019 15:15:18 +0100
x86/platform/UV: Use
Commit-ID: 30ad3e031d2feae075cd5fd2c443baa2d86c0195
Gitweb: https://git.kernel.org/tip/30ad3e031d2feae075cd5fd2c443baa2d86c0195
Author: Hedi Berriche
AuthorDate: Wed, 13 Feb 2019 19:34:10 +
Committer: Borislav Petkov
CommitDate: Fri, 15 Feb 2019 15:05:15 +0100
x86/platform/UV
Commit-ID: f816525d615fff0336d0c881e5d960bbec5ea016
Gitweb: https://git.kernel.org/tip/f816525d615fff0336d0c881e5d960bbec5ea016
Author: Hedi Berriche
AuthorDate: Wed, 13 Feb 2019 19:34:11 +
Committer: Borislav Petkov
CommitDate: Fri, 15 Feb 2019 15:13:48 +0100
x86/platform/UV
Commit-ID: f331e766c4be33f4338574f3c9f7f77e98ab4571
Gitweb: https://git.kernel.org/tip/f331e766c4be33f4338574f3c9f7f77e98ab4571
Author: Hedi Berriche
AuthorDate: Wed, 13 Feb 2019 19:34:13 +
Committer: Borislav Petkov
CommitDate: Fri, 15 Feb 2019 15:19:56 +0100
x86/platform/UV: Use
Calls into UV firmware must be protected against concurrency, expose the
efi_runtime_lock to the UV platform, and use it to serialise UV BIOS calls.
Cc: Russ Anderson
Cc: Mike Travis
Cc: Dimitri Sivanich
Cc: Steve Wahl
Cc: sta...@vger.kernel.org # v4.9+
Signed-off-by: Hedi Berriche
---
arch
uv_bios_call_reentrant() has no callers nor is it exported, kill it.
Cleanup, no functional changes.
Cc: Russ Anderson
Cc: Mike Travis
Cc: Dimitri Sivanich
Cc: Steve Wahl
Cc: sta...@vger.kernel.org # v4.9+
Signed-off-by: Hedi Berriche
---
arch/x86/include/asm/uv/bios.h | 1 -
arch/x86
-by: Hedi Berriche
---
arch/x86/include/asm/uv/bios.h | 4
arch/x86/platform/uv/bios_uv.c | 2 --
2 files changed, 6 deletions(-)
diff --git a/arch/x86/include/asm/uv/bios.h b/arch/x86/include/asm/uv/bios.h
index e652a7cc6186..00d862cfbcbe 100644
--- a/arch/x86/include/asm/uv/bios.h
+++ b
semaphore to
protect against concurrency.
Cc: Russ Anderson
Cc: Mike Travis
Cc: Dimitri Sivanich
Cc: Steve Wahl
Cc: sta...@vger.kernel.org # v4.9+
Hedi Berriche (4):
x86/platform/UV: remove unnecessary #ifdef CONFIG_EFI
x86/platform/UV: kill uv_bios_call_reentrant() as it has no callers
x86
Use ad hoc efi_enabled() instead of fiddling with test_bit().
Cleanup, no functional changes.
Cc: Russ Anderson
Cc: Mike Travis
Cc: Dimitri Sivanich
Cc: Steve Wahl
Cc: sta...@vger.kernel.org # v4.9+
Signed-off-by: Hedi Berriche
---
arch/x86/platform/uv/bios_uv.c | 2 +-
1 file changed, 1
On Tue, Feb 12, 2019 at 17:25 Hedi Berriche wrote:
On Thu, Feb 07, 2019 at 17:38 Hedi Berriche wrote:
On Thu, Feb 07, 2019 at 16:05 Ard Biesheuvel wrote:
On Thu, 7 Feb 2019 at 05:23, Hedi Berriche wrote:
Make efi_runtime_lock semaphore global so that it can be used by EFI
runtime callers
On Thu, Feb 07, 2019 at 17:38 Hedi Berriche wrote:
On Thu, Feb 07, 2019 at 16:05 Ard Biesheuvel wrote:
On Thu, 7 Feb 2019 at 05:23, Hedi Berriche wrote:
Make efi_runtime_lock semaphore global so that it can be used by EFI
runtime callers that may be defined outside efi/runtime-wrappers.c
On Thu, Feb 07, 2019 at 16:05 Ard Biesheuvel wrote:
On Thu, 7 Feb 2019 at 05:23, Hedi Berriche wrote:
Make efi_runtime_lock semaphore global so that it can be used by EFI
runtime callers that may be defined outside efi/runtime-wrappers.c.
Also now that efi_runtime_lock semaphore is no longer
Use ad hoc efi_enabled() instead of fiddling with test_bit().
Cleanup, no functional changes.
Cc: Russ Anderson
Cc: Mike Travis
Cc: Dimitri Sivanich
Cc: Steve Wahl
Cc: sta...@vger.kernel.org
Signed-off-by: Hedi Berriche
---
arch/x86/platform/uv/bios_uv.c | 2 +-
1 file changed, 1 insertion
uv_bios_call_reentrant() has no callers nor is it exported, kill it.
Cc: Russ Anderson
Cc: Mike Travis
Cc: Dimitri Sivanich
Cc: Steve Wahl
Cc: sta...@vger.kernel.org
Signed-off-by: Hedi Berriche
---
arch/x86/include/asm/uv/bios.h | 1 -
arch/x86/platform/uv/bios_uv.c | 12
2
test_bit() in favour of the ad hoc
efi_enabled().
Patch #4 makes uv_bios_call() variants use efi_runtime_sem to protect against
concurrency.
Cc: Russ Anderson
Cc: Mike Travis
Cc: Dimitri Sivanich
Cc: Steve Wahl
Cc: sta...@vger.kernel.org
Hedi Berriche (4):
efi/x86: turn EFI runtime semaphore
Calls into UV firmware must be protected against concurrency, use the
now visible efi_runtime_sem lock to serialise them.
Cc: Russ Anderson
Cc: Mike Travis
Cc: Dimitri Sivanich
Cc: Steve Wahl
Cc: sta...@vger.kernel.org
Signed-off-by: Hedi Berriche
---
arch/x86/include/asm/uv/bios.h | 3
...@vger.kernel.org
Signed-off-by: Hedi Berriche
---
drivers/firmware/efi/runtime-wrappers.c | 60 -
include/linux/efi.h | 3 ++
2 files changed, 33 insertions(+), 30 deletions(-)
diff --git a/drivers/firmware/efi/runtime-wrappers.c
b/drivers/firmware/efi/runtime
On Tue, Jan 15, 2019 at 18:55 Thomas Gleixner wrote:
On Wed, 9 Jan 2019, Hedi Berriche wrote:
Make efi_runtime_lock semaphore global so that it can be used by EFI
runtime callers that may be defined outside efi/runtime-wrappers.c.
The changelog should mention why the lock is renamed.
OK
concurrent tasks both invoking uv_bios_call()
or
- 2 concurrent tasks
- one invoking uv_bios_call()
- one, for example, accessing an EFI vars via efivars
Nitpicks below:
On 01/09/2019 04:15 PM, Hedi Berriche wrote:
Calls into UV firmware must be protected
Calls into UV firmware must be protected against concurrency, use the
now visible efi_runtime_sem lock to serialise them.
Signed-off-by: Hedi Berriche
Reviewed-by: Russ Anderson
Reviewed-by: Mike Travis
Reviewed-by: Dimitri Sivanich
Reviewed-by: Steve Wahl
---
arch/x86/include/asm/uv/bios.h
Make efi_runtime_lock semaphore global so that it can be used by EFI
runtime callers that may be defined outside efi/runtime-wrappers.c.
The immediate motivation is to piggy-back it to serialise UV platform BIOS
calls.
No functional changes.
Signed-off-by: Hedi Berriche
Reviewed-by: Russ
defined outside drivers/firmware/efi/runtime-wrappers.c in
preparation for using it to serialise calls into UV BIOS.
Patch #2 removes uv_bios_call_reentrant() because it's dead code.
Patch #3 makes uv_bios_call() variants use efi_runtime_sem to protect
against concurrency.
Hedi Berriche (3):
efi
uv_bios_call_reentrant() has no callers nor is it exported, kill it.
Signed-off-by: Hedi Berriche
Reviewed-by: Russ Anderson
Reviewed-by: Mike Travis
Reviewed-by: Dimitri Sivanich
Reviewed-by: Steve Wahl
---
arch/x86/include/asm/uv/bios.h | 1 -
arch/x86/platform/uv/bios_uv.c | 12
by filtering it out of the
kdump kernel cmdline. In the case of sysctl.conf, it would depend on
whether there are distros out there that include it in the kdump
initrd.
--
Hedi Berriche
Linux Kernel Engineer
http://www.sgi.com
--
To unsubscribe from this list: send the line "unsubs
by filtering it out of the
kdump kernel cmdline. In the case of sysctl.conf, it would depend on
whether there are distros out there that include it in the kdump
initrd.
--
Hedi Berriche
Linux Kernel Engineer
http://www.sgi.com
--
To unsubscribe from this list: send the line unsubscribe
On Mon, Dec 09, 2013 at 18:10 Hedi Berriche wrote:
| Folks,
|
| The following panic occurs *early* at boot time on high *enough* CPU count
| machines:
|
| divide error: [#1] SMP
| Modules linked in:
| CPU: 22 PID: 1146 Comm: kworker/22:0 Not tainted 3.13.0-rc2-00122-gdea4f48 #8
| Hardware
On Mon, Dec 09, 2013 at 18:10 Hedi Berriche wrote:
| Folks,
|
| The following panic occurs *early* at boot time on high *enough* CPU count
| machines:
|
| divide error: [#1] SMP
| Modules linked in:
| CPU: 22 PID: 1146 Comm: kworker/22:0 Not tainted 3.13.0-rc2-00122-gdea4f48 #8
| Hardware
Folks,
The following panic occurs *early* at boot time on high *enough* CPU count
machines:
divide error: [#1] SMP
Modules linked in:
CPU: 22 PID: 1146 Comm: kworker/22:0 Not tainted 3.13.0-rc2-00122-gdea4f48 #8
Hardware name: Intel Corp. Stoutland Platform, BIOS 2.20 UEFI2.10 PI1.0 X64
Folks,
The following panic occurs *early* at boot time on high *enough* CPU count
machines:
divide error: [#1] SMP
Modules linked in:
CPU: 22 PID: 1146 Comm: kworker/22:0 Not tainted 3.13.0-rc2-00122-gdea4f48 #8
Hardware name: Intel Corp. Stoutland Platform, BIOS 2.20 UEFI2.10 PI1.0 X64
Chaps,
The following failure was encountered on hardware that does *not*
implement a _CBA method which is AFAICT (and confirmed to me by BIOS
chaps) optional.
[1.230647] PCI: MMCONFIG for domain [bus 00-0c] at [mem
0x8000-0x80cf] (base 0x8000)
[1.241046] PCI: MMCONFIG
Chaps,
The following failure was encountered on hardware that does *not*
implement a _CBA method which is AFAICT (and confirmed to me by BIOS
chaps) optional.
[1.230647] PCI: MMCONFIG for domain [bus 00-0c] at [mem
0x8000-0x80cf] (base 0x8000)
[1.241046] PCI: MMCONFIG
On Sun, Sep 15, 2013 at 10:36 Geert Uytterhoeven wrote:
| Signed-off-by: Geert Uytterhoeven
| ---
| kernel/kexec.c |2 +-
| 1 file changed, 1 insertion(+), 1 deletion(-)
|
| diff --git a/kernel/kexec.c b/kernel/kexec.c
| index 2a74f30..490afc0 100644
| --- a/kernel/kexec.c
| +++
On Sun, Sep 15, 2013 at 10:36 Geert Uytterhoeven wrote:
| Signed-off-by: Geert Uytterhoeven ge...@linux-m68k.org
| ---
| kernel/kexec.c |2 +-
| 1 file changed, 1 insertion(+), 1 deletion(-)
|
| diff --git a/kernel/kexec.c b/kernel/kexec.c
| index 2a74f30..490afc0 100644
| ---
On Thu, Sep 12, 2013 at 19:59 Mike Travis wrote:
| On 9/12/2013 10:27 AM, Paul E. McKenney wrote:
|
| > But what is it that you are looking for? If you want to silence it
| > completely, the rcu_cpu_stall_suppress boot/sysfs parameter is what
| > you want to use.
|
| We have by default
On Thu, Sep 12, 2013 at 19:59 Mike Travis wrote:
| On 9/12/2013 10:27 AM, Paul E. McKenney wrote:
|
| But what is it that you are looking for? If you want to silence it
| completely, the rcu_cpu_stall_suppress boot/sysfs parameter is what
| you want to use.
|
| We have by default
50 matches
Mail list logo
