On Tue, Apr 09, 2024 at 01:04:12PM +0200, Pavel Machek wrote:
> Hi!
>
> > > This is driver for ANX7688 USB-C HDMI, with flashing and debugging
> > > features removed. ANX7688 is rather criticial piece on PinePhone,
> > > there's no display and no battery charging without it.
> > >
> > > There's
Hi,
On Mon, Apr 08, 2024 at 12:54:25PM +0200, Pavel Machek wrote:
> From: Ondrej Jirman
>
> This is driver for ANX7688 USB-C HDMI, with flashing and debugging
> features removed. ANX7688 is rather criticial piece on PinePhone,
> there's no display and no battery charging without it.
>
>
On Fri, Mar 15, 2024 at 05:04:22PM +0100, Luca Weiss wrote:
> Switch to using the new DRM_AUX_BRIDGE helper to create the transparent
> DRM bridge device instead of handcoding corresponding functionality.
>
> Signed-off-by: Luca Weiss
Reviewed-by: Heikki Krogerus
> ---
Hi Pavel,
I'm sorry to keep you waiting.
On Fri, Feb 23, 2024 at 10:28:49PM +0100, Pavel Machek wrote:
> From: Ondrej Jirman
>
> This is driver for ANX7688 USB-C HDMI, with flashing and debugging
> features removed. ANX7688 is rather criticial piece on PinePhone,
> there's no display and no
On Wed, Dec 20, 2023 at 11:02:57AM +0100, Luca Weiss wrote:
> The QCM6490 Linux Android firmware needs this workaround as well. Add it
> to the list.
>
> Signed-off-by: Luca Weiss
Acked-by: Heikki Krogerus
> ---
> drivers/usb/typec/ucsi/ucsi_glink.c | 1 +
> 1 file
y: Neil Armstrong
> Signed-off-by: Luca Weiss
Reviewed-by: Heikki Krogerus
> ---
> drivers/usb/typec/mux/fsa4480.c | 71
> +
> 1 file changed, 71 insertions(+)
>
> diff --git a/drivers/usb/typec/mux/fsa4480.c b/drivers/usb/typec/mux/fsa
Hi Luca,
> > Shouldn't you loop through the endpoints? In any case:
> >
> > ep = fwnode_graph_get_next_endpoint(dev_fwnode(>client->dev,
> > NULL));
>
> The docs only mention one endpoint so I'm assuming just next_endpoint is
> fine?
I'm mostly concerned about what we may have in the
Hi Luca,
On Fri, Oct 13, 2023 at 01:38:06PM +0200, Luca Weiss wrote:
> On some hardware designs the AUX+/- lanes are connected reversed to
> SBU1/2 compared to the expected design by FSA4480.
>
> Made more complicated, the otherwise compatible Orient-Chip OCP96011
> expects the lanes to be
Hi,
On Fri, Oct 13, 2023 at 04:24:48PM +0200, Luca Weiss wrote:
> Add a driver for the NXP PTN36502 Type-C USB 3.1 Gen 1 and DisplayPort
> v1.2 combo redriver.
>
> Signed-off-by: Luca Weiss
Looks OK to me, but couple of nitpicks below. With those fixed:
Reviewed-by: Hei
On Wed, Apr 14, 2021 at 11:17:55AM +0200, Greg Kroah-Hartman wrote:
> On Wed, Apr 14, 2021 at 12:13:35PM +0300, Heikki Krogerus wrote:
> > +Greg
> >
> > Sorry about that. Should I resend this?
>
> No worries, I can pick it up, thanks
>
> `b4` really is nice t
+Greg
Sorry about that. Should I resend this?
On Wed, Apr 14, 2021 at 10:54:38AM +0300, Heikki Krogerus wrote:
> If the node is added to an already exiting device, the node
> needs to be also linked to the device separately.
>
> This will make sure the reference count is kept in ba
ional. Let's
> re-arrange the code to silence the warning and make the intent more
> clear.
>
> Signed-off-by: Dan Carpenter
Reviewed-by: Heikki Krogerus
> ---
> drivers/usb/typec/port-mapper.c | 6 --
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
> d
non-pd link.
>
> Signed-off-by: Badhri Jagan Sridharan
Reviewed-by: Heikki Krogerus
> ---
> Changes since V2:
> * Refactored code based on Heikki's suggestion
> ---
> drivers/usb/typec/tcpm/tcpm.c | 17 ++---
> 1 file changed, 14 insertions(+), 3 deletions(-
D_RESET_SEND @
> 500 ms [rev2 POWER_NEGOTIATION]
> [ 169.260222] PD RX, header: 0x566 [1]
> [ 169.260227] Setting voltage/current limit 9000 mV 2000 mA
> [ 169.261315] set_auto_vbus_discharge_threshold mode:3 pps_active:n
> vbus:9000 ret:0
> [ 169.261321] state change SN
node: Introduce device_add_software_node()")
Signed-off-by: Heikki Krogerus
---
drivers/base/swnode.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/base/swnode.c b/drivers/base/swnode.c
index 740333629b420..3cc11b813f28c 100644
--- a/drivers/base/swnode.c
+++
On Tue, Apr 13, 2021 at 10:47:49AM -0500, Pierre-Louis Bossart wrote:
>
>
> On 4/13/21 9:05 AM, Heikki Krogerus wrote:
> > On Tue, Apr 13, 2021 at 03:20:45PM +0300, Heikki Krogerus wrote:
> > > On Mon, Apr 12, 2021 at 03:36:20PM -0500, Pierre-Louis Bossart wrote:
On Tue, Apr 13, 2021 at 03:20:45PM +0300, Heikki Krogerus wrote:
> On Mon, Apr 12, 2021 at 03:36:20PM -0500, Pierre-Louis Bossart wrote:
> > I took the code and split it in two for BYT/CHT (modified to remove devm_)
> > and SoundWire parts (added as is).
> >
> > https
On Mon, Apr 12, 2021 at 03:36:20PM -0500, Pierre-Louis Bossart wrote:
> I took the code and split it in two for BYT/CHT (modified to remove devm_)
> and SoundWire parts (added as is).
>
> https://github.com/thesofproject/linux/pull/2810
>
> Both cases result in a refcount error on
On Tue, Apr 13, 2021 at 02:38:01PM +0300, Andy Shevchenko wrote:
> In some cases the printf() mechanism is too heavy and can't be used.
> For example, when debugging a race condition involving devres API.
> When CONFIG_DEBUG_DEVRES is enabled I can't reproduce an issue, and
> otherwise it's quite
On Mon, Apr 12, 2021 at 02:35:44PM +0200, Greg KH wrote:
> On Mon, Apr 12, 2021 at 09:36:55PM +1000, Stephen Rothwell wrote:
> > Hi all,
> >
> > After merging the usb tree, today's linux-next build (x86_64 almodconfig
> > modules_install) failed like this:
> >
> > depmod: ERROR: Cycle detected:
On Thu, Apr 08, 2021 at 11:53:23PM +0200, Wolfram Sang wrote:
> On Mon, Mar 29, 2021 at 01:50:35PM +0300, Heikki Krogerus wrote:
> > Hi,
> >
> > The old device property API (device_add_properties()) is going to be
> > removed. These prepare the i2c subsystem
On Thu, Apr 08, 2021 at 07:14:01PM +0200, Hans de Goede wrote:
> Hi,
>
> On 4/8/21 3:55 PM, Guenter Roeck wrote:
> > On 4/8/21 1:28 AM, Heikki Krogerus wrote:
> >> On Wed, Apr 07, 2021 at 05:15:40PM +0800, Zhen Lei wrote:
> >>> Fixes the following W=1 kernel bu
On Fri, Apr 09, 2021 at 05:22:16PM +0800, Jiapeng Chong wrote:
> Fix the following gcc warning:
>
> drivers/usb/typec/tcpm/tcpm.c:2107:39: warning: ‘tcpm_altmode_ops’
> defined but not used [-Wunused-const-variable=].
>
> Reported-by: Abaci Robot
> Signed-off-by: Jiapeng Chong
> ---
>
On Thu, Apr 08, 2021 at 11:10:38AM +0200, Hans de Goede wrote:
> Hi,
>
> On 4/7/21 11:15 AM, Zhen Lei wrote:
> > Fixes the following W=1 kernel build warning:
> >
> > drivers/usb/typec/tcpm/tcpm.c:2107:39: warning: ‘tcpm_altmode_ops’ defined
> > but not used [-Wunused-const-variable=]
> >
> >
On Thu, Apr 08, 2021 at 10:38:15AM +0200, Greg Kroah-Hartman wrote:
> On Thu, Apr 08, 2021 at 11:28:09AM +0300, Heikki Krogerus wrote:
> > On Wed, Apr 07, 2021 at 05:15:40PM +0800, Zhen Lei wrote:
> > > Fixes the following W=1 kernel build warning:
> > >
> > >
ed-off-by: Zhen Lei
Oh, I thought this was already fixed. Should this go into the stable
trees as well?
Acked-by: Heikki Krogerus
> ---
> drivers/usb/typec/tcpm/tcpm.c | 60
> ---
> 1 file changed, 60 deletions(-)
>
> diff --git a
> > @@ -4047,9 +4053,12 @@ static void run_state_machine(struct tcpm_port *port)
> > break;
> > case SNK_DISCOVERY:
> > if (port->vbus_present) {
> > - tcpm_set_current_limit(port,
> > -
On Wed, Apr 07, 2021 at 01:07:22PM -0700, Badhri Jagan Sridharan wrote:
> When a PD charger advertising Rp-3.0 is connected to a sink port, the
> sink port current limit would 3A, during SNK_DISCOVERY, till power
> negotiation starts. Once the negotiation starts the power limit needs
> to drop
On Wed, Apr 07, 2021 at 01:07:21PM -0700, Badhri Jagan Sridharan wrote:
> >From PD Spec:
> The Sink Shall transition to Sink Standby before a positive or
> negative voltage transition of VBUS. During Sink Standby
> the Sink Shall reduce its power draw to pSnkStdby. This allows
> the Source to
he tcpm_reset_port as power_supply_changed is already
> called right after usb_type is changed.
>
> Fixes: f2a8aa053c176 ("typec: tcpm: Represent source supply through
> power_supply")
> Signed-off-by: Badhri Jagan Sridharan
> Reviewed-by: Adam Thomson
Reviewed-by: Heikki Kr
current_limit, supply_voltage gets updated
> once local port's tcpm enters SNK_TRANSITION_SINK when the accepted
> current_limit and supply_voltage is enforced.
>
> Fixes: f2a8aa053c176 ("typec: tcpm: Represent source supply through
> power_supply")
> Signed-off-by: Ba
pec: tcpm: Represent source supply through
> power_supply")
> Signed-off-by: Badhri Jagan Sridharan
> Reviewed-by: Guenter Roeck
> Reviewed-by: Adam Thomson
Reviewed-by: Heikki Krogerus
> ---
> Changes since V1:
> * Fixed typo as suggested by Guenter Roeck.
>
The connectors may be registered after the ports, so the
"connector" links need to be created for the ports also when
ever a new connector gets registered.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 9 +++--
drivers/usb/typec/class.h | 4 +--
drivers
Introducing usb_for_each_port(). It works the same way as
usb_for_each_dev(), but instead of going through every USB
device in the system, it walks through the USB ports in the
system.
Acked-by: Alan Stern
Signed-off-by: Heikki Krogerus
---
drivers/usb/core/usb.c | 46
Creating link to the USB Type-C connector for every new port
that is added when possible.
Signed-off-by: Heikki Krogerus
---
Documentation/ABI/testing/sysfs-bus-usb | 9 +
drivers/usb/core/port.c | 3 +++
2 files changed, 12 insertions(+)
diff --git a/Documentation/ABI
ort object shares
the _PLD (Physical Location of Device) with the USB Type-C
connector that it's attached to.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/Makefile | 2 +-
drivers/usb/typec/class.c | 7 +-
drivers/usb/typec/class.h | 9 ++
drivers/usb/typec/por
a port is important
in general, but it is really important when for example the data or
power role of a device needs to swapped. The user probable wants to
know which USB device is disconnected if role swap on a USB Type-C
connector is executed.
Hope these are OK.
thanks,
Heikki Krogerus (4):
usb:
On Mon, Apr 05, 2021 at 09:09:00AM +0200, Greg Kroah-Hartman wrote:
> On Thu, Apr 01, 2021 at 01:58:44PM +0300, Heikki Krogerus wrote:
> > Adding functions that can be used to link/unlink ports -
> > USB ports, TBT3/USB4 ports, DisplayPorts and so on - to
> > the
Introducing usb_for_each_port(). It works the same way as
usb_for_each_dev(), but instead of going through every USB
device in the system, it walks through the USB ports in the
system.
Signed-off-by: Heikki Krogerus
Acked-by: Alan Stern
---
drivers/usb/core/usb.c | 46
The connectors may be registered after the ports, so the
"connector" links need to be created for the ports also when
ever a new connector gets registered.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 9 +++--
drivers/usb/typec/class.h | 4 +--
drivers
ort object shares
the _PLD (Physical Location of Device) with the USB Type-C
connector that it's attached to.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/Makefile | 2 +-
drivers/usb/typec/class.c | 7 +-
drivers/usb/typec/class.h | 9 ++
drivers/usb/typec/por
This is only to make the handling of the class consistent
with the two other susbsystems - the alt mode bus and the
mux class.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/drivers/usb
Adding a header file for each subsystem - the connector
class, alt mode bus and the class for the muxes.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/bus.c | 2 ++
drivers/usb/typec/bus.h | 19 +-
drivers/usb/typec/class.c | 69 +++
drivers
Creating link to the USB Type-C connector for every new port
that is added when possible.
Signed-off-by: Heikki Krogerus
---
Documentation/ABI/testing/sysfs-bus-usb | 9 +
drivers/usb/core/port.c | 3 +++
2 files changed, 12 insertions(+)
diff --git a/Documentation/ABI
user probable wants to
know which USB device is disconnected if role swap on a USB Type-C
connector is executed.
Hope these are OK.
thanks,
Heikki Krogerus (6):
usb: typec: Organize the private headers properly
usb: typec: Declare the typec_class static
usb: typec: Port mapping utility
On Thu, Apr 01, 2021 at 09:53:41AM +0300, Heikki Krogerus wrote:
> Hi,
>
> One more version. I used #ifdef when I should have used #if
> IS_DEFINED(). Thanks Guenter for pointing that out.
>
> I'm sending this version right away because of the holidays. I'm not
> changing
Introducing usb_for_each_port(). It works the same way as
usb_for_each_dev(), but instead of going through every USB
device in the system, it walks through the USB ports in the
system.
Signed-off-by: Heikki Krogerus
Acked-by: Alan Stern
---
drivers/usb/core/usb.c | 46
ort object shares
the _PLD (Physical Location of Device) with the USB Type-C
connector that it's attached to.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/Makefile | 2 +-
drivers/usb/typec/class.c | 7 +-
drivers/usb/typec/class.h | 9 ++
drivers/usb/typec/por
The connectors may be registered after the ports, so the
"connector" links need to be created for the ports also when
ever a new connector gets registered.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 9 +++--
drivers/usb/typec/class.h | 4 +--
drivers
This is only to make the handling of the class consistent
with the two other susbsystems - the alt mode bus and the
mux class.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/drivers/usb
Creating link to the USB Type-C connector for every new port
that is added when possible.
Signed-off-by: Heikki Krogerus
---
Documentation/ABI/testing/sysfs-bus-usb | 9 +
drivers/usb/core/port.c | 3 +++
2 files changed, 12 insertions(+)
diff --git a/Documentation/ABI
Adding a header file for each subsystem - the connector
class, alt mode bus and the class for the muxes.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/bus.c | 2 ++
drivers/usb/typec/bus.h | 19 +-
drivers/usb/typec/class.c | 69 +++
drivers
USB Type-C
connector is executed.
Hope these are OK.
thanks,
Heikki Krogerus (6):
usb: typec: Organize the private headers properly
usb: typec: Declare the typec_class static
usb: typec: Port mapping utility
usb: Link the ports to the connectors they are attached to
usb: Iterator for ports
On Wed, Mar 31, 2021 at 09:41:22AM -0700, Guenter Roeck wrote:
> > diff --git a/include/linux/usb.h b/include/linux/usb.h
> > index ddd2f5b2a2827..ebcd03d835d04 100644
> > --- a/include/linux/usb.h
> > +++ b/include/linux/usb.h
> > @@ -882,6 +882,15 @@ extern struct usb_host_interface
e logic by freeing resources explicitly when swnode_register()
> fails. Currently it happens only in fwnode_create_software_node().
>
> Signed-off-by: Andy Shevchenko
It all looks OK to me. FWIW, for the whole series:
Reviewed-by: Heikki Krogerus
> ---
> v2: no chan
Introducing usb_for_each_port(). It works the same way as
usb_for_each_dev(), but instead of going through every USB
device in the system, it walks through the USB ports in the
system.
Signed-off-by: Heikki Krogerus
Acked-by: Alan Stern
---
drivers/usb/core/usb.c | 46
The connectors may be registered after the ports, so the
"connector" links need to be created for the ports also when
ever a new connector gets registered.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 9 +++--
drivers/usb/typec/class.h | 4 +--
drivers
Creating link to the USB Type-C connector for every new port
that is added when possible.
Signed-off-by: Heikki Krogerus
---
Documentation/ABI/testing/sysfs-bus-usb | 9 +
drivers/usb/core/port.c | 3 +++
2 files changed, 12 insertions(+)
diff --git a/Documentation/ABI
ort object shares
the _PLD (Physical Location of Device) with the USB Type-C
connector that it's attached to.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/Makefile | 2 +-
drivers/usb/typec/class.c | 7 +-
drivers/usb/typec/class.h | 9 ++
drivers/usb/typec/por
Adding a header file for each subsystem - the connector
class, alt mode bus and the class for the muxes.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/bus.c | 2 ++
drivers/usb/typec/bus.h | 19 +-
drivers/usb/typec/class.c | 69 +++
drivers
This is only to make the handling of the class consistent
with the two other susbsystems - the alt mode bus and the
mux class.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/drivers/usb
now which USB device is disconnected if role swap on a USB Type-C
connector is executed.
Hope these are OK.
thanks,
Heikki Krogerus (6):
usb: typec: Organize the private headers properly
usb: typec: Declare the typec_class static
usb: typec: Port mapping utility
usb: Link the ports to the connecto
On Wed, Mar 31, 2021 at 11:22:32AM +0200, Wolfram Sang wrote:
>
> > The old device property API (device_add_properties()) is going to be
> > removed. These prepare the i2c subsystem and drivers for the change.
> > The change is fairly trivial in case of i2c. All we need to do is add
> > complete
Hi Cristian,
On Tue, Mar 30, 2021 at 11:54:42PM +0300, cristian.bir...@microchip.com wrote:
> From: Cristian Birsan
>
> This patch adds initial driver support for the new Microchip USB
> Type-C Port Controller (TCPC) embedded in sama7g5 SoC.
>
> Signed-off-by: Cristian Birsan
> ---
>
On Mon, Mar 29, 2021 at 02:49:46PM -0400, Alan Stern wrote:
> On Mon, Mar 29, 2021 at 11:44:25AM +0300, Heikki Krogerus wrote:
> > Introducing usb_for_each_port(). It works the same way as
> > usb_for_each_dev(), but instead of going through every USB
> > device in the sys
On Mon, Mar 29, 2021 at 12:58:41PM +0200, Krzysztof Kozlowski wrote:
> On 29/03/2021 12:50, Heikki Krogerus wrote:
> > Additional device properties are always just a part of a
> > software fwnode. If the device properties are constant, the
> > software node can also b
>From now on only accepting complete software nodes.
Signed-off-by: Heikki Krogerus
---
drivers/i2c/i2c-boardinfo.c | 11 ---
drivers/i2c/i2c-core-base.c | 15 +--
include/linux/i2c.h | 2 --
3 files changed, 1 insertion(+), 27 deletions(-)
diff --git a/drivers/
Additional device properties are always just a part of a
software fwnode. If the device properties are constant, the
software node can also be constant.
Signed-off-by: Heikki Krogerus
Cc: Aaro Koskinen
Cc: Tony Lindgren
---
arch/arm/mach-omap1/board-osk.c | 6 +-
1 file changed, 5
Additional device properties are always just a part of a
software fwnode. If the device properties are constant, the
software node can also be constant.
Signed-off-by: Heikki Krogerus
Cc: Hans de Goede
---
drivers/platform/x86/intel_cht_int33fe_microb.c | 6 +-
1 file changed, 5 insertions
for the
problematic "dangling" device properties from i2c subsystem,
i.e. the "properties" member from struct i2c_board_info. The
problems caused by them are not related to this driver.
Signed-off-by: Heikki Krogerus
Cc: Dmitry Torokhov
---
drivers/input/mouse/elantech.c | 6 -
Additional device properties are always just a part of a
software fwnode. If the device properties are constant, the
software node can also be constant.
Signed-off-by: Heikki Krogerus
Cc: Krzysztof Kozlowski
---
arch/arm/mach-s3c/mach-mini2440.c | 6 +-
1 file changed, 5 insertions(+), 1
Additional device properties are always just a part of a
software fwnode. If the device properties are constant, the
software node can also be constant.
Signed-off-by: Heikki Krogerus
Cc: Jonathan Cameron
Cc: Daniel Mack
Cc: Haojian Zhuang
Cc: Robert Jarzmik
---
arch/arm/mach-pxa/stargate2
Additional device properties are always just a part of a
software fwnode. If the device properties are constant, the
software node can also be constant.
Signed-off-by: Heikki Krogerus
Cc: Sekhar Nori
Cc: Bartosz Golaszewski
---
arch/arm/mach-davinci/board-da830-evm.c| 6 +-
arch/arm
Additional device properties are always just a part of a
software fwnode. If the device properties are constant, the
software node can also be constant.
Signed-off-by: Heikki Krogerus
Cc: Hans de Goede
---
drivers/i2c/busses/i2c-cht-wc.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion
The older device property API is going to be removed soon
and that will affect also I2C subystem. Supplying complete
software nodes instead of only the properties in them for
the I2C devices.
Signed-off-by: Heikki Krogerus
Cc: Benson Leung
Cc: Enric Balletbo i Serra
---
drivers/platform
Additional device properties are always just a part of a
software fwnode. If the device properties are constant, the
software node can also be constant.
Signed-off-by: Heikki Krogerus
Cc: Ajay Gupta
---
drivers/i2c/busses/i2c-nvidia-gpu.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion
Complete software node can now be supplied to the device
with struct i2c_board_info.
Signed-off-by: Heikki Krogerus
Cc: Max Staudt
---
drivers/i2c/busses/i2c-icy.c | 32 +---
1 file changed, 9 insertions(+), 23 deletions(-)
diff --git a/drivers/i2c/busses/i2c-icy.c
nodes.
thanks,
Heikki Krogerus (12):
i2c: Add support for software nodes
ARM: davinci: Constify the software nodes
ARM: omap1: osk: Constify the software node
ARM: pxa: stargate2: Constify the software node
ARM: s3c: mini2440: Constify the software node
platform/x86
This makes it possible for the drivers to assign complete
software fwnodes to the devices instead of only the device
properties in those nodes.
Signed-off-by: Heikki Krogerus
---
drivers/i2c/i2c-core-base.c | 15 ++-
include/linux/i2c.h | 4 +++-
2 files changed, 17
> I could make a stub for the usb_for_each_port() function in case
> CONFIG_USB is not enable. Would that work?
Ah, I think that's what you meant :-)
I'll fix it.
thaks,
--
heikki
On Mon, Mar 29, 2021 at 10:48:19AM +0200, Greg Kroah-Hartman wrote:
> On Mon, Mar 29, 2021 at 11:44:26AM +0300, Heikki Krogerus wrote:
> > +#ifdef CONFIG_USB
>
> This feels odd in a file under drivers/usb/ is it still relevant? Will
> this code get built for non-USB systems
The connectors may be registered after the ports, so the
"connector" links need to be created for the ports also when
ever a new connector gets registered.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 9 +++--
drivers/usb/typec/class.h | 4 +-
drivers
Introducing usb_for_each_port(). It works the same way as
usb_for_each_dev(), but instead of going through every USB
device in the system, it walks through the USB ports in the
system.
Signed-off-by: Heikki Krogerus
---
drivers/usb/core/usb.c | 46
Creating link to the USB Type-C connector for every new port
that is added when possible.
Signed-off-by: Heikki Krogerus
---
Documentation/ABI/testing/sysfs-bus-usb | 9 +
drivers/usb/core/port.c | 3 +++
2 files changed, 12 insertions(+)
diff --git a/Documentation/ABI
ort object shares
the _PLD (Physical Location of Device) with the USB Type-C
connector that it's attached to.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/Makefile | 2 +-
drivers/usb/typec/class.c | 7 +-
drivers/usb/typec/class.h | 9 ++
drivers/usb/typec/por
Adding a header file for each subsystem - the connector
class, alt mode bus and the class for the muxes.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/bus.c | 2 ++
drivers/usb/typec/bus.h | 19 +-
drivers/usb/typec/class.c | 69 +++
drivers
This is only to make the handling of the class consistent
with the two other susbsystems - the alt mode bus and the
mux class.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/drivers/usb
.
Hope these are OK.
thanks,
Heikki Krogerus (6):
usb: typec: Organize the private headers properly
usb: typec: Declare the typec_class static
usb: typec: Port mapping utility
usb: Link the ports to the connectors they are attached to
usb: Iterator for ports
usb: typec: Link all po
On Thu, Mar 25, 2021 at 04:20:15PM +0100, Greg Kroah-Hartman wrote:
> On Thu, Mar 25, 2021 at 05:14:42PM +0200, Heikki Krogerus wrote:
> > On Thu, Mar 25, 2021 at 10:41:09AM -0400, Alan Stern wrote:
> > > On Thu, Mar 25, 2021 at 03:29:21PM +0300, Heikki Krogerus wrote:
&
On Thu, Mar 25, 2021 at 05:14:45PM +0200, Heikki Krogerus wrote:
> On Thu, Mar 25, 2021 at 10:41:09AM -0400, Alan Stern wrote:
> > On Thu, Mar 25, 2021 at 03:29:21PM +0300, Heikki Krogerus wrote:
> > > Introducing usb_for_each_port(). It works the same way as
> > > usb_
On Thu, Mar 25, 2021 at 10:41:09AM -0400, Alan Stern wrote:
> On Thu, Mar 25, 2021 at 03:29:21PM +0300, Heikki Krogerus wrote:
> > Introducing usb_for_each_port(). It works the same way as
> > usb_for_each_dev(), but instead of going through every USB
> > device in the sys
The connectors may be registered after the ports, so the
"connector" links need to be created for the ports also when
ever a new connector gets registered.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 9 +++--
drivers/usb/typec/class.h | 10 +++---
d
Introducing usb_for_each_port(). It works the same way as
usb_for_each_dev(), but instead of going through every USB
device in the system, it walks through the USB ports in the
system.
Signed-off-by: Heikki Krogerus
---
drivers/usb/core/usb.c | 43
ort object shares
the _PLD (Physical Location of Device) with the USB Type-C
connector that it's attached to.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/Makefile | 1 +
drivers/usb/typec/class.c | 7 +-
drivers/usb/typec/class.h | 18 +++
drivers/usb/typec/por
This is only to make the handling of the class consistent
with the two other susbsystems - the alt mode bus and the
mux class.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/class.c | 24 +---
1 file changed, 13 insertions(+), 11 deletions(-)
diff --git a/drivers/usb
Creating link to the USB Type-C connector for every new port
that is added when possible.
Signed-off-by: Heikki Krogerus
---
Documentation/ABI/testing/sysfs-bus-usb | 9 +
drivers/usb/core/port.c | 3 +++
2 files changed, 12 insertions(+)
diff --git a/Documentation/ABI
Adding a header file for each subsystem - the connector
class, alt mode bus and the class for the muxes.
Signed-off-by: Heikki Krogerus
---
drivers/usb/typec/bus.c | 2 ++
drivers/usb/typec/bus.h | 19 +-
drivers/usb/typec/class.c | 69 +++
drivers
connected to a port is important
in general, but it is really important when for example the data or
power role of a device needs to swapped. The user probable wants to
know which USB device is disconnected if role swap on a USB Type-C
connector is executed.
Hope these are OK.
thanks,
Heikki K
On Thu, Mar 25, 2021 at 10:40:23AM +0530, Bhaskar Chowdhury wrote:
>
> s/Acknowlege/Acknowledge/
>
> Signed-off-by: Bhaskar Chowdhury
Reviewed-by: Heikki Krogerus
> ---
> drivers/usb/typec/ucsi/ucsi.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
&g
On Mon, Mar 22, 2021 at 10:02:40AM -0500, Pierre-Louis Bossart wrote:
>
>
> On 3/22/21 6:06 AM, Heikki Krogerus wrote:
> > The function device_add_properties() is going to be removed.
> > Replacing it with software node API equivalents.
> >
> > Signed-off-by
1 - 100 of 2678 matches
Mail list logo
