On Fri, 2016-09-23 at 20:00 +0800, Ian Kent wrote:
> On Fri, 2016-09-23 at 12:26 +0800, Ian Kent wrote:
> > On Thu, 2016-09-22 at 20:37 -0500, Eric W. Biederman wrote:
> > > Ian Kent writes:
> > >
> > > > On Thu, 2016-09-22 at 10:43 -0500, Eric W. Bied
On Tue, 2016-09-27 at 08:14 -0500, Eric W. Biederman wrote:
> Ian Kent <ra...@themaw.net> writes:
>
> > On Mon, 2016-09-26 at 11:05 -0500, Eric W. Biederman wrote:
> > > Ian Kent <ra...@themaw.net> writes:
> > >
> > > > On Fri, 2016-09-23
On Tue, 2016-09-27 at 08:14 -0500, Eric W. Biederman wrote:
> Ian Kent writes:
>
> > On Mon, 2016-09-26 at 11:05 -0500, Eric W. Biederman wrote:
> > > Ian Kent writes:
> > >
> > > > On Fri, 2016-09-23 at 14:15 -0500, Eric W. Biederman wrote:
> >
On Mon, 2016-09-26 at 11:05 -0500, Eric W. Biederman wrote:
> Ian Kent <ra...@themaw.net> writes:
>
> > On Fri, 2016-09-23 at 14:15 -0500, Eric W. Biederman wrote:
> > > Ian Kent <ra...@themaw.net> writes:
> > >
> > > 2> On Thu, 2016-09-22
On Mon, 2016-09-26 at 11:05 -0500, Eric W. Biederman wrote:
> Ian Kent writes:
>
> > On Fri, 2016-09-23 at 14:15 -0500, Eric W. Biederman wrote:
> > > Ian Kent writes:
> > >
> > > 2> On Thu, 2016-09-22 at 20:37 -0500, Eric W. B
On Fri, 2016-09-23 at 14:15 -0500, Eric W. Biederman wrote:
> Ian Kent <ra...@themaw.net> writes:
>
> 2> On Thu, 2016-09-22 at 20:37 -0500, Eric W. Biederman wrote:
> > > Ian Kent <ra...@themaw.net> writes:
> > >
> > > > On Thu, 2016-09-22
On Fri, 2016-09-23 at 14:15 -0500, Eric W. Biederman wrote:
> Ian Kent writes:
>
> 2> On Thu, 2016-09-22 at 20:37 -0500, Eric W. Biederman wrote:
> > > Ian Kent writes:
> > >
> > > > On Thu, 2016-09-22 at 10:43 -0500, Eric W. B
On Fri, 2016-09-23 at 12:26 +0800, Ian Kent wrote:
> On Thu, 2016-09-22 at 20:37 -0500, Eric W. Biederman wrote:
> > Ian Kent <ra...@themaw.net> writes:
> >
> > > On Thu, 2016-09-22 at 10:43 -0500, Eric W. Biederman wrote:
> > > > Ian Kent <ra..
On Fri, 2016-09-23 at 12:26 +0800, Ian Kent wrote:
> On Thu, 2016-09-22 at 20:37 -0500, Eric W. Biederman wrote:
> > Ian Kent writes:
> >
> > > On Thu, 2016-09-22 at 10:43 -0500, Eric W. Biederman wrote:
> > > > Ian Kent writes:
> > > >
> >
On Thu, 2016-09-22 at 20:37 -0500, Eric W. Biederman wrote:
> Ian Kent <ra...@themaw.net> writes:
>
> > On Thu, 2016-09-22 at 10:43 -0500, Eric W. Biederman wrote:
> > > Ian Kent <ra...@themaw.net> writes:
> > >
> > > > Eric, Mateusz, I
On Thu, 2016-09-22 at 20:37 -0500, Eric W. Biederman wrote:
> Ian Kent writes:
>
> > On Thu, 2016-09-22 at 10:43 -0500, Eric W. Biederman wrote:
> > > Ian Kent writes:
> > >
> > > > Eric, Mateusz, I appreciate your spending time on this and pa
On Thu, 2016-09-22 at 10:43 -0500, Eric W. Biederman wrote:
> Ian Kent <ra...@themaw.net> writes:
>
> > Eric, Mateusz, I appreciate your spending time on this and particularly
> > pointing
> > out my embarrassingly stupid is_local_mountpoint() usage mistake.
>
On Thu, 2016-09-22 at 10:43 -0500, Eric W. Biederman wrote:
> Ian Kent writes:
>
> > Eric, Mateusz, I appreciate your spending time on this and particularly
> > pointing
> > out my embarrassingly stupid is_local_mountpoint() usage mistake.
> >
> > Please acc
On Wed, 2016-09-21 at 07:00 +0800, Ian Kent wrote:
> On Wed, 2016-09-21 at 06:44 +0800, Ian Kent wrote:
> > On Tue, 2016-09-20 at 11:50 -0500, Eric W. Biederman wrote:
> > > Ian Kent <ra...@themaw.net> writes:
> > >
> > > > On Sat, 2016-09-17 at 22:10
On Wed, 2016-09-21 at 07:00 +0800, Ian Kent wrote:
> On Wed, 2016-09-21 at 06:44 +0800, Ian Kent wrote:
> > On Tue, 2016-09-20 at 11:50 -0500, Eric W. Biederman wrote:
> > > Ian Kent writes:
> > >
> > > > On Sat, 2016-09-17 at 22:10 +0200, Mateusz Guzi
On Wed, 2016-09-21 at 06:44 +0800, Ian Kent wrote:
> On Tue, 2016-09-20 at 11:50 -0500, Eric W. Biederman wrote:
> > Ian Kent <ra...@themaw.net> writes:
> >
> > > On Sat, 2016-09-17 at 22:10 +0200, Mateusz Guzik wrote:
> > > > On Wed, Sep 14
On Wed, 2016-09-21 at 06:44 +0800, Ian Kent wrote:
> On Tue, 2016-09-20 at 11:50 -0500, Eric W. Biederman wrote:
> > Ian Kent writes:
> >
> > > On Sat, 2016-09-17 at 22:10 +0200, Mateusz Guzik wrote:
> > > > On Wed, Sep 14, 2016 at 02:14:45PM +0800, Ian K
On Tue, 2016-09-20 at 11:50 -0500, Eric W. Biederman wrote:
> Ian Kent <ra...@themaw.net> writes:
>
> > On Sat, 2016-09-17 at 22:10 +0200, Mateusz Guzik wrote:
> > > On Wed, Sep 14, 2016 at 02:14:45PM +0800, Ian Kent wrote:
> > > > If an automount
On Tue, 2016-09-20 at 11:50 -0500, Eric W. Biederman wrote:
> Ian Kent writes:
>
> > On Sat, 2016-09-17 at 22:10 +0200, Mateusz Guzik wrote:
> > > On Wed, Sep 14, 2016 at 02:14:45PM +0800, Ian Kent wrote:
> > > > If an automount mount is clone(2)ed into a file s
On Sat, 2016-09-17 at 22:10 +0200, Mateusz Guzik wrote:
> On Wed, Sep 14, 2016 at 02:14:45PM +0800, Ian Kent wrote:
> > If an automount mount is clone(2)ed into a file system that is
> > propagation private, when it later expires in the originating
> > namespace subse
On Sat, 2016-09-17 at 22:10 +0200, Mateusz Guzik wrote:
> On Wed, Sep 14, 2016 at 02:14:45PM +0800, Ian Kent wrote:
> > If an automount mount is clone(2)ed into a file system that is
> > propagation private, when it later expires in the originating
> > namespace subse
On Fri, 2016-09-16 at 10:58 +0800, Ian Kent wrote:
> On Thu, 2016-09-15 at 19:47 -0500, Eric W. Biederman wrote:
> > Ian Kent <ra...@themaw.net> writes:
> >
> > > On Wed, 2016-09-14 at 21:08 -0500, Eric W. Biederman wrote:
> > > > Ian Kent <ra...@
On Fri, 2016-09-16 at 10:58 +0800, Ian Kent wrote:
> On Thu, 2016-09-15 at 19:47 -0500, Eric W. Biederman wrote:
> > Ian Kent writes:
> >
> > > On Wed, 2016-09-14 at 21:08 -0500, Eric W. Biederman wrote:
> > > > Ian Kent writes:
> > > >
>
On Thu, 2016-09-15 at 19:47 -0500, Eric W. Biederman wrote:
> Ian Kent <ra...@themaw.net> writes:
>
> > On Wed, 2016-09-14 at 21:08 -0500, Eric W. Biederman wrote:
> > > Ian Kent <ra...@themaw.net> writes:
> > >
> > > > On Wed, 2016-09-14
On Thu, 2016-09-15 at 19:47 -0500, Eric W. Biederman wrote:
> Ian Kent writes:
>
> > On Wed, 2016-09-14 at 21:08 -0500, Eric W. Biederman wrote:
> > > Ian Kent writes:
> > >
> > > > On Wed, 2016-09-14 at 12:28 -0500, Eric W. B
On Thu, 2016-09-15 at 12:12 +0800, Ian Kent wrote:
> On Wed, 2016-09-14 at 21:08 -0500, Eric W. Biederman wrote:
> > Ian Kent <ra...@themaw.net> writes:
> >
> > > On Wed, 2016-09-14 at 12:28 -0500, Eric W. Biederman wrote:
> > &g
On Thu, 2016-09-15 at 12:12 +0800, Ian Kent wrote:
> On Wed, 2016-09-14 at 21:08 -0500, Eric W. Biederman wrote:
> > Ian Kent writes:
> >
> > > On Wed, 2016-09-14 at 12:28 -0500, Eric W. Biederman wrote:
> > > > Ian Kent writes:
> > > >
> >
On Wed, 2016-09-14 at 21:08 -0500, Eric W. Biederman wrote:
> Ian Kent <ra...@themaw.net> writes:
>
> > On Wed, 2016-09-14 at 12:28 -0500, Eric W. Biederman wrote:
> > > Ian Kent <ra...@themaw.net> writes:
> > >
> > > >
On Wed, 2016-09-14 at 21:08 -0500, Eric W. Biederman wrote:
> Ian Kent writes:
>
> > On Wed, 2016-09-14 at 12:28 -0500, Eric W. Biederman wrote:
> > > Ian Kent writes:
> > >
> > > > If an automount mount is clone(2)ed into a file system that is
On Wed, 2016-09-14 at 12:28 -0500, Eric W. Biederman wrote:
> Ian Kent <ra...@themaw.net> writes:
>
> > If an automount mount is clone(2)ed into a file system that is
> > propagation private, when it later expires in the originating
> > namespace subsequent
On Wed, 2016-09-14 at 12:28 -0500, Eric W. Biederman wrote:
> Ian Kent writes:
>
> > If an automount mount is clone(2)ed into a file system that is
> > propagation private, when it later expires in the originating
> > namespace subsequent calls to autofs ->d_auto
On Wed, 2016-09-14 at 12:28 -0500, Eric W. Biederman wrote:
> Ian Kent <ra...@themaw.net> writes:
>
> > If an automount mount is clone(2)ed into a file system that is
> > propagation private, when it later expires in the originating
> > namespace subsequent
On Wed, 2016-09-14 at 12:28 -0500, Eric W. Biederman wrote:
> Ian Kent writes:
>
> > If an automount mount is clone(2)ed into a file system that is
> > propagation private, when it later expires in the originating
> > namespace subsequent calls to autofs ->d_auto
Having added the have_local_submounts() function there are no
remaining users of have_submounts() so remove it.
Signed-off-by: Ian Kent <ra...@themaw.net>
Cc: Al Viro <v...@zeniv.linux.org.uk>
Cc: Eric W. Biederman <ebied...@xmission.com>
Cc: Omar Sandoval <osan...@osandov.
() can return an incorect result when a mount
exists in a namespace other than the one being checked.
Signed-off-by: Ian Kent <ra...@themaw.net>
Cc: Al Viro <v...@zeniv.linux.org.uk>
Cc: Eric W. Biederman <ebied...@xmission.com>
Cc: Omar Sandoval <osan...@osandov.com>
---
Having added the have_local_submounts() function there are no
remaining users of have_submounts() so remove it.
Signed-off-by: Ian Kent
Cc: Al Viro
Cc: Eric W. Biederman
Cc: Omar Sandoval
---
fs/dcache.c| 33 -
include/linux/dcache.h |1 -
2
() can return an incorect result when a mount
exists in a namespace other than the one being checked.
Signed-off-by: Ian Kent
Cc: Al Viro
Cc: Eric W. Biederman
Cc: Omar Sandoval
---
fs/autofs4/dev-ioctl.c |2 +-
fs/autofs4/expire.c|4 ++--
fs/autofs4/root.c
The have_submounts() function checks if a dentry is a mountpoint
in any namespace but autofs needs to know if the dentry is a
mountpoint within the current namespace.
Add have_local_submounts() to to do this.
Signed-off-by: Ian Kent <ra...@themaw.net>
Cc: Al Viro <v...@zeniv.linux.o
The is_local_mountpoint() function will be needed for autofs
to check if a dentry is a mountpoint in the current namespace.
Signed-off-by: Ian Kent <ra...@themaw.net>
Cc: Al Viro <v...@zeniv.linux.org.uk>
Cc: Eric W. Biederman <ebied...@xmission.com>
Cc: Omar Sandoval &l
The have_submounts() function checks if a dentry is a mountpoint
in any namespace but autofs needs to know if the dentry is a
mountpoint within the current namespace.
Add have_local_submounts() to to do this.
Signed-off-by: Ian Kent
Cc: Al Viro
Cc: Eric W. Biederman
Cc: Omar Sandoval
---
fs
The is_local_mountpoint() function will be needed for autofs
to check if a dentry is a mountpoint in the current namespace.
Signed-off-by: Ian Kent
Cc: Al Viro
Cc: Eric W. Biederman
Cc: Omar Sandoval
---
fs/mount.h|9 -
fs/namespace.c|1 +
include/linux
and quicker than the indirect mount expire and
adding spin lock release and re-aquires would do nothing more
than add overhead.
Fixes: 47be61845c77 ("fs/dcache.c: avoid soft-lockup in dput()")
Signed-off-by: Ian Kent <ra...@themaw.net>
Cc: Takashi Iwai <ti...@suse.de>
Cc: And
and quicker than the indirect mount expire and
adding spin lock release and re-aquires would do nothing more
than add overhead.
Fixes: 47be61845c77 ("fs/dcache.c: avoid soft-lockup in dput()")
Signed-off-by: Ian Kent
Cc: Takashi Iwai
Cc: Andrew Morton
Cc: NeilBrown
---
fs/autofs4/expir
On Fri, 2016-09-09 at 11:39 +1000, NeilBrown wrote:
> On Thu, Sep 01 2016, Ian Kent wrote:
>
> > Somewhere along the way the autofs expire operation has changed to
> > hold a spin lock over expired dentry selection. The autofs indirect
> > mount expired dentry selection
On Fri, 2016-09-09 at 11:39 +1000, NeilBrown wrote:
> On Thu, Sep 01 2016, Ian Kent wrote:
>
> > Somewhere along the way the autofs expire operation has changed to
> > hold a spin lock over expired dentry selection. The autofs indirect
> > mount expired dentry selection
and quicker than the indirect mount expire and
adding spin lock release and re-aquires would do nothing more
than add overhead.
Signed-off-by: Ian Kent <ra...@themaw.net>
---
fs/autofs4/expire.c | 55 +++
1 file changed, 42 insertions(+), 13 del
and quicker than the indirect mount expire and
adding spin lock release and re-aquires would do nothing more
than add overhead.
Signed-off-by: Ian Kent
---
fs/autofs4/expire.c | 55 +++
1 file changed, 42 insertions(+), 13 deletions(-)
diff --git a/fs
tional difference.
Signed-off-by: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
Signed-off-by: Ian Kent <ra...@themaw.net>
---
fs/autofs4/autofs_i.h |2 --
1 file changed, 2 deletions(-)
diff --git a/fs/autofs4/autofs_i.h b/fs/autofs4/autofs_i.h
index dd71bd4..4404a22 100644
--- a/fs/autofs
-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
---
fs/autofs4/autofs_i.h |2 --
1 file changed, 2 deletions(-)
diff --git a/fs/autofs4/autofs_i.h b/fs/autofs4/autofs_i.h
index dd71bd4..4404a22 100644
--- a/fs/autofs4/autofs_i.h
+++ b/fs/autofs4/autofs_i.h
@@ -34,8 +34,6 @@
#include
#include
upstream.
Signed-off-by: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
Signed-off-by: Ian Kent <ra...@themaw.net>
---
fs/autofs4/autofs_i.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/autofs4/autofs_i.h b/fs/autofs4/autofs_i.h
index 4404a22..a1fba42 100644
--- a/
From: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
cmd part of this struct is the same as an index of itself within
_ioctls[]. In fact this cmd is unused, so we can drop this part.
Signed-off-by: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
Signed-off-by: Ian Kent <ra...@them
umi
Signed-off-by: Ian Kent
---
fs/autofs4/autofs_i.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/autofs4/autofs_i.h b/fs/autofs4/autofs_i.h
index 4404a22..a1fba42 100644
--- a/fs/autofs4/autofs_i.h
+++ b/fs/autofs4/autofs_i.h
@@ -21,7 +21,7 @@
#def
From: Tomohiro Kusumi
cmd part of this struct is the same as an index of itself within
_ioctls[]. In fact this cmd is unused, so we can drop this part.
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
---
fs/autofs4/dev-ioctl.c | 49
1
On Tue, 2016-08-30 at 09:37 +0800, Ian Kent wrote:
> On Mon, 2016-08-29 at 16:18 +0100, Al Viro wrote:
> > On Mon, Aug 29, 2016 at 04:35:46PM +0200, Takashi Iwai wrote:
> >
> > > [] dput+0x46/0x400
> > ... which should not be called in atomic contexts
> &
On Tue, 2016-08-30 at 09:37 +0800, Ian Kent wrote:
> On Mon, 2016-08-29 at 16:18 +0100, Al Viro wrote:
> > On Mon, Aug 29, 2016 at 04:35:46PM +0200, Takashi Iwai wrote:
> >
> > > [] dput+0x46/0x400
> > ... which should not be called in atomic contexts
> &
On Mon, 2016-08-29 at 16:18 +0100, Al Viro wrote:
> On Mon, Aug 29, 2016 at 04:35:46PM +0200, Takashi Iwai wrote:
>
> > [] dput+0x46/0x400
> ... which should not be called in atomic contexts
> > [] follow_down_one+0x27/0x60
> ... and neither should this
> > []
On Mon, 2016-08-29 at 16:18 +0100, Al Viro wrote:
> On Mon, Aug 29, 2016 at 04:35:46PM +0200, Takashi Iwai wrote:
>
> > [] dput+0x46/0x400
> ... which should not be called in atomic contexts
> > [] follow_down_one+0x27/0x60
> ... and neither should this
> > []
On Mon, 2016-08-22 at 20:32 +0200, Mikko Rapeli wrote:
> Fixes userspace compilation error:
>
> error: ‘NAME_MAX’ undeclared here (not in a function)
Thanks for your effort but a patch for this, from from Tomohiro Kusumi, is
currently included in the mm tree.
>
> Signed-off-by: Mikko Rapeli
On Mon, 2016-08-22 at 20:32 +0200, Mikko Rapeli wrote:
> Fixes userspace compilation error:
>
> error: ‘NAME_MAX’ undeclared here (not in a function)
Thanks for your effort but a patch for this, from from Tomohiro Kusumi, is
currently included in the mm tree.
>
> Signed-off-by: Mikko Rapeli
>
From: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
autofs4_kill_sb() doesn't need to be declared as extern,
and no other functions in .h are explicitly declared as extern.
Signed-off-by: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
Signed-off-by: Ian Kent <ra...@themaw.net&g
From: Tomohiro Kusumi
autofs4_kill_sb() doesn't need to be declared as extern,
and no other functions in .h are explicitly declared as extern.
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
---
fs/autofs4/autofs_i.h |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
ed-off-by: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
Signed-off-by: Ian Kent <ik...@redhat.com>
---
.../filesystems/autofs4-mount-control.txt | 70
1 file changed, 42 insertions(+), 28 deletions(-)
diff --git a/Documentation/filesystems/autofs4-mount-control.tx
From: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
Returning -ENOTTY here fails to free dynamically allocated param.
Signed-off-by: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
Signed-off-by: Ian Kent <ik...@redhat.com>
---
fs/autofs4/dev-ioctl.c |3 ++-
1 file changed,
-by: Ian Kent
---
.../filesystems/autofs4-mount-control.txt | 70
1 file changed, 42 insertions(+), 28 deletions(-)
diff --git a/Documentation/filesystems/autofs4-mount-control.txt
b/Documentation/filesystems/autofs4-mount-control.txt
index 540d9a7..50a3e01 100644
From: Tomohiro Kusumi
Returning -ENOTTY here fails to free dynamically allocated param.
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
---
fs/autofs4/dev-ioctl.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/autofs4/dev-ioctl.c b/fs/autofs4/dev-ioctl.c
m>
Signed-off-by: Ian Kent <ik...@redhat.com>
---
.../filesystems/autofs4-mount-control.txt |5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/Documentation/filesystems/autofs4-mount-control.txt
b/Documentation/filesystems/autofs4-mount-control.txt
inde
e long run.
3. The existing code is based on the fact that validate_dev_ioctl()
sets ioctl version for any command, but AUTOFS_DEV_IOCTL_VERSION_CMD
should explicitly set it regardless of the default behavior.
Signed-off-by: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
Signed-off-by:
From: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
This macro was never used by neither kernel nor userspace,
and also doesn't represent "devid length" in bytes.
(unless it was added to mean something else).
Signed-off-by: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
Signe
From: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
This isn't a return value, so change the message to indicate
the status is the result of may_umount().
(or locate pr_debug() after put_user() with the same message)
Signed-off-by: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
Signed
Since linux/auto_dev-ioctl.h wasn't included in include/linux/Kbuild
it wasn't moved to uapi/linux as part of the uapi series.
Signed-off-by: Ian Kent <ra...@themaw.net>
---
include/linux/auto_dev-ioctl.h | 209 -
include/uapi/linux/auto_dev-ioctl.h
From: Tomohiro Kusumi
The explanation on how ioctl handles devid seems incorrect.
Userspace who calls this ioctl has no input regarding devid,
and ioctl implementation retrieves devid via superblock.
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
---
.../filesystems/autofs4-mount
is based on the fact that validate_dev_ioctl()
sets ioctl version for any command, but AUTOFS_DEV_IOCTL_VERSION_CMD
should explicitly set it regardless of the default behavior.
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
---
fs/autofs4/dev-ioctl.c | 25
From: Tomohiro Kusumi
This macro was never used by neither kernel nor userspace,
and also doesn't represent "devid length" in bytes.
(unless it was added to mean something else).
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
---
include/linux/auto_dev-ioctl.h |2
From: Tomohiro Kusumi
This isn't a return value, so change the message to indicate
the status is the result of may_umount().
(or locate pr_debug() after put_user() with the same message)
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
---
fs/autofs4/root.c |2 +-
1 file changed
Since linux/auto_dev-ioctl.h wasn't included in include/linux/Kbuild
it wasn't moved to uapi/linux as part of the uapi series.
Signed-off-by: Ian Kent
---
include/linux/auto_dev-ioctl.h | 209 -
include/uapi/linux/auto_dev-ioctl.h | 221
gt; EOF
# gcc -Wall -g ./test1.c
In file included from ./test1.c:2:0:
/usr/include/linux/auto_fs.h:54:12: error: 'NAME_MAX' undeclared here (not in
a function)
char name[NAME_MAX+1];
^
Signed-off-by: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
Signed-off-by: Ian Kent <ik..
control
interface version mismatch: kernel(1.0), user(0.0), cmd(-1072131215)
Signed-off-by: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
Signed-off-by: Ian Kent <ik...@redhat.com>
---
fs/autofs4/dev-ioctl.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/autofs4/dev-
The count of miscellaneous device ioctls in fs/autofs4/autofs_i.h is wrong.
The number of ioctls is the difference between AUTOFS_DEV_IOCTL_VERSION_CMD
and AUTOFS_DEV_IOCTL_ISMOUNTPOINT_CMD (14) not the difference between
AUTOFS_IOC_COUNT and 11 (21).
Signed-off-by: Ian Kent <ra...@themaw.
file included from ./test1.c:2:0:
/usr/include/linux/auto_fs.h:54:12: error: 'NAME_MAX' undeclared here (not in
a function)
char name[NAME_MAX+1];
^
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
---
include/linux/auto_fs.h |1 -
include/uapi/linux/auto_fs.h |
ernel(1.0), user(0.0), cmd(-1072131215)
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
---
fs/autofs4/dev-ioctl.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/autofs4/dev-ioctl.c b/fs/autofs4/dev-ioctl.c
index 7289216..e89d6bb 100644
--- a/fs/autofs4/dev-ioct
The count of miscellaneous device ioctls in fs/autofs4/autofs_i.h is wrong.
The number of ioctls is the difference between AUTOFS_DEV_IOCTL_VERSION_CMD
and AUTOFS_DEV_IOCTL_ISMOUNTPOINT_CMD (14) not the difference between
AUTOFS_IOC_COUNT and 11 (21).
Signed-off-by: Ian Kent
Cc: Tomohiro Kusumi
From: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
plus minor whitespace fixes.
Signed-off-by: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
Signed-off-by: Ian Kent <ra...@themaw.net>
---
Documentation/filesystems/autofs4.txt |8
1 file changed, 4 insertions(+), 4
The inode allocation failure case in autofs4_dir_symlink() frees
the autofs dentry info of the dentry without setting ->d_fsdata to
NULL.
That could lead to a double free so just get rid of the free and
leave it to ->d_release().
Signed-off-by: Ian Kent <ra...@themaw.net>
Cc: Tom
Somewhere along the line the error handling gotos have become incorrect.
Signed-off-by: Ian Kent <ra...@themaw.net>
Cc: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
---
fs/autofs4/inode.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/autofs4/inode.c
change in the previous patch.
Signed-off-by: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
Signed-off-by: Ian Kent <ra...@themaw.net>
---
fs/autofs4/inode.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/autofs4/inode.c b/fs/autofs4/inode.c
index 0dd4db9..f35ea
umi.tomoh...@gmail.com>
Signed-off-by: Ian Kent <ra...@themaw.net>
---
fs/autofs4/inode.c | 34 +-
1 file changed, 17 insertions(+), 17 deletions(-)
diff --git a/fs/autofs4/inode.c b/fs/autofs4/inode.c
index 61b2105..8357544 100644
--- a/fs/autofs4/inode.
From: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
It's invalid if the given mode is neither dir nor link,
so warn on else case.
Signed-off-by: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
Signed-off-by: Ian Kent <ra...@themaw.net>
---
fs/autofs4/inode.c |3 ++-
1 file cha
From: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
These two were left from aa55ddf3 which removed unused ioctls.
Signed-off-by: Tomohiro Kusumi <kusumi.tomoh...@gmail.com>
Signed-off-by: Ian Kent <ik...@redhat.com>
---
fs/autofs4/autofs_i.h |2 --
1 file changed, 2 deleti
From: Tomohiro Kusumi
plus minor whitespace fixes.
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
---
Documentation/filesystems/autofs4.txt |8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/Documentation/filesystems/autofs4.txt
b/Documentation
The inode allocation failure case in autofs4_dir_symlink() frees
the autofs dentry info of the dentry without setting ->d_fsdata to
NULL.
That could lead to a double free so just get rid of the free and
leave it to ->d_release().
Signed-off-by: Ian Kent
Cc: Tomohiro Kusumi
---
fs/a
Somewhere along the line the error handling gotos have become incorrect.
Signed-off-by: Ian Kent
Cc: Tomohiro Kusumi
---
fs/autofs4/inode.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/fs/autofs4/inode.c b/fs/autofs4/inode.c
index 8357544..64d721f 100644
-off-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
---
fs/autofs4/inode.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/autofs4/inode.c b/fs/autofs4/inode.c
index 0dd4db9..f35ead7 100644
--- a/fs/autofs4/inode.c
+++ b/fs/autofs4/inode.c
@@ -340,7 +340,7 @@ fail_dput
From: Tomohiro Kusumi
This patch does what the below comment says.
It could be and it's considered better to do this first
before various functions get called during initialization.
/* Couldn't this be tested earlier? */
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
---
fs/autofs4
From: Tomohiro Kusumi
It's invalid if the given mode is neither dir nor link,
so warn on else case.
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
---
fs/autofs4/inode.c |3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/fs/autofs4/inode.c b/fs/autofs4/inode.c
From: Tomohiro Kusumi
These two were left from aa55ddf3 which removed unused ioctls.
Signed-off-by: Tomohiro Kusumi
Signed-off-by: Ian Kent
---
fs/autofs4/autofs_i.h |2 --
1 file changed, 2 deletions(-)
diff --git a/fs/autofs4/autofs_i.h b/fs/autofs4/autofs_i.h
index eb87055..73e3d38
From: Andrey Vagin <ava...@openvz.org>
__vfs_write() returns a negative value in a error case.
Signed-off-by: Andrey Vagin <ava...@openvz.org>
Signed-off-by: Ian Kent <ra...@themaw.net>
---
fs/autofs4/waitq.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-
From: Andrey Vagin
__vfs_write() returns a negative value in a error case.
Signed-off-by: Andrey Vagin
Signed-off-by: Ian Kent
---
fs/autofs4/waitq.c |7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/fs/autofs4/waitq.c b/fs/autofs4/waitq.c
index 0146d91..631f155
On Fri, 2016-06-10 at 12:07 -0700, Andrew Morton wrote:
> On Thu, 09 Jun 2016 09:23:26 +0800 Ian Kent <ra...@themaw.net> wrote:
>
> > > I was getting ready to send these over to Andrew and found that opendir(3)
> > > is
> > > failing on a number of
On Fri, 2016-06-10 at 12:07 -0700, Andrew Morton wrote:
> On Thu, 09 Jun 2016 09:23:26 +0800 Ian Kent wrote:
>
> > > I was getting ready to send these over to Andrew and found that opendir(3)
> > > is
> > > failing on a number of tests (51 of 230,
Hi all,
An update is overdue so here it is.
It's mostly a bug fix update.
autofs
==
The package can be found at:
ftp://ftp.kernel.org/pub/linux/daemons/autofs/v5
It is autofs-5.1.2.tar.[gz|xz]
No source rpm is there as it can be produced by using:
rpmbuild -ts autofs-5.1.2.tar.gz
and
501 - 600 of 1322 matches
Mail list logo
