Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapped files

That is very important for computer forensics. Esp. in saving your ass! Ok, now back again to making that fast :-) Best Regards Ingo Oeser -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at

Re: [PATCH 4/5] x86: Add config variables for SMP_MAX

and why does this help scalability? Many thanks and Best Regards Ingo Oeser, puzzled a bit :-) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH -v6 2/2] Updating ctime and mtime for memory-mapped files

your ass! Ok, now back again to making that fast :-) Best Regards Ingo Oeser -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [PATCH 4/5] x86: Add config variables for SMP_MAX

elaborate, why this is needed and put more info about this requirement into this patch description? People worked hard to push data allocation from stack to heap to make THREAD_ORDER of 0 and 1 possible. So why increase it again and why does this help scalability? Many thanks and Best Regards Ingo

kinit (was: sleep before boot panic)

of it. The only thing really missing for me is LVM support. Debian (?) did a evil hack to make it work. Maybe one day this itches soo much, I'll even scratch it :-) Then I'll be able to test kernels on a standard LVM installation again. So please keep up the good work! Best Regards Ingo Oeser

kinit (was: sleep before boot panic)

to make it work. Maybe one day this itches soo much, I'll even scratch it :-) Then I'll be able to test kernels on a standard LVM installation again. So please keep up the good work! Best Regards Ingo Oeser -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: sleep before boot panic

uot;soft" panic better, where you still can operate the kernel debugging features, but just have no user space supporting it. One better hopes, that keyboards never need external firmware to be loaded at this stage :-) Best Regards Ingo Oeser, who just hit the same problem yesterday... -- To u

Re: sleep before boot panic

better hopes, that keyboards never need external firmware to be loaded at this stage :-) Best Regards Ingo Oeser, who just hit the same problem yesterday... -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: sleep before boot panic

Hi Bernd, CC'ed hpa, since I'm sure he can give useful advise on that :-) On Sunday 06 January 2008, Bernd Schubert wrote: > On Sunday 06 January 2008, Ingo Oeser wrote: > > Hi Bernd, > > > > On Sunday 06 January 2008, you wrote: > > > Index: zd12

Re: sleep before boot panic

msleep(60 * 1000); ssleep(60); > panic("VFS: Unable to mount root fs on %s", b); > } Better would be for this and similiar panic()s (fatal user/admin errors on boot) to NOT print a stack trace+registers, since it is useless and actually hides useful information.

Re: sleep before boot panic

root fs on %s, b); } Better would be for this and similiar panic()s (fatal user/admin errors on boot) to NOT print a stack trace+registers, since it is useless and actually hides useful information. Best Regards Ingo Oeser -- To unsubscribe from this list: send the line unsubscribe linux

Re: sleep before boot panic

Hi Bernd, CC'ed hpa, since I'm sure he can give useful advise on that :-) On Sunday 06 January 2008, Bernd Schubert wrote: On Sunday 06 January 2008, Ingo Oeser wrote: Hi Bernd, On Sunday 06 January 2008, you wrote: Index: zd1211rw.git.beno/init/do_mounts.c

Re: [PATCH 0/4] add task handling notifier

er lists ARE internal variables) to modules. What do you think? Best Regards Ingo Oeser -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 0/4] add task handling notifier

. What do you think? Best Regards Ingo Oeser -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH][RFC] dynamic pipe resizing

that it is rounding and make the unit arbitrary. That reduces the ABI requirements. Best Regards Ingo Oeser -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH][RFC] dynamic pipe resizing

Regards Ingo Oeser -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [feature] automatically detect hung TASK_UNINTERRUPTIBLE tasks

ares here? That shouldn't be killed by the OOM killer in that situation, should it? Am I missing sth.? Best Regards Ingo Oeser -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/

Re: [feature] automatically detect hung TASK_UNINTERRUPTIBLE tasks

be killed by the OOM killer in that situation, should it? Am I missing sth.? Best Regards Ingo Oeser -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [PATCH] ata: ahci: Enable enclosure management via LED (resend)

). So I'm fine either way, since I see you point. Best Regards Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] ata: ahci: Enable enclosure management via LED (resend)

linux/leds.h under include/ Since you explicitly WANT user space to control these, that should be the right API. Richard, what do YOU think? Best Regards Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PR

Re: [PATCH] ata: ahci: Enable enclosure management via LED (resend)

include/ Since you explicitly WANT user space to control these, that should be the right API. Richard, what do YOU think? Best Regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] ata: ahci: Enable enclosure management via LED (resend)

way, since I see you point. Best Regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 13/13] RT: Cache cpus_allowed weight for optimizing migration

nd cached in > the task_struct. Why not make it a task flag, since according to your code, you are only interested whether this is <= 1 or > 1. Since !(x <= 1) <=> (x > 1) for any given unsigned integer x, the required data structure is a "boolean" or a flag. Best Regards Ingo Oes

Re: [PATCH 13/13] RT: Cache cpus_allowed weight for optimizing migration

. Why not make it a task flag, since according to your code, you are only interested whether this is = 1 or 1. Since !(x = 1) = (x 1) for any given unsigned integer x, the required data structure is a boolean or a flag. Best Regards Ingo Oeser - To unsubscribe from this list: send the line

Re: [RFC] Extending kbuild syntax

eady. So kbuild is just lacking an "else" clause here. Best Regards Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [RFC] Extending kbuild syntax

Regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [patch] Combine path_put and path_put_conditional

(see the kerneldoc). ^ So why not name it path_walk_put_pair() then? Rationale: "_both" is just counting, "_pair" means they are related somehow. Best regards Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

[OT] kbuild syntax extension for ccflags and asflags (was: [PATCH 1/3] CodingStyle updates)

rther split that into -debug-y and -optimize-y flags, but that was just for my own convenience. Best Regards Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordom

[OT] kbuild syntax extension for ccflags and asflags (was: [PATCH 1/3] CodingStyle updates)

, but that was just for my own convenience. Best Regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org

Re: [patch] Combine path_put and path_put_conditional

why not name it path_walk_put_pair() then? Rationale: _both is just counting, _pair means they are related somehow. Best regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH 1/3] Fix coding style

t;, 0644, NULL); > + pe = create_proc_entry("root_user_cpu_share", 0644, NULL); > if (!pe) > return -ENOMEM; What about moving this debug stuff under debugfs? Please consider using the functions in . They compile into nothing, if DEBUGFS is not compiled in and have already

Re: [PATCH 1/3] Fix coding style

this debug stuff under debugfs? Please consider using the functions in linux/debugfs.h . They compile into nothing, if DEBUGFS is not compiled in and have already useful functions for reading/writing integers and booleans. Best Regards Ingo Oeser - To unsubscribe from this list: send the line

Re: Why do so many machines need "noapic"?

dows tool. Linux people not always (want to) have access to Windows :-) I reported the all the problems (starting 2001), no developer seemed interested. I can report them against the latest RC6 kernel tomorrow and put them into bugzilla, if we now REALLY care. Best Regards Ingo Oeser - T

Re: Why do so many machines need noapic?

interested. I can report them against the latest RC6 kernel tomorrow and put them into bugzilla, if we now REALLY care. Best Regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

[PATCH] crypto: cleanup: Use max() in blkcipher_get_spot() to state the intention.

[PATCH] crypto: cleanup: Use max() in blkcipher_get_spot() to state the intention. Signed-off-by: Ingo Oeser <[EMAIL PROTECTED]> --- Hi Herbert, here is the requested patch against Linus' latest tree. It at least compiles. Best Regards Ingo Oeser crypto/blkcipher.c |2 +- 1

[PATCH] crypto: cleanup: Use max() in blkcipher_get_spot() to state the intention.

[PATCH] crypto: cleanup: Use max() in blkcipher_get_spot() to state the intention. Signed-off-by: Ingo Oeser [EMAIL PROTECTED] --- Hi Herbert, here is the requested patch against Linus' latest tree. It at least compiles. Best Regards Ingo Oeser crypto/blkcipher.c |2 +- 1 files changed

Re: [PATCH] crypto: blkcipher_get_spot() handling of buffer at end of page

static inline u8 *blkcipher_get_spot(u8 *start, unsigned int len) { u8 *end_page = (u8 *)(((unsigned long)(start + len - 1)) & PAGE_MASK); return max(start, end_page); } Best Regards Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux-kernel&quo

[RFD] new syscalls: suspend_other/resume_other?

(). NOTES The value -1 for tid is reserved for future extension (e.g. meaning ALL other threads). This call might be restricted to the main thread. - Any opinions? Best Regards Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux-kern

[RFD] new syscalls: suspend_other/resume_other?

The value -1 for tid is reserved for future extension (e.g. meaning ALL other threads). This call might be restricted to the main thread. - Any opinions? Best Regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH] memchr (trivial) optimization

rn (void *)p; } return NULL; } Now the compiler should see the loop more clearly. Best Regards Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] memchr (trivial) optimization

; } return NULL; } Now the compiler should see the loop more clearly. Best Regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [PATCH]: proc: export a processes resource limits via proc/

Hi Neil, > +static struct limit_names lnames[RLIM_NLIMITS] = { static const ... may be better here. Best Regards Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vg

Re: [PATCH]: proc: export a processes resource limits via proc/pid

Hi Neil, +static struct limit_names lnames[RLIM_NLIMITS] = { static const ... may be better here. Best Regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org

Re: Driver-level memory management

is in lib/genalloc.c, if you like to take a look. Memory for MANAGING free/allocated space is NOT taken from your on-card memory! That allocator is explicitly developed for such use cases. Happy hacking! Best regards Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe

Re: Driver-level memory management

/genalloc.c, if you like to take a look. Memory for MANAGING free/allocated space is NOT taken from your on-card memory! That allocator is explicitly developed for such use cases. Happy hacking! Best regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [patch 03/11] fuse: add reference counting to fuse_file

kfree(ff); } This will also fix the missing smp_barriers, is very simple, saves code, makes your life easier and is a well known known kernel infrastructure :-) BTW: FUSE rocks! :-) You can add my "Signed-off-by: Ingo Oeser <[EMAIL PROTECTED]>", if you want to use that sug

Re: [patch 03/11] fuse: add reference counting to fuse_file

the missing smp_barriers, is very simple, saves code, makes your life easier and is a well known known kernel infrastructure :-) BTW: FUSE rocks! :-) You can add my Signed-off-by: Ingo Oeser [EMAIL PROTECTED], if you want to use that suggestion. Best Regards Ingo Oeser - To unsubscribe from this list

Re: [EXT4 set 7][PATCH 1/1]Remove 32000 subdirs limit.

_MAX); } static inline bool ext4_dir_link_empty(const struct inode *dir) { #ifdef FOOBAR return dir->i_nlink == 2 || dir->i_nlink == 1; #else return dir->i_nlink == 2; #endif } FOOBAR is the define, which enables ext4_is_dx(). That is not in the patch, so left as an ex

Re: [EXT4 set 7][PATCH 1/1]Remove 32000 subdirs limit.

} FOOBAR is the define, which enables ext4_is_dx(). That is not in the patch, so left as an exercise to the reader :-) Best Regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] intel-rng: Undo mess made by an 80 column extremist

e the damn fast change rate of Linux possible by keeping the base clean and neat. Best Regards Ingo oeser - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [RFC][PATCH 1/6] Storing ipcs into radix trees

Hi, On Friday 08 June 2007, Nadia Derbey wrote: > Ingo Oeser wrote: > > ... together with this means 4*256 -> 1k of precious stack space used. > > Please consider either lowering IPCS_MAX_SCAN_ENTRIES or kmalloc() that. > You're completely right, but trying to lower the

Re: [RFC][PATCH 1/6] Storing ipcs into radix trees

Hi, On Friday 08 June 2007, Nadia Derbey wrote: Ingo Oeser wrote: ... together with this means 4*256 - 1k of precious stack space used. Please consider either lowering IPCS_MAX_SCAN_ENTRIES or kmalloc() that. You're completely right, but trying to lower the extraction size, I'm afraid

Re: [PATCH] intel-rng: Undo mess made by an 80 column extremist

Regards Ingo oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [RFC][PATCH 1/6] Storing ipcs into radix trees

nnot sleep, try to lower that constant (e.g. 16-32). The current users use much smaller numbers. If you can sleep and performance goes down after lowering that constant, try to kmalloc these arrays (since kmalloc() of that small amount should succeed easily). Regards Ingo Oeser - To unsubscrib

Re: [RFC][PATCH 1/6] Storing ipcs into radix trees

after lowering that constant, try to kmalloc these arrays (since kmalloc() of that small amount should succeed easily). Regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [Bridge] [BUG] Dropping fragmented IP packets within VLAN frames on bridge

s much more readable, more documented and doesn't contain a condition monster :-) @Patrick: Could you check, wether the PPPoE case is correct? What do you think? Should I submit a patch for that? Best Regards Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: epoll,threading

ocess or thread pool to scale beyond that. Pool size is typically related to the amount of CPU cores in the system. Regards Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info a

Re: epoll,threading

to scale beyond that. Pool size is typically related to the amount of CPU cores in the system. Regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: [Bridge] [BUG] Dropping fragmented IP packets within VLAN frames on bridge

); else return br_dev_queue_push_xmit(skb); } which is much more readable, more documented and doesn't contain a condition monster :-) @Patrick: Could you check, wether the PPPoE case is correct? What do you think? Should I submit a patch for that? Best Regards Ingo Oeser

Re: [PATCH] Introduce boot based time

> keep sub-second sleep granularity? No, I'm just overworked and getting sloppy :-/ Sorry for the noise... Best regards Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at h

Re: [PATCH] Introduce boot based time

t imagine a surveillance camera triggered by door entrance. Yes, these things might run Linux (e.g. on "cris" architecture). Or your VCR. Yes, these devices might sleep more than they are awake, if you are not a TV junkie :-) Best regards Ingo Oeser - To unsubscribe from this lis

Re: [PATCH] Introduce boot based time

VCR. Yes, these devices might sleep more than they are awake, if you are not a TV junkie :-) Best regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] Introduce boot based time

granularity? No, I'm just overworked and getting sloppy :-/ Sorry for the noise... Best regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH 1/2] LogFS proper

magic. Don't worry, we have __packed predefined for this. Just look in include/linux/compiler-gcc.h I love it, because I always forget at least one brace or undescore level :-) Regards Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

Re: [PATCH 1/2] LogFS proper

predefined for this. Just look in include/linux/compiler-gcc.h I love it, because I always forget at least one brace or undescore level :-) Regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info

Re: [RFC] [PATCH] DRM TTM Memory Manager patch

gt; is Ok, what about debugfs then? If it is just for debugging blobs -> debugfs, if it is crucial for operation -> sysfs and representation of one value per file. Regards Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in t

Re: [RFC] [PATCH] DRM TTM Memory Manager patch

blobs - debugfs, if it is crucial for operation - sysfs and representation of one value per file. Regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo

Re: [PATCH] crypto: Use padlock.ko only as a module

a feature to be a module on a kernel without module support, it will effectivly be disabled. And if it is so simple to do the same in userspace like you suggest, than that's much better. Best Regards Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of

Re: [PATCH] crypto: Use padlock.ko only as a module

on a kernel without module support, it will effectivly be disabled. And if it is so simple to do the same in userspace like you suggest, than that's much better. Best Regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: init's children list is long and slows reaping children.

.g. I don't want to mlseep() twice on the same reset timeout). But we usually use locking to order that. Do I miss anything fundamental here? Regards Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Mo

Re: init's children list is long and slows reaping children.

driver/subsystem to actually queue work into a thread. And when there is a close(), socket-destruction, service completion or whatever these threads can be marked for destruction and destroyed by a timer or even immediately. Regards Ingo Oeser -- If something is getting cheap, it is getting waste

Re: init's children list is long and slows reaping children.

to actually queue work into a thread. And when there is a close(), socket-destruction, service completion or whatever these threads can be marked for destruction and destroyed by a timer or even immediately. Regards Ingo Oeser -- If something is getting cheap, it is getting wasted just

Re: init's children list is long and slows reaping children.

to mlseep() twice on the same reset timeout). But we usually use locking to order that. Do I miss anything fundamental here? Regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: getting processor numbers

these counters quiete easy, since most of them are the hamming weight (or population count) of some bitmaps. Does this sound like a proper hacky solution? :-) Regards Ingo Oeser pgpeUyaLE4v0G.pgp Description: PGP signature

Re: getting processor numbers

are the hamming weight (or population count) of some bitmaps. Does this sound like a proper hacky solution? :-) Regards Ingo Oeser pgpeUyaLE4v0G.pgp Description: PGP signature

Re: [PATCH] sysctl: vfs_cache_divisor

Hi Randy, On Monday 19 March 2007, Randy Dunlap wrote: > Were there any patches written after this? If so, I missed them. > If not, does this patch help any? How is division by zero avoided? Maybe one can avoid setting it to zero. Regards Ingo Oeser - To unsubscribe from this list

Re: [PATCH] sysctl: vfs_cache_divisor

Hi Randy, On Monday 19 March 2007, Randy Dunlap wrote: Were there any patches written after this? If so, I missed them. If not, does this patch help any? How is division by zero avoided? Maybe one can avoid setting it to zero. Regards Ingo Oeser - To unsubscribe from this list: send

Re: [patch 0/2] semaphores: add down_interruptible_timeout() and asm-generic/semaphore.h

hores aren't good "busy/ready flags", as you might have already noticed. Many Thanks and Best Regards Ingo Oeser, the down{_interruptible,}_timeout() implementation of Linux :-) - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message t

Re: [patch 0/2] semaphores: add down_interruptible_timeout() and asm-generic/semaphore.h

Ingo Oeser, the down{_interruptible,}_timeout() implementation of Linux :-) - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http

Re: [patch 1/1] MM: detach_vmas_to_be_unmapped fix

>vm_end : mm->mmap_base; > mm->unmap_area(mm, addr); > mm->mmap_cache = NULL; /* Kill the cache. */ > } Please comment, why you think this is necessary. Thanks & Regards Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux

Re: [patch 1/1] MM: detach_vmas_to_be_unmapped fix

. */ } Please comment, why you think this is necessary. Thanks Regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ

Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error

On Monday, 5. February 2007, Linus Torvalds wrote: > So thank God for the few selects we have, and we should add a whole lot > more! But "select" is not fine grained enough. I would like to have "require", "recommend", "suggest" for feature A. require X does not work without X, but X

Re: [patch] MTD: fix DOC2000/2001/2001PLUS build error

On Monday, 5. February 2007, Linus Torvalds wrote: So thank God for the few selects we have, and we should add a whole lot more! But select is not fine grained enough. I would like to have require, recommend, suggest for feature A. require X does not work without X, but X is way down

Re: [PATCH -mm 3/10][RFC] aio: use iov_length instead of ki_left

unsigned long seg_limit; size_t nr_bytes; }; That will enable resizeable iodescs with partial completion state and will enable successive filling of an iodesc with iovs. This will be needed anyway. I built an complete short userspace module for that already. I can post an

Re: [PATCH 31/59] sysctl: C99 convert the ctl_tables in arch/mips/au1000/common/power.c

.data = NULL, > + .maxlen = 0, > + .mode = 0600, > + .proc_handler = _do_freq > + }, > + {} > }; dito Regards Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux-kernel&qu

Re: [PATCH 45/59] sysctl: C99 convert ctl_tables in drivers/parport/procfs.c

, > + .procname = "autoprobe0", > + .data = NULL, > + .maxlen = 0, > + .maxlen = 0444, > + .proc_handler = _autoprobe > + }, Typo here?

Re: [PATCH -mm 3/10][RFC] aio: use iov_length instead of ki_left

completion state and will enable successive filling of an iodesc with iovs. This will be needed anyway. I built an complete short userspace module for that already. I can post and GPLv2 it somewhere, if people are interested. Regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 45/59] sysctl: C99 convert ctl_tables in drivers/parport/procfs.c

= NULL, + .maxlen = 0, + .maxlen = 0444, + .proc_handler = do_autoprobe + }, Typo here? .mode = 0444 makes mor sense. Regards Ingo Oeser - To unsubscribe from this list: send the line

Re: [PATCH 31/59] sysctl: C99 convert the ctl_tables in arch/mips/au1000/common/power.c

= pm_do_freq + }, + {} }; dito Regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] [DISCUSS] Make the variable NULL after freeing it.

On Monday, 1. January 2007 17:25, Andreas Schwab wrote: > Ingo Oeser <[EMAIL PROTECTED]> writes: > > Then this works, because the side effect (+20) is evaluated only once. > > It's not a side effect, it's a non-lvalue, and you can't take the address > of a non-lvalue.

Re: [PATCH] [DISCUSS] Make the variable NULL after freeing it.

Hi, On Monday, 1. January 2007 07:37, Amit Choudhary wrote: > --- Ingo Oeser <[EMAIL PROTECTED]> wrote: > > #define kfree_nullify(x) do { \ > > if (__builtin_constant_p(x)) { \ > > kfree(x); \ > > } else { \ > > typeof

Re: [PATCH] [DISCUSS] Make the variable NULL after freeing it.

Hi, On Monday, 1. January 2007 07:37, Amit Choudhary wrote: --- Ingo Oeser [EMAIL PROTECTED] wrote: #define kfree_nullify(x) do { \ if (__builtin_constant_p(x)) { \ kfree(x); \ } else { \ typeof(x) *__addr_x = x; \ Ok, I should change that line

Re: [PATCH] [DISCUSS] Make the variable NULL after freeing it.

On Monday, 1. January 2007 17:25, Andreas Schwab wrote: Ingo Oeser [EMAIL PROTECTED] writes: Then this works, because the side effect (+20) is evaluated only once. It's not a side effect, it's a non-lvalue, and you can't take the address of a non-lvalue. Just verified this. So If we

Re: [PATCH] [DISCUSS] Make the variable NULL after freeing it.

#define kfree_nullify(x) do { \ if (__builtin_constant_p(x)) { \ kfree(x); \ } else { \ typeof(x) *__addr_x = \ kfree(*__addr_x); \ *__addr_x = NULL; \ } \ } while (0) Regards Ingo Oeser - To unsubscribe from this lis

Re: [PATCH 4/8] KVM: Implement a few system configuration msrs

case MSR_IA32_P5_MC_TYPE: > case MSR_IA32_MC0_CTL: What about just defining constants for these? Then you can rip out these comments. Same for linux-2.6/drivers/kvm/vmx.c Regards Ingo Oeser - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

Re: [PATCH 4/8] KVM: Implement a few system configuration msrs

MSR_IA32_MC0_CTL: What about just defining constants for these? Then you can rip out these comments. Same for linux-2.6/drivers/kvm/vmx.c Regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More majordomo info at http

Re: [PATCH] [DISCUSS] Make the variable NULL after freeing it.

{ \ if (__builtin_constant_p(x)) { \ kfree(x); \ } else { \ typeof(x) *__addr_x = x; \ kfree(*__addr_x); \ *__addr_x = NULL; \ } \ } while (0) Regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux

Re: [PATCH 009 of 14] knfsd: SUNRPC: teach svc_sendto() to deal with IPv6 addresses

PV6) || defined(CONFIG_IPV6_MODULE) > + case AF_INET6: > + do { > + struct in6_pktinfo *pki = > + (struct in6_pktinfo *) CMSG_DATA(cmh); > + No casting needed, so: struct in6_pktinfo *pki = CMSG

Re: [PATCH 2.6.19] e1000: replace kmalloc with kzalloc

et rid of it? (Seems to apply to other places as well.) Because if done properly that often exceeds the 80 column limit. The intermediate variable should be optimized away from the compiler. But kcalloc() is better for another reason: Overflow checking. Regards Ingo Oeser - To unsubscribe from this

Re: [PATCH 2.6.19] e1000: replace kmalloc with kzalloc

exceeds the 80 column limit. The intermediate variable should be optimized away from the compiler. But kcalloc() is better for another reason: Overflow checking. Regards Ingo Oeser - To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL PROTECTED] More

  1   2   3   4   5   >