Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

2017-07-28 Thread Iyappan Subramanian
rived. Always abort if the clock is missing on > * DT system as the driver can't cope with this case. > > -- Thanks for the patch. Acked-by: Iyappan Subramanian <isubraman...@apm.com> > Crap can work. Given enough thrust pigs will fly, but it's not necessarily a > good idea.[ RFC1925, 2.3 ]

Re: [PATCH net] xgene: Don't fail probe, if there is no clk resource for SGMII interfaces

2017-07-28 Thread Iyappan Subramanian
data->clk = devm_clk_get(>dev, NULL); > + if (IS_ERR(pdata->clk)) { > + if (pdata->phy_mode != PHY_INTERFACE_MODE_SGMII) { > /* Abort if the clock is defined but couldn't be > * retrived. Always abort if the clock is miss

Re: [PATCH] drivers: net: xgene: Fix crash on DT systems

2017-02-28 Thread Iyappan Subramanian
irmware may have set up the clock already. */ > dev_info(dev, "clocks have been setup already\n"); > } > -- > 2.11.0 > Thanks, Alban. Acked-by: Iyappan Subramanian <isubraman...@apm.com>

Re: [PATCH] drivers: net: xgene: Fix crash on DT systems

2017-02-28 Thread Iyappan Subramanian
with this case. > +*/ > + if (PTR_ERR(pdata->clk) != -ENOENT || dev->of_node) > + return PTR_ERR(pdata->clk); > /* Firmware may have set up the clock already. */ > dev_info(dev, "clocks have been setup already\n"); > } > -- > 2.11.0 > Thanks, Alban. Acked-by: Iyappan Subramanian

Re: [PATCH] drivers: net: xgene: Simplify xgene_enet_setup_mss() to kill warning

2017-02-24 Thread Iyappan Subramanian
> pdata->mss[i] = mss; > mss_index = i; > - mss_index_found = true; > } > } > > - /* No slots with ref_count = 0 available, return busy */ > - if (!mss_index_found) > - mss_index = -EBUSY; > - > spin_unlock(>mss_lock); > > return mss_index; > -- > 2.7.4 > Thanks. Acked-by: Iyappan Subramanian <isubraman...@apm.com>

Re: [PATCH] drivers: net: xgene: Simplify xgene_enet_setup_mss() to kill warning

2017-02-24 Thread Iyappan Subramanian
mss_index = i; > - mss_index_found = true; > } > } > > - /* No slots with ref_count = 0 available, return busy */ > - if (!mss_index_found) > - mss_index = -EBUSY; > - > spin_unlock(>mss_lock); > > return mss_index; > -- > 2.7.4 > Thanks. Acked-by: Iyappan Subramanian

Re: [PATCH] drivers: net: xgene: initialize slots

2016-12-08 Thread Iyappan Subramanian
On Thu, Dec 8, 2016 at 3:17 AM, Colin King wrote: > From: Colin Ian King > > static analysis using cppcheck detected that slots was uninitialized. > Fix this by initializing it to buf_pool->slots - 1 > > Found using static analysis with

Re: [PATCH] drivers: net: xgene: initialize slots

2016-12-08 Thread Iyappan Subramanian
On Thu, Dec 8, 2016 at 3:17 AM, Colin King wrote: > From: Colin Ian King > > static analysis using cppcheck detected that slots was uninitialized. > Fix this by initializing it to buf_pool->slots - 1 > > Found using static analysis with CoverityScan, CID #1387620 > > Fixes: a9380b0f7be818

Re: [patch] drivers: net: xgene: uninitialized variable in xgene_enet_free_pagepool()

2016-12-07 Thread Iyappan Subramanian
slots = buf_pool->slots - 1; > head = buf_pool->head; > > for (i = 0; i < 4; i++) { Thanks. Acked-by: Iyappan Subramanian <isubraman...@apm.com>

Re: [patch] drivers: net: xgene: uninitialized variable in xgene_enet_free_pagepool()

2016-12-07 Thread Iyappan Subramanian
net/ethernet/apm/xgene/xgene_enet_main.c > @@ -635,6 +635,7 @@ static void xgene_enet_free_pagepool(struct > xgene_enet_desc_ring *buf_pool, > return; > > dev = ndev_to_dev(buf_pool->ndev); > + slots = buf_pool->slots - 1; > head = buf_pool->head; > > for (i = 0; i < 4; i++) { Thanks. Acked-by: Iyappan Subramanian

Re: linux-next: build warning after merge of the net-next tree

2016-07-27 Thread Iyappan Subramanian
On Tue, Jul 26, 2016 at 11:35 PM, Stephen Rothwell wrote: > Hi David, > > On Tue, 26 Jul 2016 23:19:59 -0700 (PDT) David Miller > wrote: >> >> Fixed thusly: >> >> >> From 36232012344b8db67052432742deaf17f82e70e6 Mon Sep 17

Re: linux-next: build warning after merge of the net-next tree

2016-07-27 Thread Iyappan Subramanian
On Tue, Jul 26, 2016 at 11:35 PM, Stephen Rothwell wrote: > Hi David, > > On Tue, 26 Jul 2016 23:19:59 -0700 (PDT) David Miller > wrote: >> >> Fixed thusly: >> >> >> From 36232012344b8db67052432742deaf17f82e70e6 Mon Sep 17 00:00:00 2001 >> From: "David S. Miller" >> Date:

Re: [PATCH] drivers: net: xgene: constify xgene_cle_ops structure

2016-05-01 Thread Iyappan Subramanian
struct xgene_ring_ops *ring_ops; > - struct xgene_cle_ops *cle_ops; > + const struct xgene_cle_ops *cle_ops; > struct delayed_work link_work; > u32 port_id; > u8 cpu_bufnum; > Thanks Julia. Acked-by: Iyappan Subramanian <isubraman...@apm.com>

Re: [PATCH] drivers: net: xgene: constify xgene_cle_ops structure

2016-05-01 Thread Iyappan Subramanian
struct xgene_cle_ops *cle_ops; > + const struct xgene_cle_ops *cle_ops; > struct delayed_work link_work; > u32 port_id; > u8 cpu_bufnum; > Thanks Julia. Acked-by: Iyappan Subramanian

Re: [PATCH net] drivers: net: xgene: fix possible use after free

2015-11-27 Thread Iyappan Subramanian
: Mark Rutland > Tested-by: Mark Rutland > Cc: Iyappan Subramanian > --- > drivers/net/ethernet/apm/xgene/xgene_enet_main.c |2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/net/ethernet/apm/xgene/xgene_enet_main.c > b/drivers/

Re: [PATCH net] drivers: net: xgene: fix possible use after free

2015-11-27 Thread Iyappan Subramanian
er. > > Signed-off-by: Eric Dumazet <eduma...@google.com> > Reported-by: Mark Rutland <mark.rutl...@arm.com> > Tested-by: Mark Rutland <mark.rutl...@arm.com> > Cc: Iyappan Subramanian <isubraman...@apm.com> > --- > drivers/net/ethernet/apm/xgene/x

[PATCH v2] drivers: net: xgene: fix: Out of order descriptor bytes read

2015-01-29 Thread Iyappan Subramanian
. We have to force the order of the reads and thus this patch introduces read memory barrier between these reads. Signed-off-by: Iyappan Subramanian Signed-off-by: Keyur Chudgar --- v2: Address comments from v1 * replaced smp_rmb() with dma_rmb() --- drivers/net/ethernet/apm/xgene

[PATCH v2] drivers: net: xgene: fix: Out of order descriptor bytes read

2015-01-29 Thread Iyappan Subramanian
reads in out of order fashion, then the bytes[7:0] will have older data and causing the kernel panic. We have to force the order of the reads and thus this patch introduces read memory barrier between these reads. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Keyur Chudgar

Re: [PATCH] drivers: net: xgene: fix: Out of order descriptor bytes read

2015-01-26 Thread Iyappan Subramanian
On Thu, Jan 22, 2015 at 2:50 PM, Eric Dumazet wrote: > On Thu, 2015-01-22 at 12:03 -0800, Iyappan Subramanian wrote: >> This patch fixes the following kernel crash, >> >> WARNING: CPU: 2 PID: 0 at net/ipv4/tcp_input.c:3079 >> tcp_clean_rtx_queue+0x658/

Re: [PATCH] drivers: net: xgene: fix: Out of order descriptor bytes read

2015-01-26 Thread Iyappan Subramanian
On Thu, Jan 22, 2015 at 2:50 PM, Eric Dumazet eric.duma...@gmail.com wrote: On Thu, 2015-01-22 at 12:03 -0800, Iyappan Subramanian wrote: This patch fixes the following kernel crash, WARNING: CPU: 2 PID: 0 at net/ipv4/tcp_input.c:3079 tcp_clean_rtx_queue+0x658/0x80c() Call trace

[PATCH] drivers: net: xgene: fix: Out of order descriptor bytes read

2015-01-22 Thread Iyappan Subramanian
. We have to force the order of the reads and thus this patch introduces read memory barrier between these reads. Signed-off-by: Iyappan Subramanian Signed-off-by: Keyur Chudgar Tested-by: Mark Langsdorf --- drivers/net/ethernet/apm/xgene/xgene_enet_main.c | 2 ++ 1 file changed, 2 insertions

[PATCH] drivers: net: xgene: fix: Out of order descriptor bytes read

2015-01-22 Thread Iyappan Subramanian
reads in out of order fashion, then the bytes[7:0] will have older data and causing the kernel panic. We have to force the order of the reads and thus this patch introduces read memory barrier between these reads. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Keyur Chudgar

Re: [PATCH] drivers: net: xgene: Add missing initialization in xgene_enet_ecc_init()

2014-10-20 Thread Iyappan Subramanian
xgene_enet_wr_diag_csr(p, ENET_CFG_MEM_RAM_SHUTDOWN_ADDR, 0); > -- > 1.9.1 > Acked-by: Iyappan Subramanian -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] drivers: net: xgene: Add missing initialization in xgene_enet_ecc_init()

2014-10-20 Thread Iyappan Subramanian
Acked-by: Iyappan Subramanian isubraman...@apm.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH v10 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver

2014-08-07 Thread Iyappan Subramanian
This patch adds documentation for APM X-Gene SoC ethernet DTS binding. Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- .../devicetree/bindings/net/apm-xgene-enet.txt | 66 ++ 1 file changed, 66 insertions(+) create mode

[PATCH v10 3/4] dts: Add bindings for APM X-Gene SoC ethernet driver

2014-08-07 Thread Iyappan Subramanian
This patch adds bindings for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- arch/arm64/boot/dts/apm-mustang.dts | 4 arch/arm64/boot/dts/apm-storm.dtsi | 30 +++--- 2 files changed

[PATCH v10 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-08-07 Thread Iyappan Subramanian
This patch adds network driver for APM X-Gene SoC ethernet. Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar Signed-off-by: Dean Nelson --- drivers/net/ethernet/Kconfig | 1 + drivers/net/ethernet/Makefile

[PATCH v10 1/4] MAINTAINERS: Add entry for APM X-Gene SoC ethernet driver

2014-08-07 Thread Iyappan Subramanian
This patch adds a MAINTAINERS entry for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 05e5450..e8ac352 100644

[PATCH v10 0/4] net: Add APM X-Gene SoC Ethernet driver support

2014-08-07 Thread Iyappan Subramanian
th8clk entry to menetclk v1 * Initial version Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- Iyappan Subramanian (4): MAINTAINERS: Add entry for APM X-Gene SoC ethernet driver Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver

Re: [PATCH v9 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-08-07 Thread Iyappan Subramanian
On Tue, Jul 15, 2014 at 12:48 AM, Tobias Klauser wrote: > On 2014-07-15 at 00:18:05 +0200, Iyappan Subramanian > wrote: >> This patch adds network driver for APM X-Gene SoC ethernet. >> >> Signed-off-by: Iyappan Subramanian >> Signed-off-by: Ravi Patel &

Re: [PATCH v9 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-08-07 Thread Iyappan Subramanian
On Mon, Jul 14, 2014 at 11:09 PM, Varka Bhadram wrote: > On 07/15/2014 03:48 AM, Iyappan Subramanian wrote: > > (...) > > +static void xgene_enet_rd_mcx_mac(struct xgene_enet_pdata *pdata, > + u32 rd_addr, u32 *rd_data) > +{ > + void __iomem *addr, *rd, *cmd,

Re: [PATCH v9 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver

2014-08-07 Thread Iyappan Subramanian
On Mon, Jul 14, 2014 at 10:45 PM, Varka Bhadram wrote: > On 07/15/2014 03:48 AM, Iyappan Subramanian wrote: >> >> This patch adds documentation for APM X-Gene SoC ethernet DTS binding. >> >> Signed-off-by: Iyappan Subramanian >> Signed-off-by: Ravi Patel

Re: [PATCH v9 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver

2014-08-07 Thread Iyappan Subramanian
On Mon, Jul 14, 2014 at 10:45 PM, Varka Bhadram varkabhad...@gmail.com wrote: On 07/15/2014 03:48 AM, Iyappan Subramanian wrote: This patch adds documentation for APM X-Gene SoC ethernet DTS binding. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa

Re: [PATCH v9 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-08-07 Thread Iyappan Subramanian
On Mon, Jul 14, 2014 at 11:09 PM, Varka Bhadram varkabhad...@gmail.com wrote: On 07/15/2014 03:48 AM, Iyappan Subramanian wrote: (...) +static void xgene_enet_rd_mcx_mac(struct xgene_enet_pdata *pdata, + u32 rd_addr, u32 *rd_data) +{ + void __iomem *addr, *rd, *cmd, *cmd_done; + bool ret

Re: [PATCH v9 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-08-07 Thread Iyappan Subramanian
On Tue, Jul 15, 2014 at 12:48 AM, Tobias Klauser tklau...@distanz.ch wrote: On 2014-07-15 at 00:18:05 +0200, Iyappan Subramanian isubraman...@apm.com wrote: This patch adds network driver for APM X-Gene SoC ethernet. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off

[PATCH v10 0/4] net: Add APM X-Gene SoC Ethernet driver support

2014-08-07 Thread Iyappan Subramanian
entry to menetclk v1 * Initial version Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com --- Iyappan Subramanian (4): MAINTAINERS: Add entry for APM X-Gene SoC ethernet driver Documentation: dts: Add

[PATCH v10 1/4] MAINTAINERS: Add entry for APM X-Gene SoC ethernet driver

2014-08-07 Thread Iyappan Subramanian
This patch adds a MAINTAINERS entry for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v10 3/4] dts: Add bindings for APM X-Gene SoC ethernet driver

2014-08-07 Thread Iyappan Subramanian
This patch adds bindings for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com --- arch/arm64/boot/dts/apm-mustang.dts | 4 arch/arm64/boot/dts/apm-storm.dtsi | 30

[PATCH v10 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-08-07 Thread Iyappan Subramanian
This patch adds network driver for APM X-Gene SoC ethernet. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com Signed-off-by: Dean Nelson dnel...@redhat.com --- drivers/net/ethernet/Kconfig

[PATCH v10 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver

2014-08-07 Thread Iyappan Subramanian
This patch adds documentation for APM X-Gene SoC ethernet DTS binding. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com --- .../devicetree/bindings/net/apm-xgene-enet.txt | 66

[PATCH v9 3/4] dts: Add bindings for APM X-Gene SoC ethernet driver

2014-07-14 Thread Iyappan Subramanian
This patch adds bindings for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- arch/arm64/boot/dts/apm-mustang.dts | 4 arch/arm64/boot/dts/apm-storm.dtsi | 30 +++--- 2 files changed

[PATCH v9 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver

2014-07-14 Thread Iyappan Subramanian
This patch adds documentation for APM X-Gene SoC ethernet DTS binding. Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- .../devicetree/bindings/net/apm-xgene-enet.txt | 72 ++ 1 file changed, 72 insertions(+) create mode

[PATCH v9 0/4] net: Add APM X-Gene SoC Ethernet driver support

2014-07-14 Thread Iyappan Subramanian
ed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- Iyappan Subramanian (4): MAINTAINERS: Add entry for APM X-Gene SoC ethernet driver Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver dts: Add bindings for APM X-Gene SoC ethernet driver d

[PATCH v9 1/4] MAINTAINERS: Add entry for APM X-Gene SoC ethernet driver

2014-07-14 Thread Iyappan Subramanian
This patch adds a MAINTAINERS entry for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5eede71..3af4f67 100644

[PATCH v9 0/4] net: Add APM X-Gene SoC Ethernet driver support

2014-07-14 Thread Iyappan Subramanian
-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com --- Iyappan Subramanian (4): MAINTAINERS: Add entry for APM X-Gene SoC ethernet driver Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver dts: Add

[PATCH v9 1/4] MAINTAINERS: Add entry for APM X-Gene SoC ethernet driver

2014-07-14 Thread Iyappan Subramanian
This patch adds a MAINTAINERS entry for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v9 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver

2014-07-14 Thread Iyappan Subramanian
This patch adds documentation for APM X-Gene SoC ethernet DTS binding. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com --- .../devicetree/bindings/net/apm-xgene-enet.txt | 72

[PATCH v9 3/4] dts: Add bindings for APM X-Gene SoC ethernet driver

2014-07-14 Thread Iyappan Subramanian
This patch adds bindings for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com --- arch/arm64/boot/dts/apm-mustang.dts | 4 arch/arm64/boot/dts/apm-storm.dtsi | 30

Re: [PATCH v8 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-07-09 Thread Iyappan Subramanian
On Wed, Jun 25, 2014 at 4:04 PM, Russell King - ARM Linux wrote: > On Tue, Jun 24, 2014 at 10:29:48PM -0600, Dann Frazier wrote: >> On Fri, Jun 20, 2014 at 5:18 PM, Iyappan Subramanian >> wrote: >> > + ring->desc_addr = dma_zall

Re: [PATCH v8 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-07-09 Thread Iyappan Subramanian
On Tue, Jun 24, 2014 at 10:34 PM, David Miller wrote: > From: Iyappan Subramanian > Date: Fri, 20 Jun 2014 16:18:16 -0700 > >> This patch adds network driver for APM X-Gene SoC ethernet. >> >> Signed-off-by: Iyappan Subramanian >> Signed-off-by: Ravi Patel

Re: [PATCH v8 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-07-09 Thread Iyappan Subramanian
On Tue, Jun 24, 2014 at 10:34 PM, David Miller da...@davemloft.net wrote: From: Iyappan Subramanian isubraman...@apm.com Date: Fri, 20 Jun 2014 16:18:16 -0700 This patch adds network driver for APM X-Gene SoC ethernet. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off

Re: [PATCH v8 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-07-09 Thread Iyappan Subramanian
On Wed, Jun 25, 2014 at 4:04 PM, Russell King - ARM Linux li...@arm.linux.org.uk wrote: On Tue, Jun 24, 2014 at 10:29:48PM -0600, Dann Frazier wrote: On Fri, Jun 20, 2014 at 5:18 PM, Iyappan Subramanian isubraman...@apm.com wrote: + ring-desc_addr = dma_zalloc_coherent(dev, size, ring

[PATCH v8 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver

2014-06-20 Thread Iyappan Subramanian
This patch adds documentation for APM X-Gene SoC ethernet DTS binding. Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- .../devicetree/bindings/net/apm-xgene-enet.txt | 72 ++ 1 file changed, 72 insertions(+) create mode

[PATCH v8 0/4] net: Add APM X-Gene SoC Ethernet driver support

2014-06-20 Thread Iyappan Subramanian
ef v2 * Completely redesigned ethernet driver * Added support to work with big endian kernel * Renamed dtb phyid entry to phy_addr * Changed dtb local-mac-address entry to byte string format * Renamed dtb eth8clk entry to menetclk v1 * Initial version Signed-off-by: Iyappan Subramanian Signed-off-by

[PATCH v8 1/4] MAINTAINERS: Add entry for APM X-Gene SoC ethernet driver

2014-06-20 Thread Iyappan Subramanian
This patch adds a MAINTAINERS entry for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 134483f..d65a3be 100644

[PATCH v8 3/4] dts: Add bindings for APM X-Gene SoC ethernet driver

2014-06-20 Thread Iyappan Subramanian
This patch adds bindings for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- arch/arm64/boot/dts/apm-mustang.dts | 4 arch/arm64/boot/dts/apm-storm.dtsi | 30 +++--- 2 files changed

[PATCH v8 3/4] dts: Add bindings for APM X-Gene SoC ethernet driver

2014-06-20 Thread Iyappan Subramanian
This patch adds bindings for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com --- arch/arm64/boot/dts/apm-mustang.dts | 4 arch/arm64/boot/dts/apm-storm.dtsi | 30

[PATCH v8 0/4] net: Add APM X-Gene SoC Ethernet driver support

2014-06-20 Thread Iyappan Subramanian
* Completely redesigned ethernet driver * Added support to work with big endian kernel * Renamed dtb phyid entry to phy_addr * Changed dtb local-mac-address entry to byte string format * Renamed dtb eth8clk entry to menetclk v1 * Initial version Signed-off-by: Iyappan Subramanian isubraman...@apm.com

[PATCH v8 1/4] MAINTAINERS: Add entry for APM X-Gene SoC ethernet driver

2014-06-20 Thread Iyappan Subramanian
This patch adds a MAINTAINERS entry for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v8 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver

2014-06-20 Thread Iyappan Subramanian
This patch adds documentation for APM X-Gene SoC ethernet DTS binding. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com --- .../devicetree/bindings/net/apm-xgene-enet.txt | 72

Re: [PATCH v7 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-06-19 Thread Iyappan Subramanian
On Thu, Jun 19, 2014 at 1:46 AM, Ming Lei wrote: > On Thu, Jun 19, 2014 at 9:17 AM, Iyappan Subramanian > wrote: >> This patch adds network driver for APM X-Gene SoC ethernet. >> >> Signed-off-by: Iyappan Subramanian >> Signed-off-by: Ravi Patel &

Re: [PATCH v7 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-06-19 Thread Iyappan Subramanian
On Thu, Jun 19, 2014 at 1:46 AM, Ming Lei tom.leim...@gmail.com wrote: On Thu, Jun 19, 2014 at 9:17 AM, Iyappan Subramanian isubraman...@apm.com wrote: This patch adds network driver for APM X-Gene SoC ethernet. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi

[PATCH v7 0/4] net: Add APM X-Gene SoC Ethernet driver support

2014-06-18 Thread Iyappan Subramanian
ed dtb phyid entry to phy_addr * Changed dtb local-mac-address entry to byte string format * Renamed dtb eth8clk entry to menetclk v1 * Initial version Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- Iyappan Subramanian (4): MAINTAINERS: Add entry for

[PATCH v7 1/4] MAINTAINERS: Add entry for APM X-Gene SoC ethernet driver

2014-06-18 Thread Iyappan Subramanian
This patch adds a MAINTAINERS entry for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 134483f..d65a3be 100644

[PATCH v7 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver

2014-06-18 Thread Iyappan Subramanian
This patch adds documentation for APM X-Gene SoC ethernet DTS binding. Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- .../devicetree/bindings/net/apm-xgene-enet.txt | 72 ++ 1 file changed, 72 insertions(+) create mode

[PATCH v7 3/4] dts: Add bindings for APM X-Gene SoC ethernet driver

2014-06-18 Thread Iyappan Subramanian
This patch adds bindings for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- arch/arm64/boot/dts/apm-mustang.dts | 4 arch/arm64/boot/dts/apm-storm.dtsi | 30 +++--- 2 files changed

Re: [PATCH v6 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-06-18 Thread Iyappan Subramanian
On Tue, Jun 17, 2014 at 1:20 PM, David Miller wrote: > From: Iyappan Subramanian > Date: Tue, 17 Jun 2014 12:21:08 -0700 > >> On Mon, Jun 16, 2014 at 9:42 PM, David Miller wrote: >>> From: Iyappan Subramanian >>> Date: Mon, 16 Jun 2014 17:18:46 -

Re: [PATCH v6 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-06-18 Thread Iyappan Subramanian
On Tue, Jun 17, 2014 at 1:20 PM, David Miller da...@davemloft.net wrote: From: Iyappan Subramanian isubraman...@apm.com Date: Tue, 17 Jun 2014 12:21:08 -0700 On Mon, Jun 16, 2014 at 9:42 PM, David Miller da...@davemloft.net wrote: From: Iyappan Subramanian isubraman...@apm.com Date: Mon, 16

[PATCH v7 3/4] dts: Add bindings for APM X-Gene SoC ethernet driver

2014-06-18 Thread Iyappan Subramanian
This patch adds bindings for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com --- arch/arm64/boot/dts/apm-mustang.dts | 4 arch/arm64/boot/dts/apm-storm.dtsi | 30

[PATCH v7 0/4] net: Add APM X-Gene SoC Ethernet driver support

2014-06-18 Thread Iyappan Subramanian
entry to phy_addr * Changed dtb local-mac-address entry to byte string format * Renamed dtb eth8clk entry to menetclk v1 * Initial version Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com --- Iyappan

[PATCH v7 1/4] MAINTAINERS: Add entry for APM X-Gene SoC ethernet driver

2014-06-18 Thread Iyappan Subramanian
This patch adds a MAINTAINERS entry for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v7 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver

2014-06-18 Thread Iyappan Subramanian
This patch adds documentation for APM X-Gene SoC ethernet DTS binding. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com --- .../devicetree/bindings/net/apm-xgene-enet.txt | 72

Re: [PATCH v6 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-06-17 Thread Iyappan Subramanian
On Tue, Jun 17, 2014 at 12:24 PM, Florian Fainelli wrote: > 2014-06-17 12:21 GMT-07:00 Iyappan Subramanian : >> On Mon, Jun 16, 2014 at 9:42 PM, David Miller wrote: >>> From: Iyappan Subramanian >>> Date: Mon, 16 Jun 2014 17:18:46 -0700 >>> >>>>

Re: [PATCH v6 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-06-17 Thread Iyappan Subramanian
On Mon, Jun 16, 2014 at 9:42 PM, David Miller wrote: > From: Iyappan Subramanian > Date: Mon, 16 Jun 2014 17:18:46 -0700 > >> +static netdev_tx_t xgene_enet_start_xmit(struct sk_buff *skb, >> + struct net_device *ndev) >> +{ >&

Re: [PATCH v6 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-06-17 Thread Iyappan Subramanian
On Mon, Jun 16, 2014 at 9:42 PM, David Miller da...@davemloft.net wrote: From: Iyappan Subramanian isubraman...@apm.com Date: Mon, 16 Jun 2014 17:18:46 -0700 +static netdev_tx_t xgene_enet_start_xmit(struct sk_buff *skb, + struct net_device *ndev

Re: [PATCH v6 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-06-17 Thread Iyappan Subramanian
On Tue, Jun 17, 2014 at 12:24 PM, Florian Fainelli f.faine...@gmail.com wrote: 2014-06-17 12:21 GMT-07:00 Iyappan Subramanian isubraman...@apm.com: On Mon, Jun 16, 2014 at 9:42 PM, David Miller da...@davemloft.net wrote: From: Iyappan Subramanian isubraman...@apm.com Date: Mon, 16 Jun 2014 17

[PATCH v6 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver

2014-06-16 Thread Iyappan Subramanian
This patch adds documentation for APM X-Gene SoC ethernet DTS binding. Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- .../devicetree/bindings/net/apm-xgene-enet.txt | 72 ++ 1 file changed, 72 insertions(+) create mode

[PATCH v6 0/4] net: Add APM X-Gene SoC Ethernet driver support

2014-06-16 Thread Iyappan Subramanian
ed dtb eth8clk entry to menetclk v1 * Initial version Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- Iyappan Subramanian (4): MAINTAINERS: Add entry for APM X-Gene SoC ethernet driver Documentation: dts: Add bindings for APM X-Gene SoC ethernet

[PATCH v6 3/4] dts: Add bindings for APM X-Gene SoC ethernet driver

2014-06-16 Thread Iyappan Subramanian
This patch adds bindings for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- arch/arm64/boot/dts/apm-mustang.dts | 4 arch/arm64/boot/dts/apm-storm.dtsi | 30 +++--- 2 files changed

[PATCH v6 1/4] MAINTAINERS: Add entry for APM X-Gene SoC ethernet driver

2014-06-16 Thread Iyappan Subramanian
This patch adds a MAINTAINERS entry for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 134483f..d65a3be 100644

[PATCH v6 3/4] dts: Add bindings for APM X-Gene SoC ethernet driver

2014-06-16 Thread Iyappan Subramanian
This patch adds bindings for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com --- arch/arm64/boot/dts/apm-mustang.dts | 4 arch/arm64/boot/dts/apm-storm.dtsi | 30

[PATCH v6 1/4] MAINTAINERS: Add entry for APM X-Gene SoC ethernet driver

2014-06-16 Thread Iyappan Subramanian
This patch adds a MAINTAINERS entry for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git

[PATCH v6 0/4] net: Add APM X-Gene SoC Ethernet driver support

2014-06-16 Thread Iyappan Subramanian
eth8clk entry to menetclk v1 * Initial version Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com --- Iyappan Subramanian (4): MAINTAINERS: Add entry for APM X-Gene SoC ethernet driver Documentation: dts

[PATCH v6 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver

2014-06-16 Thread Iyappan Subramanian
This patch adds documentation for APM X-Gene SoC ethernet DTS binding. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com --- .../devicetree/bindings/net/apm-xgene-enet.txt | 72

Re: [PATCH v5 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-06-11 Thread Iyappan Subramanian
On Thu, Jun 5, 2014 at 12:45 AM, David Miller wrote: > From: Iyappan Subramanian > Date: Mon, 2 Jun 2014 12:39:14 -0700 > >> + netdev_err(ndev, "LERR: %d ring_num: %d ", status, ring->num); >> + switch (status) { >> + case HBF_READ_DATA: >

Re: [PATCH v5 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-06-11 Thread Iyappan Subramanian
On Thu, Jun 5, 2014 at 12:45 AM, David Miller da...@davemloft.net wrote: From: Iyappan Subramanian isubraman...@apm.com Date: Mon, 2 Jun 2014 12:39:14 -0700 + netdev_err(ndev, LERR: %d ring_num: %d , status, ring-num); + switch (status) { + case HBF_READ_DATA

[PATCH v5 0/4] net: Add APM X-Gene SoC Ethernet driver support

2014-06-02 Thread Iyappan Subramanian
entry to phy_addr * Changed dtb local-mac-address entry to byte string format * Renamed dtb eth8clk entry to menetclk v1 * Initial version Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- *** BLURB HERE *** Iyappan Subramanian (4): MAINTAINERS: Add

[PATCH v5 1/4] MAINTAINERS: Add entry for APM X-Gene SoC ethernet driver

2014-06-02 Thread Iyappan Subramanian
This patch adds a MAINTAINERS entry for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- MAINTAINERS |8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index dd33abf..42ca1b9

[PATCH v5 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver

2014-06-02 Thread Iyappan Subramanian
This patch adds documentation for APM X-Gene SoC ethernet DTS binding. Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- .../devicetree/bindings/net/apm-xgene-enet.txt | 72 1 file changed, 72 insertions(+) create mode

[PATCH v5 3/4] dts: Add bindings for APM X-Gene SoC ethernet driver

2014-06-02 Thread Iyappan Subramanian
This patch adds bindings for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian Signed-off-by: Ravi Patel Signed-off-by: Keyur Chudgar --- arch/arm64/boot/dts/apm-mustang.dts |4 arch/arm64/boot/dts/apm-storm.dtsi | 30 +++--- 2 files

Re: [PATCH v4 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver

2014-06-02 Thread Iyappan Subramanian
On Mon, May 5, 2014 at 2:57 PM, Florian Fainelli wrote: > 2014-05-05 14:47 GMT-07:00 Iyappan Subramanian : >> This patch adds documentation for APM X-Gene SoC ethernet DTS binding. >> >> Signed-off-by: Iyappan Subramanian >> Signed-off-by: Ravi Patel >

Re: [PATCH v4 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver

2014-06-02 Thread Iyappan Subramanian
On Mon, May 5, 2014 at 2:57 PM, Florian Fainelli f.faine...@gmail.com wrote: 2014-05-05 14:47 GMT-07:00 Iyappan Subramanian isubraman...@apm.com: This patch adds documentation for APM X-Gene SoC ethernet DTS binding. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi

[PATCH v5 3/4] dts: Add bindings for APM X-Gene SoC ethernet driver

2014-06-02 Thread Iyappan Subramanian
This patch adds bindings for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com --- arch/arm64/boot/dts/apm-mustang.dts |4 arch/arm64/boot/dts/apm-storm.dtsi

[PATCH v5 2/4] Documentation: dts: Add bindings for APM X-Gene SoC ethernet driver

2014-06-02 Thread Iyappan Subramanian
This patch adds documentation for APM X-Gene SoC ethernet DTS binding. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com --- .../devicetree/bindings/net/apm-xgene-enet.txt | 72

[PATCH v5 1/4] MAINTAINERS: Add entry for APM X-Gene SoC ethernet driver

2014-06-02 Thread Iyappan Subramanian
This patch adds a MAINTAINERS entry for APM X-Gene SoC ethernet driver. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com --- MAINTAINERS |8 1 file changed, 8 insertions(+) diff --git

[PATCH v5 0/4] net: Add APM X-Gene SoC Ethernet driver support

2014-06-02 Thread Iyappan Subramanian
to phy_addr * Changed dtb local-mac-address entry to byte string format * Renamed dtb eth8clk entry to menetclk v1 * Initial version Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off-by: Keyur Chudgar kchud...@apm.com --- *** BLURB HERE

Re: [PATCH v4 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-05-29 Thread Iyappan Subramanian
On Mon, May 5, 2014 at 3:17 PM, Florian Fainelli wrote: > 2014-05-05 14:47 GMT-07:00 Iyappan Subramanian : >> This patch adds network driver for APM X-Gene SoC ethernet. >> >> Signed-off-by: Iyappan Subramanian >> Signed-off-by: Ravi Patel >> Signed-off-by: Keyu

Re: [PATCH v4 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-05-29 Thread Iyappan Subramanian
On Wed, May 14, 2014 at 8:18 AM, Dean Nelson wrote: > On 05/05/2014 04:47 PM, Iyappan Subramanian wrote: >> >> This patch adds network driver for APM X-Gene SoC ethernet. >> >> Signed-off-by: Iyappan Subramanian >> Signed-off-by: Ravi Patel >> Signed-off

Re: [PATCH v4 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-05-29 Thread Iyappan Subramanian
On Wed, May 14, 2014 at 8:18 AM, Dean Nelson dnel...@redhat.com wrote: On 05/05/2014 04:47 PM, Iyappan Subramanian wrote: This patch adds network driver for APM X-Gene SoC ethernet. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa...@apm.com Signed-off

Re: [PATCH v4 4/4] drivers: net: Add APM X-Gene SoC ethernet driver support.

2014-05-29 Thread Iyappan Subramanian
On Mon, May 5, 2014 at 3:17 PM, Florian Fainelli f.faine...@gmail.com wrote: 2014-05-05 14:47 GMT-07:00 Iyappan Subramanian isubraman...@apm.com: This patch adds network driver for APM X-Gene SoC ethernet. Signed-off-by: Iyappan Subramanian isubraman...@apm.com Signed-off-by: Ravi Patel rapa

  1   2   >