Re: [RESEND PATCH] MAINTAINERS: update thermal CPU cooling section

t;> > >>> Regards, > >>> Lukasz > >>> > >>>   MAINTAINERS | 2 +- > >>>   1 file changed, 1 insertion(+), 1 deletion(-) > >>> > >>> diff --git a/MAINTAINERS b/MAINTAINERS > >>> index f32ebcff37d2..f

Re: [PATCH] thermal: cpu_cooling: Actually trace CPU load in thermal_power_cpu_get_power

just remove the check. > > Fixes: 6828a4711f99 ("thermal: add trace events to the power allocator > governor") > Signed-off-by: Matthias Kaehlcke Yep, looks good to me. Acked-by: Javi Merino > --- > drivers/thermal/cpu_cooling.c | 2 +- > 1 file changed, 1

Re: [RFC PATCH 6/7] sched/fair: update cpu_capcity to reflect thermal pressure

On Tue, Oct 09, 2018 at 12:25:01PM -0400, Thara Gopinath wrote: > cpu_capacity relflects the maximum available capacity of a cpu. Thermal > pressure on a cpu means this maximum available capacity is reduced. This > patch reduces the average thermal pressure for a cpu from its maximum > available

Re: [RFC PATCH 6/7] sched/fair: update cpu_capcity to reflect thermal pressure

On Tue, Oct 09, 2018 at 12:25:01PM -0400, Thara Gopinath wrote: > cpu_capacity relflects the maximum available capacity of a cpu. Thermal > pressure on a cpu means this maximum available capacity is reduced. This > patch reduces the average thermal pressure for a cpu from its maximum > available

Re: [RFC PATCH 0/7] Introduce thermal pressure

On Tue, Oct 09, 2018 at 12:24:55PM -0400, Thara Gopinath wrote: > Thermal governors can respond to an overheat event for a cpu by > capping the cpu's maximum possible frequency. This in turn > means that the maximum available compute capacity of the > cpu is restricted. But today in linux kernel,

Re: [RFC PATCH 0/7] Introduce thermal pressure

On Tue, Oct 09, 2018 at 12:24:55PM -0400, Thara Gopinath wrote: > Thermal governors can respond to an overheat event for a cpu by > capping the cpu's maximum possible frequency. This in turn > means that the maximum available compute capacity of the > cpu is restricted. But today in linux kernel,

Re: [RFC PATCH v3 03/10] PM: Introduce an Energy Model management framework

On Fri, Jun 08, 2018 at 04:47:39PM +0100, Quentin Perret wrote: > Hi Javi, > > On Friday 08 Jun 2018 at 14:39:42 (+0100), Javi Merino wrote: > > On Wed, Jun 06, 2018 at 05:26:47PM +0100, Quentin Perret wrote: > > > On Wednesday 06 Jun 2018 at 16:29:50 (+010

Re: [RFC PATCH v3 03/10] PM: Introduce an Energy Model management framework

On Fri, Jun 08, 2018 at 04:47:39PM +0100, Quentin Perret wrote: > Hi Javi, > > On Friday 08 Jun 2018 at 14:39:42 (+0100), Javi Merino wrote: > > On Wed, Jun 06, 2018 at 05:26:47PM +0100, Quentin Perret wrote: > > > On Wednesday 06 Jun 2018 at 16:29:50 (+010

Re: [RFC PATCH v3 03/10] PM: Introduce an Energy Model management framework

On Thu, Jun 07, 2018 at 06:04:19PM +0200, Juri Lelli wrote: > On 07/06/18 16:19, Quentin Perret wrote: > > Hi Juri, > > > > On Thursday 07 Jun 2018 at 16:44:09 (+0200), Juri Lelli wrote: > > > On 21/05/18 15:24, Quentin Perret wrote: > > [...] > > > > > +static void fd_update_cs_table(struct

Re: [RFC PATCH v3 03/10] PM: Introduce an Energy Model management framework

On Thu, Jun 07, 2018 at 06:04:19PM +0200, Juri Lelli wrote: > On 07/06/18 16:19, Quentin Perret wrote: > > Hi Juri, > > > > On Thursday 07 Jun 2018 at 16:44:09 (+0200), Juri Lelli wrote: > > > On 21/05/18 15:24, Quentin Perret wrote: > > [...] > > > > > +static void fd_update_cs_table(struct

Re: [RFC PATCH v3 03/10] PM: Introduce an Energy Model management framework

On Wed, Jun 06, 2018 at 05:26:47PM +0100, Quentin Perret wrote: > On Wednesday 06 Jun 2018 at 16:29:50 (+0100), Quentin Perret wrote: > > On Wednesday 06 Jun 2018 at 17:20:00 (+0200), Juri Lelli wrote: > > > > > This brings me to another question. Let's say there are multiple > > > > > users of >

Re: [RFC PATCH v3 03/10] PM: Introduce an Energy Model management framework

On Wed, Jun 06, 2018 at 05:26:47PM +0100, Quentin Perret wrote: > On Wednesday 06 Jun 2018 at 16:29:50 (+0100), Quentin Perret wrote: > > On Wednesday 06 Jun 2018 at 17:20:00 (+0200), Juri Lelli wrote: > > > > > This brings me to another question. Let's say there are multiple > > > > > users of >

Re: [PATCH V2 4/4] cpu_cooling: Drop static-power related stuff

uot;thermal: cpu_cooling: implement the power cooling device API") also added documentation for it. You should remove the documentation, to keep it in sync. > Cc: Javi Merino <javi.mer...@arm.com> > Cc: Punit Agrawal <punit.agra...@arm.com> > Acked-by: Eduardo Valentin &

Re: [PATCH V2 4/4] cpu_cooling: Drop static-power related stuff

uot;thermal: cpu_cooling: implement the power cooling device API") also added documentation for it. You should remove the documentation, to keep it in sync. > Cc: Javi Merino > Cc: Punit Agrawal > Acked-by: Eduardo Valentin > Signed-off-by: Viresh Kumar >

Re: [PATCH 4/4] cpu_cooling: Drop static-power related stuff

Hi, On Tue, Nov 21, 2017 at 08:57:06AM -0800, Eduardo Valentin wrote: [snip] > As I said before, the minimal you guys (ARM and Linaro) can do is to at > least upstream the Juno code! as a reference. Come on guys? what is > preventing you to upstream Juno model? As Ionela pointed out earlier

Re: [PATCH 4/4] cpu_cooling: Drop static-power related stuff

Hi, On Tue, Nov 21, 2017 at 08:57:06AM -0800, Eduardo Valentin wrote: [snip] > As I said before, the minimal you guys (ARM and Linaro) can do is to at > least upstream the Juno code! as a reference. Come on guys? what is > preventing you to upstream Juno model? As Ionela pointed out earlier

Re: [PATCH 4/4] cpu_cooling: Drop static-power related stuff

On Wed, Nov 15, 2017 at 02:49:48PM +0530, Viresh Kumar wrote: > No one has used it for the last two and half years (since it was > introduced by commit c36cf0717631 ("thermal: cpu_cooling: implement the > power cooling device API")), get rid of it. Linaro used it in lsk 3.18 for the cpufreq

Re: [PATCH 4/4] cpu_cooling: Drop static-power related stuff

On Wed, Nov 15, 2017 at 02:49:48PM +0530, Viresh Kumar wrote: > No one has used it for the last two and half years (since it was > introduced by commit c36cf0717631 ("thermal: cpu_cooling: implement the > power cooling device API")), get rid of it. Linaro used it in lsk 3.18 for the cpufreq

Re: [PATCH] thermal: cpu_cooling: pr_err() strings should end with newlines

On Tue, Oct 24, 2017 at 01:20:39PM +0530, Arvind Yadav wrote: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. > > Signed-off-by: Arvind Yadav <arvind.yadav...@gmail.com> FWIW, Acked-by: Javi Merino <javi.mer...@kernel.org>

Re: [PATCH] thermal: cpu_cooling: pr_err() strings should end with newlines

On Tue, Oct 24, 2017 at 01:20:39PM +0530, Arvind Yadav wrote: > pr_err() messages should end with a new-line to avoid other messages > being concatenated. > > Signed-off-by: Arvind Yadav FWIW, Acked-by: Javi Merino > --- > drivers/thermal/cpu_cooling.c | 2 +- > 1 file

Re: [PATCH 2/2] tracing, thermal: Hide cpu cooling trace events when not in use

> > The trace events thermal_power_cpu_get_power and > thermal_power_cpu_limit are only used when CONFIG_CPU_THERMAL is set. > Make those events only defined when that is set as well. > > Signed-off-by: Steven Rostedt (VMware) <rost...@goodmis.org> Acked-by: Javi Merino &

Re: [PATCH 2/2] tracing, thermal: Hide cpu cooling trace events when not in use

> The trace events thermal_power_cpu_get_power and > thermal_power_cpu_limit are only used when CONFIG_CPU_THERMAL is set. > Make those events only defined when that is set as well. > > Signed-off-by: Steven Rostedt (VMware) Acked-by: Javi Merino > --- > Index: linux-t

Re: [PATCH 1/2] tracing, thermal: Hide devfreq trace events when not in use

> > The trace events thermal_power_devfreq_get_power and > thermal_power_devfreq_limit are only used when CONFIG_DEVFREQ_THERMAL > is set. Make those events only defined when that is set as well. > > Signed-off-by: Steven Rostedt (VMware) <rost...@goodmis.org>

Re: [PATCH 1/2] tracing, thermal: Hide devfreq trace events when not in use

> The trace events thermal_power_devfreq_get_power and > thermal_power_devfreq_limit are only used when CONFIG_DEVFREQ_THERMAL > is set. Make those events only defined when that is set as well. > > Signed-off-by: Steven Rostedt (VMware) Acked-by: Javi Merino > --- > Index: linux-t

[PATCH RESEND] drm: use .hword to represent 16-bit numbers

they should work in spite of the default target of the cc you are using, so use .hword where EDID specifies 16-bit numbers. Cc: Carsten Emde <c.e...@osadl.org> Cc: David Airlie <airl...@linux.ie> Signed-off-by: Javi Merino <javi.mer...@kernel.org> --- Documentation/EDID/edid.S

[PATCH RESEND] drm: use .hword to represent 16-bit numbers

they should work in spite of the default target of the cc you are using, so use .hword where EDID specifies 16-bit numbers. Cc: Carsten Emde Cc: David Airlie Signed-off-by: Javi Merino --- Documentation/EDID/edid.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

Re: [PATCH 0/2] Documentation/EDID fixes

On Tue, Mar 07, 2017 at 06:16:51PM +0200, Jani Nikula wrote: > On Mon, 06 Mar 2017, Javi Merino <javi.mer...@kernel.org> wrote: > > I found these two minor issues while building an EDID. I'm not sure > > whether the second patch (Add O= to support) is upstream material

Re: [PATCH 0/2] Documentation/EDID fixes

On Tue, Mar 07, 2017 at 06:16:51PM +0200, Jani Nikula wrote: > On Mon, 06 Mar 2017, Javi Merino wrote: > > I found these two minor issues while building an EDID. I'm not sure > > whether the second patch (Add O= to support) is upstream material, but > > I'm sending it j

[PATCH 2/2] drm: Add O= support

Add an option to put all output files in a given directory, similar to what kbuild does. Cc: Carsten Emde <c.e...@osadl.org> Cc: David Airlie <airl...@linux.ie> Signed-off-by: Javi Merino <javi.mer...@kernel.org> --- Documentation/EDID/Makefile | 21 -

[PATCH 2/2] drm: Add O= support

Add an option to put all output files in a given directory, similar to what kbuild does. Cc: Carsten Emde Cc: David Airlie Signed-off-by: Javi Merino --- Documentation/EDID/Makefile | 21 - 1 file changed, 12 insertions(+), 9 deletions(-) diff --git a/Documentation/EDID

[PATCH 1/2] drm: use .hword to represent 16-bit numbers

they should work in spite of the default target of the cc you are using, so use .hword where EDID specifies 16-bit numbers. Cc: Carsten Emde <c.e...@osadl.org> Cc: David Airlie <airl...@linux.ie> Signed-off-by: Javi Merino <javi.mer...@kernel.org> --- Documentation/EDID/edid.S

[PATCH 1/2] drm: use .hword to represent 16-bit numbers

they should work in spite of the default target of the cc you are using, so use .hword where EDID specifies 16-bit numbers. Cc: Carsten Emde Cc: David Airlie Signed-off-by: Javi Merino --- Documentation/EDID/edid.S | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git

[PATCH 0/2] Documentation/EDID fixes

Hi, I found these two minor issues while building an EDID. I'm not sure whether the second patch (Add O= to support) is upstream material, but I'm sending it just in case. Thanks, Javi Javi Merino (2): drm: use .hword to represent 16-bit numbers drm: Add O= support Documentation/EDID

[PATCH 0/2] Documentation/EDID fixes

Hi, I found these two minor issues while building an EDID. I'm not sure whether the second patch (Add O= to support) is upstream material, but I'm sending it just in case. Thanks, Javi Javi Merino (2): drm: use .hword to represent 16-bit numbers drm: Add O= support Documentation/EDID

Re: [PATCH v2] v4l: async: make v4l2 coexist with devicetree nodes in a dt overlay

On Mon, Dec 05, 2016 at 10:13:38AM -0300, Javier Martinez Canillas wrote: > Hello Javi, > > On 12/05/2016 07:09 AM, Javi Merino wrote: > > In asds configured with V4L2_ASYNC_MATCH_OF, the v4l2 subdev can be > > part of a devicetree overlay, for exam

Re: [PATCH v2] v4l: async: make v4l2 coexist with devicetree nodes in a dt overlay

On Mon, Dec 05, 2016 at 10:13:38AM -0300, Javier Martinez Canillas wrote: > Hello Javi, > > On 12/05/2016 07:09 AM, Javi Merino wrote: > > In asds configured with V4L2_ASYNC_MATCH_OF, the v4l2 subdev can be > > part of a devicetree overlay, for exam

[PATCH v2] v4l: async: make v4l2 coexist with devicetree nodes in a dt overlay

ue matching after the overlay has been removed and reapplied. Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Javier Martinez Canillas <jav...@osg.samsung.com> Cc: Sakari Ailus <sakari.ai...@linux.intel.com> Signed-off-by: Javi Merino <javi.mer...@kernel.org> --- drivers/me

[PATCH v2] v4l: async: make v4l2 coexist with devicetree nodes in a dt overlay

ue matching after the overlay has been removed and reapplied. Cc: Mauro Carvalho Chehab Cc: Javier Martinez Canillas Cc: Sakari Ailus Signed-off-by: Javi Merino --- drivers/media/v4l2-core/v4l2-async.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/v4l2-cor

Re: [PATCH] v4l: async: make v4l2 coexists with devicetree nodes in a dt overlay

On Fri, Nov 25, 2016 at 10:21:21AM +0200, Sakari Ailus wrote: Hi Sakari, > On Wed, Nov 23, 2016 at 04:15:11PM +0000, Javi Merino wrote: > > On Wed, Nov 23, 2016 at 05:10:42PM +0200, Sakari Ailus wrote: > > > Hi Javi, > > > > Hi Sakari, > > > > > O

Re: [PATCH] v4l: async: make v4l2 coexists with devicetree nodes in a dt overlay

On Fri, Nov 25, 2016 at 10:21:21AM +0200, Sakari Ailus wrote: Hi Sakari, > On Wed, Nov 23, 2016 at 04:15:11PM +0000, Javi Merino wrote: > > On Wed, Nov 23, 2016 at 05:10:42PM +0200, Sakari Ailus wrote: > > > Hi Javi, > > > > Hi Sakari, > > > > > O

Re: [PATCH] v4l: async: make v4l2 coexists with devicetree nodes in a dt overlay

On Wed, Nov 23, 2016 at 05:10:42PM +0200, Sakari Ailus wrote: > Hi Javi, Hi Sakari, > On Wed, Nov 23, 2016 at 10:09:57AM +, Javi Merino wrote: > > In asd's configured with V4L2_ASYNC_MATCH_OF, if the v4l2 subdev is in > > a devicetree overlay, its of_node pointer will be d

Re: [PATCH] v4l: async: make v4l2 coexists with devicetree nodes in a dt overlay

On Wed, Nov 23, 2016 at 05:10:42PM +0200, Sakari Ailus wrote: > Hi Javi, Hi Sakari, > On Wed, Nov 23, 2016 at 10:09:57AM +, Javi Merino wrote: > > In asd's configured with V4L2_ASYNC_MATCH_OF, if the v4l2 subdev is in > > a devicetree overlay, its of_node pointer will be d

Re: [PATCH] v4l: async: make v4l2 coexists with devicetree nodes in a dt overlay

On Wed, Nov 23, 2016 at 11:25:39AM -0300, Javier Martinez Canillas wrote: > Hello Javi, > > On 11/23/2016 07:09 AM, Javi Merino wrote: > > In asd's configured with V4L2_ASYNC_MATCH_OF, if the v4l2 subdev is in > > a devicetree overlay, its of_node pointer will b

Re: [PATCH] v4l: async: make v4l2 coexists with devicetree nodes in a dt overlay

On Wed, Nov 23, 2016 at 11:25:39AM -0300, Javier Martinez Canillas wrote: > Hello Javi, > > On 11/23/2016 07:09 AM, Javi Merino wrote: > > In asd's configured with V4L2_ASYNC_MATCH_OF, if the v4l2 subdev is in > > a devicetree overlay, its of_node pointer will b

[PATCH] v4l: async: make v4l2 coexists with devicetree nodes in a dt overlay

of_node_cmp() so that we continue matching after the overlay has been removed and reapplied. Cc: Mauro Carvalho Chehab <mche...@kernel.org> Cc: Javier Martinez Canillas <jav...@osg.samsung.com> Cc: Sakari Ailus <sakari.ai...@linux.intel.com> Signed-off-by: Javi Merino <javi.mer.

[PATCH] v4l: async: make v4l2 coexists with devicetree nodes in a dt overlay

of_node_cmp() so that we continue matching after the overlay has been removed and reapplied. Cc: Mauro Carvalho Chehab Cc: Javier Martinez Canillas Cc: Sakari Ailus Signed-off-by: Javi Merino --- Hi, I feel it is a bit of a hack, but I couldn't think of anything better. I'm ccing devicetree

[PATCH] MAINTAINERS: Switch to kernel.org email address for Javi Merino

Change my email address to my kernel.org account instead of the ARM one. Signed-off-by: Javi Merino <javi.mer...@arm.com> --- .mailmap| 1 + MAINTAINERS | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index de22daefd9da..1dab0a156489

[PATCH] MAINTAINERS: Switch to kernel.org email address for Javi Merino

Change my email address to my kernel.org account instead of the ARM one. Signed-off-by: Javi Merino --- .mailmap| 1 + MAINTAINERS | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/.mailmap b/.mailmap index de22daefd9da..1dab0a156489 100644 --- a/.mailmap +++ b/.mailmap

Re: [PATCH] of: thermal: Fixed governor at each thermal zone

On Tue, Sep 27, 2016 at 09:46:57AM +0800, Zhang Rui wrote: > On 一, 2016-09-19 at 10:18 +0900, Inhyuk Kang wrote: > > It is necessary to be added governor at each thermal_zone. > > Because some governors should be operated in the during the kernel > > booting > > in order to avoid heating problem.

Re: [PATCH] of: thermal: Fixed governor at each thermal zone

On Tue, Sep 27, 2016 at 09:46:57AM +0800, Zhang Rui wrote: > On 一, 2016-09-19 at 10:18 +0900, Inhyuk Kang wrote: > > It is necessary to be added governor at each thermal_zone. > > Because some governors should be operated in the during the kernel > > booting > > in order to avoid heating problem.

Re: [PATCH] thermal: cpu_cooling: Fix wrong comment call function name

On Wed, Sep 07, 2016 at 09:35:39AM +0900, Inhyuk Kang wrote: > The last_load is updated not cpufreq_get_actual_power() function call > but cpufreq_get_requested_power() function call. Yep, my bad. Thanks for fixing it! > Signed-off-by: Inhyuk Kang <hugh.k...@lge.com> Acked-

Re: [PATCH] thermal: cpu_cooling: Fix wrong comment call function name

On Wed, Sep 07, 2016 at 09:35:39AM +0900, Inhyuk Kang wrote: > The last_load is updated not cpufreq_get_actual_power() function call > but cpufreq_get_requested_power() function call. Yep, my bad. Thanks for fixing it! > Signed-off-by: Inhyuk Kang Acked-by: Javi Merino >

Re: [PATCH] devfreq_cooling: pass a pointer to devfreq in the power model callbacks

Eduardo, Rui, On Fri, Jun 03, 2016 at 10:25:31AM +0100, Javi Merino wrote: > When the devfreq cooling device was designed, it was an oversight not to > pass a pointer to the struct devfreq as the first parameters of the > callbacks. The design patterns of the kernel suggest it f

Re: [PATCH] devfreq_cooling: pass a pointer to devfreq in the power model callbacks

Eduardo, Rui, On Fri, Jun 03, 2016 at 10:25:31AM +0100, Javi Merino wrote: > When the devfreq cooling device was designed, it was an oversight not to > pass a pointer to the struct devfreq as the first parameters of the > callbacks. The design patterns of the kernel suggest it f

[PATCH 1/2] arm64: defconfig: enable SENSORS_ARM_SCPI

ARM SCPI Sensors were merged for v4.4 and they are defined in the Juno dts. Enable it in the defconfig to get them registered automatically in Juno by default. Signed-off-by: Javi Merino <javi.mer...@arm.com> --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 2/2] arm64: dts: juno: add thermal zones for scpi sensors

;lorenzo.pieral...@arm.com> Cc: Rob Herring <robh...@kernel.org> Cc: Mark Rutland <mark.rutl...@arm.com> Cc: Catalin Marinas <catalin.mari...@arm.com> Cc: Will Deacon <will.dea...@arm.com> Signed-off-by: Javi Merino <javi.mer...@arm.com>

[PATCH 1/2] arm64: defconfig: enable SENSORS_ARM_SCPI

ARM SCPI Sensors were merged for v4.4 and they are defined in the Juno dts. Enable it in the defconfig to get them registered automatically in Juno by default. Signed-off-by: Javi Merino --- arch/arm64/configs/defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm64/configs

[PATCH 2/2] arm64: dts: juno: add thermal zones for scpi sensors

: Will Deacon Signed-off-by: Javi Merino --- arch/arm64/boot/dts/arm/juno-base.dtsi | 42 ++ arch/arm64/boot/dts/arm/juno-r1.dts| 16 + arch/arm64/boot/dts/arm/juno-r2.dts| 16 + 3 files changed, 74 insertions(+) diff --git a/arch/arm64/boot

[PATCH 0/2] Enable SCPI sensors for Juno

Enable the ARM SCPI sensors in arm64 defconfig and add thermal zones for the thermal scpi sensors on Juno. The hwmon support for SCPI sensors was merged for v4.4, this just enables it by default. Javi Merino (2): arm64: defconfig: enable SENSORS_ARM_SCPI arm64: dts: juno: add thermal zones

[PATCH 0/2] Enable SCPI sensors for Juno

Enable the ARM SCPI sensors in arm64 defconfig and add thermal zones for the thermal scpi sensors on Juno. The hwmon support for SCPI sensors was merged for v4.4, this just enables it by default. Javi Merino (2): arm64: defconfig: enable SENSORS_ARM_SCPI arm64: dts: juno: add thermal zones

Re: [PATCH] thermal: fix race condition when updating cooling device

; assignment and the function. This would work, but will probably cause many > issues when updating all the modules that use thermal_cdev_update(). > > The other solution is to make cdev->updated an atomic_t, change the if > condition to an atomic_cmpxchg and extend the critical

Re: [PATCH] thermal: fix race condition when updating cooling device

al_cdev_update(). > > The other solution is to make cdev->updated an atomic_t, change the if > condition to an atomic_cmpxchg and extend the critical section to include the > call to cdev->ops->set_cur_state(). True. In any case, the mutex needs to cover set_cur_state() in thermal

Re: [PATCH v5 1/5] thermal: Add support for hardware-tracked trip points

<s.ha...@pengutronix.de> > Signed-off-by: Caesar Wang <w...@rock-chips.com> > Cc: Zhang Rui <rui.zh...@intel.com> > Cc: Eduardo Valentin <edubez...@gmail.com> > Cc: linux...@vger.kernel.org > > --- > > Changes in v5: > - add the lock for

Re: [PATCH v5 1/5] thermal: Add support for hardware-tracked trip points

: Eduardo Valentin > Cc: linux...@vger.kernel.org > > --- > > Changes in v5: > - add the lock for thermal_zone_set_trips function. Looks good to me! Reviewed-by: Javi Merino > - change based on next kernel. > > Changes in v4: > - Missing the lock added in v

[PATCH] devfreq_cooling: pass a pointer to devfreq in the power model callbacks

, the driver can identify which device it's referring to. Cc: Zhang Rui <rui.zh...@intel.com> Cc: Eduardo Valentin <edubez...@gmail.com> Reviewed-by: Punit Agrawal <punit.agra...@arm.com> Signed-off-by: Javi Merino <javi.mer...@arm.com> --- drivers/thermal/devfreq_cooling.c

[PATCH] devfreq_cooling: pass a pointer to devfreq in the power model callbacks

, the driver can identify which device it's referring to. Cc: Zhang Rui Cc: Eduardo Valentin Reviewed-by: Punit Agrawal Signed-off-by: Javi Merino --- drivers/thermal/devfreq_cooling.c | 5 +++-- include/linux/devfreq_cooling.h | 6 -- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git

Re: [PATCH V2 2/6] cpufreq: Remove cpufreq_frequency_get_table()

On Thu, Jun 02, 2016 at 09:06:26PM +0530, Viresh Kumar wrote: > On 2 June 2016 at 20:29, Javi Merino <javi.mer...@arm.com> wrote: > > In 5a31d594a973 ("cpufreq: Allow freq_table to be obtained for offline > > CPUs") you did the opposite: don't use cpufreq_cpu_get_

Re: [PATCH V2 2/6] cpufreq: Remove cpufreq_frequency_get_table()

On Thu, Jun 02, 2016 at 09:06:26PM +0530, Viresh Kumar wrote: > On 2 June 2016 at 20:29, Javi Merino wrote: > > In 5a31d594a973 ("cpufreq: Allow freq_table to be obtained for offline > > CPUs") you did the opposite: don't use cpufreq_cpu_get_raw() because > > it won

Re: [RESEND PATCH v4 1/5] thermal: Add support for hardware-tracked trip points

Hi Caesar, On Fri, May 27, 2016 at 04:36:44PM +0800, Caesar Wang wrote: > From: Sascha Hauer > > This adds support for hardware-tracked trip points to the device tree > thermal sensor framework. > > The framework supports an arbitrary number of trip points. Whenever >

Re: [RESEND PATCH v4 1/5] thermal: Add support for hardware-tracked trip points

Hi Caesar, On Fri, May 27, 2016 at 04:36:44PM +0800, Caesar Wang wrote: > From: Sascha Hauer > > This adds support for hardware-tracked trip points to the device tree > thermal sensor framework. > > The framework supports an arbitrary number of trip points. Whenever > the current temperature

Re: [PATCH V2 2/6] cpufreq: Remove cpufreq_frequency_get_table()

Hi Viresh, On Thu, Jun 02, 2016 at 07:34:56PM +0530, Viresh Kumar wrote: > Most of the callers of cpufreq_frequency_get_table() already have the > pointer to a valid 'policy' structure and they don't really need to go > through the per-cpu variable first and then a check to validate the >

Re: [PATCH V2 2/6] cpufreq: Remove cpufreq_frequency_get_table()

Hi Viresh, On Thu, Jun 02, 2016 at 07:34:56PM +0530, Viresh Kumar wrote: > Most of the callers of cpufreq_frequency_get_table() already have the > pointer to a valid 'policy' structure and they don't really need to go > through the per-cpu variable first and then a check to validate the >

Re: [PATCH v3 2/5] thermal: of: implement .set_trips for device tree thermal zones

Cc: Eduardo Valentin <edubez...@gmail.com> Other than that, it looks good to me. You can add my Reviewed-by: Javi Merino <javi.mer...@arm.com>

Re: [PATCH v3 2/5] thermal: of: implement .set_trips for device tree thermal zones

> > patch[0] > "thermal: Add support for hardware-tracked trip points". > > Signed-off-by: Sascha Hauer > Signed-off-by: Caesar Wang > Cc: Zhang Rui > Cc: Eduardo Valentin Other than that, it looks good to me. You can add my Reviewed-by: Javi Merino

Re: [PATCH v2 1/5] thermal: Add support for hardware-tracked trip points

Hi Caesar, On Wed, May 25, 2016 at 11:27:24AM +0800, Caesar Wang wrote: > On 2016年05月24日 20:57, Javi Merino wrote: > >On Tue, May 03, 2016 at 05:33:29PM +0800, Caesar Wang wrote: > >>From: Sascha Hauer <s.ha...@pengutronix.de> > >> > >>This add

Re: [PATCH v2 1/5] thermal: Add support for hardware-tracked trip points

Hi Caesar, On Wed, May 25, 2016 at 11:27:24AM +0800, Caesar Wang wrote: > On 2016年05月24日 20:57, Javi Merino wrote: > >On Tue, May 03, 2016 at 05:33:29PM +0800, Caesar Wang wrote: > >>From: Sascha Hauer > >> > >>This adds support for hardware-tracked trip p

Re: [PATCH v3 1/5] thermal: Add support for hardware-tracked trip points

Hi Caesar, On Wed, May 25, 2016 at 11:47:45AM +0800, Caesar Wang wrote: > From: Sascha Hauer > > This adds support for hardware-tracked trip points to the device tree > thermal sensor framework. > > The framework supports an arbitrary number of trip points. Whenever >

Re: [PATCH v3 1/5] thermal: Add support for hardware-tracked trip points

Hi Caesar, On Wed, May 25, 2016 at 11:47:45AM +0800, Caesar Wang wrote: > From: Sascha Hauer > > This adds support for hardware-tracked trip points to the device tree > thermal sensor framework. > > The framework supports an arbitrary number of trip points. Whenever > the current temperature

Re: [PATCH v2 4/5] thermal: bang-bang governor: act on lower trip boundary

Ccing Peter Feuerer, author of the bang bang governor. On Tue, May 03, 2016 at 05:33:32PM +0800, Caesar Wang wrote: > From: Sascha Hauer > > With interrupt driven thermal zones we pass the lower and upper > temperature on which shall be acted, so in the governor we have

Re: [PATCH v2 4/5] thermal: bang-bang governor: act on lower trip boundary

Ccing Peter Feuerer, author of the bang bang governor. On Tue, May 03, 2016 at 05:33:32PM +0800, Caesar Wang wrote: > From: Sascha Hauer > > With interrupt driven thermal zones we pass the lower and upper > temperature on which shall be acted, so in the governor we have to act on > the exact

Re: [PATCH v2 2/5] thermal: of: implement .set_trips for device tree thermal zones

On Tue, May 03, 2016 at 05:33:30PM +0800, Caesar Wang wrote: > From: Sascha Hauer > > This patch implemnets .set_trips for device tree thermal zones. > As the hardware-tracked trip points is supported by thermal core patch[0]. > > patch[0] > "thermal: Add support for

Re: [PATCH v2 2/5] thermal: of: implement .set_trips for device tree thermal zones

On Tue, May 03, 2016 at 05:33:30PM +0800, Caesar Wang wrote: > From: Sascha Hauer > > This patch implemnets .set_trips for device tree thermal zones. > As the hardware-tracked trip points is supported by thermal core patch[0]. > > patch[0] > "thermal: Add support for hardware-tracked trip

Re: [PATCH v2 1/5] thermal: Add support for hardware-tracked trip points

On Tue, May 03, 2016 at 05:33:29PM +0800, Caesar Wang wrote: > From: Sascha Hauer > > This adds support for hardware-tracked trip points to the device tree > thermal sensor framework. > > The framework supports an arbitrary number of trip points. Whenever > the current

Re: [PATCH v2 1/5] thermal: Add support for hardware-tracked trip points

On Tue, May 03, 2016 at 05:33:29PM +0800, Caesar Wang wrote: > From: Sascha Hauer > > This adds support for hardware-tracked trip points to the device tree > thermal sensor framework. > > The framework supports an arbitrary number of trip points. Whenever > the current temperature is updated,

Re: [PATCH] Syntactic and factual errors in the API document

On Thu, Mar 31, 2016 at 08:32:26AM +, Champ, Andy wrote: > I thought that _was_ the current kernel (not the obsolete one our chip vendor > supports). > > Which one do you mean by current? (URL & commit ID would be great!) You can find it in the MAINTAINERS file. I think Jon refers to

Re: [PATCH] Syntactic and factual errors in the API document

On Thu, Mar 31, 2016 at 08:32:26AM +, Champ, Andy wrote: > I thought that _was_ the current kernel (not the obsolete one our chip vendor > supports). > > Which one do you mean by current? (URL & commit ID would be great!) You can find it in the MAINTAINERS file. I think Jon refers to

Re: [PATCH] Syntactic and factual errors in the API document

Hi Andy, Thanks for improving the documentation! One minor nit below. Other than that, you can add my reviewed-by. On Tue, Mar 22, 2016 at 12:37:25PM +, Andy Champ wrote: > There are several places where the English in the document is syntactically > invalid, or unclear. There are also one

Re: [PATCH] Syntactic and factual errors in the API document

Hi Andy, Thanks for improving the documentation! One minor nit below. Other than that, you can add my reviewed-by. On Tue, Mar 22, 2016 at 12:37:25PM +, Andy Champ wrote: > There are several places where the English in the document is syntactically > invalid, or unclear. There are also one

Re: [PATCH v3 2/4] devicetree: bindings: let thermal-sensor point to other thermal zones

On Wed, Mar 02, 2016 at 07:21:53PM -0800, Eduardo Valentin wrote: > On Mon, Jan 04, 2016 at 03:17:09PM +0100, Sascha Hauer wrote: > > On Wed, Nov 25, 2015 at 03:09:44PM +0000, Javi Merino wrote: > > > The thermal-sensor property of the thermal zone node accepts phandles to >

Re: [PATCH v3 2/4] devicetree: bindings: let thermal-sensor point to other thermal zones

On Wed, Mar 02, 2016 at 07:21:53PM -0800, Eduardo Valentin wrote: > On Mon, Jan 04, 2016 at 03:17:09PM +0100, Sascha Hauer wrote: > > On Wed, Nov 25, 2015 at 03:09:44PM +0000, Javi Merino wrote: > > > The thermal-sensor property of the thermal zone node accepts phandles to >

Re: [PATCH v2 1/5] thermal: change "hysteresis" as optional property

On Tue, Mar 08, 2016 at 12:55:59PM -0800, Eduardo Valentin wrote: > On Tue, Mar 08, 2016 at 09:57:43PM +0800, Leo Yan wrote: > > Hi Eduardo, > > > > On Fri, Mar 04, 2016 at 11:57:53AM +, Javi Merino wrote: > > > On Fri, Mar 04, 2016 at 11:03:49AM +0800, Leo Yan

Re: [PATCH v2 1/5] thermal: change "hysteresis" as optional property

On Tue, Mar 08, 2016 at 12:55:59PM -0800, Eduardo Valentin wrote: > On Tue, Mar 08, 2016 at 09:57:43PM +0800, Leo Yan wrote: > > Hi Eduardo, > > > > On Fri, Mar 04, 2016 at 11:57:53AM +, Javi Merino wrote: > > > On Fri, Mar 04, 2016 at 11:03:49AM +0800, Leo Yan

Re: [PATCH] thermal: trace: migrating thermal traces to use TRACE_DEFINE_ENUM() macros

On Tue, Mar 08, 2016 at 09:48:42AM +, Zhang, Rui wrote: > Punit and Javi, > > What do you think of this? I'd like to get your ACK before taking it. Sorry, I didn't realize you were waiting for us. I'm quite happy for this to go in: Acked-by: Javi Merino <javi.me

Re: [PATCH] thermal: trace: migrating thermal traces to use TRACE_DEFINE_ENUM() macros

On Tue, Mar 08, 2016 at 09:48:42AM +, Zhang, Rui wrote: > Punit and Javi, > > What do you think of this? I'd like to get your ACK before taking it. Sorry, I didn't realize you were waiting for us. I'm quite happy for this to go in: Acked-by: Javi Merino > > -O

Re: [PATCH v2 1/5] thermal: change "hysteresis" as optional property

On Fri, Mar 04, 2016 at 11:03:49AM +0800, Leo Yan wrote: > Hi Eduardo, > > On Thu, Mar 03, 2016 at 08:29:44AM -0800, Eduardo Valentin wrote: > > Hi Leo, > > > > On Fri, Feb 26, 2016 at 11:43:43AM +0800, Leo Yan wrote: > > > The property "hysteresis" is mandatory for trip points, so if without >

Re: [PATCH v2 1/5] thermal: change "hysteresis" as optional property

On Fri, Mar 04, 2016 at 11:03:49AM +0800, Leo Yan wrote: > Hi Eduardo, > > On Thu, Mar 03, 2016 at 08:29:44AM -0800, Eduardo Valentin wrote: > > Hi Leo, > > > > On Fri, Feb 26, 2016 at 11:43:43AM +0800, Leo Yan wrote: > > > The property "hysteresis" is mandatory for trip points, so if without >

Re: [PATCH v2 1/5] thermal: change "hysteresis" as optional property

; + pr_warning("missing hysteresis property\n"); I'd remove the warning. It is an optional parameter, so there is no need to warn about something going wrong. As you say in the commit log, it is ignored in the thermal subsystem and only used by some sensors so no need to warn about it missing. Other than that, I'm happy to see this merged. Acked-by: Javi Merino <javi.mer...@arm.com> > + else > + trip->hysteresis = prop; > > ret = thermal_of_get_trip_type(np, >type); > if (ret < 0) { > -- > 1.9.1 >

Re: [PATCH v2 1/5] thermal: change "hysteresis" as optional property

ning("missing hysteresis property\n"); I'd remove the warning. It is an optional parameter, so there is no need to warn about something going wrong. As you say in the commit log, it is ignored in the thermal subsystem and only used by some sensors so no need to warn about it missing. Other than that, I'm happy to see this merged. Acked-by: Javi Merino > + else > + trip->hysteresis = prop; > > ret = thermal_of_get_trip_type(np, >type); > if (ret < 0) { > -- > 1.9.1 >

[PATCH] doc: fix grammar

Some minor typos: - make is unbindable -> make it unbindable - a underlying -> an underlying - different version -> different versions Cc: Jonathan Corbet <cor...@lwn.net> Signed-off-by: Javi Merino <javi.mer...@arm.com> --- Documentation/filesystems/sharedsubtree.txt

[PATCH] doc: fix grammar

Some minor typos: - make is unbindable -> make it unbindable - a underlying -> an underlying - different version -> different versions Cc: Jonathan Corbet Signed-off-by: Javi Merino --- Documentation/filesystems/sharedsubtree.txt | 8 1 file changed, 4 inserti

  1   2   3   4   5   6   7   8   9   >