Re: [RFC PATCH v2 19/31] KVM: arm64: Describe AT instruction emulation design

Hi James, On Tue, Oct 3, 2017 at 1:37 PM, James Morse <james.mo...@arm.com> wrote: > Hi Jintack, > > On 03/10/17 04:11, Jintack Lim wrote: >> This design overview will help to digest the subsequent patches that >> implement AT instruction emulation. > >> diff

Re: [RFC PATCH v2 19/31] KVM: arm64: Describe AT instruction emulation design

Hi James, On Tue, Oct 3, 2017 at 1:37 PM, James Morse wrote: > Hi Jintack, > > On 03/10/17 04:11, Jintack Lim wrote: >> This design overview will help to digest the subsequent patches that >> implement AT instruction emulation. > >> diff --git a/arch/arm64/k

[RFC PATCH v2 07/31] KVM: arm64: Setup vttbr_el2 on each VM entry

ed-off-by: Christoffer Dall <christoffer.d...@linaro.org> Signed-off-by: Jintack Lim <jint...@cs.columbia.edu> --- arch/arm64/kvm/context.c | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm64/kvm/context.c b/arch/arm64/kvm/context.c index a7811e1..afd1702 100644 --

[RFC PATCH v2 07/31] KVM: arm64: Setup vttbr_el2 on each VM entry

-by: Jintack Lim --- arch/arm64/kvm/context.c | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm64/kvm/context.c b/arch/arm64/kvm/context.c index a7811e1..afd1702 100644 --- a/arch/arm64/kvm/context.c +++ b/arch/arm64/kvm/context.c @@ -18,6 +18,7 @@ #include #include #include

[RFC PATCH v2 08/31] KVM: arm/arm64: Make mmu functions non-static

From: Christoffer Dall <christoffer.d...@linaro.org> Make mmu functions non-static so that we can reuse those functions to support mmu for the nested VMs. Signed-off-by: Christoffer Dall <christoffer.d...@linaro.org> Signed-off-by: Jintack Lim <jintack@linaro.org> --- arch

[RFC PATCH v2 04/31] KVM: arm/arm64: Abstract stage-2 MMU state into a separate structure

ed-off-by: Christoffer Dall <christoffer.d...@linaro.org> Signed-off-by: Jintack Lim <jintack@linaro.org> --- arch/arm/include/asm/kvm_asm.h| 7 +- arch/arm/include/asm/kvm_host.h | 26 +--- arch/arm/kvm/hyp/switch.c | 5 +- arch/arm/kvm/hyp/tlb.c| 18

[RFC PATCH v2 06/31] KVM: arm64: Invalidate virtual EL2 TLB entries when needed

; Signed-off-by: Jintack Lim <jintack@linaro.org> --- virt/kvm/arm/arm.c | 5 + virt/kvm/arm/mmu.c | 23 ++- 2 files changed, 27 insertions(+), 1 deletion(-) diff --git a/virt/kvm/arm/arm.c b/virt/kvm/arm/arm.c index 41e0654..63dd897 100644 --- a/virt/kvm/arm/arm.c

[RFC PATCH v2 08/31] KVM: arm/arm64: Make mmu functions non-static

From: Christoffer Dall Make mmu functions non-static so that we can reuse those functions to support mmu for the nested VMs. Signed-off-by: Christoffer Dall Signed-off-by: Jintack Lim --- arch/arm64/include/asm/kvm_mmu.h | 9 virt/kvm/arm/mmu.c | 94

[RFC PATCH v2 04/31] KVM: arm/arm64: Abstract stage-2 MMU state into a separate structure

-by: Jintack Lim --- arch/arm/include/asm/kvm_asm.h| 7 +- arch/arm/include/asm/kvm_host.h | 26 +--- arch/arm/kvm/hyp/switch.c | 5 +- arch/arm/kvm/hyp/tlb.c| 18 ++--- arch/arm64/include/asm/kvm_asm.h | 7 +- arch/arm64/include/asm/kvm_host.h | 10 ++- arch

[RFC PATCH v2 06/31] KVM: arm64: Invalidate virtual EL2 TLB entries when needed

From: Christoffer Dall Sometimes when we are invalidating the TLB for a certain S2 MMU context, this context can also have EL2 context associated with it and we have to invalidate this too. Signed-off-by: Christoffer Dall Signed-off-by: Jintack Lim --- virt/kvm/arm/arm.c | 5 + virt/kvm

[RFC PATCH v2 12/31] KVM: arm/arm64: Handle shadow stage 2 page faults

riable names so that fault_ipa is used for the former and ipa is used for the latter. Signed-off-by: Christoffer Dall <christoffer.d...@linaro.org> Signed-off-by: Jintack Lim <jintack@linaro.org> --- Notes: v1-->v2: - Added a common function to inject s2 faults. -

[RFC PATCH v2 12/31] KVM: arm/arm64: Handle shadow stage 2 page faults

is used for the former and ipa is used for the latter. Signed-off-by: Christoffer Dall Signed-off-by: Jintack Lim --- Notes: v1-->v2: - Added a common function to inject s2 faults. - Align L1 IPA as well as L2 IPA in transparent_hugepage_adjust(). This will come in handy when creat

[RFC PATCH v2 13/31] KVM: arm/arm64: Move kvm_is_write_fault to header file

From: Christoffer Dall Move this little function to the header files for arm/arm64 so other code can make use of it directly. Signed-off-by: Christoffer Dall --- arch/arm/include/asm/kvm_emulate.h | 8

[RFC PATCH v2 13/31] KVM: arm/arm64: Move kvm_is_write_fault to header file

From: Christoffer Dall Move this little function to the header files for arm/arm64 so other code can make use of it directly. Signed-off-by: Christoffer Dall --- arch/arm/include/asm/kvm_emulate.h | 8 arch/arm64/include/asm/kvm_emulate.h | 8 virt/kvm/arm/mmu.c

[RFC PATCH v2 11/31] KVM: arm64: Implement nested Stage-2 page table walk logic

From: Christoffer Dall <christoffer.d...@linaro.org> Based on the pseudo-code in the ARM ARM, implement a stage 2 software page table walker. Signed-off-by: Christoffer Dall <christoffer.d...@linaro.org> Signed-off-by: Jintack Lim <jintack@linaro.org> --- Notes: v1--

[RFC PATCH v2 14/31] KVM: arm/arm64: Forward the guest hypervisor's stage 2 permission faults

about the fault. Signed-off-by: Christoffer Dall <christoffer.d...@linaro.org> Signed-off-by: Jintack Lim <jintack@linaro.org> --- arch/arm/include/asm/kvm_mmu.h | 7 +++ arch/arm64/include/asm/kvm_mmu.h | 2 ++ arch/arm64/kvm/mmu-nested.c | 22 ++

[RFC PATCH v2 11/31] KVM: arm64: Implement nested Stage-2 page table walk logic

From: Christoffer Dall Based on the pseudo-code in the ARM ARM, implement a stage 2 software page table walker. Signed-off-by: Christoffer Dall Signed-off-by: Jintack Lim --- Notes: v1-->v2: - Handled different endianness between the host and the guest hypervisor - Decoup

[RFC PATCH v2 14/31] KVM: arm/arm64: Forward the guest hypervisor's stage 2 permission faults

-by: Christoffer Dall Signed-off-by: Jintack Lim --- arch/arm/include/asm/kvm_mmu.h | 7 +++ arch/arm64/include/asm/kvm_mmu.h | 2 ++ arch/arm64/kvm/mmu-nested.c | 22 ++ virt/kvm/arm/mmu.c | 7 +++ 4 files changed, 38 insertions(+) diff --git a/arch/arm

[RFC PATCH v2 10/31] KVM: arm/arm64: Unmap/flush shadow stage 2 page tables

xample by clearing out an entire shadow stage-2 table. This will be handled in a more efficient way using the reverse mapping feature in a later version of the patch series. Signed-off-by: Christoffer Dall <christoffer.d...@linaro.org> Signed-off-by: Jintack Lim <jintack@linaro.org>

[RFC PATCH v2 10/31] KVM: arm/arm64: Unmap/flush shadow stage 2 page tables

shadow stage-2 table. This will be handled in a more efficient way using the reverse mapping feature in a later version of the patch series. Signed-off-by: Christoffer Dall Signed-off-by: Jintack Lim --- Notes: v1-->v2: - Removed an unnecessary iteration for each v

[RFC PATCH v2 15/31] KVM: arm64: Move system register helper functions around

From: Jintack Lim <jint...@cs.columbia.edu> We are about to add a framework to handle system instruction traps. To reuse existing helper functions, let's move them around. No functional change. Signed-off-by: Jintack Lim <jintack@linaro.org> --- arch/arm64/kvm/sys

[RFC PATCH v2 15/31] KVM: arm64: Move system register helper functions around

From: Jintack Lim We are about to add a framework to handle system instruction traps. To reuse existing helper functions, let's move them around. No functional change. Signed-off-by: Jintack Lim --- arch/arm64/kvm/sys_regs.c | 89 --- 1 file

[RFC PATCH v2 16/31] KVM: arm64: Introduce sys_reg_desc.forward_trap

This introduces a function prototype to determine if we need to forward system instruction traps to the virtual EL2. The implementation of forward_trap functions for each system instruction will be added in later patches. Signed-off-by: Jintack Lim <jintack@linaro.org> --- arch/arm

[RFC PATCH v2 16/31] KVM: arm64: Introduce sys_reg_desc.forward_trap

This introduces a function prototype to determine if we need to forward system instruction traps to the virtual EL2. The implementation of forward_trap functions for each system instruction will be added in later patches. Signed-off-by: Jintack Lim --- arch/arm64/kvm/sys_regs.c | 8

[RFC PATCH v2 21/31] KVM: arm64: Emulate AT S1E[01] instructions

Emulate AT S1E[01] instructions by issuing the same instructions in EL2. We set the physical EL1 registers, NV and NV1 bits as described in the AT instruction emulation overview. Signed-off-by: Jintack Lim <jintack@linaro.org> --- arch/arm64/include/asm/kvm_emulate.h | 11 +++

[RFC PATCH v2 26/31] KVM: arm64: Emulate TLBI ALLE1(IS)

ings in the stage 2 page tables maintained by the guest hypervisor. We then need to invalidate all EL1&0 regime stage 1 and 2 TLB entries of all VMIDs, which are assigned by the host hypervisor, for this VM. Signed-off-by: Jintack Lim <jintack@linaro.org> --- arch/arm64/kvm/s

[RFC PATCH v2 21/31] KVM: arm64: Emulate AT S1E[01] instructions

Emulate AT S1E[01] instructions by issuing the same instructions in EL2. We set the physical EL1 registers, NV and NV1 bits as described in the AT instruction emulation overview. Signed-off-by: Jintack Lim --- arch/arm64/include/asm/kvm_emulate.h | 11 +++ arch/arm64/kvm/sys_regs.c

[RFC PATCH v2 26/31] KVM: arm64: Emulate TLBI ALLE1(IS)

ings in the stage 2 page tables maintained by the guest hypervisor. We then need to invalidate all EL1&0 regime stage 1 and 2 TLB entries of all VMIDs, which are assigned by the host hypervisor, for this VM. Signed-off-by: Jintack Lim --- arch/arm64/kvm/sys_regs.c | 29

[RFC PATCH v2 20/31] KVM: arm64: Implement AT instruction handling

registers and executing AT instructions. Note that ctxt->hw_sys_regs is expected to have the proper processor context before calling the handling function(__kvm_at_insn) implemented in this patch. Signed-off-by: Jintack Lim <jintack@linaro.org> --- arch/arm64/include/asm/kvm_asm.h |

[RFC PATCH v2 20/31] KVM: arm64: Implement AT instruction handling

registers and executing AT instructions. Note that ctxt->hw_sys_regs is expected to have the proper processor context before calling the handling function(__kvm_at_insn) implemented in this patch. Signed-off-by: Jintack Lim --- arch/arm64/include/asm/kvm_asm.h | 3 + arch/arm64/kvm/hyp/Makef

[RFC PATCH v2 25/31] KVM: arm64: Emulate TLBI VAE2* instrutions

Emulate TLBI VAE2* instruction executed in the virtual EL2. Based on the same principle as TLBI ALLE2 instruction, we can simply emulate those instructions by executing corresponding VAE1* instructions with the virtual EL2's VMID assigned by the host hypervisor. Signed-off-by: Jintack Lim

[RFC PATCH v2 25/31] KVM: arm64: Emulate TLBI VAE2* instrutions

Emulate TLBI VAE2* instruction executed in the virtual EL2. Based on the same principle as TLBI ALLE2 instruction, we can simply emulate those instructions by executing corresponding VAE1* instructions with the virtual EL2's VMID assigned by the host hypervisor. Signed-off-by: Jintack Lim

[RFC PATCH v2 24/31] KVM: arm64: Emulate TLBI ALLE2(IS) instruction

tage 1 TLB entries via TLBI VMALL1IS instruction, but to make it simeple, we reuse the existing function, __kvm_tlb_flush_vmid(), which invalidates both of stage 1 and 2 TLB entries. Signed-off-by: Jintack Lim <jintack@linaro.org> --- arch/arm64/kvm/sys_r

[RFC PATCH v2 24/31] KVM: arm64: Emulate TLBI ALLE2(IS) instruction

tage 1 TLB entries via TLBI VMALL1IS instruction, but to make it simeple, we reuse the existing function, __kvm_tlb_flush_vmid(), which invalidates both of stage 1 and 2 TLB entries. Signed-off-by: Jintack Lim --- arch/arm64/kvm/sys_regs.c | 35 +-- 1 file changed

[RFC PATCH v2 28/31] KVM: arm64: Emulate TLBI IPAS2E1* instructions

Based on the same principle as TLBI ALLE1(IS) and TLBI VMALLS12E1(IS) emulation, we clear the mappings in the shadow stage-2 page tables and invalidate TLB entries. We do it only for one mapping for the current VMID from the guest hypervisor's view. Signed-off-by: Jintack Lim <jint

[RFC PATCH v2 22/31] KVM: arm64: Emulate AT S1E2 instructions

Emulate AT S1E2 instructions by issuing the corresponding S1E1 instructions in EL2. We set the physical EL1 registers and the HCR_EL2 register as described in the AT instruction emulation overview. Signed-off-by: Jintack Lim <jintack@linaro.org> --- arch/arm64/kvm/sys_regs.

[RFC PATCH v2 28/31] KVM: arm64: Emulate TLBI IPAS2E1* instructions

Based on the same principle as TLBI ALLE1(IS) and TLBI VMALLS12E1(IS) emulation, we clear the mappings in the shadow stage-2 page tables and invalidate TLB entries. We do it only for one mapping for the current VMID from the guest hypervisor's view. Signed-off-by: Jintack Lim --- arch/arm64/kvm

[RFC PATCH v2 22/31] KVM: arm64: Emulate AT S1E2 instructions

Emulate AT S1E2 instructions by issuing the corresponding S1E1 instructions in EL2. We set the physical EL1 registers and the HCR_EL2 register as described in the AT instruction emulation overview. Signed-off-by: Jintack Lim --- arch/arm64/kvm/sys_regs.c | 19 +-- 1 file changed

[RFC PATCH v2 23/31] KVM: arm64: Emulate AT S12E[01] instructions

-by: Jintack Lim <jintack@linaro.org> --- arch/arm64/include/asm/kvm_arm.h | 1 + arch/arm64/kvm/sys_regs.c| 99 ++-- 2 files changed, 96 insertions(+), 4 deletions(-) diff --git a/arch/arm64/include/asm/kvm_arm.h b/arch/arm64/include/asm/kvm_arm.h

[RFC PATCH v2 23/31] KVM: arm64: Emulate AT S12E[01] instructions

-by: Jintack Lim --- arch/arm64/include/asm/kvm_arm.h | 1 + arch/arm64/kvm/sys_regs.c| 99 ++-- 2 files changed, 96 insertions(+), 4 deletions(-) diff --git a/arch/arm64/include/asm/kvm_arm.h b/arch/arm64/include/asm/kvm_arm.h index 3993703..e160895 100644

[RFC PATCH v2 29/31] KVM: arm64: Respect the virtual HCR_EL2.AT and NV setting

Forward system instruction traps to the virtual EL2 if a corresponding bit in the virtual HCR_EL2 is set. Signed-off-by: Jintack Lim <jintack@linaro.org> --- Notes: v1-->v2: This is a new commit. We can rework existing forward_nv_traps() and forward_nv1_traps() defined

[RFC PATCH v2 29/31] KVM: arm64: Respect the virtual HCR_EL2.AT and NV setting

Forward system instruction traps to the virtual EL2 if a corresponding bit in the virtual HCR_EL2 is set. Signed-off-by: Jintack Lim --- Notes: v1-->v2: This is a new commit. We can rework existing forward_nv_traps() and forward_nv1_traps() defined in rfc-v2 cpu patches to re

[RFC PATCH v2 27/31] KVM: arm64: Emulate TLBI VMALLS12E1(IS) instruction

Based on the same principle as TLBI ALLE1(IS) emulation, we clear the mappings in the shadow stage-2 page tables and invalidate TLB entries. But this time we do it only for the current VMID from the guest hypervisor's perspective, not for all VMIDs. Signed-off-by: Jintack Lim <jint

[RFC PATCH v2 27/31] KVM: arm64: Emulate TLBI VMALLS12E1(IS) instruction

Based on the same principle as TLBI ALLE1(IS) emulation, we clear the mappings in the shadow stage-2 page tables and invalidate TLB entries. But this time we do it only for the current VMID from the guest hypervisor's perspective, not for all VMIDs. Signed-off-by: Jintack Lim --- arch/arm64

[RFC PATCH v2 19/31] KVM: arm64: Describe AT instruction emulation design

This design overview will help to digest the subsequent patches that implement AT instruction emulation. Signed-off-by: Jintack Lim <jintack@linaro.org> --- arch/arm64/kvm/sys_regs.c | 66 +++ 1 file changed, 66 insertions(+) diff --git

[RFC PATCH v2 19/31] KVM: arm64: Describe AT instruction emulation design

This design overview will help to digest the subsequent patches that implement AT instruction emulation. Signed-off-by: Jintack Lim --- arch/arm64/kvm/sys_regs.c | 66 +++ 1 file changed, 66 insertions(+) diff --git a/arch/arm64/kvm/sys_regs.c b/arch

[RFC PATCH v2 30/31] KVM: arm64: Emulate TLBI instructions accesible from EL1

, then execute the same instruction in EL2. We don't set HCR_EL2.TTLB bit yet. Signed-off-by: Jintack Lim <jintack@linaro.org> --- arch/arm64/include/asm/kvm_asm.h | 1 + arch/arm64/include/asm/kvm_mmu.h | 1 + arch/arm64/include/asm/sysreg.h | 15 arch/arm64/kvm/hyp

[RFC PATCH v2 30/31] KVM: arm64: Emulate TLBI instructions accesible from EL1

, then execute the same instruction in EL2. We don't set HCR_EL2.TTLB bit yet. Signed-off-by: Jintack Lim --- arch/arm64/include/asm/kvm_asm.h | 1 + arch/arm64/include/asm/kvm_mmu.h | 1 + arch/arm64/include/asm/sysreg.h | 15 arch/arm64/kvm/hyp/tlb.c | 52

[RFC PATCH v2 18/31] KVM: arm64: Enumerate AT and TLBI instructions to emulate

List all system instructions to emulate. This patch only introduces the definitions, emulation handlers will be added in subsequent patches. Signed-off-by: Jintack Lim <jintack@linaro.org> --- arch/arm64/include/asm/sysreg.h | 38 ++ arch/arm

[RFC PATCH v2 18/31] KVM: arm64: Enumerate AT and TLBI instructions to emulate

List all system instructions to emulate. This patch only introduces the definitions, emulation handlers will be added in subsequent patches. Signed-off-by: Jintack Lim --- arch/arm64/include/asm/sysreg.h | 38 ++ arch/arm64/kvm/sys_regs.c | 26

[RFC PATCH v2 17/31] KVM: arm64: Rework the system instruction emulation framework

Rework the system instruction emulation framework to handle potentially all system instruction traps other than MSR/MRS instructions. Those system instructions would be AT and TLBI instructions controlled by HCR_EL2.NV, AT, and TTLB bits. Signed-off-by: Jintack Lim <jintack@linaro.

[RFC PATCH v2 31/31] KVM: arm64: Fixes to toggle_cache for nesting

re EL1 register). Signed-off-by: Christoffer Dall <christoffer.d...@linaro.org> Signed-off-by: Jintack Lim <jintack@linaro.org> --- arch/arm64/include/asm/kvm_mmu.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm64/include/asm/kvm_mmu.h b/arch/arm64/inc

[RFC PATCH v2 17/31] KVM: arm64: Rework the system instruction emulation framework

Rework the system instruction emulation framework to handle potentially all system instruction traps other than MSR/MRS instructions. Those system instructions would be AT and TLBI instructions controlled by HCR_EL2.NV, AT, and TTLB bits. Signed-off-by: Jintack Lim --- arch/arm64/kvm/sys_regs.c

[RFC PATCH v2 31/31] KVM: arm64: Fixes to toggle_cache for nesting

-by: Christoffer Dall Signed-off-by: Jintack Lim --- arch/arm64/include/asm/kvm_mmu.h | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/arch/arm64/include/asm/kvm_mmu.h b/arch/arm64/include/asm/kvm_mmu.h index 601f431..7a1c581 100644 --- a/arch/arm64/include/asm/kvm_mmu.h +++ b/arch

[RFC PATCH v2 09/31] KVM: arm/arm64: Manage mmus for nested VMs

a set of shadow stage-2 page tables for each shadow VMID. All this information is stored in kvm_nested_s2_mmu struct. A host hypervisor manages a list of kvm_nested_s2_mmu objects per VM. On a VM entry it searches an object in the list using a virtual VMID as a key. Signed-off-by: Jintack Lim

[RFC PATCH v2 09/31] KVM: arm/arm64: Manage mmus for nested VMs

a set of shadow stage-2 page tables for each shadow VMID. All this information is stored in kvm_nested_s2_mmu struct. A host hypervisor manages a list of kvm_nested_s2_mmu objects per VM. On a VM entry it searches an object in the list using a virtual VMID as a key. Signed-off-by: Jintack Lim

[RFC PATCH v2 03/31] KVM: arm/arm64: Remove unused params in mmu functions

inaro.org> Signed-off-by: Jintack Lim <jintack@linaro.org> --- virt/kvm/arm/mmu.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/virt/kvm/arm/mmu.c b/virt/kvm/arm/mmu.c index f2d5b6c..0a5f5ca 100644 --- a/virt/kvm/arm/mmu.c +++ b/virt/kvm/arm/mmu.

[RFC PATCH v2 05/31] KVM: arm/arm64: Support mmu for the virtual EL2 execution

ucture does not have vttbr any more. Signed-off-by: Christoffer Dall <christoffer.d...@linaro.org> Signed-off-by: Jintack Lim <jintack@linaro.org> --- Notes: v1-->v2: Fixed a bug that hw_vttbr was not initialized correctly in kvm_arch_vcpu_init() where vmid

[RFC PATCH v2 05/31] KVM: arm/arm64: Support mmu for the virtual EL2 execution

. Signed-off-by: Christoffer Dall Signed-off-by: Jintack Lim --- Notes: v1-->v2: Fixed a bug that hw_vttbr was not initialized correctly in kvm_arch_vcpu_init() where vmid is not allocated yet. This prevented the guest from booting on 32bit arm; hw_vttbr is set on each en

[RFC PATCH v2 03/31] KVM: arm/arm64: Remove unused params in mmu functions

From: Christoffer Dall stage2_flush_xxx functions take a pointer to the kvm struct as the first parameter but they are never used. Clean this up before modifying mmu code for nested virtualization support. Signed-off-by: Christoffer Dall Signed-off-by: Jintack Lim --- virt/kvm/arm/mmu.c | 15

[RFC PATCH v2 00/31] Nested Virtualization on KVM/ARM - memory virtualization

ing Dave Martin (1): arm64: KVM: Hide unsupported AArch64 CPU features from guests Jintack Lim (18): KVM: arm64: Expose limited memory management support to the virtual EL2 KVM: arm/arm64: Manage mmus for nested VMs KVM: arm64: Move system register helper functions around KVM: ar

[RFC PATCH v2 00/31] Nested Virtualization on KVM/ARM - memory virtualization

ing Dave Martin (1): arm64: KVM: Hide unsupported AArch64 CPU features from guests Jintack Lim (18): KVM: arm64: Expose limited memory management support to the virtual EL2 KVM: arm/arm64: Manage mmus for nested VMs KVM: arm64: Move system register helper functions around KVM: ar

[RFC PATCH v2 02/31] KVM: arm64: Expose limited memory management support to the virtual EL2

. Signed-off-by: Jintack Lim <jintack@linaro.org> --- arch/arm64/kvm/sys_regs.c | 47 ++- 1 file changed, 46 insertions(+), 1 deletion(-) diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c index 65f4c20..395b964 100644 --- a/arch/arm

[RFC PATCH v2 02/31] KVM: arm64: Expose limited memory management support to the virtual EL2

. Signed-off-by: Jintack Lim --- arch/arm64/kvm/sys_regs.c | 47 ++- 1 file changed, 46 insertions(+), 1 deletion(-) diff --git a/arch/arm64/kvm/sys_regs.c b/arch/arm64/kvm/sys_regs.c index 65f4c20..395b964 100644 --- a/arch/arm64/kvm/sys_regs.c +++ b/arch

[RFC PATCH v2 01/31] arm64: KVM: Hide unsupported AArch64 CPU features from guests

From: Dave Martin Currently, a guest kernel sees the true CPU feature registers (ID_*_EL1) when it reads them using MRS instructions. This means that the guest will observe features that are present in the hardware but the host doesn't understand or doesn't provide support

[RFC PATCH v2 01/31] arm64: KVM: Hide unsupported AArch64 CPU features from guests

From: Dave Martin Currently, a guest kernel sees the true CPU feature registers (ID_*_EL1) when it reads them using MRS instructions. This means that the guest will observe features that are present in the hardware but the host doesn't understand or doesn't provide support for. A guest may

Re: [RFC PATCH v2 20/38] KVM: arm64: Handle eret instruction traps

On Sun, Jul 30, 2017 at 4:00 PM, Christoffer Dall <cd...@linaro.org> wrote: > On Tue, Jul 18, 2017 at 11:58:46AM -0500, Jintack Lim wrote: >> When HCR.NV bit is set, eret instructions trap to EL2 with EC code 0x1A. >> Emulate eret instructions by setting pc and pstate. >

Re: [RFC PATCH v2 20/38] KVM: arm64: Handle eret instruction traps

On Sun, Jul 30, 2017 at 4:00 PM, Christoffer Dall wrote: > On Tue, Jul 18, 2017 at 11:58:46AM -0500, Jintack Lim wrote: >> When HCR.NV bit is set, eret instructions trap to EL2 with EC code 0x1A. >> Emulate eret instructions by setting pc and pstate. > > It may be worth

Re: [RFC PATCH v2 08/38] KVM: arm64: Add EL2 special registers to vcpu context

On Sun, Jul 30, 2017 at 3:59 PM, Christoffer Dall <cd...@linaro.org> wrote: > On Tue, Jul 18, 2017 at 11:58:34AM -0500, Jintack Lim wrote: >> To support the virtual EL2 execution, we need to maintain the EL2 >> special registers such as SPSR_EL2, ELR_EL2 and SP_EL2 in vcp

Re: [RFC PATCH v2 08/38] KVM: arm64: Add EL2 special registers to vcpu context

On Sun, Jul 30, 2017 at 3:59 PM, Christoffer Dall wrote: > On Tue, Jul 18, 2017 at 11:58:34AM -0500, Jintack Lim wrote: >> To support the virtual EL2 execution, we need to maintain the EL2 >> special registers such as SPSR_EL2, ELR_EL2 and SP_EL2 in vcpu context. >>

Re: [RFC PATCH v2 04/38] KVM: arm/arm64: Check if nested virtualization is in use

On Sun, Jul 30, 2017 at 3:59 PM, Christoffer Dall <cd...@linaro.org> wrote: > On Tue, Jul 18, 2017 at 11:58:30AM -0500, Jintack Lim wrote: >> Nested virtualizaion is in use only if all three conditions are met: >> - The architecture supports nested virtualization. >> -

Re: [RFC PATCH v2 04/38] KVM: arm/arm64: Check if nested virtualization is in use

On Sun, Jul 30, 2017 at 3:59 PM, Christoffer Dall wrote: > On Tue, Jul 18, 2017 at 11:58:30AM -0500, Jintack Lim wrote: >> Nested virtualizaion is in use only if all three conditions are met: >> - The architecture supports nested virtualization. >> - The ke

Re: [RFC PATCH v2 04/38] KVM: arm/arm64: Check if nested virtualization is in use

On Sun, Jul 30, 2017 at 3:59 PM, Christoffer Dall <cd...@linaro.org> wrote: > On Tue, Jul 18, 2017 at 11:58:30AM -0500, Jintack Lim wrote: >> Nested virtualizaion is in use only if all three conditions are met: >> - The architecture supports nested virtualization. >> -

Re: [RFC PATCH v2 04/38] KVM: arm/arm64: Check if nested virtualization is in use

On Sun, Jul 30, 2017 at 3:59 PM, Christoffer Dall wrote: > On Tue, Jul 18, 2017 at 11:58:30AM -0500, Jintack Lim wrote: >> Nested virtualizaion is in use only if all three conditions are met: >> - The architecture supports nested virtualization. >> - The ke

Re: [RFC PATCH v2 02/38] KVM: arm/arm64: Enable nested virtualization via command-line

On Sun, Jul 30, 2017 at 3:59 PM, Christoffer Dall <cd...@linaro.org> wrote: > On Tue, Jul 18, 2017 at 11:58:28AM -0500, Jintack Lim wrote: >> Add a new kernel parameter(kvm-arm.nested) to enable KVM/ARM nested >> virtualization support. This kernel parameter on arm architectur

Re: [RFC PATCH v2 02/38] KVM: arm/arm64: Enable nested virtualization via command-line

On Sun, Jul 30, 2017 at 3:59 PM, Christoffer Dall wrote: > On Tue, Jul 18, 2017 at 11:58:28AM -0500, Jintack Lim wrote: >> Add a new kernel parameter(kvm-arm.nested) to enable KVM/ARM nested >> virtualization support. This kernel parameter on arm architecture is >>

Re: [RFC PATCH v2 38/38] KVM: arm64: Respect the virtual CPTR_EL2.TCPAC setting

Hi Christoffer, On Mon, Jul 31, 2017 at 8:59 AM, Christoffer Dall <cd...@linaro.org> wrote: > On Tue, Jul 18, 2017 at 11:59:04AM -0500, Jintack Lim wrote: >> Forward CPACR_EL1 traps to the virtual EL2 if virtual CPTR_EL2 is >> configured to trap CPACR_

Re: [RFC PATCH v2 38/38] KVM: arm64: Respect the virtual CPTR_EL2.TCPAC setting

Hi Christoffer, On Mon, Jul 31, 2017 at 8:59 AM, Christoffer Dall wrote: > On Tue, Jul 18, 2017 at 11:59:04AM -0500, Jintack Lim wrote: >> Forward CPACR_EL1 traps to the virtual EL2 if virtual CPTR_EL2 is >> configured to trap CPACR_EL1 accesses from EL1. >> >> T

Re: [RFC PATCH v2 00/38] Nested Virtualization on KVM/ARM

Hi Christoffer, On Mon, Jul 31, 2017 at 9:00 AM, Christoffer Dall <cd...@linaro.org> wrote: > Hi Jintack, > > On Tue, Jul 18, 2017 at 11:58:26AM -0500, Jintack Lim wrote: >> Nested virtualization is the ability to run a virtual machine inside another >> virtual machine.

Re: [RFC PATCH v2 00/38] Nested Virtualization on KVM/ARM

Hi Christoffer, On Mon, Jul 31, 2017 at 9:00 AM, Christoffer Dall wrote: > Hi Jintack, > > On Tue, Jul 18, 2017 at 11:58:26AM -0500, Jintack Lim wrote: >> Nested virtualization is the ability to run a virtual machine inside another >> virtual machine. In other word

Re: [RFC PATCH v2 00/38] Nested Virtualization on KVM/ARM

On Fri, Jul 28, 2017 at 4:13 PM, Bandan Das <b...@redhat.com> wrote: > Jintack Lim <jintack@linaro.org> writes: > ... >>> >>> I'll share my experiment setup shortly. >> >> I summarized my experiment setup here. >> >> https://githu

Re: [RFC PATCH v2 00/38] Nested Virtualization on KVM/ARM

On Fri, Jul 28, 2017 at 4:13 PM, Bandan Das wrote: > Jintack Lim writes: > ... >>> >>> I'll share my experiment setup shortly. >> >> I summarized my experiment setup here. >> >> https://github.com/columbia/nesting-pub/wiki/Nested-virtualization-on-

Re: [RFC PATCH v2 00/38] Nested Virtualization on KVM/ARM

On Wed, Jul 19, 2017 at 4:49 AM, Christoffer Dall <cd...@linaro.org> wrote: > Hi Jintack, > > On Tue, Jul 18, 2017 at 10:23:05PM -0400, Jintack Lim wrote: >> On Tue, Jul 18, 2017 at 12:58 PM, Jintack Lim <jintack@linaro.org> wrote: >> > Nested virtualiza

Re: [RFC PATCH v2 00/38] Nested Virtualization on KVM/ARM

On Wed, Jul 19, 2017 at 4:49 AM, Christoffer Dall wrote: > Hi Jintack, > > On Tue, Jul 18, 2017 at 10:23:05PM -0400, Jintack Lim wrote: >> On Tue, Jul 18, 2017 at 12:58 PM, Jintack Lim wrote: >> > Nested virtualization is the ability to run a virtual machine inside &

Re: [RFC PATCH v2 37/38] KVM: arm64: Respect the virtual HCR_EL2.NV1 bit setting

On Tue, Jul 18, 2017 at 12:59 PM, Jintack Lim <jintack@linaro.org> wrote: > Forward ELR_EL1, SPSR_EL1 and VBAR_EL1 traps to the virtual EL2 if the > virtual HCR_EL2.NV bit is set. > > This is for recursive nested virtualization. > > Signed-off-by: Jintack Lim

Re: [RFC PATCH v2 37/38] KVM: arm64: Respect the virtual HCR_EL2.NV1 bit setting

On Tue, Jul 18, 2017 at 12:59 PM, Jintack Lim wrote: > Forward ELR_EL1, SPSR_EL1 and VBAR_EL1 traps to the virtual EL2 if the > virtual HCR_EL2.NV bit is set. > > This is for recursive nested virtualization. > > Signed-off-by: Jintack Lim This should be linaro e-mail

Re: [RFC PATCH v2 00/38] Nested Virtualization on KVM/ARM

On Tue, Jul 18, 2017 at 12:58 PM, Jintack Lim <jintack@linaro.org> wrote: > Nested virtualization is the ability to run a virtual machine inside another > virtual machine. In other words, it’s about running a hypervisor (the guest > hypervisor) on top of another hypervisor (the

Re: [RFC PATCH v2 00/38] Nested Virtualization on KVM/ARM

On Tue, Jul 18, 2017 at 12:58 PM, Jintack Lim wrote: > Nested virtualization is the ability to run a virtual machine inside another > virtual machine. In other words, it’s about running a hypervisor (the guest > hypervisor) on top of another hypervisor (the host hypervisor). > > Su

[RFC PATCH v2 00/38] Nested Virtualization on KVM/ARM

EL2 Jintack Lim (31): arm64: Add ARM64_HAS_NESTED_VIRT feature KVM: arm/arm64: Enable nested virtualization via command-line KVM: arm/arm64: Check if nested virtualization is in use KVM: arm64: Add EL2 system registers to vcpu context KVM: arm64: Add EL2 special registers to vcpu cont

[RFC PATCH v2 00/38] Nested Virtualization on KVM/ARM

EL2 Jintack Lim (31): arm64: Add ARM64_HAS_NESTED_VIRT feature KVM: arm/arm64: Enable nested virtualization via command-line KVM: arm/arm64: Check if nested virtualization is in use KVM: arm64: Add EL2 system registers to vcpu context KVM: arm64: Add EL2 special registers to vcpu cont

[RFC PATCH v2 02/38] KVM: arm/arm64: Enable nested virtualization via command-line

is completed. Just add this parameter first to use it when implementing nested virtualization support. Signed-off-by: Jintack Lim <jintack@linaro.org> --- Documentation/admin-guide/kernel-parameters.txt | 4 arch/arm/include/asm/kvm_host.h | 4 arch/arm64/inclu

[RFC PATCH v2 02/38] KVM: arm/arm64: Enable nested virtualization via command-line

is completed. Just add this parameter first to use it when implementing nested virtualization support. Signed-off-by: Jintack Lim --- Documentation/admin-guide/kernel-parameters.txt | 4 arch/arm/include/asm/kvm_host.h | 4 arch/arm64/include/asm/kvm_host.h

[RFC PATCH v2 01/38] arm64: Add ARM64_HAS_NESTED_VIRT feature

Add a new ARM64_HAS_NESTED_VIRT feature to indicate that the CPU has the ARMv8.3 nested virtualization capability. This will be used to support nested virtualization in KVM. Signed-off-by: Jintack Lim <jintack@linaro.org> --- arch/arm64/include/asm/cpucaps.h | 3 ++- arch/arm64/inclu

[RFC PATCH v2 01/38] arm64: Add ARM64_HAS_NESTED_VIRT feature

Add a new ARM64_HAS_NESTED_VIRT feature to indicate that the CPU has the ARMv8.3 nested virtualization capability. This will be used to support nested virtualization in KVM. Signed-off-by: Jintack Lim --- arch/arm64/include/asm/cpucaps.h | 3 ++- arch/arm64/include/asm/sysreg.h | 1 + arch

[RFC PATCH v2 04/38] KVM: arm/arm64: Check if nested virtualization is in use

Nested virtualizaion is in use only if all three conditions are met: - The architecture supports nested virtualization. - The kernel parameter is set. - The userspace uses nested virtualiztion feature. Signed-off-by: Jintack Lim <jintack@linaro.org> --- arch/arm/include/asm/kvm_host.h

[RFC PATCH v2 04/38] KVM: arm/arm64: Check if nested virtualization is in use

Nested virtualizaion is in use only if all three conditions are met: - The architecture supports nested virtualization. - The kernel parameter is set. - The userspace uses nested virtualiztion feature. Signed-off-by: Jintack Lim --- arch/arm/include/asm/kvm_host.h | 11 +++ arch/arm64

[RFC PATCH v2 07/38] KVM: arm64: Add EL2 system registers to vcpu context

. This patch doesn't set the NV bit yet. It will be set in a later patch once nested virtualization support is completed. Signed-off-by: Jintack Lim <jintack@linaro.org> --- arch/arm64/include/asm/kvm_host.h | 30 +++- arch/arm64/include/asm/sysreg.h

[RFC PATCH v2 07/38] KVM: arm64: Add EL2 system registers to vcpu context

. This patch doesn't set the NV bit yet. It will be set in a later patch once nested virtualization support is completed. Signed-off-by: Jintack Lim --- arch/arm64/include/asm/kvm_host.h | 30 +++- arch/arm64/include/asm/sysreg.h | 37 + arch/arm64/kvm/sys_regs.c

[RFC PATCH v2 06/38] KVM: arm64: Add vcpu_mode_el2 primitive to support nesting

From: Christoffer Dall When running a nested hypervisor we occasionally have to figure out if the mode we are switching into is the virtual EL2 mode or a regular EL0/1 mode. Signed-off-by: Christoffer Dall ---

[RFC PATCH v2 06/38] KVM: arm64: Add vcpu_mode_el2 primitive to support nesting

From: Christoffer Dall When running a nested hypervisor we occasionally have to figure out if the mode we are switching into is the virtual EL2 mode or a regular EL0/1 mode. Signed-off-by: Christoffer Dall --- arch/arm/include/asm/kvm_emulate.h | 6 ++

  1   2   3   4   5   >