Re: [PATCH 3/3] net: stmmac: Use AVB mode by default

Às 4:42 PM de 3/21/2017, Thierry Reding escreveu: > On Tue, Mar 21, 2017 at 03:23:00PM +0000, Joao Pinto wrote: >> Às 3:12 PM de 3/21/2017, Thierry Reding escreveu: >>> From: Thierry Reding >>> >>> Prior to the recent multi-queue changes the driver would con

Re: [PATCH 3/3] net: stmmac: Use AVB mode by default

Às 3:12 PM de 3/21/2017, Thierry Reding escreveu: > From: Thierry Reding > > Prior to the recent multi-queue changes the driver would configure the > queues to use the AVB mode, but the mode then got switched to DCB. The > hardware still works fine in DCB mode, but my testing

Re: [PATCH 3/3] net: stmmac: Use AVB mode by default

Às 3:12 PM de 3/21/2017, Thierry Reding escreveu: > From: Thierry Reding > > Prior to the recent multi-queue changes the driver would configure the > queues to use the AVB mode, but the mode then got switched to DCB. The > hardware still works fine in DCB mode, but my testing capabilities are >

Re: [PATCH 2/3] net: stmmac: Restore DT backwards-compatibility

* snps,mtl-rx-config or snps,mtl-tx-config properties, we fall back > + * to one RX and TX queues each. > + */ > + plat->rx_queues_to_use = 1; > + plat->tx_queues_to_use = 1; > + > rx_node = of_parse_phandle(pdev->dev.of_node, "snps,mtl-rx-config", 0); > if (!rx_node) > return; > Acked-By: Joao Pinto <jpi...@synopsys.com>

Re: [PATCH 2/3] net: stmmac: Restore DT backwards-compatibility

we fall back > + * to one RX and TX queues each. > + */ > + plat->rx_queues_to_use = 1; > + plat->tx_queues_to_use = 1; > + > rx_node = of_parse_phandle(pdev->dev.of_node, "snps,mtl-rx-config", 0); > if (!rx_node) > return; > Acked-By: Joao Pinto

Re: [PATCH 1/3] net: stmmac: Always enable MAC RX queues

needs the enable operation. >>> But came to my attention a setup that has 1 RX queue and 2 TX queues, which enables multiple queues mechanism inside the core (even with 1 RX) and so RX needs to be enabled. Because of that I agree with this patch. Acked-By: Joao Pinto <jpi...@synopsys.com>

Re: [PATCH 1/3] net: stmmac: Always enable MAC RX queues

my attention a setup that has 1 RX queue and 2 TX queues, which enables multiple queues mechanism inside the core (even with 1 RX) and so RX needs to be enabled. Because of that I agree with this patch. Acked-By: Joao Pinto

Re: linux-next-20170320 break stmmac on dwmac-sunxi

Hi Peppe, Às 2:39 PM de 3/21/2017, Giuseppe CAVALLARO escreveu: > Hello Corentin > > yes, bisect process is really good approach to me. Pls give us more details. > Recently the multi DMA channel logic has been added so it could be that > something is needed to allow your platform to manage the

Re: linux-next-20170320 break stmmac on dwmac-sunxi

Hi Peppe, Às 2:39 PM de 3/21/2017, Giuseppe CAVALLARO escreveu: > Hello Corentin > > yes, bisect process is really good approach to me. Pls give us more details. > Recently the multi DMA channel logic has been added so it could be that > something is needed to allow your platform to manage the

Re: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe

Às 5:44 PM de 3/20/2017, Niklas Cassel escreveu: > On 03/20/2017 06:42 PM, Joao Pinto wrote: >> Às 5:29 PM de 3/20/2017, Niklas Cassel escreveu: >>> From: Niklas Cassel <niklas.cas...@axis.com> >>> >>> It is usually possible to do >>> ethtool -s a

Re: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe

Às 5:44 PM de 3/20/2017, Niklas Cassel escreveu: > On 03/20/2017 06:42 PM, Joao Pinto wrote: >> Às 5:29 PM de 3/20/2017, Niklas Cassel escreveu: >>> From: Niklas Cassel >>> >>> It is usually possible to do >>> ethtool -s autoneg on >>> so that

Re: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe

Às 5:29 PM de 3/20/2017, Niklas Cassel escreveu: > From: Niklas Cassel > > It is usually possible to do > ethtool -s autoneg on > so that you trigger an autoneg before calling > ip link set dev eth0 up > > However, stmmac returns -EBUSY if !netif_running. > The only

Re: [PATCH net-next] stmmac: call stmmac_init_phy from stmmac_dvr_probe

Às 5:29 PM de 3/20/2017, Niklas Cassel escreveu: > From: Niklas Cassel > > It is usually possible to do > ethtool -s autoneg on > so that you trigger an autoneg before calling > ip link set dev eth0 up > > However, stmmac returns -EBUSY if !netif_running. > The only reason for this appears to

Re: [RESEND PATCH v3 4/7] PCI: dwc: all: Modify dbi accessors to take dbi_base as argument

Às 11:36 AM de 3/10/2017, Kishon Vijay Abraham I escreveu: > Hi, > > On Thursday 09 March 2017 08:35 PM, Niklas Cassel wrote: >> >> >> On 03/09/2017 03:48 PM, Niklas Cassel wrote: >>> On 03/09/2017 07:39 AM, Kishon Vijay Abraham I wrote: dwc has 2 dbi address space labeled dbics and dbics2.

Re: [RESEND PATCH v3 4/7] PCI: dwc: all: Modify dbi accessors to take dbi_base as argument

Às 11:36 AM de 3/10/2017, Kishon Vijay Abraham I escreveu: > Hi, > > On Thursday 09 March 2017 08:35 PM, Niklas Cassel wrote: >> >> >> On 03/09/2017 03:48 PM, Niklas Cassel wrote: >>> On 03/09/2017 07:39 AM, Kishon Vijay Abraham I wrote: dwc has 2 dbi address space labeled dbics and dbics2.

Re: [PATCH 4/7] net: stmmac: Parse FIFO sizes from feature registers

Às 7:41 PM de 3/9/2017, Thierry Reding escreveu: > On Thu, Mar 02, 2017 at 03:09:11PM +0000, Joao Pinto wrote: >> Hi Thierry, >> >> Às 5:24 PM de 2/23/2017, Thierry Reding escreveu: >>> From: Thierry Reding <tred...@nvidia.com> >>> >>>

Re: [PATCH 4/7] net: stmmac: Parse FIFO sizes from feature registers

Às 7:41 PM de 3/9/2017, Thierry Reding escreveu: > On Thu, Mar 02, 2017 at 03:09:11PM +0000, Joao Pinto wrote: >> Hi Thierry, >> >> Às 5:24 PM de 2/23/2017, Thierry Reding escreveu: >>> From: Thierry Reding >>> >>> New version of this core encode th

Re: [RESEND PATCH v3 6/7] PCI: dwc: designware: Move _unroll configurations to a separate function

base, index, > -PCIE_ATU_UNR_REGION_CTRL2); > - else > - val = dw_pcie_read_dbi(pci, base, PCIE_ATU_CR2, 0x4); > - > + val = dw_pcie_read_dbi(pci, base, PCIE_ATU_CR2, 0x4); > if (val == PCIE_ATU_ENABLE) > return; > > usleep_range(LINK_WAIT_IATU_MIN, LINK_WAIT_IATU_MAX); > } > - dev_err(pci->dev, "iATU is not being enabled\n"); > + dev_err(pci->dev, "outbound iATU is not being enabled\n"); > } > > int dw_pcie_wait_for_link(struct dw_pcie *pci) > Acked-By: Joao Pinto <jpi...@synopsys.com>

Re: [RESEND PATCH v3 6/7] PCI: dwc: designware: Move _unroll configurations to a separate function

x, > -PCIE_ATU_UNR_REGION_CTRL2); > - else > - val = dw_pcie_read_dbi(pci, base, PCIE_ATU_CR2, 0x4); > - > + val = dw_pcie_read_dbi(pci, base, PCIE_ATU_CR2, 0x4); > if (val == PCIE_ATU_ENABLE) > return; > > usleep_range(LINK_WAIT_IATU_MIN, LINK_WAIT_IATU_MAX); > } > - dev_err(pci->dev, "iATU is not being enabled\n"); > + dev_err(pci->dev, "outbound iATU is not being enabled\n"); > } > > int dw_pcie_wait_for_link(struct dw_pcie *pci) > Acked-By: Joao Pinto

Re: [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support

Hi Christoph, Às 7:14 PM de 3/8/2017, Christoph Hellwig escreveu: > On Wed, Mar 08, 2017 at 03:32:03PM +0000, Joao Pinto wrote: >> #define PCIE_GET_ATU_INB_UNR_REG_ADDR(region, register) \ >> ((0x3 <&l

Re: [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support

Hi Christoph, Às 7:14 PM de 3/8/2017, Christoph Hellwig escreveu: > On Wed, Mar 08, 2017 at 03:32:03PM +0000, Joao Pinto wrote: >> #define PCIE_GET_ATU_INB_UNR_REG_ADDR(region, register) \ >> ((0x3 <&l

Re: [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support

Às 1:31 PM de 3/8/2017, Kishon Vijay Abraham I escreveu: > Hi, > > On Wednesday 08 March 2017 05:07 PM, Joao Pinto wrote: >> Às 11:35 AM de 3/8/2017, Kishon Vijay Abraham I escreveu: >>> Hi, >>> >>> On Wednesday 08 March 2017 05:02 PM, Joao Pinto wrote

Re: [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support

Às 1:31 PM de 3/8/2017, Kishon Vijay Abraham I escreveu: > Hi, > > On Wednesday 08 March 2017 05:07 PM, Joao Pinto wrote: >> Às 11:35 AM de 3/8/2017, Kishon Vijay Abraham I escreveu: >>> Hi, >>> >>> On Wednesday 08 March 2017 05:02 PM, Joao Pinto wrote

Re: [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support

Às 3:32 PM de 3/8/2017, Joao Pinto escreveu: > Às 1:31 PM de 3/8/2017, Kishon Vijay Abraham I escreveu: >> Hi, >> >> On Wednesday 08 March 2017 05:07 PM, Joao Pinto wrote: >>> Às 11:35 AM de 3/8/2017, Kishon Vijay Abraham I escreveu: >>>> Hi, >>&

Re: [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support

Às 3:32 PM de 3/8/2017, Joao Pinto escreveu: > Às 1:31 PM de 3/8/2017, Kishon Vijay Abraham I escreveu: >> Hi, >> >> On Wednesday 08 March 2017 05:07 PM, Joao Pinto wrote: >>> Às 11:35 AM de 3/8/2017, Kishon Vijay Abraham I escreveu: >>>> Hi, >>&

Re: [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support

Às 11:35 AM de 3/8/2017, Kishon Vijay Abraham I escreveu: > Hi, > > On Wednesday 08 March 2017 05:02 PM, Joao Pinto wrote: >> >> Hi Kishon, >> >>>> Can you provide PCIE_GET_ATU_INB_UNR_REG_OFFSET (similar to >>>> PCIE_GET_ATU_OUTB_UNR_

Re: [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support

Às 11:35 AM de 3/8/2017, Kishon Vijay Abraham I escreveu: > Hi, > > On Wednesday 08 March 2017 05:02 PM, Joao Pinto wrote: >> >> Hi Kishon, >> >>>> Can you provide PCIE_GET_ATU_INB_UNR_REG_OFFSET (similar to >>>> PCIE_GET_ATU_OUTB_UNR_

Re: [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support

Hi Kishon, >> Can you provide PCIE_GET_ATU_INB_UNR_REG_OFFSET (similar to >> PCIE_GET_ATU_OUTB_UNR_REG_OFFSET)? > > Yes of course, I will send you the definition soon. As promissed here is the definition for Inbound: +/* register address builder */ +#define

Re: [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support

Hi Kishon, >> Can you provide PCIE_GET_ATU_INB_UNR_REG_OFFSET (similar to >> PCIE_GET_ATU_OUTB_UNR_REG_OFFSET)? > > Yes of course, I will send you the definition soon. As promissed here is the definition for Inbound: +/* register address builder */ +#define

Re: [PATCH v2 5/7] PCI: dwc: all: Modify dbi accessors to access data of 4/2/1 bytes

Murali Karicheri <m-kariche...@ti.com> > Cc: Thomas Petazzoni <thomas.petazz...@free-electrons.com> > Cc: Niklas Cassel <niklas.cas...@axis.com> > Cc: Jesper Nilsson <jesper.nils...@axis.com> > Cc: Joao Pinto <joao.pi...@synopsys.com> > Cc: Zhou Wang <wa

Re: [PATCH v2 5/7] PCI: dwc: all: Modify dbi accessors to access data of 4/2/1 bytes

cessors must > be used to access data of size 2. This is in preparation for > adding endpoint mode support to designware driver. > > Cc: Jingoo Han > Cc: Richard Zhu > Cc: Lucas Stach > Cc: Murali Karicheri > Cc: Thomas Petazzoni > Cc: Niklas Cassel > Cc: Jesper

Re: [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support

Hi Kishon, Às 5:18 AM de 3/7/2017, Kishon Vijay Abraham I escreveu: > Hi Joao, > > On Friday 17 February 2017 10:50 PM, Joao Pinto wrote: >> Às 9:50 AM de 2/17/2017, Kishon Vijay Abraham I escreveu: >>> Add endpoint mode support to designware driver. This uses the >

Re: [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support

Hi Kishon, Às 5:18 AM de 3/7/2017, Kishon Vijay Abraham I escreveu: > Hi Joao, > > On Friday 17 February 2017 10:50 PM, Joao Pinto wrote: >> Às 9:50 AM de 2/17/2017, Kishon Vijay Abraham I escreveu: >>> Add endpoint mode support to designware driver. This uses the >

Re: [PATCH v2 4/7] PCI: dwc: all: Modify dbi accessors to take dbi_base as argument

azzoni <thomas.petazz...@free-electrons.com> > Cc: Niklas Cassel <niklas.cas...@axis.com> > Cc: Jesper Nilsson <jesper.nils...@axis.com> > Cc: Joao Pinto <joao.pi...@synopsys.com> > Cc: Zhou Wang <wangzh...@hisilicon.com> > Cc: Gabriele Paoloni <gabriele

Re: [PATCH v2 4/7] PCI: dwc: all: Modify dbi accessors to take dbi_base as argument

e of EP mode. This is in preparation for adding EP mode support > to dwc driver. > > Cc: Jingoo Han > Cc: Richard Zhu > Cc: Lucas Stach > Cc: Murali Karicheri > Cc: Thomas Petazzoni > Cc: Niklas Cassel > Cc: Jesper Nilsson > Cc: Joao Pinto > Cc: Zhou Wang > Cc: Gabriele

Re: [PATCH v2 3/7] PCI: dwc: artpec6: Populate cpu_addr_fixup ops

gt; + .cpu_addr_fixup = artpec6_pcie_cpu_addr_fixup, > +}; > + > static int artpec6_pcie_probe(struct platform_device *pdev) > { > struct device *dev = >dev; > @@ -252,6 +256,7 @@ static int artpec6_pcie_probe(struct platform_device > *pdev) > return -ENOMEM; > > pci->dev = dev; > + pci->ops = _pcie_ops; > > artpec6_pcie->pci = pci; > > Simpler, no doubt. Acked-By: Joao Pinto <jpi...@synopsys.com>

Re: [PATCH v2 3/7] PCI: dwc: artpec6: Populate cpu_addr_fixup ops

xup, > +}; > + > static int artpec6_pcie_probe(struct platform_device *pdev) > { > struct device *dev = >dev; > @@ -252,6 +256,7 @@ static int artpec6_pcie_probe(struct platform_device > *pdev) > return -ENOMEM; > > pci->dev = dev; > + pci->ops = _pcie_ops; > > artpec6_pcie->pci = pci; > > Simpler, no doubt. Acked-By: Joao Pinto

Re: [PATCH v2 2/7] PCI: dwc: dra7xx: Populate cpu_addr_fixup ops

sh_link(dra7xx); > @@ -329,6 +329,7 @@ static int __init dra7xx_add_pcie_port(struct dra7xx_pcie > *dra7xx, > } > > static const struct dw_pcie_ops dw_pcie_ops = { > + .cpu_addr_fixup = dra7xx_pcie_cpu_addr_fixup, > .link_up = dra7xx_pcie_link_up, > }; > > Simpler, no doubt. Acked-By: Joao Pinto <jpi...@synopsys.com>

Re: [PATCH v2 2/7] PCI: dwc: dra7xx: Populate cpu_addr_fixup ops

gt; @@ -329,6 +329,7 @@ static int __init dra7xx_add_pcie_port(struct dra7xx_pcie > *dra7xx, > } > > static const struct dw_pcie_ops dw_pcie_ops = { > + .cpu_addr_fixup = dra7xx_pcie_cpu_addr_fixup, > .link_up = dra7xx_pcie_link_up, > }; > > Simpler, no doubt. Acked-By: Joao Pinto

Re: [PATCH v2 1/7] PCI: dwc: designware: Add new *ops* for cpu addr fixup

,7 @@ struct pcie_port { > }; > > struct dw_pcie_ops { > + u64 (*cpu_addr_fixup)(u64 cpu_addr); > u32 (*readl_dbi)(struct dw_pcie *pcie, u32 reg); > void(*writel_dbi)(struct dw_pcie *pcie, u32 reg, u32 val); > int (*link_up)(struct dw_pcie *pcie); > Looks good. Acked-by: Joao Pinto <jpi...@synopsys.com>

Re: [PATCH v2 1/7] PCI: dwc: designware: Add new *ops* for cpu addr fixup

{ > }; > > struct dw_pcie_ops { > + u64 (*cpu_addr_fixup)(u64 cpu_addr); > u32 (*readl_dbi)(struct dw_pcie *pcie, u32 reg); > void(*writel_dbi)(struct dw_pcie *pcie, u32 reg, u32 val); > int (*link_up)(struct dw_pcie *pcie); > Looks good. Acked-by: Joao Pinto

Re: [PATCH 7/7] net: stmmac: dwc-qos: Add Tegra186 support

Às 5:24 PM de 2/23/2017, Thierry Reding escreveu: > From: Thierry Reding > > The NVIDIA Tegra186 SoC contains an instance of the Synopsys DWC > ethernet QOS IP core. The binding that it uses is slightly different > from existing ones because of the integration (clocks,

Re: [PATCH 7/7] net: stmmac: dwc-qos: Add Tegra186 support

Às 5:24 PM de 2/23/2017, Thierry Reding escreveu: > From: Thierry Reding > > The NVIDIA Tegra186 SoC contains an instance of the Synopsys DWC > ethernet QOS IP core. The binding that it uses is slightly different > from existing ones because of the integration (clocks, resets, ...). > >

Re: [PATCH 6/7] net: stmmac: dwc-qos: Split out ->probe() and ->remove()

+ const struct dwc_eth_dwmac_data *data; > + int err; > + > + data = of_device_get_match_data(>dev); > + > + err = stmmac_dvr_remove(>dev); > + if (err < 0) > + dev_err(>dev, "failed to remove platform: %d\n", err); > + > + err = data->remove(pdev); > + if (err < 0) > + dev_err(>dev, "failed to remove subdriver: %d\n", err); > + > + stmmac_remove_config_dt(pdev, priv->plat); > + > + return err; > } > > static const struct of_device_id dwc_eth_dwmac_match[] = { > - { .compatible = "snps,dwc-qos-ethernet-4.10", }, > + { .compatible = "snps,dwc-qos-ethernet-4.10", .data = _qos_data }, > { } > }; > MODULE_DEVICE_TABLE(of, dwc_eth_dwmac_match); > Reviewed-By: Joao Pinto <jpi...@synopsys.com>

Re: [PATCH 6/7] net: stmmac: dwc-qos: Split out ->probe() and ->remove()

+ int err; > + > + data = of_device_get_match_data(>dev); > + > + err = stmmac_dvr_remove(>dev); > + if (err < 0) > + dev_err(>dev, "failed to remove platform: %d\n", err); > + > + err = data->remove(pdev); > + if (err < 0) > + dev_err(>dev, "failed to remove subdriver: %d\n", err); > + > + stmmac_remove_config_dt(pdev, priv->plat); > + > + return err; > } > > static const struct of_device_id dwc_eth_dwmac_match[] = { > - { .compatible = "snps,dwc-qos-ethernet-4.10", }, > + { .compatible = "snps,dwc-qos-ethernet-4.10", .data = _qos_data }, > { } > }; > MODULE_DEVICE_TABLE(of, dwc_eth_dwmac_match); > Reviewed-By: Joao Pinto

Re: [PATCH 5/7] net: stmmac: Program RX queue size and flow control

Às 5:24 PM de 2/23/2017, Thierry Reding escreveu: > From: Thierry Reding > > Program the receive queue size based on the RX FIFO size and enable > hardware flow control for large FIFOs. > > Signed-off-by: Thierry Reding > --- >

Re: [PATCH 5/7] net: stmmac: Program RX queue size and flow control

Às 5:24 PM de 2/23/2017, Thierry Reding escreveu: > From: Thierry Reding > > Program the receive queue size based on the RX FIFO size and enable > hardware flow control for large FIFOs. > > Signed-off-by: Thierry Reding > --- > drivers/net/ethernet/stmicro/stmmac/dwmac4.h | 12 +++ >

Re: [PATCH 4/7] net: stmmac: Parse FIFO sizes from feature registers

Hi Thierry, Às 5:24 PM de 2/23/2017, Thierry Reding escreveu: > From: Thierry Reding > > New version of this core encode the FIFO sizes in one of the feature > registers. Use these sizes as default, but still allow device tree to > override them for backwards compatibility.

Re: [PATCH 4/7] net: stmmac: Parse FIFO sizes from feature registers

Hi Thierry, Às 5:24 PM de 2/23/2017, Thierry Reding escreveu: > From: Thierry Reding > > New version of this core encode the FIFO sizes in one of the feature > registers. Use these sizes as default, but still allow device tree to > override them for backwards compatibility. > > Signed-off-by:

Re: [PATCH 2/7] net: stmmac: Balance PTP reference clock enable/disable

atform_device *pdev, > const char **mac) > plat->clk_ptp_ref = NULL; > dev_warn(>dev, "PTP uses main clock\n"); > } else { > - clk_prepare_enable(plat->clk_ptp_ref); > plat->clk_ptp_rate = clk_get_rate(plat->clk_ptp_ref); > dev_dbg(>dev, "PTP rate %d\n", plat->clk_ptp_rate); > } > Reviewed-By: Joao Pinto <jpi...@synopsys.com>

Re: [PATCH 2/7] net: stmmac: Balance PTP reference clock enable/disable

plat->clk_ptp_ref = NULL; > dev_warn(>dev, "PTP uses main clock\n"); > } else { > - clk_prepare_enable(plat->clk_ptp_ref); > plat->clk_ptp_rate = clk_get_rate(plat->clk_ptp_ref); > dev_dbg(>dev, "PTP rate %d\n", plat->clk_ptp_rate); > } > Reviewed-By: Joao Pinto

Re: [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support

Às 9:50 AM de 2/17/2017, Kishon Vijay Abraham I escreveu: > Add endpoint mode support to designware driver. This uses the > EP Core layer introduced recently to add endpoint mode support. > *Any* function driver can now use this designware device > in order to achieve the EP functionality. > >

Re: [PATCH v2 08/22] PCI: dwc: designware: Add EP mode support

Às 9:50 AM de 2/17/2017, Kishon Vijay Abraham I escreveu: > Add endpoint mode support to designware driver. This uses the > EP Core layer introduced recently to add endpoint mode support. > *Any* function driver can now use this designware device > in order to achieve the EP functionality. > >

Re: [PATCH v2 04/22] Documentation: PCI: Guide to use pci endpoint configfs

inside epf directory.) > + > +| vendorid > +| deviceid > +| revid > +| progif_code > +| subclass_code > +| baseclass_code > +| cache_line_size > + | subsys_vendor_id > +| subsys_id > +| interrupt_pin > + > +The following entry identifies the function driver that is bound to the > +function device > + | function > + > +[1] -> Documentation/PCI/endpoint/pci-endpoint.txt > +[4] -> Documentation/PCI/endpoint/function/binding/ > Good content. Acked-By: Joao Pinto <jpi...@synopsys.com>

Re: [PATCH v2 04/22] Documentation: PCI: Guide to use pci endpoint configfs

| vendorid > +| deviceid > +| revid > +| progif_code > +| subclass_code > +| baseclass_code > +| cache_line_size > +| subsys_vendor_id > +| subsys_id > +| interrupt_pin > + > +The following entry identifies the function driver that is bound to the > +function device > + | function > + > +[1] -> Documentation/PCI/endpoint/pci-endpoint.txt > +[4] -> Documentation/PCI/endpoint/function/binding/ > Good content. Acked-By: Joao Pinto

Re: [PATCH v2 01/22] PCI: endpoint: Add EP core layer to enable EP controller and EP functions

Às 11:37 AM de 2/17/2017, Kishon Vijay Abraham I escreveu: > Hi Joao, > > On Friday 17 February 2017 04:56 PM, Joao Pinto wrote: >> >> Hi Kishon, >> >> Às 9:50 AM de 2/17/2017, Kishon Vijay Abraham I escreveu: >>> Introduce a new EP core layer in order

Re: [PATCH v2 01/22] PCI: endpoint: Add EP core layer to enable EP controller and EP functions

Às 11:37 AM de 2/17/2017, Kishon Vijay Abraham I escreveu: > Hi Joao, > > On Friday 17 February 2017 04:56 PM, Joao Pinto wrote: >> >> Hi Kishon, >> >> Às 9:50 AM de 2/17/2017, Kishon Vijay Abraham I escreveu: >>> Introduce a new EP core layer in order

Re: [PATCH v2 02/22] Documentation: PCI: Guide to use PCI Endpoint Core Layer

+ EPC device has established the connection to the host. > + > +2.2.2 Other APIs > +There are other APIs provided by the EPF library. These are used to notify > +the function driver when the EPF device is bound to the EPC device. > +pci-ep-cfs.c can be used as reference for using these APIs. > + > +*) pci_epf_create() > + > + Create a new PCI EPF device by passing the name of the PCI EPF device. > + This name will be used to bind the the EPF device to a EPF driver. > + > +*) pci_epf_destroy() > + > + Destroy the created PCI EPF device. > + > +*) pci_epf_bind() > + > + pci_epf_bind() should be invoked when the EPF device has been bound to > + a EPC device. > + > +*) pci_epf_unbind() > + > + pci_epf_unbind() should be invoked when the binding between EPC device > + and EPF device is lost. > Good initial reference guide. Acked-By: Joao Pinto <jpi...@synopsys.com>

Re: [PATCH v2 02/22] Documentation: PCI: Guide to use PCI Endpoint Core Layer

nnection to the host. > + > +2.2.2 Other APIs > +There are other APIs provided by the EPF library. These are used to notify > +the function driver when the EPF device is bound to the EPC device. > +pci-ep-cfs.c can be used as reference for using these APIs. > + > +*) pci_epf_create() > + > + Create a new PCI EPF device by passing the name of the PCI EPF device. > + This name will be used to bind the the EPF device to a EPF driver. > + > +*) pci_epf_destroy() > + > + Destroy the created PCI EPF device. > + > +*) pci_epf_bind() > + > + pci_epf_bind() should be invoked when the EPF device has been bound to > + a EPC device. > + > +*) pci_epf_unbind() > + > + pci_epf_unbind() should be invoked when the binding between EPC device > + and EPF device is lost. > Good initial reference guide. Acked-By: Joao Pinto

Re: [PATCH v2 01/22] PCI: endpoint: Add EP core layer to enable EP controller and EP functions

Hi Kishon, Às 9:50 AM de 2/17/2017, Kishon Vijay Abraham I escreveu: > Introduce a new EP core layer in order to support endpoint functions > in linux kernel. This comprises of EPC library > (Endpoint Controller Library) and EPF library (Endpoint > Function Library). EPC library implements

Re: [PATCH v2 01/22] PCI: endpoint: Add EP core layer to enable EP controller and EP functions

Hi Kishon, Às 9:50 AM de 2/17/2017, Kishon Vijay Abraham I escreveu: > Introduce a new EP core layer in order to support endpoint functions > in linux kernel. This comprises of EPC library > (Endpoint Controller Library) and EPF library (Endpoint > Function Library). EPC library implements

Re: [PATCH 00/17] net: stmmac: misc fix

Às 10:33 AM de 1/31/2017, Giuseppe CAVALLARO escreveu: > On 1/31/2017 11:23 AM, Joao Pinto wrote: >> >> Hi Peppe, >> >> Às 10:00 AM de 1/31/2017, Giuseppe CAVALLARO escreveu: >>> Hello Corentin >>> >>> On 1/31/2017 10:11 AM, Corentin La

Re: [PATCH 00/17] net: stmmac: misc fix

Às 10:33 AM de 1/31/2017, Giuseppe CAVALLARO escreveu: > On 1/31/2017 11:23 AM, Joao Pinto wrote: >> >> Hi Peppe, >> >> Às 10:00 AM de 1/31/2017, Giuseppe CAVALLARO escreveu: >>> Hello Corentin >>> >>> On 1/31/2017 10:11 AM, Corentin La

Re: [PATCH 00/17] net: stmmac: misc fix

Hi Peppe, Às 10:00 AM de 1/31/2017, Giuseppe CAVALLARO escreveu: > Hello Corentin > > On 1/31/2017 10:11 AM, Corentin Labbe wrote: >> Hello >> >> I am currently working on dwmac-sun8i glue driver for Allwinner H3/A83T/A64. >> This serie is the result of all minor problem found in the stmmac

Re: [PATCH 00/17] net: stmmac: misc fix

Hi Peppe, Às 10:00 AM de 1/31/2017, Giuseppe CAVALLARO escreveu: > Hello Corentin > > On 1/31/2017 10:11 AM, Corentin Labbe wrote: >> Hello >> >> I am currently working on dwmac-sun8i glue driver for Allwinner H3/A83T/A64. >> This serie is the result of all minor problem found in the stmmac

Re: [RFC PATCH] net: stmicro: eQOS IP Core

Às 4:34 PM de 1/20/2017, David Miller escreveu: > From: Joao Pinto <joao.pi...@synopsys.com> > Date: Fri, 20 Jan 2017 16:30:41 + > >> Charade of renames? It is a bit strong, don't you agree? > > Not at all. To avoid this kind of "charade" comments,

Re: [RFC PATCH] net: stmicro: eQOS IP Core

Às 4:34 PM de 1/20/2017, David Miller escreveu: > From: Joao Pinto > Date: Fri, 20 Jan 2017 16:30:41 + > >> Charade of renames? It is a bit strong, don't you agree? > > Not at all. To avoid this kind of "charade" comments, I sent an RFC, not an off

Re: [RFC PATCH] net: stmicro: eQOS IP Core

Às 4:20 PM de 1/20/2017, David Miller escreveu: > From: Joao Pinto <joao.pi...@synopsys.com> > Date: Fri, 20 Jan 2017 12:27:33 + > >> For historical reasons the Designware eQOS IP Core started in version 4.x, >> instead of starting in 1.x. This caused some misun

Re: [RFC PATCH] net: stmicro: eQOS IP Core

Às 4:20 PM de 1/20/2017, David Miller escreveu: > From: Joao Pinto > Date: Fri, 20 Jan 2017 12:27:33 + > >> For historical reasons the Designware eQOS IP Core started in version 4.x, >> instead of starting in 1.x. This caused some misunderstanding, which resulted

Re: [PATCH] stmmac: adding EEE to GMAC4

Sorry, please ignore, wrong patch file. Joao Pinto Às 6:01 AM de 1/19/2017, Rayagond Kokatanur escreveu: > On Thu, Dec 29, 2016 at 10:40 PM, Joao Pinto <joao.pi...@synopsys.com> wrote: >> This patch adds Energy Efficiency Ethernet to GMAC4. >> >> Signed-off-by: Joao

Re: [PATCH] stmmac: adding EEE to GMAC4

Sorry, please ignore, wrong patch file. Joao Pinto Às 6:01 AM de 1/19/2017, Rayagond Kokatanur escreveu: > On Thu, Dec 29, 2016 at 10:40 PM, Joao Pinto wrote: >> This patch adds Energy Efficiency Ethernet to GMAC4. >> >> Signed-off-by: Joao Pinto >> --- >> dr

Re: [PATCH] stmmac: adding EEE to GMAC4

Hi Rayagond, Às 6:01 AM de 1/19/2017, Rayagond Kokatanur escreveu: > On Thu, Dec 29, 2016 at 10:40 PM, Joao Pinto <joao.pi...@synopsys.com> wrote: >> This patch adds Energy Efficiency Ethernet to GMAC4. >> >> Signed-off-by: Joao Pinto <jpi...@synopsys.com> >&g

Re: [PATCH] stmmac: adding EEE to GMAC4

Hi Rayagond, Às 6:01 AM de 1/19/2017, Rayagond Kokatanur escreveu: > On Thu, Dec 29, 2016 at 10:40 PM, Joao Pinto wrote: >> This patch adds Energy Efficiency Ethernet to GMAC4. >> >> Signed-off-by: Joao Pinto >> --- >> drivers/net/ethernet/stmicro/stmmac/dwm

Re: How to improve PCI bug tracking?

Hello, Às 10:53 PM de 1/18/2017, Bjorn Helgaas escreveu: > I want to improve PCI bug tracking. It feels like our bugs don't get > the attention they need, and I'm soliciting ideas for how to improve > this. > > Current situation: > > - People often report bugs via email to linux-pci. I

Re: How to improve PCI bug tracking?

Hello, Às 10:53 PM de 1/18/2017, Bjorn Helgaas escreveu: > I want to improve PCI bug tracking. It feels like our bugs don't get > the attention they need, and I'm soliciting ideas for how to improve > this. > > Current situation: > > - People often report bugs via email to linux-pci. I

Re: [PATCH] pcie: ti: Provide patch to force GEN1 PCIe operation

Hello, Às 11:38 AM de 1/17/2017, Lukasz Majewski escreveu: > Hi Joao, > > Thank you for your reply. > >> Às 10:43 AM de 1/17/2017, Joao Pinto escreveu: >>> >>> Hi Lukasz, >>> >>> Às 9:44 PM de 1/16/2017, Lukasz Majewski escreveu: >>&

Re: [PATCH] pcie: ti: Provide patch to force GEN1 PCIe operation

Hello, Às 11:38 AM de 1/17/2017, Lukasz Majewski escreveu: > Hi Joao, > > Thank you for your reply. > >> Às 10:43 AM de 1/17/2017, Joao Pinto escreveu: >>> >>> Hi Lukasz, >>> >>> Às 9:44 PM de 1/16/2017, Lukasz Majewski escreveu: >>&

Re: [PATCH] pcie: ti: Provide patch to force GEN1 PCIe operation

Às 10:43 AM de 1/17/2017, Joao Pinto escreveu: > > Hi Lukasz, > > Às 9:44 PM de 1/16/2017, Lukasz Majewski escreveu: >> Hi Joao, >> >>> >>> Hi, >>> >>> Às 10:13 AM de 1/16/2017, Kishon Vijay Abraham I escreveu: >>>> +

Re: [PATCH] pcie: ti: Provide patch to force GEN1 PCIe operation

Às 10:43 AM de 1/17/2017, Joao Pinto escreveu: > > Hi Lukasz, > > Às 9:44 PM de 1/16/2017, Lukasz Majewski escreveu: >> Hi Joao, >> >>> >>> Hi, >>> >>> Às 10:13 AM de 1/16/2017, Kishon Vijay Abraham I escreveu: >>>> +

Re: [PATCH] pcie: ti: Provide patch to force GEN1 PCIe operation

Hi Lukasz, Às 9:44 PM de 1/16/2017, Lukasz Majewski escreveu: > Hi Joao, > >> >> Hi, >> >> Às 10:13 AM de 1/16/2017, Kishon Vijay Abraham I escreveu: >>> + Joao, Jingoo >>> >>> Hi, >>> >>> On Monday 16 January 2017 03:01 PM, Lukasz Majewski wrote: Hi Kishon, > Hi Łukasz, >

Re: [PATCH] pcie: ti: Provide patch to force GEN1 PCIe operation

Hi Lukasz, Às 9:44 PM de 1/16/2017, Lukasz Majewski escreveu: > Hi Joao, > >> >> Hi, >> >> Às 10:13 AM de 1/16/2017, Kishon Vijay Abraham I escreveu: >>> + Joao, Jingoo >>> >>> Hi, >>> >>> On Monday 16 January 2017 03:01 PM, Lukasz Majewski wrote: Hi Kishon, > Hi Łukasz, >

Re: [PATCH] pcie: ti: Provide patch to force GEN1 PCIe operation

Hi, Às 5:35 AM de 1/17/2017, Kishon Vijay Abraham I escreveu: > Hi Joao, > > On Monday 16 January 2017 10:31 PM, Joao Pinto wrote: >> >> Hi, >> >> Às 10:13 AM de 1/16/2017, Kishon Vijay Abraham I escreveu: >>> + Joao, Jingoo >>> >>

Re: [PATCH] pcie: ti: Provide patch to force GEN1 PCIe operation

Hi, Às 5:35 AM de 1/17/2017, Kishon Vijay Abraham I escreveu: > Hi Joao, > > On Monday 16 January 2017 10:31 PM, Joao Pinto wrote: >> >> Hi, >> >> Às 10:13 AM de 1/16/2017, Kishon Vijay Abraham I escreveu: >>> + Joao, Jingoo >>> >>

Re: [PATCH] pcie: ti: Provide patch to force GEN1 PCIe operation

Hi, Às 10:13 AM de 1/16/2017, Kishon Vijay Abraham I escreveu: > + Joao, Jingoo > > Hi, > > On Monday 16 January 2017 03:01 PM, Lukasz Majewski wrote: >> Hi Kishon, >> >>> Hi Łukasz, >>> >>> On Monday 16 January 2017 12:19 PM, Lukasz Majewski wrote: Hi Kishon, > Hi, > >

Re: [PATCH] pcie: ti: Provide patch to force GEN1 PCIe operation

Hi, Às 10:13 AM de 1/16/2017, Kishon Vijay Abraham I escreveu: > + Joao, Jingoo > > Hi, > > On Monday 16 January 2017 03:01 PM, Lukasz Majewski wrote: >> Hi Kishon, >> >>> Hi Łukasz, >>> >>> On Monday 16 January 2017 12:19 PM, Lukasz Majewski wrote: Hi Kishon, > Hi, > >

Re: [PATCH] pcie: ti: Provide patch to force GEN1 PCIe operation

Hi, Às 10:13 AM de 1/16/2017, Kishon Vijay Abraham I escreveu: > + Joao, Jingoo > > Hi, > > On Monday 16 January 2017 03:01 PM, Lukasz Majewski wrote: >> Hi Kishon, >> >>> Hi Łukasz, >>> >>> On Monday 16 January 2017 12:19 PM, Lukasz Majewski wrote: Hi Kishon, > Hi, > >

Re: [PATCH] pcie: ti: Provide patch to force GEN1 PCIe operation

Hi, Às 10:13 AM de 1/16/2017, Kishon Vijay Abraham I escreveu: > + Joao, Jingoo > > Hi, > > On Monday 16 January 2017 03:01 PM, Lukasz Majewski wrote: >> Hi Kishon, >> >>> Hi Łukasz, >>> >>> On Monday 16 January 2017 12:19 PM, Lukasz Majewski wrote: Hi Kishon, > Hi, > >

Re: [PATCH 11/37] PCI: dwc: Split pcie-designware.c into host and core files

Às 11:30 AM de 1/16/2017, Kishon Vijay Abraham I escreveu: > Hi Joao, > > On Monday 16 January 2017 03:57 PM, Joao Pinto wrote: >> >> Hi, >> >> Às 5:21 AM de 1/16/2017, Kishon Vijay Abraham I escreveu: >>> Hi Joao, >>> >>> On Friday 13

Re: [PATCH 11/37] PCI: dwc: Split pcie-designware.c into host and core files

Às 11:30 AM de 1/16/2017, Kishon Vijay Abraham I escreveu: > Hi Joao, > > On Monday 16 January 2017 03:57 PM, Joao Pinto wrote: >> >> Hi, >> >> Às 5:21 AM de 1/16/2017, Kishon Vijay Abraham I escreveu: >>> Hi Joao, >>> >>> On Friday 13

Re: [PATCH 11/37] PCI: dwc: Split pcie-designware.c into host and core files

Hi, Às 5:21 AM de 1/16/2017, Kishon Vijay Abraham I escreveu: > Hi Joao, > > On Friday 13 January 2017 10:19 PM, Joao Pinto wrote: >> Às 10:26 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: >>> Split pcie-designware.c into pcie-designware-host.c that contains >

Re: [PATCH 11/37] PCI: dwc: Split pcie-designware.c into host and core files

Hi, Às 5:21 AM de 1/16/2017, Kishon Vijay Abraham I escreveu: > Hi Joao, > > On Friday 13 January 2017 10:19 PM, Joao Pinto wrote: >> Às 10:26 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: >>> Split pcie-designware.c into pcie-designware-host.c that contains >

Re: [PATCH 09/37] PCI: dwc: designware: Parse *num-lanes* property in dw_pcie_setup_rc

Hi, Às 5:19 AM de 1/16/2017, Kishon Vijay Abraham I escreveu: > Hi, > > On Friday 13 January 2017 10:43 PM, Joao Pinto wrote: >> Hi, >> >> Às 10:25 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: >>> *num-lanes* dt property is parsed in dw_pcie_host_in

Re: [PATCH 09/37] PCI: dwc: designware: Parse *num-lanes* property in dw_pcie_setup_rc

Hi, Às 5:19 AM de 1/16/2017, Kishon Vijay Abraham I escreveu: > Hi, > > On Friday 13 January 2017 10:43 PM, Joao Pinto wrote: >> Hi, >> >> Às 10:25 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: >>> *num-lanes* dt property is parsed in dw_pcie_host_in

Re: [PATCH 12/37] PCI: dwc: Create a new config symbol to enable pci dwc host

Hi Kishon, Às 10:26 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: > Now that pci designware host has a separate file, create a new > config symbol to select the host only driver. This is in preparation > to enable endpoint support to designware driver. > > Signed-off-by: Kishon Vijay Abraham

Re: [PATCH 12/37] PCI: dwc: Create a new config symbol to enable pci dwc host

Hi Kishon, Às 10:26 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: > Now that pci designware host has a separate file, create a new > config symbol to select the host only driver. This is in preparation > to enable endpoint support to designware driver. > > Signed-off-by: Kishon Vijay Abraham

Re: [PATCH 07/37] PCI: dwc: designware: Get device pointer at the start of dw_pcie_host_init

Hi! Às 10:25 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: > No functional change. Get device pointer at the beginning of > dw_pcie_host_init instead of getting it all over dw_pcie_host_init. > This is in preparation for splitting struct pcie_port into host and > core structures (Once split

Re: [PATCH 07/37] PCI: dwc: designware: Get device pointer at the start of dw_pcie_host_init

Hi! Às 10:25 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: > No functional change. Get device pointer at the beginning of > dw_pcie_host_init instead of getting it all over dw_pcie_host_init. > This is in preparation for splitting struct pcie_port into host and > core structures (Once split

Re: [PATCH 09/37] PCI: dwc: designware: Parse *num-lanes* property in dw_pcie_setup_rc

Hi, Às 10:25 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: > *num-lanes* dt property is parsed in dw_pcie_host_init. However > *num-lanes* property is applicable to both root complex mode and > endpoint mode. As a first step, move the parsing of this property > outside dw_pcie_host_init. This

Re: [PATCH 09/37] PCI: dwc: designware: Parse *num-lanes* property in dw_pcie_setup_rc

Hi, Às 10:25 AM de 1/12/2017, Kishon Vijay Abraham I escreveu: > *num-lanes* dt property is parsed in dw_pcie_host_init. However > *num-lanes* property is applicable to both root complex mode and > endpoint mode. As a first step, move the parsing of this property > outside dw_pcie_host_init. This

Re: [PATCH 05/37] PCI: dwc: Add platform_set_drvdata

y Zang <tie-fei.z...@freescale.com> > Cc: Thomas Petazzoni <thomas.petazz...@free-electrons.com> > Cc: Niklas Cassel <niklas.cas...@axis.com> > Cc: Jesper Nilsson <jesper.nils...@axis.com> > Cc: Joao Pinto <joao.pi...@synopsys.com> > Cc: Zhou Wang <wangzh...@

<    1   2   3   4   5   6   7   8   >