Re: [PATCH] Revert "Bluetooth: Align minimum encryption key size for LE and BR/EDR connections"

2019-06-12 Thread Johan Hedberg
Hi, On 12 Jun 2019, at 12.38, Bastien Nocera wrote: > > On Wed, 2019-06-12 at 09:07 +0200, Greg Kroah-Hartman wrote: >> On Tue, Jun 11, 2019 at 11:36:26PM +0200, Marcel Holtmann wrote: >>> Hi Vasily, >>> Can we get this revert merged into stable branches? Bluetooth HID has been

Re: linux-next: Signed-off-by missing for commits in the net-next tree

2018-04-01 Thread Johan Hedberg
Hi, On Mon, Apr 02, 2018, Stephen Rothwell wrote: > 45a42bc9cc65 ("Bluetooth: hci_bcm: Remove DMI quirk for the MINIX Z83-4") > f9b95db0165a ("Bluetooth: btrsi: remove unused including ") > 96e58d368fa6 ("Bluetooth: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for > BTUSB_QCA_ROME") >

Re: linux-next: Signed-off-by missing for commits in the net-next tree

2018-04-01 Thread Johan Hedberg
Hi, On Mon, Apr 02, 2018, Stephen Rothwell wrote: > 45a42bc9cc65 ("Bluetooth: hci_bcm: Remove DMI quirk for the MINIX Z83-4") > f9b95db0165a ("Bluetooth: btrsi: remove unused including ") > 96e58d368fa6 ("Bluetooth: Set HCI_QUIRK_SIMULTANEOUS_DISCOVERY for > BTUSB_QCA_ROME") >

Re: linux-next: Signed-off-by missing for commit in the bluetooth tree

2017-12-29 Thread Johan Hedberg
Hi, On Sat, Dec 30, 2017, Stephen Rothwell wrote: > On Sat, 30 Dec 2017 10:25:52 +1100 Stephen Rothwell > wrote: > > Commit > > > > 0a03f98b98c2 ("Bluetooth: Add a new 04ca:3015 QCA_ROME device") > > > > is missing a Signed-off-by from its . >

Re: linux-next: Signed-off-by missing for commit in the bluetooth tree

2017-12-29 Thread Johan Hedberg
Hi, On Sat, Dec 30, 2017, Stephen Rothwell wrote: > On Sat, 30 Dec 2017 10:25:52 +1100 Stephen Rothwell > wrote: > > Commit > > > > 0a03f98b98c2 ("Bluetooth: Add a new 04ca:3015 QCA_ROME device") > > > > is missing a Signed-off-by from its . > ^ >

Re: [PATCH v2] Bluetooth: btusb: add ID for LiteOn 04ca:3016

2017-07-31 Thread Johan Hedberg
Hi Brian, On Mon, Jul 31, 2017, Brian Norris wrote: > Contains a QCA6174A-5 chipset, with USB BT. Let's support loading > firmware on it. > > From usb-devices: > T: Bus=02 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#= 3 Spd=12 MxCh= 0 > D: Ver= 2.01 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 > P:

Re: [PATCH v2] Bluetooth: btusb: add ID for LiteOn 04ca:3016

2017-07-31 Thread Johan Hedberg
Hi Brian, On Mon, Jul 31, 2017, Brian Norris wrote: > Contains a QCA6174A-5 chipset, with USB BT. Let's support loading > firmware on it. > > From usb-devices: > T: Bus=02 Lev=02 Prnt=02 Port=00 Cnt=01 Dev#= 3 Spd=12 MxCh= 0 > D: Ver= 2.01 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1 > P:

Re: [PATCH] Bluetooth: btusb: add ID for LiteOn 04ca:3016

2017-07-30 Thread Johan Hedberg
Hi Brian, On Fri, Jul 28, 2017, Brian Norris wrote: > Contains a QCA6174A-5 chipset, with USB BT. Let's support loading > firmware on it. > > Signed-off-by: Brian Norris > --- > drivers/bluetooth/btusb.c | 1 + > 1 file changed, 1 insertion(+) Could you also include

Re: [PATCH] Bluetooth: btusb: add ID for LiteOn 04ca:3016

2017-07-30 Thread Johan Hedberg
Hi Brian, On Fri, Jul 28, 2017, Brian Norris wrote: > Contains a QCA6174A-5 chipset, with USB BT. Let's support loading > firmware on it. > > Signed-off-by: Brian Norris > --- > drivers/bluetooth/btusb.c | 1 + > 1 file changed, 1 insertion(+) Could you also include the relevant usb-devices

Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel

2016-10-06 Thread Johan Hedberg
Hi, On Thu, Oct 06, 2016, Joe Perches wrote: > On Thu, 2016-10-06 at 09:02 +0200, Pavel Machek wrote: > > I believe you are wrong. bit addressability does not matter, cpu can > > definitely get the bit values. > > > > u8 foo:1; > > u8 bar:1; > > u8 baz:1; > > > > should take 1 byte, where > >

Re: [PATCH] bluetooth.h: __ variants of u8 and friends are not neccessary inside kernel

2016-10-06 Thread Johan Hedberg
Hi, On Thu, Oct 06, 2016, Joe Perches wrote: > On Thu, 2016-10-06 at 09:02 +0200, Pavel Machek wrote: > > I believe you are wrong. bit addressability does not matter, cpu can > > definitely get the bit values. > > > > u8 foo:1; > > u8 bar:1; > > u8 baz:1; > > > > should take 1 byte, where > >

Re: Memory (skb) leak in kernel 4.8-rc2

2016-08-20 Thread Johan Hedberg
Hi Marcel, On Sat, Aug 20, 2016, Marcel Holtmann wrote: > > I am seeing two skb leaks in the BT sub-system for kernel 4.8-rc2. I > > only recently re-enabled kmemleak, but I do not think I saw these > > leaks in 4.7. > > > > The first leak is at btusb_recv_intr+0x12b/0x170 [btusb]. This > >

Re: Memory (skb) leak in kernel 4.8-rc2

2016-08-20 Thread Johan Hedberg
Hi Marcel, On Sat, Aug 20, 2016, Marcel Holtmann wrote: > > I am seeing two skb leaks in the BT sub-system for kernel 4.8-rc2. I > > only recently re-enabled kmemleak, but I do not think I saw these > > leaks in 4.7. > > > > The first leak is at btusb_recv_intr+0x12b/0x170 [btusb]. This > >

Re: [PATCH 1/1] Bluetooth: add printf format attribute to hci_set_[fh]w_info()

2016-08-15 Thread Johan Hedberg
Hi Nicolas, On Fri, Jul 29, 2016, Nicolas Iooss wrote: > Commit 5177a83827cd ("Bluetooth: Add debugfs fields for hardware and > firmware info") introduced hci_set_hw_info() and hci_set_fw_info(). > These functions use kvasprintf_const() but are not marked with a > __printf attribute. Adding such

Re: [PATCH 1/1] Bluetooth: add printf format attribute to hci_set_[fh]w_info()

2016-08-15 Thread Johan Hedberg
Hi Nicolas, On Fri, Jul 29, 2016, Nicolas Iooss wrote: > Commit 5177a83827cd ("Bluetooth: Add debugfs fields for hardware and > firmware info") introduced hci_set_hw_info() and hci_set_fw_info(). > These functions use kvasprintf_const() but are not marked with a > __printf attribute. Adding such

Re: [PATCH v4 01/16] bluetooth: Switch SMP to crypto_cipher_encrypt_one()

2016-06-24 Thread Johan Hedberg
t;mar...@holtmann.org> > Cc: Gustavo Padovan <gust...@padovan.org> > Cc: Johan Hedberg <johan.hedb...@gmail.com> > Cc: "David S. Miller" <da...@davemloft.net> > Cc: linux-blueto...@vger.kernel.org > Cc: Herbert Xu <herb...@gondor.apana.org.au> >

Re: [PATCH v4 01/16] bluetooth: Switch SMP to crypto_cipher_encrypt_one()

2016-06-24 Thread Johan Hedberg
; Cc: Gustavo Padovan > Cc: Johan Hedberg > Cc: "David S. Miller" > Cc: linux-blueto...@vger.kernel.org > Cc: Herbert Xu > Cc: net...@vger.kernel.org > Signed-off-by: Andy Lutomirski > --- > net/bluetooth/smp.c | 67 > ++-

Re: [PATCH] Bluetooth: Use hci_conn_hash_lookup_le

2016-05-02 Thread Johan Hedberg
Hi, On Fri, Apr 29, 2016, Julia Lawall wrote: > --- a/net/bluetooth/mgmt.c > +++ b/net/bluetooth/mgmt.c > @@ -4773,7 +4773,8 @@ static int get_conn_info(struct sock *sk, struct > hci_dev *hdev, void *data, > conn = hci_conn_hash_lookup_ba(hdev, ACL_LINK, >

Re: [PATCH] Bluetooth: Use hci_conn_hash_lookup_le

2016-05-02 Thread Johan Hedberg
Hi, On Fri, Apr 29, 2016, Julia Lawall wrote: > --- a/net/bluetooth/mgmt.c > +++ b/net/bluetooth/mgmt.c > @@ -4773,7 +4773,8 @@ static int get_conn_info(struct sock *sk, struct > hci_dev *hdev, void *data, > conn = hci_conn_hash_lookup_ba(hdev, ACL_LINK, >

Re: [PATCH] Bluetooth: hci_core: Avoid mixing up req_complete and req_complete_skb

2016-02-19 Thread Johan Hedberg
the > problem, I simply confirmed that existing functionality worked. > > net/bluetooth/hci_core.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Good catch. Acked-by: Johan Hedberg <johan.hedb...@intel.com> Marcel, I think we want to send this through our stable tree to 4.5-rc (where the patch introducing the bug is). Johan

Re: [PATCH] Bluetooth: hci_core: Avoid mixing up req_complete and req_complete_skb

2016-02-19 Thread Johan Hedberg
rmed that existing functionality worked. > > net/bluetooth/hci_core.c | 6 -- > 1 file changed, 4 insertions(+), 2 deletions(-) Good catch. Acked-by: Johan Hedberg Marcel, I think we want to send this through our stable tree to 4.5-rc (where the patch introducing the bug is). Johan

Re: [PATCH] bluetooth:Fix error checking in the function hci_disconn_complete_evt

2015-08-24 Thread Johan Hedberg
Hi Nicholas, On Wed, Aug 19, 2015, Nicholas Krause wrote: > This fixes error checking in the function hci_disconn_complete_evt > to properly check if it's call to the function hci_remove_link_key > returns NULL to signal it has not correctly removed the link key > on the passed hci_dev structure

Re: [PATCH] bluetooth:Fix error checking in the function hci_disconn_complete_evt

2015-08-24 Thread Johan Hedberg
Hi Nicholas, On Wed, Aug 19, 2015, Nicholas Krause wrote: This fixes error checking in the function hci_disconn_complete_evt to properly check if it's call to the function hci_remove_link_key returns NULL to signal it has not correctly removed the link key on the passed hci_dev structure

Re: [V4.0] Regression: Support for Bluetooth Adapter dropped.

2015-02-27 Thread Johan Hedberg
Hi Jörg, On Fri, Feb 27, 2015, Jörg Otte wrote: > Bluetooth has ever been working on my Notebook. I successfully > use Bluetooth mouse and Obex file transfer for years. And with > Kernel V4.00 the Adapter is no longer recognized. > > It is an Intel 8087:07da. > > The first bad commit is: >

Re: [V4.0] Regression: Support for Bluetooth Adapter dropped.

2015-02-27 Thread Johan Hedberg
Hi Jörg, On Fri, Feb 27, 2015, Jörg Otte wrote: Bluetooth has ever been working on my Notebook. I successfully use Bluetooth mouse and Obex file transfer for years. And with Kernel V4.00 the Adapter is no longer recognized. It is an Intel 8087:07da. The first bad commit is: commit

Re: 3.19-rc1 refuse connection from bluetooth headset

2015-02-12 Thread Johan Hedberg
Hi Ethan, On Thu, Feb 12, 2015, Ethan wrote: > I met similar issue in kernel 3.10 for Chromebook smart lock feature, I > have merged your patch but issue still happened. The whole feature of checking the whitelist when HCI_CONNECTABLE is not set was introduced only in kernel version 3.18. So it

Re: 3.19-rc1 refuse connection from bluetooth headset

2015-02-12 Thread Johan Hedberg
Hi Ethan, On Thu, Feb 12, 2015, Ethan wrote: I met similar issue in kernel 3.10 for Chromebook smart lock feature, I have merged your patch but issue still happened. The whole feature of checking the whitelist when HCI_CONNECTABLE is not set was introduced only in kernel version 3.18. So it

[tip:sched/core] sched/wait: Introduce wait_on_bit_timeout()

2015-02-04 Thread tip-bot for Johan Hedberg
Commit-ID: 44fc0e5eec00db5fba748803c95920098089c4cc Gitweb: http://git.kernel.org/tip/44fc0e5eec00db5fba748803c95920098089c4cc Author: Johan Hedberg AuthorDate: Fri, 30 Jan 2015 13:14:36 +0200 Committer: Ingo Molnar CommitDate: Wed, 4 Feb 2015 07:52:32 +0100 sched/wait: Introduce

[tip:sched/core] sched/wait: Introduce wait_on_bit_timeout()

2015-02-04 Thread tip-bot for Johan Hedberg
Commit-ID: 44fc0e5eec00db5fba748803c95920098089c4cc Gitweb: http://git.kernel.org/tip/44fc0e5eec00db5fba748803c95920098089c4cc Author: Johan Hedberg johan.hedb...@intel.com AuthorDate: Fri, 30 Jan 2015 13:14:36 +0200 Committer: Ingo Molnar mi...@kernel.org CommitDate: Wed, 4 Feb 2015 07

sched/wait: Introduce a wait_on_bit_timeout() helper function

2015-01-30 Thread Johan Hedberg
take the patch through the bluetooth-next tree and get it from there upstream. Johan [1] http://marc.info/?l=linux-bluetooth=142260834526228=2 Johan Hedberg (1): sched/wait: Introduce wait_on_bit_timeout() include/linux/wait.h

[PATCH] sched/wait: Introduce wait_on_bit_timeout()

2015-01-30 Thread Johan Hedberg
From: Johan Hedberg Add a new wait_on_bit_timeout() helper, basically the same as wait_on_bit() except that it also takes a timeout parameter. All the building blocks like bit_wait_timeout() and out_of_line_wait_on_bit_timeout() are already in place so the addition is rather simple. Signed-off

sched/wait: Introduce a wait_on_bit_timeout() helper function

2015-01-30 Thread Johan Hedberg
take the patch through the bluetooth-next tree and get it from there upstream. Johan [1] http://marc.info/?l=linux-bluetoothm=142260834526228w=2 Johan Hedberg (1): sched/wait: Introduce wait_on_bit_timeout() include/linux

[PATCH] sched/wait: Introduce wait_on_bit_timeout()

2015-01-30 Thread Johan Hedberg
From: Johan Hedberg johan.hedb...@intel.com Add a new wait_on_bit_timeout() helper, basically the same as wait_on_bit() except that it also takes a timeout parameter. All the building blocks like bit_wait_timeout() and out_of_line_wait_on_bit_timeout() are already in place so the addition

Re: [PATCH] bluetooth: Add hci_h4p driver

2015-01-20 Thread Johan Hedberg
Hi Pavel, On Tue, Dec 23, 2014, Pavel Machek wrote: > + while (1) { > + int cmd, len; > + > + fw_pos += cmd_len; > + > + if (fw_pos >= fw_entry->size) > + break; > + > + if (fw_pos + 2 > fw_entry->size) { > +

Re: [PATCH] bluetooth: Add hci_h4p driver

2015-01-20 Thread Johan Hedberg
Hi Pavel, On Tue, Dec 23, 2014, Pavel Machek wrote: + while (1) { + int cmd, len; + + fw_pos += cmd_len; + + if (fw_pos = fw_entry-size) + break; + + if (fw_pos + 2 fw_entry-size) { +

Re: 3.19-rc1 refuse connection from bluetooth headset

2014-12-24 Thread Johan Hedberg
Hi Pali, On Wed, Dec 24, 2014, Pali Rohár wrote: > > Could you try the attached patch? I think the reason might be > > the dependence on the HCI_CONNECTABLE flag that's only set if > > the page scan was enabled through mgmt (which wouldn't be the > > case with BlueZ 4.98). > > > > Johan > > Hi

Re: 3.19-rc1 refuse connection from bluetooth headset

2014-12-24 Thread Johan Hedberg
Hi Pali, On Wed, Dec 24, 2014, Pali Rohár wrote: > now I installed 3.19-rc1 kernel and my bluetooth headset was refused > to connect automatically. I need to start connection manually from > laptop (and then it working). Before when I started bluetooth headset > it automatically connected and I

Re: 3.19-rc1 refuse connection from bluetooth headset

2014-12-24 Thread Johan Hedberg
Hi Pali, On Wed, Dec 24, 2014, Pali Rohár wrote: now I installed 3.19-rc1 kernel and my bluetooth headset was refused to connect automatically. I need to start connection manually from laptop (and then it working). Before when I started bluetooth headset it automatically connected and I did

Re: 3.19-rc1 refuse connection from bluetooth headset

2014-12-24 Thread Johan Hedberg
Hi Pali, On Wed, Dec 24, 2014, Pali Rohár wrote: Could you try the attached patch? I think the reason might be the dependence on the HCI_CONNECTABLE flag that's only set if the page scan was enabled through mgmt (which wouldn't be the case with BlueZ 4.98). Johan Hi Johan! Thanks

pull request: bluetooth 2014-12-17

2014-12-17 Thread Johan Hedberg
Hi Dave, Here's the first direct (i.e. skipping the wireless tree) bluetooth pull request for you, intended for 3.19. It's just one patch: a fix from Marcel for for remote service discovery filtering which also fixes a 'used uninitialized' compiler warning. Please let me know if there are any

pull request: bluetooth 2014-12-17

2014-12-17 Thread Johan Hedberg
Hi Dave, Here's the first direct (i.e. skipping the wireless tree) bluetooth pull request for you, intended for 3.19. It's just one patch: a fix from Marcel for for remote service discovery filtering which also fixes a 'used uninitialized' compiler warning. Please let me know if there are any

pull request: bluetooth 2014-12-12

2014-12-12 Thread Johan Hedberg
device 04ca:3010 as Atheros AR3012 Johan Hedberg (5): Bluetooth: Fix calling hci_conn_put too early Bluetooth: Fix incorrect pending cmd removal in pairing_complete() Bluetooth: Fix notifying mgmt power off before flushing connection list Bluetooth: Fix enabling BR/EDR SC when

pull request: bluetooth 2014-12-12

2014-12-12 Thread Johan Hedberg
device 04ca:3010 as Atheros AR3012 Johan Hedberg (5): Bluetooth: Fix calling hci_conn_put too early Bluetooth: Fix incorrect pending cmd removal in pairing_complete() Bluetooth: Fix notifying mgmt power off before flushing connection list Bluetooth: Fix enabling BR/EDR SC when

pull request: bluetooth-next 2014-12-05

2014-12-05 Thread Johan Hedberg
scovery fields for storing filter information Bluetooth: Add logic for UUID filter handling Bluetooth: Add support for Start Service Discovery command Johan Hedberg (62): Bluetooth: Track both local and remote L2CAP fixed channel mask Bluetooth: Simplify Link Key Notification

pull request: bluetooth-next 2014-12-05

2014-12-05 Thread Johan Hedberg
tion Bluetooth: Add logic for UUID filter handling Bluetooth: Add support for Start Service Discovery command Johan Hedberg (62): Bluetooth: Track both local and remote L2CAP fixed channel mask Bluetooth: Simplify Link Key Notification event handling logic Bluetooth:

pull request: bluetooth-next 2014-12-05

2014-12-05 Thread Johan Hedberg
Bluetooth: Add logic for UUID filter handling Bluetooth: Add support for Start Service Discovery command Johan Hedberg (62): Bluetooth: Track both local and remote L2CAP fixed channel mask Bluetooth: Simplify Link Key Notification event handling logic Bluetooth: Add

pull request: bluetooth-next 2014-12-05

2014-12-05 Thread Johan Hedberg
for storing filter information Bluetooth: Add logic for UUID filter handling Bluetooth: Add support for Start Service Discovery command Johan Hedberg (62): Bluetooth: Track both local and remote L2CAP fixed channel mask Bluetooth: Simplify Link Key Notification event handling

pull request: bluetooth-next 2014-11-27

2014-11-27 Thread Johan Hedberg
n (1): Bluetooth: ath3k: Add support of MCI 13d3:3408 bt device Johan Hedberg (3): Bluetooth: Fix setting state back to TASK_RUNNING Bluetooth: Fix setting conn->pending_sec_level value from link key Bluetooth: Convert link keys list to use RCU Steven Walter (1): Bl

Re: [PATCH v3] Bluetooth: automatically flushable packets aren't allowed on LE links

2014-11-27 Thread Johan Hedberg
Hi Marcel, On Wed, Nov 26, 2014, Marcel Holtmann wrote: > I think Marcel was after just providing a clarifying code comment in > both places - having two branches of an if-statement doing exactly the > same thing looks a bit weird to me. To make thins completely clear I'd >

Re: [PATCH v3] Bluetooth: automatically flushable packets aren't allowed on LE links

2014-11-27 Thread Johan Hedberg
Hi Marcel, On Wed, Nov 26, 2014, Marcel Holtmann wrote: I think Marcel was after just providing a clarifying code comment in both places - having two branches of an if-statement doing exactly the same thing looks a bit weird to me. To make thins completely clear I'd suggest adding a

pull request: bluetooth-next 2014-11-27

2014-11-27 Thread Johan Hedberg
): Bluetooth: ath3k: Add support of MCI 13d3:3408 bt device Johan Hedberg (3): Bluetooth: Fix setting state back to TASK_RUNNING Bluetooth: Fix setting conn-pending_sec_level value from link key Bluetooth: Convert link keys list to use RCU Steven Walter (1): Bluetooth

Re: [PATCH v6] ath3k: Add support of MCI 13d3:3408 bt device

2014-11-26 Thread Johan Hedberg
Hi Dmitry, On Tue, Nov 25, 2014, Dmitry Tunin wrote: > Add support for bluetooth MCI WB335 (AR9565) Wi-Fi+bt module. > This bluetooth module requires loading patch and sysconfig by ath3k driver. > > T: Bus=01 Lev=02 Prnt=03 Port=00 Cnt=01 Dev#= 20 Spd=12 MxCh= 0 > D: Ver= 1.10 Cls=e0(wlcon)

Re: [PATCH v6] ath3k: Add support of MCI 13d3:3408 bt device

2014-11-26 Thread Johan Hedberg
Hi Dmitry, On Tue, Nov 25, 2014, Dmitry Tunin wrote: Add support for bluetooth MCI WB335 (AR9565) Wi-Fi+bt module. This bluetooth module requires loading patch and sysconfig by ath3k driver. T: Bus=01 Lev=02 Prnt=03 Port=00 Cnt=01 Dev#= 20 Spd=12 MxCh= 0 D: Ver= 1.10 Cls=e0(wlcon)

Re: [PATCH v5] ath3k: Add support of MCI 13d3:3408 bt device

2014-11-25 Thread Johan Hedberg
Hi Dmitry, On Tue, Nov 25, 2014, Dmitry Tunin wrote: > Add support for bluetooth MCI WB335 (AR9565) Wi-Fi+bt module. > This bluetooth module requires loading patch and sysconfig by ath3k driver. > > CC: sta...@vger.kernel.org > Signed-off-by: Dmitry Tunin > > --- Seems you've forgotten the

Re: [PATCH v5] ath3k: Add support of MCI 13d3:3408 bt device

2014-11-25 Thread Johan Hedberg
Hi Dmitry, On Tue, Nov 25, 2014, Dmitry Tunin wrote: Add support for bluetooth MCI WB335 (AR9565) Wi-Fi+bt module. This bluetooth module requires loading patch and sysconfig by ath3k driver. CC: sta...@vger.kernel.org Signed-off-by: Dmitry Tunin hanipouspi...@gmail.com --- Seems you've

Re: [PATCH v3] Bluetooth: automatically flushable packets aren't allowed on LE links

2014-11-20 Thread Johan Hedberg
Hi Marcel, On Thu, Nov 20, 2014, Marcel Holtmann wrote: > > static u16 get_acl_flags(struct hci_conn *hcon, struct l2cap_chan *chan) > > { > > If we do it with a helper functions, then it should only provide the > l2cap_chan since we can get the hci_conn from there. One of the places it'd get

Re: [PATCH v3] Bluetooth: automatically flushable packets aren't allowed on LE links

2014-11-20 Thread Johan Hedberg
Hi Steven, On Wed, Nov 19, 2014, Steven Walter wrote: > The bluetooth spec states that automatically flushable packets may not > be sent over a LE-U link. > > Signed-off-by: Steven Walter > --- > net/bluetooth/l2cap_core.c | 14 -- > 1 file changed, 8 insertions(+), 6 deletions(-)

Re: [PATCH v3] Bluetooth: automatically flushable packets aren't allowed on LE links

2014-11-20 Thread Johan Hedberg
Hi Steven, On Wed, Nov 19, 2014, Steven Walter wrote: The bluetooth spec states that automatically flushable packets may not be sent over a LE-U link. Signed-off-by: Steven Walter stevenrwal...@gmail.com --- net/bluetooth/l2cap_core.c | 14 -- 1 file changed, 8 insertions(+),

Re: [PATCH v3] Bluetooth: automatically flushable packets aren't allowed on LE links

2014-11-20 Thread Johan Hedberg
Hi Marcel, On Thu, Nov 20, 2014, Marcel Holtmann wrote: static u16 get_acl_flags(struct hci_conn *hcon, struct l2cap_chan *chan) { If we do it with a helper functions, then it should only provide the l2cap_chan since we can get the hci_conn from there. One of the places it'd get called

Re: pull request: bluetooth-next 2014-11-07

2014-11-19 Thread Johan Hedberg
Hi Kirill, On Wed, Nov 19, 2014, Kirill A. Shutemov wrote: > > From: Johan Hedberg > > Date: Tue, 18 Nov 2014 20:00:15 +0200 > > Subject: [PATCH] Bluetooth: Fix setting state back to TASK_RUNNING > > > > In __hci_cmd_sync_ev() and __hci_req_sync() if the hci_r

Re: pull request: bluetooth-next 2014-11-07

2014-11-19 Thread Johan Hedberg
Hi Kirill, On Wed, Nov 19, 2014, Kirill A. Shutemov wrote: From: Johan Hedberg johan.hedb...@intel.com Date: Tue, 18 Nov 2014 20:00:15 +0200 Subject: [PATCH] Bluetooth: Fix setting state back to TASK_RUNNING In __hci_cmd_sync_ev() and __hci_req_sync() if the hci_req_run() call fails

Re: pull request: bluetooth-next 2014-11-07

2014-11-18 Thread Johan Hedberg
Hi Kirill, On Tue, Nov 18, 2014, Kirill A. Shutemov wrote: > On Fri, Nov 07, 2014 at 11:27:54AM +0200, Johan Hedberg wrote: > > Chan-yeol Park (1): > > Bluetooth: Fix hci_sync missing wakeup interrupt > > Look like this commit causes problem for me: > > [

pull request: bluetooth-next 2014-11-18

2014-11-18 Thread Johan Hedberg
: Send mgmt_connected only if state is BT_CONFIG Johan Hedberg (20): Bluetooth: Fix sparse warning in amp.c Bluetooth: Fix mgmt connected notification Bluetooth: 6lowpan: Remove unnecessary RCU callback Bluetooth: Fix l2cap_sock_teardown_cb lockdep warning Bluetooth

Re: pull request: bluetooth-next 2014-11-07

2014-11-18 Thread Johan Hedberg
Hi Kirill, On Tue, Nov 18, 2014, Kirill A. Shutemov wrote: On Fri, Nov 07, 2014 at 11:27:54AM +0200, Johan Hedberg wrote: Chan-yeol Park (1): Bluetooth: Fix hci_sync missing wakeup interrupt Look like this commit causes problem for me: [2.018671] [ cut here

pull request: bluetooth-next 2014-11-18

2014-11-18 Thread Johan Hedberg
: Send mgmt_connected only if state is BT_CONFIG Johan Hedberg (20): Bluetooth: Fix sparse warning in amp.c Bluetooth: Fix mgmt connected notification Bluetooth: 6lowpan: Remove unnecessary RCU callback Bluetooth: Fix l2cap_sock_teardown_cb lockdep warning Bluetooth

pull request: bluetooth-next 2014-11-07

2014-11-07 Thread Johan Hedberg
wakeup interrupt Dan Carpenter (1): ieee802154: || vs && in ieee802154_is_valid_extended_addr() Fengguang Wu (1): at86rf230: fix simple_return.cocci warnings Johan Hedberg (1): Bluetooth: Fix sparse warnings in RFCOMM Kuba Pawlak (2): Bluetooth: Clear role switch

pull request: bluetooth-next 2014-11-07

2014-11-07 Thread Johan Hedberg
wakeup interrupt Dan Carpenter (1): ieee802154: || vs in ieee802154_is_valid_extended_addr() Fengguang Wu (1): at86rf230: fix simple_return.cocci warnings Johan Hedberg (1): Bluetooth: Fix sparse warnings in RFCOMM Kuba Pawlak (2): Bluetooth: Clear role switch pending flag

pull request: bluetooth-next 2014-10-31

2014-10-31 Thread Johan Hedberg
Add support for Acer [0489:e078] Dan Carpenter (1): Bluetooth: 6lowpan: use after free in disconnect_devices() Fabian Frederick (1): Bluetooth: fix shadow warning in hci_disconnect() Johan Hedberg (6): Bluetooth: Pass only crypto context to SMP crypto functions Bluetooth:

pull request: bluetooth-next 2014-10-31

2014-10-31 Thread Johan Hedberg
support for Acer [0489:e078] Dan Carpenter (1): Bluetooth: 6lowpan: use after free in disconnect_devices() Fabian Frederick (1): Bluetooth: fix shadow warning in hci_disconnect() Johan Hedberg (6): Bluetooth: Pass only crypto context to SMP crypto functions Bluetooth: Add

Re: linux-next: build failure after merge of the bluetooth tree

2014-10-28 Thread Johan Hedberg
Hi Stephen, On Mon, Oct 27, 2014, Stephen Rothwell wrote: > After merging the bluetooth tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > net/bluetooth/smp.o: In function `test_smp': > smp.c:(.init.text+0x0): multiple definition of `init_module' >

Re: linux-next: build failure after merge of the bluetooth tree

2014-10-28 Thread Johan Hedberg
Hi Stephen, On Mon, Oct 27, 2014, Stephen Rothwell wrote: After merging the bluetooth tree, today's linux-next build (x86_64 allmodconfig) failed like this: net/bluetooth/smp.o: In function `test_smp': smp.c:(.init.text+0x0): multiple definition of `init_module'

pull request: bluetooth-next 2014-10-02

2014-10-02 Thread Johan Hedberg
0300) Amitkumar Karwar (2): Bluetooth: btmrvl: rename definitions from 88xx to 8897 Bluetooth: btusb: remove redundant lock variable Johan Hedberg (1): Bluetooth: Fix lockdep warning with l2cap_chan_connect Jukka Rissanen (7): Bluetooth: 6lowpan: Make sure skb ex

pull request: bluetooth-next 2014-10-02

2014-10-02 Thread Johan Hedberg
) Amitkumar Karwar (2): Bluetooth: btmrvl: rename definitions from 88xx to 8897 Bluetooth: btusb: remove redundant lock variable Johan Hedberg (1): Bluetooth: Fix lockdep warning with l2cap_chan_connect Jukka Rissanen (7): Bluetooth: 6lowpan: Make sure skb exists

pull request: bluetooth-next 2014-09-25

2014-09-25 Thread Johan Hedberg
e to esco_param_msbc (2014-09-25 10:35:08 +0200) Bernhard Thaler (1): Bluetooth: Check for SCO type before setting retransmission effort Joe Perches (1): Bluetooth: Convert bt_ logging functions to return vo

pull request: bluetooth-next 2014-09-25

2014-09-25 Thread Johan Hedberg
-09-25 10:35:08 +0200) Bernhard Thaler (1): Bluetooth: Check for SCO type before setting retransmission effort Joe Perches (1): Bluetooth: Convert bt_level logging functions to return void Johan Hedberg (5

pull request: bluetooth-next 2014-09-22

2014-09-21 Thread Johan Hedberg
changes up to 5eb596f55cacc2389554a8d7572d90d5e9d4269d: Bluetooth: Fix setting correct security level when initiating SMP (2014-09-18 17:39:37 +0200) Johan Hedberg (2): Bluetooth: btusb: Use GFP_KERNEL in btusb_send_frame

pull request: bluetooth-next 2014-09-22

2014-09-21 Thread Johan Hedberg
changes up to 5eb596f55cacc2389554a8d7572d90d5e9d4269d: Bluetooth: Fix setting correct security level when initiating SMP (2014-09-18 17:39:37 +0200) Johan Hedberg (2): Bluetooth: btusb: Use GFP_KERNEL in btusb_send_frame

Re: pull request: bluetooth-next 2014-09-14

2014-09-13 Thread Johan Hedberg
Hi John, On Sun, Sep 14, 2014, Johan Hedberg wrote: > Here are some more patches intended for 3.18. Most of them are cleanups > or fixes for SMP. The only exception is a fix for BR/EDR L2CAP fixed > channels which should now work better together with the L2CAP > information reque

pull request: bluetooth-next 2014-09-14

2014-09-13 Thread Johan Hedberg
/bluetooth-next.git master for you to fetch changes up to 9a783a139c32a905825ee0aa9597f485ea461f76: Bluetooth: Fix re-setting RPA as expired when deferring update (2014-09-12 18:34:25 +0200) Johan Hedberg (10): Bluetooth

pull request: bluetooth-next 2014-09-14

2014-09-13 Thread Johan Hedberg
/bluetooth-next.git master for you to fetch changes up to 9a783a139c32a905825ee0aa9597f485ea461f76: Bluetooth: Fix re-setting RPA as expired when deferring update (2014-09-12 18:34:25 +0200) Johan Hedberg (10): Bluetooth

Re: pull request: bluetooth-next 2014-09-14

2014-09-13 Thread Johan Hedberg
Hi John, On Sun, Sep 14, 2014, Johan Hedberg wrote: Here are some more patches intended for 3.18. Most of them are cleanups or fixes for SMP. The only exception is a fix for BR/EDR L2CAP fixed channels which should now work better together with the L2CAP information request procedure. Let

pull request: bluetooth-next 2014-09-09

2014-09-09 Thread Johan Hedberg
): Bluetooth: LLVMLinux: Remove VLAIS from bluetooth/amp.c Champion Chen (1): Bluetooth: Fix issue with USB suspend in btusb driver Johan Hedberg (31): Bluetooth: Fix incorrect LE CoC PDU length restriction based on HCI MTU Bluetooth: Remove unnecessary l2cap_chan_unlock before

pull request: bluetooth-next 2014-09-09

2014-09-09 Thread Johan Hedberg
): Bluetooth: LLVMLinux: Remove VLAIS from bluetooth/amp.c Champion Chen (1): Bluetooth: Fix issue with USB suspend in btusb driver Johan Hedberg (31): Bluetooth: Fix incorrect LE CoC PDU length restriction based on HCI MTU Bluetooth: Remove unnecessary l2cap_chan_unlock before

pull request: bluetooth 2014-08-20

2014-08-20 Thread Johan Hedberg
Alexander Aring (2): ieee802154: 6lowpan_rtnl: fix correct errno value ieee802154: 6lowpan: ensure of sending 1280 packets Johan Hedberg (1): Bluetooth: Fix hci_conn reference counting for auto-connections Martin Townsend (3): mac802154: fixed potentia

pull request: bluetooth 2014-08-20

2014-08-20 Thread Johan Hedberg
Aring (2): ieee802154: 6lowpan_rtnl: fix correct errno value ieee802154: 6lowpan: ensure of sending 1280 packets Johan Hedberg (1): Bluetooth: Fix hci_conn reference counting for auto-connections Martin Townsend (3): mac802154: fixed potential skb leak

pull request: bluetooth-next 2014-08-14

2014-08-14 Thread Johan Hedberg
): ieee802154: 6lowpan: remove unused function Himangi Saraogi (4): Bluetooth: Remove typedef bluecard_info_t Bluetooth: Remove typedef btuart_info_t Bluetooth: Remove typedefs nsh_t and dtl1_info_t Bluetooth: Remove typedef bt3c_info_t Johan Hedberg (35): Bluetooth: Add

pull request: bluetooth-next 2014-08-14

2014-08-14 Thread Johan Hedberg
): ieee802154: 6lowpan: remove unused function Himangi Saraogi (4): Bluetooth: Remove typedef bluecard_info_t Bluetooth: Remove typedef btuart_info_t Bluetooth: Remove typedefs nsh_t and dtl1_info_t Bluetooth: Remove typedef bt3c_info_t Johan Hedberg (35): Bluetooth: Add

pull request: bluetooth-next 2014-07-31

2014-07-31 Thread Johan Hedberg
river initialization codepath Johan Hedberg (5): Bluetooth: Fix SMP context tracking leading to a kernel crash Bluetooth: Fix check for connected state when pairing Bluetooth: Rename HCI_PAIRABLE to HCI_BONDABLE Bluetooth: Rename pairable mgmt setting to bondable Bluet

pull request: bluetooth-next 2014-07-31

2014-07-31 Thread Johan Hedberg
codepath Johan Hedberg (5): Bluetooth: Fix SMP context tracking leading to a kernel crash Bluetooth: Fix check for connected state when pairing Bluetooth: Rename HCI_PAIRABLE to HCI_BONDABLE Bluetooth: Rename pairable mgmt setting to bondable Bluetooth: Always use non

pull request: bluetooth-next 2014-07-28

2014-07-28 Thread Johan Hedberg
3:32 +0200) Alexander Aring (1): MAINTAINERS: add 6lowpan header file Georg Lukas (2): Bluetooth: Provide defaults for LE advertising interval Bluetooth: Expose default LE advertising interval via debugfs Johan Hedberg (2):

pull request: bluetooth-next 2014-07-28

2014-07-28 Thread Johan Hedberg
) Alexander Aring (1): MAINTAINERS: add 6lowpan header file Georg Lukas (2): Bluetooth: Provide defaults for LE advertising interval Bluetooth: Expose default LE advertising interval via debugfs Johan Hedberg (2): Bluetooth: Fix

Re: [PATCH 3.13 131/160] Bluetooth: Fix redundant encryption request for reauthentication

2014-06-10 Thread Johan Hedberg
Hi, On Tue, Jun 10, 2014, Kamal Mostafa wrote: > 3.13.11.3 -stable review patch. If anyone has any objections, please let me > know. > > -- > > From: Johan Hedberg > > commit 09da1f3463eb81d59685df723b1c5950b7570340 upstream. > > When we'

Re: [PATCH 3.13 131/160] Bluetooth: Fix redundant encryption request for reauthentication

2014-06-10 Thread Johan Hedberg
Hi, On Tue, Jun 10, 2014, Kamal Mostafa wrote: 3.13.11.3 -stable review patch. If anyone has any objections, please let me know. -- From: Johan Hedberg johan.hedb...@intel.com commit 09da1f3463eb81d59685df723b1c5950b7570340 upstream. When we're performing

Re: [PATCH 3.12 064/146] Bluetooth: Fix redundant encryption request for reauthentication

2014-06-09 Thread Johan Hedberg
ead, the REAUTH_PEND flag takes care of all necessary steps for > reauthentication. > > Signed-off-by: Johan Hedberg > Signed-off-by: Marcel Holtmann > Signed-off-by: Jiri Slaby > --- > net/bluetooth/hci_conn.c | 9 ++--- > 1 file changed, 6 insertions(+), 3 deletions(-)

Re: [PATCH 3.12 064/146] Bluetooth: Fix redundant encryption request for reauthentication

2014-06-09 Thread Johan Hedberg
steps for reauthentication. Signed-off-by: Johan Hedberg johan.hedb...@intel.com Signed-off-by: Marcel Holtmann mar...@holtmann.org Signed-off-by: Jiri Slaby jsl...@suse.cz --- net/bluetooth/hci_conn.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) This one seems

Re: [PATCH] bluetooth:hci_ldisc: add tasklet for deferred TX handling

2014-04-23 Thread Johan Hedberg
q+0x40/0x54) from [] > (handle_IRQ+0x70/0x94) > [] (handle_IRQ+0x70/0x94) from [] > (omap3_intc_handle_irq+0x64/0x78) > [] (omap3_intc_handle_irq+0x64/0x78) from [] > (__irq_svc+0x44/0x78) > --->8--- > > Signed-off-by: Andreas Bießmann > Cc: Marcel Holtmann > Cc:

Re: [PATCH] bluetooth:hci_ldisc: add tasklet for deferred TX handling

2014-04-23 Thread Johan Hedberg
--- Signed-off-by: Andreas Bießmann andr...@biessmann.de Cc: Marcel Holtmann mar...@holtmann.org Cc: Gustavo Padovan gust...@padovan.org Cc: Johan Hedberg johan.hedb...@gmail.com Cc: linux-blueto...@vger.kernel.org --- It seems at least one other guy had the very same problem with another uart

Re: USB autosuspend causing trouble on Intel bluetooth (Linux 3.14)

2014-04-03 Thread Johan Hedberg
Hi Thomas, On Thu, Apr 03, 2014, Thomas Bächler wrote: > > You can easily check by running the "Inquiry (LIAC)” test from > > tools/hci-tester. Problem is that some of the HCI events are not > > making it to the host. They get delivered as soon as the device > > wakes up again. In this test case

Re: USB autosuspend causing trouble on Intel bluetooth (Linux 3.14)

2014-04-03 Thread Johan Hedberg
Hi Thomas, On Thu, Apr 03, 2014, Thomas Bächler wrote: You can easily check by running the Inquiry (LIAC)” test from tools/hci-tester. Problem is that some of the HCI events are not making it to the host. They get delivered as soon as the device wakes up again. In this test case it is the

Re: [PATCH] drivers:bluetooth:ath3k.c: Fixed sparse warning for cast to restricted __le32

2014-03-25 Thread Johan Hedberg
Hi, On Tue, Mar 25, 2014, Surendra Patil wrote: > This patch fixes below Sparse warnings - > drivers/bluetooth/ath3k.c:370:17: warning: cast to restricted __le32 > drivers/bluetooth/ath3k.c:432:17: warning: cast to restricted __le32 > > Signed-off-by: Surendra Patil > --- >

  1   2   >