This patch changes device name to more user friendly name of
Analog and SPDIF sound nodes for rk3399-rockpro64.
Signed-off-by: Katsuhiro Suzuki
---
arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts
]
Subdevices: 1/1
Subdevice #0: subdevice #0
card 2: rockchiprk339_1 [rockchip,rk3399], device 0:
ff87.spdif-dit-hifi dit-hifi-0 [ff87.spdif-dit-hifi dit-hifi-0]
Subdevices: 1/1
Subdevice #0: subdevice #0
On 10/5/20 4:03 PM, Katsuhiro Suzuki wrote:
This patch adds 'disabl
6 DMA channels. So users have
to choose from the following:
- Disable one of I2S (Ex. I2S0) and enable SPDIF tx
- Keep enable I2S0/1/2 and disable SPDIF tx
Signed-off-by: Katsuhiro Suzuki
---
Changes in v3:
- Refine commit description why adding disabled node
Changes in v2:
- Remove
On 2020/08/31 4:16, Heiko Stuebner wrote:
Hi,
Am Sonntag, 2. August 2020, 17:42:31 CEST schrieb Katsuhiro Suzuki:
This patch enables HDMI sound (I2S0) and Analog sound (I2S1) which
are defined in rk3328.dtsi, and replace SPDIF nodes.
We can use SPDIF pass-through with suitable ALSA settings
Hello Heiko,
On 2020/08/31 4:08, Heiko Stuebner wrote:
Hi,
Am Montag, 10. August 2020, 11:16:19 CEST schrieb Katsuhiro Suzuki:
This patch adds 'disabled' SPDIF sound node and related settings
for rk3399-rockpro64.
There are 2 reasons:
- All RK3399 dma-bus channels have been already used
This patch adds 'disabled' SPDIF sound node and related settings
for rk3399-rockpro64.
There are 2 reasons:
- All RK3399 dma-bus channels have been already used by I2S0/1/2
- RockPro64 does not have SPDIF optical nor coaxial connector,
just have 3pins
Signed-off-by: Katsuhiro Suzuki
Hello Johan,
Sorry for late and thanks for your comment!
On 2020/08/03 2:52, Johan Jonker wrote:
Hi Katsuhiro,
On 8/1/20 7:49 PM, Katsuhiro Suzuki wrote:
This patch adds 'disabled' SPDIF sound node and related settings
for rk3399-rockpro64.
There are 2 reasons:
- All RK3399 dma-bus
lem.
Signed-off-by: Katsuhiro Suzuki
---
.../arm64/boot/dts/rockchip/rk3328-rock64.dts | 56 ---
1 file changed, 24 insertions(+), 32 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
index 86cfb5c50
off-by: Katsuhiro Suzuki
---
.../arm64/boot/dts/rockchip/rk3328-rock64.dts | 58 +--
1 file changed, 26 insertions(+), 32 deletions(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
b/arch/arm64/boot/dts/rockchip/rk3328-rock64.dts
index 86cfb5c50a94..4608f8fc6ff3 100644
--- a/a
This patch adds 'disabled' SPDIF sound node and related settings
for rk3399-rockpro64.
There are 2 reasons:
- All RK3399 dma-bus channels have been already used by I2S0/1/2
- RockPro64 does not have SPDIF optical nor coaxial connector,
just have 3pins
Signed-off-by: Katsuhiro Suzuki
This patch converts Everest Semiconductor ES8316 low power audio
CODEC binding to DT schema.
Signed-off-by: Katsuhiro Suzuki
---
Changes in v2:
- Change maintainers from Mark to Daniel and me
---
.../bindings/sound/everest,es8316.txt | 23 -
.../bindings/sound/everest,es8316
Hello Rob,
Thank you for review.
On 2020/07/24 6:26, Rob Herring wrote:
On Thu, Jul 23, 2020 at 03:07:28AM +0900, Katsuhiro Suzuki wrote:
This patch converts Everest Semiconductor ES8316 low power audio
CODEC binding to DT schema.
Signed-off-by: Katsuhiro Suzuki
---
.../bindings/sound
Hello Rob,
Thanks a lot for your review!
Best Regards,
Katsuhiro Suzuki
On 2020/07/21 11:12, Rob Herring wrote:
On Tue, Jul 14, 2020 at 05:09:59PM +0900, Katsuhiro Suzuki wrote:
This patch converts ROHM BD28623UMV class D speaker amplifier binding
to DT schema.
Signed-off-by: Katsuhiro
This patch converts Everest Semiconductor ES8316 low power audio
CODEC binding to DT schema.
Signed-off-by: Katsuhiro Suzuki
---
.../bindings/sound/everest,es8316.txt | 23 -
.../bindings/sound/everest,es8316.yaml| 49 +++
2 files changed, 49 insertions
This patch converts ROHM BD28623UMV class D speaker amplifier binding
to DT schema.
Signed-off-by: Katsuhiro Suzuki
Reviewed-by: Rob Herring
---
Changes in v2:
- add additionalProperties:false
- add Rob's Reviewed-by
---
.../bindings/sound/rohm,bd28623.txt | 29
This patch converts ROHM BD28623UMV class D speaker amplifier binding
to DT schema.
Signed-off-by: Katsuhiro Suzuki
---
.../bindings/sound/rohm,bd28623.txt | 29 -
.../bindings/sound/rohm,bd28623.yaml | 65 +++
2 files changed, 65 insertions(+), 29
Past about 1 month, so I send a ping...
On 2019/09/08 2:48, Katsuhiro Suzuki wrote:
This patch adds audio codec (Everest ES8316) and I2S audio nodes for
RK3399 RockPro64.
Signed-off-by: Katsuhiro Suzuki
---
.../boot/dts/rockchip/rk3399-rockpro64.dts| 28 +++
1 file
by sysclk
32kHz (1/256), 21.33kHz (1/384), 16kHz (1/512)
- Play 48kHz again, but it's NOT acceptable because constraints
do not allow 48kHz
So codecs treat 0Hz sysclk as signal of applying no constraints to
avoid this problem.
Signed-off-by: Katsuhiro Suzuki
---
I'm not 100
This patch adds audio codec (Everest ES8316) and I2S audio nodes for
RK3399 RockPro64.
Signed-off-by: Katsuhiro Suzuki
---
.../boot/dts/rockchip/rk3399-rockpro64.dts| 28 +++
1 file changed, 28 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
b
48kHz again, but it's NOT acceptable because constraints
do not allow 48kHz
So codecs treat 0Hz sysclk as signal of applying no constraints to
avoid this problem.
Signed-off-by: Katsuhiro Suzuki
---
sound/soc/generic/simple-card-utils.c | 7 +++
1 file changed, 7 insertions(+)
diff --git
-by: Katsuhiro Suzuki
---
sound/soc/rockchip/rockchip_i2s.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/sound/soc/rockchip/rockchip_i2s.c
b/sound/soc/rockchip/rockchip_i2s.c
index 88ebaf6e1880..af2d5a6124c8 100644
--- a/sound/soc/rockchip/rockchip_i2s.c
+++ b/sound/soc/rockchip/rockchip_i2s.c
not allow 48kHz
Signed-off-by: Katsuhiro Suzuki
---
sound/soc/codecs/es8316.c | 35 ---
1 file changed, 20 insertions(+), 15 deletions(-)
diff --git a/sound/soc/codecs/es8316.c b/sound/soc/codecs/es8316.c
index 1424ecd6952c..36eef1fb3d18 100644
--- a/sound/soc/codecs
This patch removes redundant null checks for optional MCLK clock.
And fix DT binding document for changing clock property to optional
from required.
Signed-off-by: Katsuhiro Suzuki
---
.../bindings/sound/everest,es8316.txt | 3 ++
sound/soc/codecs/es8316.c | 31
On 2019/09/05 0:30, Mark Brown wrote:
On Thu, Sep 05, 2019 at 12:06:23AM +0900, Katsuhiro Suzuki wrote:
Would you tell me one more thing. I don't understand who sets MCLK to 0.
Is it needed original machine driver instead of audio-graph-card?
On my test environment (audio-graph-card
Hello Andy,
Thank you for reviewing.
On 2019/09/04 23:37, Andy Shevchenko wrote:
On Tue, Sep 3, 2019 at 7:54 PM Katsuhiro Suzuki wrote:
This patch introduce clock property for MCLK master freq control.
Driver will set rate of MCLK master if set_sysclk is called and
changing sysclk by board
Hello Mark,
On 2019/09/04 2:48, Mark Brown wrote:
On Wed, Sep 04, 2019 at 01:53:19AM +0900, Katsuhiro Suzuki wrote:
Root cause of this strange behavior is changing constraints list at
set_sysclk timing. It seems that is too early to determine. So this
patch does not use constraints list
This patch adds missing DT-bindings document for Everest ES8316.
Signed-off-by: Katsuhiro Suzuki
---
.../bindings/sound/everest,es8316.txt | 20 +++
1 file changed, 20 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/everest,es8316.txt
diff
This patch supports some type of machine drivers that use fixed clock
rate. After applied this patch, sysclk == 0 means there is no
constraint of sound rate and other values will set constraints which
is derived by sysclk setting.
Signed-off-by: Katsuhiro Suzuki
---
Changes from v2:
- Newly
. It seems that is too early to determine. So this
patch does not use constraints list and check PCM rate limit more
later timing at hw_params.
Signed-off-by: Katsuhiro Suzuki
---
sound/soc/codecs/es8316.c | 37 +++--
1 file changed, 15 insertions(+), 22 deletions
This patch introduce clock property for MCLK master freq control.
Driver will set rate of MCLK master if set_sysclk is called and
changing sysclk by board driver.
Signed-off-by: Katsuhiro Suzuki
---
Changes from v1:
- Output logs if clock error is found
- Disable and unprepare mclk when
Hello Mark,
On 2019/09/03 20:11, Mark Brown wrote:
On Tue, Sep 03, 2019 at 04:19:10AM +0900, Katsuhiro Suzuki wrote:
On 2019/09/02 21:02, Mark Brown wrote:
The best way to handle this is to try to support both fixed and variable
clock rates, some other drivers do this by setting constraints
Hello Mark,
Thanks a lot for your comments.
On 2019/09/02 21:02, Mark Brown wrote:
On Sun, Sep 01, 2019 at 01:26:48AM +0900, Katsuhiro Suzuki wrote:
This patch change the judge timing about playing/capturing PCM rate.
Original code set constraints list of PCM rate limits at set_sysclk
This patch introduce clock property for MCLK master freq control.
Driver will set rate of MCLK master if set_sysclk is called and
changing sysclk by board driver.
Signed-off-by: Katsuhiro Suzuki
---
Changes from v1:
- Output logs if clock error is found
- Disable and unprepare mclk when
This patch adds missing DT-bindings document for Everest ES8316.
Signed-off-by: Katsuhiro Suzuki
---
.../bindings/sound/everest,es8316.txt | 20 +++
1 file changed, 20 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/everest,es8316.txt
diff
. It seems that is too early to determine. So this
patch does not use constraints list and check PCM rate limit more
later timing at hw_params.
Signed-off-by: Katsuhiro Suzuki
---
sound/soc/codecs/es8316.c | 37 +++--
1 file changed, 15 insertions(+), 22 deletions
Hello Mark,
On 2019/08/30 20:18, Mark Brown wrote:
On Fri, Aug 30, 2019 at 02:32:04AM +0900, Katsuhiro Suzuki wrote:
+ es8316->mclk = devm_clk_get(component->dev, "mclk");
+ if (PTR_ERR(es8316->mclk) == -EPROBE_DEFER)
+ return -EPROBE_DEFER;
If w
This patch introduce clock property for MCLK master freq control.
Driver will set rate of MCLK master if set_sysclk is called and
changing sysclk by board driver.
Signed-off-by: Katsuhiro Suzuki
---
sound/soc/codecs/es8316.c | 20
1 file changed, 20 insertions(+)
diff
. It seems that is too early to determine. So this
patch does not use constraints list and check PCM rate limit more
later timing at hw_params.
Signed-off-by: Katsuhiro Suzuki
---
sound/soc/codecs/es8316.c | 37 +++--
1 file changed, 15 insertions(+), 22 deletions
This patch adds missing DT-bindings document for Everest ES8316.
Signed-off-by: Katsuhiro Suzuki
---
.../bindings/sound/everest,es8316.txt | 20 +++
1 file changed, 20 insertions(+)
create mode 100644 Documentation/devicetree/bindings/sound/everest,es8316.txt
diff
-by: Katsuhiro Suzuki
---
sound/soc/codecs/es8316.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/es8316.c b/sound/soc/codecs/es8316.c
index 8dfb5dbeebbf..f97d9c5210f0 100644
--- a/sound/soc/codecs/es8316.c
+++ b/sound/soc/codecs/es8316.c
@@ -53,7 +53,10
This patch fixes inverted Left-Right channel of headphone mixer
volume by wrong shift_left, shift_right values.
Signed-off-by: Katsuhiro Suzuki
---
sound/soc/codecs/es8316.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/es8316.c b/sound/soc/codecs/es8316.c
Hello Hans, Daniel,
Thank you for reviewing and comment.
On 2019/08/26 18:09, Hans de Goede wrote:
Hi,
On 26-08-19 04:53, Daniel Drake wrote:
On Mon, Aug 26, 2019 at 1:38 AM Hans de Goede
wrote:
On 24-08-19 23:04, Katsuhiro Suzuki wrote:
This patch limits Headphone mixer volume to 4 from
er_gain_tlv),
is correct.
Best Regards,
Katsuhiro Suzuki
On 2019/08/26 17:41, Katsuhiro Suzuki wrote:
Hello Daniel,
On 2019/08/26 11:53, Daniel Drake wrote:
On Mon, Aug 26, 2019 at 1:38 AM Hans de Goede
wrote:
On 24-08-19 23:04, Katsuhiro Suzuki wrote:
This patch limits Headphone mixer vo
Hello Daniel,
On 2019/08/26 11:53, Daniel Drake wrote:
On Mon, Aug 26, 2019 at 1:38 AM Hans de Goede wrote:
On 24-08-19 23:04, Katsuhiro Suzuki wrote:
This patch limits Headphone mixer volume to 4 from 7.
Because output sound suddenly becomes very loudly with many noise if
set volume over 4
This patch limits Headphone mixer volume to 4 from 7.
Because output sound suddenly becomes very loudly with many noise if
set volume over 4.
Signed-off-by: Katsuhiro Suzuki
---
sound/soc/codecs/es8316.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/sound/soc/codecs/es8316
Hello Andrew,
On 2019/06/25 23:51, Andrew Lunn wrote:
On Tue, Jun 25, 2019 at 11:40:00PM +0900, Katsuhiro Suzuki wrote:
Hello Jose,
This patch works fine with my Tinker Board. Thanks a lot!
Tested-by: Katsuhiro Suzuki
BTW, from network guys point of view, is it better to add a phy node
Hello Jose,
This patch works fine with my Tinker Board. Thanks a lot!
Tested-by: Katsuhiro Suzuki
BTW, from network guys point of view, is it better to add a phy node
into device trees that have no phy node such as the Tinker Board?
Best Regards,
Katsuhiro Suzuki
On 2019/06/25 22:11
the device-trees such as TinkerBoard. The mdio
subnode creating a mdio bus is changed to required or still optional?
Best Regards,
Katsuhiro Suzuki
Hello Heiko, Andrew,
Thank you for comments. I found the commit that has regression:
74371272f97f net: stmmac: Convert to phylink and remove phylib logic
So I'll report it to netdev and stmmac guys.
Best Regards,
---
Katsuhiro Suzuki
On 2019/06/23 2:55, Andrew Lunn wrote:
On Sat, Jun 22
Board worked correctly if use it.
I have not bisect commit of root cause yet... Is it better to bisect
and find problem instead of sending this patch?
Best Regards,
---
Katsuhiro Suzuki
On 2019/06/22 17:33, Heiko Stuebner wrote:
Hi,
Am Freitag, 21. Juni 2019, 20:00:17 CEST schrieb Katsuhiro Suzuki
This patch adds missing mdio and ethernet PHY nodes for rk3328 ASUS
tinker board.
Signed-off-by: Katsuhiro Suzuki
---
arch/arm/boot/dts/rk3288-tinker.dtsi | 12
1 file changed, 12 insertions(+)
diff --git a/arch/arm/boot/dts/rk3288-tinker.dtsi
b/arch/arm/boot/dts/rk3288
This patch adds PCIe, PCIe phy and pinctrl (for PERST#) nodes for
RockPro64 board.
Signed-off-by: Katsuhiro Suzuki
---
.../boot/dts/rockchip/rk3399-rockpro64.dts | 18 ++
1 file changed, 18 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
b/arch
ping...
On 2019/03/27 21:03, Katsuhiro Suzuki wrote:
This patch fixes IO domain voltage setting that is related to
audio_gpio3d4a_ms (bit 1) of GRF_IO_VSEL.
This is because RockPro64 schematics P.16 says that regulator
supplies 3.0V power to APIO5_VDD. So audio_gpio3d4a_ms bit should
be clear
This patch fixes pin assign of cts and rts signal of UART3.
Currently GPIO3_C2 and C3 pins are assigned but TRM says that
GPIO3_C0 and C1 are correct.
Refer:
RK3399 TRM v1.4 - Table 19-1 UART Interface Description
Signed-off-by: Katsuhiro Suzuki
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi
(supplies 1.8V) but I believe P.16 is actual connectings.
Signed-off-by: Katsuhiro Suzuki
Suggested-by: Robin Murphy
---
arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts
b
Hello Robin,
Sorry for inconvenience. Since I don't adhere enabling DMA for UARTs,
please revert my patch if you need.
BTW, there are DMA properties in RK3328 device-tree like as this patch.
RK3328 UART DMA could not work correctly too...??
Best Regards,
Katsuhiro Suzuki
On 2019/03/26 20:48
, Katsuhiro Suzuki wrote:
Hello Tony, Robin,
On 2019/03/04 5:41, Tony McKahan wrote:
On Sun, Mar 3, 2019 at 2:51 PM Robin Murphy wrote:
On 2019-03-03 6:45 pm, Tony McKahan wrote:
Hello Katsushiro,
On Sun, Mar 3, 2019 at 12:31 PM Katsuhiro Suzuki
wrote:
Hello Tony,
On 2019/03/04 0:13, Tony
Add UART dma channels as specified by the rk3399 TRM.
Refer:
RK3399 TRM V1.4: Chapter 12 DMA Controller
Signed-off-by: Katsuhiro Suzuki
---
Changes from v1:
- Add dma property for UART4
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 10 ++
1 file changed, 10 insertions(+)
diff
Hello Robin,
On 2019/03/22 0:21, Robin Murphy wrote:
On 21/03/2019 14:40, Katsuhiro Suzuki wrote:
Add UART dma channels as specified by the rk3399 TRM.
No UART4? That's arguably one of the more useful ones, since 1 and 3
often end up muxed to ethernet instead.
Oops... I forgot to add
ping again...
Please let me know if there is problem in this patch.
On 2019/03/04 23:00, Katsuhiro Suzuki wrote:
ping...
On 2019/02/19 23:08, Katsuhiro Suzuki wrote:
This patch fixes pin assign of cts and rts signal of UART3.
Currently GPIO3_C2 and C3 pins are assigned but TRM says
about Non-LPCM sound. I understand your concern.
My patch should be keeping until this problem is solved.
I'm going to find test environment and try KODI or mpv. Thank you for
great information!
Best Regards,
Katsuhiro Suzuki
Regards,
Jonas
On 2019-03-17 10:54, Katsuhiro Suzuki wrote:
Hel
Add UART dma channels as specified by the rk3399 TRM.
Refer:
RK3399 TRM V1.4: Chapter 12 DMA Controller
Signed-off-by: Katsuhiro Suzuki
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 8
1 file changed, 8 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399.dtsi
b/arch
11
3 12
4 14
5 15
6 10
7 --
Signed-off-by: Katsuhiro Suzuki
---
drivers/dma/pl330.c | 51 +
1 file changed, 51 insertions(+)
diff --git a/drivers/dma/pl330.c b/drivers/dma
Hello,
Sorry, I got mistake in title of this patch...
Please ignore this patch.
Best Regards,
Katsuhiro Suzuki
On 2019/03/17 19:00, Katsuhiro Suzuki wrote:
This patch adds debugfs interface to show the relationship between
DMA threads (hardware resource for transferring data) and DMA
channel
11
3 12
4 14
5 15
6 10
7 --
Signed-off-by: Katsuhiro Suzuki
---
drivers/dma/pl330.c | 51 +
1 file changed, 51 insertions(+)
diff --git a/drivers/dma/pl330.c b/drivers/dma
Hello Vinod,
Thank you for your comment.
I fix it all and re-post v2 patch.
On 2019/03/16 2:00, Vinod Koul wrote:
On 15-03-19, 03:49, Katsuhiro Suzuki wrote:
This patch adds debugfs interface to show the relationship between
DMA threads (hardware resource for transferring data) and DMA
Hello Jonas,
How about this topic?
I think this patch does not have bad effect for multi channel
sound of HDMI. If you don't think so, please tell me.
I wait your sound patch and after re-check this patch.
Best Regards,
Katsuhiro Suzuki
On 2019/03/03 4:26, Katsuhiro Suzuki wrote:
Hello Jonas
11
3 12
4 14
5 15
6 10
7 --
Signed-off-by: Katsuhiro Suzuki
---
drivers/dma/pl330.c | 51 +
1 file changed, 51 insertions(+)
diff --git a/drivers/dma/pl330.c b/drivers
rv>;
regulator-name = "vcc_host1_5v";
After this patch applied, USB and S/PDIF both work well.
Tested-by: Katsuhiro Suzuki
$ lsusb
Bus 003 Device 001: ID 1d6b:0001 Linux Foundation 1.1 root hub
Bus 002 Device 001: ID 1d6b:0002 Linux Foundation 2.0 root hub
Bus 001 Device 00
ping...
On 2019/02/19 23:08, Katsuhiro Suzuki wrote:
This patch fixes pin assign of cts and rts signal of UART3.
Currently GPIO3_C2 and C3 pins are assigned but TRM says that
GPIO3_C0 and C1 are correct.
Refer:
RK3399 TRM v1.4 - Table 19-1 UART Interface Description
Signed-off
Hello Heiko,
On 2019/03/03 22:55, Heiko Stuebner wrote:
Am Sonntag, 17. Februar 2019, 18:34:06 CET schrieb Katsuhiro Suzuki:
This patch adds #sound-dai-cells to use HDMI node as audio
codec from device tree of rk3328 boards.
Signed-off-by: Katsuhiro Suzuki
applied for 5.2 .
I'm holding
Hello Tony, Robin,
On 2019/03/04 5:41, Tony McKahan wrote:
On Sun, Mar 3, 2019 at 2:51 PM Robin Murphy wrote:
On 2019-03-03 6:45 pm, Tony McKahan wrote:
Hello Katsushiro,
On Sun, Mar 3, 2019 at 12:31 PM Katsuhiro Suzuki
wrote:
Hello Tony,
On 2019/03/04 0:13, Tony McKahan wrote:
On Sun
No problem! Thank you for discussion :)
On 2019/03/04 4:12, Tony McKahan wrote:
On Sun, Mar 3, 2019 at 1:45 PM Tony McKahan wrote:
Hello Katsushiro,
And apologies for the extra "s", typing too quickly I'm afraid.
On Sun, Mar 3, 2019 at 12:31 PM Katsuhiro Suzuki
wrote:
Hello Tony,
On 2019/03/04 0:13, Tony McKahan wrote:
On Sun, Mar 3, 2019 at 9:04 AM Katsuhiro Suzuki wrote:
Hello Heiko,
Thank you for comments.
On 2019/03/03 22:19, Heiko Stuebner wrote:
Hi,
Am Sonntag, 3. März 2019, 13:27:05 CET schrieb Katsuhiro Suzuki:
This patch increases drive
Hello Heiko,
Thank you for comments.
On 2019/03/03 22:19, Heiko Stuebner wrote:
Hi,
Am Sonntag, 3. März 2019, 13:27:05 CET schrieb Katsuhiro Suzuki:
This patch increases drive strength of UART2 from 3mA to 12mA for
getting more faster rising edge.
RockPro64 is using a very high speed rate
time of RockPro64 UART2 is 40ns, but riging time
is over 650ns. So UART receiver will get wrong data, because receiver
read intermediate data of rising edge.
Rising time becomes 300ns from 650ns if apply this patch. This is not
perfect solution but better than now.
Signed-off-by: Katsuhiro Suzuki
Hello Jonas,
Thanks for your comments.
On 2019/03/03 2:20, Jonas Karlman wrote:
On 2019-03-02 15:19, Katsuhiro Suzuki wrote:
Ping...
On 2019/02/18 2:34, Katsuhiro Suzuki wrote:
This patch adds HDMI sound (I2S0) node for rock64.
After apply this patch, UART2 will fail to allocate DMA
Ping...
On 2019/02/18 2:34, Katsuhiro Suzuki wrote:
This patch adds HDMI sound (I2S0) node for rock64.
After apply this patch, UART2 will fail to allocate DMA resources
but UART driver can work fine without DMA.
This error is related to the DMAC of rk3328 (pl330 or compatible).
DMAC connected
Ping...
On 2019/02/11 0:38, Katsuhiro Suzuki wrote:
Custom approximation of fractional-divider may not need parent clock
rate checking. For example Rockchip SoCs work fine using grand parent
clock rate even if target rate is greater than parent.
This patch checks parent clock rate only
The rockpro64 has hdmi support. So this patch enables hdmi audio
feature that is defined in rk3399 devicetree.
Signed-off-by: Katsuhiro Suzuki
---
arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dts | 4
1 file changed, 4 insertions(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3399
This patch just replace some absolute GPIO numbers of I2C, I2S, UART,
SPDIF, SPI and so on for rk3399 devicetree into RK_PXn macro for more
readability.
Signed-off-by: Katsuhiro Suzuki
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi | 236 +++
1 file changed, 118 insertions
This patch fixes pin assign of cts and rts signal of UART3.
Currently GPIO3_C2 and C3 pins are assigned but TRM says that
GPIO3_C0 and C1 are correct.
Refer:
RK3399 TRM v1.4 - Table 19-1 UART Interface Description
Signed-off-by: Katsuhiro Suzuki
---
arch/arm64/boot/dts/rockchip/rk3399.dtsi
This patch adds #sound-dai-cells to use HDMI node as audio
codec from device tree of rk3328 boards.
Signed-off-by: Katsuhiro Suzuki
---
arch/arm64/boot/dts/rockchip/rk3328.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
b/arch/arm64/boot/dts
is simply activated by this
patch, required DMAC channels will be 9. So last one (UART2) cannot
allocate the DMA resources.
Virt-dma mechanism for pl0330 DMAC driver is needed to fix this
problem.
Signed-off-by: Katsuhiro Suzuki
---
.../arm64/boot/dts/rockchip/rk3328-rock64.dts | 21
Hello Heiko,
On 2019/02/12 20:12, Heiko Stübner wrote:
Hi,
Am Montag, 4. Februar 2019, 13:59:37 CET schrieb Katsuhiro Suzuki:
On 2019/02/03 18:06, Heiko Stuebner wrote:
Am Samstag, 2. Februar 2019, 05:34:44 CET schrieb Katsuhiro Suzuki:
This patch adds HDMI sound (I2S0) node and remove dma
Hello Stephen,
Thanks a lot for your review. I choose clk_hw_can_set_parent_rate()
macro and fix typo and patch description. And I post v2 patch.
Best Regards,
Katsuhiro Suzuki
On 2019/02/07 4:40, Stephen Boyd wrote:
+Heiko because it mentions Rockchip
Quoting Katsuhiro Suzuki (2019-01-30 15
time.
If apply this commit, clk_fd_round_rate() calls custom approximate
function of Rockchip even if target rate is higher than parent.
Custom function changes both grand parent (i2s1_div) and parent
(i2s_frac) settings at same time. Clock mux system can choose
i2s1_frac and audio works fine.
removes 2 DMA
channel allocation for UART2. These released channels can be used
for I2S0.
Signed-off-by: Katsuhiro Suzuki
---
.../arm64/boot/dts/rockchip/rk3328-rock64.dts | 24 ++-
1 file changed, 23 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328
This patch adds #sound-dai-cells to use HDMI node as audio
codec from device tree of rk3328 boards.
Signed-off-by: Katsuhiro Suzuki
---
arch/arm64/boot/dts/rockchip/rk3328.dtsi | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/rockchip/rk3328.dtsi
b/arch/arm64/boot/dts
Hello Heiko,
On 2019/02/03 18:06, Heiko Stuebner wrote:
Am Samstag, 2. Februar 2019, 05:34:44 CET schrieb Katsuhiro Suzuki:
This patch adds HDMI sound (I2S0) node and remove dma properties
from UART2 node for rock64.
The DMAC of rk3328 can use 8 channels at same time. Currently, total
7
but DMAC has only 1 channel.
UART2 can work without DMA resources, so this patch removes dma
allocation for UART2 and reuses it to I2S0.
Signed-off-by: Katsuhiro Suzuki
---
.../arm64/boot/dts/rockchip/rk3328-rock64.dts | 24 ++-
arch/arm64/boot/dts/rockchip/rk3328.dtsi | 1 +
2
d parent
(i2s1_div) and parent (i2s_frac) settings at same time.
Clock mux system can choose i2s1_frac and audio works fine.
Signed-off-by: Katsuhiro Suzuki
---
drivers/clk/clk-fractional-divider.c | 10 +++---
1 file changed, 7 insertions(+), 3 deletions(-)
diff --git a/drivers/clk/clk
Hello Stephen,
Thank you for your comment.
I'll add detail description and send it.
Best Regards,
Katsuhiro Suzuki
On 2019/01/30 6:55, Stephen Boyd wrote:
Quoting Katsuhiro Suzuki (2019-01-07 05:21:24)
Custom approximation of fractional-divider may not need parent clock
rate checking
Ping...
On 2019/01/07 22:21, Katsuhiro Suzuki wrote:
Custom approximation of fractional-divider may not need parent clock
rate checking. For example Rockchip SoCs work fine using grand parent
clock rate evne if target rate is greater than parent.
This patch removes parent clock rate check from
Custom approximation of fractional-divider may not need parent clock
rate checking. For example Rockchip SoCs work fine using grand parent
clock rate evne if target rate is greater than parent.
This patch removes parent clock rate check from custom approximation.
Signed-off-by: Katsuhiro Suzuki
Hello Heiko,
I understand. Thanks a lot!
Best Regards,
Katsuhiro Suzuki
On 2018/12/24 16:16, Heiko Stuebner wrote:
Hi,
Am Sonntag, 23. Dezember 2018, 11:10:26 CET schrieb Katsuhiro Suzuki:
The Rock64 boards has analog audio jack on it. RK3328 can output
analog audio signal using I2S1
The Rock64 boards has analog audio jack on it. RK3328 can output
analog audio signal using I2S1 and ACODEC core.
This patch adds sound node for analog audio for Rock64.
Signed-off-by: Katsuhiro Suzuki
---
This patch depends on the following ACODEC node patch. If ACODEC
patch is not good to you
This patch adds audio codec (ACODEC) node that converts to analog
audio signal from I2S for rk3328.
Signed-off-by: Katsuhiro Suzuki
---
This patch depends on Rockcihp RK3328 ACODEC driver patches that were
applied in ALSA SoC tree. We can see the patches on this thread.
https://lkml.org/lkml
99. It seems wrong.
If frac has 134218 (it is increased 1 from original value), second
term is 64000. All other items have same situation. So this patch
adds 1 to frac member in all items of rk3328_pll_frac_rate.
Signed-off-by: Katsuhiro Suzuki
---
drivers/clk/rockchip/clk-rk3328.c | 12 ++--
This patch adds reset and precharge in shutdown of PCM device.
ACODEC goes to silence if we change Fs to 44.1kHz from 48kHz. This
workaround seems to work but I don't know this workaround is correct
sequence or not for ACODEC.
Signed-off-by: Katsuhiro Suzuki
---
sound/soc/codecs/rk3328_codec.c
1 - 100 of 394 matches
Mail list logo
