Hi Andreas,
On Sat, 23 Feb 2008 16:47:50 +0100, Andreas Schwab wrote:
Kiyoshi Ueda <[EMAIL PROTECTED]> writes:
> Could you try this patch?
> I've only done a compile test, so this patch may not work.
Unfortunately, that is not enough to get DVD burning working again.
This
Hi Andreas,
On Sat, 23 Feb 2008 16:47:50 +0100, Andreas Schwab wrote:
Kiyoshi Ueda [EMAIL PROTECTED] writes:
Could you try this patch?
I've only done a compile test, so this patch may not work.
Unfortunately, that is not enough to get DVD burning working again.
This is the error
Hi,
On Mon, 18 Feb 2008 23:37:48 +0100, Borislav Petkov wrote:
> On Mon, Feb 18, 2008 at 09:20:41PM +0100, Borislav Petkov wrote:
> > On Mon, Feb 18, 2008 at 01:58:27PM -0500, Kiyoshi Ueda wrote:
> > > Hi Andreas,
> > >
> > > On Sat, 16 Feb 2008
BUG();
HWGROUP(drive)->rq = NULL;
spin_unlock_irqrestore(_lock, flags);
Thanks,
Kiyoshi Ueda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.or
;
spin_unlock_irqrestore(ide_lock, flags);
Thanks,
Kiyoshi Ueda
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Hi,
On Mon, 18 Feb 2008 23:37:48 +0100, Borislav Petkov wrote:
On Mon, Feb 18, 2008 at 09:20:41PM +0100, Borislav Petkov wrote:
On Mon, Feb 18, 2008 at 01:58:27PM -0500, Kiyoshi Ueda wrote:
Hi Andreas,
On Sat, 16 Feb 2008 21:52:21 +0100, Andreas Schwab wrote:
Since commit
This patch converts dm-multipath target to request-based from bio-based.
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
drivers/md/dm-mpath.c | 228 +-
drivers/md/dm-rq-rec
This patch adds a hw-handler interface for request-based dm-multipath.
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
drivers/md/dm-hw-handler.h |1 +
1 files changed, 1 insertion(+)
Index: 2.6.25-rc1/drivers/md/dm-
This patch rejects bad table load for request-based dm.
The following table loadings are rejected:
- including non-stackable device
- shrinking the current restrictions
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
d
: request-based dm device on bio-based dm device
The type of a dm device is decided at the first table loading time.
Until then, mempool creations and queue initializations are deferred.
Once the type of a dm device is decided, the type can't be changed.
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTEC
This patch adds core functions for request-based dm.
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
drivers/md/dm.c | 452 +++-
drivers/md/dm.h |7
2 files changed, 45
This patch prepares memory pools for request-based dm.
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
drivers/md/dm.c | 26 +-
1 files changed, 25 insertions(+), 1 deletion(-)
Index: 2.6.25-rc1/dri
This patch adds target interfaces for request-based dm.
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
include/linux/device-mapper.h | 23 +++
1 files changed, 23 insertions(+)
Index: 2.6.25-rc1/include/
any more.
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
drivers/md/dm.c | 14 +-
1 files changed, 1 insertion(+), 13 deletions(-)
Index: 2.6.25
This patch tidies local_init() as preparation for request-based dm.
No functional change.
This patch is just a clean up of the codes and not functionally
related to request-based dm. But included here due to literal
dependency.
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Sign
-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
block/blk-core.c |6 +++---
include/linux/blkdev.h |3 +++
2 files changed, 6 insertions(+), 3 deletions(-)
Index: 2.6.25-rc1/bloc
are needed.
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
block/blk-core.c | 65 +
include/linux/blkdev.h |1
2 files changed, 66 insertions(+)
Index: 2.6.25-rc1/bloc
This patch adds a flag to indicate the request is a clone and
avoids __end_that_request_first() call for cloned requests
in blk_end_io().
So request-based dm can use blk_end_io() to complete clones
while dm doesn't want to complete the data in the clones.
Signed-off-by: Kiyoshi Ueda <[EM
time.
Then, request-based dm sets q->request_fn and wants to register
the queue correctly again.
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
block/blk-sysfs.c |1 +
1 files changed, 1 insertion(+)
Index: 2.6.25-rc1/bl
clears the busy flag when a command has been dispatched
successfully, since there may be more spaces to dispatch (the exact
limit check will be done in the next loop for the next request.)
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
that, and the block
layer is not ready for request stacking now.
To complete all requests without the queue lock, this patch uses
kblockd in such cases.
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
block/blk-barrier.c|8 ++--
bloc
o be used by request stacking drivers.
(scsi patch is included just for an example of the setting.)
To detect wrong use of the flag and the hook, some checks are also
put in __blk_end_request().
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
g.
(or rename the current ->end_io() to ->dtor() and make ->end_io()
a request stacking hook.)
Thanks,
Kiyoshi Ueda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This patch tidies local_init() as preparation for request-based dm.
No functional change.
This patch is just a clean up of the codes and not functionally
related to request-based dm. But included here due to literal
dependency.
Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]
Signed-off
This patch adds target interfaces for request-based dm.
Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]
Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED]
---
include/linux/device-mapper.h | 23 +++
1 files changed, 23 insertions(+)
Index: 2.6.25-rc1/include/linux/device
clears the busy flag when a command has been dispatched
successfully, since there may be more spaces to dispatch (the exact
limit check will be done in the next loop for the next request.)
Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]
Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED]
---
drivers/scsi
: request-based dm device on bio-based dm device
The type of a dm device is decided at the first table loading time.
Until then, mempool creations and queue initializations are deferred.
Once the type of a dm device is decided, the type can't be changed.
Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED
This patch converts dm-multipath target to request-based from bio-based.
Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]
Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED]
---
drivers/md/dm-mpath.c | 228 +-
drivers/md/dm-rq-record.h | 36 +++
2
This patch adds a flag to indicate the request is a clone and
avoids __end_that_request_first() call for cloned requests
in blk_end_io().
So request-based dm can use blk_end_io() to complete clones
while dm doesn't want to complete the data in the clones.
Signed-off-by: Kiyoshi Ueda [EMAIL
This patch adds a hw-handler interface for request-based dm-multipath.
Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]
Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED]
---
drivers/md/dm-hw-handler.h |1 +
1 files changed, 1 insertion(+)
Index: 2.6.25-rc1/drivers/md/dm-hw-handler.h
that, and the block
layer is not ready for request stacking now.
To complete all requests without the queue lock, this patch uses
kblockd in such cases.
Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]
Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED]
---
block/blk-barrier.c|8 ++--
block/blk-core.c
This patch rejects bad table load for request-based dm.
The following table loadings are rejected:
- including non-stackable device
- shrinking the current restrictions
Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]
Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED]
---
drivers/md/dm-table.c
time.
Then, request-based dm sets q-request_fn and wants to register
the queue correctly again.
Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]
Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED]
---
block/blk-sysfs.c |1 +
1 files changed, 1 insertion(+)
Index: 2.6.25-rc1/block/blk-sysfs.c
()
a request stacking hook.)
Thanks,
Kiyoshi Ueda
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
This patch adds core functions for request-based dm.
Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]
Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED]
---
drivers/md/dm.c | 452 +++-
drivers/md/dm.h |7
2 files changed, 456 insertions(+), 3
This patch prepares memory pools for request-based dm.
Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]
Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED]
---
drivers/md/dm.c | 26 +-
1 files changed, 25 insertions(+), 1 deletion(-)
Index: 2.6.25-rc1/drivers/md/dm.c
-by: Kiyoshi Ueda [EMAIL PROTECTED]
Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED]
---
block/blk-core.c |6 +++---
include/linux/blkdev.h |3 +++
2 files changed, 6 insertions(+), 3 deletions(-)
Index: 2.6.25-rc1/block/blk-core.c
.
Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]
Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED]
---
drivers/md/dm.c | 14 +-
1 files changed, 1 insertion(+), 13 deletions(-)
Index: 2.6.25-rc1/drivers/md/dm.c
are needed.
Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]
Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED]
---
block/blk-core.c | 65 +
include/linux/blkdev.h |1
2 files changed, 66 insertions(+)
Index: 2.6.25-rc1/block/blk-core.c
stacking drivers.
(scsi patch is included just for an example of the setting.)
To detect wrong use of the flag and the hook, some checks are also
put in __blk_end_request().
Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]
Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED]
---
block/blk-core.c
pc_intr(ide_drive_t
> *drive)
> */
> if ((stat & DRQ_STAT) == 0) {
> spin_lock_irqsave(_lock, flags);
> - if (__blk_end_request(rq, 0, 0))
> + if (unlikely(__blk_end_request(rq, 0, rq->data_len)))
>
ver return 1 and we should never
BUG() on the residual byte counts, unless inconsistency happens such as
the size of remaining bios is bigger than the residual byte counts.
So if __blk_end_request() returns 1 even with the Jens' patch,
it means that the block layer or the driver really have a bug.
().
Thanks,
Kiyoshi Ueda
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
;
spin_unlock_irqrestore(ide_lock, flags);
I think it's reasonable.
Thanks,
Kiyoshi Ueda
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ
fer , data , len 158
> Jan 31 22:10:06 gollum kernel: [ 26.703122] cdb: 12 00 00 00 fe 00 00 00 00
> 00 00 00 00 00 00 00
> Jan 31 22:10:06 gollum kernel: [ 26.703877] backup: data_len=158
> bi_size=158
>
> ... so we've been simply silently ignoring this unti
Hi Jens,
On Thu, 31 Jan 2008 19:16:54 +0100, Jens Axboe wrote:
> On 31/01/2008, at 18.04, Kiyoshi Ueda <[EMAIL PROTECTED]> wrote:
> > On Thu, 31 Jan 2008 14:05:58 +0100, Jens Axboe wrote:
> >> On Thu, Jan 31 2008, Nai Xia wrote:
> >>> My
))
> + if (__blk_end_request(rq, 0, rq->data_len))
> BUG();
> HWGROUP(drive)->rq = NULL;
> spin_unlock_irqrestore(_lock, flags);
OK, I undarstand the leftover is legal.
By the way, is it safe to always return succ
if there is a leftover?
I thought we might have to complete the rq with -EIO in such case.
Thanks,
Kiyoshi Ueda
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Hi Jens,
On Thu, 31 Jan 2008 19:16:54 +0100, Jens Axboe wrote:
On 31/01/2008, at 18.04, Kiyoshi Ueda [EMAIL PROTECTED] wrote:
On Thu, 31 Jan 2008 14:05:58 +0100, Jens Axboe wrote:
On Thu, Jan 31 2008, Nai Xia wrote:
My dmesg relevant info is quite similar:
[6.875041] Freeing unused
be there.
And fortunately, the issuer seems not to mind whether
end_that_request_first() is called for the remaining bio or not.
So I think Jens' patch is fine.
Thanks,
Kiyoshi Ueda
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info
Hi Roland, Borislav, Bart,
Added linux-ide ML, since we may be able to get helps from other
ide experts. This thread started from:
http://lkml.org/lkml/2008/1/29/140
On Tue, 29 Jan 2008 18:23:56 -0500 (EST), Kiyoshi Ueda wrote:
> Hi Bart,
>
> On Tue, 29 Jan 2008 14:22:53 -080
Hi Roland, Borislav, Bart,
Added linux-ide ML, since we may be able to get helps from other
ide experts. This thread started from:
http://lkml.org/lkml/2008/1/29/140
On Tue, 29 Jan 2008 18:23:56 -0500 (EST), Kiyoshi Ueda wrote:
Hi Bart,
On Tue, 29 Jan 2008 14:22:53 -0800, Roland Dreier
the rq still has a bio even after DRQ_STAT is cleared.
The original ide-cd code was calling only end_that_request_last() there.
So I thought that the rq should have no bio when DRQ_STAT is cleared,
otherwise the bio leaks.
Was my understanding wrong and is that correct behavior in ide-cd?
d outputs?
--- linus-git.orig/drivers/ide/ide-cd.c 2008-01-29 10:04:51.0 -0500
+++ linus-git/drivers/ide/ide-cd.c 2008-01-29 21:00:19.0 -0500
@@ -1723,7 +1723,7 @@
if ((stat & DRQ_STAT) == 0) {
spin_lock_irqsave(_lock, flags);
if (__blk_end_request(rq, 0,
))
- BUG();
+ blk_dump_rq_flags(rq, ide-cd: rq still having bio);
HWGROUP(drive)-rq = NULL;
spin_unlock_irqrestore(ide_lock, flags);
Thanks,
Kiyoshi Ueda
--
To unsubscribe from this list: send the line unsubscribe linux-kernel
() there.
So I thought that the rq should have no bio when DRQ_STAT is cleared,
otherwise the bio leaks.
Was my understanding wrong and is that correct behavior in ide-cd?
Thanks,
Kiyoshi Ueda
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL
This patch removes end_queued_request() and end_dequeued_request(),
which are no longer used.
As a results, users of __end_request() became only end_request().
So the actual code in __end_request() is moved to end_request()
and __end_request() is removed.
Signed-off-by: Kiyoshi Ueda <[EM
ist))
blkdev_dequeue_request(rq);
In the case of elv_next_request(), blkdev_dequeue_request() has not
been done and the queuelist isn't empty.
So __blk_end_request() calls blkdev_dequeue_request() and
the behavior of elv_next_request() doesn't change.
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]&g
[EMAIL PROTECTED]>
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
drivers/block/virtio_blk.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
Index: 2.6.24-rc7/drive
of your linux-2.6-block.git.
Please review and apply.
Thanks,
Kiyoshi Ueda
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FA
of your linux-2.6-block.git.
Please review and apply.
Thanks,
Kiyoshi Ueda
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http
PROTECTED]
Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]
Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED]
---
drivers/block/virtio_blk.c | 10 +-
1 files changed, 5 insertions(+), 5 deletions(-)
Index: 2.6.24-rc7/drivers/block/virtio_blk.c
This patch removes end_queued_request() and end_dequeued_request(),
which are no longer used.
As a results, users of __end_request() became only end_request().
So the actual code in __end_request() is moved to end_request()
and __end_request() is removed.
Signed-off-by: Kiyoshi Ueda [EMAIL
))
blkdev_dequeue_request(rq);
In the case of elv_next_request(), blkdev_dequeue_request() has not
been done and the queuelist isn't empty.
So __blk_end_request() calls blkdev_dequeue_request() and
the behavior of elv_next_request() doesn't change.
Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]
Signed
().
Cc: Grant Likely <[EMAIL PROTECTED]>
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
drivers/block/xsysace.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
--- a/drivers/block/xsysace.c
+++ b/drive
to __blk_end_request().
Cc: Grant Likely [EMAIL PROTECTED]
Signed-off-by: Kiyoshi Ueda [EMAIL PROTECTED]
Signed-off-by: Jun'ichi Nomura [EMAIL PROTECTED]
---
drivers/block/xsysace.c |6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
--- a/drivers/block/xsysace.c
+++ b/drivers/block/xsysace.c
@@ -483,7
ve investigated all code paths which call ub_end_rq() in ub.c,
and confirmed that ub_end_rq() is always called with the queue lock
held. (sc->lock is registered as a queue lock.)
So there is no such race in the current ub code.
You don't need to rewrite ub.
Thanks,
Kiyoshi Ueda
--
To unsubscribe fro
to rewrite ub.
Thanks,
Kiyoshi Ueda
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
disk_stat_add(rq->rq_disk, sectors[rw],
> > rq->nr_sectors);
> > + all_stat_add(rq->rq_disk, sectors[rw],
> > +rq->nr_sectors, rq->sector);
> > }
>
> How does this mesh with the changes submitted by
-nr_sectors, rq-sector);
}
How does this mesh with the changes submitted by Kiyoshi Ueda? Any conflicts?
I think no conflict with my patch technically.
Jerome's patch changes __end_that_request_first(), too, as same as
the change above.
And my patch changes cciss/cpqarray to use
Hi James, Jens,
On Wed, 12 Dec 2007 07:53:36 -0500, James Bottomley wrote:
> On Tue, 2007-12-11 at 17:40 -0500, Kiyoshi Ueda wrote:
> > This patch adds 2 new interfaces for request completion:
> > o blk_end_request() : called without queue lock
> > o __blk_end_request(
() calls end_that_request_last() without taking
the queue lock in itself.
So the queue lock must have been taken outside ub_end_rq().
But, if ub is calling end_that_request_last() without the queue lock,
it is a bug in the original code and we should use blk_end_request()
to fix that.
Does
A_COMPLETE);
>
> Why is this removed?
Sorry for the less explanation.
Because it is done in __end_that_request_first() called from
blk_end_request().
I'll add the explanation to the patch description when I update
the patch.
Thanks,
Kiyoshi Ueda
--
To unsubscribe from this list: send the line &quo
s again, and I found no other miss conversions.
Below is the revised patch for xsysace.
Thanks,
Kiyoshi Ueda
Subject: [PATCH 20/30] blk_end_request: changing xsysace (take 4)
This patch converts xsysace to use blk_end_request interfaces.
Related 'uptodate' arguments are converted to 'error'.
xsys
sectors __blk_end_request() now takes
bytes
Thank you for pointing it out! And I'm very sorry for the bug.
I have checked all conversions between sectors and bytes through
all patches again, and I found no other miss conversions.
Below is the revised patch for xsysace.
Thanks,
Kiyoshi Ueda
blk_end_request().
I'll add the explanation to the patch description when I update
the patch.
Thanks,
Kiyoshi Ueda
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
is calling end_that_request_last() without the queue lock,
it is a bug in the original code and we should use blk_end_request()
to fix that.
Does that answer satisfy you?
Thanks,
Kiyoshi Ueda
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to [EMAIL
Hi James, Jens,
On Wed, 12 Dec 2007 07:53:36 -0500, James Bottomley wrote:
On Tue, 2007-12-11 at 17:40 -0500, Kiyoshi Ueda wrote:
This patch adds 2 new interfaces for request completion:
o blk_end_request() : called without queue lock
o __blk_end_request() : called with queue lock
ed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
block/ll_rw_blk.c | 56 +++--
include/linux/blkdev.h |8 ---
2 files changed, 9 insertions(+), 55 deletions(-)
Index: 2.6.24-rc4
This patch removes the following functions:
o end_that_request_first()
o end_that_request_chunk()
and stops exporting the functions below:
o end_that_request_last()
Cc: Boaz Harrosh <[EMAIL PROTECTED]>
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi No
() is no longer exported, the code can be
merged to end_that_request_last().
Cc: Boaz Harrosh <[EMAIL PROTECTED]>
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
block/ll_rw_blk.c | 31 ++-
1
;
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
drivers/scsi/scsi_lib.c | 31 +++
1 files changed, 11 insertions(+), 20 deletions(-)
Index: 2.6.24-rc4
t_rq->end_io is not
called). So if special completion handling is needed, the handler
must be set to rq->end_io.
And the handler must take care of freeing next_rq too, since
the interface doesn't care of it if rq->end_io is not NULL.
Cc: Boaz Harrosh <[EMAIL PROTECTED]>
Signed-o
AIL PROTECTED]>
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
drivers/ide/ide-cd.c | 49 +++--
1 files changed, 35 insertions(+), 14 deletions(-)
Index: 2.6.24-rc4/dr
the patch subject
"[PATCH 01/30] blk_end_request: add new request completion interface".
Cc: Mike Miller <[EMAIL PROTECTED]>
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
drivers/block/cpqarray.c | 36 +++
blk_end_request_callback() to return
without completing request.
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
block/ll_rw_blk.c | 72 -
include/linux/blkdev.h |2 +
2 f
add new request
completion interface".
Cc: Grant Likely <[EMAIL PROTECTED]>
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
drivers/block/xsysace.c |5 +
1 files changed, 1 insertion(+), 4 deletions(-)
Ind
blk_end_request can handle it correctly although ide always run
thought the code above.
Cc: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
drivers/ide/ide-cd.c |
ch subject
"[PATCH 01/30] blk_end_request: add new request completion interface".
Cc: Mike Miller <[EMAIL PROTECTED]>
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
drivers/block/cciss.c | 25 +++---
This patch converts ide-scsi to use blk_end_request interfaces.
Related 'uptodate' arguments are converted to 'error'.
Cc: Bartlomiej Zolnierkiewicz <[EMAIL PROTECTED]>
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
drive
rstens <[EMAIL PROTECTED]>
Cc: [EMAIL PROTECTED]
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
drivers/s390/block/dasd.c | 19 ++-
drivers/s390/char/tape_block.c | 13 ++---
2 files chang
This patch converts viocd to use blk_end_request interfaces.
Related 'uptodate' arguments are converted to 'error'.
As a result, the interface of internal function, viocd_end_request(),
is changed.
Cc: Stephen Rothwell <[EMAIL PROTECTED]>
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED
This patch converts mmc to use blk_end_request interfaces.
Related 'uptodate' arguments are converted to 'error'.
Cc: Pierre Ossman <[EMAIL PROTECTED]>
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
drivers/mmc/c
This patch converts xen-blkfront to use blk_end_request interfaces.
Related 'uptodate' arguments are converted to 'error'.
Cc: Jeremy Fitzhardinge <[EMAIL PROTECTED]>
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
This patch converts i2o_block to use blk_end_request interfaces.
Related 'uptodate' arguments are converted to 'error'.
As a result, the interface of internal function, i2o_block_end_request(),
is changed.
Cc: Markus Lidel <[EMAIL PROTECTED]>
Signed-off-by: Kiyoshi Ueda <[EMAIL
This patch converts viodasd to use blk_end_request interfaces.
Related 'uptodate' arguments are converted to 'error'.
As a result, the interface of internal function, viodasd_end_request(),
is changed.
Cc: Stephen Rothwell <[EMAIL PROTECTED]>
Signed-off-by: Kiyoshi Ueda <[EMAIL
place above.
Cc: Jeff Garzik <[EMAIL PROTECTED]>
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
drivers/block/sx8.c | 58 +---
1 files changed, 28 insertions(+), 30 deletions
This patch converts ub to use blk_end_request interfaces.
Related 'uptodate' arguments are converted to 'error'.
Cc: Pete Zaitcev <[EMAIL PROTECTED]>
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura <[EMAIL PROTECTED]>
---
drivers/block/ub.c |
This patch converts sunvdc to use blk_end_request interfaces.
Related 'uptodate' arguments are converted to 'error'.
As a result, the interface of internal function, vdc_end_request(),
is changed.
Cc: David S. Miller <[EMAIL PROTECTED]>
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
This patch converts ps3disk to use blk_end_request interfaces.
Related 'uptodate' arguments are converted to 'error'.
Cc: Geoff Levand <[EMAIL PROTECTED]>
Cc: Geert Uytterhoeven <[EMAIL PROTECTED]>
Signed-off-by: Kiyoshi Ueda <[EMAIL PROTECTED]>
Signed-off-by: Jun'ichi Nomura
1 - 100 of 351 matches
Mail list logo
