Re: [PATCH -next] sound: n64: Fix return value check in n64audio_probe()

2021-02-23 Thread Lauri Kasanen
ound: Add n64 driver") > Reported-by: Hulk Robot > Signed-off-by: Wei Yongjun > --- > sound/mips/snd-n64.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Reviewed-by: Lauri Kasanen - Lauri

[PATCH v3] carl9170: Clarify kconfig text

2016-04-18 Thread Lauri Kasanen
The previous text was confusing, leading readers to think this driver was a duplicate, and so didn't need to be enabled. After the removal of the older staging driver, this is the only driver in mainline for these devices. Signed-off-by: Lauri Kasanen <c...@gmx.com> --- v3: Remove all fi

[PATCH v3] carl9170: Clarify kconfig text

2016-04-18 Thread Lauri Kasanen
The previous text was confusing, leading readers to think this driver was a duplicate, and so didn't need to be enabled. After the removal of the older staging driver, this is the only driver in mainline for these devices. Signed-off-by: Lauri Kasanen --- v3: Remove all firmware mentions

[PATCH v2] carl9170: Clarify kconfig text

2016-04-16 Thread Lauri Kasanen
The previous text was confusing, leading readers to think this driver was a duplicate, and so didn't need to be enabled. After the removal of the older staging driver, this is the only driver in mainline for these devices. Signed-off-by: Lauri Kasanen <c...@gmx.com> --- v2: Remove the m

[PATCH v2] carl9170: Clarify kconfig text

2016-04-16 Thread Lauri Kasanen
The previous text was confusing, leading readers to think this driver was a duplicate, and so didn't need to be enabled. After the removal of the older staging driver, this is the only driver in mainline for these devices. Signed-off-by: Lauri Kasanen --- v2: Remove the mention of the previous

[PATCH] carl9170: Clarify kconfig text

2016-04-16 Thread Lauri Kasanen
The previous text was confusing, leading readers to think this driver was a duplicate, and so didn't need to be enabled. After the removal of the older staging driver, this is the only driver in mainline for these devices. Signed-off-by: Lauri Kasanen <c...@gmx.com> --- drivers/net/wirele

[PATCH] carl9170: Clarify kconfig text

2016-04-16 Thread Lauri Kasanen
The previous text was confusing, leading readers to think this driver was a duplicate, and so didn't need to be enabled. After the removal of the older staging driver, this is the only driver in mainline for these devices. Signed-off-by: Lauri Kasanen --- drivers/net/wireless/ath/carl9170

[PATCHv4] HID: sony: Enable Gasia third-party PS3 controllers

2015-02-16 Thread Lauri Kasanen
Without this, my "Gasia Co.,Ltd PS(R) Gamepad" would not send any events. Now everything works including the leds. Based on work by Andrew Haines and Antonio Ospite. cc: Antonio Ospite cc: Andrew Haines Signed-off-by: Lauri Kasanen --- drivers/hid/hid-sony.c | 22 +++

[PATCHv4] HID: sony: Enable Gasia third-party PS3 controllers

2015-02-16 Thread Lauri Kasanen
Without this, my Gasia Co.,Ltd PS(R) Gamepad would not send any events. Now everything works including the leds. Based on work by Andrew Haines and Antonio Ospite. cc: Antonio Ospite a...@ao2.it cc: Andrew Haines andrewd...@aol.com Signed-off-by: Lauri Kasanen c...@gmx.com --- drivers/hid/hid

[PATCHv3] HID: sony: Enable Gasia third-party PS3 controllers

2015-02-10 Thread Lauri Kasanen
Without this, my "Gasia Co.,Ltd PS(R) Gamepad" would not send any events. Now everything works including the leds. Based on work by Andrew Haines and Antonio Ospite. cc: Antonio Ospite cc: Andrew Haines Signed-off-by: Lauri Kasanen --- drivers/hid/hid-sony.c | 24 +

Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers, v2

2015-02-10 Thread Lauri Kasanen
Hi Antonio, > These annotations about the history of a patch are usually added > after the '---' marker right before sending the patch, not in the commit > message. > > They are useful for reviewers, but not really interesting anymore after > the code is validated and merged. > > In the subject

Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers, v2

2015-02-10 Thread Lauri Kasanen
Hi Antonio, These annotations about the history of a patch are usually added after the '---' marker right before sending the patch, not in the commit message. They are useful for reviewers, but not really interesting anymore after the code is validated and merged. In the subject you can

[PATCHv3] HID: sony: Enable Gasia third-party PS3 controllers

2015-02-10 Thread Lauri Kasanen
Without this, my Gasia Co.,Ltd PS(R) Gamepad would not send any events. Now everything works including the leds. Based on work by Andrew Haines and Antonio Ospite. cc: Antonio Ospite a...@ao2.it cc: Andrew Haines andrewd...@aol.com Signed-off-by: Lauri Kasanen c...@gmx.com --- drivers/hid/hid

Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers

2015-02-09 Thread Lauri Kasanen
On Mon, 09 Feb 2015 11:08:01 +0100 Oliver Neukum wrote: > > + ret = usb_interrupt_msg(dev, usb_sndintpipe(dev, 0x02), > > + buf2, sizeof(buf2), > > + , USB_CTRL_SET_TIMEOUT); > > You cannot do this. Even for a single byte DMA on the stack is

Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers

2015-02-09 Thread Lauri Kasanen
On Mon, 09 Feb 2015 11:08:01 +0100 Oliver Neukum oneu...@suse.de wrote: + ret = usb_interrupt_msg(dev, usb_sndintpipe(dev, 0x02), + buf2, sizeof(buf2), + transfered, USB_CTRL_SET_TIMEOUT); You cannot do this. Even for a single byte

[PATCH] HID: sony: Enable Gasia third-party PS3 controllers, v2

2015-02-08 Thread Lauri Kasanen
Without this, my "Gasia Co.,Ltd PS(R) Gamepad" would not send any events. Now everything works including the leds. Based on work by Andrew Haines and Antonio Ospite. v2: - edited error messages - use output_report cc: Antonio Ospite cc: Andrew Haines Signed-off-by: Lauri Kasanen --

[PATCH] HID: sony: Enable Gasia third-party PS3 controllers, v2

2015-02-08 Thread Lauri Kasanen
-by: Lauri Kasanen c...@gmx.com --- drivers/hid/hid-sony.c | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) Despite Andrew's report, using output_report worked fine. diff --git a/drivers/hid/hid-sony.c b/drivers/hid/hid-sony.c index 31e9d25..2661227 100644 --- a/drivers/hid

Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers

2015-02-07 Thread Lauri Kasanen
Hi, On Sat, 7 Feb 2015 17:31:33 +0100 Antonio Ospite wrote: > > > +#include > > > > Please don't. > > HID should be transport agnostic, so please refrain from directly call usb. > > > > I agree with Benjamin here. > > > > + > > > + ret = usb_interrupt_msg(dev, usb_sndintpipe(dev,

[PATCH] HID: sony: Enable Gasia third-party PS3 controllers

2015-02-07 Thread Lauri Kasanen
Without this, my "Gasia Co.,Ltd PS(R) Gamepad" would not send any events. Now everything works including the leds. Based on work by Andrew Haines and Antonio Ospite. cc: Antonio Ospite cc: Andrew Haines Signed-off-by: Lauri Kasanen --- drivers/hid/hid-s

[PATCH] HID: sony: Enable Gasia third-party PS3 controllers

2015-02-07 Thread Lauri Kasanen
Without this, my Gasia Co.,Ltd PS(R) Gamepad would not send any events. Now everything works including the leds. Based on work by Andrew Haines and Antonio Ospite. cc: Antonio Ospite a...@ao2.it cc: Andrew Haines andrewd...@aol.com Signed-off-by: Lauri Kasanen c...@gmx.com --- drivers/hid/hid

Re: [PATCH] HID: sony: Enable Gasia third-party PS3 controllers

2015-02-07 Thread Lauri Kasanen
Hi, On Sat, 7 Feb 2015 17:31:33 +0100 Antonio Ospite a...@ao2.it wrote: +#include linux/usb/input.h Please don't. HID should be transport agnostic, so please refrain from directly call usb. I agree with Benjamin here. + + ret = usb_interrupt_msg(dev,

Re: [RFC] rootmpfs

2013-04-11 Thread Lauri Kasanen
Rob Landley landley.net> writes: > Attached is my quick and dirty hack to make rootfs be tmpfs when > CONFIG_TMPFS is > enabled. It can't be this easy or somebody would have done it in the > _eight_years_ > since https://lkml.org/lkml/2006/7/31/145 Hi Rob, We've been using a variation of

Re: [RFC] rootmpfs

2013-04-11 Thread Lauri Kasanen
Rob Landley rob at landley.net writes: Attached is my quick and dirty hack to make rootfs be tmpfs when CONFIG_TMPFS is enabled. It can't be this easy or somebody would have done it in the _eight_years_ since https://lkml.org/lkml/2006/7/31/145 Hi Rob, We've been using a variation of

Kernel hang right before init on some i586 (bug report)

2007-06-07 Thread Lauri Kasanen
Hi. Yesterday I encountered this bug, and after trying everything, thought I'd let you know. I also googled a lot, and there is no known solution. So now I tell my findings to the kernel developers. On some i586 comps linux kernel hangs right after displaying "freeing unused kernel memory:".

Kernel hang right before init on some i586 (bug report)

2007-06-07 Thread Lauri Kasanen
Hi. Yesterday I encountered this bug, and after trying everything, thought I'd let you know. I also googled a lot, and there is no known solution. So now I tell my findings to the kernel developers. On some i586 comps linux kernel hangs right after displaying freeing unused kernel memory:. Here