On Fri, 12 Apr 2024 16:22:53 +0200, Luca Weiss wrote:
> Add the PBS (Programmable Boot Sequencer) to the list of devices.
>
>
Applied, thanks!
[1/1] dt-bindings: mfd: qcom,spmi-pmic: Add pbs to SPMI device types
commit: a1f3b5edaf18b1c71a537032c4a6537bde2ad5e9
--
Lee Jones [李琼斯]
On Thu, 11 Apr 2024, Karel Balej wrote:
> Lee Jones, 2024-04-11T12:37:26+01:00:
> [...]
> > > diff --git a/drivers/mfd/88pm886.c b/drivers/mfd/88pm886.c
> > > new file mode 100644
> > > index ..e06d418a5da9
> > > --- /dev/null
> > &g
D_88PM886_PMIC) += 88pm886.o
> obj-$(CONFIG_MFD_ACT8945A) += act8945a.o
> obj-$(CONFIG_MFD_SM501) += sm501.o
> obj-$(CONFIG_ARCH_BCM2835) += bcm2835-pm.o
> diff --git a/include/linux/mfd/88pm886.h b/include/linux/mfd/88pm886.h
> new file mode 100644
> index ..5ce30a3b85aa
> --- /dev/null
> +++ b/include/linux/mfd/88pm886.h
> @@ -0,0 +1,30 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +#ifndef __MFD_88PM886_H
> +#define __MFD_88PM886_H
> +
> +#include
> +#include
> +
> +#define PM886_A1_CHIP_ID 0xa1
> +
> +#define PM886_REG_ID 0x00
> +
> +#define PM886_REG_STATUS10x01
> +#define PM886_ONKEY_STS1 BIT(0)
> +
> +#define PM886_REG_MISC_CONFIG1 0x14
> +#define PM886_SW_PDOWN BIT(5)
> +
> +#define PM886_REG_MISC_CONFIG2 0x15
> +#define PM886_INT_INVBIT(0)
> +#define PM886_INT_CLEAR BIT(1)
> +#define PM886_INT_RC 0x00
> +#define PM886_INT_WC BIT(1)
> +#define PM886_INT_MASK_MODE BIT(2)
> +
> +struct pm886_chip {
> + struct i2c_client *client;
> + unsigned int chip_id;
> + struct regmap *regmap;
> +};
> +#endif /* __MFD_88PM886_H */
> --
> 2.44.0
>
--
Lee Jones [李琼斯]
On Thu, 21 Mar 2024, Karel Balej wrote:
> Lee Jones, 2024-03-21T15:42:11+00:00:
> > On Mon, 11 Mar 2024, Karel Balej wrote:
> >
> > > From: Karel Balej
> > >
> > > Marvell 88PM886 is a PMIC which provides various functions such as
> > >
client *client;
> + unsigned int chip_id;
> + struct regmap *regmap;
> +};
> +
> +static const struct regmap_config pm886_i2c_regmap = {
> + .reg_bits = 8,
> + .val_bits = 8,
> + .max_register = PM886_REGMAP_CONF_MAX_REG,
> +};
Why is this in here?
> +#endif /* __MFD_88PM886_H */
What would you like me to do with this RFC patch?
--
Lee Jones [李琼斯]
; + err = PTR_ERR(regmap);
> > > + dev_err(dev, "Failed to initialize regulators regmap: %d\n",
> > > err);
> > > + return err;
> > > + }
> > > + chip->regmaps[PM886_REGMAP_REGULATORS] = regmap;
> >
> > Except for the regulator driver, where else is the regulators regmap used?
>
> Nowhere, at least as of now. So you are saying that I should initialize
> the regmap in the regulator driver?
I am.
--
Lee Jones [李琼斯]
100644
> index ..c7527bab0fba
> --- /dev/null
> +++ b/include/linux/mfd/88pm886.h
> @@ -0,0 +1,46 @@
> +/* SPDX-License-Identifier: GPL-2.0-only */
> +#ifndef __MFD_88PM886_H
> +#define __MFD_88PM886_H
> +
> +#include
What's this for?
> +#define PM886_A1_CHIP_ID 0xa1
> +
> +#define PM886_REG_ID 0x00
> +
> +#define PM886_REG_STATUS10x01
> +#define PM886_ONKEY_STS1 BIT(0)
> +
> +#define PM886_REG_MISC_CONFIG1 0x14
> +#define PM886_SW_PDOWN BIT(5)
> +
> +#define PM886_REG_MISC_CONFIG2 0x15
> +#define PM886_INT_INVBIT(0)
> +#define PM886_INT_CLEAR BIT(1)
> +#define PM886_INT_RC 0x00
> +#define PM886_INT_WC BIT(1)
> +#define PM886_INT_MASK_MODE BIT(2)
> +
> +#define PM886_PAGE_OFFSET_REGULATORS 1
> +
> +enum pm886_regulator_id {
> + PM886_REGULATOR_ID_LDO2,
> + PM886_REGULATOR_ID_LDO15,
> + PM886_REGULATOR_ID_BUCK2,
> +
> + PM886_REGULATOR_ID_SENTINEL
> +};
> +
> +enum pm886_regmap_index {
> + PM886_REGMAP_BASE,
> + PM886_REGMAP_REGULATORS,
> +
> + PM886_REGMAP_NR
> +};
> +
> +struct pm886_chip {
> + struct i2c_client *client;
> + unsigned int whoami;
chip_id
> + struct regmap *regmaps[PM886_REGMAP_NR];
> +};
> +#endif /* __MFD_88PM886_H */
> --
> 2.44.0
>
--
Lee Jones [李琼斯]
t; belonging to the synchronized triled block and one loose PWM channel.
>
>
Applied, thanks!
[1/1] leds: qcom-lpg: Add PM660L configuration and compatible
commit: 0e848bb4630e12099636fde050cadad33221045f
--
Lee Jones [李琼斯]
Linus,
On Fri, 02 Feb 2024, Karel Balej wrote:
> Lee Jones, 2024-02-02T12:45:50+00:00:
> > On Thu, 01 Feb 2024, Karel Balej wrote:
> >
> > > Lee Jones, 2024-01-31T11:03:11+00:00:
> > > > On Sun, 28 Jan 2024, Karel Balej wrote:
> &g
On Thu, 01 Feb 2024, Karel Balej wrote:
> Lee Jones, 2024-01-31T11:03:11+00:00:
> > On Sun, 28 Jan 2024, Karel Balej wrote:
> > > > > + /* GPIO1: DVC, GPIO0: input */
> > > > > + REG_SEQ0(PM88X_REG_GPIO_CTRL1, 0x40),
> > > &
ady use for. I intend to add the other parts along with the
> respective subdevice drivers, please see my regulator series [1] for an
> example.
>
> I thought this approach would make for shorter and simpler patches and
> also would allow me to make more informed decisions as I familiarize
> myself with the downstream subdevice drivers more closely one by one.
One device doesn't warrant an MFD. Please add more devices.
--
Lee Jones [李琼斯]
ONFIG2 0x15
> +#define PM88X_INT_INVBIT(0)
> +#define PM88X_INT_CLEAR BIT(1)
> +#define PM88X_INT_RC 0x00
> +#define PM88X_INT_WC BIT(1)
> +#define PM88X_INT_MASK_MODE BIT(2)
> +
> +#define PM88X_REG_WDOG 0x1d
> +
> +#define PM88X_REG_LOWPOWER2 0x21
> +#define PM88X_REG_LOWPOWER4 0x23
> +
> +#define PM88X_REG_GPIO_CTRL1 0x30
These don't really need to be spaced out, do they?
> +#define PM88X_REG_GPIO_CTRL2 0x31
> +
> +#define PM88X_REG_GPIO_CTRL3 0x32
> +
> +#define PM88X_REG_GPIO_CTRL4 0x33
> +
> +#define PM88X_REG_BK_OSC_CTRL1 0x50
> +#define PM88X_REG_BK_OSC_CTRL3 0x52
> +
> +#define PM88X_REG_AON_CTRL2 0xe2
> +
> +enum pm88x_regmap_index {
> + PM88X_REGMAP_BASE,
> +
> + PM88X_REGMAP_NR
> +};
> +
> +struct pm88x_data {
> + unsigned int whoami;
> + struct reg_sequence *presets;
> + unsigned int num_presets;
> +};
> +
> +struct pm88x_chip {
> + struct i2c_client *client;
> + struct regmap_irq_chip_data *irq_data;
Group this with the other regmap related member(s).
What are you using this for?
> + const struct pm88x_data *data;
Remove this.
> + struct regmap *regmaps[PM88X_REGMAP_NR];
> +};
> +#endif /* __LINUX_MFD_88PM88X_H */
> --
> 2.43.0
>
--
9)
4)
Lee Jones [李琼斯]
On Thu, 11 Jan 2024, Karel Balej wrote:
> On Thu Jan 11, 2024 at 4:25 PM CET, Lee Jones wrote:
>
> [...]
>
> > > > > diff --git a/include/linux/mfd/88pm88x.h b/include/linux/mfd/88pm88x.h
> > > > > index a34c57447827..9a335f6b9c07 100644
&
On Thu, 11 Jan 2024, Karel Balej wrote:
> Lee,
>
> On Thu Jan 11, 2024 at 11:54 AM CET, Lee Jones wrote:
> > The subject needs work. Please tell us what the patches is doing.
> >
> > On Thu, 28 Dec 2023, Karel Balej wrote:
> >
> > > From: Karel Balej
335f6b9c07 100644
> --- a/include/linux/mfd/88pm88x.h
> +++ b/include/linux/mfd/88pm88x.h
> @@ -49,6 +49,8 @@ struct pm88x_data {
> unsigned int whoami;
> struct reg_sequence *presets;
> unsigned int num_presets;
> + struct mfd_cell *devs;
> + unsigned int num_devs;
Why are you adding extra abstraction?
> };
>
> struct pm88x_chip {
> --
> 2.43.0
>
--
Lee Jones [李琼斯]
26d9b40
[2/2] leds: add ktd202x driver
commit: 4239b17b5de0dcd5900727be5597ba061acd00b8
--
Lee Jones [李琼斯]
unused labels from examples
commit: cac94656ff2b16827d7cd455f0d3746280cf3138
--
Lee Jones [李琼斯]
ate as possible and omitting as many
of these gotos as you can.
> + }
> +
> + chip->regulators[0].supply = "vin";
> + chip->regulators[1].supply = "vio";
> + ret = devm_regulator_bulk_get(dev, ARRAY_SIZE(chip->regulators),
> + chip->regulators);
> + if (ret < 0) {
> + dev_err_probe(dev, ret, "Failed to request regulators.\n");
> + goto error;
> + }
> +
> + ret = regulator_bulk_enable(ARRAY_SIZE(chip->regulators),
> + chip->regulators);
> + if (ret) {
> + dev_err_probe(dev, ret, "Failed to enable regulators.\n");
> + goto error;
> + }
> +
> + ret = ktd202x_probe_dt(chip);
> + if (ret < 0)
> + goto error_reg;
> +
> + ret = regulator_bulk_disable(ARRAY_SIZE(chip->regulators),
> + chip->regulators);
> + if (ret) {
> + dev_err_probe(dev, ret, "Failed to disable regulators.\n");
> + goto error;
> + }
> +
> + return 0;
> +
> +error_reg:
> + regulator_bulk_disable(ARRAY_SIZE(chip->regulators),
> +chip->regulators);
> +
> +error:
> + mutex_destroy(>mutex);
> + return ret;
> +}
> +
> +static void ktd202x_remove(struct i2c_client *client)
> +{
> + struct ktd202x *chip = i2c_get_clientdata(client);
> +
> + ktd202x_chip_disable(chip);
> +
> + mutex_destroy(>mutex);
> +}
> +
> +static void ktd202x_shutdown(struct i2c_client *client)
> +{
> + struct ktd202x *chip = i2c_get_clientdata(client);
> +
> + /* Reset registers to make sure all off before shutdown */
Grammar.
> + regmap_write(chip->regmap, KTD202X_REG_RESET_CONTROL,
> + KTD202X_RSTR_RESET);
> +}
> +
> +static const struct of_device_id ktd202x_match_table[] = {
> + { .compatible = "kinetic,ktd2026", .data = (void *)KTD2026_NUM_LEDS },
> + { .compatible = "kinetic,ktd2027", .data = (void *)KTD2027_NUM_LEDS },
> + {},
> +};
> +
Remove these line.
> +MODULE_DEVICE_TABLE(of, ktd202x_match_table);
> +
> +static struct i2c_driver ktd202x_driver = {
> + .driver = {
> + .name = "leds-ktd202x",
> + .of_match_table = ktd202x_match_table,
> + },
> + .probe = ktd202x_probe,
> + .remove = ktd202x_remove,
> + .shutdown = ktd202x_shutdown,
> +};
> +module_i2c_driver(ktd202x_driver);
> +
> +MODULE_AUTHOR("André Apitzsch ");
> +MODULE_DESCRIPTION("Kinetic KTD2026/7 LED driver");
> +MODULE_LICENSE("GPL");
>
> --
> 2.42.0
>
--
8)
3)
Lee Jones [李琼斯]
On Fri, 16 Apr 2021, Christian König wrote:
>
>
> Am 16.04.21 um 16:37 schrieb Lee Jones:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/gpu/drm/ttm/ttm_tt.c:398: warning: Function parameter or member
> > 'num_pages' not described in 't
On Mon, 19 Apr 2021, Tyler Hicks wrote:
> On 2021-03-30 17:44:27, Lee Jones wrote:
> > This set is part of a larger effort attempting to clean-up W=1
> > kernel builds, which are currently overwhelmingly riddled with
> > niggly little warnings.
> >
> > T
On Mon, 19 Apr 2021, Lee Jones wrote:
> On Mon, 19 Apr 2021, Lee Jones wrote:
>
> > On Mon, 19 Apr 2021, ChiYuan Huang wrote:
> >
> > > Hi, Linux mfd reviewers:
> > >It's been three weeks not to get any response from you.
> > > Is there somet
On Mon, 19 Apr 2021, Lee Jones wrote:
> On Mon, 19 Apr 2021, ChiYuan Huang wrote:
>
> > Hi, Linux mfd reviewers:
> >It's been three weeks not to get any response from you.
> > Is there something wrong about this mfd patch?
> > If yes, please feel free to let
copyright.
> > - Refine error logs in probe.
> > - Refine comment lines in remove and shutdown.
> > ---
> > drivers/mfd/Kconfig | 10 +
> > drivers/mfd/Makefile | 1 +
> > drivers/mfd/rt4831.c | 115
> > +++
> > 3 files changed, 126 insertions(+)
> > create mode 100644 drivers/mfd/rt4831.c
--
Lee Jones [李琼斯]
Senior Technical Lead - Developer Services
Linaro.org │ Open source software for Arm SoCs
Follow Linaro: Facebook | Twitter | Blog
On Fri, 16 Apr 2021, Krzysztof Kozlowski wrote:
> On 16/04/2021 16:37, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/gpu/drm/exynos/exynos_drm_fimd.c:734: warning: expecting prototype
> > for shad
: Benjamin Gaignard
Cc: David Airlie
Cc: Daniel Vetter
Cc: Philipp Zabel
Cc: Vincent Abriou
Cc: dri-de...@lists.freedesktop.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/sti/sti_hdmi.c | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/sti
: linux-arm-ker...@lists.infradead.org
Cc: linux-samsung-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/exynos/exynos_drm_ipp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/exynos/exynos_drm_ipp.c
b/drivers/gpu/drm/exynos/exynos_drm_ipp.c
Cc: David Airlie
Cc: Daniel Vetter
Cc: Matthias Brugger
Cc: dri-de...@lists.freedesktop.org
Cc: linux-media...@lists.infradead.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/mediatek/mtk_disp_ccorr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion
Cc: Daniel Vetter
Cc: Krzysztof Kozlowski
Cc: Akshu Agarwal
Cc: Ajay Kumar
Cc: dri-de...@lists.freedesktop.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-samsung-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/exynos/exynos7_drm_decon.c | 2 +-
1 file changed, 1
: Daniel Vetter
Cc: dri-de...@lists.freedesktop.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/panel/panel-sitronix-st7701.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-sitronix-st7701.c
b/drivers/gpu/drm/panel/panel-sitronix-st7701.c
index
Vetter
Cc: Sumit Semwal
Cc: Jerome Glisse
Cc: amd-...@lists.freedesktop.org
Cc: dri-de...@lists.freedesktop.org
Cc: linux-me...@vger.kernel.org
Cc: linaro-mm-...@lists.linaro.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 2 +-
1 file changed, 1 insertion(+),
Vetter
Cc: Sumit Semwal
Cc: Jerome Glisse
Cc: amd-...@lists.freedesktop.org
Cc: dri-de...@lists.freedesktop.org
Cc: linux-me...@vger.kernel.org
Cc: linaro-mm-...@lists.linaro.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/amd/amdgpu/amdgpu_cs.c | 6 +++---
1 file changed, 3 insertions(+), 3
: Daniel Vetter
Cc: Krzysztof Kozlowski
Cc: dri-de...@lists.freedesktop.org
Cc: linux-arm-ker...@lists.infradead.org
Cc: linux-samsung-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/exynos/exynos_drm_fimd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
for
amdgpu_dummy_page_fini(). Prototype was for amdgpu_gart_dummy_page_fini()
instead
Cc: Alex Deucher
Cc: "Christian König"
Cc: David Airlie
Cc: Daniel Vetter
Cc: Nirmoy Das
Cc: amd-...@lists.freedesktop.org
Cc: dri-de...@lists.freedesktop.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/
l
Cc: amd-...@lists.freedesktop.org
Cc: dri-de...@lists.freedesktop.org
Cc: linux-me...@vger.kernel.org
Cc: linaro-mm-...@lists.linaro.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ring.c
mit Semwal
Cc: Jerome Glisse
Cc: amd-...@lists.freedesktop.org
Cc: dri-de...@lists.freedesktop.org
Cc: linux-me...@vger.kernel.org
Cc: linaro-mm-...@lists.linaro.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/amd/amdgpu/amdgpu_fence.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/g
Cc: Adam Jackson
Cc: Ben Widawsky
Cc: dri-de...@lists.freedesktop.org
Cc: linux-me...@vger.kernel.org
Cc: linaro-mm-...@lists.linaro.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/vgem/vgem_drv.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/vgem/vgem_drv.c
"
Cc: David Airlie
Cc: Daniel Vetter
Cc: Sumit Semwal
Cc: amd-...@lists.freedesktop.org
Cc: dri-de...@lists.freedesktop.org
Cc: linux-me...@vger.kernel.org
Cc: linaro-mm-...@lists.linaro.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 5 ++---
1 file
Vetter
Cc: Eric Anholt
Cc: dri-de...@lists.freedesktop.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/panel/panel-raspberrypi-touchscreen.c
b/drivers/gpu/drm/panel/panel
: warning: expecting prototype for A
buffer object shrink method that tries to swap out the first(). Prototype was
for ttm_global_swapout() instead
Cc: Christian Koenig
Cc: Huang Rui
Cc: David Airlie
Cc: Daniel Vetter
Cc: dri-de...@lists.freedesktop.org
Signed-off-by: Lee Jones
---
drivers
Vetter
Cc: amd-...@lists.freedesktop.org
Cc: dri-de...@lists.freedesktop.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/radeon/radeon_device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/radeon/radeon_device.c
b/drivers/gpu/drm/radeon/radeon_devi
: "Christian König"
Cc: dri-de...@lists.freedesktop.org
Cc: linux-me...@vger.kernel.org
Cc: linaro-mm-...@lists.linaro.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/scheduler/sched_entity.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm
'
Cc: Christian Koenig
Cc: Huang Rui
Cc: David Airlie
Cc: Daniel Vetter
Cc: dri-de...@lists.freedesktop.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/ttm/ttm_tt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm/ttm/ttm_tt.c
: dri-de...@lists.freedesktop.org
Cc: linux-me...@vger.kernel.org
Cc: linaro-mm-...@lists.linaro.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/ttm/ttm_bo.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/gpu/drm/ttm/ttm_bo.c
index
Zabel
Cc: dri-de...@lists.freedesktop.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/xlnx/zynqmp_dp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_dp.c b/drivers/gpu/drm/xlnx/zynqmp_dp.c
index
-de...@lists.freedesktop.org
Cc: linux-arm-ker...@lists.infradead.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/xlnx/zynqmp_disp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/xlnx/zynqmp_disp.c
b/drivers/gpu/drm/xlnx/zynqmp_disp.c
index 109d627968ac0
König"
Cc: Rob Clark
Cc: dri-de...@lists.freedesktop.org
Cc: linux-me...@vger.kernel.org
Cc: linaro-mm-...@lists.linaro.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/omapdrm/omap_gem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/omapdrm/omap_gem.c
was for omap_irq_disable_vblank() instead
Cc: Tomi Valkeinen
Cc: David Airlie
Cc: Daniel Vetter
Cc: Rob Clark
Cc: dri-de...@lists.freedesktop.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/omapdrm/omap_irq.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu
in 'nouveau_compat_ioctl'
drivers/gpu/drm/nouveau/nouveau_ioc32.c:52: warning: Function parameter or
member 'arg' not described in 'nouveau_compat_ioctl'
Cc: Ben Skeggs
Cc: David Airlie
Cc: Daniel Vetter
Cc: dri-de...@lists.freedesktop.org
Cc: nouv...@lists.freedesktop.org
Signed-off-by: Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/gpu/host1x/bus.c:774: warning: Excess function parameter 'key'
description in '__host1x_client_register'
Cc: Thierry Reding
Cc: dri-de...@lists.freedesktop.org
Cc: linux-te...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/gpu
: dri-de...@lists.freedesktop.org
Cc: nouv...@lists.freedesktop.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/nouveau/nouveau_svm.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_svm.c
b/drivers/gpu/drm/nouveau/nouveau_svm.c
index
...@lists.freedesktop.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c
b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index 351f954989530..4905ed584ff48 100644
--- a/drivers/gpu/drm/nouveau/dispnv50
...@lists.freedesktop.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/nouveau/nv50_display.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nv50_display.h
b/drivers/gpu/drm/nouveau/nv50_display.h
index fbd3b15583bc8..2421401d12636 100644
--- a/drivers/gpu/drm/nouveau
Fixes the following W=1 kernel build warning(s):
drivers/gpu/drm/nouveau/nouveau_ioc32.c:2: warning: Cannot understand * file
mga_ioc32.c
Cc: Ben Skeggs
Cc: David Airlie
Cc: Daniel Vetter
Cc: dri-de...@lists.freedesktop.org
Cc: nouv...@lists.freedesktop.org
Signed-off-by: Lee Jones
Cc: dri-de...@lists.freedesktop.org
Cc: nouv...@lists.freedesktop.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c
b/drivers/gpu/drm/nouveau/dispnv50/disp.c
...@lists.freedesktop.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/nouveau/dispnv04/crtc.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv04/crtc.c
b/drivers/gpu/drm/nouveau/dispnv04/crtc.c
index f9e962fd94d0d..f9a276ea5a9e0 100644
--- a/drivers/gpu
...@lists.freedesktop.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/nouveau/dispnv50/headc57d.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv50/headc57d.c
b/drivers/gpu/drm/nouveau/dispnv50/headc57d.c
index fd51527b56b83..bdcfd240d61c8 100644
g
Cc: nouv...@lists.freedesktop.org
Cc: linux-me...@vger.kernel.org
Cc: linaro-mm-...@lists.linaro.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/nouveau/nouveau_bo.c | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_bo.c
b/drivers/gpu/drm/nouveau/nouveau_
: Daniel Vetter
Cc: dri-de...@lists.freedesktop.org
Cc: nouv...@lists.freedesktop.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/nouveau/nouveau_display.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_display.c
b/drivers/gpu/drm/nouveau
ter
Cc: Rob Clark
Cc: dri-de...@lists.freedesktop.org
Signed-off-by: Lee Jones
---
include/drm/drm_atomic.h | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h
index ac5a28eff2c86..259e6970dc836 100644
--- a/include/
...@lists.freedesktop.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
b/drivers/gpu/drm/nouveau/nvkm/engine/gr/gf100.c
index 397ff4fe9df89..69e6008f99196 100644
Cc: Daniel Vetter
Cc: Kuogee Hsieh
Cc: linux-arm-...@vger.kernel.org
Cc: dri-de...@lists.freedesktop.org
Cc: freedr...@lists.freedesktop.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/msm/dp/dp_display.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
' not described in 'gk20a_volt_get_cvb_t_voltage'
Cc: Ben Skeggs
Cc: David Airlie
Cc: Daniel Vetter
Cc: dri-de...@lists.freedesktop.org
Cc: nouv...@lists.freedesktop.org
Signed-off-by: Lee Jones
---
drivers/gpu/drm/nouveau/nvkm/subdev/volt/gk20a.c | 4 ++--
1 file changed, 2 insertions(+), 2
of these!)
Cc: Ben Skeggs
Cc: David Airlie
Cc: Daniel Vetter
Cc: dri-de...@lists.freedesktop.org
Cc: nouv...@lists.freedesktop.org
Signed-off-by: Lee Jones
---
.../gpu/drm/nouveau/nvkm/subdev/bios/init.c | 204 ++
1 file changed, 68 insertions(+), 136 deletions(-)
diff --git
This set is part of a larger effort attempting to clean-up W=1
kernel builds, which are currently overwhelmingly riddled with
niggly little warnings.
Lee Jones (40):
drm/nouveau/nvkm/subdev/bios/init: Demote obvious abuse of kernel-doc
drm/nouveau/dispnv50/disp: Remove unused variable 'ret
Signed-off-by: Lee Jones
---
drivers/gpu/drm/nouveau/dispnv50/disp.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/nouveau/dispnv50/disp.c
b/drivers/gpu/drm/nouveau/dispnv50/disp.c
index 1c9c0cdf85dbc..4801aafd9552b 100644
--- a/drivers/gpu/drm/nouveau/dispnv50
On Thu, 15 Apr 2021, Ian Abbott wrote:
> On 14/04/2021 19:11, Lee Jones wrote:
> > ... and mark it as __maybe_unused since not all users of the
> > header file reference it.
> >
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/stagin
On Thu, 15 Apr 2021, Fabio Aiuto wrote:
> On Wed, Apr 14, 2021 at 07:11:29PM +0100, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/staging/rtl8723bs/hal/sdio_halinit.c: In function
> > ‘CardDisableRTL8723BSdio’:
> &g
On Thu, 15 Apr 2021, Ian Abbott wrote:
> On 14/04/2021 19:11, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > drivers/staging/comedi/drivers/jr3_pci.c: In function
> > ‘jr3_pci_poll_subdevice’:
> > drivers/staging/comedi/
'll see if I can make the subject line a little more clear.
> On Wed, Apr 14, 2021 at 07:11:27PM +0100, Lee Jones wrote:
> > ... and mark it as __maybe_unused since not all users of the
> > header file reference it.
> >
> > Fixes the following W=1 kernel build warni
On Thu, 15 Apr 2021, Dan Carpenter wrote:
> I screwed up my last email and dropped Lee and Arnd from the To: headers.
> Resending.
>
> On Thu, Apr 15, 2021 at 08:20:16AM +0300, Dan Carpenter wrote:
> > On Wed, Apr 14, 2021 at 07:11:09PM +0100, Lee Jones wrote:
> > >
On Thu, 15 Apr 2021, Fabio Aiuto wrote:
> On Wed, Apr 14, 2021 at 07:10:47PM +0100, Lee Jones wrote:
> > Fixes the following W=1 kernel build warning(s):
> >
> > from drivers/staging/rtl8188eu/core/rtw_security.c:10:
> > drivers/staging/rtl8188eu/core/rtw_securi
On Wed, 14 Apr 2021, Andy Shevchenko wrote:
> On Wed, Apr 14, 2021 at 06:13:19PM +0100, Lee Jones wrote:
> > On Fri, 26 Mar 2021, Lee Jones wrote:
> >
> > > On Fri, 26 Mar 2021, Andy Shevchenko wrote:
> > >
> > > > As Linus rightfully not
' description in 'comedi_isadma_alloc'
Cc: Ian Abbott
Cc: H Hartley Sweeten
Cc: Greg Kroah-Hartman
Cc: linux-stag...@lists.linux.dev
Signed-off-by: Lee Jones
---
drivers/staging/comedi/drivers/comedi_isadma.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/comedi
Hartley Sweeten
Cc: Greg Kroah-Hartman
Cc: Thierry Reding
Cc: "Uwe Kleine-König"
Cc: Lee Jones
Cc: "David A. Schleef"
Cc: Mori Hess
Cc: Truxton Fulton
Cc: linux-stag...@lists.linux.dev
Cc: linux-...@vger.kernel.org
Signed-off-by: Lee Jones
---
drivers/staging/comedi/dri
Signed-off-by: Lee Jones
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
index f6d734dd1a24f..60d3d6d1ba678 100644
--- a/drivers
Cc: Stanley@BB.SD3
Cc: linux-stag...@lists.linux.dev
Signed-off-by: Lee Jones
---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 8 +---
1 file changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
b/drivers/staging/rtl8723bs/hal
: linux-stag...@lists.linux.dev
Signed-off-by: Lee Jones
---
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c | 7 ++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
b/drivers/staging/rtl8723bs/core/rtw_mlme_ext.c
index f708e7b9f8fc8
-Hartman
Cc: Marco Cesati
Cc: linux-stag...@lists.linux.dev
Signed-off-by: Lee Jones
---
drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c
b/drivers/staging/rtl8723bs/hal
in 'ni_find_route_source'
Cc: Ian Abbott
Cc: H Hartley Sweeten
Cc: Greg Kroah-Hartman
Cc: "Alexander A. Klimov"
Cc: "Spencer E. Olson"
Cc: linux-stag...@lists.linux.dev
Signed-off-by: Lee Jones
---
drivers/staging/comedi/drivers/ni_routes.c | 6 +++---
1 file changed, 3 insert
Fixes the following W=1 kernel build warning(s):
drivers/staging/axis-fifo/axis-fifo.c:356: warning: expecting prototype for
axis_fifo_write(). Prototype was for axis_fifo_read() instead
Cc: Greg Kroah-Hartman
Cc: Jacob Feder
Cc: linux-stag...@lists.linux.dev
Signed-off-by: Lee Jones
Sweeten
Cc: Greg Kroah-Hartman
Cc: "Alexander A. Klimov"
Cc: Anders Blomdell
Cc: linux-stag...@lists.linux.dev
Signed-off-by: Lee Jones
---
drivers/staging/comedi/drivers/jr3_pci.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/comedi/drivers/jr
Sweeten
Cc: Greg Kroah-Hartman
Cc: Mori Hess
Cc: "J.P. Mellor"
Cc: herman.bruynin...@mech.kuleuven.ac.be
Cc: wim.meeus...@mech.kuleuven.ac.be
Cc: klaas.gade...@mech.kuleuven.ac.be
Cc: Comedi
Cc: linux-stag...@lists.linux.dev
Signed-off-by: Lee Jones
---
drivers/staging/comedi/driver
: linux-stag...@lists.linux.dev
Signed-off-by: Lee Jones
---
drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
b/drivers/staging/rtl8723bs/os_dep/ioctl_cfg80211.c
index
-but-set-variable]
drivers/staging/rtl8723bs/hal/sdio_ops.c: In function ‘sdio_read_mem’:
drivers/staging/rtl8723bs/hal/sdio_ops.c:381:6: warning: variable ‘err’ set
but not used [-Wunused-but-set-variable]
Cc: Greg Kroah-Hartman
Cc: Fabio Aiuto
Cc: linux-stag...@lists.linux.dev
Signed-off-by: Lee
...@lists.linux.dev
Signed-off-by: Lee Jones
---
drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
b/drivers/staging/rtl8723bs/hal/rtl8723b_phycfg.c
index f43abf9b0d225
-Hartman
Cc: Marco Cesati
Cc: linux-stag...@lists.linux.dev
Signed-off-by: Lee Jones
---
drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c | 8 +---
1 file changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/odm_NoiseMonitor.c
b/drivers/staging/rtl8723bs/hal
'bytes_per_frame' not described in 'dim_norm_sync_buffer_size'
drivers/staging/most/dim2/hal.c:802: warning: expecting prototype for
Retrieves maximal possible correct buffer size for synchronous data type().
Prototype was for dim_norm_sync_buffer_size() instead
Cc: Greg Kroah-Hartman
Cc: Lee Jones
Cc
: Marco Cesati
Cc: Fabio Aiuto
Cc: Stanley@BB.SD3
Cc: linux-stag...@lists.linux.dev
Signed-off-by: Lee Jones
---
drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c | 13 ++---
1 file changed, 2 insertions(+), 11 deletions(-)
diff --git a/drivers/staging/rtl8723bs/hal/rtl8723b_hal_init.c
Aiuto
Cc: Stanley@BB.SD3
Cc: linux-stag...@lists.linux.dev
Signed-off-by: Lee Jones
---
drivers/staging/rtl8723bs/hal/sdio_halinit.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/hal/sdio_halinit.c
b/drivers/staging/rtl8723bs/hal/sdio_halinit.c
Signed-off-by: Lee Jones
---
drivers/staging/rtl8188eu/os_dep/rtw_android.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8188eu/os_dep/rtw_android.c
b/drivers/staging/rtl8188eu/os_dep/rtw_android.c
index f5763a9d70c58..91c51b5583d27 100644
--- a/drivers
:
‘iw_operation_mode’ defined but not used [-Wunused-const-variable=]
Cc: Larry Finger
Cc: Greg Kroah-Hartman
Cc: linux-stag...@lists.linux.dev
Signed-off-by: Lee Jones
---
drivers/staging/rtl8188eu/os_dep/ioctl_linux.c | 12 +++-
1 file changed, 11 insertions(+), 1 deletion(-)
diff --git
Cc: "John B. Wyatt IV"
Cc: Jacob Feder
Cc: linux-stag...@lists.linux.dev
Signed-off-by: Lee Jones
---
drivers/staging/axis-fifo/axis-fifo.c | 16
1 file changed, 8 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/axis-fifo/axis-fifo.c
b/drivers/staging
: linux-fb...@vger.kernel.org
Cc: linux-stag...@lists.linux.dev
Signed-off-by: Lee Jones
---
drivers/staging/fbtft/fb_ili9320.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/fbtft/fb_ili9320.c
b/drivers/staging/fbtft/fb_ili9320.c
index f2e72d14431db
or
member 'frame' not described in 'rtl88eu_mon_xmit_hook'
drivers/staging/rtl8188eu/os_dep/mon.c:108: warning: Function parameter or
member 'frag_len' not described in 'rtl88eu_mon_xmit_hook'
Cc: Larry Finger
Cc: Greg Kroah-Hartman
Cc: linux-stag...@lists.linux.dev
Signed-off-by: Lee Jones
Fixes the following W=1 kernel build warning(s):
drivers/staging/rtl8723bs/core/rtw_ieee80211.c:889: warning: expecting
prototype for ieee802_11_parse_elems(). Prototype was for
rtw_ieee802_11_parse_elems() instead
Cc: Greg Kroah-Hartman
Cc: linux-stag...@lists.linux.dev
Signed-off-by: Lee
-stag...@lists.linux.dev
Signed-off-by: Lee Jones
---
drivers/staging/most/i2c/i2c.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/most/i2c/i2c.c b/drivers/staging/most/i2c/i2c.c
index 893a8babdb2f7..7042f10887bb6 100644
--- a/drivers/staging/most
Shvetsov
Cc: linux-stag...@lists.linux.dev
Signed-off-by: Lee Jones
---
drivers/staging/most/dim2/hal.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/most/dim2/hal.c b/drivers/staging/most/dim2/hal.c
index 39e17a7d2f24b..30112413f20a0 100644
--- a/drivers
/rtw_mlme_ext.c: In function ‘issue_probersp’:
drivers/staging/rtl8723bs/core/rtw_mlme_ext.c:2543:1: warning: the frame size
of 1096 bytes is larger than 1024 bytes [-Wframe-larger-than=]
Cc: Greg Kroah-Hartman
Cc: linux-stag...@lists.linux.dev
Signed-off-by: Lee Jones
---
drivers/staging/rtl8723bs/core
Aiuto
Cc: linux-stag...@lists.linux.dev
Signed-off-by: Lee Jones
---
drivers/staging/rtl8723bs/core/rtw_mlme.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_mlme.c
b/drivers/staging/rtl8723bs/core/rtw_mlme.c
index c624887aeed0c
"
Cc: Andrey Shvetsov
Cc: linux-stag...@lists.linux.dev
Signed-off-by: Lee Jones
---
drivers/staging/most/dim2/dim2.c | 23 +--
1 file changed, 13 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/most/dim2/dim2.c b/drivers/staging/most/dim2/dim2.c
index b34
1 - 100 of 24011 matches
Mail list logo
