Re: [PATCH] drivers :staging: android: make alignment match open parenthesis

2015-10-13 Thread Liao Tonglang
On Tue, Oct 13, 2015 at 11:40:00AM +0800, Greg KH wrote: - ashmem_area_cachep = kmem_cache_create("ashmem_area_cache", - sizeof(struct ashmem_area), - 0, 0, NULL); + ashmem_area_cachep = +

Re: [PATCH] drivers :staging: android: make alignment match open parenthesis

2015-10-13 Thread Liao Tonglang
On Tue, Oct 13, 2015 at 11:40:00AM +0800, Greg KH wrote: - ashmem_area_cachep = kmem_cache_create("ashmem_area_cache", - sizeof(struct ashmem_area), - 0, 0, NULL); + ashmem_area_cachep = +

[PATCH] drivers :staging: android: make alignment match open parenthesis

2015-10-12 Thread Liao Tonglang
Cleanup for checkpatch.pl warn below: CHECK: Alignment should match open parenthesis #836: FILE: drivers/staging/android/ashmem.c:836: by split three lines to four. Signed-off-by: Liao Tonglang --- drivers/staging/android/ashmem.c | 7 --- 1 file changed, 4 insertions(+), 3

Re: [PATCH] mm: cleanup balance_dirty_pages() that leave variables uninitialized

2015-10-12 Thread Liao Tonglang
On 2015/10/12 20:58, Jan Kara wrote: What gcc version are you using? It is the last line of my gcc -v command. gcc version 4.8.3 20140911 (Red Hat 4.8.3-9) (GCC) And it warn like this: mm/page-writeback.c: In function ‘balance_dirty_pages.isra.26’: mm/page-writeback.c:1537:26: warning:

[PATCH] mm: cleanup balance_dirty_pages() that leave variables uninitialized

2015-10-12 Thread Liao Tonglang
Variables m_thresh and m_dirty in function balance_dirty_pages() may use uninitialized. GCC throws a warning on it. Fixed by assigned to 0 as initial value. Signed-off-by: Liao Tonglang --- mm/page-writeback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/page

[PATCH] mm: cleanup balance_dirty_pages() that leave variables uninitialized

2015-10-12 Thread Liao Tonglang
Variables m_thresh and m_dirty in function balance_dirty_pages() may use uninitialized. GCC throws a warning on it. Fixed by assigned to 0 as initial value. Signed-off-by: Liao Tonglang <liaotongl...@gmail.com> --- mm/page-writeback.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

Re: [PATCH] mm: cleanup balance_dirty_pages() that leave variables uninitialized

2015-10-12 Thread Liao Tonglang
On 2015/10/12 20:58, Jan Kara wrote: What gcc version are you using? It is the last line of my gcc -v command. gcc version 4.8.3 20140911 (Red Hat 4.8.3-9) (GCC) And it warn like this: mm/page-writeback.c: In function ‘balance_dirty_pages.isra.26’: mm/page-writeback.c:1537:26: warning:

[PATCH] drivers :staging: android: make alignment match open parenthesis

2015-10-12 Thread Liao Tonglang
Cleanup for checkpatch.pl warn below: CHECK: Alignment should match open parenthesis #836: FILE: drivers/staging/android/ashmem.c:836: by split three lines to four. Signed-off-by: Liao Tonglang <liaotongl...@gmail.com> --- drivers/staging/android/ashmem.c | 7 ---