Re: [Linux-stm32] [PATCH] ARM: dts: stm32: enable STM32MP1 crypto/CRC accelerators unconditionally

2021-01-19 Thread Lionel DEBIEVE
Hi Ahmad, These IPs could be enabled in the secure side. To avoid any concurrency access, I prefer to keep all that crypto IPs status disable. For examples, RNG can be managed in OP-TEE, so it will remain disable in Linux. BR, Lionel On 1/19/21 10:52 AM, Ahmad Fatoum wrote: There is no

[PATCH 3/3] ARM: dts: stm32: enable CRYP by default on stm32mp15

2020-11-05 Thread Lionel Debieve
Enable CRYP1 device for cryp accelerated support on stm32mp157C-EV1/DK2 STMicroelectronics platforms. Signed-off-by: Nicolas Toromanoff Signed-off-by: Lionel Debieve --- arch/arm/boot/dts/stm32mp157c-dk2.dts | 4 arch/arm/boot/dts/stm32mp157c-ed1.dts | 4 2 files changed, 8

[PATCH 2/3] ARM: dts: stm32: enable CRC1 by default on stm32mp15

2020-11-05 Thread Lionel Debieve
From: Nicolas Toromanoff Enable CRC1 device for CRC-32 accelerated support on stm32mp15 STMicroelectronics platforms. Signed-off-by: Nicolas Toromanoff Signed-off-by: Lionel Debieve --- arch/arm/boot/dts/stm32mp157c-ed1.dts | 4 arch/arm/boot/dts/stm32mp15xx-dkx.dtsi | 4 2 files

[PATCH 0/3] ARM: dts: stm32: enable crypto controllers

2020-11-05 Thread Lionel Debieve
Enable the crypto controllers in the STM32MP157C-EV1 and STM32MP157A-DK1 STM32MP157C-DK2 boards. Lionel Debieve (2): ARM: dts: stm32: enable HASH by default on stm32mp15 ARM: dts: stm32: enable CRYP by default on stm32mp15 Nicolas Toromanoff (1): ARM: dts: stm32: enable CRC1 by default

[PATCH 1/3] ARM: dts: stm32: enable HASH by default on stm32mp15

2020-11-05 Thread Lionel Debieve
Enable HASH1 device for HASH accelerated support on stm32mp15 STMicroelectronics platforms. Signed-off-by: Lionel Debieve --- arch/arm/boot/dts/stm32mp157c-ed1.dts | 4 arch/arm/boot/dts/stm32mp15xx-dkx.dtsi | 4 2 files changed, 8 insertions(+) diff --git a/arch/arm/boot/dts

[PATCH 1/1] ARM: multi_v7_defconfig: add STM32 crypto support

2020-11-05 Thread Lionel Debieve
Enable crypto controllers enabling following flags as module: CONFIG_CRYPTO_DEV_STM32_CRC CONFIG_CRYPTO_DEV_STM32_HASH CONFIG_CRYPTO_DEV_STM32_CRYP Signed-off-by: Lionel Debieve --- arch/arm/configs/multi_v7_defconfig | 3 +++ 1 file changed, 3 insertions(+) diff --git a/arch/arm/configs

[PATCH 1/1] ARM: dts: stm32: Add HASH support on stm32mp157c

2018-05-14 Thread Lionel Debieve
This patch add HASH instance of the stm32mp157c SoC Signed-off-by: Lionel Debieve <lionel.debi...@st.com> --- arch/arm/boot/dts/stm32mp157c.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi

[PATCH 1/1] ARM: dts: stm32: Add HASH support on stm32mp157c

2018-05-14 Thread Lionel Debieve
This patch add HASH instance of the stm32mp157c SoC Signed-off-by: Lionel Debieve --- arch/arm/boot/dts/stm32mp157c.dtsi | 12 1 file changed, 12 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi index b66f673b5038..cb39fb6d9960

[PATCH 0/4] ARM: dts: Add cryptographic support for stm32mp157c

2018-04-23 Thread Lionel Debieve
Patches serie add support or RNG, CRYP and CRC IPs for stm32mp157c SoC and add RNG default support for ev1 board. Lionel Debieve (4): ARM: dts: stm32: Add RNG support on stm32mp157c ARM: dts: stm32: Enable RNG for stm32mp157c-ed1 ARM: dts: stm32: Add CRYP support on stm32mp157c ARM: dts

[PATCH 0/4] ARM: dts: Add cryptographic support for stm32mp157c

2018-04-23 Thread Lionel Debieve
Patches serie add support or RNG, CRYP and CRC IPs for stm32mp157c SoC and add RNG default support for ev1 board. Lionel Debieve (4): ARM: dts: stm32: Add RNG support on stm32mp157c ARM: dts: stm32: Enable RNG for stm32mp157c-ed1 ARM: dts: stm32: Add CRYP support on stm32mp157c ARM: dts

[PATCH 4/4] ARM: dts: stm32: Add CRC support on stm32mp157c

2018-04-23 Thread Lionel Debieve
This patch add CRC instance of the stm32mp157c SoC Signed-off-by: Lionel Debieve <lionel.debi...@st.com> --- arch/arm/boot/dts/stm32mp157c.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi index 5ce7d2

[PATCH 4/4] ARM: dts: stm32: Add CRC support on stm32mp157c

2018-04-23 Thread Lionel Debieve
This patch add CRC instance of the stm32mp157c SoC Signed-off-by: Lionel Debieve --- arch/arm/boot/dts/stm32mp157c.dtsi | 7 +++ 1 file changed, 7 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi index 5ce7d28f8a1f..2962decacd87 100644

[PATCH 1/4] ARM: dts: stm32: Add RNG support on stm32mp157c

2018-04-23 Thread Lionel Debieve
This patch add RNG instance of the stm32mp157c SoC Signed-off-by: Lionel Debieve <lionel.debi...@st.com> --- arch/arm/boot/dts/stm32mp157c.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi index bc3edd

[PATCH 3/4] ARM: dts: stm32: Add CRYP support on stm32mp157c

2018-04-23 Thread Lionel Debieve
This patch add CRYP instance of the stm32mp157c SoC Signed-off-by: Lionel Debieve <lionel.debi...@st.com> --- arch/arm/boot/dts/stm32mp157c.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi

[PATCH 1/4] ARM: dts: stm32: Add RNG support on stm32mp157c

2018-04-23 Thread Lionel Debieve
This patch add RNG instance of the stm32mp157c SoC Signed-off-by: Lionel Debieve --- arch/arm/boot/dts/stm32mp157c.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi index bc3eddc3eda6..bf00885971b3 100644

[PATCH 3/4] ARM: dts: stm32: Add CRYP support on stm32mp157c

2018-04-23 Thread Lionel Debieve
This patch add CRYP instance of the stm32mp157c SoC Signed-off-by: Lionel Debieve --- arch/arm/boot/dts/stm32mp157c.dtsi | 9 + 1 file changed, 9 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c.dtsi b/arch/arm/boot/dts/stm32mp157c.dtsi index bf00885971b3..5ce7d28f8a1f 100644

[PATCH 2/4] ARM: dts: stm32: Enable RNG for stm32mp157c-ed1

2018-04-23 Thread Lionel Debieve
Enable stm32-hwrng for ed1 and ev1 boards Signed-off-by: Lionel Debieve <lionel.debi...@st.com> --- arch/arm/boot/dts/stm32mp157c-ed1.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c-ed1.dts b/arch/arm/boot/dts/stm32mp157c-ed1.dts index 9f9033

[PATCH 2/4] ARM: dts: stm32: Enable RNG for stm32mp157c-ed1

2018-04-23 Thread Lionel Debieve
Enable stm32-hwrng for ed1 and ev1 boards Signed-off-by: Lionel Debieve --- arch/arm/boot/dts/stm32mp157c-ed1.dts | 4 1 file changed, 4 insertions(+) diff --git a/arch/arm/boot/dts/stm32mp157c-ed1.dts b/arch/arm/boot/dts/stm32mp157c-ed1.dts index 9f90337a22e3..2a992525919c 100644

[PATCH 0/2] Fix stm32-rng for default state and suspend

2018-04-23 Thread Lionel Debieve
This series are fixing the default build state for stm32-rng that activate the driver with arm multi_v7_defconfig. Second patch is fixing the power suspend/resume behavior which was not working. Lionel Debieve (2): hwrng: stm32 - define default state for rng driver hwrng: stm32-rng: Fix

[PATCH 0/2] Fix stm32-rng for default state and suspend

2018-04-23 Thread Lionel Debieve
This series are fixing the default build state for stm32-rng that activate the driver with arm multi_v7_defconfig. Second patch is fixing the power suspend/resume behavior which was not working. Lionel Debieve (2): hwrng: stm32 - define default state for rng driver hwrng: stm32-rng: Fix

[PATCH 1/2] hwrng: stm32 - define default state for rng driver

2018-04-23 Thread Lionel Debieve
Define default state for stm32_rng driver. It will be default selected with multi_v7_defconfig Signed-off-by: Lionel Debieve <lionel.debi...@st.com> --- drivers/char/hw_random/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_

[PATCH 1/2] hwrng: stm32 - define default state for rng driver

2018-04-23 Thread Lionel Debieve
Define default state for stm32_rng driver. It will be default selected with multi_v7_defconfig Signed-off-by: Lionel Debieve --- drivers/char/hw_random/Kconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/char/hw_random/Kconfig b/drivers/char/hw_random/Kconfig index d53541e96bee

[PATCH 2/2] hwrng: stm32-rng - fix pm_suspend issue

2018-04-23 Thread Lionel Debieve
When suspend is called after pm_runtime_suspend, same callback is used and access to rng register is freezing system. By calling the pm_runtime_force_suspend, it first checks that runtime has been already done. Signed-off-by: Lionel Debieve <lionel.debi...@st.com> --- drivers/char/hw_

[PATCH 2/2] hwrng: stm32-rng - fix pm_suspend issue

2018-04-23 Thread Lionel Debieve
When suspend is called after pm_runtime_suspend, same callback is used and access to rng register is freezing system. By calling the pm_runtime_force_suspend, it first checks that runtime has been already done. Signed-off-by: Lionel Debieve --- drivers/char/hw_random/stm32-rng.c | 9

[PATCH Resend 5/5] hwrng: stm32 - rework read timeout calculation

2018-02-15 Thread Lionel Debieve
Increase timeout delay to support longer timing linked to rng initialization. Measurement is based on timer instead of instructions per iteration which is not powerful on all targets. Signed-off-by: Lionel Debieve <lionel.debi...@st.com> --- drivers/char/hw_random/stm32-rng.

[PATCH Resend 5/5] hwrng: stm32 - rework read timeout calculation

2018-02-15 Thread Lionel Debieve
Increase timeout delay to support longer timing linked to rng initialization. Measurement is based on timer instead of instructions per iteration which is not powerful on all targets. Signed-off-by: Lionel Debieve --- drivers/char/hw_random/stm32-rng.c | 25 ++--- 1 file

[PATCH Resend 0/5] hwrng: stm32 - Improvement for stm32-rng

2018-02-15 Thread Lionel Debieve
on specific target. Patch #5 rework the timeout calculation for read value that was previously defined based on loop operation and is now based on timer. Lionel Debieve (5): hwrng: stm32 - add reset during probe dt-bindings: rng: add reset node for stm32 hwrng: stm32 - allow disable clock

[PATCH Resend 0/5] hwrng: stm32 - Improvement for stm32-rng

2018-02-15 Thread Lionel Debieve
on specific target. Patch #5 rework the timeout calculation for read value that was previously defined based on loop operation and is now based on timer. Lionel Debieve (5): hwrng: stm32 - add reset during probe dt-bindings: rng: add reset node for stm32 hwrng: stm32 - allow disable clock

[PATCH Resend 3/5] hwrng: stm32 - allow disable clock error detection

2018-02-15 Thread Lionel Debieve
Add a new property that allow to disable the clock error detection which is required when the clock source selected is out of specification (which is not mandatory). Signed-off-by: Lionel Debieve <lionel.debi...@st.com> --- drivers/char/hw_random/stm32-rng.c | 10 +- 1 file chan

[PATCH Resend 3/5] hwrng: stm32 - allow disable clock error detection

2018-02-15 Thread Lionel Debieve
Add a new property that allow to disable the clock error detection which is required when the clock source selected is out of specification (which is not mandatory). Signed-off-by: Lionel Debieve --- drivers/char/hw_random/stm32-rng.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion

[PATCH Resend 2/5] dt-bindings: rng: add reset node for stm32

2018-02-15 Thread Lionel Debieve
Adding optional resets property for rng. Signed-off-by: Lionel Debieve <lionel.debi...@st.com> --- Documentation/devicetree/bindings/rng/st,stm32-rng.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/rng/st,stm32-rng.txt b/Documentation/devi

[PATCH Resend 2/5] dt-bindings: rng: add reset node for stm32

2018-02-15 Thread Lionel Debieve
Adding optional resets property for rng. Signed-off-by: Lionel Debieve --- Documentation/devicetree/bindings/rng/st,stm32-rng.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/rng/st,stm32-rng.txt b/Documentation/devicetree/bindings/rng/st,stm32

[PATCH Resend 4/5] dt-bindings: rng: add clock detection error for stm32

2018-02-15 Thread Lionel Debieve
Add optional property to enable the clock detection error on rng block. It is used to allow slow clock source which give correct entropy for rng. Signed-off-by: Lionel Debieve <lionel.debi...@st.com> --- Documentation/devicetree/bindings/rng/st,stm32-rng.txt | 1 + 1 file changed, 1 ins

[PATCH Resend 4/5] dt-bindings: rng: add clock detection error for stm32

2018-02-15 Thread Lionel Debieve
Add optional property to enable the clock detection error on rng block. It is used to allow slow clock source which give correct entropy for rng. Signed-off-by: Lionel Debieve --- Documentation/devicetree/bindings/rng/st,stm32-rng.txt | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH Resend 1/5] hwrng: stm32 - add reset during probe

2018-02-15 Thread Lionel Debieve
Avoid issue when probing the RNG without reset if bad status has been detected previously Signed-off-by: Lionel Debieve <lionel.debi...@st.com> --- drivers/char/hw_random/stm32-rng.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/char/hw_random/stm32-rng.c b/driver

[PATCH Resend 1/5] hwrng: stm32 - add reset during probe

2018-02-15 Thread Lionel Debieve
Avoid issue when probing the RNG without reset if bad status has been detected previously Signed-off-by: Lionel Debieve --- drivers/char/hw_random/stm32-rng.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/char/hw_random/stm32-rng.c b/drivers/char/hw_random/stm32-rng.c

[PATCH 3/5] hwrng: stm32 - allow disable clock error detection

2018-01-29 Thread Lionel Debieve
Add a new property that allow to disable the clock error detection which is required when the clock source selected is out of specification (which is not mandatory). Signed-off-by: Lionel Debieve <lionel.debi...@st.com> --- drivers/char/hw_random/stm32-rng.c | 10 +- 1 file chan

[PATCH 3/5] hwrng: stm32 - allow disable clock error detection

2018-01-29 Thread Lionel Debieve
Add a new property that allow to disable the clock error detection which is required when the clock source selected is out of specification (which is not mandatory). Signed-off-by: Lionel Debieve --- drivers/char/hw_random/stm32-rng.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion

[PATCH 4/5] dt-bindings: rng: add clock detection error for stm32

2018-01-29 Thread Lionel Debieve
Add optional property to enable the clock detection error on rng block. It is used to allow slow clock source which give correct entropy for rng. Signed-off-by: Lionel Debieve <lionel.debi...@st.com> --- Documentation/devicetree/bindings/rng/st,stm32-rng.txt | 1 + 1 file changed, 1 ins

[PATCH 4/5] dt-bindings: rng: add clock detection error for stm32

2018-01-29 Thread Lionel Debieve
Add optional property to enable the clock detection error on rng block. It is used to allow slow clock source which give correct entropy for rng. Signed-off-by: Lionel Debieve --- Documentation/devicetree/bindings/rng/st,stm32-rng.txt | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 1/5] hwrng: stm32 - add reset during probe

2018-01-29 Thread Lionel Debieve
Avoid issue when probing the RNG without reset if bad status has been detected previously Signed-off-by: Lionel Debieve <lionel.debi...@st.com> --- drivers/char/hw_random/stm32-rng.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/char/hw_random/stm32-rng.c b/driver

[PATCH 1/5] hwrng: stm32 - add reset during probe

2018-01-29 Thread Lionel Debieve
Avoid issue when probing the RNG without reset if bad status has been detected previously Signed-off-by: Lionel Debieve --- drivers/char/hw_random/stm32-rng.c | 9 + 1 file changed, 9 insertions(+) diff --git a/drivers/char/hw_random/stm32-rng.c b/drivers/char/hw_random/stm32-rng.c

[PATCH 0/5] hwrng: stm32 - Improvement for stm32-rng

2018-01-29 Thread Lionel Debieve
on specific target. Patch #5 rework the timeout calculation for read value that was previously defined based on loop operation and is now based on timer. Lionel Debieve (5): hwrng: stm32 - add reset during probe dt-bindings: rng: add reset node for stm32 hwrng: stm32 - allow disable clock

[PATCH 0/5] hwrng: stm32 - Improvement for stm32-rng

2018-01-29 Thread Lionel Debieve
on specific target. Patch #5 rework the timeout calculation for read value that was previously defined based on loop operation and is now based on timer. Lionel Debieve (5): hwrng: stm32 - add reset during probe dt-bindings: rng: add reset node for stm32 hwrng: stm32 - allow disable clock

[PATCH 2/5] dt-bindings: rng: add reset node for stm32

2018-01-29 Thread Lionel Debieve
Adding optional resets property for rng. Signed-off-by: Lionel Debieve <lionel.debi...@st.com> --- Documentation/devicetree/bindings/rng/st,stm32-rng.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/rng/st,stm32-rng.txt b/Documentation/devi

[PATCH 2/5] dt-bindings: rng: add reset node for stm32

2018-01-29 Thread Lionel Debieve
Adding optional resets property for rng. Signed-off-by: Lionel Debieve --- Documentation/devicetree/bindings/rng/st,stm32-rng.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/Documentation/devicetree/bindings/rng/st,stm32-rng.txt b/Documentation/devicetree/bindings/rng/st,stm32

[PATCH 2/3] crypto: stm32/hash: fix performance issues

2018-01-29 Thread Lionel Debieve
From: Lionel Debieve <lionel.debi...@st.com> Fixing bugs link to stress tests. Bad results are detected during testmgr selftests executing in a faster environment. bufcnt value may be resetted and false IT are sometimes detected. Signed-off-by: Lionel Debieve <lionel.debi...@st.com>

[PATCH 2/3] crypto: stm32/hash: fix performance issues

2018-01-29 Thread Lionel Debieve
From: Lionel Debieve Fixing bugs link to stress tests. Bad results are detected during testmgr selftests executing in a faster environment. bufcnt value may be resetted and false IT are sometimes detected. Signed-off-by: Lionel Debieve --- drivers/crypto/stm32/stm32-hash.c | 8 ++-- 1

[PATCH 1/3] crypto: stm32/hash: avoid error if maxburst not defined

2018-01-29 Thread Lionel Debieve
From: Lionel Debieve <lionel.debi...@st.com> dma-maxburst is an optional value and must not return error in case of dma not used (or max-burst not defined). Signed-off-by: Lionel Debieve <lionel.debi...@st.com> --- drivers/crypto/stm32/stm32-hash.c | 11 ++- 1 file changed,

[PATCH 1/3] crypto: stm32/hash: avoid error if maxburst not defined

2018-01-29 Thread Lionel Debieve
From: Lionel Debieve dma-maxburst is an optional value and must not return error in case of dma not used (or max-burst not defined). Signed-off-by: Lionel Debieve --- drivers/crypto/stm32/stm32-hash.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/drivers

[PATCH 3/3] crypto: stm32/hash: rework padding length

2018-01-29 Thread Lionel Debieve
From: Lionel Debieve <lionel.debi...@st.com> Due to another patch, the dma fails when padding is needed as the given length is not correct. Signed-off-by: Lionel Debieve <lionel.debi...@st.com> --- drivers/crypto/stm32/stm32-hash.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH 3/3] crypto: stm32/hash: rework padding length

2018-01-29 Thread Lionel Debieve
From: Lionel Debieve Due to another patch, the dma fails when padding is needed as the given length is not correct. Signed-off-by: Lionel Debieve --- drivers/crypto/stm32/stm32-hash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/stm32/stm32-hash.c b

[PATCH 0/3] crypto: stm32/hash: Correction to improve robustness

2018-01-29 Thread Lionel Debieve
From: Lionel Debieve <lionel.debi...@st.com> Hi, This patch serie will improve global robustness for stm32-hash driver. Patch #1 is fixing dma-burst issue when configuration is not set. Patch #2 solves issue that occurs when irq append during final req processing. Patch #3 is fixing an

[PATCH 0/3] crypto: stm32/hash: Correction to improve robustness

2018-01-29 Thread Lionel Debieve
From: Lionel Debieve Hi, This patch serie will improve global robustness for stm32-hash driver. Patch #1 is fixing dma-burst issue when configuration is not set. Patch #2 solves issue that occurs when irq append during final req processing. Patch #3 is fixing an issue that have been

[PATCH 1/1] crypto: stm32/hash - Fix return issue in update

2017-11-06 Thread Lionel Debieve
When update data reached the threshold for data processing, we must inform that processing is on going. Signed-off-by: Lionel Debieve <lionel.debi...@st.com> --- drivers/crypto/stm32/stm32-hash.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/crypto

[PATCH 1/1] crypto: stm32/hash - Fix return issue in update

2017-11-06 Thread Lionel Debieve
When update data reached the threshold for data processing, we must inform that processing is on going. Signed-off-by: Lionel Debieve --- drivers/crypto/stm32/stm32-hash.c | 8 +--- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/crypto/stm32/stm32-hash.c b/drivers

Re: [PATCH 1/2] crypto: stm32 - Fix uninitialized data usage

2017-09-18 Thread Lionel DEBIEVE
Hi Arnd, I've already push this fix for review last month, waiting the ack. " From: Lionel Debieve <lionel.debi...@st.com> To: Herbert Xu <herb...@gondor.apana.org.au>, "David S . Miller" <da...@davemloft.net>, Maxime Coquelin <mcoquelin.s

Re: [PATCH 1/2] crypto: stm32 - Fix uninitialized data usage

2017-09-18 Thread Lionel DEBIEVE
Hi Arnd, I've already push this fix for review last month, waiting the ack. " From: Lionel Debieve To: Herbert Xu , "David S . Miller" , Maxime Coquelin , Alexandre Torgue , , , CC: Benjamin Gaignard , Fabien Dessenne , Ludovic Barre Subject: [PA

[PATCH 1/1] crypto: stm32/hash - Remove uninitialized symbol

2017-08-18 Thread Lionel Debieve
Remove err symbol as this is not used in the thread context and the variable is not initialized. Signed-off-by: Lionel Debieve <lionel.debi...@st.com> --- drivers/crypto/stm32/stm32-hash.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/stm32/stm32-

[PATCH 1/1] crypto: stm32/hash - Remove uninitialized symbol

2017-08-18 Thread Lionel Debieve
Remove err symbol as this is not used in the thread context and the variable is not initialized. Signed-off-by: Lionel Debieve --- drivers/crypto/stm32/stm32-hash.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/crypto/stm32/stm32-hash.c b/drivers/crypto/stm32

Re: [PATCH v5] crypto : stm32 - Add STM32F4 CRC32 support

2017-08-16 Thread Lionel DEBIEVE
Hi Cosar, Sorry for the delay to feedback. This implementation is in the good way. But it should be better to use platform data and use array with type of algs instead of duplicating the algo description for each platform. If we add a new platform, with another type of crc, we will again

Re: [PATCH v5] crypto : stm32 - Add STM32F4 CRC32 support

2017-08-16 Thread Lionel DEBIEVE
Hi Cosar, Sorry for the delay to feedback. This implementation is in the good way. But it should be better to use platform data and use array with type of algs instead of duplicating the algo description for each platform. If we add a new platform, with another type of crc, we will again

Re: [RESEND,PATCH v4 3/3] crypto : stm32 - Add STM32F4 CRC32 support

2017-07-17 Thread Lionel DEBIEVE
Hi Cosar, - ret = crypto_register_shashes(algs, ARRAY_SIZE(algs)); + /* For F4 series only CRC32 algorithm will be used */ + if (of_device_is_compatible(crc->dev->of_node, "st,stm32f4-crc")) + algs_size = 1; + else + algs_size =

Re: [RESEND,PATCH v4 3/3] crypto : stm32 - Add STM32F4 CRC32 support

2017-07-17 Thread Lionel DEBIEVE
Hi Cosar, - ret = crypto_register_shashes(algs, ARRAY_SIZE(algs)); + /* For F4 series only CRC32 algorithm will be used */ + if (of_device_is_compatible(crc->dev->of_node, "st,stm32f4-crc")) + algs_size = 1; + else + algs_size =

[PATCH 2/2] crypto: stm32 - Support for STM32 HASH module

2017-07-13 Thread Lionel Debieve
This module register a HASH module that support multiples algorithms: MD5, SHA1, SHA224, SHA256. It includes the support of HMAC hardware processing corresponding to the supported algorithms. DMA or IRQ mode are used depending on data length. Signed-off-by: Lionel Debieve <lionel.debi...@st.

[PATCH 2/2] crypto: stm32 - Support for STM32 HASH module

2017-07-13 Thread Lionel Debieve
This module register a HASH module that support multiples algorithms: MD5, SHA1, SHA224, SHA256. It includes the support of HMAC hardware processing corresponding to the supported algorithms. DMA or IRQ mode are used depending on data length. Signed-off-by: Lionel Debieve --- drivers/crypto

[PATCH 0/2] STM32 HASH crypto driver

2017-07-13 Thread Lionel Debieve
/ testmgr. Note: Since two other set of patches (update of STM32 CRC32 and addition of STM32 CRYP) are being proposed, it may happen that there are some minor conflicts in 'Kconfig' and 'Makefile'. In that case, I will fix the issue in due course. Lionel Debieve (2): dt-bindings: Document STM32

[PATCH 0/2] STM32 HASH crypto driver

2017-07-13 Thread Lionel Debieve
/ testmgr. Note: Since two other set of patches (update of STM32 CRC32 and addition of STM32 CRYP) are being proposed, it may happen that there are some minor conflicts in 'Kconfig' and 'Makefile'. In that case, I will fix the issue in due course. Lionel Debieve (2): dt-bindings: Document STM32

[PATCH 1/2] dt-bindings: Document STM32 HASH bindings

2017-07-13 Thread Lionel Debieve
This adds documentation of device tree bindings for the STM32 HASH controller. Signed-off-by: Lionel Debieve <lionel.debi...@st.com> --- .../devicetree/bindings/crypto/st,stm32-hash.txt | 30 ++ 1 file changed, 30 insertions(+) create mode 100644 Documentation/devi

[PATCH 1/2] dt-bindings: Document STM32 HASH bindings

2017-07-13 Thread Lionel Debieve
This adds documentation of device tree bindings for the STM32 HASH controller. Signed-off-by: Lionel Debieve --- .../devicetree/bindings/crypto/st,stm32-hash.txt | 30 ++ 1 file changed, 30 insertions(+) create mode 100644 Documentation/devicetree/bindings/crypto/st,stm32

[PATCH 3/3] crypto: stm32 - Rename module to use generic crypto

2017-07-13 Thread Lionel Debieve
The complete stm32 module is rename as crypto in order to use generic naming Signed-off-by: Lionel Debieve <lionel.debi...@st.com> Reviewed-by: Fabien Dessenne <fabien.desse...@st.com> --- drivers/crypto/Makefile | 2 +- drivers/crypto/stm32/Kconfig | 6 +++--- drivers/

[PATCH 3/3] crypto: stm32 - Rename module to use generic crypto

2017-07-13 Thread Lionel Debieve
The complete stm32 module is rename as crypto in order to use generic naming Signed-off-by: Lionel Debieve Reviewed-by: Fabien Dessenne --- drivers/crypto/Makefile | 2 +- drivers/crypto/stm32/Kconfig | 6 +++--- drivers/crypto/stm32/Makefile | 3 +-- 3 files changed, 5 insertions(+), 6

[PATCH 1/3] crypto: stm32 - CRC use relaxed function

2017-07-13 Thread Lionel Debieve
In case of arm soc support, readl and writel will be optimized using relaxed functions Signed-off-by: Lionel Debieve <lionel.debi...@st.com> Reviewed-by: Fabien Dessenne <fabien.desse...@st.com> --- drivers/crypto/stm32/stm32_crc32.c | 15 --- 1 file changed, 8 inse

[PATCH 1/3] crypto: stm32 - CRC use relaxed function

2017-07-13 Thread Lionel Debieve
In case of arm soc support, readl and writel will be optimized using relaxed functions Signed-off-by: Lionel Debieve Reviewed-by: Fabien Dessenne --- drivers/crypto/stm32/stm32_crc32.c | 15 --- 1 file changed, 8 insertions(+), 7 deletions(-) diff --git a/drivers/crypto/stm32

[PATCH 0/3] STM32 CRC update

2017-07-13 Thread Lionel Debieve
crypto algos, HASH and CRYP are pushed accordingly. Lionel Debieve (3): crypto: stm32 - CRC use relaxed function crypto: stm32 - solve crc issue during unbind crypto: stm32 - Rename module to use generic crypto drivers/crypto/Makefile| 2 +- drivers/crypto/stm32/Kconfig

[PATCH 2/3] crypto: stm32 - solve crc issue during unbind

2017-07-13 Thread Lionel Debieve
Use the correct unregister_shashes function to to remove the registered algo Signed-off-by: Lionel Debieve <lionel.debi...@st.com> Reviewed-by: Fabien Dessenne <fabien.desse...@st.com> --- drivers/crypto/stm32/stm32_crc32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)

[PATCH 0/3] STM32 CRC update

2017-07-13 Thread Lionel Debieve
crypto algos, HASH and CRYP are pushed accordingly. Lionel Debieve (3): crypto: stm32 - CRC use relaxed function crypto: stm32 - solve crc issue during unbind crypto: stm32 - Rename module to use generic crypto drivers/crypto/Makefile| 2 +- drivers/crypto/stm32/Kconfig

[PATCH 2/3] crypto: stm32 - solve crc issue during unbind

2017-07-13 Thread Lionel Debieve
Use the correct unregister_shashes function to to remove the registered algo Signed-off-by: Lionel Debieve Reviewed-by: Fabien Dessenne --- drivers/crypto/stm32/stm32_crc32.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/crypto/stm32/stm32_crc32.c b/drivers

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-04-04 Thread Lionel DEBIEVE
ior wrote: > >> On 2017-03-22 09:05:58 [-0700], Steven Rostedt wrote: >>> On Wed, 22 Mar 2017 16:18:43 +0100 >>> Lionel Debieve <lionel.debi...@st.com> wrote: >>> >>>> Use raw_spin_lock in enable/disable channel as it comes from >>>> in

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-04-04 Thread Lionel DEBIEVE
ior wrote: > >> On 2017-03-22 09:05:58 [-0700], Steven Rostedt wrote: >>> On Wed, 22 Mar 2017 16:18:43 +0100 >>> Lionel Debieve wrote: >>> >>>> Use raw_spin_lock in enable/disable channel as it comes from >>>> interrupt context. >>>

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-23 Thread Lionel DEBIEVE
On 03/22/2017 07:47 PM, Julia Cartwright wrote: > On Wed, Mar 22, 2017 at 01:30:12PM -0500, Grygorii Strashko wrote: >> On 03/22/2017 01:01 PM, Steven Rostedt wrote: >>> On Wed, 22 Mar 2017 12:37:59 -0500 >>> Julia Cartwright wrote: >>> Which kernel were you testing on, here?

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-23 Thread Lionel DEBIEVE
On 03/22/2017 07:47 PM, Julia Cartwright wrote: > On Wed, Mar 22, 2017 at 01:30:12PM -0500, Grygorii Strashko wrote: >> On 03/22/2017 01:01 PM, Steven Rostedt wrote: >>> On Wed, 22 Mar 2017 12:37:59 -0500 >>> Julia Cartwright wrote: >>> Which kernel were you testing on, here? From what I

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-22 Thread Lionel DEBIEVE
On 03/22/2017 05:05 PM, Steven Rostedt wrote: > On Wed, 22 Mar 2017 16:18:43 +0100 > Lionel Debieve <lionel.debi...@st.com> wrote: > >> Use raw_spin_lock in enable/disable channel as it comes from >> interrupt context. >> >> BUG: sleeping function called fr

Re: [PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-22 Thread Lionel DEBIEVE
On 03/22/2017 05:05 PM, Steven Rostedt wrote: > On Wed, 22 Mar 2017 16:18:43 +0100 > Lionel Debieve wrote: > >> Use raw_spin_lock in enable/disable channel as it comes from >> interrupt context. >> >> BUG: sleeping function called from invalid context a

[PATCH 1/1] tty: serial: st-asc: Make the locking RT aware

2017-03-22 Thread Lionel Debieve
The lock is a sleeping lock and local_irq_save() is not the standard implementation now. Working for both -RT and non RT. Signed-off-by: Lionel Debieve <lionel.debi...@st.com> --- drivers/tty/serial/st-asc.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drive

[PATCH 1/1] tty: serial: st-asc: Make the locking RT aware

2017-03-22 Thread Lionel Debieve
The lock is a sleeping lock and local_irq_save() is not the standard implementation now. Working for both -RT and non RT. Signed-off-by: Lionel Debieve --- drivers/tty/serial/st-asc.c | 8 +++- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/st-asc.c b

RE: [PATCH RT] tty: serial: st-asc: Make the locking RT aware

2017-03-22 Thread Lionel DEBIEVE
OK, resend without. BR Lionel -Original Message- From: Steven Rostedt [mailto:rost...@goodmis.org] Sent: mercredi 22 mars 2017 17:11 To: Lionel DEBIEVE <lionel.debi...@st.com> Cc: Thomas Gleixner <t...@linutronix.de>; linux-rt-us...@vger.kernel.org; linux-kernel@vger.kern

RE: [PATCH RT] tty: serial: st-asc: Make the locking RT aware

2017-03-22 Thread Lionel DEBIEVE
OK, resend without. BR Lionel -Original Message- From: Steven Rostedt [mailto:rost...@goodmis.org] Sent: mercredi 22 mars 2017 17:11 To: Lionel DEBIEVE Cc: Thomas Gleixner ; linux-rt-us...@vger.kernel.org; linux-kernel@vger.kernel.org; bige...@linutronix.de; Patrice CHOTARD ; Greg

[PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-22 Thread Lionel Debieve
) [] (handle_fasteoi_irq) [] (generic_handle_irq) [] (__handle_domain_irq) [] (gic_handle_irq) Signed-off-by: Lionel Debieve <lionel.debi...@st.com> --- drivers/mailbox/mailbox-sti.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/mailbox/mailbox-s

[PATCH RT 1/1] remoteproc: Prevent schedule while atomic

2017-03-22 Thread Lionel Debieve
) [] (handle_fasteoi_irq) [] (generic_handle_irq) [] (__handle_domain_irq) [] (gic_handle_irq) Signed-off-by: Lionel Debieve --- drivers/mailbox/mailbox-sti.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/mailbox/mailbox-sti.c b/drivers/mailbox/mailbox

Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware

2017-03-22 Thread Lionel DEBIEVE
Just to agree with Thomas. Do you want me to resend the patch without RT tag? BR, Lionel On 03/21/2017 09:15 PM, Steven Rostedt wrote: > On Tue, 21 Mar 2017 19:51:47 +0100 (CET) > Thomas Gleixner wrote: > >> On Tue, 21 Mar 2017, Steven Rostedt wrote: /* *

Re: [PATCH RT] tty: serial: st-asc: Make the locking RT aware

2017-03-22 Thread Lionel DEBIEVE
Just to agree with Thomas. Do you want me to resend the patch without RT tag? BR, Lionel On 03/21/2017 09:15 PM, Steven Rostedt wrote: > On Tue, 21 Mar 2017 19:51:47 +0100 (CET) > Thomas Gleixner wrote: > >> On Tue, 21 Mar 2017, Steven Rostedt wrote: /* * Disable interrupts