Re: [PATCH v2 0/7] KASan for arm

On 03/20/2018 2:30 AM, Abbott Liu wrote: >BTW, it looks like you have some section mismatches: > >WARNING: vmlinux.o(.meminit.text+0x40): Section mismatch in reference >from the function kasan_pte_populate() to the function >.init.text:kasan_alloc_block.constprop.5() >The function __meminit

Re: [PATCH v2 0/7] KASan for arm

On 03/20/2018 2:30 AM, Abbott Liu wrote: >BTW, it looks like you have some section mismatches: > >WARNING: vmlinux.o(.meminit.text+0x40): Section mismatch in reference >from the function kasan_pte_populate() to the function >.init.text:kasan_alloc_block.constprop.5() >The function __meminit

Re: [PATCH 3/7] Disable instrumentation for some code

On 19/03/2018 16:38, Marc Zyngier wrote: >You need to extend this at least to arch/arm/kvm/hyp/Makefile, as the >KASAN shadow region won't be mapped in HYP. See commit a6cdf1c08cbfe for >more details (all the arm64 comments in this patch apply to 32bit as well). Thanks for your review. I will

Re: [PATCH 3/7] Disable instrumentation for some code

On 19/03/2018 16:38, Marc Zyngier wrote: >You need to extend this at least to arch/arm/kvm/hyp/Makefile, as the >KASAN shadow region won't be mapped in HYP. See commit a6cdf1c08cbfe for >more details (all the arm64 comments in this patch apply to 32bit as well). Thanks for your review. I will

Re: [PATCH v2 0/7] KASan for arm

On 03/19/2018 09:23 AM, Florian Fainelli wrote: >On 03/18/2018 06:20 PM, Liuwenliang (Abbott Liu) wrote: >> On 03/19/2018 03:14 AM, Florian Fainelli wrote: >>> Thanks for posting these patches! Just FWIW, you cannot quite add >>> someone's Tested-by for a patch serie

Re: [PATCH v2 0/7] KASan for arm

On 03/19/2018 09:23 AM, Florian Fainelli wrote: >On 03/18/2018 06:20 PM, Liuwenliang (Abbott Liu) wrote: >> On 03/19/2018 03:14 AM, Florian Fainelli wrote: >>> Thanks for posting these patches! Just FWIW, you cannot quite add >>> someone's Tested-by for a patch serie

Re: [PATCH v2 0/7] KASan for arm

On 03/19/2018 03:14 AM, Florian Fainelli wrote: >Thanks for posting these patches! Just FWIW, you cannot quite add >someone's Tested-by for a patch series that was just resubmitted given >the differences with v1. I just gave it a spin on a Cortex-A5 (no LPAE) >and it looks like test_kasan.ko is

Re: [PATCH v2 0/7] KASan for arm

On 03/19/2018 03:14 AM, Florian Fainelli wrote: >Thanks for posting these patches! Just FWIW, you cannot quite add >someone's Tested-by for a patch series that was just resubmitted given >the differences with v1. I just gave it a spin on a Cortex-A5 (no LPAE) >and it looks like test_kasan.ko is

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

On Oct 19, 2017 at 19:09, Russell King - ARM Linux [mailto:li...@armlinux.org.uk] wrote: >On Wed, Oct 11, 2017 at 04:22:17PM +0800, Abbott Liu wrote: >> +#else >> +#define pud_populate(mm,pmd,pte)do { } while (0) >> +#endif > >Please explain this change - we don't have a "pud" as far as the

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

On Oct 19, 2017 at 19:09, Russell King - ARM Linux [mailto:li...@armlinux.org.uk] wrote: >On Wed, Oct 11, 2017 at 04:22:17PM +0800, Abbott Liu wrote: >> +#else >> +#define pud_populate(mm,pmd,pte)do { } while (0) >> +#endif > >Please explain this change - we don't have a "pud" as far as the

Re: [PATCH 00/11] KASan for arm

On 2018/2/14 2:41 AM, Florian Fainelli [f.faine...@gmail.com] wrote: >Hi Abbott, > >Are you planning on picking up these patches and sending a second >version? I would be more than happy to provide test results once you >have something, this is very useful, thank you! >-- >Florian I'm sorry to

Re: [PATCH 00/11] KASan for arm

On 2018/2/14 2:41 AM, Florian Fainelli [f.faine...@gmail.com] wrote: >Hi Abbott, > >Are you planning on picking up these patches and sending a second >version? I would be more than happy to provide test results once you >have something, this is very useful, thank you! >-- >Florian I'm sorry to

Re: [PATCH 06/11] change memory_is_poisoned_16 for aligned error

On 6 December 2017 at 1:09 Ard Biesheuvel [ard.biesheu...@linaro.org] wrote: >On 5 December 2017 at 14:19, Liuwenliang (Abbott Liu) ><liuwenli...@huawei.com> wrote: >> On Nov 23, 2017 20:30 Russell King - ARM Linux >> [mailto:li...@armlinux.org.uk] wrote: >>>O

Re: [PATCH 06/11] change memory_is_poisoned_16 for aligned error

On 6 December 2017 at 1:09 Ard Biesheuvel [ard.biesheu...@linaro.org] wrote: >On 5 December 2017 at 14:19, Liuwenliang (Abbott Liu) > wrote: >> On Nov 23, 2017 20:30 Russell King - ARM Linux >> [mailto:li...@armlinux.org.uk] wrote: >>>On Thu, Oct 12, 2017 at 11

Re: [PATCH 06/11] change memory_is_poisoned_16 for aligned error

On Nov 23, 2017 20:30 Russell King - ARM Linux [mailto:li...@armlinux.org.uk] wrote: >On Thu, Oct 12, 2017 at 11:27:40AM +, Liuwenliang (Lamb) wrote: >> >> - I don't understand why this is necessary. memory_is_poisoned_16() >> >> already handles unaligned addresses? >> >> >> >> - If

Re: [PATCH 06/11] change memory_is_poisoned_16 for aligned error

On Nov 23, 2017 20:30 Russell King - ARM Linux [mailto:li...@armlinux.org.uk] wrote: >On Thu, Oct 12, 2017 at 11:27:40AM +, Liuwenliang (Lamb) wrote: >> >> - I don't understand why this is necessary. memory_is_poisoned_16() >> >> already handles unaligned addresses? >> >> >> >> - If

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

On Nov 23, 2017 23:22 Russell King - ARM Linux [mailto:li...@armlinux.org.uk] wrote: >Please pay attention to the project coding style whenever creating code >for a program. It doesn't matter what the project coding style is, as >long as you write your code to match the style that is already

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

On Nov 23, 2017 23:22 Russell King - ARM Linux [mailto:li...@armlinux.org.uk] wrote: >Please pay attention to the project coding style whenever creating code >for a program. It doesn't matter what the project coding style is, as >long as you write your code to match the style that is already

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

_KERNEL) | L_PTE_RDONLY))); memset(kasan_zero_page, 0, PAGE_SIZE); - cpu_set_ttbr0(orig_ttbr0); + set_ttbr0(orig_ttbr0); flush_cache_all(); local_flush_bp_all(); local_flush_tlb_all(); -邮件原件- 发件人: Marc Zyngier [mailto:marc.zyng...@arm.com] 发送时间: 2017年11月22

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

_KERNEL) | L_PTE_RDONLY))); memset(kasan_zero_page, 0, PAGE_SIZE); - cpu_set_ttbr0(orig_ttbr0); + set_ttbr0(orig_ttbr0); flush_cache_all(); local_flush_bp_all(); local_flush_tlb_all(); -邮件原件- 发件人: Marc Zyngier [mailto:marc.zyng...@arm.com] 发送时间: 2017年11月22

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

On Nov 22, 2017 20:30 Mark Rutland [mailto:mark.rutl...@arm.com] wrote: >On Tue, Nov 21, 2017 at 07:59:01AM +0000, Liuwenliang (Abbott Liu) wrote: >> On Nov 17, 2017 21:49 Marc Zyngier [mailto:marc.zyng...@arm.com] wrote: >> >On Sat, 18 Nov 2017 10:40:08 +0000 >> &

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

On Nov 22, 2017 20:30 Mark Rutland [mailto:mark.rutl...@arm.com] wrote: >On Tue, Nov 21, 2017 at 07:59:01AM +0000, Liuwenliang (Abbott Liu) wrote: >> On Nov 17, 2017 21:49 Marc Zyngier [mailto:marc.zyng...@arm.com] wrote: >> >On Sat, 18 Nov 2017 10:40:08 +0000 >> &

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

On Nov 17, 2017 15:36 Christoffer Dall [mailto:cd...@linaro.org] wrote: >If your processor does support LPAE (like a Cortex-A15 for example), >then you have both the 32-bit accessors (MRC and MCR) and the 64-bit >accessors (MRRC, MCRR), and using the 32-bit accessor will simply access >the lower

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

On Nov 17, 2017 15:36 Christoffer Dall [mailto:cd...@linaro.org] wrote: >If your processor does support LPAE (like a Cortex-A15 for example), >then you have both the 32-bit accessors (MRC and MCR) and the 64-bit >accessors (MRRC, MCRR), and using the 32-bit accessor will simply access >the lower

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

On 16/11/17 22:41 Marc Zyngier [mailto:marc.zyng...@arm.com] wrote: >No, it doesn't. It cannot work, because Cortex-A9 predates the invention >of the 64bit accessor. I suspect that you are testing stuff in QEMU, >which is giving you a SW model that always supports LPAE. I suggest you >test this

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

On 16/11/17 22:41 Marc Zyngier [mailto:marc.zyng...@arm.com] wrote: >No, it doesn't. It cannot work, because Cortex-A9 predates the invention >of the 64bit accessor. I suspect that you are testing stuff in QEMU, >which is giving you a SW model that always supports LPAE. I suggest you >test this

答复: [PATCH 01/11] Initialize the mapping of KASan shadow memory

On 16/11/17 22:41 Marc Zyngier [mailto:marc.zyng...@arm.com] wrote: >- If the CPU supports LPAE, then both 32 and 64bit accessors work I don't how 32bit accessor can work on CPU supporting LPAE, give me your solution. Thanks.

答复: [PATCH 01/11] Initialize the mapping of KASan shadow memory

On 16/11/17 22:41 Marc Zyngier [mailto:marc.zyng...@arm.com] wrote: >- If the CPU supports LPAE, then both 32 and 64bit accessors work I don't how 32bit accessor can work on CPU supporting LPAE, give me your solution. Thanks.

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

On 16/11/17 17:54 Marc Zyngier [mailto:marc.zyng...@arm.com] wrote: >On Thu, Nov 16 2017 at 3:07:54 am GMT, "Liuwenliang (Abbott Liu)" ><liuwenli...@huawei.com> wrote: >>>On 15/11/17 13:16, Liuwenliang (Abbott Liu) wrote: >>>> On 09/11/17 18:36 Marc

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

On 16/11/17 17:54 Marc Zyngier [mailto:marc.zyng...@arm.com] wrote: >On Thu, Nov 16 2017 at 3:07:54 am GMT, "Liuwenliang (Abbott Liu)" > wrote: >>>On 15/11/17 13:16, Liuwenliang (Abbott Liu) wrote: >>>> On 09/11/17 18:36 Marc Zyngier [mailto:marc.zyng...

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

>On 15/11/17 13:16, Liuwenliang (Abbott Liu) wrote: >> On 09/11/17 18:36 Marc Zyngier [mailto:marc.zyng...@arm.com] wrote: >>> On Wed, Nov 15 2017 at 10:20:02 am GMT, "Liuwenliang (Abbott Liu)" >>> <liuwenli...@huawei.com> wrote: >>>> diff

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

>On 15/11/17 13:16, Liuwenliang (Abbott Liu) wrote: >> On 09/11/17 18:36 Marc Zyngier [mailto:marc.zyng...@arm.com] wrote: >>> On Wed, Nov 15 2017 at 10:20:02 am GMT, "Liuwenliang (Abbott Liu)" >>> wrote: >>>> diff --git a/arch/arm/include/as

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

On 09/11/17 18:36 Marc Zyngier [mailto:marc.zyng...@arm.com] wrote: >On Wed, Nov 15 2017 at 10:20:02 am GMT, "Liuwenliang (Abbott Liu)" ><liuwenli...@huawei.com> wrote: >> On 09/11/17 18:11, Marc Zyngier [mailto:marc.zyng...@arm.com] wrote: >>>On 09/11/17

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

On 09/11/17 18:36 Marc Zyngier [mailto:marc.zyng...@arm.com] wrote: >On Wed, Nov 15 2017 at 10:20:02 am GMT, "Liuwenliang (Abbott Liu)" > wrote: >> On 09/11/17 18:11, Marc Zyngier [mailto:marc.zyng...@arm.com] wrote: >>>On 09/11/17 07:46, Liuwenliang (Abbott Liu

Re: [PATCH 05/11] Disable kasan's instrumentation

On 19/10/17 20:47, Russell King - ARM Linux [mailto:li...@armlinux.org.uk] wrote: >On Wed, Oct 11, 2017 at 04:22:21PM +0800, Abbott Liu wrote: >> From: Andrey Ryabinin >> >> To avoid some build and runtime errors, compiler's instrumentation must >> be disabled for

Re: [PATCH 05/11] Disable kasan's instrumentation

On 19/10/17 20:47, Russell King - ARM Linux [mailto:li...@armlinux.org.uk] wrote: >On Wed, Oct 11, 2017 at 04:22:21PM +0800, Abbott Liu wrote: >> From: Andrey Ryabinin >> >> To avoid some build and runtime errors, compiler's instrumentation must >> be disabled for code not linked with kernel

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

On 09/11/17 18:11, Marc Zyngier [mailto:marc.zyng...@arm.com] wrote: >On 09/11/17 07:46, Liuwenliang (Abbott Liu) wrote: >> diff --git a/arch/arm/mm/kasan_init.c b/arch/arm/mm/kasan_init.c >> index 049ee0a..359a782 100644 >> --- a/arch/arm/mm/kasan_init.c >> +++

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

On 09/11/17 18:11, Marc Zyngier [mailto:marc.zyng...@arm.com] wrote: >On 09/11/17 07:46, Liuwenliang (Abbott Liu) wrote: >> diff --git a/arch/arm/mm/kasan_init.c b/arch/arm/mm/kasan_init.c >> index 049ee0a..359a782 100644 >> --- a/arch/arm/mm/kasan_init.c >> +++

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

On 12/10/17 15:59, Marc Zyngier [mailto:marc.zyng...@arm.com] wrote: > On 11/10/17 09:22, Abbott Liu wrote: >> diff --git a/arch/arm/include/asm/proc-fns.h >> b/arch/arm/include/asm/proc-fns.h >> index f2e1af4..6e26714 100644 >> --- a/arch/arm/include/asm/proc-fns.h >> +++

Re: [PATCH 01/11] Initialize the mapping of KASan shadow memory

On 12/10/17 15:59, Marc Zyngier [mailto:marc.zyng...@arm.com] wrote: > On 11/10/17 09:22, Abbott Liu wrote: >> diff --git a/arch/arm/include/asm/proc-fns.h >> b/arch/arm/include/asm/proc-fns.h >> index f2e1af4..6e26714 100644 >> --- a/arch/arm/include/asm/proc-fns.h >> +++