[PATCH v5 0/2] add ISO7816 support

2018-09-26 Thread Ludovic Desroches
Hi, This patchset adds support for the ISO7816 standard. The USART devices in Microchip SoCs have an ISO7816 mode. It allows to let the USART managing the CLK and I/O signals of a smart card. Changes: - v5 - rebase on tty-next. - add documentation for the new ioctls (mimic rs485 one). -

[PATCH v5 2/2] tty/serial: atmel: add ISO7816 support

2018-09-26 Thread Ludovic Desroches
, add check on fidi ratio, checkpatch fixes] Signed-off-by: Ludovic Desroches Acked-by: Richard Genoud --- drivers/tty/serial/atmel_serial.c | 190 +++--- drivers/tty/serial/atmel_serial.h | 3 +- 2 files changed, 181 insertions(+), 12 deletions(-) diff --git

[PATCH v5 1/2] tty/serial_core: add ISO7816 infrastructure

2018-09-26 Thread Ludovic Desroches
-off-by: Ludovic Desroches --- Documentation/serial/serial-iso7816.txt | 83 + arch/alpha/include/uapi/asm/ioctls.h| 2 + arch/mips/include/uapi/asm/ioctls.h | 2 + arch/parisc/include/uapi/asm/ioctls.h | 2 + arch/powerpc/include/uapi/asm/ioctls.h | 2

[PATCH v5 0/2] add ISO7816 support

2018-09-26 Thread Ludovic Desroches
Hi, This patchset adds support for the ISO7816 standard. The USART devices in Microchip SoCs have an ISO7816 mode. It allows to let the USART managing the CLK and I/O signals of a smart card. Changes: - v5 - rebase on tty-next. - add documentation for the new ioctls (mimic rs485 one). -

Re: [PATCH v4 2/2] tty/serial: atmel: add ISO7816 support

2018-09-26 Thread Ludovic Desroches
On Tue, Sep 18, 2018 at 03:28:56PM +0200, Greg KH wrote: > On Thu, Sep 06, 2018 at 03:42:14PM +0200, Ludovic Desroches wrote: > > From: Nicolas Ferre > > > > When mode is set in atmel_config_iso7816() we backup last RS232 mode > > for coming back to this mode if requ

Re: [PATCH v4 2/2] tty/serial: atmel: add ISO7816 support

2018-09-26 Thread Ludovic Desroches
On Tue, Sep 18, 2018 at 03:28:56PM +0200, Greg KH wrote: > On Thu, Sep 06, 2018 at 03:42:14PM +0200, Ludovic Desroches wrote: > > From: Nicolas Ferre > > > > When mode is set in atmel_config_iso7816() we backup last RS232 mode > > for coming back to this mode if requ

Re: [GIT PULL] ARM: at91: SoC for 4.20

2018-09-26 Thread Ludovic Desroches
On Tue, Sep 25, 2018 at 01:38:12PM -0700, Olof Johansson wrote: > On Tue, Sep 25, 2018 at 12:37:35PM +0200, Alexandre Belloni wrote: > > Arnd, Olof, > > > > Most changes are shuffling around the maintainers entries. There are > > also two PM non urgent fixes. > > > > This one as a trivial

Re: [GIT PULL] ARM: at91: SoC for 4.20

2018-09-26 Thread Ludovic Desroches
On Tue, Sep 25, 2018 at 01:38:12PM -0700, Olof Johansson wrote: > On Tue, Sep 25, 2018 at 12:37:35PM +0200, Alexandre Belloni wrote: > > Arnd, Olof, > > > > Most changes are shuffling around the maintainers entries. There are > > also two PM non urgent fixes. > > > > This one as a trivial

Re: [PATCH v2 2/2] iio: adc: at91: fix wrong channel number in triggered buffer mode

2018-09-25 Thread Ludovic Desroches
annel. > > Fixes 0e589d5fb "ARM: AT91: IIO: Add AT91 ADC driver." > Cc: Maxime Ripard > Signed-off-by: Eugen Hristev Acked-by: Ludovic Desroches > --- > Changes in v2: > - Added 'const' spec to the declaration to avoid build warning > > drivers/iio/adc/at

Re: [PATCH v2 2/2] iio: adc: at91: fix wrong channel number in triggered buffer mode

2018-09-25 Thread Ludovic Desroches
annel. > > Fixes 0e589d5fb "ARM: AT91: IIO: Add AT91 ADC driver." > Cc: Maxime Ripard > Signed-off-by: Eugen Hristev Acked-by: Ludovic Desroches > --- > Changes in v2: > - Added 'const' spec to the declaration to avoid build warning > > drivers/iio/adc/at

Re: [PATCH v2 1/2] iio: adc: at91: fix acking DRDY irq on simple conversions

2018-09-25 Thread Ludovic Desroches
ipard > Signed-off-by: Eugen Hristev Acked-by: Ludovic Desroches > --- > Hello Jonathan, > > I moved this LCDR read/acknowledge into the IRQ handler after the conversion > value is being read. > Sorry about the noise to stable@vger, removed from message. > > Thanks, &

Re: [PATCH v2 1/2] iio: adc: at91: fix acking DRDY irq on simple conversions

2018-09-25 Thread Ludovic Desroches
ipard > Signed-off-by: Eugen Hristev Acked-by: Ludovic Desroches > --- > Hello Jonathan, > > I moved this LCDR read/acknowledge into the IRQ handler after the conversion > value is being read. > Sorry about the noise to stable@vger, removed from message. > > Thanks, &

[PATCH] pinctrl: at91: don't use the same irqchip with multiple gpiochips

2018-09-13 Thread Ludovic Desroches
Sharing the same irqchip with multiple gpiochips is not a good practice. For instance, when installing hooks, we change the state of the irqchip. The initial state of the irqchip for the second gpiochip to register is then disrupted. Signed-off-by: Ludovic Desroches --- Hi, This patch fixes

[PATCH] pinctrl: at91: don't use the same irqchip with multiple gpiochips

2018-09-13 Thread Ludovic Desroches
Sharing the same irqchip with multiple gpiochips is not a good practice. For instance, when installing hooks, we change the state of the irqchip. The initial state of the irqchip for the second gpiochip to register is then disrupted. Signed-off-by: Ludovic Desroches --- Hi, This patch fixes

Re: [PATCH] ARM: dts: at91: sama5d4: add labels to soc dtsi for derivative boards

2018-09-07 Thread Ludovic Desroches
t for all peripherals: trng, aes, tdes and sha are still missing a label. Otherwise Acked-by: Ludovic Desroches Regards Ludovic > > Based on top of at91-next branch of at91.git > > Thanks. > > arch/arm/boot/dts/sama5d4.dtsi | 8 > 1 file changed, 4 insertions(+), 4

Re: [PATCH] ARM: dts: at91: sama5d4: add labels to soc dtsi for derivative boards

2018-09-07 Thread Ludovic Desroches
t for all peripherals: trng, aes, tdes and sha are still missing a label. Otherwise Acked-by: Ludovic Desroches Regards Ludovic > > Based on top of at91-next branch of at91.git > > Thanks. > > arch/arm/boot/dts/sama5d4.dtsi | 8 > 1 file changed, 4 insertions(+), 4

[PATCH] ARM: dts: at91: sama5d2_ptc_ek: fix nand pinctrl

2018-09-07 Thread Ludovic Desroches
The drive strength has to be set to medium otherwise some data corruption may happen. Signed-off-by: Ludovic Desroches --- Hi, This fix depends on the support of the drive-strength for the atmel pio4 pinctroller. It has been added in v4.19 but I omitted to send it at the same time. Ludovic

[PATCH] ARM: dts: at91: sama5d2_ptc_ek: fix nand pinctrl

2018-09-07 Thread Ludovic Desroches
The drive strength has to be set to medium otherwise some data corruption may happen. Signed-off-by: Ludovic Desroches --- Hi, This fix depends on the support of the drive-strength for the atmel pio4 pinctroller. It has been added in v4.19 but I omitted to send it at the same time. Ludovic

[PATCH v4 0/2] add ISO7816 support

2018-09-06 Thread Ludovic Desroches
Hi, This patchset adds support for the ISO7816 standard. The USART devices in Microchip SoCs have an ISO7816 mode. It allows to let the USART managing the CLK and I/O signals of a smart card. Changes: - v4 - use the IP version number instead of the compatible string to set min and max values

[PATCH v4 2/2] tty/serial: atmel: add ISO7816 support

2018-09-06 Thread Ludovic Desroches
, add check on fidi ratio, checkpatch fixes] Signed-off-by: Ludovic Desroches --- drivers/tty/serial/atmel_serial.c | 190 +++--- drivers/tty/serial/atmel_serial.h | 3 +- 2 files changed, 181 insertions(+), 12 deletions(-) diff --git a/drivers/tty/serial

[PATCH v4 0/2] add ISO7816 support

2018-09-06 Thread Ludovic Desroches
Hi, This patchset adds support for the ISO7816 standard. The USART devices in Microchip SoCs have an ISO7816 mode. It allows to let the USART managing the CLK and I/O signals of a smart card. Changes: - v4 - use the IP version number instead of the compatible string to set min and max values

[PATCH v4 2/2] tty/serial: atmel: add ISO7816 support

2018-09-06 Thread Ludovic Desroches
, add check on fidi ratio, checkpatch fixes] Signed-off-by: Ludovic Desroches --- drivers/tty/serial/atmel_serial.c | 190 +++--- drivers/tty/serial/atmel_serial.h | 3 +- 2 files changed, 181 insertions(+), 12 deletions(-) diff --git a/drivers/tty/serial

[PATCH v4 1/2] tty/serial_core: add ISO7816 infrastructure

2018-09-06 Thread Ludovic Desroches
-off-by: Ludovic Desroches --- arch/alpha/include/uapi/asm/ioctls.h | 2 ++ arch/mips/include/uapi/asm/ioctls.h| 2 ++ arch/parisc/include/uapi/asm/ioctls.h | 2 ++ arch/powerpc/include/uapi/asm/ioctls.h | 2 ++ arch/sh/include/uapi/asm/ioctls.h | 2 ++ arch/sparc/include/uapi/asm

[PATCH v4 1/2] tty/serial_core: add ISO7816 infrastructure

2018-09-06 Thread Ludovic Desroches
-off-by: Ludovic Desroches --- arch/alpha/include/uapi/asm/ioctls.h | 2 ++ arch/mips/include/uapi/asm/ioctls.h| 2 ++ arch/parisc/include/uapi/asm/ioctls.h | 2 ++ arch/powerpc/include/uapi/asm/ioctls.h | 2 ++ arch/sh/include/uapi/asm/ioctls.h | 2 ++ arch/sparc/include/uapi/asm

Re: [PATCH v3 2/2] tty/serial: atmel: add ISO7816 support

2018-09-05 Thread Ludovic Desroches
On Wed, Sep 05, 2018 at 03:53:02PM +0200, Richard Genoud wrote: > [added Nicolas back in the thread, he was removed somehow] > > Hi Ludovic ! > > On 05/09/2018 14:43, Ludovic Desroches wrote: > > Hi Richard, > > > > On Thu, Aug 09, 2018 at 01:30:35PM +0200,

Re: [PATCH v3 2/2] tty/serial: atmel: add ISO7816 support

2018-09-05 Thread Ludovic Desroches
On Wed, Sep 05, 2018 at 03:53:02PM +0200, Richard Genoud wrote: > [added Nicolas back in the thread, he was removed somehow] > > Hi Ludovic ! > > On 05/09/2018 14:43, Ludovic Desroches wrote: > > Hi Richard, > > > > On Thu, Aug 09, 2018 at 01:30:35PM +0200,

Re: [PATCH v3 2/2] tty/serial: atmel: add ISO7816 support

2018-09-05 Thread Ludovic Desroches
Hi Richard, On Thu, Aug 09, 2018 at 01:30:35PM +0200, Ludovic Desroches wrote: > Hi Richard, > > On Thu, Aug 09, 2018 at 10:47:17AM +0200, Richard Genoud wrote: > > Hi ! > > > > On 07/08/2018 15:00, Ludovic Desroches wrote: > > > From: Nicolas

Re: [PATCH v3 2/2] tty/serial: atmel: add ISO7816 support

2018-09-05 Thread Ludovic Desroches
Hi Richard, On Thu, Aug 09, 2018 at 01:30:35PM +0200, Ludovic Desroches wrote: > Hi Richard, > > On Thu, Aug 09, 2018 at 10:47:17AM +0200, Richard Genoud wrote: > > Hi ! > > > > On 07/08/2018 15:00, Ludovic Desroches wrote: > > > From: Nicolas

Re: [PATCH 3/3] dmaengine: at_xdmac: move spin_lock_bh to spin_lock in tasklet

2018-08-20 Thread Ludovic Desroches
On Fri, Aug 17, 2018 at 06:03:43AM -0700, Barry Song wrote: > as you are already in a tasklet, it is unnecessary to call spin_lock_bh. > > Signed-off-by: Barry Song <21cn...@gmail.com> Acked-by: Ludovic Desroches Thanks > --- > drivers/dma/at_xdmac.c | 4 ++-- > 1 fi

Re: [PATCH 3/3] dmaengine: at_xdmac: move spin_lock_bh to spin_lock in tasklet

2018-08-20 Thread Ludovic Desroches
On Fri, Aug 17, 2018 at 06:03:43AM -0700, Barry Song wrote: > as you are already in a tasklet, it is unnecessary to call spin_lock_bh. > > Signed-off-by: Barry Song <21cn...@gmail.com> Acked-by: Ludovic Desroches Thanks > --- > drivers/dma/at_xdmac.c | 4 ++-- > 1 fi

[PATCH 1/2] mmc: atmel-mci: fix bad logic of sg_copy_{from,to}_buffer conversion

2018-08-20 Thread Ludovic Desroches
-off-by: Ludovic Desroches Suggested-by: Douglas Gilbert Fixes: 5b4277814e3f ("mmc: atmel-mci: use sg_copy_{from,to}_buffer") --- drivers/mmc/host/atmel-mci.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/a

[PATCH 2/2] mmc: android-goldfish: fix bad logic of sg_copy_{from,to}_buffer conversion

2018-08-20 Thread Ludovic Desroches
om_buffer but in the opposite way. Signed-off-by: Ludovic Desroches Suggested-by: Douglas Gilbert Fixes: 53d7e098ba08 ("mmc: android-goldfish: use sg_copy_{from,to}_buffer") --- drivers/mmc/host/android-goldfish.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/an

[PATCH 1/2] mmc: atmel-mci: fix bad logic of sg_copy_{from,to}_buffer conversion

2018-08-20 Thread Ludovic Desroches
-off-by: Ludovic Desroches Suggested-by: Douglas Gilbert Fixes: 5b4277814e3f ("mmc: atmel-mci: use sg_copy_{from,to}_buffer") --- drivers/mmc/host/atmel-mci.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/mmc/host/atmel-mci.c b/drivers/mmc/host/a

[PATCH 2/2] mmc: android-goldfish: fix bad logic of sg_copy_{from,to}_buffer conversion

2018-08-20 Thread Ludovic Desroches
om_buffer but in the opposite way. Signed-off-by: Ludovic Desroches Suggested-by: Douglas Gilbert Fixes: 53d7e098ba08 ("mmc: android-goldfish: use sg_copy_{from,to}_buffer") --- drivers/mmc/host/android-goldfish.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/mmc/host/an

[PATCH 0/2] atmel-mci and maybe android-goldfish broken on 4.18

2018-08-20 Thread Ludovic Desroches
o it can't replace a memcpy where the destination is the virtual address of an SG buffer. This patch was part of "make more host drivers highmem safe v2". It seems there is the same logical error within the android-goldfish driver but I couldn't check it on real hardware. Ludovic Desroches (

[PATCH 0/2] atmel-mci and maybe android-goldfish broken on 4.18

2018-08-20 Thread Ludovic Desroches
o it can't replace a memcpy where the destination is the virtual address of an SG buffer. This patch was part of "make more host drivers highmem safe v2". It seems there is the same logical error within the android-goldfish driver but I couldn't check it on real hardware. Ludovic Desroches (

Re: [PATCH v3 2/2] tty/serial: atmel: add ISO7816 support

2018-08-09 Thread Ludovic Desroches
Hi Richard, On Thu, Aug 09, 2018 at 10:47:17AM +0200, Richard Genoud wrote: > Hi ! > > On 07/08/2018 15:00, Ludovic Desroches wrote: > > From: Nicolas Ferre > > > > When mode is set in atmel_config_iso7816() we backup last RS232 mode > > for coming back to

Re: [PATCH v3 2/2] tty/serial: atmel: add ISO7816 support

2018-08-09 Thread Ludovic Desroches
Hi Richard, On Thu, Aug 09, 2018 at 10:47:17AM +0200, Richard Genoud wrote: > Hi ! > > On 07/08/2018 15:00, Ludovic Desroches wrote: > > From: Nicolas Ferre > > > > When mode is set in atmel_config_iso7816() we backup last RS232 mode > > for coming back to

[PATCH v3 2/2] tty/serial: atmel: add ISO7816 support

2018-08-07 Thread Ludovic Desroches
, add check on fidi ratio, checkpatch fixes] Signed-off-by: Ludovic Desroches --- drivers/tty/serial/atmel_serial.c | 211 +++--- drivers/tty/serial/atmel_serial.h | 6 +- 2 files changed, 201 insertions(+), 16 deletions(-) diff --git a/drivers/tty/serial

[PATCH v3 1/2] tty/serial_core: add ISO7816 infrastructure

2018-08-07 Thread Ludovic Desroches
-by: Ludovic Desroches --- arch/alpha/include/uapi/asm/ioctls.h | 2 ++ arch/mips/include/uapi/asm/ioctls.h| 2 ++ arch/parisc/include/uapi/asm/ioctls.h | 2 ++ arch/powerpc/include/uapi/asm/ioctls.h | 2 ++ arch/sh/include/uapi/asm/ioctls.h | 2 ++ arch/sparc/include/uapi/asm/ioctls.h

[PATCH v3 2/2] tty/serial: atmel: add ISO7816 support

2018-08-07 Thread Ludovic Desroches
, add check on fidi ratio, checkpatch fixes] Signed-off-by: Ludovic Desroches --- drivers/tty/serial/atmel_serial.c | 211 +++--- drivers/tty/serial/atmel_serial.h | 6 +- 2 files changed, 201 insertions(+), 16 deletions(-) diff --git a/drivers/tty/serial

[PATCH v3 1/2] tty/serial_core: add ISO7816 infrastructure

2018-08-07 Thread Ludovic Desroches
-by: Ludovic Desroches --- arch/alpha/include/uapi/asm/ioctls.h | 2 ++ arch/mips/include/uapi/asm/ioctls.h| 2 ++ arch/parisc/include/uapi/asm/ioctls.h | 2 ++ arch/powerpc/include/uapi/asm/ioctls.h | 2 ++ arch/sh/include/uapi/asm/ioctls.h | 2 ++ arch/sparc/include/uapi/asm/ioctls.h

[PATCH v3 0/2] add ISO7816 support

2018-08-07 Thread Ludovic Desroches
Hi, This patchset adds support for the ISO7816 standard. The USART devices in Microchip SoCs have an ISO7816 mode. It allows to let the USART managing the CLK and I/O signals of a smart card. Changes: - v3 - add IOCTLs to parisc arch. - rework atmel_config_iso7816 according to the comments

[PATCH v3 0/2] add ISO7816 support

2018-08-07 Thread Ludovic Desroches
Hi, This patchset adds support for the ISO7816 standard. The USART devices in Microchip SoCs have an ISO7816 mode. It allows to let the USART managing the CLK and I/O signals of a smart card. Changes: - v3 - add IOCTLs to parisc arch. - rework atmel_config_iso7816 according to the comments

Re: [PATCH v2 2/2] tty/serial: atmel: add ISO7816 support

2018-08-03 Thread Ludovic Desroches
Hi Richard, On Fri, Jul 27, 2018 at 04:39:17PM +0200, Richard Genoud wrote: > Hi Ludovic, > > On 19/07/2018 10:47, Ludovic Desroches wrote: > > From: Nicolas Ferre > > > > When mode is set in atmel_config_iso7816() we backup last RS232 mode > > for comi

Re: [PATCH v2 2/2] tty/serial: atmel: add ISO7816 support

2018-08-03 Thread Ludovic Desroches
Hi Richard, On Fri, Jul 27, 2018 at 04:39:17PM +0200, Richard Genoud wrote: > Hi Ludovic, > > On 19/07/2018 10:47, Ludovic Desroches wrote: > > From: Nicolas Ferre > > > > When mode is set in atmel_config_iso7816() we backup last RS232 mode > > for comi

Re: [PATCH v3 0/3] i2c: at91: slave mode support

2018-07-30 Thread Ludovic Desroches
On Sat, Jul 21, 2018 at 12:41:41AM +0200, Wolfram Sang wrote: > > [Ludovic Desroches] > > Changes in v3: > > - rebase (cherry-pick was enough) > > Thanks for the rebase. I wonder, though, I recall to had more > complicated issues. However... > > >

Re: [PATCH v3 0/3] i2c: at91: slave mode support

2018-07-30 Thread Ludovic Desroches
On Sat, Jul 21, 2018 at 12:41:41AM +0200, Wolfram Sang wrote: > > [Ludovic Desroches] > > Changes in v3: > > - rebase (cherry-pick was enough) > > Thanks for the rebase. I wonder, though, I recall to had more > complicated issues. However... > > >

Re: [PATCH v2 0/2] add ISO7816 support

2018-07-19 Thread Ludovic Desroches
Hi Neil, On Thu, Jul 19, 2018 at 10:59:47AM +0200, Neil Armstrong wrote: > Hi Ludovic, > > On 19/07/2018 10:47, Ludovic Desroches wrote: > > Hi, > > > > This patchset adds support for the ISO7816 standard. The USART devices in > > Microchip SoCs have an ISO7816

Re: [PATCH v2 0/2] add ISO7816 support

2018-07-19 Thread Ludovic Desroches
Hi Neil, On Thu, Jul 19, 2018 at 10:59:47AM +0200, Neil Armstrong wrote: > Hi Ludovic, > > On 19/07/2018 10:47, Ludovic Desroches wrote: > > Hi, > > > > This patchset adds support for the ISO7816 standard. The USART devices in > > Microchip SoCs have an ISO7816

[PATCH v2 1/2] tty/serial_core: add ISO7816 infrastructure

2018-07-19 Thread Ludovic Desroches
From: Nicolas Ferre Add the ISO7816 ioctl and associated accessors and data structure. Drivers can then use this common implementation to handle ISO7816. Signed-off-by: Nicolas Ferre Signed-off-by: Ludovic Desroches --- arch/alpha/include/uapi/asm/ioctls.h | 2 ++ arch/mips/include/uapi

[PATCH v2 0/2] add ISO7816 support

2018-07-19 Thread Ludovic Desroches
Hi, This patchset adds support for the ISO7816 standard. The USART devices in Microchip SoCs have an ISO7816 mode. It allows to let the USART managing the CLK and I/O signals of a smart card. Changes: - v2 - uart_get_iso7816_config: check there is an iso7816_config function - use IOCTL

[PATCH v2 1/2] tty/serial_core: add ISO7816 infrastructure

2018-07-19 Thread Ludovic Desroches
From: Nicolas Ferre Add the ISO7816 ioctl and associated accessors and data structure. Drivers can then use this common implementation to handle ISO7816. Signed-off-by: Nicolas Ferre Signed-off-by: Ludovic Desroches --- arch/alpha/include/uapi/asm/ioctls.h | 2 ++ arch/mips/include/uapi

[PATCH v2 0/2] add ISO7816 support

2018-07-19 Thread Ludovic Desroches
Hi, This patchset adds support for the ISO7816 standard. The USART devices in Microchip SoCs have an ISO7816 mode. It allows to let the USART managing the CLK and I/O signals of a smart card. Changes: - v2 - uart_get_iso7816_config: check there is an iso7816_config function - use IOCTL

[PATCH v2 2/2] tty/serial: atmel: add ISO7816 support

2018-07-19 Thread Ludovic Desroches
Ferre Signed-off-by: Ludovic Desroches --- drivers/tty/serial/atmel_serial.c | 170 +++--- drivers/tty/serial/atmel_serial.h | 3 +- 2 files changed, 162 insertions(+), 11 deletions(-) diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial

[PATCH v2 2/2] tty/serial: atmel: add ISO7816 support

2018-07-19 Thread Ludovic Desroches
Ferre Signed-off-by: Ludovic Desroches --- drivers/tty/serial/atmel_serial.c | 170 +++--- drivers/tty/serial/atmel_serial.h | 3 +- 2 files changed, 162 insertions(+), 11 deletions(-) diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial

[PATCH v3 3/3] i2c: at91: added slave mode support

2018-07-16 Thread Ludovic Desroches
From: Juergen Fitschen Slave mode driver is based on the concept of i2c-designware driver. Signed-off-by: Juergen Fitschen Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/Makefile | 3 + drivers/i2c/busses/i2c-at91-core.c | 13 +++- drivers/i2c/busses/i2c-at91-slave.c

[PATCH v3 1/3] i2c: at91: segregate master mode specific code from probe and init func

2018-07-16 Thread Ludovic Desroches
the shared general code has been executed. This concept has been influenced by the i2c-designware driver. Signed-off-by: Juergen Fitschen Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/i2c-at91.c | 90 ++- 1 file changed, 55 insertions(+), 35

[PATCH v3 0/3] i2c: at91: slave mode support

2018-07-16 Thread Ludovic Desroches
[Ludovic Desroches: see 'Changes in v3' section] Based on the discussion we had on the i2c-linux list [1], I wrote a patch for AT91 hardware and tried to fulfill the Linux I2C slave interface description [2] as good as possible. This enables aforementioned hardware to act as an I2C slave that can

[PATCH v3 2/3] i2c: at91: split driver into core and master file

2018-07-16 Thread Ludovic Desroches
had to be made non-static. Furthermore, includes have been cleaned up. Signed-off-by: Juergen Fitschen [ludovic.desroc...@microchip.com: fix checkpatch errors] Signed-off-by: Ludovic Desroches --- MAINTAINERS| 3 +- drivers/i2c/busses/Makefile

[PATCH v3 3/3] i2c: at91: added slave mode support

2018-07-16 Thread Ludovic Desroches
From: Juergen Fitschen Slave mode driver is based on the concept of i2c-designware driver. Signed-off-by: Juergen Fitschen Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/Makefile | 3 + drivers/i2c/busses/i2c-at91-core.c | 13 +++- drivers/i2c/busses/i2c-at91-slave.c

[PATCH v3 1/3] i2c: at91: segregate master mode specific code from probe and init func

2018-07-16 Thread Ludovic Desroches
the shared general code has been executed. This concept has been influenced by the i2c-designware driver. Signed-off-by: Juergen Fitschen Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/i2c-at91.c | 90 ++- 1 file changed, 55 insertions(+), 35

[PATCH v3 0/3] i2c: at91: slave mode support

2018-07-16 Thread Ludovic Desroches
[Ludovic Desroches: see 'Changes in v3' section] Based on the discussion we had on the i2c-linux list [1], I wrote a patch for AT91 hardware and tried to fulfill the Linux I2C slave interface description [2] as good as possible. This enables aforementioned hardware to act as an I2C slave that can

[PATCH v3 2/3] i2c: at91: split driver into core and master file

2018-07-16 Thread Ludovic Desroches
had to be made non-static. Furthermore, includes have been cleaned up. Signed-off-by: Juergen Fitschen [ludovic.desroc...@microchip.com: fix checkpatch errors] Signed-off-by: Ludovic Desroches --- MAINTAINERS| 3 +- drivers/i2c/busses/Makefile

Re: [PATCH 1/3] tty/serial_core: add ISO7816 infrastructure

2018-07-13 Thread Ludovic Desroches
On Thu, Jul 12, 2018 at 04:58:08PM +0200, Greg KH wrote: > On Wed, Jul 11, 2018 at 03:16:36PM +0200, Ludovic Desroches wrote: > > From: Nicolas Ferre > > > > Add the ISO7816 ioctl and associated accessors and data structure. > > Drivers can then use this common imple

Re: [PATCH 1/3] tty/serial_core: add ISO7816 infrastructure

2018-07-13 Thread Ludovic Desroches
On Thu, Jul 12, 2018 at 04:58:08PM +0200, Greg KH wrote: > On Wed, Jul 11, 2018 at 03:16:36PM +0200, Ludovic Desroches wrote: > > From: Nicolas Ferre > > > > Add the ISO7816 ioctl and associated accessors and data structure. > > Drivers can then use this common imple

Re: [PATCH 1/3] tty/serial_core: add ISO7816 infrastructure

2018-07-13 Thread Ludovic Desroches
On Thu, Jul 12, 2018 at 05:02:29PM +0200, Greg KH wrote: > On Wed, Jul 11, 2018 at 03:16:36PM +0200, Ludovic Desroches wrote: > > From: Nicolas Ferre > > > > Add the ISO7816 ioctl and associated accessors and data structure. > > Drivers can then use this common imple

Re: [PATCH 1/3] tty/serial_core: add ISO7816 infrastructure

2018-07-13 Thread Ludovic Desroches
On Thu, Jul 12, 2018 at 05:02:29PM +0200, Greg KH wrote: > On Wed, Jul 11, 2018 at 03:16:36PM +0200, Ludovic Desroches wrote: > > From: Nicolas Ferre > > > > Add the ISO7816 ioctl and associated accessors and data structure. > > Drivers can then use this common imple

Re: [v2,3/3] i2c: at91: added slave mode support

2018-07-13 Thread Ludovic Desroches
On Thu, Jul 12, 2018 at 11:56:24PM +0200, Wolfram Sang wrote: > > > Yes sure, you can add my Ack. I would be pleased to see the slave > > support taken. > > Sadly, I can't get it to apply cleanly. Could you rebase and retest? > Ok I'll handle it and add my Acked-by. Ludovic

Re: [v2,3/3] i2c: at91: added slave mode support

2018-07-13 Thread Ludovic Desroches
On Thu, Jul 12, 2018 at 11:56:24PM +0200, Wolfram Sang wrote: > > > Yes sure, you can add my Ack. I would be pleased to see the slave > > support taken. > > Sadly, I can't get it to apply cleanly. Could you rebase and retest? > Ok I'll handle it and add my Acked-by. Ludovic

Re: [PATCH 3/3] tty/serial: atmel: manage shutdown in case of RS485 or ISO7816 mode

2018-07-12 Thread Ludovic Desroches
On Thu, Jul 12, 2018 at 04:58:27PM +0200, Greg KH wrote: > On Wed, Jul 11, 2018 at 03:26:23PM +0200, Ludovic Desroches wrote: > > From: Nicolas Ferre > > > > In atmel_shutdown() we call atmel_stop_rx() and atmel_stop_tx() functions. > > Prevent the rx restart t

Re: [PATCH 3/3] tty/serial: atmel: manage shutdown in case of RS485 or ISO7816 mode

2018-07-12 Thread Ludovic Desroches
On Thu, Jul 12, 2018 at 04:58:27PM +0200, Greg KH wrote: > On Wed, Jul 11, 2018 at 03:26:23PM +0200, Ludovic Desroches wrote: > > From: Nicolas Ferre > > > > In atmel_shutdown() we call atmel_stop_rx() and atmel_stop_tx() functions. > > Prevent the rx restart t

Re: [PATCH] ARM: dts: at91: fix typo for PIN_PB22

2018-07-12 Thread Ludovic Desroches
Hi Claudiu, On Wed, Jul 11, 2018 at 07:25:37PM +0300, Claudiu Beznea wrote: > Fix typo for PIN_PB22 on TD function. In fact, this typo is present in several places in this file. It could be worth fixing all those occurences in a single patch. Regards Ludovic > > Signed-off-by: Claudiu Beznea

Re: [PATCH] ARM: dts: at91: fix typo for PIN_PB22

2018-07-12 Thread Ludovic Desroches
Hi Claudiu, On Wed, Jul 11, 2018 at 07:25:37PM +0300, Claudiu Beznea wrote: > Fix typo for PIN_PB22 on TD function. In fact, this typo is present in several places in this file. It could be worth fixing all those occurences in a single patch. Regards Ludovic > > Signed-off-by: Claudiu Beznea

[PATCH 3/3] tty/serial: atmel: manage shutdown in case of RS485 or ISO7816 mode

2018-07-11 Thread Ludovic Desroches
From: Nicolas Ferre In atmel_shutdown() we call atmel_stop_rx() and atmel_stop_tx() functions. Prevent the rx restart that is implemented in RS485 or ISO7816 modes when calling atmel_stop_tx() by using the atomic information tasklet_shutdown that is already in place for this purpose.

[PATCH 3/3] tty/serial: atmel: manage shutdown in case of RS485 or ISO7816 mode

2018-07-11 Thread Ludovic Desroches
From: Nicolas Ferre In atmel_shutdown() we call atmel_stop_rx() and atmel_stop_tx() functions. Prevent the rx restart that is implemented in RS485 or ISO7816 modes when calling atmel_stop_tx() by using the atomic information tasklet_shutdown that is already in place for this purpose.

[PATCH 2/3] tty/serial: atmel: add ISO7816 support

2018-07-11 Thread Ludovic Desroches
Ferre [ludovic.desroc...@microchip.com: rebase, add check on fidi ratio, checkpatch fixes] Signed-off-by: Ludovic Desroches --- drivers/tty/serial/atmel_serial.c | 175 +++--- drivers/tty/serial/atmel_serial.h | 3 +- 2 files changed, 167 insertions(+), 11

[PATCH 2/3] tty/serial: atmel: add ISO7816 support

2018-07-11 Thread Ludovic Desroches
Ferre [ludovic.desroc...@microchip.com: rebase, add check on fidi ratio, checkpatch fixes] Signed-off-by: Ludovic Desroches --- drivers/tty/serial/atmel_serial.c | 175 +++--- drivers/tty/serial/atmel_serial.h | 3 +- 2 files changed, 167 insertions(+), 11

[PATCH 1/3] tty/serial_core: add ISO7816 infrastructure

2018-07-11 Thread Ludovic Desroches
-by: Ludovic Desroches --- drivers/tty/serial/serial_core.c | 49 +++ include/linux/serial_core.h | 3 +++ include/uapi/asm-generic/ioctls.h | 2 ++ include/uapi/linux/serial.h | 17 ++ 4 files changed, 71 insertions(+) diff --git a/drivers/tty

[PATCH 0/3] add ISO7816 support

2018-07-11 Thread Ludovic Desroches
Hi, This set of patches adds support for the ISO7816 standard. The USART devices in Microchip SoCs have an ISO7816 mode. It allows to let the USART managing the CLK and I/O signals of a smart card. Nicolas Ferre (3): tty/serial_core: add ISO7816 infrastructure tty/serial: atmel: add ISO7816

[PATCH 3/3] tty/serial: atmel: manage shutdown in case of RS485 or ISO7816 mode

2018-07-11 Thread Ludovic Desroches
From: Nicolas Ferre In atmel_shutdown() we call atmel_stop_rx() and atmel_stop_tx() functions. Prevent the rx restart that is implemented in RS485 or ISO7816 modes when calling atmel_stop_tx() by using the atomic information tasklet_shutdown that is already in place for this purpose.

[PATCH 1/3] tty/serial_core: add ISO7816 infrastructure

2018-07-11 Thread Ludovic Desroches
-by: Ludovic Desroches --- drivers/tty/serial/serial_core.c | 49 +++ include/linux/serial_core.h | 3 +++ include/uapi/asm-generic/ioctls.h | 2 ++ include/uapi/linux/serial.h | 17 ++ 4 files changed, 71 insertions(+) diff --git a/drivers/tty

[PATCH 0/3] add ISO7816 support

2018-07-11 Thread Ludovic Desroches
Hi, This set of patches adds support for the ISO7816 standard. The USART devices in Microchip SoCs have an ISO7816 mode. It allows to let the USART managing the CLK and I/O signals of a smart card. Nicolas Ferre (3): tty/serial_core: add ISO7816 infrastructure tty/serial: atmel: add ISO7816

[PATCH 3/3] tty/serial: atmel: manage shutdown in case of RS485 or ISO7816 mode

2018-07-11 Thread Ludovic Desroches
From: Nicolas Ferre In atmel_shutdown() we call atmel_stop_rx() and atmel_stop_tx() functions. Prevent the rx restart that is implemented in RS485 or ISO7816 modes when calling atmel_stop_tx() by using the atomic information tasklet_shutdown that is already in place for this purpose.

Re: [v2,3/3] i2c: at91: added slave mode support

2018-07-10 Thread Ludovic Desroches
On Mon, Jul 09, 2018 at 05:51:36PM +0200, Wolfram Sang wrote: > > > Sorry for having not catched it. If I remember well, it was the only > > issue I had while testing the slave support. > > > > > > > > BTW maybe I asked already and forgot: is this IP core capable of being > > > master and slave

Re: [v2,3/3] i2c: at91: added slave mode support

2018-07-10 Thread Ludovic Desroches
On Mon, Jul 09, 2018 at 05:51:36PM +0200, Wolfram Sang wrote: > > > Sorry for having not catched it. If I remember well, it was the only > > issue I had while testing the slave support. > > > > > > > > BTW maybe I asked already and forgot: is this IP core capable of being > > > master and slave

Re: [v2,3/3] i2c: at91: added slave mode support

2018-07-09 Thread Ludovic Desroches
Sorry for the delay to answer. I changed my email filters. Unfortunately there was a bug and I missed message from this mailing list... On Sat, Jun 02, 2018 at 11:35:13PM +0200, Wolfram Sang wrote: > On Thu, Nov 09, 2017 at 06:22:29PM +0100, Juergen Fitschen wrote: > > Slave mode driver is based

Re: [v2,3/3] i2c: at91: added slave mode support

2018-07-09 Thread Ludovic Desroches
Sorry for the delay to answer. I changed my email filters. Unfortunately there was a bug and I missed message from this mailing list... On Sat, Jun 02, 2018 at 11:35:13PM +0200, Wolfram Sang wrote: > On Thu, Nov 09, 2017 at 06:22:29PM +0100, Juergen Fitschen wrote: > > Slave mode driver is based

[PATCH v2] pinctrl: at91-pio4: add support for drive strength

2018-06-29 Thread Ludovic Desroches
-by: Ludovic Desroches --- Changes: - v2: use atmel,drive-strength property instead of drive-strengh one since it is not expressend in mA and there is no way to retrieve this value at runtime. - v1: https://www.spinics.net/lists/linux-gpio/msg27789.html .../bindings/pinctrl/atmel,at91-pio4-pinctrl.txt

[PATCH v2] pinctrl: at91-pio4: add support for drive strength

2018-06-29 Thread Ludovic Desroches
-by: Ludovic Desroches --- Changes: - v2: use atmel,drive-strength property instead of drive-strengh one since it is not expressend in mA and there is no way to retrieve this value at runtime. - v1: https://www.spinics.net/lists/linux-gpio/msg27789.html .../bindings/pinctrl/atmel,at91-pio4-pinctrl.txt

Re: [PATCH v7 3/6] mfd: at91-usart: added mfd driver for usart

2018-06-14 Thread Ludovic Desroches
On Wed, Jun 13, 2018 at 07:36:18PM +0300, Radu Pirea wrote: > This mfd driver is just a wrapper over atmel_serial driver and > spi-at91-usart driver. Selection of one of the drivers is based on a > property from device tree. If the property is not specified, the default > driver is atmel_serial. >

Re: [PATCH v7 3/6] mfd: at91-usart: added mfd driver for usart

2018-06-14 Thread Ludovic Desroches
On Wed, Jun 13, 2018 at 07:36:18PM +0300, Radu Pirea wrote: > This mfd driver is just a wrapper over atmel_serial driver and > spi-at91-usart driver. Selection of one of the drivers is based on a > property from device tree. If the property is not specified, the default > driver is atmel_serial. >

Re: [PATCH 1/5] pinctrl: at91-pio4: add missing of_node_put

2018-05-24 Thread Ludovic Desroches
. > } > ... when != child > // > > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Acked-by: Ludovic Desroches <ludovic.desroc...@microchip.com> Thanks > > --- > drivers/pinctrl/pinctrl-at91-pio4.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion

Re: [PATCH 1/5] pinctrl: at91-pio4: add missing of_node_put

2018-05-24 Thread Ludovic Desroches
. > } > ... when != child > // > > Signed-off-by: Julia Lawall Acked-by: Ludovic Desroches Thanks > > --- > drivers/pinctrl/pinctrl-at91-pio4.c |4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-at91-pio4.

Re: [PATCH v7 7/9] dt-bindings: iio: adc: at91-sama5d2_adc: add channel specific consumer info

2018-05-22 Thread Ludovic Desroches
On Tue, May 22, 2018 at 10:52:37AM +0300, Eugen Hristev wrote: > Added defines for channel consumer device-tree binding > > Signed-off-by: Eugen Hristev <eugen.hris...@microchip.com> > Reviewed-by: Rob Herring <r...@kernel.org> Acked-by: Ludovic Desroches <ludo

Re: [PATCH v7 7/9] dt-bindings: iio: adc: at91-sama5d2_adc: add channel specific consumer info

2018-05-22 Thread Ludovic Desroches
On Tue, May 22, 2018 at 10:52:37AM +0300, Eugen Hristev wrote: > Added defines for channel consumer device-tree binding > > Signed-off-by: Eugen Hristev > Reviewed-by: Rob Herring Acked-by: Ludovic Desroches > --- > .../devicetree/bindings/iio/adc/at91-sama5d

Re: [PATCH v7 5/9] iio: adc: at91-sama5d2_adc: add support for position and pressure channels

2018-05-22 Thread Ludovic Desroches
f this patch are based on initial original work by > Mohamed Jamsheeth Hajanajubudeen and Bandaru Venkateswara Swamy > > Signed-off-by: Eugen Hristev <eugen.hris...@microchip.com> Acked-by: Ludovic Desroches <ludovic.desroc...@microchip.com> > --- > Changes in v6: > - fix

Re: [PATCH v7 5/9] iio: adc: at91-sama5d2_adc: add support for position and pressure channels

2018-05-22 Thread Ludovic Desroches
f this patch are based on initial original work by > Mohamed Jamsheeth Hajanajubudeen and Bandaru Venkateswara Swamy > > Signed-off-by: Eugen Hristev Acked-by: Ludovic Desroches > --- > Changes in v6: > - fixed a crash when issuing buffer enable from sysfs, if no trigger was > pre

Re: [PATCH v2] i2c: at91: Read all available bytes at once

2018-04-26 Thread Ludovic Desroches
bytes at > once. > > Signed-off-by: David Engraf <david.eng...@sysgo.com> Acked-by: Ludovic Desroches <ludovic.desroc...@microchip.com> Thanks a lot David. Regards Ludovic > --- > drivers/i2c/busses/i2c-at91.c | 12 ++-- > 1 file changed, 10 insertions(+),

Re: [PATCH v2] i2c: at91: Read all available bytes at once

2018-04-26 Thread Ludovic Desroches
bytes at > once. > > Signed-off-by: David Engraf Acked-by: Ludovic Desroches Thanks a lot David. Regards Ludovic > --- > drivers/i2c/busses/i2c-at91.c | 12 ++-- > 1 file changed, 10 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-at91.c

<    1   2   3   4   5   6   7   8   9   10   >