Re: [PATCH 5/5] ARM: dts: sama5d27_som1_ek: Add sama5d27 SoM1 EK support

On Thu, Jun 29, 2017 at 02:44:34PM +0300, Claudiu Beznea wrote: > Add specifig DTS files and bindings for sama5d27 SoM1 EK board. > > Signed-off-by: Claudiu Beznea > Signed-off-by: Cristian Birsan > --- > arch/arm/boot/dts/Makefile

Re: [PATCH 5/5] ARM: dts: sama5d27_som1_ek: Add sama5d27 SoM1 EK support

On Thu, Jun 29, 2017 at 02:44:34PM +0300, Claudiu Beznea wrote: > Add specifig DTS files and bindings for sama5d27 SoM1 EK board. > > Signed-off-by: Claudiu Beznea > Signed-off-by: Cristian Birsan > --- > arch/arm/boot/dts/Makefile | 1 + >

Re: [PATCH 4/5] ARM: dts: at91: at91-sama5d27_som1: add sama5d27 SoM1 support

On Thu, Jun 29, 2017 at 02:44:33PM +0300, Claudiu Beznea wrote: > Add specific DTS file and bindings for sama5d27 SoM1 board. > > Signed-off-by: Claudiu Beznea > Signed-off-by: Cristian Birsan > --- >

Re: [PATCH 4/5] ARM: dts: at91: at91-sama5d27_som1: add sama5d27 SoM1 support

On Thu, Jun 29, 2017 at 02:44:33PM +0300, Claudiu Beznea wrote: > Add specific DTS file and bindings for sama5d27 SoM1 board. > > Signed-off-by: Claudiu Beznea > Signed-off-by: Cristian Birsan > --- > arch/arm/boot/dts/at91-sama5d27_som1.dtsi | 178 > ++ > 1 file

Re: [RFC PATCH 2/3] drivers: misc: eeprom: at24: support reading mac eeprom from different addresses

On Thu, Jun 29, 2017 at 02:56:03PM +0300, Andy Shevchenko wrote: > On Thu, Jun 29, 2017 at 2:39 PM, Claudiu Beznea > wrote: > > Add support for reading from different offsets of EEPROM. > > The offset is initialized via device tree. If nothing is > > given as input

Re: [RFC PATCH 2/3] drivers: misc: eeprom: at24: support reading mac eeprom from different addresses

On Thu, Jun 29, 2017 at 02:56:03PM +0300, Andy Shevchenko wrote: > On Thu, Jun 29, 2017 at 2:39 PM, Claudiu Beznea > wrote: > > Add support for reading from different offsets of EEPROM. > > The offset is initialized via device tree. If nothing is > > given as input the old value, 0x90, is used.

Re: [PATCH 2/2] mmc: sdhci-of-at91: set clocks and presets after resume from deepest PM

On Tue, Jun 20, 2017 at 10:07:06AM +0200, Quentin Schulz wrote: > Hi Adrian, > > On 20/06/2017 09:39, Adrian Hunter wrote: > > On 16/06/17 10:29, Quentin Schulz wrote: > >> This adds deepest (Backup+Self-Refresh) PM support to the ATMEL SAMA5D2 > >> SoC's SDHCI controller. > >> > >> When resuming

Re: [PATCH 2/2] mmc: sdhci-of-at91: set clocks and presets after resume from deepest PM

On Tue, Jun 20, 2017 at 10:07:06AM +0200, Quentin Schulz wrote: > Hi Adrian, > > On 20/06/2017 09:39, Adrian Hunter wrote: > > On 16/06/17 10:29, Quentin Schulz wrote: > >> This adds deepest (Backup+Self-Refresh) PM support to the ATMEL SAMA5D2 > >> SoC's SDHCI controller. > >> > >> When resuming

Re: [PATCH 2/2] mmc: sdhci-of-at91: set clocks and presets after resume from deepest PM

D core has been shut down > when entering deepest state on the SAMA5D2. The clocks need to be > reconfigured as well. > > The other registers and init process are taken care of by the SDHCI > core. > > Signed-off-by: Quentin Schulz <quentin.sch...@free-electrons.com> A

Re: [PATCH 2/2] mmc: sdhci-of-at91: set clocks and presets after resume from deepest PM

D core has been shut down > when entering deepest state on the SAMA5D2. The clocks need to be > reconfigured as well. > > The other registers and init process are taken care of by the SDHCI > core. > > Signed-off-by: Quentin Schulz Acked-by: Ludovic Desroches > --- &

Re: [PATCH 1/2] mmc: sdhci-of-at91: factor out clks and presets setting

by: Quentin Schulz <quentin.sch...@free-electrons.com> Acked-by: Ludovic Desroches <ludovic.desroc...@microchip.com> Thanks > --- > drivers/mmc/host/sdhci-of-at91.c | 147 > ++- > 1 file changed, 82 insertions(+), 65 deletions(-) > > di

Re: [PATCH 1/2] mmc: sdhci-of-at91: factor out clks and presets setting

ntin Schulz Acked-by: Ludovic Desroches Thanks > --- > drivers/mmc/host/sdhci-of-at91.c | 147 > ++- > 1 file changed, 82 insertions(+), 65 deletions(-) > > diff --git a/drivers/mmc/host/sdhci-of-at91.c > b/drivers/mmc/host/sdhci-of-at

Re: [PATCH v4 0/4] iio: adc: sama5d2_adc hw triggers and buffers

interrupt. > If the reuse of IRQ macros in the trigger case is accepted, you can add Acked-by: Ludovic Desroches <ludovic.desroc...@microchip.com> for the next version with the corrections suggested by Jonathan. Regards Ludovic > Changes in v4: > - Modified bindings t

Re: [PATCH v4 0/4] iio: adc: sama5d2_adc hw triggers and buffers

interrupt. > If the reuse of IRQ macros in the trigger case is accepted, you can add Acked-by: Ludovic Desroches for the next version with the corrections suggested by Jonathan. Regards Ludovic > Changes in v4: > - Modified bindings to be similar with interrupts > - Used iio cla

Re: [PATCH] i2c: at91: Fix compilation warning.

d\n", *dev->buf, dev->buf_len); > ^ > drivers/i2c/busses/i2c-at91.c: In function ‘at91_do_twi_transfer’: > drivers/i2c/busses/i2c-at91.c:625:2: warning: format ‘%d’ expects argument of > type ‘int’, but argument 5 has type ‘size_t’ [-Wformat=] > dev_dbg(dev->dev, "

Re: [PATCH] i2c: at91: Fix compilation warning.

d\n", *dev->buf, dev->buf_len); > ^ > drivers/i2c/busses/i2c-at91.c: In function ‘at91_do_twi_transfer’: > drivers/i2c/busses/i2c-at91.c:625:2: warning: format ‘%d’ expects argument of > type ‘int’, but argument 5 has type ‘size_t’ [-Wformat=] > dev_dbg(dev->dev, "tra

Re: [PATCH] i2c: at91: Handle return value of clk_prepare_enable

enable() return value Since there are trivial fixes, maybe having them squashed is ok. Acked-by: Ludovic Desroches <ludovic.desroc...@microchip.com> Thanks > --- > drivers/i2c/busses/i2c-at91.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --g

Re: [PATCH] i2c: at91: Handle return value of clk_prepare_enable

ue Since there are trivial fixes, maybe having them squashed is ok. Acked-by: Ludovic Desroches Thanks > --- > drivers/i2c/busses/i2c-at91.c | 8 ++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > > diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c > in

Re: [PATCH v2 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

On Wed, May 10, 2017 at 11:49:07AM +0300, Eugen Hristev wrote: > Hello, > > Thanks for the suggestions and reply. > > Please see my answers inline > > Eugen > > On 07.05.2017 18:01, Jonathan Cameron wrote: > > On 04/05/17 13:13, Eugen Hristev wrote: > > > Added support for the external

Re: [PATCH v2 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

On Wed, May 10, 2017 at 11:49:07AM +0300, Eugen Hristev wrote: > Hello, > > Thanks for the suggestions and reply. > > Please see my answers inline > > Eugen > > On 07.05.2017 18:01, Jonathan Cameron wrote: > > On 04/05/17 13:13, Eugen Hristev wrote: > > > Added support for the external

Re: [PATCH 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

tev <eugen.hris...@microchip.com> Acked-by: Ludovic Desroches <ludovic.desroc...@microchip.com> > --- > drivers/iio/adc/at91-sama5d2_adc.c | 207 > - > 1 file changed, 204 insertions(+), 3 deletions(-) > > diff --git a/drivers/iio/adc

Re: [PATCH 2/3] iio: adc: at91-sama5d2_adc: add hw trigger and buffer support

On Wed, Apr 19, 2017 at 11:20:44AM +0300, Eugen Hristev wrote: > Added support for the external hardware trigger on pin ADTRG, > integrated the three possible edge triggers into the subsystem > and created buffer management for data retrieval > > Signed-off-by: Eugen Hristev Ac

Re: [PATCH 1/3] ARM: dts: at91: sama5d2_xplained: enable ADTRG pin

On Wed, Apr 19, 2017 at 11:20:43AM +0300, Eugen Hristev wrote: > Enable pinctrl for ADTRG pin (PD31) for ADC hardware trigger support. > > Signed-off-by: Eugen Hristev <eugen.hris...@microchip.com> Acked-by: Ludovic Desroches <ludovic.desroc...@microchip.com> > --- &

Re: [PATCH 1/3] ARM: dts: at91: sama5d2_xplained: enable ADTRG pin

On Wed, Apr 19, 2017 at 11:20:43AM +0300, Eugen Hristev wrote: > Enable pinctrl for ADTRG pin (PD31) for ADC hardware trigger support. > > Signed-off-by: Eugen Hristev Acked-by: Ludovic Desroches > --- > arch/arm/boot/dts/at91-sama5d2_xplained.dts | 16 +++- >

Re: [PATCH v2 3/5] MAINTAINERS: add Atmel PTC entries

On Fri, Apr 21, 2017 at 10:39:22AM +0200, Ludovic Desroches wrote: > Add entries for the Atmel PTC Subsystem. > > Signed-off-by: Ludovic Desroches <ludovic.desroc...@microchip.com> > --- > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) > > diff --g

Re: [PATCH v2 3/5] MAINTAINERS: add Atmel PTC entries

On Fri, Apr 21, 2017 at 10:39:22AM +0200, Ludovic Desroches wrote: > Add entries for the Atmel PTC Subsystem. > > Signed-off-by: Ludovic Desroches > --- > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > in

[PATCH v2 1/5] dt-bindings: input: Add Atmel PTC subsystem bindings

Add description of the Atmel PTC subsystem bindings. Signed-off-by: Ludovic Desroches <ludovic.desroc...@microchip.com> Acked-by: Rob Herring <r...@kernel.org> --- .../devicetree/bindings/input/atmel,ptc.txt| 67 ++ 1 file changed, 67 insertions(+) create

[PATCH v2 1/5] dt-bindings: input: Add Atmel PTC subsystem bindings

Add description of the Atmel PTC subsystem bindings. Signed-off-by: Ludovic Desroches Acked-by: Rob Herring --- .../devicetree/bindings/input/atmel,ptc.txt| 67 ++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/atmel

[PATCH v2 3/5] MAINTAINERS: add Atmel PTC entries

Add entries for the Atmel PTC Subsystem. Signed-off-by: Ludovic Desroches <ludovic.desroc...@microchip.com> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 860dacb..e1b8b0e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2323,6 +2

[PATCH v2 3/5] MAINTAINERS: add Atmel PTC entries

Add entries for the Atmel PTC Subsystem. Signed-off-by: Ludovic Desroches --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 860dacb..e1b8b0e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2323,6 +2323,13 @@ F: Documentation

[PATCH v2 2/5] input: misc: introduce Atmel PTC driver

end to provide high level information as button touch or untouch, slider position, etc. - a configuration file that describe the topology and the parameters of the sensors. Signed-off-by: Ludovic Desroches <ludovic.desroc...@microchip.com> --- drivers/input/misc/Kconfig | 12 + d

[PATCH v2 2/5] input: misc: introduce Atmel PTC driver

end to provide high level information as button touch or untouch, slider position, etc. - a configuration file that describe the topology and the parameters of the sensors. Signed-off-by: Ludovic Desroches --- drivers/input/misc/Kconfig | 12 + drivers/input/misc/Makefile| 1

[PATCH v2 5/5] ARM: at91/defconfig: add PTC driver to sama5_defconfig

Add Peripheral Touch Controller driver to sama5_defconfig. Signed-off-by: Ludovic Desroches <ludovic.desroc...@microchip.com> --- arch/arm/configs/sama5_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig

[PATCH v2 5/5] ARM: at91/defconfig: add PTC driver to sama5_defconfig

Add Peripheral Touch Controller driver to sama5_defconfig. Signed-off-by: Ludovic Desroches --- arch/arm/configs/sama5_defconfig | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig index 777c9e9..7480665 100644 --- a/arch/arm

[PATCH v2 4/5] ARM: dts: at91: sama5d2: add PTC subsystem device

Add the Atmel Peripheral Touch Controller subsystem. Signed-off-by: Ludovic Desroches <ludovic.desroc...@microchip.com> --- arch/arm/boot/dts/sama5d2.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi

[PATCH v2 4/5] ARM: dts: at91: sama5d2: add PTC subsystem device

Add the Atmel Peripheral Touch Controller subsystem. Signed-off-by: Ludovic Desroches --- arch/arm/boot/dts/sama5d2.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi index 8067c71..fa4ed56 100644 --- a/arch

[PATCH v2 0/5] Introduce the Atmel PTC subsystem

are loaded when probing the driver. Changes: - v2: - reorder patches to get the bindings documentation in first - remove the header from the uapi since it may change in the future. Declare only the few structures needed in the driver. - add this driver to the sama5_defconfig Ludovic Desroches (5

[PATCH v2 0/5] Introduce the Atmel PTC subsystem

are loaded when probing the driver. Changes: - v2: - reorder patches to get the bindings documentation in first - remove the header from the uapi since it may change in the future. Declare only the few structures needed in the driver. - add this driver to the sama5_defconfig Ludovic Desroches (5

[PATCH 2/2] ARM: dts: at91: sama5d3_xplained: not all ADC channels are available

Remove ADC channels that are not available by default on the sama5d3_xplained board (resistor not populated) in order to not create confusion. Signed-off-by: Ludovic Desroches <ludovic.desroc...@microchip.com> Cc: <sta...@vger.kernel.org> # 3.16+ --- arch/arm/boot/dts/at91-sama5d3_

[PATCH 1/2] ARM: dts: at91: sama5d3_xplained: fix ADC vref

The voltage reference for the ADC is not 3V but 3.3V since it is connected to VDDANA. Signed-off-by: Ludovic Desroches <ludovic.desroc...@microchip.com> Cc: <sta...@vger.kernel.org> # 3.16+ --- arch/arm/boot/dts/at91-sama5d3_xplained.dts | 1 + 1 file changed, 1 insertion(+) diff

[PATCH 2/2] ARM: dts: at91: sama5d3_xplained: not all ADC channels are available

Remove ADC channels that are not available by default on the sama5d3_xplained board (resistor not populated) in order to not create confusion. Signed-off-by: Ludovic Desroches Cc: # 3.16+ --- arch/arm/boot/dts/at91-sama5d3_xplained.dts | 4 +--- 1 file changed, 1 insertion(+), 3 deletions

[PATCH 1/2] ARM: dts: at91: sama5d3_xplained: fix ADC vref

The voltage reference for the ADC is not 3V but 3.3V since it is connected to VDDANA. Signed-off-by: Ludovic Desroches Cc: # 3.16+ --- arch/arm/boot/dts/at91-sama5d3_xplained.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/at91-sama5d3_xplained.dts b/arch/arm/boot

Re: [PATCH] pinctrl: at91-pio4: handle suspend to ram

up[i]); > + atmel_pioctrl->pm_suspend_backup[i].imr); > + atmel_gpio_write(atmel_pioctrl, i, ATMEL_PIO_SODR, > + atmel_pioctrl->pm_suspend_backup[i].odsr); I would also configure CODR to be sure to be in the same stat

Re: [PATCH] pinctrl: at91-pio4: handle suspend to ram

mel_pioctrl->pm_suspend_backup[i].imr); > + atmel_gpio_write(atmel_pioctrl, i, ATMEL_PIO_SODR, > + atmel_pioctrl->pm_suspend_backup[i].odsr); I would also configure CODR to be sure to be in the same state. Otherwise: Acked-by: Ludovic D

Re: [PATCH 4.4 42/76] mmc: sdhci: Do not disable interrupts while waiting for clock

On Tue, Apr 04, 2017 at 05:50:50PM +0100, Ben Hutchings wrote: > On Tue, 2017-03-28 at 14:30 +0200, Greg Kroah-Hartman wrote: > > 4.4-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Adrian Hunter > > > >

Re: [PATCH 4.4 42/76] mmc: sdhci: Do not disable interrupts while waiting for clock

On Tue, Apr 04, 2017 at 05:50:50PM +0100, Ben Hutchings wrote: > On Tue, 2017-03-28 at 14:30 +0200, Greg Kroah-Hartman wrote: > > 4.4-stable review patch. If anyone has any objections, please let me know. > > > > -- > > > > From: Adrian Hunter > > > > commit

Re: [PATCH 1/4] input: misc: introduce Atmel PTC driver

On Mon, Apr 03, 2017 at 05:58:40PM +0200, Alexandre Belloni wrote: > On 31/03/2017 at 17:22:47 +0200, Ludovic Desroches wrote: > > From: Ludovic Desroches <ludovic.desroc...@atmel.com> > > I think you probably want to switch to your microchip email. > > Also, th

Re: [PATCH 1/4] input: misc: introduce Atmel PTC driver

On Mon, Apr 03, 2017 at 05:58:40PM +0200, Alexandre Belloni wrote: > On 31/03/2017 at 17:22:47 +0200, Ludovic Desroches wrote: > > From: Ludovic Desroches > > I think you probably want to switch to your microchip email. > > Also, this requires a proper commit message. I'l

[PATCH 4/4] dt-bindings: input: Add Atmel PTC subsystem bindings

Add description of the Atmel PTC subsystem bindings. Signed-off-by: Ludovic Desroches <ludovic.desroc...@microchip.com> --- .../devicetree/bindings/input/atmel,ptc.txt| 67 ++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH 4/4] dt-bindings: input: Add Atmel PTC subsystem bindings

Add description of the Atmel PTC subsystem bindings. Signed-off-by: Ludovic Desroches --- .../devicetree/bindings/input/atmel,ptc.txt| 67 ++ 1 file changed, 67 insertions(+) create mode 100644 Documentation/devicetree/bindings/input/atmel,ptc.txt diff --git

[PATCH 0/4] Introduce the Atmel PTC subsystem

are loaded when probing the driver. Ludovic Desroches (4): input: misc: introduce Atmel PTC driver ARM: dts: at91: sama5d2: add PTC subsystem device MAINTAINERS: add Atmel PTC entries dt-bindings: input: Add Atmel PTC subsystem bindings .../devicetree/bindings/input/atmel,ptc.txt| 67

[PATCH 0/4] Introduce the Atmel PTC subsystem

are loaded when probing the driver. Ludovic Desroches (4): input: misc: introduce Atmel PTC driver ARM: dts: at91: sama5d2: add PTC subsystem device MAINTAINERS: add Atmel PTC entries dt-bindings: input: Add Atmel PTC subsystem bindings .../devicetree/bindings/input/atmel,ptc.txt| 67

[PATCH 2/4] ARM: dts: at91: sama5d2: add PTC subsystem device

From: Ludovic Desroches <ludovic.desroc...@atmel.com> Add the Atmel Peripheral Touch Controller subsystem. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/boot/dts/sama5d2.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/

[PATCH 1/4] input: misc: introduce Atmel PTC driver

From: Ludovic Desroches <ludovic.desroc...@atmel.com> Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/input/misc/Kconfig | 12 + drivers/input/misc/Makefile| 1 + drivers/input/misc/atmel_ptc.c | 651 +

[PATCH 3/4] MAINTAINERS: add Atmel PTC entries

Add entries for the Atmel PTC Subsystem. Signed-off-by: Ludovic Desroches <ludovic.desroc...@microchip.com> --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 57634d0..afb2645 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2292,6 +2

[PATCH 2/4] ARM: dts: at91: sama5d2: add PTC subsystem device

From: Ludovic Desroches Add the Atmel Peripheral Touch Controller subsystem. Signed-off-by: Ludovic Desroches --- arch/arm/boot/dts/sama5d2.dtsi | 16 1 file changed, 16 insertions(+) diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi index 468ef9c

[PATCH 1/4] input: misc: introduce Atmel PTC driver

From: Ludovic Desroches Signed-off-by: Ludovic Desroches --- drivers/input/misc/Kconfig | 12 + drivers/input/misc/Makefile| 1 + drivers/input/misc/atmel_ptc.c | 651 + include/uapi/linux/atmel_ptc.h | 355 ++ 4 files

[PATCH 3/4] MAINTAINERS: add Atmel PTC entries

Add entries for the Atmel PTC Subsystem. Signed-off-by: Ludovic Desroches --- MAINTAINERS | 7 +++ 1 file changed, 7 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 57634d0..afb2645 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2292,6 +2292,13 @@ F: Documentation

[PATCH] mmc: sdhci-of-at91: fix MMC_DDR_52 timing selection

The controller has different timings for MMC_TIMING_UHS_DDR50 and MMC_TIMING_MMC_DDR52. Configuring the controller with SDHCI_CTRL_UHS_DDR50, when MMC_TIMING_MMC_DDR52 timings are requested, is not correct and can lead to unexpected behavior. Signed-off-by: Ludovic Desroches <ludovic.des

[PATCH] mmc: sdhci-of-at91: fix MMC_DDR_52 timing selection

The controller has different timings for MMC_TIMING_UHS_DDR50 and MMC_TIMING_MMC_DDR52. Configuring the controller with SDHCI_CTRL_UHS_DDR50, when MMC_TIMING_MMC_DDR52 timings are requested, is not correct and can lead to unexpected behavior. Signed-off-by: Ludovic Desroches Fixes: bb5f8ea4d514

Re: [PATCH] mmc: sdhci-of-at91: Support external regulators

On Thu, Mar 09, 2017 at 04:18:20PM +0100, Romain Izard wrote: > The SDHCI controller in the SAMA5D2 chip requires a valid voltage set > in the power control register, otherwise commands will fail with a > timeout error. > > When using the regulator framework to specify the regulator used by the >

Re: [PATCH] mmc: sdhci-of-at91: Support external regulators

On Thu, Mar 09, 2017 at 04:18:20PM +0100, Romain Izard wrote: > The SDHCI controller in the SAMA5D2 chip requires a valid voltage set > in the power control register, otherwise commands will fail with a > timeout error. > > When using the regulator framework to specify the regulator used by the >

Re: [PATCH] mmc: sdhci-of-at91: Support external regulators

for this specific hardware, that configures the voltage in the register in all cases. I don't remember if the set_power ops was available at that time. If yes, I would have thought about it. IMO it's a nice solution. Signed-off-by: Romain Izard <romain.izard@gmail.com> Acked-by: L

Re: [PATCH] mmc: sdhci-of-at91: Support external regulators

for this specific hardware, that configures the voltage in the register in all cases. I don't remember if the set_power ops was available at that time. If yes, I would have thought about it. IMO it's a nice solution. Signed-off-by: Romain Izard Acked-by: Ludovic Desroches --- drivers/mmc

Re: [PATCH v2] i2c: at91: ensure state is restored after suspending

On Thu, Feb 16, 2017 at 06:27:59PM +0100, Alexandre Belloni wrote: > When going to suspend, the I2C registers may be lost because the power to > VDDcore is cut. Restore them when resuming. > > Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> Acked-by:

Re: [PATCH v2] i2c: at91: ensure state is restored after suspending

On Thu, Feb 16, 2017 at 06:27:59PM +0100, Alexandre Belloni wrote: > When going to suspend, the I2C registers may be lost because the power to > VDDcore is cut. Restore them when resuming. > > Signed-off-by: Alexandre Belloni Acked-by: Ludovic Desroches > --- > Changes in v2

Re: [PATCH] atmel_serial: Use the fractional divider when possible

s was tested with a board using an Atmel SAMA5D2 chip and a TI > WL1831 WiFi/Bluetooth combo chip at 3 Mbauds, with hardware flow control > enabled. > > Signed-off-by: Romain Izard <romain.izard@gmail.com> Acked-by: Ludovic Desroches <ludovic.desroc...@microchip.com>

Re: [PATCH] atmel_serial: Use the fractional divider when possible

s was tested with a board using an Atmel SAMA5D2 chip and a TI > WL1831 WiFi/Bluetooth combo chip at 3 Mbauds, with hardware flow control > enabled. > > Signed-off-by: Romain Izard Acked-by: Ludovic Desroches Thanks > --- > drivers/tty/serial/atmel_serial.c | 7 ---

Re: Fractional divider on the Atmel USART controller

On Mon, Feb 06, 2017 at 04:37:23PM +0100, Ludovic Desroches wrote: > On Mon, Feb 06, 2017 at 03:58:52PM +0100, Richard Genoud wrote: > > Hi Ludovic, > > > > On 06/02/2017 14:42, Ludovic Desroches wrote: > > > Hello Romain, > > > > > > On Mon, Feb

Re: Fractional divider on the Atmel USART controller

On Mon, Feb 06, 2017 at 04:37:23PM +0100, Ludovic Desroches wrote: > On Mon, Feb 06, 2017 at 03:58:52PM +0100, Richard Genoud wrote: > > Hi Ludovic, > > > > On 06/02/2017 14:42, Ludovic Desroches wrote: > > > Hello Romain, > > > > > > On Mon, Feb

Re: [PATCH] i2c: busses: constify i2c_algorithm structures

83349 d15 drivers/i2c/busses/i2c-xlp9xx.o >2797 544 83349 d15 drivers/i2c/busses/i2c-xlp9xx.o > >2643 248 82899 b53 drivers/i2c/busses/i2c-xlr.o >2707 192 82907 b5b drivers/i2c/busses/i2c-xlr.o > > Signed-off-by: Bhumika Goyal <bhumi...@gmail.com> > --- > drivers/i2c/busses/i2c-at91.c| 2 +- Acked-by: Ludovic Desroches <ludovic.desroc...@microchip.com> Regards Ludovic

Re: [PATCH] i2c: busses: constify i2c_algorithm structures

83349 d15 drivers/i2c/busses/i2c-xlp9xx.o >2797 544 83349 d15 drivers/i2c/busses/i2c-xlp9xx.o > >2643 248 82899 b53 drivers/i2c/busses/i2c-xlr.o >2707 192 82907 b5b drivers/i2c/busses/i2c-xlr.o > > Signed-off-by: Bhumika Goyal > --- > drivers/i2c/busses/i2c-at91.c| 2 +- Acked-by: Ludovic Desroches Regards Ludovic

Re: Fractional divider on the Atmel USART controller

On Mon, Feb 06, 2017 at 03:58:52PM +0100, Richard Genoud wrote: > Hi Ludovic, > > On 06/02/2017 14:42, Ludovic Desroches wrote: > > Hello Romain, > > > > On Mon, Feb 06, 2017 at 12:56:42PM +0100, Romain Izard wrote: > >> Hello, > >> > >> On

Re: Fractional divider on the Atmel USART controller

On Mon, Feb 06, 2017 at 03:58:52PM +0100, Richard Genoud wrote: > Hi Ludovic, > > On 06/02/2017 14:42, Ludovic Desroches wrote: > > Hello Romain, > > > > On Mon, Feb 06, 2017 at 12:56:42PM +0100, Romain Izard wrote: > >> Hello, > >> > >> On

Re: [PATCH] i2c: at91: ensure state is restored after suspending

Hi, I add Cyrille for FIFO part. On Mon, Jan 30, 2017 at 06:25:33PM +0100, Alexandre Belloni wrote: > When going to suspend, the I2C registers may be lost because the power to > VDDcore is cut. Save them and restore them when resuming. > > Signed-off-by: Alexandre Belloni

Re: [PATCH] i2c: at91: ensure state is restored after suspending

Hi, I add Cyrille for FIFO part. On Mon, Jan 30, 2017 at 06:25:33PM +0100, Alexandre Belloni wrote: > When going to suspend, the I2C registers may be lost because the power to > VDDcore is cut. Save them and restore them when resuming. > > Signed-off-by: Alexandre Belloni > --- >

Re: Fractional divider on the Atmel USART controller

Hello Romain, On Mon, Feb 06, 2017 at 12:56:42PM +0100, Romain Izard wrote: > Hello, > > On Atmel SAMA5D2, when trying to configure a serial port for 3 Mbauds > operation, I do not always get the requested baud rate. If the hardware > flow control is disabled by software, the line works

Re: Fractional divider on the Atmel USART controller

Hello Romain, On Mon, Feb 06, 2017 at 12:56:42PM +0100, Romain Izard wrote: > Hello, > > On Atmel SAMA5D2, when trying to configure a serial port for 3 Mbauds > operation, I do not always get the requested baud rate. If the hardware > flow control is disabled by software, the line works

Re: [PATCH linux-next 1/1] usb: gadget: udc: atmel: Update endpoint allocation scheme

Hi Cristian, Minor comments about syntax otherwise Reviewed-by: Ludovic Desroches <ludovic.desroc...@microchip.com> On Fri, Jan 20, 2017 at 05:40:59PM +0200, cristian.bir...@microchip.com wrote: > From: Cristian Birsan <cristian.bir...@microchip.com> > > Update atmel

Re: [PATCH linux-next 1/1] usb: gadget: udc: atmel: Update endpoint allocation scheme

Hi Cristian, Minor comments about syntax otherwise Reviewed-by: Ludovic Desroches On Fri, Jan 20, 2017 at 05:40:59PM +0200, cristian.bir...@microchip.com wrote: > From: Cristian Birsan > > Update atmel udc driver with a new enpoint allocation scheme. The data > sheet requi

Re: [PATCH] mmc: sdhci-of-at91: remove bogus MMC_SDHCI_IO_ACCESSORS select

On Thu, Dec 01, 2016 at 01:05:46PM +0900, Masahiro Yamada wrote: > I see no override of read/write callbacks in sdhci-of-at91.c. > > Signed-off-by: Masahiro Yamada <yamada.masah...@socionext.com> Acked-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Thanks > --- &

Re: [PATCH] mmc: sdhci-of-at91: remove bogus MMC_SDHCI_IO_ACCESSORS select

On Thu, Dec 01, 2016 at 01:05:46PM +0900, Masahiro Yamada wrote: > I see no override of read/write callbacks in sdhci-of-at91.c. > > Signed-off-by: Masahiro Yamada Acked-by: Ludovic Desroches Thanks > --- > > BTW, this config may not be so useful in recent multi-pl

Re: [PATCH] dmaengine: at_xdmac: don't restore unsaved status

function. > > Signed-off-by: Alexandre Belloni <alexandre.bell...@free-electrons.com> Acked-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Thanks > --- > drivers/dma/at_xdmac.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/dma/at_xdmac.c b/d

Re: [PATCH] dmaengine: at_xdmac: don't restore unsaved status

function. > > Signed-off-by: Alexandre Belloni Acked-by: Ludovic Desroches Thanks > --- > drivers/dma/at_xdmac.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c > index b7d7f2d443a1..8c1abb794340 100644 > --- a/dr

Re: [PATCH v2] iio: adc: at91: add suspend and resume callback

On Wed, Nov 02, 2016 at 05:21:48PM +0800, Wenyou Yang wrote: > Add suspend/resume callback, support the pinctrl sleep state when > the system suspend as well. > > Signed-off-by: Wenyou Yang <wenyou.y...@atmel.com> Acked-by: Ludovic Desroches <ludovic.desroc.

Re: [PATCH v2] iio: adc: at91: add suspend and resume callback

On Wed, Nov 02, 2016 at 05:21:48PM +0800, Wenyou Yang wrote: > Add suspend/resume callback, support the pinctrl sleep state when > the system suspend as well. > > Signed-off-by: Wenyou Yang Acked-by: Ludovic Desroches Thanks > --- > > Changes in v2: > - Use C

Re: [PATCH v1] iio: adc: at91: add suspend and resume callback

On Wed, Nov 02, 2016 at 10:40:16AM +0800, Wenyou Yang wrote: > Add suspend/resume callback, support the pinctrl sleep state when > the system suspend as well. > > Signed-off-by: Wenyou Yang > --- > > drivers/iio/adc/at91_adc.c | 35 +++ >

Re: [PATCH v1] iio: adc: at91: add suspend and resume callback

On Wed, Nov 02, 2016 at 10:40:16AM +0800, Wenyou Yang wrote: > Add suspend/resume callback, support the pinctrl sleep state when > the system suspend as well. > > Signed-off-by: Wenyou Yang > --- > > drivers/iio/adc/at91_adc.c | 35 +++ > 1 file changed, 35

Re: [PATCH 2/2] mmc: sdhci-of-at91: Fix module autoload

tmel,sama5d2-sdhciC* > alias: of:N*T*Catmel,sama5d2-sdhci > > Signed-off-by: Javier Martinez Canillas <jav...@osg.samsung.com> Acked-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Thanks > --- > > drivers/mmc/host/sdhci-of-at91.c | 1 + > 1 file c

Re: [PATCH 2/2] mmc: sdhci-of-at91: Fix module autoload

tmel,sama5d2-sdhciC* > alias: of:N*T*Catmel,sama5d2-sdhci > > Signed-off-by: Javier Martinez Canillas Acked-by: Ludovic Desroches Thanks > --- > > drivers/mmc/host/sdhci-of-at91.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mmc/host/sd

[PATCH] tty/serial: atmel: add fractional baud rate support

The USART device provides a fractional baud rate generator to get a more accurate baud rate. It can be used only when the USART is configured in 'normal mode' and this feature is not available on AT91RM9200 SoC. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drive

[PATCH] tty/serial: atmel: add fractional baud rate support

The USART device provides a fractional baud rate generator to get a more accurate baud rate. It can be used only when the USART is configured in 'normal mode' and this feature is not available on AT91RM9200 SoC. Signed-off-by: Ludovic Desroches --- drivers/tty/serial/atmel_serial.c | 41

Re: [PATCH] i2c: don't print error when adding adapter fails

On Tue, Aug 09, 2016 at 01:36:17PM +0200, Wolfram Sang wrote: > The core will do this for us now. > > Signed-off-by: Wolfram Sang <wsa-...@sang-engineering.com> > --- [...] > drivers/i2c/busses/i2c-at91.c | 2 -- Acked-by: Ludovic Desroches <lud

Re: [PATCH] i2c: don't print error when adding adapter fails

On Tue, Aug 09, 2016 at 01:36:17PM +0200, Wolfram Sang wrote: > The core will do this for us now. > > Signed-off-by: Wolfram Sang > --- [...] > drivers/i2c/busses/i2c-at91.c | 2 -- Acked-by: Ludovic Desroches [...] > diff --git a/drivers/i2c/busses/i2c-at

[PATCH] i2c: at91: fix support of the "alternative command" feature

Pitchen <cyrille.pitc...@atmel.com> Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/i2c/busses/i2c-at91.c | 24 ++-- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c index

[PATCH] i2c: at91: fix support of the "alternative command" feature

o 255 bytes can take advantage of the "alternative command" feature. For greater data transfer sizes, the driver should use the previous implementation, when the "alternative command" support was not implemented yet. Signed-off-by: Cyrille Pitchen Signed-off-by: Ludovic Desro

Re: at_xdmac: txd used outside spinlock after being released?

Hi Brent, On Tue, Jul 19, 2016 at 10:58:40PM -0500, Brent Taylor wrote: > Hi Ludovic, >I'm learning about the dmaengine subsystem and I was using the > at_xdmac as a reference.I'm not real familiar with tasklets > because I have used threaded interrupt handlers instead of them. >I

Re: at_xdmac: txd used outside spinlock after being released?

Hi Brent, On Tue, Jul 19, 2016 at 10:58:40PM -0500, Brent Taylor wrote: > Hi Ludovic, >I'm learning about the dmaengine subsystem and I was using the > at_xdmac as a reference.I'm not real familiar with tasklets > because I have used threaded interrupt handlers instead of them. >I

Re: [PATCH 9/9] pinctrl: at91-pio4: make it explicitly non-modular

TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Ludovic Desroches <ludovic.desroc...@atmel.com> > Cc: Linus Walleij <linus.wall...@li

Re: [PATCH 9/9] pinctrl: at91-pio4: make it explicitly non-modular

TABLE is a no-op for non-modular code. > > We also delete the MODULE_LICENSE tag etc. since all that information > is already contained at the top of the file in the comments. > > Cc: Ludovic Desroches > Cc: Linus Walleij > Cc: linux-g...@vger.kernel.org > Signed-of

<    1   2   3   4   5   6   7   8   9   10   >