Re: [PATCH v2] mmc: sdhci: fix wakeup configuration

2016-05-26 Thread Ludovic Desroches
On Fri, May 20, 2016 at 09:28:56PM +0300, Adrian Hunter wrote: > On 20/05/2016 4:39 p.m., Ulf Hansson wrote: > > On 20 May 2016 at 13:46, Adrian Hunter <adrian.hun...@intel.com> wrote: > > > On 13/05/16 16:16, Ludovic Desroches wrote: > > > > Activating wakeup

Re: [PATCH v2] mmc: sdhci: fix wakeup configuration

2016-05-26 Thread Ludovic Desroches
On Fri, May 20, 2016 at 09:28:56PM +0300, Adrian Hunter wrote: > On 20/05/2016 4:39 p.m., Ulf Hansson wrote: > > On 20 May 2016 at 13:46, Adrian Hunter wrote: > > > On 13/05/16 16:16, Ludovic Desroches wrote: > > > > Activating wakeup event is not

[PATCH v3] i2c: at91: change log when dma configuration fails

2016-05-20 Thread Ludovic Desroches
but it doesn't prevent to use i2c. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/i2c/busses/i2c-at91.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Douglas, sorry but I can't answer you directly, your email address is blacklisted on our server. Changes: - v3:

[PATCH v3] i2c: at91: change log when dma configuration fails

2016-05-20 Thread Ludovic Desroches
but it doesn't prevent to use i2c. Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/i2c-at91.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Douglas, sorry but I can't answer you directly, your email address is blacklisted on our server. Changes: - v3: - s/request/get (comment done

Re: [RESEND PATCH] mmc: sdhci: fix wakeup configuration

2016-05-13 Thread Ludovic Desroches
Mistake while sending v2, sorry for the noise. On Fri, May 13, 2016 at 03:14:46PM +0200, Ludovic Desroches wrote: > Activating wakeup event is not enough to get a wakeup signal. The > corresponding events have to be enabled in the Interrupt Status Enable > Register too. >

Re: [RESEND PATCH] mmc: sdhci: fix wakeup configuration

2016-05-13 Thread Ludovic Desroches
Mistake while sending v2, sorry for the noise. On Fri, May 13, 2016 at 03:14:46PM +0200, Ludovic Desroches wrote: > Activating wakeup event is not enough to get a wakeup signal. The > corresponding events have to be enabled in the Interrupt Status Enable > Register too. >

[PATCH v2] mmc: sdhci: fix wakeup configuration

2016-05-13 Thread Ludovic Desroches
Activating wakeup event is not enough to get a wakeup signal. The corresponding events have to be enabled in the Interrupt Status Enable Register too. It follows the specification and is needed at least by sdhci-of-at91. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- d

[PATCH v2] mmc: sdhci: fix wakeup configuration

2016-05-13 Thread Ludovic Desroches
Activating wakeup event is not enough to get a wakeup signal. The corresponding events have to be enabled in the Interrupt Status Enable Register too. It follows the specification and is needed at least by sdhci-of-at91. Signed-off-by: Ludovic Desroches --- drivers/mmc/host/sdhci.c | 15

[RESEND PATCH] mmc: sdhci: fix wakeup configuration

2016-05-13 Thread Ludovic Desroches
Activating wakeup event is not enough to get a wakeup signal. The corresponding events have to be enabled in the Interrupt Status Enable Register too. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- Hi, I just updated sdhci_enable_irq_wakeups() not sdhci_disable_irq_w

[RESEND PATCH] mmc: sdhci: fix wakeup configuration

2016-05-13 Thread Ludovic Desroches
Activating wakeup event is not enough to get a wakeup signal. The corresponding events have to be enabled in the Interrupt Status Enable Register too. Signed-off-by: Ludovic Desroches --- Hi, I just updated sdhci_enable_irq_wakeups() not sdhci_disable_irq_wakeups() because I don't think

[PATCH v2] i2c: at91: change log when dma configuration fails

2016-05-13 Thread Ludovic Desroches
but it doesn't prevent to use i2c. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/i2c/busses/i2c-at91.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Changes: - v2: - remove ret parameter diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c

[PATCH v2] i2c: at91: change log when dma configuration fails

2016-05-13 Thread Ludovic Desroches
but it doesn't prevent to use i2c. Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/i2c-at91.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) Changes: - v2: - remove ret parameter diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c index 921d32b..6384d08 100644

Re: [RESEND PATCH] mmc: sdhci: fix wakeup configuration

2016-05-13 Thread Ludovic Desroches
On Fri, May 13, 2016 at 02:37:21PM +0300, Adrian Hunter wrote: > + cc some Marvell people because they added this code > > On 13/05/16 12:27, Ludovic Desroches wrote: > > Activating wakeup event is not enough to get a wakeup signal. The > > corresponding events have to be ena

Re: [RESEND PATCH] mmc: sdhci: fix wakeup configuration

2016-05-13 Thread Ludovic Desroches
On Fri, May 13, 2016 at 02:37:21PM +0300, Adrian Hunter wrote: > + cc some Marvell people because they added this code > > On 13/05/16 12:27, Ludovic Desroches wrote: > > Activating wakeup event is not enough to get a wakeup signal. The > > corresponding events have to be ena

[RESEND PATCH] mmc: sdhci: fix wakeup configuration

2016-05-13 Thread Ludovic Desroches
Activating wakeup event is not enough to get a wakeup signal. The corresponding events have to be enabled in the Interrupt Status Enable Register too. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- Hi, I just updated sdhci_enable_irq_wakeups() not sdhci_disable_irq_w

[RESEND PATCH] mmc: sdhci: fix wakeup configuration

2016-05-13 Thread Ludovic Desroches
Activating wakeup event is not enough to get a wakeup signal. The corresponding events have to be enabled in the Interrupt Status Enable Register too. Signed-off-by: Ludovic Desroches --- Hi, I just updated sdhci_enable_irq_wakeups() not sdhci_disable_irq_wakeups() because I don't think

[PATCH] i2c: at91: change log when dma configuration fails

2016-05-13 Thread Ludovic Desroches
but it doesn't prevent to use i2c. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/i2c/busses/i2c-at91.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c index 921d32b..f2a7457 100644 --- a/d

[PATCH] i2c: at91: change log when dma configuration fails

2016-05-13 Thread Ludovic Desroches
but it doesn't prevent to use i2c. Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/i2c-at91.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c index 921d32b..f2a7457 100644 --- a/drivers/i2c/busses/i2c-at91.c +++ b

[PATCH 3/3] tty/serial: atmel: add comment for the ring buffer size macro

2016-05-12 Thread Ludovic Desroches
There is a macro named ATMEL_SERIAL_RINGSIZE which suggesting that it corresponds to the real size of the ring buffer. Let warn people that there is a factor of four since allocation size is sizeof(struct atmel_uart_char) * ATMEL_SERIAL_RINGSIZE. Signed-off-by: Ludovic Desroches <ludovic.des

[PATCH 3/3] tty/serial: atmel: add comment for the ring buffer size macro

2016-05-12 Thread Ludovic Desroches
There is a macro named ATMEL_SERIAL_RINGSIZE which suggesting that it corresponds to the real size of the ring buffer. Let warn people that there is a factor of four since allocation size is sizeof(struct atmel_uart_char) * ATMEL_SERIAL_RINGSIZE. Signed-off-by: Ludovic Desroches --- drivers/tty

[PATCH 2/3] tty/serial: atmel: split tx and rx paths

2016-05-12 Thread Ludovic Desroches
From: Nicolas Ferre <nicolas.fe...@atmel.com> Split TX and RX paths to not schedule RX tasklet on TX events and vice versa. Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com> Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/tty/serial/a

[PATCH 2/3] tty/serial: atmel: split tx and rx paths

2016-05-12 Thread Ludovic Desroches
From: Nicolas Ferre Split TX and RX paths to not schedule RX tasklet on TX events and vice versa. Signed-off-by: Nicolas Ferre Signed-off-by: Ludovic Desroches --- drivers/tty/serial/atmel_serial.c | 53 +-- 1 file changed, 34 insertions(+), 19 deletions

[PATCH 1/3] tty/serial: atmel: re-integrate status check in irq handler

2016-05-12 Thread Ludovic Desroches
ctions. Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com> Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/tty/serial/atmel_serial.c | 43 --- 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/drivers/tty/serial

[PATCH 1/3] tty/serial: atmel: re-integrate status check in irq handler

2016-05-12 Thread Ludovic Desroches
Signed-off-by: Ludovic Desroches --- drivers/tty/serial/atmel_serial.c | 43 --- 1 file changed, 17 insertions(+), 26 deletions(-) diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c index 954941d..8854ac6 100644 --- a/drivers

[PATCH 2/3] dmaengine: at_xdmac: fix residue corruption

2016-05-12 Thread Ludovic Desroches
An unexpected value of CUBC can lead to a corrupted residue. A more complex sequence is needed to detect an inaccurate value for NCA or CUBC. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Fixes: e1f7c9eee707 ("dmaengine: at_xdmac: creation of the atmel eXtended DMA

[PATCH 3/3] dmaengine: at_xdmac: double FIFO flush needed to compute residue

2016-05-12 Thread Ludovic Desroches
Due to the way CUBC register is updated, a double flush is needed to compute an accurate residue. First flush aim is to get data from the DMA FIFO and second one ensures that we won't report data which are not in memory. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com>

[PATCH 2/3] dmaengine: at_xdmac: fix residue corruption

2016-05-12 Thread Ludovic Desroches
An unexpected value of CUBC can lead to a corrupted residue. A more complex sequence is needed to detect an inaccurate value for NCA or CUBC. Signed-off-by: Ludovic Desroches Fixes: e1f7c9eee707 ("dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver"

[PATCH 3/3] dmaengine: at_xdmac: double FIFO flush needed to compute residue

2016-05-12 Thread Ludovic Desroches
Due to the way CUBC register is updated, a double flush is needed to compute an accurate residue. First flush aim is to get data from the DMA FIFO and second one ensures that we won't report data which are not in memory. Signed-off-by: Ludovic Desroches Fixes: e1f7c9eee707 ("dmaengine: at_

[PATCH 1/3] dmaengine: at_xdmac: align descriptors on 64 bits

2016-05-12 Thread Ludovic Desroches
Having descriptors aligned on 64 bits allows update CNDA and CUBC in an atomic way. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Fixes: e1f7c9eee707 ("dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver") Cc: sta...@vger.kernel.org

[PATCH 1/3] dmaengine: at_xdmac: align descriptors on 64 bits

2016-05-12 Thread Ludovic Desroches
Having descriptors aligned on 64 bits allows update CNDA and CUBC in an atomic way. Signed-off-by: Ludovic Desroches Fixes: e1f7c9eee707 ("dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver") Cc: sta...@vger.kernel.org #v4.1 and later --- drivers/dma/at_x

[PATCH v2] mmc: sdhci-of-at91: add presets setup

2016-04-28 Thread Ludovic Desroches
-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- Changes: - v2: - use a define for preset_common since it's a constant drivers/mmc/host/sdhci-of-at91.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mm

[PATCH v2] mmc: sdhci-of-at91: add presets setup

2016-04-28 Thread Ludovic Desroches
-by: Ludovic Desroches --- Changes: - v2: - use a define for preset_common since it's a constant drivers/mmc/host/sdhci-of-at91.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c index c1923c0

Re: [PATCH] mmc: sdhci-of-at91: add presets setup

2016-04-28 Thread Ludovic Desroches
On Thu, Apr 28, 2016 at 11:32:50AM +0300, Adrian Hunter wrote: > On 21/04/16 16:54, Ludovic Desroches wrote: > > The controller claims to support SDR104. In fact, it only supports a > > degraded SDR104 since the maximum frequency of the SD clock is 120 MHz > > instead of 2

Re: [PATCH] mmc: sdhci-of-at91: add presets setup

2016-04-28 Thread Ludovic Desroches
On Thu, Apr 28, 2016 at 11:32:50AM +0300, Adrian Hunter wrote: > On 21/04/16 16:54, Ludovic Desroches wrote: > > The controller claims to support SDR104. In fact, it only supports a > > degraded SDR104 since the maximum frequency of the SD clock is 120 MHz > > instead of 2

Re: [PATCH v3] mmc: sdhci-pci: add Support of Synopsys DWC_MSHC IP

2016-04-26 Thread Ludovic Desroches
On Tue, Apr 26, 2016 at 12:31:50PM +, Prabu Thangamuthu wrote: > Hi Ludovic, Jaehoon Chung, > > Thank you for your review comments, > > On 04/26/2016 04:15 PM, Jaehoon Chung wrote: > > > > On 04/26/2016 05:58 PM, Ludovic Desroches wrote: > > > On Wed, Apr

Re: [PATCH v3] mmc: sdhci-pci: add Support of Synopsys DWC_MSHC IP

2016-04-26 Thread Ludovic Desroches
On Tue, Apr 26, 2016 at 12:31:50PM +, Prabu Thangamuthu wrote: > Hi Ludovic, Jaehoon Chung, > > Thank you for your review comments, > > On 04/26/2016 04:15 PM, Jaehoon Chung wrote: > > > > On 04/26/2016 05:58 PM, Ludovic Desroches wrote: > > > On Wed, Apr

Re: [PATCH v3] mmc: sdhci-pci: add Support of Synopsys DWC_MSHC IP

2016-04-26 Thread Ludovic Desroches
On Tue, Apr 26, 2016 at 10:58:45AM +0200, Ludovic Desroches wrote: > On Wed, Apr 20, 2016 at 12:22:59PM +, Prabu Thangamuthu wrote: > > Patch for Standard SD Host Controller Interface compliant Synopsys > > sdhci-dwc controller driver. This code supports PCI based interface.

Re: [PATCH v3] mmc: sdhci-pci: add Support of Synopsys DWC_MSHC IP

2016-04-26 Thread Ludovic Desroches
On Tue, Apr 26, 2016 at 10:58:45AM +0200, Ludovic Desroches wrote: > On Wed, Apr 20, 2016 at 12:22:59PM +, Prabu Thangamuthu wrote: > > Patch for Standard SD Host Controller Interface compliant Synopsys > > sdhci-dwc controller driver. This code supports PCI based interface.

Re: [PATCH v3] mmc: sdhci-pci: add Support of Synopsys DWC_MSHC IP

2016-04-26 Thread Ludovic Desroches
On Wed, Apr 20, 2016 at 12:22:59PM +, Prabu Thangamuthu wrote: > Patch for Standard SD Host Controller Interface compliant Synopsys > sdhci-dwc controller driver. This code supports PCI based interface. > > Signed-off-by: Prabu Thangamuthu > --- > Change log v3: >

Re: [PATCH v3] mmc: sdhci-pci: add Support of Synopsys DWC_MSHC IP

2016-04-26 Thread Ludovic Desroches
On Wed, Apr 20, 2016 at 12:22:59PM +, Prabu Thangamuthu wrote: > Patch for Standard SD Host Controller Interface compliant Synopsys > sdhci-dwc controller driver. This code supports PCI based interface. > > Signed-off-by: Prabu Thangamuthu > --- > Change log v3: > -Removed unused code.

[PATCH] mmc: sdhci: fix wakeup configuration

2016-04-25 Thread Ludovic Desroches
Activating wakeup event is not enough to get a wakeup signal. The corresponding events have to be enabled in the Interrupt Status Enable Register too. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- Hi, I just updated sdhci_enable_irq_wakeups() not sdhci_disable_irq_w

[PATCH] mmc: sdhci: fix wakeup configuration

2016-04-25 Thread Ludovic Desroches
Activating wakeup event is not enough to get a wakeup signal. The corresponding events have to be enabled in the Interrupt Status Enable Register too. Signed-off-by: Ludovic Desroches --- Hi, I just updated sdhci_enable_irq_wakeups() not sdhci_disable_irq_wakeups() because I don't think

[PATCH] mmc: sdhci-of-at91: add presets setup

2016-04-21 Thread Ludovic Desroches
-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/mmc/host/sdhci-of-at91.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c index c1923c0..76308b1 100644 --- a/drivers/mmc/host

[PATCH] mmc: sdhci-of-at91: add presets setup

2016-04-21 Thread Ludovic Desroches
-by: Ludovic Desroches --- drivers/mmc/host/sdhci-of-at91.c | 24 1 file changed, 24 insertions(+) diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c index c1923c0..76308b1 100644 --- a/drivers/mmc/host/sdhci-of-at91.c +++ b/drivers/mmc/host

[PATCH] pinctrl: at91-pio4: fix pull-up/down logic

2016-04-19 Thread Ludovic Desroches
. This was leading to a pull-down condition not taken into account for instance. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Fixes: 776180848b57 ("pinctrl: introduce driver for Atmel PIO4 controller") Cc: sta...@vger.kernel.org #v4.4 and later --- drivers/pinctrl/pin

[PATCH] pinctrl: at91-pio4: fix pull-up/down logic

2016-04-19 Thread Ludovic Desroches
. This was leading to a pull-down condition not taken into account for instance. Signed-off-by: Ludovic Desroches Fixes: 776180848b57 ("pinctrl: introduce driver for Atmel PIO4 controller") Cc: sta...@vger.kernel.org #v4.4 and later --- drivers/pinctrl/pinctrl-at91-pio4.c | 2 ++ 1 file

Re: [PATCH v2] mmc: sdhci-pci: add Support of Synopsys DWC_MSHC IP

2016-04-19 Thread Ludovic Desroches
Hi Prabu, On Tue, Apr 19, 2016 at 07:18:36AM +, Prabu Thangamuthu wrote: > Synopsys DWC_MSHC is compliant with SD Host Specifications. This patch > is to support DWC_MSHC controller on PCI interface. > > Signed-off-by: Prabu Thangamuthu > --- > Change log v2: >

Re: [PATCH v2] mmc: sdhci-pci: add Support of Synopsys DWC_MSHC IP

2016-04-19 Thread Ludovic Desroches
Hi Prabu, On Tue, Apr 19, 2016 at 07:18:36AM +, Prabu Thangamuthu wrote: > Synopsys DWC_MSHC is compliant with SD Host Specifications. This patch > is to support DWC_MSHC controller on PCI interface. > > Signed-off-by: Prabu Thangamuthu > --- > Change log v2: > -Removed Synopsys

Re: [PATCH 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver

2016-04-15 Thread Ludovic Desroches
+ linux-me...@vger.kernel.org On Wed, Apr 13, 2016 at 03:44:20PM +0800, Songjun Wu wrote: > DT binding documentation for ISC driver. > > Signed-off-by: Songjun Wu > --- > > .../devicetree/bindings/media/atmel-isc.txt| 84 > ++ > 1 file

Re: [PATCH 2/2] [media] atmel-isc: DT binding for Image Sensor Controller driver

2016-04-15 Thread Ludovic Desroches
+ linux-me...@vger.kernel.org On Wed, Apr 13, 2016 at 03:44:20PM +0800, Songjun Wu wrote: > DT binding documentation for ISC driver. > > Signed-off-by: Songjun Wu > --- > > .../devicetree/bindings/media/atmel-isc.txt| 84 > ++ > 1 file changed, 84 insertions(+) >

Re: [PATCH v3 1/3] mmc: sdhci: introduce sdhci_compute_clock_config

2016-04-12 Thread Ludovic Desroches
On Tue, Apr 12, 2016 at 02:59:15PM +0200, Ulf Hansson wrote: > On 12 April 2016 at 14:53, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > On Tue, Apr 12, 2016 at 03:31:46PM +0300, Adrian Hunter wrote: > >> On 07/04/16 12:13, Ludovic Desroches wrote

Re: [PATCH v3 1/3] mmc: sdhci: introduce sdhci_compute_clock_config

2016-04-12 Thread Ludovic Desroches
On Tue, Apr 12, 2016 at 02:59:15PM +0200, Ulf Hansson wrote: > On 12 April 2016 at 14:53, Ludovic Desroches > wrote: > > On Tue, Apr 12, 2016 at 03:31:46PM +0300, Adrian Hunter wrote: > >> On 07/04/16 12:13, Ludovic Desroches wrote: >

Re: [PATCH v3 1/3] mmc: sdhci: introduce sdhci_compute_clock_config

2016-04-12 Thread Ludovic Desroches
On Tue, Apr 12, 2016 at 03:31:46PM +0300, Adrian Hunter wrote: > On 07/04/16 12:13, Ludovic Desroches wrote: > > In order to remove the SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST and to > > reduce code duplication, put the code relative to the SD clock > > configuration in

Re: [PATCH v3 1/3] mmc: sdhci: introduce sdhci_compute_clock_config

2016-04-12 Thread Ludovic Desroches
On Tue, Apr 12, 2016 at 03:31:46PM +0300, Adrian Hunter wrote: > On 07/04/16 12:13, Ludovic Desroches wrote: > > In order to remove the SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST and to > > reduce code duplication, put the code relative to the SD clock > > configuration in

Re: [PATCH] sdhci: wakeup from runtime PM

2016-04-07 Thread Ludovic Desroches
On Thu, Apr 07, 2016 at 11:11:08AM +0200, Ulf Hansson wrote: > On 5 April 2016 at 14:40, Adrian Hunter <adrian.hun...@intel.com> wrote: > > On 25/03/16 18:05, Ludovic Desroches wrote: > >> Hi, > >> > >> When not using the SDHCI controller, it is

Re: [PATCH] sdhci: wakeup from runtime PM

2016-04-07 Thread Ludovic Desroches
On Thu, Apr 07, 2016 at 11:11:08AM +0200, Ulf Hansson wrote: > On 5 April 2016 at 14:40, Adrian Hunter wrote: > > On 25/03/16 18:05, Ludovic Desroches wrote: > >> Hi, > >> > >> When not using the SDHCI controller, it is logical to save power by > >>

[PATCH v3 1/3] mmc: sdhci: introduce sdhci_compute_clock_config

2016-04-07 Thread Ludovic Desroches
In order to remove the SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST and to reduce code duplication, put the code relative to the SD clock configuration in a function which can be used by hosts for the implementation of the set_clock() callback. Signed-off-by: Ludovic Desroches <ludovic.des

[PATCH v3 1/3] mmc: sdhci: introduce sdhci_compute_clock_config

2016-04-07 Thread Ludovic Desroches
In order to remove the SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST and to reduce code duplication, put the code relative to the SD clock configuration in a function which can be used by hosts for the implementation of the set_clock() callback. Signed-off-by: Ludovic Desroches --- drivers/mmc/host

[PATCH v3 3/3] mmc: sdhci: removal of SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST

2016-04-07 Thread Ludovic Desroches
SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST quirk is not used anymore so remove it. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/mmc/host/sdhci.c | 2 -- drivers/mmc/host/sdhci.h | 5 - 2 files changed, 7 deletions(-) diff --git a/drivers/mmc/host/sdh

[PATCH v3 2/3] mmc: sdhci-of-at91: implement specific set_clock function

2016-04-07 Thread Ludovic Desroches
internal re-synchronisation but it seems in some cases the delay (even if longer) doesn't fix this bug. The safest workaround is to not disable/enable the internal clock during the SD card clock configuration. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/mm

[PATCH v3 3/3] mmc: sdhci: removal of SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST

2016-04-07 Thread Ludovic Desroches
SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST quirk is not used anymore so remove it. Signed-off-by: Ludovic Desroches --- drivers/mmc/host/sdhci.c | 2 -- drivers/mmc/host/sdhci.h | 5 - 2 files changed, 7 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index

[PATCH v3 2/3] mmc: sdhci-of-at91: implement specific set_clock function

2016-04-07 Thread Ludovic Desroches
internal re-synchronisation but it seems in some cases the delay (even if longer) doesn't fix this bug. The safest workaround is to not disable/enable the internal clock during the SD card clock configuration. Signed-off-by: Ludovic Desroches --- drivers/mmc/host/sdhci-of-at91.c | 48

[PATCH v3 0/3] SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST removal

2016-04-07 Thread Ludovic Desroches
. - don't update actual_clock in sdhci_calc_clk but return its value as an output parameter. - v2: - sdhci_compute_clock_config uses a returned value instead of an out-parameter to provide the clock configuration. Ludovic Desroches (3): mmc: sdhci: introduce sdhci_compute_clock_config mmc

[PATCH v3 0/3] SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST removal

2016-04-07 Thread Ludovic Desroches
. - don't update actual_clock in sdhci_calc_clk but return its value as an output parameter. - v2: - sdhci_compute_clock_config uses a returned value instead of an out-parameter to provide the clock configuration. Ludovic Desroches (3): mmc: sdhci: introduce sdhci_compute_clock_config mmc

Re: [PATCH v2 1/3] mmc: sdhci: introduce sdhci_compute_clock_config

2016-04-06 Thread Ludovic Desroches
On Wed, Apr 06, 2016 at 05:04:45PM +0200, Ludovic Desroches wrote: > On Wed, Apr 06, 2016 at 03:37:28PM +0300, Adrian Hunter wrote: > > On 04/04/16 18:27, Ludovic Desroches wrote: > > > In order to remove the SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST and to > > > r

Re: [PATCH v2 1/3] mmc: sdhci: introduce sdhci_compute_clock_config

2016-04-06 Thread Ludovic Desroches
On Wed, Apr 06, 2016 at 05:04:45PM +0200, Ludovic Desroches wrote: > On Wed, Apr 06, 2016 at 03:37:28PM +0300, Adrian Hunter wrote: > > On 04/04/16 18:27, Ludovic Desroches wrote: > > > In order to remove the SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST and to > > > r

Re: [PATCH v2 1/3] mmc: sdhci: introduce sdhci_compute_clock_config

2016-04-06 Thread Ludovic Desroches
On Wed, Apr 06, 2016 at 03:37:28PM +0300, Adrian Hunter wrote: > On 04/04/16 18:27, Ludovic Desroches wrote: > > In order to remove the SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST and to > > reduce code duplication, put the code relative to the SD clock > > configuration in

Re: [PATCH v2 1/3] mmc: sdhci: introduce sdhci_compute_clock_config

2016-04-06 Thread Ludovic Desroches
On Wed, Apr 06, 2016 at 03:37:28PM +0300, Adrian Hunter wrote: > On 04/04/16 18:27, Ludovic Desroches wrote: > > In order to remove the SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST and to > > reduce code duplication, put the code relative to the SD clock > > configuration in

[PATCH v2 3/3] mmc: sdhci: removal of SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST

2016-04-04 Thread Ludovic Desroches
SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST quirk is not used anymore so remove it. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/mmc/host/sdhci.c | 2 -- drivers/mmc/host/sdhci.h | 5 - 2 files changed, 7 deletions(-) diff --git a/drivers/mmc/host/sdh

[PATCH v2 2/3] mmc: sdhci-of-at91: implement specific set_clock function

2016-04-04 Thread Ludovic Desroches
internal re-synchronisation but it seems in some cases the delay (even if longer) doesn't fix this bug. The safest workaround is to not disable/enable the internal clock during the SD card clock configuration. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/mm

[PATCH v2 0/3] SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST removal

2016-04-04 Thread Ludovic Desroches
instead of an out-parameter to provide the clock configuration. Ludovic Desroches (3): mmc: sdhci: introduce sdhci_compute_clock_config mmc: sdhci-of-at91: implement specific set_clock function mmc: sdhci: removal of SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST drivers/mmc/host/sdhci

[PATCH v2 3/3] mmc: sdhci: removal of SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST

2016-04-04 Thread Ludovic Desroches
SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST quirk is not used anymore so remove it. Signed-off-by: Ludovic Desroches --- drivers/mmc/host/sdhci.c | 2 -- drivers/mmc/host/sdhci.h | 5 - 2 files changed, 7 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index

[PATCH v2 2/3] mmc: sdhci-of-at91: implement specific set_clock function

2016-04-04 Thread Ludovic Desroches
internal re-synchronisation but it seems in some cases the delay (even if longer) doesn't fix this bug. The safest workaround is to not disable/enable the internal clock during the SD card clock configuration. Signed-off-by: Ludovic Desroches --- drivers/mmc/host/sdhci-of-at91.c | 48

[PATCH v2 0/3] SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST removal

2016-04-04 Thread Ludovic Desroches
instead of an out-parameter to provide the clock configuration. Ludovic Desroches (3): mmc: sdhci: introduce sdhci_compute_clock_config mmc: sdhci-of-at91: implement specific set_clock function mmc: sdhci: removal of SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST drivers/mmc/host/sdhci

[PATCH v2 1/3] mmc: sdhci: introduce sdhci_compute_clock_config

2016-04-04 Thread Ludovic Desroches
In order to remove the SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST and to reduce code duplication, put the code relative to the SD clock configuration in a function which can be used by hosts for the implementation of the set_clock() callback. Signed-off-by: Ludovic Desroches <ludovic.des

[PATCH v2 1/3] mmc: sdhci: introduce sdhci_compute_clock_config

2016-04-04 Thread Ludovic Desroches
In order to remove the SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST and to reduce code duplication, put the code relative to the SD clock configuration in a function which can be used by hosts for the implementation of the set_clock() callback. Signed-off-by: Ludovic Desroches --- drivers/mmc/host

[PATCH 3/3] mmc: sdhci: removal of SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST

2016-04-04 Thread Ludovic Desroches
SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST quirk is not used anymore so remove it. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/mmc/host/sdhci.c | 2 -- drivers/mmc/host/sdhci.h | 5 - 2 files changed, 7 deletions(-) diff --git a/drivers/mmc/host/sdh

[PATCH 3/3] mmc: sdhci: removal of SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST

2016-04-04 Thread Ludovic Desroches
SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST quirk is not used anymore so remove it. Signed-off-by: Ludovic Desroches --- drivers/mmc/host/sdhci.c | 2 -- drivers/mmc/host/sdhci.h | 5 - 2 files changed, 7 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index

[PATCH 0/3] SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST removal

2016-04-04 Thread Ludovic Desroches
quirks, I have decided to remove it and to implement my own set_clock() function. In ordrer to reduce code duplication with the sdhci set_clock function, I moved some of the code in a new sdhci_compute_clock_config() function. Regards Ludovic Desroches (3): mmc: sdhci: introduce

[PATCH 0/3] SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST removal

2016-04-04 Thread Ludovic Desroches
quirks, I have decided to remove it and to implement my own set_clock() function. In ordrer to reduce code duplication with the sdhci set_clock function, I moved some of the code in a new sdhci_compute_clock_config() function. Regards Ludovic Desroches (3): mmc: sdhci: introduce

[PATCH 2/3] mmc: sdhci-of-at91: implement specific set_clock function

2016-04-04 Thread Ludovic Desroches
internal re-synchronisation but it seems in some cases the delay (even if longer) doesn't fix this bug. The safest workaround is to not disable/enable the internal clock during the SD card clock configuration. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/mm

[PATCH 2/3] mmc: sdhci-of-at91: implement specific set_clock function

2016-04-04 Thread Ludovic Desroches
internal re-synchronisation but it seems in some cases the delay (even if longer) doesn't fix this bug. The safest workaround is to not disable/enable the internal clock during the SD card clock configuration. Signed-off-by: Ludovic Desroches --- drivers/mmc/host/sdhci-of-at91.c | 48

[PATCH 1/3] mmc: sdhci: introduce sdhci_compute_clock_config

2016-04-04 Thread Ludovic Desroches
In order to remove the SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST and to reduce code duplication, put the code relative to the SD clock configuration in a function which can be used by hosts for the implementation of the set_clock() callback. Signed-off-by: Ludovic Desroches <ludovic.des

[PATCH 1/3] mmc: sdhci: introduce sdhci_compute_clock_config

2016-04-04 Thread Ludovic Desroches
In order to remove the SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST and to reduce code duplication, put the code relative to the SD clock configuration in a function which can be used by hosts for the implementation of the set_clock() callback. Signed-off-by: Ludovic Desroches --- drivers/mmc/host

[PATCH] mmc: sdhci-of-at91: allow the use of controller card detect as wake up

2016-03-25 Thread Ludovic Desroches
disable the interface clock if there is a removable device and no gpio for card detection. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/mmc/host/sdhci-of-at91.c | 71 +--- 1 file changed, 45 insertions(+), 26 deletions(-) diff

[PATCH] DRAFT: shdci: allows custom wakeup irqs for runtime PM

2016-03-25 Thread Ludovic Desroches
Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/mmc/host/sdhci-of-at91.c | 36 ++-- drivers/mmc/host/sdhci.c | 12 +--- drivers/mmc/host/sdhci.h | 2 +- 3 files changed, 16 insertions(+), 34 deletions(-)

[PATCH] mmc: sdhci-of-at91: allow the use of controller card detect as wake up

2016-03-25 Thread Ludovic Desroches
disable the interface clock if there is a removable device and no gpio for card detection. Signed-off-by: Ludovic Desroches --- drivers/mmc/host/sdhci-of-at91.c | 71 +--- 1 file changed, 45 insertions(+), 26 deletions(-) diff --git a/drivers/mmc/host/sdhci

[PATCH] DRAFT: shdci: allows custom wakeup irqs for runtime PM

2016-03-25 Thread Ludovic Desroches
Signed-off-by: Ludovic Desroches --- drivers/mmc/host/sdhci-of-at91.c | 36 ++-- drivers/mmc/host/sdhci.c | 12 +--- drivers/mmc/host/sdhci.h | 2 +- 3 files changed, 16 insertions(+), 34 deletions(-) diff --git a/drivers/mmc/host/sdhci

[PATCH] sdhci: wakeup from runtime PM

2016-03-25 Thread Ludovic Desroches
Hi, When not using the SDHCI controller, it is logical to save power by suspending it. The issue is that SDHCI assumes that the controller is completely disabled. It means the only way to wake up on a card event is to have a gpio for the card detection (so two pins for the same signal). A

[PATCH] sdhci: wakeup from runtime PM

2016-03-25 Thread Ludovic Desroches
Hi, When not using the SDHCI controller, it is logical to save power by suspending it. The issue is that SDHCI assumes that the controller is completely disabled. It means the only way to wake up on a card event is to have a gpio for the card detection (so two pins for the same signal). A

Re: Warnings for invalid VDD (sdhci-s3c)

2016-03-24 Thread Ludovic Desroches
ric SDHCI code. > > > > Fix by adding a 'set_power' callback and restoring the default > > behaviour prior to commit 918f4cbd4340 ("mmc: sdhci: restore > > behavior when setting VDD via external regulator"). The desired > > behaviour of that commit is gott

Re: Warnings for invalid VDD (sdhci-s3c)

2016-03-24 Thread Ludovic Desroches
; > Subject: [PATCH V2] mmc: sdhci: Fix regression setting power on Trats2 board > > > > Several commits relating to setting power have been introducing > > problems by putting driver-specific rules into generic SDHCI code. > > > > Fix by adding a '

Re: Warnings for invalid VDD (sdhci-s3c)

2016-03-24 Thread Ludovic Desroches
Hi, On Thu, Mar 24, 2016 at 03:11:25PM +0200, Adrian Hunter wrote: > On 24/03/16 10:42, Krzysztof Kozlowski wrote: > > On 24.03.2016 17:24, Jisheng Zhang wrote: > >> Hi, > >> > >> On Thu, 24 Mar 2016 17:09:27 +0900 Jaehoon Chung wrote: > >> > >>> Hi, > >>> > >>> On 03/24/2016 04:58 PM, Jisheng

Re: Warnings for invalid VDD (sdhci-s3c)

2016-03-24 Thread Ludovic Desroches
Hi, On Thu, Mar 24, 2016 at 03:11:25PM +0200, Adrian Hunter wrote: > On 24/03/16 10:42, Krzysztof Kozlowski wrote: > > On 24.03.2016 17:24, Jisheng Zhang wrote: > >> Hi, > >> > >> On Thu, 24 Mar 2016 17:09:27 +0900 Jaehoon Chung wrote: > >> > >>> Hi, > >>> > >>> On 03/24/2016 04:58 PM, Jisheng

[PATCH 2/2] iio:adc:at91-sama5d2: add support for differential conversions

2016-03-22 Thread Ludovic Desroches
Add signed differential channels and update the voltage scale for differential conversions. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- This patch is based on: iio:adc:at91-sama5d2: fix identation iio:adc:at91-sama5d2: fix typo drivers/iio/adc/at91-sama5d2_adc.

[PATCH 2/2] iio:adc:at91-sama5d2: add support for differential conversions

2016-03-22 Thread Ludovic Desroches
Add signed differential channels and update the voltage scale for differential conversions. Signed-off-by: Ludovic Desroches --- This patch is based on: iio:adc:at91-sama5d2: fix identation iio:adc:at91-sama5d2: fix typo drivers/iio/adc/at91-sama5d2_adc.c | 71

[PATCH 1/2] iio:adc:at91-sama5d2: cleanup mode register use

2016-03-22 Thread Ludovic Desroches
Do not erase previous configuration of the mode register when setting the sampling frequency. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/iio/adc/at91-sama5d2_adc.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/i

[PATCH 1/2] iio:adc:at91-sama5d2: cleanup mode register use

2016-03-22 Thread Ludovic Desroches
Do not erase previous configuration of the mode register when setting the sampling frequency. Signed-off-by: Ludovic Desroches --- drivers/iio/adc/at91-sama5d2_adc.c | 15 ++- 1 file changed, 10 insertions(+), 5 deletions(-) diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b

[PATCH] ARM: at91/dt: sama5d2: add SFR node

2016-03-19 Thread Ludovic Desroches
From: Cyrille Pitchen <cyrille.pitc...@atmel.com> This SFR node is looked up by the I2S controller driver to tune the SFR_I2SCLKSEL register. Signed-off-by: Cyrille Pitchen <cyrille.pitc...@atmel.com> Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- Docume

[PATCH] ARM: at91/dt: sama5d2: add SFR node

2016-03-19 Thread Ludovic Desroches
From: Cyrille Pitchen This SFR node is looked up by the I2S controller driver to tune the SFR_I2SCLKSEL register. Signed-off-by: Cyrille Pitchen Signed-off-by: Ludovic Desroches --- Documentation/devicetree/bindings/arm/atmel-at91.txt | 2 +- arch/arm/boot/dts/sama5d2.dtsi

<    1   2   3   4   5   6   7   8   9   10   >