[PATCH 2/3] ARM: at91/soc: reference the whole sama5d2 family

2016-03-19 Thread Ludovic Desroches
Add EXID of all SoCs of the SAMA5D2 family. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/mach-at91/sama5.c | 20 +++- arch/arm/mach-at91/soc.h | 12 +++- 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/arch/arm/mac

[PATCH 2/3] ARM: at91/soc: reference the whole sama5d2 family

2016-03-19 Thread Ludovic Desroches
Add EXID of all SoCs of the SAMA5D2 family. Signed-off-by: Ludovic Desroches --- arch/arm/mach-at91/sama5.c | 20 +++- arch/arm/mach-at91/soc.h | 12 +++- 2 files changed, 30 insertions(+), 2 deletions(-) diff --git a/arch/arm/mach-at91/sama5.c b/arch/arm/mach-at91

[RESEND PATCH] ARM: at91/dt: sama5d2: add SFR node

2016-03-19 Thread Ludovic Desroches
From: Cyrille Pitchen <cyrille.pitc...@atmel.com> This SFR node is looked up by the I2S controller driver to tune the SFR_I2SCLKSEL register. Signed-off-by: Cyrille Pitchen <cyrille.pitc...@atmel.com> Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- Docume

[RESEND PATCH] ARM: at91/dt: sama5d2: add SFR node

2016-03-19 Thread Ludovic Desroches
From: Cyrille Pitchen This SFR node is looked up by the I2S controller driver to tune the SFR_I2SCLKSEL register. Signed-off-by: Cyrille Pitchen Signed-off-by: Ludovic Desroches --- Documentation/devicetree/bindings/arm/atmel-at91.txt | 2 +- arch/arm/boot/dts/sama5d2.dtsi

[PATCH 3/3] ARM: at91/dt: sama5d2: add chipid node

2016-03-19 Thread Ludovic Desroches
Add node for chipid device in order to have access to the CIDR and EXID values. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/boot/dts/sama5d2.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/s

[PATCH 3/3] ARM: at91/dt: sama5d2: add chipid node

2016-03-19 Thread Ludovic Desroches
Add node for chipid device in order to have access to the CIDR and EXID values. Signed-off-by: Ludovic Desroches --- arch/arm/boot/dts/sama5d2.dtsi | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi index 78996bd..173e3d7

[PATCH v2] mmc: sdhci-of-at91: fix wake-up issue when using runtime pm

2016-03-19 Thread Ludovic Desroches
is broken. It is curently we only way to wake-up on card event if using runtime pm. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- Changes: - v2: - remove SDHCI_QUIRK_BROKEN_CARD_DETECTION quirk if set by the broken-cd property. drivers/mmc/host/sdhci-of-at91.

[PATCH v2] mmc: sdhci-of-at91: fix wake-up issue when using runtime pm

2016-03-19 Thread Ludovic Desroches
is broken. It is curently we only way to wake-up on card event if using runtime pm. Signed-off-by: Ludovic Desroches --- Changes: - v2: - remove SDHCI_QUIRK_BROKEN_CARD_DETECTION quirk if set by the broken-cd property. drivers/mmc/host/sdhci-of-at91.c | 20 1 file changed

[PATCH 1/3] ARM: at91: use chipid device for soc detection

2016-03-18 Thread Ludovic Desroches
So far, the CIDR and EXID registers were in the DBGU interface. This device has disappeared with the SAMA5D2 family. These registers are exposed through a new device called chipid. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> [nicolas.fe...@atmel.com: remove useless wa

[PATCH 1/3] ARM: at91: use chipid device for soc detection

2016-03-18 Thread Ludovic Desroches
So far, the CIDR and EXID registers were in the DBGU interface. This device has disappeared with the SAMA5D2 family. These registers are exposed through a new device called chipid. Signed-off-by: Ludovic Desroches [nicolas.fe...@atmel.com: remove useless warnings] --- .../devicetree/bindings

Re: [PATCH] mmc: sdhci-of-at91: fix wakeup issue when using runtime pm

2016-03-11 Thread Ludovic Desroches
On Thu, Mar 10, 2016 at 11:30:58AM +0100, Ludovic Desroches wrote: > It was impossible to wake-up on card detect event because when sdhci > controller is runtime suspend, it is assumed that all the clocks are > disabled so we can't get irqs. > If the device is removable and ther

Re: [PATCH] mmc: sdhci-of-at91: fix wakeup issue when using runtime pm

2016-03-11 Thread Ludovic Desroches
On Thu, Mar 10, 2016 at 11:30:58AM +0100, Ludovic Desroches wrote: > It was impossible to wake-up on card detect event because when sdhci > controller is runtime suspend, it is assumed that all the clocks are > disabled so we can't get irqs. > If the device is removable and ther

[PATCH] ARM: at91/dt: sama5d3 xplained: don't disable hsmci regulator

2016-03-11 Thread Ludovic Desroches
If enabling the hsmci regulator on card detection, the board can reboot on sd card insertion. Keeping the regulator always enabled fixes this issue. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Fixes: 1b53e3416dd0 ("ARM: at91/dt: sama5d3 xplained: add fixed regulato

[PATCH] ARM: at91/dt: sama5d3 xplained: don't disable hsmci regulator

2016-03-11 Thread Ludovic Desroches
If enabling the hsmci regulator on card detection, the board can reboot on sd card insertion. Keeping the regulator always enabled fixes this issue. Signed-off-by: Ludovic Desroches Fixes: 1b53e3416dd0 ("ARM: at91/dt: sama5d3 xplained: add fixed regulator for vmmc0") Cc: sta...@vger.

[PATCH] ARM: at91/dt: sama5d4 xplained: don't disable hsmci regulator

2016-03-11 Thread Ludovic Desroches
If enabling the hsmci regulator on card detection, the board can reboot on sd card insertion. Keeping the regulator always enabled fixes this issue. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Fixes: 8d545f32bd77 ("ARM: at91/dt: sama5d4 xplained: add regulators f

[PATCH] ARM: at91/dt: sama5d4 xplained: don't disable hsmci regulator

2016-03-11 Thread Ludovic Desroches
If enabling the hsmci regulator on card detection, the board can reboot on sd card insertion. Keeping the regulator always enabled fixes this issue. Signed-off-by: Ludovic Desroches Fixes: 8d545f32bd77 ("ARM: at91/dt: sama5d4 xplained: add regulators for v(q)mmc1 supplies"

Re: [PATCH v2 1/2] iio: core: introduce IIO_CHAN_INFO_SIGNED

2016-03-10 Thread Ludovic Desroches
On Wed, Mar 09, 2016 at 09:04:21PM +, Jonathan Cameron wrote: > On 07/03/16 20:09, Lars-Peter Clausen wrote: > > On 03/07/2016 03:29 PM, Ludovic Desroches wrote: > >> The same channel can be used to perform a signed or an unsigned > >> conversion. Add a new

Re: [PATCH v2 1/2] iio: core: introduce IIO_CHAN_INFO_SIGNED

2016-03-10 Thread Ludovic Desroches
On Wed, Mar 09, 2016 at 09:04:21PM +, Jonathan Cameron wrote: > On 07/03/16 20:09, Lars-Peter Clausen wrote: > > On 03/07/2016 03:29 PM, Ludovic Desroches wrote: > >> The same channel can be used to perform a signed or an unsigned > >> conversion. Add a new

[PATCH] mmc: sdhci-of-at91: fix wakeup issue when using runtime pm

2016-03-10 Thread Ludovic Desroches
-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- Hi Ulf, Adrian, Following the discussion, I need to fix my issue. I think we could both agree on this patch that I see more as temporary workaround. I will try to change the muxing of the card detect pio in order to no more use the

[PATCH] mmc: sdhci-of-at91: fix wakeup issue when using runtime pm

2016-03-10 Thread Ludovic Desroches
-by: Ludovic Desroches --- Hi Ulf, Adrian, Following the discussion, I need to fix my issue. I think we could both agree on this patch that I see more as temporary workaround. I will try to change the muxing of the card detect pio in order to no more use the sdhci controller to manage it but a gpio

[RESEND PATCH] dmaengine: at_xdmac: fix residue computation

2016-03-10 Thread Ludovic Desroches
descriptor has not changed. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Suggested-by: Cyrille Pitchen <cyrille.pitc...@atmel.com> Reported-by: David Engraf <david.eng...@sysgo.com> Tested-by: David Engraf <david.eng...@sysgo.com> Fixes: e1f7c9eee707 ("

[RESEND PATCH] dmaengine: at_xdmac: fix residue computation

2016-03-10 Thread Ludovic Desroches
descriptor has not changed. Signed-off-by: Ludovic Desroches Suggested-by: Cyrille Pitchen Reported-by: David Engraf Tested-by: David Engraf Fixes: e1f7c9eee707 ("dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver") Cc: sta...@vger.kernel.org #4.1 and later --

Re: [PATCH] mmc: sdhci-of-at91: fix wakeup issue when using runtime pm

2016-03-09 Thread Ludovic Desroches
+ PM mailing list since the discussion is mixing PM and sdhci On Tue, Mar 08, 2016 at 10:56:31PM +0100, Ulf Hansson wrote: > +Ludovic > > On 8 March 2016 at 22:54, Ulf Hansson <ulf.hans...@linaro.org> wrote: > > On 4 March 2016 at 14:48, Ludovic Desroches <ludovic.desroc.

Re: [PATCH] mmc: sdhci-of-at91: fix wakeup issue when using runtime pm

2016-03-09 Thread Ludovic Desroches
+ PM mailing list since the discussion is mixing PM and sdhci On Tue, Mar 08, 2016 at 10:56:31PM +0100, Ulf Hansson wrote: > +Ludovic > > On 8 March 2016 at 22:54, Ulf Hansson wrote: > > On 4 March 2016 at 14:48, Ludovic Desroches > > wrote: [snip] > >> &

[PATCH v2 2/2] iio:adc:at91-sama5d2: add support for signed conversion

2016-03-07 Thread Ludovic Desroches
. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/iio/adc/at91-sama5d2_adc.c | 125 ++--- 1 file changed, 102 insertions(+), 23 deletions(-) diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c index 5

[PATCH v2 2/2] iio:adc:at91-sama5d2: add support for signed conversion

2016-03-07 Thread Ludovic Desroches
. Signed-off-by: Ludovic Desroches --- drivers/iio/adc/at91-sama5d2_adc.c | 125 ++--- 1 file changed, 102 insertions(+), 23 deletions(-) diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c index 5bc038f..0370c4f 100644 --- a/drivers

[PATCH v2 1/2] iio: core: introduce IIO_CHAN_INFO_SIGNED

2016-03-07 Thread Ludovic Desroches
The same channel can be used to perform a signed or an unsigned conversion. Add a new infomask element to be able to select the type of conversion wanted: a raw one or a signed raw one. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- Documentation/ABI/testing/sysfs-b

[PATCH v2 1/2] iio: core: introduce IIO_CHAN_INFO_SIGNED

2016-03-07 Thread Ludovic Desroches
The same channel can be used to perform a signed or an unsigned conversion. Add a new infomask element to be able to select the type of conversion wanted: a raw one or a signed raw one. Signed-off-by: Ludovic Desroches --- Documentation/ABI/testing/sysfs-bus-iio | 10 ++ drivers/iio

[PATCH v2 0/2] iio: add support for signed conversions

2016-03-07 Thread Ludovic Desroches
Hi Jonathan, I hope these patches are in adequacy with your comments. They are based on the the previous two patches you have taken. I am not sure about the correctness of the documentation. Ludovic Desroches (2): iio: core: introduce IIO_CHAN_INFO_SIGNED iio:adc:at91-sama5d2: add support

[PATCH v2 0/2] iio: add support for signed conversions

2016-03-07 Thread Ludovic Desroches
Hi Jonathan, I hope these patches are in adequacy with your comments. They are based on the the previous two patches you have taken. I am not sure about the correctness of the documentation. Ludovic Desroches (2): iio: core: introduce IIO_CHAN_INFO_SIGNED iio:adc:at91-sama5d2: add support

Re: [PATCH] mmc: sdhci-of-at91: fix wakeup issue when using runtime pm

2016-03-04 Thread Ludovic Desroches
Hi Ulf, On Fri, Mar 04, 2016 at 10:09:37AM +0100, Ulf Hansson wrote: > On 17 February 2016 at 11:35, Ludovic Desroches [snip] > > I am wondering if I should take account of sdio irq enabled or not here. > > > > I have a sdio device which drives me crazy becaus

Re: [PATCH] mmc: sdhci-of-at91: fix wakeup issue when using runtime pm

2016-03-04 Thread Ludovic Desroches
Hi Ulf, On Fri, Mar 04, 2016 at 10:09:37AM +0100, Ulf Hansson wrote: > On 17 February 2016 at 11:35, Ludovic Desroches [snip] > > I am wondering if I should take account of sdio irq enabled or not here. > > > > I have a sdio device which drives me crazy becaus

[PATCH 1/3] iio:adc:at91-sama5d2: fix typo

2016-03-03 Thread Ludovic Desroches
Fix typo in the name of a macro. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/iio/adc/at91-sama5d2_adc.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/ad

[PATCH 1/3] iio:adc:at91-sama5d2: fix typo

2016-03-03 Thread Ludovic Desroches
Fix typo in the name of a macro. Signed-off-by: Ludovic Desroches --- drivers/iio/adc/at91-sama5d2_adc.c | 26 +- 1 file changed, 13 insertions(+), 13 deletions(-) diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c index dbee13a

[PATCH 3/3] iio:adc:at91-sama5d2: add support for signed conversion

2016-03-03 Thread Ludovic Desroches
The at91-sama5d2 ADC controller can achieve unsigned and signed conversion. For each channel, a signed and an unsigned variant are created. We can't set the sign mode for each channel. For that reason, the controller has to be configured upon conversion requests. Signed-off-by: Ludovic Desroches

[PATCH 2/3] iio:adc:at91-sama5d2: fix identation

2016-03-03 Thread Ludovic Desroches
Remove some extra tabs. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/iio/adc/at91-sama5d2_adc.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c

[PATCH 3/3] iio:adc:at91-sama5d2: add support for signed conversion

2016-03-03 Thread Ludovic Desroches
The at91-sama5d2 ADC controller can achieve unsigned and signed conversion. For each channel, a signed and an unsigned variant are created. We can't set the sign mode for each channel. For that reason, the controller has to be configured upon conversion requests. Signed-off-by: Ludovic Desroches

[PATCH 2/3] iio:adc:at91-sama5d2: fix identation

2016-03-03 Thread Ludovic Desroches
Remove some extra tabs. Signed-off-by: Ludovic Desroches --- drivers/iio/adc/at91-sama5d2_adc.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/drivers/iio/adc/at91-sama5d2_adc.c b/drivers/iio/adc/at91-sama5d2_adc.c index 33bacec..5bc038f 100644

[PATCH 0/3] iio:adc:at91-sama5d2: add support for signed conversion

2016-03-03 Thread Ludovic Desroches
Hi, This set of patches does some cleanup in the code and export channels for signed and unsigned conversions. Ludovic Desroches (3): iio:adc:at91-sama5d2: fix typo iio:adc:at91-sama5d2: fix identation iio:adc:at91-sama5d2: add support for signed conversion drivers/iio/adc/at91

[PATCH 0/3] iio:adc:at91-sama5d2: add support for signed conversion

2016-03-03 Thread Ludovic Desroches
Hi, This set of patches does some cleanup in the code and export channels for signed and unsigned conversions. Ludovic Desroches (3): iio:adc:at91-sama5d2: fix typo iio:adc:at91-sama5d2: fix identation iio:adc:at91-sama5d2: add support for signed conversion drivers/iio/adc/at91

Re: [PATCH 01/14] pinctrl: at91: use __maybe_unused to hide pm functions

2016-03-02 Thread Ludovic Desroches
it can silently drop them instead of warning. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Thanks > --- > drivers/pinctrl/pinctrl-at91-pio4.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > dif

Re: [PATCH 01/14] pinctrl: at91: use __maybe_unused to hide pm functions

2016-03-02 Thread Ludovic Desroches
it can silently drop them instead of warning. > > Signed-off-by: Arnd Bergmann Acked-by: Ludovic Desroches Thanks > --- > drivers/pinctrl/pinctrl-at91-pio4.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c > b

Re: [PATCH] mmc: sdhci-of-at91: fix wakeup issue when using runtime pm

2016-02-25 Thread Ludovic Desroches
On Sat, Feb 13, 2016 at 10:56:40AM +0100, Ludovic Desroches wrote: > When suspending the sdhci host, the only hardware event that could wake > up the host is a sdio irq if they are enabled. If we want to wakeup on > card detect events, a gpio as to be used. > If we don't want t

Re: [PATCH] mmc: sdhci-of-at91: fix wakeup issue when using runtime pm

2016-02-25 Thread Ludovic Desroches
On Sat, Feb 13, 2016 at 10:56:40AM +0100, Ludovic Desroches wrote: > When suspending the sdhci host, the only hardware event that could wake > up the host is a sdio irq if they are enabled. If we want to wakeup on > card detect events, a gpio as to be used. > If we don't want t

[PATCH] ARM: at91/dt: fix typo in sama5d2 pinmux descriptions

2016-02-19 Thread Ludovic Desroches
PIN_PA15 macro has the same value as PIN_PA14 so we were overriding PA14 mux/configuration. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Reported-by: Cyrille Pitchen <cyrille.pitc...@atmel.com> Fixes: 7f16cb676c00 ("ARM: at91/dt: add sama5d2 pinmux") Cc:

[PATCH] ARM: at91/dt: fix typo in sama5d2 pinmux descriptions

2016-02-19 Thread Ludovic Desroches
PIN_PA15 macro has the same value as PIN_PA14 so we were overriding PA14 mux/configuration. Signed-off-by: Ludovic Desroches Reported-by: Cyrille Pitchen Fixes: 7f16cb676c00 ("ARM: at91/dt: add sama5d2 pinmux") Cc: sta...@vger.kernel.org #4.4 and later --- arch/arm/boot/dts/sama5d2

Re: Device probing proceeds even when the default pinctrl state is invalid

2016-02-19 Thread Ludovic Desroches
Hi Romain, On Fri, Feb 19, 2016 at 02:30:49PM +0100, romain izard wrote: > 2016-02-18 21:07 GMT+01:00 Linus Walleij : > > On Thu, Feb 18, 2016 at 11:37 AM, Romain Izard > > wrote: > > > >> The current code for device probing tries to map the

Re: Device probing proceeds even when the default pinctrl state is invalid

2016-02-19 Thread Ludovic Desroches
Hi Romain, On Fri, Feb 19, 2016 at 02:30:49PM +0100, romain izard wrote: > 2016-02-18 21:07 GMT+01:00 Linus Walleij : > > On Thu, Feb 18, 2016 at 11:37 AM, Romain Izard > > wrote: > > > >> The current code for device probing tries to map the default pinctrl > >> state (in pinctrl_bind_pins), but

Re: [PATCH] ARM: dts: at91: sama5d2 Xplained: Correct the macb irq pinctrl node

2016-02-19 Thread Ludovic Desroches
the Ethernet PHY's interrupt line. > > Signed-off-by: Romain Izard <romain.izard....@gmail.com> Acked-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Thanks > --- > arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/

Re: [PATCH] ARM: dts: at91: sama5d2 Xplained: Correct the macb irq pinctrl node

2016-02-19 Thread Ludovic Desroches
the Ethernet PHY's interrupt line. > > Signed-off-by: Romain Izard Acked-by: Ludovic Desroches Thanks > --- > arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts > b/arch/ar

[PATCH] dmaengine: at_xdmac: fix residue computation

2016-02-19 Thread Ludovic Desroches
descriptor has not changed. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Suggested-by: Cyrille Pitchen <cyrille.pitc...@atmel.com> Reported-by: David Engraf <david.eng...@sysgo.com> Tested-by: David Engraf <david.eng...@sysgo.com> Fixes: e1f7c9eee707 ("

[PATCH] dmaengine: at_xdmac: fix residue computation

2016-02-19 Thread Ludovic Desroches
descriptor has not changed. Signed-off-by: Ludovic Desroches Suggested-by: Cyrille Pitchen Reported-by: David Engraf Tested-by: David Engraf Fixes: e1f7c9eee707 ("dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver") Cc: sta...@vger.kernel.org #4.1 and later --

Re: [PATCH] mmc: sdhci-of-at91: fix wakeup issue when using runtime pm

2016-02-17 Thread Ludovic Desroches
On Tue, Feb 16, 2016 at 04:22:04PM +0100, Ludovic Desroches wrote: > On Tue, Feb 16, 2016 at 03:38:29PM +0100, Ulf Hansson wrote: > > On 13 February 2016 at 10:56, Ludovic Desroches > > <ludovic.desroc...@atmel.com> wrote: > > > When suspending the sdhci host, the

Re: [PATCH] mmc: sdhci-of-at91: fix wakeup issue when using runtime pm

2016-02-17 Thread Ludovic Desroches
On Tue, Feb 16, 2016 at 04:22:04PM +0100, Ludovic Desroches wrote: > On Tue, Feb 16, 2016 at 03:38:29PM +0100, Ulf Hansson wrote: > > On 13 February 2016 at 10:56, Ludovic Desroches > > wrote: > > > When suspending the sdhci host, the only hardware event that coul

Re: [PATCH] mmc: sdhci-of-at91: fix wakeup issue when using runtime pm

2016-02-16 Thread Ludovic Desroches
On Tue, Feb 16, 2016 at 03:38:29PM +0100, Ulf Hansson wrote: > On 13 February 2016 at 10:56, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > When suspending the sdhci host, the only hardware event that could wake > > up the host is a sdio irq if they are enabl

Re: [PATCH] mmc: sdhci-of-at91: fix wakeup issue when using runtime pm

2016-02-16 Thread Ludovic Desroches
On Tue, Feb 16, 2016 at 03:38:29PM +0100, Ulf Hansson wrote: > On 13 February 2016 at 10:56, Ludovic Desroches > wrote: > > When suspending the sdhci host, the only hardware event that could wake > > up the host is a sdio irq if they are enabled. If we want to wakeup on >

[PATCH] mmc: sdhci-of-at91: fix wakeup issue when using runtime pm

2016-02-13 Thread Ludovic Desroches
of the controller interface to get the interrupt and to not set the host in a suspended state to have the interrupt handled. Signed-off-by: Ludovic Desroches --- drivers/mmc/host/sdhci-of-at91.c | 46 ++-- 1 file changed, 35 insertions(+), 11 deletions(-) diff

[PATCH] mmc: sdhci-of-at91: fix wakeup issue when using runtime pm

2016-02-13 Thread Ludovic Desroches
of the controller interface to get the interrupt and to not set the host in a suspended state to have the interrupt handled. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/mmc/host/sdhci-of-at91.c | 46 ++-- 1 file chang

Re: [PATCH] mmc: sdhci-of-at91: fix card detect when using runtime PM

2016-02-12 Thread Ludovic Desroches
On Fri, Feb 12, 2016 at 12:01:39PM +0100, Ulf Hansson wrote: > >> > >> According to the below commit, SDHCI_QUIRK_BROKEN_CARD_DETECTION was > >> invented because of unreliable card detection mechanism inside the > >> sdhci controller. > >> Therefore it required polling to be used, but also to make

Re: [PATCH] mmc: sdhci-of-at91: fix card detect when using runtime PM

2016-02-12 Thread Ludovic Desroches
On Thu, Feb 11, 2016 at 04:10:54PM +0100, Ulf Hansson wrote: > On 11 February 2016 at 14:48, Ludovic Desroches > wrote: > > Add quirk broken card detection to enable card detection polling. It is > > a short term solution until reworking PM stuff. > > > > If the c

Re: [PATCH] mmc: sdhci-of-at91: fix card detect when using runtime PM

2016-02-12 Thread Ludovic Desroches
On Thu, Feb 11, 2016 at 04:10:54PM +0100, Ulf Hansson wrote: > On 11 February 2016 at 14:48, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > Add quirk broken card detection to enable card detection polling. It is > > a short term solution until reworking PM st

Re: [PATCH] mmc: sdhci-of-at91: fix card detect when using runtime PM

2016-02-12 Thread Ludovic Desroches
On Fri, Feb 12, 2016 at 12:01:39PM +0100, Ulf Hansson wrote: > >> > >> According to the below commit, SDHCI_QUIRK_BROKEN_CARD_DETECTION was > >> invented because of unreliable card detection mechanism inside the > >> sdhci controller. > >> Therefore it required polling to be used, but also to make

[PATCH] mmc: sdhci-of-at91: fix card detect when using runtime PM

2016-02-11 Thread Ludovic Desroches
are no more enabled. Signed-off-by: Ludovic Desroches Fixes: f5f17813ae9b ("mmc: sdhci-of-at91: add PM support") --- drivers/mmc/host/sdhci-of-at91.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c index 9cb86f

Re: [RFC PATCH] mmc: sdhci-of-at91: don't put device in suspend after probe

2016-02-11 Thread Ludovic Desroches
On Thu, Feb 11, 2016 at 10:46:08AM +0100, Ulf Hansson wrote: > [...] > > >> > > >> >> Currently, sdhci disables card detect interrupts when runtime suspended, > >> >> and drivers use a card-detect GPIO to wake-up. > >> >> > >> > > >> > It is what I have seen going through the sdhci layer. So next

Re: [RFC PATCH] mmc: sdhci-of-at91: don't put device in suspend after probe

2016-02-11 Thread Ludovic Desroches
Hi Ulf, On Wed, Feb 10, 2016 at 04:56:11PM +0100, Ulf Hansson wrote: > On 10 February 2016 at 13:51, Ludovic Desroches > wrote: > > Hi Adrian, > > > > On Wed, Feb 10, 2016 at 01:50:44PM +0200, Adrian Hunter wrote: > >> On 10/02/16 11:58, Ludovic Desroches wr

Re: [RFC PATCH] mmc: sdhci-of-at91: don't put device in suspend after probe

2016-02-11 Thread Ludovic Desroches
Hi Ulf, On Wed, Feb 10, 2016 at 04:56:11PM +0100, Ulf Hansson wrote: > On 10 February 2016 at 13:51, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > Hi Adrian, > > > > On Wed, Feb 10, 2016 at 01:50:44PM +0200, Adrian Hunter wrote: > >> On

[PATCH] mmc: sdhci-of-at91: fix card detect when using runtime PM

2016-02-11 Thread Ludovic Desroches
are no more enabled. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Fixes: f5f17813ae9b ("mmc: sdhci-of-at91: add PM support") --- drivers/mmc/host/sdhci-of-at91.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/ho

Re: [RFC PATCH] mmc: sdhci-of-at91: don't put device in suspend after probe

2016-02-11 Thread Ludovic Desroches
On Thu, Feb 11, 2016 at 10:46:08AM +0100, Ulf Hansson wrote: > [...] > > >> > > >> >> Currently, sdhci disables card detect interrupts when runtime suspended, > >> >> and drivers use a card-detect GPIO to wake-up. > >> >> > >> > > >> > It is what I have seen going through the sdhci layer. So next

Re: [RFC PATCH] mmc: sdhci-of-at91: don't put device in suspend after probe

2016-02-10 Thread Ludovic Desroches
On Wed, Feb 10, 2016 at 04:20:43PM +0200, Adrian Hunter wrote: > On 10/02/16 16:16, Ludovic Desroches wrote: > > On Wed, Feb 10, 2016 at 03:00:09PM +0200, Adrian Hunter wrote: > >> On 10/02/16 14:51, Ludovic Desroches wrote: > >>> Hi Adrian, > >>> >

Re: [RFC PATCH] mmc: sdhci-of-at91: don't put device in suspend after probe

2016-02-10 Thread Ludovic Desroches
On Wed, Feb 10, 2016 at 03:00:09PM +0200, Adrian Hunter wrote: > On 10/02/16 14:51, Ludovic Desroches wrote: > > Hi Adrian, > > > > On Wed, Feb 10, 2016 at 01:50:44PM +0200, Adrian Hunter wrote: > >> On 10/02/16 11:58, Ludovic Desroches wrote: > >>> B

Re: [RFC PATCH] mmc: sdhci-of-at91: don't put device in suspend after probe

2016-02-10 Thread Ludovic Desroches
Hi Adrian, On Wed, Feb 10, 2016 at 01:50:44PM +0200, Adrian Hunter wrote: > On 10/02/16 11:58, Ludovic Desroches wrote: > > By putting the device in suspend at the end of the probe, it is > > impossible to wake up on non software event such as card > > insertion/removal

[RFC PATCH] mmc: sdhci-of-at91: don't put device in suspend after probe

2016-02-10 Thread Ludovic Desroches
By putting the device in suspend at the end of the probe, it is impossible to wake up on non software event such as card insertion/removal. Signed-off-by: Ludovic Desroches --- Hi, Since I had no feedback on this topic: http://permalink.gmane.org/gmane.linux.kernel.mmc/35160 I would like

Re: [RFC PATCH] mmc: sdhci-of-at91: don't put device in suspend after probe

2016-02-10 Thread Ludovic Desroches
On Wed, Feb 10, 2016 at 04:20:43PM +0200, Adrian Hunter wrote: > On 10/02/16 16:16, Ludovic Desroches wrote: > > On Wed, Feb 10, 2016 at 03:00:09PM +0200, Adrian Hunter wrote: > >> On 10/02/16 14:51, Ludovic Desroches wrote: > >>> Hi Adrian, > >>> >

Re: [RFC PATCH] mmc: sdhci-of-at91: don't put device in suspend after probe

2016-02-10 Thread Ludovic Desroches
On Wed, Feb 10, 2016 at 03:00:09PM +0200, Adrian Hunter wrote: > On 10/02/16 14:51, Ludovic Desroches wrote: > > Hi Adrian, > > > > On Wed, Feb 10, 2016 at 01:50:44PM +0200, Adrian Hunter wrote: > >> On 10/02/16 11:58, Ludovic Desroches wrote: > >>> B

[RFC PATCH] mmc: sdhci-of-at91: don't put device in suspend after probe

2016-02-10 Thread Ludovic Desroches
By putting the device in suspend at the end of the probe, it is impossible to wake up on non software event such as card insertion/removal. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- Hi, Since I had no feedback on this topic: http://permalink.gma

Re: [RFC PATCH] mmc: sdhci-of-at91: don't put device in suspend after probe

2016-02-10 Thread Ludovic Desroches
Hi Adrian, On Wed, Feb 10, 2016 at 01:50:44PM +0200, Adrian Hunter wrote: > On 10/02/16 11:58, Ludovic Desroches wrote: > > By putting the device in suspend at the end of the probe, it is > > impossible to wake up on non software event such as card > > insertion/removal

Re: [PATCH] mmc: sdhci-of-at91: fix pm runtime unbalanced issue in error path

2016-01-27 Thread Ludovic Desroches
e's power usage counter. > Well spotted, thanks. > Signed-off-by: Jisheng Zhang Acked-by: Ludovic Desroches > Fixes: f5f17813ae9b ("mmc: sdhci-of-at91: add PM support) > --- > drivers/mmc/host/sdhci-of-at91.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) &g

Re: [PATCH] mmc: sdhci-of-at91: fix pm runtime unbalanced issue in error path

2016-01-27 Thread Ludovic Desroches
e's power usage counter. > Well spotted, thanks. > Signed-off-by: Jisheng Zhang <jszh...@marvell.com> Acked-by: Ludovic Desroches <ludovic.desroc...@atmel.com> > Fixes: f5f17813ae9b ("mmc: sdhci-of-at91: add PM support) > --- > drivers/mmc/host/sdhci-of-at9

[PATCH v2 5/5] ARM: at91/defconfig: add sama5d2 adc support in sama5_defconfig

2016-01-06 Thread Ludovic Desroches
Signed-off-by: Ludovic Desroches --- arch/arm/configs/sama5_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig index c11bab7..37aa085 100644 --- a/arch/arm/configs/sama5_defconfig +++ b/arch/arm/configs

[PATCH v2 4/5] ARM: at91/dt: sama5d2 Xplained: enable the adc device

2016-01-06 Thread Ludovic Desroches
Enable the adc on the sama5d2 Xplained board. Signed-off-by: Ludovic Desroches --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts

[PATCH v2 3/5] ARM: at91/dt: sama5d2: add adc device

2016-01-06 Thread Ludovic Desroches
Add the ADC device, and remove the adc_op_clk which is useless since the adc sampling frequency is configured with sysfs. Signed-off-by: Ludovic Desroches --- arch/arm/boot/dts/sama5d2.dtsi | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/arch/arm/boot/dts

[PATCH v2 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver

2016-01-06 Thread Ludovic Desroches
This driver supports the new version of the Atmel ADC device introduced with the SAMA5D2 SoC family. Signed-off-by: Ludovic Desroches --- .../devicetree/bindings/iio/adc/at91_adc8xx.txt| 28 ++ drivers/iio/adc/Kconfig| 11 + drivers/iio/adc/Makefile

[PATCH v2 2/5] MAINTAINERS: add entry for Atmel ADC 8xx driver

2016-01-06 Thread Ludovic Desroches
Signed-off-by: Ludovic Desroches --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 248828d..827bc83 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1945,6 +1945,12 @@ M: Nicolas Ferre S: Supported F: drivers/tty/serial

[PATCH v2 0/5] Introduce at91_adc8xx driver

2016-01-06 Thread Ludovic Desroches
. Ludovic Desroches (5): iio:adc:at91_adc8xx: introduce new atmel adc driver MAINTAINERS: add entry for Atmel ADC 8xx driver ARM: at91/dt: sama5d2: add adc device ARM: at91/dt: sama5d2 Xplained: enable the adc device ARM: at91/defconfig: add sama5d2 adc support in sama5_defconfig

Re: [PATCH v3 06/12] mmc: sdhci-of-at91: use sdhci_pltfm_init for private allocation

2016-01-06 Thread Ludovic Desroches
; sdhci-of-at91 driver to this allocation. > > Signed-off-by: Jisheng Zhang > Acked-by: Arnd Bergmann Acked-by: Ludovic Desroches Thanks > --- > drivers/mmc/host/sdhci-of-at91.c | 24 +--- > 1 file changed, 9 insertions(+), 15 deletions(-) > > diff

Re: [PATCH v2 06/12] mmc: sdhci-of-at91: use sdhci_pltfm_init for private allocation

2016-01-06 Thread Ludovic Desroches
On Wed, Jan 06, 2016 at 05:22:48PM +0800, Jisheng Zhang wrote: > Dear Ludovic, > > On Wed, 6 Jan 2016 10:02:15 +0100 Ludovic Desroches wrote: > > > Hi Jisheng, > > > > Thanks for your patch but it needs to be updated since it breaks this > > driver. >

Re: [PATCH v2 06/12] mmc: sdhci-of-at91: use sdhci_pltfm_init for private allocation

2016-01-06 Thread Ludovic Desroches
Hi Jisheng, Thanks for your patch but it needs to be updated since it breaks this driver. - struct sdhci_at91_priv *priv = pltfm_host->priv; + struct sdhci_at91_priv *priv = sdhci_pltfm_priv(pltfm_host); is missing in sdhci_at91_runtime_suspend and sdhci_at91_runtime_resume

Re: [PATCH v2 06/12] mmc: sdhci-of-at91: use sdhci_pltfm_init for private allocation

2016-01-06 Thread Ludovic Desroches
On Wed, Jan 06, 2016 at 05:22:48PM +0800, Jisheng Zhang wrote: > Dear Ludovic, > > On Wed, 6 Jan 2016 10:02:15 +0100 Ludovic Desroches wrote: > > > Hi Jisheng, > > > > Thanks for your patch but it needs to be updated since it breaks this > > driver. >

Re: [PATCH v2 06/12] mmc: sdhci-of-at91: use sdhci_pltfm_init for private allocation

2016-01-06 Thread Ludovic Desroches
Hi Jisheng, Thanks for your patch but it needs to be updated since it breaks this driver. - struct sdhci_at91_priv *priv = pltfm_host->priv; + struct sdhci_at91_priv *priv = sdhci_pltfm_priv(pltfm_host); is missing in sdhci_at91_runtime_suspend and sdhci_at91_runtime_resume

Re: [PATCH v3 06/12] mmc: sdhci-of-at91: use sdhci_pltfm_init for private allocation

2016-01-06 Thread Ludovic Desroches
; sdhci-of-at91 driver to this allocation. > > Signed-off-by: Jisheng Zhang <jszh...@marvell.com> > Acked-by: Arnd Bergmann <a...@arndb.de> Acked-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Thanks > --- > drivers/mmc/host/sdhci-of-at91.c | 24

[PATCH v2 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver

2016-01-06 Thread Ludovic Desroches
This driver supports the new version of the Atmel ADC device introduced with the SAMA5D2 SoC family. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- .../devicetree/bindings/iio/adc/at91_adc8xx.txt| 28 ++ drivers/iio/adc/Kconfig| 11 + d

[PATCH v2 2/5] MAINTAINERS: add entry for Atmel ADC 8xx driver

2016-01-06 Thread Ludovic Desroches
Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 248828d..827bc83 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1945,6 +1945,12 @@ M: Nicolas Ferre <n

[PATCH v2 3/5] ARM: at91/dt: sama5d2: add adc device

2016-01-06 Thread Ludovic Desroches
Add the ADC device, and remove the adc_op_clk which is useless since the adc sampling frequency is configured with sysfs. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/boot/dts/sama5d2.dtsi | 18 -- 1 file changed, 12 insertions(+), 6 del

[PATCH v2 4/5] ARM: at91/dt: sama5d2 Xplained: enable the adc device

2016-01-06 Thread Ludovic Desroches
Enable the adc on the sama5d2 Xplained board. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/ar

[PATCH v2 5/5] ARM: at91/defconfig: add sama5d2 adc support in sama5_defconfig

2016-01-06 Thread Ludovic Desroches
Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/configs/sama5_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig index c11bab7..37aa085 100644 --- a/arch/arm/configs/sama5_defconfig

[PATCH v2 0/5] Introduce at91_adc8xx driver

2016-01-06 Thread Ludovic Desroches
. Ludovic Desroches (5): iio:adc:at91_adc8xx: introduce new atmel adc driver MAINTAINERS: add entry for Atmel ADC 8xx driver ARM: at91/dt: sama5d2: add adc device ARM: at91/dt: sama5d2 Xplained: enable the adc device ARM: at91/defconfig: add sama5d2 adc support in sama5_defconfig

Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver

2016-01-05 Thread Ludovic Desroches
On Wed, Dec 23, 2015 at 05:21:25PM +, Jonathan Cameron wrote: > > > On 23 December 2015 10:48:33 GMT+00:00, Ludovic Desroches > wrote: > >On Wed, Dec 23, 2015 at 11:27:00AM +0100, Ludovic Desroches wrote: > >> On Tue, Dec 22, 2015 at 06:34:00PM +, Jonathan

Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver

2016-01-05 Thread Ludovic Desroches
On Wed, Dec 23, 2015 at 05:21:25PM +, Jonathan Cameron wrote: > > > On 23 December 2015 10:48:33 GMT+00:00, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > >On Wed, Dec 23, 2015 at 11:27:00AM +0100, Ludovic Desroches wrote: > >> On Tue, Dec 22, 2

Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver

2015-12-23 Thread Ludovic Desroches
On Wed, Dec 23, 2015 at 11:27:00AM +0100, Ludovic Desroches wrote: > On Tue, Dec 22, 2015 at 06:34:00PM +, Jonathan Cameron wrote: > > On 21/12/15 09:24, Ludovic Desroches wrote: > > > This driver supports the new version of the Atmel ADC device introduced > > >

Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver

2015-12-23 Thread Ludovic Desroches
On Tue, Dec 22, 2015 at 06:51:18PM -0600, Rob Herring wrote: > On Mon, Dec 21, 2015 at 10:24:08AM +0100, Ludovic Desroches wrote: > > This driver supports the new version of the Atmel ADC device introduced > > with the SAMA5D2 SoC family. > > > > Signe

<    2   3   4   5   6   7   8   9   10   11   >