Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver

On Tue, Dec 22, 2015 at 06:34:00PM +, Jonathan Cameron wrote: > On 21/12/15 09:24, Ludovic Desroches wrote: > > This driver supports the new version of the Atmel ADC device introduced > > with the SAMA5D2 SoC family. > > > > Signed-off-by: Ludovic Desroches > A

Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver

On Tue, Dec 22, 2015 at 06:34:00PM +, Jonathan Cameron wrote: > On 21/12/15 09:24, Ludovic Desroches wrote: > > This driver supports the new version of the Atmel ADC device introduced > > with the SAMA5D2 SoC family. > > > > Signed-off-by: Ludovic Desroches &

Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver

On Tue, Dec 22, 2015 at 06:51:18PM -0600, Rob Herring wrote: > On Mon, Dec 21, 2015 at 10:24:08AM +0100, Ludovic Desroches wrote: > > This driver supports the new version of the Atmel ADC device introduced > > with the SAMA5D2 SoC family. > > > > Signed-off-by: Ludovi

Re: [PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver

On Wed, Dec 23, 2015 at 11:27:00AM +0100, Ludovic Desroches wrote: > On Tue, Dec 22, 2015 at 06:34:00PM +, Jonathan Cameron wrote: > > On 21/12/15 09:24, Ludovic Desroches wrote: > > > This driver supports the new version of the Atmel ADC device introduced > > >

[PATCH 5/5] ARM: at91/defconfig: add sama5d2 adc support in sama5_defconfig

Signed-off-by: Ludovic Desroches --- arch/arm/configs/sama5_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig index c11bab7..afbda41 100644 --- a/arch/arm/configs/sama5_defconfig +++ b/arch/arm/configs

[PATCH 3/5] ARM: at91/dt: sama5d2: add adc device

Add the ADC device. Signed-off-by: Ludovic Desroches --- arch/arm/boot/dts/sama5d2.dtsi | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi index 545264b..91c6e42 100644 --- a/arch/arm/boot/dts/sama5d2

[PATCH 2/5] MAINTAINERS: add entry for Atmel ADC 8xx driver

Signed-off-by: Ludovic Desroches --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a27c660..5971c25 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1927,6 +1927,12 @@ M: Nicolas Ferre S: Supported F: drivers/tty/serial

[PATCH 4/5] ARM: at91/dt: sama5d2 Xplained: enable the adc device

Enable the adc on the sama5d2 Xplained board. Signed-off-by: Ludovic Desroches --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts

[PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver

This driver supports the new version of the Atmel ADC device introduced with the SAMA5D2 SoC family. Signed-off-by: Ludovic Desroches --- .../devicetree/bindings/iio/adc/at91_adc8xx.txt| 27 ++ drivers/iio/adc/Kconfig| 11 + drivers/iio/adc/Makefile

[PATCH 0/5] Introduce at91_adc8xx driver

, differential channels, hardware triggers, dma support, touchscreen support, and others. Ludovic Desroches (5): iio:adc:at91_adc8xx: introduce new atmel adc driver MAINTAINERS: add entry for Atmel ADC 8xx driver ARM: at91/dt: sama5d2: add adc device ARM: at91/dt: sama5d2 Xplained: enable

[PATCH 5/5] ARM: at91/defconfig: add sama5d2 adc support in sama5_defconfig

Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/configs/sama5_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig index c11bab7..afbda41 100644 --- a/arch/arm/configs/sama5_defconfig

[PATCH 3/5] ARM: at91/dt: sama5d2: add adc device

Add the ADC device. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/boot/dts/sama5d2.dtsi | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/sama5d2.dtsi b/arch/arm/boot/dts/sama5d2.dtsi index 545264b..91c6e42

[PATCH 0/5] Introduce at91_adc8xx driver

, differential channels, hardware triggers, dma support, touchscreen support, and others. Ludovic Desroches (5): iio:adc:at91_adc8xx: introduce new atmel adc driver MAINTAINERS: add entry for Atmel ADC 8xx driver ARM: at91/dt: sama5d2: add adc device ARM: at91/dt: sama5d2 Xplained: enable

[PATCH 4/5] ARM: at91/dt: sama5d2 Xplained: enable the adc device

Enable the adc on the sama5d2 Xplained board. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 22 ++ 1 file changed, 22 insertions(+) diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/ar

[PATCH 1/5] iio:adc:at91_adc8xx: introduce new atmel adc driver

This driver supports the new version of the Atmel ADC device introduced with the SAMA5D2 SoC family. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- .../devicetree/bindings/iio/adc/at91_adc8xx.txt| 27 ++ drivers/iio/adc/Kconfig| 11 + d

[PATCH 2/5] MAINTAINERS: add entry for Atmel ADC 8xx driver

Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- MAINTAINERS | 6 ++ 1 file changed, 6 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index a27c660..5971c25 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1927,6 +1927,12 @@ M: Nicolas Ferre <n

Re: [PATCH v2] mmc: sdhci: restore behavior when setting VDD via external regulator

n. > > > > After this patch, the sdcard on Marvell Berlin SoC boards work again. > > > > Signed-off-by: Jisheng Zhang > > Fixes: 52221610dd84 ("mmc: sdhci: Improve external VDD ...") Reviewed-by: Ludovic Desroches Tested-by: Ludovic Desroches Even if the patc

Re: [PATCH v2] mmc: sdhci: restore behavior when setting VDD via external regulator

hci_set_power() function. > > > > After this patch, the sdcard on Marvell Berlin SoC boards work again. > > > > Signed-off-by: Jisheng Zhang <jszh...@marvell.com> > > Fixes: 52221610dd84 ("mmc: sdhci: Improve external VDD ...") Reviewed-by: Ludovic De

Re: [PATCH v2] mmc: sdhci: restore behavior when setting VDD via external regulator

On Fri, Dec 11, 2015 at 03:48:04PM +0100, Ulf Hansson wrote: > + Ludovic (We had some discussions around this code recently as well) > Thanks Ulf. > On 11 December 2015 at 14:36, Jisheng Zhang wrote: > > After commit 52221610dd84 ("mmc: sdhci: Improve external VDD regulator > > support"), for

Re: [PATCH v2] mmc: sdhci: restore behavior when setting VDD via external regulator

On Fri, Dec 11, 2015 at 03:48:04PM +0100, Ulf Hansson wrote: > + Ludovic (We had some discussions around this code recently as well) > Thanks Ulf. > On 11 December 2015 at 14:36, Jisheng Zhang wrote: > > After commit 52221610dd84 ("mmc: sdhci: Improve external VDD

Re: [RESEND RFC PATCH 0/2] Expose the PIO_ISR register on SAMA5D3

Hi Peter, On Tue, Dec 08, 2015 at 04:20:06AM +0100, Peter Rosin wrote: > From: Peter Rosin > > Hi! > > I have a signal connected to a gpio pin which is the output of > a comparator. By changing the level of one of the inputs to the > comparator, I can detect the envelope of the other input to

Re: [RESEND RFC PATCH 0/2] Expose the PIO_ISR register on SAMA5D3

Hi Peter, On Tue, Dec 08, 2015 at 04:20:06AM +0100, Peter Rosin wrote: > From: Peter Rosin > > Hi! > > I have a signal connected to a gpio pin which is the output of > a comparator. By changing the level of one of the inputs to the > comparator, I can detect the envelope of

Re: [PATCH 1/1] dmaengine: at_xdmac: fix at_xdmac_prep_dma_memcpy()

t; new value. > > Signed-off-by: Cyrille Pitchen Thanks. Acked-by: Ludovic Desroches Fixes: e1f7c9eee70 ("dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver") Cc: sta...@vger.kernel.org #4.1 and later (minor conflict due to the introduction of a

Re: [PATCH 1/1] dmaengine: at_xdmac: fix at_xdmac_prep_dma_memcpy()

t; new value. > > Signed-off-by: Cyrille Pitchen <cyrille.pitc...@atmel.com> Thanks. Acked-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Fixes: e1f7c9eee70 ("dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver") Cc: sta...@vger.kerne

Re: [PATCH v2 1/4] i2c: at91: add upport for the HOLD field

Sorry forget this one, I have sent an old version. On Thu, Dec 03, 2015 at 10:53:51AM +0100, Ludovic Desroches wrote: > The hold field allows to configure the data hold time which can be set > with the help of the generic binding 'i2c-sda-hold-time-ns'. This > feature has been i

[PATCH v2 4/4] ARM: at91/dt: sama5d2 Xplained: pmic needs a specific sda hold time

Data have to be held longer for the PMIC device. The ACT8945A datasheet claims that minimum SDA data hold time is about 300 ns. Signed-off-by: Ludovic Desroches --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/at91

[PATCH v2 3/4] ARM: at91/dt: sama5d4: update i2c compatible string

A new compatible string has been introduced: atmel,sama5d4-i2c. It allows to use the i2c-sda-hold-time-ns property if needed. Signed-off-by: Ludovic Desroches --- arch/arm/boot/dts/sama5d4.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/sama5d4

[PATCH v2 1/4] i2c: at91: add upport for the HOLD field

The hold field allows to configure the data hold time which can be set with the help of the generic binding 'i2c-sda-hold-time-ns'. This feature has been introduced with SAMA5D4 SoC family. Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/i2c-at91.c | 53

[PATCH v2 2/4] i2c: at91: update bindings documention

The i2c-sda-hold-time-ns property is supported from atmel,sama5d4-i2c. Signed-off-by: Ludovic Desroches Acked-by: Rob Herring --- Documentation/devicetree/bindings/i2c/i2c-at91.txt | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/i2c/i2c

[PATCH v2 1/4] i2c: at91: add support for the HOLD field

The hold field allows to configure the data hold time which can be set with the help of the generic binding 'i2c-sda-hold-time-ns'. This feature has been introduced with SAMA5D4 SoC family. Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/i2c-at91.c | 53

[PATCH v2 0/4] i2c: at91: add support for SDA HOLD

Changes: - from v1: - fix typos, - change MAX_HOLD macro to follow Nicolas' advice, - make it clear that sama5d2 also support i2c-sda-hold-time-ns. Ludovic Desroches (4): i2c: at91: add support for the HOLD field i2c: at91: update bindings documention ARM: at91/dt: sama5d4: update i2c

[PATCH v2 4/4] ARM: at91/dt: sama5d2 Xplained: pmic needs a specific sda hold time

Data have to be held longer for the PMIC device. The ACT8945A datasheet claims that minimum SDA data hold time is about 300 ns. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH v2 3/4] ARM: at91/dt: sama5d4: update i2c compatible string

A new compatible string has been introduced: atmel,sama5d4-i2c. It allows to use the i2c-sda-hold-time-ns property if needed. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/boot/dts/sama5d4.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

Re: [PATCH v2 1/4] i2c: at91: add upport for the HOLD field

Sorry forget this one, I have sent an old version. On Thu, Dec 03, 2015 at 10:53:51AM +0100, Ludovic Desroches wrote: > The hold field allows to configure the data hold time which can be set > with the help of the generic binding 'i2c-sda-hold-time-ns'. This > feature has been i

[PATCH v2 0/4] i2c: at91: add support for SDA HOLD

Changes: - from v1: - fix typos, - change MAX_HOLD macro to follow Nicolas' advice, - make it clear that sama5d2 also support i2c-sda-hold-time-ns. Ludovic Desroches (4): i2c: at91: add support for the HOLD field i2c: at91: update bindings documention ARM: at91/dt: sama5d4: update i2c

[PATCH v2 1/4] i2c: at91: add support for the HOLD field

The hold field allows to configure the data hold time which can be set with the help of the generic binding 'i2c-sda-hold-time-ns'. This feature has been introduced with SAMA5D4 SoC family. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/i2c/busses/i2c-at91.

[PATCH v2 2/4] i2c: at91: update bindings documention

The i2c-sda-hold-time-ns property is supported from atmel,sama5d4-i2c. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/i2c/i2c-at91.txt | 5 - 1 file changed, 4 insertions(+), 1 delet

[PATCH v2 1/4] i2c: at91: add upport for the HOLD field

The hold field allows to configure the data hold time which can be set with the help of the generic binding 'i2c-sda-hold-time-ns'. This feature has been introduced with SAMA5D4 SoC family. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/i2c/busses/i2c-at91.

[PATCH] dmaengine: at_xdmac: fix bad behavior in interleaved mode

From: Sylvain ETIENNE When performing interleaved transfers with numf > 1, an extra line is copied. The mbr.bc field is incremented once too often. The length of the block is (BLEN+1) microblocks. Signed-off-by: Sylvain ETIENNE Signed-off-by: Ludovic Desroches Fixes: 4e5385784e69 ("d

[PATCH 4/4] ARM: at91/dt: sama5d2 Xplained: pmic needs a specific sda hold time

Data have to been hold longer for the PMIC device. Signed-off-by: Ludovic Desroches --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts/at91-sama5d2_xplained.dts index ad6de73

[PATCH 3/4] ARM: at91/dt: sama5d4: update i2c compatible string

A new compatible string has been introduced: atmel,sama5d4-i2c. It allows to use the i2c-sda-hold-time-ns property if needed. Signed-off-by: Ludovic Desroches --- arch/arm/boot/dts/sama5d4.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/arch/arm/boot/dts/sama5d4

[PATCH 2/4] i2c: at91: update bindings documention

The i2c-sda-hold-time-ns property is supported from atmel,sama5d4-i2c. Signed-off-by: Ludovic Desroches --- Documentation/devicetree/bindings/i2c/i2c-at91.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/i2c/i2c-at91.txt b

[PATCH 1/4] i2c: at91: add upport for the HOLD field

The hold field allows to configure the data hold time which can be set with the help of the generic binding 'i2c-sda-hold-time-ns'. This feature has been introduced with SAMA5D4 SoC family. Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/i2c-at91.c | 54

Re: [PATCH] ARM: at91/dt: add always-on to 1.8V regulator

or definitions doesn't suit our > controller > for this 1.8V purpose. > > Signed-off-by: Nicolas Ferre Acked-by: Ludovic Desroches > --- > arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/at91

[PATCH] dmaengine: at_xdmac: fix bad behavior in interleaved mode

.com> Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Fixes: 4e5385784e69 ("dmaengine: at_xdmac: handle numf > 1") --- drivers/dma/at_xdmac.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdm

[PATCH 2/4] i2c: at91: update bindings documention

The i2c-sda-hold-time-ns property is supported from atmel,sama5d4-i2c. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- Documentation/devicetree/bindings/i2c/i2c-at91.txt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bi

[PATCH 1/4] i2c: at91: add upport for the HOLD field

The hold field allows to configure the data hold time which can be set with the help of the generic binding 'i2c-sda-hold-time-ns'. This feature has been introduced with SAMA5D4 SoC family. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/i2c/busses/i2c-at91.

Re: [PATCH] ARM: at91/dt: add always-on to 1.8V regulator

or definitions doesn't suit our > controller > for this 1.8V purpose. > > Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com> Acked-by: Ludovic Desroches <ludovic.desroc...@atmel.com> > --- > arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + > 1 file changed,

[PATCH 3/4] ARM: at91/dt: sama5d4: update i2c compatible string

A new compatible string has been introduced: atmel,sama5d4-i2c. It allows to use the i2c-sda-hold-time-ns property if needed. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/boot/dts/sama5d4.dtsi | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff

[PATCH 4/4] ARM: at91/dt: sama5d2 Xplained: pmic needs a specific sda hold time

Data have to been hold longer for the PMIC device. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dt

[PATCH] pinctrl: at91-pio4: fix memleak after using dt map

configs is allocated by pinconf_generic_parse_dt_config(), pinctrl_utils_add_map_configs() duplicates configs so it can and has to be freed to prevent memory leaks. Signed-off-by: Ludovic Desroches Reported-by: Yingjoe Chen --- drivers/pinctrl/pinctrl-at91-pio4.c | 15 +-- 1 file

[PATCH] ARM: at91: fix pinctrl driver selection

Move the selection of the pinctrl driver to SoC family level since we have two pinctrl drivers. It is useless to select one which is not compatible with the SoC. Signed-off-by: Ludovic Desroches --- This patch is an improvement of this one (already acked by Linus and Nicolas): https://lkml.org

Re: [PATCH] pinctrl: update document for pinconf_generic_parse_dt_config

On Tue, Dec 01, 2015 at 11:12:16AM +0100, Linus Walleij wrote: > On Wed, Nov 25, 2015 at 1:13 PM, Yingjoe Chen > wrote: > > > The returned configs from pinconf_generic_parse_dt_config() is > > duplicated from original. Make it clear it must be freed when no > > longer necessary. > > > >

Re: [PATCH] pinctrl: update document for pinconf_generic_parse_dt_config

On Tue, Dec 01, 2015 at 11:12:16AM +0100, Linus Walleij wrote: > On Wed, Nov 25, 2015 at 1:13 PM, Yingjoe Chen > wrote: > > > The returned configs from pinconf_generic_parse_dt_config() is > > duplicated from original. Make it clear it must be freed when no > > longer

[PATCH] ARM: at91: fix pinctrl driver selection

Move the selection of the pinctrl driver to SoC family level since we have two pinctrl drivers. It is useless to select one which is not compatible with the SoC. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- This patch is an improvement of this one (already acked by

[PATCH] pinctrl: at91-pio4: fix memleak after using dt map

configs is allocated by pinconf_generic_parse_dt_config(), pinctrl_utils_add_map_configs() duplicates configs so it can and has to be freed to prevent memory leaks. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Reported-by: Yingjoe Chen <yingjoe.c...@mediatek.com>

Re: [PATCH 1/3] i2c: at91: add setting HOLD field of TWIHS_CWGR via DT

On Mon, Nov 30, 2015 at 04:13:20PM +0100, Wolfram Sang wrote: > On Tue, Nov 24, 2015 at 02:47:40PM +0100, Ludovic Desroches wrote: > > From: Wenyou Yang > > > > Add the HOLD field management. Some i2c devices need a longer data hold > > time than the one given in the i

Re: [PATCH 1/3] i2c: at91: add setting HOLD field of TWIHS_CWGR via DT

On Mon, Nov 30, 2015 at 04:13:20PM +0100, Wolfram Sang wrote: > On Tue, Nov 24, 2015 at 02:47:40PM +0100, Ludovic Desroches wrote: > > From: Wenyou Yang <wenyou.y...@atmel.com> > > > > Add the HOLD field management. Some i2c devices need a longer data hold > > t

Re: [PATCH] mmc: sdhci-of-at91: controller is suspended too early

On Fri, Nov 27, 2015 at 03:11:58PM +0100, Ulf Hansson wrote: > On 26 November 2015 at 17:41, Ludovic Desroches > wrote: > > When calling sdhci_add_host(), the controller is already suspended. It > > causes to read 0 in registers. > > Increment the device's usag

Re: [PATCH] mmc: sdhci-of-at91: controller is suspended too early

On Fri, Nov 27, 2015 at 03:11:58PM +0100, Ulf Hansson wrote: > On 26 November 2015 at 17:41, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > When calling sdhci_add_host(), the controller is already suspended. It > > causes to read 0 in registers. > >

[PATCH] mmc: sdhci-of-at91: controller is suspended too early

When calling sdhci_add_host(), the controller is already suspended. It causes to read 0 in registers. Increment the device's usage counter before calling sdhci_add_host(), decrement it after and put it in suspend if it is possible. Signed-off-by: Ludovic Desroches Fixes: "mmc: sdhci-of-at91

Re: [PATCH v2] mmc: sdhci at91: add PM support

On Thu, Nov 26, 2015 at 05:24:40PM +0100, Ulf Hansson wrote: > On 26 November 2015 at 17:07, Ludovic Desroches > wrote: > > On Tue, Nov 10, 2015 at 12:12:30PM +0100, Ulf Hansson wrote: > >> On 10 November 2015 at 11:36, Ludovic Desroches > >> wrote: > &g

Re: [PATCH v2] mmc: sdhci at91: add PM support

On Tue, Nov 10, 2015 at 12:12:30PM +0100, Ulf Hansson wrote: > On 10 November 2015 at 11:36, Ludovic Desroches > wrote: > > Add runtime PM support and use runtime_force_suspend|resume() for system > > PM. > > [...] > > static int sdhci_at91_prob

Re: [PATCH v2] mmc: sdhci at91: add PM support

On Tue, Nov 10, 2015 at 12:12:30PM +0100, Ulf Hansson wrote: > On 10 November 2015 at 11:36, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > Add runtime PM support and use runtime_force_suspend|resume() for system > > PM. > > [...] > >

Re: [PATCH v2] mmc: sdhci at91: add PM support

On Thu, Nov 26, 2015 at 05:24:40PM +0100, Ulf Hansson wrote: > On 26 November 2015 at 17:07, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > On Tue, Nov 10, 2015 at 12:12:30PM +0100, Ulf Hansson wrote: > >> On 10 November 2015 at 11:36, Ludovic Des

[PATCH] mmc: sdhci-of-at91: controller is suspended too early

When calling sdhci_add_host(), the controller is already suspended. It causes to read 0 in registers. Increment the device's usage counter before calling sdhci_add_host(), decrement it after and put it in suspend if it is possible. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

On Tue, Nov 24, 2015 at 02:56:21PM +0100, Ulf Hansson wrote: > On 24 November 2015 at 14:12, Ludovic Desroches > wrote: > > On Tue, Nov 24, 2015 at 12:01:53PM +0100, Ulf Hansson wrote: > >> On 24 November 2015 at 10:23, Ludovic Desroches > >> wrote: > >>

[PATCH 2/3] i2c: at91: add DT property "atmel,twd-hold-cycles" to binding

From: Wenyou Yang Add a DT property "atmel,twd-hold-cycles" to specify the HOLD filed of TWIHS_CWGR register to increase the TWD hold time. Signed-off-by: Wenyou Yang Signed-off-by: Ludovic Desroches --- Documentation/devicetree/bindings/i2c/i2c-at91.txt | 4 1 file

[PATCH 3/3] ARM: dts: at91: specify DT property "atmel,twd-hold-cycles"

From: Wenyou Yang Specify the device tree property "atmel,twd-hold-cycles" to 25 to adapt to the PMIC ACT8945A. Signed-off-by: Wenyou Yang --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts

[PATCH 1/3] i2c: at91: add setting HOLD field of TWIHS_CWGR via DT

enyou Yang Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/i2c-at91.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c index 10835d1..b3595ea 100644 --- a/drivers/i2c/busses/i2c-at91.c +++ b/d

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

On Tue, Nov 24, 2015 at 12:01:53PM +0100, Ulf Hansson wrote: > On 24 November 2015 at 10:23, Ludovic Desroches > wrote: > > Hi Ulf, > > > > On Mon, Nov 09, 2015 at 05:30:26PM +0100, Ludovic Desroches wrote: > >> On Mon, Nov 09, 2015 at 05

[PATCH] dmaengine: at_xdmac: fix false condition for memset_sg transfers

The code was not in agreement with the comments. Signed-off-by: Ludovic Desroches Cc: sta...@vger.kernel.org # 4.3 and later --- drivers/dma/at_xdmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index 7f039de..3b68471

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

Hi Ulf, On Mon, Nov 09, 2015 at 05:30:26PM +0100, Ludovic Desroches wrote: > On Mon, Nov 09, 2015 at 05:00:46PM +0100, Ulf Hansson wrote: [...] > > Now, this discussion was interesting, but I forgot what problem you > > actually where trying to solve? :-) > > There is th

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

Hi Ulf, On Mon, Nov 09, 2015 at 05:30:26PM +0100, Ludovic Desroches wrote: > On Mon, Nov 09, 2015 at 05:00:46PM +0100, Ulf Hansson wrote: [...] > > Now, this discussion was interesting, but I forgot what problem you > > actually where trying to solve? :-) > > There is th

[PATCH] dmaengine: at_xdmac: fix false condition for memset_sg transfers

The code was not in agreement with the comments. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Cc: sta...@vger.kernel.org # 4.3 and later --- drivers/dma/at_xdmac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/dma/at_xdmac.c b/drive

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

On Tue, Nov 24, 2015 at 02:56:21PM +0100, Ulf Hansson wrote: > On 24 November 2015 at 14:12, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > On Tue, Nov 24, 2015 at 12:01:53PM +0100, Ulf Hansson wrote: > >> On 24 November 2015 at 10:23, Ludovic Des

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

On Tue, Nov 24, 2015 at 12:01:53PM +0100, Ulf Hansson wrote: > On 24 November 2015 at 10:23, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > Hi Ulf, > > > > On Mon, Nov 09, 2015 at 05:30:26PM +0100, Ludovic Desroches wrote: > >> On Mon, Nov 09

[PATCH 2/3] i2c: at91: add DT property "atmel,twd-hold-cycles" to binding

From: Wenyou Yang <wenyou.y...@atmel.com> Add a DT property "atmel,twd-hold-cycles" to specify the HOLD filed of TWIHS_CWGR register to increase the TWD hold time. Signed-off-by: Wenyou Yang <wenyou.y...@atmel.com> Signed-off-by: Ludovic Desroches <ludovic.desroc...@atme

[PATCH 1/3] i2c: at91: add setting HOLD field of TWIHS_CWGR via DT

hold-cycles". Signed-off-by: Wenyou Yang <wenyou.y...@atmel.com> Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/i2c/busses/i2c-at91.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers

[PATCH 3/3] ARM: dts: at91: specify DT property "atmel,twd-hold-cycles"

From: Wenyou Yang Specify the device tree property "atmel,twd-hold-cycles" to 25 to adapt to the PMIC ACT8945A. Signed-off-by: Wenyou Yang --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 1 + 1 file changed, 1 insertion(+) diff --git

[PATCH 3/3] mmc: atmel-mci: atmci_convert_chksize depends on controller version

The atmci_convert_chksize() function is no more valid for controller version 0x600 due to the introduction of '2 data' chunk size. Signed-off-by: Ludovic Desroches --- drivers/mmc/host/atmel-mci.c | 43 +++ 1 file changed, 27 insertions(+), 16 deletions

[PATCH 2/3] MAINTAINERS: remove atmel-mci-regs.h file

Remove atmel-mci-regs.h file since it has been merged in atmel-mci.c. Signed-off-by: Ludovic Desroches --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index b2ab9fc..1df3df3 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1904,7 +1904,6 @@ ATMEL AT91

[PATCH 1/3] mmc: atmel-mci: move atmel-mci-regs.h content in atmel-mci.c

atmel-mci-regs.h is only included in atmel-mci.c so move its content in the driver and do some cleanup in these definitions to remove checkpatch errors. Signed-off-by: Ludovic Desroches --- drivers/mmc/host/atmel-mci-regs.h | 171 -- drivers/mmc/host/atmel

[PATCH 2/2] dmaengine: at_xdmac: fix spurious flag status for mem2mem transfers

the highest perid value for mem2mem transfers since it doesn't match the perid of other devices. Signed-off-by: Ludovic Desroches --- drivers/dma/at_xdmac.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/dma/at_xdmac.c b/drivers/dma/at_xdmac.c index

[PATCH 1/2] dmaengine: at_xdmac: fix macro typo

Fix typo in a macro which was not used until now. It explains why there is no error at compilation time. Signed-off-by: Ludovic Desroches Fixes: e1f7c9eee707 "dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver" Cc: sta...@vger.kernel.org # 3.19 and later --- d

[PATCH 2/2] dmaengine: at_xdmac: fix spurious flag status for mem2mem transfers

the highest perid value for mem2mem transfers since it doesn't match the perid of other devices. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/dma/at_xdmac.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/dma/at_xdm

[PATCH 1/2] dmaengine: at_xdmac: fix macro typo

Fix typo in a macro which was not used until now. It explains why there is no error at compilation time. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Fixes: e1f7c9eee707 "dmaengine: at_xdmac: creation of the atmel eXtended DMA Controller driver" Cc: sta...@vger.k

[PATCH 1/3] mmc: atmel-mci: move atmel-mci-regs.h content in atmel-mci.c

atmel-mci-regs.h is only included in atmel-mci.c so move its content in the driver and do some cleanup in these definitions to remove checkpatch errors. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/mmc/host/atmel-mci-regs.h

[PATCH 3/3] mmc: atmel-mci: atmci_convert_chksize depends on controller version

The atmci_convert_chksize() function is no more valid for controller version 0x600 due to the introduction of '2 data' chunk size. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/mmc/host/atmel-mci.c | 43 +++ 1 file chang

[PATCH 2/3] MAINTAINERS: remove atmel-mci-regs.h file

Remove atmel-mci-regs.h file since it has been merged in atmel-mci.c. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index b2ab9fc..1df3df3 100644 --- a/MAINTAINERS +++ b/MAINT

Re: [PATCH v2] pinctrl: at91-pio4: use %pr format string for resource

format string to use the special "%pr" format > string that prints a resource, and changes the arguments so we > the resource structure directly. > > Signed-off-by: Arnd Bergmann Acked-by: Ludovic Desroches Thanks. > --- > v2: don't break ordering of arguments, that part

Re: [PATCH v2] pinctrl: at91-pio4: use %pr format string for resource

format string to use the special "%pr" format > string that prints a resource, and changes the arguments so we > the resource structure directly. > > Signed-off-by: Arnd Bergmann <a...@arndb.de> Acked-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Thanks. >

Re: [PATCH v2 4/7] ARM: at91/dt: sama5d2: add pio controller node

; On Wed, Sep 16, 2015 at 8:37 AM, Ludovic Desroches > >>> wrote: > >>> > >>>> Add pio4 controller node to enable pinmux and gpio. > >>>> > >>>> Signed-off-by: Ludovic Desroches > >>> > >>> Patch applied

Re: [PATCH] pinctrl: at91-pio4: use %pr format string for resource

Hi Arnd, On Thu, Nov 12, 2015 at 03:15:38PM +0100, Arnd Bergmann wrote: > resource_size_t may be defined as 32 or 64 bit depending on configuration, > so it cannot be printed using the normal format strings, as gcc correctly > warns: > > pinctrl-at91-pio4.c: In function 'atmel_pinctrl_probe': >

Re: [PATCH] MAINTAINERS: Atmel drivers: change NAND and ISI entries

On Tue, Nov 17, 2015 at 11:21:35AM +0100, Nicolas Ferre wrote: > Update Josh's entries about NAND and ISI drivers. > Thanks for your work with Atmel Josh! > > Signed-off-by: Nicolas Ferre > Cc: Ludovic Desroches > Cc: Wenyou Yang > Cc: Josh Wu Acked-

Re: [PATCH] pinctrl: at91-pio4: use %pr format string for resource

Hi Arnd, On Thu, Nov 12, 2015 at 03:15:38PM +0100, Arnd Bergmann wrote: > resource_size_t may be defined as 32 or 64 bit depending on configuration, > so it cannot be printed using the normal format strings, as gcc correctly > warns: > > pinctrl-at91-pio4.c: In function 'atmel_pinctrl_probe': >

Re: [PATCH] MAINTAINERS: Atmel drivers: change NAND and ISI entries

On Tue, Nov 17, 2015 at 11:21:35AM +0100, Nicolas Ferre wrote: > Update Josh's entries about NAND and ISI drivers. > Thanks for your work with Atmel Josh! > > Signed-off-by: Nicolas Ferre <nicolas.fe...@atmel.com> > Cc: Ludovic Desroches <ludovic.desroc...@atmel.com>

Re: [PATCH v2 4/7] ARM: at91/dt: sama5d2: add pio controller node

M, Linus Walleij > >> <linus.wall...@linaro.org> wrote: > >>> On Wed, Sep 16, 2015 at 8:37 AM, Ludovic Desroches > >>> <ludovic.desroc...@atmel.com> wrote: > >>> > >>>> Add pio4 controller node to enable pinmux and gpi

[PATCH v4] mmc: sdhci at91: add PM support

Add runtime PM support and use runtime_force_suspend|resume() for system PM. Signed-off-by: Ludovic Desroches --- Changes: - from v3: add error handling of runtime PM - from v2: cleanup thanks to Ulf feedback - from v1: take a runtime PM centric approach drivers/mmc/host/sdhci-of-at91.c | 72

[PATCH v4] mmc: sdhci at91: add PM support

Add runtime PM support and use runtime_force_suspend|resume() for system PM. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- Changes: - from v3: add error handling of runtime PM - from v2: cleanup thanks to Ulf feedback - from v1: take a runtime PM centric approach d

<    3   4   5   6   7   8   9   10   11   12   >