Re: [PATCH v3] mmc: sdhci at91: add PM support

2015-11-10 Thread Ludovic Desroches
On Tue, Nov 10, 2015 at 03:03:57PM +0100, Ulf Hansson wrote: > On 10 November 2015 at 14:23, Ludovic Desroches > wrote: > > Add runtime PM support and use runtime_force_suspend|resume() for system > > PM. > > > > Signed-off-by: Ludovic Desroches > > --- >

[PATCH v3] mmc: sdhci at91: add PM support

2015-11-10 Thread Ludovic Desroches
Add runtime PM support and use runtime_force_suspend|resume() for system PM. Signed-off-by: Ludovic Desroches --- Changes: - from v2: cleanup thanks to Ulf feedback - from v1: take a runtime PM centric approach drivers/mmc/host/sdhci-of-at91.c | 67 +++- 1

Re: [PATCH v2] mmc: sdhci at91: add PM support

2015-11-10 Thread Ludovic Desroches
On Tue, Nov 10, 2015 at 12:12:30PM +0100, Ulf Hansson wrote: > On 10 November 2015 at 11:36, Ludovic Desroches > wrote: > > Add runtime PM support and use runtime_force_suspend|resume() for system > > PM. > > > > Signed-off-by: Ludovic Desroches > > ---

[PATCH v2] mmc: sdhci at91: add PM support

2015-11-10 Thread Ludovic Desroches
Add runtime PM support and use runtime_force_suspend|resume() for system PM. Signed-off-by: Ludovic Desroches --- Changes: - from v1: take a runtime PM centric approach drivers/mmc/host/sdhci-of-at91.c | 66 +++- 1 file changed, 65 insertions(+), 1 deletion

[PATCH v2] mmc: sdhci at91: add PM support

2015-11-10 Thread Ludovic Desroches
Add runtime PM support and use runtime_force_suspend|resume() for system PM. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- Changes: - from v1: take a runtime PM centric approach drivers/mmc/host/sdhci-of-at91.c | 66 +++- 1 file c

Re: [PATCH v3] mmc: sdhci at91: add PM support

2015-11-10 Thread Ludovic Desroches
On Tue, Nov 10, 2015 at 03:03:57PM +0100, Ulf Hansson wrote: > On 10 November 2015 at 14:23, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > Add runtime PM support and use runtime_force_suspend|resume() for system > > PM. > > > > Signed-off-b

Re: [PATCH v2] mmc: sdhci at91: add PM support

2015-11-10 Thread Ludovic Desroches
On Tue, Nov 10, 2015 at 12:12:30PM +0100, Ulf Hansson wrote: > On 10 November 2015 at 11:36, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > Add runtime PM support and use runtime_force_suspend|resume() for system > > PM. > > > > Signed-off-b

[PATCH v3] mmc: sdhci at91: add PM support

2015-11-10 Thread Ludovic Desroches
Add runtime PM support and use runtime_force_suspend|resume() for system PM. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- Changes: - from v2: cleanup thanks to Ulf feedback - from v1: take a runtime PM centric approach drivers/mmc/host/sdhci-of-at91.

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-09 Thread Ludovic Desroches
On Mon, Nov 09, 2015 at 05:00:46PM +0100, Ulf Hansson wrote: > On 9 November 2015 at 15:40, Ludovic Desroches > wrote: > > On Mon, Nov 09, 2015 at 03:12:46PM +0100, Ulf Hansson wrote: > >> On 9 November 2015 at 14:23, Ludovic Desroches > >> wrote: > >> >

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-09 Thread Ludovic Desroches
On Mon, Nov 09, 2015 at 03:12:46PM +0100, Ulf Hansson wrote: > On 9 November 2015 at 14:23, Ludovic Desroches > wrote: > > On Fri, Nov 06, 2015 at 04:59:29PM +0100, Ludovic Desroches wrote: > >> When there is a vmmc regulator, only SD Bus Power is set to 1 in the > &

[PATCH] mmc: core: set regulator not found message as debug

2015-11-09 Thread Ludovic Desroches
Turn the informative message about no vmmc/vqmmc regulator found in debug one. There is no need to indicate that something optional is missing. Moreover, it can bring confusion, people who doesn't know it is optional may consider these messages as warnings or errors. Signed-off-by: Ludovic

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-09 Thread Ludovic Desroches
On Fri, Nov 06, 2015 at 04:59:29PM +0100, Ludovic Desroches wrote: > When there is a vmmc regulator, only SD Bus Power is set to 1 in the > Power Control Register. It means SD Bus Voltage Select field is set to 0 > that is a reserved value. The SD Host Controller specification says:

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-09 Thread Ludovic Desroches
On Mon, Nov 09, 2015 at 11:50:50AM +0100, Ulf Hansson wrote: > [...] > > >> > >> This doesn't seems like a case where a gpio regulator should be used > >> and I am not sure what problem it would solve. Beside to suppress the > >> log warnings (actually those aren't warnings but informations). >

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-09 Thread Ludovic Desroches
On Mon, Nov 09, 2015 at 10:38:03AM +0100, Ulf Hansson wrote: > [...] > > >> > Is the regulator-gpio usage the right thing to do for vqmmc? In my case > >> > it is > >> > not really driven by a gpio but by a pio from the sdhci device. In the > >> > binding, > >> > >> What's a "pio"? > >> > >>

[PATCH] mmc: core: set regulator not found message as debug

2015-11-09 Thread Ludovic Desroches
Turn the informative message about no vmmc/vqmmc regulator found in debug one. There is no need to indicate that something optional is missing. Moreover, it can bring confusion, people who doesn't know it is optional may consider these messages as warnings or errors. Signed-off-by: Ludovic

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-09 Thread Ludovic Desroches
On Fri, Nov 06, 2015 at 04:59:29PM +0100, Ludovic Desroches wrote: > When there is a vmmc regulator, only SD Bus Power is set to 1 in the > Power Control Register. It means SD Bus Voltage Select field is set to 0 > that is a reserved value. The SD Host Controller specification says:

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-09 Thread Ludovic Desroches
On Mon, Nov 09, 2015 at 03:12:46PM +0100, Ulf Hansson wrote: > On 9 November 2015 at 14:23, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > On Fri, Nov 06, 2015 at 04:59:29PM +0100, Ludovic Desroches wrote: > >> When there is a vmmc regulator, on

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-09 Thread Ludovic Desroches
On Mon, Nov 09, 2015 at 11:50:50AM +0100, Ulf Hansson wrote: > [...] > > >> > >> This doesn't seems like a case where a gpio regulator should be used > >> and I am not sure what problem it would solve. Beside to suppress the > >> log warnings (actually those aren't warnings but informations). >

Re: [PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-09 Thread Ludovic Desroches
On Mon, Nov 09, 2015 at 05:00:46PM +0100, Ulf Hansson wrote: > On 9 November 2015 at 15:40, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > On Mon, Nov 09, 2015 at 03:12:46PM +0100, Ulf Hansson wrote: > >> On 9 November 2015 at 14:23, Ludovic Des

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-09 Thread Ludovic Desroches
On Mon, Nov 09, 2015 at 10:38:03AM +0100, Ulf Hansson wrote: > [...] > > >> > Is the regulator-gpio usage the right thing to do for vqmmc? In my case > >> > it is > >> > not really driven by a gpio but by a pio from the sdhci device. In the > >> > binding, > >> > >> What's a "pio"? > >> > >>

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-08 Thread Ludovic Desroches
Hi Ulf, Thanks for your answer. On Fri, Nov 06, 2015 at 05:42:51PM +0100, Ulf Hansson wrote: > On 6 November 2015 at 16:59, Ludovic Desroches > wrote: > > Hi, > > > > I would like to have some feedback for these two patches. I have two > > questions. > > >

Re: [PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-08 Thread Ludovic Desroches
Hi Ulf, Thanks for your answer. On Fri, Nov 06, 2015 at 05:42:51PM +0100, Ulf Hansson wrote: > On 6 November 2015 at 16:59, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > Hi, > > > > I would like to have some feedback for these two patches. I have

[PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-06 Thread Ludovic Desroches
llows the specification then we need to set a valid value. Signed-off-by: Ludovic Desroches --- drivers/mmc/host/sdhci.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index ac97b46..0cfd7b2 100644 --- a/drivers/mmc/host/sdhci.c +++ b/dr

[PATCH 2/2] ARM: at91/dt: sama5d2 Xplained: add regulators for sdhci devices

2015-11-06 Thread Ludovic Desroches
Add vmmc and vqmmc regulators for sdhci devices. The voltage for sdmmc0 vqmmc is selected by a signal from coming from the sdhci device. Signed-off-by: Ludovic Desroches --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 14 ++ 1 file changed, 14 insertions(+) diff --git a/arch/arm

[PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-06 Thread Ludovic Desroches
ase it is not really driven by a gpio but by a pio from the sdhci device. In the binding, declaring the gpio is an option so I thought using this regulator fits my need. P.S. patch 2 is based on another patch not yet in next: http://www.spinics.net/lists/arm-kernel/msg453447.html Thanks Ludovic Ludo

[PATCH 0/2] mmc: sdhci: potentially bad behavior when using vmmc supply

2015-11-06 Thread Ludovic Desroches
ase it is not really driven by a gpio but by a pio from the sdhci device. In the binding, declaring the gpio is an option so I thought using this regulator fits my need. P.S. patch 2 is based on another patch not yet in next: http://www.spinics.net/lists/arm-kernel/msg453447.html Thanks Ludovic Ludo

[PATCH 1/2] mmc: sdhci: set bus voltage before enabling bus power

2015-11-06 Thread Ludovic Desroches
llows the specification then we need to set a valid value. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/mmc/host/sdhci.c | 7 --- 1 file changed, 7 deletions(-) diff --git a/drivers/mmc/host/sdhci.c b/drivers/mmc/host/sdhci.c index ac97b46..0cfd7b2 100644 --

[PATCH 2/2] ARM: at91/dt: sama5d2 Xplained: add regulators for sdhci devices

2015-11-06 Thread Ludovic Desroches
Add vmmc and vqmmc regulators for sdhci devices. The voltage for sdmmc0 vqmmc is selected by a signal from coming from the sdhci device. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 14 ++ 1 file chang

Re: [PATCH 9/9] pinctrl: at91: add missing of_node_put

2015-10-26 Thread Ludovic Desroches
eturn ...; > ) >... > } > // > > Signed-off-by: Julia Lawall Acked-by: Ludovic Desroches > > --- > drivers/pinctrl/pinctrl-at91.c |5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/pinctrl/pinctrl-at91.c b/drive

[PATCH v3] i2c: at91: manage unexpected RXRDY flag when starting a transfer

2015-10-26 Thread Ludovic Desroches
-off-by: Ludovic Desroches Fixes: 93563a6a71bb ("i2c: at91: fix a race condition when using the DMA controller") Reported-by: Peter Rosin Tested-by: Peter Rosin Cc: sta...@vger.kernel.org #4.1 --- Changes from v2: - fix smatch warning: variable 'sr' set but not used drivers/i2c/busse

[PATCH v3] i2c: at91: manage unexpected RXRDY flag when starting a transfer

2015-10-26 Thread Ludovic Desroches
-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Fixes: 93563a6a71bb ("i2c: at91: fix a race condition when using the DMA controller") Reported-by: Peter Rosin <p...@lysator.liu.se> Tested-by: Peter Rosin <p...@lysator.liu.se> Cc: sta...@vger.kernel.org #4.1 --- C

Re: [PATCH 9/9] pinctrl: at91: add missing of_node_put

2015-10-26 Thread Ludovic Desroches
eturn ...; > ) >... > } > // > > Signed-off-by: Julia Lawall <julia.law...@lip6.fr> Acked-by: Ludovic Desroches <ludovic.desroc...@atmel.com> > > --- > drivers/pinctrl/pinctrl-at91.c |5 - > 1 file changed, 4 insertions(+), 1 deletion(-) >

[PATCH v2 2/2] i2c: at91: manage unexpected RXRDY flag when starting a transfer

2015-10-21 Thread Ludovic Desroches
-off-by: Ludovic Desroches Fixes: 93563a6a71bb ("i2c: at91: fix a race condition when using the DMA controller") Reported-by: Peter Rosin Tested-by: Peter Rosin Cc: sta...@vger.kernel.org #4.1 --- drivers/i2c/busses/i2c-at91.c | 33 + 1 file changed, 25

[PATCH v2 1/2] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-21 Thread Ludovic Desroches
eter Rosin Signed-off-by: Ludovic Desroches Tested-by: Peter Rosin Cc: sta...@vger.kernel.org #4.1 --- drivers/i2c/busses/i2c-at91.c | 58 +-- 1 file changed, 50 insertions(+), 8 deletions(-) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-21 Thread Ludovic Desroches
On Wed, Oct 21, 2015 at 09:42:40AM +0200, Peter Rosin wrote: > On 2015-10-21 09:21, Peter Rosin wrote: > > On 2015-10-20 15:27, Ludovic Desroches wrote: > >> On Mon, Oct 19, 2015 at 12:49:03PM +0200, Peter Rosin wrote: > >>> On 2015-10-19 10:51, Ludovic De

[PATCH v2 2/2] i2c: at91: manage unexpected RXRDY flag when starting a transfer

2015-10-21 Thread Ludovic Desroches
-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Fixes: 93563a6a71bb ("i2c: at91: fix a race condition when using the DMA controller") Reported-by: Peter Rosin <p...@lysator.liu.se> Tested-by: Peter Rosin <p...@lysator.liu.se> Cc: sta...@vger.kernel.org #4.1 --- d

[PATCH v2 1/2] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-21 Thread Ludovic Desroches
ce condition when using the DMA controller") Reported-by: Peter Rosin <p...@lysator.liu.se> Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Tested-by: Peter Rosin <p...@lysator.liu.se> Cc: sta...@vger.kernel.org #4.1 --- drivers/i2c/busses/i2c-at91.c | 58 ++

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-21 Thread Ludovic Desroches
On Wed, Oct 21, 2015 at 09:42:40AM +0200, Peter Rosin wrote: > On 2015-10-21 09:21, Peter Rosin wrote: > > On 2015-10-20 15:27, Ludovic Desroches wrote: > >> On Mon, Oct 19, 2015 at 12:49:03PM +0200, Peter Rosin wrote: > >>> On 2015-10-19 10:51, Ludovic De

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-20 Thread Ludovic Desroches
On Mon, Oct 19, 2015 at 12:49:03PM +0200, Peter Rosin wrote: > On 2015-10-19 10:51, Ludovic Desroches wrote: > > Hi Peter, > > > > On Fri, Oct 16, 2015 at 11:08:42AM +0200, Peter Rosin wrote: > >> On 2015-10-16 01:47, Peter Rosin wrote: > >>> On

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-20 Thread Ludovic Desroches
On Mon, Oct 19, 2015 at 12:49:03PM +0200, Peter Rosin wrote: > On 2015-10-19 10:51, Ludovic Desroches wrote: > > Hi Peter, > > > > On Fri, Oct 16, 2015 at 11:08:42AM +0200, Peter Rosin wrote: > >> On 2015-10-16 01:47, Peter Rosin wrote: > >>> On

Re: [PATCH] mmc: sdhci at91: add suspend/resume

2015-10-19 Thread Ludovic Desroches
On Fri, Oct 16, 2015 at 06:33:44PM +0200, Ulf Hansson wrote: > On 16 October 2015 at 17:01, Ludovic Desroches > wrote: > > Add suspend and resume PM ops. > > > > Signed-off-by: Ludovic Desroches > > I have no problem with this patch, nice and easy. > > Alt

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-19 Thread Ludovic Desroches
Hi Peter, On Fri, Oct 16, 2015 at 11:08:42AM +0200, Peter Rosin wrote: > On 2015-10-16 01:47, Peter Rosin wrote: > > On 2015-10-14 07:43, Ludovic Desroches wrote: > >> On Tue, Oct 13, 2015 at 08:01:34PM +0200, Peter Rosin wrote: > >>> On 2015-10-13 18:47, Cyrille

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-19 Thread Ludovic Desroches
Hi Peter, On Fri, Oct 16, 2015 at 11:08:42AM +0200, Peter Rosin wrote: > On 2015-10-16 01:47, Peter Rosin wrote: > > On 2015-10-14 07:43, Ludovic Desroches wrote: > >> On Tue, Oct 13, 2015 at 08:01:34PM +0200, Peter Rosin wrote: > >>> On 2015-10-13 18:47, Cyrille

Re: [PATCH] mmc: sdhci at91: add suspend/resume

2015-10-19 Thread Ludovic Desroches
On Fri, Oct 16, 2015 at 06:33:44PM +0200, Ulf Hansson wrote: > On 16 October 2015 at 17:01, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > Add suspend and resume PM ops. > > > > Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> &g

[PATCH] mmc: sdhci at91: add suspend/resume

2015-10-16 Thread Ludovic Desroches
Add suspend and resume PM ops. Signed-off-by: Ludovic Desroches --- drivers/mmc/host/sdhci-of-at91.c | 55 +++- 1 file changed, 54 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mmc/host/sdhci-of-at91.c index 06d0b50

[PATCH v2 8/8] ARM: multi_v7_defconfig: Add Atmel SDHCI device

2015-10-16 Thread Ludovic Desroches
The AT91 SDHCI device has been introduced with Atmel SAMA5D2 SoC. Signed-off-by: Ludovic Desroches --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 6dcc048..844e921 100644

[PATCH v2 6/8] ARM: multi_v7_defconfig: Add Atmel SAMA5D2 SoC

2015-10-16 Thread Ludovic Desroches
Add Atmel SAMA5D2 SoC family to multi_v7 image. Signed-off-by: Ludovic Desroches --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index bf099b7..63703fa 100644 --- a/arch/arm

[PATCH v2 7/8] ARM: multi_v7_defconfig: Add Atmel Flexcom device

2015-10-16 Thread Ludovic Desroches
The Flexcom device has been introduced with Atmel SAMA5D2 SoC. Signed-off-by: Ludovic Desroches --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index 63703fa..6dcc048 100644

[PATCH v2 5/8] ARM: at91/defconfig: add sama5d2 and its new devices to sama5 defconfig

2015-10-16 Thread Ludovic Desroches
Add SAMA5D2 SoC plus Atmel flexcom and Atmel sdhci devices. Signed-off-by: Ludovic Desroches --- arch/arm/configs/sama5_defconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig index 3b2f686..a0c57ac 100644 --- a/arch

[PATCH v2 3/8] ARM: at91/defconfig: update sama5 defconfig

2015-10-16 Thread Ludovic Desroches
Trivial savedefconfig update. Signed-off-by: Ludovic Desroches --- arch/arm/configs/sama5_defconfig | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig index 31eb951..3b2f686 100644 --- a/arch/arm

[PATCH v2 4/8] ARM: at91/defconfig: update at91_dt defconfig

2015-10-16 Thread Ludovic Desroches
Trivial savedefconfig update. Signed-off-by: Ludovic Desroches --- arch/arm/configs/at91_dt_defconfig | 15 --- 1 file changed, 15 deletions(-) diff --git a/arch/arm/configs/at91_dt_defconfig b/arch/arm/configs/at91_dt_defconfig index 090c5b2..1b1e5ac 100644 --- a/arch/arm/configs

[PATCH v2 1/8] ARM: at91/dt: sama5d2: add missing devices

2015-10-16 Thread Ludovic Desroches
Big update of the sama5d2.dtsi file since many patches have reached te mainline: - add generated clocks - enable crypto devices - add flexcom devices - add tdes device - add sdmmc devices Signed-off-by: Ludovic Desroches Signed-off-by: Nicolas Ferre Signed-off-by: Cyrille Pitchen --- arch/arm

[PATCH v2 2/8] ARM: at91/dt: sama5d2 Xplained: add several devices

2015-10-16 Thread Ludovic Desroches
Add sdmmc and flexcom devices Signed-off-by: Ludovic Desroches Signed-off-by: Cyrille Pitchen --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 106 1 file changed, 106 insertions(+) diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts

[PATCH v2 0/8] Enable several devices for Atmel SAMA5D2

2015-10-16 Thread Ludovic Desroches
Hi, This set of patches enables several devices for the freshly introduced SAMA5D2 SoC. dts and defconfig files are updated to enable SAMA5D2 and its new devices such as Flexcom and AT91 SDHCI. Changes: - v2: - update whole Atmel defconfigs - update multi_v7_defconfig Ludovic Desroches (8

Re: [PATCH 3/3] ARM: at91/defconfig: update sama5 defconfig

2015-10-16 Thread Ludovic Desroches
On Thu, Oct 15, 2015 at 05:42:53PM +0200, Nicolas Ferre wrote: > Le 15/10/2015 17:31, Ludovic Desroches a écrit : > > On Thu, Oct 15, 2015 at 03:24:51PM +0200, Alexandre Belloni wrote: > >> Hi, > >> > >> On 14/10/2015 at 14:11:24 +0200, Ludovic Desroches wrot

Re: [PATCH 3/3] ARM: at91/defconfig: update sama5 defconfig

2015-10-16 Thread Ludovic Desroches
On Thu, Oct 15, 2015 at 05:42:53PM +0200, Nicolas Ferre wrote: > Le 15/10/2015 17:31, Ludovic Desroches a écrit : > > On Thu, Oct 15, 2015 at 03:24:51PM +0200, Alexandre Belloni wrote: > >> Hi, > >> > >> On 14/10/2015 at 14:11:24 +0200, Ludovic Desroches wrot

[PATCH v2 1/8] ARM: at91/dt: sama5d2: add missing devices

2015-10-16 Thread Ludovic Desroches
Big update of the sama5d2.dtsi file since many patches have reached te mainline: - add generated clocks - enable crypto devices - add flexcom devices - add tdes device - add sdmmc devices Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Signed-off-by: Nicolas Ferre <n

[PATCH v2 2/8] ARM: at91/dt: sama5d2 Xplained: add several devices

2015-10-16 Thread Ludovic Desroches
Add sdmmc and flexcom devices Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Signed-off-by: Cyrille Pitchen <cyrille.pitc...@atmel.com> --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 106 1 file changed, 106 insertions(+) diff --gi

[PATCH v2 6/8] ARM: multi_v7_defconfig: Add Atmel SAMA5D2 SoC

2015-10-16 Thread Ludovic Desroches
Add Atmel SAMA5D2 SoC family to multi_v7 image. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_defconfig index b

[PATCH v2 8/8] ARM: multi_v7_defconfig: Add Atmel SDHCI device

2015-10-16 Thread Ludovic Desroches
The AT91 SDHCI device has been introduced with Atmel SAMA5D2 SoC. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_def

[PATCH v2 3/8] ARM: at91/defconfig: update sama5 defconfig

2015-10-16 Thread Ludovic Desroches
Trivial savedefconfig update. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/configs/sama5_defconfig | 11 +-- 1 file changed, 1 insertion(+), 10 deletions(-) diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig index 3

[PATCH v2 4/8] ARM: at91/defconfig: update at91_dt defconfig

2015-10-16 Thread Ludovic Desroches
Trivial savedefconfig update. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/configs/at91_dt_defconfig | 15 --- 1 file changed, 15 deletions(-) diff --git a/arch/arm/configs/at91_dt_defconfig b/arch/arm/configs/at91_dt_defconfig index 090c5b2..1

[PATCH v2 5/8] ARM: at91/defconfig: add sama5d2 and its new devices to sama5 defconfig

2015-10-16 Thread Ludovic Desroches
Add SAMA5D2 SoC plus Atmel flexcom and Atmel sdhci devices. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/configs/sama5_defconfig | 5 + 1 file changed, 5 insertions(+) diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig

[PATCH v2 7/8] ARM: multi_v7_defconfig: Add Atmel Flexcom device

2015-10-16 Thread Ludovic Desroches
The Flexcom device has been introduced with Atmel SAMA5D2 SoC. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/configs/multi_v7_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/multi_v7_defconfig b/arch/arm/configs/multi_v7_def

[PATCH v2 0/8] Enable several devices for Atmel SAMA5D2

2015-10-16 Thread Ludovic Desroches
Hi, This set of patches enables several devices for the freshly introduced SAMA5D2 SoC. dts and defconfig files are updated to enable SAMA5D2 and its new devices such as Flexcom and AT91 SDHCI. Changes: - v2: - update whole Atmel defconfigs - update multi_v7_defconfig Ludovic Desroches (8

[PATCH] mmc: sdhci at91: add suspend/resume

2015-10-16 Thread Ludovic Desroches
Add suspend and resume PM ops. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/mmc/host/sdhci-of-at91.c | 55 +++- 1 file changed, 54 insertions(+), 1 deletion(-) diff --git a/drivers/mmc/host/sdhci-of-at91.c b/drivers/mm

Re: [PATCH] ARM: at91: debug: update prompt for DEBUG_AT91_UART

2015-10-15 Thread Ludovic Desroches
On Thu, Oct 15, 2015 at 04:04:45PM +0200, Alexandre Belloni wrote: > On 14/10/2015 at 09:24:42 +0200, Ludovic Desroches wrote : > > Add (read help!) to DEBUG_AT91_UART prompt. It is not obvious there are > > such useful information to set DEBUG_UART_PHYS. > > > > Signe

Re: [PATCH 3/3] ARM: at91/defconfig: update sama5 defconfig

2015-10-15 Thread Ludovic Desroches
On Thu, Oct 15, 2015 at 03:24:51PM +0200, Alexandre Belloni wrote: > Hi, > > On 14/10/2015 at 14:11:24 +0200, Ludovic Desroches wrote : > > Add SAMA5D2 SoC plus Atmel flexcom and Atmel sdhci devices. > > > > Signed-off-by: Ludovic Desroches > > --- > >

Re: [PATCH 3/3] ARM: at91/defconfig: update sama5 defconfig

2015-10-15 Thread Ludovic Desroches
On Thu, Oct 15, 2015 at 03:24:51PM +0200, Alexandre Belloni wrote: > Hi, > > On 14/10/2015 at 14:11:24 +0200, Ludovic Desroches wrote : > > Add SAMA5D2 SoC plus Atmel flexcom and Atmel sdhci devices. > > > > Signed-off-by: Ludovic Desroches <ludovic.desroc...@at

Re: [PATCH] ARM: at91: debug: update prompt for DEBUG_AT91_UART

2015-10-15 Thread Ludovic Desroches
On Thu, Oct 15, 2015 at 04:04:45PM +0200, Alexandre Belloni wrote: > On 14/10/2015 at 09:24:42 +0200, Ludovic Desroches wrote : > > Add (read help!) to DEBUG_AT91_UART prompt. It is not obvious there are > > such useful information to set DEBUG_UART_PHYS. > > > > Signe

[PATCH 3/3] ARM: at91/defconfig: update sama5 defconfig

2015-10-14 Thread Ludovic Desroches
Add SAMA5D2 SoC plus Atmel flexcom and Atmel sdhci devices. Signed-off-by: Ludovic Desroches --- arch/arm/configs/sama5_defconfig | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig index 31eb951..6e806f5

[PATCH 1/3] ARM: at91/dt: sama5d2: add missing devices

2015-10-14 Thread Ludovic Desroches
Big update of the sama5d2.dtsi file since many patches have reached te mainline: - add generated clocks - enable crypto devices - add flexcom devices - add tdes device - add sdmmc devices Signed-off-by: Ludovic Desroches Signed-off-by: Nicolas Ferre Signed-off-by: Cyrille Pitchen --- arch/arm

[PATCH 2/3] ARM: at91/dt: sama5d2 Xplained: add several devices

2015-10-14 Thread Ludovic Desroches
Add sdmmc and flexcom devices Signed-off-by: Ludovic Desroches Signed-off-by: Cyrille Pitchen --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 106 1 file changed, 106 insertions(+) diff --git a/arch/arm/boot/dts/at91-sama5d2_xplained.dts b/arch/arm/boot/dts

[PATCH] ARM: at91: debug: update prompt for DEBUG_AT91_UART

2015-10-14 Thread Ludovic Desroches
Add (read help!) to DEBUG_AT91_UART prompt. It is not obvious there are such useful information to set DEBUG_UART_PHYS. Signed-off-by: Ludovic Desroches --- arch/arm/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/Kconfig.debug b/arch/arm/Kconfig.debug

[PATCH] ARM: at91: debug: update prompt for DEBUG_AT91_UART

2015-10-14 Thread Ludovic Desroches
Add (read help!) to DEBUG_AT91_UART prompt. It is not obvious there are such useful information to set DEBUG_UART_PHYS. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/Kconfig.debug | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ar

[PATCH 3/3] ARM: at91/defconfig: update sama5 defconfig

2015-10-14 Thread Ludovic Desroches
Add SAMA5D2 SoC plus Atmel flexcom and Atmel sdhci devices. Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- arch/arm/configs/sama5_defconfig | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/c

[PATCH 2/3] ARM: at91/dt: sama5d2 Xplained: add several devices

2015-10-14 Thread Ludovic Desroches
Add sdmmc and flexcom devices Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Signed-off-by: Cyrille Pitchen <cyrille.pitc...@atmel.com> --- arch/arm/boot/dts/at91-sama5d2_xplained.dts | 106 1 file changed, 106 insertions(+) diff --gi

[PATCH 1/3] ARM: at91/dt: sama5d2: add missing devices

2015-10-14 Thread Ludovic Desroches
Big update of the sama5d2.dtsi file since many patches have reached te mainline: - add generated clocks - enable crypto devices - add flexcom devices - add tdes device - add sdmmc devices Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Signed-off-by: Nicolas Ferre <n

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-13 Thread Ludovic Desroches
On Tue, Oct 13, 2015 at 08:01:34PM +0200, Peter Rosin wrote: > On 2015-10-13 18:47, Cyrille Pitchen wrote: > > Le 13/10/2015 17:19, Peter Rosin a écrit : > >> On 2015-10-13 16:21, Ludovic Desroches wrote: > >>> From: Cyrille Pitchen > >>> > >

[PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-13 Thread Ludovic Desroches
eter Rosin Signed-off-by: Ludovic Desroches Cc: sta...@vger.kernel.org #4.1 --- drivers/i2c/busses/i2c-at91.c | 58 +-- 1 file changed, 50 insertions(+), 8 deletions(-) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c index 1c758c

Re: [PATCH 1/2] mmc: sdhci: add quirk SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST

2015-10-13 Thread Ludovic Desroches
On Thu, Oct 08, 2015 at 08:01:23PM +0200, Ulf Hansson wrote: > +Russell > > On 17 September 2015 at 10:16, Ludovic Desroches > wrote: > > The Atmel sdhci device needs a new quirk. sdhci_set_clock set the Clock > > Control Register to 0 before computing t

Re: [PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-13 Thread Ludovic Desroches
On Tue, Oct 13, 2015 at 08:01:34PM +0200, Peter Rosin wrote: > On 2015-10-13 18:47, Cyrille Pitchen wrote: > > Le 13/10/2015 17:19, Peter Rosin a écrit : > >> On 2015-10-13 16:21, Ludovic Desroches wrote: > >>> From: Cyrille Pitchen <cyrille.pitc...@atmel.com&

Re: [PATCH 1/2] mmc: sdhci: add quirk SDHCI_QUIRK2_NEED_DELAY_AFTER_INT_CLK_RST

2015-10-13 Thread Ludovic Desroches
On Thu, Oct 08, 2015 at 08:01:23PM +0200, Ulf Hansson wrote: > +Russell > > On 17 September 2015 at 10:16, Ludovic Desroches > <ludovic.desroc...@atmel.com> wrote: > > The Atmel sdhci device needs a new quirk. sdhci_set_clock set the Clock > > Control Register to 0

[PATCH] i2c: at91: fix write transfers by clearing pending interrupt first

2015-10-13 Thread Ludovic Desroches
ce condition when using the DMA controller") Reported-by: Peter Rosin <p...@lysator.liu.se> Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> Cc: sta...@vger.kernel.org #4.1 --- drivers/i2c/busses/i2c-at91.c | 58 +-- 1 file chan

Re: Regression: at24 eeprom writing

2015-10-05 Thread Ludovic Desroches
Hi Peter On Mon, Oct 05, 2015 at 10:45:29AM +0200, Peter Rosin wrote: > On 2015-10-03 01:05, Peter Rosin wrote: [...] > Ok, I found the culprit, and I double and triple checked it this time... > > If I move to the very latest on the linux-3.18-at91 branch, the bug is > there too. Which made it

Re: [PATCH 1/2] pinctrl: at91-pio4: Use irq_set_handler_locked()

2015-10-05 Thread Ludovic Desroches
Hi Nicolas, On Fri, Oct 02, 2015 at 03:57:32PM +0200, Nicolas Ferre wrote: > Hi all, > > Well it seems my cover letter is missing. So, here it is: > > ---8< > pinctrl: at91-pio4: fixes for current linux-next (irq) > > While testing the sama5d2 on today's linux-next I discovered that some >

Re: [PATCH 1/2] pinctrl: at91-pio4: Use irq_set_handler_locked()

2015-10-05 Thread Ludovic Desroches
Hi Nicolas, On Fri, Oct 02, 2015 at 03:57:32PM +0200, Nicolas Ferre wrote: > Hi all, > > Well it seems my cover letter is missing. So, here it is: > > ---8< > pinctrl: at91-pio4: fixes for current linux-next (irq) > > While testing the sama5d2 on today's linux-next I discovered that some >

Re: Regression: at24 eeprom writing

2015-10-05 Thread Ludovic Desroches
Hi Peter On Mon, Oct 05, 2015 at 10:45:29AM +0200, Peter Rosin wrote: > On 2015-10-03 01:05, Peter Rosin wrote: [...] > Ok, I found the culprit, and I double and triple checked it this time... > > If I move to the very latest on the linux-3.18-at91 branch, the bug is > there too. Which made it

Re: [PATCH 08/16] clk: at91: only enable available IRQs

2015-10-01 Thread Ludovic Desroches
On Wed, Sep 30, 2015 at 06:11:01PM +0200, Alexandre Belloni wrote: > From: Boris Brezillon > > Only enable available IRQs in case writing to a reserved bit has an armful > effect. You probably mean disable instead of enable and s/armful/harmful. > > Signed-off-by: Boris Brezillon >

Re: [PATCH 08/16] clk: at91: only enable available IRQs

2015-10-01 Thread Ludovic Desroches
On Wed, Sep 30, 2015 at 06:11:01PM +0200, Alexandre Belloni wrote: > From: Boris Brezillon > > Only enable available IRQs in case writing to a reserved bit has an armful > effect. You probably mean disable instead of enable and s/armful/harmful. > >

Re: [PATCH v2 2/2] regulator: act8865: add DT binding for property "active-semi, vsel-high"

2015-09-30 Thread Ludovic Desroches
On Wed, Sep 30, 2015 at 03:25:50PM +0800, Wenyou Yang wrote: > Add a DT property "active-semi,vsel-high" to indicate the VSEL pin > is high. If this property is missing, then assume the VSEL pin is > low(0). > > Signed-off-by: Wenyou Yang Reviewed-by: Ludovic Desroches

Re: [PATCH v2 1/2] regulator: act8865: support output voltage by VSET2[] bits

2015-09-30 Thread Ludovic Desroches
> output voltage is programmed by VSET2[] bits. > > The DT property "active-semi,vsel-high" is used to specify > the VSEL pin at high on the board. > > Signed-off-by: Wenyou Yang Minor comment below, it's only my point of view. Anyway, Reviewed-by: Ludovic Desroches

[PATCH 2/2] i2c: at91: update documentation for new "atmel,twd-hold-cycles" property

2015-09-30 Thread Ludovic Desroches
From: Wenyou Yang Add a DT property "atmel,twd-hold-cycles" to specify the HOLD field of TWIHS_CWGR register to increase the TWD hold time. Signed-off-by: Wenyou Yang Signed-off-by: Ludovic Desroches --- Documentation/devicetree/bindings/i2c/i2c-at91.txt | 3 +++ 1 file changed, 3

[PATCH 1/2] i2c: at91: add DT property for the HOLD field of TWIHS_CWGR

2015-09-30 Thread Ludovic Desroches
Signed-off-by: Ludovic Desroches --- drivers/i2c/busses/i2c-at91.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/busses/i2c-at91.c index 1c758cd..06e66ef 100644 --- a/drivers/i2c/busses/i2c-at91.c +++ b/drivers/i2c/

[PATCH 2/2] i2c: at91: update documentation for new "atmel,twd-hold-cycles" property

2015-09-30 Thread Ludovic Desroches
From: Wenyou Yang <wenyou.y...@atmel.com> Add a DT property "atmel,twd-hold-cycles" to specify the HOLD field of TWIHS_CWGR register to increase the TWD hold time. Signed-off-by: Wenyou Yang <wenyou.y...@atmel.com> Signed-off-by: Ludovic Desroches <ludovic.desroc...@atme

[PATCH 1/2] i2c: at91: add DT property for the HOLD field of TWIHS_CWGR

2015-09-30 Thread Ludovic Desroches
eld. Signed-off-by: Wenyou Yang <wenyou.y...@atmel.com> Signed-off-by: Ludovic Desroches <ludovic.desroc...@atmel.com> --- drivers/i2c/busses/i2c-at91.c | 16 +--- 1 file changed, 13 insertions(+), 3 deletions(-) diff --git a/drivers/i2c/busses/i2c-at91.c b/drivers/i2c/bus

Re: [PATCH v2 1/2] regulator: act8865: support output voltage by VSET2[] bits

2015-09-30 Thread Ludovic Desroches
> output voltage is programmed by VSET2[] bits. > > The DT property "active-semi,vsel-high" is used to specify > the VSEL pin at high on the board. > > Signed-off-by: Wenyou Yang <wenyou.y...@atmel.com> Minor comment below, it's only my point of view. Anyway, Rev

Re: [PATCH v2 2/2] regulator: act8865: add DT binding for property "active-semi, vsel-high"

2015-09-30 Thread Ludovic Desroches
On Wed, Sep 30, 2015 at 03:25:50PM +0800, Wenyou Yang wrote: > Add a DT property "active-semi,vsel-high" to indicate the VSEL pin > is high. If this property is missing, then assume the VSEL pin is > low(0). > > Signed-off-by: Wenyou Yang <wenyou.y...@atmel.com>

Re: [PATCH 0/2] Fixes for next

2015-09-28 Thread Ludovic Desroches
Sorry I have forgotten: --in-reply-to=20150925133410.3c9e2...@canb.auug.org.au (linux-next: build failure after merge of the pinctrl tree) On Mon, Sep 28, 2015 at 11:41:11AM +0200, Ludovic Desroches wrote: > Hi Stephen, Linus, > > Here are fixes for next. I did the at91-pio4 patch

[PATCH 1/2] pinctrl: at91-pio4: use irq_set_handler_locked

2015-09-28 Thread Ludovic Desroches
Use irq_set_handler_locked() as it avoids a redundant lookup of the irq descriptor. Signed-off-by: Ludovic Desroches --- drivers/pinctrl/pinctrl-at91-pio4.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/pinctrl/pinctrl-at91-pio4.c b/drivers/pinctrl

<    4   5   6   7   8   9   10   11   12   13   >