Re: [PATCH v6 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2021-03-28 Thread Marcel Ziswiler
Hi Liu On Tue, 2021-03-23 at 17:09 +0800, Liu Ying wrote: > On Tue, 2021-03-23 at 01:03 +0000, Marcel Ziswiler wrote: > > Hi Liu > > > > Some further discrepancy with them binding examples: > > > > arch/arm64/boot/dts/freescale/imx8qxp.dtsi:335.9-36: Warning (re

Re: [PATCH v6 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2021-03-22 Thread Marcel Ziswiler
Hi Liu Some further discrepancy with them binding examples: arch/arm64/boot/dts/freescale/imx8qxp.dtsi:335.9-36: Warning (reg_format): /dpu@5618:reg: property has invalid length (8 bytes) (#address-cells == 2, #size-cells == 2) arch/arm64/boot/dts/freescale/imx8qxp.dtsi:508.9-35: Warning (re

Re: [PATCH v6 05/14] dt-bindings: display: bridge: Add i.MX8qm/qxp display pixel link binding

2021-03-22 Thread Marcel Ziswiler
On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > This patch adds bindings for i.MX8qm/qxp display pixel link. > > Reviewed-by: Rob Herring > Signed-off-by: Liu Ying > --- > v5->v6: > * No change. > > v4->v5: > * No change. > > v3->v4: > * No change. > > v2->v3: > * Add Rob's R-b tag. > >

Re: [PATCH v6 03/14] dt-bindings: display: bridge: Add i.MX8qm/qxp pixel combiner binding

2021-03-22 Thread Marcel Ziswiler
On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > This patch adds bindings for i.MX8qm/qxp pixel combiner. > > Reviewed-by: Rob Herring > Signed-off-by: Liu Ying > --- > v5->v6: > * No change. > > v4->v5: > * No change. > > v3->v4: > * No change. > > v2->v3: > * Add Rob's R-b tag. > > v1-

Re: [PATCH v6 01/14] media: uapi: Add some RGB bus formats for i.MX8qm/qxp pixel combiner

2021-03-22 Thread Marcel Ziswiler
On Wed, 2021-03-17 at 11:42 +0800, Liu Ying wrote: > This patch adds RGB666_1X30_CPADLO, RGB888_1X30_CPADLO, RGB666_1X36_CPADLO > and RGB888_1X36_CPADLO bus formats used by i.MX8qm/qxp pixel combiner. > The RGB pixels with padding low per component are transmitted on a 30-bit > input bus(10-bit per

Re: [PATCH v6 00/14] Add some DRM bridge drivers support for i.MX8qm/qxp SoCs

2021-03-22 Thread Marcel Ziswiler
Hi Liu I gave this a try however I believe I am still missing some piece as it throws the following during compilation of the device tree: arch/arm64/boot/dts/freescale/imx8qxp.dtsi:333.18-439.7: ERROR (phandle_references): /dpu@5618: Reference to non-existent node or label "dc0_irqsteer"

Re: [PATCH 1/2] arm64: boot: dts: add new dts for hellcat & petra

2021-01-21 Thread Marcel Ziswiler
Hi Daniel Is it just me or something looks rather askew with the indentation of your dts' (e.g. tabs vs. spaces)? Cheers Marcel On Thu, 2021-01-21 at 15:12 -0800, Daniel Walker wrote: > Add Petra and Hellcat dts file. These platforms are based on > the Xilinx Zynqmp platform. > > Signed-off-b

Re: [PATCH 1/2] arm64: dts: Add the Kontron i.MX8M-Mini SoMs and baseboards

2020-07-03 Thread Marcel Ziswiler
Hi Frieder Nice to see some more i.MX 8M Mini action. Much appreciated! On Thu, 2020-07-02 at 16:33 +0200, Schrempf Frieder wrote: > From: Frieder Schrempf > > Kontron Electronics GmbH offers small and powerful SoMs based on the > i.MX8MM To avoid much confusion in NXP's nomenclature I would r

[PATCH v1] arm64: dts: freescale: add initial support for colibri imx8x

2019-09-16 Thread Marcel Ziswiler
From: Marcel Ziswiler This patch adds the device tree to support Toradex Colibri iMX8X a computer on module which can be used on different carrier boards. The module consists of a NXP i.MX 8X family SoC (either i.MX 8DualX or 8QuadXPlus), a PF8100 PMIC, a FastEthernet PHY, 1 or 2 GB of LPDDR4

Re: [PATCH v3 21/21] ARM: dts: imx7-colibri: Add UHS support to eval board

2019-08-09 Thread Marcel Ziswiler
Hi Philippe On Wed, 2019-08-07 at 08:26 +, Philippe Schenker wrote: > This commit adds UHS capability to Toradex Eval Boards How about any other carrier board? > Signed-off-by: Philippe Schenker > > --- > > Changes in v3: > - New patch to make use of ARM: dts: imx7-colibri: fix 1.8V/UHS >

Re: [PATCH v3 20/21] ARM: dts: imx6ull-colibri: Add touchscreen used with Eval Board

2019-08-09 Thread Marcel Ziswiler
Hi Philippe On Wed, 2019-08-07 at 08:26 +, Philippe Schenker wrote: > This adds the common touchscreen that is used with Toradex's > Eval Boards. Is that really Eval Board specific? > Signed-off-by: Philippe Schenker > > --- > > Changes in v3: None > Changes in v2: > - Removed f0710a, tha

Re: [PATCH v3 19/21] ARM: dts: imx6/7-colibri: switch dr_mode to otg

2019-08-09 Thread Marcel Ziswiler
Hi Philippe On Wed, 2019-08-07 at 08:26 +, Philippe Schenker wrote: > In order for the otg ports, that these modules support, it is needed > that dr_mode is on otg. Switch to use that feature. Isn't further extcon integration required for this to truly work? > Signed-off-by: Philippe Schenke

Re: [PATCH v3 18/21] ARM: dts: imx6ull-colibri: Add general wakeup key used on Colibri

2019-08-09 Thread Marcel Ziswiler
On Wed, 2019-08-07 at 08:26 +, Philippe Schenker wrote: > This adds the possibility to wake the module with an external signal > as defined in the Colibri standard > > Signed-off-by: Philippe Schenker Acked-by: Marcel Ziswiler > --- > > Changes in v3: None

Re: [PATCH v3 17/21] ARM: dts: imx6ull: improve can templates

2019-08-09 Thread Marcel Ziswiler
Hi Philippe On Wed, 2019-08-07 at 08:26 +, Philippe Schenker wrote: > From: Max Krummenacher > > Add the pinmuxing and a inactive node for flexcan1 on SODIMM 55/63 > and move the inactive flexcan nodes to imx6ull-colibri-eval-v3.dtsi > where they belong. > > Note that this commit does not e

Re: [PATCH v3 16/21] ARM: dts: imx6ull-colibri: Add watchdog

2019-08-09 Thread Marcel Ziswiler
On Wed, 2019-08-07 at 08:26 +, Philippe Schenker wrote: > This patch adds the watchdog to the imx6ull-colibri devicetree > > Signed-off-by: Philippe Schenker Acked-by: Marcel Ziswiler > --- > > Changes in v3: None > Changes in v2: None > > arch/arm/boot/dt

Re: [PATCH v3 15/21] ARM: dts: imx6ull-colibri: reduce v_batt current in power off

2019-08-09 Thread Marcel Ziswiler
> the > module for TAMPER7 and TAMPER9 SoC pin and switches on a pull down > instead of a pullup for the USBC_DET module pin (TAMPER2). > > Signed-off-by: Max Krummenacher > Signed-off-by: Philippe Schenker Acked-by: Marcel Ziswiler > --- > > Changes in v3: None > Cha

Re: [PATCH v3 14/21] ARM: dts: imx6ull-colibri: Add sleep mode to fec

2019-08-09 Thread Marcel Ziswiler
On Wed, 2019-08-07 at 08:26 +, Philippe Schenker wrote: > Do not change the clock as the power for this phy is switched > with that clock. > > Signed-off-by: Philippe Schenker Acked-by: Marcel Ziswiler > --- > > Changes in v3: None > Changes in v2: None > &

Re: [PATCH v3 13/21] ARM: dts: imx6-colibri: Add missing pinmuxing to Toradex eval board

2019-08-09 Thread Marcel Ziswiler
On Wed, 2019-08-07 at 08:26 +, Philippe Schenker wrote: > This patch adds some missing pinmuxing that is in the colibri > standard to the dts. > > Signed-off-by: Philippe Schenker Acked-by: Marcel Ziswiler > --- > > Changes in v3: None > Changes in v2: > -

Re: [PATCH v3 12/21] ARM: dts: imx6-apalis: Add touchscreens used on Toradex eval boards

2019-08-09 Thread Marcel Ziswiler
Hi Philippe On Wed, 2019-08-07 at 08:26 +, Philippe Schenker wrote: > This commit adds the touchscreens from Toradex so one can enable it. > > Signed-off-by: Philippe Schenker > > --- > > Changes in v3: > - Fix commit title to "...imx6-apalis:..." > > Changes in v2: > - Deleted touchrevol

Re: [PATCH v3 11/21] ARM: dts: imx6qdl-apalis: Add sleep state to can interfaces

2019-08-09 Thread Marcel Ziswiler
> > Signed-off-by: Philippe Schenker Acked-by: Marcel Ziswiler > --- > > Changes in v3: None > Changes in v2: > - Changed commit title to '...imx6qdl-apalis:...' > > arch/arm/boot/dts/imx6qdl-apalis.dtsi | 27 +-- > > 1 file c

Re: [PATCH v3 10/21] ARM: dts: imx6qdl-colibri: Add missing pin declaration in iomuxc

2019-08-09 Thread Marcel Ziswiler
On Wed, 2019-08-07 at 08:26 +, Philippe Schenker wrote: > This adds the muxing for the optional pins usb-oc (overcurrent) and > usb-id. > > Signed-off-by: Philippe Schenker Acked-by: Marcel Ziswiler > --- > > Changes in v3: None > Changes in v2: None > &

Re: [PATCH v3 09/21] ARM: dts: imx6qdl-colibri: add phy to fec

2019-08-09 Thread Marcel Ziswiler
d-off-by: Philippe Schenker Acked-by: Marcel Ziswiler > --- > > Changes in v3: None > Changes in v2: None > > arch/arm/boot/dts/imx6qdl-colibri.dtsi | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/arch/arm/boot/dts/imx6qdl-colibri.dtsi >

Re: [PATCH v3 08/21] ARM: dts: imx7-colibri: Add touch controllers

2019-08-09 Thread Marcel Ziswiler
On Wed, 2019-08-07 at 08:26 +, Philippe Schenker wrote: > Add touch controller that is connected over an I2C bus. > > Signed-off-by: Philippe Schenker Acked-by: Marcel Ziswiler > --- > > Changes in v3: > - Fix commit message > > Changes in v2: > - Dele

Re: [PATCH v3 07/21] ARM: dts: imx7-colibri: fix 1.8V/UHS support

2019-08-09 Thread Marcel Ziswiler
by the carrier > board. > > Signed-off-by: Stefan Agner > Signed-off-by: Philippe Schenker Acked-by: Marcel Ziswiler > --- > > Changes in v3: > - Add new commit message from Stefan's proposal on ML > > Changes in v2: None > > arch/arm/boot/dts/imx7-col

Re: [PATCH v3 06/21] ARM: dts: imx7-colibri: add GPIO wakeup key

2019-08-09 Thread Marcel Ziswiler
On Wed, 2019-08-07 at 08:26 +, Philippe Schenker wrote: > From: Stefan Agner > > Add wakeup GPIO key which is able to wake the system from sleep > modes (e.g. Suspend-to-Memory). > > Signed-off-by: Stefan Agner > Signed-off-by: Philippe Schenker Acke

Re: [PATCH v3 05/21] ARM: dts: add recovery for I2C for iMX7

2019-08-09 Thread Marcel Ziswiler
On Wed, 2019-08-07 at 08:26 +, Philippe Schenker wrote: > From: Oleksandr Suvorov > > - add recovery mode for applicable i2c buses for > Colibri iMX7 module. > > Signed-off-by: Oleksandr Suvorov > Signed-off-by: Philippe Schenker Acked-by: Marcel Ziswiler >

Re: [PATCH v3 04/21] ARM: dts: imx7-colibri: Add sleep mode to ethernet

2019-08-09 Thread Marcel Ziswiler
On Wed, 2019-08-07 at 08:26 +, Philippe Schenker wrote: > Add sleep pinmux to the fec so it can properly sleep. > > Signed-off-by: Philippe Schenker Acked-by: Marcel Ziswiler > --- > > Changes in v3: None > Changes in v2: None > > arch/arm/boot

Re: [PATCH v3 03/21] ARM: dts: imx7-colibri: prepare module device tree for FlexCAN

2019-08-09 Thread Marcel Ziswiler
Philippe Schenker Acked-by: Marcel Ziswiler > --- > > Changes in v3: None > Changes in v2: None > > arch/arm/boot/dts/imx7-colibri.dtsi | 35 --- > -- > 1 file changed, 30 insertions(+), 5 deletions(-) > > diff --git a/arch/arm/boot/

Re: [PATCH v3 02/21] ARM: dts: imx7-colibri: disable HS400

2019-08-09 Thread Marcel Ziswiler
tus REF not lock! > > Signed-off-by: Stefan Agner > Signed-off-by: Philippe Schenker Acked-by: Marcel Ziswiler > --- > > Changes in v3: None > Changes in v2: None > > arch/arm/boot/dts/imx7-colibri.dtsi | 1 + > 1 file changed, 1 insertion(+) > > dif

Re: [PATCH v2 1/1] ARM: dts: colibri: introduce dts with UHS-I support enabled

2019-07-08 Thread Marcel Ziswiler
Hi Marco On Tue, 2019-07-02 at 14:51 +0200, Marco Felsch wrote: > Hi Igor, > > On 19-07-02 09:42, Igor Opaniuk wrote: > > Hi Marco, > > > > On Tue, Jul 2, 2019 at 10:27 AM Marco Felsch < > > m.fel...@pengutronix.de> wrote: > > > Hi Igor, > > > > > > On 19-05-14 17:38, Igor Opaniuk wrote: > > >

Re: [PATCH v1 1/6] ASoC: sgtl5000: Fix definition of VAG Ramp Control

2019-06-24 Thread Marcel Ziswiler
On Wed, 2019-06-19 at 10:00 +, Oleksandr Suvorov wrote: > > > > From: Marcel Ziswiler > > Sent: Thursday, June 13, 2019 12:05 > > To: feste...@gmail.com; Oleksandr Suvorov > > Cc: Igor Opaniuk; linux-kernel@vger.ke

Re: [PATCH v1 2/6] ASoC: sgtl5000: add ADC mute control

2019-06-13 Thread Marcel Ziswiler
On Tue, 2019-05-21 at 13:36 +0300, Oleksandr Suvorov wrote: > This control mute/unmute the ADC input of SGTL5000 > using its CHIP_ANA_CTRL register. > > Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler > --- > > sound/soc/codecs/sgtl5000.c | 1 + > 1 f

Re: [PATCH v1 1/6] ASoC: sgtl5000: Fix definition of VAG Ramp Control

2019-06-13 Thread Marcel Ziswiler
On Tue, 2019-05-21 at 13:36 +0300, Oleksandr Suvorov wrote: > SGTL5000_SMALL_POP is a bit mask, not a value. Usage of > correct definition makes device probing code more clear. > > Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler > --- > > sound/soc/

Re: [PATCH v1 3/6] ASoC: sgtl5000: Fix of unmute outputs on probe

2019-06-13 Thread Marcel Ziswiler
On Tue, 2019-05-21 at 13:36 +0300, Oleksandr Suvorov wrote: > To enable "zero cross detect" for ADC/HP, change > HP_ZCD_EN/ADC_ZCD_EN bits only instead of writing the whole > CHIP_ANA_CTRL register. > > Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler >

Re: [PATCH v1 5/6] ASoC: Define a set of DAPM pre/post-up events

2019-06-13 Thread Marcel Ziswiler
On Tue, 2019-05-21 at 13:36 +0300, Oleksandr Suvorov wrote: > Prepare to use SND_SOC_DAPM_PRE_POST_PMU definition to > reduce coming code size and make it more readable. > > Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler > --- > > include/sound/soc-da

Re: [PATCH v1 6/6] ASoC: sgtl5000: Improve VAG power and mute control

2019-06-13 Thread Marcel Ziswiler
oid any pops/clicks, > the outputs should be muted during input/output > routing changes. > > Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler > --- > > sound/soc/codecs/sgtl5000.c | 227 +++--- > -- > 1 file changed, 195 ins

Re: [PATCH v1 4/6] ASoC: sgtl5000: Fix charge pump source assignment

2019-06-13 Thread Marcel Ziswiler
On Tue, 2019-05-21 at 13:36 +0300, Oleksandr Suvorov wrote: > If VDDA != VDDIO and any of them is greater than 3.1V, charge pump > source can be assigned automatically. > > Signed-off-by: Oleksandr Suvorov Reviewed-by: Marcel Ziswiler > --- > > sound/soc/c

Re: [PATCH 1/1] ARM: dts: imx6ull-colibri: enable UHS-I for USDHC1

2019-06-06 Thread Marcel Ziswiler
igned-off-by: Igor Opaniuk Reviewed-by: Marcel Ziswiler > --- > arch/arm/boot/dts/imx6ul.dtsi | 4 > arch/arm/boot/dts/imx6ull-colibri-eval-v3.dtsi | 11 +-- > arch/arm/boot/dts/imx6ull-colibri.dtsi | 6 ++ > 3 files changed, 19 insertions(

Re: [PATCH v2 1/1] ARM: dts: colibri: introduce dts with UHS-I support enabled

2019-05-24 Thread Marcel Ziswiler
peration > mode. > > Signed-off-by: Igor Opaniuk Acked-by: Marcel Ziswiler > --- > > v2: > - rework hierarchy of dts files, and a separate dtsi for Colibri > iMX6S/DL V1.1x re-design, where UHS-I was added > - add comments about vgen3 power rail > - fix other minor issues,

Re: [PATCH v1 1/1] ARM: dts: colibri: introduce dts with UHS-I support enabled

2019-05-13 Thread Marcel Ziswiler
Hi Igor On Mon, 2019-05-06 at 11:51 +, Igor Opaniuk wrote: > Hi Marcel, > > On Thu, Apr 25, 2019 at 11:47 AM Marcel Ziswiler > wrote: > > Hi Igor > > > > Sorry, for my late reply but this one got stuck in my private > > email. > > > > On Th

Re: [PATCH v1 1/1] ARM: dts: colibri: introduce dts with UHS-I support enabled

2019-04-25 Thread Marcel Ziswiler
Hi Igor Sorry, for my late reply but this one got stuck in my private email. On Thu, 2019-04-04 at 11:19 +0200, Igor Opaniuk wrote: > Introduce DTS for Colibri iMX6DL with proper configuration for VGEN3, > which allows that rail to be automatically switched to 1.8 volts for > proper UHS-I operati

Re: [PATCH v2 2/2] ARM: dts: tegra124-apalis: convert to SPDX license tags

2019-04-17 Thread Marcel Ziswiler
On Wed, 2019-04-17 at 10:54 +0200, Thierry Reding wrote: > On Wed, Apr 17, 2019 at 08:13:51AM +0200, Marcel Ziswiler wrote: > > +// SPDX-License-Identifier: (GPL-2.0 OR X11) > > > > I believe the parentheses don't really server any purpose here. > > With that: &g

Re: [PATCH] net: usb: asix: ax88772_bind return error when hw_reset fail

2019-01-24 Thread Marcel Ziswiler
zed): Failed to read > reg index 0x: -71 > ... > > Signed-off-by: Zhang Run > Reviewed-by: Yang Wei Tested-by: Marcel Ziswiler > --- > drivers/net/usb/asix_devices.c | 9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > > diff --git a/drivers

Re: [PATCH] net: fec: get regulator optional

2019-01-21 Thread Marcel Ziswiler
c 2188000.ethernet: 2188000.ethernet supply phy not found, using > dummy regulator > > Signed-off-by: Stefan Agner Reviewed-by: Marcel Ziswiler > --- > drivers/net/ethernet/freescale/fec_main.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/dri

Re: [PATCH v5 8/8] ARM: dts: Add stmpe-adc DT node to Toradex T30 modules

2019-01-09 Thread Marcel Ziswiler
On Fri, 2018-12-21 at 14:46 +0100, Philippe Schenker wrote: > From: Philippe Schenker > > Add the stmpe-adc DT node as found on Toradex T30 modules > > Signed-off-by: Philippe Schenker Acked-by: Marcel Ziswiler > --- > > Changes in v5: None > Changes in v4: >

Re: [PATCH v5 7/8] ARM: dts: Add stmpe-adc DT node to Toradex iMX6 modules

2019-01-09 Thread Marcel Ziswiler
On Fri, 2018-12-21 at 14:46 +0100, Philippe Schenker wrote: > From: Philippe Schenker > > Add the stmpe-adc DT node as found on Toradex iMX6 modules > > Signed-off-by: Philippe Schenker Acked-by: Marcel Ziswiler > --- > > Changes in v5: None > Changes in v4

Re: [REGRESSION] imx_v6_v7_defconfig: undefined reference to `__hyp_stub_vectors'

2018-12-19 Thread Marcel Ziswiler
On Wed, 2018-12-19 at 12:20 -0200, Fabio Estevam wrote: > Hi Daniel, > > On Wed, Dec 19, 2018 at 11:32 AM Daniel Baluta < > daniel.bal...@gmail.com> wrote: > > On Wed, Dec 19, 2018 at 3:17 PM Daniel Baluta < > > daniel.bal...@nxp.com> wrote: > > > &g

[REGRESSION] imx_v6_v7_defconfig: undefined reference to `__hyp_stub_vectors'

2018-12-19 Thread Marcel Ziswiler
Hi there I noticed that at least today's and yesterdays -next won't build with the imx_v6_v7_defconfig giving the following error: LD arch/arm/boot/compressed/vmlinux arch/arm/boot/compressed/head.o: In function `restart': (.text+0xa8): undefined reference to `__hyp_stub_vectors' (.text+0x

Re: [PATCH v1 2/3] clk: tegra: ignore unused vfir clock shared with uartb

2018-12-10 Thread Marcel Ziswiler
On November 28, 2018 10:24:04 AM GMT+01:00, Thierry Reding wrote: >On Thu, Nov 01, 2018 at 10:41:52AM +0200, Peter De Schrijver wrote: >> On Thu, Nov 01, 2018 at 02:52:29AM +0100, Marcel Ziswiler wrote: >> > From: Marcel Ziswiler >> > >> > As UARTB and

Re: [PATCH 4.14 069/143] ARM: tegra: Fix ULPI regression on Tegra20

2018-11-06 Thread Marcel Ziswiler
On Tue, 2018-11-06 at 01:31 -0500, Sasha Levin wrote: > On Mon, Nov 05, 2018 at 02:05:49PM +0000, Marcel Ziswiler wrote: > > On Fri, 2018-11-02 at 22:02 -0400, Sasha Levin wrote: > > > On Fri, Nov 02, 2018 at 07:56:57PM +, Sudip Mukherjee wrote: > > > > Hi Greg,

Re: [PATCH 4.14 069/143] ARM: tegra: Fix ULPI regression on Tegra20

2018-11-05 Thread Marcel Ziswiler
On Fri, 2018-11-02 at 22:02 -0400, Sasha Levin wrote: > On Fri, Nov 02, 2018 at 07:56:57PM +, Sudip Mukherjee wrote: > > Hi Greg, > > > > On Fri, Nov 2, 2018 at 6:53 PM Greg Kroah-Hartman > > wrote: > > > > > > 4.14-stable review patch. If anyone has any objections, please > > > let me know

[PATCH v1 2/3] clk: tegra: ignore unused vfir clock shared with uartb

2018-10-31 Thread Marcel Ziswiler
From: Marcel Ziswiler As UARTB and VFIR share their clock enable bit it is rather unwise for the kernel to turn off the VFIR one should that be unused (and potentially vice versa but so far there anyway is no VFIR driver). Without this patch trying to use UARTB with the regular 8250 driver will

[PATCH v1 3/3] serial: tegra: fix some spelling mistakes

2018-10-31 Thread Marcel Ziswiler
From: Marcel Ziswiler Fix a few spelling mistakes I stumbled upon while debugging a customers UART issues. Signed-off-by: Marcel Ziswiler --- drivers/tty/serial/serial-tegra.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/tty/serial/serial-tegra.c b

[PATCH v1 1/3] clk: tegra: get rid of duplicate defines

2018-10-31 Thread Marcel Ziswiler
From: Marcel Ziswiler Get rid of 3 duplicate defines. Signed-off-by: Marcel Ziswiler --- drivers/clk/tegra/clk-tegra-periph.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/clk/tegra/clk-tegra-periph.c b/drivers/clk/tegra/clk-tegra-periph.c index 38c4eb28c8bf..cc5275ec2c01

[PATCH v1 0/3] clk/serial tegra: uart related fixes

2018-10-31 Thread Marcel Ziswiler
This series features some UART related clock issue fix and clean-up. Marcel Ziswiler (3): clk: tegra: get rid of duplicate defines clk: tegra: ignore unused vfir clock shared with uartb serial: tegra: fix some spelling mistakes drivers/clk/tegra/clk-tegra-periph.c | 5 + drivers

[PATCH v1 2/3] ASoC: soc-core: fix trivial checkpatch issues

2018-10-18 Thread Marcel Ziswiler
From: Marcel Ziswiler Fix a few trivial aka cosmetic only checkpatch issues like long lines, wrong indentations, spurious blanks and newlines, missing newlines, multi-line comments etc. Signed-off-by: Marcel Ziswiler --- Changes in v1: None sound/soc/soc-core.c | 146

[PATCH v1 1/3] ASoC: tegra_sgtl5000: fix device_node refcounting

2018-10-18 Thread Marcel Ziswiler
From: Marcel Ziswiler Similar to the following: commit 4321723648b0 ("ASoC: tegra_alc5632: fix device_node refcounting") commit 7c5dfd549617 ("ASoC: tegra: fix device_node refcounting") Signed-off-by: Marcel Ziswiler Acked-by: Jon Hunter --- Changes in v1: No

[PATCH v1 0/3] ASoC: last minute fixes

2018-10-18 Thread Marcel Ziswiler
This series comes with some last minutes fixes and clean-up. Changes in v1: - Split from the Tegra series as suggested by Mark. - Fix issue in soc-core rather than working around it in tegra_sgtl5000. Marcel Ziswiler (3): ASoC: tegra_sgtl5000: fix device_node refcounting ASoC: soc-core

[PATCH v1 3/3] ASoC: soc-core: fix platform name vs. of_node assignement

2018-10-18 Thread Marcel Ziswiler
From: Marcel Ziswiler This fixes the following error as seen post commit daecf46ee0e5 ("ASoC: soc-core: use snd_soc_dai_link_component for platform") on Apalis TK1 after initial probe deferral: tegra-snd-sgtl5000 sound: ASoC: Both platform name/of_node are set for sgtl5000 tegra-sn

[PATCH v3 3/7] ARM: tegra: colibri_t20: reorder pmic properties

2018-10-18 Thread Marcel Ziswiler
From: Marcel Ziswiler Reorder PMIC properties to be more in-line with any of our other device trees. Signed-off-by: Marcel Ziswiler --- Changes in v3: None Changes in v2: None Changes in v1: None arch/arm/boot/dts/tegra20-colibri.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions

[PATCH v3 7/7] ARM: tegra: apalis_t30: further regulator clean-up

2018-10-18 Thread Marcel Ziswiler
From: Marcel Ziswiler Rename label vdd2_reg to reg_1v05. Rename label ldo6_reg to reg_1v05_avdd_plle. Drop unused labels. Rename regulator tps62362-vout to +V1.2_VDD_CORE. Reorder TPS65911 properties. Rename +V1.05 to +V1.05_AVDD_PLLE. Add ti,en-ck32k-xtal. Specify TPS62362 vin-supply. Drop

[PATCH v3 6/7] ARM: tegra: colibri_t30: further regulator clean-up

2018-10-18 Thread Marcel Ziswiler
From: Marcel Ziswiler Drop unused labels. Rename regulator tps62362-vout to +V1.2_VDD_CORE. Reorder TPS65911 properties. Rename +V1.05 to +V1.05_AVDD_PLLE. Add ti,en-ck32k-xtal. Specify TPS62362 vin-supply. Signed-off-by: Marcel Ziswiler --- Changes in v3: None Changes in v2: None Changes in

[PATCH v3 4/7] ARM: tegra: apalis-tk1: further regulator clean-up

2018-10-18 Thread Marcel Ziswiler
From: Marcel Ziswiler Add reg_ prefix to vddio_sdmmc1 and vddio_sdmmc3. Reorder PMIC properties. Signed-off-by: Marcel Ziswiler --- Changes in v3: None Changes in v2: None Changes in v1: None arch/arm/boot/dts/tegra124-apalis-eval.dts | 4 ++-- arch/arm/boot/dts/tegra124-apalis-v1.2

[PATCH v3 0/7] ARM: dts: tegra: last minute fixes

2018-10-18 Thread Marcel Ziswiler
- Added 2 new patches improving/fixing audio on Apalis TK1. Changes in v1: - Remove simple-panel compatible as suggested by Rob. Marcel Ziswiler (7): ARM: tegra: fix simple-panel compatibles ARM: tegra: apalis-tk1/colibri_t20/t30: eval/iris: fix regulator gpio enable ARM: tegra: colibri_t2

[PATCH v3 5/7] ARM: tegra: apalis_t30/tk1: annotate power I2C being on-module

2018-10-18 Thread Marcel Ziswiler
From: Marcel Ziswiler The power I2C bus aka PWR_I2C which connects to the audio codec, PMIC, temperature sensor and touch screen controller is really on-module only. Signed-off-by: Marcel Ziswiler --- Changes in v3: None Changes in v2: None Changes in v1: None arch/arm/boot/dts/tegra124

[PATCH v3 1/7] ARM: tegra: fix simple-panel compatibles

2018-10-18 Thread Marcel Ziswiler
From: Marcel Ziswiler As there is no such thing as a generic simple-panel compatible remove them. Signed-off-by: Marcel Ziswiler --- Changes in v3: None Changes in v2: None Changes in v1: - Remove simple-panel compatible as suggested by Rob. arch/arm/boot/dts/tegra114-dalmore.dts

[PATCH v3 2/7] ARM: tegra: apalis-tk1/colibri_t20/t30: eval/iris: fix regulator gpio enable

2018-10-18 Thread Marcel Ziswiler
From: Marcel Ziswiler Anything other than the default active-low would require the separate property enable-active-high to be set. This gets rid of the following warning during boot: regulator-usbh-vbus GPIO handle specifies active low - ignored resp.: regulator-1v05-avdd-hdmi-pll GPIO

Re: [PATCH v2 9/9] ASoC: tegra_sgtl5000: fix platform name vs. of_node assignement

2018-10-17 Thread Marcel Ziswiler
On Wed, 2018-10-17 at 20:16 +0100, Mark Brown wrote: > On Wed, Oct 17, 2018 at 02:28:22PM +0000, Marcel Ziswiler wrote: > > > Some questions: > > - How exactly are devm allocations supposed to work concerning > > probe > > deferrals? > > Probe deferrals are

Re: [PATCH v2 9/9] ASoC: tegra_sgtl5000: fix platform name vs. of_node assignement

2018-10-17 Thread Marcel Ziswiler
On Wed, 2018-10-17 at 13:32 +0100, Jon Hunter wrote: > On 16/10/2018 11:47, Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > > > This fixes the following error as seen post commit daecf46ee0e5 > > ("ASoC: soc-core: use snd_soc_dai_link_component for platfor

Re: [PATCH v2 2/2] clk: tegra20: Enable lock-status polling for PLLs

2018-10-17 Thread Marcel Ziswiler
On Fri, 2018-08-31 at 12:29 +0300, Peter De Schrijver wrote: > On Thu, Aug 30, 2018 at 09:42:10PM +0300, Dmitry Osipenko wrote: > > Currently all PLL's on Tegra20 use a hardcoded delay despite of > > having > > a lock-status bit. The lock-status polling was disabled ~7 years > > ago > > because PLL

Re: [PATCH v2 0/9] ARM: dts: tegra: last minute fixes

2018-10-17 Thread Marcel Ziswiler
On Tue, 2018-10-16 at 12:58 +0100, Mark Brown wrote: > On Tue, Oct 16, 2018 at 12:47:21PM +0200, Marcel Ziswiler wrote: > > > Marcel Ziswiler (9): > > ARM: tegra: fix simple-panel compatibles > > ARM: tegra: apalis-tk1/colibri_t20/t30: eval/iris: fix regulator

Re: [PATCH v2 0/9] ARM: dts: tegra: last minute fixes

2018-10-16 Thread Marcel Ziswiler
On Tue, 2018-10-16 at 12:58 +0100, Mark Brown wrote: > On Tue, Oct 16, 2018 at 12:47:21PM +0200, Marcel Ziswiler wrote: > > > Marcel Ziswiler (9): > > ARM: tegra: fix simple-panel compatibles > > ARM: tegra: apalis-tk1/colibri_t20/t30: eval/iris: fix regulator

[PATCH v2 8/9] ASoC: tegra_sgtl5000: fix device_node refcounting

2018-10-16 Thread Marcel Ziswiler
From: Marcel Ziswiler Similar to the following: commit 4321723648b0 ("ASoC: tegra_alc5632: fix device_node refcounting") commit 7c5dfd549617 ("ASoC: tegra: fix device_node refcounting") Signed-off-by: Marcel Ziswiler --- Changes in v2: New patch sound/soc/tegra/t

[PATCH v2 3/9] ARM: tegra: colibri_t20: reorder pmic properties

2018-10-16 Thread Marcel Ziswiler
From: Marcel Ziswiler Reorder PMIC properties to be more in-line with any of our other device trees. Signed-off-by: Marcel Ziswiler --- Changes in v2: None Changes in v1: None arch/arm/boot/dts/tegra20-colibri.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

[PATCH v2 9/9] ASoC: tegra_sgtl5000: fix platform name vs. of_node assignement

2018-10-16 Thread Marcel Ziswiler
From: Marcel Ziswiler This fixes the following error as seen post commit daecf46ee0e5 ("ASoC: soc-core: use snd_soc_dai_link_component for platform"): tegra-snd-sgtl5000 sound: ASoC: Both platform name/of_node are set for sgtl5000 tegra-snd-sgtl5000 sound: ASoC: failed to init lin

[PATCH v2 0/9] ARM: dts: tegra: last minute fixes

2018-10-16 Thread Marcel Ziswiler
mple-panel compatible as suggested by Rob. Marcel Ziswiler (9): ARM: tegra: fix simple-panel compatibles ARM: tegra: apalis-tk1/colibri_t20/t30: eval/iris: fix regulator gpio enable ARM: tegra: colibri_t20: reorder pmic properties ARM: tegra: apalis-tk1: further regulator clean-up

[PATCH v2 7/9] ARM: tegra: apalis_t30: further regulator clean-up

2018-10-16 Thread Marcel Ziswiler
From: Marcel Ziswiler Rename label vdd2_reg to reg_1v05. Rename label ldo6_reg to reg_1v05_avdd_plle. Drop unused labels. Rename regulator tps62362-vout to +V1.2_VDD_CORE. Reorder TPS65911 properties. Rename +V1.05 to +V1.05_AVDD_PLLE. Add ti,en-ck32k-xtal. Specify TPS62362 vin-supply. Drop

[PATCH v2 4/9] ARM: tegra: apalis-tk1: further regulator clean-up

2018-10-16 Thread Marcel Ziswiler
From: Marcel Ziswiler Add reg_ prefix to vddio_sdmmc1 and vddio_sdmmc3. Reorder PMIC properties. Signed-off-by: Marcel Ziswiler --- Changes in v2: None Changes in v1: None arch/arm/boot/dts/tegra124-apalis-eval.dts | 4 ++-- arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts | 4

[PATCH v2 2/9] ARM: tegra: apalis-tk1/colibri_t20/t30: eval/iris: fix regulator gpio enable

2018-10-16 Thread Marcel Ziswiler
From: Marcel Ziswiler Anything other than the default active-low would require the separate property enable-active-high to be set. This gets rid of the following warning during boot: regulator-usbh-vbus GPIO handle specifies active low - ignored resp.: regulator-1v05-avdd-hdmi-pll GPIO

[PATCH v2 1/9] ARM: tegra: fix simple-panel compatibles

2018-10-16 Thread Marcel Ziswiler
From: Marcel Ziswiler As there is no such thing as a generic simple-panel compatible remove them. Signed-off-by: Marcel Ziswiler --- Changes in v2: None Changes in v1: - Remove simple-panel compatible as suggested by Rob. arch/arm/boot/dts/tegra114-dalmore.dts | 3 +-- arch/arm

[PATCH v2 6/9] ARM: tegra: colibri_t30: further regulator clean-up

2018-10-16 Thread Marcel Ziswiler
From: Marcel Ziswiler Drop unused labels. Rename regulator tps62362-vout to +V1.2_VDD_CORE. Reorder TPS65911 properties. Rename +V1.05 to +V1.05_AVDD_PLLE. Add ti,en-ck32k-xtal. Specify TPS62362 vin-supply. Signed-off-by: Marcel Ziswiler --- Changes in v2: None Changes in v1: None arch/arm

[PATCH v2 5/9] ARM: tegra: apalis_t30/tk1: annotate power I2C being on-module

2018-10-16 Thread Marcel Ziswiler
From: Marcel Ziswiler The power I2C bus aka PWR_I2C which connects to the audio codec, PMIC, temperature sensor and touch screen controller is really on-module only. Signed-off-by: Marcel Ziswiler --- Changes in v2: None Changes in v1: None arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 5

Re: [PATCH v1 3/8] ARM: tegra: apalis/colibri_t30: fix hdmi regulator

2018-10-12 Thread Marcel Ziswiler
On Fri, 2018-10-12 at 11:44 +0100, Jon Hunter wrote: > On 09/10/18 16:25, Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > ... > > > Given Linus W's fix for the gpiolib [0], I am not convinced that this > is > really better/needed. Looks like nobody else f

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-12 Thread Marcel Ziswiler
On Fri, 2018-10-12 at 13:59 +0100, Russell King - ARM Linux wrote: > On Fri, Oct 12, 2018 at 11:43:13AM +0000, Marcel Ziswiler wrote: > > I don't think it is that fictitious as it makes it crystal clear > > that > > there is something shared with all its pros and cons. E.

Re: [PATCH v1 3/8] ARM: tegra: apalis/colibri_t30: fix hdmi regulator

2018-10-12 Thread Marcel Ziswiler
On Fri, 2018-10-12 at 11:44 +0100, Jon Hunter wrote: > On 09/10/18 16:25, Marcel Ziswiler wrote: > > From: Marcel Ziswiler > > ... > > > Given Linus W's fix for the gpiolib [0], I am not convinced that this > is > really better/needed. Being pragmatic at the

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-12 Thread Marcel Ziswiler
On Fri, 2018-10-12 at 11:43 +0100, Russell King - ARM Linux wrote: > On Fri, Oct 12, 2018 at 11:39:15AM +0100, Jon Hunter wrote: > > We had the same situation for Tegra124 Jetson TK1 but I don't think > > that > > adding a pseudo intermediate regulator is cleaner. If the GPIO > > controls > > more

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-12 Thread Marcel Ziswiler
On Thu, 2018-10-11 at 19:47 +0200, Linus Walleij wrote: > On Thu, Oct 11, 2018 at 5:34 PM Marcel Ziswiler > wrote: > > > I guess that is also what broke HDMI on Apalis/Colibri T30 causing > > me > > to submit a fix [1]. I may also help testing. > > I see the

Re: REGRESSION: [PATCH v5 3/3] gpiolib: Show correct direction from the beginning

2018-10-12 Thread Marcel Ziswiler
On Fri, 2018-10-12 at 11:08 +0200, Linus Walleij wrote: > On Fri, Oct 12, 2018 at 11:00 AM Marcel Ziswiler > wrote: > > On Fri, 2018-10-05 at 08:53 +0200, Ricardo Ribalda Delgado wrote: > > > Current code assumes that the direction is input if > > > directi

REGRESSION: [PATCH v5 3/3] gpiolib: Show correct direction from the beginning

2018-10-12 Thread Marcel Ziswiler
On Fri, 2018-10-05 at 08:53 +0200, Ricardo Ribalda Delgado wrote: > Current code assumes that the direction is input if direction_input > function is set. > This might not be the case on GPIOs with programmable direction. Unfortunately, this breaks at least Apalis T30 and Apalis TK1. Enabling earl

Re: [PATCH v7] regulator: fixed: Convert to use GPIO descriptor only

2018-10-11 Thread Marcel Ziswiler
Hi Linus On Thu, 2018-10-11 at 16:00 +0100, Jon Hunter wrote: > Hi Linus, > > On 11/10/18 10:29, Linus Walleij wrote: > > On Thu, Oct 11, 2018 at 11:01 AM Marek Szyprowski > > wrote: > > > > > I've just noticed that this patch causes regression on Samsung > > > Exynos4412-based Trats2 board. Co

[PATCH v1 2/8] ARM: tegra: apalis-tk1/colibri_t20/t30: eval/iris: fix regulator gpio enable

2018-10-09 Thread Marcel Ziswiler
From: Marcel Ziswiler Anything other than the default active-low would require the separate property enable-active-high to be set. This gets rid of the following warning during boot: regulator-usbh-vbus GPIO handle specifies active low - ignored resp.: regulator-1v05-avdd-hdmi-pll GPIO

[PATCH v1 6/8] ARM: tegra: apalis_t30/tk1: annotate power I2C being on-module

2018-10-09 Thread Marcel Ziswiler
From: Marcel Ziswiler The power I2C bus aka PWR_I2C which connects to the audio codec, PMIC, temperature sensor and touch screen controller is really on-module only. Signed-off-by: Marcel Ziswiler --- Changes in v1: None arch/arm/boot/dts/tegra124-apalis-v1.2.dtsi | 5 - arch/arm/boot

[PATCH v1 7/8] ARM: tegra: colibri_t30: further regulator clean-up

2018-10-09 Thread Marcel Ziswiler
From: Marcel Ziswiler Drop unused labels. Rename regulator tps62362-vout to +V1.2_VDD_CORE. Reorder TPS65911 properties. Rename +V1.05 to +V1.05_AVDD_PLLE. Add ti,en-ck32k-xtal. Specify TPS62362 vin-supply. Signed-off-by: Marcel Ziswiler --- Changes in v1: None arch/arm/boot/dts/tegra30

[PATCH v1 8/8] ARM: tegra: apalis_t30: further regulator clean-up

2018-10-09 Thread Marcel Ziswiler
From: Marcel Ziswiler Rename label vdd2_reg to reg_1v05. Rename label ldo6_reg to reg_1v05_avdd_plle. Drop unused labels. Rename regulator tps62362-vout to +V1.2_VDD_CORE. Reorder TPS65911 properties. Rename +V1.05 to +V1.05_AVDD_PLLE. Add ti,en-ck32k-xtal. Specify TPS62362 vin-supply. Drop

[PATCH v1 3/8] ARM: tegra: apalis/colibri_t30: fix hdmi regulator

2018-10-09 Thread Marcel Ziswiler
From: Marcel Ziswiler Fix HDMI requiring two regulators being enabled by a single GPIO. Model this using an intermediate reg_en_vdd_hdmi regulator being the vin-supply of them other two. This fixes the display subsystem and gets rid of the following error during boot: reg-fixed-voltage: probe

[PATCH v1 4/8] ARM: tegra: colibri_t20: reorder pmic properties

2018-10-09 Thread Marcel Ziswiler
From: Marcel Ziswiler Reorder PMIC properties to be more in-line with any of our other device trees. Signed-off-by: Marcel Ziswiler --- Changes in v1: None arch/arm/boot/dts/tegra20-colibri.dtsi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/arm/boot/dts

[PATCH v1 5/8] ARM: tegra: apalis-tk1: further regulator clean-up

2018-10-09 Thread Marcel Ziswiler
From: Marcel Ziswiler Add reg_ prefix to vddio_sdmmc1 and vddio_sdmmc3. Reorder PMIC properties. Signed-off-by: Marcel Ziswiler --- Changes in v1: None arch/arm/boot/dts/tegra124-apalis-eval.dts | 4 ++-- arch/arm/boot/dts/tegra124-apalis-v1.2-eval.dts | 4 ++-- arch/arm/boot/dts

[PATCH v1 1/8] ARM: tegra: fix simple-panel compatibles

2018-10-09 Thread Marcel Ziswiler
From: Marcel Ziswiler As there is no such thing as a generic simple-panel compatible remove them. Signed-off-by: Marcel Ziswiler --- Changes in v1: - Remove simple-panel compatible as suggested by Rob. arch/arm/boot/dts/tegra114-dalmore.dts | 3 +-- arch/arm/boot/dts/tegra124

[PATCH v1 0/8] ARM: dts: tegra: last minute fixes

2018-10-09 Thread Marcel Ziswiler
This series comes with some last minutes fixes and further clean-up. Marcel Ziswiler (8): ARM: tegra: fix simple-panel compatibles ARM: tegra: apalis-tk1/colibri_t20/t30: eval/iris: fix regulator gpio enable ARM: tegra: apalis/colibri_t30: fix hdmi regulator ARM: tegra: colibri_t20

Re: [PATCH v2 00/37] ARM: dts: tegra: colibri_t20: major revamp incl. eval board support

2018-09-26 Thread Marcel Ziswiler
Hi Thierry On September 26, 2018 4:56:46 PM GMT+02:00, Thierry Reding wrote: >On Sun, Sep 02, 2018 at 12:08:29PM +0200, Marcel Ziswiler wrote: >> This series is a major overhaul and adds support for the Colibri >> Evaluation Board device tree. >> >> Changes in

  1   2   3   4   5   6   7   >