Re: [PATCH v3] staging: pi433: replace simple switch statements

Hi Dan, I'd like to mention once more, that the idea of the abstraction was to support multiple modules of Hope-RF. If the decision of the "team" of developer of this driver is, that it should be reduced to a Pi433 or RFM69CW driver only, I fully agree, that the abstraction layer isn't

Re: [PATCH v3] staging: pi433: replace simple switch statements

Hi Dan, I'd like to mention once more, that the idea of the abstraction was to support multiple modules of Hope-RF. If the decision of the "team" of developer of this driver is, that it should be reduced to a Pi433 or RFM69CW driver only, I fully agree, that the abstraction layer isn't

Re: [PATCH v3] staging: pi433: replace simple switch statements

Reviewed-by: Marcus Wolf Thank you Valentin, very nice patch :-) Valentin Vidic schrieb am 24.06.2018 18:31: Use const array to map switch cases to resulting values. Signed-off-by: Valentin Vidic --- v2: use correct type for const arrays v3: add missing static keyword for af_map drivers

Re: [PATCH v3] staging: pi433: replace simple switch statements

Reviewed-by: Marcus Wolf Thank you Valentin, very nice patch :-) Valentin Vidic schrieb am 24.06.2018 18:31: Use const array to map switch cases to resulting values. Signed-off-by: Valentin Vidic --- v2: use correct type for const arrays v3: add missing static keyword for af_map drivers

Re: pi433: initialization of tx config in pi433_open()

Hi Hugo, thank you for all your work on Pi433 driver. For a better understanding some info about Pi433 and the ideas behind it. Pi433 was developed by me in order to have a simple to mount CE-compliant 433MHz shield for the Raspberry Pi. I wanted to put it on sale on the one side and develop a

Re: pi433: initialization of tx config in pi433_open()

Hi Hugo, thank you for all your work on Pi433 driver. For a better understanding some info about Pi433 and the ideas behind it. Pi433 was developed by me in order to have a simple to mount CE-compliant 433MHz shield for the Raspberry Pi. I wanted to put it on sale on the one side and develop a

Re: rf69_set_deviation in rf69.c (pi433 driver)

Hi Hugo, sorry for the late response and thank you for all that deep investigation in the pi433 driver! > According to the datasheet[0], the deviation should always be smaller > than 300kHz, and the following equation should be respected: > > (1) FDA + BRF/2 =< 500 kHz > > Why did you choose

Re: rf69_set_deviation in rf69.c (pi433 driver)

Hi Hugo, sorry for the late response and thank you for all that deep investigation in the pi433 driver! > According to the datasheet[0], the deviation should always be smaller > than 300kHz, and the following equation should be respected: > > (1) FDA + BRF/2 =< 500 kHz > > Why did you choose

Re: [PATCH v2] staging: pi433: cleanup tx_fifo locking

Reviewed-by: Marcus Wolf <marcus.w...@wolf-entwicklungen.de> Am 19.04.2018 um 12:25 schrieb Valentin Vidic: > pi433_write requires locking due to multiple writers. After acquiring > the lock check if enough free space is available in the kfifo to write > the whole message. Th

Re: [PATCH v2] staging: pi433: cleanup tx_fifo locking

Reviewed-by: Marcus Wolf Am 19.04.2018 um 12:25 schrieb Valentin Vidic: > pi433_write requires locking due to multiple writers. After acquiring > the lock check if enough free space is available in the kfifo to write > the whole message. This check should prevent partial writes to tx_

Re: [PATCH] staging: pi433: add descriptions for mutex locks

Hi! So if you like, give me your address, and I'll send you two development samples of Pi433. Cheers, Marcus Am 19.04.2018 um 11:47 schrieb Valentin Vidic: > On Thu, Apr 19, 2018 at 11:25:19AM +0200, Marcus Wolf wrote: >> let me know, what you like to have. For sure with just on

Re: [PATCH] staging: pi433: add descriptions for mutex locks

Hi! So if you like, give me your address, and I'll send you two development samples of Pi433. Cheers, Marcus Am 19.04.2018 um 11:47 schrieb Valentin Vidic: > On Thu, Apr 19, 2018 at 11:25:19AM +0200, Marcus Wolf wrote: >> let me know, what you like to have. For sure with just on

Re: [PATCH] staging: pi433: add descriptions for mutex locks

Am 12.04.2018 um 20:46 schrieb Valentin Vidic: > On Sun, Apr 08, 2018 at 05:22:46PM +0200, Marcus Wolf wrote: >> Regarding your patch, I did not understand, why you did not remove >> the mutex_lock in pi433_write. Wasn't it the goal to remove it? > > Is it possible for mo

Re: [PATCH] staging: pi433: add descriptions for mutex locks

Am 12.04.2018 um 20:46 schrieb Valentin Vidic: > On Sun, Apr 08, 2018 at 05:22:46PM +0200, Marcus Wolf wrote: >> Regarding your patch, I did not understand, why you did not remove >> the mutex_lock in pi433_write. Wasn't it the goal to remove it? > > Is it possible for mo

Re: [PATCH] staging: pi433: add descriptions for mutex locks

Am 12.04.2018 um 19:15 schrieb Valentin Vidic: > On Sun, Apr 08, 2018 at 04:15:30PM +0200, Marcus Wolf wrote: >> The hardware of Pi433 is working with every Raspberry Pi (on zero, you >> need to solder the GPIO-pins) and with several other fruits like banana >> pi. The on

Re: [PATCH] staging: pi433: add descriptions for mutex locks

Am 12.04.2018 um 19:15 schrieb Valentin Vidic: > On Sun, Apr 08, 2018 at 04:15:30PM +0200, Marcus Wolf wrote: >> The hardware of Pi433 is working with every Raspberry Pi (on zero, you >> need to solder the GPIO-pins) and with several other fruits like banana >> pi. The on

Re: [PATCH] staging: pi433: add descriptions for mutex locks

25.03.2018 um 15:09 schrieb Valentin Vidic: > On Sun, Mar 25, 2018 at 03:00:09PM +0200, Marcus Wolf wrote: >> Unfortunaly I can't find the time to have a closer look on the code this >> weekend - still busy with tax stuff :-( >> >> Idea sounds great. I'll try to look at the

Re: [PATCH] staging: pi433: add descriptions for mutex locks

25.03.2018 um 15:09 schrieb Valentin Vidic: > On Sun, Mar 25, 2018 at 03:00:09PM +0200, Marcus Wolf wrote: >> Unfortunaly I can't find the time to have a closer look on the code this >> weekend - still busy with tax stuff :-( >> >> Idea sounds great. I'll try to look at the

Re: [PATCH] staging: pi433: add descriptions for mutex locks

um 16:24 schrieb Valentin Vidic: > On Sun, Mar 25, 2018 at 03:12:52PM +0200, Marcus Wolf wrote: >> I am not at home the next two weeks. So I can do a codereading on >> Easter, but testing will not take place earlier then mid/end of April :-( >> >> If you are in

Re: [PATCH] staging: pi433: add descriptions for mutex locks

um 16:24 schrieb Valentin Vidic: > On Sun, Mar 25, 2018 at 03:12:52PM +0200, Marcus Wolf wrote: >> I am not at home the next two weeks. So I can do a codereading on >> Easter, but testing will not take place earlier then mid/end of April :-( >> >> If you are in

Re: [PATCH] staging: pi433: add descriptions for mutex locks

: > On Sun, Mar 25, 2018 at 03:00:09PM +0200, Marcus Wolf wrote: >> Unfortunaly I can't find the time to have a closer look on the code this >> weekend - still busy with tax stuff :-( >> >> Idea sounds great. I'll try to look at the code and think about it >> during

Re: [PATCH] staging: pi433: add descriptions for mutex locks

: > On Sun, Mar 25, 2018 at 03:00:09PM +0200, Marcus Wolf wrote: >> Unfortunaly I can't find the time to have a closer look on the code this >> weekend - still busy with tax stuff :-( >> >> Idea sounds great. I'll try to look at the code and think about it >> during

Re: [PATCH] staging: pi433: add descriptions for mutex locks

hollidays. Cheers, Marcus -- Smarthome-Wolf UG (haftungsbeschränkt) Helene-Lange-Weg 23 80637 München Amtsgericht München, HRB 223529 Umastzsteuer-ID: DE304719911 Geschäftsführer: Marcus Wolf

Re: [PATCH] staging: pi433: add descriptions for mutex locks

hollidays. Cheers, Marcus -- Smarthome-Wolf UG (haftungsbeschränkt) Helene-Lange-Weg 23 80637 München Amtsgericht München, HRB 223529 Umastzsteuer-ID: DE304719911 Geschäftsführer: Marcus Wolf

Re: [PATCH] staging: pi433: add descriptions for mutex locks

100, Marcus Wolf wrote: >> could you please decribe in short words, why you think, that hte lock >> isn't obsolete? >> >> I wasn't sure, but close to remove the lock. That's why I putted the >> comment. > > Sure, if pi433_tx_thread runs on one CPU it might be poss

Re: [PATCH] staging: pi433: add descriptions for mutex locks

100, Marcus Wolf wrote: >> could you please decribe in short words, why you think, that hte lock >> isn't obsolete? >> >> I wasn't sure, but close to remove the lock. That's why I putted the >> comment. > > Sure, if pi433_tx_thread runs on one CPU it might be poss

Re: [PATCH] staging: pi433: add descriptions for mutex locks

ränkt) Helene-Lange-Weg 23 80637 München Amtsgericht München, HRB 223529 Umastzsteuer-ID: DE304719911 Geschäftsführer: Marcus Wolf

Re: [PATCH] staging: pi433: add descriptions for mutex locks

rx_position; > - struct mutexrx_lock; > + struct mutexrx_lock; /* serialize read requests */ > wait_queue_head_t rx_wait_queue; > > /* fifo wait queue */ > -- Smarthome-Wolf UG (haftungsbeschränkt) Helene-Lange-Weg 23 80637 München Amtsgericht München, HRB 223529 Umastzsteuer-ID: DE304719911 Geschäftsführer: Marcus Wolf

Re: [PATCH] staging: pi433: remove unnecessary parentheses

Joe Perches schrieb am 10.01.2018 10:05: > On Wed, 2018-01-10 at 09:44 +0100, Greg Kroah-Hartman wrote: > > On Tue, Jan 09, 2018 at 11:42:16AM -0800, Joe Perches wrote: > > > if (a == b && c == d) > > > is pretty trivial. > > > > But again, don't do that. > > We disagree. Life goes on. > >

Re: [PATCH] staging: pi433: remove unnecessary parentheses

Joe Perches schrieb am 10.01.2018 10:05: > On Wed, 2018-01-10 at 09:44 +0100, Greg Kroah-Hartman wrote: > > On Tue, Jan 09, 2018 at 11:42:16AM -0800, Joe Perches wrote: > > > if (a == b && c == d) > > > is pretty trivial. > > > > But again, don't do that. > > We disagree. Life goes on. > >

[PATCH] Staging: Pi433: Bugfix for wrong argument for sizeof() in TX thread

sizeof(array) != sizeof(pointer to array) Fixes: "staging: pi433: reduce stack size in tx thread" Signed-off-by: Marcus Wolf <li...@wolf-entwicklungen.de> --- drivers/staging/pi433/pi433_if.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a

[PATCH] Staging: Pi433: Bugfix for wrong argument for sizeof() in TX thread

sizeof(array) != sizeof(pointer to array) Fixes: "staging: pi433: reduce stack size in tx thread" Signed-off-by: Marcus Wolf --- drivers/staging/pi433/pi433_if.c | 13 ++--- 1 file changed, 6 insertions(+), 7 deletions(-) diff --git a/drivers/staging/pi433/pi433_if.c

Re: [PATCH 6/6] staging: pi433: Rename enum modShaping in rf69_enum.h

Am 04.12.2017 um 21:18 schrieb Dan Carpenter: On Mon, Dec 04, 2017 at 08:59:35PM +0200, Marcus Wolf wrote: Am 04.12.2017 um 12:33 schrieb Dan Carpenter: On Sun, Dec 03, 2017 at 04:17:26PM +0100, Simon Sandström wrote: diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433

Re: [PATCH 6/6] staging: pi433: Rename enum modShaping in rf69_enum.h

Am 04.12.2017 um 21:18 schrieb Dan Carpenter: On Mon, Dec 04, 2017 at 08:59:35PM +0200, Marcus Wolf wrote: Am 04.12.2017 um 12:33 schrieb Dan Carpenter: On Sun, Dec 03, 2017 at 04:17:26PM +0100, Simon Sandström wrote: diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433

rf69_get_lna_gain

Hi! This is an information for all of you, doing experiments with real hardware! I wanted to explain, what this lna_gain stuff is used for: If you are receiving messages from different sender (let's say several thermometers), it may happen (e. g. due to different distance and different

rf69_get_lna_gain

Hi! This is an information for all of you, doing experiments with real hardware! I wanted to explain, what this lna_gain stuff is used for: If you are receiving messages from different sender (let's say several thermometers), it may happen (e. g. due to different distance and different

Re: [PATCH 6/8 v3] staging: pi433: use defines for shifting register values

Am 13.12.2017 um 19:44 schrieb Valentin Vidic: Avoid shifting by magic numbers and use defines instead. Signed-off-by: Valentin Vidic --- v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE - move shifting to the header file v3: - drop auto case - use

Re: [PATCH 6/8 v3] staging: pi433: use defines for shifting register values

Am 13.12.2017 um 19:44 schrieb Valentin Vidic: Avoid shifting by magic numbers and use defines instead. Signed-off-by: Valentin Vidic --- v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE - move shifting to the header file v3: - drop auto case - use CURRENT suffix -

Re: [PATCH 6/8 v2] staging: pi433: use defines for shifting register values

Am 13.12.2017 um 18:55 schrieb Valentin Vidic: Avoid shifting by magic numbers and use defines instead. Signed-off-by: Valentin Vidic --- v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE - move shifting to the header file drivers/staging/pi433/rf69.c

Re: [PATCH 6/8 v2] staging: pi433: use defines for shifting register values

Am 13.12.2017 um 18:55 schrieb Valentin Vidic: Avoid shifting by magic numbers and use defines instead. Signed-off-by: Valentin Vidic --- v2: - drop change for SHIFT_DATAMODUL_MODULATION_TYPE - move shifting to the header file drivers/staging/pi433/rf69.c | 16

Re: [PATCH 6/8] staging: pi433: use defines for shifting register values

nchen, HRB 223529 Umastzsteuer-ID: DE304719911 Geschäftsführer: Marcus Wolf

Re: [PATCH 6/8] staging: pi433: use defines for shifting register values

0x07 +#define SHIFT_LNA_CURRENT_GAIN3 #define LNA_GAIN_AUTO0x00 /* default */ #define LNA_GAIN_MAX 0x01 -- Smarthome-Wolf UG (haftungsbeschränkt) Helene-Lange-Weg 23 80637 München Amtsgericht München, HRB 223529 Umastzsteuer-ID: DE304719911 Geschäftsführer: Marcus Wolf

Re: [PATCH 4/8] staging: pi433: add parentheses to mask and shift

UTO: return automatic; case LNA_GAIN_MAX: return max; case LNA_GAIN_MAX_MINUS_6: return maxMinus6; -- Smarthome-Wolf UG (haftungsbeschränkt) Helene-Lange-Weg 23 80637 München Amtsgericht München, HRB 223529 Umastzsteuer-ID: DE304719911 Geschäftsführer: Marcus Wolf

Re: [PATCH 4/8] staging: pi433: add parentheses to mask and shift

ic; case LNA_GAIN_MAX: return max; case LNA_GAIN_MAX_MINUS_6: return maxMinus6; -- Smarthome-Wolf UG (haftungsbeschränkt) Helene-Lange-Weg 23 80637 München Amtsgericht München, HRB 223529 Umastzsteuer-ID: DE304719911 Geschäftsführer: Marcus Wolf

staging: pi433: Plans from Smarthome-Wolf

Am 06.12.2017 um 14:47 schrieb Dan Carpenter: > On Wed, Dec 06, 2017 at 11:11:27AM +0200, Marcus Wolf wrote: >> >> Since the rule for kernel development seems to be, not to care about future, >> most probably you patch is fine, anyway. >> > > Yeah. Deleting cod

staging: pi433: Plans from Smarthome-Wolf

Am 06.12.2017 um 14:47 schrieb Dan Carpenter: > On Wed, Dec 06, 2017 at 11:11:27AM +0200, Marcus Wolf wrote: >> >> Since the rule for kernel development seems to be, not to care about future, >> most probably you patch is fine, anyway. >> > > Yeah. Deleting cod

Re: [PATCH 5/6] staging: pi433: Move enum option_on_off to pi433_if.h

Am 06.12.2017 um 22:42 schrieb Simon Sandström: The enum is now only used for ioctl, so move it pi433_if.h. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.h | 5 + drivers/staging/pi433/rf69_enum.h | 5 - 2 files changed, 5 insertions(+), 5

Re: [PATCH 5/6] staging: pi433: Move enum option_on_off to pi433_if.h

Am 06.12.2017 um 22:42 schrieb Simon Sandström: The enum is now only used for ioctl, so move it pi433_if.h. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.h | 5 + drivers/staging/pi433/rf69_enum.h | 5 - 2 files changed, 5 insertions(+), 5 deletions(-) diff

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 06.12.2017 um 21:57 schrieb Simon Sandström: On Wed, Dec 06, 2017 at 01:44:14PM +0300, Dan Carpenter wrote: On Wed, Dec 06, 2017 at 12:31:31PM +0200, Marcus Wolf wrote: Am 06.12.2017 um 12:23 schrieb Dan Carpenter: Wow... This was the one patch I thought was going to sink

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 06.12.2017 um 21:57 schrieb Simon Sandström: On Wed, Dec 06, 2017 at 01:44:14PM +0300, Dan Carpenter wrote: On Wed, Dec 06, 2017 at 12:31:31PM +0200, Marcus Wolf wrote: Am 06.12.2017 um 12:23 schrieb Dan Carpenter: Wow... This was the one patch I thought was going to sink

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

is new (mainline for just something like 2 monthes) and stil under devel, I think we should "risk" it. Gruß, Marcus > Am 06.12.2017 um 11:44 schrieb Dan Carpenter <dan.carpen...@oracle.com>: > >> On Wed, Dec 06, 2017 at 12:31:31PM +0200, Marcus Wolf wrote: >> >

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

is new (mainline for just something like 2 monthes) and stil under devel, I think we should "risk" it. Gruß, Marcus > Am 06.12.2017 um 11:44 schrieb Dan Carpenter : > >> On Wed, Dec 06, 2017 at 12:31:31PM +0200, Marcus Wolf wrote: >> >> >>> Am 06.12.2017

Re: [PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

>> >> rf69 -set/get - action >> -> rf69_set_crc_enable > > No... Simon's name is better. His is shorter and makes more sense. I disagree. If I am going to implement a new functionality and need to think about the naming of the function name, every time I need to change a register setting

Re: [PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

>> >> rf69 -set/get - action >> -> rf69_set_crc_enable > > No... Simon's name is better. His is shorter and makes more sense. I disagree. If I am going to implement a new functionality and need to think about the naming of the function name, every time I need to change a register setting

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 06.12.2017 um 12:23 schrieb Dan Carpenter: On Wed, Dec 06, 2017 at 11:46:41AM +0200, Marcus Wolf wrote: diff --git a/drivers/staging/pi433/rf69_enum.h b/drivers/staging/pi433/rf69_enum.h index babe597e2ec6..5247e9269de9 100644 --- a/drivers/staging/pi433/rf69_enum.h +++ b/drivers/staging

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 06.12.2017 um 12:23 schrieb Dan Carpenter: On Wed, Dec 06, 2017 at 11:46:41AM +0200, Marcus Wolf wrote: diff --git a/drivers/staging/pi433/rf69_enum.h b/drivers/staging/pi433/rf69_enum.h index babe597e2ec6..5247e9269de9 100644 --- a/drivers/staging/pi433/rf69_enum.h +++ b/drivers/staging

Re: [PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

Am 06.12.2017 um 11:37 schrieb Dan Carpenter: On Wed, Dec 06, 2017 at 11:05:22AM +0200, Marcus Wolf wrote: Am 06.12.2017 um 00:08 schrieb Simon Sandström: Splits rf69_set_crc_enabled(dev, enabled) into rf69_enable_crc(dev) and rf69_disable_crc(dev). Signed-off-by: Simon Sandström <

Re: [PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

Am 06.12.2017 um 11:37 schrieb Dan Carpenter: On Wed, Dec 06, 2017 at 11:05:22AM +0200, Marcus Wolf wrote: Am 06.12.2017 um 00:08 schrieb Simon Sandström: Splits rf69_set_crc_enabled(dev, enabled) into rf69_enable_crc(dev) and rf69_disable_crc(dev). Signed-off-by: Simon Sandström

Re: [PATCH] staging: pi433: Fixes issue with bit shift in rf69_get_modulation

Am 06.12.2017 um 11:02 schrieb Greg KH: On Wed, Nov 08, 2017 at 07:13:56PM +0200, Marcus Wolf wrote: Fixes issue with bit shift in rf69_get_modulation What "issue"? Signed-off-by: Marcus Wolf <li...@wolf-entwicklungen.de> --- drivers/staging/pi433/rf69.c |2 +- 1

Re: [PATCH] staging: pi433: Fixes issue with bit shift in rf69_get_modulation

Am 06.12.2017 um 11:02 schrieb Greg KH: On Wed, Nov 08, 2017 at 07:13:56PM +0200, Marcus Wolf wrote: Fixes issue with bit shift in rf69_get_modulation What "issue"? Signed-off-by: Marcus Wolf --- drivers/staging/pi433/rf69.c |2 +- 1 file changed, 1 insertion(+),

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 06.12.2017 um 00:08 schrieb Simon Sandström: Renames the enum optionOnOff and its values optionOn, optionOff to enum option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings: "Avoid CamelCase: , , ". Signed-off-by: Simon Sandström ---

Re: [PATCH v2 04/11] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 06.12.2017 um 00:08 schrieb Simon Sandström: Renames the enum optionOnOff and its values optionOn, optionOff to enum option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings: "Avoid CamelCase: , , ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 34

Re: [PATCH v2 09/11] staging: pi433: Combine all rf69_set_amplifier_x()

Am 06.12.2017 um 00:08 schrieb Simon Sandström: Replaces the functions rf69_set_amplifier_1, _2, _3 with two functions: rf69_enable_amplifier(dev, amp_mask) and rf69_disable_amplifier(dev, amp_mask). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 6

Re: [PATCH v2 09/11] staging: pi433: Combine all rf69_set_amplifier_x()

Am 06.12.2017 um 00:08 schrieb Simon Sandström: Replaces the functions rf69_set_amplifier_1, _2, _3 with two functions: rf69_enable_amplifier(dev, amp_mask) and rf69_disable_amplifier(dev, amp_mask). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 6 +++---

Re: [PATCH v2 08/11] staging: pi433: Remove enum data_mode

Am 06.12.2017 um 00:08 schrieb Simon Sandström: Call rf69_set_data_mode with DATAMODUL_MODE value directly. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 15 ++- drivers/staging/pi433/rf69.h

Re: [PATCH v2 08/11] staging: pi433: Remove enum data_mode

Am 06.12.2017 um 00:08 schrieb Simon Sandström: Call rf69_set_data_mode with DATAMODUL_MODE value directly. Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 2 +- drivers/staging/pi433/rf69.c | 15 ++- drivers/staging/pi433/rf69.h | 2 +-

Re: [PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

Am 06.12.2017 um 00:08 schrieb Simon Sandström: Splits rf69_set_crc_enabled(dev, enabled) into rf69_enable_crc(dev) and rf69_disable_crc(dev). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 22 -- drivers/staging/pi433/rf69.c

Re: [PATCH v2 06/11] staging: pi433: Split rf69_set_crc_enabled into two functions

Am 06.12.2017 um 00:08 schrieb Simon Sandström: Splits rf69_set_crc_enabled(dev, enabled) into rf69_enable_crc(dev) and rf69_disable_crc(dev). Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 22 -- drivers/staging/pi433/rf69.c | 18

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 05.12.2017 um 13:16 schrieb Dan Carpenter: > On Mon, Dec 04, 2017 at 09:59:02PM +0200, Marcus Wolf wrote: >> Keep in mind, that if you split the functions, in the interface >> implementation you also need more code: >> >> SET_CHECKED(rf69_set_sync_enable(de

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 05.12.2017 um 13:16 schrieb Dan Carpenter: > On Mon, Dec 04, 2017 at 09:59:02PM +0200, Marcus Wolf wrote: >> Keep in mind, that if you split the functions, in the interface >> implementation you also need more code: >> >> SET_CHECKED(rf69_set_sync_enable(de

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 04.12.2017 um 21:05 schrieb Simon Sandström: > On Mon, Dec 04, 2017 at 09:59:02PM +0200, Marcus Wolf wrote: >> >> Hi Simon, hi Dan, >> >> if you both are of the same opinion, for me, it's fine, if we go with two >> functions. >> >> But I do

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 04.12.2017 um 21:05 schrieb Simon Sandström: > On Mon, Dec 04, 2017 at 09:59:02PM +0200, Marcus Wolf wrote: >> >> Hi Simon, hi Dan, >> >> if you both are of the same opinion, for me, it's fine, if we go with two >> functions. >> >> But I do

[PATCH V3] staging: pi433: rf69.c: Replace macros READ_REG and WRITE_REG with smarter functions

introduced by this patch, but were long and camel cased before. Signed-off-by: Marcus Wolf <li...@wolf-entwicklungen.de> --- drivers/staging/pi433/rf69.c | 336 ++ 1 file changed, 180 insertions(+), 156 deletions(-) diff --git a/drivers/staging/pi43

[PATCH V3] staging: pi433: rf69.c: Replace macros READ_REG and WRITE_REG with smarter functions

introduced by this patch, but were long and camel cased before. Signed-off-by: Marcus Wolf --- drivers/staging/pi433/rf69.c | 336 ++ 1 file changed, 180 insertions(+), 156 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433

[PATCH V2] staging: pi433: rf69.c: Replace macros READ_REG and WRITE_REG with inline functions rf69_set_bit, rf69_reset_bit and rf69_read_modify_write

introduced by this patch, but were long and camel cased before. Signed-off-by: Marcus Wolf <li...@wolf-entwicklungen.de> --- drivers/staging/pi433/rf69.c | 336 ++ 1 file changed, 180 insertions(+), 156 deletions(-) diff --git a/drivers/staging/pi43

[PATCH V2] staging: pi433: rf69.c: Replace macros READ_REG and WRITE_REG with inline functions rf69_set_bit, rf69_reset_bit and rf69_read_modify_write

introduced by this patch, but were long and camel cased before. Signed-off-by: Marcus Wolf --- drivers/staging/pi433/rf69.c | 336 ++ 1 file changed, 180 insertions(+), 156 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433

Re: [PATCH 5/6] staging: pi433: Rename enum dataMode in rf69_enum.h

Am 04.12.2017 um 21:56 schrieb Dan Carpenter: On Mon, Dec 04, 2017 at 09:31:06PM +0200, Marcus Wolf wrote: Then it might be, that DATAMODUL_MODE_PACKET might need an other value. That's future code so we can delete that sentence for now. With the rule above, you are absolutely right

Re: [PATCH 5/6] staging: pi433: Rename enum dataMode in rf69_enum.h

Am 04.12.2017 um 21:56 schrieb Dan Carpenter: On Mon, Dec 04, 2017 at 09:31:06PM +0200, Marcus Wolf wrote: Then it might be, that DATAMODUL_MODE_PACKET might need an other value. That's future code so we can delete that sentence for now. With the rule above, you are absolutely right

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 04.12.2017 um 21:42 schrieb Simon Sandström: On Mon, Dec 04, 2017 at 09:22:06PM +0200, Marcus Wolf wrote: Am 04.12.2017 um 21:15 schrieb Dan Carpenter: That's a bad name, because it doesn't just enable it also disables. Please split them. regards, dan carpenter Same applies to all

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 04.12.2017 um 21:42 schrieb Simon Sandström: On Mon, Dec 04, 2017 at 09:22:06PM +0200, Marcus Wolf wrote: Am 04.12.2017 um 21:15 schrieb Dan Carpenter: That's a bad name, because it doesn't just enable it also disables. Please split them. regards, dan carpenter Same applies to all

Re: [PATCH 6/6] staging: pi433: Rename enum modShaping in rf69_enum.h

Am 04.12.2017 um 21:18 schrieb Dan Carpenter: On Mon, Dec 04, 2017 at 08:59:35PM +0200, Marcus Wolf wrote: Am 04.12.2017 um 12:33 schrieb Dan Carpenter: On Sun, Dec 03, 2017 at 04:17:26PM +0100, Simon Sandström wrote: diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433

Re: [PATCH 6/6] staging: pi433: Rename enum modShaping in rf69_enum.h

Am 04.12.2017 um 21:18 schrieb Dan Carpenter: On Mon, Dec 04, 2017 at 08:59:35PM +0200, Marcus Wolf wrote: Am 04.12.2017 um 12:33 schrieb Dan Carpenter: On Sun, Dec 03, 2017 at 04:17:26PM +0100, Simon Sandström wrote: diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433

Re: [PATCH 5/6] staging: pi433: Rename enum dataMode in rf69_enum.h

Second there might be the idea of supporting different chips in the future (I already thought about). Linux style is never to write code for the future. Ok. I didn't know. To be honest, I already started writing code, also supporting the rf12 some time ago, thus programming a rfxx.c, but

Re: [PATCH 5/6] staging: pi433: Rename enum dataMode in rf69_enum.h

Second there might be the idea of supporting different chips in the future (I already thought about). Linux style is never to write code for the future. Ok. I didn't know. To be honest, I already started writing code, also supporting the rf12 some time ago, thus programming a rfxx.c, but

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 04.12.2017 um 21:15 schrieb Dan Carpenter: On Mon, Dec 04, 2017 at 08:37:51PM +0200, Marcus Wolf wrote: Am 04.12.2017 um 12:37 schrieb Dan Carpenter: On Mon, Dec 04, 2017 at 01:17:37PM +0300, Dan Carpenter wrote: Perhaps choose different function names if you want? You could do

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 04.12.2017 um 21:15 schrieb Dan Carpenter: On Mon, Dec 04, 2017 at 08:37:51PM +0200, Marcus Wolf wrote: Am 04.12.2017 um 12:37 schrieb Dan Carpenter: On Mon, Dec 04, 2017 at 01:17:37PM +0300, Dan Carpenter wrote: Perhaps choose different function names if you want? You could do

Re: [PATCH 5/6] staging: pi433: Rename enum dataMode in rf69_enum.h

Am 04.12.2017 um 12:24 schrieb Dan Carpenter: On Sun, Dec 03, 2017 at 04:17:25PM +0100, Simon Sandström wrote: Renames enum dataMode and its values packet, continuous, continuousNoSync to enum data_mode and PACKET, CONTINUOUS, CONTINUOUS_NO_SYNC. Fixes checkpatch.pl warnings: "Avoid

Re: [PATCH 5/6] staging: pi433: Rename enum dataMode in rf69_enum.h

Am 04.12.2017 um 12:24 schrieb Dan Carpenter: On Sun, Dec 03, 2017 at 04:17:25PM +0100, Simon Sandström wrote: Renames enum dataMode and its values packet, continuous, continuousNoSync to enum data_mode and PACKET, CONTINUOUS, CONTINUOUS_NO_SYNC. Fixes checkpatch.pl warnings: "Avoid

Re: [PATCH 6/6] staging: pi433: Rename enum modShaping in rf69_enum.h

Am 04.12.2017 um 12:33 schrieb Dan Carpenter: On Sun, Dec 03, 2017 at 04:17:26PM +0100, Simon Sandström wrote: diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h index 34ff0d4807bd..bcfe29840889 100644 --- a/drivers/staging/pi433/pi433_if.h +++

Re: [PATCH 6/6] staging: pi433: Rename enum modShaping in rf69_enum.h

Am 04.12.2017 um 12:33 schrieb Dan Carpenter: On Sun, Dec 03, 2017 at 04:17:26PM +0100, Simon Sandström wrote: diff --git a/drivers/staging/pi433/pi433_if.h b/drivers/staging/pi433/pi433_if.h index 34ff0d4807bd..bcfe29840889 100644 --- a/drivers/staging/pi433/pi433_if.h +++

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 04.12.2017 um 12:37 schrieb Dan Carpenter: On Mon, Dec 04, 2017 at 01:17:37PM +0300, Dan Carpenter wrote: Perhaps choose different function names if you want? You could do it as several patches: patch 1: change types to bool patch 2: sed -e '/ == optionOn//' patch 3: split the functions

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 04.12.2017 um 12:37 schrieb Dan Carpenter: On Mon, Dec 04, 2017 at 01:17:37PM +0300, Dan Carpenter wrote: Perhaps choose different function names if you want? You could do it as several patches: patch 1: change types to bool patch 2: sed -e '/ == optionOn//' patch 3: split the functions

[PATCH] staging: pi433: rf69.c: Replace macros READ_REG and WRITE_REG with inline functions rf69_set_bit, rf69_reset_bit and rf69_read_modify_write

. Signed-off-by: Marcus Wolf <li...@wolf-entwicklungen.de> --- drivers/staging/pi433/rf69.c | 340 ++ 1 file changed, 182 insertions(+), 158 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index e69a215..8a31ed7

[PATCH] staging: pi433: rf69.c: Replace macros READ_REG and WRITE_REG with inline functions rf69_set_bit, rf69_reset_bit and rf69_read_modify_write

. Signed-off-by: Marcus Wolf --- drivers/staging/pi433/rf69.c | 340 ++ 1 file changed, 182 insertions(+), 158 deletions(-) diff --git a/drivers/staging/pi433/rf69.c b/drivers/staging/pi433/rf69.c index e69a215..8a31ed7 100644 --- a/drivers/staging/pi433

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 03.12.2017 um 17:17 schrieb Simon Sandström: Renames the enum optionOnOff and its values optionOn, optionOff to enum option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings: "Avoid CamelCase: , , ". Signed-off-by: Simon Sandström ---

Re: [PATCH 4/6] staging: pi433: Rename enum optionOnOff in rf69_enum.h

Am 03.12.2017 um 17:17 schrieb Simon Sandström: Renames the enum optionOnOff and its values optionOn, optionOff to enum option_on_off and OPTION_ON, OPTION_OFF. Fixes checkpatch.pl warnings: "Avoid CamelCase: , , ". Signed-off-by: Simon Sandström --- drivers/staging/pi433/pi433_if.c | 34

Re: [PATCH] staging: pi433: Make rf69_set_dc_cut_off_frequency_intern static

Am 02.12.2017 um 18:46 schrieb Joe Perches: On Sat, 2017-12-02 at 17:20 +0200, Marcus Wolf wrote: rf69_set_dc_cut_off_frequency_intern is used by rf69.c internally only. Therefore removed the function from header and declared it staic in the implemtation. Signed-off-by: Marcus Wolf <

Re: [PATCH] staging: pi433: Make rf69_set_dc_cut_off_frequency_intern static

Am 02.12.2017 um 18:46 schrieb Joe Perches: On Sat, 2017-12-02 at 17:20 +0200, Marcus Wolf wrote: rf69_set_dc_cut_off_frequency_intern is used by rf69.c internally only. Therefore removed the function from header and declared it staic in the implemtation. Signed-off-by: Marcus Wolf

Re: [PATCH] staging: pi433: rf69.c: Introduced define DEBUG_FUNC_ENTRY

Am 02.12.2017 um 17:00 schrieb Greg KH: On Sat, Dec 02, 2017 at 01:45:50PM +0200, Marcus Wolf wrote: Since dev_dbg already depends on define DEBUG, there was no sense, to enclose dev_dbg lines with #ifdef DEBUG. Instead of removing #ifdef DEBUG, I introduced define DEBUG_FUNC_ENTRY. So now

Re: [PATCH] staging: pi433: rf69.c: Introduced define DEBUG_FUNC_ENTRY

Am 02.12.2017 um 17:00 schrieb Greg KH: On Sat, Dec 02, 2017 at 01:45:50PM +0200, Marcus Wolf wrote: Since dev_dbg already depends on define DEBUG, there was no sense, to enclose dev_dbg lines with #ifdef DEBUG. Instead of removing #ifdef DEBUG, I introduced define DEBUG_FUNC_ENTRY. So now

  1   2   3   >