Re: [PATCH 08/25] ASoC: sun8i-codec: Use snd_soc_dai_get_drvdata

2020-10-05 Thread Maxime Ripard
On Wed, Sep 30, 2020 at 09:11:31PM -0500, Samuel Holland wrote: > Remove a level of indirection by getting the device directly from the > passed-in struct snd_soc_dai, instead of going through its component. > > Signed-off-by: Samuel Holland Acked-by: Maxime Ripard Maxime s

Re: [PATCH 06/25] ASoC: sun8i-codec: Fix AIF widget channel references

2020-10-05 Thread Maxime Ripard
On Wed, Sep 30, 2020 at 09:11:29PM -0500, Samuel Holland wrote: > Both the left and right side widgets referenced channel 0. This would > unnecessarily power on the right side widget (and its associated path) > when a mono stream was active. > > Signed-off-by: Samuel Holland A

Re: [PATCH 07/25] ASoC: sun8i-codec: Enable AIF mono/stereo control

2020-10-05 Thread Maxime Ripard
Add the support to control this feature from userspace. > > Signed-off-by: Samuel Holland Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH 05/25] ASoC: sun8i-codec: Correct DAPM widget types

2020-10-05 Thread Maxime Ripard
dget type > for that reason, and so these widgets will match newly-added widgets for > the other AIFs. > > Signed-off-by: Samuel Holland Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH 04/25] ASoC: sun8i-codec: Consistently name DAPM widgets and routes

2020-10-05 Thread Maxime Ripard
h the naming scheme of the other widgets. > > The mixer controls are not renamed because they are exposed to > userspace. > > Signed-off-by: Samuel Holland Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH 03/25] ASoC: sun8i-codec: Sort DAPM controls, widgets, and routes

2020-10-05 Thread Maxime Ripard
the > AIF-related widgets from the ADC/DAC widgets, which allows the AIF > widgets to stay in a logical order as more AIFs are added to the driver. > > No widgets are renamed, to ease verification that this commit makes no > functional change. > > Signed-off-by: Samuel Holland Ac

Re: [PATCH 02/25] ASoC: sun8i-codec: Swap module clock/reset dependencies

2020-10-05 Thread Maxime Ripard
the > widget and route arrays (previously they were at opposite ends), and it > makes it easier to track which parts of which registers are implemented. > > Signed-off-by: Samuel Holland Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH 01/25] ASoC: sun8i-codec: Set up clock tree at probe time

2020-10-05 Thread Maxime Ripard
ing DAPM widgets. The DAPM > widgets unnecessarily change clock parents when the codec goes in/out > of idle and the supply widgets are powered up/down. > > Signed-off-by: Samuel Holland Acked-by: Maxime Ripard Maxime signature.asc Description: PGP signature

Re: [PATCH] ARM: dts: sun4i-a10: fix cpu_alert temperature

2020-10-05 Thread Maxime Ripard
On Sat, Oct 03, 2020 at 12:03:32PM +0200, Clément Péron wrote: > When running dtbs_check thermal_zone warn about the > temperature declared. > > thermal-zones: cpu-thermal:trips:cpu-alert0:temperature:0:0: 85 is > greater than the maximum of 20 > > It's indeed wrong the real value is

Re: [PATCH v2] arm64: dts: allwinner: h6: add eMMC voltage property for Beelink GS1

2020-10-05 Thread Maxime Ripard
Hi Clément, On Sat, Oct 03, 2020 at 11:20:01AM +0200, Clément Péron wrote: > Sunxi MMC driver can't distinguish at runtime what's the I/O voltage > for HS200 mode. Unfortunately, that's not true (or at least, that's not related to your patch). > Add a property in the device-tree to notify MMC

Re: [PATCH] dt-bindings: display: Add dsi-controller.yaml in DSI controller schemas

2020-10-05 Thread Maxime Ripard
On Fri, Oct 02, 2020 at 05:59:24PM -0500, Rob Herring wrote: > Some DSI controllers are missing a reference to the recently added > dsi-controller.yaml schema. Add it and we can drop the duplicate parts. > > Cc: Maxime Ripard Acked-by: Maxime Ripard Thanks! Maxime signature.asc

Re: [PATCH 0/2] Try to fix DT schema problems for V3-series DTs

2020-10-05 Thread Maxime Ripard
On Sun, Oct 04, 2020 at 07:48:42AM +0800, Icenowy Zheng wrote: > This patchset tries to fix DT schema verification errors that exist in > V3-series device trees. > > The first patch drops bogus properties that is not needed in PineCube > DT, and the second one adds compatible to the binding. > >

Re: [linux-sunxi] [PATCH v5 09/20] arm64: dts: allwinner: h6: Add DAI node and soundcard for HDMI

2020-10-02 Thread Maxime Ripard
On Fri, Oct 02, 2020 at 06:01:21PM +0200, Clément Péron wrote: > Hi Chen-Yu, > > On Mon, 28 Sep 2020 at 07:42, Chen-Yu Tsai wrote: > > > > On Mon, Sep 28, 2020 at 1:32 PM Chen-Yu Tsai wrote: > > > > > > On Mon, Sep 28, 2020 at 3:29 AM Clément Péron > > > wrote: > > > > > > > > From: Jernej

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-10-02 Thread Maxime Ripard
Hi Tim, On Thu, Oct 01, 2020 at 11:15:46AM +0100, Tim Gover wrote: > hdmi_enable_4k60=1 causes the firmware to select 3.3 GHz for the PLLC > VCO to support a core-frequency of 550 MHz which is the minimum > frequency required by the HVS at 4Kp60. The side effect is that if the > display clock

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-10-01 Thread Maxime Ripard
On Thu, Oct 01, 2020 at 11:22:03AM +0200, Nicolas Saenz Julienne wrote: > On Wed, 2020-09-30 at 09:38 -0700, Nathan Chancellor wrote: > > On Wed, Sep 30, 2020 at 04:07:58PM +0200, Maxime Ripard wrote: > > > Hi Nathan, > > > > > > On Tue, Sep 29, 2020 at 03:15

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-10-01 Thread Maxime Ripard
On Thu, Oct 01, 2020 at 08:48:43AM +0200, Maxime Ripard wrote: > Hi Stefan, > > On Wed, Sep 30, 2020 at 06:52:13PM +0200, Stefan Wahren wrote: > > Am 30.09.20 um 18:38 schrieb Nathan Chancellor: > > > On Wed, Sep 30, 2020 at 04:07:58PM +0200, Maxime Ripard

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-10-01 Thread Maxime Ripard
Hi Stefan, On Wed, Sep 30, 2020 at 06:52:13PM +0200, Stefan Wahren wrote: > Am 30.09.20 um 18:38 schrieb Nathan Chancellor: > > On Wed, Sep 30, 2020 at 04:07:58PM +0200, Maxime Ripard wrote: > >> Hi Nathan, > >> > >> On Tue, Sep 29, 2020 at 03:15:26PM -0700, N

Re: [PATCH] mfd: sun4i-gpadc: Interrupt numbers should start from 1

2020-09-30 Thread Maxime Ripard
On Thu, Sep 17, 2020 at 04:01:17PM +0200, Ondřej Jirman wrote: > Hello Maxime, > > On Thu, Sep 17, 2020 at 03:19:04PM +0200, Maxime Ripard wrote: > > Hi, > > > > On Sat, Sep 12, 2020 at 01:22:00PM +0200, Ondrej Jirman wrote: > > > mfd: sun4i-gpadc: I

Re: [PATCH v5 80/80] ARM: dts: bcm2711: Enable the display pipeline

2020-09-30 Thread Maxime Ripard
Hi Nathan, On Tue, Sep 29, 2020 at 03:15:26PM -0700, Nathan Chancellor wrote: > On Thu, Sep 03, 2020 at 10:01:52AM +0200, Maxime Ripard wrote: > > Now that all the drivers have been adjusted for it, let's bring in the > > necessary device tree changes. > > > > T

Re: [PATCH] arm64: dts: allwinner: h6: add eMMC voltage property for Beelink GS1

2020-09-30 Thread Maxime Ripard
Hi, On Mon, Sep 28, 2020 at 05:00:37PM +0200, Clément Péron wrote: > VQMMC supply is connected to BLDO2 which provides 1.8V. > > Let's reflect this in the device-tree. This commit log doesn't really explain what is going on though? > Fixes: 089bee8dd119 ("arm64: dts: allwinner: h6: Introduce

Re: [PATCH v4 09/22] arm64: dts: allwinner: h6: Add HDMI audio node

2020-09-30 Thread Maxime Ripard
On Mon, Sep 28, 2020 at 04:27:42PM +0200, Clément Péron wrote: > On Mon, 28 Sep 2020 at 10:43, Maxime Ripard wrote: > > > > On Mon, Sep 21, 2020 at 08:37:09PM +0200, Jernej Škrabec wrote: > > > Dne ponedeljek, 21. september 2020 ob 19:23:49 CEST je Clément Péron >

Re: [PATCH v4 02/22] ASoC: sun4i-i2s: Change set_chan_cfg() params

2020-09-28 Thread Maxime Ripard
On Mon, Sep 21, 2020 at 07:15:13PM +0200, Clément Péron wrote: > Hi Maxime, > > On Mon, 21 Sep 2020 at 14:29, Maxime Ripard wrote: > > > > On Mon, Sep 21, 2020 at 12:27:11PM +0200, Clément Péron wrote: > > > As slots and slot_width can be overwritter in case se

Re: [PATCH v4 09/22] arm64: dts: allwinner: h6: Add HDMI audio node

2020-09-28 Thread Maxime Ripard
On Mon, Sep 21, 2020 at 08:37:09PM +0200, Jernej Škrabec wrote: > Dne ponedeljek, 21. september 2020 ob 19:23:49 CEST je Clément Péron > napisal(a): > > Hi Maxime, > > > > On Mon, 21 Sep 2020 at 15:59, Maxime Ripard wrote: > > > > > > On Mon, Sep 2

Re: [PATCH RFC v7 5/6] dt-bindings: display: add Unisoc's mipi dsi bindings

2020-09-28 Thread Maxime Ripard
Hi! On Mon, Sep 28, 2020 at 02:27:39PM +0800, Kevin Tang wrote: > From: Kevin Tang > > Adds MIPI DSI Master and MIPI DSI-PHY (D-PHY) > support for Unisoc's display subsystem. > > RFC v7: > - Fix DTC unit name warnings > - Fix the problem of maintainers > > Cc: Orson Zhai > Cc: Chunyan

Re: [PATCH RFC v7 1/6] dt-bindings: display: add Unisoc's drm master bindings

2020-09-28 Thread Maxime Ripard
Hi! On Mon, Sep 28, 2020 at 02:27:35PM +0800, Kevin Tang wrote: > From: Kevin Tang > > The Unisoc DRM master device is a virtual device needed to list all > DPU devices or other display interface nodes that comprise the > graphics subsystem > > RFC v7: > - Fix DTC unit name warnings > -

Re: [PATCH] ARM: dts: sun8i: v3s: Add simple-framebuffer

2020-09-25 Thread Maxime Ripard
Hi, On Wed, Sep 16, 2020 at 07:59:41PM +0200, Martin Cerveny wrote: > Add support for "allwinner,simple-framebuffer" > with "mixer0-lcd0" pipeline from boot loader (u-boot). > It depends on boot loader implementation of DE2/TCON0 > setup with LCD. > > Signed-off-by: Martin Cerveny queued for

Re: [PATCH 0/7] Pine64 PineCube support

2020-09-25 Thread Maxime Ripard
Hi, On Wed, Sep 23, 2020 at 08:57:02AM +0800, Icenowy Zheng wrote: > Pine64 PineCube is an IP camera based on Allwinner S3 chip. > > This patchset tries to add support for it. > > In order to make sure the system do not hang when camera is brought up, > a fix to AXP209 driver is needed (sent

Re: [PATCH v4 09/22] arm64: dts: allwinner: h6: Add HDMI audio node

2020-09-21 Thread Maxime Ripard
On Mon, Sep 21, 2020 at 12:27:18PM +0200, Clément Péron wrote: > From: Jernej Skrabec > > Add a simple-soundcard to link audio between HDMI and I2S. > > Signed-off-by: Jernej Skrabec > Signed-off-by: Marcus Cooper > Signed-off-by: Clément Péron > --- >

Re: [PATCH v4 03/22] ASoC: sun4i-i2s: Change get_sr() and get_wss() to be more explicit

2020-09-21 Thread Maxime Ripard
On Mon, Sep 21, 2020 at 12:27:12PM +0200, Clément Péron wrote: > We are actually using a complex formula to just return a bunch of > simple values. Also this formula is wrong for sun4i. Just like the previous patch, this could use a bit more explanation, like why it's a good thing, or how it's

Re: [PATCH v4 02/22] ASoC: sun4i-i2s: Change set_chan_cfg() params

2020-09-21 Thread Maxime Ripard
On Mon, Sep 21, 2020 at 12:27:11PM +0200, Clément Péron wrote: > As slots and slot_width can be overwritter in case set_tdm() is > called. Avoid to have this logic in set_chan_cfg(). > > Instead pass the required values as params to set_chan_cfg(). It's not really clear here what the issue is,

Re: [PATCH v2] documentation: arm: sunxi: Allwinner H2+/H3 update

2020-09-21 Thread Maxime Ripard
On Mon, Sep 14, 2020 at 06:19:45AM +0200, Wilken Gottwalt wrote: > Updated information about H2+ and H3 differences and added a link to a > slightly newer datasheet. > > Signed-off-by: Wilken Gottwalt > --- > Changes in v2: > - addressed comments/proposals from Maxime > --- >

Re: [PATCH] dt-bindings: arm: sunxi: update H2+/H3 cpu clocks

2020-09-21 Thread Maxime Ripard
Hi, On Mon, Sep 14, 2020 at 06:00:56AM +0200, Wilken Gottwalt wrote: > > > > cpufreq OPP misconfiguration on Allwinner SoCs has been known to create > > > > some errors that are fairly hard to spot and be quite easy to go > > > > unnoticed (like caches corruptions). > > > > > > Yeah, I noticed

Re: [PATCH 0/5] ARM: dts: sun8i: r40: Enable video decoder

2020-09-17 Thread Maxime Ripard
On Thu, Sep 17, 2020 at 10:33:39AM +0200, Hans Verkuil wrote: > Hi Maxime, > > On 27/08/2020 17:19, Maxime Ripard wrote: > > On Tue, Aug 25, 2020 at 07:35:18PM +0200, Jernej Skrabec wrote: > >> Allwinner R40 SoC contains video engine very similar to that in A33. > &g

Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S

2020-09-17 Thread Maxime Ripard
Hi Clement, On Thu, Sep 17, 2020 at 03:55:45PM +0200, Clément Péron wrote: > Hi Maxime and Samuel, > > On Thu, 17 Sep 2020 at 15:21, Maxime Ripard wrote: > > > > Hi, > > > > On Sat, Sep 12, 2020 at 03:29:55PM -0500, Samuel Holland wrote: > > &g

Re: [PATCH] mfd: sun4i-gpadc: Interrupt numbers should start from 1

2020-09-17 Thread Maxime Ripard
Hi, On Sat, Sep 12, 2020 at 01:22:00PM +0200, Ondrej Jirman wrote: > mfd: sun4i-gpadc: Interrupt numbers should start from 1 Why? An hwirq with 0 is totally fine > This avoids a warning: > > [2.891592] [ cut here ] > [2.895052] WARNING: CPU: 0 PID: 149 at

Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S

2020-09-17 Thread Maxime Ripard
Hi, On Sat, Sep 12, 2020 at 03:29:55PM -0500, Samuel Holland wrote: > On 9/10/20 9:33 AM, Maxime Ripard wrote: > > On Thu, Sep 03, 2020 at 09:54:39PM -0500, Samuel Holland wrote: > >> On 9/3/20 3:58 PM, Maxime Ripard wrote: > >>> On Thu, Sep 03, 2020 at 10:02:3

Re: [PATCH v5 00/80] drm/vc4: Support BCM2711 Display Pipeline

2020-09-16 Thread Maxime Ripard
On Mon, Sep 14, 2020 at 07:14:11PM +0900, Hoegeun Kwon wrote: > Hi Maxime, > > On 9/8/20 9:00 PM, Maxime Ripard wrote: > > Hi Hoegeun, > > > > On Mon, Sep 07, 2020 at 08:49:12PM +0900, Hoegeun Kwon wrote: > >> On 9/3/20 5:00 PM, Maxime Ripard wrote: > >&g

Re: [PATCH] clk: bcm: fix kconfig dependency warning for CLK_BCM2711_DVP

2020-09-15 Thread Maxime Ripard
Hi, On Tue, Sep 15, 2020 at 01:37:50PM +0300, Necip Fazil Yildiran wrote: > When CLK_BCM2711_DVP is enabled and RESET_CONTROLLER is disabled, it > results in the following Kbuild warning: > > WARNING: unmet direct dependencies detected for RESET_SIMPLE > Depends on [n]: RESET_CONTROLLER [=n] >

Re: [PATCH] soc: sunxi: sram: remove unneeded semicolon

2020-09-11 Thread Maxime Ripard
hi, On Thu, Sep 10, 2020 at 10:05:46PM +0800, Jason Yan wrote: > Eliminate the following coccicheck warning: > > drivers/soc/sunxi/sunxi_sram.c:197:2-3: Unneeded semicolon > > Reported-by: Hulk Robot > Signed-off-by: Jason Yan Applied, thanks! Maxime signature.asc Description: PGP

Re: [PATCH] drm/vc4: Fix bitwise OR versus ternary operator in vc4_plane_mode_set

2020-09-11 Thread Maxime Ripard
On Thu, Sep 10, 2020 at 10:18:32AM -0700, Nathan Chancellor wrote: > Clang warns: > > drivers/gpu/drm/vc4/vc4_plane.c:901:27: warning: operator '?:' has lower > precedence than '|'; '|' will be evaluated first > [-Wbitwise-conditional-parentheses] >

Re: [PATCH] drm/vc4: Update type of reg parameter in vc4_hdmi_{read,write}

2020-09-11 Thread Maxime Ripard
On Thu, Sep 10, 2020 at 10:04:02AM -0700, Nathan Chancellor wrote: > Clang warns 100+ times in the vc4 driver along the lines of: > > drivers/gpu/drm/vc4/vc4_hdmi_phy.c:518:13: warning: implicit conversion > from enumeration type 'enum vc4_hdmi_field' to different enumeration > type 'enum

Re: [PATCH] documentation: arm: sunxi: Allwinner H2+/H3 update

2020-09-10 Thread Maxime Ripard
Hi, On Tue, Sep 08, 2020 at 03:18:08PM +0200, Wilken Gottwalt wrote: > Updated information about H2+ and H3 difference and added a link to a > slightly newer datasheet. > > Signed-off-by: Wilken Gottwalt > --- > Documentation/arm/sunxi.rst | 3 +++ > 1 file changed, 3 insertions(+) > > diff

Re: [PATCH 0/6] ARM: dts: sun8i: v3s: Enable video decoder

2020-09-10 Thread Maxime Ripard
On Tue, Sep 08, 2020 at 06:44:06PM +0200, Martin Cerveny wrote: > Hello. > > On Tue, 8 Sep 2020, Maxime Ripard wrote: > > On Fri, Sep 04, 2020 at 10:01:06PM +0200, Martin Cerveny wrote: > > > First patch extends cedrus capability to all decoders > > >

Re: [PATCH 0/2] drm/sun4i: sun8i-csc: Secondary CSC register correction

2020-09-10 Thread Maxime Ripard
On Sun, Sep 06, 2020 at 06:21:38PM +0200, Martin Cerveny wrote: > The secondary video layer (VI) on "Allwinner V3s" displays > decoded video (YUV) in wrong colors. The secondary > CSC should be programmed. > Let's correct CSC register offset and extend regmap size. Applied both, thanks Maxime

Re: [PATCH] dt-bindings: arm: sunxi: update H2+/H3 cpu clocks

2020-09-09 Thread Maxime Ripard
On Wed, Sep 09, 2020 at 03:54:46PM +0200, Wilken Gottwalt wrote: > On Wed, 9 Sep 2020 14:08:59 +0200 > Maxime Ripard wrote: > > Hi! > > > > Thanks for contributing > > > > The prefix isn't right though. > > > > dt-bindings is u

Re: [PATCH] dt-bindings: arm: sunxi: update H2+/H3 cpu clocks

2020-09-09 Thread Maxime Ripard
Hi! Thanks for contributing The prefix isn't right though. dt-bindings is used when you're modifying the binding itself, ie the description of what the node is supposed to look like, not when you actually use that node in a DT. In that case, that would be ARM: dts: sunxi: (we're on the ARM

Re: [PATCH v5 00/80] drm/vc4: Support BCM2711 Display Pipeline

2020-09-08 Thread Maxime Ripard
Hi Hoegeun, On Mon, Sep 07, 2020 at 08:49:12PM +0900, Hoegeun Kwon wrote: > On 9/3/20 5:00 PM, Maxime Ripard wrote: > > Hi everyone, > > > > Here's a (pretty long) series to introduce support in the VC4 DRM driver > > for the display pipeline found in the BCM2711

Re: [PATCH 5/6] media: allwinner,sun4i-a10-video-engine: Add V3s compatible

2020-09-08 Thread Maxime Ripard
On Fri, Sep 04, 2020 at 10:01:11PM +0200, Martin Cerveny wrote: > Allwinner V3s SoC contains video engine. Add compatible for it. > > Signed-off-by: Martin Cerveny The prefix isn't the right one, it shouldn't be media: but dt-bindings: media: cedrus: Maxime signature.asc Description: PGP

Re: [PATCH 0/6] ARM: dts: sun8i: v3s: Enable video decoder

2020-09-08 Thread Maxime Ripard
Hi, On Fri, Sep 04, 2020 at 10:01:06PM +0200, Martin Cerveny wrote: > First patch extends cedrus capability to all decoders > because V3s missing MPEG2 decoder. > > Next two patches add system control node (SRAM C1) and > next three patches add support for Cedrus VPU. How was it tested?

Re: [PATCH v3 0/2] ARM: dts: sun8i: v3s: Enable crypto engine

2020-09-08 Thread Maxime Ripard
On Mon, Sep 07, 2020 at 06:24:56PM +0200, Martin Cerveny wrote: > Add support for crypto engine (sun4i-ss) for Allwinner V3s. > Functionality like A33 so add only compatible and enable > in device tree. > > Regards. Applied, thanks Maxime signature.asc Description: PGP signature

Re: [PATCH v3] dt-bindings: crypto: Specify that allwinner,sun8i-a33-crypto needs reset

2020-09-08 Thread Maxime Ripard
On Tue, Sep 08, 2020 at 08:15:56AM +0200, Maxime Ripard wrote: > On Mon, Sep 07, 2020 at 07:54:37PM +0200, Corentin Labbe wrote: > > When adding allwinner,sun8i-a33-crypto, I forgot to add that it needs reset. > > Furthermore, there are no need to use items to list only

Re: [PATCH v3] dt-bindings: crypto: Specify that allwinner,sun8i-a33-crypto needs reset

2020-09-08 Thread Maxime Ripard
ngs: crypto: add new compatible for A33 SS") > Signed-off-by: Corentin Labbe Acked-by: Maxime Ripard Thanks! Maxime signature.asc Description: PGP signature

Re: [PATCH v5 00/80] drm/vc4: Support BCM2711 Display Pipeline

2020-09-07 Thread Maxime Ripard
Hi, On Thu, Sep 03, 2020 at 10:00:32AM +0200, Maxime Ripard wrote: > Hi everyone, > > Here's a (pretty long) series to introduce support in the VC4 DRM driver > for the display pipeline found in the BCM2711 (and thus the RaspberryPi 4). > > The main differences are tha

Re: [PATCH v5 75/80] drm/vc4: hdmi: Add pixel BVB clock control

2020-09-07 Thread Maxime Ripard
Hi, On Fri, Sep 04, 2020 at 10:46:26AM +0100, Dave Stevenson wrote: > On Thu, 3 Sep 2020 at 09:03, Maxime Ripard wrote: > > > > From: Hoegeun Kwon > > > > The BCM2711 has another clock that needs to be ramped up depending on the > > pixel rate: the pixel

Re: [PATCH v5 00/80] drm/vc4: Support BCM2711 Display Pipeline

2020-09-07 Thread Maxime Ripard
Hi! On Fri, Sep 04, 2020 at 06:16:16PM +0800, Jian-Hong Pan wrote: > Thanks for version 5 patch series! > > I applied it based on linux-next tag next-20200828 and build it with > the config [1] to test on RPi 4 > However, It fails to get HDMI state machine clock and pixel bcb clock. > Then,

Re: [PATCH] iommu/sun50i: Fix set-but-not-used variable warning

2020-09-07 Thread Maxime Ripard
et but not > used [-Wunused-but-set-variable] > 890 | phys_addr_t iova; > | ^~~~ > > Reported-by: kernel test robot > Signed-off-by: Joerg Roedel Acked-by: Maxime Ripard Thanks! Maxime

Re: [PATCH v2] dt-bindings: crypto: Specify that allwinner,sun8i-a33-crypto needs reset

2020-09-04 Thread Maxime Ripard
On Thu, Sep 03, 2020 at 04:54:45PM +0200, Corentin Labbe wrote: > When adding allwinner,sun8i-a33-crypto, I forgot to add that it needs reset. > Furthermore, there are no need to use items to list only one compatible > in compatible list. > > Fixes: f81547ba7a98 ("dt-bindings: crypto: add new

Re: [PATCH 8/9] ASoC: sun8i-codec: Attach the bus clock to the regmap

2020-09-04 Thread Maxime Ripard
On Sun, Aug 30, 2020 at 10:48:51PM -0500, Samuel Holland wrote: > When attached to the regmap, the bus clock is automatically enabled as > needed to access device registers. This avoids needing code to manage it > separately in the driver. > > Signed-off-by: Samuel Holland A

Re: [PATCH 9/9] ASoC: sun8i-codec: Manage module clock via DAPM

2020-09-04 Thread Maxime Ripard
Holland Acked-by: Maxime Ripard Thanks! Maxime signature.asc Description: PGP signature

Re: [PATCH] drm/sun4i: Fix DE2 YVU handling

2020-09-04 Thread Maxime Ripard
On Wed, Sep 02, 2020 at 12:03:05AM +0200, Jernej Skrabec wrote: > Function sun8i_vi_layer_get_csc_mode() is supposed to return CSC mode > but due to inproper return type (bool instead of u32) it returns just 0 > or 1. Colors are wrong for YVU formats because of that. > > Fixes: daab3d0e8e2b

Re: [PATCH v3 3/7] ASoC: sun4i-i2s: Add support for H6 I2S

2020-09-03 Thread Maxime Ripard
On Thu, Sep 03, 2020 at 10:02:31PM +0200, Clément Péron wrote: > Hi Maxime, > > On Wed, 29 Jul 2020 at 17:16, Mark Brown wrote: > > > > On Wed, Jul 29, 2020 at 04:39:27PM +0200, Maxime Ripard wrote: > > > > > It really looks like the polarity of LRCK is fine

Re: [PATCH v2 01/20] Revert "ASoC: sun4i-i2s: Fix the LRCK polarity"

2020-09-03 Thread Maxime Ripard
Hi On Thu, Sep 03, 2020 at 10:30:15PM +0200, Clément Péron wrote: > This reverts commit dd657eae8164f7e4bafe8b875031a7c6c50646a9. > > There was a misinterpretation of the analysis using a scope. > After rechecking this using a logical analyzer the LRCK polarity is > fine. Yes, it's fine indeed,

[PATCH v5 13/80] drm/vc4: kms: Convert to for_each_new_crtc_state

2020-09-03 Thread Maxime Ripard
The vc4 atomic commit loop has an handrolled loop that is basically identical to for_each_new_crtc_state, let's convert it to that helper. Tested-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_kms.c | 10

[PATCH v5 05/80] drm/vc4: plane: Optimize the LBM allocation size

2020-09-03 Thread Maxime Ripard
no longer have that luxury. Tested-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_plane.c | 17 + 1 file changed, 13 insertions(+), 4 deletions(-) diff --git a/drivers

[PATCH v5 00/80] drm/vc4: Support BCM2711 Display Pipeline

2020-09-03 Thread Maxime Ripard
the b-frame marker to the match ALSA's default. drm/vc4: hdmi: Add audio-related callbacks Hoegeun Kwon (1): drm/vc4: hdmi: Add pixel BVB clock control Maxime Ripard (72): dt-bindings: display: Add support for the BCM2711 HVS drm/vc4: hvs: Boost the core clock during modeset drm/vc4: plane

[PATCH v5 08/80] drm/vc4: crtc: Use a shared interrupt

2020-09-03 Thread Maxime Ripard
Some pixelvalves in vc5 use the same interrupt line so let's register our interrupt handler as a shared one. Reviewed-by: Eric Anholt Tested-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 4 +++- 1 file

[PATCH v5 10/80] drm/vc4: crtc: Rename HVS channel to output

2020-09-03 Thread Maxime Ripard
to hvs_output in the vc4_crtc_data, since a pixelvalve is really connected to an output, and not to a FIFO. Reviewed-by: Dave Stevenson Tested-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 8 drivers/gpu

[PATCH v5 07/80] drm/vc4: crtc: Deal with different number of pixel per clock

2020-09-03 Thread Maxime Ripard
Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 18 +++--- drivers/gpu/drm/vc4/vc4_drv.h | 3 +++ 2 files changed, 14 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index 6d8fa6118fc1..e55b2208b4b7 100644

[PATCH v5 01/80] dt-bindings: display: Add support for the BCM2711 HVS

2020-09-03 Thread Maxime Ripard
The HVS found in the BCM2711 is slightly different from the previous generations, let's add a compatible for it. Reviewed-by: Eric Anholt Tested-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard --- Documentation/devicetree/bindings/display/brcm

[PATCH v5 31/80] drm/vc4: crtc: Clear the PixelValve FIFO during configuration

2020-09-03 Thread Maxime Ripard
-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index 73d918706f7e..00b2c2b011d1 100644 --- a/drivers/gpu/drm

[PATCH v5 16/80] drm/vc4: crtc: Add function to compute FIFO level bits

2020-09-03 Thread Maxime Ripard
-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 12 ++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index 2c64efd2d3d9..1d9e3658ae59 100644

[PATCH v5 20/80] drm/vc4: crtc: Turn pixelvalve reset into a function

2020-09-03 Thread Maxime Ripard
-by: Stefan Wahren Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 20 +--- 1 file changed, 13 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index 41bc61d5a61f..c2ab907611e3 100644 --- a/drivers/gpu/drm

[PATCH v5 17/80] drm/vc4: crtc: Rename HDMI encoder type to HDMI0

2020-09-03 Thread Maxime Ripard
The previous generations were only supporting a single HDMI controller, but that's about to change, so put an index as well to differentiate between the two controllers. Reviewed-by: Eric Anholt Tested-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime

[PATCH v5 19/80] drm/vc4: crtc: Disable color management for HVS5

2020-09-03 Thread Maxime Ripard
The HVS5 uses different color matrices. Disable color management support for now. Reviewed-by: Eric Anholt Tested-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 17 +++-- drivers/gpu/drm/vc4

[PATCH v5 18/80] drm/vc4: crtc: Add HDMI1 encoder type

2020-09-03 Thread Maxime Ripard
The BCM2711 sports a second HDMI controller, so let's add that second HDMI encoder type. Reviewed-by: Eric Anholt Tested-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_drv.h | 1 + 1 file changed, 1 insertion

[PATCH v5 30/80] drm/vc4: crtc: Clear the PixelValve FIFO on disable

2020-09-03 Thread Maxime Ripard
In order to avoid a stale pixel getting stuck on mode change or a disable / enable cycle, we need to make sure to flush the PV FIFO on disable. Reviewed-by: Dave Stevenson Tested-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard --- drivers/gpu

[PATCH v5 23/80] drm/vc4: crtc: Move the HVS gamma LUT setup to our init function

2020-09-03 Thread Maxime Ripard
-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 2 +- drivers/gpu/drm/vc4/vc4_drv.h | 1 +- drivers/gpu/drm/vc4/vc4_hvs.c | 59 +-- drivers/gpu/drm/vc4/vc4_txp.c | 1 +- 4 files changed, 16 insertions(+), 47 deletions(-) diff --git a/drivers/gpu/drm/vc4

[PATCH v5 25/80] drm/vc4: crtc: Remove mode_set_nofb

2020-09-03 Thread Maxime Ripard
Stevenson Tested-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index

[PATCH v5 26/80] drm/vc4: crtc: Remove redundant pixelvalve reset

2020-09-03 Thread Maxime Ripard
the first call. Reviewed-by: Dave Stevenson Tested-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4

[PATCH v5 29/80] drm/vc4: crtc: Add a delay after disabling the PixelValve output

2020-09-03 Thread Maxime Ripard
Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index d0b326e1df0a..4c23cf8aefb9 100644

[PATCH v5 28/80] drm/vc4: encoder: Add finer-grained encoder callbacks

2020-09-03 Thread Maxime Ripard
-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 19 +++ drivers/gpu/drm/vc4/vc4_drv.h | 7 +++ 2 files changed, 26 insertions(+) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu

[PATCH v5 21/80] drm/vc4: crtc: Move PV dump to config_pv

2020-09-03 Thread Maxime Ripard
Now that we only configure the PixelValve in vc4_crtc_config_pv, it doesn't really make much sense to dump its register content in its caller. Reviewed-by: Dave Stevenson Tested-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard --- drivers/gpu

[PATCH v5 27/80] drm/vc4: crtc: Move HVS channel init before the PV initialisation

2020-09-03 Thread Maxime Ripard
Wahren Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_crtc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_crtc.c b/drivers/gpu/drm/vc4/vc4_crtc.c index 2c5ff45dc315..b7b0e19e2fe1 100644 --- a/drivers/gpu/drm/vc4/vc4_crtc.c +++ b

[PATCH v5 22/80] drm/vc4: crtc: Move HVS init and close to a function

2020-09-03 Thread Maxime Ripard
In order to make further refactoring easier, let's move the HVS channel setup / teardown to their own function. Reviewed-by: Dave Stevenson Tested-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hvs.c | 104

[PATCH v5 47/80] drm/vc4: hdmi: Retrieve the vc4_hdmi at unbind using our device

2020-09-03 Thread Maxime Ripard
Wahren Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 24 +++- drivers/gpu/drm/vc4/vc4_hdmi.h | 4 ++-- 2 files changed, 25 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 44126ae55a19

[PATCH v5 43/80] drm/vc4: hdmi: Move accessors to vc4_hdmi

2020-09-03 Thread Maxime Ripard
the vc4_hdmi structure so that we can eventually get rid of that single global pointer. Reviewed-by: Eric Anholt Tested-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 22 -- drivers/gpu/drm/vc4

[PATCH v5 51/80] drm/vc4: hdmi: Implement a register layout abstraction

2020-09-03 Thread Maxime Ripard
as much as possible. Let's implement some indirection to wrap around a register and depending on the variant will lookup the associated register on that particular variant. Reviewed-by: Dave Stevenson Tested-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime

[PATCH v5 36/80] dt-bindings: display: vc4: pv: Add BCM2711 pixel valves

2020-09-03 Thread Maxime Ripard
The BCM2711 comes with other pixelvalves that have different requirements and capabilities. Let's document their compatible. Reviewed-by: Rob Herring Reviewed-by: Eric Anholt Tested-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard

[PATCH v5 38/80] drm/vc4: hdmi: Use debugfs private field

2020-09-03 Thread Maxime Ripard
Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index ec34c08b16df..ae8c4d53e239 100644

[PATCH v5 48/80] drm/vc4: hdmi: Remove vc4_dev hdmi pointer

2020-09-03 Thread Maxime Ripard
Now that we don't have any users anymore, we can kill that pointer. Reviewed-by: Eric Anholt Tested-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_drv.h | 1 - drivers/gpu/drm/vc4/vc4_hdmi.c | 7 --- 2 files

[PATCH v5 45/80] drm/vc4: hdmi: Add container_of macros for encoders and connectors

2020-09-03 Thread Maxime Ripard
-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 41 ++- drivers/gpu/drm/vc4/vc4_hdmi.h | 16 ++- 2 files changed, 28 insertions(+), 29 deletions(-) diff --git a/drivers

[PATCH v5 49/80] drm/vc4: hdmi: Remove vc4_hdmi_connector

2020-09-03 Thread Maxime Ripard
The vc4_hdmi_connector was only used to switch between drm_connector to drm_encoder. However, we can now use vc4_hdmi to do the switch, so that structure is redundant. Reviewed-by: Eric Anholt Tested-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime

[PATCH v5 56/80] drm/vc4: hdmi: Add a set_timings callback

2020-09-03 Thread Maxime Ripard
. Tested-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 72 +++ drivers/gpu/drm/vc4/vc4_hdmi.h | 4 ++- 2 files changed, 44 insertions(+), 32 deletions(-) diff --git a/drivers/gpu

[PATCH v5 44/80] drm/vc4: hdmi: Use local vc4_hdmi directly

2020-09-03 Thread Maxime Ripard
, and we'll fix the local variable later. Reviewed-by: Eric Anholt Tested-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm

[PATCH v5 54/80] drm/vc4: hdmi: Add PHY RNG enable / disable function

2020-09-03 Thread Maxime Ripard
Let's continue the implementation of hooks for the parts that change in the BCM2711 SoC with the PHY RNG setup. Reviewed-by: Dave Stevenson Tested-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 15

[PATCH v5 57/80] drm/vc4: hdmi: Store the encoder type in the variant structure

2020-09-03 Thread Maxime Ripard
-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 3 ++- drivers/gpu/drm/vc4/vc4_hdmi.h | 3 +++ 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 9e2bc6cb690e

[PATCH v5 63/80] drm/vc4: hdmi: Adjust HSM clock rate depending on pixel rate

2020-09-03 Thread Maxime Ripard
-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 79 --- drivers/gpu/drm/vc4/vc4_hdmi.h | 3 +- 2 files changed, 41 insertions(+), 41 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 1e6c0e26d186..84273fe650d6 100644

[PATCH v5 64/80] drm/vc4: hdmi: Use clk_set_min_rate instead

2020-09-03 Thread Maxime Ripard
-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index 84273fe650d6..487c04de6b85 100644 --- a/drivers/gpu/drm/vc4/vc4_hdmi.c +++ b/drivers/gpu/drm/vc4

[PATCH v5 68/80] drm/vc4: hdmi: Add audio-related callbacks

2020-09-03 Thread Maxime Ripard
-by: Dave Stevenson Signed-off-by: Maxime Ripard --- drivers/gpu/drm/vc4/vc4_hdmi.c | 25 + drivers/gpu/drm/vc4/vc4_hdmi.h | 4 2 files changed, 21 insertions(+), 8 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_hdmi.c b/drivers/gpu/drm/vc4/vc4_hdmi.c index

[PATCH v5 79/80] drm/vc4: drv: Support BCM2711

2020-09-03 Thread Maxime Ripard
The BCM2711 has a reworked display pipeline, and the load tracker needs some adjustment to operate properly. Let's add a compatible for BCM2711 and disable the load tracker until properly supported. Tested-by: Chanwoo Choi Tested-by: Hoegeun Kwon Tested-by: Stefan Wahren Signed-off-by: Maxime

<    1   2   3   4   5   6   7   8   9   10   >