[PATCH v8 1/6] vmcore: Introduce ELF header in new memory feature

2013-07-23 Thread Michael Holzheu
by the architecture backend code to read from new memory: * elfcorehdr_alloc: Allocate ELF header * elfcorehdr_free: Free the memory of the ELF header * elfcorehdr_read: Read from ELF header * elfcorehdr_read_notes: Read from ELF notes Signed-off-by: Michael Holzheu holz...@linux.vnet.ibm.com Acked

[PATCH v8 0/6] kdump: Allow ELF header creation in new kernel

2013-07-23 Thread Michael Holzheu
): s390/vmcore: Implement remap_oldmem_pfn_range for s390 Michael Holzheu (5): vmcore: Introduce ELF header in new memory feature s390/vmcore: Use ELF header in new memory feature vmcore: Introduce remap_oldmem_pfn_range() vmcore: Enable /proc/vmcore mmap for s390 s390/vmcore: Use vmcore

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

2013-07-18 Thread Michael Holzheu
On Thu, 18 Jul 2013 09:27:57 -0400 Vivek Goyal wrote: > On Thu, Jul 18, 2013 at 12:40:04PM +0200, Michael Holzheu wrote: > > On Wed, 17 Jul 2013 17:42:07 -0400 > > Vivek Goyal wrote: > > > On Wed, Jul 17, 2013 at 06:00:49PM +0200, Michael Holzh

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

2013-07-18 Thread Michael Holzheu
On Wed, 17 Jul 2013 17:42:07 -0400 Vivek Goyal wrote: > On Wed, Jul 17, 2013 at 06:00:49PM +0200, Michael Holzheu wrote: [snip] > > But this is all additional effort now and would not be necessary if we > > integrate this patch series in 3.11. > > > > Perhaps we sh

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

2013-07-18 Thread Michael Holzheu
On Wed, 17 Jul 2013 17:42:07 -0400 Vivek Goyal vgo...@redhat.com wrote: On Wed, Jul 17, 2013 at 06:00:49PM +0200, Michael Holzheu wrote: [snip] But this is all additional effort now and would not be necessary if we integrate this patch series in 3.11. Perhaps we should let Andrew

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

2013-07-18 Thread Michael Holzheu
On Thu, 18 Jul 2013 09:27:57 -0400 Vivek Goyal vgo...@redhat.com wrote: On Thu, Jul 18, 2013 at 12:40:04PM +0200, Michael Holzheu wrote: On Wed, 17 Jul 2013 17:42:07 -0400 Vivek Goyal vgo...@redhat.com wrote: On Wed, Jul 17, 2013 at 06:00:49PM +0200, Michael Holzheu wrote: [snip

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

2013-07-17 Thread Michael Holzheu
> On Tue, Jul 16, 2013 at 06:18:10PM +0200, Michael Holzheu wrote: > > Hello Andrew, > > > > Here a new kdump patch series that we have discussed with Vivek and > > Hatayama during the last months. > > > > Besides of the feature described below, this p

Re: [PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

2013-07-17 Thread Michael Holzheu
On Tue, Jul 16, 2013 at 06:18:10PM +0200, Michael Holzheu wrote: Hello Andrew, Here a new kdump patch series that we have discussed with Vivek and Hatayama during the last months. Besides of the feature described below, this patch series also fixes a regression on s390

[PATCH v7 4/5] s390/vmcore: Implement remap_oldmem_pfn_range for s390

2013-07-16 Thread Michael Holzheu
From: Jan Willeke This patch introduces the s390 specific way to map pages from oldmem. The memory area below OLDMEM_SIZE is mapped with offset OLDMEM_BASE. The other old memory is mapped directly. Signed-off-by: Jan Willeke Signed-off-by: Michael Holzheu --- arch/s390/kernel/crash_dump.c

[PATCH v7 2/5] s390/vmcore: Use ELF header in new memory feature

2013-07-16 Thread Michael Holzheu
This patch now exchanges the old relocate mechanism with the new arch function call override mechanism that allows to create the ELF core header in the 2nd kernel. Signed-off-by: Michael Holzheu --- arch/s390/kernel/crash_dump.c | 81 --- 1 file changed

[PATCH v7 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-07-16 Thread Michael Holzheu
. This handler works as follows: * Get already available or new page from page cache (find_or_create_page) * Check if /proc/vmcore page is filled with data (PageUptodate) * If yes: Return that page * If no: Fill page using __vmcore_read(), set PageUptodate, and return page Signed-off-by: Michael Holzheu

[PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

2013-07-16 Thread Michael Holzheu
py_oldmem_page() copies from HSA for memory below HSA_SIZE - copy_oldmem_page() copies from real memory for memory above HSA_SIZE --- Jan Willeke (1): s390/vmcore: Implement remap_oldmem_pfn_range for s390 Michael Holzheu (4): vmcore: Introduce ELF header in new memory feature s390/v

[PATCH v7 1/5] vmcore: Introduce ELF header in new memory feature

2013-07-16 Thread Michael Holzheu
by the architecture backend code to read from new memory: * elfcorehdr_alloc: Allocate ELF header * elfcorehdr_free: Free the memory of the ELF header * elfcorehdr_read: Read from ELF header * elfcorehdr_read_notes: Read from ELF notes Signed-off-by: Michael Holzheu Acked-by: Vivek Goyal --- fs

[PATCH v7 5/5] s390/vmcore: Use vmcore for zfcpdump

2013-07-16 Thread Michael Holzheu
This patch modifies the s390 copy_oldmem_page() and remap_oldmem_pfn_range() function for zfcpdump to read from the HSA memory if memory below HSA_SIZE bytes is requested. Otherwise real memory is used. Signed-off-by: Michael Holzheu --- arch/s390/Kconfig | 3 +- arch/s390/include

Re: [PATCH v6 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-07-16 Thread Michael Holzheu
On Tue, 16 Jul 2013 10:04:18 -0400 Vivek Goyal wrote: > On Tue, Jul 16, 2013 at 11:25:27AM +0200, Michael Holzheu wrote: > > [..] > > > > Hello Vivek and Andrew, > > > > > > > > We just realized that Hatayama's mmap patches went into v3.11-rc1. This

Re: [PATCH v6 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-07-16 Thread Michael Holzheu
On Mon, 15 Jul 2013 10:27:08 -0400 Vivek Goyal wrote: > On Mon, Jul 15, 2013 at 03:44:51PM +0200, Michael Holzheu wrote: > > On Tue, 2 Jul 2013 11:42:14 -0400 > > Vivek Goyal wrote: > > > > > On Mon, Jul 01, 2013 at 09:32:37PM +0200, Michael Holzheu wrote: >

Re: [PATCH v6 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-07-16 Thread Michael Holzheu
On Mon, 15 Jul 2013 10:27:08 -0400 Vivek Goyal vgo...@redhat.com wrote: On Mon, Jul 15, 2013 at 03:44:51PM +0200, Michael Holzheu wrote: On Tue, 2 Jul 2013 11:42:14 -0400 Vivek Goyal vgo...@redhat.com wrote: On Mon, Jul 01, 2013 at 09:32:37PM +0200, Michael Holzheu wrote

Re: [PATCH v6 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-07-16 Thread Michael Holzheu
On Tue, 16 Jul 2013 10:04:18 -0400 Vivek Goyal vgo...@redhat.com wrote: On Tue, Jul 16, 2013 at 11:25:27AM +0200, Michael Holzheu wrote: [..] Hello Vivek and Andrew, We just realized that Hatayama's mmap patches went into v3.11-rc1. This currently breaks s390 kdump

[PATCH v7 5/5] s390/vmcore: Use vmcore for zfcpdump

2013-07-16 Thread Michael Holzheu
This patch modifies the s390 copy_oldmem_page() and remap_oldmem_pfn_range() function for zfcpdump to read from the HSA memory if memory below HSA_SIZE bytes is requested. Otherwise real memory is used. Signed-off-by: Michael Holzheu holz...@linux.vnet.ibm.com --- arch/s390/Kconfig

[PATCH v7 1/5] vmcore: Introduce ELF header in new memory feature

2013-07-16 Thread Michael Holzheu
by the architecture backend code to read from new memory: * elfcorehdr_alloc: Allocate ELF header * elfcorehdr_free: Free the memory of the ELF header * elfcorehdr_read: Read from ELF header * elfcorehdr_read_notes: Read from ELF notes Signed-off-by: Michael Holzheu holz...@linux.vnet.ibm.com Acked

[PATCH v7 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-07-16 Thread Michael Holzheu
. This handler works as follows: * Get already available or new page from page cache (find_or_create_page) * Check if /proc/vmcore page is filled with data (PageUptodate) * If yes: Return that page * If no: Fill page using __vmcore_read(), set PageUptodate, and return page Signed-off-by: Michael Holzheu

[PATCH v7 0/5] kdump: Allow ELF header creation in new kernel

2013-07-16 Thread Michael Holzheu
for memory below HSA_SIZE - copy_oldmem_page() copies from real memory for memory above HSA_SIZE --- Jan Willeke (1): s390/vmcore: Implement remap_oldmem_pfn_range for s390 Michael Holzheu (4): vmcore: Introduce ELF header in new memory feature s390/vmcore: Use ELF header in new memory

[PATCH v7 2/5] s390/vmcore: Use ELF header in new memory feature

2013-07-16 Thread Michael Holzheu
This patch now exchanges the old relocate mechanism with the new arch function call override mechanism that allows to create the ELF core header in the 2nd kernel. Signed-off-by: Michael Holzheu holz...@linux.vnet.ibm.com --- arch/s390/kernel/crash_dump.c | 81

[PATCH v7 4/5] s390/vmcore: Implement remap_oldmem_pfn_range for s390

2013-07-16 Thread Michael Holzheu
From: Jan Willeke will...@de.ibm.com This patch introduces the s390 specific way to map pages from oldmem. The memory area below OLDMEM_SIZE is mapped with offset OLDMEM_BASE. The other old memory is mapped directly. Signed-off-by: Jan Willeke will...@de.ibm.com Signed-off-by: Michael Holzheu

Re: [PATCH v6 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-07-15 Thread Michael Holzheu
On Tue, 2 Jul 2013 11:42:14 -0400 Vivek Goyal wrote: > On Mon, Jul 01, 2013 at 09:32:37PM +0200, Michael Holzheu wrote: > > For zfcpdump we can't map the HSA storage because it is only available > > via a read interface. Therefore, for the new vmcore mmap feature we have >

Re: [PATCH v6 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-07-15 Thread Michael Holzheu
On Tue, 2 Jul 2013 11:42:14 -0400 Vivek Goyal vgo...@redhat.com wrote: On Mon, Jul 01, 2013 at 09:32:37PM +0200, Michael Holzheu wrote: For zfcpdump we can't map the HSA storage because it is only available via a read interface. Therefore, for the new vmcore mmap feature we have introduce

Re: [PATCH v6 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-07-10 Thread Michael Holzheu
On Wed, 10 Jul 2013 18:50:18 +0900 HATAYAMA Daisuke wrote: [snip] > (2013/07/10 17:42), Michael Holzheu wrote: > > My suggestion is to add the WARN_ONCE() for #ifndef CONFIG_S390. This has > > the same > > effect as your suggestion for all architectures besides of s390.

Re: [PATCH v6 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-07-10 Thread Michael Holzheu
Hello Hatayama, On Tue, 09 Jul 2013 14:49:48 +0900 HATAYAMA Daisuke wrote: > (2013/07/08 23:28), Vivek Goyal wrote: > > On Mon, Jul 08, 2013 at 11:28:39AM +0200, Michael Holzheu wrote: > >> On Mon, 08 Jul 2013 14:32:09 +0900 > >> HATAYAMA Daisuke wrote: [sni

Re: [PATCH v6 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-07-10 Thread Michael Holzheu
Hello Hatayama, On Tue, 09 Jul 2013 14:49:48 +0900 HATAYAMA Daisuke d.hatay...@jp.fujitsu.com wrote: (2013/07/08 23:28), Vivek Goyal wrote: On Mon, Jul 08, 2013 at 11:28:39AM +0200, Michael Holzheu wrote: On Mon, 08 Jul 2013 14:32:09 +0900 HATAYAMA Daisuke d.hatay...@jp.fujitsu.com wrote

Re: [PATCH v6 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-07-10 Thread Michael Holzheu
On Wed, 10 Jul 2013 18:50:18 +0900 HATAYAMA Daisuke d.hatay...@jp.fujitsu.com wrote: [snip] (2013/07/10 17:42), Michael Holzheu wrote: My suggestion is to add the WARN_ONCE() for #ifndef CONFIG_S390. This has the same effect as your suggestion for all architectures besides of s390

Re: [PATCH v6 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-07-08 Thread Michael Holzheu
On Mon, 08 Jul 2013 14:32:09 +0900 HATAYAMA Daisuke wrote: > (2013/07/02 4:32), Michael Holzheu wrote: > > For zfcpdump we can't map the HSA storage because it is only available > > via a read interface. Therefore, for the new vmcore mmap feature we have > > introduce a ne

Re: [PATCH v6 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-07-08 Thread Michael Holzheu
On Mon, 08 Jul 2013 14:32:09 +0900 HATAYAMA Daisuke d.hatay...@jp.fujitsu.com wrote: (2013/07/02 4:32), Michael Holzheu wrote: For zfcpdump we can't map the HSA storage because it is only available via a read interface. Therefore, for the new vmcore mmap feature we have introduce a new

Re: [PATCH v6 2/5] s390/vmcore: Use ELF header in new memory feature

2013-07-03 Thread Michael Holzheu
On Wed, 3 Jul 2013 10:15:29 -0400 Vivek Goyal wrote: > On Wed, Jul 03, 2013 at 09:59:13AM +0200, Michael Holzheu wrote: > > On Tue, 2 Jul 2013 12:23:23 -0400 > > Vivek Goyal wrote: > > > > > On Mon, Jul 01, 2013 at 09:32:36PM +0200, Michael Holzheu wrote: >

Re: [PATCH v6 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-07-03 Thread Michael Holzheu
On Tue, 2 Jul 2013 11:42:14 -0400 Vivek Goyal wrote: > On Mon, Jul 01, 2013 at 09:32:37PM +0200, Michael Holzheu wrote: [snip] > > This handler works as follows: > > > > * Get already available or new page from page cache (find_or_create_page) > > * Check if

Re: [PATCH v6 2/5] s390/vmcore: Use ELF header in new memory feature

2013-07-03 Thread Michael Holzheu
On Tue, 2 Jul 2013 12:23:23 -0400 Vivek Goyal wrote: > On Mon, Jul 01, 2013 at 09:32:36PM +0200, Michael Holzheu wrote: > > [..] > > +ssize_t elfcorehdr_read(char *buf, size_t count, u64 *ppos) > > +{ > > + void *src = (void *)(unsigned long)*ppos; > > + >

Re: [PATCH v6 2/5] s390/vmcore: Use ELF header in new memory feature

2013-07-03 Thread Michael Holzheu
On Tue, 2 Jul 2013 12:23:23 -0400 Vivek Goyal vgo...@redhat.com wrote: On Mon, Jul 01, 2013 at 09:32:36PM +0200, Michael Holzheu wrote: [..] +ssize_t elfcorehdr_read(char *buf, size_t count, u64 *ppos) +{ + void *src = (void *)(unsigned long)*ppos; + + src = elfcorehdr_newmem

Re: [PATCH v6 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-07-03 Thread Michael Holzheu
On Tue, 2 Jul 2013 11:42:14 -0400 Vivek Goyal vgo...@redhat.com wrote: On Mon, Jul 01, 2013 at 09:32:37PM +0200, Michael Holzheu wrote: [snip] This handler works as follows: * Get already available or new page from page cache (find_or_create_page) * Check if /proc/vmcore page

Re: [PATCH v6 2/5] s390/vmcore: Use ELF header in new memory feature

2013-07-03 Thread Michael Holzheu
On Wed, 3 Jul 2013 10:15:29 -0400 Vivek Goyal vgo...@redhat.com wrote: On Wed, Jul 03, 2013 at 09:59:13AM +0200, Michael Holzheu wrote: On Tue, 2 Jul 2013 12:23:23 -0400 Vivek Goyal vgo...@redhat.com wrote: On Mon, Jul 01, 2013 at 09:32:36PM +0200, Michael Holzheu wrote

[PATCH v6 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-07-01 Thread Michael Holzheu
. This handler works as follows: * Get already available or new page from page cache (find_or_create_page) * Check if /proc/vmcore page is filled with data (PageUptodate) * If yes: Return that page * If no: Fill page using __vmcore_read(), set PageUptodate, and return page Signed-off-by: Michael Holzheu

[PATCH v6 2/5] s390/vmcore: Use ELF header in new memory feature

2013-07-01 Thread Michael Holzheu
This patch now exchanges the old relocate mechanism with the new arch function call override mechanism that allows to create the ELF core header in the 2nd kernel. Signed-off-by: Michael Holzheu --- arch/s390/kernel/crash_dump.c | 81 --- 1 file changed

[PATCH v6 5/5] s390/vmcore: Use vmcore for zfcpdump

2013-07-01 Thread Michael Holzheu
This patch modifies the s390 copy_oldmem_page() and remap_oldmem_pfn_range() function for zfcpdump to read from the HSA memory if memory below HSA_SIZE bytes is requested. Otherwise real memory is used. Signed-off-by: Michael Holzheu --- arch/s390/Kconfig | 3 +- arch/s390/include

[PATCH v6 1/5] vmcore: Introduce ELF header in new memory feature

2013-07-01 Thread Michael Holzheu
by the architecture backend code to read from new memory: * elfcorehdr_alloc: Allocate ELF header * elfcorehdr_free: Free the memory of the ELF header * elfcorehdr_read: Read from ELF header * elfcorehdr_read_notes: Read from ELF notes Signed-off-by: Michael Holzheu --- fs/proc/vmcore.c

[PATCH v6 0/5] kdump: Allow ELF header creation in new kernel

2013-07-01 Thread Michael Holzheu
nt remap_oldmem_pfn_range for s390 Michael Holzheu (4): vmcore: Introduce ELF header in new memory feature s390/vmcore: Use ELF header in new memory feature vmcore: Introduce remap_oldmem_pfn_range() s390/vmcore: Use vmcore for zfcpdump arch/s390/Kconfig | 3 +- arch/s390/

[PATCH v6 4/5] s390/vmcore: Implement remap_oldmem_pfn_range for s390

2013-07-01 Thread Michael Holzheu
From: Jan Willeke This patch introduces the s390 specific way to map pages from oldmem. The memory area below OLDMEM_SIZE is mapped with offset OLDMEM_BASE. The other old memory is mapped directly. Signed-off-by: Jan Willeke Signed-off-by: Michael Holzheu --- arch/s390/kernel/crash_dump.c

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-07-01 Thread Michael Holzheu
On Mon, 1 Jul 2013 13:37:27 -0400 Vivek Goyal wrote: > On Fri, Jun 28, 2013 at 10:15:52AM +0200, Michael Holzheu wrote: > > On Thu, 27 Jun 2013 16:23:34 -0400 > > Vivek Goyal wrote: > > > > > On Thu, Jun 27, 2013 at 03:32:02PM -0400, Vivek Goyal wrote: > &g

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-07-01 Thread Michael Holzheu
On Mon, 1 Jul 2013 13:37:27 -0400 Vivek Goyal vgo...@redhat.com wrote: On Fri, Jun 28, 2013 at 10:15:52AM +0200, Michael Holzheu wrote: On Thu, 27 Jun 2013 16:23:34 -0400 Vivek Goyal vgo...@redhat.com wrote: On Thu, Jun 27, 2013 at 03:32:02PM -0400, Vivek Goyal wrote: On Fri, Jun

[PATCH v6 4/5] s390/vmcore: Implement remap_oldmem_pfn_range for s390

2013-07-01 Thread Michael Holzheu
From: Jan Willeke will...@de.ibm.com This patch introduces the s390 specific way to map pages from oldmem. The memory area below OLDMEM_SIZE is mapped with offset OLDMEM_BASE. The other old memory is mapped directly. Signed-off-by: Jan Willeke will...@de.ibm.com Signed-off-by: Michael Holzheu

[PATCH v6 1/5] vmcore: Introduce ELF header in new memory feature

2013-07-01 Thread Michael Holzheu
by the architecture backend code to read from new memory: * elfcorehdr_alloc: Allocate ELF header * elfcorehdr_free: Free the memory of the ELF header * elfcorehdr_read: Read from ELF header * elfcorehdr_read_notes: Read from ELF notes Signed-off-by: Michael Holzheu holz...@linux.vnet.ibm.com --- fs

[PATCH v6 0/5] kdump: Allow ELF header creation in new kernel

2013-07-01 Thread Michael Holzheu
Michael Holzheu (4): vmcore: Introduce ELF header in new memory feature s390/vmcore: Use ELF header in new memory feature vmcore: Introduce remap_oldmem_pfn_range() s390/vmcore: Use vmcore for zfcpdump arch/s390/Kconfig | 3 +- arch/s390/include/asm/sclp.h | 1 + arch/s390

[PATCH v6 2/5] s390/vmcore: Use ELF header in new memory feature

2013-07-01 Thread Michael Holzheu
This patch now exchanges the old relocate mechanism with the new arch function call override mechanism that allows to create the ELF core header in the 2nd kernel. Signed-off-by: Michael Holzheu holz...@linux.vnet.ibm.com --- arch/s390/kernel/crash_dump.c | 81

[PATCH v6 5/5] s390/vmcore: Use vmcore for zfcpdump

2013-07-01 Thread Michael Holzheu
This patch modifies the s390 copy_oldmem_page() and remap_oldmem_pfn_range() function for zfcpdump to read from the HSA memory if memory below HSA_SIZE bytes is requested. Otherwise real memory is used. Signed-off-by: Michael Holzheu holz...@linux.vnet.ibm.com --- arch/s390/Kconfig

[PATCH v6 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-07-01 Thread Michael Holzheu
. This handler works as follows: * Get already available or new page from page cache (find_or_create_page) * Check if /proc/vmcore page is filled with data (PageUptodate) * If yes: Return that page * If no: Fill page using __vmcore_read(), set PageUptodate, and return page Signed-off-by: Michael Holzheu

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-28 Thread Michael Holzheu
On Thu, 27 Jun 2013 16:23:34 -0400 Vivek Goyal wrote: > On Thu, Jun 27, 2013 at 03:32:02PM -0400, Vivek Goyal wrote: > > On Fri, Jun 21, 2013 at 04:17:03PM +0200, Michael Holzheu wrote: > > > On Fri, 14 Jun 2013 14:54:02 -0400 > > > Vivek Goyal wrote: [snip] > T

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-28 Thread Michael Holzheu
On Thu, 27 Jun 2013 16:23:34 -0400 Vivek Goyal vgo...@redhat.com wrote: On Thu, Jun 27, 2013 at 03:32:02PM -0400, Vivek Goyal wrote: On Fri, Jun 21, 2013 at 04:17:03PM +0200, Michael Holzheu wrote: On Fri, 14 Jun 2013 14:54:02 -0400 Vivek Goyal vgo...@redhat.com wrote: [snip] Thinking

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-21 Thread Michael Holzheu
On Fri, 14 Jun 2013 14:54:02 -0400 Vivek Goyal wrote: > On Fri, Jun 07, 2013 at 06:55:57PM +0200, Michael Holzheu wrote: > > [..] > > @@ -935,10 +967,17 @@ static int __init vmcore_init(void) > > { > > int rc = 0; > > > > - /* If elfcorehdr= h

Re: [PATCH v5 0/5] kdump: Allow ELF header creation in new kernel

2013-06-21 Thread Michael Holzheu
On Fri, 14 Jun 2013 14:54:54 -0400 Vivek Goyal wrote: > On Fri, Jun 07, 2013 at 06:55:56PM +0200, Michael Holzheu wrote: > > [..] > > In this patch series I did not include the discussed ELF header swap trick > > patch because with the ELF header read functions

Re: [PATCH v5 0/5] kdump: Allow ELF header creation in new kernel

2013-06-21 Thread Michael Holzheu
On Fri, 14 Jun 2013 14:54:54 -0400 Vivek Goyal vgo...@redhat.com wrote: On Fri, Jun 07, 2013 at 06:55:56PM +0200, Michael Holzheu wrote: [..] In this patch series I did not include the discussed ELF header swap trick patch because with the ELF header read functions this patch currently

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-21 Thread Michael Holzheu
On Fri, 14 Jun 2013 14:54:02 -0400 Vivek Goyal vgo...@redhat.com wrote: On Fri, Jun 07, 2013 at 06:55:57PM +0200, Michael Holzheu wrote: [..] @@ -935,10 +967,17 @@ static int __init vmcore_init(void) { int rc = 0; - /* If elfcorehdr= has been passed in cmdline, then capture

Re: [PATCH v5 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-06-13 Thread Michael Holzheu
On Thu, 13 Jun 2013 10:32:48 +0900 HATAYAMA Daisuke wrote: > > Perhaps one open issue remains: > > > > Can we remove the page from the page cache if __read_vmcore() fails? > > > > Yes, use page_cache_release() after unlocking the page like: > > if (__read_vmcore(buf,

Re: [PATCH v5 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-06-13 Thread Michael Holzheu
On Thu, 13 Jun 2013 10:32:48 +0900 HATAYAMA Daisuke d.hatay...@jp.fujitsu.com wrote: Perhaps one open issue remains: Can we remove the page from the page cache if __read_vmcore() fails? Yes, use page_cache_release() after unlocking the page like: if

Re: [PATCH v5 5/5] s390/vmcore: Use vmcore for zfcpdump

2013-06-12 Thread Michael Holzheu
On Wed, 12 Jun 2013 08:47:52 +0900 HATAYAMA Daisuke wrote: > (2013/06/08 1:56), Michael Holzheu wrote: [snip] > > +static int remap_oldmem_pfn_range_zfcpdump(struct vm_area_struct *vma, > > + uns

Re: [PATCH v5 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-06-12 Thread Michael Holzheu
On Tue, 11 Jun 2013 21:42:15 +0900 HATAYAMA Daisuke wrote: > 2013/6/11 Michael Holzheu : > > On Mon, 10 Jun 2013 22:40:24 +0900 > > HATAYAMA Daisuke wrote: > > > >> 2013/6/8 Michael Holzheu : > >> > >> > @@ -225,6 +251,56 @@ static ssize_t

Re: [PATCH v5 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-06-12 Thread Michael Holzheu
On Tue, 11 Jun 2013 21:42:15 +0900 HATAYAMA Daisuke d.hatay...@gmail.com wrote: 2013/6/11 Michael Holzheu holz...@linux.vnet.ibm.com: On Mon, 10 Jun 2013 22:40:24 +0900 HATAYAMA Daisuke d.hatay...@gmail.com wrote: 2013/6/8 Michael Holzheu holz...@linux.vnet.ibm.com: cut @@ -225,6

Re: [PATCH v5 5/5] s390/vmcore: Use vmcore for zfcpdump

2013-06-12 Thread Michael Holzheu
On Wed, 12 Jun 2013 08:47:52 +0900 HATAYAMA Daisuke d.hatay...@jp.fujitsu.com wrote: (2013/06/08 1:56), Michael Holzheu wrote: [snip] +static int remap_oldmem_pfn_range_zfcpdump(struct vm_area_struct *vma, + unsigned long from

Re: [PATCH v5 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-06-10 Thread Michael Holzheu
On Mon, 10 Jun 2013 22:40:24 +0900 HATAYAMA Daisuke wrote: > 2013/6/8 Michael Holzheu : > > > @@ -225,6 +251,56 @@ static ssize_t read_vmcore(struct file *file, char > > __user *buffer, > > return acc; > > } > > > > +static ssize_t read_vmc

Re: [PATCH v5 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-06-10 Thread Michael Holzheu
On Mon, 10 Jun 2013 22:40:24 +0900 HATAYAMA Daisuke wrote: > > +static int mmap_vmcore_fault(struct vm_area_struct *vma, struct vm_fault > > *vmf) > > +{ > > + struct address_space *mapping = vma->vm_private_data; > > + pgoff_t index = vmf->pgoff; > > + struct page *page; > >

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-10 Thread Michael Holzheu
On Mon, 10 Jun 2013 22:35:30 +0900 HATAYAMA Daisuke wrote: > 2013/6/8 Michael Holzheu : > > > @@ -935,10 +967,17 @@ static int __init vmcore_init(void) > > { > > int rc = 0; > > > > - /* If elfcorehdr= has been passed in

Re: [PATCH v5 2/5] s390/vmcore: Use ELF header in new memory feature

2013-06-10 Thread Michael Holzheu
On Mon, 10 Jun 2013 22:36:57 +0900 HATAYAMA Daisuke wrote: > > -static int setup_kdump_elfcorehdr(void) > > +void elfcorehdr_free(void) > > { > > - size_t elfcorebuf_sz; > > - char *elfcorebuf; > > - > > - if (!OLDMEM_BASE || is_kdump_kernel()) > > - return

Re: [PATCH v5 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-06-10 Thread Michael Holzheu
On Sat, 8 Jun 2013 11:38:00 +0400 Maxim Uvarov wrote: [snip] > > +static int copy_to(void *target, void *src, size_t size, int > > userbuf) +{ > > + if (userbuf) { > > + if (copy_to_user(target, src, size)) > > + return -EFAULT; > > +

Re: [PATCH v5 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-06-10 Thread Michael Holzheu
On Sat, 8 Jun 2013 11:38:00 +0400 Maxim Uvarov muva...@gmail.com wrote: [snip] +static int copy_to(void *target, void *src, size_t size, int userbuf) +{ + if (userbuf) { + if (copy_to_user(target, src, size)) + return -EFAULT; +

Re: [PATCH v5 2/5] s390/vmcore: Use ELF header in new memory feature

2013-06-10 Thread Michael Holzheu
On Mon, 10 Jun 2013 22:36:57 +0900 HATAYAMA Daisuke d.hatay...@gmail.com wrote: -static int setup_kdump_elfcorehdr(void) +void elfcorehdr_free(void) { - size_t elfcorebuf_sz; - char *elfcorebuf; - - if (!OLDMEM_BASE || is_kdump_kernel()) - return

Re: [PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-10 Thread Michael Holzheu
On Mon, 10 Jun 2013 22:35:30 +0900 HATAYAMA Daisuke d.hatay...@gmail.com wrote: 2013/6/8 Michael Holzheu holz...@linux.vnet.ibm.com: cut @@ -935,10 +967,17 @@ static int __init vmcore_init(void) { int rc = 0; - /* If elfcorehdr= has been passed in cmdline, then capture

Re: [PATCH v5 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-06-10 Thread Michael Holzheu
On Mon, 10 Jun 2013 22:40:24 +0900 HATAYAMA Daisuke d.hatay...@gmail.com wrote: +static int mmap_vmcore_fault(struct vm_area_struct *vma, struct vm_fault *vmf) +{ + struct address_space *mapping = vma-vm_private_data; + pgoff_t index = vmf-pgoff; + struct page

Re: [PATCH v5 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-06-10 Thread Michael Holzheu
On Mon, 10 Jun 2013 22:40:24 +0900 HATAYAMA Daisuke d.hatay...@gmail.com wrote: 2013/6/8 Michael Holzheu holz...@linux.vnet.ibm.com: cut @@ -225,6 +251,56 @@ static ssize_t read_vmcore(struct file *file, char __user *buffer, return acc; } +static ssize_t read_vmcore(struct

[PATCH v5 2/5] s390/vmcore: Use ELF header in new memory feature

2013-06-07 Thread Michael Holzheu
This patch now exchanges the old relocate mechanism with the new arch function call override mechanism that allows to create the ELF core header in the 2nd kernel. Signed-off-by: Michael Holzheu --- arch/s390/kernel/crash_dump.c | 70 ++- 1 file changed

[PATCH v5 5/5] s390/vmcore: Use vmcore for zfcpdump

2013-06-07 Thread Michael Holzheu
This patch modifies the s390 copy_oldmem_page() and remap_oldmem_pfn_range() function for zfcpdump to read from the HSA memory if memory below HSA_SIZE bytes is requested. Otherwise real memory is used. Signed-off-by: Michael Holzheu --- arch/s390/Kconfig | 3 +- arch/s390/include

[PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-07 Thread Michael Holzheu
by the architecture backend code to read from new memory: * elfcorehdr_alloc: Return the address and size of the ELF header * elfcorehdr_free: Free the memory of the ELF header * elfcorehdr_read: Read from ELF header * elfcorehdr_read_notes: Read from ELF notes Signed-off-by: Michael Holzheu --- fs

[PATCH v5 0/5] kdump: Allow ELF header creation in new kernel

2013-06-07 Thread Michael Holzheu
oldmem_page() copies from HSA for memory below HSA_SIZE - copy_oldmem_page() copies from real memory for memory above HSA_SIZE Jan Willeke (1): s390/kdump/mmap: Implement remap_oldmem_pfn_range for s390 Michael Holzheu (4): kdump: Introduce ELF header in new memory feature s390/kdump: Use EL

[PATCH v5 4/5] s390/vmcore: Implement remap_oldmem_pfn_range for s390

2013-06-07 Thread Michael Holzheu
From: Jan Willeke This patch introduces the s390 specific way to map pages from oldmem. The memory area below OLDMEM_SIZE is mapped with offset OLDMEM_BASE. The other old memory is mapped directly. Signed-off-by: Jan Willeke Signed-off-by: Michael Holzheu --- arch/s390/kernel/crash_dump.c

[PATCH v5 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-06-07 Thread Michael Holzheu
. This handler does the following: * Check if /proc/vmcore page cache page is already available * If yes: - Return that page * If no: - Allocate new page - Fill page using __vmcore_read() - Add new page to page cache Signed-off-by: Michael Holzheu --- fs/proc/vmcore.c | 94

[PATCH v5 3/5] vmcore: Introduce remap_oldmem_pfn_range()

2013-06-07 Thread Michael Holzheu
. This handler does the following: * Check if /proc/vmcore page cache page is already available * If yes: - Return that page * If no: - Allocate new page - Fill page using __vmcore_read() - Add new page to page cache Signed-off-by: Michael Holzheu holz...@linux.vnet.ibm.com --- fs/proc/vmcore.c

[PATCH v5 1/5] vmcore: Introduce ELF header in new memory feature

2013-06-07 Thread Michael Holzheu
by the architecture backend code to read from new memory: * elfcorehdr_alloc: Return the address and size of the ELF header * elfcorehdr_free: Free the memory of the ELF header * elfcorehdr_read: Read from ELF header * elfcorehdr_read_notes: Read from ELF notes Signed-off-by: Michael Holzheu holz

[PATCH v5 0/5] kdump: Allow ELF header creation in new kernel

2013-06-07 Thread Michael Holzheu
() copies from real memory for memory above HSA_SIZE Jan Willeke (1): s390/kdump/mmap: Implement remap_oldmem_pfn_range for s390 Michael Holzheu (4): kdump: Introduce ELF header in new memory feature s390/kdump: Use ELF header in new memory feature vmcore/mmap: Introduce remap_oldmem_pfn_range

[PATCH v5 4/5] s390/vmcore: Implement remap_oldmem_pfn_range for s390

2013-06-07 Thread Michael Holzheu
From: Jan Willeke will...@de.ibm.com This patch introduces the s390 specific way to map pages from oldmem. The memory area below OLDMEM_SIZE is mapped with offset OLDMEM_BASE. The other old memory is mapped directly. Signed-off-by: Jan Willeke will...@de.ibm.com Signed-off-by: Michael Holzheu

[PATCH v5 2/5] s390/vmcore: Use ELF header in new memory feature

2013-06-07 Thread Michael Holzheu
This patch now exchanges the old relocate mechanism with the new arch function call override mechanism that allows to create the ELF core header in the 2nd kernel. Signed-off-by: Michael Holzheu holz...@linux.vnet.ibm.com --- arch/s390/kernel/crash_dump.c | 70

[PATCH v5 5/5] s390/vmcore: Use vmcore for zfcpdump

2013-06-07 Thread Michael Holzheu
This patch modifies the s390 copy_oldmem_page() and remap_oldmem_pfn_range() function for zfcpdump to read from the HSA memory if memory below HSA_SIZE bytes is requested. Otherwise real memory is used. Signed-off-by: Michael Holzheu holz...@linux.vnet.ibm.com --- arch/s390/Kconfig

Re: [PATCH 0/2] kdump/mmap: Fix mmap of /proc/vmcore for s390

2013-06-03 Thread Michael Holzheu
On Mon, 3 Jun 2013 11:59:40 -0400 Vivek Goyal wrote: > On Mon, Jun 03, 2013 at 03:27:18PM +0200, Michael Holzheu wrote: > > [..] > > > If not, how would remap_pfn_range() work with HSA region when > > > /proc/vmcore is mmaped()? > > > > I am no m

Re: [PATCH 0/2] kdump/mmap: Fix mmap of /proc/vmcore for s390

2013-06-03 Thread Michael Holzheu
On Fri, 31 May 2013 12:01:58 -0400 Vivek Goyal wrote: > On Fri, May 31, 2013 at 04:21:27PM +0200, Michael Holzheu wrote: > > On Thu, 30 May 2013 16:38:47 -0400 > > Vivek Goyal wrote: > > > > > On Wed, May 29, 2013 at 01:51:44PM +0200, Michael Holzheu wrote: &

Re: [PATCH 0/2] kdump/mmap: Fix mmap of /proc/vmcore for s390

2013-06-03 Thread Michael Holzheu
On Fri, 31 May 2013 12:01:58 -0400 Vivek Goyal vgo...@redhat.com wrote: On Fri, May 31, 2013 at 04:21:27PM +0200, Michael Holzheu wrote: On Thu, 30 May 2013 16:38:47 -0400 Vivek Goyal vgo...@redhat.com wrote: On Wed, May 29, 2013 at 01:51:44PM +0200, Michael Holzheu wrote

Re: [PATCH 0/2] kdump/mmap: Fix mmap of /proc/vmcore for s390

2013-06-03 Thread Michael Holzheu
On Mon, 3 Jun 2013 11:59:40 -0400 Vivek Goyal vgo...@redhat.com wrote: On Mon, Jun 03, 2013 at 03:27:18PM +0200, Michael Holzheu wrote: [..] If not, how would remap_pfn_range() work with HSA region when /proc/vmcore is mmaped()? I am no memory management expert, so I discussed

Re: [PATCH 0/2] kdump/mmap: Fix mmap of /proc/vmcore for s390

2013-05-31 Thread Michael Holzheu
On Thu, 30 May 2013 16:38:47 -0400 Vivek Goyal wrote: > On Wed, May 29, 2013 at 01:51:44PM +0200, Michael Holzheu wrote: > > [..] > > >>> START QUOTE > > > > [PATCH v3 1/3] kdump: Introduce ELF header in new memory feature > > > > Currently f

Re: [PATCH 0/2] kdump/mmap: Fix mmap of /proc/vmcore for s390

2013-05-31 Thread Michael Holzheu
On Thu, 30 May 2013 16:38:47 -0400 Vivek Goyal vgo...@redhat.com wrote: On Wed, May 29, 2013 at 01:51:44PM +0200, Michael Holzheu wrote: [..] START QUOTE [PATCH v3 1/3] kdump: Introduce ELF header in new memory feature Currently for s390 we create the ELF core header in the 2nd

Re: [PATCH 0/2] kdump/mmap: Fix mmap of /proc/vmcore for s390

2013-05-29 Thread Michael Holzheu
On Wed, 29 May 2013 12:23:26 -0400 Vivek Goyal wrote: > On Wed, May 29, 2013 at 01:51:44PM +0200, Michael Holzheu wrote: > > On Tue, 28 May 2013 09:55:01 -0400 > > Vivek Goyal wrote: > > > > > On Sat, May 25, 2013 at 02:52:17PM +0200, Michael Holzheu wrote: > &

Re: [PATCH 0/2] kdump/mmap: Fix mmap of /proc/vmcore for s390

2013-05-29 Thread Michael Holzheu
On Tue, 28 May 2013 09:55:01 -0400 Vivek Goyal wrote: > On Sat, May 25, 2013 at 02:52:17PM +0200, Michael Holzheu wrote: [snip] > > Besides of the newmem mechanism, for completeness, we also > > implemented the oldmem ELF header mechansim in kexec. But this is > >

Re: [PATCH 0/2] kdump/mmap: Fix mmap of /proc/vmcore for s390

2013-05-29 Thread Michael Holzheu
On Tue, 28 May 2013 09:55:01 -0400 Vivek Goyal vgo...@redhat.com wrote: On Sat, May 25, 2013 at 02:52:17PM +0200, Michael Holzheu wrote: [snip] Besides of the newmem mechanism, for completeness, we also implemented the oldmem ELF header mechansim in kexec. But this is disabled by default

Re: [PATCH 0/2] kdump/mmap: Fix mmap of /proc/vmcore for s390

2013-05-29 Thread Michael Holzheu
On Wed, 29 May 2013 12:23:26 -0400 Vivek Goyal vgo...@redhat.com wrote: On Wed, May 29, 2013 at 01:51:44PM +0200, Michael Holzheu wrote: On Tue, 28 May 2013 09:55:01 -0400 Vivek Goyal vgo...@redhat.com wrote: On Sat, May 25, 2013 at 02:52:17PM +0200, Michael Holzheu wrote: [snip

Re: [PATCH 0/2] kdump/mmap: Fix mmap of /proc/vmcore for s390

2013-05-25 Thread Michael Holzheu
On Fri, 24 May 2013 13:05:07 -0400 Vivek Goyal wrote: > On Fri, May 24, 2013 at 06:46:53PM +0200, Michael Holzheu wrote: > > On Fri, 24 May 2013 11:28:49 -0400 > > Vivek Goyal wrote: > > > > > On Fri, May 24, 2013 at 05:06:26PM +0200, Michael Holzheu wrote: > &

Re: [PATCH 0/2] kdump/mmap: Fix mmap of /proc/vmcore for s390

2013-05-25 Thread Michael Holzheu
On Sat, 25 May 2013 16:31:58 +0800 Zhang Yanfei wrote: [snip] > For s390, if we put swap info into the elf header, This will > change /sbin/kexec. But at this point, copy_oldmem_page is still > doing the swap when we try to read the pages among [0 - OLDMEM_SIZE] > and [OLDMEM_BASE - OLDMEM_BASE

Re: [PATCH 0/2] kdump/mmap: Fix mmap of /proc/vmcore for s390

2013-05-25 Thread Michael Holzheu
On Sat, 25 May 2013 16:31:58 +0800 Zhang Yanfei zhangyanfei@gmail.com wrote: [snip] For s390, if we put swap info into the elf header, This will change /sbin/kexec. But at this point, copy_oldmem_page is still doing the swap when we try to read the pages among [0 - OLDMEM_SIZE] and

Re: [PATCH 0/2] kdump/mmap: Fix mmap of /proc/vmcore for s390

2013-05-25 Thread Michael Holzheu
On Fri, 24 May 2013 13:05:07 -0400 Vivek Goyal vgo...@redhat.com wrote: On Fri, May 24, 2013 at 06:46:53PM +0200, Michael Holzheu wrote: On Fri, 24 May 2013 11:28:49 -0400 Vivek Goyal vgo...@redhat.com wrote: On Fri, May 24, 2013 at 05:06:26PM +0200, Michael Holzheu wrote: [snip

<    1   2   3   >