Re: [PATCH] Fix IB va_start+ib_bytes range check on 32Bit systems

2017-03-29 Thread Michel Dänzer
(chunk_ib->va_start + chunk_ib->ib_bytes) > > (u64)(m->it.last + 1) * AMDGPU_GPU_PAGE_SIZE) { That won't work correctly if m->it.last == 0x ? Or is that not possible? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

Re: [PATCH] Fix IB va_start+ib_bytes range check on 32Bit systems

2017-03-29 Thread Michel Dänzer
+ chunk_ib->ib_bytes) > >> -(m->it.last + 1) * AMDGPU_GPU_PAGE_SIZE) { >> +(it_last + 1) * AMDGPU_GPU_PAGE_SIZE) { > > Nice catch, but just adding a u64 case should do here as well. E.g: > > if ((chunk_ib->va_sta

[PATCH] drm/fb-helper: Allow var->x/yres(_virtual) < fb->width/height again

2017-03-23 Thread Michel Dänzer
From: Michel Dänzer <michel.daen...@amd.com> Otherwise this can also prevent modesets e.g. for switching VTs, when multiple monitors with different native resolutions are connected. The depths must match though, so keep the != test for that. Also update the DRM_DEBUG output to be slightl

[PATCH] drm/fb-helper: Allow var->x/yres(_virtual) < fb->width/height again

2017-03-23 Thread Michel Dänzer
From: Michel Dänzer Otherwise this can also prevent modesets e.g. for switching VTs, when multiple monitors with different native resolutions are connected. The depths must match though, so keep the != test for that. Also update the DRM_DEBUG output to be slightly more accurate, this doesn't

Re: [PATCH] drm/fb-helper: Only reject FB changes if FB_MISC_USER_EVENT is set

2017-03-20 Thread Michel Dänzer
On 17/03/17 08:13 PM, Ville Syrjälä wrote: > On Fri, Mar 17, 2017 at 07:19:27PM +0900, Michel Dänzer wrote: >> On 17/03/17 07:01 PM, Ville Syrjälä wrote: >>> On Fri, Mar 17, 2017 at 06:01:41PM +0900, Michel Dänzer wrote: >>>> On 16/03/17 07:09 PM, Ville Syrjälä wro

Re: [PATCH] drm/fb-helper: Only reject FB changes if FB_MISC_USER_EVENT is set

2017-03-20 Thread Michel Dänzer
On 17/03/17 08:13 PM, Ville Syrjälä wrote: > On Fri, Mar 17, 2017 at 07:19:27PM +0900, Michel Dänzer wrote: >> On 17/03/17 07:01 PM, Ville Syrjälä wrote: >>> On Fri, Mar 17, 2017 at 06:01:41PM +0900, Michel Dänzer wrote: >>>> On 16/03/17 07:09 PM, Ville Syrjälä wro

Re: [PATCH] drm/fb-helper: Only reject FB changes if FB_MISC_USER_EVENT is set

2017-03-17 Thread Michel Dänzer
On 17/03/17 07:01 PM, Ville Syrjälä wrote: > On Fri, Mar 17, 2017 at 06:01:41PM +0900, Michel Dänzer wrote: >> On 16/03/17 07:09 PM, Ville Syrjälä wrote: >>> On Thu, Mar 16, 2017 at 06:55:53PM +0900, Michel Dänzer wrote: >>>> From: Michel Dänzer <michel.dae

Re: [PATCH] drm/fb-helper: Only reject FB changes if FB_MISC_USER_EVENT is set

2017-03-17 Thread Michel Dänzer
On 17/03/17 07:01 PM, Ville Syrjälä wrote: > On Fri, Mar 17, 2017 at 06:01:41PM +0900, Michel Dänzer wrote: >> On 16/03/17 07:09 PM, Ville Syrjälä wrote: >>> On Thu, Mar 16, 2017 at 06:55:53PM +0900, Michel Dänzer wrote: >>>> From: Michel Dänzer >>>> >

Re: [PATCH] drm/fb-helper: Only reject FB changes if FB_MISC_USER_EVENT is set

2017-03-17 Thread Michel Dänzer
On 16/03/17 07:09 PM, Ville Syrjälä wrote: > On Thu, Mar 16, 2017 at 06:55:53PM +0900, Michel Dänzer wrote: >> From: Michel Dänzer <michel.daen...@amd.com> >> >> Otherwise this can also prevent modesets e.g. for switching VTs. >> >> FB_MISC_USER_EVENT

Re: [PATCH] drm/fb-helper: Only reject FB changes if FB_MISC_USER_EVENT is set

2017-03-17 Thread Michel Dänzer
On 16/03/17 07:09 PM, Ville Syrjälä wrote: > On Thu, Mar 16, 2017 at 06:55:53PM +0900, Michel Dänzer wrote: >> From: Michel Dänzer >> >> Otherwise this can also prevent modesets e.g. for switching VTs. >> >> FB_MISC_USER_EVENT is set when the request originates

Re: [PATCH] drm/fb-helper: Only reject FB changes if FB_MISC_USER_EVENT is set

2017-03-17 Thread Michel Dänzer
On 16/03/17 07:09 PM, Daniel Stone wrote: > On 16 March 2017 at 09:55, Michel Dänzer <mic...@daenzer.net> wrote: >> Otherwise this can also prevent modesets e.g. for switching VTs. >> >> FB_MISC_USER_EVENT is set when the request originates from userspace, >> which

Re: [PATCH] drm/fb-helper: Only reject FB changes if FB_MISC_USER_EVENT is set

2017-03-17 Thread Michel Dänzer
On 16/03/17 07:09 PM, Daniel Stone wrote: > On 16 March 2017 at 09:55, Michel Dänzer wrote: >> Otherwise this can also prevent modesets e.g. for switching VTs. >> >> FB_MISC_USER_EVENT is set when the request originates from userspace, >> which is what we're i

[PATCH] drm/fb-helper: Only reject FB changes if FB_MISC_USER_EVENT is set

2017-03-16 Thread Michel Dänzer
From: Michel Dänzer <michel.daen...@amd.com> Otherwise this can also prevent modesets e.g. for switching VTs. FB_MISC_USER_EVENT is set when the request originates from userspace, which is what we're interested in here according to the DRM_DEBUG output. Bugzilla: https://bugs.freedeskt

[PATCH] drm/fb-helper: Only reject FB changes if FB_MISC_USER_EVENT is set

2017-03-16 Thread Michel Dänzer
From: Michel Dänzer Otherwise this can also prevent modesets e.g. for switching VTs. FB_MISC_USER_EVENT is set when the request originates from userspace, which is what we're interested in here according to the DRM_DEBUG output. Bugzilla: https://bugs.freedesktop.org/99841 Fixes: 865afb11949e

Re: Linux 4.11: Reported regressions as of Tuesday, 20176-03-14

2017-03-14 Thread Michel Dänzer
init in 4.11. AMD folks, should this be addressed by fleshing out SI GDS support, or by completely disabling GDS initialization for SI? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

Re: Linux 4.11: Reported regressions as of Tuesday, 20176-03-14

2017-03-14 Thread Michel Dänzer
init in 4.11. AMD folks, should this be addressed by fleshing out SI GDS support, or by completely disabling GDS initialization for SI? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

Re: [PATCH 3.16 302/370] drm/radeon: Use mode h/vdisplay fields to hide out of bounds HW cursor

2017-03-12 Thread Michel Dänzer
On 10/03/17 08:46 PM, Ben Hutchings wrote: > 3.16.42-rc1 review patch. If anyone has any objections, please let me know. > > -- > > From: Michel Dänzer <michel.daen...@amd.com> > > commit d74c67dd7800fc7aae381f272875c337f268806c upstream. > &g

Re: [PATCH 3.16 302/370] drm/radeon: Use mode h/vdisplay fields to hide out of bounds HW cursor

2017-03-12 Thread Michel Dänzer
On 10/03/17 08:46 PM, Ben Hutchings wrote: > 3.16.42-rc1 review patch. If anyone has any objections, please let me know. > > -- > > From: Michel Dänzer > > commit d74c67dd7800fc7aae381f272875c337f268806c upstream. > > The crtc_h/vdisplay fields may

Re: [PATCH v3 2/2] drm/fb-helper: implement ioctl FBIO_WAITFORVSYNC

2017-02-21 Thread Michel Dänzer
intervals the ioctl returns, and which CRTCs are in vertical blank when it does. So it would be useless for both timing and tearing prevention purposes, i.e. more or less completely useless. -- Earthling Michel Dänzer | http://www.amd.com Libre software e

Re: [PATCH v3 2/2] drm/fb-helper: implement ioctl FBIO_WAITFORVSYNC

2017-02-21 Thread Michel Dänzer
intervals the ioctl returns, and which CRTCs are in vertical blank when it does. So it would be useless for both timing and tearing prevention purposes, i.e. more or less completely useless. -- Earthling Michel Dänzer | http://www.amd.com Libre software e

Re: [PATCH] drm/amdgpu: shut up #warning for compile testing

2017-02-03 Thread Michel Dänzer
On 02/02/17 06:36 PM, Christian König wrote: > Am 02.02.2017 um 07:09 schrieb Michel Dänzer: >> [SNIP] >> OTOH the people running the kernel aren't always the same people >> building it, so the downside is that this would potentially delay >> getting X86_PA

Re: [PATCH] drm/amdgpu: shut up #warning for compile testing

2017-02-03 Thread Michel Dänzer
On 02/02/17 06:36 PM, Christian König wrote: > Am 02.02.2017 um 07:09 schrieb Michel Dänzer: >> [SNIP] >> OTOH the people running the kernel aren't always the same people >> building it, so the downside is that this would potentially delay >> getting X86_PA

Re: [PATCH] drm/amdgpu: shut up #warning for compile testing

2017-02-01 Thread Michel Dänzer
ch > shuts it up for me, but not people that may actually want to run the kernel > as a compromize. This is fine with me as well. Whichever way we end up going for this, it should be applied to the radeon driver as well. -- Earthling Michel Dänzer |

Re: [PATCH] drm/amdgpu: shut up #warning for compile testing

2017-02-01 Thread Michel Dänzer
ch > shuts it up for me, but not people that may actually want to run the kernel > as a compromize. This is fine with me as well. Whichever way we end up going for this, it should be applied to the radeon driver as well. -- Earthling Michel Dänzer |

Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-26 Thread Michel Dänzer
On 26/01/17 09:46 AM, Sinclair Yeh wrote: > On Wed, Jan 25, 2017 at 10:49:33AM +0100, Christian König wrote: >> Am 25.01.2017 um 10:25 schrieb Thomas Hellstrom: >>> On 01/25/2017 09:21 AM, Michel Dänzer wrote: >>>> From: Michel Dänzer <michel.daen...@amd.com>

Re: [PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-26 Thread Michel Dänzer
On 26/01/17 09:46 AM, Sinclair Yeh wrote: > On Wed, Jan 25, 2017 at 10:49:33AM +0100, Christian König wrote: >> Am 25.01.2017 um 10:25 schrieb Thomas Hellstrom: >>> On 01/25/2017 09:21 AM, Michel Dänzer wrote: >>>> From: Michel Dänzer >>>> >>>>

Re: [git pull] drm fixes for 4.10-rc6 (just missed rc5 tagging :-)

2017-01-25 Thread Michel Dänzer
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=3846fd9b86001bea171943cc3bb9222cb6da6b42 Daniel, please take a look. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

Re: [git pull] drm fixes for 4.10-rc6 (just missed rc5 tagging :-)

2017-01-25 Thread Michel Dänzer
https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=3846fd9b86001bea171943cc3bb9222cb6da6b42 Daniel, please take a look. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

[PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-25 Thread Michel Dänzer
From: Michel Dänzer <michel.daen...@amd.com> The current caching state may not be tt_cached, even though the placement contains TTM_PL_FLAG_CACHED, because placement can contain multiple caching flags. Trying to swap out such a BO would trip up the BUG_ON(ttm->caching_state !=

[PATCH] drm/ttm: Make sure BOs being swapped out are cacheable

2017-01-25 Thread Michel Dänzer
From: Michel Dänzer The current caching state may not be tt_cached, even though the placement contains TTM_PL_FLAG_CACHED, because placement can contain multiple caching flags. Trying to swap out such a BO would trip up the BUG_ON(ttm->caching_state != tt_cached); in ttm_tt_swap

Re: amdgpu: Corrupted video on 32 bit systems (possible fix)

2017-01-20 Thread Michel Dänzer
On 20/01/17 04:44 PM, Nils Holland wrote: > On Fri, Jan 20, 2017 at 11:47:53AM +0900, Michel Dänzer wrote: >> On 20/01/17 04:35 AM, Nils Holland wrote: >>> >>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c2016-12-11 >>> 20:17:54.0 +0100

Re: amdgpu: Corrupted video on 32 bit systems (possible fix)

2017-01-20 Thread Michel Dänzer
On 20/01/17 04:44 PM, Nils Holland wrote: > On Fri, Jan 20, 2017 at 11:47:53AM +0900, Michel Dänzer wrote: >> On 20/01/17 04:35 AM, Nils Holland wrote: >>> >>> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_object.c2016-12-11 >>> 20:17:54.0 +0100

Re: amdgpu: Corrupted video on 32 bit systems (possible fix)

2017-01-19 Thread Michel Dänzer
er works fine for me on my 32 bit > kernel: All graphics output looks the way it's supposed to, even with > full acceleration enabled - great! > > I'd suggest that it might be a good idea to put to apply the above > patch or something similar to the official sources. Indeed. Do y

Re: amdgpu: Corrupted video on 32 bit systems (possible fix)

2017-01-19 Thread Michel Dänzer
er works fine for me on my 32 bit > kernel: All graphics output looks the way it's supposed to, even with > full acceleration enabled - great! > > I'd suggest that it might be a good idea to put to apply the above > patch or something similar to the official sources. Indeed. Do y

Re: [RFC PATCH 0/3] staging: remove fbdev drivers

2016-12-12 Thread Michel Dänzer
potentially trying to access the framebuffer at the most inconvenient times). There's still ttm_fbdev_mmap, but I'm not sure everything to make this fully work for userspace fbdev mappings is still there. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

Re: [RFC PATCH 0/3] staging: remove fbdev drivers

2016-12-12 Thread Michel Dänzer
potentially trying to access the framebuffer at the most inconvenient times). There's still ttm_fbdev_mmap, but I'm not sure everything to make this fully work for userspace fbdev mappings is still there. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

Re: [PATCH] drm/radeon: don't add files at control minor debugfs directory

2016-12-05 Thread Michel Dänzer
ertainly will get complains about > that rather fast. Suspect we already did: https://bugs.freedesktop.org/show_bug.cgi?id=98915 -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

Re: [PATCH] drm/radeon: don't add files at control minor debugfs directory

2016-12-05 Thread Michel Dänzer
ertainly will get complains about > that rather fast. Suspect we already did: https://bugs.freedesktop.org/show_bug.cgi?id=98915 -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

Re: drm: GPF in drm_getcap

2016-11-27 Thread Michel Dänzer
be more appropriate to return -ENOTSUPP rather >> than 0. Can't see how that would matter FWIW. > Seems a bit overkill, but can't hurt. This is most likely a > regression, probably introduced in > > commit f837297ad82480024d3ad08cd84f6670bcafa862 > Author: Michel Dänzer <michel.daen...@amd.com> > Dat

Re: drm: GPF in drm_getcap

2016-11-27 Thread Michel Dänzer
directory >> >> Looks like vgem. Something like this should help: >> >> https://gist.github.com/dvdhrm/1bcdf4f3485aa1614a0198a7b90515e2 >> >> I wonder whether it would be more appropriate to return -ENOTSUPP rather >> than 0. Can't see how that would

Re: radeon_connector_unregister NULL ptr deref

2016-10-24 Thread Michel Dänzer
badc1a3379fb3211e5 https://cgit.freedesktop.org/~airlied/linux/commit/?h=drm-next=9305ee6fe52035f63d70d023235b792ba22107f0 -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

Re: radeon_connector_unregister NULL ptr deref

2016-10-24 Thread Michel Dänzer
badc1a3379fb3211e5 https://cgit.freedesktop.org/~airlied/linux/commit/?h=drm-next=9305ee6fe52035f63d70d023235b792ba22107f0 -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

Re: kernel panic caused by raedon driver during reboot

2016-10-17 Thread Michel Dänzer
in Linus' tree soon: https://cgit.freedesktop.org/~airlied/linux/commit/?h=drm-next=b0c80bd5d2e317f7596fe2badc1a3379fb3211e5 https://cgit.freedesktop.org/~airlied/linux/commit/?h=drm-next=9305ee6fe52035f63d70d023235b792ba22107f0 -- Earthling Michel Dänzer | http://ww

Re: kernel panic caused by raedon driver during reboot

2016-10-17 Thread Michel Dänzer
in Linus' tree soon: https://cgit.freedesktop.org/~airlied/linux/commit/?h=drm-next=b0c80bd5d2e317f7596fe2badc1a3379fb3211e5 https://cgit.freedesktop.org/~airlied/linux/commit/?h=drm-next=9305ee6fe52035f63d70d023235b792ba22107f0 -- Earthling Michel Dänzer | http://ww

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-07 Thread Michel Dänzer
On 07.07.2016 16:43, Christian König wrote: > Am 07.07.2016 um 05:32 schrieb Michel Dänzer: >> On 06.07.2016 22:45, Tejun Heo wrote: >>> On Wed, Jul 06, 2016 at 12:12:52PM +0900, Michel Dänzer wrote: >>> >>>> Not being very familiar with the workqueue API

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-07 Thread Michel Dänzer
On 07.07.2016 16:43, Christian König wrote: > Am 07.07.2016 um 05:32 schrieb Michel Dänzer: >> On 06.07.2016 22:45, Tejun Heo wrote: >>> On Wed, Jul 06, 2016 at 12:12:52PM +0900, Michel Dänzer wrote: >>> >>>> Not being very familiar with the workqueue API

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-06 Thread Michel Dänzer
On 06.07.2016 22:45, Tejun Heo wrote: > On Wed, Jul 06, 2016 at 12:12:52PM +0900, Michel Dänzer wrote: > >> Not being very familiar with the workqueue APIs, I'll describe how it's >> supposed to work from a driver POV, which will hopefully help you guys >> decide

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-06 Thread Michel Dänzer
On 06.07.2016 22:45, Tejun Heo wrote: > On Wed, Jul 06, 2016 at 12:12:52PM +0900, Michel Dänzer wrote: > >> Not being very familiar with the workqueue APIs, I'll describe how it's >> supposed to work from a driver POV, which will hopefully help you guys >> decide

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-05 Thread Michel Dänzer
On 06.07.2016 06:06, Tejun Heo wrote: > On Mon, Jul 04, 2016 at 12:58:32PM +0900, Michel Dänzer wrote: >> On 02.07.2016 22:46, Tejun Heo wrote: >>> On Sat, Jul 02, 2016 at 04:33:50PM +0530, Bhaktipriya Shridhar wrote: >>>> alloc_workqueue replaces deprecated

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-05 Thread Michel Dänzer
On 06.07.2016 06:06, Tejun Heo wrote: > On Mon, Jul 04, 2016 at 12:58:32PM +0900, Michel Dänzer wrote: >> On 02.07.2016 22:46, Tejun Heo wrote: >>> On Sat, Jul 02, 2016 at 04:33:50PM +0530, Bhaktipriya Shridhar wrote: >>>> alloc_workqueue replaces deprecated

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-03 Thread Michel Dänzer
imit is unnecessary here. > > What are the involved work items? drivers/gpu/drm/radeon/radeon_display.c:radeon_flip_work_func() > Is it safe to run them concurrently? Concurrently with what exactly? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

Re: [PATCH] drm/radeon: Remove deprecated create_singlethread_workqueue

2016-07-03 Thread Michel Dänzer
imit is unnecessary here. > > What are the involved work items? drivers/gpu/drm/radeon/radeon_display.c:radeon_flip_work_func() > Is it safe to run them concurrently? Concurrently with what exactly? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

Re: [PATCH 06/10] drm/amdgpu: use drm_crtc_vblank_{on,off}()

2016-06-07 Thread Michel Dänzer
On 07.06.2016 23:07, Gustavo Padovan wrote: > From: Gustavo Padovan <gustavo.pado...@collabora.co.uk> > > Replace the legacy drm_vblank_{on,off}() with the new helper functions. > > Signed-off-by: Gustavo Padovan <gustavo.pado...@collabora.co.uk> Patches 6 & 8-10

Re: [PATCH 06/10] drm/amdgpu: use drm_crtc_vblank_{on,off}()

2016-06-07 Thread Michel Dänzer
On 07.06.2016 23:07, Gustavo Padovan wrote: > From: Gustavo Padovan > > Replace the legacy drm_vblank_{on,off}() with the new helper functions. > > Signed-off-by: Gustavo Padovan Patches 6 & 8-10 are Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer |

Re: [PATCH 08/14] drm/amdgpu: use drm_crtc_vblank_{get,put}()

2016-06-06 Thread Michel Dänzer
> @@ -268,7 +268,7 @@ int amdgpu_crtc_page_flip(struct drm_crtc *crtc, > return 0; > > vblank_cleanup: > - drm_vblank_put(crtc->dev, amdgpu_crtc->crtc_id); > + drm_crtc_vblank_put(_crtc->base); Can just use crtc here instead of _crtc->base.

Re: [PATCH 08/14] drm/amdgpu: use drm_crtc_vblank_{get,put}()

2016-06-06 Thread Michel Dänzer
, > return 0; > > vblank_cleanup: > - drm_vblank_put(crtc->dev, amdgpu_crtc->crtc_id); > + drm_crtc_vblank_put(_crtc->base); Can just use crtc here instead of _crtc->base. Same for the radeon patch. -- Earthling Michel Dänzer |

Re: [PATCH 01/14] drm/amdgpu: use drm_crtc_send_vblank_event()

2016-04-14 Thread Michel Dänzer
tatic int dce_v8_0_pageflip_irq(struct amdgpu_device > *adev, > > /* wakeup usersapce */ > if (works->event) > - drm_send_vblank_event(adev->ddev, crtc_id, works->event); > + drm_crtc_send_vblank_event(_crtc->base, works->event); > > spin_unl

Re: [PATCH 01/14] drm/amdgpu: use drm_crtc_send_vblank_event()

2016-04-14 Thread Michel Dänzer
/* wakeup usersapce */ > if (works->event) > - drm_send_vblank_event(adev->ddev, crtc_id, works->event); > + drm_crtc_send_vblank_event(_crtc->base, works->event); > > spin_unlock_irqrestore(>ddev->event_lock, flags); > > This patch and patch 8 are Reviewed-by: Michel Dänzer -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

Re: [PATCH 4.4 159/210] drm/radeon: disable runtime pm on PX laptops without dGPU power control

2016-04-13 Thread Michel Dänzer
On 12.04.2016 23:16, Greg Kroah-Hartman wrote: > On Mon, Apr 11, 2016 at 11:26:00AM +0900, Michel Dänzer wrote: >> On 11.04.2016 03:36, Greg Kroah-Hartman wrote: >>> 4.4-stable review patch. If anyone has any objections, please let me know. >> >> A regressi

Re: [PATCH 4.4 159/210] drm/radeon: disable runtime pm on PX laptops without dGPU power control

2016-04-13 Thread Michel Dänzer
On 12.04.2016 23:16, Greg Kroah-Hartman wrote: > On Mon, Apr 11, 2016 at 11:26:00AM +0900, Michel Dänzer wrote: >> On 11.04.2016 03:36, Greg Kroah-Hartman wrote: >>> 4.4-stable review patch. If anyone has any objections, please let me know. >> >> A regressi

Re: [PATCH 4.4 159/210] drm/radeon: disable runtime pm on PX laptops without dGPU power control

2016-04-12 Thread Michel Dänzer
On 12.04.2016 23:16, Greg Kroah-Hartman wrote: > On Mon, Apr 11, 2016 at 11:26:00AM +0900, Michel Dänzer wrote: >> On 11.04.2016 03:36, Greg Kroah-Hartman wrote: >>> 4.4-stable review patch. If anyone has any objections, please let me know. >> >> A regressi

Re: [PATCH 4.4 159/210] drm/radeon: disable runtime pm on PX laptops without dGPU power control

2016-04-12 Thread Michel Dänzer
On 12.04.2016 23:16, Greg Kroah-Hartman wrote: > On Mon, Apr 11, 2016 at 11:26:00AM +0900, Michel Dänzer wrote: >> On 11.04.2016 03:36, Greg Kroah-Hartman wrote: >>> 4.4-stable review patch. If anyone has any objections, please let me know. >> >> A regressi

Re: [PATCH 4.4 159/210] drm/radeon: disable runtime pm on PX laptops without dGPU power control

2016-04-10 Thread Michel Dänzer
bly the corresponding amdgpu commit as well). -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

Re: [PATCH 4.4 159/210] drm/radeon: disable runtime pm on PX laptops without dGPU power control

2016-04-10 Thread Michel Dänzer
bly the corresponding amdgpu commit as well). -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

Re: BUG caused by "Use new drm_fb_helper functions" series

2016-02-03 Thread Michel Dänzer
bution on my part. > This bug clearly has nothing to do with this series. > > But a better look has me wondering how all these gpus are syncing > the framebuffer for direct access via cfb_imageblit and friends. I only see > nouveau and intel gma even trying. Probably no

Re: BUG caused by "Use new drm_fb_helper functions" series

2016-02-03 Thread Michel Dänzer
bution on my part. > This bug clearly has nothing to do with this series. > > But a better look has me wondering how all these gpus are syncing > the framebuffer for direct access via cfb_imageblit and friends. I only see > nouveau and intel gma even trying. Probably no

Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon

2016-01-24 Thread Michel Dänzer
On 23.01.2016 00:18, Ville Syrjälä wrote: > On Fri, Jan 22, 2016 at 12:06:00PM +0900, Michel Dänzer wrote: >> >> [ Trimming KDE folks from Cc ] >> >> On 21.01.2016 19:09, Daniel Vetter wrote: >>> On Thu, Jan 21, 2016 at 05:36:46PM +0900, Michel Dänzer wrote: >

Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon

2016-01-24 Thread Michel Dänzer
On 23.01.2016 00:18, Ville Syrjälä wrote: > On Fri, Jan 22, 2016 at 12:06:00PM +0900, Michel Dänzer wrote: >> >> [ Trimming KDE folks from Cc ] >> >> On 21.01.2016 19:09, Daniel Vetter wrote: >>> On Thu, Jan 21, 2016 at 05:36:46PM +0900, Michel Dänzer wrote: >

Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon

2016-01-21 Thread Michel Dänzer
[ Trimming KDE folks from Cc ] On 21.01.2016 19:09, Daniel Vetter wrote: > On Thu, Jan 21, 2016 at 05:36:46PM +0900, Michel Dänzer wrote: >> On 21.01.2016 16:58, Daniel Vetter wrote: >>> >>> Can you please point me at the vblank on/off jump bug please? >&g

Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon

2016-01-21 Thread Michel Dänzer
On 21.01.2016 16:58, Daniel Vetter wrote: > On Thu, Jan 21, 2016 at 03:41:27PM +0900, Michel Dänzer wrote: >> On 21.01.2016 15:38, Michel Dänzer wrote: >>> On 21.01.2016 14:31, Mario Kleiner wrote: >>>> On 01/21/2016 04:43 AM, Michel Dänzer wrote: >>>>

Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon

2016-01-21 Thread Michel Dänzer
On 21.01.2016 16:58, Daniel Vetter wrote: > On Thu, Jan 21, 2016 at 03:41:27PM +0900, Michel Dänzer wrote: >> On 21.01.2016 15:38, Michel Dänzer wrote: >>> On 21.01.2016 14:31, Mario Kleiner wrote: >>>> On 01/21/2016 04:43 AM, Michel Dänzer wrote: >>>>

Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon

2016-01-21 Thread Michel Dänzer
[ Trimming KDE folks from Cc ] On 21.01.2016 19:09, Daniel Vetter wrote: > On Thu, Jan 21, 2016 at 05:36:46PM +0900, Michel Dänzer wrote: >> On 21.01.2016 16:58, Daniel Vetter wrote: >>> >>> Can you please point me at the vblank on/off jump bug please? >&g

Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon

2016-01-20 Thread Michel Dänzer
On 21.01.2016 15:38, Michel Dänzer wrote: > On 21.01.2016 14:31, Mario Kleiner wrote: >> On 01/21/2016 04:43 AM, Michel Dänzer wrote: >>> On 21.01.2016 05:32, Mario Kleiner wrote: >>>> >>>> So the problem is that AMDs hardware frame counters reset to &g

Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon

2016-01-20 Thread Michel Dänzer
On 21.01.2016 14:31, Mario Kleiner wrote: > On 01/21/2016 04:43 AM, Michel Dänzer wrote: >> On 21.01.2016 05:32, Mario Kleiner wrote: >>> >>> So the problem is that AMDs hardware frame counters reset to >>> zero during a modeset. The old DRM code dealt with driv

Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon

2016-01-20 Thread Michel Dänzer
f anybody has any ideas offhand... -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon

2016-01-20 Thread Michel Dänzer
On 21.01.2016 15:38, Michel Dänzer wrote: > On 21.01.2016 14:31, Mario Kleiner wrote: >> On 01/21/2016 04:43 AM, Michel Dänzer wrote: >>> On 21.01.2016 05:32, Mario Kleiner wrote: >>>> >>>> So the problem is that AMDs hardware frame counters reset to &g

Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon

2016-01-20 Thread Michel Dänzer
f anybody has any ideas offhand... -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer

Re: linux-4.4 bisected: kwin5 stuck on kde5 loading screen with radeon

2016-01-20 Thread Michel Dänzer
On 21.01.2016 14:31, Mario Kleiner wrote: > On 01/21/2016 04:43 AM, Michel Dänzer wrote: >> On 21.01.2016 05:32, Mario Kleiner wrote: >>> >>> So the problem is that AMDs hardware frame counters reset to >>> zero during a modeset. The old DRM code dealt with driv

Re: [PATCH 3/9] drm/vc4: Add create and map BO ioctls.

2015-12-07 Thread Michel Dänzer
none of the drivers do, either. daenzer@kaveri|11:55:31> grep '#include "drm.h"' include/uapi/drm/* include/uapi/drm/amdgpu_drm.h:#include "drm.h" include/uapi/drm/radeon_drm.h:#include "drm.h" Patches to convert the rest are pending. -- Earthling Michel Dänzer

Re: [PATCH 3/9] drm/vc4: Add create and map BO ioctls.

2015-12-07 Thread Michel Dänzer
to include/uapi/drm/drm.h in that tree? > and none of the drivers do, either. daenzer@kaveri|11:55:31> grep '#include "drm.h"' include/uapi/drm/* include/uapi/drm/amdgpu_drm.h:#include "drm.h" include/uapi/drm/radeon_drm.h:#include "drm.h" Patches to convert

Re: [radeon r100] when ring test fails, provide users with option to test

2015-12-01 Thread Michel Dänzer
a problem, you did not know how to debug it, but it already > happened to pebolle at tiscali ... and yes, it was agpmode. That > problem is clearly more common then you realize... So this should go > in. I agree with Christian, but at the very least, agpmode must not be m

Re: [radeon r100] when ring test fails, provide users with option to test

2015-12-01 Thread Michel Dänzer
83 > > . I had a problem, you did not know how to debug it, but it already > happened to pebolle at tiscali ... and yes, it was agpmode. That > problem is clearly more common then you realize... So this should go > in. I agree with Christian, but at the very least, agpmode must no

Re: [PATCH v2] drm: support hotspot for universal plane cursors

2015-11-18 Thread Michel Dänzer
On 18.11.2015 17:51, Daniel Vetter wrote: > On Wed, Nov 18, 2015 at 05:39:39PM +0900, Michel Dänzer wrote: >> On 18.11.2015 01:29, Daniel Vetter wrote: >>> >>> And no, I have absolutely no idea why radeon is pulling some tricks here, >>> whi

Re: [PATCH v2] drm: support hotspot for universal plane cursors

2015-11-18 Thread Michel Dänzer
isplay so we need to offset the plane position in order for the active >> pixel to be in the correct place. > > Nope, hot_x/y is just for virtual machines to indicate where the logical > cursor position is within the cursor plane. It should have 2 effect on how > someth

Re: [PATCH v2] drm: support hotspot for universal plane cursors

2015-11-18 Thread Michel Dänzer
active pixel on the >> display so we need to offset the plane position in order for the active >> pixel to be in the correct place. > > Nope, hot_x/y is just for virtual machines to indicate where the logical > cursor position is within the cursor plane. It should have 2 effect on h

Re: [PATCH v2] drm: support hotspot for universal plane cursors

2015-11-18 Thread Michel Dänzer
On 18.11.2015 17:51, Daniel Vetter wrote: > On Wed, Nov 18, 2015 at 05:39:39PM +0900, Michel Dänzer wrote: >> On 18.11.2015 01:29, Daniel Vetter wrote: >>> >>> And no, I have absolutely no idea why radeon is pulling some tricks here, >>> whi

Re: Mobility Radeon HD 4530/4570/545v: flicker in 1920x1080

2015-11-05 Thread Michel Dänzer
gt; > ..and same issue. And yes, it looks like an underflow to me. How can I > debug reclocking / underflows? Does radeon.disp_priority=2 help? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X develope

Re: Mobility Radeon HD 4530/4570/545v: flicker in 1920x1080

2015-11-05 Thread Michel Dänzer
gt; > ..and same issue. And yes, it looks like an underflow to me. How can I > debug reclocking / underflows? Does radeon.disp_priority=2 help? -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X develope

Re: [PATCH 3.16.y-ckt 072/104] drm/radeon: Restore LCD backlight level on resume (>= R5xx)

2015-11-01 Thread Michel Dänzer
On 28.10.2015 19:45, Luis Henriques wrote: > On Tue, Oct 27, 2015 at 11:10:29AM +0900, Michel Dänzer wrote: >> On 26.10.2015 22:42, Luis Henriques wrote: >>> 3.16.7-ckt19 -stable review patch. If anyone has any objections, please >>> let me know. >>> >>

Re: [PATCH 3.16.y-ckt 072/104] drm/radeon: Restore LCD backlight level on resume (>= R5xx)

2015-11-01 Thread Michel Dänzer
On 28.10.2015 19:45, Luis Henriques wrote: > On Tue, Oct 27, 2015 at 11:10:29AM +0900, Michel Dänzer wrote: >> On 26.10.2015 22:42, Luis Henriques wrote: >>> 3.16.7-ckt19 -stable review patch. If anyone has any objections, please >>> let me know. >>> >>

Re: Re: [Regression] 4.3.0rc4 through rc7: No LCD backlight on Thinkpad T60P

2015-10-29 Thread Michel Dänzer
een introduced between those. > > Well this looks like it might have something to do with it will > attempt a build just before it. > -- > commit 4281f46ef839050d2ef60348f661eb463c21cc2e > Author: Michel Dänzer > Date: Mon Sep 28 18:16:31 2015 +0900 > > drm/radeon: Rest

Re: Re: [Regression] 4.3.0rc4 through rc7: No LCD backlight on Thinkpad T60P

2015-10-29 Thread Michel Dänzer
een introduced between those. > > Well this looks like it might have something to do with it will > attempt a build just before it. > -- > commit 4281f46ef839050d2ef60348f661eb463c21cc2e > Author: Michel Dänzer <michel.daen...@amd.com> > Date: Mon Sep 28 18:16:31 2015

Re: [PATCH 3.16.y-ckt 072/104] drm/radeon: Restore LCD backlight level on resume (>= R5xx)

2015-10-26 Thread Michel Dänzer
On 26.10.2015 22:42, Luis Henriques wrote: > 3.16.7-ckt19 -stable review patch. If anyone has any objections, please let > me know. > > -- > > From: =TF-8?q?Michel Dänzer?= > > commit 4281f46ef839050d2ef60348f661eb463c21cc2e upstream. >

Re: [PATCH 3.16.y-ckt 072/104] drm/radeon: Restore LCD backlight level on resume (>= R5xx)

2015-10-26 Thread Michel Dänzer
On 26.10.2015 22:42, Luis Henriques wrote: > 3.16.7-ckt19 -stable review patch. If anyone has any objections, please let > me know. > > -- > > From: =TF-8?q?Michel Dänzer?= <michel.daen...@amd.com> > > commit 4281f46ef839050d2ef60348f661eb463

Re: [Regression v4.2] Re: [PATCH 7/9] drm/radeon: add VCE 1.0 support v4

2015-08-13 Thread Michel Dänzer
n driver is built into the kernel (or loaded from the initrd?), the attempt to load the firmware might take a long time to time out. Please provide more information about the symptoms, e.g. any dmesg output etc. -- Earthling Michel Dänzer | http://www.

Re: [Regression v4.2] Re: [PATCH 7/9] drm/radeon: add VCE 1.0 support v4

2015-08-13 Thread Michel Dänzer
the initrd?), the attempt to load the firmware might take a long time to time out. Please provide more information about the symptoms, e.g. any dmesg output etc. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa

Re: [Intel-gfx] [-next] WARNING at i915_gem_track_fb

2015-07-14 Thread Michel Dänzer
the DPMS state to on again. You can avoid that with something like "sleep 1 && xset dpms force off". -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer -- To unsubscribe fr

Re: [Intel-gfx] [-next] WARNING at i915_gem_track_fb

2015-07-14 Thread Michel Dänzer
state to on again. You can avoid that with something like sleep 1 xset dpms force off. -- Earthling Michel Dänzer | http://www.amd.com Libre software enthusiast | Mesa and X developer -- To unsubscribe from this list: send the line unsubscribe

Re: [PATCH 1/1] gpu/drm: remove unnecessary check before kfree

2015-06-26 Thread Michel Dänzer
); > adev->ip_block_enabled = NULL; > adev->accel_working = false; > /* free i2c buses */ > The shortlog prefix of both your patches should be "drm/amdgpu:" instead of "gpu/drm:". With that fixed, both are Reviewed-by: Michel Dänze

Re: [PATCH 1/1] gpu/drm: remove unnecessary check before kfree

2015-06-26 Thread Michel Dänzer
-accel_working = false; /* free i2c buses */ The shortlog prefix of both your patches should be drm/amdgpu: instead of gpu/drm:. With that fixed, both are Reviewed-by: Michel Dänzer michel.daen...@amd.com -- Earthling Michel Dänzer | http://www.amd.com Libre

<    1   2   3   4   >