[PATCH v3 02/13] perf util: store srcline in callchain_cursor_node

2017-09-06 Thread Milian Wolff
of the srcline and handle deletion properly. Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yao Jin Signed-off-by: Milian Wolff --- tools/perf/util/callchain.c | 31 +-- tools/perf/util/callchain.h | 6 -- tools/perf

[PATCH v3 08/13] perf report: compare symbol name for inlined frames when sorting

2017-09-06 Thread Milian Wolff
[.] cabs ~ Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com>

[PATCH v3 08/13] perf report: compare symbol name for inlined frames when sorting

2017-09-06 Thread Milian Wolff
(inlined) 12.29% 0.00% cpp-inlining cpp-inlining [.] std::linear_congruential_engine::operator() (inlined) 0.52% 0.52% cpp-inlining libm-2.25.so [.] cabs ~ Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yao Jin Signed-off-b

[PATCH v3 09/13] perf report: properly handle branch count in match_chain

2017-09-06 Thread Milian Wolff
Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/callchain.c | 115 +++- 1 file changed, 59

[PATCH v3 09/13] perf report: properly handle branch count in match_chain

2017-09-06 Thread Milian Wolff
Signed-off-by: Milian Wolff --- tools/perf/util/callchain.c | 115 +++- 1 file changed, 59 insertions(+), 56 deletions(-) diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c index 5c8aaa2c0123..9c355f02934f 100644 --- a/tools/perf/util

[PATCH v3 12/13] perf report: use srcline from callchain for hist entries

2017-09-06 Thread Milian Wolff
o Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/per

[PATCH v3 12/13] perf report: use srcline from callchain for hist entries

2017-09-06 Thread Milian Wolff
hypot_finite+163 4.13% 0.00% [.] __hypot_finite __hypot_finite+18446603487892193443 ... ~ Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yao Jin Signed-off-by: Milian Wolff --- t

[PATCH v3 10/13] perf report: cache failed lookups of inlined frames

2017-09-06 Thread Milian Wolff
.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/machine.c | 15 +++ tools/perf/util/srcline.c | 18 ++ 2 files changed, 9 insertions(+), 24 d

[PATCH v3 10/13] perf report: cache failed lookups of inlined frames

2017-09-06 Thread Milian Wolff
#1.66% of all branches ( +- 0.19% ) 0.114222393 seconds time elapsed ( +- 1.19% ) ~ Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yao Jin Signed-off-by: Milian Wolff --- tools

[PATCH v3 07/13] perf report: compare symbol name for inlined frames when matching

2017-09-06 Thread Milian Wolff
std::abs (inlined) std::__complex_abs (inlined) ~ Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com&

[PATCH v3 07/13] perf report: compare symbol name for inlined frames when matching

2017-09-06 Thread Milian Wolff
Jin Signed-off-by: Milian Wolff --- tools/perf/util/callchain.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c index 18362b23a976..5c8aaa2c0123 100644 --- a/tools/perf/util/callchain.c +++ b/tools/perf/util

[PATCH v3 13/13] perf util: enable handling of inlined frames by default

2017-09-06 Thread Milian Wolff
.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Cc: Ingo Molnar <mi...@kernel.org> Suggested-by: Ingo Molnar <mi...@kernel.org> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/Documentation/perf-report.txt |

[PATCH v3 13/13] perf util: enable handling of inlined frames by default

2017-09-06 Thread Milian Wolff
Molnar Signed-off-by: Milian Wolff --- tools/perf/Documentation/perf-report.txt | 3 ++- tools/perf/Documentation/perf-script.txt | 3 ++- tools/perf/util/symbol.c | 1 + 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/perf/Documentation/perf-report.txt b

[PATCH v3 11/13] perf report: cache srclines for callchain nodes

2017-09-06 Thread Milian Wolff
l.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/dso.c | 1 + tools/perf/util/dso.h | 1 + tools/perf/util/mac

[PATCH v3 11/13] perf report: cache srclines for callchain nodes

2017-09-06 Thread Milian Wolff
: Yao Jin Signed-off-by: Milian Wolff --- tools/perf/util/dso.c | 1 + tools/perf/util/dso.h | 1 + tools/perf/util/machine.c | 17 +--- tools/perf/util/srcline.c | 66 +++ tools/perf/util/srcline.h | 7 + 5 files changed, 89

[PATCH v3 00/13] generate full callchain cursor entries for inlined frames

2017-09-06 Thread Milian Wolff
amhyung. v2 fixes some issues reported by Namhyung or found by me in further testing, adds caching and enables inline frames by default. Milian Wolff (13): perf report: remove code to handle inline frames from browsers perf util: store srcline in callchain_cursor_node perf report: creat

[PATCH v3 00/13] generate full callchain cursor entries for inlined frames

2017-09-06 Thread Milian Wolff
its the initial patch up into two to simplify reviewing. It also adds a comment to clarify the lifetime handling of fake symbols and aliased non-fake symbols, based on the feedback by Namhyung. v2 fixes some issues reported by Namhyung or found by me in further testing, adds caching and enabl

Re: [PATCH v2 03/14] perf report: create real callchain entries for inlined frames

2017-09-06 Thread Milian Wolff
On Sonntag, 20. August 2017 22:57:17 CEST Milian Wolff wrote: > On Mittwoch, 16. August 2017 09:53:13 CEST Namhyung Kim wrote: > > Hi Milian, > > > > On Sun, Aug 06, 2017 at 11:24:35PM +0200, Milian Wolff wrote: > > > The inlined frames use a fake symbol that is

Re: [PATCH v2 03/14] perf report: create real callchain entries for inlined frames

2017-09-06 Thread Milian Wolff
On Sonntag, 20. August 2017 22:57:17 CEST Milian Wolff wrote: > On Mittwoch, 16. August 2017 09:53:13 CEST Namhyung Kim wrote: > > Hi Milian, > > > > On Sun, Aug 06, 2017 at 11:24:35PM +0200, Milian Wolff wrote: > > > The inlined frames use a fake symbol that is

Re: broken cycle counts from perf record in frequency mode [Was: Re: deducing CPU clock rate over time from cycle samples]

2017-09-05 Thread Milian Wolff
t of course that would only work for cycles, and not for instructions or any of the other fancy event counters. But since the frequency mode is probably similarly broken there, it should not be the default. Better ask the user for explicit values rather than doing something automatically whic

Re: broken cycle counts from perf record in frequency mode [Was: Re: deducing CPU clock rate over time from cycle samples]

2017-09-05 Thread Milian Wolff
t of course that would only work for cycles, and not for instructions or any of the other fancy event counters. But since the frequency mode is probably similarly broken there, it should not be the default. Better ask the user for explicit values rather than doing something automatically whic

Re: broken cycle counts from perf record in frequency mode [Was: Re: deducing CPU clock rate over time from cycle samples]

2017-09-04 Thread Milian Wolff
On Friday, September 1, 2017 6:48:20 PM CEST Andi Kleen wrote: > Milian Wolff <milian.wo...@kdab.com> writes: > > do you have any input on this issue? I really wonder why noone else is > > complaining about the frequency mode being unreliable or right out broken > > in

Re: broken cycle counts from perf record in frequency mode [Was: Re: deducing CPU clock rate over time from cycle samples]

2017-09-04 Thread Milian Wolff
On Friday, September 1, 2017 6:48:20 PM CEST Andi Kleen wrote: > Milian Wolff writes: > > do you have any input on this issue? I really wonder why noone else is > > complaining about the frequency mode being unreliable or right out broken > > in many situations. Since it'

Re: broken cycle counts from perf record in frequency mode [Was: Re: deducing CPU clock rate over time from cycle samples]

2017-09-01 Thread Milian Wolff
4:40:43PM +0200, Milian Wolff wrote: > > On Monday, August 28, 2017 4:08:47 PM CEST Milian Wolff wrote: > > > On Sunday, June 18, 2017 9:53:05 PM CEST Milian Wolff wrote: > > > > On Sonntag, 18. Juni 2017 06:22:19 CEST Andi Kleen wrote: > > > > > Milian Wol

Re: broken cycle counts from perf record in frequency mode [Was: Re: deducing CPU clock rate over time from cycle samples]

2017-09-01 Thread Milian Wolff
4:40:43PM +0200, Milian Wolff wrote: > > On Monday, August 28, 2017 4:08:47 PM CEST Milian Wolff wrote: > > > On Sunday, June 18, 2017 9:53:05 PM CEST Milian Wolff wrote: > > > > On Sonntag, 18. Juni 2017 06:22:19 CEST Andi Kleen wrote: > > > > > Milian

Re: broken cycle counts from perf record in frequency mode [Was: Re: deducing CPU clock rate over time from cycle samples]

2017-08-28 Thread Milian Wolff
On Monday, August 28, 2017 4:08:47 PM CEST Milian Wolff wrote: > On Sunday, June 18, 2017 9:53:05 PM CEST Milian Wolff wrote: > > On Sonntag, 18. Juni 2017 06:22:19 CEST Andi Kleen wrote: > > > Milian Wolff <milian.wo...@kdab.com> writes: > > > > But when I

Re: broken cycle counts from perf record in frequency mode [Was: Re: deducing CPU clock rate over time from cycle samples]

2017-08-28 Thread Milian Wolff
On Monday, August 28, 2017 4:08:47 PM CEST Milian Wolff wrote: > On Sunday, June 18, 2017 9:53:05 PM CEST Milian Wolff wrote: > > On Sonntag, 18. Juni 2017 06:22:19 CEST Andi Kleen wrote: > > > Milian Wolff writes: > > > > But when I look at the naive

broken cycle counts from perf record in frequency mode [Was: Re: deducing CPU clock rate over time from cycle samples]

2017-08-28 Thread Milian Wolff
On Sunday, June 18, 2017 9:53:05 PM CEST Milian Wolff wrote: > On Sonntag, 18. Juni 2017 06:22:19 CEST Andi Kleen wrote: > > Milian Wolff <milian.wo...@kdab.com> writes: > > > But when I look at the naively calculated first derivative, to visualize > > > CP

broken cycle counts from perf record in frequency mode [Was: Re: deducing CPU clock rate over time from cycle samples]

2017-08-28 Thread Milian Wolff
On Sunday, June 18, 2017 9:53:05 PM CEST Milian Wolff wrote: > On Sonntag, 18. Juni 2017 06:22:19 CEST Andi Kleen wrote: > > Milian Wolff writes: > > > But when I look at the naively calculated first derivative, to visualize > > > CPU load, i.e. CPU clock rate in Hz,

Re: [PATCH v2 03/14] perf report: create real callchain entries for inlined frames

2017-08-20 Thread Milian Wolff
On Mittwoch, 16. August 2017 09:53:13 CEST Namhyung Kim wrote: > Hi Milian, > > On Sun, Aug 06, 2017 at 11:24:35PM +0200, Milian Wolff wrote: > > The inlined frames use a fake symbol that is tracked in a special > > map inside the dso, which is always sorted by name. Al

Re: [PATCH v2 03/14] perf report: create real callchain entries for inlined frames

2017-08-20 Thread Milian Wolff
On Mittwoch, 16. August 2017 09:53:13 CEST Namhyung Kim wrote: > Hi Milian, > > On Sun, Aug 06, 2017 at 11:24:35PM +0200, Milian Wolff wrote: > > The inlined frames use a fake symbol that is tracked in a special > > map inside the dso, which is always sorted by name. Al

[tip:perf/core] perf srcline: Do not consider empty files as valid srclines

2017-08-14 Thread tip-bot for Milian Wolff
Commit-ID: d964b1cdbd94f359f1f65f81440be84ceb45978e Gitweb: http://git.kernel.org/tip/d964b1cdbd94f359f1f65f81440be84ceb45978e Author: Milian Wolff <milian.wo...@kdab.com> AuthorDate: Sun, 6 Aug 2017 23:24:45 +0200 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> CommitD

[tip:perf/core] perf srcline: Do not consider empty files as valid srclines

2017-08-14 Thread tip-bot for Milian Wolff
Commit-ID: d964b1cdbd94f359f1f65f81440be84ceb45978e Gitweb: http://git.kernel.org/tip/d964b1cdbd94f359f1f65f81440be84ceb45978e Author: Milian Wolff AuthorDate: Sun, 6 Aug 2017 23:24:45 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 11 Aug 2017 16:06:31 -0300 perf srcline

[tip:perf/core] perf util: Take elf_name as const string in dso__demangle_sym

2017-08-14 Thread tip-bot for Milian Wolff
Commit-ID: 80c345b255cbb4e9dfb193bf0bf5536217237f6a Gitweb: http://git.kernel.org/tip/80c345b255cbb4e9dfb193bf0bf5536217237f6a Author: Milian Wolff <milian.wo...@kdab.com> AuthorDate: Sun, 6 Aug 2017 23:24:34 +0200 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> CommitD

[tip:perf/core] perf util: Take elf_name as const string in dso__demangle_sym

2017-08-14 Thread tip-bot for Milian Wolff
Commit-ID: 80c345b255cbb4e9dfb193bf0bf5536217237f6a Gitweb: http://git.kernel.org/tip/80c345b255cbb4e9dfb193bf0bf5536217237f6a Author: Milian Wolff AuthorDate: Sun, 6 Aug 2017 23:24:34 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 11 Aug 2017 16:06:31 -0300 perf util

Re: [PATCH v2 11/14] perf report: cache srclines for callchain nodes

2017-08-11 Thread Milian Wolff
On Donnerstag, 10. August 2017 19:58:45 CEST Arnaldo Carvalho de Melo wrote: > Em Thu, Aug 10, 2017 at 11:56:24PM +0900, Namhyung Kim escreveu: > > On Thu, Aug 10, 2017 at 8:51 PM, Milian Wolff <milian.wo...@kdab.com> wrote: > > > On Donnerstag, 10. August 2017 04:13:25

Re: [PATCH v2 11/14] perf report: cache srclines for callchain nodes

2017-08-11 Thread Milian Wolff
On Donnerstag, 10. August 2017 19:58:45 CEST Arnaldo Carvalho de Melo wrote: > Em Thu, Aug 10, 2017 at 11:56:24PM +0900, Namhyung Kim escreveu: > > On Thu, Aug 10, 2017 at 8:51 PM, Milian Wolff wrote: > > > On Donnerstag, 10. August 2017 04:13:25 CEST Namhyung Kim wrote: >

Re: [PATCH v2 11/14] perf report: cache srclines for callchain nodes

2017-08-10 Thread Milian Wolff
On Donnerstag, 10. August 2017 04:13:25 CEST Namhyung Kim wrote: > Hi Milian, > > On Sun, Aug 06, 2017 at 11:24:43PM +0200, Milian Wolff wrote: > > On one hand this ensures that the memory is properly freed when > > the DSO gets freed. On the other hand this si

Re: [PATCH v2 11/14] perf report: cache srclines for callchain nodes

2017-08-10 Thread Milian Wolff
On Donnerstag, 10. August 2017 04:13:25 CEST Namhyung Kim wrote: > Hi Milian, > > On Sun, Aug 06, 2017 at 11:24:43PM +0200, Milian Wolff wrote: > > On one hand this ensures that the memory is properly freed when > > the DSO gets freed. On the other hand this si

Re: [PATCH v2 01/14] perf report: remove code to handle inline frames from browsers

2017-08-07 Thread Milian Wolff
On Montag, 7. August 2017 17:07:10 CEST Arnaldo Carvalho de Melo wrote: > Em Sun, Aug 06, 2017 at 11:24:33PM +0200, Milian Wolff escreveu: > > The follow-up commits will make inline frames first-class citizens > > in the callchain, thereby obsoleting all of this special co

Re: [PATCH v2 01/14] perf report: remove code to handle inline frames from browsers

2017-08-07 Thread Milian Wolff
On Montag, 7. August 2017 17:07:10 CEST Arnaldo Carvalho de Melo wrote: > Em Sun, Aug 06, 2017 at 11:24:33PM +0200, Milian Wolff escreveu: > > The follow-up commits will make inline frames first-class citizens > > in the callchain, thereby obsoleting all of this special co

[PATCH v2 00/14] generate full callchain cursor entries for inlined frames

2017-08-06 Thread Milian Wolff
ction and srcline is shown, as well as the (inlined) suffix only the basename of the srcline is shown v2 fixes some issues reported by Namhyung or found by me in further testing, adds caching and enables inline frames by default. Milian Wolff (14): perf report: remove code to handle inline frames

[PATCH v2 00/14] generate full callchain cursor entries for inlined frames

2017-08-06 Thread Milian Wolff
2 fixes some issues reported by Namhyung or found by me in further testing, adds caching and enables inline frames by default. Milian Wolff (14): perf report: remove code to handle inline frames from browsers perf util: take elf_name as const string in dso__demangle_sym perf report: create real callch

[PATCH v2 02/14] perf util: take elf_name as const string in dso__demangle_sym

2017-08-06 Thread Milian Wolff
...@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/symbol-elf.c | 2 +- tools/perf/util/symbol-minimal.c | 2 +- tools/perf/util/symbol.h | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/symbol-

[PATCH v2 02/14] perf util: take elf_name as const string in dso__demangle_sym

2017-08-06 Thread Milian Wolff
The input string is not modified and thus can be passed in as a pointer to const data. Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yao Jin Signed-off-by: Milian Wolff --- tools/perf/util/symbol-elf.c | 2 +- tools/perf/util/symbol-minimal.c | 2

[PATCH v2 06/14] perf script: mark inlined frames and do not print DSO for them

2017-08-06 Thread Milian Wolff
c: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/evsel_fprintf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git

[PATCH v2 06/14] perf script: mark inlined frames and do not print DSO for them

2017-08-06 Thread Milian Wolff
Signed-off-by: Milian Wolff --- tools/perf/util/evsel_fprintf.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/tools/perf/util/evsel_fprintf.c b/tools/perf/util/evsel_fprintf.c index f2c6c5ee11e8..5b9e89257aa7 100644 --- a/tools/perf/util/evsel_fprintf.c +++ b/tools

[PATCH v2 07/14] perf report: compare symbol name for inlined frames when matching

2017-08-06 Thread Milian Wolff
std::abs (inlined) std::__complex_abs (inlined) ~ Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com&

[PATCH v2 04/14] perf report: fall-back to function name comparison for -g srcline

2017-08-06 Thread Milian Wolff
| | | --0.85%--cabs ~ Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo.

[PATCH v2 07/14] perf report: compare symbol name for inlined frames when matching

2017-08-06 Thread Milian Wolff
Jin Signed-off-by: Milian Wolff --- tools/perf/util/callchain.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c index 5e099fe0b9dc..45a39260a821 100644 --- a/tools/perf/util/callchain.c +++ b/tools/perf/util

[PATCH v2 04/14] perf report: fall-back to function name comparison for -g srcline

2017-08-06 Thread Milian Wolff
| | | --0.85%--cabs ~ Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yao Jin Signed-off-by: Milian Wolff --- tools/perf/util/callchain.c | 20 1 file changed, 12 insertions(+), 8 deletions(-) diff --git a/tools/perf/util/callchain.c b

[PATCH v2 08/14] perf report: compare symbol name for inlined frames when sorting

2017-08-06 Thread Milian Wolff
[.] cabs ~ Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com>

[PATCH v2 08/14] perf report: compare symbol name for inlined frames when sorting

2017-08-06 Thread Milian Wolff
(inlined) 12.29% 0.00% cpp-inlining cpp-inlining [.] std::linear_congruential_engine::operator() (inlined) 0.52% 0.52% cpp-inlining libm-2.25.so [.] cabs ~ Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yao Jin Signed-off-b

[PATCH v2 09/14] perf report: properly handle branch count in match_chain

2017-08-06 Thread Milian Wolff
Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/callchain.c | 115 +++- 1 file changed, 59

[PATCH v2 09/14] perf report: properly handle branch count in match_chain

2017-08-06 Thread Milian Wolff
Signed-off-by: Milian Wolff --- tools/perf/util/callchain.c | 115 +++- 1 file changed, 59 insertions(+), 56 deletions(-) diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c index 45a39260a821..2c85adc1a3e2 100644 --- a/tools/perf/util

[PATCH v2 03/14] perf report: create real callchain entries for inlined frames

2017-08-06 Thread Milian Wolff
transparently display inlined frames without having to patch their code. Cc: Arnaldo Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com&g

[PATCH v2 12/14] perf report: use srcline from callchain for hist entries

2017-08-06 Thread Milian Wolff
o Carvalho de Melo <a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/per

[PATCH v2 11/14] perf report: cache srclines for callchain nodes

2017-08-06 Thread Milian Wolff
l.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/dso.c | 1 + tools/perf/util/dso.h | 1 + tools/perf/util/mac

[PATCH v2 12/14] perf report: use srcline from callchain for hist entries

2017-08-06 Thread Milian Wolff
hypot_finite+163 4.13% 0.00% [.] __hypot_finite __hypot_finite+18446603487892193443 ... ~ Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yao Jin Signed-off-by: Milian Wolff --- t

[PATCH v2 11/14] perf report: cache srclines for callchain nodes

2017-08-06 Thread Milian Wolff
: Yao Jin Signed-off-by: Milian Wolff --- tools/perf/util/dso.c | 1 + tools/perf/util/dso.h | 1 + tools/perf/util/machine.c | 17 +--- tools/perf/util/srcline.c | 66 +++ tools/perf/util/srcline.h | 7 + 5 files changed, 89

[PATCH v2 03/14] perf report: create real callchain entries for inlined frames

2017-08-06 Thread Milian Wolff
transparently display inlined frames without having to patch their code. Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yao Jin Signed-off-by: Milian Wolff --- tools/perf/util/callchain.c | 31 +++- tools/perf/util/callchain.h | 6 +- tools/perf/util

[PATCH v2 13/14] perf util: do not consider empty files as valid srclines

2017-08-06 Thread Milian Wolff
<a...@redhat.com> Cc: David Ahern <dsah...@gmail.com> Cc: Namhyung Kim <namhy...@kernel.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao....@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/srcline.c | 6 +++

[PATCH v2 10/14] perf report: cache failed lookups of inlined frames

2017-08-06 Thread Milian Wolff
.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/machine.c | 15 +++ tools/perf/util/srcline.c | 18 ++ 2 files changed, 9 insertions(+), 24 d

[PATCH v2 14/14] perf util: enable handling of inlined frames by default

2017-08-06 Thread Milian Wolff
.org> Cc: Peter Zijlstra <a.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Cc: Ingo Molnar <mi...@kernel.org> Suggested-by: Ingo Molnar <mi...@kernel.org> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/Documentation/perf-report.txt |

[PATCH v2 13/14] perf util: do not consider empty files as valid srclines

2017-08-06 Thread Milian Wolff
Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yao Jin Signed-off-by: Milian Wolff --- tools/perf/util/srcline.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tools/perf/util/srcline.c b/tools/perf/util/srcline.c index 0c5ee741c515..7bf38b78a1ba 100644 --- a/tools/perf/

[PATCH v2 10/14] perf report: cache failed lookups of inlined frames

2017-08-06 Thread Milian Wolff
#1.66% of all branches ( +- 0.19% ) 0.114222393 seconds time elapsed ( +- 1.19% ) ~ Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yao Jin Signed-off-by: Milian Wolff --- tools

[PATCH v2 14/14] perf util: enable handling of inlined frames by default

2017-08-06 Thread Milian Wolff
Molnar Signed-off-by: Milian Wolff --- tools/perf/Documentation/perf-report.txt | 3 ++- tools/perf/Documentation/perf-script.txt | 3 ++- tools/perf/util/symbol.c | 1 + 3 files changed, 5 insertions(+), 2 deletions(-) diff --git a/tools/perf/Documentation/perf-report.txt b

[PATCH v2 05/14] perf report: mark inlined frames in output by " (inlined)" suffix

2017-08-06 Thread Milian Wolff
hello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/util/callchain.c | 10 +++--- tools/perf/util/sort.c | 3 +++ 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/callchain.c

[PATCH v2 01/14] perf report: remove code to handle inline frames from browsers

2017-08-06 Thread Milian Wolff
.p.zijls...@chello.nl> Cc: Yao Jin <yao@linux.intel.com> Signed-off-by: Milian Wolff <milian.wo...@kdab.com> --- tools/perf/ui/browsers/hists.c | 180 +++- tools/perf/ui/stdio/hist.c | 77 + tools/perf/util/evsel_fprintf.c |

[PATCH v2 05/14] perf report: mark inlined frames in output by " (inlined)" suffix

2017-08-06 Thread Milian Wolff
. This allows us to efficiently lookup the symbol for a given name without first having to append the suffix before the lookup. Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yao Jin Signed-off-by: Milian Wolff --- tools/perf/util/callchain.c | 10

[PATCH v2 01/14] perf report: remove code to handle inline frames from browsers

2017-08-06 Thread Milian Wolff
The follow-up commits will make inline frames first-class citizens in the callchain, thereby obsoleting all of this special code. Cc: Arnaldo Carvalho de Melo Cc: David Ahern Cc: Namhyung Kim Cc: Peter Zijlstra Cc: Yao Jin Signed-off-by: Milian Wolff --- tools/perf/ui/browsers/hists.c

hotspot v1.0.0 available - a GUI for Linux perf

2017-07-06 Thread Milian Wolff
a C++/Qt/KDE guy, so I used the technologies I'm familiar with. Cheers -- Milian Wolff | milian.wo...@kdab.com | Senior Software Engineer KDAB (Deutschland) GmbH KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts smime.p7s Description: S/MIME cryptographic signature

hotspot v1.0.0 available - a GUI for Linux perf

2017-07-06 Thread Milian Wolff
a C++/Qt/KDE guy, so I used the technologies I'm familiar with. Cheers -- Milian Wolff | milian.wo...@kdab.com | Senior Software Engineer KDAB (Deutschland) GmbH KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts smime.p7s Description: S/MIME cryptographic signature

Re: perf report: fix off-by-one for non-activation frames

2017-07-04 Thread Milian Wolff
On Monday, June 19, 2017 8:59:39 PM CEST Arnaldo Carvalho de Melo wrote: > Em Sat, Jun 17, 2017 at 01:13:11PM +0200, Milian Wolff escreveu: > > On Samstag, 17. Juni 2017 10:04:02 CEST Jan Kratochvil wrote: > > > On Sat, 17 Jun 2017 09:56:57 +0200, Namhyung Kim wrote: > &

Re: perf report: fix off-by-one for non-activation frames

2017-07-04 Thread Milian Wolff
On Monday, June 19, 2017 8:59:39 PM CEST Arnaldo Carvalho de Melo wrote: > Em Sat, Jun 17, 2017 at 01:13:11PM +0200, Milian Wolff escreveu: > > On Samstag, 17. Juni 2017 10:04:02 CEST Jan Kratochvil wrote: > > > On Sat, 17 Jun 2017 09:56:57 +0200, Namhyung Kim wrote: > &

Re: [PATCH/RFC 0/4] perf annotate: Add --source-only option and the new source code TUI view

2017-06-28 Thread Milian Wolff
On Wednesday, June 28, 2017 6:27:34 PM CEST Taeung Song wrote: > On 06/28/2017 06:53 PM, Milian Wolff wrote: > > On Wednesday, June 28, 2017 5:18:08 AM CEST Taeung Song wrote: > >> Hi, > >> > >> The --source-only option and new source code TUI view can show >

Re: [PATCH/RFC 0/4] perf annotate: Add --source-only option and the new source code TUI view

2017-06-28 Thread Milian Wolff
On Wednesday, June 28, 2017 6:27:34 PM CEST Taeung Song wrote: > On 06/28/2017 06:53 PM, Milian Wolff wrote: > > On Wednesday, June 28, 2017 5:18:08 AM CEST Taeung Song wrote: > >> Hi, > >> > >> The --source-only option and new source code TUI view can show >

Re: [PATCH/RFC 0/4] perf annotate: Add --source-only option and the new source code TUI view

2017-06-28 Thread Milian Wolff
r inlining. Right now, we only see the self cost that is directly within main, I suspect. For C++ this is usually very misleading, and basically makes the annotate view completely useless for application-level profiling. If a second column would be added with the inclusive cost with the ability

Re: [PATCH/RFC 0/4] perf annotate: Add --source-only option and the new source code TUI view

2017-06-28 Thread Milian Wolff
r inlining. Right now, we only see the self cost that is directly within main, I suspect. For C++ this is usually very misleading, and basically makes the annotate view completely useless for application-level profiling. If a second column would be added with the inclusive cost with the ability

Re: [PATCH/RFC 2/4] perf annotate: Add new source code view to the annotate TUI browser

2017-06-28 Thread Milian Wolff
view. The 't' key support should be a separate patch, I guess. It also does not update the column header (it stays at "Percent"). -- Milian Wolff | milian.wo...@kdab.com | Senior Software Engineer KDAB (Deutschland) GmbH KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts

Re: [PATCH/RFC 2/4] perf annotate: Add new source code view to the annotate TUI browser

2017-06-28 Thread Milian Wolff
view. The 't' key support should be a separate patch, I guess. It also does not update the column header (it stays at "Percent"). -- Milian Wolff | milian.wo...@kdab.com | Senior Software Engineer KDAB (Deutschland) GmbH KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-21 Thread Milian Wolff
On Mittwoch, 21. Juni 2017 14:48:29 CEST Arnaldo Carvalho de Melo wrote: > Em Wed, Jun 21, 2017 at 10:16:56AM +0200, Milian Wolff escreveu: > > On Mittwoch, 21. Juni 2017 03:07:39 CEST Arnaldo Carvalho de Melo wrote: > > > Hi Millian, can I take this as an Acked-by or Tested-b

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-21 Thread Milian Wolff
On Mittwoch, 21. Juni 2017 14:48:29 CEST Arnaldo Carvalho de Melo wrote: > Em Wed, Jun 21, 2017 at 10:16:56AM +0200, Milian Wolff escreveu: > > On Mittwoch, 21. Juni 2017 03:07:39 CEST Arnaldo Carvalho de Melo wrote: > > > Hi Millian, can I take this as an Acked-by or Tested-b

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-21 Thread Milian Wolff
On Mittwoch, 21. Juni 2017 03:07:39 CEST Arnaldo Carvalho de Melo wrote: > Em Thu, Jun 15, 2017 at 10:46:16AM +0200, Milian Wolff escreveu: > > On Tuesday, June 13, 2017 5:55:09 PM CEST Ravi Bangoria wrote: > > Just a quick question: Have you guys applied my recent patch:

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-21 Thread Milian Wolff
On Mittwoch, 21. Juni 2017 03:07:39 CEST Arnaldo Carvalho de Melo wrote: > Em Thu, Jun 15, 2017 at 10:46:16AM +0200, Milian Wolff escreveu: > > On Tuesday, June 13, 2017 5:55:09 PM CEST Ravi Bangoria wrote: > > Just a quick question: Have you guys applied my recent patch:

Re: perf report: fix off-by-one for non-activation frames

2017-06-17 Thread Milian Wolff
with Jan that we should mimick existing tool's behavior. I just fear that it's not trivial to do it with the current code base... -- Milian Wolff | milian.wo...@kdab.com | Senior Software Engineer KDAB (Deutschland) GmbH KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts

Re: perf report: fix off-by-one for non-activation frames

2017-06-17 Thread Milian Wolff
with Jan that we should mimick existing tool's behavior. I just fear that it's not trivial to do it with the current code base... -- Milian Wolff | milian.wo...@kdab.com | Senior Software Engineer KDAB (Deutschland) GmbH KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts

Re: perf report: fix off-by-one for non-activation frames

2017-06-16 Thread Milian Wolff
On Freitag, 16. Juni 2017 13:57:44 CEST Jan Kratochvil wrote: > On Fri, 16 Jun 2017 13:51:37 +0200, Milian Wolff wrote: > > > perf-4.12.0-0.rc5.git0.1.fc27.x86_64 > > > > > > 39e32e gdb_main (/usr/libexec/gdb) > > >

Re: perf report: fix off-by-one for non-activation frames

2017-06-16 Thread Milian Wolff
On Freitag, 16. Juni 2017 13:57:44 CEST Jan Kratochvil wrote: > On Fri, 16 Jun 2017 13:51:37 +0200, Milian Wolff wrote: > > > perf-4.12.0-0.rc5.git0.1.fc27.x86_64 > > > > > > 39e32e gdb_main (/usr/libexec/gdb) > > >

[tip:perf/urgent] perf unwind: Report module before querying isactivation in dwfl unwind

2017-06-16 Thread tip-bot for Milian Wolff
Commit-ID: 9126cbbacecb8917bd0418809ef1d26616b2061e Gitweb: http://git.kernel.org/tip/9126cbbacecb8917bd0418809ef1d26616b2061e Author: Milian Wolff <milian.wo...@kdab.com> AuthorDate: Fri, 2 Jun 2017 16:37:53 +0200 Committer: Arnaldo Carvalho de Melo <a...@redhat.com> CommitD

[tip:perf/urgent] perf unwind: Report module before querying isactivation in dwfl unwind

2017-06-16 Thread tip-bot for Milian Wolff
Commit-ID: 9126cbbacecb8917bd0418809ef1d26616b2061e Gitweb: http://git.kernel.org/tip/9126cbbacecb8917bd0418809ef1d26616b2061e Author: Milian Wolff AuthorDate: Fri, 2 Jun 2017 16:37:53 +0200 Committer: Arnaldo Carvalho de Melo CommitDate: Fri, 16 Jun 2017 14:37:30 -0300 perf unwind

Re: perf report: fix off-by-one for non-activation frames

2017-06-16 Thread Milian Wolff
On Freitag, 16. Juni 2017 08:14:56 CEST Jan Kratochvil wrote: > On Mon, 15 May 2017 17:04:44 +0200, Milian Wolff wrote: > > commit 1982ad48fc82c284a5cc55697a012d3357e84d01 > Author: Milian Wolff <milian.wo...@kdab.com> > Date: Wed May 24 15:21:25 2017 +0900 > > >

Re: perf report: fix off-by-one for non-activation frames

2017-06-16 Thread Milian Wolff
On Freitag, 16. Juni 2017 08:14:56 CEST Jan Kratochvil wrote: > On Mon, 15 May 2017 17:04:44 +0200, Milian Wolff wrote: > > commit 1982ad48fc82c284a5cc55697a012d3357e84d01 > Author: Milian Wolff > Date: Wed May 24 15:21:25 2017 +0900 > > > --- a/tools/perf/util/unwind

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-15 Thread Milian Wolff
zip 16699 6857.354663: 300677 cycles:u: > > zip 16699 6857.354895: 584131 cycles:u: > > zip 16699 6857.355312: 589687 cycles:u: > > zip 16699 6857.355606: 560142 cycles:u: Just a quick question: Have you guys applied my recent patch: commit 5ea0416f51cc9343

Re: [PATCH v2] perf: libdw support for powerpc [ping]

2017-06-15 Thread Milian Wolff
zip 16699 6857.354663: 300677 cycles:u: > > zip 16699 6857.354895: 584131 cycles:u: > > zip 16699 6857.355312: 589687 cycles:u: > > zip 16699 6857.355606: 560142 cycles:u: Just a quick question: Have you guys applied my recent patch: commit 5ea0416f51cc93436b

Re: [PATCH] perf, tools, script: Allow adding and removing fields

2017-06-09 Thread Milian Wolff
On Freitag, 9. Juni 2017 04:52:43 CEST Andi Kleen wrote: > On Thu, Jun 08, 2017 at 02:59:58PM +0200, Milian Wolff wrote: > > But I notice that this functionality is missing in other places too. Most > > notably, I would like to be able to configure `perf stat` in a

Re: [PATCH] perf, tools, script: Allow adding and removing fields

2017-06-09 Thread Milian Wolff
On Freitag, 9. Juni 2017 04:52:43 CEST Andi Kleen wrote: > On Thu, Jun 08, 2017 at 02:59:58PM +0200, Milian Wolff wrote: > > But I notice that this functionality is missing in other places too. Most > > notably, I would like to be able to configure `perf stat` in a

Re: [GIT PULL 0/7] perf/urgent callchain fixes

2017-06-08 Thread Milian Wolff
On Thursday, June 8, 2017 3:59:31 PM CEST Arnaldo Carvalho de Melo wrote: > Em Thu, Jun 08, 2017 at 03:15:32PM +0200, Milian Wolff escreveu: > > On Wednesday, May 24, 2017 8:21:22 AM CEST Namhyung Kim wrote: > > > Hi Ingo, > > > > > > Please consider pulling th

Re: [GIT PULL 0/7] perf/urgent callchain fixes

2017-06-08 Thread Milian Wolff
On Thursday, June 8, 2017 3:59:31 PM CEST Arnaldo Carvalho de Melo wrote: > Em Thu, Jun 08, 2017 at 03:15:32PM +0200, Milian Wolff escreveu: > > On Wednesday, May 24, 2017 8:21:22 AM CEST Namhyung Kim wrote: > > > Hi Ingo, > > > > > > Please consider pulling th

Re: [GIT PULL 0/7] perf/urgent callchain fixes

2017-06-08 Thread Milian Wolff
it later. Hey guys, I notice that these patches are not in acme's perf/core branch. Can they be applied there too please? Thanks -- Milian Wolff | milian.wo...@kdab.com | Software Engineer KDAB (Deutschland) GmbH KG, a KDAB Group company Tel: +49-30-521325470 KDAB - The Qt Experts smime.p7s

<    1   2   3   4   5   6   >