On Dienstag, 16. Mai 2017 16:38:29 CEST Namhyung Kim wrote:
> On Tue, May 16, 2017 at 10:59:51AM +0200, Milian Wolff wrote:
> > As the documentation for dwfl_frame_pc says, frames that
> > are no activation frames need to have their program counter
> > decremented by
On Dienstag, 16. Mai 2017 02:53:32 CEST Namhyung Kim wrote:
> On Mon, May 15, 2017 at 12:01:54PM +0200, Milian Wolff wrote:
> > On Monday, May 15, 2017 3:21:58 AM CEST Namhyung Kim wrote:
> > > Hi Milian,
> > >
> > > On Sun, May 14, 2017 at 08:10:50PM +0200, Mi
On Dienstag, 16. Mai 2017 02:53:32 CEST Namhyung Kim wrote:
> On Mon, May 15, 2017 at 12:01:54PM +0200, Milian Wolff wrote:
> > On Monday, May 15, 2017 3:21:58 AM CEST Namhyung Kim wrote:
> > > Hi Milian,
> > >
> > > On Sun, May 14, 2017 at 08:10:50PM +0200, Mi
On Dienstag, 16. Mai 2017 03:57:53 CEST Namhyung Kim wrote:
> On Mon, May 15, 2017 at 05:13:06PM +0200, Milian Wolff wrote:
> > On Monday, May 15, 2017 5:04:44 PM CEST Milian Wolff wrote:
> > > As the documentation for dwfl_frame_pc says, frames that
> > > are no act
On Dienstag, 16. Mai 2017 03:57:53 CEST Namhyung Kim wrote:
> On Mon, May 15, 2017 at 05:13:06PM +0200, Milian Wolff wrote:
> > On Monday, May 15, 2017 5:04:44 PM CEST Milian Wolff wrote:
> > > As the documentation for dwfl_frame_pc says, frames that
> > > are no act
st frame.
Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/unwind-libdw.c | 6 +-
tools/perf/util/unwind-libunwind-local.c | 14 ++
2 files changed, 19 insertions(+), 1 deletion(-)
v2:
- use unw_is_signal_frame to also fix this issue for libun
On Monday, May 15, 2017 5:04:44 PM CEST Milian Wolff wrote:
> As the documentation for dwfl_frame_pc says, frames that
> are no activation frames need to have their program counter
> decremented by one to properly find the function of the caller.
Note that this leaves the perf buil
On Monday, May 15, 2017 5:04:44 PM CEST Milian Wolff wrote:
> As the documentation for dwfl_frame_pc says, frames that
> are no activation frames need to have their program counter
> decremented by one to properly find the function of the caller.
Note that this leaves the perf buil
chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/unwind-libdw.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/perf/util/unwind-libdw.c b/tools/perf/util/unwind-libdw.c
index f90e11
_libc_start_main
_start
~~~
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/unwind-libdw.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/tools/perf/uti
On Monday, May 15, 2017 3:21:58 AM CEST Namhyung Kim wrote:
> Hi Milian,
>
> On Sun, May 14, 2017 at 08:10:50PM +0200, Milian Wolff wrote:
> > On Freitag, 12. Mai 2017 15:01:29 CEST Namhyung Kim wrote:
> > > On Fri, May 12, 2017 at 12:37:01PM +0200, Milian Wolff wrote:
On Monday, May 15, 2017 3:21:58 AM CEST Namhyung Kim wrote:
> Hi Milian,
>
> On Sun, May 14, 2017 at 08:10:50PM +0200, Milian Wolff wrote:
> > On Freitag, 12. Mai 2017 15:01:29 CEST Namhyung Kim wrote:
> > > On Fri, May 12, 2017 at 12:37:01PM +0200, Milian Wolff wrote:
On Freitag, 12. Mai 2017 15:01:29 CEST Namhyung Kim wrote:
> On Fri, May 12, 2017 at 12:37:01PM +0200, Milian Wolff wrote:
> > On Mittwoch, 10. Mai 2017 07:53:52 CEST Namhyung Kim wrote:
> > > Hi,
> >
> > > On Wed, May 03, 2017 at 11:35:36PM +0200, Milian Wolff
On Freitag, 12. Mai 2017 15:01:29 CEST Namhyung Kim wrote:
> On Fri, May 12, 2017 at 12:37:01PM +0200, Milian Wolff wrote:
> > On Mittwoch, 10. Mai 2017 07:53:52 CEST Namhyung Kim wrote:
> > > Hi,
> >
> > > On Wed, May 03, 2017 at 11:35:36PM +0200, Milian Wolff
On Mittwoch, 10. Mai 2017 07:53:52 CEST Namhyung Kim wrote:
> Hi,
>
> On Wed, May 03, 2017 at 11:35:36PM +0200, Milian Wolff wrote:
> > +static enum match_result match_chain_srcline(struct callchain_cursor_node
> > *node, +
On Mittwoch, 10. Mai 2017 07:53:52 CEST Namhyung Kim wrote:
> Hi,
>
> On Wed, May 03, 2017 at 11:35:36PM +0200, Milian Wolff wrote:
> > +static enum match_result match_chain_srcline(struct callchain_cursor_node
> > *node, +
On Mittwoch, 10. Mai 2017 08:04:23 CEST Namhyung Kim wrote:
> On Tue, May 09, 2017 at 10:50:46PM +0200, Milian Wolff wrote:
> > diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
> > index 9ab68682c6d0..295f0846fd84 100644
> > --- a/tools/perf/util/
On Mittwoch, 10. Mai 2017 08:04:23 CEST Namhyung Kim wrote:
> On Tue, May 09, 2017 at 10:50:46PM +0200, Milian Wolff wrote:
> > diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
> > index 9ab68682c6d0..295f0846fd84 100644
> > --- a/tools/perf/util/
hello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/util/callchain.c | 23 ---
1 file changed, 16 insertions(+), 7 deletions(-)
diff --git a/tools/perf/util/callchain.c b/tools/perf/util/callchain.c
ind
: run_builtin (perf.c:296)
==8359== Address 0x70 is not stack'd, malloc'd or (recently) free'd
This patch fixes the issue.
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/callchain.c | 23
On Mittwoch, 3. Mai 2017 23:35:36 CEST Milian Wolff wrote:
> When different functions get inlined into the same function, we
> want to show them individually in the reports. But when we group by
> function, we would aggregate all IPs and would only keep the first
> one in that function
On Mittwoch, 3. Mai 2017 23:35:36 CEST Milian Wolff wrote:
> When different functions get inlined into the same function, we
> want to show them individually in the reports. But when we group by
> function, we would aggregate all IPs and would only keep the first
> one in that function
On Thursday, May 4, 2017 3:12:50 PM CEST Arnaldo Carvalho de Melo wrote:
> Em Thu, May 04, 2017 at 11:01:48AM +0200, Milian Wolff escreveu:
> > On Thursday, May 4, 2017 4:58:15 PM CEST Jin Yao wrote:
> > > This patch adds the titles "Percent", "
On Thursday, May 4, 2017 3:12:50 PM CEST Arnaldo Carvalho de Melo wrote:
> Em Thu, May 04, 2017 at 11:01:48AM +0200, Milian Wolff escreveu:
> > On Thursday, May 4, 2017 4:58:15 PM CEST Jin Yao wrote:
> > > This patch adds the titles "Percent", "
tually is. I guess
it's a sample percentage? Maybe a header should be added that explains these
values to newbies. I bet many people won't even know what IPC is either.
Cheers
--
Milian Wolff | milian.wo...@kdab.com | Software Engineer
KDAB (Deutschland) GmbH KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
tually is. I guess
it's a sample percentage? Maybe a header should be added that explains these
values to newbies. I bet many people won't even know what IPC is either.
Cheers
--
Milian Wolff | milian.wo...@kdab.com | Software Engineer
KDAB (Deutschland) GmbH KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
m.order == ORDER_CALLEE) {
> be[i] = branch->entries[i];
> +
> + if (chain == NULL)
> + continue;
> +
> /*
>* Check for overlap into the call
be[i] = branch->entries[i];
> +
> + if (chain == NULL)
> + continue;
> +
> /*
>* Check for overlap into the callchain.
>* The return address is one off compared to
> @@ -1998,6 +2005,10 @@ static int thread__resolve_callchain_sample(struct
> thread *thread, if (err)
> return err;
> }
> +
> + if (chain_nr == 0)
> + return 0;
> +
> chain_nr -= nr;
> }
--
Milian Wolff | milian.wo...@kdab.com | Software Engineer
KDAB (Deutschland) GmbH KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
an equal first inline frame "main (inline)".
Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed
hey share an equal first inline frame "main (inline)".
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
v2:
- compare the full stack of inlined frames to distinguish different branches
in top-down call-
80%--main
The problem here is that all samples in main start with the same inlined
frame, the "main (inline)" one. Even if that wouldn't be there, we'd still get
wrong results if we inline a function A which in turns has two other functions
B and C inlined. we need to split the grap
n (inline)" one. Even if that wouldn't be there, we'd still get
wrong results if we inline a function A which in turns has two other functions
B and C inlined. we need to split the graph for that situation too, but we
don't so far...
I'll try t find the time to improve this situation, thanks for the early
review already Jin!
Cheers
--
Milian Wolff | milian.wo...@kdab.com | Software Engineer
KDAB (Deutschland) GmbH KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
_start
...
~
Cc: Arnaldo Carvalho de Melo <a...@redhat.com>
Cc: David Ahern <dsah...@gmail.com>
Cc: Namhyung Kim <namhy...@kernel.org>
Cc: Peter Zijlstra <a.p.zijls...@chello.nl>
Cc: Yao Jin <yao@linux.intel.com>
Signed-off-by: Milian W
art_main
_start
...
~
Cc: Arnaldo Carvalho de Melo
Cc: David Ahern
Cc: Namhyung Kim
Cc: Peter Zijlstra
Cc: Yao Jin
Signed-off-by: Milian Wolff
---
tools/perf/util/callchain.c | 71 +
1 file changed, 59 insertions(+), 12 deleti
Commit-ID: 5dfa210e407d0fedf746958bff206995bd46570d
Gitweb: http://git.kernel.org/tip/5dfa210e407d0fedf746958bff206995bd46570d
Author: Milian Wolff <milian.wo...@kdab.com>
AuthorDate: Sat, 18 Mar 2017 22:49:28 +0100
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
Com
Commit-ID: 5dfa210e407d0fedf746958bff206995bd46570d
Gitweb: http://git.kernel.org/tip/5dfa210e407d0fedf746958bff206995bd46570d
Author: Milian Wolff
AuthorDate: Sat, 18 Mar 2017 22:49:28 +0100
Committer: Arnaldo Carvalho de Melo
CommitDate: Mon, 27 Mar 2017 12:13:28 -0300
perf report
)
| /usr/include/c++/6.3.1/bits/random.h:185
(inline)
...
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/Documentation/perf-report.txt | 1 +
tools/perf/ui/browsers/hists.c | 3 +-
tools/perf/ui/stdio/hist.c | 3 +-
tools/per
)
| /usr/include/c++/6.3.1/bits/random.h:185
(inline)
...
Signed-off-by: Milian Wolff
---
tools/perf/Documentation/perf-report.txt | 1 +
tools/perf/ui/browsers/hists.c | 3 +-
tools/perf/ui/stdio/hist.c | 3 +-
tools/perf/util/annotate.c
t, again: I think these are minor issues, and the feature itself is already
extremely useful and I hope to see it finally merged.
Thanks again Jin for your good work!
Cheers
--
Milian Wolff | milian.wo...@kdab.com | Software Engineer
KDAB (Deutschland) GmbH KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
smime.p7s
Description: S/MIME cryptographic signature
in" instead of
std::norm". When the inline stack is shown below we actually see what happens,
i.e. we eventually end up in main again, but of course this output is not the
best as-is.
But, again: I think these are minor issues, and the feature itself is already
extremely useful and I
line but not a symbol name.
Again, why don't you align this with the other non-inlined frames, and honor
the grouping setting? Check whether we group by address (then display file/
line), or by function (then display the function name).
Bye
--
Milian Wolff | milian.wo...@kdab.com | Software Engi
line but not a symbol name.
Again, why don't you align this with the other non-inlined frames, and honor
the grouping setting? Check whether we group by address (then display file/
line), or by function (then display the function name).
Bye
--
Milian Wolff | milian.wo...@kdab.com | Software Engi
l feature and I
would like to see it integrated upstream. From my POV, you can add
Tested-by: Milian Wolff <milian.wo...@kdab.com>
to all patches in this series.
Many thanks!
--
Milian Wolff | milian.wo...@kdab.com | Software Engineer
KDAB (Deutschland) GmbH KG, a KDAB Group company
Tel: +
l feature and I
would like to see it integrated upstream. From my POV, you can add
Tested-by: Milian Wolff
to all patches in this series.
Many thanks!
--
Milian Wolff | milian.wo...@kdab.com | Software Engineer
KDAB (Deutschland) GmbH KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Q
k frames at
all? Can you try `perf record --call-graph dwarf` instead? Of course, make
sure you compile your code with `-g -O2` or similar.
--
Milian Wolff | milian.wo...@kdab.com | Software Engineer
KDAB (Deutschland) GmbH KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
s
k frames at
all? Can you try `perf record --call-graph dwarf` instead? Of course, make
sure you compile your code with `-g -O2` or similar.
--
Milian Wolff | milian.wo...@kdab.com | Software Engineer
KDAB (Deutschland) GmbH KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
s
On Tuesday, December 20, 2016 2:43:41 PM CET Steinar H. Gunderson wrote:
> On Tue, Dec 20, 2016 at 02:27:10PM +0100, Milian Wolff wrote:
> > It is not even possible with that, perf report is lacking the steps
> > required to add inline frames - it will only add "real"
On Tuesday, December 20, 2016 2:43:41 PM CET Steinar H. Gunderson wrote:
> On Tue, Dec 20, 2016 at 02:27:10PM +0100, Milian Wolff wrote:
> > It is not even possible with that, perf report is lacking the steps
> > required to add inline frames - it will only add "real"
On Tuesday, December 20, 2016 10:54:50 AM CET Arnaldo Carvalho de Melo wrote:
> Em Tue, Dec 20, 2016 at 02:27:10PM +0100, Milian Wolff escreveu:
> > On Tuesday, December 20, 2016 1:17:55 PM CET Peter Zijlstra wrote:
> > > On Tue, Dec 20, 2016 at 12:59:54PM +0100, Steinar
On Tuesday, December 20, 2016 10:54:50 AM CET Arnaldo Carvalho de Melo wrote:
> Em Tue, Dec 20, 2016 at 02:27:10PM +0100, Milian Wolff escreveu:
> > On Tuesday, December 20, 2016 1:17:55 PM CET Peter Zijlstra wrote:
> > > On Tue, Dec 20, 2016 at 12:59:54PM +0100, Steinar
ds to be compiled with
> frame pointers enabled and inlined functions, as you noticed, are
> 'lost'.
>
> There has been talk to attempt to utilize the ELF EH frames which are
> mandatory in the x86_64 ABI (even for C) to attempt a kernel based
> 'DWARF' unwind, but nobody has put f
ds to be compiled with
> frame pointers enabled and inlined functions, as you noticed, are
> 'lost'.
>
> There has been talk to attempt to utilize the ELF EH frames which are
> mandatory in the x86_64 ABI (even for C) to attempt a kernel based
> 'DWARF' unwind, but nobody has put f
|
|--1--read
|
|--1--init_tls
|
|--1--brk
Signed-off-by: Milian Wolff <milian.wo...@kdab.com>
---
tools/perf/Documentation/perf-inject.txt | 5 +
tools/perf/builtin-inject.c | 157 +--
2
|
|--1--read
|
|--1--init_tls
|
|--1--brk
Signed-off-by: Milian Wolff
---
tools/perf/Documentation/perf-inject.txt | 5 +
tools/perf/builtin-inject.c | 157 +--
2 files changed, 134 insertions
Commit-ID: 6186de9a491af030889b372193fc9f38c248e69a
Gitweb: http://git.kernel.org/tip/6186de9a491af030889b372193fc9f38c248e69a
Author: Milian Wolff <milian.wo...@kdab.com>
AuthorDate: Mon, 11 Apr 2016 10:18:11 -0300
Committer: Arnaldo Carvalho de Melo <a...@redhat.com>
Com
Commit-ID: 6186de9a491af030889b372193fc9f38c248e69a
Gitweb: http://git.kernel.org/tip/6186de9a491af030889b372193fc9f38c248e69a
Author: Milian Wolff
AuthorDate: Mon, 11 Apr 2016 10:18:11 -0300
Committer: Arnaldo Carvalho de Melo
CommitDate: Mon, 11 Apr 2016 22:18:14 -0300
perf evsel
On Freitag, 8. April 2016 15:18:53 CEST Arnaldo Carvalho de Melo wrote:
> Em Fri, Apr 08, 2016 at 02:57:54PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Fri, Apr 08, 2016 at 01:34:15PM +0200, Milian Wolff escreveu:
> > > Now, one can print the call chain for every en
On Freitag, 8. April 2016 15:18:53 CEST Arnaldo Carvalho de Melo wrote:
> Em Fri, Apr 08, 2016 at 02:57:54PM -0300, Arnaldo Carvalho de Melo escreveu:
> > Em Fri, Apr 08, 2016 at 01:34:15PM +0200, Milian Wolff escreveu:
> > > Now, one can print the call chain for every en
one?
> nope, nothing yet
I'll send a working solution based on Jiri's fix later when I'm back home. In
the meantime, please have a look at my other patch regarding `perf inject`
merging of trace events for sys_enter/exit.
Thanks
--
Milian Wolff | milian.wo...@kdab.com | Software Engineer
nothing yet
I'll send a working solution based on Jiri's fix later when I'm back home. In
the meantime, please have a look at my other patch regarding `perf inject`
merging of trace events for sys_enter/exit.
Thanks
--
Milian Wolff | milian.wo...@kdab.com | Software Engineer
KDAB (Deutschland) GmbH KG,
tting it fixed for libdw. Much appreciated!
Cheers
--
Milian Wolff | milian.wo...@kdab.com | Software Engineer
KDAB (Deutschland) GmbH KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
smime.p7s
Description: S/MIME cryptographic signature
tting it fixed for libdw. Much appreciated!
Cheers
--
Milian Wolff | milian.wo...@kdab.com | Software Engineer
KDAB (Deutschland) GmbH KG, a KDAB Group company
Tel: +49-30-521325470
KDAB - The Qt Experts
smime.p7s
Description: S/MIME cryptographic signature
On Monday, August 17, 2015 10:47:50 AM CEST Arnaldo Carvalho de Melo wrote:
> Em Thu, Aug 13, 2015 at 10:53:36AM +0200, Milian Wolff escreveu:
> > On Thursday, August 13, 2015 09:17:24 AM Jiri Olsa wrote:
> > > right you are.. does attached patch help?
> >
On Monday, August 17, 2015 10:47:50 AM CEST Arnaldo Carvalho de Melo wrote:
Em Thu, Aug 13, 2015 at 10:53:36AM +0200, Milian Wolff escreveu:
On Thursday, August 13, 2015 09:17:24 AM Jiri Olsa wrote:
right you are.. does attached patch help?
snip
Hey Jiri,
it works a treat
On Thursday, August 13, 2015 09:17:24 AM Jiri Olsa wrote:
> On Wed, Jul 22, 2015 at 08:48:40PM +0200, Milian Wolff wrote:
> > Hey all,
> >
> > I recorded a perf data file using
> >
> > perf record --call-graph dwarf kwrite
> >
> > when I report i
On Thursday, August 13, 2015 09:17:24 AM Jiri Olsa wrote:
On Wed, Jul 22, 2015 at 08:48:40PM +0200, Milian Wolff wrote:
Hey all,
I recorded a perf data file using
perf record --call-graph dwarf kwrite some large file
when I report it I see backtraces pointing to the user space
Commit-ID: 007d66a0bd43d886eb3e4aceaf1a96b8743ccaff
Gitweb: http://git.kernel.org/tip/007d66a0bd43d886eb3e4aceaf1a96b8743ccaff
Author: Milian Wolff
AuthorDate: Wed, 5 Aug 2015 16:52:23 -0300
Committer: Arnaldo Carvalho de Melo
CommitDate: Wed, 5 Aug 2015 16:52:23 -0300
perf trace
Commit-ID: 007d66a0bd43d886eb3e4aceaf1a96b8743ccaff
Gitweb: http://git.kernel.org/tip/007d66a0bd43d886eb3e4aceaf1a96b8743ccaff
Author: Milian Wolff milian.wo...@kdab.com
AuthorDate: Wed, 5 Aug 2015 16:52:23 -0300
Committer: Arnaldo Carvalho de Melo a...@redhat.com
CommitDate: Wed, 5 Aug
for better performance when parsing perf's data
> > files and a complete access to the raw data.
>
> You'll at least need some documentation how to use it.
Ping, any news on this feature? I'd welcome the ability to create native
scripts to write efficient tools based on perf.
By
performance when parsing perf's data
files and a complete access to the raw data.
You'll at least need some documentation how to use it.
Ping, any news on this feature? I'd welcome the ability to create native
scripts to write efficient tools based on perf.
Bye
--
Milian Wolff
m...@milianw.de
501 - 571 of 571 matches
Mail list logo
