Re: [PATCHv3 1/1] kernel/power/autosleep.c: check for pm_suspend() return before queueing suspend again

2015-07-22 Thread Nitish Ambastha
. I might be wrong, but this is how I understand it. Regards Nitish Ambastha On Thu, Jul 16, 2015 at 3:59 AM, Rafael J. Wysocki wrote: > On Tuesday, July 14, 2015 09:34:08 AM Nitish Ambastha wrote: >> On Tue, Jul 14, 2015 at 5:13 AM, Rafael J. Wysocki >> wrote: >> > O

Re: [PATCHv3 1/1] kernel/power/autosleep.c: check for pm_suspend() return before queueing suspend again

2015-07-22 Thread Nitish Ambastha
. I might be wrong, but this is how I understand it. Regards Nitish Ambastha On Thu, Jul 16, 2015 at 3:59 AM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Tuesday, July 14, 2015 09:34:08 AM Nitish Ambastha wrote: On Tue, Jul 14, 2015 at 5:13 AM, Rafael J. Wysocki r...@rjwysocki.net wrote

Re: [PATCHv3 1/1] kernel/power/autosleep.c: check for pm_suspend() return before queueing suspend again

2015-07-13 Thread Nitish Ambastha
On Tue, Jul 14, 2015 at 5:13 AM, Rafael J. Wysocki wrote: > On Tuesday, July 14, 2015 01:38:02 AM Nitish Ambastha wrote: >> Prevent tight loop for suspend-resume when some >> devices failed to suspend > > This *still* doesn't explain what problem you're *really* trying

Re: [PATCHv3 1/1] kernel/power/autosleep.c: check for pm_suspend() return before queueing suspend again

2015-07-13 Thread Nitish Ambastha
if this is reasonable? On Tue, Jul 14, 2015 at 1:38 AM, Nitish Ambastha wrote: > Prevent tight loop for suspend-resume when some > devices failed to suspend > If some devices failed to suspend, we monitor this > error in try_to_suspend(). pm_suspend() is already > an 'int' returning func

[PATCHv3 1/1] kernel/power/autosleep.c: check for pm_suspend() return before queueing suspend again

2015-07-13 Thread Nitish Ambastha
do not register for pending events, this will prevent tight loop for suspend-resume in suspend abort scenarios due to device suspend failures Signed-off-by: Nitish Ambastha --- v2: Rearranged code to make wait entry shared with existing one as suggested by Pavel Machek Corrected log

Re: [PATCHv3 1/1] kernel/power/autosleep.c: check for pm_suspend() return before queueing suspend again

2015-07-13 Thread Nitish Ambastha
On Tue, Jul 14, 2015 at 5:13 AM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Tuesday, July 14, 2015 01:38:02 AM Nitish Ambastha wrote: Prevent tight loop for suspend-resume when some devices failed to suspend This *still* doesn't explain what problem you're *really* trying to address

[PATCHv3 1/1] kernel/power/autosleep.c: check for pm_suspend() return before queueing suspend again

2015-07-13 Thread Nitish Ambastha
do not register for pending events, this will prevent tight loop for suspend-resume in suspend abort scenarios due to device suspend failures Signed-off-by: Nitish Ambastha nitis...@samsung.com --- v2: Rearranged code to make wait entry shared with existing one as suggested by Pavel Machek pa

Re: [PATCHv3 1/1] kernel/power/autosleep.c: check for pm_suspend() return before queueing suspend again

2015-07-13 Thread Nitish Ambastha
if this is reasonable? On Tue, Jul 14, 2015 at 1:38 AM, Nitish Ambastha nitis...@samsung.com wrote: Prevent tight loop for suspend-resume when some devices failed to suspend If some devices failed to suspend, we monitor this error in try_to_suspend(). pm_suspend() is already an 'int' returning function

Re: [PATCHv2 1/1] kernel/power/autosleep.c: check for pm_suspend() return before queueing suspend again

2015-07-05 Thread Nitish Ambastha
On Wed, Jul 1, 2015 at 1:31 AM, Rafael J. Wysocki wrote: > > On Wednesday, July 01, 2015 12:52:43 AM Nitish Ambastha wrote: > > Hi Rafael > > > > Thanks for your feedback > > > > On Tue, Jun 30, 2015 at 1:37 AM, Rafael J. Wysocki > > wrote: > >

Re: [PATCHv2 1/1] kernel/power/autosleep.c: check for pm_suspend() return before queueing suspend again

2015-07-05 Thread Nitish Ambastha
On Wed, Jul 1, 2015 at 1:31 AM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Wednesday, July 01, 2015 12:52:43 AM Nitish Ambastha wrote: Hi Rafael Thanks for your feedback On Tue, Jun 30, 2015 at 1:37 AM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Monday, June 29, 2015 09

Re: [PATCHv2 1/1] kernel/power/autosleep.c: check for pm_suspend() return before queueing suspend again

2015-06-30 Thread Nitish Ambastha
Hi Rafael Thanks for your feedback On Tue, Jun 30, 2015 at 1:37 AM, Rafael J. Wysocki wrote: > On Monday, June 29, 2015 09:56:18 PM Rafael J. Wysocki wrote: >> On Tuesday, June 30, 2015 12:24:14 AM Nitish Ambastha wrote: >> > Prevent tight loop for suspend-resume when some &

Re: [PATCHv2 1/1] kernel/power/autosleep.c: check for pm_suspend() return before queueing suspend again

2015-06-30 Thread Nitish Ambastha
Hi Rafael Thanks for your feedback On Tue, Jun 30, 2015 at 1:37 AM, Rafael J. Wysocki r...@rjwysocki.net wrote: On Monday, June 29, 2015 09:56:18 PM Rafael J. Wysocki wrote: On Tuesday, June 30, 2015 12:24:14 AM Nitish Ambastha wrote: Prevent tight loop for suspend-resume when some devices

[PATCHv2 1/1] kernel/power/autosleep.c: check for pm_suspend() return before queueing suspend again

2015-06-29 Thread Nitish Ambastha
do not register for pending events, this will prevent tight loop for suspend-resume in suspend abort scenarios due to device suspend failures Signed-off-by: Nitish Ambastha --- v2: Rearranged code to make wait entry shared with existing one as suggested by Pavel Machek Corrected log

[PATCH 1/1] kernel/power/autosleep.c: check for pm_suspend() return before queueing suspend again

2015-06-29 Thread Nitish Ambastha
do not register for pending events, this will prevent tight loop for suspend-resume in suspend abort scenarios due to device suspend failures Signed-off-by: Nitish Ambastha --- kernel/power/autosleep.c | 13 - 1 file changed, 12 insertions(+), 1 deletion(-) diff --git a/kernel

[PATCHv2 1/1] kernel/power/autosleep.c: check for pm_suspend() return before queueing suspend again

2015-06-29 Thread Nitish Ambastha
do not register for pending events, this will prevent tight loop for suspend-resume in suspend abort scenarios due to device suspend failures Signed-off-by: Nitish Ambastha nitis...@samsung.com --- v2: Rearranged code to make wait entry shared with existing one as suggested by Pavel Machek pa

[PATCH 1/1] kernel/power/autosleep.c: check for pm_suspend() return before queueing suspend again

2015-06-29 Thread Nitish Ambastha
do not register for pending events, this will prevent tight loop for suspend-resume in suspend abort scenarios due to device suspend failures Signed-off-by: Nitish Ambastha nitis...@samsung.com --- kernel/power/autosleep.c | 13 - 1 file changed, 12 insertions(+), 1 deletion