RE: [PATCH V2] MAINTAINERS: Add Dialog PMIC search terms for missing documentation and header files

On 08 June 2016 15:19, Mark Brown wrote: > Subject: Re: [PATCH V2] MAINTAINERS: Add Dialog PMIC search terms for > missing documentation and header files > > On Tue, May 24, 2016 at 08:53:46AM +0100, Steve Twiss wrote: > > > The majority of these updates are for MFD documentation and headers, >

RE: [PATCH V2] MAINTAINERS: Add Dialog PMIC search terms for missing documentation and header files

On 08 June 2016 15:19, Mark Brown wrote: > Subject: Re: [PATCH V2] MAINTAINERS: Add Dialog PMIC search terms for > missing documentation and header files > > On Tue, May 24, 2016 at 08:53:46AM +0100, Steve Twiss wrote: > > > The majority of these updates are for MFD documentation and headers, >

RE: [PATCH V1] MAINTAINERS: Add Dialog PMIC search terms for missing documentation and header files

Hi Mark, I'm probably too quick with this e-mail, but just in case I needed to put you in the TO: field to begin with, or I need to modify & re-send? On 11 May 2016 14:19, Lee Jones wrote: > Subject: Re: [PATCH V1] MAINTAINERS: Add Dialog PMIC search terms for > missing documentation and header

RE: [PATCH V1] MAINTAINERS: Add Dialog PMIC search terms for missing documentation and header files

Hi Mark, I'm probably too quick with this e-mail, but just in case I needed to put you in the TO: field to begin with, or I need to modify & re-send? On 11 May 2016 14:19, Lee Jones wrote: > Subject: Re: [PATCH V1] MAINTAINERS: Add Dialog PMIC search terms for > missing documentation and header

RE: [NEW DRIVER V6 0/7] DA9058 PMIC - please comment on this new driver

> On 23 March 2016, Alexandre Belloni wrote: > > Subject: Re: [NEW DRIVER V6 0/7] DA9058 PMIC - please comment on this new > > driver > > > > Hi Anthony, Steve, > > > > This driver has been submitted a while ago and reached v6 but still had > > a few comments. Do you still have some interest in

RE: [NEW DRIVER V6 0/7] DA9058 PMIC - please comment on this new driver

> On 23 March 2016, Alexandre Belloni wrote: > > Subject: Re: [NEW DRIVER V6 0/7] DA9058 PMIC - please comment on this new > > driver > > > > Hi Anthony, Steve, > > > > This driver has been submitted a while ago and reached v6 but still had > > a few comments. Do you still have some interest in

RE: [NEW DRIVER V6 0/7] DA9058 PMIC - please comment on this new driver

On 23 March 2016, Alexandre Belloni wrote: > To: Opensource [Anthony Olech]; Opensource [Steve Twiss] > Subject: Re: [NEW DRIVER V6 0/7] DA9058 PMIC - please comment on this new > driver > > Hi Anthony, Steve, > > This driver has been submitted a while ago and reached v6

RE: [NEW DRIVER V6 0/7] DA9058 PMIC - please comment on this new driver

On 23 March 2016, Alexandre Belloni wrote: > To: Opensource [Anthony Olech]; Opensource [Steve Twiss] > Subject: Re: [NEW DRIVER V6 0/7] DA9058 PMIC - please comment on this new > driver > > Hi Anthony, Steve, > > This driver has been submitted a while ago and reached v6

RE: [PATCH] mfd: da9063: remove unused array mask_events_buf

On 20 March 2016 18:54 Colin King wrote: > Subject: [PATCH] mfd: da9063: remove unused array mask_events_buf > From: Colin Ian King > > mask_events_buf is not used, so remove this redundant array. > > Signed-off-by: Colin Ian King > --- >

RE: [PATCH] mfd: da9063: remove unused array mask_events_buf

On 20 March 2016 18:54 Colin King wrote: > Subject: [PATCH] mfd: da9063: remove unused array mask_events_buf > From: Colin Ian King > > mask_events_buf is not used, so remove this redundant array. > > Signed-off-by: Colin Ian King > --- > drivers/mfd/da9063-irq.c | 2 -- > 1 file changed, 2

RE: [PATCH V1] mfd: da9062: fix missing volatile registers in the core regmap_range volatile lists

On 10 February 2016 16:56, Lee Jones wrote: > To: Opensource [Steve Twiss] > Cc: LINUXKERNEL; David Dajun Chen; Support Opensource > Subject: Re: [PATCH V1] mfd: da9062: fix missing volatile registers in the > core > regmap_range volatile lists > > On Mon, 01 Feb 20

RE: [PATCH V1] mfd: da9062: fix missing volatile registers in the core regmap_range volatile lists

On 10 February 2016 16:56, Lee Jones wrote: > To: Opensource [Steve Twiss] > Cc: LINUXKERNEL; David Dajun Chen; Support Opensource > Subject: Re: [PATCH V1] mfd: da9062: fix missing volatile registers in the > core > regmap_range volatile lists > > On Mon, 01 Feb 20

RE: [PATCH] mfd: da9063: Allow modular build

On 08 December 2015 13:56, Lee Jones wrote: > To: Geert Uytterhoeven > Subject: Re: [PATCH] mfd: da9063: Allow modular build > > On Mon, 07 Dec 2015, Geert Uytterhoeven wrote: > > > Allow support for the DA9063 PMIC to be modular, cfr. DA9062, which > > allows to decrease size of multi-platform

RE: [PATCH V1] rtc: da9063: access ordering error during RTC interrupt system power on

On 16 December 2015 23:47 Alexandre Belloni wrote: > Subject: Re: [PATCH V1] rtc: da9063: access ordering error during RTC > interrupt system power on > > This seems mostly fine, however ... Hi Alexandre, Thanks for reviewing this. > On 08/12/2015 at 16:28:39 +, Steve Twiss wrote : > >

RE: [PATCH] mfd: da9063: Allow modular build

On 08 December 2015 13:56, Lee Jones wrote: > To: Geert Uytterhoeven > Subject: Re: [PATCH] mfd: da9063: Allow modular build > > On Mon, 07 Dec 2015, Geert Uytterhoeven wrote: > > > Allow support for the DA9063 PMIC to be modular, cfr. DA9062, which > > allows to decrease size of multi-platform

RE: [PATCH V1] rtc: da9063: access ordering error during RTC interrupt system power on

On 16 December 2015 23:47 Alexandre Belloni wrote: > Subject: Re: [PATCH V1] rtc: da9063: access ordering error during RTC > interrupt system power on > > This seems mostly fine, however ... Hi Alexandre, Thanks for reviewing this. > On 08/12/2015 at 16:28:39 +, Steve Twiss wrote : > >

RE: [PATCH V2] input: da9063: report KEY_POWER instead of KEY_SLEEP during power key-press

Regarding: > To: Dmitry Torokhov; LINUX-INPUT; LINUXKERNEL > Subject: [PATCH V2] input: da9063: report KEY_POWER instead of KEY_SLEEP > during power key-press Hi Dmitry, Thanks for your Signed-off-by and merge. Regards, Steve repo linux-next tag next-20151214 commit

RE: [PATCH V2] input: da9063: report KEY_POWER instead of KEY_SLEEP during power key-press

Regarding: > To: Dmitry Torokhov; LINUX-INPUT; LINUXKERNEL > Subject: [PATCH V2] input: da9063: report KEY_POWER instead of KEY_SLEEP > during power key-press Hi Dmitry, Thanks for your Signed-off-by and merge. Regards, Steve repo linux-next tag next-20151214 commit

RE: [PATCH] mfd: da9063: Allow modular build

On 08 December 2015 @ 13:56 Lee Jones wrote: > To: Geert Uytterhoeven > Cc: Support Opensource; Liam Girdwood; Mark Brown; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH] mfd: da9063: Allow modular build > > On Mon, 07 Dec 2015, Geert Uytterhoeven wrote: > > > Allow support for the

RE: [PATCH] mfd: da9063: Allow modular build

On 08 December 2015 @ 13:56 Lee Jones wrote: > To: Geert Uytterhoeven > Cc: Support Opensource; Liam Girdwood; Mark Brown; linux- > ker...@vger.kernel.org > Subject: Re: [PATCH] mfd: da9063: Allow modular build > > On Mon, 07 Dec 2015, Geert Uytterhoeven wrote: > > > Allow support for the

RE: [PATCH V1 1/2] mfd: da9053: Addition of extra registers for GPIOs 8-13

On 13 October 2015 08:32 Lee Jones wrote: > To: Opensource [Steve Twiss] > Cc: LINUXKERNEL; Samuel Ortiz; David Dajun Chen; Support Opensource > Subject: Re: [PATCH V1 1/2] mfd: da9053: Addition of extra registers for > GPIOs 8-13 > > On Thu, 08 Oct 2015, Steve Twiss wrote:

RE: [PATCH V1 1/2] mfd: da9053: Addition of extra registers for GPIOs 8-13

On 13 October 2015 08:32 Lee Jones wrote: > To: Opensource [Steve Twiss] > Cc: LINUXKERNEL; Samuel Ortiz; David Dajun Chen; Support Opensource > Subject: Re: [PATCH V1 1/2] mfd: da9053: Addition of extra registers for > GPIOs 8-13 > > On Thu, 08 Oct 2015, Steve Twiss wrote:

RE: [PATCH V1 0/2] Add DA9021 support to the existing DA9052/53 driver

2:36 Mark Brown wrote: > > > To: Opensource [Steve Twiss] > > Cc: LINUXKERNEL; Lee Jones; Liam Girdwood; Samuel Ortiz; David Dajun > > Chen; Support Opensource > > Subject: Re: [PATCH V1 0/2] Add DA9021 support to the existing DA9052/53 > > driver > > The title o

RE: [PATCH V1 0/2] Add DA9021 support to the existing DA9052/53 driver

2:36 Mark Brown wrote: > > > To: Opensource [Steve Twiss] > > Cc: LINUXKERNEL; Lee Jones; Liam Girdwood; Samuel Ortiz; David Dajun > > Chen; Support Opensource > > Subject: Re: [PATCH V1 0/2] Add DA9021 support to the existing DA9052/53 > > driver > > The title o

RE: [PATCH V1 0/2] Add DA9021 support to the existing DA9052/53 driver

On 09 October 2015 12:36 Mark Brown wrote: > To: Opensource [Steve Twiss] > Cc: LINUXKERNEL; Lee Jones; Liam Girdwood; Samuel Ortiz; David Dajun > Chen; Support Opensource > Subject: Re: [PATCH V1 0/2] Add DA9021 support to the existing DA9052/53 > driver > > On Thu, Oct 0

RE: [PATCH V1 0/2] Add DA9021 support to the existing DA9052/53 driver

On 09 October 2015 12:36 Mark Brown wrote: > To: Opensource [Steve Twiss] > Cc: LINUXKERNEL; Lee Jones; Liam Girdwood; Samuel Ortiz; David Dajun > Chen; Support Opensource > Subject: Re: [PATCH V1 0/2] Add DA9021 support to the existing DA9052/53 > driver > > On Thu, Oct 0

RE: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey

On 30 September 2015 00:54 Dmitry Torokhov wrote: > To: Opensource [Steve Twiss] > Cc: Lee Jones; DEVICETREE; Ian Campbell; Kumar Gala; LINUXINPUT; > LINUXKERNEL; Mark Rutland; Pawel Moll; RTCLINUX; Rob Herring; David > Dajun Chen; Samuel Ortiz; Support Opensource > Subject: Re

RE: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey

On 30 September 2015 00:54 Dmitry Torokhov wrote: > To: Opensource [Steve Twiss] > Cc: Lee Jones; DEVICETREE; Ian Campbell; Kumar Gala; LINUXINPUT; > LINUXKERNEL; Mark Rutland; Pawel Moll; RTCLINUX; Rob Herring; David > Dajun Chen; Samuel Ortiz; Support Opensource > Subject: Re

RE: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey

> Subject: Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for > DA9062 OnKey > > On Mon, Jul 27, 2015 at 03:43:00PM -0700, Dmitry Torokhov wrote: > > On Thu, Jul 23, 2015 at 05:17:41PM +0100, S Twiss wrote: > > > From: S Twiss > > > > > > Add device tree bindings for the

RE: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey

> Subject: Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for > DA9062 OnKey > > On Mon, Jul 27, 2015 at 03:43:00PM -0700, Dmitry Torokhov wrote: > > On Thu, Jul 23, 2015 at 05:17:41PM +0100, S Twiss wrote: > > > From: S Twiss > > > > > > Add

RE: [PATCH V3 2/3] onkey: da9063: Add DA9062 OnKey capability to DA9063 OnKey driver

This is a resend of my previous e-mail sent just a couple of minutes ago -- this one removes the copyright footer that was added by our IT department On 23 July 2015 17:18, Steve Twiss wrote: > Subject: [PATCH V3 2/3] onkey: da9063: Add DA9062 OnKey capability to DA9063 > OnKey driver > >

RE: [PATCH V3 2/3] onkey: da9063: Add DA9062 OnKey capability to DA9063 OnKey driver

This is a resend of my previous e-mail sent just a couple of minutes ago -- this one removes the copyright footer that was added by our IT department On 23 July 2015 17:18, Steve Twiss wrote: > Subject: [PATCH V3 2/3] onkey: da9063: Add DA9062 OnKey capability to DA9063 > OnKey driver > >

RE: [PATCH V3 3/3] rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver

On 05 August 2015 02:55 Alexandre Belloni wrote: > Subject: Re: [PATCH V3 3/3] rtc: da9063: Add DA9062 RTC capability to DA9063 > RTC driver > > On 21/07/2015 at 11:29:07 +0100, S Twiss wrote : > > From: S Twiss > > > > Add DA9062 RTC support into the existing DA9063 RTC driver component by >

RE: [PATCH V3 3/3] rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver

On 05 August 2015 02:55 Alexandre Belloni wrote: Subject: Re: [PATCH V3 3/3] rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver On 21/07/2015 at 11:29:07 +0100, S Twiss wrote : From: S Twiss stwiss.opensou...@diasemi.com Add DA9062 RTC support into the existing DA9063 RTC

RE: [PATCH] Input: da9052_onkey: Convert to managed resources

On 27 July 2015 03:56, Vaishali Thakkar wrote: > Subject: [PATCH] Input: da9052_onkey: Convert to managed resources > > Use managed resource functions devm_input_allocate_device and > devm_kzalloc. To be compatible with the change, replace various > gotos by direct returns and drop unneeded

RE: [PATCH] Input: da9052_onkey: Convert to managed resources

On 27 July 2015 03:56, Vaishali Thakkar wrote: Subject: [PATCH] Input: da9052_onkey: Convert to managed resources Use managed resource functions devm_input_allocate_device and devm_kzalloc. To be compatible with the change, replace various gotos by direct returns and drop unneeded labels.

RE: [PATCH V3 0/3] da9062: Add DA9062 OnKey support using the existing DA9063 OnKey driver

On 28 July 2015 09:52 Lee Jones wrote: > To: Opensource [Steve Twiss] > > Steve, > > Can you sort out your git configuration please. Your name should be > represented in full. No abbreviations or synonyms please. > > I would expect to see: 'Steve Twiss ' Sure, I wil

RE: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey

On 28 July 2015 08:43 Lee Jones wrote: > To: Dmitry Torokhov > Subject: Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for > DA9062 OnKey > > On Mon, 27 Jul 2015, Dmitry Torokhov wrote: > > > On Mon, Jul 27, 2015 at 03:43:00PM -0700, Dmitry Torokhov wrote: > > > On Thu, Jul

RE: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey

On 28 July 2015 06:40, Dmitry Torokhov wrote: > Subject: Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for > DA9062 OnKey > > On Mon, Jul 27, 2015 at 03:43:00PM -0700, Dmitry Torokhov wrote: > > On Thu, Jul 23, 2015 at 05:17:41PM +0100, S Twiss wrote: > > > From: S Twiss > >

RE: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey

On 28 July 2015 08:43 Lee Jones wrote: To: Dmitry Torokhov Subject: Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey On Mon, 27 Jul 2015, Dmitry Torokhov wrote: On Mon, Jul 27, 2015 at 03:43:00PM -0700, Dmitry Torokhov wrote: On Thu, Jul 23, 2015 at

RE: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey

On 28 July 2015 06:40, Dmitry Torokhov wrote: Subject: Re: [PATCH V3 3/3] devicetree: da9062: Add device tree bindings for DA9062 OnKey On Mon, Jul 27, 2015 at 03:43:00PM -0700, Dmitry Torokhov wrote: On Thu, Jul 23, 2015 at 05:17:41PM +0100, S Twiss wrote: From: S Twiss

RE: [PATCH V3 0/3] da9062: Add DA9062 OnKey support using the existing DA9063 OnKey driver

On 28 July 2015 09:52 Lee Jones wrote: To: Opensource [Steve Twiss] Steve, Can you sort out your git configuration please. Your name should be represented in full. No abbreviations or synonyms please. I would expect to see: 'Steve Twiss stwiss.opensou...@diasemi.com' Sure, I will do

RE: [PATCH V2 3/3] rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver

On 21 July 2015 11:02, Alexandre Belloni wrote: Hi Alexandre, Thanks for your help on this I will send patch v3 with the following changes ... > On 21/07/2015 at 10:43:10 +0100, S Twiss wrote : > > - if (val & (DA9063_E_ALARM)) > > + if (val & (config->rtc_event_alarm_mask)) > unneeded

RE: [PATCH RFC V1 2/3] rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver

rce [Steve Twiss] wrote : > > On 18 July 2015 00:45, Alexandre Belloni wrote: [...] > > > > diff --git a/drivers/rtc/rtc-da9063.c b/drivers/rtc/rtc-da9063.c > > > > index 7ffc570..e94fb6d 100644 > > > > --- a/drivers/rtc/rtc-da9063.c > > > >

RE: [PATCH RFC V1 2/3] rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver

Hi Alexandre, Thank you for your quick responses on these patches. I will probably need your further advice on the of_compatible issue with the DA9063 RTC ... I've made some quick replies below. On 20 July 2015 22:51 Alexandre Belloni wrote: On 20/07/2015 at 17:57:50 +, Opensource [Steve

RE: [PATCH V2 3/3] rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver

On 21 July 2015 11:02, Alexandre Belloni wrote: Hi Alexandre, Thanks for your help on this I will send patch v3 with the following changes ... On 21/07/2015 at 10:43:10 +0100, S Twiss wrote : - if (val (DA9063_E_ALARM)) + if (val (config-rtc_event_alarm_mask)) unneeded parenthesis

RE: [PATCH RFC V1 2/3] rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver

On 18 July 2015 00:45, Alexandre Belloni wrote: > On 09/07/2015 at 08:45:53 +0100, S Twiss wrote : > > From: S Twiss > > > > Add DA9062 RTC support into the existing DA9063 RTC driver component by > > using generic access tables for common register and bit mask definitions. > > > > The following

RE: [PATCH RFC V1 3/3] devicetree: da9062: Add device tree bindings for DA9062 RTC

On 18 July 2015 00:48, Alexandre Belloni wrote: > On 09/07/2015 at 08:45:54 +0100, S Twiss wrote : > > From: S Twiss > > > > Add device tree bindings for the DA9062 RTC driver component > > > > Signed-off-by: Steve Twiss [...] > > +- rtc : This node defines settings required for the Real-Time

RE: [PATCH RFC V1 2/3] onkey: da9063: Add DA9062 OnKey capability to DA9063 OnKey driver

On 17 July 2015 23:51, Dmitry Torokhov wrote: > Hi Steve, > On Tue, Jul 14, 2015 at 02:07:50PM +0100, S Twiss wrote: > > From: S Twiss > > Add DA9062 OnKey support into the existing DA9063 OnKey driver component by > > using generic access tables for common register and bit mask definitions. > >

RE: [PATCH RFC V1 2/3] onkey: da9063: Add DA9062 OnKey capability to DA9063 OnKey driver

On 17 July 2015 23:51, Dmitry Torokhov wrote: Hi Steve, On Tue, Jul 14, 2015 at 02:07:50PM +0100, S Twiss wrote: From: S Twiss stwiss.opensou...@diasemi.com Add DA9062 OnKey support into the existing DA9063 OnKey driver component by using generic access tables for common register and bit

RE: [PATCH RFC V1 3/3] devicetree: da9062: Add device tree bindings for DA9062 RTC

On 18 July 2015 00:48, Alexandre Belloni wrote: On 09/07/2015 at 08:45:54 +0100, S Twiss wrote : From: S Twiss stwiss.opensou...@diasemi.com Add device tree bindings for the DA9062 RTC driver component Signed-off-by: Steve Twiss stwiss.opensou...@diasemi.com [...] +- rtc : This

RE: [PATCH RFC V1 2/3] rtc: da9063: Add DA9062 RTC capability to DA9063 RTC driver

On 18 July 2015 00:45, Alexandre Belloni wrote: On 09/07/2015 at 08:45:53 +0100, S Twiss wrote : From: S Twiss stwiss.opensou...@diasemi.com Add DA9062 RTC support into the existing DA9063 RTC driver component by using generic access tables for common register and bit mask definitions.

RE: [PATCH RFC V1 0/3] da9062: Add DA9062 RTC support using the existing DA9063 RTC driver

On 09 July 2015 09:02, Geert Uytterhoeven wrote: > Subject: Re: [PATCH RFC V1 0/3] da9062: Add DA9062 RTC support using the > existing DA9063 RTC driver > > Hi Steve, > > On Thu, Jul 9, 2015 at 9:45 AM, S Twiss > wrote: > > From: S Twiss > > > > This patch set adds RTC support for the Dialog

RE: [PATCH RFC V1 0/3] da9062: Add DA9062 RTC support using the existing DA9063 RTC driver

On 09 July 2015 09:02, Geert Uytterhoeven wrote: Subject: Re: [PATCH RFC V1 0/3] da9062: Add DA9062 RTC support using the existing DA9063 RTC driver Hi Steve, On Thu, Jul 9, 2015 at 9:45 AM, S Twiss stwiss.opensou...@diasemi.com wrote: From: S Twiss stwiss.opensou...@diasemi.com

RE: [PATCH V5 1/2] mfd: da9062: DA9062 MFD core driver

On 07 July 2015 12:42, Lee Jones wrote: > To: Opensource [Steve Twiss] > Subject: Re: [PATCH V5 1/2] mfd: da9062: DA9062 MFD core driver > > > From: S Twiss > > > > Add MFD core driver support for DA9062 > > > > Signed-off-by: Steve Twiss > > [...]

RE: [PATCH V5 1/2] mfd: da9062: DA9062 MFD core driver

On 07 July 2015 12:42, Lee Jones wrote: To: Opensource [Steve Twiss] Subject: Re: [PATCH V5 1/2] mfd: da9062: DA9062 MFD core driver From: S Twiss stwiss.opensou...@diasemi.com Add MFD core driver support for DA9062 Signed-off-by: Steve Twiss stwiss.opensou...@diasemi.com

RE: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver

On 11 June 2015 09:57, Lee Jones wrote: > To: Opensource [Steve Twiss] > Subject: Re: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver > > > > > > Steve Twiss wrote: > > > > > +#define DA9062AA_PAGE_SHIFT 0 > > > > > +#define DA906

RE: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver

On 11 June 2015 09:57, Lee Jones wrote: To: Opensource [Steve Twiss] Subject: Re: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver Steve Twiss wrote: +#define DA9062AA_PAGE_SHIFT 0 +#define DA9062AA_PAGE_MASK (0x3f 0) +#define

RE: [PATCH] regulator: da9210: Add optional interrupt support

On 24 June 2015 13:14, Geert Uytterhoeven wrote: > To: Support Opensource; Liam Girdwood; Mark Brown; Opensource [Steve Twiss] > Subject: [PATCH] regulator: da9210: Add optional interrupt support > > Add optional interrupt support to the da9210 regulator driver, to handle > over

RE: [PATCH] regulator: da9210: Add optional interrupt support

On 24 June 2015 13:14, Geert Uytterhoeven wrote: To: Support Opensource; Liam Girdwood; Mark Brown; Opensource [Steve Twiss] Subject: [PATCH] regulator: da9210: Add optional interrupt support Add optional interrupt support to the da9210 regulator driver, to handle over-current, under

RE: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver

On 11 June 2015 09:57 Lee Jones wrote: > To: Opensource [Steve Twiss] > Subject: Re: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver > > > > > > diff --git a/include/linux/mfd/da9062/registers.h [...] > > > > > +#define DA9062AA_W

RE: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver

On 28 May 2015 13:53, Steve Twiss wrote: > To: 'Lee Jones' > Subject: RE: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver > > Hi Lee, > > I will refactor a lot of the driver and implement your changes as requested. Hi Lee, I realise this is a busy kernel time for you, as ever, so this is

RE: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver

On 11 June 2015 09:57 Lee Jones wrote: To: Opensource [Steve Twiss] Subject: Re: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver diff --git a/include/linux/mfd/da9062/registers.h [...] +#define DA9062AA_WRITE_MODE_SHIFT6 +#define DA9062AA_WRITE_MODE_MASK (0x01 6

RE: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver

On 28 May 2015 13:53, Steve Twiss wrote: To: 'Lee Jones' Subject: RE: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver Hi Lee, I will refactor a lot of the driver and implement your changes as requested. Hi Lee, I realise this is a busy kernel time for you, as ever, so this is just to

RE: [RESEND PATCH V4 3/3] mfd: da9063: MFD support for OnKey driver

On 09 June 2015 07:51 Lee Jones wrote: > On Mon, 08 Jun 2015, Dmitry Torokhov wrote: > > On Tue, May 19, 2015 at 11:32:45AM +0100, S Twiss wrote: > > > From: Steve Twiss > > > > > > Add MFD support for the DA9063 OnKey driver > > > > > > The function da9063_clear_fault_log() is added to mitigate

RE: [RESEND PATCH V4 3/3] mfd: da9063: MFD support for OnKey driver

On 09 June 2015 07:51 Lee Jones wrote: On Mon, 08 Jun 2015, Dmitry Torokhov wrote: On Tue, May 19, 2015 at 11:32:45AM +0100, S Twiss wrote: From: Steve Twiss stwiss.opensou...@diasemi.com Add MFD support for the DA9063 OnKey driver The function da9063_clear_fault_log() is added

RE: [RESEND PATCH V4 1/1] input: misc: da9063: OnKey driver

On 05 June 2015 18:50 Dmitry Torokhov wrote: > Subject: Re: [RESEND PATCH V4 1/1] input: misc: da9063: OnKey driver > On Thu, Jun 04, 2015 at 12:02:32PM +0100, S Twiss wrote: > > From: Steve Twiss > > > > Add OnKey driver support for DA9063 > > > > Signed-off-by: Steve Twiss > > > > --- > > The

RE: [RESEND PATCH V4 1/1] input: misc: da9063: OnKey driver

On 05 June 2015 18:50 Dmitry Torokhov wrote: Subject: Re: [RESEND PATCH V4 1/1] input: misc: da9063: OnKey driver On Thu, Jun 04, 2015 at 12:02:32PM +0100, S Twiss wrote: From: Steve Twiss stwiss.opensou...@diasemi.com Add OnKey driver support for DA9063 Signed-off-by: Steve Twiss

RE: [PATCH V1] regulators: da9062: Remove unused variable build warning

On 02 June 2015 12:12 Mark Brown wrote: > To: Opensource [Steve Twiss] > Cc: LINUXKERNEL; Liam Girdwood; David Dajun Chen; Support Opensource > Subject: Re: [PATCH V1] regulators: da9062: Remove unused variable build > warning > > On Mon, Jun 01, 2015 at 02:00:20PM +0100, S Twi

RE: [PATCH V1] regulators: da9062: Remove unused variable build warning

On 02 June 2015 12:12 Mark Brown wrote: To: Opensource [Steve Twiss] Cc: LINUXKERNEL; Liam Girdwood; David Dajun Chen; Support Opensource Subject: Re: [PATCH V1] regulators: da9062: Remove unused variable build warning On Mon, Jun 01, 2015 at 02:00:20PM +0100, S Twiss wrote: From: S

RE: [RESEND PATCH V4 1/3] input: misc: da9063: OnKey driver

On 27 May 2015 16:38, Steve Twiss wrote: > On 19 May 2015 11:33, S Twiss wrote: > > > To: Dmitry Torokhov > > Subject: [RESEND PATCH V4 1/3] input: misc: da9063: OnKey driver > > > > From: Steve Twiss > > Add OnKey driver support for DA9063 > > Signed-off-by: Steve Twiss > > > > --- > > The

RE: [RESEND PATCH V4 1/3] input: misc: da9063: OnKey driver

On 27 May 2015 16:38, Steve Twiss wrote: On 19 May 2015 11:33, S Twiss wrote: To: Dmitry Torokhov Subject: [RESEND PATCH V4 1/3] input: misc: da9063: OnKey driver From: Steve Twiss stwiss.opensou...@diasemi.com Add OnKey driver support for DA9063 Signed-off-by: Steve Twiss

RE: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver

Please find more detailed comments below. thanks, Steve On 26 May 2015 17:10 Lee Jones wrote > To: Opensource [Steve Twiss] > Cc: LINUXKERNEL; Samuel Ortiz; Alessandro Zummo; DEVICETREE; David > Dajun Chen; Dmitry Torokhov; Ian Campbell; Kumar Gala; LINUXINPUT; > LINUXWATCHDOG; L

RE: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver

Please find more detailed comments below. thanks, Steve On 26 May 2015 17:10 Lee Jones wrote To: Opensource [Steve Twiss] Cc: LINUXKERNEL; Samuel Ortiz; Alessandro Zummo; DEVICETREE; David Dajun Chen; Dmitry Torokhov; Ian Campbell; Kumar Gala; LINUXINPUT; LINUXWATCHDOG; Liam Girdwood; Mark

RE: [RESEND PATCH V4 1/3] input: misc: da9063: OnKey driver

On 19 May 2015 11:33, S Twiss wrote: > To: Dmitry Torokhov > Cc: DT; David Dajun Chen; INPUT; Ian Campbell; Kumar Gala; LKML; Lee > Jones; Mark Rutland; Pawel Moll; Rob Herring; Samuel Ortiz; Opensource > [Steve Twiss]; Support Opensource > Subject: [RESEND PATCH V4 1/3] inpu

RE: regulator: da9062: undefined Kconfig option MFD_DA9062

On 26 May 2015 11:37 Lee Jones wrote: > To: Opensource [Steve Twiss] > Subject: Re: regulator: da9062: undefined Kconfig option MFD_DA9062 > > > On 22 May 2015 09:20 Valentin Rothberg wrote: > > > To: Opensource [Steve Twiss] > > > Hi Steve, > > >

RE: [RESEND PATCH V4 1/3] input: misc: da9063: OnKey driver

On 19 May 2015 11:33, S Twiss wrote: To: Dmitry Torokhov Cc: DT; David Dajun Chen; INPUT; Ian Campbell; Kumar Gala; LKML; Lee Jones; Mark Rutland; Pawel Moll; Rob Herring; Samuel Ortiz; Opensource [Steve Twiss]; Support Opensource Subject: [RESEND PATCH V4 1/3] input: misc: da9063: OnKey

RE: regulator: da9062: undefined Kconfig option MFD_DA9062

On 26 May 2015 11:37 Lee Jones wrote: To: Opensource [Steve Twiss] Subject: Re: regulator: da9062: undefined Kconfig option MFD_DA9062 On 22 May 2015 09:20 Valentin Rothberg wrote: To: Opensource [Steve Twiss] Hi Steve, your commit 4068e5182ada (regulator: da9062: DA9062

RE: [RESEND PATCH V4 3/3] mfd: da9063: MFD support for OnKey driver

On 26 May 2015 14:58 Lee Jones wrote: > To: Opensource [Steve Twiss] > Cc: Samuel Ortiz; DT; David Dajun Chen; Dmitry Torokhov; INPUT; Ian > Campbell; Kumar Gala; LKML; Mark Rutland; Pawel Moll; Rob Herring; > Support Opensource > Subject: Re: [RESEND PATCH V4 3/3] mfd: da90

RE: [RESEND PATCH V4 3/3] mfd: da9063: MFD support for OnKey driver

On 26 May 2015 14:58 Lee Jones wrote: To: Opensource [Steve Twiss] Cc: Samuel Ortiz; DT; David Dajun Chen; Dmitry Torokhov; INPUT; Ian Campbell; Kumar Gala; LKML; Mark Rutland; Pawel Moll; Rob Herring; Support Opensource Subject: Re: [RESEND PATCH V4 3/3] mfd: da9063: MFD support for OnKey

RE: regulator: da9062: undefined Kconfig option MFD_DA9062

On 22 May 2015 09:20 Valentin Rothberg wrote: > To: Opensource [Steve Twiss] > Cc: broo...@kernel.org; lgirdw...@gmail.com; Support Opensource; linux- > ker...@vger.kernel.org; Paul Bolle; Andreas Ruprecht; hengelein Stefan > Subject: regulator: da9062: undefined Kconfig option MFD_DA

RE: regulator: da9062: undefined Kconfig option MFD_DA9062

On 22 May 2015 09:20 Valentin Rothberg wrote: To: Opensource [Steve Twiss] Cc: broo...@kernel.org; lgirdw...@gmail.com; Support Opensource; linux- ker...@vger.kernel.org; Paul Bolle; Andreas Ruprecht; hengelein Stefan Subject: regulator: da9062: undefined Kconfig option MFD_DA9062 Hi Steve

RE: [PATCH V3 2/4] regulator: da9062: DA9062 regulator driver

On 21 May 2015 13:04 Mark Brown wrote: > Subject: Re: [PATCH V3 2/4] regulator: da9062: DA9062 regulator driver > > On Tue, May 19, 2015 at 02:10:30PM +0100, S Twiss wrote: > > From: S Twiss > > > > Add BUCK and LDO regulator driver support for DA9062 > > Applied, thanks. Thank you Regards,

RE: [PATCH V3 3/4] watchdog: da9062: DA9062 watchdog driver

On 20 May 2015 21:30 Guenter Roeck wrote: > Subject: Re: [PATCH V3 3/4] watchdog: da9062: DA9062 watchdog driver > > On Tue, May 19, 2015 at 02:10:30PM +0100, S Twiss wrote: > > From: S Twiss > > > > Add watchdog driver support for DA9062 > > > > > > Signed-off-by: Steve Twiss > > >

RE: [PATCH V3 3/4] watchdog: da9062: DA9062 watchdog driver

On 20 May 2015 21:30 Guenter Roeck wrote: Subject: Re: [PATCH V3 3/4] watchdog: da9062: DA9062 watchdog driver On Tue, May 19, 2015 at 02:10:30PM +0100, S Twiss wrote: From: S Twiss stwiss.opensou...@diasemi.com Add watchdog driver support for DA9062 Signed-off-by: Steve Twiss

RE: [PATCH V3 2/4] regulator: da9062: DA9062 regulator driver

On 21 May 2015 13:04 Mark Brown wrote: Subject: Re: [PATCH V3 2/4] regulator: da9062: DA9062 regulator driver On Tue, May 19, 2015 at 02:10:30PM +0100, S Twiss wrote: From: S Twiss stwiss.opensou...@diasemi.com Add BUCK and LDO regulator driver support for DA9062 Applied, thanks.

RE: [RESEND PATCH V4 2/3] devicetree: Add bindings for DA9063 OnKey

On 20 May 2015 14:44 Rob Herring wrote: > To: Opensource [Steve Twiss] > Cc: Ian Campbell; Kumar Gala; Lee Jones; Mark Rutland; Pawel Moll; Rob > Herring; DT; David Dajun Chen; Dmitry Torokhov; INPUT; LKML; Samuel Ortiz; > Support Opensource > Subject: Re: [RESEND PATCH V4 2/3]

RE: [RESEND PATCH V4 2/3] devicetree: Add bindings for DA9063 OnKey

On 20 May 2015 14:44 Rob Herring wrote: To: Opensource [Steve Twiss] Cc: Ian Campbell; Kumar Gala; Lee Jones; Mark Rutland; Pawel Moll; Rob Herring; DT; David Dajun Chen; Dmitry Torokhov; INPUT; LKML; Samuel Ortiz; Support Opensource Subject: Re: [RESEND PATCH V4 2/3] devicetree: Add

RE: [rtc-linux] RE: [PATCH V2 3/4] watchdog: da9062: DA9062 watchdog driver

On 18 May 2015 18:39 Alexandre Belloni wrote: > Sure, what I understand is that the base functionality is the same and > even the registers are compatible. Are you sure the new features can't > be added to the da9063 and called conditionally? Plenty of drivers are > doing that. Hi

RE: [rtc-linux] [PATCH V2 1/4] mfd: da9062: DA9062 MFD core driver

On 16 May 2015 09:53 Alexandre Belloni wrote: Hi Alexandre, > On 14/05/2015 at 17:43:52 +0100, S Twiss wrote : [...] > > + { > > + .name = "da9062-watchdog", > > + .num_resources = ARRAY_SIZE(da9062_wdt_resources), > > + .resources =

RE: [rtc-linux] [PATCH V2 1/4] mfd: da9062: DA9062 MFD core driver

On 16 May 2015 09:53 Alexandre Belloni wrote: Hi Alexandre, On 14/05/2015 at 17:43:52 +0100, S Twiss wrote : [...] + { + .name = da9062-watchdog, + .num_resources = ARRAY_SIZE(da9062_wdt_resources), + .resources = da9062_wdt_resources,

RE: [rtc-linux] RE: [PATCH V2 3/4] watchdog: da9062: DA9062 watchdog driver

On 18 May 2015 18:39 Alexandre Belloni wrote: Sure, what I understand is that the base functionality is the same and even the registers are compatible. Are you sure the new features can't be added to the da9063 and called conditionally? Plenty of drivers are doing that. Hi Alexandre/Guenter,

RE: [PATCH V2 3/4] watchdog: da9062: DA9062 watchdog driver

On 18 May 2015 16:28 Guenter Roeck wrote: > On Mon, May 18, 2015 at 02:15:01PM +0000, Opensource [Steve Twiss] > wrote: > > On 15 May 2015 21:20 Guenter Roeck, > > > > > > > > + > > > > > > +/* E_WDG_WARN interrupt handler */ > > >

RE: [rtc-linux] [PATCH V2 0/4] da9062: DA9062 driver submission

On 16 May 2015 01:47, Alexandre Belloni wrote > On 14/05/2015 at 17:43:53 +0100, S Twiss wrote : > > From: S Twiss > > > > This patch set adds support for the Dialog DA9062 Power Management IC. > > > > In this patch set the following is provided: > > - [PATCH V2 1/4]: MFD core support > > -

RE: [PATCH V2 3/4] watchdog: da9062: DA9062 watchdog driver

On 15 May 2015 21:20 Guenter Roeck, > > > > + > > > > +/* E_WDG_WARN interrupt handler */ > > > > +static irqreturn_t da9062_wdt_wdg_warn_irq_handler(int irq, void*data) > > > > +{ > > > > + struct da9062_watchdog *wdt = data; > > > > + > > > > + dev_notice(wdt->hw->dev, "Watchdog

RE: [PATCH V2 3/4] watchdog: da9062: DA9062 watchdog driver

On 15 May 2015 21:20 Guenter Roeck, + +/* E_WDG_WARN interrupt handler */ +static irqreturn_t da9062_wdt_wdg_warn_irq_handler(int irq, void*data) +{ + struct da9062_watchdog *wdt = data; + + dev_notice(wdt-hw-dev, Watchdog timeout warning trigger.\n); +

RE: [rtc-linux] [PATCH V2 0/4] da9062: DA9062 driver submission

On 16 May 2015 01:47, Alexandre Belloni wrote On 14/05/2015 at 17:43:53 +0100, S Twiss wrote : From: S Twiss stwiss.opensou...@diasemi.com This patch set adds support for the Dialog DA9062 Power Management IC. In this patch set the following is provided: - [PATCH V2 1/4]: MFD core

RE: [PATCH V2 3/4] watchdog: da9062: DA9062 watchdog driver

On 18 May 2015 16:28 Guenter Roeck wrote: On Mon, May 18, 2015 at 02:15:01PM +, Opensource [Steve Twiss] wrote: On 15 May 2015 21:20 Guenter Roeck, + +/* E_WDG_WARN interrupt handler */ +static irqreturn_t da9062_wdt_wdg_warn_irq_handler(int irq, void*data

RE: [PATCH V2 3/4] watchdog: da9062: DA9062 watchdog driver

> > + > > +/* E_WDG_WARN interrupt handler */ > > +static irqreturn_t da9062_wdt_wdg_warn_irq_handler(int irq, void *data) > > +{ > > + struct da9062_watchdog *wdt = data; > > + > > + dev_notice(wdt->hw->dev, "Watchdog timeout warning trigger.\n"); > > + return IRQ_HANDLED; > > +} > > + On

RE: [PATCH V2 3/4] watchdog: da9062: DA9062 watchdog driver

Hi Guenter, Thank you for your comments again, Here are my responses. Regards, Steve On 15 May 2015 03:13, Guenter Roeck > Subject: Re: [PATCH V2 3/4] watchdog: da9062: DA9062 watchdog driver > [...] > > +static void da9062_apply_window_protection(struct da9062_watchdog > *wdt) > > +{ > > +

  1   2   3   >