It allows kernel modules which are not compiled into kernel image to use
pci-bridge-emul API functions.
Signed-off-by: Pali Rohár
Reviewed-by: Marek Behún
---
drivers/pci/pci-bridge-emul.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/pci/pci-bridge-emul.c b/drivers/pci/pci
it is a good idea to
have this code at the same place as link training calls.
This patch does not change behavior of aardvark initialization.
Signed-off-by: Pali Rohár
Tested-by: Marek Behún
---
drivers/pci/controller/pci-aardvark.c | 64 ++-
1 file changed, 34 insertions
& Pali
Changes in V2 for patch 4/5:
* Protect pci_stop_root_bus() and pci_remove_root_bus() function calls by
pci_lock_rescan_remove() and pci_unlock_rescan_remove()
Pali Rohár (5):
PCI: aardvark: Fix compilation on s390
PCI: aardvark: Check for errors from pci_bridge_emul_init() call
Function pci_bridge_emul_init() may fail so correctly check for errors.
Fixes: 8a3ebd8de328 ("PCI: aardvark: Implement emulated root PCI bridge config
space")
Signed-off-by: Pali Rohár
Reviewed-by: Marek Behún
---
drivers/pci/controller/pci-aardvark.c | 11 +++
1 file
On Monday 03 August 2020 14:00:37 Rob Herring wrote:
> On Mon, Aug 3, 2020 at 8:46 AM Pali Rohár wrote:
> >
> > On Wednesday 29 July 2020 12:48:09 Rob Herring wrote:
> > > On Wed, Jul 15, 2020 at 04:25:56PM +0200, Marek Behún wrote:
> > > > From: Pali Rohár
On Wednesday 29 July 2020 12:48:09 Rob Herring wrote:
> On Wed, Jul 15, 2020 at 04:25:56PM +0200, Marek Behún wrote:
> > From: Pali Rohár
> >
> > Providing driver's 'remove' function allows kernel to bind and unbind
> > devices
> > from aardvark driver. It als
information for PCMCIA cards should contain following strings in
this order: Manufacturer, Product Name, Lot number, Programming Conditions.
Note that not all SDIO cards export all those info strings in that order as
described in PCMCIA Metaformat Specification.
Signed-off-by: Pali Rohár
They should indicate compliance of standard.
Signed-off-by: Pali Rohár
---
drivers/mmc/core/sdio_cis.c | 8
include/linux/mmc/card.h | 2 ++
include/linux/mmc/sdio_func.h | 2 ++
3 files changed, 12 insertions(+)
diff --git a/drivers/mmc/core/sdio_cis.c b/drivers/mmc/core
This simplify code for generating sdio config attributes and allows easily
define new sdio attributes.
Signed-off-by: Pali Rohár
---
drivers/mmc/core/sdio_bus.c | 20 ++--
1 file changed, 6 insertions(+), 14 deletions(-)
diff --git a/drivers/mmc/core/sdio_bus.c b/drivers/mmc
Before parsing CISTPL_VERS_1 structure check that its size is at least two
bytes to prevent buffer overflow.
Signed-off-by: Pali Rohár
---
drivers/mmc/core/sdio_cis.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/mmc/core/sdio_cis.c b/drivers/mmc/core/sdio_cis.c
index
specificaion and the third and the second strings are empty.
Pali Rohár (4):
mmc: sdio: Check for CISTPL_VERS_1 buffer size
mmc: sdio: Parse CISTPL_VERS_1 major and minor revision numbers
mmc: sdio: Extend sdio_config_attr macro and use it also for modalias
mmc: sdio: Export SDIO revision
Reset gpio is optional and it does not have to be defined for all boards.
So in mvebu_pcie_powerdown() like in mvebu_pcie_powerup() check that reset
gpio is defined prior usage to prevent NULL pointer dereference.
Signed-off-by: Pali Rohár
---
drivers/pci/controller/pci-mvebu.c | 3 ++-
1 file
-by: Pali Rohár
---
arch/arm64/boot/dts/marvell/armada-37xx.dtsi | 2 +-
drivers/pinctrl/mvebu/pinctrl-armada-37xx.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
b/arch/arm64/boot/dts/marvell/armada-37xx.dtsi
index 2bbc69b4dc99
On Wednesday 15 July 2020 17:21:08 Lorenzo Pieralisi wrote:
> On Wed, Jul 15, 2020 at 02:17:26PM +0200, Pali Rohár wrote:
> > On Monday 13 July 2020 12:23:25 Lorenzo Pieralisi wrote:
> > > On Mon, Jul 13, 2020 at 10:27:47AM +0200, Pali Rohár wrote:
> > > > On Friday
Hello Bjorn!
I see following error message in dmesg which looks like a race condition:
sysfs: cannot create duplicate filename
'/devices/platform/soc/d007.pcie/pci:00/:00:00.0/config'
I looked at it deeper and found out that in PCI subsystem code is race
condition between
On Wednesday 15 July 2020 18:30:01 Randy Dunlap wrote:
> From: Randy Dunlap
>
> Drop the doubled word "for".
> Change "It it" to "If it".
>
> Signed-off-by: Randy Dunlap
> Cc: Pali Rohár
> Cc: Sebastian Reichel
> Cc: linux...@vger.ker
On Monday 13 July 2020 12:23:25 Lorenzo Pieralisi wrote:
> On Mon, Jul 13, 2020 at 10:27:47AM +0200, Pali Rohár wrote:
> > On Friday 10 July 2020 10:18:00 Lorenzo Pieralisi wrote:
> > > On Thu, Jul 09, 2020 at 05:09:59PM +0200, Pali Rohár wrote:
> > > > > I u
On Monday 13 July 2020 17:41:40 Lorenzo Pieralisi wrote:
> On Mon, Jul 13, 2020 at 04:50:03PM +0200, Pali Rohár wrote:
> > On Monday 13 July 2020 12:23:25 Lorenzo Pieralisi wrote:
> > > I will go over the thread again but I suspect I can merge the patch even
> >
On Monday 13 July 2020 12:23:25 Lorenzo Pieralisi wrote:
> I will go over the thread again but I suspect I can merge the patch even
> though I still believe there is work to be done to understand the issue
> we are facing.
Just to note that pci-mvebu.c also checks if pcie link is up before
trying
On Friday 10 July 2020 10:18:00 Lorenzo Pieralisi wrote:
> On Thu, Jul 09, 2020 at 05:09:59PM +0200, Pali Rohár wrote:
> > > I understand that but the bridge bus resource can be trimmed to just
> > > contain the root bus because that's the only one where there is a
> >
On Thursday 09 July 2020 22:29:42 Andy Shevchenko wrote:
> On Wed, Jun 10, 2020 at 10:23 PM wrote:
> >
> > > -Original Message-
> > > From: Y Paritcher
> > > Sent: Wednesday, June 10, 2020 12:57 PM
> > > To: Pali Rohár
> >
On Friday 10 July 2020 11:08:28 Bjorn Helgaas wrote:
> On Fri, Jul 10, 2020 at 05:44:58PM +0200, Pali Rohár wrote:
> > I can reproduce following issue: Connect Compex WLE900VX card, configure
> > aardvark to gen2 mode. And then card is detected only after the first
> > lin
On Friday 10 July 2020 10:18:00 Lorenzo Pieralisi wrote:
> I would be very grateful if you could describe what happens in HW
> when these conditions trigger - I would like to understand if this
> issue is aardvark specific or it isn't.
Hello Lorenzo! We are not sure what is the problem and where
On Thursday 09 July 2020 15:47:01 Lorenzo Pieralisi wrote:
> On Thu, Jul 09, 2020 at 02:22:08PM +0200, Pali Rohár wrote:
> > On Thursday 09 July 2020 12:35:09 Lorenzo Pieralisi wrote:
> > > On Thu, Jul 02, 2020 at 10:30:36AM +0200, Pali Rohár wrote:
> > > > When t
On Thursday 09 July 2020 12:35:09 Lorenzo Pieralisi wrote:
> On Thu, Jul 02, 2020 at 10:30:36AM +0200, Pali Rohár wrote:
> > When there is no PCIe card connected and advk_pcie_rd_conf() or
> > advk_pcie_wr_conf() is called for PCI bus which doesn't belong to emulated
> > root
On Tuesday 07 July 2020 14:53:11 Lorenzo Pieralisi wrote:
> On Fri, Jun 19, 2020 at 12:56:18PM +0200, Pali Rohár wrote:
> > Hello Lorenzo! Could you please review this patch?
> >
> > On Monday 01 June 2020 15:03:15 Pali Rohár wrote:
> > > Most callers of config read
.
This patch fixes problem that mwifiex kernel driver sends to userspace
unsupported error codes like: "failed: -524 (No error information)".
After applying this patch userspace see: "failed: -95 (Not supported)".
Signed-off-by: Pali Rohár
---
.../net/wireless/marvell/mwifie
-off-by: Pali Rohár
---
Changes in V3:
* Add comment to the code
Changes in V2:
* Update commit message, mention that this is optimization
---
drivers/pci/controller/pci-aardvark.c | 7 +++
1 file changed, 7 insertions(+)
diff --git a/drivers/pci/controller/pci-aardvark.c
b/drivers/pci
On Wednesday 01 July 2020 16:34:42 Bjorn Helgaas wrote:
> On Wed, Jul 01, 2020 at 10:20:44AM +0200, Pali Rohár wrote:
> > When there is no PCIe card connected and advk_pcie_rd_conf() or
> > advk_pcie_wr_conf() is called for PCI bus which doesn't belong to emulated
> > root
-off-by: Pali Rohár
---
Changes in V2:
* Update commit message, mention that this is optimization
---
drivers/pci/controller/pci-aardvark.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/pci/controller/pci-aardvark.c
b/drivers/pci/controller/pci-aardvark.c
index 90ff291c24f0
On Tuesday 30 June 2020 09:58:48 Bjorn Helgaas wrote:
> On Tue, Jun 30, 2020 at 04:04:20PM +0200, Pali Rohár wrote:
> > On Tuesday 30 June 2020 08:51:27 Bjorn Helgaas wrote:
> > > On Thu, May 28, 2020 at 06:38:09PM +0200, Pali Rohár wrote:
> > > > On Thursday 28 M
On Tuesday 30 June 2020 08:51:27 Bjorn Helgaas wrote:
> On Thu, May 28, 2020 at 06:38:09PM +0200, Pali Rohár wrote:
> > On Thursday 28 May 2020 11:26:04 Bjorn Helgaas wrote:
> > > On Thu, May 28, 2020 at 04:31:41PM +0200, Pali Rohár wrote:
> > > > When t
Hello!
On Friday 29 May 2020 10:30:13 Pali Rohár wrote:
> On Thursday 28 May 2020 11:49:38 Bjorn Helgaas wrote:
> > On Thu, May 28, 2020 at 06:38:09PM +0200, Pali Rohár wrote:
> > > On Thursday 28 May 2020 11:26:04 Bjorn Helgaas wrote:
> > > > On Thu, May 28, 2020 a
Define appropriate macro names for consistency with other macros.
Signed-off-by: Pali Rohár
---
Hello Ulf! I forgot to include change for rsi driver into patch series:
"mmc: sdio: Move SDIO IDs from drivers to common include file"
https://lore.kernel.org/linux-mmc/20200522144412
This macro is already used in mwifiex driver for specifying upper limit and
is defined to value 3. So use it also in struct ieee80211_iface_limit.
Signed-off-by: Pali Rohár
---
drivers/net/wireless/marvell/mwifiex/cfg80211.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git
Hello!
On Friday 26 June 2020 14:53:50 Pavel Machek wrote:
> Hi!
>
> > [ Upstream commit 90c6cb4a355e7befcb557d217d1d8b8bd5875a05 ]
> >
> > Trying to change Link Status register does not have any effect as this
> > is a read-only register. Trying to overwrite bits for Negotiated Link
> > Width
On Sunday 21 June 2020 11:05:22 kernel test robot wrote:
> >> drivers/pci/controller/pci-aardvark.c:350:2: error: implicit declaration
> >> of function 'gpiod_set_value_cansleep'
> >> [-Werror,-Wimplicit-function-declaration]
>gpiod_set_value_cansleep(pcie->reset_gpio, 1);
>
On Friday 19 June 2020 19:55:21 Sebastian Reichel wrote:
> Hi,
>
> On Wed, May 27, 2020 at 09:42:54AM +0200, Pali Rohár wrote:
> > On Tuesday 26 May 2020 21:16:28 Andrew F. Davis wrote:
> > > On 5/25/20 7:32 AM, Krzysztof Kozlowski wrote:
>
On Thursday 18 June 2020 21:55:29 Jeffrey Lin wrote:
> This allows manual PWM control without the BIOS fighting back on Dell
> Latitude 5480.
>
> Signed-off-by: Jeffrey Lin
If it is working fine on your machine, you can add my:
Acked-by: Pali Rohár
> ---
> drivers/hwmon/de
Hello Lorenzo! Could you please review this patch?
On Monday 01 June 2020 15:03:15 Pali Rohár wrote:
> Most callers of config read do not check for return value. But most of the
> ones that do, checks for error indication in 'val' variable.
>
> This patch updates er
On Friday 29 May 2020 11:12:11 Pali Rohár wrote:
> On Friday 29 May 2020 09:11:08 Ganapathi Bhat wrote:
> > Hi Pali,
> >
> > > Hello Ganapathi! Seems that on both locations is older version of
> > > sdsd8997_combo_v4.bin firmware, not the latest one. On both
On Wednesday 10 June 2020 12:35:09 mario.limoncie...@dell.com wrote:
> > -Original Message-
> > From: platform-driver-x86-ow...@vger.kernel.org > ow...@vger.kernel.org> On Behalf Of Pali Rohár
> > Sent: Wednesday, June 10, 2020 4:45 AM
> > To: L
+---
> 1 file changed, 25 insertions(+), 3 deletions(-)
>
> --
> 2.27.0
>
I'm fine with this patch series too.
Reviewed-by: Pali Rohár
On Tuesday 09 June 2020 19:49:18 mario.limoncie...@dell.com wrote:
> >
> > Looking at the last two lines... and for me it looks like that 0x00FF
> > and 0x are just "placeholders" or special values for unknown /
> > custom / unsupported / reserved / special / ... codes.
> >
> > It is really
On Monday 08 June 2020 20:36:58 mario.limoncie...@dell.com wrote:
> Can you please comment here how you would like to see events like this should
> come
> through to userspace?
>
> * Wrong power adapter (you have X and should have Y)
> * You have plugged a dock into the wrong port
> * Fn-lock
Adding Darren and Andy, please look at this issue as this is something
which should be decided how to handle in all platform/wmi drivers.
On Monday 08 June 2020 23:52:54 Y Paritcher wrote:
> This looks to be a special value for some sort of custom scancode.
> This code could not be triggered for
On Tuesday 09 June 2020 00:26:45 mario.limoncie...@dell.com wrote:
> > Mario, are you able to get some official documentation for these 0x0012
> > event types? I think it could be really useful for community so they can
> > understand and add easily new type of code and events. Because currently
>
On Monday 08 June 2020 20:57:38 Y Paritcher wrote:
> On 6/8/20 8:26 PM, mario.limoncie...@dell.com wrote:
> >> -Original Message-
> >> From: Pali Rohár
> >> Sent: Monday, June 8, 2020 6:33 PM
> >> To: Y Paritcher
> >> Cc: linux-kernel@vger
On Monday 08 June 2020 20:43:45 Y Paritcher wrote:
> On 6/8/20 7:55 PM, Pali Rohár wrote:
> > Hello!
> >
> > On Monday 08 June 2020 16:27:10 Randy Dunlap wrote:
> >> Hi--
> >>
> >> On 6/8/20 4:05 PM, Y Paritcher wrote:
> >>> Increa
On Monday 08 June 2020 20:58:38 mario.limoncie...@dell.com wrote:
> > -Original Message-
> > From: platform-driver-x86-ow...@vger.kernel.org > ow...@vger.kernel.org> On Behalf Of Pali Rohár
> > Sent: Monday, June 8, 2020 3:48 PM
> > To: Limonciello, Mario
On Monday 08 June 2020 15:40:53 mario.limoncie...@dell.com wrote:
> > dell_wmi: Unknown WMI event type 0x12
> > dell_wmi: Unknown key with type 0x0012 and code 0xe035 pressed
>
> Event type 0x12 is for "System Events". This is the type of events that
> you typically would see come in for things
Hello!
On Monday 08 June 2020 16:27:10 Randy Dunlap wrote:
> Hi--
>
> On 6/8/20 4:05 PM, Y Paritcher wrote:
> > Increase length of bios_to_linux_keycode to 2 bytes (the true size of a
> > keycode) to allow for a new keycode 0x, this silences the following
> > messages being logged at startup
own key with type 0x0012 and code 0xe035 pressed
>
> This is consistent with the behavior for the Fn-lock key
> elsewhere in this file.
>
> Signed-off-by: Y Paritcher
I'm fine with this patch now.
Reviewed-by: Pali Rohár
> ---
> drivers/platform/x86/dell-wmi.c | 20 +
nown key with type 0x0010 and code 0x0058 pressed
>
> These are brightness events and will be handled by acpi-video
>
> Signed-off-by: Y Paritcher
Reviewed-by: Pali Rohár
> ---
> drivers/platform/x86/dell-wmi.c | 4
> 1 file changed, 4 insertions(+)
>
> diff --gi
On Monday 08 June 2020 15:46:44 mario.limoncie...@dell.com wrote:
> I would actually question if there is value to lines in dell-wmi.c like this:
>
> pr_info("Unknown WMI event type 0x%x\n", (int)buffer_entry[1]);
>
> and
>
> pr_info("Unknown key with type 0x%04x and code 0x%04x pressed\n",
On Monday 08 June 2020 20:14:15 mario.limoncie...@dell.com wrote:
> > >>> index c25a4286d766..0b4f72f923cd 100644
> > >>> --- a/drivers/platform/x86/dell-wmi.c
> > >>> +++ b/drivers/platform/x86/dell-wmi.c
> > >>> @@ -252,6 +252,10 @@ static const struct key_entry
> > >>
Hello!
On Monday 08 June 2020 16:12:52 Y Paritcher wrote:
> You are right.
> I had assumed (incorrectly) the were the same.
> I turned on dyndbg and got the events with the extended data.
>
> Fn lock key switched to multimedia keys
> dell_wmi: Received WMI event (02 00 12 00 35 e0 01 00 00 00 00
Hello!
On Monday 08 June 2020 00:22:26 Y Paritcher wrote:
> Increase length of bios_to_linux_keycode to 2 bytes to allow for a new
> keycode 0x, this silences the following messages being logged at
> startup on a Dell Inspiron 5593
>
> dell_wmi: firmware scancode 0x48 maps to unrecognized
Hello!
On Monday 08 June 2020 00:22:25 Y Paritcher wrote:
> Ignore events with a type of 0x0012 and a code of 0xe035,
> this silences the following messages being logged when
> pressing the Fn-lock key on a Dell Inspiron 5593:
Could you please explain why to ignore these events instead of
On Monday 08 June 2020 00:22:24 Y Paritcher wrote:
> Ignore events with a type of 0x0010 and a code of 0x57 / 0x58,
> this silences the following messages being logged on a
> Dell Inspiron 5593:
>
> dell_wmi: Unknown key with type 0x0010 and code 0x0057 pressed
> dell_wmi: Unknown key with type
of this patch series can be
applied separately via wireless and bluetooth trees. I'm sending all four
patches in one patch series for easier review.
[1] -
https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git/tree/mrvl
Pali Rohár (4):
mwifiex: Fix firmware filename for sd8977
Signed-off-by: Pali Rohár
---
drivers/net/wireless/marvell/mwifiex/sdio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.h
b/drivers/net/wireless/marvell/mwifiex/sdio.h
index 71cd8629b28e..0cac2296ed53 100644
--- a/drivers/net/wirele
Signed-off-by: Pali Rohár
---
drivers/net/wireless/marvell/mwifiex/sdio.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/wireless/marvell/mwifiex/sdio.h
b/drivers/net/wireless/marvell/mwifiex/sdio.h
index 0cac2296ed53..8b476b007c5e 100644
--- a/drivers/net/wirele
ipset")
Signed-off-by: Pali Rohár
---
drivers/bluetooth/btmrvl_sdio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c
index 0f3a020703ab..7aa2c94720bc 100644
--- a/drivers/bluetooth/btmrvl_sdio.c
+++
pport")
Signed-off-by: Pali Rohár
---
drivers/bluetooth/btmrvl_sdio.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/bluetooth/btmrvl_sdio.c b/drivers/bluetooth/btmrvl_sdio.c
index 7aa2c94720bc..4c7978cb1786 100644
--- a/drivers/bluetooth/btmrvl_sdio.c
+++ b/drivers
.
Signed-off-by: Pali Rohár
---
drivers/pci/controller/pci-aardvark.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/pci/controller/pci-aardvark.c
b/drivers/pci/controller/pci-aardvark.c
index 53a4cfd7d377..783a7f1f2c44 100644
--- a/drivers/pci/controller/pci-aardvark.c
On Thursday 21 May 2020 14:35:59 Pali Rohár wrote:
> SD8997 firmware sends TLV_TYPE_MAX_CONN with struct hw_spec_max_conn to
> inform kernel about maximum number of p2p connections and stations in AP
> mode.
>
> During initialization of SD8997 wifi chip kernel prints warning:
>
On Friday 29 May 2020 09:11:08 Ganapathi Bhat wrote:
> Hi Pali,
>
> > Hello Ganapathi! Seems that on both locations is older version of
> > sdsd8997_combo_v4.bin firmware, not the latest one. On both location is
> > available just version 16.68.1.p179. But we have newer version 16.68.1.p197.
> >
On Friday 29 May 2020 08:49:18 Ganapathi Bhat wrote:
> Hi Pali,
>
> > Hello Ganapathi! Thank you for information. Can you point me to git tree or
> > location where are firmware files already updated?
>
> https://git.kernel.org/pub/scm/linux/kernel/git/firmware/linux-firmware.git
>
> or
>
>
On Friday 29 May 2020 08:43:56 Ganapathi Bhat wrote:
> Hi Pali,
>
> > According to publicly available information, firmware for these W8xxx
> > Marvell wifi chips is vulnerable to security issue CVE-2019-6496 [1].
> >
> > Are you able to update firmwares to the last versions and give us some
> >
On Thursday 28 May 2020 11:49:38 Bjorn Helgaas wrote:
> On Thu, May 28, 2020 at 06:38:09PM +0200, Pali Rohár wrote:
> > On Thursday 28 May 2020 11:26:04 Bjorn Helgaas wrote:
> > > On Thu, May 28, 2020 at 04:31:41PM +0200, Pali Rohár wrote:
> > > > When t
On Thursday 28 May 2020 11:26:04 Bjorn Helgaas wrote:
> On Thu, May 28, 2020 at 04:31:41PM +0200, Pali Rohár wrote:
> > When there is no PCIe card connected and advk_pcie_rd_conf() or
> > advk_pcie_wr_conf() is called for PCI bus which doesn't belong to emulated
> > root
registers of disconnected card is not possible.
Extend check in advk_pcie_valid_device() function for validating
availability of PCIe bus. If PCIe link is down, then the device is marked
as Not Found and the driver does not try to access these registers.
Signed-off-by: Pali Rohár
---
drivers/pci
On Saturday 16 May 2020 08:17:17 Ganapathi Bhat wrote:
> Hi Pali,
>
> Thanks for this notice. We will try to push the new firmware and also, fix
> the naming problem.
>
> Regards,
> Ganapathi
Hello Ganapathi!
According to publicly available information, firmware for these W8xxx
Marvell wifi
On Thursday 21 May 2020 14:34:44 Pali Rohár wrote:
> During initialization of SD8997 wifi chip kernel prints warnings:
>
> mwifiex_sdio mmc0:0001:1: Unknown api_id: 3
> mwifiex_sdio mmc0:0001:1: Unknown api_id: 4
>
> This patch adds support for parsing all api ids
SDIO non-combo cards are not handled by mmc_block driver and do not have
accessible CID register which is used for MMC_NAME= construction.
Signed-off-by: Pali Rohár
Reviewed-by: Marek Behún
---
Changes in V2:
* Use early returns pattern
---
drivers/mmc/core/bus.c | 7 +++
1 file changed
opers to debug whole
SDIO card as e.g. kernel mmc quirks use device/vendor ids from Common CIS
and not from particular SDIO function. Also it allows to write userspace
applications which list all connected SDIO cards based on CIS ids.
Signed-off-by: Pali Rohár
Reviewed-by: Marek Behún
---
C
On Wednesday 27 May 2020 09:39:50 Ulf Hansson wrote:
> On Tue, 26 May 2020 at 17:43, Pali Rohár wrote:
> >
> > Device/vendor ids from Common CIS (Card Information Structure) may be
> > different as device/vendor ids from CIS on particular SDIO function.
> >
> >
On Tuesday 26 May 2020 21:16:28 Andrew F. Davis wrote:
> On 5/25/20 7:32 AM, Krzysztof Kozlowski wrote:
> > This reverts commit 8cfaaa811894a3ae2d7360a15a6cfccff3ebc7db.
> >
> > If device was unbound and bound, the polling interval would be set to 0.
> > This is both unexpected and messes up with
ected SDIO and SD combo cards.
Signed-off-by: Pali Rohár
Reviewed-by: Marek Behún
---
drivers/mmc/core/bus.c | 7 +++
drivers/mmc/core/sd.c | 26 +-
drivers/mmc/core/sdio.c | 20 +++-
3 files changed, 51 insertions(+), 2 deletions(-)
diff --git
SDIO non-combo cards are not handled by mmc_block driver and do not have
accessible CID register which is used for MMC_NAME= construction.
Signed-off-by: Pali Rohár
Reviewed-by: Marek Behún
---
drivers/mmc/core/bus.c | 23 ++-
1 file changed, 14 insertions(+), 9 deletions
Define appropriate macro names for consistency with other Marvell macros.
Signed-off-by: Pali Rohár
---
drivers/bluetooth/btmrvl_sdio.c | 18 +-
include/linux/mmc/sdio_ids.h| 8
2 files changed, 17 insertions(+), 9 deletions(-)
diff --git a/drivers/bluetooth
Fix ordering of SDIO IDs to conform to the comment above, which says vendor
first, device next.
Signed-off-by: Pali Rohár
---
include/linux/mmc/sdio_ids.h | 43 ++--
1 file changed, 22 insertions(+), 21 deletions(-)
diff --git a/include/linux/mmc/sdio_ids.h b
Add _WLAN suffix to macro names for consistency with other Marvell macros.
These IDs represents wlan function of combo bt/wlan cards. Other functions
of these cards have different IDs.
Signed-off-by: Pali Rohár
---
drivers/net/wireless/marvell/mwifiex/sdio.c | 38 +
include
Add underscore as separator in Marvell 8688 macro names for better
readability and consistency.
Signed-off-by: Pali Rohár
---
drivers/net/wireless/marvell/libertas/if_sdio.c | 2 +-
include/linux/mmc/sdio_ids.h| 4 ++--
2 files changed, 3 insertions(+), 3 deletions(-)
diff
Also replace generic MANUFACTURER macros by proper SDIO IDs macros.
Check for "AR6003 or later" is slightly modified to use SDIO device IDs.
This allows removal of all custom MANUFACTURER macros from ath6kl.
Signed-off-by: Pali Rohár
---
drivers/net/wireless/ath/ath6kl/h
Also replace generic MANUFACTURER macros by proper SDIO IDs macros.
Checks for device IDs are slightly modified to use SDIO device IDs.
This allows removal of all custom MANUFACTURER macros from ath10k.
Signed-off-by: Pali Rohár
---
drivers/net/wireless/ath/ath10k/sdio.c | 25
-by: Pali Rohár
---
drivers/mmc/core/quirks.h| 2 +-
include/linux/mmc/sdio_ids.h | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/mmc/core/quirks.h b/drivers/mmc/core/quirks.h
index 3dba15bccce2..472fa2fdcf13 100644
--- a/drivers/mmc/core/quirks.h
+++ b/drivers/mmc
Define appropriate macro names for consistency with other macros.
Signed-off-by: Pali Rohár
---
drivers/net/wireless/broadcom/b43/sdio.c | 4 ++--
include/linux/mmc/sdio_ids.h | 4
2 files changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/broadcom/b43
Define appropriate macro names for consistency with other Siano macros.
Signed-off-by: Pali Rohár
---
drivers/media/mmc/siano/smssdio.c | 10 +-
include/linux/mmc/sdio_ids.h | 5 +
2 files changed, 10 insertions(+), 5 deletions(-)
diff --git a/drivers/media/mmc/siano
to be
consistent with all other values.
Signed-off-by: Pali Rohár
---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/bcmsdh.c | 6 +++---
drivers/net/wireless/broadcom/brcm80211/brcmfmac/sdio.c | 4 ++--
include/linux/mmc/sdio_ids.h | 6 +++---
3 files changed, 8 insertions
Define appropriate macro names for consistency with other macros.
Signed-off-by: Pali Rohár
---
drivers/bluetooth/btmtksdio.c | 4 ++--
include/linux/mmc/sdio_ids.h | 2 ++
2 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/bluetooth/btmtksdio.c b/drivers/bluetooth
to the common include file.
Also some macro names are changed to follow existing naming conventions.
Pali Rohár (11):
mmc: sdio: Fix macro name for Marvell device with ID 0x9134
mmc: sdio: Change macro names for Marvell 8688 modules
mmc: sdio: Move SDIO IDs from mwifiex driver to common include
support for parsing TLV_TYPE_MAX_CONN (0x217) and sets
appropriate cfg80211 member 'max_ap_assoc_sta' from retrieved structure.
It allows userspace to retrieve NL80211_ATTR_MAX_AP_ASSOC_STA attribute.
Signed-off-by: Pali Rohár
---
drivers/net/wireless/marvell/mwifiex/cfg80211.c | 5
During initialization of SD8997 wifi chip kernel prints warnings:
mwifiex_sdio mmc0:0001:1: Unknown api_id: 3
mwifiex_sdio mmc0:0001:1: Unknown api_id: 4
This patch adds support for parsing all api ids provided by SD8997
firmware.
Signed-off-by: Pali Rohár
---
drivers/net/wireless/marvell
They are already present in linux/mmc/sdio_ids.h.
Signed-off-by: Pali Rohár
---
drivers/net/wireless/st/cw1200/cw1200_sdio.c | 9 +
1 file changed, 1 insertion(+), 8 deletions(-)
diff --git a/drivers/net/wireless/st/cw1200/cw1200_sdio.c
b/drivers/net/wireless/st/cw1200/cw1200_sdio.c
> to avoid duplicate events.
>
> Signed-off-by: Hans de Goede
Looks good, you can add my:
Acked-by: Pali Rohár
> ---
> drivers/platform/x86/dell-wmi.c | 10 ++
> 1 file changed, 10 insertions(+)
>
> diff --git a/drivers/platform/x86/dell-wmi.c b/drivers/platform/x86/d
On Monday 18 May 2020 14:13:48 Thomas Gleixner wrote:
> Pali Rohár writes:
> > On Monday 18 May 2020 13:26:14 Thomas Gleixner wrote:
> >> System clock shifted by one hour? You mean DST change?
> >
> > Yes, clock was shifted by one hour.
> >
> >&
On Monday 18 May 2020 13:26:14 Thomas Gleixner wrote:
> Pali Rohár writes:
> > On Saturday 09 May 2020 11:49:27 Thomas Gleixner wrote:
> >> Sure, but what's the problem? The adjustemt is done to make the observed
> >> time as correct as possible.
> >
> > Y
On Saturday 09 May 2020 11:49:27 Thomas Gleixner wrote:
> Pali,
>
> Pali Rohár writes:
> > On Friday 08 May 2020 22:59:57 Thomas Gleixner wrote:
> >> Pali Rohár writes:
> >> Neither CLOCK_BOOTTIME nor CLOCK_MONOTONIC jump. They are frequency
> >>
301 - 400 of 4324 matches
Mail list logo
