Re: [PATCH 10/11] block: xen-blkfront: Demote kernel-doc abuses

2021-04-06 Thread Roger Pau Monné
mber > 'dev' not described in 'blkfront_resume' > drivers/block/xen-blkfront.c:2085: warning: expecting prototype for or a > backend(). Prototype was for blkfront_resume() instead > drivers/block/xen-blkfront.c:2444: warning: wrong kernel-doc identifier on > line: > > Cc: Konrad Rzes

[PATCH v3] intel/pinctrl: check REVID register value for device presence

2021-03-25 Thread Roger Pau Monne
to features') Suggested-by: Andy Shevchenko Signed-off-by: Roger Pau Monné --- Changes since v2: - Return ENODEV. - Adjust code comment. Changes since v1: - New in this version. --- Cc: Mika Westerberg Cc: Andy Shevchenko Cc: Linus Walleij Cc: linux-g...@vger.kernel.org --- drivers/pinctrl

Re: [PATCH RESEND] intel/pinctrl: check capability offset is between MMIO region

2021-03-25 Thread Roger Pau Monné
On Wed, Mar 24, 2021 at 06:57:12PM +0200, Andy Shevchenko wrote: > On Wed, Mar 24, 2021 at 04:13:59PM +0100, Roger Pau Monné wrote: > > On Wed, Mar 24, 2021 at 04:22:44PM +0200, Andy Shevchenko wrote: > > > On Wed, Mar 24, 2021 at 02:55:15PM +0100, Roger Pau Monné wrote: >

Re: [PATCH v2 1/2] intel/pinctrl: check REVID register value for device presence

2021-03-25 Thread Roger Pau Monné
On Wed, Mar 24, 2021 at 07:01:18PM +0200, Andy Shevchenko wrote: > On Wed, Mar 24, 2021 at 04:43:11PM +0100, Roger Pau Monne wrote: > > Thanks for a fix! My comments below. > > > Use the value read from the REVID register in order to check for the > > presence of the de

[PATCH v2 2/2] intel/pinctrl: check capability offset is between MMIO region

2021-03-24 Thread Roger Pau Monne
: 91d898e51e60 ('pinctrl: intel: Convert capability list to features') Signed-off-by: Roger Pau Monné --- Changes since v1: - Adjust commit message. --- Cc: Mika Westerberg Cc: Andy Shevchenko Cc: Linus Walleij Cc: linux-g...@vger.kernel.org --- drivers/pinctrl/intel/pinctrl-intel.c | 14 +- 1

[PATCH v2 1/2] intel/pinctrl: check REVID register value for device presence

2021-03-24 Thread Roger Pau Monne
and hence contains the pinctrl devices, but the MMIO region(s) containing the device registers might not be mapped in the guest physical memory map if such region(s) are not exposed on a PCI device BAR or marked as reserved in the host memory map. Suggested-by: Andy Shevchenko Signed-off-by: Roger Pau

[PATCH v2 0/2] intel/pinctrl: check some registers reads

2021-03-24 Thread Roger Pau Monne
Hello, The following series adds some consistency checks to the values returned by some of the MMIO registers of the Intel pinctrl device. That done to avoid a crash when running as a PVH dom0. See patch #1 for more details. Thanks, Roger. Roger Pau Monne (2): intel/pinctrl: check REVID

Re: [PATCH RESEND] intel/pinctrl: check capability offset is between MMIO region

2021-03-24 Thread Roger Pau Monné
On Wed, Mar 24, 2021 at 04:22:44PM +0200, Andy Shevchenko wrote: > On Wed, Mar 24, 2021 at 02:55:15PM +0100, Roger Pau Monné wrote: > > On Wed, Mar 24, 2021 at 02:58:07PM +0200, Andy Shevchenko wrote: > > > On Wed, Mar 24, 2021 at 01:31:18PM +0100, Roger Pau Monne wrote: > &

Re: [PATCH RESEND] intel/pinctrl: check capability offset is between MMIO region

2021-03-24 Thread Roger Pau Monné
On Wed, Mar 24, 2021 at 02:58:07PM +0200, Andy Shevchenko wrote: > On Wed, Mar 24, 2021 at 01:31:18PM +0100, Roger Pau Monne wrote: > > When parsing the capability list make sure the offset is between the > > MMIO region mapped in 'regs', or else the kernel hits a page fault. >

[PATCH RESEND] intel/pinctrl: check capability offset is between MMIO region

2021-03-24 Thread Roger Pau Monne
region is not properly reported. Fixes: 91d898e51e60 ('pinctrl: intel: Convert capability list to features') Signed-off-by: Roger Pau Monné --- Cc: Mika Westerberg Cc: Andy Shevchenko Cc: Linus Walleij Cc: linux-g...@vger.kernel.org --- Resend because I've missed adding the maintainers, sorry

[PATCH v2 1/2] xen/x86: make XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on MEMORY_HOTPLUG

2021-03-24 Thread Roger Pau Monne
limitation of the p2m. Rename the option to XEN_MEMORY_HOTPLUG_LIMIT since it's no longer tied to ballooning. Fixes: 9e2369c06c8a18 ("xen: add helpers to allocate unpopulated memory") Signed-off-by: Roger Pau Monné --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: Jan B

[PATCH v2 2/2] Revert "xen: fix p2m size in dom0 for disabled memory hotplug case"

2021-03-24 Thread Roger Pau Monne
already trigger a properly sized p2m on Xen PV. Note that XEN_UNPOPULATED_ALLOC depends on ZONE_DEVICE which pulls in MEMORY_HOTPLUG. Leave the check added to __set_phys_to_machine and the adjusted comment about EXTRA_MEM_RATIO. Signed-off-by: Roger Pau Monné --- Cc: Boris Ostrovsky Cc: Juergen

[PATCH v2 0/2] xen/x86: alternative fix for XSA-369

2021-03-24 Thread Roger Pau Monne
XEN_BALLOON_MEMORY_HOTPLUG is disabled with XEN_UNPOPULATED_ALLOC. Thanks, Roger. Roger Pau Monne (2): xen/x86: make XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on MEMORY_HOTPLUG Revert "xen: fix p2m size in dom0 for disabled memory hotplug case" arch/x86/include/asm/xen/page.h | 12 ar

[PATCH] intel/pinctrl: check capability offset is between MMIO region

2021-03-24 Thread Roger Pau Monne
region is not properly reported. Fixes: 91d898e51e60 ('pinctrl: intel: Convert capability list to features') Signed-off-by: Roger Pau Monné --- drivers/pinctrl/intel/pinctrl-intel.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/intel/pinctrl

[PATCH 2/2] Revert "xen: fix p2m size in dom0 for disabled memory hotplug case"

2021-03-17 Thread Roger Pau Monne
already trigger a properly sized p2m on Xen PV. Leave the check added to __set_phys_to_machine. Signed-off-by: Roger Pau Monné --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: Jan Beulich Cc: xen-de...@lists.xenproject.org --- arch/x86/include/asm/xen/page.h | 12

[PATCH 1/2] xen/x86: make XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on MEMORY_HOTPLUG

2021-03-17 Thread Roger Pau Monne
limitation of the p2m. Rename the option to XEN_MEMORY_HOTPLUG_LIMIT since it's no longer tied to ballooning. Fixes: 9e2369c06c8a18 ("xen: add helpers to allocate unpopulated memory") Signed-off-by: Roger Pau Monné --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: Jan B

[PATCH 0/2] xen/x86: alternative fix for XSA-369

2021-03-17 Thread Roger Pau Monne
XEN_BALLOON_MEMORY_HOTPLUG is disabled with XEN_UNPOPULATED_ALLOC. Thanks, Roger. Roger Pau Monne (2): xen/x86: make XEN_BALLOON_MEMORY_HOTPLUG_LIMIT depend on MEMORY_HOTPLUG Revert "xen: fix p2m size in dom0 for disabled memory hotplug case" arch/x86/include/asm/xen/page.h | 12 ar

Re: [PATCH v3 5/8] xen/events: link interdomain events to associated xenbus device

2021-02-22 Thread Roger Pau Monné
Liu > Reviewed-by: Paul Durrant > --- > drivers/block/xen-blkback/xenbus.c | 2 +- Reviewed-by: Roger Pau Monné Thanks, Roger.

Re: [PATCH v2] xen-blkback: fix compatibility bug with single page rings

2021-02-02 Thread Roger Pau Monné
the stale > 'ring-ref0' left around by the previous frontend will try to map the wrong > grant reference. > > This patch restores the original behaviour. > > Fixes: 4a8c31a1c6f5 ("xen/blkback: rework connect_ring() to avoid > inconsistent xenstore 'ring-page-order' set

Re: [PATCH v2] xen-blkfront: allow discard-* nodes to be optional

2021-01-20 Thread Roger Pau Monné
On Wed, Jan 20, 2021 at 03:37:57PM +0100, Jan Beulich wrote: > On 20.01.2021 15:35, Roger Pau Monné wrote: > > On Wed, Jan 20, 2021 at 03:23:30PM +0100, Arthur Borsboom wrote: > >> Hi Roger, > >> > >> I have set up a test environment based on Linux 5.11.0-rc4

Re: [PATCH v2] xen-blkfront: allow discard-* nodes to be optional

2021-01-20 Thread Roger Pau Monné
se also, since I know the xenstore keys. I think it's possible your email client has mangled the patch, I'm attaching the same patch to this email, could you try to apply it again and report back? (this time it should apply cleanly) Thanks, Roger. >From f09acedb2e40fa84f31cfe4c960dea2037d06e3f Mon

Re: [PATCH v2] xen-blkfront: allow discard-* nodes to be optional

2021-01-19 Thread Roger Pau Monné
Forgot to Cc stable for the Fixes tag. Doing it now. On Tue, Jan 19, 2021 at 11:57:27AM +0100, Roger Pau Monne wrote: > This is inline with the specification described in blkif.h: > > * discard-granularity: should be set to the physical block size if >node is not present.

[PATCH v2] xen-blkfront: allow discard-* nodes to be optional

2021-01-19 Thread Roger Pau Monne
: ed30bf317c5ce ('xen-blkfront: Handle discard requests.') Reported-by: Arthur Borsboom Signed-off-by: Roger Pau Monné --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: Konrad Rzeszutek Wilk Cc: "Roger Pau Monné" Cc: Jens Axboe Cc: xen-de...@lists.xenproject.org Cc

Re: [PATCH] xen-blkfront: don't make discard-alignment mandatory

2021-01-19 Thread Roger Pau Monné
On Tue, Jan 19, 2021 at 11:11:26AM +0100, Jürgen Groß wrote: > On 19.01.21 11:06, Roger Pau Monné wrote: > > On Tue, Jan 19, 2021 at 08:43:01AM +0100, Jürgen Groß wrote: > > > On 18.01.21 16:15, Roger Pau Monne wrote: > > > > Don't require the discard-alignme

Re: [PATCH] xen-blkfront: don't make discard-alignment mandatory

2021-01-19 Thread Roger Pau Monné
On Tue, Jan 19, 2021 at 08:43:01AM +0100, Jürgen Groß wrote: > On 18.01.21 16:15, Roger Pau Monne wrote: > > Don't require the discard-alignment xenstore node to be present in > > order to correctly setup the feature. This can happen with versions of > > QEMU that o

[PATCH] xen-blkfront: don't make discard-alignment mandatory

2021-01-18 Thread Roger Pau Monne
to not enable the discard feature if discard-granularity is not present. Reported-by: Arthur Borsboom Signed-off-by: Roger Pau Monné --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: Konrad Rzeszutek Wilk Cc: "Roger Pau Monné" Cc: Jens Axboe

[PATCH v2] xen/privcmd: allow fetching resource sizes

2021-01-12 Thread Roger Pau Monne
implementation, and causes issues when mapping resources that don't have fixed or known sizes. Signed-off-by: Roger Pau Monné Cc: sta...@vger.kernel.org # >= 4.18 --- NB: fetching the size of a resource shouldn't trigger an hypercall preemption, and hence I've dropped the preempt indicati

Re: [PATCH] xen/privcmd: allow fetching resource sizes

2021-01-12 Thread Roger Pau Monné
On Tue, Jan 12, 2021 at 06:57:30AM +0100, Jürgen Groß wrote: > On 11.01.21 16:29, Roger Pau Monne wrote: > > Allow issuing an IOCTL_PRIVCMD_MMAP_RESOURCE ioctl with num = 0 and > > addr = 0 in order to fetch the size of a specific resource. > > > > Add a shortcut to th

[PATCH] xen/privcmd: allow fetching resource sizes

2021-01-11 Thread Roger Pau Monne
/privcmd: add IOCTL_PRIVCMD_MMAP_RESOURCE') Signed-off-by: Roger Pau Monné --- NB: fetching the size of a resource shouldn't trigger an hypercall preemption, and hence I've dropped the preempt indications. --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: Paul Durrant Cc: xen-de

Re: [PATCH] xen: fix: use WARN_ON instead of if condition followed by BUG.

2020-12-30 Thread Roger Pau Monné
On Wed, Dec 30, 2020 at 02:38:06PM +0800, YANG LI wrote: > Use WARN_ON instead of if condition followed by BUG in > gnttab_batch_map() and gnttab_batch_copy(). But those are not equivalent as far as I'm aware. BUG will stop execution, while WARN_ON will print a splat and continue executing. If

Re: [PATCH 2/2] xen: don't use page->lru for ZONE_DEVICE memory

2020-12-10 Thread Roger Pau Monné
ache_enq? > > No, I don't think so. At least in the CONFIG_ZONE_DEVICE case the > initial list in a PV dom0 is populated from extra memory (basically > the same, but not marked as zone device memory explicitly). I assume it's fine for us to then use page->zone_device_data even if the page is not explicitly marked as ZONE_DEVICE memory? If that's fine, add my: Acked-by: Roger Pau Monné To both patches, and thank you very much for fixing this! Roger.

Re: [PATCH v3 3/6] mm: support THP migration to device private memory

2020-12-05 Thread Roger Pau Monné
On Wed, Dec 02, 2020 at 11:08:54AM +0100, Christoph Hellwig wrote: > On Fri, Nov 20, 2020 at 04:01:33PM -0400, Jason Gunthorpe wrote: > > On Wed, Nov 11, 2020 at 03:38:42PM -0800, Ralph Campbell wrote: > > > > > MEMORY_DEVICE_GENERIC: > > > Struct pages are created in dev_dax_probe() and

Re: [PATCH 058/141] xen-blkfront: Fix fall-through warnings for Clang

2020-11-23 Thread Roger Pau Monné
On Fri, Nov 20, 2020 at 12:32:58PM -0600, Gustavo A. R. Silva wrote: > In preparation to enable -Wimplicit-fallthrough for Clang, fix a warning > by explicitly adding a break statement instead of letting the code fall > through to the next case. > > Link: https://github.com/KSPP/linux/issues/115

Re: [PATCH 1/2] xen: Remove Xen PVH/PVHVM dependency on PCI

2020-10-15 Thread Roger Pau Monné
On Thu, Oct 15, 2020 at 05:02:21PM +0200, Jan Beulich wrote: > On 15.10.2020 16:59, Jason Andryuk wrote: > > On Thu, Oct 15, 2020 at 4:10 AM Jan Beulich wrote: > >> > >> On 14.10.2020 19:53, Jason Andryuk wrote: > >>> @@ -76,7 +80,9 @@ config XEN_DEBUG_FS > >>> Enabling this option may

Re: [PATCH 2/2] xen/blkback: turn the cache purge percent into a parameter

2020-10-15 Thread Roger Pau Monné
On Thu, Oct 15, 2020 at 04:37:52PM +0200, Jürgen Groß wrote: > On 15.10.20 16:24, Roger Pau Monne wrote: > > Assume that reads and writes to the variable will be atomic. The worse > > that could happen is that one of the purges removes a partially > > written percentage of

[PATCH 2/2] xen/blkback: turn the cache purge percent into a parameter

2020-10-15 Thread Roger Pau Monne
Assume that reads and writes to the variable will be atomic. The worse that could happen is that one of the purges removes a partially written percentage of grants, but the cache itself will recover. Signed-off-by: Roger Pau Monné --- Cc: Konrad Rzeszutek Wilk Cc: Jens Axboe Cc: Boris

[PATCH 1/2] xen/blkback: turn the cache purge LRU interval into a parameter

2020-10-15 Thread Roger Pau Monne
Assume that reads and writes to the variable will be atomic. The worse that could happen is that one of the LRU intervals is not calculated properly if a partially written value is read, but that would only be a transient issue. Signed-off-by: Roger Pau Monné --- Cc: Konrad Rzeszutek Wilk Cc

[PATCH 0/2] xen/blkback: add LRU purge parameters

2020-10-15 Thread Roger Pau Monne
Add the LRU parameters as tunables. Roger Pau Monne (2): xen/blkback: turn the cache purge LRU interval into a parameter xen/blkback: turn the cache purge percent into a parameter .../ABI/testing/sysfs-driver-xen-blkback | 19 +++ drivers/block/xen-blkback/blkback.c

Re: [PATCH] xen-blkback: add a parameter for disabling of persistent grants

2020-09-24 Thread Roger Pau Monné
On Thu, Sep 24, 2020 at 12:27:14PM +0200, SeongJae Park wrote: > On Thu, 24 Sep 2020 12:13:44 +0200 "Roger Pau Monné" > wrote: > > > On Wed, Sep 23, 2020 at 04:09:30PM -0400, Konrad Rzeszutek Wilk wrote: > > > On Tue, Sep 22, 2020 at 09:01:25AM +0200, SeongJae

Re: [PATCH] xen-blkback: add a parameter for disabling of persistent grants

2020-09-24 Thread Roger Pau Monné
On Wed, Sep 23, 2020 at 04:09:30PM -0400, Konrad Rzeszutek Wilk wrote: > On Tue, Sep 22, 2020 at 09:01:25AM +0200, SeongJae Park wrote: > > From: SeongJae Park > > > > Persistent grants feature provides high scalability. On some small > > systems, however, it could incur data copy overhead[1]

Re: [PATCH v3 0/3] xen-blk(back|front): Let users disable persistent grants

2020-09-22 Thread Roger Pau Monné
tion to disable it. For > the reason, this commit adds module parameters for disabling of the > feature. With the changes requested by Jürgen you can add my: Acked-by: Roger Pau Monné Thanks, Roger.

Re: [PATCH v3 3/3] xen-blkfront: Apply changed parameter name to the document

2020-09-22 Thread Roger Pau Monné
On Tue, Sep 22, 2020 at 04:27:39PM +0200, Jürgen Groß wrote: > On 22.09.20 16:15, SeongJae Park wrote: > > From: SeongJae Park > > > > Commit 14e710fe7897 ("xen-blkfront: rename indirect descriptor > > parameter") changed the name of the module parameter for the maximum > > amount of segments in

Re: [PATCH v2 1/3] xen-blkback: add a parameter for disabling of persistent grants

2020-09-22 Thread Roger Pau Monné
On Tue, Sep 22, 2020 at 01:26:38PM +0200, SeongJae Park wrote: > On Tue, 22 Sep 2020 13:12:59 +0200 "Roger Pau Monné" > wrote: > > > On Tue, Sep 22, 2020 at 12:52:07PM +0200, SeongJae Park wrote: > > > From: SeongJae Park > > > > > >

Re: [PATCH v2 1/3] xen-blkback: add a parameter for disabling of persistent grants

2020-09-22 Thread Roger Pau Monné
On Tue, Sep 22, 2020 at 12:52:07PM +0200, SeongJae Park wrote: > From: SeongJae Park > > Persistent grants feature provides high scalability. On some small > systems, however, it could incur data copy overheads[1] and thus it is > required to be disabled. But, there is no option to disable it.

Re: [PATCH] xen-blkback: add a parameter for disabling of persistent grants

2020-09-22 Thread Roger Pau Monné
On Tue, Sep 22, 2020 at 09:01:25AM +0200, SeongJae Park wrote: > From: SeongJae Park > > Persistent grants feature provides high scalability. On some small > systems, however, it could incur data copy overhead[1] and thus it is > required to be disabled. But, there is no option to disable it.

Re: linux-next: build failure after merge of the akpm-current tree

2020-09-09 Thread Roger Pau Monné
On Tue, Sep 08, 2020 at 08:09:50PM +1000, Stephen Rothwell wrote: > Hi all, > > After merging the akpm-current tree, today's linux-next build (x86_64 > allmodconfig) failed like this: > > drivers/xen/unpopulated-alloc.c: In function 'fill_list': > drivers/xen/unpopulated-alloc.c:30:9: error:

Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory

2020-09-04 Thread Roger Pau Monné
On Fri, Sep 04, 2020 at 09:00:18AM +0200, Jürgen Groß wrote: > On 03.09.20 18:38, Roger Pau Monné wrote: > > On Thu, Sep 03, 2020 at 05:30:07PM +0200, Jürgen Groß wrote: > > > On 01.09.20 10:33, Roger Pau Monne wrote: > > > > To be used in order to create f

Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory

2020-09-03 Thread Roger Pau Monné
On Thu, Sep 03, 2020 at 05:30:07PM +0200, Jürgen Groß wrote: > On 01.09.20 10:33, Roger Pau Monne wrote: > > To be used in order to create foreign mappings. This is based on the > > ZONE_DEVICE facility which is used by persistent memory devices in > > order to create st

Re: [PATCH v5 3/3] xen: add helpers to allocate unpopulated memory

2020-09-01 Thread Roger Pau Monné
On Tue, Sep 01, 2020 at 10:33:26AM +0200, Roger Pau Monne wrote: > +static int fill_list(unsigned int nr_pages) > +{ > + struct dev_pagemap *pgmap; > + void *vaddr; > + unsigned int i, alloc_pages = round_up(nr_pages, PAGES_PER_SECTION); > + int nid, ret;

[PATCH v5 2/3] memremap: rename MEMORY_DEVICE_DEVDAX to MEMORY_DEVICE_GENERIC

2020-09-01 Thread Roger Pau Monne
This is in preparation for the logic behind MEMORY_DEVICE_DEVDAX also being used by non DAX devices. No functional change intended. Signed-off-by: Roger Pau Monné Reviewed-by: Ira Weiny Acked-by: Andrew Morton --- Cc: Dan Williams Cc: Vishal Verma Cc: Dave Jiang Cc: Andrew Morton Cc

[PATCH v5 3/3] xen: add helpers to allocate unpopulated memory

2020-09-01 Thread Roger Pau Monne
on some platforms. Signed-off-by: Roger Pau Monné --- Cc: Oleksandr Andrushchenko Cc: David Airlie Cc: Daniel Vetter Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: Dan Carpenter Cc: Roger Pau Monne Cc: Wei Liu Cc: Yan Yankovskyi Cc: dri-de...@lists.freedesktop.org Cc

[PATCH v5 0/3] xen/balloon: fixes for memory hotplug

2020-09-01 Thread Roger Pau Monne
due to Arm using an identity map for dom0 p2m and thus needing special handling. Thanks, Roger. Roger Pau Monne (3): xen/balloon: add header guard memremap: rename MEMORY_DEVICE_DEVDAX to MEMORY_DEVICE_GENERIC xen: add helpers to allocate unpopulated memory drivers/dax/device.c

[PATCH v5 1/3] xen/balloon: add header guard

2020-09-01 Thread Roger Pau Monne
In order to protect against the header being included multiple times on the same compilation unit. Signed-off-by: Roger Pau Monné Reviewed-by: Boris Ostrovsky --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: xen-de...@lists.xenproject.org --- This is required as a pre

Re: [PATCH v4 1/2] memremap: rename MEMORY_DEVICE_DEVDAX to MEMORY_DEVICE_GENERIC

2020-08-31 Thread Roger Pau Monné
On Thu, Aug 20, 2020 at 01:37:41PM +0200, Roger Pau Monné wrote: > On Tue, Aug 11, 2020 at 11:07:36PM +0200, David Hildenbrand wrote: > > On 11.08.20 11:44, Roger Pau Monne wrote: > > > This is in preparation for the logic behind MEMORY_DEVICE_DEVDAX also > > > be

Re: [PATCH] efi: discover ESRT table on Xen PV too

2020-08-20 Thread Roger Pau Monné
On Wed, Aug 19, 2020 at 01:33:39PM +0200, Norbert Kaminski wrote: > > On 19.08.2020 10:19, Roger Pau Monné wrote: > > On Tue, Aug 18, 2020 at 08:40:18PM +0200, Marek Marczykowski-Górecki wrote: > > > On Tue, Aug 18, 2020 at 07:21:14PM +0200, Roger Pau Monné wrote:

Re: [PATCH] efi: discover ESRT table on Xen PV too

2020-08-20 Thread Roger Pau Monné
On Thu, Aug 20, 2020 at 11:34:54AM +0200, Marek Marczykowski-Górecki wrote: > On Thu, Aug 20, 2020 at 11:30:25AM +0200, Roger Pau Monné wrote: > > Right, so you only need access to the ESRT table, that's all. Then I > > think we need to make sure Xen doesn't use this memory for an

Re: [PATCH] efi: discover ESRT table on Xen PV too

2020-08-19 Thread Roger Pau Monné
On Tue, Aug 18, 2020 at 08:40:18PM +0200, Marek Marczykowski-Górecki wrote: > On Tue, Aug 18, 2020 at 07:21:14PM +0200, Roger Pau Monné wrote: > > > Let me draw the picture from the beginning. > > > > Thanks, greatly appreciated. > > > > > EFI memory ma

Re: [PATCH] efi: discover ESRT table on Xen PV too

2020-08-18 Thread Roger Pau Monné
On Tue, Aug 18, 2020 at 05:00:20PM +0200, Marek Marczykowski-Górecki wrote: > On Tue, Aug 18, 2020 at 02:47:10PM +0200, Roger Pau Monné wrote: > > On Tue, Aug 18, 2020 at 02:01:35PM +0200, Marek Marczykowski-Górecki wrote: > > > Do you mean PV dom0 should receive full EFI memor

Re: [PATCH] efi: discover ESRT table on Xen PV too

2020-08-18 Thread Roger Pau Monné
On Tue, Aug 18, 2020 at 02:01:35PM +0200, Marek Marczykowski-Górecki wrote: > On Mon, Aug 17, 2020 at 11:00:13AM +0200, Roger Pau Monné wrote: > > On Sun, Aug 16, 2020 at 02:19:49AM +0200, Marek Marczykowski-Górecki wrote: > > > In case of Xen PV dom0, Xen passes along info a

Re: [PATCH] efi: discover ESRT table on Xen PV too

2020-08-17 Thread Roger Pau Monné
On Sun, Aug 16, 2020 at 02:19:49AM +0200, Marek Marczykowski-Górecki wrote: > In case of Xen PV dom0, Xen passes along info about system tables (see > arch/x86/xen/efi.c), but not the memory map from EFI. I think that's because the memory map returned by XENMEM_machine_memory_map is in e820 form,

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

2020-08-14 Thread Roger Pau Monné
On Fri, Aug 14, 2020 at 02:54:38PM +0200, Jürgen Groß wrote: > On 14.08.20 14:47, Roger Pau Monné wrote: > > On Fri, Aug 14, 2020 at 12:27:32PM +0200, Jürgen Groß wrote: > > > On 14.08.20 11:56, Roger Pau Monné wrote: > > > > On Fri, Aug 14, 2020 at 08:29:20AM

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

2020-08-14 Thread Roger Pau Monné
On Fri, Aug 14, 2020 at 12:27:32PM +0200, Jürgen Groß wrote: > On 14.08.20 11:56, Roger Pau Monné wrote: > > On Fri, Aug 14, 2020 at 08:29:20AM +0100, Christoph Hellwig wrote: > > > On Thu, Aug 13, 2020 at 09:54:20AM +0200, Roger Pau Monn?? wrote: > > > > On Thu, Au

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

2020-08-14 Thread Roger Pau Monné
On Fri, Aug 14, 2020 at 08:29:20AM +0100, Christoph Hellwig wrote: > On Thu, Aug 13, 2020 at 09:54:20AM +0200, Roger Pau Monn?? wrote: > > On Thu, Aug 13, 2020 at 08:33:37AM +0100, Christoph Hellwig wrote: > > > On Tue, Aug 11, 2020 at 11:44:47AM +0200, Roger Pau Monne wrote:

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

2020-08-13 Thread Roger Pau Monné
: > On Thu, Aug 13, 2020 at 09:54:20AM +0200, Roger Pau Monné wrote: > > On Thu, Aug 13, 2020 at 08:33:37AM +0100, Christoph Hellwig wrote: > > > On Tue, Aug 11, 2020 at 11:44:47AM +0200, Roger Pau Monne wrote: > > > > If enabled (because ZONE_DEVICE is supported) the usage of

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

2020-08-13 Thread Roger Pau Monné
On Thu, Aug 13, 2020 at 08:33:37AM +0100, Christoph Hellwig wrote: > On Tue, Aug 11, 2020 at 11:44:47AM +0200, Roger Pau Monne wrote: > > If enabled (because ZONE_DEVICE is supported) the usage of the new > > functionality untangles Xen balloon and RAM hotplug from the usage of

Re: [PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

2020-08-12 Thread Roger Pau Monné
On Wed, Aug 12, 2020 at 09:28:45AM +0200, Jürgen Groß wrote: > On 11.08.20 11:44, Roger Pau Monne wrote: > > To be used in order to create foreign mappings. This is based on the > > ZONE_DEVICE facility which is used by persistent memory devices in > > order to create st

[PATCH v4 1/2] memremap: rename MEMORY_DEVICE_DEVDAX to MEMORY_DEVICE_GENERIC

2020-08-11 Thread Roger Pau Monne
This is in preparation for the logic behind MEMORY_DEVICE_DEVDAX also being used by non DAX devices. No functional change intended. Signed-off-by: Roger Pau Monné --- Cc: Dan Williams Cc: Vishal Verma Cc: Dave Jiang Cc: Andrew Morton Cc: Jason Gunthorpe Cc: Ira Weiny Cc: "Aneesh Kuma

[PATCH v4 2/2] xen: add helpers to allocate unpopulated memory

2020-08-11 Thread Roger Pau Monne
on some platforms. Signed-off-by: Roger Pau Monné --- Cc: Oleksandr Andrushchenko Cc: David Airlie Cc: Daniel Vetter Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: Dan Carpenter Cc: Roger Pau Monne Cc: Wei Liu Cc: Yan Yankovskyi Cc: dri-de...@lists.freedesktop.org Cc

[PATCH v4 0/2] xen/balloon: fixes for memory hotplug

2020-08-11 Thread Roger Pau Monne
is that MEMORY_DEVICE_DEVDAX is renamed to MEMORY_DEVICE_GENERIC, as using DEVDAX in the Xen code to allocate unpopulated memory felt wrong. Thanks, Roger. Roger Pau Monne (2): memremap: rename MEMORY_DEVICE_DEVDAX to MEMORY_DEVICE_GENERIC xen: add helpers to allocate unpopulated memory drivers/dax/device.c

Re: [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-28 Thread Roger Pau Monné
On Tue, Jul 28, 2020 at 06:12:46PM +0100, Julien Grall wrote: > Hi Roger, > > On 28/07/2020 17:59, Roger Pau Monné wrote: > > On Tue, Jul 28, 2020 at 05:48:23PM +0100, Julien Grall wrote: > > > Hi, > > > > > > On 27/07/2020 10:13, Roger Pau Monne wr

Re: [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-28 Thread Roger Pau Monné
On Tue, Jul 28, 2020 at 06:06:25PM +0100, Andrew Cooper wrote: > On 28/07/2020 17:59, Roger Pau Monné wrote: > > On Tue, Jul 28, 2020 at 05:48:23PM +0100, Julien Grall wrote: > >> Hi, > >> > >> On 27/07/2020 10:13, Roger Pau Monne wrote: > >>>

Re: [PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-28 Thread Roger Pau Monné
On Tue, Jul 28, 2020 at 05:48:23PM +0100, Julien Grall wrote: > Hi, > > On 27/07/2020 10:13, Roger Pau Monne wrote: > > To be used in order to create foreign mappings. This is based on the > > ZONE_DEVICE facility which is used by persistent memory devices in > > o

[PATCH] xen/balloon: add header guard

2020-07-28 Thread Roger Pau Monne
In order to protect against the header being included multiple times on the same compilation unit. Signed-off-by: Roger Pau Monné --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: xen-de...@lists.xenproject.org --- This is required as a pre-patch to use ZONE_DEVICE, or else

[PATCH v3 4/4] xen: add helpers to allocate unpopulated memory

2020-07-27 Thread Roger Pau Monne
hotplug from the usage of unpopulated physical memory ranges to map foreign pages, which is the correct thing to do in order to avoid mappings of foreign pages depend on memory hotplug. Signed-off-by: Roger Pau Monné --- I've not added a new memory_type type and just used MEMORY_DEVICE_DEVDAX which

[PATCH v3 2/4] xen/balloon: make the balloon wait interruptible

2020-07-27 Thread Roger Pau Monne
So it can be killed, or else processes can get hung indefinitely waiting for balloon pages. Signed-off-by: Roger Pau Monné Reviewed-by: Juergen Gross Cc: sta...@vger.kernel.org --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: xen-de...@lists.xenproject.org --- drivers

[PATCH v3 3/4] Revert "xen/balloon: Fix crash when ballooning on x86 32 bit PAE"

2020-07-27 Thread Roger Pau Monne
, as it checked the start address of the resource, but it should instead test the end address to assert the whole resource falls below MAX_PHYSMEM_BITS. Signed-off-by: Roger Pau Monné Reviewed-by: Juergen Gross --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: xen-de

[PATCH v3 0/4] xen/balloon: fixes for memory hotplug

2020-07-27 Thread Roger Pau Monne
be backported to stable branches, third patch is a revert of a workaround applied to the balloon driver and last patch introduces an interface based on ZONE_DEVICE in order to manage regions to use for foreign mappings. Thanks, Roger. Roger Pau Monne (4): xen/balloon: fix accounting

[PATCH v3 1/4] xen/balloon: fix accounting in alloc_xenballooned_pages error path

2020-07-27 Thread Roger Pau Monne
target_unpopulated is incremented with nr_pages at the start of the function, but the call to free_xenballooned_pages will only subtract pgno number of pages, and thus the rest need to be subtracted before returning or else accounting will be skewed. Signed-off-by: Roger Pau Monné Reviewed

Re: [PATCH v2 4/4] xen: add helpers to allocate unpopulated memory

2020-07-27 Thread Roger Pau Monné
On Fri, Jul 24, 2020 at 12:36:33PM -0400, Boris Ostrovsky wrote: > On 7/24/20 10:34 AM, David Hildenbrand wrote: > > CCing Dan > > > > On 24.07.20 14:42, Roger Pau Monne wrote: > >> + > >> +#include > >> +#include > >>

[PATCH v2 4/4] xen: add helpers to allocate unpopulated memory

2020-07-24 Thread Roger Pau Monne
hotplug from the usage of unpopulated physical memory ranges to map foreign pages, which is the correct thing to do in order to avoid mappings of foreign pages depend on memory hotplug. Signed-off-by: Roger Pau Monné --- I've not added a new memory_type type and just used MEMORY_DEVICE_DEVDAX which

[PATCH v2 3/4] Revert "xen/balloon: Fix crash when ballooning on x86 32 bit PAE"

2020-07-24 Thread Roger Pau Monne
, as it checked the start address of the resource, but it should instead test the end address to assert the whole resource falls below MAX_PHYSMEM_BITS. Signed-off-by: Roger Pau Monné --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: xen-de...@lists.xenproject.org --- drivers/xen

[PATCH v2 0/4] xen/balloon: fixes for memory hotplug

2020-07-24 Thread Roger Pau Monne
be backported to stable branches, third patch is a revert of a workaround applied to the balloon driver and last patch introduces an interface based on ZONE_DEVICE in order to manage regions to use for foreign mappings. Thanks, Roger. Roger Pau Monne (4): xen/balloon: fix accounting

[PATCH v2 1/4] xen/balloon: fix accounting in alloc_xenballooned_pages error path

2020-07-24 Thread Roger Pau Monne
target_unpopulated is incremented with nr_pages at the start of the function, but the call to free_xenballooned_pages will only subtract pgno number of pages, and thus the rest need to be subtracted before returning or else accounting will be skewed. Signed-off-by: Roger Pau Monné Cc: sta

[PATCH v2 2/4] xen/balloon: make the balloon wait interruptible

2020-07-24 Thread Roger Pau Monne
So it can be killed, or else processes can get hung indefinitely waiting for balloon pages. Signed-off-by: Roger Pau Monné Cc: sta...@vger.kernel.org --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: xen-de...@lists.xenproject.org --- drivers/xen/balloon.c | 6 -- 1

Re: [PATCH 3/3] memory: introduce an option to force onlining of hotplug memory

2020-07-23 Thread Roger Pau Monné
On Thu, Jul 23, 2020 at 05:10:03PM +0200, Jürgen Groß wrote: > On 23.07.20 15:59, Roger Pau Monné wrote: > > On Thu, Jul 23, 2020 at 03:22:49PM +0200, David Hildenbrand wrote: > > > On 23.07.20 14:23, Roger Pau Monné wrote: > > > > On Thu, Jul 23, 2020 at 01:37:03PM

Re: [PATCH 3/3] memory: introduce an option to force onlining of hotplug memory

2020-07-23 Thread Roger Pau Monné
On Thu, Jul 23, 2020 at 03:22:49PM +0200, David Hildenbrand wrote: > On 23.07.20 14:23, Roger Pau Monné wrote: > > On Thu, Jul 23, 2020 at 01:37:03PM +0200, David Hildenbrand wrote: > >> On 23.07.20 10:45, Roger Pau Monne wrote: > >>> Add an extra option to add_

Re: [PATCH 3/3] memory: introduce an option to force onlining of hotplug memory

2020-07-23 Thread Roger Pau Monné
On Thu, Jul 23, 2020 at 03:20:55PM +0200, Jürgen Groß wrote: > On 23.07.20 15:08, Roger Pau Monné wrote: > > On Thu, Jul 23, 2020 at 02:28:13PM +0200, Jürgen Groß wrote: > > > On 23.07.20 14:23, Roger Pau Monné wrote: > > > > On Thu, Jul 23, 2020 at 01:37:03PM

Re: [PATCH 3/3] memory: introduce an option to force onlining of hotplug memory

2020-07-23 Thread Roger Pau Monné
On Thu, Jul 23, 2020 at 03:14:31PM +0200, David Hildenbrand wrote: > On 23.07.20 15:08, Roger Pau Monné wrote: > > On Thu, Jul 23, 2020 at 02:28:13PM +0200, Jürgen Groß wrote: > >> On 23.07.20 14:23, Roger Pau Monné wrote: > >>> On Thu, Jul 23, 2020 at 01:37:03PM

Re: [PATCH 3/3] memory: introduce an option to force onlining of hotplug memory

2020-07-23 Thread Roger Pau Monné
On Thu, Jul 23, 2020 at 02:28:13PM +0200, Jürgen Groß wrote: > On 23.07.20 14:23, Roger Pau Monné wrote: > > On Thu, Jul 23, 2020 at 01:37:03PM +0200, David Hildenbrand wrote: > > > On 23.07.20 10:45, Roger Pau Monne wrote: > > > > Add an extra option to add_

Re: [PATCH 3/3] memory: introduce an option to force onlining of hotplug memory

2020-07-23 Thread Roger Pau Monné
On Thu, Jul 23, 2020 at 01:37:03PM +0200, David Hildenbrand wrote: > On 23.07.20 10:45, Roger Pau Monne wrote: > > Add an extra option to add_memory_resource that overrides the memory > > hotplug online behavior in order to force onlining of memory from > > add_memory_res

[PATCH 1/3] xen/balloon: fix accounting in alloc_xenballooned_pages error path

2020-07-23 Thread Roger Pau Monne
target_unpopulated is incremented with nr_pages at the start of the function, but the call to free_xenballooned_pages will only subtract pgno number of pages, and thus the rest need to be subtracted before returning or else accounting will be skewed. Signed-off-by: Roger Pau Monné Cc: sta

[PATCH 3/3] memory: introduce an option to force onlining of hotplug memory

2020-07-23 Thread Roger Pau Monne
attempting to map memory from a different domain. Setting a different default value of memhp_default_online_type when attaching the balloon driver is not a robust solution, as the user (or distro init scripts) could still change it and thus break the Xen balloon driver. Signed-off-by: Roger Pau Monné

[PATCH 2/3] xen/balloon: make the balloon wait interruptible

2020-07-23 Thread Roger Pau Monne
So it can be killed, or else processes can get hung indefinitely waiting for balloon pages. Signed-off-by: Roger Pau Monné Cc: sta...@vger.kernel.org --- Cc: Boris Ostrovsky Cc: Juergen Gross Cc: Stefano Stabellini Cc: xen-de...@lists.xenproject.org --- drivers/xen/balloon.c | 6 -- 1

[PATCH 0/3] xen/balloon: fixes for memory hotplug

2020-07-23 Thread Roger Pau Monne
hotplug interface. Thanks, Roger. Roger Pau Monne (3): xen/balloon: fix accounting in alloc_xenballooned_pages error path xen/balloon: make the balloon wait interruptible memory: introduce an option to force onlining of hotplug memory drivers/xen/balloon.c | 14

Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode

2020-07-22 Thread Roger Pau Monné
On Tue, Jul 21, 2020 at 07:55:09PM +, Anchal Agarwal wrote: > On Tue, Jul 21, 2020 at 10:30:18AM +0200, Roger Pau Monné wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the

Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode

2020-07-21 Thread Roger Pau Monné
Marek: I'm adding you in case you could be able to give this a try and make sure it doesn't break suspend for dom0. On Tue, Jul 21, 2020 at 12:17:36AM +, Anchal Agarwal wrote: > On Mon, Jul 20, 2020 at 11:37:05AM +0200, Roger Pau Monné wrote: > > CAUTION: This email originated fro

Re: [PATCH v2 01/11] xen/manage: keep track of the on-going suspend mode

2020-07-20 Thread Roger Pau Monné
On Sat, Jul 18, 2020 at 09:47:04PM -0400, Boris Ostrovsky wrote: > (Roger, question for you at the very end) > > On 7/17/20 3:10 PM, Anchal Agarwal wrote: > > On Wed, Jul 15, 2020 at 05:18:08PM -0400, Boris Ostrovsky wrote: > >> CAUTION: This email originated from outside of the organization. Do

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation]

2020-06-30 Thread Roger Pau Monné
On Mon, Jun 29, 2020 at 07:20:35PM +, Anchal Agarwal wrote: > On Fri, Jun 26, 2020 at 11:12:39AM +0200, Roger Pau Monné wrote: > > So the frontend should do: > > > > - Switch to Closed state (and cleanup everything required). > > - Wait for backend to switch to

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation]

2020-06-26 Thread Roger Pau Monné
On Thu, Jun 25, 2020 at 06:36:59PM +, Anchal Agarwal wrote: > On Tue, Jun 23, 2020 at 10:19:03AM +0200, Roger Pau Monné wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the

Re: [PATCH 06/12] xen-blkfront: add callbacks for PM suspend and hibernation]

2020-06-23 Thread Roger Pau Monné
On Tue, Jun 23, 2020 at 12:43:14AM +, Anchal Agarwal wrote: > On Mon, Jun 22, 2020 at 10:38:46AM +0200, Roger Pau Monné wrote: > > CAUTION: This email originated from outside of the organization. Do not > > click links or open attachments unless you can confirm the

  1   2   3   4   5   6   7   8   9   10   >