[tip:timers/core] tick: Introduce hrtimer based broadcast

2014-02-07 Thread tip-bot for Preeti U Murthy
Commit-ID: 5d1638acb9f62fa7eb0c07cb85318bbe1f13b227 Gitweb: http://git.kernel.org/tip/5d1638acb9f62fa7eb0c07cb85318bbe1f13b227 Author: Preeti U Murthy pre...@linux.vnet.ibm.com AuthorDate: Fri, 7 Feb 2014 13:36:32 +0530 Committer: Thomas Gleixner t...@linutronix.de CommitDate: Fri, 7 Feb

[PATCH] time/cpuidle:Fixup fallout from hrtimer broadcast mode inclusion

2014-02-07 Thread Preeti U Murthy
The broadcast timer registration has to be done only when GENERIC_CLOCKEVENTS_BROADCAST and TICK_ONESHOT config options are enabled. Also fix max_delta_ticks value for the pseudo clock device. Reported-by: Fengguang Wu fengguang...@intel.com Signed-off-by: Preeti U Murthy pre

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-06 Thread Preeti U Murthy
local_irq_enable() since we are in the call path of cpuidle driver and that explicitly enables irqs on exit from idle states. On 02/07/2014 06:47 AM, Nicolas Pitre wrote: > On Thu, 6 Feb 2014, Preeti U Murthy wrote: > >> Hi Daniel, >> >> On 02/06/2014 09:55 PM, Daniel Le

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-06 Thread Preeti U Murthy
Hi Nicolas, On 02/07/2014 06:47 AM, Nicolas Pitre wrote: > On Thu, 6 Feb 2014, Preeti U Murthy wrote: > >> Hi Daniel, >> >> On 02/06/2014 09:55 PM, Daniel Lezcano wrote: >>> Hi Nico, >>> >>> >>> On 6 February 2014 14:16, Nico

Re: [PATCH V3 2/3] tick/cpuidle: Initialize hrtimer mode of broadcast

2014-02-06 Thread Preeti U Murthy
Hi Thomas, On 02/06/2014 09:33 PM, Thomas Gleixner wrote: > On Thu, 6 Feb 2014, Preeti U Murthy wrote: > > Compiler warnings are not so important, right? > > kernel/time/tick-broadcast.c: In function ‘tick_broadcast_oneshot_control’: > kernel/time/tick-broadcast.c:700:3

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-06 Thread Preeti U Murthy
oes that ontop of this. There have been cpuidle driver cleanups for powernv and pseries in this merge window. While no change would be required in the pseries cpuidle driver as a result of Nicolas's cleanup, we would need to add the ppc64_runlatch_on and off functions before and after the entry into th

Re: [PATCH 2/2] ARM64: powernv: remove redundant cpuidle_idle_call()

2014-02-06 Thread Preeti U Murthy
Hi Nicolas, powernv in the subject of the patch? Regards Preeti U Murthy On 02/06/2014 07:46 PM, Nicolas Pitre wrote: > The core idle loop now takes care of it. > > Signed-off-by: Nicolas Pitre > --- > arch/arm64/kernel/process.c | 7 ++- > 1 file changed, 2 insertio

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-06 Thread Preeti U Murthy
gt; .show_cpuinfo = pnv_show_cpuinfo, > .progress = pnv_progress, > .machine_shutdown = pnv_shutdown, > - .power_save = powernv_idle, > + .power_save = power7_idle, > .calibrate_decr = generic_calibrat

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-06 Thread Preeti U Murthy
-by: Preeti U Murthy pre...@linux.vnet.ibm.com -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 2/2] ARM64: powernv: remove redundant cpuidle_idle_call()

2014-02-06 Thread Preeti U Murthy
Hi Nicolas, powernv in the subject of the patch? Regards Preeti U Murthy On 02/06/2014 07:46 PM, Nicolas Pitre wrote: The core idle loop now takes care of it. Signed-off-by: Nicolas Pitre n...@linaro.org --- arch/arm64/kernel/process.c | 7 ++- 1 file changed, 2 insertions(+), 5

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-06 Thread Preeti U Murthy
as a result of Nicolas's cleanup, we would need to add the ppc64_runlatch_on and off functions before and after the entry into the powernv idle states. Thanks Regards Preeti U Murthy -- Daniel -} - define_machine(powernv) { .name = PowerNV, .probe

Re: [PATCH V3 2/3] tick/cpuidle: Initialize hrtimer mode of broadcast

2014-02-06 Thread Preeti U Murthy
Hi Thomas, On 02/06/2014 09:33 PM, Thomas Gleixner wrote: On Thu, 6 Feb 2014, Preeti U Murthy wrote: Compiler warnings are not so important, right? kernel/time/tick-broadcast.c: In function ‘tick_broadcast_oneshot_control’: kernel/time/tick-broadcast.c:700:3: warning: ‘return

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-06 Thread Preeti U Murthy
Hi Nicolas, On 02/07/2014 06:47 AM, Nicolas Pitre wrote: On Thu, 6 Feb 2014, Preeti U Murthy wrote: Hi Daniel, On 02/06/2014 09:55 PM, Daniel Lezcano wrote: Hi Nico, On 6 February 2014 14:16, Nicolas Pitre nicolas.pi...@linaro.org wrote: The core idle loop now takes care

Re: [PATCH 1/2] PPC: powernv: remove redundant cpuidle_idle_call()

2014-02-06 Thread Preeti U Murthy
local_irq_enable() since we are in the call path of cpuidle driver and that explicitly enables irqs on exit from idle states. On 02/07/2014 06:47 AM, Nicolas Pitre wrote: On Thu, 6 Feb 2014, Preeti U Murthy wrote: Hi Daniel, On 02/06/2014 09:55 PM, Daniel Lezcano wrote: Hi Nico, On 6 February 2014 14

[PATCH V3 2/3] tick/cpuidle: Initialize hrtimer mode of broadcast

2014-02-05 Thread Preeti U Murthy
as well by moving the hrtimer on to the CPU handling the CPU_DEAD notification. Signed-off-by: Preeti U Murthy [Added Changelog and code to handle reprogramming of hrtimer] --- include/linux/clockchips.h |9 +++ kernel/time/Makefile |2 - kernel/time/tick

[PATCH V3 3/3] time/cpuidle:Handle failed call to BROADCAST_ENTER on archs with CPUIDLE_FLAG_TIMER_STOP set

2014-02-05 Thread Preeti U Murthy
we are in no further position to take a decision on an alternative idle state to enter into. Signed-off-by: Preeti U Murthy --- drivers/cpuidle/cpuidle.c | 38 +++--- 1 file changed, 23 insertions(+), 15 deletions(-) diff --git a/drivers/cpuidle/cpuidle.c b

[PATCH V3 0/3] time/cpuidle: Support in tick broadcast framework in absence of external clock device

2014-02-05 Thread Preeti U Murthy
comments and code around programming of the broadcast hrtimer. --- Preeti U Murthy (2): time: Change the return type of clockevents_notify() to integer time/cpuidle:Handle failed call to BROADCAST_ENTER on archs with CPUIDLE_FLAG_TIMER_STOP set Thomas Gleixner (1): tick/cpuidle

[PATCH V3 1/3] time: Change the return type of clockevents_notify() to integer

2014-02-05 Thread Preeti U Murthy
. For such a CPU, the BROADCAST_ENTER notification has to fail indicating that its clock device cannot be shutdown. To make way for this support, change the return type of tick_broadcast_oneshot_control() and hence clockevents_notify() to indicate such scenarios. Signed-off-by: Preeti U Murthy

[PATCH V3 1/3] time: Change the return type of clockevents_notify() to integer

2014-02-05 Thread Preeti U Murthy
. For such a CPU, the BROADCAST_ENTER notification has to fail indicating that its clock device cannot be shutdown. To make way for this support, change the return type of tick_broadcast_oneshot_control() and hence clockevents_notify() to indicate such scenarios. Signed-off-by: Preeti U Murthy pre

[PATCH V3 0/3] time/cpuidle: Support in tick broadcast framework in absence of external clock device

2014-02-05 Thread Preeti U Murthy
comments and code around programming of the broadcast hrtimer. --- Preeti U Murthy (2): time: Change the return type of clockevents_notify() to integer time/cpuidle:Handle failed call to BROADCAST_ENTER on archs with CPUIDLE_FLAG_TIMER_STOP set Thomas Gleixner (1): tick/cpuidle

[PATCH V3 2/3] tick/cpuidle: Initialize hrtimer mode of broadcast

2014-02-05 Thread Preeti U Murthy
of the stand by CPU as well by moving the hrtimer on to the CPU handling the CPU_DEAD notification. Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com [Added Changelog and code to handle reprogramming of hrtimer] --- include/linux/clockchips.h |9 +++ kernel/time/Makefile

[PATCH V3 3/3] time/cpuidle:Handle failed call to BROADCAST_ENTER on archs with CPUIDLE_FLAG_TIMER_STOP set

2014-02-05 Thread Preeti U Murthy
we are in no further position to take a decision on an alternative idle state to enter into. Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com --- drivers/cpuidle/cpuidle.c | 38 +++--- 1 file changed, 23 insertions(+), 15 deletions(-) diff --git

Re: [PATCH V3] cpuidle/governors: Fix logic in selection of idle states

2014-02-04 Thread Preeti U Murthy
Hi Arjan, On 02/04/2014 08:22 PM, Arjan van de Ven wrote: > On 2/4/2014 12:35 AM, Preeti U Murthy wrote: >> The cpuidle governors today are not handling scenarios where no idle >> state >> can be chosen. Such scenarios coud arise if the user has disabled all the >

Re: [PATCH V2 2/2] tick/cpuidle: Initialize hrtimer mode of broadcast

2014-02-04 Thread Preeti U Murthy
R_RESTART; > > We probably want to check whether the timer needs to be restarted at > all. > > if (ce_broadcast_timer.next_event.tv64 == KTIME_MAX) > return HRTIMER_NORESTART; > > return HRTIMER_RESTART; True this additional check would be

Re: [PATCH V2 1/2] time: Change the return type of clockevents_notify() to integer

2014-02-04 Thread Preeti U Murthy
On 02/04/2014 03:31 PM, Thomas Gleixner wrote: > On Fri, 24 Jan 2014, Preeti U Murthy wrote: >> -extern void tick_broadcast_oneshot_control(unsigned long reason); >> +extern int tick_broadcast_oneshot_control(unsigned long reason); > >> -static inline void tick_broadcast_

[PATCH V3] cpuidle/governors: Fix logic in selection of idle states

2014-02-04 Thread Preeti U Murthy
there is no point correcting the prediction either. Signed-off-by: Preeti U Murthy Changes from V1:https://lkml.org/lkml/2014/1/14/26 1. Change the return code to success from -EINVAL due to the reason mentioned in the changelog. 2. Add logic that the patch is addressing in the ladder governor as well

[PATCH V3] cpuidle/governors: Fix logic in selection of idle states

2014-02-04 Thread Preeti U Murthy
there is no point correcting the prediction either. Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com Changes from V1:https://lkml.org/lkml/2014/1/14/26 1. Change the return code to success from -EINVAL due to the reason mentioned in the changelog. 2. Add logic that the patch is addressing

Re: [PATCH V2 1/2] time: Change the return type of clockevents_notify() to integer

2014-02-04 Thread Preeti U Murthy
On 02/04/2014 03:31 PM, Thomas Gleixner wrote: On Fri, 24 Jan 2014, Preeti U Murthy wrote: -extern void tick_broadcast_oneshot_control(unsigned long reason); +extern int tick_broadcast_oneshot_control(unsigned long reason); -static inline void tick_broadcast_oneshot_control(unsigned long

Re: [PATCH V2 2/2] tick/cpuidle: Initialize hrtimer mode of broadcast

2014-02-04 Thread Preeti U Murthy
out the next version with the above corrections including the patch added to this thread where we handle archs setting the CPUIDLE_FLAG_TIMER_STOP flag? Hmm? Thanks, tglx Thanks Regards Preeti U Murthy ___ Linuxppc-dev mailing list

Re: [PATCH V3] cpuidle/governors: Fix logic in selection of idle states

2014-02-04 Thread Preeti U Murthy
Hi Arjan, On 02/04/2014 08:22 PM, Arjan van de Ven wrote: On 2/4/2014 12:35 AM, Preeti U Murthy wrote: The cpuidle governors today are not handling scenarios where no idle state can be chosen. Such scenarios coud arise if the user has disabled all the idle states at runtime or the latency

Re: a LLC sched domain bug for panda board?

2014-02-03 Thread Preeti U Murthy
On PowerPC, the SCHED_MC option can never be set. Its not even optional. On x86, it is on by default and on arm looks like its off by default. Thanks, Regards Preeti U Murthy > >> >>> >>> >>> On 3 February 2014 17:17, Alex Shi wrote: >>>> I just ru

Re: a LLC sched domain bug for panda board?

2014-02-03 Thread Preeti U Murthy
not even optional. On x86, it is on by default and on arm looks like its off by default. Thanks, Regards Preeti U Murthy On 3 February 2014 17:17, Alex Shi alex@linaro.org wrote: I just run the 3.14-rc1 kernel on panda board. The only domain for it is 'CPU' domain, but this domain

Re: [RFC PATCH 3/3] idle: store the idle state index in the struct rq

2014-02-02 Thread Preeti U Murthy
r target residency.. The same holds for exit_latency. > > I am not sure to get the point. Actually, this loop should be just > optimized to backward search the idle state like cpuidle_play_dead does > > There is also a patch proposed by Alex Shi about this loop. > > [RFC PATCH

Re: Is it ok for deferrable timer wakeup the idle cpu?

2014-02-02 Thread Preeti U Murthy
t; But just a thought on if there is scope to improve this part of the >> cpufreq code. >> What do you all think? > > I fear I don't know the problem well enough to display any serious advice. > It depends what kind of measurement is needed. For example, isn't there some

Re: Is it ok for deferrable timer wakeup the idle cpu?

2014-02-02 Thread Preeti U Murthy
of different loads and power statistics taken in interesting path such as the tick or sched switches. Aren't there some read-only metrics that could be interesting? Thanks Regards Preeti U Murthy -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [RFC PATCH 3/3] idle: store the idle state index in the struct rq

2014-02-02 Thread Preeti U Murthy
are copying the exit_latency and target_residency numbers of the idle state entered, into the rq as soon as the idle state for the CPU is chosen, as per the discussion on this thread, then I guess the ordering of the idle states in the cpuidle state table does not matter. Thanks Regards Preeti U Murthy

Re: [RFC PATCH 3/3] idle: store the idle state index in the struct rq

2014-01-31 Thread Preeti U Murthy
; > Alternatively, can we enforce sanity on the cpuidle infrastructure to > make the index naturally ordered? If not, please explain why :-) The commit id 71abbbf856a0e70 says that there are SOCs which could have their target_residency and exit_latency values change at runtime. This comm

Re: [RFC PATCH 3/3] idle: store the idle state index in the struct rq

2014-01-31 Thread Preeti U Murthy
their target_residency and exit_latency values change at runtime. This commit thus removed the ordering of the idle states according to their target_residency/exit_latency. Adding Len and Arjan to the CC. Thanks Regards Preeti U Murthy -- To unsubscribe from this list: send the line unsubscribe linux

[PATCH 0/3] powerpc: Free up an IPI message slot for tick broadcast IPIs

2014-01-30 Thread Preeti U Murthy
broadcast framework to handle wakeup of CPUs from deep idle states on such implementations is currently under discussion. https://lkml.org/lkml/2014/1/15/86 https://lkml.org/lkml/2014/1/24/28 Either way this patchset is essential to enable handling the tick broadcast IPIs. --- Preeti U Murthy (1

[PATCH 3/3] cpuidle/ppc: Split timer_interrupt() into timer handling and interrupt handling routines

2014-01-30 Thread Preeti U Murthy
From: Preeti U Murthy Split timer_interrupt(), which is the local timer interrupt handler on ppc into routines called during regular interrupt handling and __timer_interrupt(), which takes care of running local timers and collecting time related stats. This will enable callers interested only

[PATCH 1/3] powerpc: Free up the slot of PPC_MSG_CALL_FUNC_SINGLE IPI message

2014-01-30 Thread Preeti U Murthy
slots are available). So, implement the functionality of PPC_MSG_CALL_FUNC_SINGLE using PPC_MSG_CALL_FUNC itself and release its IPI message slot, so that it can be used for something else in the future, if desired. Signed-off-by: Srivatsa S. Bhat Signed-off-by: Preeti U. Murthy Acked-by: Geoff

[PATCH 2/3] powerpc: Implement tick broadcast IPI as a fixed IPI message

2014-01-30 Thread Preeti U Murthy
[Functions renamed to tick_broadcast* and Changelog modified by Preeti U. Murthy] Signed-off-by: Preeti U. Murthy Acked-by: Geoff Levand [For the PS3 part] --- arch/powerpc/include/asm/smp.h |2 +- arch/powerpc/include/asm/time.h |1 + arch/powerpc/kernel/smp.c

[PATCH 1/3] powerpc: Free up the slot of PPC_MSG_CALL_FUNC_SINGLE IPI message

2014-01-30 Thread Preeti U Murthy
...@linux.vnet.ibm.com Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com Acked-by: Geoff Levand ge...@infradead.org [For the PS3 part] --- arch/powerpc/include/asm/smp.h |2 +- arch/powerpc/kernel/smp.c | 12 +--- arch/powerpc/platforms/cell/interrupt.c |2

[PATCH 2/3] powerpc: Implement tick broadcast IPI as a fixed IPI message

2014-01-30 Thread Preeti U Murthy
-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com [Functions renamed to tick_broadcast* and Changelog modified by Preeti U. Murthypre...@linux.vnet.ibm.com] Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com Acked-by: Geoff Levand ge...@infradead.org [For the PS3 part] --- arch

[PATCH 3/3] cpuidle/ppc: Split timer_interrupt() into timer handling and interrupt handling routines

2014-01-30 Thread Preeti U Murthy
From: Preeti U Murthy pre...@linux.vnet.ibm.com Split timer_interrupt(), which is the local timer interrupt handler on ppc into routines called during regular interrupt handling and __timer_interrupt(), which takes care of running local timers and collecting time related stats. This will enable

[PATCH 0/3] powerpc: Free up an IPI message slot for tick broadcast IPIs

2014-01-30 Thread Preeti U Murthy
broadcast framework to handle wakeup of CPUs from deep idle states on such implementations is currently under discussion. https://lkml.org/lkml/2014/1/15/86 https://lkml.org/lkml/2014/1/24/28 Either way this patchset is essential to enable handling the tick broadcast IPIs. --- Preeti U Murthy (1

Re: [PATCH v2 1/6] idle: move the cpuidle entry point to the generic idle loop

2014-01-29 Thread Preeti U Murthy
Hi Nicolas, On 01/30/2014 10:58 AM, Nicolas Pitre wrote: > On Thu, 30 Jan 2014, Preeti U Murthy wrote: > >> Hi Nicolas, >> >> On 01/30/2014 02:01 AM, Nicolas Pitre wrote: >>> On Wed, 29 Jan 2014, Nicolas Pitre wrote: >>> >>>> In order

Re: [PATCH v2 1/6] idle: move the cpuidle entry point to the generic idle loop

2014-01-29 Thread Preeti U Murthy
Its supposed to only catch faulty cpuidle drivers that haven't enabled IRQs on exit from idle state but are expected to have done so, isn't it? Thanks Regards Preeti U Murthy > allowing for the warning to trig. > > Signed-off-by: Nicolas Pitre > > diff --git

Re: [PATCH v2 1/6] idle: move the cpuidle entry point to the generic idle loop

2014-01-29 Thread Preeti U Murthy
but are expected to have done so, isn't it? Thanks Regards Preeti U Murthy allowing for the warning to trig. Signed-off-by: Nicolas Pitre n...@linaro.org diff --git a/kernel/cpu/idle.c b/kernel/cpu/idle.c index 988573a9a3..14ca43430a 100644 --- a/kernel/cpu/idle.c +++ b/kernel/cpu/idle.c

Re: [PATCH v2 1/6] idle: move the cpuidle entry point to the generic idle loop

2014-01-29 Thread Preeti U Murthy
Hi Nicolas, On 01/30/2014 10:58 AM, Nicolas Pitre wrote: On Thu, 30 Jan 2014, Preeti U Murthy wrote: Hi Nicolas, On 01/30/2014 02:01 AM, Nicolas Pitre wrote: On Wed, 29 Jan 2014, Nicolas Pitre wrote: In order to integrate cpuidle with the scheduler, we must have a better proximity

Re: [PATCH V2] cpuidle/governors: Fix logic in selection of idle states

2014-01-28 Thread Preeti U Murthy
Hi Daniel, On 01/28/2014 02:16 PM, Daniel Lezcano wrote: > On 01/24/2014 11:21 AM, Preeti U Murthy wrote: >> On 01/24/2014 02:38 PM, Daniel Lezcano wrote: >>> On 01/23/2014 12:15 PM, Preeti U Murthy wrote: >>>> Hi Daniel, >

Re: [PATCH V2 0/2] time/cpuidle: Support in tick broadcast framework in absence of external clock device

2014-01-28 Thread Preeti U Murthy
notification too in this case if the CPU in question is made the stand by CPU. Thanks Regards Preeti U Murthy - time/cpuidle:Handle failed call to BROADCAST_ENTER on archs with CPUIDLE_FLAG_TIMER_STOP set From: Preeti U

Re: [PATCH V2 0/2] time/cpuidle: Support in tick broadcast framework in absence of external clock device

2014-01-28 Thread Preeti U Murthy
notification too in this case if the CPU in question is made the stand by CPU. Thanks Regards Preeti U Murthy - time/cpuidle:Handle failed call to BROADCAST_ENTER on archs with CPUIDLE_FLAG_TIMER_STOP set From: Preeti U

Re: [PATCH V2] cpuidle/governors: Fix logic in selection of idle states

2014-01-28 Thread Preeti U Murthy
Hi Daniel, On 01/28/2014 02:16 PM, Daniel Lezcano wrote: On 01/24/2014 11:21 AM, Preeti U Murthy wrote: On 01/24/2014 02:38 PM, Daniel Lezcano wrote: On 01/23/2014 12:15 PM, Preeti U Murthy wrote: Hi Daniel, Thank you for the review. [ ... ] --- drivers/cpuidle/cpuidle.c

Re: [PATCH 6/9] PPC: remove redundant cpuidle_idle_call()

2014-01-27 Thread Preeti U Murthy
upt occurs (which are driven prior > + * to returning here) or if a prod occurs from another > + * processor. When returning here, external interrupts > + * are enabled. > + */ > + cede_processor(); > > - get_lppaca()->idle = 0; > - } &

Re: [PATCH 6/9] PPC: remove redundant cpuidle_idle_call()

2014-01-27 Thread Preeti U Murthy
-by: Preeti U Murthy pre...@linux.vnet.ibm.com The consequence of this would be for other Power platforms like PowerNV, we will need to invoke ppc_runlatch_off() and ppc_runlatch_on() in each of the idle routines since the idle_loop_prologue() and idle_loop_epilogue() are not invoked by them, but we

Re: [PATCH V2] cpuidle/governors: Fix logic in selection of idle states

2014-01-24 Thread Preeti U Murthy
On 01/24/2014 02:38 PM, Daniel Lezcano wrote: > On 01/23/2014 12:15 PM, Preeti U Murthy wrote: >> Hi Daniel, >> >> Thank you for the review. >> >> On 01/22/2014 01:59 PM, Daniel Lezcano wrote: >>> On 01/17/2014 05:33 AM, Preeti U Murthy wrote: >>

Re: [PATCH V2] cpuidle/governors: Fix logic in selection of idle states

2014-01-24 Thread Preeti U Murthy
On 01/24/2014 02:38 PM, Daniel Lezcano wrote: On 01/23/2014 12:15 PM, Preeti U Murthy wrote: Hi Daniel, Thank you for the review. On 01/22/2014 01:59 PM, Daniel Lezcano wrote: On 01/17/2014 05:33 AM, Preeti U Murthy wrote: diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c

[PATCH V2 1/2] time: Change the return type of clockevents_notify() to integer

2014-01-23 Thread Preeti U Murthy
. For such a CPU, the BROADCAST_ENTER notification has to fail indicating that its clock device cannot be shutdown. To make way for this support, change the return type of tick_broadcast_oneshot_control() and hence clockevents_notify() to indicate such scenarios. Signed-off-by: Preeti U Murthy

[PATCH V2 2/2] tick/cpuidle: Initialize hrtimer mode of broadcast

2014-01-23 Thread Preeti U Murthy
as well by moving the hrtimer on to the CPU handling the CPU_DEAD notification. Signed-off-by: Preeti U Murthy [Added Changelog and code to handle reprogramming of hrtimer] --- include/linux/clockchips.h |9 +++ kernel/time/Makefile |2 - kernel/time/tick

[PATCH V2 0/2] time/cpuidle: Support in tick broadcast framework in absence of external clock device

2014-01-23 Thread Preeti U Murthy
the local timers stop can make use of. Presently we are in need of this support on certain implementations of PowerPC. This patchset has been used on PowerPC for testing with --- Preeti U Murthy (1): time: Change the return type of clockevents_notify() to integer Thomas Gleixner (1

Re: [PATCH V5 6/8] time/cpuidle: Support in tick broadcast framework in the absence of external clock device

2014-01-23 Thread Preeti U Murthy
Hi Thomas, The below patch works pretty much as is. I tried this out with deep idle states on our system. Looking through the code and analysing corner cases also did not bring out any issues to me. I will send out a patch V2 of this. Regards Preeti U Murthy On 01/22/2014 06:57 PM, Thomas

Re: [PATCH V2] cpuidle/governors: Fix logic in selection of idle states

2014-01-23 Thread Preeti U Murthy
Hi Daniel, Thank you for the review. On 01/22/2014 01:59 PM, Daniel Lezcano wrote: > On 01/17/2014 05:33 AM, Preeti U Murthy wrote: >> >> diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c >> index a55e68f..831b664 100644 >> --- a/drivers/cpuidle

Re: [PATCH V2] cpuidle/governors: Fix logic in selection of idle states

2014-01-23 Thread Preeti U Murthy
Hi Daniel, Thank you for the review. On 01/22/2014 01:59 PM, Daniel Lezcano wrote: On 01/17/2014 05:33 AM, Preeti U Murthy wrote: diff --git a/drivers/cpuidle/cpuidle.c b/drivers/cpuidle/cpuidle.c index a55e68f..831b664 100644 --- a/drivers/cpuidle/cpuidle.c +++ b/drivers/cpuidle/cpuidle.c

Re: [PATCH V5 6/8] time/cpuidle: Support in tick broadcast framework in the absence of external clock device

2014-01-23 Thread Preeti U Murthy
Hi Thomas, The below patch works pretty much as is. I tried this out with deep idle states on our system. Looking through the code and analysing corner cases also did not bring out any issues to me. I will send out a patch V2 of this. Regards Preeti U Murthy On 01/22/2014 06:57 PM, Thomas

[PATCH V2 0/2] time/cpuidle: Support in tick broadcast framework in absence of external clock device

2014-01-23 Thread Preeti U Murthy
where the local timers stop can make use of. Presently we are in need of this support on certain implementations of PowerPC. This patchset has been used on PowerPC for testing with --- Preeti U Murthy (1): time: Change the return type of clockevents_notify() to integer Thomas Gleixner (1

[PATCH V2 2/2] tick/cpuidle: Initialize hrtimer mode of broadcast

2014-01-23 Thread Preeti U Murthy
of the stand by CPU as well by moving the hrtimer on to the CPU handling the CPU_DEAD notification. Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com [Added Changelog and code to handle reprogramming of hrtimer] --- include/linux/clockchips.h |9 +++ kernel/time/Makefile

[PATCH V2 1/2] time: Change the return type of clockevents_notify() to integer

2014-01-23 Thread Preeti U Murthy
. For such a CPU, the BROADCAST_ENTER notification has to fail indicating that its clock device cannot be shutdown. To make way for this support, change the return type of tick_broadcast_oneshot_control() and hence clockevents_notify() to indicate such scenarios. Signed-off-by: Preeti U Murthy pre

Re: [PATCH V5 6/8] time/cpuidle: Support in tick broadcast framework in the absence of external clock device

2014-01-22 Thread Preeti U Murthy
Hi Thomas, Thank you very much for the review. On 01/22/2014 06:57 PM, Thomas Gleixner wrote: > On Wed, 15 Jan 2014, Preeti U Murthy wrote: >> diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c >> index 086ad60..d61404e 100644 >> --- a/kernel/time/clockeve

Re: [PATCH V5 6/8] time/cpuidle: Support in tick broadcast framework in the absence of external clock device

2014-01-22 Thread Preeti U Murthy
Hi Thomas, Thank you very much for the review. On 01/22/2014 06:57 PM, Thomas Gleixner wrote: On Wed, 15 Jan 2014, Preeti U Murthy wrote: diff --git a/kernel/time/clockevents.c b/kernel/time/clockevents.c index 086ad60..d61404e 100644 --- a/kernel/time/clockevents.c +++ b/kernel/time

[RESEND PATCH V5 8/8] cpuidle/powernv: Parse device tree to setup idle states

2014-01-21 Thread Preeti U Murthy
Add deep idle states such as nap and fast sleep to the cpuidle state table only if they are discovered from the device tree during cpuidle initialization. Signed-off-by: Preeti U Murthy --- drivers/cpuidle/cpuidle-powernv.c | 81 + 1 file changed, 64

[RESEND PATCH V5 7/8] cpuidle/powernv: Add "Fast-Sleep" CPU idle state

2014-01-21 Thread Preeti U Murthy
support for fast sleep, enable it in the cpuidle framework on PowerNV. Signed-off-by: Preeti U Murthy --- arch/powerpc/Kconfig |2 ++ arch/powerpc/kernel/time.c|2 +- drivers/cpuidle/cpuidle-powernv.c | 42 + 3 files changed, 45

[RESEND PATCH V5 4/8] powernv/cpuidle: Add context management for Fast Sleep

2014-01-21 Thread Preeti U Murthy
-by: Vaidyanathan Srinivasan [Changelog modified by Preeti U. Murthy ] Signed-off-by: Preeti U. Murthy --- arch/powerpc/include/asm/processor.h |1 + arch/powerpc/kernel/exceptions-64s.S | 10 - arch/powerpc/kernel/idle_power7.S| 63 -- 3 files

[RESEND PATCH V5 5/8] powermgt: Add OPAL call to resync timebase on wakeup

2014-01-21 Thread Preeti U Murthy
Signed-off-by: Vaidyanathan Srinivasan Signed-off-by: Preeti U. Murthy --- arch/powerpc/include/asm/opal.h|2 ++ arch/powerpc/kernel/exceptions-64s.S |2 +- arch/powerpc/kernel/idle_power7.S | 27 arch/powerpc/platforms/po

[RESEND PATCH V5 6/8] time/cpuidle: Support in tick broadcast framework in the absence of external clock device

2014-01-21 Thread Preeti U Murthy
in the broadcast mask. This newly nominated bc_cpu is woken up by an IPI so as to queue the above mentioned hrtimer on it. Signed-off-by: Preeti U Murthy --- include/linux/clockchips.h |4 - kernel/time/clockevents.c|9 +- kernel/time/tick-broadcast.c | 192

[RESEND PATCH V5 3/8] cpuidle/ppc: Split timer_interrupt() into timer handling and interrupt handling routines

2014-01-21 Thread Preeti U Murthy
timers to directly call into __timer_interupt(). One of the use cases of this is the tick broadcast IPI handling in which the sleeping CPUs need to handle the local timers that have expired. Signed-off-by: Preeti U Murthy --- arch/powerpc/kernel/time.c | 81

[RESEND PATCH V5 1/8] powerpc: Free up the slot of PPC_MSG_CALL_FUNC_SINGLE IPI message

2014-01-21 Thread Preeti U Murthy
slots are available). So, implement the functionality of PPC_MSG_CALL_FUNC_SINGLE using PPC_MSG_CALL_FUNC itself and release its IPI message slot, so that it can be used for something else in the future, if desired. Signed-off-by: Srivatsa S. Bhat Signed-off-by: Preeti U. Murthy Acked-by: Geoff

[RESEND PATCH V5 2/8] powerpc: Implement tick broadcast IPI as a fixed IPI message

2014-01-21 Thread Preeti U Murthy
[Functions renamed to tick_broadcast* and Changelog modified by Preeti U. Murthy] Signed-off-by: Preeti U. Murthy Acked-by: Geoff Levand [For the PS3 part] --- arch/powerpc/include/asm/smp.h |2 +- arch/powerpc/include/asm/time.h |1 + arch/powerpc/kernel/smp.c

[RESEND PATCH V5 0/8] cpuidle/ppc: Enable deep idle states on PowerNV

2014-01-21 Thread Preeti U Murthy
in deep idle states in which the local timers stop. --- Preeti U Murthy (5): cpuidle/ppc: Split timer_interrupt() into timer handling and interrupt handling routines powermgt: Add OPAL call to resync timebase on wakeup time/cpuidle: Support in tick broadcast framework in t

[RESEND PATCH V5 0/8] cpuidle/ppc: Enable deep idle states on PowerNV

2014-01-21 Thread Preeti U Murthy
. --- Preeti U Murthy (5): cpuidle/ppc: Split timer_interrupt() into timer handling and interrupt handling routines powermgt: Add OPAL call to resync timebase on wakeup time/cpuidle: Support in tick broadcast framework in the absence of external clock device cpuidle/powernv: Add

[RESEND PATCH V5 3/8] cpuidle/ppc: Split timer_interrupt() into timer handling and interrupt handling routines

2014-01-21 Thread Preeti U Murthy
timers to directly call into __timer_interupt(). One of the use cases of this is the tick broadcast IPI handling in which the sleeping CPUs need to handle the local timers that have expired. Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com --- arch/powerpc/kernel/time.c | 81

[RESEND PATCH V5 1/8] powerpc: Free up the slot of PPC_MSG_CALL_FUNC_SINGLE IPI message

2014-01-21 Thread Preeti U Murthy
...@linux.vnet.ibm.com Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com Acked-by: Geoff Levand ge...@infradead.org [For the PS3 part] --- arch/powerpc/include/asm/smp.h |2 +- arch/powerpc/kernel/smp.c | 12 +--- arch/powerpc/platforms/cell/interrupt.c |2

[RESEND PATCH V5 2/8] powerpc: Implement tick broadcast IPI as a fixed IPI message

2014-01-21 Thread Preeti U Murthy
-by: Srivatsa S. Bhat srivatsa.b...@linux.vnet.ibm.com [Functions renamed to tick_broadcast* and Changelog modified by Preeti U. Murthypre...@linux.vnet.ibm.com] Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com Acked-by: Geoff Levand ge...@infradead.org [For the PS3 part] --- arch

[RESEND PATCH V5 7/8] cpuidle/powernv: Add Fast-Sleep CPU idle state

2014-01-21 Thread Preeti U Murthy
support for fast sleep, enable it in the cpuidle framework on PowerNV. Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com --- arch/powerpc/Kconfig |2 ++ arch/powerpc/kernel/time.c|2 +- drivers/cpuidle/cpuidle-powernv.c | 42

[RESEND PATCH V5 4/8] powernv/cpuidle: Add context management for Fast Sleep

2014-01-21 Thread Preeti U Murthy
idle state. Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com [Changelog modified by Preeti U. Murthy pre...@linux.vnet.ibm.com] Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com --- arch/powerpc/include/asm/processor.h |1 + arch/powerpc/kernel/exceptions-64s.S | 10

[RESEND PATCH V5 5/8] powermgt: Add OPAL call to resync timebase on wakeup

2014-01-21 Thread Preeti U Murthy
methods. Signed-off-by: Vaidyanathan Srinivasan sva...@linux.vnet.ibm.com Signed-off-by: Preeti U. Murthy pre...@linux.vnet.ibm.com --- arch/powerpc/include/asm/opal.h|2 ++ arch/powerpc/kernel/exceptions-64s.S |2 +- arch/powerpc/kernel/idle_power7.S

[RESEND PATCH V5 6/8] time/cpuidle: Support in tick broadcast framework in the absence of external clock device

2014-01-21 Thread Preeti U Murthy
in the broadcast mask. This newly nominated bc_cpu is woken up by an IPI so as to queue the above mentioned hrtimer on it. Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com --- include/linux/clockchips.h |4 - kernel/time/clockevents.c|9 +- kernel/time/tick-broadcast.c | 192

[RESEND PATCH V5 8/8] cpuidle/powernv: Parse device tree to setup idle states

2014-01-21 Thread Preeti U Murthy
Add deep idle states such as nap and fast sleep to the cpuidle state table only if they are discovered from the device tree during cpuidle initialization. Signed-off-by: Preeti U Murthy pre...@linux.vnet.ibm.com --- drivers/cpuidle/cpuidle-powernv.c | 81

[PATCH V2] cpuidle/governors: Fix logic in selection of idle states

2014-01-16 Thread Preeti U Murthy
-by: Preeti U Murthy Changes from V1:https://lkml.org/lkml/2014/1/14/26 1. Change the return code to success from -EINVAL due to the reason mentioned in the changelog. 2. Add logic that the patch is addressing in the ladder governor as well. 3. Added relevant comments and removed redundant logic

[PATCH V2] cpuidle/governors: Fix logic in selection of idle states

2014-01-16 Thread Preeti U Murthy
-by: Preeti U Murthy pre...@linux.vnet.ibm.com Changes from V1:https://lkml.org/lkml/2014/1/14/26 1. Change the return code to success from -EINVAL due to the reason mentioned in the changelog. 2. Add logic that the patch is addressing in the ladder governor as well. 3. Added relevant comments and removed

Re: [PATCH V5 0/8] cpuidle/ppc: Enable deep idle states on PowerNV

2014-01-15 Thread Preeti U Murthy
Hi Paul, On 01/15/2014 08:59 PM, Paul Gortmaker wrote: > On 14-01-15 03:07 AM, Preeti U Murthy wrote: > > [...] > >> >> This patchset is based on mainline commit-id:8ae516aa8b8161254d3, and the > > I figured I'd give this a quick sanity build test for a fe

[PATCH V5 7/8] cpuidle/powernv: Add "Fast-Sleep" CPU idle state

2014-01-15 Thread Preeti U Murthy
support for fast sleep, enable it in the cpuidle framework on PowerNV. Signed-off-by: Preeti U Murthy --- arch/powerpc/Kconfig |2 ++ arch/powerpc/kernel/time.c|2 +- drivers/cpuidle/cpuidle-powernv.c | 39 + 3 files changed, 42

[PATCH V5 8/8] cpuidle/powernv: Parse device tree to setup idle states

2014-01-15 Thread Preeti U Murthy
Add deep idle states such as nap and fast sleep to the cpuidle state table only if they are discovered from the device tree during cpuidle initialization. Signed-off-by: Preeti U Murthy --- drivers/cpuidle/cpuidle-powernv.c | 81 + 1 file changed, 64

[PATCH V5 5/8] powermgt: Add OPAL call to resync timebase on wakeup

2014-01-15 Thread Preeti U Murthy
Signed-off-by: Vaidyanathan Srinivasan Signed-off-by: Preeti U. Murthy --- arch/powerpc/include/asm/opal.h|2 ++ arch/powerpc/kernel/exceptions-64s.S |2 +- arch/powerpc/kernel/idle_power7.S | 27 arch/powerpc/platforms/po

[PATCH V5 6/8] time/cpuidle: Support in tick broadcast framework in the absence of external clock device

2014-01-15 Thread Preeti U Murthy
in the broadcast mask. This newly nominated bc_cpu is woken up by an IPI so as to queue the above mentioned hrtimer on it. Signed-off-by: Preeti U Murthy --- include/linux/clockchips.h |4 - kernel/time/clockevents.c|9 +- kernel/time/tick-broadcast.c | 192

[PATCH V5 4/8] powernv/cpuidle: Add context management for Fast Sleep

2014-01-15 Thread Preeti U Murthy
-by: Vaidyanathan Srinivasan [Changelog modified by Preeti U. Murthy ] Signed-off-by: Preeti U. Murthy --- arch/powerpc/include/asm/processor.h |1 + arch/powerpc/kernel/exceptions-64s.S | 10 - arch/powerpc/kernel/idle_power7.S| 63 -- 3 files

[PATCH V5 3/8] cpuidle/ppc: Split timer_interrupt() into timer handling and interrupt handling routines

2014-01-15 Thread Preeti U Murthy
timers to directly call into __timer_interupt(). One of the use cases of this is the tick broadcast IPI handling in which the sleeping CPUs need to handle the local timers that have expired. Signed-off-by: Preeti U Murthy --- arch/powerpc/kernel/time.c | 73

[PATCH V5 2/8] powerpc: Implement tick broadcast IPI as a fixed IPI message

2014-01-15 Thread Preeti U Murthy
[Functions renamed to tick_broadcast* and Changelog modified by Preeti U. Murthy] Signed-off-by: Preeti U. Murthy Acked-by: Geoff Levand [For the PS3 part] --- arch/powerpc/include/asm/smp.h |2 +- arch/powerpc/include/asm/time.h |1 + arch/powerpc/kernel/smp.c

[PATCH V5 0/8] cpuidle/ppc: Enable deep idle states on PowerNV

2014-01-15 Thread Preeti U Murthy
ick a broadcast CPU, instead of having a dedicated one. 2. Remove the constraint of having to disable tickless idle on the broadcast CPU by queueing a hrtimer dedicated to do broadcast. V1 posting: https://lkml.org/lkml/2013/7/25/740. 1. Added the infrastructure to wakeup CPUs in deep idle st

[PATCH V5 1/8] powerpc: Free up the slot of PPC_MSG_CALL_FUNC_SINGLE IPI message

2014-01-15 Thread Preeti U Murthy
slots are available). So, implement the functionality of PPC_MSG_CALL_FUNC_SINGLE using PPC_MSG_CALL_FUNC itself and release its IPI message slot, so that it can be used for something else in the future, if desired. Signed-off-by: Srivatsa S. Bhat Signed-off-by: Preeti U. Murthy Acked-by: Geoff

<    3   4   5   6   7   8   9   10   11   12   >