RE: [PATCH 0/3] Receive Side Coalescing for macb driver

From: David Miller [mailto:da...@davemloft.net] Sent: 16 kwietnia 2018 17:09 > From: Rafal Ozieblo <raf...@cadence.com> > Date: Sat, 14 Apr 2018 21:53:07 +0100 > >> This patch series adds support for receive side coalescing for Cadence >> GEM driver. Rece

RE: [PATCH 0/3] Receive Side Coalescing for macb driver

From: David Miller [mailto:da...@davemloft.net] Sent: 16 kwietnia 2018 17:09 > From: Rafal Ozieblo > Date: Sat, 14 Apr 2018 21:53:07 +0100 > >> This patch series adds support for receive side coalescing for Cadence >> GEM driver. Receive segmentation coalescing is a mechan

[PATCH 3/3] net: macb: Receive Side Coalescing (RSC) feature added.

This is basically the same as Large Receive Offload (LRO) in Linux framework. Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- drivers/net/ethernet/cadence/macb.h | 6 +++ drivers/net/ethernet/cadence/macb_main.c | 70 +++- 2 files changed, 75 inse

[PATCH 3/3] net: macb: Receive Side Coalescing (RSC) feature added.

This is basically the same as Large Receive Offload (LRO) in Linux framework. Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/macb.h | 6 +++ drivers/net/ethernet/cadence/macb_main.c | 70 +++- 2 files changed, 75 insertions(+), 1 deletion

[PATCH 2/3] net: macb: Add support for header data spliting

This patch adds support for frames splited between many rx buffers. Header data spliting can be used but also buffers shorter than max frame length. The only limitation is that frame header can't be splited. Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- drivers/net/ethernet/c

[PATCH 2/3] net: macb: Add support for header data spliting

This patch adds support for frames splited between many rx buffers. Header data spliting can be used but also buffers shorter than max frame length. The only limitation is that frame header can't be splited. Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/macb.h | 13

[PATCH 1/3] net: macb: Add support for rsc capable hardware

When the pbuf_rsc has been enabled in hardware the receive buffer offset for incoming packets cannot be changed in the network configuration register (even when rsc is not use at all). Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- drivers/net/ethernet/cadence/macb.h | 2 ++ d

[PATCH 1/3] net: macb: Add support for rsc capable hardware

When the pbuf_rsc has been enabled in hardware the receive buffer offset for incoming packets cannot be changed in the network configuration register (even when rsc is not use at all). Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/macb.h | 2 ++ drivers/net/ethernet

[PATCH 0/3] Receive Side Coalescing for macb driver

the CPU only has to process the single header and act upon the one data payload. Rafal Ozieblo (3): net: macb: Add support for rsc capable hardware net: macb: Add support for header data spliting net: macb: Receive Side Coalescing (RSC) feature added. drivers/net/ethernet/cadence/macb.h

[PATCH 0/3] Receive Side Coalescing for macb driver

the CPU only has to process the single header and act upon the one data payload. Rafal Ozieblo (3): net: macb: Add support for rsc capable hardware net: macb: Add support for header data spliting net: macb: Receive Side Coalescing (RSC) feature added. drivers/net/ethernet/cadence/macb.h

[PATCH 2/3] net: macb: Added some queue statistics

Added statistics per queue: - qX_rx_packets - qX_rx_bytes - qX_rx_dropped - qX_tx_packets - qX_tx_bytes - qX_tx_dropped Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- drivers/net/ethernet/cadence/macb.h | 31 +- drivers/net/ethernet/cadence/macb_main.

[PATCH 2/3] net: macb: Added some queue statistics

Added statistics per queue: - qX_rx_packets - qX_rx_bytes - qX_rx_dropped - qX_tx_packets - qX_tx_bytes - qX_tx_dropped Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/macb.h | 31 +- drivers/net/ethernet/cadence/macb_main.c | 37

[PATCH 3/3] net: macb: Added support for RX filtering

This patch allows filtering received packets to different hardware queues (aka ntuple). Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- drivers/net/ethernet/cadence/macb.h | 109 ++ drivers/net/ethernet/cadence/macb_main.c | 336 ++- 2 files c

[PATCH 3/3] net: macb: Added support for RX filtering

This patch allows filtering received packets to different hardware queues (aka ntuple). Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/macb.h | 109 ++ drivers/net/ethernet/cadence/macb_main.c | 336 ++- 2 files changed, 444 insertions

[PATCH 1/3] net: macb: Added support for many RX queues

To be able for packet reception on different RX queues some configuration has to be performed. This patch checks how many hardware queue does GEM support and initializes them. Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- drivers/net/ethernet/cadence/macb.h | 26 ++- drive

[PATCH 1/3] net: macb: Added support for many RX queues

To be able for packet reception on different RX queues some configuration has to be performed. This patch checks how many hardware queue does GEM support and initializes them. Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/macb.h | 26 ++- drivers/net/ethernet/cadence

[PATCH 0/3] Receive packets filtering for macb driver

This patch series adds support for receive packets filtering for Cadence GEM driver. Packets can be redirect to different hardware queues based on source IP, destination IP, source port or destination port. To enable filtering, support for RX queueing was added as well. Rafal Ozieblo (3): net

[PATCH 0/3] Receive packets filtering for macb driver

This patch series adds support for receive packets filtering for Cadence GEM driver. Packets can be redirect to different hardware queues based on source IP, destination IP, source port or destination port. To enable filtering, support for RX queueing was added as well. Rafal Ozieblo (3): net

[PATCH v4 4/4] net: macb: Add hardware PTP support

Ethernet packets are received using the SO_TIMESTAMPING API. Time stamps are obtained from the dma buffer descriptors - add macb_ptp to compilation chain Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- drivers/net/ethernet/cadence/Makefile| 4 + drivers/net/ethernet/cadence/

[PATCH v4 4/4] net: macb: Add hardware PTP support

Ethernet packets are received using the SO_TIMESTAMPING API. Time stamps are obtained from the dma buffer descriptors - add macb_ptp to compilation chain Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/Makefile| 4 + drivers/net/ethernet/cadence/macb.h | 126

[PATCH v4 2/4] net: macb: Add tsu_clk to device tree

Signed-off-by: Rafal Ozieblo <raf...@cadence.com> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/ma

[PATCH v4 2/4] net: macb: Add tsu_clk to device tree

Signed-off-by: Rafal Ozieblo Acked-by: Rob Herring --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt index 1506e94..27966ae 100644

[PATCH v4 1/4] net: macb: Add support for PTP timestamps in DMA descriptors

This patch adds support for PTP timestamps in DMA buffer descriptors. It checks capability at runtime and uses appropriate buffer descriptor. Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- drivers/net/ethernet/cadence/Kconfig | 10 ++- drivers/net/ethernet/cadence/macb.c

[PATCH v4 1/4] net: macb: Add support for PTP timestamps in DMA descriptors

This patch adds support for PTP timestamps in DMA buffer descriptors. It checks capability at runtime and uses appropriate buffer descriptor. Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/Kconfig | 10 ++- drivers/net/ethernet/cadence/macb.c | 117

[PATCH v4 0/4] PTP support for macb driver

: * respin to the newest next-next (28 Jun 2017) Rafal Ozieblo (4): net: macb: Add support for PTP timestamps in DMA descriptors net: macb: Add tsu_clk to device tree net: macb: macb.c changed to macb_main.c net: macb: Add hardware PTP support Documentation/devicetree/bindings/net/macb.txt |1

[PATCH v4 0/4] PTP support for macb driver

: * respin to the newest next-next (28 Jun 2017) Rafal Ozieblo (4): net: macb: Add support for PTP timestamps in DMA descriptors net: macb: Add tsu_clk to device tree net: macb: macb.c changed to macb_main.c net: macb: Add hardware PTP support Documentation/devicetree/bindings/net/macb.txt |1

[PATCH v3 4/4] net: macb: Add hardware PTP support

Ethernet packets are received using the SO_TIMESTAMPING API. Time stamps are obtained from the dma buffer descriptors - add macb_ptp to compilation chain Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- drivers/net/ethernet/cadence/Makefile| 4 + drivers/net/ethernet/cadence/

[PATCH v3 4/4] net: macb: Add hardware PTP support

Ethernet packets are received using the SO_TIMESTAMPING API. Time stamps are obtained from the dma buffer descriptors - add macb_ptp to compilation chain Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/Makefile| 4 + drivers/net/ethernet/cadence/macb.h | 126

[PATCH v3 1/4] net: macb: Add support for PTP timestamps in DMA descriptors

This patch adds support for PTP timestamps in DMA buffer descriptors. It checks capability at runtime and uses appropriate buffer descriptor. Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- drivers/net/ethernet/cadence/Kconfig | 10 ++- drivers/net/ethernet/cadence/macb.c

[PATCH v3 1/4] net: macb: Add support for PTP timestamps in DMA descriptors

This patch adds support for PTP timestamps in DMA buffer descriptors. It checks capability at runtime and uses appropriate buffer descriptor. Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/Kconfig | 10 ++- drivers/net/ethernet/cadence/macb.c | 117

[PATCH v3 2/4] net: macb: Add tsu_clk to device tree

Signed-off-by: Rafal Ozieblo <raf...@cadence.com> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/ma

[PATCH v3 2/4] net: macb: Add tsu_clk to device tree

Signed-off-by: Rafal Ozieblo Acked-by: Rob Herring --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt index 1506e94..27966ae 100644

[PATCH v3 0/4] PTP support for macb driver

unnecessary #ifdef * fixed coding style and alligment issues * renamed macb.c to macb_main.c v3 changes: * added checking NULL ptr from ptp_clock_register() * fixed error codes return * locals list in "upside down Christmas tree" style * fixed some other issues from review Rafal Ozieblo (4):

[PATCH v3 0/4] PTP support for macb driver

unnecessary #ifdef * fixed coding style and alligment issues * renamed macb.c to macb_main.c v3 changes: * added checking NULL ptr from ptp_clock_register() * fixed error codes return * locals list in "upside down Christmas tree" style * fixed some other issues from review Rafal Ozieblo (4):

RE: [PATCH v2 4/4] net: macb: Add hardware PTP support

> From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: 7 czerwca 2017 15:28 > To: Rafal Ozieblo <raf...@cadence.com> > Cc: David Miller <da...@davemloft.net>; nicolas.fe...@atmel.com; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; > devicet...@

RE: [PATCH v2 4/4] net: macb: Add hardware PTP support

> From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: 7 czerwca 2017 15:28 > To: Rafal Ozieblo > Cc: David Miller ; nicolas.fe...@atmel.com; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; > devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.

RE: [PATCH v2 4/4] net: macb: Add hardware PTP support

> From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: 6 czerwca 2017 20:34 > To: Rafal Ozieblo <raf...@cadence.com> > Cc: David Miller <da...@davemloft.net>; nicolas.fe...@atmel.com; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; > devicet...@

RE: [PATCH v2 4/4] net: macb: Add hardware PTP support

> From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: 6 czerwca 2017 20:34 > To: Rafal Ozieblo > Cc: David Miller ; nicolas.fe...@atmel.com; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; > devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.

RE: [PATCH v2 4/4] net: macb: Add hardware PTP support

> From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: 4 czerwca 2017 22:55 > To: Rafal Ozieblo <raf...@cadence.com> > Cc: David Miller <da...@davemloft.net>; nicolas.fe...@atmel.com; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; > devicet...@

RE: [PATCH v2 4/4] net: macb: Add hardware PTP support

> From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: 4 czerwca 2017 22:55 > To: Rafal Ozieblo > Cc: David Miller ; nicolas.fe...@atmel.com; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; > devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.

[PATCH v2 0/4] PTP support for macb driver

unnecessary #ifdef * fixed coding style and alligment issues * renamed macb.c to macb_main.c Rafal Ozieblo (4): net: macb: Add support for PTP timestamps in DMA descriptors net: macb: Add tsu_clk to device tree net: macb: macb.c changed to macb_main.c net: macb: Add hardware PTP support

[PATCH v2 0/4] PTP support for macb driver

unnecessary #ifdef * fixed coding style and alligment issues * renamed macb.c to macb_main.c Rafal Ozieblo (4): net: macb: Add support for PTP timestamps in DMA descriptors net: macb: Add tsu_clk to device tree net: macb: macb.c changed to macb_main.c net: macb: Add hardware PTP support

[PATCH v2 2/4] net: macb: Add tsu_clk to device tree

Signed-off-by: Rafal Ozieblo <raf...@cadence.com> Acked-by: Rob Herring <r...@kernel.org> --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/ma

[PATCH v2 2/4] net: macb: Add tsu_clk to device tree

Signed-off-by: Rafal Ozieblo Acked-by: Rob Herring --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt index 1506e94..27966ae 100644

[PATCH v2 4/4] net: macb: Add hardware PTP support

Ethernet packets are received using the SO_TIMESTAMPING API. Time stamps are obtained from the dma buffer descriptors - add macb_ptp to compilation chain Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- drivers/net/ethernet/cadence/Makefile| 4 + drivers/net/ethernet/cadence/

[PATCH v2 4/4] net: macb: Add hardware PTP support

Ethernet packets are received using the SO_TIMESTAMPING API. Time stamps are obtained from the dma buffer descriptors - add macb_ptp to compilation chain Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/Makefile| 4 + drivers/net/ethernet/cadence/macb.h | 126

[PATCH v2 1/4] net: macb: Add support for PTP timestamps in DMA descriptors

This patch adds support for PTP timestamps in DMA buffer descriptors. It checks capability at runtime and uses appropriate buffer descriptor. Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- drivers/net/ethernet/cadence/Kconfig | 10 ++- drivers/net/ethernet/cadence/macb.c

[PATCH v2 1/4] net: macb: Add support for PTP timestamps in DMA descriptors

This patch adds support for PTP timestamps in DMA buffer descriptors. It checks capability at runtime and uses appropriate buffer descriptor. Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/Kconfig | 10 ++- drivers/net/ethernet/cadence/macb.c | 117

[PATCH 4/4] net: macb: Add hardware PTP support

Ethernet packets are received using the SO_TIMESTAMPING API. Time stamps are obtained from the dma buffer descriptors - add macb_ptp to compilation chain Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- drivers/net/ethernet/cadence/Makefile| 4 + drivers/net/ethernet/cadence/

[PATCH 4/4] net: macb: Add hardware PTP support

Ethernet packets are received using the SO_TIMESTAMPING API. Time stamps are obtained from the dma buffer descriptors - add macb_ptp to compilation chain Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/Makefile| 4 + drivers/net/ethernet/cadence/macb.h | 126

[PATCH 2/4] net: macb: Add tsu_clk to device tree

Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt index 1506e94..27966ae

[PATCH 2/4] net: macb: Add tsu_clk to device tree

Signed-off-by: Rafal Ozieblo --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt index 1506e94..27966ae 100644 --- a/Documentation/devicetree

[PATCH 1/4] net: macb: Add support for PTP timestamps in DMA descriptors

This patch adds support for PTP timestamps in DMA buffer descriptors. It checks capability at runtime and uses appropriate buffer descriptor. Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- drivers/net/ethernet/cadence/Kconfig | 10 ++- drivers/net/ethernet/cadence/macb.c

[PATCH 1/4] net: macb: Add support for PTP timestamps in DMA descriptors

This patch adds support for PTP timestamps in DMA buffer descriptors. It checks capability at runtime and uses appropriate buffer descriptor. Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/Kconfig | 10 ++- drivers/net/ethernet/cadence/macb.c | 117

RE: [PATCH 3/4] net: macb: Add hardware PTP support

> From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: 14 kwietnia 2017 20:29 > To: Rafal Ozieblo <raf...@cadence.com> > Cc: David Miller <da...@davemloft.net>; nicolas.fe...@atmel.com; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; > devicet...@

RE: [PATCH 3/4] net: macb: Add hardware PTP support

> From: Richard Cochran [mailto:richardcoch...@gmail.com] > Sent: 14 kwietnia 2017 20:29 > To: Rafal Ozieblo > Cc: David Miller ; nicolas.fe...@atmel.com; > net...@vger.kernel.org; linux-kernel@vger.kernel.org; > devicet...@vger.kernel.org; linux-arm-ker...@lists.infradead.org;

[PATCH 1/4] net: macb: Add support for PTP timestamps in DMA descriptors

This patch adds support for PTP timestamps in DMA buffer descriptors. It checks capability at runtime and uses appropriate buffer descriptor. Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- drivers/net/ethernet/cadence/Kconfig | 10 ++- drivers/net/ethernet/cadence/macb.c

[PATCH 1/4] net: macb: Add support for PTP timestamps in DMA descriptors

This patch adds support for PTP timestamps in DMA buffer descriptors. It checks capability at runtime and uses appropriate buffer descriptor. Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/Kconfig | 10 ++- drivers/net/ethernet/cadence/macb.c | 133

[PATCH 4/4] net: macb: Add macb_ptp to compilation chain

Add macb_ptp.c to Makefile. In case that macb is compiled as a module, it has been renamed to cadence-macb.ko to avoid naming confusion in Makefile. Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- drivers/net/ethernet/cadence/Makefile | 7 ++- 1 file changed, 6 insertions

[PATCH 4/4] net: macb: Add macb_ptp to compilation chain

Add macb_ptp.c to Makefile. In case that macb is compiled as a module, it has been renamed to cadence-macb.ko to avoid naming confusion in Makefile. Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/Makefile | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git

[PATCH 3/4] net: macb: Add hardware PTP support

Ethernet packets are received using the SO_TIMESTAMPING API. Where timers are obtained from the dma buffer descriptors Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- drivers/net/ethernet/cadence/macb.c | 99 - drivers/net/ethernet/cadence/macb.h | 140 ++ drive

[PATCH 3/4] net: macb: Add hardware PTP support

Ethernet packets are received using the SO_TIMESTAMPING API. Where timers are obtained from the dma buffer descriptors Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/macb.c | 99 - drivers/net/ethernet/cadence/macb.h | 140 ++ drivers/net/ethernet/cadence

[PATCH 2/4] net: macb: Add tsu_clk to device tree

Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt index 1506e94..27966ae

[PATCH 2/4] net: macb: Add tsu_clk to device tree

Signed-off-by: Rafal Ozieblo --- Documentation/devicetree/bindings/net/macb.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/Documentation/devicetree/bindings/net/macb.txt b/Documentation/devicetree/bindings/net/macb.txt index 1506e94..27966ae 100644 --- a/Documentation/devicetree

[PATCH net-next] macb: Add hardware PTP support.

buffer descriptors - Added tsu_clk to device tree Note: Patch on net-next, on April 3rd. Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- Documentation/devicetree/bindings/net/macb.txt | 1 + drivers/net/ethernet/cadence/Kconfig | 10 +- drivers/net/ethernet/cadence/Ma

[PATCH net-next] macb: Add hardware PTP support.

buffer descriptors - Added tsu_clk to device tree Note: Patch on net-next, on April 3rd. Signed-off-by: Rafal Ozieblo --- Documentation/devicetree/bindings/net/macb.txt | 1 + drivers/net/ethernet/cadence/Kconfig | 10 +- drivers/net/ethernet/cadence/Makefile | 7 +- drivers

[PATCH] Add hardware PTP support.

buffer descriptors - Added tsu_clk to device tree Note: Patch on net-next, on March 15th. Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- Documentation/devicetree/bindings/net/macb.txt | 1 + drivers/net/ethernet/cadence/Kconfig | 10 +- drivers/net/ethernet/cadence/Ma

[PATCH] Add hardware PTP support.

buffer descriptors - Added tsu_clk to device tree Note: Patch on net-next, on March 15th. Signed-off-by: Rafal Ozieblo --- Documentation/devicetree/bindings/net/macb.txt | 1 + drivers/net/ethernet/cadence/Kconfig | 10 +- drivers/net/ethernet/cadence/Makefile | 7

[PATCH v2] net: macb: Fix 64 bit addressing support for GEM

This patch adds support for 32 bit GEM in 64 bit system. It checks capability at runtime and uses appropriate buffer descriptor. Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- Changed in v2: Added upper_32_bits() and lower_32_bits() instead of shifting. --- drivers/net/ethernet/c

[PATCH v2] net: macb: Fix 64 bit addressing support for GEM

This patch adds support for 32 bit GEM in 64 bit system. It checks capability at runtime and uses appropriate buffer descriptor. Signed-off-by: Rafal Ozieblo --- Changed in v2: Added upper_32_bits() and lower_32_bits() instead of shifting. --- drivers/net/ethernet/cadence/macb.c | 188

RE: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM

>-Original Message- >From: Nicolas Ferre [mailto:nicolas.fe...@atmel.com] >Sent: 27 stycznia 2017 11:28 >Subject: Re: [PATCH net-next v2] macb: Common code to enable ptp support for >MACB/GEM > >Le 27/01/2017 à 11:26, Rafal Ozieblo a écrit : >>> -

RE: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM

>-Original Message- >From: Nicolas Ferre [mailto:nicolas.fe...@atmel.com] >Sent: 27 stycznia 2017 11:28 >Subject: Re: [PATCH net-next v2] macb: Common code to enable ptp support for >MACB/GEM > >Le 27/01/2017 à 11:26, Rafal Ozieblo a écrit : >>> -

RE: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM

>-Original Message- >From: Harini Katakam [mailto:harinikatakamli...@gmail.com] >Sent: 27 stycznia 2017 06:43 >Subject: Re: [PATCH net-next v2] macb: Common code to enable ptp support for >MACB/GEM > >Hi Rafal, > >On Thu, Jan 26, 2017 at 8:45 PM, Rafal Ozieblo

RE: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM

>-Original Message- >From: Harini Katakam [mailto:harinikatakamli...@gmail.com] >Sent: 27 stycznia 2017 06:43 >Subject: Re: [PATCH net-next v2] macb: Common code to enable ptp support for >MACB/GEM > >Hi Rafal, > >On Thu, Jan 26, 2017 at 8:45 PM, Rafal Oziebl

[PATCH] net: macb: Fix 64 bit addressing support for GEM

This patch adds support for 32 bit GEM in 64 bit system. It checks capability at runtime and uses appropriate buffer descriptor. Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- drivers/net/ethernet/cadence/macb.c | 182 +--- drivers/net/ethernet/c

[PATCH] net: macb: Fix 64 bit addressing support for GEM

This patch adds support for 32 bit GEM in 64 bit system. It checks capability at runtime and uses appropriate buffer descriptor. Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/macb.c | 182 +--- drivers/net/ethernet/cadence/macb.h | 20 +++- 2

RE: [PATCH] Fix 64 bit addressing support for GEM

-Original Message- > From: Rafal Ozieblo [mailto:raf...@cadence.com] > Sent: 26 stycznia 2017 16:01 > Subject: [PATCH] Fix 64 bit addressing support for GEM > > This patch adds support for 32 bit GEM in > 64 bit system. It checks capability at runtime > and us

RE: [PATCH] Fix 64 bit addressing support for GEM

-Original Message- > From: Rafal Ozieblo [mailto:raf...@cadence.com] > Sent: 26 stycznia 2017 16:01 > Subject: [PATCH] Fix 64 bit addressing support for GEM > > This patch adds support for 32 bit GEM in > 64 bit system. It checks capability at runtime > and us

[PATCH] Fix 64 bit addressing support for GEM

This patch adds support for 32 bit GEM in 64 bit system. It checks capability at runtime and uses appropriate buffer descriptor. Signed-off-by: Rafal Ozieblo <raf...@cadence.com> --- drivers/net/ethernet/cadence/macb.c | 183 +--- drivers/net/ethernet/c

[PATCH] Fix 64 bit addressing support for GEM

This patch adds support for 32 bit GEM in 64 bit system. It checks capability at runtime and uses appropriate buffer descriptor. Signed-off-by: Rafal Ozieblo --- drivers/net/ethernet/cadence/macb.c | 183 +--- drivers/net/ethernet/cadence/macb.h | 20 +++- 2

RE: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM

> -Original Message- > From: Andrei Pistirica [mailto:andrei.pistir...@microchip.com] > Sent: 19 stycznia 2017 16:56 > Subject: [PATCH net-next v2] macb: Common code to enable ptp support for > MACB/GEM > > > +static inline bool gem_has_ptp(struct macb *bp) > +{ > + return

RE: [PATCH net-next v2] macb: Common code to enable ptp support for MACB/GEM

> -Original Message- > From: Andrei Pistirica [mailto:andrei.pistir...@microchip.com] > Sent: 19 stycznia 2017 16:56 > Subject: [PATCH net-next v2] macb: Common code to enable ptp support for > MACB/GEM > > > +static inline bool gem_has_ptp(struct macb *bp) > +{ > + return

RE: [RFC PATCH net-next v4 1/2] macb: Add 1588 support in Cadence GEM.

>From: Harini Katakam [mailto:harinikatakamli...@gmail.com] >Sent: 3 stycznia 2017 06:06 >Subject: Re: [RFC PATCH net-next v4 1/2] macb: Add 1588 support in Cadence GEM. > >Hi Richard, > >On Mon, Jan 2, 2017 at 9:43 PM, Richard Cochran >wrote: >> On Mon, Jan 02, 2017

RE: [RFC PATCH net-next v4 1/2] macb: Add 1588 support in Cadence GEM.

>From: Harini Katakam [mailto:harinikatakamli...@gmail.com] >Sent: 3 stycznia 2017 06:06 >Subject: Re: [RFC PATCH net-next v4 1/2] macb: Add 1588 support in Cadence GEM. > >Hi Richard, > >On Mon, Jan 2, 2017 at 9:43 PM, Richard Cochran >wrote: >> On Mon, Jan 02, 2017 at 03:47:07PM +0100,

RE: [RFC PATCH net-next v4 1/2] macb: Add 1588 support in Cadence GEM.

> -Original Message- > From: Rafal Ozieblo > Sent: 28 grudnia 2016 14:23 > Subject: RE: [RFC PATCH net-next v4 1/2] macb: Add 1588 support in Cadence > GEM. > > > +static void gem_ptp_tx_hwtstamp(struct macb *bp, struct sk_buff *skb, > > +

RE: [RFC PATCH net-next v4 1/2] macb: Add 1588 support in Cadence GEM.

> -Original Message- > From: Rafal Ozieblo > Sent: 28 grudnia 2016 14:23 > Subject: RE: [RFC PATCH net-next v4 1/2] macb: Add 1588 support in Cadence > GEM. > > > +static void gem_ptp_tx_hwtstamp(struct macb *bp, struct sk_buff *skb, > > +

RE: [RFC PATCH net-next v4 1/2] macb: Add 1588 support in Cadence GEM.

TP interface functions */ void > +gem_ptp_txstamp(struct macb *bp, struct sk_buff *skb) { > + if (unlikely(skb_shinfo(skb)->tx_flags & SKBTX_HW_TSTAMP)) { > + int class = ptp_classify_raw(skb); > + int peer; > + > + peer = gem_get_ptp_peer(skb, class); > + if (peer < 0) > + return; > + > + /* Timestamp this packet */ > + gem_ptp_tx_hwtstamp(bp, skb, peer); > + } > +} > + > +void gem_ptp_rxstamp(struct macb *bp, struct sk_buff *skb) { > + int class, peer; > + > + __skb_push(skb, ETH_HLEN); > + class = ptp_classify_raw(skb); > + __skb_pull(skb, ETH_HLEN); > + > + peer = gem_get_ptp_peer(skb, class); > + if (peer < 0) > + return; > + > + gem_ptp_rx_hwtstamp(bp, skb, peer); > +} > + > +void gem_ptp_init(struct net_device *ndev) { > + struct macb *bp = netdev_priv(ndev); > + > + spin_lock_init(>tsu_clk_lock); > + bp->ptp_caps = gem_ptp_caps_template; > + > + /* nominal frequency and maximum adjustment in ppb */ > + bp->tsu_rate = bp->ptp_info->get_tsu_rate(bp); > + bp->ptp_caps.max_adj = bp->ptp_info->get_ptp_max_adj(); > + > + gem_ptp_init_timer(bp); > + > + bp->ptp_clock = ptp_clock_register(>ptp_caps, NULL); > + if (IS_ERR(>ptp_clock)) { > + bp->ptp_clock = NULL; > + pr_err("ptp clock register failed\n"); > + return; But you have already overwritten TSU and Increments. > + } > + > + dev_info(>pdev->dev, "%s ptp clock registered.\n", > + GEM_PTP_TIMER_NAME); > +} > + > +void gem_ptp_remove(struct net_device *ndev) { > + struct macb *bp = netdev_priv(ndev); > + > + if (bp->ptp_clock) > + ptp_clock_unregister(bp->ptp_clock); > + > + gem_ptp_clear_timer(bp); > + > + dev_info(>pdev->dev, "%s ptp clock unregistered.\n", > + GEM_PTP_TIMER_NAME); > +} > -- > 2.7.4 > Why don't you support HWTSTAMP_TX_ONESTEP_SYNC? (Network control register 0x000, bit 24: one_step_sync_mode) Best regards, Rafal Ozieblo | Firmware System Engineer, www.cadence.com

RE: [RFC PATCH net-next v4 1/2] macb: Add 1588 support in Cadence GEM.

} The same concerns like above. > + ns = timespec64_to_ns(); > + > + memset(shhwtstamps, 0, sizeof(struct skb_shared_hwtstamps)); > + shhwtstamps->hwtstamp = ns_to_ktime(ns); } > + > +/* no static, GEM PTP interface functions */ void > +gem_ptp_txstamp(stru

RE: [RFC PATCH net-next v4 2/2] macb: Enable 1588 support in SAMA5Dx platforms.

fdef > +CONFIG_MACB_USE_HWSTAMP > + if (gem_has_ptp(bp)) > + bp->ptp_info = _ptp_info; > +#endif > } > > dev_dbg(>pdev->dev, "Cadence caps 0x%08x\n", bp->caps); @@ -3041,7 > +3198,7 @@ static const struct macb_config pc302gem_config = { }; > > static const struct macb_config sama5d2_config = { > - .caps = MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII, > + .caps = MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII | MACB_CAPS_GEM_HAS_PTP, There are many IP cores with many configuration. If it is possible, capabilities should be read from IP directly. And it is possible in that case: Design Configuration Register 5 (0x290) bit 8: tsu There is now PTP hardware support without that bit. > .dma_burst_length = 16, > .clk_init = macb_clk_init, > .init = macb_init, > @@ -3049,14 +3206,15 @@ static const struct macb_config sama5d2_config = { > > static const struct macb_config sama5d3_config = { > .caps = MACB_CAPS_SG_DISABLED | MACB_CAPS_GIGABIT_MODE_AVAILABLE > - | MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII, > + | MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII > + | MACB_CAPS_GEM_HAS_PTP, > .dma_burst_length = 16, > .clk_init = macb_clk_init, > .init = macb_init, > }; > > static const struct macb_config sama5d4_config = { > - .caps = MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII, > + .caps = MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII | MACB_CAPS_GEM_HAS_PTP, > .dma_burst_length = 4, > .clk_init = macb_clk_init, > .init = macb_init, > -- > 2.7.4 In macb_start_xmit() there is also invoked skb_tx_timestamp() for software timestamping. I think, it should be disabled if you do hardware timestamping. Best regards, Rafal Ozieblo | Firmware System Engineer, www.cadence.com

RE: [RFC PATCH net-next v4 2/2] macb: Enable 1588 support in SAMA5Dx platforms.

if (gem_has_ptp(bp)) > + bp->ptp_info = _ptp_info; > +#endif > } > > dev_dbg(>pdev->dev, "Cadence caps 0x%08x\n", bp->caps); @@ -3041,7 > +3198,7 @@ static const struct macb_config pc302gem_config = { }; > > static const struct macb_config sama5d2_config = { > - .caps = MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII, > + .caps = MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII | MACB_CAPS_GEM_HAS_PTP, There are many IP cores with many configuration. If it is possible, capabilities should be read from IP directly. And it is possible in that case: Design Configuration Register 5 (0x290) bit 8: tsu There is now PTP hardware support without that bit. > .dma_burst_length = 16, > .clk_init = macb_clk_init, > .init = macb_init, > @@ -3049,14 +3206,15 @@ static const struct macb_config sama5d2_config = { > > static const struct macb_config sama5d3_config = { > .caps = MACB_CAPS_SG_DISABLED | MACB_CAPS_GIGABIT_MODE_AVAILABLE > - | MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII, > + | MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII > + | MACB_CAPS_GEM_HAS_PTP, > .dma_burst_length = 16, > .clk_init = macb_clk_init, > .init = macb_init, > }; > > static const struct macb_config sama5d4_config = { > - .caps = MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII, > + .caps = MACB_CAPS_USRIO_DEFAULT_IS_MII_GMII | MACB_CAPS_GEM_HAS_PTP, > .dma_burst_length = 4, > .clk_init = macb_clk_init, > .init = macb_init, > -- > 2.7.4 In macb_start_xmit() there is also invoked skb_tx_timestamp() for software timestamping. I think, it should be disabled if you do hardware timestamping. Best regards, Rafal Ozieblo | Firmware System Engineer, www.cadence.com

RE: [RFC PATCH net-next v3 1/2] macb: Add 1588 support in Cadence GEM.

.@davemloft.net; > nicolas.fe...@atmel.com; harinikatakamli...@gmail.com; > harini.kata...@xilinx.com; punn...@xilinx.com; mich...@xilinx.com; > anir...@xilinx.com; boris.brezil...@free-electrons.com; > alexandre.bell...@free-electrons.com; tbul...@pixelsurmer.com; Rafal Ozieblo > Subject:

RE: [RFC PATCH net-next v3 1/2] macb: Add 1588 support in Cadence GEM.

.@davemloft.net; > nicolas.fe...@atmel.com; harinikatakamli...@gmail.com; > harini.kata...@xilinx.com; punn...@xilinx.com; mich...@xilinx.com; > anir...@xilinx.com; boris.brezil...@free-electrons.com; > alexandre.bell...@free-electrons.com; tbul...@pixelsurmer.com; Rafal Ozieblo > Subject:

Re: [RFC PATCH 2/3] net: macb: Add support for 1588 for Zynq Ultrascale+ MPSoC

d_lock_bh() // second lock is taken I know that those are different locks and different types. But this could lead to deadlocks. This is the reason of warning I could see. And this is the reason why I get timestamp in interrupt routine but pass it to skb outside interrupt (using circular buffer). Best regards, Rafal Ozieblo   |   Firmware System Engineer, phone nbr.: +48 32 5085469 www.cadence.com

Re: [RFC PATCH 2/3] net: macb: Add support for 1588 for Zynq Ultrascale+ MPSoC

d_lock_bh() // second lock is taken I know that those are different locks and different types. But this could lead to deadlocks. This is the reason of warning I could see. And this is the reason why I get timestamp in interrupt routine but pass it to skb outside interrupt (using circular buffer). Best regards, Rafal Ozieblo   |   Firmware System Engineer, phone nbr.: +48 32 5085469 www.cadence.com

[RFC PATCH 1/2] macb: Add 1588 support in Cadence GEM.

le, >+}; I'm wondering, how did you count max_adj ? Best regards, Rafal Ozieblo   |   Firmware System Engineer, phone nbr.: +48 32 5085469 www.cadence.com  

[RFC PATCH 1/2] macb: Add 1588 support in Cadence GEM.

le, >+}; I'm wondering, how did you count max_adj ? Best regards, Rafal Ozieblo   |   Firmware System Engineer, phone nbr.: +48 32 5085469 www.cadence.com  

RE: [PATCH net-next] cadence: Add hardware PTP support.

>> MACB_BIT(PTP_PDELAY_REQ_FRAME_TRANSMITTED)); >> + if (macb_ptp_time_peer_frame_tx_get(bp, ) != 0) { >> + ts.tv_sec = 0; >> + ts.tv_nsec = 0; >> + } >> + macb_ptp_event(bp, ); >> + } >> + >> + if (status & MACB_BIT(PTP_PDELAY_RESP_FRAME_TRANSMITTED)) { >> + if (bp->caps & MACB_CAPS_ISR_CLEAR_ON_WRITE) >> + queue_writel(queue, ISR, >> MACB_BIT(PTP_PDELAY_RESP_FRAME_TRANSMITTED)); >> + if (macb_ptp_time_peer_frame_tx_get(bp, ) != 0) { >> + ts.tv_sec = 0; >> + ts.tv_nsec = 0; >> + } >> + macb_ptp_event(bp, ); >> + } >> +#endif > >I'm not sure of your application and why this is necessary. >Can you please check Andrei's patches and mine and Richard Cochran's comments? >I use linuxptp to test. > This could be an overhead. I use linuxptp as well and it works. >Regards, >Harini >  Best regards, Rafal Ozieblo   |   Firmware System Engineer, phone nbr.: +48 32 5085469 www.cadence.com

RE: [PATCH net-next] cadence: Add hardware PTP support.

>> MACB_BIT(PTP_PDELAY_REQ_FRAME_TRANSMITTED)); >> + if (macb_ptp_time_peer_frame_tx_get(bp, ) != 0) { >> + ts.tv_sec = 0; >> + ts.tv_nsec = 0; >> + } >> + macb_ptp_event(bp, ); >> + } >> + >> + if (status & MACB_BIT(PTP_PDELAY_RESP_FRAME_TRANSMITTED)) { >> + if (bp->caps & MACB_CAPS_ISR_CLEAR_ON_WRITE) >> + queue_writel(queue, ISR, >> MACB_BIT(PTP_PDELAY_RESP_FRAME_TRANSMITTED)); >> + if (macb_ptp_time_peer_frame_tx_get(bp, ) != 0) { >> + ts.tv_sec = 0; >> + ts.tv_nsec = 0; >> + } >> + macb_ptp_event(bp, ); >> + } >> +#endif > >I'm not sure of your application and why this is necessary. >Can you please check Andrei's patches and mine and Richard Cochran's comments? >I use linuxptp to test. > This could be an overhead. I use linuxptp as well and it works. >Regards, >Harini >  Best regards, Rafal Ozieblo   |   Firmware System Engineer, phone nbr.: +48 32 5085469 www.cadence.com

RE: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM

>Hi Rafal, > >On Fri, Nov 18, 2016 at 2:29 PM, Rafal Ozieblo <raf...@cadence.com>

RE: [RFC PATCH 2/2] net: macb: Add 64 bit addressing support for GEM

>Hi Rafal, > >On Fri, Nov 18, 2016 at 2:29 PM, Rafal Ozieblo wrote:

  1   2   >