Re: [RFC 1/3] power_supply: Define Binding for supplied-nodes

2013-02-17 Thread Rajanikanth HV
On Sunday 17 February 2013 04:08 AM, Anton Vorontsov wrote: [...] > > "supplied nodes" sounds confusing (doesn't reflect direction), IMO. I'd > rather call it power-supply,supplied-to = <_battery>; > > But... I'm recalling there was a similar discussion not that long ago, and > Arnd came up

Re: [RFC 1/3] power_supply: Define Binding for supplied-nodes

2013-02-17 Thread Rajanikanth HV
On Sunday 17 February 2013 04:08 AM, Anton Vorontsov wrote: [...] supplied nodes sounds confusing (doesn't reflect direction), IMO. I'd rather call it power-supply,supplied-to = some_battery; But... I'm recalling there was a similar discussion not that long ago, and Arnd came up with the

Re: [PATCH Resend V2] dt: add helper function to read u8 & u16 variables & arrays

2012-11-18 Thread Rajanikanth HV
On 19 November 2012 12:00, Viresh Kumar wrote: > Firstly you tried square braces [ ], I am not sure if that is allowed. > Can you point me to the specification? http://www.devicetree.org/Device_Tree_Usage " a-byte-data-property = [0x01 0x23 0x34 0x56]; " > > And simply passing 0x50, 0x60 etc..

Re: [PATCH Resend V2] dt: add helper function to read u8 & u16 variables & arrays

2012-11-18 Thread Rajanikanth HV
On 19 November 2012 09:24, Viresh Kumar wrote: > On 12 November 2012 09:03, Viresh Kumar wrote: >> On 12 November 2012 01:12, Rob Herring wrote: >>> I don't think the size is stored in the dtb. It is only in the dts. You >>> need to define the size in the binding definitions and use '/bits/'

Re: [PATCH 0/4] Implement device tree support for ab8500 BM Devices

2012-11-18 Thread Rajanikanth HV
> On 19 November 2012 09:16, Anton Vorontsov wrote: > (But I'm bouncing the patches to Samuel and Mark anyway, jfyi.) > > p.s. > > FWIW, I fixed these warnings. > > CHECK drivers/power/ab8500_bmdata.c > drivers/power/ab8500_bmdata.c:146:23: warning: symbol > 'temp_to_batres_tbl_thermistor'

Re: [PATCH 0/4] Implement device tree support for ab8500 BM Devices

2012-11-18 Thread Rajanikanth HV
On 19 November 2012 09:16, Anton Vorontsov anton.voront...@linaro.org wrote: (But I'm bouncing the patches to Samuel and Mark anyway, jfyi.) p.s. FWIW, I fixed these warnings. CHECK drivers/power/ab8500_bmdata.c drivers/power/ab8500_bmdata.c:146:23: warning: symbol

Re: [PATCH Resend V2] dt: add helper function to read u8 u16 variables arrays

2012-11-18 Thread Rajanikanth HV
On 19 November 2012 09:24, Viresh Kumar viresh.ku...@linaro.org wrote: On 12 November 2012 09:03, Viresh Kumar viresh.ku...@linaro.org wrote: On 12 November 2012 01:12, Rob Herring robherri...@gmail.com wrote: I don't think the size is stored in the dtb. It is only in the dts. You need to

Re: [PATCH Resend V2] dt: add helper function to read u8 u16 variables arrays

2012-11-18 Thread Rajanikanth HV
On 19 November 2012 12:00, Viresh Kumar viresh.ku...@linaro.org wrote: Firstly you tried square braces [ ], I am not sure if that is allowed. Can you point me to the specification? http://www.devicetree.org/Device_Tree_Usage a-byte-data-property = [0x01 0x23 0x34 0x56]; And simply passing

Re: [PATCH 1/4] mfd: ab8500: add devicetree support for fuelgauge

2012-11-15 Thread Rajanikanth HV
On Saturday 10 November 2012 10:23 PM, Francesco Lavra wrote: >>> I don't get the point of declaring the char array and copying the string >>> in it, when you could simply use just the pointer returned by >>> of_get_property(). >> >> I am considering a corner case where in 'battery-type'

Re: [PATCH 1/4] mfd: ab8500: add devicetree support for fuelgauge

2012-11-15 Thread Rajanikanth HV
On Saturday 10 November 2012 10:23 PM, Francesco Lavra wrote: I don't get the point of declaring the char array and copying the string in it, when you could simply use just the pointer returned by of_get_property(). I am considering a corner case where in 'battery-type' property is not

Re: [PATCH 1/4] mfd: ab8500: add devicetree support for fuelgauge

2012-10-27 Thread Rajanikanth HV
On 27 October 2012 20:37, Francesco Lavra wrote: > On 10/25/2012 08:30 AM, Rajanikanth H.V wrote: >> From: "Rajanikanth H.V" >> + bat_tech = of_get_property(np_bat_supply, >> + "stericsson,battery-type", NULL); >> + if (!bat_tech) >> + dev_warn(dev,

Re: [PATCH 1/4] mfd: ab8500: add devicetree support for fuelgauge

2012-10-27 Thread Rajanikanth HV
On 27 October 2012 20:37, Francesco Lavra francescolavra...@gmail.com wrote: On 10/25/2012 08:30 AM, Rajanikanth H.V wrote: From: Rajanikanth H.V rajanikanth...@stericsson.com + bat_tech = of_get_property(np_bat_supply, + stericsson,battery-type, NULL); + if

Re: [PATCH 1/4] mfd: ab8500: add devicetree support for fuelgauge

2012-10-01 Thread Rajanikanth HV
did you have a look at arnd and anton comments regarding 'supplied-to' and boolean property On Monday 01 October 2012 03:19 PM, Lee Jones wrote: > On Mon, 01 Oct 2012, Rajanikanth H.V wrote: > >> From: "Rajanikanth H.V" >> >> - This patch adds device tree support for fuelguage driver >> -

Re: [PATCH 1/4] mfd: ab8500: add devicetree support for fuelgauge

2012-10-01 Thread Rajanikanth HV
did you have a look at arnd and anton comments regarding 'supplied-to' and boolean property On Monday 01 October 2012 03:19 PM, Lee Jones wrote: On Mon, 01 Oct 2012, Rajanikanth H.V wrote: From: Rajanikanth H.V rajanikanth...@stericsson.com - This patch adds device tree support for

Re: Implement devicetree support for AB8500 Btemp

2012-09-14 Thread Rajanikanth HV
On Thursday 13 September 2012 08:07 PM, Arnd Bergmann wrote: > On Thursday 13 September 2012, Rajanikanth HV wrote: >> On Wednesday 12 September 2012 09:06 PM, Arnd Bergmann wrote:> > >>> If this is true, I don't understand what makes the 'supplied-to' >>> prope

Re: Implement devicetree support for AB8500 Btemp

2012-09-14 Thread Rajanikanth HV
On Friday 14 September 2012 01:39 PM, Arnd Bergmann wrote: > On Friday 14 September 2012, Anton Vorontsov wrote: >> Power supply subsystem's supplied_to describes not just how driver >> should notify other devices, supplied_to is more generic stuff, in terms >> that it describes power supply

Re: Implement devicetree support for AB8500 Btemp

2012-09-14 Thread Rajanikanth HV
On Friday 14 September 2012 01:39 PM, Arnd Bergmann wrote: On Friday 14 September 2012, Anton Vorontsov wrote: Power supply subsystem's supplied_to describes not just how driver should notify other devices, supplied_to is more generic stuff, in terms that it describes power supply hierarchy.

Re: Implement devicetree support for AB8500 Btemp

2012-09-14 Thread Rajanikanth HV
On Thursday 13 September 2012 08:07 PM, Arnd Bergmann wrote: On Thursday 13 September 2012, Rajanikanth HV wrote: On Wednesday 12 September 2012 09:06 PM, Arnd Bergmann wrote: If this is true, I don't understand what makes the 'supplied-to' properties you list in the device tree binding

Re: Implement devicetree support for AB8500 Btemp

2012-09-13 Thread Rajanikanth HV
On Wednesday 12 September 2012 09:06 PM, Arnd Bergmann wrote: > On Wednesday 12 September 2012, Rajanikanth HV wrote: >> On Tuesday 11 September 2012 04:52 PM, Arnd Bergmann wrote: >>> On Tuesday 11 September 2012, Rajanikanth HV wrote: > >

Re: Implement devicetree support for AB8500 Btemp

2012-09-13 Thread Rajanikanth HV
On Wednesday 12 September 2012 09:06 PM, Arnd Bergmann wrote: On Wednesday 12 September 2012, Rajanikanth HV wrote: On Tuesday 11 September 2012 04:52 PM, Arnd Bergmann wrote: On Tuesday 11 September 2012, Rajanikanth HV wrote: Consider: USB charging

Re: Implement devicetree support for AB8500 Btemp

2012-09-12 Thread Rajanikanth HV
On Tuesday 11 September 2012 04:52 PM, Arnd Bergmann wrote: > On Tuesday 11 September 2012, Rajanikanth HV wrote: >>>> +Supplied-to: >>>> + This shall be power supply class dependency where in the >> runtime battery >>>> + properties

Re: Implement devicetree support for AB8500 Btemp

2012-09-12 Thread Rajanikanth HV
On Tuesday 11 September 2012 04:52 PM, Arnd Bergmann wrote: On Tuesday 11 September 2012, Rajanikanth HV wrote: +Supplied-to: + This shall be power supply class dependency where in the runtime battery + properties will be shared across fuel guage and charging algorithm driver. I

mfd: Implement devicetree support for AB8500 Btemp

2012-09-10 Thread Rajanikanth HV
This patch adds device tree support for battery temperature monitor driver Signed-off-by: Rajanikanth H.V --- .../bindings/power_supply/ab8500/btemp.txt | 52 ++ arch/arm/boot/dts/dbx5x0.dtsi |8 + drivers/mfd/ab8500-core.c |1

[PATCH] mfd: Implement devicetree support for AB8500 fg

2012-09-10 Thread Rajanikanth HV
This patch adds device tree support for fuel guage driver Signed-off-by: Rajanikanth H.V --- Documentation/devicetree/bindings/mfd/ab8500.txt |8 +- .../devicetree/bindings/power_supply/ab8500/fg.txt | 61 +++ arch/arm/boot/dts/dbx5x0.dtsi |8 +

[PATCH] mfd: Implement devicetree support for AB8500 fg

2012-09-10 Thread Rajanikanth HV
This patch adds device tree support for fuel guage driver Signed-off-by: Rajanikanth H.V rajanikanth...@stericsson.com --- Documentation/devicetree/bindings/mfd/ab8500.txt |8 +- .../devicetree/bindings/power_supply/ab8500/fg.txt | 61 +++ arch/arm/boot/dts/dbx5x0.dtsi

mfd: Implement devicetree support for AB8500 Btemp

2012-09-10 Thread Rajanikanth HV
This patch adds device tree support for battery temperature monitor driver Signed-off-by: Rajanikanth H.V rajanikanth...@stericsson.com --- .../bindings/power_supply/ab8500/btemp.txt | 52 ++ arch/arm/boot/dts/dbx5x0.dtsi |8 + drivers/mfd/ab8500-core.c

Re: [PATCH] mfd: Implement devicetree support for AB8500 Btemp

2012-07-13 Thread Rajanikanth HV
> Date: Tue, 10 Jul 2012 14:12:01 + > From: Arnd Bergmann > To: linux-arm-ker...@lists.infradead.org > Cc: linaro-...@lists.linaro.org, linux-kernel@vger.kernel.org, > "Rajanikanth H.V" , patc...@linaro.org > Subject: Re: [PATCH] mfd: Implement devicetree support for AB8500 >

Re: [PATCH] mfd: Implement devicetree support for AB8500 Btemp

2012-07-13 Thread Rajanikanth HV
> Date: Tue, 10 Jul 2012 18:20:13 +0200 > From: Lee Jones > To: "Rajanikanth H.V" > Cc: STEricsson_nomadik_linux , > linaro-...@lists.linaro.org, linux-kernel@vger.kernel.org, > linux-arm-ker...@lists.infradead.org, patc...@linaro.org > Subject: Re: [PATCH] mfd: Implement

Re: [PATCH] mfd: Implement devicetree support for AB8500 Btemp

2012-07-13 Thread Rajanikanth HV
Date: Tue, 10 Jul 2012 18:20:13 +0200 From: Lee Jones lee.jo...@linaro.org To: Rajanikanth H.V rajanikanth...@stericsson.com Cc: STEricsson_nomadik_linux stericsson_nomadik_li...@list.st.com, linaro-...@lists.linaro.org, linux-kernel@vger.kernel.org,

Re: [PATCH] mfd: Implement devicetree support for AB8500 Btemp

2012-07-13 Thread Rajanikanth HV
Date: Tue, 10 Jul 2012 14:12:01 + From: Arnd Bergmann a...@arndb.de To: linux-arm-ker...@lists.infradead.org Cc: linaro-...@lists.linaro.org, linux-kernel@vger.kernel.org, Rajanikanth H.V rajanikanth...@stericsson.com, patc...@linaro.org Subject: Re: [PATCH] mfd: Implement